{"action":"created","comment":{"url":"https://api.github.com/repos/scala/scala/pulls/comments/32575000","id":32575000,"diff_hunk":"@@ -134,7 +134,7 @@ object Numeric {\n     def div(x: Float, y: Float): Float = x / y\n   }\n   trait FloatAsIfIntegral extends FloatIsConflicted with Integral[Float] {\n-    def quot(x: Float, y: Float): Float = (BigDecimal(x) / BigDecimal(y)).floatValue","path":"src/library/scala/math/Numeric.scala","position":4,"original_position":4,"commit_id":"4df1a0c6e315da8447325a6ee036dc82fcb1c564","original_commit_id":"4df1a0c6e315da8447325a6ee036dc82fcb1c564","user":{"login":"axel22","id":151774,"avatar_url":"https://avatars.githubusercontent.com/u/151774?v=3","gravatar_id":"","url":"https://api.github.com/users/axel22","html_url":"https://github.com/axel22","followers_url":"https://api.github.com/users/axel22/followers","following_url":"https://api.github.com/users/axel22/following{/other_user}","gists_url":"https://api.github.com/users/axel22/gists{/gist_id}","starred_url":"https://api.github.com/users/axel22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axel22/subscriptions","organizations_url":"https://api.github.com/users/axel22/orgs","repos_url":"https://api.github.com/users/axel22/repos","events_url":"https://api.github.com/users/axel22/events{/privacy}","received_events_url":"https://api.github.com/users/axel22/received_events","type":"User","site_admin":false},"body":"Since we're changing the current behavior of `FloatAsIfIntegral`, this needs its own unit test. I suggest that you use `bigDecimalTest.scala` to add the tests for `quot`.","created_at":"2015-06-16T21:47:15Z","updated_at":"2015-06-16T21:47:15Z","html_url":"https://github.com/scala/scala/pull/4541#discussion_r32575000","pull_request_url":"https://api.github.com/repos/scala/scala/pulls/4541","_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/comments/32575000"},"html":{"href":"https://github.com/scala/scala/pull/4541#discussion_r32575000"},"pull_request":{"href":"https://api.github.com/repos/scala/scala/pulls/4541"}}},"pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/4541","id":37078270,"html_url":"https://github.com/scala/scala/pull/4541","diff_url":"https://github.com/scala/scala/pull/4541.diff","patch_url":"https://github.com/scala/scala/pull/4541.patch","issue_url":"https://api.github.com/repos/scala/scala/issues/4541","number":4541,"state":"open","locked":false,"title":"SI-9348 Fix missing last element in exclusive floating point ranges","user":{"login":"vuakko","id":1800423,"avatar_url":"https://avatars.githubusercontent.com/u/1800423?v=3","gravatar_id":"","url":"https://api.github.com/users/vuakko","html_url":"https://github.com/vuakko","followers_url":"https://api.github.com/users/vuakko/followers","following_url":"https://api.github.com/users/vuakko/following{/other_user}","gists_url":"https://api.github.com/users/vuakko/gists{/gist_id}","starred_url":"https://api.github.com/users/vuakko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuakko/subscriptions","organizations_url":"https://api.github.com/users/vuakko/orgs","repos_url":"https://api.github.com/users/vuakko/repos","events_url":"https://api.github.com/users/vuakko/events{/privacy}","received_events_url":"https://api.github.com/users/vuakko/received_events","type":"User","site_admin":false},"body":"Fix exclusive floating point ranges to contain also the last element\r\nwhen the end-start difference is not an integer multiple of step.\r\n\r\nReview by @axel22 ","created_at":"2015-06-05T23:17:48Z","updated_at":"2015-06-16T21:47:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7708c027b60dc8f65837504e91c8ce53e479176c","assignee":null,"milestone":{"url":"https://api.github.com/repos/scala/scala/milestones/48","html_url":"https://github.com/scala/scala/milestones/2.11.7","labels_url":"https://api.github.com/repos/scala/scala/milestones/48/labels","id":985497,"number":48,"title":"2.11.7","description":"  - [ ] unfork repl for spark\r\n\r\nMerge to 2.11.x.\r\n","creator":{"login":"adriaanm","id":91083,"avatar_url":"https://avatars.githubusercontent.com/u/91083?v=3","gravatar_id":"","url":"https://api.github.com/users/adriaanm","html_url":"https://github.com/adriaanm","followers_url":"https://api.github.com/users/adriaanm/followers","following_url":"https://api.github.com/users/adriaanm/following{/other_user}","gists_url":"https://api.github.com/users/adriaanm/gists{/gist_id}","starred_url":"https://api.github.com/users/adriaanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriaanm/subscriptions","organizations_url":"https://api.github.com/users/adriaanm/orgs","repos_url":"https://api.github.com/users/adriaanm/repos","events_url":"https://api.github.com/users/adriaanm/events{/privacy}","received_events_url":"https://api.github.com/users/adriaanm/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":133,"state":"open","created_at":"2015-02-19T00:12:20Z","updated_at":"2015-06-16T21:06:00Z","due_on":"2015-06-21T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scala/scala/pulls/4541/commits","review_comments_url":"https://api.github.com/repos/scala/scala/pulls/4541/comments","review_comment_url":"https://api.github.com/repos/scala/scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala/scala/issues/4541/comments","statuses_url":"https://api.github.com/repos/scala/scala/statuses/4df1a0c6e315da8447325a6ee036dc82fcb1c564","head":{"label":"vuakko:SI-9348_2.11.x","ref":"SI-9348_2.11.x","sha":"4df1a0c6e315da8447325a6ee036dc82fcb1c564","user":{"login":"vuakko","id":1800423,"avatar_url":"https://avatars.githubusercontent.com/u/1800423?v=3","gravatar_id":"","url":"https://api.github.com/users/vuakko","html_url":"https://github.com/vuakko","followers_url":"https://api.github.com/users/vuakko/followers","following_url":"https://api.github.com/users/vuakko/following{/other_user}","gists_url":"https://api.github.com/users/vuakko/gists{/gist_id}","starred_url":"https://api.github.com/users/vuakko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuakko/subscriptions","organizations_url":"https://api.github.com/users/vuakko/orgs","repos_url":"https://api.github.com/users/vuakko/repos","events_url":"https://api.github.com/users/vuakko/events{/privacy}","received_events_url":"https://api.github.com/users/vuakko/received_events","type":"User","site_admin":false},"repo":{"id":36950672,"name":"scala","full_name":"vuakko/scala","owner":{"login":"vuakko","id":1800423,"avatar_url":"https://avatars.githubusercontent.com/u/1800423?v=3","gravatar_id":"","url":"https://api.github.com/users/vuakko","html_url":"https://github.com/vuakko","followers_url":"https://api.github.com/users/vuakko/followers","following_url":"https://api.github.com/users/vuakko/following{/other_user}","gists_url":"https://api.github.com/users/vuakko/gists{/gist_id}","starred_url":"https://api.github.com/users/vuakko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuakko/subscriptions","organizations_url":"https://api.github.com/users/vuakko/orgs","repos_url":"https://api.github.com/users/vuakko/repos","events_url":"https://api.github.com/users/vuakko/events{/privacy}","received_events_url":"https://api.github.com/users/vuakko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vuakko/scala","description":"The Scala programming language","fork":true,"url":"https://api.github.com/repos/vuakko/scala","forks_url":"https://api.github.com/repos/vuakko/scala/forks","keys_url":"https://api.github.com/repos/vuakko/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuakko/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuakko/scala/teams","hooks_url":"https://api.github.com/repos/vuakko/scala/hooks","issue_events_url":"https://api.github.com/repos/vuakko/scala/issues/events{/number}","events_url":"https://api.github.com/repos/vuakko/scala/events","assignees_url":"https://api.github.com/repos/vuakko/scala/assignees{/user}","branches_url":"https://api.github.com/repos/vuakko/scala/branches{/branch}","tags_url":"https://api.github.com/repos/vuakko/scala/tags","blobs_url":"https://api.github.com/repos/vuakko/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuakko/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuakko/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuakko/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuakko/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/vuakko/scala/languages","stargazers_url":"https://api.github.com/repos/vuakko/scala/stargazers","contributors_url":"https://api.github.com/repos/vuakko/scala/contributors","subscribers_url":"https://api.github.com/repos/vuakko/scala/subscribers","subscription_url":"https://api.github.com/repos/vuakko/scala/subscription","commits_url":"https://api.github.com/repos/vuakko/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuakko/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuakko/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuakko/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuakko/scala/contents/{+path}","compare_url":"https://api.github.com/repos/vuakko/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuakko/scala/merges","archive_url":"https://api.github.com/repos/vuakko/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuakko/scala/downloads","issues_url":"https://api.github.com/repos/vuakko/scala/issues{/number}","pulls_url":"https://api.github.com/repos/vuakko/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/vuakko/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/vuakko/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuakko/scala/labels{/name}","releases_url":"https://api.github.com/repos/vuakko/scala/releases{/id}","created_at":"2015-06-05T19:12:01Z","updated_at":"2015-06-05T19:12:19Z","pushed_at":"2015-06-05T23:13:33Z","git_url":"git://github.com/vuakko/scala.git","ssh_url":"git@github.com:vuakko/scala.git","clone_url":"https://github.com/vuakko/scala.git","svn_url":"https://github.com/vuakko/scala","homepage":"http://www.scala-lang.org/","size":194211,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.11.x"}},"base":{"label":"scala:2.11.x","ref":"2.11.x","sha":"0bc7fa67d130f75079df79814b33ef073254e27a","user":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":2888818,"name":"scala","full_name":"scala/scala","owner":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/scala","description":"The Scala programming language","fork":false,"url":"https://api.github.com/repos/scala/scala","forks_url":"https://api.github.com/repos/scala/scala/forks","keys_url":"https://api.github.com/repos/scala/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/scala/teams","hooks_url":"https://api.github.com/repos/scala/scala/hooks","issue_events_url":"https://api.github.com/repos/scala/scala/issues/events{/number}","events_url":"https://api.github.com/repos/scala/scala/events","assignees_url":"https://api.github.com/repos/scala/scala/assignees{/user}","branches_url":"https://api.github.com/repos/scala/scala/branches{/branch}","tags_url":"https://api.github.com/repos/scala/scala/tags","blobs_url":"https://api.github.com/repos/scala/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/scala/languages","stargazers_url":"https://api.github.com/repos/scala/scala/stargazers","contributors_url":"https://api.github.com/repos/scala/scala/contributors","subscribers_url":"https://api.github.com/repos/scala/scala/subscribers","subscription_url":"https://api.github.com/repos/scala/scala/subscription","commits_url":"https://api.github.com/repos/scala/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala/scala/contents/{+path}","compare_url":"https://api.github.com/repos/scala/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/scala/merges","archive_url":"https://api.github.com/repos/scala/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/scala/downloads","issues_url":"https://api.github.com/repos/scala/scala/issues{/number}","pulls_url":"https://api.github.com/repos/scala/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/scala/labels{/name}","releases_url":"https://api.github.com/repos/scala/scala/releases{/id}","created_at":"2011-12-01T05:02:34Z","updated_at":"2015-06-16T19:02:11Z","pushed_at":"2015-06-16T21:05:59Z","git_url":"git://github.com/scala/scala.git","ssh_url":"git@github.com:scala/scala.git","clone_url":"https://github.com/scala/scala.git","svn_url":"https://github.com/scala/scala","homepage":"http://www.scala-lang.org/","size":194211,"stargazers_count":4363,"watchers_count":4363,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1116,"mirror_url":null,"open_issues_count":33,"forks":1116,"open_issues":33,"watchers":4363,"default_branch":"2.11.x"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/4541"},"html":{"href":"https://github.com/scala/scala/pull/4541"},"issue":{"href":"https://api.github.com/repos/scala/scala/issues/4541"},"comments":{"href":"https://api.github.com/repos/scala/scala/issues/4541/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/scala/pulls/4541/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala/scala/pulls/4541/commits"},"statuses":{"href":"https://api.github.com/repos/scala/scala/statuses/4df1a0c6e315da8447325a6ee036dc82fcb1c564"}}}}