{"action":"created","issue":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1477","labels_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1477/labels{/name}","comments_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1477/comments","events_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1477/events","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/1477","id":91615439,"number":1477,"title":"dynamic_compiler_plug.c cannot be a plugin (needs to be renamed)","user":{"login":"frank-dittrich","id":2026819,"avatar_url":"https://avatars.githubusercontent.com/u/2026819?v=3","gravatar_id":"","url":"https://api.github.com/users/frank-dittrich","html_url":"https://github.com/frank-dittrich","followers_url":"https://api.github.com/users/frank-dittrich/followers","following_url":"https://api.github.com/users/frank-dittrich/following{/other_user}","gists_url":"https://api.github.com/users/frank-dittrich/gists{/gist_id}","starred_url":"https://api.github.com/users/frank-dittrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frank-dittrich/subscriptions","organizations_url":"https://api.github.com/users/frank-dittrich/orgs","repos_url":"https://api.github.com/users/frank-dittrich/repos","events_url":"https://api.github.com/users/frank-dittrich/events{/privacy}","received_events_url":"https://api.github.com/users/frank-dittrich/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-28T16:50:33Z","updated_at":"2015-06-28T22:07:53Z","closed_at":null,"body":"Otherwise, build fails when I try to create a minimal john binary by moving all plugins somewhere else:\r\n```\r\njohn.o: In function `john_register_one':\r\n/home/fd/git/JtR/src/john.c:279: undefined reference to `dynamic_compile'\r\n/home/fd/git/JtR/src/john.c:280: undefined reference to `dynamic_assign_script_to_format'\r\n/home/fd/git/JtR/src/john.c:279: undefined reference to `dynamic_compile'\r\n/home/fd/git/JtR/src/john.c:280: undefined reference to `dynamic_assign_script_to_format'\r\n```\r\n\r\nAnd I guess come more functions need to be moved from dynamic_compiler_fmt_plug.c to the (renamed) dynamic_compiler_plug.c, because when I move dynamic_compiler_plug.c back in place, the build still fails:\r\n\r\n```\r\njohn.o: In function `john_register_one':\r\n/home/fd/git/JtR/src/john.c:280: undefined reference to `dynamic_assign_script_to_format'\r\n/home/fd/git/JtR/src/john.c:280: undefined reference to `dynamic_assign_script_to_format'\r\n```\r\n\r\nIdeally, a first commit would just rename dynamic_compiler_plug.c (and add the new object file to Makefile.in (and if you care, also to Makefile.legacy), the second would just move all the functions required for a non-plugin build.\r\nI don't want to interfere with @jfoug here, that's why I'll not touch these files now, and wait whether or not I'll have to adjust Makefile.legacy..."},"comment":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/comments/116354502","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/1477#issuecomment-116354502","issue_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/1477","id":116354502,"user":{"login":"jfoug","id":1270024,"avatar_url":"https://avatars.githubusercontent.com/u/1270024?v=3","gravatar_id":"","url":"https://api.github.com/users/jfoug","html_url":"https://github.com/jfoug","followers_url":"https://api.github.com/users/jfoug/followers","following_url":"https://api.github.com/users/jfoug/following{/other_user}","gists_url":"https://api.github.com/users/jfoug/gists{/gist_id}","starred_url":"https://api.github.com/users/jfoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfoug/subscriptions","organizations_url":"https://api.github.com/users/jfoug/orgs","repos_url":"https://api.github.com/users/jfoug/repos","events_url":"https://api.github.com/users/jfoug/events{/privacy}","received_events_url":"https://api.github.com/users/jfoug/received_events","type":"User","site_admin":false},"created_at":"2015-06-28T22:07:53Z","updated_at":"2015-06-28T22:07:53Z","body":"I will get this fully working, including the Makefile.legacy.  Pretty simple stuff.  There will still be some dynamic compiler 'looking' stuff in john.c, BUT if the format (which is a _plug.c) is removed, then there will never be a format that satisfies the valid() for a dynamic=expression format.\r\n\r\nBut you are right, the compiler can not be a _plug.c, or there will be no way to hook it properly into john.c"}}