{"action":"opened","issue":{"url":"https://api.github.com/repos/Beckhoff/ADS/issues/12","labels_url":"https://api.github.com/repos/Beckhoff/ADS/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/Beckhoff/ADS/issues/12/comments","events_url":"https://api.github.com/repos/Beckhoff/ADS/issues/12/events","html_url":"https://github.com/Beckhoff/ADS/issues/12","id":111283532,"number":12,"title":"AdsNotificationHeader has nTimeStamp & nNotification backwards","user":{"login":"tdjordan","id":8079,"avatar_url":"https://avatars.githubusercontent.com/u/8079?v=3","gravatar_id":"","url":"https://api.github.com/users/tdjordan","html_url":"https://github.com/tdjordan","followers_url":"https://api.github.com/users/tdjordan/followers","following_url":"https://api.github.com/users/tdjordan/following{/other_user}","gists_url":"https://api.github.com/users/tdjordan/gists{/gist_id}","starred_url":"https://api.github.com/users/tdjordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdjordan/subscriptions","organizations_url":"https://api.github.com/users/tdjordan/orgs","repos_url":"https://api.github.com/users/tdjordan/repos","events_url":"https://api.github.com/users/tdjordan/events{/privacy}","received_events_url":"https://api.github.com/users/tdjordan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-10-13T22:19:32Z","updated_at":"2015-10-13T22:19:32Z","closed_at":null,"body":"In AdsDef.h at line [287](https://github.com/Beckhoff/ADS/blob/master/AdsLib/AdsDef.h#L287),\r\nnTimeStamp and hNotification are in the wrong order.\r\n\r\n```cpp\r\ntypedef struct {\r\n    uint64_t nTimeStamp;\r\n    uint32_t hNotification;\r\n    uint32_t cbSampleSize;\r\n#ifndef __cplusplus\r\n    uint8_t data[];\r\n#endif\r\n} AdsNotificationHeader, * PAdsNotificationHeader;\r\n```\r\n\r\nMy reference for this is from these two places.\r\n\r\n> [TwinCat2 docs](http://infosys.beckhoff.de/english.php?content=../content/1033/tcadsdll2/html/tcadsdll_strucadsnotificationheader.htm&id=21585)\r\n\r\n```cpp\r\ntypedef struct {\r\n  ULONG           hNotification;\r\n  __int64         nTimeStamp;\r\n  ULONG           cbSampleSize;\r\n  UCHAR           data[ANYSIZE_ARRAY];\r\n} AdsNotificationHeader, *PAdsNotificationHeader;\r\n```\r\n\r\n> [TwinCat3 docs](http://infosys.beckhoff.de/english.php?content=../content/1033/tcinfosys3/html/startpage.htm&id=14786)\r\n\r\n```cpp\r\n      typedef struct {\r\n\r\n       ULONG\r\n      hNotification;\r\n      __int64\r\n      nTimeStamp;\r\n      ULONG\r\n      cbSampleSize;\r\n      UCHAR\r\n      data[ANYSIZE_ARRAY];\r\n      } AdsNotificationHeader, *PAdsNotificationHeader;\r\n```\r\n\r\n\r\n"}}