{"action":"created","comment":{"url":"https://api.github.com/repos/boto/botocore/pulls/comments/38777700","id":38777700,"diff_hunk":"@@ -196,6 +208,65 @@ def generate_presigned_url(self, request_dict, expires_in=3600,\n         return request.url\n \n \n+class CloudFrontSigner(object):","path":"botocore/signers.py","position":30,"original_position":30,"commit_id":"b2f874379d83af88470ce7335bcd04e8f344f1b4","original_commit_id":"b2f874379d83af88470ce7335bcd04e8f344f1b4","user":{"login":"rayluo","id":821550,"avatar_url":"https://avatars.githubusercontent.com/u/821550?v=3","gravatar_id":"","url":"https://api.github.com/users/rayluo","html_url":"https://github.com/rayluo","followers_url":"https://api.github.com/users/rayluo/followers","following_url":"https://api.github.com/users/rayluo/following{/other_user}","gists_url":"https://api.github.com/users/rayluo/gists{/gist_id}","starred_url":"https://api.github.com/users/rayluo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rayluo/subscriptions","organizations_url":"https://api.github.com/users/rayluo/orgs","repos_url":"https://api.github.com/users/rayluo/repos","events_url":"https://api.github.com/users/rayluo/events{/privacy}","received_events_url":"https://api.github.com/users/rayluo/received_events","type":"User","site_admin":false},"body":"But I thought \"pre-signed\" is a naming convention only for S3. For example, in [S3 document, there are 19 occurrence of \"pre-signed\" and they don't use \"signed\"](http://docs.aws.amazon.com/AmazonS3/latest/dev/PresignedUrlUploadObject.html). On the contrary, [in CloudFront document, the naming convention is always saying \"signed\", never \"pre-signed\"](http://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/private-content-creating-signed-url-custom-policy.html). So, shall we keep the current \"CloudFrontSigner\" as-is?","created_at":"2015-09-04T17:59:02Z","updated_at":"2015-09-04T17:59:02Z","html_url":"https://github.com/boto/botocore/pull/635#discussion_r38777700","pull_request_url":"https://api.github.com/repos/boto/botocore/pulls/635","_links":{"self":{"href":"https://api.github.com/repos/boto/botocore/pulls/comments/38777700"},"html":{"href":"https://github.com/boto/botocore/pull/635#discussion_r38777700"},"pull_request":{"href":"https://api.github.com/repos/boto/botocore/pulls/635"}}},"pull_request":{"url":"https://api.github.com/repos/boto/botocore/pulls/635","id":43466729,"html_url":"https://github.com/boto/botocore/pull/635","diff_url":"https://github.com/boto/botocore/pull/635.diff","patch_url":"https://github.com/boto/botocore/pull/635.patch","issue_url":"https://api.github.com/repos/boto/botocore/issues/635","number":635,"state":"open","locked":false,"title":"Implement helpers for CloudFront url signer","user":{"login":"rayluo","id":821550,"avatar_url":"https://avatars.githubusercontent.com/u/821550?v=3","gravatar_id":"","url":"https://api.github.com/users/rayluo","html_url":"https://github.com/rayluo","followers_url":"https://api.github.com/users/rayluo/followers","following_url":"https://api.github.com/users/rayluo/following{/other_user}","gists_url":"https://api.github.com/users/rayluo/gists{/gist_id}","starred_url":"https://api.github.com/users/rayluo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rayluo/subscriptions","organizations_url":"https://api.github.com/users/rayluo/orgs","repos_url":"https://api.github.com/users/rayluo/repos","events_url":"https://api.github.com/users/rayluo/events{/privacy}","received_events_url":"https://api.github.com/users/rayluo/received_events","type":"User","site_admin":false},"body":"setup.py and requirements.txt are also updated to include new dependency rsa.","created_at":"2015-08-27T00:10:19Z","updated_at":"2015-09-04T17:59:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e6b283e05d1139b68ee4e30c7baa607e078df68","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/boto/botocore/pulls/635/commits","review_comments_url":"https://api.github.com/repos/boto/botocore/pulls/635/comments","review_comment_url":"https://api.github.com/repos/boto/botocore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boto/botocore/issues/635/comments","statuses_url":"https://api.github.com/repos/boto/botocore/statuses/b2f874379d83af88470ce7335bcd04e8f344f1b4","head":{"label":"rayluo:feature-cloudfront-sign","ref":"feature-cloudfront-sign","sha":"b2f874379d83af88470ce7335bcd04e8f344f1b4","user":{"login":"rayluo","id":821550,"avatar_url":"https://avatars.githubusercontent.com/u/821550?v=3","gravatar_id":"","url":"https://api.github.com/users/rayluo","html_url":"https://github.com/rayluo","followers_url":"https://api.github.com/users/rayluo/followers","following_url":"https://api.github.com/users/rayluo/following{/other_user}","gists_url":"https://api.github.com/users/rayluo/gists{/gist_id}","starred_url":"https://api.github.com/users/rayluo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rayluo/subscriptions","organizations_url":"https://api.github.com/users/rayluo/orgs","repos_url":"https://api.github.com/users/rayluo/repos","events_url":"https://api.github.com/users/rayluo/events{/privacy}","received_events_url":"https://api.github.com/users/rayluo/received_events","type":"User","site_admin":false},"repo":{"id":39043948,"name":"botocore","full_name":"rayluo/botocore","owner":{"login":"rayluo","id":821550,"avatar_url":"https://avatars.githubusercontent.com/u/821550?v=3","gravatar_id":"","url":"https://api.github.com/users/rayluo","html_url":"https://github.com/rayluo","followers_url":"https://api.github.com/users/rayluo/followers","following_url":"https://api.github.com/users/rayluo/following{/other_user}","gists_url":"https://api.github.com/users/rayluo/gists{/gist_id}","starred_url":"https://api.github.com/users/rayluo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rayluo/subscriptions","organizations_url":"https://api.github.com/users/rayluo/orgs","repos_url":"https://api.github.com/users/rayluo/repos","events_url":"https://api.github.com/users/rayluo/events{/privacy}","received_events_url":"https://api.github.com/users/rayluo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rayluo/botocore","description":"The low-level, core functionality of boto 3.","fork":true,"url":"https://api.github.com/repos/rayluo/botocore","forks_url":"https://api.github.com/repos/rayluo/botocore/forks","keys_url":"https://api.github.com/repos/rayluo/botocore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rayluo/botocore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rayluo/botocore/teams","hooks_url":"https://api.github.com/repos/rayluo/botocore/hooks","issue_events_url":"https://api.github.com/repos/rayluo/botocore/issues/events{/number}","events_url":"https://api.github.com/repos/rayluo/botocore/events","assignees_url":"https://api.github.com/repos/rayluo/botocore/assignees{/user}","branches_url":"https://api.github.com/repos/rayluo/botocore/branches{/branch}","tags_url":"https://api.github.com/repos/rayluo/botocore/tags","blobs_url":"https://api.github.com/repos/rayluo/botocore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rayluo/botocore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rayluo/botocore/git/refs{/sha}","trees_url":"https://api.github.com/repos/rayluo/botocore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rayluo/botocore/statuses/{sha}","languages_url":"https://api.github.com/repos/rayluo/botocore/languages","stargazers_url":"https://api.github.com/repos/rayluo/botocore/stargazers","contributors_url":"https://api.github.com/repos/rayluo/botocore/contributors","subscribers_url":"https://api.github.com/repos/rayluo/botocore/subscribers","subscription_url":"https://api.github.com/repos/rayluo/botocore/subscription","commits_url":"https://api.github.com/repos/rayluo/botocore/commits{/sha}","git_commits_url":"https://api.github.com/repos/rayluo/botocore/git/commits{/sha}","comments_url":"https://api.github.com/repos/rayluo/botocore/comments{/number}","issue_comment_url":"https://api.github.com/repos/rayluo/botocore/issues/comments{/number}","contents_url":"https://api.github.com/repos/rayluo/botocore/contents/{+path}","compare_url":"https://api.github.com/repos/rayluo/botocore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rayluo/botocore/merges","archive_url":"https://api.github.com/repos/rayluo/botocore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rayluo/botocore/downloads","issues_url":"https://api.github.com/repos/rayluo/botocore/issues{/number}","pulls_url":"https://api.github.com/repos/rayluo/botocore/pulls{/number}","milestones_url":"https://api.github.com/repos/rayluo/botocore/milestones{/number}","notifications_url":"https://api.github.com/repos/rayluo/botocore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rayluo/botocore/labels{/name}","releases_url":"https://api.github.com/repos/rayluo/botocore/releases{/id}","created_at":"2015-07-14T00:11:06Z","updated_at":"2015-07-14T00:11:09Z","pushed_at":"2015-09-04T06:39:01Z","git_url":"git://github.com/rayluo/botocore.git","ssh_url":"git@github.com:rayluo/botocore.git","clone_url":"https://github.com/rayluo/botocore.git","svn_url":"https://github.com/rayluo/botocore","homepage":null,"size":17606,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"boto:develop","ref":"develop","sha":"af77892fdb7a7f4161ed79bc4dfb7b558a0035b3","user":{"login":"boto","id":327752,"avatar_url":"https://avatars.githubusercontent.com/u/327752?v=3","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"repo":{"id":6670942,"name":"botocore","full_name":"boto/botocore","owner":{"login":"boto","id":327752,"avatar_url":"https://avatars.githubusercontent.com/u/327752?v=3","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boto/botocore","description":"The low-level, core functionality of boto 3.","fork":false,"url":"https://api.github.com/repos/boto/botocore","forks_url":"https://api.github.com/repos/boto/botocore/forks","keys_url":"https://api.github.com/repos/boto/botocore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boto/botocore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boto/botocore/teams","hooks_url":"https://api.github.com/repos/boto/botocore/hooks","issue_events_url":"https://api.github.com/repos/boto/botocore/issues/events{/number}","events_url":"https://api.github.com/repos/boto/botocore/events","assignees_url":"https://api.github.com/repos/boto/botocore/assignees{/user}","branches_url":"https://api.github.com/repos/boto/botocore/branches{/branch}","tags_url":"https://api.github.com/repos/boto/botocore/tags","blobs_url":"https://api.github.com/repos/boto/botocore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boto/botocore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boto/botocore/git/refs{/sha}","trees_url":"https://api.github.com/repos/boto/botocore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boto/botocore/statuses/{sha}","languages_url":"https://api.github.com/repos/boto/botocore/languages","stargazers_url":"https://api.github.com/repos/boto/botocore/stargazers","contributors_url":"https://api.github.com/repos/boto/botocore/contributors","subscribers_url":"https://api.github.com/repos/boto/botocore/subscribers","subscription_url":"https://api.github.com/repos/boto/botocore/subscription","commits_url":"https://api.github.com/repos/boto/botocore/commits{/sha}","git_commits_url":"https://api.github.com/repos/boto/botocore/git/commits{/sha}","comments_url":"https://api.github.com/repos/boto/botocore/comments{/number}","issue_comment_url":"https://api.github.com/repos/boto/botocore/issues/comments{/number}","contents_url":"https://api.github.com/repos/boto/botocore/contents/{+path}","compare_url":"https://api.github.com/repos/boto/botocore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boto/botocore/merges","archive_url":"https://api.github.com/repos/boto/botocore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boto/botocore/downloads","issues_url":"https://api.github.com/repos/boto/botocore/issues{/number}","pulls_url":"https://api.github.com/repos/boto/botocore/pulls{/number}","milestones_url":"https://api.github.com/repos/boto/botocore/milestones{/number}","notifications_url":"https://api.github.com/repos/boto/botocore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boto/botocore/labels{/name}","releases_url":"https://api.github.com/repos/boto/botocore/releases{/id}","created_at":"2012-11-13T13:25:36Z","updated_at":"2015-08-31T21:21:26Z","pushed_at":"2015-09-04T06:39:01Z","git_url":"git://github.com/boto/botocore.git","ssh_url":"git@github.com:boto/botocore.git","clone_url":"https://github.com/boto/botocore.git","svn_url":"https://github.com/boto/botocore","homepage":null,"size":24154,"stargazers_count":184,"watchers_count":184,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":105,"mirror_url":null,"open_issues_count":29,"forks":105,"open_issues":29,"watchers":184,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/boto/botocore/pulls/635"},"html":{"href":"https://github.com/boto/botocore/pull/635"},"issue":{"href":"https://api.github.com/repos/boto/botocore/issues/635"},"comments":{"href":"https://api.github.com/repos/boto/botocore/issues/635/comments"},"review_comments":{"href":"https://api.github.com/repos/boto/botocore/pulls/635/comments"},"review_comment":{"href":"https://api.github.com/repos/boto/botocore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boto/botocore/pulls/635/commits"},"statuses":{"href":"https://api.github.com/repos/boto/botocore/statuses/b2f874379d83af88470ce7335bcd04e8f344f1b4"}}}}