{"action":"created","issue":{"url":"https://api.github.com/repos/dimagi/commcare-hq/issues/6617","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/6617/labels{/name}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/6617/comments","events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/6617/events","html_url":"https://github.com/dimagi/commcare-hq/pull/6617","id":74365600,"number":6617,"title":"Add a 1em bottom margin below the save button","user":{"login":"kaapstorm","id":708421,"avatar_url":"https://avatars.githubusercontent.com/u/708421?v=3","gravatar_id":"","url":"https://api.github.com/users/kaapstorm","html_url":"https://github.com/kaapstorm","followers_url":"https://api.github.com/users/kaapstorm/followers","following_url":"https://api.github.com/users/kaapstorm/following{/other_user}","gists_url":"https://api.github.com/users/kaapstorm/gists{/gist_id}","starred_url":"https://api.github.com/users/kaapstorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaapstorm/subscriptions","organizations_url":"https://api.github.com/users/kaapstorm/orgs","repos_url":"https://api.github.com/users/kaapstorm/repos","events_url":"https://api.github.com/users/kaapstorm/events{/privacy}","received_events_url":"https://api.github.com/users/kaapstorm/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dimagi/commcare-hq/labels/Open%20for%20review:%20hold%20off%20on%20merge","name":"Open for review: hold off on merge","color":"5319e7"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-05-08T13:31:45Z","updated_at":"2015-05-26T09:02:21Z","closed_at":"2015-05-11T17:32:20Z","pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/6617","html_url":"https://github.com/dimagi/commcare-hq/pull/6617","diff_url":"https://github.com/dimagi/commcare-hq/pull/6617.diff","patch_url":"https://github.com/dimagi/commcare-hq/pull/6617.patch"},"body":"Hey @biyeun, I want to add a 1em margin below a button, otherwise it touches a well below it and looks dumb.\r\n\r\nBut I'm not sure where my class definition should go. I'm sure \"utilities.less\" is probably the wrong place, but the other places all looked even more wrong.\r\n\r\nAlso unsure about class naming conventions, if any; \"one-em-bottom\" would be a bad name if we decided that 10px would be better.\r\n\r\nCould you tell me what I should change, or point me to a style guide?\r\n\r\nBuddy @millerdev \r\n"},"comment":{"url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments/105456416","html_url":"https://github.com/dimagi/commcare-hq/pull/6617#issuecomment-105456416","issue_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/6617","id":105456416,"user":{"login":"kaapstorm","id":708421,"avatar_url":"https://avatars.githubusercontent.com/u/708421?v=3","gravatar_id":"","url":"https://api.github.com/users/kaapstorm","html_url":"https://github.com/kaapstorm","followers_url":"https://api.github.com/users/kaapstorm/followers","following_url":"https://api.github.com/users/kaapstorm/following{/other_user}","gists_url":"https://api.github.com/users/kaapstorm/gists{/gist_id}","starred_url":"https://api.github.com/users/kaapstorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaapstorm/subscriptions","organizations_url":"https://api.github.com/users/kaapstorm/orgs","repos_url":"https://api.github.com/users/kaapstorm/repos","events_url":"https://api.github.com/users/kaapstorm/events{/privacy}","received_events_url":"https://api.github.com/users/kaapstorm/received_events","type":"User","site_admin":false},"created_at":"2015-05-26T09:02:21Z","updated_at":"2015-05-26T09:02:21Z","body":"Thanks @biyeun, I agree. I took @orangejenny's advice, added a short README to static/style/lib, and applied the style at the block level. I also dropped the range of styles I had created for different sized gaps, and replaced them with just two, \"top-spacer\" and \"bottom-spacer\", with an explanation for why I made them 9px. It's in [commit 3c3c4bd9](https://github.com/dimagi/commcare-hq/commit/3c3c4bd9d4709bf938968098a54c5c0725831ab8). Please let me know if you think I should change anything."}}