{"push_id":804988470,"size":16,"distinct_size":1,"ref":"refs/heads/fix-trailing-commas","head":"45e844a16d9afcd4f96e05198ca56ef11db64a0f","before":"a7860c254ff4e5b4fb3a103e2ff0498bfa4ff66d","commits":[{"sha":"a8011f8846ea600028f400b2a397fb008c46c9ba","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Use Sidekiq (w/ Redis) as queueing backend\n\nIt's configured to use Sidekiq in both production and development. The\nlatter may not be desirable in the long term, but for now it enables\nad-hoc testing.\n\nThere is no specific configuration, so it assumes a Redis instance\nrunning locally on the default port.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/a8011f8846ea600028f400b2a397fb008c46c9ba"},{"sha":"3eb77d8716fe6bbc3264743d2a66774e29364c29","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Add queues to healthcheck & remove SMTP & Zendesk\n\nNow that we are going to send emails via queues, we don't actually care\nabout transient unavailability of SMTP servers or the Zendesk API.\nInstead, we care how many items are on the queues, and how old they are.\n\nThe healthcheck response now looks like this:\n\n    {\n      \"checks\": {\n        \"database\": true,\n        \"mailers\": false,\n        \"zendesk\": false\n      },\n      \"queues\": {\n        \"mailers\": {\n          \"oldest\": \"2015-08-24T11:19:21.993Z\",\n          \"count\": 2\n        },\n        \"zendesk\": {\n          \"oldest\": \"2015-08-24T11:19:21.995Z\",\n          \"count\": 1\n        }\n      }\n    }\n\nThe mailers and zendesk checks pass if there are no stale items in those\nqueues, which is computed by checking whether the oldest queue item is\nmore than ten minutes old.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/3eb77d8716fe6bbc3264743d2a66774e29364c29"},{"sha":"9c276713bf912e6ee36b4942a477ab350bc17a6a","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Remove now-unused SMTP check\n\nWe no longer include SMTP status in the healthcheck, so the\nconfusingly-named SendgridHelper.smtp_alive? method can go away.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/9c276713bf912e6ee36b4942a477ab350bc17a6a"},{"sha":"6f62025a80684522c3c4e9ba72bf22fd21fd0dc3","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Make healthcheck more robust\n\nCatch exceptions so that we always report what's broken - even if we\ndon't know why - rather than returning an unparseable 500 error page.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/6f62025a80684522c3c4e9ba72bf22fd21fd0dc3"},{"sha":"d07e43df716b58c5c7a69111ed5dfcb7ccbab022","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Configure Sidekiq queues via file\n\nThis allows the queues used by the application to be changed without\nhaving to alter the server configuration.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/d07e43df716b58c5c7a69111ed5dfcb7ccbab022"},{"sha":"70656c961b26a5c879dcd144136fb002a651bec0","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Match healthcheck format used by other services\n\nThe output of healthcheck.json now looks like this:\n\n    {\n      \"database\": {\n        \"description\": \"Postgres database\",\n        \"ok\": true\n      },\n      \"mailers\": {\n        \"description\": \"Email queue\",\n        \"ok\": true,\n        \"oldest\": \"2015-09-04T16:06:18.173Z\",\n        \"count\": 3\n      },\n      \"zendesk\": {\n        \"description\": \"Zendesk queue\",\n        \"ok\": true,\n        \"oldest\": \"2015-09-04T16:06:18.178Z\",\n        \"count\": 1\n      },\n      \"ok\": true\n    }\n\nFixes #225.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/70656c961b26a5c879dcd144136fb002a651bec0"},{"sha":"2afebed8b3b43a05db6f2d7c11f44a88f92fe537","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Don't rescue Exception\n\nException includes SyntaxError, LoadError, and Interrupt, which is\nprobably not what we want. If StandardError turns out not to be\nadequate, we can revisit this.\n\nSee http://stackoverflow.com/a/10048406","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/2afebed8b3b43a05db6f2d7c11f44a88f92fe537"},{"sha":"e3a1817a9707a44b7558d3274379329ab5e7c9fb","author":{"email":"09fda5260b7a9d52f2f61df887c9701d5c23b7e1@gmail.com","name":"Evangelos Giataganas"},"message":"Exclude Metrics/CyclomaticComplexity\n\nWe excluded cyclomatic complexity for error_key, because is already\nrefactored in the most simple way and whatever is there is needed.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/e3a1817a9707a44b7558d3274379329ab5e7c9fb"},{"sha":"010cfe3fed4855cbd8cbf5d0325318eae6bbce8b","author":{"email":"09fda5260b7a9d52f2f61df887c9701d5c23b7e1@gmail.com","name":"Evangelos Giataganas"},"message":"Fix cyclomatic complexity","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/010cfe3fed4855cbd8cbf5d0325318eae6bbce8b"},{"sha":"9bc4d476a71c9b0684fc2f51fd59927c7e8450a1","author":{"email":"9ce5770b3bb4b2a1d59be2d97e34379cd192299f@nascentguruism.com","name":"Steve Marshall"},"message":"Merge pull request #317 from ministryofjustice/fix-cyclomatic-complexity\n\nFix cyclomatic complexity","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/9bc4d476a71c9b0684fc2f51fd59927c7e8450a1"},{"sha":"d6b479cc933c5aa1e6c2407257a784cacc320b1a","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Fix trailing blank lines\n\nAs per the rubocop TODO.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/d6b479cc933c5aa1e6c2407257a784cacc320b1a"},{"sha":"77ea9af5f63ff08ea761f8cbcf08648e719159a1","author":{"email":"9ce5770b3bb4b2a1d59be2d97e34379cd192299f@nascentguruism.com","name":"Steve Marshall"},"message":"Merge pull request #323 from ministryofjustice/fix-trailing-blank-lines\n\nFix trailing blank lines","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/77ea9af5f63ff08ea761f8cbcf08648e719159a1"},{"sha":"b844aff5dba561759de44f46b26e609e5365b34e","author":{"email":"9ce5770b3bb4b2a1d59be2d97e34379cd192299f@nascentguruism.com","name":"Steve Marshall"},"message":"Merge pull request #258 from ministryofjustice/queued-emails\n\nSend email and tickets outside the main request-response cycle","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/b844aff5dba561759de44f46b26e609e5365b34e"},{"sha":"def70aee3a4cb8f48f5c026167021f1ee67a33f0","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Remove documentary comments/associated whitespace\n\nI started to do this as part of the rubocop LineLength TODO. On\nreflection, it seemed cleaner to do it on a separate branch as not all\nof them were excessively long.  Nevertheless, we don't want them in the\ncodebase.  Where removal would result in an empty file, as with\nconfig/initializers/backtrace_silencers.rb, I have left the opening\ncomment (almost always a warning to restart the server if the file\nchanges).","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/def70aee3a4cb8f48f5c026167021f1ee67a33f0"},{"sha":"36b1eec6910db81a10d50ff6b6046a3f64497b6c","author":{"email":"53237635563790ddc44f8cd7fa42a8eb8693bfdf@gmail.com","name":"Paul Battley"},"message":"Merge pull request #325 from ministryofjustice/remove-documentary-comments\n\nRemove documentary comments/associated whitespace","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/36b1eec6910db81a10d50ff6b6046a3f64497b6c"},{"sha":"45e844a16d9afcd4f96e05198ca56ef11db64a0f","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Remove trailing commas from last array elements\n\nAs per the rubocop TODO list.","distinct":true,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/45e844a16d9afcd4f96e05198ca56ef11db64a0f"}]}