{"action":"created","comment":{"url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/comments/48227080","id":48227080,"diff_hunk":"@@ -228,13 +225,17 @@ void failure_detector::process_all_records()\n                 report(record.node, true, false);\n             }\n         }\n-    }\n \n-    if ( expire.size() > 0 )\n-    {\n-        on_master_disconnected(expire);\n+        /*\n+         * The disconnected event MUST be under the protection of the _lock\n+         */\n+        if ( expire.size() > 0 )\n+        {\n+            on_master_disconnected(expire);\n+        }","path":"src/dist/failure_detector/failure_detector.cpp","position":88,"original_position":88,"commit_id":"b670c8cf45a1ee0886776e8553f4ef65a746285c","original_commit_id":"b670c8cf45a1ee0886776e8553f4ef65a746285c","user":{"login":"qinzuoyan","id":528445,"avatar_url":"https://avatars.githubusercontent.com/u/528445?v=3","gravatar_id":"","url":"https://api.github.com/users/qinzuoyan","html_url":"https://github.com/qinzuoyan","followers_url":"https://api.github.com/users/qinzuoyan/followers","following_url":"https://api.github.com/users/qinzuoyan/following{/other_user}","gists_url":"https://api.github.com/users/qinzuoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/qinzuoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinzuoyan/subscriptions","organizations_url":"https://api.github.com/users/qinzuoyan/orgs","repos_url":"https://api.github.com/users/qinzuoyan/repos","events_url":"https://api.github.com/users/qinzuoyan/events{/privacy}","received_events_url":"https://api.github.com/users/qinzuoyan/received_events","type":"User","site_admin":false},"body":"on_master_disconnected() is protected by lock, but why the following on_worker_disconnected() is not protected by lock?","created_at":"2015-12-22T07:13:23Z","updated_at":"2015-12-22T07:13:23Z","html_url":"https://github.com/imzhenyu/rDSN/pull/106#discussion_r48227080","pull_request_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/106","_links":{"self":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/comments/48227080"},"html":{"href":"https://github.com/imzhenyu/rDSN/pull/106#discussion_r48227080"},"pull_request":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/106","id":53966740,"html_url":"https://github.com/imzhenyu/rDSN/pull/106","diff_url":"https://github.com/imzhenyu/rDSN/pull/106.diff","patch_url":"https://github.com/imzhenyu/rDSN/pull/106.patch","issue_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/106","number":106,"state":"open","locked":false,"title":"fd bug fix and improvements with master switch","user":{"login":"shengofsun","id":1041832,"avatar_url":"https://avatars.githubusercontent.com/u/1041832?v=3","gravatar_id":"","url":"https://api.github.com/users/shengofsun","html_url":"https://github.com/shengofsun","followers_url":"https://api.github.com/users/shengofsun/followers","following_url":"https://api.github.com/users/shengofsun/following{/other_user}","gists_url":"https://api.github.com/users/shengofsun/gists{/gist_id}","starred_url":"https://api.github.com/users/shengofsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shengofsun/subscriptions","organizations_url":"https://api.github.com/users/shengofsun/orgs","repos_url":"https://api.github.com/users/shengofsun/repos","events_url":"https://api.github.com/users/shengofsun/events{/privacy}","received_events_url":"https://api.github.com/users/shengofsun/received_events","type":"User","site_admin":false},"body":"1. modify the failure detector, to support multiple meta servers\r\n2. add test case for failure detector\r\n3. fix some cases in rep-test, at it may fail\r\n4. fix travis.yml. Currently no need to do \"apt-get\" things, only download necessary packages and do install.\r\n","created_at":"2015-12-17T11:48:32Z","updated_at":"2015-12-22T07:13:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d57b17a9a2e74241680c8d52eddb40f14060fba7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/106/commits","review_comments_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/106/comments","review_comment_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls/comments{/number}","comments_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/106/comments","statuses_url":"https://api.github.com/repos/imzhenyu/rDSN/statuses/b670c8cf45a1ee0886776e8553f4ef65a746285c","head":{"label":"shengofsun:developing","ref":"developing","sha":"b670c8cf45a1ee0886776e8553f4ef65a746285c","user":{"login":"shengofsun","id":1041832,"avatar_url":"https://avatars.githubusercontent.com/u/1041832?v=3","gravatar_id":"","url":"https://api.github.com/users/shengofsun","html_url":"https://github.com/shengofsun","followers_url":"https://api.github.com/users/shengofsun/followers","following_url":"https://api.github.com/users/shengofsun/following{/other_user}","gists_url":"https://api.github.com/users/shengofsun/gists{/gist_id}","starred_url":"https://api.github.com/users/shengofsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shengofsun/subscriptions","organizations_url":"https://api.github.com/users/shengofsun/orgs","repos_url":"https://api.github.com/users/shengofsun/repos","events_url":"https://api.github.com/users/shengofsun/events{/privacy}","received_events_url":"https://api.github.com/users/shengofsun/received_events","type":"User","site_admin":false},"repo":{"id":37642478,"name":"rDSN","full_name":"shengofsun/rDSN","owner":{"login":"shengofsun","id":1041832,"avatar_url":"https://avatars.githubusercontent.com/u/1041832?v=3","gravatar_id":"","url":"https://api.github.com/users/shengofsun","html_url":"https://github.com/shengofsun","followers_url":"https://api.github.com/users/shengofsun/followers","following_url":"https://api.github.com/users/shengofsun/following{/other_user}","gists_url":"https://api.github.com/users/shengofsun/gists{/gist_id}","starred_url":"https://api.github.com/users/shengofsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shengofsun/subscriptions","organizations_url":"https://api.github.com/users/shengofsun/orgs","repos_url":"https://api.github.com/users/shengofsun/repos","events_url":"https://api.github.com/users/shengofsun/events{/privacy}","received_events_url":"https://api.github.com/users/shengofsun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shengofsun/rDSN","description":"Robust Distributed System Nucleus (rDSN) is an open framework for quickly building and managing high performance and robust distributed systems.","fork":true,"url":"https://api.github.com/repos/shengofsun/rDSN","forks_url":"https://api.github.com/repos/shengofsun/rDSN/forks","keys_url":"https://api.github.com/repos/shengofsun/rDSN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shengofsun/rDSN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shengofsun/rDSN/teams","hooks_url":"https://api.github.com/repos/shengofsun/rDSN/hooks","issue_events_url":"https://api.github.com/repos/shengofsun/rDSN/issues/events{/number}","events_url":"https://api.github.com/repos/shengofsun/rDSN/events","assignees_url":"https://api.github.com/repos/shengofsun/rDSN/assignees{/user}","branches_url":"https://api.github.com/repos/shengofsun/rDSN/branches{/branch}","tags_url":"https://api.github.com/repos/shengofsun/rDSN/tags","blobs_url":"https://api.github.com/repos/shengofsun/rDSN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shengofsun/rDSN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shengofsun/rDSN/git/refs{/sha}","trees_url":"https://api.github.com/repos/shengofsun/rDSN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shengofsun/rDSN/statuses/{sha}","languages_url":"https://api.github.com/repos/shengofsun/rDSN/languages","stargazers_url":"https://api.github.com/repos/shengofsun/rDSN/stargazers","contributors_url":"https://api.github.com/repos/shengofsun/rDSN/contributors","subscribers_url":"https://api.github.com/repos/shengofsun/rDSN/subscribers","subscription_url":"https://api.github.com/repos/shengofsun/rDSN/subscription","commits_url":"https://api.github.com/repos/shengofsun/rDSN/commits{/sha}","git_commits_url":"https://api.github.com/repos/shengofsun/rDSN/git/commits{/sha}","comments_url":"https://api.github.com/repos/shengofsun/rDSN/comments{/number}","issue_comment_url":"https://api.github.com/repos/shengofsun/rDSN/issues/comments{/number}","contents_url":"https://api.github.com/repos/shengofsun/rDSN/contents/{+path}","compare_url":"https://api.github.com/repos/shengofsun/rDSN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shengofsun/rDSN/merges","archive_url":"https://api.github.com/repos/shengofsun/rDSN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shengofsun/rDSN/downloads","issues_url":"https://api.github.com/repos/shengofsun/rDSN/issues{/number}","pulls_url":"https://api.github.com/repos/shengofsun/rDSN/pulls{/number}","milestones_url":"https://api.github.com/repos/shengofsun/rDSN/milestones{/number}","notifications_url":"https://api.github.com/repos/shengofsun/rDSN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shengofsun/rDSN/labels{/name}","releases_url":"https://api.github.com/repos/shengofsun/rDSN/releases{/id}","created_at":"2015-06-18T06:43:44Z","updated_at":"2015-06-18T06:43:45Z","pushed_at":"2015-12-22T03:47:56Z","git_url":"git://github.com/shengofsun/rDSN.git","ssh_url":"git@github.com:shengofsun/rDSN.git","clone_url":"https://github.com/shengofsun/rDSN.git","svn_url":"https://github.com/shengofsun/rDSN","homepage":null,"size":46243,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"imzhenyu:master","ref":"master","sha":"09774b7fa8a7d52379f6dac001ff8bef7a9ce407","user":{"login":"imzhenyu","id":6927143,"avatar_url":"https://avatars.githubusercontent.com/u/6927143?v=3","gravatar_id":"","url":"https://api.github.com/users/imzhenyu","html_url":"https://github.com/imzhenyu","followers_url":"https://api.github.com/users/imzhenyu/followers","following_url":"https://api.github.com/users/imzhenyu/following{/other_user}","gists_url":"https://api.github.com/users/imzhenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/imzhenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imzhenyu/subscriptions","organizations_url":"https://api.github.com/users/imzhenyu/orgs","repos_url":"https://api.github.com/users/imzhenyu/repos","events_url":"https://api.github.com/users/imzhenyu/events{/privacy}","received_events_url":"https://api.github.com/users/imzhenyu/received_events","type":"User","site_admin":false},"repo":{"id":37038578,"name":"rDSN","full_name":"imzhenyu/rDSN","owner":{"login":"imzhenyu","id":6927143,"avatar_url":"https://avatars.githubusercontent.com/u/6927143?v=3","gravatar_id":"","url":"https://api.github.com/users/imzhenyu","html_url":"https://github.com/imzhenyu","followers_url":"https://api.github.com/users/imzhenyu/followers","following_url":"https://api.github.com/users/imzhenyu/following{/other_user}","gists_url":"https://api.github.com/users/imzhenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/imzhenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imzhenyu/subscriptions","organizations_url":"https://api.github.com/users/imzhenyu/orgs","repos_url":"https://api.github.com/users/imzhenyu/repos","events_url":"https://api.github.com/users/imzhenyu/events{/privacy}","received_events_url":"https://api.github.com/users/imzhenyu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imzhenyu/rDSN","description":"Robust Distributed System Nucleus (rDSN) is an open framework for quickly building and managing high performance and robust distributed systems.","fork":true,"url":"https://api.github.com/repos/imzhenyu/rDSN","forks_url":"https://api.github.com/repos/imzhenyu/rDSN/forks","keys_url":"https://api.github.com/repos/imzhenyu/rDSN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imzhenyu/rDSN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imzhenyu/rDSN/teams","hooks_url":"https://api.github.com/repos/imzhenyu/rDSN/hooks","issue_events_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/events{/number}","events_url":"https://api.github.com/repos/imzhenyu/rDSN/events","assignees_url":"https://api.github.com/repos/imzhenyu/rDSN/assignees{/user}","branches_url":"https://api.github.com/repos/imzhenyu/rDSN/branches{/branch}","tags_url":"https://api.github.com/repos/imzhenyu/rDSN/tags","blobs_url":"https://api.github.com/repos/imzhenyu/rDSN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imzhenyu/rDSN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imzhenyu/rDSN/git/refs{/sha}","trees_url":"https://api.github.com/repos/imzhenyu/rDSN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imzhenyu/rDSN/statuses/{sha}","languages_url":"https://api.github.com/repos/imzhenyu/rDSN/languages","stargazers_url":"https://api.github.com/repos/imzhenyu/rDSN/stargazers","contributors_url":"https://api.github.com/repos/imzhenyu/rDSN/contributors","subscribers_url":"https://api.github.com/repos/imzhenyu/rDSN/subscribers","subscription_url":"https://api.github.com/repos/imzhenyu/rDSN/subscription","commits_url":"https://api.github.com/repos/imzhenyu/rDSN/commits{/sha}","git_commits_url":"https://api.github.com/repos/imzhenyu/rDSN/git/commits{/sha}","comments_url":"https://api.github.com/repos/imzhenyu/rDSN/comments{/number}","issue_comment_url":"https://api.github.com/repos/imzhenyu/rDSN/issues/comments{/number}","contents_url":"https://api.github.com/repos/imzhenyu/rDSN/contents/{+path}","compare_url":"https://api.github.com/repos/imzhenyu/rDSN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imzhenyu/rDSN/merges","archive_url":"https://api.github.com/repos/imzhenyu/rDSN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imzhenyu/rDSN/downloads","issues_url":"https://api.github.com/repos/imzhenyu/rDSN/issues{/number}","pulls_url":"https://api.github.com/repos/imzhenyu/rDSN/pulls{/number}","milestones_url":"https://api.github.com/repos/imzhenyu/rDSN/milestones{/number}","notifications_url":"https://api.github.com/repos/imzhenyu/rDSN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imzhenyu/rDSN/labels{/name}","releases_url":"https://api.github.com/repos/imzhenyu/rDSN/releases{/id}","created_at":"2015-06-08T00:54:11Z","updated_at":"2015-12-22T00:03:11Z","pushed_at":"2015-12-22T06:52:34Z","git_url":"git://github.com/imzhenyu/rDSN.git","ssh_url":"git@github.com:imzhenyu/rDSN.git","clone_url":"https://github.com/imzhenyu/rDSN.git","svn_url":"https://github.com/imzhenyu/rDSN","homepage":null,"size":46391,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":36,"forks":4,"open_issues":36,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/106"},"html":{"href":"https://github.com/imzhenyu/rDSN/pull/106"},"issue":{"href":"https://api.github.com/repos/imzhenyu/rDSN/issues/106"},"comments":{"href":"https://api.github.com/repos/imzhenyu/rDSN/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/imzhenyu/rDSN/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/imzhenyu/rDSN/statuses/b670c8cf45a1ee0886776e8553f4ef65a746285c"}}}}