{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/pulls/comments/42369258","id":42369258,"diff_hunk":"@@ -21,12 +19,33 @@ function merge{T}(ta1::TimeArray{T}, ta2::TimeArray{T}; col_names=[\"\"])\n     # combine existing colnames\n     cnames = vcat(ta1.colnames, ta2.colnames)\n     # check if kwarg to over-ride simple vcat and then if colnames is valid length\n-    size(col_names,1) == 1 ? cnames = cnames :       # kwarg not supplied\n-    size(col_names,1) == size(vals,2) ? cnames = col_names : error(\"col_names supplied is not correct size\")\n+    length(col_names) == size(vals,2) ? cnames = col_names :","path":"src/combine.jl","position":19,"original_position":19,"commit_id":"df52fd0f13072ff518a1beed8c921d7951d2e39b","original_commit_id":"df52fd0f13072ff518a1beed8c921d7951d2e39b","user":{"login":"milktrader","id":324836,"avatar_url":"https://avatars.githubusercontent.com/u/324836?v=3","gravatar_id":"","url":"https://api.github.com/users/milktrader","html_url":"https://github.com/milktrader","followers_url":"https://api.github.com/users/milktrader/followers","following_url":"https://api.github.com/users/milktrader/following{/other_user}","gists_url":"https://api.github.com/users/milktrader/gists{/gist_id}","starred_url":"https://api.github.com/users/milktrader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milktrader/subscriptions","organizations_url":"https://api.github.com/users/milktrader/orgs","repos_url":"https://api.github.com/users/milktrader/repos","events_url":"https://api.github.com/users/milktrader/events{/privacy}","received_events_url":"https://api.github.com/users/milktrader/received_events","type":"User","site_admin":false},"body":"Why change `size(col_names,1)` to `length(col_names)`? I'd prefer to not use `length`","created_at":"2015-10-19T13:21:29Z","updated_at":"2015-10-19T13:21:29Z","html_url":"https://github.com/JuliaStats/TimeSeries.jl/pull/215#discussion_r42369258","pull_request_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/pulls/215","_links":{"self":{"href":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/pulls/comments/42369258"},"html":{"href":"https://github.com/JuliaStats/TimeSeries.jl/pull/215#discussion_r42369258"},"pull_request":{"href":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/pulls/215"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/pulls/215","id":47964457,"html_url":"https://github.com/JuliaStats/TimeSeries.jl/pull/215","diff_url":"https://github.com/JuliaStats/TimeSeries.jl/pull/215.diff","patch_url":"https://github.com/JuliaStats/TimeSeries.jl/pull/215.patch","issue_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/issues/215","number":215,"state":"open","locked":false,"title":"WIP: Merge extensions","user":{"login":"GordStephen","id":2753264,"avatar_url":"https://avatars.githubusercontent.com/u/2753264?v=3","gravatar_id":"","url":"https://api.github.com/users/GordStephen","html_url":"https://github.com/GordStephen","followers_url":"https://api.github.com/users/GordStephen/followers","following_url":"https://api.github.com/users/GordStephen/following{/other_user}","gists_url":"https://api.github.com/users/GordStephen/gists{/gist_id}","starred_url":"https://api.github.com/users/GordStephen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordStephen/subscriptions","organizations_url":"https://api.github.com/users/GordStephen/orgs","repos_url":"https://api.github.com/users/GordStephen/repos","events_url":"https://api.github.com/users/GordStephen/events{/privacy}","received_events_url":"https://api.github.com/users/GordStephen/received_events","type":"User","site_admin":false},"body":"Eventually it would be good to have left, right, and outer merges/joins as well as the default inner merge - maybe once we have a better means of handling missing values though. I needed to induce equal spacing of observation rows and figured a left merge would be the cleanest way to do that, so implemented it and leave it here as a potential starting point if we want to come back to this somewhere down the road.\r\n\r\nFor reference, here's what the uniform spacing functions do:\r\n\r\n```julia\r\njulia> using TimeSeries\r\njulia> using MarketData\r\njulia> uniformlyspaced(cl)\r\nfalse\r\njulia> uniformlyspace(cl)[1:8]\r\n8x1 TimeSeries.TimeArray{Float64,2,Void} 2000-01-03 to 2000-01-10\r\n\r\n             Close     \r\n2000-01-03 | 111.94    \r\n2000-01-04 | 102.5     \r\n2000-01-05 | 104.0     \r\n2000-01-06 | 95.0      \r\n⋮\r\n2000-01-07 | 99.5      \r\n2000-01-08 | NaN       \r\n2000-01-09 | NaN       \r\n2000-01-10 | 97.75\r\n```","created_at":"2015-10-16T21:51:41Z","updated_at":"2015-10-19T13:21:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a65e4171d69feb6aae86d7eb5efb26f6e018d940","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/pulls/215/commits","review_comments_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/pulls/215/comments","review_comment_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/issues/215/comments","statuses_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/statuses/df52fd0f13072ff518a1beed8c921d7951d2e39b","head":{"label":"JuliaStats:merge-extensions","ref":"merge-extensions","sha":"df52fd0f13072ff518a1beed8c921d7951d2e39b","user":{"login":"JuliaStats","id":2761531,"avatar_url":"https://avatars.githubusercontent.com/u/2761531?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaStats","html_url":"https://github.com/JuliaStats","followers_url":"https://api.github.com/users/JuliaStats/followers","following_url":"https://api.github.com/users/JuliaStats/following{/other_user}","gists_url":"https://api.github.com/users/JuliaStats/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaStats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaStats/subscriptions","organizations_url":"https://api.github.com/users/JuliaStats/orgs","repos_url":"https://api.github.com/users/JuliaStats/repos","events_url":"https://api.github.com/users/JuliaStats/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaStats/received_events","type":"Organization","site_admin":false},"repo":{"id":7288296,"name":"TimeSeries.jl","full_name":"JuliaStats/TimeSeries.jl","owner":{"login":"JuliaStats","id":2761531,"avatar_url":"https://avatars.githubusercontent.com/u/2761531?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaStats","html_url":"https://github.com/JuliaStats","followers_url":"https://api.github.com/users/JuliaStats/followers","following_url":"https://api.github.com/users/JuliaStats/following{/other_user}","gists_url":"https://api.github.com/users/JuliaStats/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaStats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaStats/subscriptions","organizations_url":"https://api.github.com/users/JuliaStats/orgs","repos_url":"https://api.github.com/users/JuliaStats/repos","events_url":"https://api.github.com/users/JuliaStats/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaStats/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaStats/TimeSeries.jl","description":"Time series toolkit for Julia","fork":false,"url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl","forks_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/forks","keys_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/teams","hooks_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/events","assignees_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/tags","blobs_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/subscription","commits_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/merges","archive_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/downloads","issues_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/releases{/id}","created_at":"2012-12-22T16:59:57Z","updated_at":"2015-10-07T03:51:07Z","pushed_at":"2015-10-18T13:35:01Z","git_url":"git://github.com/JuliaStats/TimeSeries.jl.git","ssh_url":"git@github.com:JuliaStats/TimeSeries.jl.git","clone_url":"https://github.com/JuliaStats/TimeSeries.jl.git","svn_url":"https://github.com/JuliaStats/TimeSeries.jl","homepage":"","size":2733,"stargazers_count":40,"watchers_count":40,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":18,"forks":15,"open_issues":18,"watchers":40,"default_branch":"master"}},"base":{"label":"JuliaStats:master","ref":"master","sha":"fc08218dbf9c680f423c3a4e8ca94cfa74da8e25","user":{"login":"JuliaStats","id":2761531,"avatar_url":"https://avatars.githubusercontent.com/u/2761531?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaStats","html_url":"https://github.com/JuliaStats","followers_url":"https://api.github.com/users/JuliaStats/followers","following_url":"https://api.github.com/users/JuliaStats/following{/other_user}","gists_url":"https://api.github.com/users/JuliaStats/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaStats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaStats/subscriptions","organizations_url":"https://api.github.com/users/JuliaStats/orgs","repos_url":"https://api.github.com/users/JuliaStats/repos","events_url":"https://api.github.com/users/JuliaStats/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaStats/received_events","type":"Organization","site_admin":false},"repo":{"id":7288296,"name":"TimeSeries.jl","full_name":"JuliaStats/TimeSeries.jl","owner":{"login":"JuliaStats","id":2761531,"avatar_url":"https://avatars.githubusercontent.com/u/2761531?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaStats","html_url":"https://github.com/JuliaStats","followers_url":"https://api.github.com/users/JuliaStats/followers","following_url":"https://api.github.com/users/JuliaStats/following{/other_user}","gists_url":"https://api.github.com/users/JuliaStats/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaStats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaStats/subscriptions","organizations_url":"https://api.github.com/users/JuliaStats/orgs","repos_url":"https://api.github.com/users/JuliaStats/repos","events_url":"https://api.github.com/users/JuliaStats/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaStats/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaStats/TimeSeries.jl","description":"Time series toolkit for Julia","fork":false,"url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl","forks_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/forks","keys_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/teams","hooks_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/events","assignees_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/tags","blobs_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/subscription","commits_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/merges","archive_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/downloads","issues_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/releases{/id}","created_at":"2012-12-22T16:59:57Z","updated_at":"2015-10-07T03:51:07Z","pushed_at":"2015-10-18T13:35:01Z","git_url":"git://github.com/JuliaStats/TimeSeries.jl.git","ssh_url":"git@github.com:JuliaStats/TimeSeries.jl.git","clone_url":"https://github.com/JuliaStats/TimeSeries.jl.git","svn_url":"https://github.com/JuliaStats/TimeSeries.jl","homepage":"","size":2733,"stargazers_count":40,"watchers_count":40,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":18,"forks":15,"open_issues":18,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/pulls/215"},"html":{"href":"https://github.com/JuliaStats/TimeSeries.jl/pull/215"},"issue":{"href":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/issues/215"},"comments":{"href":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/issues/215/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/pulls/215/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/pulls/215/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaStats/TimeSeries.jl/statuses/df52fd0f13072ff518a1beed8c921d7951d2e39b"}}}}