{"action":"created","issue":{"url":"https://api.github.com/repos/gcstaublin/pregame/issues/3","labels_url":"https://api.github.com/repos/gcstaublin/pregame/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/gcstaublin/pregame/issues/3/comments","events_url":"https://api.github.com/repos/gcstaublin/pregame/issues/3/events","html_url":"https://github.com/gcstaublin/pregame/issues/3","id":110658237,"number":3,"title":"Variables","user":{"login":"gcstaublin","id":959486,"avatar_url":"https://avatars.githubusercontent.com/u/959486?v=3","gravatar_id":"","url":"https://api.github.com/users/gcstaublin","html_url":"https://github.com/gcstaublin","followers_url":"https://api.github.com/users/gcstaublin/followers","following_url":"https://api.github.com/users/gcstaublin/following{/other_user}","gists_url":"https://api.github.com/users/gcstaublin/gists{/gist_id}","starred_url":"https://api.github.com/users/gcstaublin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcstaublin/subscriptions","organizations_url":"https://api.github.com/users/gcstaublin/orgs","repos_url":"https://api.github.com/users/gcstaublin/repos","events_url":"https://api.github.com/users/gcstaublin/events{/privacy}","received_events_url":"https://api.github.com/users/gcstaublin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/gcstaublin/pregame/labels/Discussion","name":"Discussion","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-09T13:22:13Z","updated_at":"2015-10-21T21:25:02Z","closed_at":null,"body":"Let's talk about variables.\r\n\r\n1. How do we organize them? One big file vs. smaller, discrete files (i.e. `settings.colors`, `settings.zindex`, etc)\r\n1. What is the naming convention?  \r\n  - Underscores vs. hyphens: `$ui_text_dark_color` vs `$ui-text-dark-color`\r\n  - Any BEM style modifications? `$ui-text-color--dark`  \r\n  - Order of the naming convention? \r\n1. Do we have configuration (local) variables on the top of individual files?  \r\nFor instance, does the button mixin file have the local default variables declared at the top of the that file, mapping back to our universally declared variables?\r\n1. Using `!default` variables?  \r\nHypothetically, we could allow for some configuration by adding the default flag to certain variables, which could then be overwritten locally by a cluster importing a `defaults.scss` file before the rest of Pregame\r\n"},"comment":{"url":"https://api.github.com/repos/gcstaublin/pregame/issues/comments/150028505","html_url":"https://github.com/gcstaublin/pregame/issues/3#issuecomment-150028505","issue_url":"https://api.github.com/repos/gcstaublin/pregame/issues/3","id":150028505,"user":{"login":"mfouquet","id":7400740,"avatar_url":"https://avatars.githubusercontent.com/u/7400740?v=3","gravatar_id":"","url":"https://api.github.com/users/mfouquet","html_url":"https://github.com/mfouquet","followers_url":"https://api.github.com/users/mfouquet/followers","following_url":"https://api.github.com/users/mfouquet/following{/other_user}","gists_url":"https://api.github.com/users/mfouquet/gists{/gist_id}","starred_url":"https://api.github.com/users/mfouquet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfouquet/subscriptions","organizations_url":"https://api.github.com/users/mfouquet/orgs","repos_url":"https://api.github.com/users/mfouquet/repos","events_url":"https://api.github.com/users/mfouquet/events{/privacy}","received_events_url":"https://api.github.com/users/mfouquet/received_events","type":"User","site_admin":false},"created_at":"2015-10-21T21:25:02Z","updated_at":"2015-10-21T21:25:02Z","body":"1. My vote is for separate files. I was thinking originally just one file, but we'll probably end up having a lot and if we separate them out mixins, we should do the same with variables. Set up the expectation and all that. Using Atom/Sublime you can pretty quickly navigate between files. \r\n2. Ever since Nick showed me the light, I like the underscores because it's easier to copy/paste. I don't know how to feel about the BEM style naming - my gut says no since I like the underscores. I could see the argument though for local variables (like for buttons) since those won't be copied/used elsewhere except within that element and you'll run into more times where you'd need modifiers. \r\n3. I think I know the benefits of doing this and I'm not sure I'm completely sold on it - what do you see this solving?\r\n4. Same as 3. "}}