{"action":"created","comment":{"url":"https://api.github.com/repos/falconry/falcon/pulls/comments/28376284","id":28376284,"diff_hunk":"@@ -117,6 +117,16 @@ def on_head(self, req, resp):\n         resp.content_location = self.URL1\n \n \n+class UnicodeHeaderResource:\n+\n+    def on_get(self, req, resp):\n+        resp.set_headers([\n+            (u'X-auTH-toKEN', 'toomanysecrets'),\n+            ('Content-TYpE', u'application/json'),\n+            (u'X-symBOl', u'\\u0040'),","path":"tests/test_headers.py","position":10,"original_position":10,"commit_id":"fc35d430c1382b128eaea186c277e9009bc95fe6","original_commit_id":"fc35d430c1382b128eaea186c277e9009bc95fe6","user":{"login":"kgriffs","id":719939,"avatar_url":"https://avatars.githubusercontent.com/u/719939?v=3","gravatar_id":"","url":"https://api.github.com/users/kgriffs","html_url":"https://github.com/kgriffs","followers_url":"https://api.github.com/users/kgriffs/followers","following_url":"https://api.github.com/users/kgriffs/following{/other_user}","gists_url":"https://api.github.com/users/kgriffs/gists{/gist_id}","starred_url":"https://api.github.com/users/kgriffs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgriffs/subscriptions","organizations_url":"https://api.github.com/users/kgriffs/orgs","repos_url":"https://api.github.com/users/kgriffs/repos","events_url":"https://api.github.com/users/kgriffs/events{/privacy}","received_events_url":"https://api.github.com/users/kgriffs/received_events","type":"User","site_admin":false},"body":"Would you mind adding a negative test that includes a non-ascii character, and asserting that it does indeed raise an error?","created_at":"2015-04-14T22:10:03Z","updated_at":"2015-04-14T22:10:03Z","html_url":"https://github.com/falconry/falcon/pull/490#discussion_r28376284","pull_request_url":"https://api.github.com/repos/falconry/falcon/pulls/490","_links":{"self":{"href":"https://api.github.com/repos/falconry/falcon/pulls/comments/28376284"},"html":{"href":"https://github.com/falconry/falcon/pull/490#discussion_r28376284"},"pull_request":{"href":"https://api.github.com/repos/falconry/falcon/pulls/490"}}},"pull_request":{"url":"https://api.github.com/repos/falconry/falcon/pulls/490","id":33210447,"html_url":"https://github.com/falconry/falcon/pull/490","diff_url":"https://github.com/falconry/falcon/pull/490.diff","patch_url":"https://github.com/falconry/falcon/pull/490.patch","issue_url":"https://api.github.com/repos/falconry/falcon/issues/490","number":490,"state":"open","locked":false,"title":"fix(falcon/request): HTTP headers as strings","user":{"login":"ginoledesma","id":879991,"avatar_url":"https://avatars.githubusercontent.com/u/879991?v=3","gravatar_id":"","url":"https://api.github.com/users/ginoledesma","html_url":"https://github.com/ginoledesma","followers_url":"https://api.github.com/users/ginoledesma/followers","following_url":"https://api.github.com/users/ginoledesma/following{/other_user}","gists_url":"https://api.github.com/users/ginoledesma/gists{/gist_id}","starred_url":"https://api.github.com/users/ginoledesma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginoledesma/subscriptions","organizations_url":"https://api.github.com/users/ginoledesma/orgs","repos_url":"https://api.github.com/users/ginoledesma/repos","events_url":"https://api.github.com/users/ginoledesma/events{/privacy}","received_events_url":"https://api.github.com/users/ginoledesma/received_events","type":"User","site_admin":false},"body":"Ensure HTTP headers and values are string types per PEP3333. This\r\nfixes wsgi servers running under py2k.\r\n\r\nFixes #413\r\nThis doesn't enforce codepoint boundary yet (must be in \\u00-\\uFF)","created_at":"2015-04-13T22:33:38Z","updated_at":"2015-04-14T22:10:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da8f1887a2afcf157f4a5246e96022378cd3d383","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/falconry/falcon/pulls/490/commits","review_comments_url":"https://api.github.com/repos/falconry/falcon/pulls/490/comments","review_comment_url":"https://api.github.com/repos/falconry/falcon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/falconry/falcon/issues/490/comments","statuses_url":"https://api.github.com/repos/falconry/falcon/statuses/fc35d430c1382b128eaea186c277e9009bc95fe6","head":{"label":"ginoledesma:unicode-header-values","ref":"unicode-header-values","sha":"fc35d430c1382b128eaea186c277e9009bc95fe6","user":{"login":"ginoledesma","id":879991,"avatar_url":"https://avatars.githubusercontent.com/u/879991?v=3","gravatar_id":"","url":"https://api.github.com/users/ginoledesma","html_url":"https://github.com/ginoledesma","followers_url":"https://api.github.com/users/ginoledesma/followers","following_url":"https://api.github.com/users/ginoledesma/following{/other_user}","gists_url":"https://api.github.com/users/ginoledesma/gists{/gist_id}","starred_url":"https://api.github.com/users/ginoledesma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginoledesma/subscriptions","organizations_url":"https://api.github.com/users/ginoledesma/orgs","repos_url":"https://api.github.com/users/ginoledesma/repos","events_url":"https://api.github.com/users/ginoledesma/events{/privacy}","received_events_url":"https://api.github.com/users/ginoledesma/received_events","type":"User","site_admin":false},"repo":{"id":33870729,"name":"falcon","full_name":"ginoledesma/falcon","owner":{"login":"ginoledesma","id":879991,"avatar_url":"https://avatars.githubusercontent.com/u/879991?v=3","gravatar_id":"","url":"https://api.github.com/users/ginoledesma","html_url":"https://github.com/ginoledesma","followers_url":"https://api.github.com/users/ginoledesma/followers","following_url":"https://api.github.com/users/ginoledesma/following{/other_user}","gists_url":"https://api.github.com/users/ginoledesma/gists{/gist_id}","starred_url":"https://api.github.com/users/ginoledesma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginoledesma/subscriptions","organizations_url":"https://api.github.com/users/ginoledesma/orgs","repos_url":"https://api.github.com/users/ginoledesma/repos","events_url":"https://api.github.com/users/ginoledesma/events{/privacy}","received_events_url":"https://api.github.com/users/ginoledesma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ginoledesma/falcon","description":"Falcon is a high-performance Python framework for building cloud APIs and web app backends.","fork":true,"url":"https://api.github.com/repos/ginoledesma/falcon","forks_url":"https://api.github.com/repos/ginoledesma/falcon/forks","keys_url":"https://api.github.com/repos/ginoledesma/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ginoledesma/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ginoledesma/falcon/teams","hooks_url":"https://api.github.com/repos/ginoledesma/falcon/hooks","issue_events_url":"https://api.github.com/repos/ginoledesma/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/ginoledesma/falcon/events","assignees_url":"https://api.github.com/repos/ginoledesma/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/ginoledesma/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/ginoledesma/falcon/tags","blobs_url":"https://api.github.com/repos/ginoledesma/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ginoledesma/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ginoledesma/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/ginoledesma/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ginoledesma/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/ginoledesma/falcon/languages","stargazers_url":"https://api.github.com/repos/ginoledesma/falcon/stargazers","contributors_url":"https://api.github.com/repos/ginoledesma/falcon/contributors","subscribers_url":"https://api.github.com/repos/ginoledesma/falcon/subscribers","subscription_url":"https://api.github.com/repos/ginoledesma/falcon/subscription","commits_url":"https://api.github.com/repos/ginoledesma/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/ginoledesma/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/ginoledesma/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/ginoledesma/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/ginoledesma/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/ginoledesma/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ginoledesma/falcon/merges","archive_url":"https://api.github.com/repos/ginoledesma/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ginoledesma/falcon/downloads","issues_url":"https://api.github.com/repos/ginoledesma/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/ginoledesma/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/ginoledesma/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/ginoledesma/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ginoledesma/falcon/labels{/name}","releases_url":"https://api.github.com/repos/ginoledesma/falcon/releases{/id}","created_at":"2015-04-13T13:40:28Z","updated_at":"2015-04-13T13:40:29Z","pushed_at":"2015-04-14T01:57:13Z","git_url":"git://github.com/ginoledesma/falcon.git","ssh_url":"git@github.com:ginoledesma/falcon.git","clone_url":"https://github.com/ginoledesma/falcon.git","svn_url":"https://github.com/ginoledesma/falcon","homepage":"http://falconframework.org","size":11143,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"falconry:master","ref":"master","sha":"62f63a2ec384a804b3005397c4ba54311bd77e06","user":{"login":"falconry","id":11353642,"avatar_url":"https://avatars.githubusercontent.com/u/11353642?v=3","gravatar_id":"","url":"https://api.github.com/users/falconry","html_url":"https://github.com/falconry","followers_url":"https://api.github.com/users/falconry/followers","following_url":"https://api.github.com/users/falconry/following{/other_user}","gists_url":"https://api.github.com/users/falconry/gists{/gist_id}","starred_url":"https://api.github.com/users/falconry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falconry/subscriptions","organizations_url":"https://api.github.com/users/falconry/orgs","repos_url":"https://api.github.com/users/falconry/repos","events_url":"https://api.github.com/users/falconry/events{/privacy}","received_events_url":"https://api.github.com/users/falconry/received_events","type":"Organization","site_admin":false},"repo":{"id":7040500,"name":"falcon","full_name":"falconry/falcon","owner":{"login":"falconry","id":11353642,"avatar_url":"https://avatars.githubusercontent.com/u/11353642?v=3","gravatar_id":"","url":"https://api.github.com/users/falconry","html_url":"https://github.com/falconry","followers_url":"https://api.github.com/users/falconry/followers","following_url":"https://api.github.com/users/falconry/following{/other_user}","gists_url":"https://api.github.com/users/falconry/gists{/gist_id}","starred_url":"https://api.github.com/users/falconry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falconry/subscriptions","organizations_url":"https://api.github.com/users/falconry/orgs","repos_url":"https://api.github.com/users/falconry/repos","events_url":"https://api.github.com/users/falconry/events{/privacy}","received_events_url":"https://api.github.com/users/falconry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/falconry/falcon","description":"Falcon is a high-performance Python framework for building cloud APIs, app backends, and WSGI middleware.","fork":false,"url":"https://api.github.com/repos/falconry/falcon","forks_url":"https://api.github.com/repos/falconry/falcon/forks","keys_url":"https://api.github.com/repos/falconry/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/falconry/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/falconry/falcon/teams","hooks_url":"https://api.github.com/repos/falconry/falcon/hooks","issue_events_url":"https://api.github.com/repos/falconry/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/falconry/falcon/events","assignees_url":"https://api.github.com/repos/falconry/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/falconry/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/falconry/falcon/tags","blobs_url":"https://api.github.com/repos/falconry/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/falconry/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/falconry/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/falconry/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/falconry/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/falconry/falcon/languages","stargazers_url":"https://api.github.com/repos/falconry/falcon/stargazers","contributors_url":"https://api.github.com/repos/falconry/falcon/contributors","subscribers_url":"https://api.github.com/repos/falconry/falcon/subscribers","subscription_url":"https://api.github.com/repos/falconry/falcon/subscription","commits_url":"https://api.github.com/repos/falconry/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/falconry/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/falconry/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/falconry/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/falconry/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/falconry/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/falconry/falcon/merges","archive_url":"https://api.github.com/repos/falconry/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/falconry/falcon/downloads","issues_url":"https://api.github.com/repos/falconry/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/falconry/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/falconry/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/falconry/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/falconry/falcon/labels{/name}","releases_url":"https://api.github.com/repos/falconry/falcon/releases{/id}","created_at":"2012-12-06T18:17:51Z","updated_at":"2015-04-14T21:32:14Z","pushed_at":"2015-04-14T21:52:38Z","git_url":"git://github.com/falconry/falcon.git","ssh_url":"git@github.com:falconry/falcon.git","clone_url":"https://github.com/falconry/falcon.git","svn_url":"https://github.com/falconry/falcon","homepage":"http://falconframework.org","size":14669,"stargazers_count":1572,"watchers_count":1572,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":184,"mirror_url":null,"open_issues_count":167,"forks":184,"open_issues":167,"watchers":1572,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/falconry/falcon/pulls/490"},"html":{"href":"https://github.com/falconry/falcon/pull/490"},"issue":{"href":"https://api.github.com/repos/falconry/falcon/issues/490"},"comments":{"href":"https://api.github.com/repos/falconry/falcon/issues/490/comments"},"review_comments":{"href":"https://api.github.com/repos/falconry/falcon/pulls/490/comments"},"review_comment":{"href":"https://api.github.com/repos/falconry/falcon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/falconry/falcon/pulls/490/commits"},"statuses":{"href":"https://api.github.com/repos/falconry/falcon/statuses/fc35d430c1382b128eaea186c277e9009bc95fe6"}}}}