{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleChrome/webrtc/issues/381","labels_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues/381/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues/381/comments","events_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues/381/events","html_url":"https://github.com/GoogleChrome/webrtc/pull/381","id":54396374,"number":381,"title":"Use params returned from /register call","user":{"login":"chuckhays","id":1405600,"avatar_url":"https://avatars.githubusercontent.com/u/1405600?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckhays","html_url":"https://github.com/chuckhays","followers_url":"https://api.github.com/users/chuckhays/followers","following_url":"https://api.github.com/users/chuckhays/following{/other_user}","gists_url":"https://api.github.com/users/chuckhays/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckhays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckhays/subscriptions","organizations_url":"https://api.github.com/users/chuckhays/orgs","repos_url":"https://api.github.com/users/chuckhays/repos","events_url":"https://api.github.com/users/chuckhays/events{/privacy}","received_events_url":"https://api.github.com/users/chuckhays/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-15T00:16:20Z","updated_at":"2015-01-15T18:29:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/webrtc/pulls/381","html_url":"https://github.com/GoogleChrome/webrtc/pull/381","diff_url":"https://github.com/GoogleChrome/webrtc/pull/381.diff","patch_url":"https://github.com/GoogleChrome/webrtc/pull/381.patch"},"body":"Instead of using a params array from the initial html page, use the params array as returned by the /register/ call.\r\n\r\nThis will enable the Chrome app to get all of its parameters from the server instead of hard coding defaults, without adding any additional endpoints.\r\n\r\nThe most significant piece is that it required re-ordering the sequence of promises in call setup, because we needed the call to /register to happen first, so we had a params array to use in other calls. I did take into account the change today by @jiayliu to the ordering to maintain that change.\r\n\r\nThis step is in preparation for the landing page, and joining a room without requiring navigating to another page. When the browser requests /, the loadingParams can specify connect: false, and we will show the room selection UI. After they select a room, call setup proceeds as before. If the browser navigates directly to /r/#, loadingParams can specify connect: true and the call will be initiated immediately.\r\n\r\n@jiayliu @juberti \r\n"},"comment":{"url":"https://api.github.com/repos/GoogleChrome/webrtc/issues/comments/70135536","html_url":"https://github.com/GoogleChrome/webrtc/pull/381#issuecomment-70135536","issue_url":"https://api.github.com/repos/GoogleChrome/webrtc/issues/381","id":70135536,"user":{"login":"chuckhays","id":1405600,"avatar_url":"https://avatars.githubusercontent.com/u/1405600?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckhays","html_url":"https://github.com/chuckhays","followers_url":"https://api.github.com/users/chuckhays/followers","following_url":"https://api.github.com/users/chuckhays/following{/other_user}","gists_url":"https://api.github.com/users/chuckhays/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckhays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckhays/subscriptions","organizations_url":"https://api.github.com/users/chuckhays/orgs","repos_url":"https://api.github.com/users/chuckhays/repos","events_url":"https://api.github.com/users/chuckhays/events{/privacy}","received_events_url":"https://api.github.com/users/chuckhays/received_events","type":"User","site_admin":false},"created_at":"2015-01-15T18:29:47Z","updated_at":"2015-01-15T18:29:47Z","body":"Updated to do the following:\r\n* Web app gets params in the /r/# page load as before\r\n* Chrome app calls /params during initialization to get params\r\n* Call setup ordering restored to original\r\n\r\n"}}