{"action":"created","issue":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/861","labels_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/861/labels{/name}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/861/comments","events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/861/events","html_url":"https://github.com/The-Compiler/qutebrowser/pull/861","id":99806645,"number":861,"title":"Add a column_widths property to the base class for completion models.","user":{"login":"acogneau","id":1290188,"avatar_url":"https://avatars.githubusercontent.com/u/1290188?v=3","gravatar_id":"","url":"https://api.github.com/users/acogneau","html_url":"https://github.com/acogneau","followers_url":"https://api.github.com/users/acogneau/followers","following_url":"https://api.github.com/users/acogneau/following{/other_user}","gists_url":"https://api.github.com/users/acogneau/gists{/gist_id}","starred_url":"https://api.github.com/users/acogneau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acogneau/subscriptions","organizations_url":"https://api.github.com/users/acogneau/orgs","repos_url":"https://api.github.com/users/acogneau/repos","events_url":"https://api.github.com/users/acogneau/events{/privacy}","received_events_url":"https://api.github.com/users/acogneau/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-08T14:51:01Z","updated_at":"2015-08-08T14:58:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/861","html_url":"https://github.com/The-Compiler/qutebrowser/pull/861","diff_url":"https://github.com/The-Compiler/qutebrowser/pull/861.diff","patch_url":"https://github.com/The-Compiler/qutebrowser/pull/861.patch"},"body":"Could be a start for #693 \r\nThe column widths for the completion widget are now properties of the completion models. The base model reads this list from the configuration (the default is the old (20,70,10)). At the moment only UrlCompletionModel overrides this.\r\n\r\nI also set these value in the constructor of CompletionView to provide some sort of fallback if the model is not loaded yet. But I don't know if that is really necessary.\r\n\r\nShould I write some sort of test for this?"},"comment":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/comments/128988354","html_url":"https://github.com/The-Compiler/qutebrowser/pull/861#issuecomment-128988354","issue_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/861","id":128988354,"user":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"created_at":"2015-08-08T14:58:39Z","updated_at":"2015-08-08T14:58:39Z","body":"You can ignore the AppVeyor issue - seems like sourceforge is being funny again..."}}