{"action":"created","comment":{"url":"https://api.github.com/repos/sass/node-sass/pulls/comments/36587663","id":36587663,"diff_hunk":"@@ -61,52 +61,52 @@ void ExtractOptions(Local<Object> options, void* cptr, sass_context_wrapper* ctx\n     ctx_w->request.data = ctx_w;\n \n     // async (callback) style\n-    Local<Function> success_callback = Local<Function>::Cast(options->Get(NanNew(\"success\")));\n-    Local<Function> error_callback = Local<Function>::Cast(options->Get(NanNew(\"error\")));\n+    v8::Local<v8::Function> success_callback = v8::Local<v8::Function>::Cast(Nan::Get(options, Nan::New(\"success\").ToLocalChecked()).ToLocalChecked());\n+    v8::Local<v8::Function> error_callback = v8::Local<v8::Function>::Cast(Nan::Get(options, Nan::New(\"error\").ToLocalChecked()).ToLocalChecked());\n \n-    ctx_w->success_callback = new NanCallback(success_callback);\n-    ctx_w->error_callback = new NanCallback(error_callback);\n+    ctx_w->success_callback = new Nan::Callback(success_callback);\n+    ctx_w->error_callback = new Nan::Callback(error_callback);\n   }\n \n   if (!is_file) {\n-    ctx_w->file = create_string(options->Get(NanNew(\"file\")));\n+    ctx_w->file = create_string(Nan::Get(options, Nan::New(\"file\").ToLocalChecked()));\n     sass_option_set_input_path(sass_options, ctx_w->file);\n   }\n \n-  int indent_len = options->Get(NanNew(\"indentWidth\"))->Int32Value();\n+  int indent_len = Nan::Get(options, Nan::New(\"indentWidth\").ToLocalChecked()).ToLocalChecked()->Int32Value();\n \n   ctx_w->indent = (char*)malloc(indent_len + 1);\n \n   strcpy(ctx_w->indent, std::string(\n     indent_len,\n-    options->Get(NanNew(\"indentType\"))->Int32Value() == 1 ? '\\t' : ' '\n+    Nan::Get(options, Nan::New(\"indentType\").ToLocalChecked()).ToLocalChecked()->Int32Value() == 1 ? '\\t' : ' '\n     ).c_str());\n \n-  ctx_w->linefeed = create_string(options->Get(NanNew(\"linefeed\")));\n-  ctx_w->include_path = create_string(options->Get(NanNew(\"includePaths\")));\n-  ctx_w->out_file = create_string(options->Get(NanNew(\"outFile\")));\n-  ctx_w->source_map = create_string(options->Get(NanNew(\"sourceMap\")));\n-  ctx_w->source_map_root = create_string(options->Get(NanNew(\"sourceMapRoot\")));\n+  ctx_w->linefeed = create_string(Nan::Get(options, Nan::New(\"linefeed\").ToLocalChecked()));\n+  ctx_w->include_path = create_string(Nan::Get(options, Nan::New(\"includePaths\").ToLocalChecked()));\n+  ctx_w->out_file = create_string(Nan::Get(options, Nan::New(\"outFile\").ToLocalChecked()));\n+  ctx_w->source_map = create_string(Nan::Get(options, Nan::New(\"sourceMap\").ToLocalChecked()));\n+  ctx_w->source_map_root = create_string(Nan::Get(options, Nan::New(\"sourceMapRoot\").ToLocalChecked()));\n \n   sass_option_set_output_path(sass_options, ctx_w->out_file);\n-  sass_option_set_output_style(sass_options, (Sass_Output_Style)options->Get(NanNew(\"style\"))->Int32Value());\n-  sass_option_set_is_indented_syntax_src(sass_options, options->Get(NanNew(\"indentedSyntax\"))->BooleanValue());\n-  sass_option_set_source_comments(sass_options, options->Get(NanNew(\"sourceComments\"))->BooleanValue());\n-  sass_option_set_omit_source_map_url(sass_options, options->Get(NanNew(\"omitSourceMapUrl\"))->BooleanValue());\n-  sass_option_set_source_map_embed(sass_options, options->Get(NanNew(\"sourceMapEmbed\"))->BooleanValue());\n-  sass_option_set_source_map_contents(sass_options, options->Get(NanNew(\"sourceMapContents\"))->BooleanValue());\n+  sass_option_set_output_style(sass_options, (Sass_Output_Style)Nan::Get(options, Nan::New(\"style\").ToLocalChecked()).ToLocalChecked()->Int32Value());\n+  sass_option_set_is_indented_syntax_src(sass_options, Nan::Get(options, Nan::New(\"indentedSyntax\").ToLocalChecked()).ToLocalChecked()->BooleanValue());\n+  sass_option_set_source_comments(sass_options, Nan::Get(options, Nan::New(\"sourceComments\").ToLocalChecked()).ToLocalChecked()->BooleanValue());\n+  sass_option_set_omit_source_map_url(sass_options, Nan::Get(options, Nan::New(\"omitSourceMapUrl\").ToLocalChecked()).ToLocalChecked()->BooleanValue());\n+  sass_option_set_source_map_embed(sass_options, Nan::Get(options, Nan::New(\"sourceMapEmbed\").ToLocalChecked()).ToLocalChecked()->BooleanValue());\n+  sass_option_set_source_map_contents(sass_options, Nan::Get(options, Nan::New(\"sourceMapContents\").ToLocalChecked()).ToLocalChecked()->BooleanValue());","path":"src/binding.cpp","position":71,"original_position":71,"commit_id":"d96ad377f9fc4f82c569d29b59b38b7ec1d0d5b2","original_commit_id":"d96ad377f9fc4f82c569d29b59b38b7ec1d0d5b2","user":{"login":"kkoopa","id":4103081,"avatar_url":"https://avatars.githubusercontent.com/u/4103081?v=3","gravatar_id":"","url":"https://api.github.com/users/kkoopa","html_url":"https://github.com/kkoopa","followers_url":"https://api.github.com/users/kkoopa/followers","following_url":"https://api.github.com/users/kkoopa/following{/other_user}","gists_url":"https://api.github.com/users/kkoopa/gists{/gist_id}","starred_url":"https://api.github.com/users/kkoopa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkoopa/subscriptions","organizations_url":"https://api.github.com/users/kkoopa/orgs","repos_url":"https://api.github.com/users/kkoopa/repos","events_url":"https://api.github.com/users/kkoopa/events{/privacy}","received_events_url":"https://api.github.com/users/kkoopa/received_events","type":"User","site_admin":false},"body":"I'll stop commenting on these now.","created_at":"2015-08-09T12:59:27Z","updated_at":"2015-08-09T12:59:27Z","html_url":"https://github.com/sass/node-sass/pull/1054#discussion_r36587663","pull_request_url":"https://api.github.com/repos/sass/node-sass/pulls/1054","_links":{"self":{"href":"https://api.github.com/repos/sass/node-sass/pulls/comments/36587663"},"html":{"href":"https://github.com/sass/node-sass/pull/1054#discussion_r36587663"},"pull_request":{"href":"https://api.github.com/repos/sass/node-sass/pulls/1054"}}},"pull_request":{"url":"https://api.github.com/repos/sass/node-sass/pulls/1054","id":41717340,"html_url":"https://github.com/sass/node-sass/pull/1054","diff_url":"https://github.com/sass/node-sass/pull/1054.diff","patch_url":"https://github.com/sass/node-sass/pull/1054.patch","issue_url":"https://api.github.com/repos/sass/node-sass/issues/1054","number":1054,"state":"open","locked":false,"title":"Update bindings for io.js 3.0.0","user":{"login":"saper","id":248374,"avatar_url":"https://avatars.githubusercontent.com/u/248374?v=3","gravatar_id":"","url":"https://api.github.com/users/saper","html_url":"https://github.com/saper","followers_url":"https://api.github.com/users/saper/followers","following_url":"https://api.github.com/users/saper/following{/other_user}","gists_url":"https://api.github.com/users/saper/gists{/gist_id}","starred_url":"https://api.github.com/users/saper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saper/subscriptions","organizations_url":"https://api.github.com/users/saper/orgs","repos_url":"https://api.github.com/users/saper/repos","events_url":"https://api.github.com/users/saper/events{/privacy}","received_events_url":"https://api.github.com/users/saper/received_events","type":"User","site_admin":false},"body":"## Update to io.js 3.0.0, use nan 2.0\r\n\r\nThe code has been updated to meet\r\nthe requirements of the updated V8 engine\r\nas provided by io.js.\r\n\r\nIn some cases additional `EscapableHandleScope`\r\nhas been provided.\r\n\r\n`SassValueWrapper<T>::New` has been changed:\r\nin case of instance construction via\r\nthe function call `sass.types.Color(0,0,0)` \r\n(actually incorrect JavaScript...)\r\ninstead of `new sass.types.Color(0,0,0)`\r\nthe `new` part is no longer executed by\r\nfalling through. This should not be necessary\r\nbecause the constructor is called by\r\nthe `NewInstance` call anyway.\r\n\r\nThis fixes the following error:\r\n\r\n    FATAL ERROR: v8::Object::SetAlignedPointerInInternalField() Internal field out of bounds","created_at":"2015-08-05T19:38:06Z","updated_at":"2015-08-09T12:59:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"207bd4f41e7a92b7942b27210c8888641326ed16","assignee":null,"milestone":{"url":"https://api.github.com/repos/sass/node-sass/milestones/7","html_url":"https://github.com/sass/node-sass/milestones/next.minor","labels_url":"https://api.github.com/repos/sass/node-sass/milestones/7/labels","id":1087616,"number":7,"title":"next.minor","description":"This milestone tracks issues and PRs for the upcoming minor release.\r\n\r\nThis is used for prioritisation and tracking release notes.","creator":{"login":"xzyfer","id":579928,"avatar_url":"https://avatars.githubusercontent.com/u/579928?v=3","gravatar_id":"","url":"https://api.github.com/users/xzyfer","html_url":"https://github.com/xzyfer","followers_url":"https://api.github.com/users/xzyfer/followers","following_url":"https://api.github.com/users/xzyfer/following{/other_user}","gists_url":"https://api.github.com/users/xzyfer/gists{/gist_id}","starred_url":"https://api.github.com/users/xzyfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xzyfer/subscriptions","organizations_url":"https://api.github.com/users/xzyfer/orgs","repos_url":"https://api.github.com/users/xzyfer/repos","events_url":"https://api.github.com/users/xzyfer/events{/privacy}","received_events_url":"https://api.github.com/users/xzyfer/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":1,"state":"open","created_at":"2015-04-28T14:47:29Z","updated_at":"2015-08-08T03:41:52Z","due_on":"2015-05-30T14:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/sass/node-sass/pulls/1054/commits","review_comments_url":"https://api.github.com/repos/sass/node-sass/pulls/1054/comments","review_comment_url":"https://api.github.com/repos/sass/node-sass/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sass/node-sass/issues/1054/comments","statuses_url":"https://api.github.com/repos/sass/node-sass/statuses/d96ad377f9fc4f82c569d29b59b38b7ec1d0d5b2","head":{"label":"saper:iojs45","ref":"iojs45","sha":"d96ad377f9fc4f82c569d29b59b38b7ec1d0d5b2","user":{"login":"saper","id":248374,"avatar_url":"https://avatars.githubusercontent.com/u/248374?v=3","gravatar_id":"","url":"https://api.github.com/users/saper","html_url":"https://github.com/saper","followers_url":"https://api.github.com/users/saper/followers","following_url":"https://api.github.com/users/saper/following{/other_user}","gists_url":"https://api.github.com/users/saper/gists{/gist_id}","starred_url":"https://api.github.com/users/saper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saper/subscriptions","organizations_url":"https://api.github.com/users/saper/orgs","repos_url":"https://api.github.com/users/saper/repos","events_url":"https://api.github.com/users/saper/events{/privacy}","received_events_url":"https://api.github.com/users/saper/received_events","type":"User","site_admin":false},"repo":{"id":31617984,"name":"node-sass","full_name":"saper/node-sass","owner":{"login":"saper","id":248374,"avatar_url":"https://avatars.githubusercontent.com/u/248374?v=3","gravatar_id":"","url":"https://api.github.com/users/saper","html_url":"https://github.com/saper","followers_url":"https://api.github.com/users/saper/followers","following_url":"https://api.github.com/users/saper/following{/other_user}","gists_url":"https://api.github.com/users/saper/gists{/gist_id}","starred_url":"https://api.github.com/users/saper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saper/subscriptions","organizations_url":"https://api.github.com/users/saper/orgs","repos_url":"https://api.github.com/users/saper/repos","events_url":"https://api.github.com/users/saper/events{/privacy}","received_events_url":"https://api.github.com/users/saper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saper/node-sass","description":":rainbow: Node.js bindings to libsass","fork":true,"url":"https://api.github.com/repos/saper/node-sass","forks_url":"https://api.github.com/repos/saper/node-sass/forks","keys_url":"https://api.github.com/repos/saper/node-sass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saper/node-sass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saper/node-sass/teams","hooks_url":"https://api.github.com/repos/saper/node-sass/hooks","issue_events_url":"https://api.github.com/repos/saper/node-sass/issues/events{/number}","events_url":"https://api.github.com/repos/saper/node-sass/events","assignees_url":"https://api.github.com/repos/saper/node-sass/assignees{/user}","branches_url":"https://api.github.com/repos/saper/node-sass/branches{/branch}","tags_url":"https://api.github.com/repos/saper/node-sass/tags","blobs_url":"https://api.github.com/repos/saper/node-sass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saper/node-sass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saper/node-sass/git/refs{/sha}","trees_url":"https://api.github.com/repos/saper/node-sass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saper/node-sass/statuses/{sha}","languages_url":"https://api.github.com/repos/saper/node-sass/languages","stargazers_url":"https://api.github.com/repos/saper/node-sass/stargazers","contributors_url":"https://api.github.com/repos/saper/node-sass/contributors","subscribers_url":"https://api.github.com/repos/saper/node-sass/subscribers","subscription_url":"https://api.github.com/repos/saper/node-sass/subscription","commits_url":"https://api.github.com/repos/saper/node-sass/commits{/sha}","git_commits_url":"https://api.github.com/repos/saper/node-sass/git/commits{/sha}","comments_url":"https://api.github.com/repos/saper/node-sass/comments{/number}","issue_comment_url":"https://api.github.com/repos/saper/node-sass/issues/comments{/number}","contents_url":"https://api.github.com/repos/saper/node-sass/contents/{+path}","compare_url":"https://api.github.com/repos/saper/node-sass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saper/node-sass/merges","archive_url":"https://api.github.com/repos/saper/node-sass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saper/node-sass/downloads","issues_url":"https://api.github.com/repos/saper/node-sass/issues{/number}","pulls_url":"https://api.github.com/repos/saper/node-sass/pulls{/number}","milestones_url":"https://api.github.com/repos/saper/node-sass/milestones{/number}","notifications_url":"https://api.github.com/repos/saper/node-sass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saper/node-sass/labels{/name}","releases_url":"https://api.github.com/repos/saper/node-sass/releases{/id}","created_at":"2015-03-03T19:52:17Z","updated_at":"2015-05-08T09:01:05Z","pushed_at":"2015-08-08T02:35:25Z","git_url":"git://github.com/saper/node-sass.git","ssh_url":"git@github.com:saper/node-sass.git","clone_url":"https://github.com/saper/node-sass.git","svn_url":"https://github.com/saper/node-sass","homepage":"https://npmjs.org/package/node-sass","size":15390,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sass:master","ref":"master","sha":"34db870992bcae17de30dd0e1f0fd8ddb4bcc363","user":{"login":"sass","id":317889,"avatar_url":"https://avatars.githubusercontent.com/u/317889?v=3","gravatar_id":"","url":"https://api.github.com/users/sass","html_url":"https://github.com/sass","followers_url":"https://api.github.com/users/sass/followers","following_url":"https://api.github.com/users/sass/following{/other_user}","gists_url":"https://api.github.com/users/sass/gists{/gist_id}","starred_url":"https://api.github.com/users/sass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sass/subscriptions","organizations_url":"https://api.github.com/users/sass/orgs","repos_url":"https://api.github.com/users/sass/repos","events_url":"https://api.github.com/users/sass/events{/privacy}","received_events_url":"https://api.github.com/users/sass/received_events","type":"Organization","site_admin":false},"repo":{"id":4128353,"name":"node-sass","full_name":"sass/node-sass","owner":{"login":"sass","id":317889,"avatar_url":"https://avatars.githubusercontent.com/u/317889?v=3","gravatar_id":"","url":"https://api.github.com/users/sass","html_url":"https://github.com/sass","followers_url":"https://api.github.com/users/sass/followers","following_url":"https://api.github.com/users/sass/following{/other_user}","gists_url":"https://api.github.com/users/sass/gists{/gist_id}","starred_url":"https://api.github.com/users/sass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sass/subscriptions","organizations_url":"https://api.github.com/users/sass/orgs","repos_url":"https://api.github.com/users/sass/repos","events_url":"https://api.github.com/users/sass/events{/privacy}","received_events_url":"https://api.github.com/users/sass/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sass/node-sass","description":":rainbow: Node.js bindings to libsass","fork":false,"url":"https://api.github.com/repos/sass/node-sass","forks_url":"https://api.github.com/repos/sass/node-sass/forks","keys_url":"https://api.github.com/repos/sass/node-sass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sass/node-sass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sass/node-sass/teams","hooks_url":"https://api.github.com/repos/sass/node-sass/hooks","issue_events_url":"https://api.github.com/repos/sass/node-sass/issues/events{/number}","events_url":"https://api.github.com/repos/sass/node-sass/events","assignees_url":"https://api.github.com/repos/sass/node-sass/assignees{/user}","branches_url":"https://api.github.com/repos/sass/node-sass/branches{/branch}","tags_url":"https://api.github.com/repos/sass/node-sass/tags","blobs_url":"https://api.github.com/repos/sass/node-sass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sass/node-sass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sass/node-sass/git/refs{/sha}","trees_url":"https://api.github.com/repos/sass/node-sass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sass/node-sass/statuses/{sha}","languages_url":"https://api.github.com/repos/sass/node-sass/languages","stargazers_url":"https://api.github.com/repos/sass/node-sass/stargazers","contributors_url":"https://api.github.com/repos/sass/node-sass/contributors","subscribers_url":"https://api.github.com/repos/sass/node-sass/subscribers","subscription_url":"https://api.github.com/repos/sass/node-sass/subscription","commits_url":"https://api.github.com/repos/sass/node-sass/commits{/sha}","git_commits_url":"https://api.github.com/repos/sass/node-sass/git/commits{/sha}","comments_url":"https://api.github.com/repos/sass/node-sass/comments{/number}","issue_comment_url":"https://api.github.com/repos/sass/node-sass/issues/comments{/number}","contents_url":"https://api.github.com/repos/sass/node-sass/contents/{+path}","compare_url":"https://api.github.com/repos/sass/node-sass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sass/node-sass/merges","archive_url":"https://api.github.com/repos/sass/node-sass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sass/node-sass/downloads","issues_url":"https://api.github.com/repos/sass/node-sass/issues{/number}","pulls_url":"https://api.github.com/repos/sass/node-sass/pulls{/number}","milestones_url":"https://api.github.com/repos/sass/node-sass/milestones{/number}","notifications_url":"https://api.github.com/repos/sass/node-sass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sass/node-sass/labels{/name}","releases_url":"https://api.github.com/repos/sass/node-sass/releases{/id}","created_at":"2012-04-24T18:46:30Z","updated_at":"2015-08-09T02:54:49Z","pushed_at":"2015-08-08T02:35:26Z","git_url":"git://github.com/sass/node-sass.git","ssh_url":"git@github.com:sass/node-sass.git","clone_url":"https://github.com/sass/node-sass.git","svn_url":"https://github.com/sass/node-sass","homepage":"https://npmjs.org/package/node-sass","size":18155,"stargazers_count":1901,"watchers_count":1901,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":254,"mirror_url":null,"open_issues_count":60,"forks":254,"open_issues":60,"watchers":1901,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sass/node-sass/pulls/1054"},"html":{"href":"https://github.com/sass/node-sass/pull/1054"},"issue":{"href":"https://api.github.com/repos/sass/node-sass/issues/1054"},"comments":{"href":"https://api.github.com/repos/sass/node-sass/issues/1054/comments"},"review_comments":{"href":"https://api.github.com/repos/sass/node-sass/pulls/1054/comments"},"review_comment":{"href":"https://api.github.com/repos/sass/node-sass/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sass/node-sass/pulls/1054/commits"},"statuses":{"href":"https://api.github.com/repos/sass/node-sass/statuses/d96ad377f9fc4f82c569d29b59b38b7ec1d0d5b2"}}}}