{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/45349849","id":45349849,"diff_hunk":"@@ -19,6 +19,8 @@ cat \"${OS_ROOT}/Dockerfile\" | oc new-build -D - --name=test\n oc get bc/test\n oc new-build --dockerfile=$'FROM centos:7\\nRUN yum install -y httpd'\n oc get bc/centos\n+oc new-build -D $'FROM openshift/origin:v1.1' --to-docker\n+[[ $(oc get bc/origin --template '{{with .spec.output.to}}{{.kind}} {{.name}}{{end}}') == \"DockerImage openshift/origin:latest\" ]]","path":"test/cmd/builds.sh","position":5,"original_position":5,"commit_id":"eed3d203359bd9eddce7b97caef99a55750a3f90","original_commit_id":"eed3d203359bd9eddce7b97caef99a55750a3f90","user":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars.githubusercontent.com/u/88819?v=3","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"body":"@bparees could you please validate this test case?\r\n\r\nToday the outcome of `oc new-build -D $'FROM openshift/origin:v1.1' --to-docker` would output to `origin:latest`, but IMHO that's wrong. WDYT?","created_at":"2015-11-19T14:55:19Z","updated_at":"2015-11-19T14:55:19Z","html_url":"https://github.com/openshift/origin/pull/5948#discussion_r45349849","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/5948","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/45349849"},"html":{"href":"https://github.com/openshift/origin/pull/5948#discussion_r45349849"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/5948"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/5948","id":51107177,"html_url":"https://github.com/openshift/origin/pull/5948","diff_url":"https://github.com/openshift/origin/pull/5948.diff","patch_url":"https://github.com/openshift/origin/pull/5948.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/5948","number":5948,"state":"open","locked":false,"title":"Fix --to-docker missing namespace bug","user":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars.githubusercontent.com/u/88819?v=3","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"body":"`oc new-build <source> --to-docker` incorrectly removed the namespace\r\npart of the Docker image reference, eventually causing builds to push to\r\nthe wrong spec.","created_at":"2015-11-18T16:30:12Z","updated_at":"2015-11-19T14:55:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42672d22d5ba92e4b9fc8a9e9bfe742fc8a419b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/5948/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/5948/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/5948/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/eed3d203359bd9eddce7b97caef99a55750a3f90","head":{"label":"rhcarvalho:to-docker-missing-namespace","ref":"to-docker-missing-namespace","sha":"eed3d203359bd9eddce7b97caef99a55750a3f90","user":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars.githubusercontent.com/u/88819?v=3","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"repo":{"id":30794668,"name":"origin","full_name":"rhcarvalho/origin","owner":{"login":"rhcarvalho","id":88819,"avatar_url":"https://avatars.githubusercontent.com/u/88819?v=3","gravatar_id":"","url":"https://api.github.com/users/rhcarvalho","html_url":"https://github.com/rhcarvalho","followers_url":"https://api.github.com/users/rhcarvalho/followers","following_url":"https://api.github.com/users/rhcarvalho/following{/other_user}","gists_url":"https://api.github.com/users/rhcarvalho/gists{/gist_id}","starred_url":"https://api.github.com/users/rhcarvalho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhcarvalho/subscriptions","organizations_url":"https://api.github.com/users/rhcarvalho/orgs","repos_url":"https://api.github.com/users/rhcarvalho/repos","events_url":"https://api.github.com/users/rhcarvalho/events{/privacy}","received_events_url":"https://api.github.com/users/rhcarvalho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhcarvalho/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/rhcarvalho/origin","forks_url":"https://api.github.com/repos/rhcarvalho/origin/forks","keys_url":"https://api.github.com/repos/rhcarvalho/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhcarvalho/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhcarvalho/origin/teams","hooks_url":"https://api.github.com/repos/rhcarvalho/origin/hooks","issue_events_url":"https://api.github.com/repos/rhcarvalho/origin/issues/events{/number}","events_url":"https://api.github.com/repos/rhcarvalho/origin/events","assignees_url":"https://api.github.com/repos/rhcarvalho/origin/assignees{/user}","branches_url":"https://api.github.com/repos/rhcarvalho/origin/branches{/branch}","tags_url":"https://api.github.com/repos/rhcarvalho/origin/tags","blobs_url":"https://api.github.com/repos/rhcarvalho/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhcarvalho/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhcarvalho/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhcarvalho/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhcarvalho/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/rhcarvalho/origin/languages","stargazers_url":"https://api.github.com/repos/rhcarvalho/origin/stargazers","contributors_url":"https://api.github.com/repos/rhcarvalho/origin/contributors","subscribers_url":"https://api.github.com/repos/rhcarvalho/origin/subscribers","subscription_url":"https://api.github.com/repos/rhcarvalho/origin/subscription","commits_url":"https://api.github.com/repos/rhcarvalho/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhcarvalho/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhcarvalho/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhcarvalho/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhcarvalho/origin/contents/{+path}","compare_url":"https://api.github.com/repos/rhcarvalho/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhcarvalho/origin/merges","archive_url":"https://api.github.com/repos/rhcarvalho/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhcarvalho/origin/downloads","issues_url":"https://api.github.com/repos/rhcarvalho/origin/issues{/number}","pulls_url":"https://api.github.com/repos/rhcarvalho/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/rhcarvalho/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/rhcarvalho/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhcarvalho/origin/labels{/name}","releases_url":"https://api.github.com/repos/rhcarvalho/origin/releases{/id}","created_at":"2015-02-14T11:22:53Z","updated_at":"2015-04-29T10:04:56Z","pushed_at":"2015-11-19T14:50:34Z","git_url":"git://github.com/rhcarvalho/origin.git","ssh_url":"git@github.com:rhcarvalho/origin.git","clone_url":"https://github.com/rhcarvalho/origin.git","svn_url":"https://github.com/rhcarvalho/origin","homepage":"https://openshift.github.io","size":177812,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"5e353c06e32ffd0cc03206f930bdcd5e1d5123ac","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-11-19T12:42:52Z","pushed_at":"2015-11-19T14:50:35Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":226494,"stargazers_count":815,"watchers_count":815,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":509,"mirror_url":null,"open_issues_count":680,"forks":509,"open_issues":680,"watchers":815,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/5948"},"html":{"href":"https://github.com/openshift/origin/pull/5948"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/5948"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/5948/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/5948/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/5948/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/eed3d203359bd9eddce7b97caef99a55750a3f90"}}}}