{"comment":{"url":"https://api.github.com/repos/kripken/emscripten/comments/13331704","html_url":"https://github.com/kripken/emscripten/commit/4637acbf1c18dd910777ebb2f31587a66e10f65d#commitcomment-13331704","id":13331704,"user":{"login":"juj","id":225351,"avatar_url":"https://avatars.githubusercontent.com/u/225351?v=3","gravatar_id":"","url":"https://api.github.com/users/juj","html_url":"https://github.com/juj","followers_url":"https://api.github.com/users/juj/followers","following_url":"https://api.github.com/users/juj/following{/other_user}","gists_url":"https://api.github.com/users/juj/gists{/gist_id}","starred_url":"https://api.github.com/users/juj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juj/subscriptions","organizations_url":"https://api.github.com/users/juj/orgs","repos_url":"https://api.github.com/users/juj/repos","events_url":"https://api.github.com/users/juj/events{/privacy}","received_events_url":"https://api.github.com/users/juj/received_events","type":"User","site_admin":false},"position":12,"line":17,"path":"tests/core/test_emscripten_api.in","commit_id":"4637acbf1c18dd910777ebb2f31587a66e10f65d","created_at":"2015-09-20T20:45:35Z","updated_at":"2015-09-20T20:45:35Z","body":"The `max` field only signals how many bytes at most `emscripten_print_double` is allowed to write out to the passed string buffer. I don't think anyone will ever allocate a single >2GB string to serve as the output space in a call to this function (considering that a double needs only at most ~20 characters to be uniquely represented as a string), but someone might easily make a mistake of having some computation pass a negative length here, which could result in a write overrun?"}}