{"action":"created","comment":{"url":"https://api.github.com/repos/bndtools/bndtools/pulls/comments/47560608","id":47560608,"diff_hunk":"@@ -257,8 +259,8 @@ private void doAddBundle() {\n             WizardDialog dialog = new WizardDialog(getSection().getShell(), wizard);\n \n             if (Window.OK == dialog.open()) {\n-                List<VersionedClause> result = wizard.getSelectedBundles();\n-                List<Requirement> adding = new ArrayList<Requirement>(result.size());\n+                final List<VersionedClause> result = wizard.getSelectedBundles();\n+                final List<Requirement> adding = new ArrayList<Requirement>(result.size());","path":"bndtools.core/src/bndtools/editor/project/RunRequirementsPart.java","position":23,"original_position":23,"commit_id":"bba5ffaca9cff8597df961ed6c2341b2deae37f2","original_commit_id":"bba5ffaca9cff8597df961ed6c2341b2deae37f2","user":{"login":"bjhargrave","id":277682,"avatar_url":"https://avatars.githubusercontent.com/u/277682?v=3","gravatar_id":"","url":"https://api.github.com/users/bjhargrave","html_url":"https://github.com/bjhargrave","followers_url":"https://api.github.com/users/bjhargrave/followers","following_url":"https://api.github.com/users/bjhargrave/following{/other_user}","gists_url":"https://api.github.com/users/bjhargrave/gists{/gist_id}","starred_url":"https://api.github.com/users/bjhargrave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjhargrave/subscriptions","organizations_url":"https://api.github.com/users/bjhargrave/orgs","repos_url":"https://api.github.com/users/bjhargrave/repos","events_url":"https://api.github.com/users/bjhargrave/events{/privacy}","received_events_url":"https://api.github.com/users/bjhargrave/received_events","type":"User","site_admin":false},"body":"Just do `adding.removeAll(requires)` to remove any existing requirements before the empty check. Then the editor will only be marked dirty if there are new requirements being added.","created_at":"2015-12-14T21:28:56Z","updated_at":"2015-12-14T21:28:56Z","html_url":"https://github.com/bndtools/bndtools/pull/1223#discussion_r47560608","pull_request_url":"https://api.github.com/repos/bndtools/bndtools/pulls/1223","_links":{"self":{"href":"https://api.github.com/repos/bndtools/bndtools/pulls/comments/47560608"},"html":{"href":"https://github.com/bndtools/bndtools/pull/1223#discussion_r47560608"},"pull_request":{"href":"https://api.github.com/repos/bndtools/bndtools/pulls/1223"}}},"pull_request":{"url":"https://api.github.com/repos/bndtools/bndtools/pulls/1223","id":51463951,"html_url":"https://github.com/bndtools/bndtools/pull/1223","diff_url":"https://github.com/bndtools/bndtools/pull/1223.diff","patch_url":"https://github.com/bndtools/bndtools/pull/1223.patch","issue_url":"https://api.github.com/repos/bndtools/bndtools/issues/1223","number":1223,"state":"open","locked":false,"title":"796: Run Requirements: don't allow duplicates","user":{"login":"lostiniceland","id":1516116,"avatar_url":"https://avatars.githubusercontent.com/u/1516116?v=3","gravatar_id":"","url":"https://api.github.com/users/lostiniceland","html_url":"https://github.com/lostiniceland","followers_url":"https://api.github.com/users/lostiniceland/followers","following_url":"https://api.github.com/users/lostiniceland/following{/other_user}","gists_url":"https://api.github.com/users/lostiniceland/gists{/gist_id}","starred_url":"https://api.github.com/users/lostiniceland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostiniceland/subscriptions","organizations_url":"https://api.github.com/users/lostiniceland/orgs","repos_url":"https://api.github.com/users/lostiniceland/repos","events_url":"https://api.github.com/users/lostiniceland/events{/privacy}","received_events_url":"https://api.github.com/users/lostiniceland/received_events","type":"User","site_admin":false},"body":"Requirements are checked with \"equals\" provided by BND. \r\nIgnored Requirements are displayed as information-message.\r\n\r\nSigned-off-by: Marc Schlegel <maschlegel@gmail.com>","created_at":"2015-11-22T12:41:32Z","updated_at":"2015-12-14T21:28:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8db08c2c4261f859d2be04dd56308c736b13822e","assignee":{"login":"njbartlett","id":6366,"avatar_url":"https://avatars.githubusercontent.com/u/6366?v=3","gravatar_id":"","url":"https://api.github.com/users/njbartlett","html_url":"https://github.com/njbartlett","followers_url":"https://api.github.com/users/njbartlett/followers","following_url":"https://api.github.com/users/njbartlett/following{/other_user}","gists_url":"https://api.github.com/users/njbartlett/gists{/gist_id}","starred_url":"https://api.github.com/users/njbartlett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njbartlett/subscriptions","organizations_url":"https://api.github.com/users/njbartlett/orgs","repos_url":"https://api.github.com/users/njbartlett/repos","events_url":"https://api.github.com/users/njbartlett/events{/privacy}","received_events_url":"https://api.github.com/users/njbartlett/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/bndtools/bndtools/milestones/14","html_url":"https://github.com/bndtools/bndtools/milestones/3.1","labels_url":"https://api.github.com/repos/bndtools/bndtools/milestones/14/labels","id":1092714,"number":14,"title":"3.1","description":"3.1.0.REL","creator":{"login":"bjhargrave","id":277682,"avatar_url":"https://avatars.githubusercontent.com/u/277682?v=3","gravatar_id":"","url":"https://api.github.com/users/bjhargrave","html_url":"https://github.com/bjhargrave","followers_url":"https://api.github.com/users/bjhargrave/followers","following_url":"https://api.github.com/users/bjhargrave/following{/other_user}","gists_url":"https://api.github.com/users/bjhargrave/gists{/gist_id}","starred_url":"https://api.github.com/users/bjhargrave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjhargrave/subscriptions","organizations_url":"https://api.github.com/users/bjhargrave/orgs","repos_url":"https://api.github.com/users/bjhargrave/repos","events_url":"https://api.github.com/users/bjhargrave/events{/privacy}","received_events_url":"https://api.github.com/users/bjhargrave/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":64,"state":"open","created_at":"2015-05-01T16:43:20Z","updated_at":"2015-12-11T23:24:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/bndtools/bndtools/pulls/1223/commits","review_comments_url":"https://api.github.com/repos/bndtools/bndtools/pulls/1223/comments","review_comment_url":"https://api.github.com/repos/bndtools/bndtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bndtools/bndtools/issues/1223/comments","statuses_url":"https://api.github.com/repos/bndtools/bndtools/statuses/bba5ffaca9cff8597df961ed6c2341b2deae37f2","head":{"label":"lostiniceland:796-runrequirement-without-duplicates","ref":"796-runrequirement-without-duplicates","sha":"bba5ffaca9cff8597df961ed6c2341b2deae37f2","user":{"login":"lostiniceland","id":1516116,"avatar_url":"https://avatars.githubusercontent.com/u/1516116?v=3","gravatar_id":"","url":"https://api.github.com/users/lostiniceland","html_url":"https://github.com/lostiniceland","followers_url":"https://api.github.com/users/lostiniceland/followers","following_url":"https://api.github.com/users/lostiniceland/following{/other_user}","gists_url":"https://api.github.com/users/lostiniceland/gists{/gist_id}","starred_url":"https://api.github.com/users/lostiniceland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostiniceland/subscriptions","organizations_url":"https://api.github.com/users/lostiniceland/orgs","repos_url":"https://api.github.com/users/lostiniceland/repos","events_url":"https://api.github.com/users/lostiniceland/events{/privacy}","received_events_url":"https://api.github.com/users/lostiniceland/received_events","type":"User","site_admin":false},"repo":{"id":32923250,"name":"bndtools","full_name":"lostiniceland/bndtools","owner":{"login":"lostiniceland","id":1516116,"avatar_url":"https://avatars.githubusercontent.com/u/1516116?v=3","gravatar_id":"","url":"https://api.github.com/users/lostiniceland","html_url":"https://github.com/lostiniceland","followers_url":"https://api.github.com/users/lostiniceland/followers","following_url":"https://api.github.com/users/lostiniceland/following{/other_user}","gists_url":"https://api.github.com/users/lostiniceland/gists{/gist_id}","starred_url":"https://api.github.com/users/lostiniceland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lostiniceland/subscriptions","organizations_url":"https://api.github.com/users/lostiniceland/orgs","repos_url":"https://api.github.com/users/lostiniceland/repos","events_url":"https://api.github.com/users/lostiniceland/events{/privacy}","received_events_url":"https://api.github.com/users/lostiniceland/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lostiniceland/bndtools","description":"Eclipse tools for developing OSGi bundles","fork":true,"url":"https://api.github.com/repos/lostiniceland/bndtools","forks_url":"https://api.github.com/repos/lostiniceland/bndtools/forks","keys_url":"https://api.github.com/repos/lostiniceland/bndtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lostiniceland/bndtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lostiniceland/bndtools/teams","hooks_url":"https://api.github.com/repos/lostiniceland/bndtools/hooks","issue_events_url":"https://api.github.com/repos/lostiniceland/bndtools/issues/events{/number}","events_url":"https://api.github.com/repos/lostiniceland/bndtools/events","assignees_url":"https://api.github.com/repos/lostiniceland/bndtools/assignees{/user}","branches_url":"https://api.github.com/repos/lostiniceland/bndtools/branches{/branch}","tags_url":"https://api.github.com/repos/lostiniceland/bndtools/tags","blobs_url":"https://api.github.com/repos/lostiniceland/bndtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lostiniceland/bndtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lostiniceland/bndtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/lostiniceland/bndtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lostiniceland/bndtools/statuses/{sha}","languages_url":"https://api.github.com/repos/lostiniceland/bndtools/languages","stargazers_url":"https://api.github.com/repos/lostiniceland/bndtools/stargazers","contributors_url":"https://api.github.com/repos/lostiniceland/bndtools/contributors","subscribers_url":"https://api.github.com/repos/lostiniceland/bndtools/subscribers","subscription_url":"https://api.github.com/repos/lostiniceland/bndtools/subscription","commits_url":"https://api.github.com/repos/lostiniceland/bndtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/lostiniceland/bndtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/lostiniceland/bndtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/lostiniceland/bndtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/lostiniceland/bndtools/contents/{+path}","compare_url":"https://api.github.com/repos/lostiniceland/bndtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lostiniceland/bndtools/merges","archive_url":"https://api.github.com/repos/lostiniceland/bndtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lostiniceland/bndtools/downloads","issues_url":"https://api.github.com/repos/lostiniceland/bndtools/issues{/number}","pulls_url":"https://api.github.com/repos/lostiniceland/bndtools/pulls{/number}","milestones_url":"https://api.github.com/repos/lostiniceland/bndtools/milestones{/number}","notifications_url":"https://api.github.com/repos/lostiniceland/bndtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lostiniceland/bndtools/labels{/name}","releases_url":"https://api.github.com/repos/lostiniceland/bndtools/releases{/id}","created_at":"2015-03-26T11:24:01Z","updated_at":"2015-03-26T11:24:05Z","pushed_at":"2015-12-14T21:08:36Z","git_url":"git://github.com/lostiniceland/bndtools.git","ssh_url":"git@github.com:lostiniceland/bndtools.git","clone_url":"https://github.com/lostiniceland/bndtools.git","svn_url":"https://github.com/lostiniceland/bndtools","homepage":"http://bndtools.org","size":418978,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bndtools:master","ref":"master","sha":"a43befb8a175c1a5a0e33ec513ae796d6878640d","user":{"login":"bndtools","id":1130828,"avatar_url":"https://avatars.githubusercontent.com/u/1130828?v=3","gravatar_id":"","url":"https://api.github.com/users/bndtools","html_url":"https://github.com/bndtools","followers_url":"https://api.github.com/users/bndtools/followers","following_url":"https://api.github.com/users/bndtools/following{/other_user}","gists_url":"https://api.github.com/users/bndtools/gists{/gist_id}","starred_url":"https://api.github.com/users/bndtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bndtools/subscriptions","organizations_url":"https://api.github.com/users/bndtools/orgs","repos_url":"https://api.github.com/users/bndtools/repos","events_url":"https://api.github.com/users/bndtools/events{/privacy}","received_events_url":"https://api.github.com/users/bndtools/received_events","type":"Organization","site_admin":false},"repo":{"id":128476,"name":"bndtools","full_name":"bndtools/bndtools","owner":{"login":"bndtools","id":1130828,"avatar_url":"https://avatars.githubusercontent.com/u/1130828?v=3","gravatar_id":"","url":"https://api.github.com/users/bndtools","html_url":"https://github.com/bndtools","followers_url":"https://api.github.com/users/bndtools/followers","following_url":"https://api.github.com/users/bndtools/following{/other_user}","gists_url":"https://api.github.com/users/bndtools/gists{/gist_id}","starred_url":"https://api.github.com/users/bndtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bndtools/subscriptions","organizations_url":"https://api.github.com/users/bndtools/orgs","repos_url":"https://api.github.com/users/bndtools/repos","events_url":"https://api.github.com/users/bndtools/events{/privacy}","received_events_url":"https://api.github.com/users/bndtools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bndtools/bndtools","description":"Eclipse tools for developing OSGi bundles","fork":false,"url":"https://api.github.com/repos/bndtools/bndtools","forks_url":"https://api.github.com/repos/bndtools/bndtools/forks","keys_url":"https://api.github.com/repos/bndtools/bndtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bndtools/bndtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bndtools/bndtools/teams","hooks_url":"https://api.github.com/repos/bndtools/bndtools/hooks","issue_events_url":"https://api.github.com/repos/bndtools/bndtools/issues/events{/number}","events_url":"https://api.github.com/repos/bndtools/bndtools/events","assignees_url":"https://api.github.com/repos/bndtools/bndtools/assignees{/user}","branches_url":"https://api.github.com/repos/bndtools/bndtools/branches{/branch}","tags_url":"https://api.github.com/repos/bndtools/bndtools/tags","blobs_url":"https://api.github.com/repos/bndtools/bndtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bndtools/bndtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bndtools/bndtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/bndtools/bndtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bndtools/bndtools/statuses/{sha}","languages_url":"https://api.github.com/repos/bndtools/bndtools/languages","stargazers_url":"https://api.github.com/repos/bndtools/bndtools/stargazers","contributors_url":"https://api.github.com/repos/bndtools/bndtools/contributors","subscribers_url":"https://api.github.com/repos/bndtools/bndtools/subscribers","subscription_url":"https://api.github.com/repos/bndtools/bndtools/subscription","commits_url":"https://api.github.com/repos/bndtools/bndtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/bndtools/bndtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/bndtools/bndtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/bndtools/bndtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/bndtools/bndtools/contents/{+path}","compare_url":"https://api.github.com/repos/bndtools/bndtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bndtools/bndtools/merges","archive_url":"https://api.github.com/repos/bndtools/bndtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bndtools/bndtools/downloads","issues_url":"https://api.github.com/repos/bndtools/bndtools/issues{/number}","pulls_url":"https://api.github.com/repos/bndtools/bndtools/pulls{/number}","milestones_url":"https://api.github.com/repos/bndtools/bndtools/milestones{/number}","notifications_url":"https://api.github.com/repos/bndtools/bndtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bndtools/bndtools/labels{/name}","releases_url":"https://api.github.com/repos/bndtools/bndtools/releases{/id}","created_at":"2009-02-13T21:39:29Z","updated_at":"2015-12-08T17:33:05Z","pushed_at":"2015-12-14T21:08:37Z","git_url":"git://github.com/bndtools/bndtools.git","ssh_url":"git@github.com:bndtools/bndtools.git","clone_url":"https://github.com/bndtools/bndtools.git","svn_url":"https://github.com/bndtools/bndtools","homepage":"http://bndtools.org","size":427372,"stargazers_count":159,"watchers_count":159,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":133,"forks":68,"open_issues":133,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bndtools/bndtools/pulls/1223"},"html":{"href":"https://github.com/bndtools/bndtools/pull/1223"},"issue":{"href":"https://api.github.com/repos/bndtools/bndtools/issues/1223"},"comments":{"href":"https://api.github.com/repos/bndtools/bndtools/issues/1223/comments"},"review_comments":{"href":"https://api.github.com/repos/bndtools/bndtools/pulls/1223/comments"},"review_comment":{"href":"https://api.github.com/repos/bndtools/bndtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bndtools/bndtools/pulls/1223/commits"},"statuses":{"href":"https://api.github.com/repos/bndtools/bndtools/statuses/bba5ffaca9cff8597df961ed6c2341b2deae37f2"}}}}