{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/mar49/magic-pen_python/pulls/1","id":33599277,"html_url":"https://github.com/mar49/magic-pen_python/pull/1","diff_url":"https://github.com/mar49/magic-pen_python/pull/1.diff","patch_url":"https://github.com/mar49/magic-pen_python/pull/1.patch","issue_url":"https://api.github.com/repos/mar49/magic-pen_python/issues/1","number":1,"state":"closed","locked":false,"title":"Aggiustamenti","user":{"login":"mariolamacchia","id":6282722,"avatar_url":"https://avatars.githubusercontent.com/u/6282722?v=3","gravatar_id":"","url":"https://api.github.com/users/mariolamacchia","html_url":"https://github.com/mariolamacchia","followers_url":"https://api.github.com/users/mariolamacchia/followers","following_url":"https://api.github.com/users/mariolamacchia/following{/other_user}","gists_url":"https://api.github.com/users/mariolamacchia/gists{/gist_id}","starred_url":"https://api.github.com/users/mariolamacchia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariolamacchia/subscriptions","organizations_url":"https://api.github.com/users/mariolamacchia/orgs","repos_url":"https://api.github.com/users/mariolamacchia/repos","events_url":"https://api.github.com/users/mariolamacchia/events{/privacy}","received_events_url":"https://api.github.com/users/mariolamacchia/received_events","type":"User","site_admin":false},"body":"- isMagicOn e toggleMagic sono getter e setter, sarebbero perciò da evitare in python.\r\n- import non dovrebbe usare la wildcard: http://docs.quantifiedcode.com/python-code-patterns/maintainability/from_module_import_all_used.html\r\n- aggiustamenti stilistici per rispettare le pep8 https://www.python.org/dev/peps/pep-0008/","created_at":"2015-04-18T09:12:52Z","updated_at":"2015-04-18T14:50:39Z","closed_at":"2015-04-18T14:50:39Z","merged_at":"2015-04-18T14:50:39Z","merge_commit_sha":"25bded24c2a740dc4cb89717f4e0d7afa20ad8bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mar49/magic-pen_python/pulls/1/commits","review_comments_url":"https://api.github.com/repos/mar49/magic-pen_python/pulls/1/comments","review_comment_url":"https://api.github.com/repos/mar49/magic-pen_python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mar49/magic-pen_python/issues/1/comments","statuses_url":"https://api.github.com/repos/mar49/magic-pen_python/statuses/fad22efb827371ba046007622a6ca953a648aceb","head":{"label":"mariolamacchia:master","ref":"master","sha":"fad22efb827371ba046007622a6ca953a648aceb","user":{"login":"mariolamacchia","id":6282722,"avatar_url":"https://avatars.githubusercontent.com/u/6282722?v=3","gravatar_id":"","url":"https://api.github.com/users/mariolamacchia","html_url":"https://github.com/mariolamacchia","followers_url":"https://api.github.com/users/mariolamacchia/followers","following_url":"https://api.github.com/users/mariolamacchia/following{/other_user}","gists_url":"https://api.github.com/users/mariolamacchia/gists{/gist_id}","starred_url":"https://api.github.com/users/mariolamacchia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariolamacchia/subscriptions","organizations_url":"https://api.github.com/users/mariolamacchia/orgs","repos_url":"https://api.github.com/users/mariolamacchia/repos","events_url":"https://api.github.com/users/mariolamacchia/events{/privacy}","received_events_url":"https://api.github.com/users/mariolamacchia/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"mar49:master","ref":"master","sha":"0cd0bd482e0ac71e8160c90d5a6fdb6f8f4a48ea","user":{"login":"mar49","id":10885061,"avatar_url":"https://avatars.githubusercontent.com/u/10885061?v=3","gravatar_id":"","url":"https://api.github.com/users/mar49","html_url":"https://github.com/mar49","followers_url":"https://api.github.com/users/mar49/followers","following_url":"https://api.github.com/users/mar49/following{/other_user}","gists_url":"https://api.github.com/users/mar49/gists{/gist_id}","starred_url":"https://api.github.com/users/mar49/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mar49/subscriptions","organizations_url":"https://api.github.com/users/mar49/orgs","repos_url":"https://api.github.com/users/mar49/repos","events_url":"https://api.github.com/users/mar49/events{/privacy}","received_events_url":"https://api.github.com/users/mar49/received_events","type":"User","site_admin":false},"repo":{"id":34139158,"name":"magic-pen_python","full_name":"mar49/magic-pen_python","owner":{"login":"mar49","id":10885061,"avatar_url":"https://avatars.githubusercontent.com/u/10885061?v=3","gravatar_id":"","url":"https://api.github.com/users/mar49","html_url":"https://github.com/mar49","followers_url":"https://api.github.com/users/mar49/followers","following_url":"https://api.github.com/users/mar49/following{/other_user}","gists_url":"https://api.github.com/users/mar49/gists{/gist_id}","starred_url":"https://api.github.com/users/mar49/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mar49/subscriptions","organizations_url":"https://api.github.com/users/mar49/orgs","repos_url":"https://api.github.com/users/mar49/repos","events_url":"https://api.github.com/users/mar49/events{/privacy}","received_events_url":"https://api.github.com/users/mar49/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mar49/magic-pen_python","description":"","fork":false,"url":"https://api.github.com/repos/mar49/magic-pen_python","forks_url":"https://api.github.com/repos/mar49/magic-pen_python/forks","keys_url":"https://api.github.com/repos/mar49/magic-pen_python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mar49/magic-pen_python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mar49/magic-pen_python/teams","hooks_url":"https://api.github.com/repos/mar49/magic-pen_python/hooks","issue_events_url":"https://api.github.com/repos/mar49/magic-pen_python/issues/events{/number}","events_url":"https://api.github.com/repos/mar49/magic-pen_python/events","assignees_url":"https://api.github.com/repos/mar49/magic-pen_python/assignees{/user}","branches_url":"https://api.github.com/repos/mar49/magic-pen_python/branches{/branch}","tags_url":"https://api.github.com/repos/mar49/magic-pen_python/tags","blobs_url":"https://api.github.com/repos/mar49/magic-pen_python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mar49/magic-pen_python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mar49/magic-pen_python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mar49/magic-pen_python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mar49/magic-pen_python/statuses/{sha}","languages_url":"https://api.github.com/repos/mar49/magic-pen_python/languages","stargazers_url":"https://api.github.com/repos/mar49/magic-pen_python/stargazers","contributors_url":"https://api.github.com/repos/mar49/magic-pen_python/contributors","subscribers_url":"https://api.github.com/repos/mar49/magic-pen_python/subscribers","subscription_url":"https://api.github.com/repos/mar49/magic-pen_python/subscription","commits_url":"https://api.github.com/repos/mar49/magic-pen_python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mar49/magic-pen_python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mar49/magic-pen_python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mar49/magic-pen_python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mar49/magic-pen_python/contents/{+path}","compare_url":"https://api.github.com/repos/mar49/magic-pen_python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mar49/magic-pen_python/merges","archive_url":"https://api.github.com/repos/mar49/magic-pen_python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mar49/magic-pen_python/downloads","issues_url":"https://api.github.com/repos/mar49/magic-pen_python/issues{/number}","pulls_url":"https://api.github.com/repos/mar49/magic-pen_python/pulls{/number}","milestones_url":"https://api.github.com/repos/mar49/magic-pen_python/milestones{/number}","notifications_url":"https://api.github.com/repos/mar49/magic-pen_python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mar49/magic-pen_python/labels{/name}","releases_url":"https://api.github.com/repos/mar49/magic-pen_python/releases{/id}","created_at":"2015-04-17T20:42:20Z","updated_at":"2015-04-17T20:46:56Z","pushed_at":"2015-04-18T14:50:39Z","git_url":"git://github.com/mar49/magic-pen_python.git","ssh_url":"git@github.com:mar49/magic-pen_python.git","clone_url":"https://github.com/mar49/magic-pen_python.git","svn_url":"https://github.com/mar49/magic-pen_python","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mar49/magic-pen_python/pulls/1"},"html":{"href":"https://github.com/mar49/magic-pen_python/pull/1"},"issue":{"href":"https://api.github.com/repos/mar49/magic-pen_python/issues/1"},"comments":{"href":"https://api.github.com/repos/mar49/magic-pen_python/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/mar49/magic-pen_python/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/mar49/magic-pen_python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mar49/magic-pen_python/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/mar49/magic-pen_python/statuses/fad22efb827371ba046007622a6ca953a648aceb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mar49","id":10885061,"avatar_url":"https://avatars.githubusercontent.com/u/10885061?v=3","gravatar_id":"","url":"https://api.github.com/users/mar49","html_url":"https://github.com/mar49","followers_url":"https://api.github.com/users/mar49/followers","following_url":"https://api.github.com/users/mar49/following{/other_user}","gists_url":"https://api.github.com/users/mar49/gists{/gist_id}","starred_url":"https://api.github.com/users/mar49/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mar49/subscriptions","organizations_url":"https://api.github.com/users/mar49/orgs","repos_url":"https://api.github.com/users/mar49/repos","events_url":"https://api.github.com/users/mar49/events{/privacy}","received_events_url":"https://api.github.com/users/mar49/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":16,"deletions":25,"changed_files":2}}