{"action":"created","comment":{"url":"https://api.github.com/repos/google/compare-codecs/pulls/comments/28863298","id":28863298,"diff_hunk":"@@ -549,6 +549,10 @@ def AllScoredVariants(self, videofile, vary):\n                                                          videofile).encodings)\n     return encodings\n \n+  def ChangeValue(self, name, new_value):","path":"lib/encoder.py","position":4,"original_position":4,"commit_id":"5ff1a3a1d3c0802e8991a0f56ee05df0ea4fdd99","original_commit_id":"5ff1a3a1d3c0802e8991a0f56ee05df0ea4fdd99","user":{"login":"phoglund","id":7911315,"avatar_url":"https://avatars.githubusercontent.com/u/7911315?v=3","gravatar_id":"","url":"https://api.github.com/users/phoglund","html_url":"https://github.com/phoglund","followers_url":"https://api.github.com/users/phoglund/followers","following_url":"https://api.github.com/users/phoglund/following{/other_user}","gists_url":"https://api.github.com/users/phoglund/gists{/gist_id}","starred_url":"https://api.github.com/users/phoglund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoglund/subscriptions","organizations_url":"https://api.github.com/users/phoglund/orgs","repos_url":"https://api.github.com/users/phoglund/repos","events_url":"https://api.github.com/users/phoglund/events{/privacy}","received_events_url":"https://api.github.com/users/phoglund/received_events","type":"User","site_admin":false},"body":"ChangeValue implies you mutate the current encoder. What about CreateVariant(self, parameter_to_change, new_value)?","created_at":"2015-04-22T11:17:22Z","updated_at":"2015-04-22T11:17:22Z","html_url":"https://github.com/google/compare-codecs/pull/56#discussion_r28863298","pull_request_url":"https://api.github.com/repos/google/compare-codecs/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/google/compare-codecs/pulls/comments/28863298"},"html":{"href":"https://github.com/google/compare-codecs/pull/56#discussion_r28863298"},"pull_request":{"href":"https://api.github.com/repos/google/compare-codecs/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/google/compare-codecs/pulls/56","id":33650512,"html_url":"https://github.com/google/compare-codecs/pull/56","diff_url":"https://github.com/google/compare-codecs/pull/56.diff","patch_url":"https://github.com/google/compare-codecs/pull/56.patch","issue_url":"https://api.github.com/repos/google/compare-codecs/issues/56","number":56,"state":"open","locked":false,"title":"Add \"--threads\" parameter to x264 codec.","user":{"login":"alvestrand","id":480893,"avatar_url":"https://avatars.githubusercontent.com/u/480893?v=3","gravatar_id":"","url":"https://api.github.com/users/alvestrand","html_url":"https://github.com/alvestrand","followers_url":"https://api.github.com/users/alvestrand/followers","following_url":"https://api.github.com/users/alvestrand/following{/other_user}","gists_url":"https://api.github.com/users/alvestrand/gists{/gist_id}","starred_url":"https://api.github.com/users/alvestrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvestrand/subscriptions","organizations_url":"https://api.github.com/users/alvestrand/orgs","repos_url":"https://api.github.com/users/alvestrand/repos","events_url":"https://api.github.com/users/alvestrand/events{/privacy}","received_events_url":"https://api.github.com/users/alvestrand/received_events","type":"User","site_admin":false},"body":"This adds a parameter for controlling the number of threads to\r\nthe x264 codec, removing the previously hardcoded default.\r\nNOTE: WILL INVALIDATE STORED ENCODES.\r\n\r\nIt also adds a new tool \"vary_parameter\" that lets one run encodes\r\nfor all possible values of a parameter, so that response curves\r\ncan be seen.\r\n\r\nIt also fixes a minor Lint error in openh264.py.","created_at":"2015-04-20T09:57:25Z","updated_at":"2015-04-22T11:17:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbf20405b23965562e427098d8aefdb37134444c","assignee":{"login":"phoglund","id":7911315,"avatar_url":"https://avatars.githubusercontent.com/u/7911315?v=3","gravatar_id":"","url":"https://api.github.com/users/phoglund","html_url":"https://github.com/phoglund","followers_url":"https://api.github.com/users/phoglund/followers","following_url":"https://api.github.com/users/phoglund/following{/other_user}","gists_url":"https://api.github.com/users/phoglund/gists{/gist_id}","starred_url":"https://api.github.com/users/phoglund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoglund/subscriptions","organizations_url":"https://api.github.com/users/phoglund/orgs","repos_url":"https://api.github.com/users/phoglund/repos","events_url":"https://api.github.com/users/phoglund/events{/privacy}","received_events_url":"https://api.github.com/users/phoglund/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/google/compare-codecs/pulls/56/commits","review_comments_url":"https://api.github.com/repos/google/compare-codecs/pulls/56/comments","review_comment_url":"https://api.github.com/repos/google/compare-codecs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/compare-codecs/issues/56/comments","statuses_url":"https://api.github.com/repos/google/compare-codecs/statuses/5ff1a3a1d3c0802e8991a0f56ee05df0ea4fdd99","head":{"label":"google:x264-threads","ref":"x264-threads","sha":"5ff1a3a1d3c0802e8991a0f56ee05df0ea4fdd99","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":27724471,"name":"compare-codecs","full_name":"google/compare-codecs","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/compare-codecs","description":null,"fork":false,"url":"https://api.github.com/repos/google/compare-codecs","forks_url":"https://api.github.com/repos/google/compare-codecs/forks","keys_url":"https://api.github.com/repos/google/compare-codecs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/compare-codecs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/compare-codecs/teams","hooks_url":"https://api.github.com/repos/google/compare-codecs/hooks","issue_events_url":"https://api.github.com/repos/google/compare-codecs/issues/events{/number}","events_url":"https://api.github.com/repos/google/compare-codecs/events","assignees_url":"https://api.github.com/repos/google/compare-codecs/assignees{/user}","branches_url":"https://api.github.com/repos/google/compare-codecs/branches{/branch}","tags_url":"https://api.github.com/repos/google/compare-codecs/tags","blobs_url":"https://api.github.com/repos/google/compare-codecs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/compare-codecs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/compare-codecs/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/compare-codecs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/compare-codecs/statuses/{sha}","languages_url":"https://api.github.com/repos/google/compare-codecs/languages","stargazers_url":"https://api.github.com/repos/google/compare-codecs/stargazers","contributors_url":"https://api.github.com/repos/google/compare-codecs/contributors","subscribers_url":"https://api.github.com/repos/google/compare-codecs/subscribers","subscription_url":"https://api.github.com/repos/google/compare-codecs/subscription","commits_url":"https://api.github.com/repos/google/compare-codecs/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/compare-codecs/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/compare-codecs/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/compare-codecs/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/compare-codecs/contents/{+path}","compare_url":"https://api.github.com/repos/google/compare-codecs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/compare-codecs/merges","archive_url":"https://api.github.com/repos/google/compare-codecs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/compare-codecs/downloads","issues_url":"https://api.github.com/repos/google/compare-codecs/issues{/number}","pulls_url":"https://api.github.com/repos/google/compare-codecs/pulls{/number}","milestones_url":"https://api.github.com/repos/google/compare-codecs/milestones{/number}","notifications_url":"https://api.github.com/repos/google/compare-codecs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/compare-codecs/labels{/name}","releases_url":"https://api.github.com/repos/google/compare-codecs/releases{/id}","created_at":"2014-12-08T16:42:21Z","updated_at":"2015-04-21T05:53:39Z","pushed_at":"2015-04-22T09:53:21Z","git_url":"git://github.com/google/compare-codecs.git","ssh_url":"git@github.com:google/compare-codecs.git","clone_url":"https://github.com/google/compare-codecs.git","svn_url":"https://github.com/google/compare-codecs","homepage":null,"size":1095,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":24,"forks":4,"open_issues":24,"watchers":18,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"b97d0bf3aae0f555a8b998c72003c5c22a837d04","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":27724471,"name":"compare-codecs","full_name":"google/compare-codecs","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/compare-codecs","description":null,"fork":false,"url":"https://api.github.com/repos/google/compare-codecs","forks_url":"https://api.github.com/repos/google/compare-codecs/forks","keys_url":"https://api.github.com/repos/google/compare-codecs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/compare-codecs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/compare-codecs/teams","hooks_url":"https://api.github.com/repos/google/compare-codecs/hooks","issue_events_url":"https://api.github.com/repos/google/compare-codecs/issues/events{/number}","events_url":"https://api.github.com/repos/google/compare-codecs/events","assignees_url":"https://api.github.com/repos/google/compare-codecs/assignees{/user}","branches_url":"https://api.github.com/repos/google/compare-codecs/branches{/branch}","tags_url":"https://api.github.com/repos/google/compare-codecs/tags","blobs_url":"https://api.github.com/repos/google/compare-codecs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/compare-codecs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/compare-codecs/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/compare-codecs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/compare-codecs/statuses/{sha}","languages_url":"https://api.github.com/repos/google/compare-codecs/languages","stargazers_url":"https://api.github.com/repos/google/compare-codecs/stargazers","contributors_url":"https://api.github.com/repos/google/compare-codecs/contributors","subscribers_url":"https://api.github.com/repos/google/compare-codecs/subscribers","subscription_url":"https://api.github.com/repos/google/compare-codecs/subscription","commits_url":"https://api.github.com/repos/google/compare-codecs/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/compare-codecs/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/compare-codecs/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/compare-codecs/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/compare-codecs/contents/{+path}","compare_url":"https://api.github.com/repos/google/compare-codecs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/compare-codecs/merges","archive_url":"https://api.github.com/repos/google/compare-codecs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/compare-codecs/downloads","issues_url":"https://api.github.com/repos/google/compare-codecs/issues{/number}","pulls_url":"https://api.github.com/repos/google/compare-codecs/pulls{/number}","milestones_url":"https://api.github.com/repos/google/compare-codecs/milestones{/number}","notifications_url":"https://api.github.com/repos/google/compare-codecs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/compare-codecs/labels{/name}","releases_url":"https://api.github.com/repos/google/compare-codecs/releases{/id}","created_at":"2014-12-08T16:42:21Z","updated_at":"2015-04-21T05:53:39Z","pushed_at":"2015-04-22T09:53:21Z","git_url":"git://github.com/google/compare-codecs.git","ssh_url":"git@github.com:google/compare-codecs.git","clone_url":"https://github.com/google/compare-codecs.git","svn_url":"https://github.com/google/compare-codecs","homepage":null,"size":1095,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":24,"forks":4,"open_issues":24,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/compare-codecs/pulls/56"},"html":{"href":"https://github.com/google/compare-codecs/pull/56"},"issue":{"href":"https://api.github.com/repos/google/compare-codecs/issues/56"},"comments":{"href":"https://api.github.com/repos/google/compare-codecs/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/google/compare-codecs/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/google/compare-codecs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/compare-codecs/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/google/compare-codecs/statuses/5ff1a3a1d3c0802e8991a0f56ee05df0ea4fdd99"}}}}