{"action":"closed","number":5283,"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/5283","id":20898076,"html_url":"https://github.com/mrdoob/three.js/pull/5283","diff_url":"https://github.com/mrdoob/three.js/pull/5283.diff","patch_url":"https://github.com/mrdoob/three.js/pull/5283.patch","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/5283","number":5283,"state":"closed","locked":false,"title":"r69 compatible WebGLOptimizedRenderer","user":{"login":"AleksandrAlbert","id":7092038,"avatar_url":"https://avatars.githubusercontent.com/u/7092038?v=3","gravatar_id":"","url":"https://api.github.com/users/AleksandrAlbert","html_url":"https://github.com/AleksandrAlbert","followers_url":"https://api.github.com/users/AleksandrAlbert/followers","following_url":"https://api.github.com/users/AleksandrAlbert/following{/other_user}","gists_url":"https://api.github.com/users/AleksandrAlbert/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksandrAlbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksandrAlbert/subscriptions","organizations_url":"https://api.github.com/users/AleksandrAlbert/orgs","repos_url":"https://api.github.com/users/AleksandrAlbert/repos","events_url":"https://api.github.com/users/AleksandrAlbert/events{/privacy}","received_events_url":"https://api.github.com/users/AleksandrAlbert/received_events","type":"User","site_admin":false},"body":"An update of my previous pull request #5274 for users of r69. \r\n\r\nHighlights:\r\n\r\n- needed to change program.id with _currentMaterialId in the loadUniformsGeneric() function\r\n- Refactored the sampleUniform function to include the sampleUniformArray function\r\n\r\nNew Compression Ratio (Ocean Demo)\r\n\r\nr69 WebGLRenderer = 303 calls\r\nr69 WebGLOptimizedRenderer = 134 calls\r\n\r\n~56% call reduction\r\n\r\nFor comparison, the original demo (raw WebGL) = 105 calls\r\n\r\n","created_at":"2014-09-08T15:43:49Z","updated_at":"2015-12-21T23:15:44Z","closed_at":"2015-12-21T23:15:44Z","merged_at":null,"merge_commit_sha":"d175ddb68be8f71fe874586c4d8149e2dcf247e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mrdoob/three.js/pulls/5283/commits","review_comments_url":"https://api.github.com/repos/mrdoob/three.js/pulls/5283/comments","review_comment_url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/5283/comments","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/8dd8b231cf1a801b8aa6e9e9e9ff27f2d792b7e9","head":{"label":"AleksandrAlbert:dev","ref":"dev","sha":"8dd8b231cf1a801b8aa6e9e9e9ff27f2d792b7e9","user":{"login":"AleksandrAlbert","id":7092038,"avatar_url":"https://avatars.githubusercontent.com/u/7092038?v=3","gravatar_id":"","url":"https://api.github.com/users/AleksandrAlbert","html_url":"https://github.com/AleksandrAlbert","followers_url":"https://api.github.com/users/AleksandrAlbert/followers","following_url":"https://api.github.com/users/AleksandrAlbert/following{/other_user}","gists_url":"https://api.github.com/users/AleksandrAlbert/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksandrAlbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksandrAlbert/subscriptions","organizations_url":"https://api.github.com/users/AleksandrAlbert/orgs","repos_url":"https://api.github.com/users/AleksandrAlbert/repos","events_url":"https://api.github.com/users/AleksandrAlbert/events{/privacy}","received_events_url":"https://api.github.com/users/AleksandrAlbert/received_events","type":"User","site_admin":false},"repo":{"id":23724129,"name":"three.js","full_name":"AleksandrAlbert/three.js","owner":{"login":"AleksandrAlbert","id":7092038,"avatar_url":"https://avatars.githubusercontent.com/u/7092038?v=3","gravatar_id":"","url":"https://api.github.com/users/AleksandrAlbert","html_url":"https://github.com/AleksandrAlbert","followers_url":"https://api.github.com/users/AleksandrAlbert/followers","following_url":"https://api.github.com/users/AleksandrAlbert/following{/other_user}","gists_url":"https://api.github.com/users/AleksandrAlbert/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksandrAlbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksandrAlbert/subscriptions","organizations_url":"https://api.github.com/users/AleksandrAlbert/orgs","repos_url":"https://api.github.com/users/AleksandrAlbert/repos","events_url":"https://api.github.com/users/AleksandrAlbert/events{/privacy}","received_events_url":"https://api.github.com/users/AleksandrAlbert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AleksandrAlbert/three.js","description":"JavaScript 3D library.","fork":true,"url":"https://api.github.com/repos/AleksandrAlbert/three.js","forks_url":"https://api.github.com/repos/AleksandrAlbert/three.js/forks","keys_url":"https://api.github.com/repos/AleksandrAlbert/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AleksandrAlbert/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AleksandrAlbert/three.js/teams","hooks_url":"https://api.github.com/repos/AleksandrAlbert/three.js/hooks","issue_events_url":"https://api.github.com/repos/AleksandrAlbert/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/AleksandrAlbert/three.js/events","assignees_url":"https://api.github.com/repos/AleksandrAlbert/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/AleksandrAlbert/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/AleksandrAlbert/three.js/tags","blobs_url":"https://api.github.com/repos/AleksandrAlbert/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AleksandrAlbert/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AleksandrAlbert/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/AleksandrAlbert/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AleksandrAlbert/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/AleksandrAlbert/three.js/languages","stargazers_url":"https://api.github.com/repos/AleksandrAlbert/three.js/stargazers","contributors_url":"https://api.github.com/repos/AleksandrAlbert/three.js/contributors","subscribers_url":"https://api.github.com/repos/AleksandrAlbert/three.js/subscribers","subscription_url":"https://api.github.com/repos/AleksandrAlbert/three.js/subscription","commits_url":"https://api.github.com/repos/AleksandrAlbert/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/AleksandrAlbert/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/AleksandrAlbert/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/AleksandrAlbert/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/AleksandrAlbert/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/AleksandrAlbert/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AleksandrAlbert/three.js/merges","archive_url":"https://api.github.com/repos/AleksandrAlbert/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AleksandrAlbert/three.js/downloads","issues_url":"https://api.github.com/repos/AleksandrAlbert/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/AleksandrAlbert/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/AleksandrAlbert/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/AleksandrAlbert/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AleksandrAlbert/three.js/labels{/name}","releases_url":"https://api.github.com/repos/AleksandrAlbert/three.js/releases{/id}","created_at":"2014-09-06T01:59:25Z","updated_at":"2014-09-06T20:14:51Z","pushed_at":"2014-09-09T03:03:35Z","git_url":"git://github.com/AleksandrAlbert/three.js.git","ssh_url":"git@github.com:AleksandrAlbert/three.js.git","clone_url":"https://github.com/AleksandrAlbert/three.js.git","svn_url":"https://github.com/AleksandrAlbert/three.js","homepage":"http://threejs.org/","size":258146,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mrdoob:dev","ref":"dev","sha":"c6e69f22561148453c5d0974344b5158e6e30074","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"repo":{"id":576201,"name":"three.js","full_name":"mrdoob/three.js","owner":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdoob/three.js","description":"JavaScript 3D library.","fork":false,"url":"https://api.github.com/repos/mrdoob/three.js","forks_url":"https://api.github.com/repos/mrdoob/three.js/forks","keys_url":"https://api.github.com/repos/mrdoob/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdoob/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdoob/three.js/teams","hooks_url":"https://api.github.com/repos/mrdoob/three.js/hooks","issue_events_url":"https://api.github.com/repos/mrdoob/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/mrdoob/three.js/events","assignees_url":"https://api.github.com/repos/mrdoob/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/mrdoob/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/mrdoob/three.js/tags","blobs_url":"https://api.github.com/repos/mrdoob/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdoob/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdoob/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdoob/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdoob/three.js/languages","stargazers_url":"https://api.github.com/repos/mrdoob/three.js/stargazers","contributors_url":"https://api.github.com/repos/mrdoob/three.js/contributors","subscribers_url":"https://api.github.com/repos/mrdoob/three.js/subscribers","subscription_url":"https://api.github.com/repos/mrdoob/three.js/subscription","commits_url":"https://api.github.com/repos/mrdoob/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdoob/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdoob/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdoob/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrdoob/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/mrdoob/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdoob/three.js/merges","archive_url":"https://api.github.com/repos/mrdoob/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdoob/three.js/downloads","issues_url":"https://api.github.com/repos/mrdoob/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/mrdoob/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdoob/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdoob/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdoob/three.js/labels{/name}","releases_url":"https://api.github.com/repos/mrdoob/three.js/releases{/id}","created_at":"2010-03-23T18:58:01Z","updated_at":"2015-12-21T20:53:36Z","pushed_at":"2015-12-21T23:14:45Z","git_url":"git://github.com/mrdoob/three.js.git","ssh_url":"git@github.com:mrdoob/three.js.git","clone_url":"https://github.com/mrdoob/three.js.git","svn_url":"https://github.com/mrdoob/three.js","homepage":"http://threejs.org/","size":405373,"stargazers_count":22521,"watchers_count":22521,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":7112,"mirror_url":null,"open_issues_count":558,"forks":7112,"open_issues":558,"watchers":22521,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/5283"},"html":{"href":"https://github.com/mrdoob/three.js/pull/5283"},"issue":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/5283"},"comments":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/5283/comments"},"review_comments":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/5283/comments"},"review_comment":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/5283/commits"},"statuses":{"href":"https://api.github.com/repos/mrdoob/three.js/statuses/8dd8b231cf1a801b8aa6e9e9e9ff27f2d792b7e9"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":11,"review_comments":0,"commits":27,"additions":3836,"deletions":3503,"changed_files":1}}