{"action":"created","comment":{"url":"https://api.github.com/repos/Khan/KaTeX/pulls/comments/37494202","id":37494202,"diff_hunk":"@@ -575,12 +579,48 @@ var groupTypes = {\n             totalHeight += depth + gap; // \\@yargarraycr\n             body[r] = outrow;\n         }\n+\n         var offset = totalHeight / 2 + fontMetrics.metrics.axisHeight;\n         var coldescriptions = group.value.cols || [];\n         var cols = [];\n         var colsep;\n-        for (c = 0; c < nc; ++c) {\n-            var coldescr = coldescriptions[c] || {};\n+        var colDescrNum;\n+        for (c = 0, colDescrNum = 0;\n+             c < nc || colDescrNum < coldescriptions.length;\n+             ++c, ++colDescrNum) {\n+            var coldescr = coldescriptions[colDescrNum] || {};\n+\n+            var lastWasSeparator = false;\n+            while (coldescr.type === \"separator\") {\n+                if (lastWasSeparator) {\n+                    colsep = makeSpan([\"arraycolsep\"], []);\n+                    colsep.style.width = \"0.2em\";","path":"src/buildHTML.js","position":49,"original_position":49,"commit_id":"410281bd957b292011797f3ef7a549d2bc971797","original_commit_id":"410281bd957b292011797f3ef7a549d2bc971797","user":{"login":"spicyj","id":6820,"avatar_url":"https://avatars.githubusercontent.com/u/6820?v=3","gravatar_id":"","url":"https://api.github.com/users/spicyj","html_url":"https://github.com/spicyj","followers_url":"https://api.github.com/users/spicyj/followers","following_url":"https://api.github.com/users/spicyj/following{/other_user}","gists_url":"https://api.github.com/users/spicyj/gists{/gist_id}","starred_url":"https://api.github.com/users/spicyj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicyj/subscriptions","organizations_url":"https://api.github.com/users/spicyj/orgs","repos_url":"https://api.github.com/users/spicyj/repos","events_url":"https://api.github.com/users/spicyj/events{/privacy}","received_events_url":"https://api.github.com/users/spicyj/received_events","type":"User","site_admin":false},"body":"Yeah, these look different.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/6820/9375745/6deee14e-46b9-11e5-85fd-8c91e72d4e4f.png)\r\n","created_at":"2015-08-20T04:29:55Z","updated_at":"2015-08-20T04:29:55Z","html_url":"https://github.com/Khan/KaTeX/pull/330#discussion_r37494202","pull_request_url":"https://api.github.com/repos/Khan/KaTeX/pulls/330","_links":{"self":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/comments/37494202"},"html":{"href":"https://github.com/Khan/KaTeX/pull/330#discussion_r37494202"},"pull_request":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/330"}}},"pull_request":{"url":"https://api.github.com/repos/Khan/KaTeX/pulls/330","id":42838997,"html_url":"https://github.com/Khan/KaTeX/pull/330","diff_url":"https://github.com/Khan/KaTeX/pull/330.diff","patch_url":"https://github.com/Khan/KaTeX/pull/330.patch","issue_url":"https://api.github.com/repos/Khan/KaTeX/issues/330","number":330,"state":"open","locked":false,"title":"Add | column separators to arrays.","user":{"login":"xymostech","id":217900,"avatar_url":"https://avatars.githubusercontent.com/u/217900?v=3","gravatar_id":"","url":"https://api.github.com/users/xymostech","html_url":"https://github.com/xymostech","followers_url":"https://api.github.com/users/xymostech/followers","following_url":"https://api.github.com/users/xymostech/following{/other_user}","gists_url":"https://api.github.com/users/xymostech/gists{/gist_id}","starred_url":"https://api.github.com/users/xymostech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xymostech/subscriptions","organizations_url":"https://api.github.com/users/xymostech/orgs","repos_url":"https://api.github.com/users/xymostech/repos","events_url":"https://api.github.com/users/xymostech/events{/privacy}","received_events_url":"https://api.github.com/users/xymostech/received_events","type":"User","site_admin":false},"body":"This adds the ability to add `|` to a column description and have\r\nvertical separators be added. I added type tags to the column descriptions\r\nand added some logic to handle the separators when building the vertical\r\nlists of the array.\r\n\r\nThe LimitControls and UnsupportedCmds images also changed, which is worrying... Maybe my computer just doesn't like rendering images the same as everyone else.\r\n\r\nTest plan:\r\n - See the Arrays screenshot looks good.\r\n - `make test`\r\n\r\ntexcmp diff: \r\n![arrays](https://cloud.githubusercontent.com/assets/217900/9363113/4f9d13e2-4659-11e5-8e21-80b1396f406d.png)\r\n\r\n(I'm not at all positive about the 0.2em used as the spacer between the two separators on the right in that image, I just guessed; anyone have an idea where to find a source for that number?)\r\n","created_at":"2015-08-19T17:04:50Z","updated_at":"2015-08-20T04:29:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d481b27302ccabd8e994151ca53d8a00df71576","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Khan/KaTeX/pulls/330/commits","review_comments_url":"https://api.github.com/repos/Khan/KaTeX/pulls/330/comments","review_comment_url":"https://api.github.com/repos/Khan/KaTeX/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Khan/KaTeX/issues/330/comments","statuses_url":"https://api.github.com/repos/Khan/KaTeX/statuses/410281bd957b292011797f3ef7a549d2bc971797","head":{"label":"xymostech:add-vert-separator","ref":"add-vert-separator","sha":"410281bd957b292011797f3ef7a549d2bc971797","user":{"login":"xymostech","id":217900,"avatar_url":"https://avatars.githubusercontent.com/u/217900?v=3","gravatar_id":"","url":"https://api.github.com/users/xymostech","html_url":"https://github.com/xymostech","followers_url":"https://api.github.com/users/xymostech/followers","following_url":"https://api.github.com/users/xymostech/following{/other_user}","gists_url":"https://api.github.com/users/xymostech/gists{/gist_id}","starred_url":"https://api.github.com/users/xymostech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xymostech/subscriptions","organizations_url":"https://api.github.com/users/xymostech/orgs","repos_url":"https://api.github.com/users/xymostech/repos","events_url":"https://api.github.com/users/xymostech/events{/privacy}","received_events_url":"https://api.github.com/users/xymostech/received_events","type":"User","site_admin":false},"repo":{"id":31235727,"name":"KaTeX","full_name":"xymostech/KaTeX","owner":{"login":"xymostech","id":217900,"avatar_url":"https://avatars.githubusercontent.com/u/217900?v=3","gravatar_id":"","url":"https://api.github.com/users/xymostech","html_url":"https://github.com/xymostech","followers_url":"https://api.github.com/users/xymostech/followers","following_url":"https://api.github.com/users/xymostech/following{/other_user}","gists_url":"https://api.github.com/users/xymostech/gists{/gist_id}","starred_url":"https://api.github.com/users/xymostech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xymostech/subscriptions","organizations_url":"https://api.github.com/users/xymostech/orgs","repos_url":"https://api.github.com/users/xymostech/repos","events_url":"https://api.github.com/users/xymostech/events{/privacy}","received_events_url":"https://api.github.com/users/xymostech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xymostech/KaTeX","description":"Fast math typesetting for the web.","fork":true,"url":"https://api.github.com/repos/xymostech/KaTeX","forks_url":"https://api.github.com/repos/xymostech/KaTeX/forks","keys_url":"https://api.github.com/repos/xymostech/KaTeX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xymostech/KaTeX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xymostech/KaTeX/teams","hooks_url":"https://api.github.com/repos/xymostech/KaTeX/hooks","issue_events_url":"https://api.github.com/repos/xymostech/KaTeX/issues/events{/number}","events_url":"https://api.github.com/repos/xymostech/KaTeX/events","assignees_url":"https://api.github.com/repos/xymostech/KaTeX/assignees{/user}","branches_url":"https://api.github.com/repos/xymostech/KaTeX/branches{/branch}","tags_url":"https://api.github.com/repos/xymostech/KaTeX/tags","blobs_url":"https://api.github.com/repos/xymostech/KaTeX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xymostech/KaTeX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xymostech/KaTeX/git/refs{/sha}","trees_url":"https://api.github.com/repos/xymostech/KaTeX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xymostech/KaTeX/statuses/{sha}","languages_url":"https://api.github.com/repos/xymostech/KaTeX/languages","stargazers_url":"https://api.github.com/repos/xymostech/KaTeX/stargazers","contributors_url":"https://api.github.com/repos/xymostech/KaTeX/contributors","subscribers_url":"https://api.github.com/repos/xymostech/KaTeX/subscribers","subscription_url":"https://api.github.com/repos/xymostech/KaTeX/subscription","commits_url":"https://api.github.com/repos/xymostech/KaTeX/commits{/sha}","git_commits_url":"https://api.github.com/repos/xymostech/KaTeX/git/commits{/sha}","comments_url":"https://api.github.com/repos/xymostech/KaTeX/comments{/number}","issue_comment_url":"https://api.github.com/repos/xymostech/KaTeX/issues/comments{/number}","contents_url":"https://api.github.com/repos/xymostech/KaTeX/contents/{+path}","compare_url":"https://api.github.com/repos/xymostech/KaTeX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xymostech/KaTeX/merges","archive_url":"https://api.github.com/repos/xymostech/KaTeX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xymostech/KaTeX/downloads","issues_url":"https://api.github.com/repos/xymostech/KaTeX/issues{/number}","pulls_url":"https://api.github.com/repos/xymostech/KaTeX/pulls{/number}","milestones_url":"https://api.github.com/repos/xymostech/KaTeX/milestones{/number}","notifications_url":"https://api.github.com/repos/xymostech/KaTeX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xymostech/KaTeX/labels{/name}","releases_url":"https://api.github.com/repos/xymostech/KaTeX/releases{/id}","created_at":"2015-02-23T23:31:17Z","updated_at":"2015-02-23T23:31:18Z","pushed_at":"2015-08-19T17:05:53Z","git_url":"git://github.com/xymostech/KaTeX.git","ssh_url":"git@github.com:xymostech/KaTeX.git","clone_url":"https://github.com/xymostech/KaTeX.git","svn_url":"https://github.com/xymostech/KaTeX","homepage":"http://khan.github.io/KaTeX/","size":11666,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Khan:master","ref":"master","sha":"cb9f765e0696261712e01735a639ddaf6a222966","user":{"login":"Khan","id":15455,"avatar_url":"https://avatars.githubusercontent.com/u/15455?v=3","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"repo":{"id":11195700,"name":"KaTeX","full_name":"Khan/KaTeX","owner":{"login":"Khan","id":15455,"avatar_url":"https://avatars.githubusercontent.com/u/15455?v=3","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Khan/KaTeX","description":"Fast math typesetting for the web.","fork":false,"url":"https://api.github.com/repos/Khan/KaTeX","forks_url":"https://api.github.com/repos/Khan/KaTeX/forks","keys_url":"https://api.github.com/repos/Khan/KaTeX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Khan/KaTeX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Khan/KaTeX/teams","hooks_url":"https://api.github.com/repos/Khan/KaTeX/hooks","issue_events_url":"https://api.github.com/repos/Khan/KaTeX/issues/events{/number}","events_url":"https://api.github.com/repos/Khan/KaTeX/events","assignees_url":"https://api.github.com/repos/Khan/KaTeX/assignees{/user}","branches_url":"https://api.github.com/repos/Khan/KaTeX/branches{/branch}","tags_url":"https://api.github.com/repos/Khan/KaTeX/tags","blobs_url":"https://api.github.com/repos/Khan/KaTeX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Khan/KaTeX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Khan/KaTeX/git/refs{/sha}","trees_url":"https://api.github.com/repos/Khan/KaTeX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Khan/KaTeX/statuses/{sha}","languages_url":"https://api.github.com/repos/Khan/KaTeX/languages","stargazers_url":"https://api.github.com/repos/Khan/KaTeX/stargazers","contributors_url":"https://api.github.com/repos/Khan/KaTeX/contributors","subscribers_url":"https://api.github.com/repos/Khan/KaTeX/subscribers","subscription_url":"https://api.github.com/repos/Khan/KaTeX/subscription","commits_url":"https://api.github.com/repos/Khan/KaTeX/commits{/sha}","git_commits_url":"https://api.github.com/repos/Khan/KaTeX/git/commits{/sha}","comments_url":"https://api.github.com/repos/Khan/KaTeX/comments{/number}","issue_comment_url":"https://api.github.com/repos/Khan/KaTeX/issues/comments{/number}","contents_url":"https://api.github.com/repos/Khan/KaTeX/contents/{+path}","compare_url":"https://api.github.com/repos/Khan/KaTeX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Khan/KaTeX/merges","archive_url":"https://api.github.com/repos/Khan/KaTeX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Khan/KaTeX/downloads","issues_url":"https://api.github.com/repos/Khan/KaTeX/issues{/number}","pulls_url":"https://api.github.com/repos/Khan/KaTeX/pulls{/number}","milestones_url":"https://api.github.com/repos/Khan/KaTeX/milestones{/number}","notifications_url":"https://api.github.com/repos/Khan/KaTeX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Khan/KaTeX/labels{/name}","releases_url":"https://api.github.com/repos/Khan/KaTeX/releases{/id}","created_at":"2013-07-05T09:01:54Z","updated_at":"2015-08-20T00:30:48Z","pushed_at":"2015-08-20T04:07:35Z","git_url":"git://github.com/Khan/KaTeX.git","ssh_url":"git@github.com:Khan/KaTeX.git","clone_url":"https://github.com/Khan/KaTeX.git","svn_url":"https://github.com/Khan/KaTeX","homepage":"http://khan.github.io/KaTeX/","size":14496,"stargazers_count":3817,"watchers_count":3817,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":210,"mirror_url":null,"open_issues_count":93,"forks":210,"open_issues":93,"watchers":3817,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/330"},"html":{"href":"https://github.com/Khan/KaTeX/pull/330"},"issue":{"href":"https://api.github.com/repos/Khan/KaTeX/issues/330"},"comments":{"href":"https://api.github.com/repos/Khan/KaTeX/issues/330/comments"},"review_comments":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/330/comments"},"review_comment":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/330/commits"},"statuses":{"href":"https://api.github.com/repos/Khan/KaTeX/statuses/410281bd957b292011797f3ef7a549d2bc971797"}}}}