{"action":"closed","number":3423,"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/3423","id":46533371,"html_url":"https://github.com/juju/juju/pull/3423","diff_url":"https://github.com/juju/juju/pull/3423.diff","patch_url":"https://github.com/juju/juju/pull/3423.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/3423","number":3423,"state":"closed","locked":false,"title":"WIP: Metadata search path.","user":{"login":"anastasiamac","id":9034160,"avatar_url":"https://avatars.githubusercontent.com/u/9034160?v=3","gravatar_id":"","url":"https://api.github.com/users/anastasiamac","html_url":"https://github.com/anastasiamac","followers_url":"https://api.github.com/users/anastasiamac/followers","following_url":"https://api.github.com/users/anastasiamac/following{/other_user}","gists_url":"https://api.github.com/users/anastasiamac/gists{/gist_id}","starred_url":"https://api.github.com/users/anastasiamac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anastasiamac/subscriptions","organizations_url":"https://api.github.com/users/anastasiamac/orgs","repos_url":"https://api.github.com/users/anastasiamac/repos","events_url":"https://api.github.com/users/anastasiamac/events{/privacy}","received_events_url":"https://api.github.com/users/anastasiamac/received_events","type":"User","site_admin":false},"body":"This PR changes image metadata search path  to look into state server before looking into simplestreams.\r\n\r\nMost interesting changes are in provider/common/imagemetadata files and bootstrap files.\r\n\r\nWIP because I am unsure:\r\n\r\n1. Is behavior around bootstrap correct? \r\n\r\n2. environs/tools/simplestreams.go currently uses Fetch and GetMetadata with datasource... This will now by-pass state.. Is this still a desired behaviour?\r\n\r\n3. provider/vsphere/image_metadata.go currently uses GetMetadata with datasource... This will now by-pass state.. Is this still a desired behaviour?\r\n\r\n4. environs/tools/validation.go currently uses Fetch with datasource... This will now by-pass state.. Is this still a desired behaviour? It is used in exported ValidateToolsMetadata which is called in production code of cmd/plugins/juju-metadata/validatetoolsmetadata.go\r\n\r\n5. environs/imagemetadata/generate.go currently uses Fetch with datasource... It is used in exported MergeAndWriteMetadata func used in production[1] and test[2] code. This will now by-pass state.. Is this still a desired behaviour?\r\n[1] \r\n[cmd/plugins/juju-metadata/imagemetadata.go,\r\ncmd/plugins/juju-metadata/toolsmetadata.go,\r\ncmd/plugins/juju-metadata/validatemetadata_test.go,\r\nenvirons/sync/sync.go,\r\nenvirons/tools/simplestreams.go] \r\n[2]\r\n[cmd/juju/commands/bootstrap_test.go, \r\ncmd/jujud/agent/testing/agent.go,\r\nenvirons/bootstrap/bootstrap_test.go,\r\nenvirons/testing/tools.go,\r\nenvirons/tools/simplestreams _test,\r\nenvirons/tools/testing/testing.go,\r\nprovider/common/supportedarchitectures_test.go,\r\nworker/upgrader/upgrader_test.go]\r\n\r\n6. Do I need to worry about updates/upgrades?\r\n\r\n7. Need to do manual testing.\r\n\r\n","created_at":"2015-10-01T14:50:22Z","updated_at":"2015-10-07T04:36:23Z","closed_at":"2015-10-07T04:36:23Z","merged_at":null,"merge_commit_sha":"746dc5b476aca6fd60095185ccc763da56c6b7d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/3423/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/3423/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/3423/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/b7a5129d6e0c97785c527a28aeedbf0fc373dce0","head":{"label":"anastasiamac:metadata-search","ref":"metadata-search","sha":"b7a5129d6e0c97785c527a28aeedbf0fc373dce0","user":{"login":"anastasiamac","id":9034160,"avatar_url":"https://avatars.githubusercontent.com/u/9034160?v=3","gravatar_id":"","url":"https://api.github.com/users/anastasiamac","html_url":"https://github.com/anastasiamac","followers_url":"https://api.github.com/users/anastasiamac/followers","following_url":"https://api.github.com/users/anastasiamac/following{/other_user}","gists_url":"https://api.github.com/users/anastasiamac/gists{/gist_id}","starred_url":"https://api.github.com/users/anastasiamac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anastasiamac/subscriptions","organizations_url":"https://api.github.com/users/anastasiamac/orgs","repos_url":"https://api.github.com/users/anastasiamac/repos","events_url":"https://api.github.com/users/anastasiamac/events{/privacy}","received_events_url":"https://api.github.com/users/anastasiamac/received_events","type":"User","site_admin":false},"repo":{"id":24841340,"name":"juju","full_name":"anastasiamac/juju","owner":{"login":"anastasiamac","id":9034160,"avatar_url":"https://avatars.githubusercontent.com/u/9034160?v=3","gravatar_id":"","url":"https://api.github.com/users/anastasiamac","html_url":"https://github.com/anastasiamac","followers_url":"https://api.github.com/users/anastasiamac/followers","following_url":"https://api.github.com/users/anastasiamac/following{/other_user}","gists_url":"https://api.github.com/users/anastasiamac/gists{/gist_id}","starred_url":"https://api.github.com/users/anastasiamac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anastasiamac/subscriptions","organizations_url":"https://api.github.com/users/anastasiamac/orgs","repos_url":"https://api.github.com/users/anastasiamac/repos","events_url":"https://api.github.com/users/anastasiamac/events{/privacy}","received_events_url":"https://api.github.com/users/anastasiamac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anastasiamac/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/anastasiamac/juju","forks_url":"https://api.github.com/repos/anastasiamac/juju/forks","keys_url":"https://api.github.com/repos/anastasiamac/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anastasiamac/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anastasiamac/juju/teams","hooks_url":"https://api.github.com/repos/anastasiamac/juju/hooks","issue_events_url":"https://api.github.com/repos/anastasiamac/juju/issues/events{/number}","events_url":"https://api.github.com/repos/anastasiamac/juju/events","assignees_url":"https://api.github.com/repos/anastasiamac/juju/assignees{/user}","branches_url":"https://api.github.com/repos/anastasiamac/juju/branches{/branch}","tags_url":"https://api.github.com/repos/anastasiamac/juju/tags","blobs_url":"https://api.github.com/repos/anastasiamac/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anastasiamac/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anastasiamac/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/anastasiamac/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anastasiamac/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/anastasiamac/juju/languages","stargazers_url":"https://api.github.com/repos/anastasiamac/juju/stargazers","contributors_url":"https://api.github.com/repos/anastasiamac/juju/contributors","subscribers_url":"https://api.github.com/repos/anastasiamac/juju/subscribers","subscription_url":"https://api.github.com/repos/anastasiamac/juju/subscription","commits_url":"https://api.github.com/repos/anastasiamac/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/anastasiamac/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/anastasiamac/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/anastasiamac/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/anastasiamac/juju/contents/{+path}","compare_url":"https://api.github.com/repos/anastasiamac/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anastasiamac/juju/merges","archive_url":"https://api.github.com/repos/anastasiamac/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anastasiamac/juju/downloads","issues_url":"https://api.github.com/repos/anastasiamac/juju/issues{/number}","pulls_url":"https://api.github.com/repos/anastasiamac/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/anastasiamac/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/anastasiamac/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anastasiamac/juju/labels{/name}","releases_url":"https://api.github.com/repos/anastasiamac/juju/releases{/id}","created_at":"2014-10-06T10:12:53Z","updated_at":"2015-05-04T01:58:04Z","pushed_at":"2015-10-07T04:28:41Z","git_url":"git://github.com/anastasiamac/juju.git","ssh_url":"git@github.com:anastasiamac/juju.git","clone_url":"https://github.com/anastasiamac/juju.git","svn_url":"https://github.com/anastasiamac/juju","homepage":"juju.ubuntu.com","size":58051,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"72cb662ac44364e46ba3adc03776e396f1af6aad","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","created_at":"2014-06-03T14:28:10Z","updated_at":"2015-10-05T03:33:43Z","pushed_at":"2015-10-07T02:55:37Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":96789,"stargazers_count":330,"watchers_count":330,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":101,"forks":110,"open_issues":101,"watchers":330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/3423"},"html":{"href":"https://github.com/juju/juju/pull/3423"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/3423"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/3423/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/3423/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/3423/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/b7a5129d6e0c97785c527a28aeedbf0fc373dce0"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":372,"deletions":220,"changed_files":25}}