{"action":"created","issue":{"url":"https://api.github.com/repos/nojhan/liquidprompt/issues/374","labels_url":"https://api.github.com/repos/nojhan/liquidprompt/issues/374/labels{/name}","comments_url":"https://api.github.com/repos/nojhan/liquidprompt/issues/374/comments","events_url":"https://api.github.com/repos/nojhan/liquidprompt/issues/374/events","html_url":"https://github.com/nojhan/liquidprompt/issues/374","id":86881104,"number":374,"title":"liquidprompt joined Debian","user":{"login":"aborrero","id":1462733,"avatar_url":"https://avatars.githubusercontent.com/u/1462733?v=3","gravatar_id":"","url":"https://api.github.com/users/aborrero","html_url":"https://github.com/aborrero","followers_url":"https://api.github.com/users/aborrero/followers","following_url":"https://api.github.com/users/aborrero/following{/other_user}","gists_url":"https://api.github.com/users/aborrero/gists{/gist_id}","starred_url":"https://api.github.com/users/aborrero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aborrero/subscriptions","organizations_url":"https://api.github.com/users/aborrero/orgs","repos_url":"https://api.github.com/users/aborrero/repos","events_url":"https://api.github.com/users/aborrero/events{/privacy}","received_events_url":"https://api.github.com/users/aborrero/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-10T08:01:19Z","updated_at":"2015-06-15T10:43:53Z","closed_at":null,"body":"Hi, just to let you know liquidprompt joined Debian.\r\n\r\nSome links:\r\n * https://tracker.debian.org/pkg/liquidprompt\r\n * https://github.com/aborrero/pkg-liquidprompt\r\n\r\nSome things to note in the Debian package:\r\n * all exported functions were prefixed `liquidprompt`. For example: `liquidprompt_tag` or `liquidprompt_off`. So we get a common namespace for available commands.\r\n * there is a small script to activate liquidprompt for the current user: `liquidprompt_activate`.\r\n * small changes to the default config (to get the prompt in similar shape of debian default).\r\n * a man page was added.\r\n\r\nPlease, let me know if you are interested in any of these things to be merged upstream."},"comment":{"url":"https://api.github.com/repos/nojhan/liquidprompt/issues/comments/112015626","html_url":"https://github.com/nojhan/liquidprompt/issues/374#issuecomment-112015626","issue_url":"https://api.github.com/repos/nojhan/liquidprompt/issues/374","id":112015626,"user":{"login":"dolmen","id":129536,"avatar_url":"https://avatars.githubusercontent.com/u/129536?v=3","gravatar_id":"","url":"https://api.github.com/users/dolmen","html_url":"https://github.com/dolmen","followers_url":"https://api.github.com/users/dolmen/followers","following_url":"https://api.github.com/users/dolmen/following{/other_user}","gists_url":"https://api.github.com/users/dolmen/gists{/gist_id}","starred_url":"https://api.github.com/users/dolmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolmen/subscriptions","organizations_url":"https://api.github.com/users/dolmen/orgs","repos_url":"https://api.github.com/users/dolmen/repos","events_url":"https://api.github.com/users/dolmen/events{/privacy}","received_events_url":"https://api.github.com/users/dolmen/received_events","type":"User","site_admin":false},"created_at":"2015-06-15T10:43:53Z","updated_at":"2015-06-15T10:43:53Z","body":"> `liquidprompt_activate` uses that code to try to be POSIX compliant, the code you propose seems to be a bashisms.\r\nWhy is it wrong to use bashisms in `~/.bashrc` and zshisms in `~/.zshrc`?\r\n\r\n> I think we can get liquidprompt in shape to be used with lot of shells (apart of zshand bash) if we stick to the POSIX standard (however a bit of work is required in the main code).\r\n\r\nIt is already a nightmare to maintain `liquidprompt` for both bash and zsh. Forget about porting the current code to be more shell agnostic.\r\nSee instead my other project, [angel-PS1](/dolmen/angel-PS1) that use a more radical solution to be able to have a dynamic prompt for bash/zsh/mksh/dash/ksh93/tcsh/fish. Still work in progress.\r\n\r\n>Regarding the renaming of the functions, the reason is to have a common namespace for all liquidprompt-related commands.\r\n\r\nI understand your reasons.\r\n\r\n> I can't guarantee (now or in the future) that there aren't any other packages using the prompt_tag name: it's too generic.\r\n\r\nYou have to understand my reasons. This is breaking compatibility for a hypothetical future conflict with something else. We'll see when that happens.\r\n\r\n>In fact, I would suggest merging this upstream.\r\n\r\nNo."}}