{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/2068","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/2068/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/2068/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/2068/events","html_url":"https://github.com/LMMS/lmms/pull/2068","id":79851219,"number":2068,"title":"First version of a new dynamic LADSPA control dialog","user":{"login":"michaelgregorius","id":9293269,"avatar_url":"https://avatars.githubusercontent.com/u/9293269?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelgregorius","html_url":"https://github.com/michaelgregorius","followers_url":"https://api.github.com/users/michaelgregorius/followers","following_url":"https://api.github.com/users/michaelgregorius/following{/other_user}","gists_url":"https://api.github.com/users/michaelgregorius/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelgregorius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelgregorius/subscriptions","organizations_url":"https://api.github.com/users/michaelgregorius/orgs","repos_url":"https://api.github.com/users/michaelgregorius/repos","events_url":"https://api.github.com/users/michaelgregorius/events{/privacy}","received_events_url":"https://api.github.com/users/michaelgregorius/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-05-23T13:39:55Z","updated_at":"2015-08-25T16:28:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/2068","html_url":"https://github.com/LMMS/lmms/pull/2068","diff_url":"https://github.com/LMMS/lmms/pull/2068.diff","patch_url":"https://github.com/LMMS/lmms/pull/2068.patch"},"body":"The new dialog shows the LADSPA controls in a matrix layout. Each row\r\ncorresponds to a LADSPA parameter. Each parameter can have several\r\nchannels which can be linked. Each channel has its own row of controls.\r\n\r\nSome base classes have been extended to enable the resizing of the new\r\ncontrol dialog. A new virtual method `isResizable` was added to the class\r\n`EffectControlDialog`. The default implementation returns `false` which means\r\nthat for all other types of dialogs the code in `EffectView.cpp` will still\r\nset the dialogs to a fixed size. `LadspaMatrixControlDialog` returns `true`\r\nso the code is skipped. A better solution would be to remove the fixed\r\nsize code from `EffectView.cpp` altogether and to make it an implementation\r\ndetail of each dialog whether it is resizable or not.\r\n\r\nThe class `LadspaMatrixControlView` was added by copying and modifying\r\n`LadspaControlView` to get rid of the link buttons which are associated\r\nwith some controls and some labels.\r\n\r\nHere is a screenshot showing the dialogs in action:\r\n![new control dialog](https://cloud.githubusercontent.com/assets/9293269/7784312/99dbd584-0161-11e5-8978-99404c253d5a.png)\r\n"},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/134661114","html_url":"https://github.com/LMMS/lmms/pull/2068#issuecomment-134661114","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/2068","id":134661114,"user":{"login":"Wallacoloo","id":1210751,"avatar_url":"https://avatars.githubusercontent.com/u/1210751?v=3","gravatar_id":"","url":"https://api.github.com/users/Wallacoloo","html_url":"https://github.com/Wallacoloo","followers_url":"https://api.github.com/users/Wallacoloo/followers","following_url":"https://api.github.com/users/Wallacoloo/following{/other_user}","gists_url":"https://api.github.com/users/Wallacoloo/gists{/gist_id}","starred_url":"https://api.github.com/users/Wallacoloo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wallacoloo/subscriptions","organizations_url":"https://api.github.com/users/Wallacoloo/orgs","repos_url":"https://api.github.com/users/Wallacoloo/repos","events_url":"https://api.github.com/users/Wallacoloo/events{/privacy}","received_events_url":"https://api.github.com/users/Wallacoloo/received_events","type":"User","site_admin":false},"created_at":"2015-08-25T16:28:33Z","updated_at":"2015-08-25T16:28:33Z","body":"@budislav I don't follow 100%. Take the old Calf EQ layout shown in @michaelgregorius 's comment earlier: https://github.com/LMMS/lmms/pull/2068#issuecomment-105162567 . As is, it seems that both the new implementation *as well as the current one* are ill-fitted to being placed in a horizontal scrolling environment like that in your [proposal](https://cloud.githubusercontent.com/assets/3619927/8806809/aa768f92-2fd8-11e5-882f-258fa6c058f1.png).\r\n\r\nFor what it's worth, I don't imagine that very much of the existing LADSPA layout code will be compatible with your UI proposal anyway. Unless I'm mistaken, that portion of it will pretty much be a rewrite when based against either the current code or the code in this pull request. So in my opinion it's more important to question whether this pull request will improve the existing UI and/or make the code easier to deal with in the future.\r\n\r\nI don't mean to discredit your UI proposal or to offend - my perspective is one in which I value small, incremental improvements in order to make growth more manageable at the cost of these improvements occasionally being redundant."}}