{"action":"created","issue":{"url":"https://api.github.com/repos/phpspec/phpspec/issues/765","labels_url":"https://api.github.com/repos/phpspec/phpspec/issues/765/labels{/name}","comments_url":"https://api.github.com/repos/phpspec/phpspec/issues/765/comments","events_url":"https://api.github.com/repos/phpspec/phpspec/issues/765/events","html_url":"https://github.com/phpspec/phpspec/pull/765","id":103733359,"number":765,"title":"ValidatingExtensionTrait first implementation","user":{"login":"gajdaw","id":676675,"avatar_url":"https://avatars.githubusercontent.com/u/676675?v=3","gravatar_id":"","url":"https://api.github.com/users/gajdaw","html_url":"https://github.com/gajdaw","followers_url":"https://api.github.com/users/gajdaw/followers","following_url":"https://api.github.com/users/gajdaw/following{/other_user}","gists_url":"https://api.github.com/users/gajdaw/gists{/gist_id}","starred_url":"https://api.github.com/users/gajdaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gajdaw/subscriptions","organizations_url":"https://api.github.com/users/gajdaw/orgs","repos_url":"https://api.github.com/users/gajdaw/repos","events_url":"https://api.github.com/users/gajdaw/events{/privacy}","received_events_url":"https://api.github.com/users/gajdaw/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/phpspec/phpspec/labels/feature","name":"feature","color":"02e10c"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-28T14:54:40Z","updated_at":"2015-10-25T11:51:34Z","closed_at":"2015-10-25T11:51:34Z","pull_request":{"url":"https://api.github.com/repos/phpspec/phpspec/pulls/765","html_url":"https://github.com/phpspec/phpspec/pull/765","diff_url":"https://github.com/phpspec/phpspec/pull/765.diff","patch_url":"https://github.com/phpspec/phpspec/pull/765.patch"},"body":"This PR contains a trait that can help to validate services injected inside an extension.\r\n\r\nRight now it only validates matchers but it can be extended by assigning new values to the map stored `$map` private property.\r\n\r\nThe whole concept was to allow validation of injected service only for user created services injected in the extension. The services injected within `setupMatchers` method in `ContainerAssembler` class are left intact.\r\n"},"comment":{"url":"https://api.github.com/repos/phpspec/phpspec/issues/comments/150917104","html_url":"https://github.com/phpspec/phpspec/pull/765#issuecomment-150917104","issue_url":"https://api.github.com/repos/phpspec/phpspec/issues/765","id":150917104,"user":{"login":"ciaranmcnulty","id":237866,"avatar_url":"https://avatars.githubusercontent.com/u/237866?v=3","gravatar_id":"","url":"https://api.github.com/users/ciaranmcnulty","html_url":"https://github.com/ciaranmcnulty","followers_url":"https://api.github.com/users/ciaranmcnulty/followers","following_url":"https://api.github.com/users/ciaranmcnulty/following{/other_user}","gists_url":"https://api.github.com/users/ciaranmcnulty/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaranmcnulty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaranmcnulty/subscriptions","organizations_url":"https://api.github.com/users/ciaranmcnulty/orgs","repos_url":"https://api.github.com/users/ciaranmcnulty/repos","events_url":"https://api.github.com/users/ciaranmcnulty/events{/privacy}","received_events_url":"https://api.github.com/users/ciaranmcnulty/received_events","type":"User","site_admin":false},"created_at":"2015-10-25T11:51:34Z","updated_at":"2015-10-25T11:51:34Z","body":"I'm afraid after a lot of thought I don't think this is appropriate to core - I don't see the value of checking these things at runtime rather than, for instance, writing tests for your extension.\r\n\r\nHowever if you want to open-source it in your own repository for other extension developers to make use of I'd be happy to link to it in the docs."}}