{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/24898064","id":24898064,"diff_hunk":"@@ -72,7 +72,7 @@ EXTERN long Rows                        /* nr of rows in the screen */\n   = 24L\n #endif\n ;\n-EXTERN long Columns INIT(= 80);         /* nr of columns in the screen */\n+EXTERN int Columns INIT(= 80);         /* nr of columns in the screen */","path":"src/nvim/globals.h","position":5,"original_position":5,"commit_id":"56cf3e2ef413e5ca1ad4706632a47866e581ec57","original_commit_id":"56cf3e2ef413e5ca1ad4706632a47866e581ec57","user":{"login":"elmart","id":135757,"avatar_url":"https://avatars.githubusercontent.com/u/135757?v=3","gravatar_id":"","url":"https://api.github.com/users/elmart","html_url":"https://github.com/elmart","followers_url":"https://api.github.com/users/elmart/followers","following_url":"https://api.github.com/users/elmart/following{/other_user}","gists_url":"https://api.github.com/users/elmart/gists{/gist_id}","starred_url":"https://api.github.com/users/elmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmart/subscriptions","organizations_url":"https://api.github.com/users/elmart/orgs","repos_url":"https://api.github.com/users/elmart/repos","events_url":"https://api.github.com/users/elmart/events{/privacy}","received_events_url":"https://api.github.com/users/elmart/received_events","type":"User","site_admin":false},"body":"There are about 240 usages of global `Columns`. Have you checked all of them?\r\nNotice that the fact that it compiles without warnings after this change doesn't mean anything, as many of those usages can be in files where -Wconversion is not active yet. And, in files where -Wconversion is enabled, casts (and corresponding previous checks through asserts) may be present that could be removed.\r\nSo, to do it right, you have to manually check each occurrence. That's why this has been proceeding slowly. It's not so easy as it can seem. In fact, I don't consider enabling -Wconversion an entry-level task.\r\n","created_at":"2015-02-18T12:41:58Z","updated_at":"2015-02-18T12:41:58Z","html_url":"https://github.com/neovim/neovim/pull/2012#discussion_r24898064","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/2012","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/24898064"},"html":{"href":"https://github.com/neovim/neovim/pull/2012#discussion_r24898064"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2012"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/2012","id":29517397,"html_url":"https://github.com/neovim/neovim/pull/2012","diff_url":"https://github.com/neovim/neovim/pull/2012.diff","patch_url":"https://github.com/neovim/neovim/pull/2012.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/2012","number":2012,"state":"open","locked":false,"title":"[RFC] Enable -Wconversion for popupmnu.c","user":{"login":"Numkil","id":5604686,"avatar_url":"https://avatars.githubusercontent.com/u/5604686?v=3","gravatar_id":"","url":"https://api.github.com/users/Numkil","html_url":"https://github.com/Numkil","followers_url":"https://api.github.com/users/Numkil/followers","following_url":"https://api.github.com/users/Numkil/following{/other_user}","gists_url":"https://api.github.com/users/Numkil/gists{/gist_id}","starred_url":"https://api.github.com/users/Numkil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Numkil/subscriptions","organizations_url":"https://api.github.com/users/Numkil/orgs","repos_url":"https://api.github.com/users/Numkil/repos","events_url":"https://api.github.com/users/Numkil/events{/privacy}","received_events_url":"https://api.github.com/users/Numkil/received_events","type":"User","site_admin":false},"body":"Enables -Wconversion for popumnu.c\r\nAll tests passed on my pc but I realize that only testing on 1 pc is not enough\r\n\r\nI only noticed now that my copy of neovim was a bit aggressive on the removing of trailing white-space on a few lines. I hope this is not a problem. If it is I will manually fix it.\r\n\r\nEdit: I only just now noticed that someone else had already changed this file, I had somehow completely missed it in the pr listings. I'll leave this here should it be a better approach then the one used in #1284 ","created_at":"2015-02-18T11:14:11Z","updated_at":"2015-02-18T12:41:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bef6b301ebcd1268f34892d772331c15b032eb8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/2012/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/2012/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments/{number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/2012/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/56cf3e2ef413e5ca1ad4706632a47866e581ec57","head":{"label":"Numkil:master","ref":"master","sha":"56cf3e2ef413e5ca1ad4706632a47866e581ec57","user":{"login":"Numkil","id":5604686,"avatar_url":"https://avatars.githubusercontent.com/u/5604686?v=3","gravatar_id":"","url":"https://api.github.com/users/Numkil","html_url":"https://github.com/Numkil","followers_url":"https://api.github.com/users/Numkil/followers","following_url":"https://api.github.com/users/Numkil/following{/other_user}","gists_url":"https://api.github.com/users/Numkil/gists{/gist_id}","starred_url":"https://api.github.com/users/Numkil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Numkil/subscriptions","organizations_url":"https://api.github.com/users/Numkil/orgs","repos_url":"https://api.github.com/users/Numkil/repos","events_url":"https://api.github.com/users/Numkil/events{/privacy}","received_events_url":"https://api.github.com/users/Numkil/received_events","type":"User","site_admin":false},"repo":{"id":30962157,"name":"neovim","full_name":"Numkil/neovim","owner":{"login":"Numkil","id":5604686,"avatar_url":"https://avatars.githubusercontent.com/u/5604686?v=3","gravatar_id":"","url":"https://api.github.com/users/Numkil","html_url":"https://github.com/Numkil","followers_url":"https://api.github.com/users/Numkil/followers","following_url":"https://api.github.com/users/Numkil/following{/other_user}","gists_url":"https://api.github.com/users/Numkil/gists{/gist_id}","starred_url":"https://api.github.com/users/Numkil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Numkil/subscriptions","organizations_url":"https://api.github.com/users/Numkil/orgs","repos_url":"https://api.github.com/users/Numkil/repos","events_url":"https://api.github.com/users/Numkil/events{/privacy}","received_events_url":"https://api.github.com/users/Numkil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Numkil/neovim","description":"vim out of the box","fork":true,"url":"https://api.github.com/repos/Numkil/neovim","forks_url":"https://api.github.com/repos/Numkil/neovim/forks","keys_url":"https://api.github.com/repos/Numkil/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Numkil/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Numkil/neovim/teams","hooks_url":"https://api.github.com/repos/Numkil/neovim/hooks","issue_events_url":"https://api.github.com/repos/Numkil/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/Numkil/neovim/events","assignees_url":"https://api.github.com/repos/Numkil/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/Numkil/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/Numkil/neovim/tags","blobs_url":"https://api.github.com/repos/Numkil/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Numkil/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Numkil/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/Numkil/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Numkil/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/Numkil/neovim/languages","stargazers_url":"https://api.github.com/repos/Numkil/neovim/stargazers","contributors_url":"https://api.github.com/repos/Numkil/neovim/contributors","subscribers_url":"https://api.github.com/repos/Numkil/neovim/subscribers","subscription_url":"https://api.github.com/repos/Numkil/neovim/subscription","commits_url":"https://api.github.com/repos/Numkil/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/Numkil/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/Numkil/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/Numkil/neovim/issues/comments/{number}","contents_url":"https://api.github.com/repos/Numkil/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/Numkil/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Numkil/neovim/merges","archive_url":"https://api.github.com/repos/Numkil/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Numkil/neovim/downloads","issues_url":"https://api.github.com/repos/Numkil/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/Numkil/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/Numkil/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/Numkil/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Numkil/neovim/labels{/name}","releases_url":"https://api.github.com/repos/Numkil/neovim/releases{/id}","created_at":"2015-02-18T11:04:19Z","updated_at":"2015-02-18T11:05:31Z","pushed_at":"2015-02-18T11:05:31Z","git_url":"git://github.com/Numkil/neovim.git","ssh_url":"git@github.com:Numkil/neovim.git","clone_url":"https://github.com/Numkil/neovim.git","svn_url":"https://github.com/Numkil/neovim","homepage":"http://neovim.org","size":50755,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"66a03a7385dfd11503d22d8cc9dc6a972e27dcc2","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"vim out of the box","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments/{number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","created_at":"2014-01-31T13:39:22Z","updated_at":"2015-02-18T12:37:19Z","pushed_at":"2015-02-17T09:17:39Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"http://neovim.org","size":50755,"stargazers_count":11975,"watchers_count":11975,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":780,"mirror_url":null,"open_issues_count":370,"forks":780,"open_issues":370,"watchers":11975,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2012"},"html":{"href":"https://github.com/neovim/neovim/pull/2012"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/2012"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/2012/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2012/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2012/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/56cf3e2ef413e5ca1ad4706632a47866e581ec57"}}}}