{"action":"closed","number":432,"pull_request":{"url":"https://api.github.com/repos/brian-team/brian2/pulls/432","id":31742601,"html_url":"https://github.com/brian-team/brian2/pull/432","diff_url":"https://github.com/brian-team/brian2/pull/432.diff","patch_url":"https://github.com/brian-team/brian2/pull/432.patch","issue_url":"https://api.github.com/repos/brian-team/brian2/issues/432","number":432,"state":"closed","locked":false,"title":"Small change to the algorithm for `SpikeGeneratorGroup`","user":{"login":"mstimberg","id":1381982,"avatar_url":"https://avatars.githubusercontent.com/u/1381982?v=3","gravatar_id":"","url":"https://api.github.com/users/mstimberg","html_url":"https://github.com/mstimberg","followers_url":"https://api.github.com/users/mstimberg/followers","following_url":"https://api.github.com/users/mstimberg/following{/other_user}","gists_url":"https://api.github.com/users/mstimberg/gists{/gist_id}","starred_url":"https://api.github.com/users/mstimberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstimberg/subscriptions","organizations_url":"https://api.github.com/users/mstimberg/orgs","repos_url":"https://api.github.com/users/mstimberg/repos","events_url":"https://api.github.com/users/mstimberg/events{/privacy}","received_events_url":"https://api.github.com/users/mstimberg/received_events","type":"User","site_admin":false},"body":"I changed the algorithm slightly, and now I'm getting correct rounding behaviour for spike times at multiples of dt for long simulations. I added two tests that check this, they take quite some time to run and are therefore only tested when running the long test suite.\r\n\r\n@thesamovar Could you run the long test suite on your machine and merge if it passes -- our automatic testing on travis and appveyor will not run those tests.","created_at":"2015-03-23T15:28:03Z","updated_at":"2015-03-23T18:14:47Z","closed_at":"2015-03-23T18:14:47Z","merged_at":"2015-03-23T18:14:47Z","merge_commit_sha":"56f6fc3e0583ec86348562af33f257f8d060bc5e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brian-team/brian2/pulls/432/commits","review_comments_url":"https://api.github.com/repos/brian-team/brian2/pulls/432/comments","review_comment_url":"https://api.github.com/repos/brian-team/brian2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brian-team/brian2/issues/432/comments","statuses_url":"https://api.github.com/repos/brian-team/brian2/statuses/294d42f297a59bff5d0a80f1457c6e85c08d5a55","head":{"label":"brian-team:spikegenerator_fixes","ref":"spikegenerator_fixes","sha":"294d42f297a59bff5d0a80f1457c6e85c08d5a55","user":{"login":"brian-team","id":2292949,"avatar_url":"https://avatars.githubusercontent.com/u/2292949?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-team","html_url":"https://github.com/brian-team","followers_url":"https://api.github.com/users/brian-team/followers","following_url":"https://api.github.com/users/brian-team/following{/other_user}","gists_url":"https://api.github.com/users/brian-team/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-team/subscriptions","organizations_url":"https://api.github.com/users/brian-team/orgs","repos_url":"https://api.github.com/users/brian-team/repos","events_url":"https://api.github.com/users/brian-team/events{/privacy}","received_events_url":"https://api.github.com/users/brian-team/received_events","type":"Organization","site_admin":false},"repo":{"id":6884056,"name":"brian2","full_name":"brian-team/brian2","owner":{"login":"brian-team","id":2292949,"avatar_url":"https://avatars.githubusercontent.com/u/2292949?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-team","html_url":"https://github.com/brian-team","followers_url":"https://api.github.com/users/brian-team/followers","following_url":"https://api.github.com/users/brian-team/following{/other_user}","gists_url":"https://api.github.com/users/brian-team/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-team/subscriptions","organizations_url":"https://api.github.com/users/brian-team/orgs","repos_url":"https://api.github.com/users/brian-team/repos","events_url":"https://api.github.com/users/brian-team/events{/privacy}","received_events_url":"https://api.github.com/users/brian-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brian-team/brian2","description":"Brian2 is an improved and partly rewritten version of Brian, the spiking neural network simulator (see http://briansimulator.org). It is currently in a beta state, ready for testing.","fork":false,"url":"https://api.github.com/repos/brian-team/brian2","forks_url":"https://api.github.com/repos/brian-team/brian2/forks","keys_url":"https://api.github.com/repos/brian-team/brian2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brian-team/brian2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brian-team/brian2/teams","hooks_url":"https://api.github.com/repos/brian-team/brian2/hooks","issue_events_url":"https://api.github.com/repos/brian-team/brian2/issues/events{/number}","events_url":"https://api.github.com/repos/brian-team/brian2/events","assignees_url":"https://api.github.com/repos/brian-team/brian2/assignees{/user}","branches_url":"https://api.github.com/repos/brian-team/brian2/branches{/branch}","tags_url":"https://api.github.com/repos/brian-team/brian2/tags","blobs_url":"https://api.github.com/repos/brian-team/brian2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brian-team/brian2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brian-team/brian2/git/refs{/sha}","trees_url":"https://api.github.com/repos/brian-team/brian2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brian-team/brian2/statuses/{sha}","languages_url":"https://api.github.com/repos/brian-team/brian2/languages","stargazers_url":"https://api.github.com/repos/brian-team/brian2/stargazers","contributors_url":"https://api.github.com/repos/brian-team/brian2/contributors","subscribers_url":"https://api.github.com/repos/brian-team/brian2/subscribers","subscription_url":"https://api.github.com/repos/brian-team/brian2/subscription","commits_url":"https://api.github.com/repos/brian-team/brian2/commits{/sha}","git_commits_url":"https://api.github.com/repos/brian-team/brian2/git/commits{/sha}","comments_url":"https://api.github.com/repos/brian-team/brian2/comments{/number}","issue_comment_url":"https://api.github.com/repos/brian-team/brian2/issues/comments{/number}","contents_url":"https://api.github.com/repos/brian-team/brian2/contents/{+path}","compare_url":"https://api.github.com/repos/brian-team/brian2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brian-team/brian2/merges","archive_url":"https://api.github.com/repos/brian-team/brian2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brian-team/brian2/downloads","issues_url":"https://api.github.com/repos/brian-team/brian2/issues{/number}","pulls_url":"https://api.github.com/repos/brian-team/brian2/pulls{/number}","milestones_url":"https://api.github.com/repos/brian-team/brian2/milestones{/number}","notifications_url":"https://api.github.com/repos/brian-team/brian2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brian-team/brian2/labels{/name}","releases_url":"https://api.github.com/repos/brian-team/brian2/releases{/id}","created_at":"2012-11-27T13:46:43Z","updated_at":"2015-03-23T18:14:47Z","pushed_at":"2015-03-23T18:14:47Z","git_url":"git://github.com/brian-team/brian2.git","ssh_url":"git@github.com:brian-team/brian2.git","clone_url":"https://github.com/brian-team/brian2.git","svn_url":"https://github.com/brian-team/brian2","homepage":"","size":14338,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":106,"forks":16,"open_issues":106,"watchers":38,"default_branch":"master"}},"base":{"label":"brian-team:master","ref":"master","sha":"75d1137f37fe4cba97e1eb639e1de554d472ba58","user":{"login":"brian-team","id":2292949,"avatar_url":"https://avatars.githubusercontent.com/u/2292949?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-team","html_url":"https://github.com/brian-team","followers_url":"https://api.github.com/users/brian-team/followers","following_url":"https://api.github.com/users/brian-team/following{/other_user}","gists_url":"https://api.github.com/users/brian-team/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-team/subscriptions","organizations_url":"https://api.github.com/users/brian-team/orgs","repos_url":"https://api.github.com/users/brian-team/repos","events_url":"https://api.github.com/users/brian-team/events{/privacy}","received_events_url":"https://api.github.com/users/brian-team/received_events","type":"Organization","site_admin":false},"repo":{"id":6884056,"name":"brian2","full_name":"brian-team/brian2","owner":{"login":"brian-team","id":2292949,"avatar_url":"https://avatars.githubusercontent.com/u/2292949?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-team","html_url":"https://github.com/brian-team","followers_url":"https://api.github.com/users/brian-team/followers","following_url":"https://api.github.com/users/brian-team/following{/other_user}","gists_url":"https://api.github.com/users/brian-team/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-team/subscriptions","organizations_url":"https://api.github.com/users/brian-team/orgs","repos_url":"https://api.github.com/users/brian-team/repos","events_url":"https://api.github.com/users/brian-team/events{/privacy}","received_events_url":"https://api.github.com/users/brian-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brian-team/brian2","description":"Brian2 is an improved and partly rewritten version of Brian, the spiking neural network simulator (see http://briansimulator.org). It is currently in a beta state, ready for testing.","fork":false,"url":"https://api.github.com/repos/brian-team/brian2","forks_url":"https://api.github.com/repos/brian-team/brian2/forks","keys_url":"https://api.github.com/repos/brian-team/brian2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brian-team/brian2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brian-team/brian2/teams","hooks_url":"https://api.github.com/repos/brian-team/brian2/hooks","issue_events_url":"https://api.github.com/repos/brian-team/brian2/issues/events{/number}","events_url":"https://api.github.com/repos/brian-team/brian2/events","assignees_url":"https://api.github.com/repos/brian-team/brian2/assignees{/user}","branches_url":"https://api.github.com/repos/brian-team/brian2/branches{/branch}","tags_url":"https://api.github.com/repos/brian-team/brian2/tags","blobs_url":"https://api.github.com/repos/brian-team/brian2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brian-team/brian2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brian-team/brian2/git/refs{/sha}","trees_url":"https://api.github.com/repos/brian-team/brian2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brian-team/brian2/statuses/{sha}","languages_url":"https://api.github.com/repos/brian-team/brian2/languages","stargazers_url":"https://api.github.com/repos/brian-team/brian2/stargazers","contributors_url":"https://api.github.com/repos/brian-team/brian2/contributors","subscribers_url":"https://api.github.com/repos/brian-team/brian2/subscribers","subscription_url":"https://api.github.com/repos/brian-team/brian2/subscription","commits_url":"https://api.github.com/repos/brian-team/brian2/commits{/sha}","git_commits_url":"https://api.github.com/repos/brian-team/brian2/git/commits{/sha}","comments_url":"https://api.github.com/repos/brian-team/brian2/comments{/number}","issue_comment_url":"https://api.github.com/repos/brian-team/brian2/issues/comments{/number}","contents_url":"https://api.github.com/repos/brian-team/brian2/contents/{+path}","compare_url":"https://api.github.com/repos/brian-team/brian2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brian-team/brian2/merges","archive_url":"https://api.github.com/repos/brian-team/brian2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brian-team/brian2/downloads","issues_url":"https://api.github.com/repos/brian-team/brian2/issues{/number}","pulls_url":"https://api.github.com/repos/brian-team/brian2/pulls{/number}","milestones_url":"https://api.github.com/repos/brian-team/brian2/milestones{/number}","notifications_url":"https://api.github.com/repos/brian-team/brian2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brian-team/brian2/labels{/name}","releases_url":"https://api.github.com/repos/brian-team/brian2/releases{/id}","created_at":"2012-11-27T13:46:43Z","updated_at":"2015-03-23T18:14:47Z","pushed_at":"2015-03-23T18:14:47Z","git_url":"git://github.com/brian-team/brian2.git","ssh_url":"git@github.com:brian-team/brian2.git","clone_url":"https://github.com/brian-team/brian2.git","svn_url":"https://github.com/brian-team/brian2","homepage":"","size":14338,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":106,"forks":16,"open_issues":106,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brian-team/brian2/pulls/432"},"html":{"href":"https://github.com/brian-team/brian2/pull/432"},"issue":{"href":"https://api.github.com/repos/brian-team/brian2/issues/432"},"comments":{"href":"https://api.github.com/repos/brian-team/brian2/issues/432/comments"},"review_comments":{"href":"https://api.github.com/repos/brian-team/brian2/pulls/432/comments"},"review_comment":{"href":"https://api.github.com/repos/brian-team/brian2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brian-team/brian2/pulls/432/commits"},"statuses":{"href":"https://api.github.com/repos/brian-team/brian2/statuses/294d42f297a59bff5d0a80f1457c6e85c08d5a55"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"thesamovar","id":2903870,"avatar_url":"https://avatars.githubusercontent.com/u/2903870?v=3","gravatar_id":"","url":"https://api.github.com/users/thesamovar","html_url":"https://github.com/thesamovar","followers_url":"https://api.github.com/users/thesamovar/followers","following_url":"https://api.github.com/users/thesamovar/following{/other_user}","gists_url":"https://api.github.com/users/thesamovar/gists{/gist_id}","starred_url":"https://api.github.com/users/thesamovar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesamovar/subscriptions","organizations_url":"https://api.github.com/users/thesamovar/orgs","repos_url":"https://api.github.com/users/thesamovar/repos","events_url":"https://api.github.com/users/thesamovar/events{/privacy}","received_events_url":"https://api.github.com/users/thesamovar/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":79,"deletions":46,"changed_files":5}}