{"action":"created","issue":{"url":"https://api.github.com/repos/personalrobotics/prpy/issues/194","labels_url":"https://api.github.com/repos/personalrobotics/prpy/issues/194/labels{/name}","comments_url":"https://api.github.com/repos/personalrobotics/prpy/issues/194/comments","events_url":"https://api.github.com/repos/personalrobotics/prpy/issues/194/events","html_url":"https://github.com/personalrobotics/prpy/pull/194","id":108877693,"number":194,"title":"Patched TSR wrapping to use Bw_cont and added TSR unit test.","user":{"login":"psigen","id":2805291,"avatar_url":"https://avatars.githubusercontent.com/u/2805291?v=3","gravatar_id":"","url":"https://api.github.com/users/psigen","html_url":"https://github.com/psigen","followers_url":"https://api.github.com/users/psigen/followers","following_url":"https://api.github.com/users/psigen/following{/other_user}","gists_url":"https://api.github.com/users/psigen/gists{/gist_id}","starred_url":"https://api.github.com/users/psigen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psigen/subscriptions","organizations_url":"https://api.github.com/users/psigen/orgs","repos_url":"https://api.github.com/users/psigen/repos","events_url":"https://api.github.com/users/psigen/events{/privacy}","received_events_url":"https://api.github.com/users/psigen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/personalrobotics/prpy/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-29T14:09:19Z","updated_at":"2015-10-06T21:48:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/personalrobotics/prpy/pulls/194","html_url":"https://github.com/personalrobotics/prpy/pull/194","diff_url":"https://github.com/personalrobotics/prpy/pull/194.diff","patch_url":"https://github.com/personalrobotics/prpy/pull/194.patch"},"body":"This PR addresses https://github.com/personalrobotics/prpy/issues/190 by changing the wrapping function to be bounds-aware.  This allows wrapping into the `Bw` interval for checks, and wrapping into the `[-pi, pi)` interval for samples, and also fixes various bugs with zero-measure intervals wrapping incorrectly.\r\n\r\nThe PR also adds a unit test for TSRs, although it is very simple right now."},"comment":{"url":"https://api.github.com/repos/personalrobotics/prpy/issues/comments/146011244","html_url":"https://github.com/personalrobotics/prpy/pull/194#issuecomment-146011244","issue_url":"https://api.github.com/repos/personalrobotics/prpy/issues/194","id":146011244,"user":{"login":"mkoval","id":142251,"avatar_url":"https://avatars.githubusercontent.com/u/142251?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoval","html_url":"https://github.com/mkoval","followers_url":"https://api.github.com/users/mkoval/followers","following_url":"https://api.github.com/users/mkoval/following{/other_user}","gists_url":"https://api.github.com/users/mkoval/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoval/subscriptions","organizations_url":"https://api.github.com/users/mkoval/orgs","repos_url":"https://api.github.com/users/mkoval/repos","events_url":"https://api.github.com/users/mkoval/events{/privacy}","received_events_url":"https://api.github.com/users/mkoval/received_events","type":"User","site_admin":false},"created_at":"2015-10-06T21:48:03Z","updated_at":"2015-10-06T21:48:03Z","body":"This pull request most likely does not fix the `contains` function if `Bw` wraps around `pi`. However, it does fix a major regression in `sample` that was causing issues with the `block_sorting` and `table_clearing` demos, so I am merging it.\r\n\r\nI'll create another issue to track the `contains` issue."}}