{"action":"created","issue":{"url":"https://api.github.com/repos/LearnersGuild/product-development/issues/2","labels_url":"https://api.github.com/repos/LearnersGuild/product-development/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/LearnersGuild/product-development/issues/2/comments","events_url":"https://api.github.com/repos/LearnersGuild/product-development/issues/2/events","html_url":"https://github.com/LearnersGuild/product-development/issues/2","id":115113726,"number":2,"title":"Review & suggestions","user":{"login":"tannerwelsh","id":709100,"avatar_url":"https://avatars.githubusercontent.com/u/709100?v=3","gravatar_id":"","url":"https://api.github.com/users/tannerwelsh","html_url":"https://github.com/tannerwelsh","followers_url":"https://api.github.com/users/tannerwelsh/followers","following_url":"https://api.github.com/users/tannerwelsh/following{/other_user}","gists_url":"https://api.github.com/users/tannerwelsh/gists{/gist_id}","starred_url":"https://api.github.com/users/tannerwelsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannerwelsh/subscriptions","organizations_url":"https://api.github.com/users/tannerwelsh/orgs","repos_url":"https://api.github.com/users/tannerwelsh/repos","events_url":"https://api.github.com/users/tannerwelsh/events{/privacy}","received_events_url":"https://api.github.com/users/tannerwelsh/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/LearnersGuild/product-development/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-04T18:11:16Z","updated_at":"2015-11-11T23:01:24Z","closed_at":"2015-11-11T19:47:53Z","body":"This is a good start. I reviewed and will put a bit more thought into changes that I'd make and submit my own PRs.\r\n\r\n---\r\n\r\nSeems too strongly coupled to technical topic (programming). Services should support learning practices, and not be tied to the subject being learned.\r\n\r\nTo keep focus on core vs. auxiliary services, thinking about what can be accomplished by third-party tools vs. what should be part of our system. Here's how I'd break it down:\r\n\r\n**Core services**\r\n- identity\r\n- admissions\r\n- feedback\r\n- pairing\r\n\r\n**Auxiliary services** (consider using third party software)\r\n- group collaboration\r\n- task list\r\n- surveys\r\n- collaborative decision making\r\n\r\n**Not sure whether core/external**\r\n- alumni portal\r\n\r\n**Remove or reconsider**\r\n- challenge authoring\r\n- challenge taking\r\n\r\n**Other services**\r\n- project management (likely auxiliary)\r\n- dashboard (internal): primary UI to bind other services\r\n- aptitude graph (internal): graph of skills/knowledge forming a \"map\" of what is to be learned)\r\n\r\nAnother section that could be useful is a \"Standard Toolkit\". I'd see this composed of:\r\n\r\n- Service generator\r\n  <br>Boilerplate app for rapid prototyping, follows our established best practices/global requirements and easily integrates into the SOA\r\n- Dev env manager\r\n  <br>Like boxen https://github.com/boxen/our-boxen/\r\n\r\nLike the best practices, would add these to the list:\r\n\r\n- follow a style guide\r\n- prefer latest releases for all dependencies\r\n- testing:\r\n  - unit test suite should run in < 5sec\r\n  - write integration tests for all common use cases\r\n  - seek at least 90% test coverage"},"comment":{"url":"https://api.github.com/repos/LearnersGuild/product-development/issues/comments/155936905","html_url":"https://github.com/LearnersGuild/product-development/issues/2#issuecomment-155936905","issue_url":"https://api.github.com/repos/LearnersGuild/product-development/issues/2","id":155936905,"user":{"login":"tannerwelsh","id":709100,"avatar_url":"https://avatars.githubusercontent.com/u/709100?v=3","gravatar_id":"","url":"https://api.github.com/users/tannerwelsh","html_url":"https://github.com/tannerwelsh","followers_url":"https://api.github.com/users/tannerwelsh/followers","following_url":"https://api.github.com/users/tannerwelsh/following{/other_user}","gists_url":"https://api.github.com/users/tannerwelsh/gists{/gist_id}","starred_url":"https://api.github.com/users/tannerwelsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannerwelsh/subscriptions","organizations_url":"https://api.github.com/users/tannerwelsh/orgs","repos_url":"https://api.github.com/users/tannerwelsh/repos","events_url":"https://api.github.com/users/tannerwelsh/events{/privacy}","received_events_url":"https://api.github.com/users/tannerwelsh/received_events","type":"User","site_admin":false},"created_at":"2015-11-11T23:01:24Z","updated_at":"2015-11-11T23:01:24Z","body":":+1: thanks!"}}