{"action":"opened","number":213,"pull_request":{"url":"https://api.github.com/repos/coinbase/toshi/pulls/213","id":44748542,"html_url":"https://github.com/coinbase/toshi/pull/213","diff_url":"https://github.com/coinbase/toshi/pull/213.diff","patch_url":"https://github.com/coinbase/toshi/pull/213.patch","issue_url":"https://api.github.com/repos/coinbase/toshi/issues/213","number":213,"state":"open","locked":false,"title":"Extract shared behavior module from Transaction and UnconfirmedTransaction","user":{"login":"georgemillo","id":2656485,"avatar_url":"https://avatars.githubusercontent.com/u/2656485?v=3","gravatar_id":"","url":"https://api.github.com/users/georgemillo","html_url":"https://github.com/georgemillo","followers_url":"https://api.github.com/users/georgemillo/followers","following_url":"https://api.github.com/users/georgemillo/following{/other_user}","gists_url":"https://api.github.com/users/georgemillo/gists{/gist_id}","starred_url":"https://api.github.com/users/georgemillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgemillo/subscriptions","organizations_url":"https://api.github.com/users/georgemillo/orgs","repos_url":"https://api.github.com/users/georgemillo/repos","events_url":"https://api.github.com/users/georgemillo/events{/privacy}","received_events_url":"https://api.github.com/users/georgemillo/received_events","type":"User","site_admin":false},"body":"Transaction and UnconfirmedTransaction have a lot of identical or very similar code. This PR extracts the lowest-hanging fruit into a shared module to make it more DRY.\r\n\r\nI'm not sure if `TransactionShared` is the best name, or if `toshi/models` is the best place to put it - what do you think?","created_at":"2015-09-11T05:50:26Z","updated_at":"2015-09-11T05:50:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coinbase/toshi/pulls/213/commits","review_comments_url":"https://api.github.com/repos/coinbase/toshi/pulls/213/comments","review_comment_url":"https://api.github.com/repos/coinbase/toshi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coinbase/toshi/issues/213/comments","statuses_url":"https://api.github.com/repos/coinbase/toshi/statuses/d1ec2fbb234f19b0a8c100fe918fca2936c91bc6","head":{"label":"georgemillo:transaction-shared","ref":"transaction-shared","sha":"d1ec2fbb234f19b0a8c100fe918fca2936c91bc6","user":{"login":"georgemillo","id":2656485,"avatar_url":"https://avatars.githubusercontent.com/u/2656485?v=3","gravatar_id":"","url":"https://api.github.com/users/georgemillo","html_url":"https://github.com/georgemillo","followers_url":"https://api.github.com/users/georgemillo/followers","following_url":"https://api.github.com/users/georgemillo/following{/other_user}","gists_url":"https://api.github.com/users/georgemillo/gists{/gist_id}","starred_url":"https://api.github.com/users/georgemillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgemillo/subscriptions","organizations_url":"https://api.github.com/users/georgemillo/orgs","repos_url":"https://api.github.com/users/georgemillo/repos","events_url":"https://api.github.com/users/georgemillo/events{/privacy}","received_events_url":"https://api.github.com/users/georgemillo/received_events","type":"User","site_admin":false},"repo":{"id":42282671,"name":"toshi","full_name":"georgemillo/toshi","owner":{"login":"georgemillo","id":2656485,"avatar_url":"https://avatars.githubusercontent.com/u/2656485?v=3","gravatar_id":"","url":"https://api.github.com/users/georgemillo","html_url":"https://github.com/georgemillo","followers_url":"https://api.github.com/users/georgemillo/followers","following_url":"https://api.github.com/users/georgemillo/following{/other_user}","gists_url":"https://api.github.com/users/georgemillo/gists{/gist_id}","starred_url":"https://api.github.com/users/georgemillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgemillo/subscriptions","organizations_url":"https://api.github.com/users/georgemillo/orgs","repos_url":"https://api.github.com/users/georgemillo/repos","events_url":"https://api.github.com/users/georgemillo/events{/privacy}","received_events_url":"https://api.github.com/users/georgemillo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/georgemillo/toshi","description":"An open source Bitcoin node built to power large scale web applications.","fork":true,"url":"https://api.github.com/repos/georgemillo/toshi","forks_url":"https://api.github.com/repos/georgemillo/toshi/forks","keys_url":"https://api.github.com/repos/georgemillo/toshi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/georgemillo/toshi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/georgemillo/toshi/teams","hooks_url":"https://api.github.com/repos/georgemillo/toshi/hooks","issue_events_url":"https://api.github.com/repos/georgemillo/toshi/issues/events{/number}","events_url":"https://api.github.com/repos/georgemillo/toshi/events","assignees_url":"https://api.github.com/repos/georgemillo/toshi/assignees{/user}","branches_url":"https://api.github.com/repos/georgemillo/toshi/branches{/branch}","tags_url":"https://api.github.com/repos/georgemillo/toshi/tags","blobs_url":"https://api.github.com/repos/georgemillo/toshi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/georgemillo/toshi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/georgemillo/toshi/git/refs{/sha}","trees_url":"https://api.github.com/repos/georgemillo/toshi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/georgemillo/toshi/statuses/{sha}","languages_url":"https://api.github.com/repos/georgemillo/toshi/languages","stargazers_url":"https://api.github.com/repos/georgemillo/toshi/stargazers","contributors_url":"https://api.github.com/repos/georgemillo/toshi/contributors","subscribers_url":"https://api.github.com/repos/georgemillo/toshi/subscribers","subscription_url":"https://api.github.com/repos/georgemillo/toshi/subscription","commits_url":"https://api.github.com/repos/georgemillo/toshi/commits{/sha}","git_commits_url":"https://api.github.com/repos/georgemillo/toshi/git/commits{/sha}","comments_url":"https://api.github.com/repos/georgemillo/toshi/comments{/number}","issue_comment_url":"https://api.github.com/repos/georgemillo/toshi/issues/comments{/number}","contents_url":"https://api.github.com/repos/georgemillo/toshi/contents/{+path}","compare_url":"https://api.github.com/repos/georgemillo/toshi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/georgemillo/toshi/merges","archive_url":"https://api.github.com/repos/georgemillo/toshi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/georgemillo/toshi/downloads","issues_url":"https://api.github.com/repos/georgemillo/toshi/issues{/number}","pulls_url":"https://api.github.com/repos/georgemillo/toshi/pulls{/number}","milestones_url":"https://api.github.com/repos/georgemillo/toshi/milestones{/number}","notifications_url":"https://api.github.com/repos/georgemillo/toshi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/georgemillo/toshi/labels{/name}","releases_url":"https://api.github.com/repos/georgemillo/toshi/releases{/id}","created_at":"2015-09-11T02:25:41Z","updated_at":"2015-09-11T02:25:42Z","pushed_at":"2015-09-11T05:44:52Z","git_url":"git://github.com/georgemillo/toshi.git","ssh_url":"git@github.com:georgemillo/toshi.git","clone_url":"https://github.com/georgemillo/toshi.git","svn_url":"https://github.com/georgemillo/toshi","homepage":"https://toshi.io","size":3966,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coinbase:master","ref":"master","sha":"f7083d6df65fade61d586b860f8b2058005aec80","user":{"login":"coinbase","id":1885080,"avatar_url":"https://avatars.githubusercontent.com/u/1885080?v=3","gravatar_id":"","url":"https://api.github.com/users/coinbase","html_url":"https://github.com/coinbase","followers_url":"https://api.github.com/users/coinbase/followers","following_url":"https://api.github.com/users/coinbase/following{/other_user}","gists_url":"https://api.github.com/users/coinbase/gists{/gist_id}","starred_url":"https://api.github.com/users/coinbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coinbase/subscriptions","organizations_url":"https://api.github.com/users/coinbase/orgs","repos_url":"https://api.github.com/users/coinbase/repos","events_url":"https://api.github.com/users/coinbase/events{/privacy}","received_events_url":"https://api.github.com/users/coinbase/received_events","type":"Organization","site_admin":false},"repo":{"id":23672982,"name":"toshi","full_name":"coinbase/toshi","owner":{"login":"coinbase","id":1885080,"avatar_url":"https://avatars.githubusercontent.com/u/1885080?v=3","gravatar_id":"","url":"https://api.github.com/users/coinbase","html_url":"https://github.com/coinbase","followers_url":"https://api.github.com/users/coinbase/followers","following_url":"https://api.github.com/users/coinbase/following{/other_user}","gists_url":"https://api.github.com/users/coinbase/gists{/gist_id}","starred_url":"https://api.github.com/users/coinbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coinbase/subscriptions","organizations_url":"https://api.github.com/users/coinbase/orgs","repos_url":"https://api.github.com/users/coinbase/repos","events_url":"https://api.github.com/users/coinbase/events{/privacy}","received_events_url":"https://api.github.com/users/coinbase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coinbase/toshi","description":"An open source Bitcoin node built to power large scale web applications.","fork":false,"url":"https://api.github.com/repos/coinbase/toshi","forks_url":"https://api.github.com/repos/coinbase/toshi/forks","keys_url":"https://api.github.com/repos/coinbase/toshi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coinbase/toshi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coinbase/toshi/teams","hooks_url":"https://api.github.com/repos/coinbase/toshi/hooks","issue_events_url":"https://api.github.com/repos/coinbase/toshi/issues/events{/number}","events_url":"https://api.github.com/repos/coinbase/toshi/events","assignees_url":"https://api.github.com/repos/coinbase/toshi/assignees{/user}","branches_url":"https://api.github.com/repos/coinbase/toshi/branches{/branch}","tags_url":"https://api.github.com/repos/coinbase/toshi/tags","blobs_url":"https://api.github.com/repos/coinbase/toshi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coinbase/toshi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coinbase/toshi/git/refs{/sha}","trees_url":"https://api.github.com/repos/coinbase/toshi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coinbase/toshi/statuses/{sha}","languages_url":"https://api.github.com/repos/coinbase/toshi/languages","stargazers_url":"https://api.github.com/repos/coinbase/toshi/stargazers","contributors_url":"https://api.github.com/repos/coinbase/toshi/contributors","subscribers_url":"https://api.github.com/repos/coinbase/toshi/subscribers","subscription_url":"https://api.github.com/repos/coinbase/toshi/subscription","commits_url":"https://api.github.com/repos/coinbase/toshi/commits{/sha}","git_commits_url":"https://api.github.com/repos/coinbase/toshi/git/commits{/sha}","comments_url":"https://api.github.com/repos/coinbase/toshi/comments{/number}","issue_comment_url":"https://api.github.com/repos/coinbase/toshi/issues/comments{/number}","contents_url":"https://api.github.com/repos/coinbase/toshi/contents/{+path}","compare_url":"https://api.github.com/repos/coinbase/toshi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coinbase/toshi/merges","archive_url":"https://api.github.com/repos/coinbase/toshi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coinbase/toshi/downloads","issues_url":"https://api.github.com/repos/coinbase/toshi/issues{/number}","pulls_url":"https://api.github.com/repos/coinbase/toshi/pulls{/number}","milestones_url":"https://api.github.com/repos/coinbase/toshi/milestones{/number}","notifications_url":"https://api.github.com/repos/coinbase/toshi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coinbase/toshi/labels{/name}","releases_url":"https://api.github.com/repos/coinbase/toshi/releases{/id}","created_at":"2014-09-04T17:53:22Z","updated_at":"2015-09-11T02:25:47Z","pushed_at":"2015-09-11T05:47:54Z","git_url":"git://github.com/coinbase/toshi.git","ssh_url":"git@github.com:coinbase/toshi.git","clone_url":"https://github.com/coinbase/toshi.git","svn_url":"https://github.com/coinbase/toshi","homepage":"https://toshi.io","size":5300,"stargazers_count":619,"watchers_count":619,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":133,"mirror_url":null,"open_issues_count":76,"forks":133,"open_issues":76,"watchers":619,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coinbase/toshi/pulls/213"},"html":{"href":"https://github.com/coinbase/toshi/pull/213"},"issue":{"href":"https://api.github.com/repos/coinbase/toshi/issues/213"},"comments":{"href":"https://api.github.com/repos/coinbase/toshi/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/coinbase/toshi/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/coinbase/toshi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coinbase/toshi/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/coinbase/toshi/statuses/d1ec2fbb234f19b0a8c100fe918fca2936c91bc6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":91,"deletions":84,"changed_files":4}}