{"action":"created","comment":{"url":"https://api.github.com/repos/damianavila/RISE/pulls/comments/36052546","id":36052546,"diff_hunk":"@@ -0,0 +1,18 @@\n+{\n+  \"name\": \"fulminologist\",","path":"package.json","position":2,"original_position":2,"commit_id":"988e6f5959c1d8181725a4a6e5ce0b9ba7ddfc23","original_commit_id":"988e6f5959c1d8181725a4a6e5ce0b9ba7ddfc23","user":{"login":"bollwyvl","id":45380,"avatar_url":"https://avatars.githubusercontent.com/u/45380?v=3","gravatar_id":"","url":"https://api.github.com/users/bollwyvl","html_url":"https://github.com/bollwyvl","followers_url":"https://api.github.com/users/bollwyvl/followers","following_url":"https://api.github.com/users/bollwyvl/following{/other_user}","gists_url":"https://api.github.com/users/bollwyvl/gists{/gist_id}","starred_url":"https://api.github.com/users/bollwyvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollwyvl/subscriptions","organizations_url":"https://api.github.com/users/bollwyvl/orgs","repos_url":"https://api.github.com/users/bollwyvl/repos","events_url":"https://api.github.com/users/bollwyvl/events{/privacy}","received_events_url":"https://api.github.com/users/bollwyvl/received_events","type":"User","site_admin":false},"body":"Opps!","created_at":"2015-08-03T02:24:03Z","updated_at":"2015-08-03T02:24:03Z","html_url":"https://github.com/damianavila/RISE/pull/128#discussion_r36052546","pull_request_url":"https://api.github.com/repos/damianavila/RISE/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/damianavila/RISE/pulls/comments/36052546"},"html":{"href":"https://github.com/damianavila/RISE/pull/128#discussion_r36052546"},"pull_request":{"href":"https://api.github.com/repos/damianavila/RISE/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/damianavila/RISE/pulls/128","id":39764378,"html_url":"https://github.com/damianavila/RISE/pull/128","diff_url":"https://github.com/damianavila/RISE/pull/128.diff","patch_url":"https://github.com/damianavila/RISE/pull/128.patch","issue_url":"https://api.github.com/repos/damianavila/RISE/issues/128","number":128,"state":"open","locked":false,"title":"Mode transitions, LESS","user":{"login":"bollwyvl","id":45380,"avatar_url":"https://avatars.githubusercontent.com/u/45380?v=3","gravatar_id":"","url":"https://api.github.com/users/bollwyvl","html_url":"https://github.com/bollwyvl","followers_url":"https://api.github.com/users/bollwyvl/followers","following_url":"https://api.github.com/users/bollwyvl/following{/other_user}","gists_url":"https://api.github.com/users/bollwyvl/gists{/gist_id}","starred_url":"https://api.github.com/users/bollwyvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollwyvl/subscriptions","organizations_url":"https://api.github.com/users/bollwyvl/orgs","repos_url":"https://api.github.com/users/bollwyvl/repos","events_url":"https://api.github.com/users/bollwyvl/events{/privacy}","received_events_url":"https://api.github.com/users/bollwyvl/received_events","type":"User","site_admin":false},"body":"Jumping between slide and notebook modes is a little jarring.\r\n\r\nThis adds some transitions, maybe too many, to the transition between the modes.\r\n\r\n> screenshot\r\n![](http://i.imgur.com/EUcy4PI.gif)\r\n\r\nTo achieve this, it needs a few things:\r\n- the styles have to be loaded when modes change: this means the CSS has to be added prior to switching modes, and has to be there when you leave...\r\n  - thus, the styles get added at extension setup time...\r\n- to keep the styles from firing all the time against important elements like `#site`, the `body` is given a `rise-enabled` class, and all of the styles are conditional off being inside that\r\n  - to do this, I have ported the CSS to LESS rather than putting `.rise-enabled` in front of every directive\r\n- this also shortens the code some, as CSS not directly manipulated by reveal can be done in CSS\r\n\r\n## tool creep\r\nI hate tool creep as much as the next guy, but i think it makes sense in this case. LESS is a good choice because of the upstream (though with phosphor, i guess we'll have to start contending with stylus, too?). I've used `watch` to let us have live compiling without gulp/grunt.\r\n\r\nOnce the die is cast, however, things like bower may follow. even if the bower components still get checked in, they could be checked in on a `dist`-like folder so that we're not tracking all _n_000 reveal files.","created_at":"2015-07-12T16:20:37Z","updated_at":"2015-08-03T02:24:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20ed6bd5db61f7c0e8dc4c3ac4809f4a6c468213","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/damianavila/RISE/pulls/128/commits","review_comments_url":"https://api.github.com/repos/damianavila/RISE/pulls/128/comments","review_comment_url":"https://api.github.com/repos/damianavila/RISE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/damianavila/RISE/issues/128/comments","statuses_url":"https://api.github.com/repos/damianavila/RISE/statuses/988e6f5959c1d8181725a4a6e5ce0b9ba7ddfc23","head":{"label":"bollwyvl:mode-transitions","ref":"mode-transitions","sha":"988e6f5959c1d8181725a4a6e5ce0b9ba7ddfc23","user":{"login":"bollwyvl","id":45380,"avatar_url":"https://avatars.githubusercontent.com/u/45380?v=3","gravatar_id":"","url":"https://api.github.com/users/bollwyvl","html_url":"https://github.com/bollwyvl","followers_url":"https://api.github.com/users/bollwyvl/followers","following_url":"https://api.github.com/users/bollwyvl/following{/other_user}","gists_url":"https://api.github.com/users/bollwyvl/gists{/gist_id}","starred_url":"https://api.github.com/users/bollwyvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollwyvl/subscriptions","organizations_url":"https://api.github.com/users/bollwyvl/orgs","repos_url":"https://api.github.com/users/bollwyvl/repos","events_url":"https://api.github.com/users/bollwyvl/events{/privacy}","received_events_url":"https://api.github.com/users/bollwyvl/received_events","type":"User","site_admin":false},"repo":{"id":28945997,"name":"live_reveal","full_name":"bollwyvl/live_reveal","owner":{"login":"bollwyvl","id":45380,"avatar_url":"https://avatars.githubusercontent.com/u/45380?v=3","gravatar_id":"","url":"https://api.github.com/users/bollwyvl","html_url":"https://github.com/bollwyvl","followers_url":"https://api.github.com/users/bollwyvl/followers","following_url":"https://api.github.com/users/bollwyvl/following{/other_user}","gists_url":"https://api.github.com/users/bollwyvl/gists{/gist_id}","starred_url":"https://api.github.com/users/bollwyvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollwyvl/subscriptions","organizations_url":"https://api.github.com/users/bollwyvl/orgs","repos_url":"https://api.github.com/users/bollwyvl/repos","events_url":"https://api.github.com/users/bollwyvl/events{/privacy}","received_events_url":"https://api.github.com/users/bollwyvl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bollwyvl/live_reveal","description":"RJSE/RISE: \"LIVE\" Reveal - Jupyter/IPython Slideshow Extension","fork":true,"url":"https://api.github.com/repos/bollwyvl/live_reveal","forks_url":"https://api.github.com/repos/bollwyvl/live_reveal/forks","keys_url":"https://api.github.com/repos/bollwyvl/live_reveal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bollwyvl/live_reveal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bollwyvl/live_reveal/teams","hooks_url":"https://api.github.com/repos/bollwyvl/live_reveal/hooks","issue_events_url":"https://api.github.com/repos/bollwyvl/live_reveal/issues/events{/number}","events_url":"https://api.github.com/repos/bollwyvl/live_reveal/events","assignees_url":"https://api.github.com/repos/bollwyvl/live_reveal/assignees{/user}","branches_url":"https://api.github.com/repos/bollwyvl/live_reveal/branches{/branch}","tags_url":"https://api.github.com/repos/bollwyvl/live_reveal/tags","blobs_url":"https://api.github.com/repos/bollwyvl/live_reveal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bollwyvl/live_reveal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bollwyvl/live_reveal/git/refs{/sha}","trees_url":"https://api.github.com/repos/bollwyvl/live_reveal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bollwyvl/live_reveal/statuses/{sha}","languages_url":"https://api.github.com/repos/bollwyvl/live_reveal/languages","stargazers_url":"https://api.github.com/repos/bollwyvl/live_reveal/stargazers","contributors_url":"https://api.github.com/repos/bollwyvl/live_reveal/contributors","subscribers_url":"https://api.github.com/repos/bollwyvl/live_reveal/subscribers","subscription_url":"https://api.github.com/repos/bollwyvl/live_reveal/subscription","commits_url":"https://api.github.com/repos/bollwyvl/live_reveal/commits{/sha}","git_commits_url":"https://api.github.com/repos/bollwyvl/live_reveal/git/commits{/sha}","comments_url":"https://api.github.com/repos/bollwyvl/live_reveal/comments{/number}","issue_comment_url":"https://api.github.com/repos/bollwyvl/live_reveal/issues/comments{/number}","contents_url":"https://api.github.com/repos/bollwyvl/live_reveal/contents/{+path}","compare_url":"https://api.github.com/repos/bollwyvl/live_reveal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bollwyvl/live_reveal/merges","archive_url":"https://api.github.com/repos/bollwyvl/live_reveal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bollwyvl/live_reveal/downloads","issues_url":"https://api.github.com/repos/bollwyvl/live_reveal/issues{/number}","pulls_url":"https://api.github.com/repos/bollwyvl/live_reveal/pulls{/number}","milestones_url":"https://api.github.com/repos/bollwyvl/live_reveal/milestones{/number}","notifications_url":"https://api.github.com/repos/bollwyvl/live_reveal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bollwyvl/live_reveal/labels{/name}","releases_url":"https://api.github.com/repos/bollwyvl/live_reveal/releases{/id}","created_at":"2015-01-08T03:01:30Z","updated_at":"2015-01-08T03:01:31Z","pushed_at":"2015-07-12T15:53:18Z","git_url":"git://github.com/bollwyvl/live_reveal.git","ssh_url":"git@github.com:bollwyvl/live_reveal.git","clone_url":"https://github.com/bollwyvl/live_reveal.git","svn_url":"https://github.com/bollwyvl/live_reveal","homepage":"","size":676,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"damianavila:master","ref":"master","sha":"56eff79aac0a0c49ad212c6944ff2fd16c774b65","user":{"login":"damianavila","id":1640669,"avatar_url":"https://avatars.githubusercontent.com/u/1640669?v=3","gravatar_id":"","url":"https://api.github.com/users/damianavila","html_url":"https://github.com/damianavila","followers_url":"https://api.github.com/users/damianavila/followers","following_url":"https://api.github.com/users/damianavila/following{/other_user}","gists_url":"https://api.github.com/users/damianavila/gists{/gist_id}","starred_url":"https://api.github.com/users/damianavila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianavila/subscriptions","organizations_url":"https://api.github.com/users/damianavila/orgs","repos_url":"https://api.github.com/users/damianavila/repos","events_url":"https://api.github.com/users/damianavila/events{/privacy}","received_events_url":"https://api.github.com/users/damianavila/received_events","type":"User","site_admin":false},"repo":{"id":12387090,"name":"RISE","full_name":"damianavila/RISE","owner":{"login":"damianavila","id":1640669,"avatar_url":"https://avatars.githubusercontent.com/u/1640669?v=3","gravatar_id":"","url":"https://api.github.com/users/damianavila","html_url":"https://github.com/damianavila","followers_url":"https://api.github.com/users/damianavila/followers","following_url":"https://api.github.com/users/damianavila/following{/other_user}","gists_url":"https://api.github.com/users/damianavila/gists{/gist_id}","starred_url":"https://api.github.com/users/damianavila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianavila/subscriptions","organizations_url":"https://api.github.com/users/damianavila/orgs","repos_url":"https://api.github.com/users/damianavila/repos","events_url":"https://api.github.com/users/damianavila/events{/privacy}","received_events_url":"https://api.github.com/users/damianavila/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/damianavila/RISE","description":"RISE: \"Live\" Reveal.js Jupyter/IPython Slideshow Extension","fork":false,"url":"https://api.github.com/repos/damianavila/RISE","forks_url":"https://api.github.com/repos/damianavila/RISE/forks","keys_url":"https://api.github.com/repos/damianavila/RISE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/damianavila/RISE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/damianavila/RISE/teams","hooks_url":"https://api.github.com/repos/damianavila/RISE/hooks","issue_events_url":"https://api.github.com/repos/damianavila/RISE/issues/events{/number}","events_url":"https://api.github.com/repos/damianavila/RISE/events","assignees_url":"https://api.github.com/repos/damianavila/RISE/assignees{/user}","branches_url":"https://api.github.com/repos/damianavila/RISE/branches{/branch}","tags_url":"https://api.github.com/repos/damianavila/RISE/tags","blobs_url":"https://api.github.com/repos/damianavila/RISE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/damianavila/RISE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/damianavila/RISE/git/refs{/sha}","trees_url":"https://api.github.com/repos/damianavila/RISE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/damianavila/RISE/statuses/{sha}","languages_url":"https://api.github.com/repos/damianavila/RISE/languages","stargazers_url":"https://api.github.com/repos/damianavila/RISE/stargazers","contributors_url":"https://api.github.com/repos/damianavila/RISE/contributors","subscribers_url":"https://api.github.com/repos/damianavila/RISE/subscribers","subscription_url":"https://api.github.com/repos/damianavila/RISE/subscription","commits_url":"https://api.github.com/repos/damianavila/RISE/commits{/sha}","git_commits_url":"https://api.github.com/repos/damianavila/RISE/git/commits{/sha}","comments_url":"https://api.github.com/repos/damianavila/RISE/comments{/number}","issue_comment_url":"https://api.github.com/repos/damianavila/RISE/issues/comments{/number}","contents_url":"https://api.github.com/repos/damianavila/RISE/contents/{+path}","compare_url":"https://api.github.com/repos/damianavila/RISE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/damianavila/RISE/merges","archive_url":"https://api.github.com/repos/damianavila/RISE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/damianavila/RISE/downloads","issues_url":"https://api.github.com/repos/damianavila/RISE/issues{/number}","pulls_url":"https://api.github.com/repos/damianavila/RISE/pulls{/number}","milestones_url":"https://api.github.com/repos/damianavila/RISE/milestones{/number}","notifications_url":"https://api.github.com/repos/damianavila/RISE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/damianavila/RISE/labels{/name}","releases_url":"https://api.github.com/repos/damianavila/RISE/releases{/id}","created_at":"2013-08-26T18:55:36Z","updated_at":"2015-08-01T10:37:27Z","pushed_at":"2015-08-02T19:07:39Z","git_url":"git://github.com/damianavila/RISE.git","ssh_url":"git@github.com:damianavila/RISE.git","clone_url":"https://github.com/damianavila/RISE.git","svn_url":"https://github.com/damianavila/RISE","homepage":"","size":1207,"stargazers_count":229,"watchers_count":229,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"open_issues_count":19,"forks":40,"open_issues":19,"watchers":229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/damianavila/RISE/pulls/128"},"html":{"href":"https://github.com/damianavila/RISE/pull/128"},"issue":{"href":"https://api.github.com/repos/damianavila/RISE/issues/128"},"comments":{"href":"https://api.github.com/repos/damianavila/RISE/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/damianavila/RISE/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/damianavila/RISE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/damianavila/RISE/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/damianavila/RISE/statuses/988e6f5959c1d8181725a4a6e5ce0b9ba7ddfc23"}}}}