{"action":"created","comment":{"url":"https://api.github.com/repos/windup/windup-rulesets/pulls/comments/31226392","id":31226392,"diff_hunk":"@@ -0,0 +1,1219 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<!DOCTYPE ruleset PUBLIC \"http://windup.jboss.org/ns/ruleset/2.3.0.Final\">\n+<ruleset id=\"WebSphereRules\"\n+        xmlns=\"http://windup.jboss.org/ns/ruleset/2.3.0.Final\"\n+        xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n+        xsi:schemaLocation=\"http://windup.jboss.org/ns/ruleset/2.3.0.Final file:/home/ondra/work/Migration/Windup/config-xml/addon/src/main/resources/windup-ruleset-2.3.0.Final.xsd\">\n+        <!-- http://windup.jboss.org/schema/windup-ruleset-2.3.0.Final.xsd -->\n+        <!-- file:/home/ondra/work/Migration/Windup/config-xml/addon/src/main/resources/windup-ruleset-2.3.0.Final.xsd -->\n+\n+    <metadata>\n+        <dependencies>\n+            <addon id=\"org.jboss.windup.rules,windup-rules-javaee,2.0.1.Final\"/>\n+            <addon id=\"org.jboss.windup.rules,windup-rules-java,2.0.0.Final\"/>\n+        </dependencies>\n+        <description>\n+            Provides analysis of WebSphere proprietary classes and constructs that may require individual attention when migrating to JBoss EAP 6+.\n+        </description>\n+        <sourceTechnology id=\"weblogic\" versionRange=\"(10,12]\"/>\n+        <targetTechnology id=\"eap\" versionRange=\"[6,)\"/>\n+        <tags>\n+            <tag>reviewed-2015-05-WIP</tag>\n+        </tags>\n+    </metadata>\n+\n+    <rules>\n+        <rule id=\"WebLogic-weblogic.net.http.HttpsURLConnection.loadLocalIdentity()\">\n+            <when>\n+                <javaclass references=\"weblogic.net.http.HttpsURLConnection.loadLocalIdentity()\" as=\"default\">\n+                </javaclass>\n+            </when>\n+            <perform>\n+                <hint message=\"Replace with `javax.net.ssl.HttpsURLConnection.getLocalPrincipal()`\" effort=\"2\"/>\n+            </perform>\n+        </rule>\n+        <rule id=\"WebLogic-weblogic.net.http.HttpsURLConnection\">","path":"rules-reviewed/jboss-eap/websphere/WebSphere.windup.xml","position":35,"original_position":35,"commit_id":"dc3a59561ee476eecac611f5343f0c2315bc5549","original_commit_id":"dc3a59561ee476eecac611f5343f0c2315bc5549","user":{"login":"mbriskar","id":1478315,"avatar_url":"https://avatars.githubusercontent.com/u/1478315?v=3","gravatar_id":"","url":"https://api.github.com/users/mbriskar","html_url":"https://github.com/mbriskar","followers_url":"https://api.github.com/users/mbriskar/followers","following_url":"https://api.github.com/users/mbriskar/following{/other_user}","gists_url":"https://api.github.com/users/mbriskar/gists{/gist_id}","starred_url":"https://api.github.com/users/mbriskar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbriskar/subscriptions","organizations_url":"https://api.github.com/users/mbriskar/orgs","repos_url":"https://api.github.com/users/mbriskar/repos","events_url":"https://api.github.com/users/mbriskar/events{/privacy}","received_events_url":"https://api.github.com/users/mbriskar/received_events","type":"User","site_admin":false},"body":"these IDs will need to be adjusted to yesterday's meeting","created_at":"2015-05-28T12:11:03Z","updated_at":"2015-05-28T12:11:03Z","html_url":"https://github.com/windup/windup-rulesets/pull/19#discussion_r31226392","pull_request_url":"https://api.github.com/repos/windup/windup-rulesets/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/comments/31226392"},"html":{"href":"https://github.com/windup/windup-rulesets/pull/19#discussion_r31226392"},"pull_request":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/windup/windup-rulesets/pulls/19","id":36283273,"html_url":"https://github.com/windup/windup-rulesets/pull/19","diff_url":"https://github.com/windup/windup-rulesets/pull/19.diff","patch_url":"https://github.com/windup/windup-rulesets/pull/19.patch","issue_url":"https://api.github.com/repos/windup/windup-rulesets/issues/19","number":19,"state":"open","locked":false,"title":"Rules check ondra windup 610    WINDUP-610  Rules check - Ondra","user":{"login":"OndraZizka","id":644904,"avatar_url":"https://avatars.githubusercontent.com/u/644904?v=3","gravatar_id":"","url":"https://api.github.com/users/OndraZizka","html_url":"https://github.com/OndraZizka","followers_url":"https://api.github.com/users/OndraZizka/followers","following_url":"https://api.github.com/users/OndraZizka/following{/other_user}","gists_url":"https://api.github.com/users/OndraZizka/gists{/gist_id}","starred_url":"https://api.github.com/users/OndraZizka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OndraZizka/subscriptions","organizations_url":"https://api.github.com/users/OndraZizka/orgs","repos_url":"https://api.github.com/users/OndraZizka/repos","events_url":"https://api.github.com/users/OndraZizka/events{/privacy}","received_events_url":"https://api.github.com/users/OndraZizka/received_events","type":"User","site_admin":false},"body":"First shot. Critics welcome. I would like to make it more like\r\n```xml\r\n<when>\r\n       <or>\r\n          <javaclass ...>\r\n          <javaclass ...>\r\n          <javaclass ...>\r\n          <javaclass ...>\r\n     </or>\r\n</when>\r\n<perform> ...\r\n```\r\nThat would make the whole ruleset much shorter. But seems that's not supported.","created_at":"2015-05-27T09:11:47Z","updated_at":"2015-05-28T12:11:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2f346091626b499d8ff32360b62df3819fa6eb3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/windup/windup-rulesets/pulls/19/commits","review_comments_url":"https://api.github.com/repos/windup/windup-rulesets/pulls/19/comments","review_comment_url":"https://api.github.com/repos/windup/windup-rulesets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/windup/windup-rulesets/issues/19/comments","statuses_url":"https://api.github.com/repos/windup/windup-rulesets/statuses/dc3a59561ee476eecac611f5343f0c2315bc5549","head":{"label":"OndraZizka:RulesCheckOndra-WINDUP-610","ref":"RulesCheckOndra-WINDUP-610","sha":"dc3a59561ee476eecac611f5343f0c2315bc5549","user":{"login":"OndraZizka","id":644904,"avatar_url":"https://avatars.githubusercontent.com/u/644904?v=3","gravatar_id":"","url":"https://api.github.com/users/OndraZizka","html_url":"https://github.com/OndraZizka","followers_url":"https://api.github.com/users/OndraZizka/followers","following_url":"https://api.github.com/users/OndraZizka/following{/other_user}","gists_url":"https://api.github.com/users/OndraZizka/gists{/gist_id}","starred_url":"https://api.github.com/users/OndraZizka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OndraZizka/subscriptions","organizations_url":"https://api.github.com/users/OndraZizka/orgs","repos_url":"https://api.github.com/users/OndraZizka/repos","events_url":"https://api.github.com/users/OndraZizka/events{/privacy}","received_events_url":"https://api.github.com/users/OndraZizka/received_events","type":"User","site_admin":false},"repo":{"id":36249911,"name":"windup-rulesets","full_name":"OndraZizka/windup-rulesets","owner":{"login":"OndraZizka","id":644904,"avatar_url":"https://avatars.githubusercontent.com/u/644904?v=3","gravatar_id":"","url":"https://api.github.com/users/OndraZizka","html_url":"https://github.com/OndraZizka","followers_url":"https://api.github.com/users/OndraZizka/followers","following_url":"https://api.github.com/users/OndraZizka/following{/other_user}","gists_url":"https://api.github.com/users/OndraZizka/gists{/gist_id}","starred_url":"https://api.github.com/users/OndraZizka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OndraZizka/subscriptions","organizations_url":"https://api.github.com/users/OndraZizka/orgs","repos_url":"https://api.github.com/users/OndraZizka/repos","events_url":"https://api.github.com/users/OndraZizka/events{/privacy}","received_events_url":"https://api.github.com/users/OndraZizka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OndraZizka/windup-rulesets","description":"Rules and rulesets contributed by community.","fork":true,"url":"https://api.github.com/repos/OndraZizka/windup-rulesets","forks_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/forks","keys_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/teams","hooks_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/hooks","issue_events_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/issues/events{/number}","events_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/events","assignees_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/assignees{/user}","branches_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/branches{/branch}","tags_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/tags","blobs_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/git/refs{/sha}","trees_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/statuses/{sha}","languages_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/languages","stargazers_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/stargazers","contributors_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/contributors","subscribers_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/subscribers","subscription_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/subscription","commits_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/commits{/sha}","git_commits_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/git/commits{/sha}","comments_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/comments{/number}","issue_comment_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/issues/comments{/number}","contents_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/contents/{+path}","compare_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/merges","archive_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/downloads","issues_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/issues{/number}","pulls_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/pulls{/number}","milestones_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/milestones{/number}","notifications_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/labels{/name}","releases_url":"https://api.github.com/repos/OndraZizka/windup-rulesets/releases{/id}","created_at":"2015-05-25T19:19:57Z","updated_at":"2015-05-25T19:19:58Z","pushed_at":"2015-05-27T09:43:09Z","git_url":"git://github.com/OndraZizka/windup-rulesets.git","ssh_url":"git@github.com:OndraZizka/windup-rulesets.git","clone_url":"https://github.com/OndraZizka/windup-rulesets.git","svn_url":"https://github.com/OndraZizka/windup-rulesets","homepage":null,"size":545,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"windup:master","ref":"master","sha":"cddf4dc24908322aa3f211c73d04059b4e60bf76","user":{"login":"windup","id":4266383,"avatar_url":"https://avatars.githubusercontent.com/u/4266383?v=3","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"repo":{"id":23937058,"name":"windup-rulesets","full_name":"windup/windup-rulesets","owner":{"login":"windup","id":4266383,"avatar_url":"https://avatars.githubusercontent.com/u/4266383?v=3","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/windup/windup-rulesets","description":"Rules and rulesets contributed by community.","fork":false,"url":"https://api.github.com/repos/windup/windup-rulesets","forks_url":"https://api.github.com/repos/windup/windup-rulesets/forks","keys_url":"https://api.github.com/repos/windup/windup-rulesets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windup/windup-rulesets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windup/windup-rulesets/teams","hooks_url":"https://api.github.com/repos/windup/windup-rulesets/hooks","issue_events_url":"https://api.github.com/repos/windup/windup-rulesets/issues/events{/number}","events_url":"https://api.github.com/repos/windup/windup-rulesets/events","assignees_url":"https://api.github.com/repos/windup/windup-rulesets/assignees{/user}","branches_url":"https://api.github.com/repos/windup/windup-rulesets/branches{/branch}","tags_url":"https://api.github.com/repos/windup/windup-rulesets/tags","blobs_url":"https://api.github.com/repos/windup/windup-rulesets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windup/windup-rulesets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windup/windup-rulesets/git/refs{/sha}","trees_url":"https://api.github.com/repos/windup/windup-rulesets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windup/windup-rulesets/statuses/{sha}","languages_url":"https://api.github.com/repos/windup/windup-rulesets/languages","stargazers_url":"https://api.github.com/repos/windup/windup-rulesets/stargazers","contributors_url":"https://api.github.com/repos/windup/windup-rulesets/contributors","subscribers_url":"https://api.github.com/repos/windup/windup-rulesets/subscribers","subscription_url":"https://api.github.com/repos/windup/windup-rulesets/subscription","commits_url":"https://api.github.com/repos/windup/windup-rulesets/commits{/sha}","git_commits_url":"https://api.github.com/repos/windup/windup-rulesets/git/commits{/sha}","comments_url":"https://api.github.com/repos/windup/windup-rulesets/comments{/number}","issue_comment_url":"https://api.github.com/repos/windup/windup-rulesets/issues/comments{/number}","contents_url":"https://api.github.com/repos/windup/windup-rulesets/contents/{+path}","compare_url":"https://api.github.com/repos/windup/windup-rulesets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windup/windup-rulesets/merges","archive_url":"https://api.github.com/repos/windup/windup-rulesets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windup/windup-rulesets/downloads","issues_url":"https://api.github.com/repos/windup/windup-rulesets/issues{/number}","pulls_url":"https://api.github.com/repos/windup/windup-rulesets/pulls{/number}","milestones_url":"https://api.github.com/repos/windup/windup-rulesets/milestones{/number}","notifications_url":"https://api.github.com/repos/windup/windup-rulesets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windup/windup-rulesets/labels{/name}","releases_url":"https://api.github.com/repos/windup/windup-rulesets/releases{/id}","created_at":"2014-09-11T21:51:19Z","updated_at":"2015-05-06T19:48:11Z","pushed_at":"2015-05-28T12:08:24Z","git_url":"git://github.com/windup/windup-rulesets.git","ssh_url":"git@github.com:windup/windup-rulesets.git","clone_url":"https://github.com/windup/windup-rulesets.git","svn_url":"https://github.com/windup/windup-rulesets","homepage":null,"size":545,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/19"},"html":{"href":"https://github.com/windup/windup-rulesets/pull/19"},"issue":{"href":"https://api.github.com/repos/windup/windup-rulesets/issues/19"},"comments":{"href":"https://api.github.com/repos/windup/windup-rulesets/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/windup/windup-rulesets/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/windup/windup-rulesets/statuses/dc3a59561ee476eecac611f5343f0c2315bc5549"}}}}