{"action":"created","comment":{"url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/pulls/comments/26993307","id":26993307,"diff_hunk":"@@ -555,6 +628,349 @@ protected GroupType build(String name) {\n           \"Cannot build an empty group\");\n       return new GroupType(repetition, name, originalType, fields, id);\n     }\n+\n+    public MapBuilder<Q> map(\n+        Type.Repetition repetition) {\n+      return new MapBuilder<Q>(self()).repetition(repetition);\n+    }\n+\n+    public MapBuilder<Q> requiredMap() {\n+      return new MapBuilder<Q>(self())\n+          .repetition(Type.Repetition.REQUIRED);\n+    }\n+\n+    public MapBuilder<Q> optionalMap() {\n+      return new MapBuilder<Q>(self())\n+          .repetition(Type.Repetition.OPTIONAL);\n+    }\n+\n+    public ListBuilder<BaseGroupBuilder<P, Q>> list(Type.Repetition repetition) {\n+      return new ListBuilder<BaseGroupBuilder<P, Q>>(this).repetition(repetition);\n+    }\n+\n+    public ListBuilder<BaseGroupBuilder<P, Q>> requiredList() {\n+      return list(Type.Repetition.REQUIRED);\n+    }\n+\n+    public ListBuilder<BaseGroupBuilder<P, Q>> optionalList() {\n+      return list(Type.Repetition.OPTIONAL);\n+    }\n+  }\n+\n+  /**\n+   * A builder for {@link GroupType} objects.\n+   *\n+   * @param <P> The type that this builder will return from\n+   *          {@link #named(String)} when the type is built.\n+   */\n+  public static class GroupBuilder<P> extends BaseGroupBuilder<P, GroupBuilder<P>> {\n+\n+    private GroupBuilder(P parent) {\n+      super(parent);\n+    }\n+\n+    private GroupBuilder(Class<P> returnType) {\n+      super(returnType);\n+    }\n+\n+    @Override\n+    protected GroupBuilder<P> self() {\n+      return this;\n+    }\n+  }\n+\n+  public static class MapBuilder<P> extends Builder<MapBuilder<P>, P> {\n+    private static final Type STRING_KEY = Types\n+        .required(PrimitiveTypeName.BINARY).as(OriginalType.UTF8).named(\"key\");\n+\n+    public static class MapKeyBuilder<P> extends BasePrimitiveBuilder<P, MapKeyBuilder<P>> {\n+      private MapBuilder<P> parent = null;\n+\n+      public MapKeyBuilder(MapBuilder<P> parent, PrimitiveTypeName type) {\n+        super(parent.parent, type);\n+        this.parent = parent;\n+        repetition(Type.Repetition.REQUIRED);\n+      }\n+\n+      public MapKeyBuilder(MapBuilder<P> parent, Class<P> returnType, PrimitiveTypeName type) {","path":"parquet-column/src/main/java/parquet/schema/Types.java","position":null,"original_position":414,"commit_id":"857fe56aecf457f8d7dad360772b413180f0baac","original_commit_id":"7f5e070e6ce31846527a9b389ba1f2e87284933a","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"body":"It is being called from the method {{public MapKeyBuilder<P, Q> key(PrimitiveTypeName type)}}","created_at":"2015-03-24T00:01:30Z","updated_at":"2015-03-24T00:01:30Z","html_url":"https://github.com/rdblue/incubator-parquet-mr/pull/1#discussion_r26993307","pull_request_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/rdblue/incubator-parquet-mr/pulls/comments/26993307"},"html":{"href":"https://github.com/rdblue/incubator-parquet-mr/pull/1#discussion_r26993307"},"pull_request":{"href":"https://api.github.com/repos/rdblue/incubator-parquet-mr/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/pulls/1","id":30610660,"html_url":"https://github.com/rdblue/incubator-parquet-mr/pull/1","diff_url":"https://github.com/rdblue/incubator-parquet-mr/pull/1.diff","patch_url":"https://github.com/rdblue/incubator-parquet-mr/pull/1.patch","issue_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/issues/1","number":1,"state":"open","locked":false,"title":"Add map and list builders","user":{"login":"rdblue","id":87915,"avatar_url":"https://avatars.githubusercontent.com/u/87915?v=3","gravatar_id":"","url":"https://api.github.com/users/rdblue","html_url":"https://github.com/rdblue","followers_url":"https://api.github.com/users/rdblue/followers","following_url":"https://api.github.com/users/rdblue/following{/other_user}","gists_url":"https://api.github.com/users/rdblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rdblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdblue/subscriptions","organizations_url":"https://api.github.com/users/rdblue/orgs","repos_url":"https://api.github.com/users/rdblue/repos","events_url":"https://api.github.com/users/rdblue/events{/privacy}","received_events_url":"https://api.github.com/users/rdblue/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-06T00:28:23Z","updated_at":"2015-03-24T00:01:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c78894aa8bdc1c894356c2c062fe448dc6fb4e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/pulls/1/commits","review_comments_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/pulls/1/comments","review_comment_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/issues/1/comments","statuses_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/statuses/857fe56aecf457f8d7dad360772b413180f0baac","head":{"label":"SinghAsDev:map","ref":"map","sha":"857fe56aecf457f8d7dad360772b413180f0baac","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"repo":{"id":30125280,"name":"incubator-parquet-mr","full_name":"SinghAsDev/incubator-parquet-mr","owner":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SinghAsDev/incubator-parquet-mr","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr","forks_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/forks","keys_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/teams","hooks_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/events","assignees_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/tags","blobs_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/languages","stargazers_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/subscription","commits_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/issues/comments{/number}","contents_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/merges","archive_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/downloads","issues_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/SinghAsDev/incubator-parquet-mr/releases{/id}","created_at":"2015-01-31T20:28:15Z","updated_at":"2015-02-14T00:10:31Z","pushed_at":"2015-03-23T23:56:27Z","git_url":"git://github.com/SinghAsDev/incubator-parquet-mr.git","ssh_url":"git@github.com:SinghAsDev/incubator-parquet-mr.git","clone_url":"https://github.com/SinghAsDev/incubator-parquet-mr.git","svn_url":"https://github.com/SinghAsDev/incubator-parquet-mr","homepage":null,"size":12053,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rdblue:master","ref":"master","sha":"a7155a8d7a980b4b1122961a05e8c42a0f26540e","user":{"login":"rdblue","id":87915,"avatar_url":"https://avatars.githubusercontent.com/u/87915?v=3","gravatar_id":"","url":"https://api.github.com/users/rdblue","html_url":"https://github.com/rdblue","followers_url":"https://api.github.com/users/rdblue/followers","following_url":"https://api.github.com/users/rdblue/following{/other_user}","gists_url":"https://api.github.com/users/rdblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rdblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdblue/subscriptions","organizations_url":"https://api.github.com/users/rdblue/orgs","repos_url":"https://api.github.com/users/rdblue/repos","events_url":"https://api.github.com/users/rdblue/events{/privacy}","received_events_url":"https://api.github.com/users/rdblue/received_events","type":"User","site_admin":false},"repo":{"id":21755687,"name":"incubator-parquet-mr","full_name":"rdblue/incubator-parquet-mr","owner":{"login":"rdblue","id":87915,"avatar_url":"https://avatars.githubusercontent.com/u/87915?v=3","gravatar_id":"","url":"https://api.github.com/users/rdblue","html_url":"https://github.com/rdblue","followers_url":"https://api.github.com/users/rdblue/followers","following_url":"https://api.github.com/users/rdblue/following{/other_user}","gists_url":"https://api.github.com/users/rdblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rdblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdblue/subscriptions","organizations_url":"https://api.github.com/users/rdblue/orgs","repos_url":"https://api.github.com/users/rdblue/repos","events_url":"https://api.github.com/users/rdblue/events{/privacy}","received_events_url":"https://api.github.com/users/rdblue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rdblue/incubator-parquet-mr","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/rdblue/incubator-parquet-mr","forks_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/forks","keys_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/teams","hooks_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/events","assignees_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/tags","blobs_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/languages","stargazers_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/subscription","commits_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/merges","archive_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/downloads","issues_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/rdblue/incubator-parquet-mr/releases{/id}","created_at":"2014-07-12T00:08:35Z","updated_at":"2015-03-06T22:12:24Z","pushed_at":"2015-03-23T23:56:28Z","git_url":"git://github.com/rdblue/incubator-parquet-mr.git","ssh_url":"git@github.com:rdblue/incubator-parquet-mr.git","clone_url":"https://github.com/rdblue/incubator-parquet-mr.git","svn_url":"https://github.com/rdblue/incubator-parquet-mr","homepage":null,"size":13064,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rdblue/incubator-parquet-mr/pulls/1"},"html":{"href":"https://github.com/rdblue/incubator-parquet-mr/pull/1"},"issue":{"href":"https://api.github.com/repos/rdblue/incubator-parquet-mr/issues/1"},"comments":{"href":"https://api.github.com/repos/rdblue/incubator-parquet-mr/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/rdblue/incubator-parquet-mr/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/rdblue/incubator-parquet-mr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rdblue/incubator-parquet-mr/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/rdblue/incubator-parquet-mr/statuses/857fe56aecf457f8d7dad360772b413180f0baac"}}}}