{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3250","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3250/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3250/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3250/events","html_url":"https://github.com/cockroachdb/cockroach/pull/3250","id":119523872,"number":3250,"title":"fix rpc block when net partitioned","user":{"login":"Kevin-GuanJian","id":3643265,"avatar_url":"https://avatars.githubusercontent.com/u/3643265?v=3","gravatar_id":"","url":"https://api.github.com/users/Kevin-GuanJian","html_url":"https://github.com/Kevin-GuanJian","followers_url":"https://api.github.com/users/Kevin-GuanJian/followers","following_url":"https://api.github.com/users/Kevin-GuanJian/following{/other_user}","gists_url":"https://api.github.com/users/Kevin-GuanJian/gists{/gist_id}","starred_url":"https://api.github.com/users/Kevin-GuanJian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kevin-GuanJian/subscriptions","organizations_url":"https://api.github.com/users/Kevin-GuanJian/orgs","repos_url":"https://api.github.com/users/Kevin-GuanJian/repos","events_url":"https://api.github.com/users/Kevin-GuanJian/events{/privacy}","received_events_url":"https://api.github.com/users/Kevin-GuanJian/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2015-11-30T16:11:04Z","updated_at":"2015-12-02T21:09:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/3250","html_url":"https://github.com/cockroachdb/cockroach/pull/3250","diff_url":"https://github.com/cockroachdb/cockroach/pull/3250.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/3250.patch"},"body":"fix: when the net partitioned, rpc client will be blocked to send ```Heartbeat.Ping```, so change to send heartbeat asynchronously\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/3250)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/161434639","html_url":"https://github.com/cockroachdb/cockroach/pull/3250#issuecomment-161434639","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3250","id":161434639,"user":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"created_at":"2015-12-02T21:09:27Z","updated_at":"2015-12-02T21:09:27Z","body":"LGTM.\r\n\r\nI think golang/go#13442 is a documentation bug rather than a behavior bug (backpressure is important, and a semi-blocking method can be converted to fully non-blocking with the `go` keyword but the other direction is trickier)."}}