{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/5403","labels_url":"https://api.github.com/repos/facebook/react/issues/5403/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/5403/comments","events_url":"https://api.github.com/repos/facebook/react/issues/5403/events","html_url":"https://github.com/facebook/react/pull/5403","id":115285471,"number":5403,"title":"Clarify note about stable keys","user":{"login":"yuyokk","id":1225343,"avatar_url":"https://avatars.githubusercontent.com/u/1225343?v=3","gravatar_id":"","url":"https://api.github.com/users/yuyokk","html_url":"https://github.com/yuyokk","followers_url":"https://api.github.com/users/yuyokk/followers","following_url":"https://api.github.com/users/yuyokk/following{/other_user}","gists_url":"https://api.github.com/users/yuyokk/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyokk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyokk/subscriptions","organizations_url":"https://api.github.com/users/yuyokk/orgs","repos_url":"https://api.github.com/users/yuyokk/repos","events_url":"https://api.github.com/users/yuyokk/events{/privacy}","received_events_url":"https://api.github.com/users/yuyokk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react/labels/Component:%20Documentation%20&%20Website","name":"Component: Documentation & Website","color":"eb6420"},{"url":"https://api.github.com/repos/facebook/react/labels/GH%20Review:%20needs-revision","name":"GH Review: needs-revision","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-11-05T13:40:16Z","updated_at":"2015-11-10T01:02:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/5403","html_url":"https://github.com/facebook/react/pull/5403","diff_url":"https://github.com/facebook/react/pull/5403.diff","patch_url":"https://github.com/facebook/react/pull/5403.patch"},"body":"Hello,\r\n\r\nI've been reading [docs](https://facebook.github.io/react/docs/reconciliation.html) that say\r\n\r\n> If you don't provide stable keys (by using Math.random() for example), all the sub-trees are going to be re-rendered every single time. By giving the users the choice to choose the key, they have the ability to shoot themselves in the foot.\r\n\r\nand then I see this [comment](https://github.com/facebook/react/issues/1342#issuecomment-39230939) on some issue that says\r\n\r\n> We made this mistake in one of our examples for a while and it's just really bad. By doing this, you'll actually end up recreating all of your nodes on every render because the key will be different.\r\n\r\nPlease let me know if it makes sense to remove this piece of doc from the site.\r\n\r\nThank you\r\n"},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/155249806","html_url":"https://github.com/facebook/react/pull/5403#issuecomment-155249806","issue_url":"https://api.github.com/repos/facebook/react/issues/5403","id":155249806,"user":{"login":"yaycmyk","id":570070,"avatar_url":"https://avatars.githubusercontent.com/u/570070?v=3","gravatar_id":"","url":"https://api.github.com/users/yaycmyk","html_url":"https://github.com/yaycmyk","followers_url":"https://api.github.com/users/yaycmyk/followers","following_url":"https://api.github.com/users/yaycmyk/following{/other_user}","gists_url":"https://api.github.com/users/yaycmyk/gists{/gist_id}","starred_url":"https://api.github.com/users/yaycmyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaycmyk/subscriptions","organizations_url":"https://api.github.com/users/yaycmyk/orgs","repos_url":"https://api.github.com/users/yaycmyk/repos","events_url":"https://api.github.com/users/yaycmyk/events{/privacy}","received_events_url":"https://api.github.com/users/yaycmyk/received_events","type":"User","site_admin":false},"created_at":"2015-11-10T01:02:39Z","updated_at":"2015-11-10T01:02:39Z","body":"@jimfb not my PR, but I'm happy to make a separate one with the revised text "}}