{"action":"created","issue":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5956","labels_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5956/labels{/name}","comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5956/comments","events_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5956/events","html_url":"https://github.com/HabitRPG/habitrpg/pull/5956","id":107350079,"number":5956,"title":"Added lastCron condition to senior member and tests","user":{"login":"TheHollidayInn","id":1253400,"avatar_url":"https://avatars.githubusercontent.com/u/1253400?v=3","gravatar_id":"","url":"https://api.github.com/users/TheHollidayInn","html_url":"https://github.com/TheHollidayInn","followers_url":"https://api.github.com/users/TheHollidayInn/followers","following_url":"https://api.github.com/users/TheHollidayInn/following{/other_user}","gists_url":"https://api.github.com/users/TheHollidayInn/gists{/gist_id}","starred_url":"https://api.github.com/users/TheHollidayInn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheHollidayInn/subscriptions","organizations_url":"https://api.github.com/users/TheHollidayInn/orgs","repos_url":"https://api.github.com/users/TheHollidayInn/repos","events_url":"https://api.github.com/users/TheHollidayInn/events{/privacy}","received_events_url":"https://api.github.com/users/TheHollidayInn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/HabitRPG/habitrpg/labels/status:%20READY%20FOR%20REVIEW","name":"status: READY FOR REVIEW","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-09-19T18:53:25Z","updated_at":"2015-09-22T20:38:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/5956","html_url":"https://github.com/HabitRPG/habitrpg/pull/5956","diff_url":"https://github.com/HabitRPG/habitrpg/pull/5956.diff","patch_url":"https://github.com/HabitRPG/habitrpg/pull/5956.patch"},"body":"This is for #5871 - Most senior member should be made leader . The code to make a member the leader when the current leader leaves was already there. I modified it to add lastCron check to make sure the user is active. However, we might need to add other parameters to ensure the member is considered \"Senior\".\r\n\r\nAlso, I am having an issued when inviting and joining the two users. I'm posting this so you can start reviewing, and if you know what the issue is. Otherwise, I will debug this tomorrow. "},"comment":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/comments/142412750","html_url":"https://github.com/HabitRPG/habitrpg/pull/5956#issuecomment-142412750","issue_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5956","id":142412750,"user":{"login":"TheHollidayInn","id":1253400,"avatar_url":"https://avatars.githubusercontent.com/u/1253400?v=3","gravatar_id":"","url":"https://api.github.com/users/TheHollidayInn","html_url":"https://github.com/TheHollidayInn","followers_url":"https://api.github.com/users/TheHollidayInn/followers","following_url":"https://api.github.com/users/TheHollidayInn/following{/other_user}","gists_url":"https://api.github.com/users/TheHollidayInn/gists{/gist_id}","starred_url":"https://api.github.com/users/TheHollidayInn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheHollidayInn/subscriptions","organizations_url":"https://api.github.com/users/TheHollidayInn/orgs","repos_url":"https://api.github.com/users/TheHollidayInn/repos","events_url":"https://api.github.com/users/TheHollidayInn/events{/privacy}","received_events_url":"https://api.github.com/users/TheHollidayInn/received_events","type":"User","site_admin":false},"created_at":"2015-09-22T20:38:14Z","updated_at":"2015-09-22T20:38:14Z","body":"I made the updates and included some changes to the query to maintain consistency. Do I need to created the compound index?"}}