{"action":"created","issue":{"url":"https://api.github.com/repos/OCA/account-payment/issues/18","labels_url":"https://api.github.com/repos/OCA/account-payment/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/OCA/account-payment/issues/18/comments","events_url":"https://api.github.com/repos/OCA/account-payment/issues/18/events","html_url":"https://github.com/OCA/account-payment/pull/18","id":48619715,"number":18,"title":"[8.0] Migration of account_vat_on_payment and account_voucher_cash_basis","user":{"login":"tafaRU","id":3512779,"avatar_url":"https://avatars.githubusercontent.com/u/3512779?v=3","gravatar_id":"","url":"https://api.github.com/users/tafaRU","html_url":"https://github.com/tafaRU","followers_url":"https://api.github.com/users/tafaRU/followers","following_url":"https://api.github.com/users/tafaRU/following{/other_user}","gists_url":"https://api.github.com/users/tafaRU/gists{/gist_id}","starred_url":"https://api.github.com/users/tafaRU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tafaRU/subscriptions","organizations_url":"https://api.github.com/users/tafaRU/orgs","repos_url":"https://api.github.com/users/tafaRU/repos","events_url":"https://api.github.com/users/tafaRU/events{/privacy}","received_events_url":"https://api.github.com/users/tafaRU/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OCA/account-payment/labels/needs%20review","name":"needs review","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/OCA/account-payment/milestones/3","html_url":"https://github.com/OCA/account-payment/milestones/8.0","labels_url":"https://api.github.com/repos/OCA/account-payment/milestones/3/labels","id":985603,"number":3,"title":"8.0","description":"","creator":{"login":"max3903","id":939952,"avatar_url":"https://avatars.githubusercontent.com/u/939952?v=3","gravatar_id":"","url":"https://api.github.com/users/max3903","html_url":"https://github.com/max3903","followers_url":"https://api.github.com/users/max3903/followers","following_url":"https://api.github.com/users/max3903/following{/other_user}","gists_url":"https://api.github.com/users/max3903/gists{/gist_id}","starred_url":"https://api.github.com/users/max3903/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/max3903/subscriptions","organizations_url":"https://api.github.com/users/max3903/orgs","repos_url":"https://api.github.com/users/max3903/repos","events_url":"https://api.github.com/users/max3903/events{/privacy}","received_events_url":"https://api.github.com/users/max3903/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2015-02-19T02:01:43Z","updated_at":"2015-02-19T02:05:38Z","due_on":null,"closed_at":null},"comments":38,"created_at":"2014-11-13T10:22:15Z","updated_at":"2015-06-14T13:51:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OCA/account-payment/pulls/18","html_url":"https://github.com/OCA/account-payment/pull/18","diff_url":"https://github.com/OCA/account-payment/pull/18.diff","patch_url":"https://github.com/OCA/account-payment/pull/18.patch"},"body":"This PR contains the migration (without porting to the new API) of the following modules:\r\n\r\n1. ***account_vat_on_payment*** at the moment only present in https://github.com/eLBati/account-payment/tree/adding_account_vat_on_payment_7/account_vat_on_payment\r\n2. ***account_voucher_cash_basis*** from which the first one depends on"},"comment":{"url":"https://api.github.com/repos/OCA/account-payment/issues/comments/111828023","html_url":"https://github.com/OCA/account-payment/pull/18#issuecomment-111828023","issue_url":"https://api.github.com/repos/OCA/account-payment/issues/18","id":111828023,"user":{"login":"eLBati","id":1033131,"avatar_url":"https://avatars.githubusercontent.com/u/1033131?v=3","gravatar_id":"","url":"https://api.github.com/users/eLBati","html_url":"https://github.com/eLBati","followers_url":"https://api.github.com/users/eLBati/followers","following_url":"https://api.github.com/users/eLBati/following{/other_user}","gists_url":"https://api.github.com/users/eLBati/gists{/gist_id}","starred_url":"https://api.github.com/users/eLBati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eLBati/subscriptions","organizations_url":"https://api.github.com/users/eLBati/orgs","repos_url":"https://api.github.com/users/eLBati/repos","events_url":"https://api.github.com/users/eLBati/events{/privacy}","received_events_url":"https://api.github.com/users/eLBati/received_events","type":"User","site_admin":false},"created_at":"2015-06-14T13:51:39Z","updated_at":"2015-06-14T13:51:39Z","body":"Hello @feketemihai we move customer/supplier entry away from bank entry because we wanted the bank entry to contain only the bank, VAT and sales move lines. So that customer/supplier entry can be recorded on a different journal.\r\n\r\nWhat do you mean with\r\n>you don't see that you paid a supplier or receive a payment from customer\r\n\r\n?\r\nFrom voucher you can reach receivable/payable move through ```shadow_move_id``` field\r\nFrom invoice you can reach bank move through ```real_payment_move_id``` on payment move line (in the payments TAB).\r\n\r\nMaybe you could  make a PR proposing the changes which avoid to execute ```_move_payment_lines_to_shadow_entry``` based on a configuration flag?"}}