{"action":"created","comment":{"url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/comments/41343894","id":41343894,"diff_hunk":"@@ -1009,8 +995,8 @@ def _configure(self, msg):\n         _, obj, args, kwargs = msg\n         if not hasattr(obj, 'configure'):\n             return None\n-        result = obj.configure(*args, **kwargs)\n-        self._configured.append(obj)\n+        self._configured.add(obj)  # add first in case of failure below\n+        result = obj.configure(kwargs.get('state'))","path":"bluesky/run_engine.py","position":152,"original_position":152,"commit_id":"51e72330b48f1420bc53d4a94c54c37c82686805","original_commit_id":"51e72330b48f1420bc53d4a94c54c37c82686805","user":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"body":"don't need the `result` local anynare","created_at":"2015-10-07T01:42:26Z","updated_at":"2015-10-07T01:42:26Z","html_url":"https://github.com/NSLS-II/bluesky/pull/219#discussion_r41343894","pull_request_url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/219","_links":{"self":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/comments/41343894"},"html":{"href":"https://github.com/NSLS-II/bluesky/pull/219#discussion_r41343894"},"pull_request":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/219"}}},"pull_request":{"url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/219","id":46675880,"html_url":"https://github.com/NSLS-II/bluesky/pull/219","diff_url":"https://github.com/NSLS-II/bluesky/pull/219.diff","patch_url":"https://github.com/NSLS-II/bluesky/pull/219.patch","issue_url":"https://api.github.com/repos/NSLS-II/bluesky/issues/219","number":219,"state":"open","locked":false,"title":"Configuration","user":{"login":"danielballan","id":2279598,"avatar_url":"https://avatars.githubusercontent.com/u/2279598?v=3","gravatar_id":"","url":"https://api.github.com/users/danielballan","html_url":"https://github.com/danielballan","followers_url":"https://api.github.com/users/danielballan/followers","following_url":"https://api.github.com/users/danielballan/following{/other_user}","gists_url":"https://api.github.com/users/danielballan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielballan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielballan/subscriptions","organizations_url":"https://api.github.com/users/danielballan/orgs","repos_url":"https://api.github.com/users/danielballan/repos","events_url":"https://api.github.com/users/danielballan/events{/privacy}","received_events_url":"https://api.github.com/users/danielballan/received_events","type":"User","site_admin":false},"body":"This PR adds an `objects` property to `ScanBase`. It is a dict mapping the ophyd objects to their data keys. It addresses two issues at once:\r\n\r\n1. Downstream consumers can get a list of the objects involved without needing to know a scan's specific layout (motor or motors plural).\r\n2. They can know which objects are associated with which data keys. This information was previously not knowable.\r\n\r\nThis PR also pushes all configure/deconfigure logic into ScanBase. The scan's `num` and `shape` attributes, if present, are passed. Users can pass custom configuration logic through the `.configuration` attribute.\r\n\r\nThis PR does not support a configuration kwarg. I'd like to postpone that until we need it.","created_at":"2015-10-02T20:01:02Z","updated_at":"2015-10-07T01:42:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c17b3d5f35ffead8b6dbb6a048eae082bed2228","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/219/commits","review_comments_url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/219/comments","review_comment_url":"https://api.github.com/repos/NSLS-II/bluesky/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NSLS-II/bluesky/issues/219/comments","statuses_url":"https://api.github.com/repos/NSLS-II/bluesky/statuses/51e72330b48f1420bc53d4a94c54c37c82686805","head":{"label":"danielballan:configuration","ref":"configuration","sha":"51e72330b48f1420bc53d4a94c54c37c82686805","user":{"login":"danielballan","id":2279598,"avatar_url":"https://avatars.githubusercontent.com/u/2279598?v=3","gravatar_id":"","url":"https://api.github.com/users/danielballan","html_url":"https://github.com/danielballan","followers_url":"https://api.github.com/users/danielballan/followers","following_url":"https://api.github.com/users/danielballan/following{/other_user}","gists_url":"https://api.github.com/users/danielballan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielballan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielballan/subscriptions","organizations_url":"https://api.github.com/users/danielballan/orgs","repos_url":"https://api.github.com/users/danielballan/repos","events_url":"https://api.github.com/users/danielballan/events{/privacy}","received_events_url":"https://api.github.com/users/danielballan/received_events","type":"User","site_admin":false},"repo":{"id":39904738,"name":"bluesky","full_name":"danielballan/bluesky","owner":{"login":"danielballan","id":2279598,"avatar_url":"https://avatars.githubusercontent.com/u/2279598?v=3","gravatar_id":"","url":"https://api.github.com/users/danielballan","html_url":"https://github.com/danielballan","followers_url":"https://api.github.com/users/danielballan/followers","following_url":"https://api.github.com/users/danielballan/following{/other_user}","gists_url":"https://api.github.com/users/danielballan/gists{/gist_id}","starred_url":"https://api.github.com/users/danielballan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielballan/subscriptions","organizations_url":"https://api.github.com/users/danielballan/orgs","repos_url":"https://api.github.com/users/danielballan/repos","events_url":"https://api.github.com/users/danielballan/events{/privacy}","received_events_url":"https://api.github.com/users/danielballan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielballan/bluesky","description":"a data collection interface","fork":true,"url":"https://api.github.com/repos/danielballan/bluesky","forks_url":"https://api.github.com/repos/danielballan/bluesky/forks","keys_url":"https://api.github.com/repos/danielballan/bluesky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielballan/bluesky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielballan/bluesky/teams","hooks_url":"https://api.github.com/repos/danielballan/bluesky/hooks","issue_events_url":"https://api.github.com/repos/danielballan/bluesky/issues/events{/number}","events_url":"https://api.github.com/repos/danielballan/bluesky/events","assignees_url":"https://api.github.com/repos/danielballan/bluesky/assignees{/user}","branches_url":"https://api.github.com/repos/danielballan/bluesky/branches{/branch}","tags_url":"https://api.github.com/repos/danielballan/bluesky/tags","blobs_url":"https://api.github.com/repos/danielballan/bluesky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielballan/bluesky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielballan/bluesky/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielballan/bluesky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielballan/bluesky/statuses/{sha}","languages_url":"https://api.github.com/repos/danielballan/bluesky/languages","stargazers_url":"https://api.github.com/repos/danielballan/bluesky/stargazers","contributors_url":"https://api.github.com/repos/danielballan/bluesky/contributors","subscribers_url":"https://api.github.com/repos/danielballan/bluesky/subscribers","subscription_url":"https://api.github.com/repos/danielballan/bluesky/subscription","commits_url":"https://api.github.com/repos/danielballan/bluesky/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielballan/bluesky/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielballan/bluesky/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielballan/bluesky/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielballan/bluesky/contents/{+path}","compare_url":"https://api.github.com/repos/danielballan/bluesky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielballan/bluesky/merges","archive_url":"https://api.github.com/repos/danielballan/bluesky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielballan/bluesky/downloads","issues_url":"https://api.github.com/repos/danielballan/bluesky/issues{/number}","pulls_url":"https://api.github.com/repos/danielballan/bluesky/pulls{/number}","milestones_url":"https://api.github.com/repos/danielballan/bluesky/milestones{/number}","notifications_url":"https://api.github.com/repos/danielballan/bluesky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielballan/bluesky/labels{/name}","releases_url":"https://api.github.com/repos/danielballan/bluesky/releases{/id}","created_at":"2015-07-29T16:42:41Z","updated_at":"2015-07-29T16:42:41Z","pushed_at":"2015-10-07T01:32:54Z","git_url":"git://github.com/danielballan/bluesky.git","ssh_url":"git@github.com:danielballan/bluesky.git","clone_url":"https://github.com/danielballan/bluesky.git","svn_url":"https://github.com/danielballan/bluesky","homepage":"http://danielballan.github.io/bluesky","size":3155,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NSLS-II:master","ref":"master","sha":"b4b84e6c43307a21babfa1d065fcd010ec5b8109","user":{"login":"NSLS-II","id":8700262,"avatar_url":"https://avatars.githubusercontent.com/u/8700262?v=3","gravatar_id":"","url":"https://api.github.com/users/NSLS-II","html_url":"https://github.com/NSLS-II","followers_url":"https://api.github.com/users/NSLS-II/followers","following_url":"https://api.github.com/users/NSLS-II/following{/other_user}","gists_url":"https://api.github.com/users/NSLS-II/gists{/gist_id}","starred_url":"https://api.github.com/users/NSLS-II/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NSLS-II/subscriptions","organizations_url":"https://api.github.com/users/NSLS-II/orgs","repos_url":"https://api.github.com/users/NSLS-II/repos","events_url":"https://api.github.com/users/NSLS-II/events{/privacy}","received_events_url":"https://api.github.com/users/NSLS-II/received_events","type":"Organization","site_admin":false},"repo":{"id":36754446,"name":"bluesky","full_name":"NSLS-II/bluesky","owner":{"login":"NSLS-II","id":8700262,"avatar_url":"https://avatars.githubusercontent.com/u/8700262?v=3","gravatar_id":"","url":"https://api.github.com/users/NSLS-II","html_url":"https://github.com/NSLS-II","followers_url":"https://api.github.com/users/NSLS-II/followers","following_url":"https://api.github.com/users/NSLS-II/following{/other_user}","gists_url":"https://api.github.com/users/NSLS-II/gists{/gist_id}","starred_url":"https://api.github.com/users/NSLS-II/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NSLS-II/subscriptions","organizations_url":"https://api.github.com/users/NSLS-II/orgs","repos_url":"https://api.github.com/users/NSLS-II/repos","events_url":"https://api.github.com/users/NSLS-II/events{/privacy}","received_events_url":"https://api.github.com/users/NSLS-II/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NSLS-II/bluesky","description":"a data collection interface","fork":false,"url":"https://api.github.com/repos/NSLS-II/bluesky","forks_url":"https://api.github.com/repos/NSLS-II/bluesky/forks","keys_url":"https://api.github.com/repos/NSLS-II/bluesky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NSLS-II/bluesky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NSLS-II/bluesky/teams","hooks_url":"https://api.github.com/repos/NSLS-II/bluesky/hooks","issue_events_url":"https://api.github.com/repos/NSLS-II/bluesky/issues/events{/number}","events_url":"https://api.github.com/repos/NSLS-II/bluesky/events","assignees_url":"https://api.github.com/repos/NSLS-II/bluesky/assignees{/user}","branches_url":"https://api.github.com/repos/NSLS-II/bluesky/branches{/branch}","tags_url":"https://api.github.com/repos/NSLS-II/bluesky/tags","blobs_url":"https://api.github.com/repos/NSLS-II/bluesky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NSLS-II/bluesky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NSLS-II/bluesky/git/refs{/sha}","trees_url":"https://api.github.com/repos/NSLS-II/bluesky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NSLS-II/bluesky/statuses/{sha}","languages_url":"https://api.github.com/repos/NSLS-II/bluesky/languages","stargazers_url":"https://api.github.com/repos/NSLS-II/bluesky/stargazers","contributors_url":"https://api.github.com/repos/NSLS-II/bluesky/contributors","subscribers_url":"https://api.github.com/repos/NSLS-II/bluesky/subscribers","subscription_url":"https://api.github.com/repos/NSLS-II/bluesky/subscription","commits_url":"https://api.github.com/repos/NSLS-II/bluesky/commits{/sha}","git_commits_url":"https://api.github.com/repos/NSLS-II/bluesky/git/commits{/sha}","comments_url":"https://api.github.com/repos/NSLS-II/bluesky/comments{/number}","issue_comment_url":"https://api.github.com/repos/NSLS-II/bluesky/issues/comments{/number}","contents_url":"https://api.github.com/repos/NSLS-II/bluesky/contents/{+path}","compare_url":"https://api.github.com/repos/NSLS-II/bluesky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NSLS-II/bluesky/merges","archive_url":"https://api.github.com/repos/NSLS-II/bluesky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NSLS-II/bluesky/downloads","issues_url":"https://api.github.com/repos/NSLS-II/bluesky/issues{/number}","pulls_url":"https://api.github.com/repos/NSLS-II/bluesky/pulls{/number}","milestones_url":"https://api.github.com/repos/NSLS-II/bluesky/milestones{/number}","notifications_url":"https://api.github.com/repos/NSLS-II/bluesky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NSLS-II/bluesky/labels{/name}","releases_url":"https://api.github.com/repos/NSLS-II/bluesky/releases{/id}","created_at":"2015-06-02T18:50:18Z","updated_at":"2015-08-06T14:19:42Z","pushed_at":"2015-10-07T01:32:55Z","git_url":"git://github.com/NSLS-II/bluesky.git","ssh_url":"git@github.com:NSLS-II/bluesky.git","clone_url":"https://github.com/NSLS-II/bluesky.git","svn_url":"https://github.com/NSLS-II/bluesky","homepage":"http://nsls-ii.github.io/bluesky","size":3092,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":52,"forks":9,"open_issues":52,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/219"},"html":{"href":"https://github.com/NSLS-II/bluesky/pull/219"},"issue":{"href":"https://api.github.com/repos/NSLS-II/bluesky/issues/219"},"comments":{"href":"https://api.github.com/repos/NSLS-II/bluesky/issues/219/comments"},"review_comments":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/219/comments"},"review_comment":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NSLS-II/bluesky/pulls/219/commits"},"statuses":{"href":"https://api.github.com/repos/NSLS-II/bluesky/statuses/51e72330b48f1420bc53d4a94c54c37c82686805"}}}}