{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/amo-validator/pulls/comments/33997388","id":33997388,"diff_hunk":"@@ -384,20 +389,28 @@ def print_summary(self, verbose=False, no_color=False):\n                                     message=notice,\n                                     verbose=verbose)\n \n-        if \"is_jetpack\" in self.metadata and verbose:\n-            self.handler.write(\"\\n\")\n-            self.handler.write(\"<<GREEN>>Jetpack add-on detected.<<NORMAL>>\\n\"\n-                               \"Identified files:\")\n-            if \"jetpack_identified_files\" in self.metadata:\n-                for filename, data in \\\n-                        self.metadata[\"jetpack_identified_files\"].items():\n-                    self.handler.write((\" %s\\n\" % filename) +\n-                                       (\"  %s : %s\" % data))\n-\n-            if \"jetpack_unknown_files\" in self.metadata:\n-                self.handler.write(\"Unknown files:\")\n-                for filename in self.metadata[\"jetpack_unknown_files\"]:\n-                    self.handler.write(\" %s\" % filename)\n+        if verbose:\n+            if \"framework\" in self.metadata:\n+                framework = self.metadata[\"framework\"]\n+\n+                self.handler.write(\"\\n\")\n+                self.handler.write(\"<<GREEN>>%s %s framework add-on detected.\"\n+                                   \"<<NORMAL>>\\n\" % (framework[\"name\"],\n+                                                     framework[\"version\"]))\n+\n+            if self.metadata.get(\"framework_files\"):\n+                self.handler.write(\"Framework files:\")\n+                for filenamename in self.metadata[\"framework_files\"]:\n+                    self.handler.write(\" %s\" % filenamename)\n+                self.handler.write(\"\")","path":"validator/errorbundler.py","position":43,"original_position":43,"commit_id":"c30f3d31659a201ef4496cec0192594bb9d51be5","original_commit_id":"c30f3d31659a201ef4496cec0192594bb9d51be5","user":{"login":"kmaglione","id":125842,"avatar_url":"https://avatars.githubusercontent.com/u/125842?v=3","gravatar_id":"","url":"https://api.github.com/users/kmaglione","html_url":"https://github.com/kmaglione","followers_url":"https://api.github.com/users/kmaglione/followers","following_url":"https://api.github.com/users/kmaglione/following{/other_user}","gists_url":"https://api.github.com/users/kmaglione/gists{/gist_id}","starred_url":"https://api.github.com/users/kmaglione/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmaglione/subscriptions","organizations_url":"https://api.github.com/users/kmaglione/orgs","repos_url":"https://api.github.com/users/kmaglione/repos","events_url":"https://api.github.com/users/kmaglione/events{/privacy}","received_events_url":"https://api.github.com/users/kmaglione/received_events","type":"User","site_admin":false},"body":"This function writes newlines after the string. This just writes out a newline.","created_at":"2015-07-07T00:14:49Z","updated_at":"2015-07-07T00:14:49Z","html_url":"https://github.com/mozilla/amo-validator/pull/271#discussion_r33997388","pull_request_url":"https://api.github.com/repos/mozilla/amo-validator/pulls/271","_links":{"self":{"href":"https://api.github.com/repos/mozilla/amo-validator/pulls/comments/33997388"},"html":{"href":"https://github.com/mozilla/amo-validator/pull/271#discussion_r33997388"},"pull_request":{"href":"https://api.github.com/repos/mozilla/amo-validator/pulls/271"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/amo-validator/pulls/271","id":28604669,"html_url":"https://github.com/mozilla/amo-validator/pull/271","diff_url":"https://github.com/mozilla/amo-validator/pull/271.diff","patch_url":"https://github.com/mozilla/amo-validator/pull/271.patch","issue_url":"https://api.github.com/repos/mozilla/amo-validator/issues/271","number":271,"state":"open","locked":false,"title":"Refactor framework and library detection code.","user":{"login":"kmaglione","id":125842,"avatar_url":"https://avatars.githubusercontent.com/u/125842?v=3","gravatar_id":"","url":"https://api.github.com/users/kmaglione","html_url":"https://github.com/kmaglione","followers_url":"https://api.github.com/users/kmaglione/followers","following_url":"https://api.github.com/users/kmaglione/following{/other_user}","gists_url":"https://api.github.com/users/kmaglione/gists{/gist_id}","starred_url":"https://api.github.com/users/kmaglione/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmaglione/subscriptions","organizations_url":"https://api.github.com/users/kmaglione/orgs","repos_url":"https://api.github.com/users/kmaglione/repos","events_url":"https://api.github.com/users/kmaglione/events{/privacy}","received_events_url":"https://api.github.com/users/kmaglione/received_events","type":"User","site_admin":false},"body":"Sorry. This is kind of large.\r\n\r\nThoughts for easier review:\r\n\r\nThe `JetpackCFX.validate` method is mostly code that was in 'jetpack.js', but with a lot of dead code removed.\r\n\r\nThe 'test_libraries.py` file is mostly code from the very strangely misnamed 'test_libraryblacklist.py' file, but git's rename tracking is not smart enough to notice.\r\n\r\nThe code in 'metadata/libfetcher.py' and 'metadata/update.py' can be skipped, if you prefer. It won't be run on servers, and we'll probably be changing it locally without submitting PRs immediately for a lot of runs.\r\n\r\nThere's a related update to Olympia coming to handle out-of-band updates of the metadata JSON and add some integration with the file viewer.","created_at":"2015-02-04T00:57:53Z","updated_at":"2015-07-07T00:14:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3896c659046b03693708b64124d456a1fd401ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/amo-validator/pulls/271/commits","review_comments_url":"https://api.github.com/repos/mozilla/amo-validator/pulls/271/comments","review_comment_url":"https://api.github.com/repos/mozilla/amo-validator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/amo-validator/issues/271/comments","statuses_url":"https://api.github.com/repos/mozilla/amo-validator/statuses/c30f3d31659a201ef4496cec0192594bb9d51be5","head":{"label":"kmaglione:framework-stuff","ref":"framework-stuff","sha":"c30f3d31659a201ef4496cec0192594bb9d51be5","user":{"login":"kmaglione","id":125842,"avatar_url":"https://avatars.githubusercontent.com/u/125842?v=3","gravatar_id":"","url":"https://api.github.com/users/kmaglione","html_url":"https://github.com/kmaglione","followers_url":"https://api.github.com/users/kmaglione/followers","following_url":"https://api.github.com/users/kmaglione/following{/other_user}","gists_url":"https://api.github.com/users/kmaglione/gists{/gist_id}","starred_url":"https://api.github.com/users/kmaglione/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmaglione/subscriptions","organizations_url":"https://api.github.com/users/kmaglione/orgs","repos_url":"https://api.github.com/users/kmaglione/repos","events_url":"https://api.github.com/users/kmaglione/events{/privacy}","received_events_url":"https://api.github.com/users/kmaglione/received_events","type":"User","site_admin":false},"repo":{"id":1508852,"name":"amo-validator","full_name":"kmaglione/amo-validator","owner":{"login":"kmaglione","id":125842,"avatar_url":"https://avatars.githubusercontent.com/u/125842?v=3","gravatar_id":"","url":"https://api.github.com/users/kmaglione","html_url":"https://github.com/kmaglione","followers_url":"https://api.github.com/users/kmaglione/followers","following_url":"https://api.github.com/users/kmaglione/following{/other_user}","gists_url":"https://api.github.com/users/kmaglione/gists{/gist_id}","starred_url":"https://api.github.com/users/kmaglione/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmaglione/subscriptions","organizations_url":"https://api.github.com/users/kmaglione/orgs","repos_url":"https://api.github.com/users/kmaglione/repos","events_url":"https://api.github.com/users/kmaglione/events{/privacy}","received_events_url":"https://api.github.com/users/kmaglione/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kmaglione/amo-validator","description":"Validator for addons.mozilla.org","fork":true,"url":"https://api.github.com/repos/kmaglione/amo-validator","forks_url":"https://api.github.com/repos/kmaglione/amo-validator/forks","keys_url":"https://api.github.com/repos/kmaglione/amo-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kmaglione/amo-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kmaglione/amo-validator/teams","hooks_url":"https://api.github.com/repos/kmaglione/amo-validator/hooks","issue_events_url":"https://api.github.com/repos/kmaglione/amo-validator/issues/events{/number}","events_url":"https://api.github.com/repos/kmaglione/amo-validator/events","assignees_url":"https://api.github.com/repos/kmaglione/amo-validator/assignees{/user}","branches_url":"https://api.github.com/repos/kmaglione/amo-validator/branches{/branch}","tags_url":"https://api.github.com/repos/kmaglione/amo-validator/tags","blobs_url":"https://api.github.com/repos/kmaglione/amo-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kmaglione/amo-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kmaglione/amo-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/kmaglione/amo-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kmaglione/amo-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/kmaglione/amo-validator/languages","stargazers_url":"https://api.github.com/repos/kmaglione/amo-validator/stargazers","contributors_url":"https://api.github.com/repos/kmaglione/amo-validator/contributors","subscribers_url":"https://api.github.com/repos/kmaglione/amo-validator/subscribers","subscription_url":"https://api.github.com/repos/kmaglione/amo-validator/subscription","commits_url":"https://api.github.com/repos/kmaglione/amo-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/kmaglione/amo-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/kmaglione/amo-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/kmaglione/amo-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/kmaglione/amo-validator/contents/{+path}","compare_url":"https://api.github.com/repos/kmaglione/amo-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kmaglione/amo-validator/merges","archive_url":"https://api.github.com/repos/kmaglione/amo-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kmaglione/amo-validator/downloads","issues_url":"https://api.github.com/repos/kmaglione/amo-validator/issues{/number}","pulls_url":"https://api.github.com/repos/kmaglione/amo-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/kmaglione/amo-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/kmaglione/amo-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kmaglione/amo-validator/labels{/name}","releases_url":"https://api.github.com/repos/kmaglione/amo-validator/releases{/id}","created_at":"2011-03-21T22:22:40Z","updated_at":"2014-08-09T22:13:54Z","pushed_at":"2015-07-06T23:28:59Z","git_url":"git://github.com/kmaglione/amo-validator.git","ssh_url":"git@github.com:kmaglione/amo-validator.git","clone_url":"https://github.com/kmaglione/amo-validator.git","svn_url":"https://github.com/kmaglione/amo-validator","homepage":"","size":17245,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"78cc3b7a4fdb7d367966361f3e0f83676968b1f8","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1441734,"name":"amo-validator","full_name":"mozilla/amo-validator","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/amo-validator","description":"Validator for addons.mozilla.org","fork":false,"url":"https://api.github.com/repos/mozilla/amo-validator","forks_url":"https://api.github.com/repos/mozilla/amo-validator/forks","keys_url":"https://api.github.com/repos/mozilla/amo-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/amo-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/amo-validator/teams","hooks_url":"https://api.github.com/repos/mozilla/amo-validator/hooks","issue_events_url":"https://api.github.com/repos/mozilla/amo-validator/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/amo-validator/events","assignees_url":"https://api.github.com/repos/mozilla/amo-validator/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/amo-validator/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/amo-validator/tags","blobs_url":"https://api.github.com/repos/mozilla/amo-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/amo-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/amo-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/amo-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/amo-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/amo-validator/languages","stargazers_url":"https://api.github.com/repos/mozilla/amo-validator/stargazers","contributors_url":"https://api.github.com/repos/mozilla/amo-validator/contributors","subscribers_url":"https://api.github.com/repos/mozilla/amo-validator/subscribers","subscription_url":"https://api.github.com/repos/mozilla/amo-validator/subscription","commits_url":"https://api.github.com/repos/mozilla/amo-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/amo-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/amo-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/amo-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/amo-validator/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/amo-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/amo-validator/merges","archive_url":"https://api.github.com/repos/mozilla/amo-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/amo-validator/downloads","issues_url":"https://api.github.com/repos/mozilla/amo-validator/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/amo-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/amo-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/amo-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/amo-validator/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/amo-validator/releases{/id}","created_at":"2011-03-05T00:24:22Z","updated_at":"2015-07-03T06:53:52Z","pushed_at":"2015-07-06T22:15:00Z","git_url":"git://github.com/mozilla/amo-validator.git","ssh_url":"git@github.com:mozilla/amo-validator.git","clone_url":"https://github.com/mozilla/amo-validator.git","svn_url":"https://github.com/mozilla/amo-validator","homepage":"","size":385383,"stargazers_count":41,"watchers_count":41,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":3,"forks":40,"open_issues":3,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/amo-validator/pulls/271"},"html":{"href":"https://github.com/mozilla/amo-validator/pull/271"},"issue":{"href":"https://api.github.com/repos/mozilla/amo-validator/issues/271"},"comments":{"href":"https://api.github.com/repos/mozilla/amo-validator/issues/271/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/amo-validator/pulls/271/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/amo-validator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/amo-validator/pulls/271/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/amo-validator/statuses/c30f3d31659a201ef4496cec0192594bb9d51be5"}}}}