{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/bouncer-tests/pulls/comments/40233604","id":40233604,"diff_hunk":"@@ -206,58 +122,33 @@ def test_redirect_for_firefox_aliases(self, base_url, product_alias):\n             url_scheme = 'http'\n             if product_alias['product_name'] == 'firefox-beta-stub':\n                 url_scheme = 'https'\n-            Assert.equal(\n-                response.status_code,\n-                requests.codes.ok,\n-                'Redirect failed with HTTP status %s. \\n %s' %\n-                (response.status_code, self.response_info_failure_message(\n-                    base_url,\n-                    param,\n-                    response))\n-            )\n-            Assert.equal(\n-                parsed_url.scheme,\n-                url_scheme,\n-                'Failed, redirected to incorrect scheme %s. \\n %s' %\n-                (parsed_url.scheme, self.response_info_failure_message(\n-                    base_url,\n-                    param,\n-                    response))\n-            )\n-            Assert.true(\n-                parsed_url.netloc in ['download.cdn.mozilla.net', 'edgecastcdn.net',\n-                        'download-installer.cdn.mozilla.net', 'cloudfront.net',\n-                        'ftp.mozilla.org']\n-               ,\n-                'Failed, redirected to unknown host %s. \\n %s' %\n-                (parsed_url.netloc, self.response_info_failure_message(\n-                    base_url,\n-                    param,\n-                    response))\n-            )\n-            Assert.not_equal(\n-                self.get_x_backend_server(response),\n-                'Unknown',\n-                'Failed, x-backend-server was not in the response object %s' %\n-                (self.response_info_failure_message(base_url,\n-                    param,\n-                    response))\n-            )\n+            assert (requests.codes.ok == response.status_code,\n+                    'Redirect failed with HTTP status. %s' %\n+                    response.status_code, self.response_info_failure_message(base_url, param, response))","path":"tests/test_redirects.py","position":253,"original_position":253,"commit_id":"3cb9a2fab81a9f0e30ea8be2e7cc896de730c84b","original_commit_id":"3cb9a2fab81a9f0e30ea8be2e7cc896de730c84b","user":{"login":"davehunt","id":122800,"avatar_url":"https://avatars.githubusercontent.com/u/122800?v=3","gravatar_id":"","url":"https://api.github.com/users/davehunt","html_url":"https://github.com/davehunt","followers_url":"https://api.github.com/users/davehunt/followers","following_url":"https://api.github.com/users/davehunt/following{/other_user}","gists_url":"https://api.github.com/users/davehunt/gists{/gist_id}","starred_url":"https://api.github.com/users/davehunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davehunt/subscriptions","organizations_url":"https://api.github.com/users/davehunt/orgs","repos_url":"https://api.github.com/users/davehunt/repos","events_url":"https://api.github.com/users/davehunt/events{/privacy}","received_events_url":"https://api.github.com/users/davehunt/received_events","type":"User","site_admin":false},"body":"As above, too many arguments.","created_at":"2015-09-23T17:42:14Z","updated_at":"2015-09-23T17:42:14Z","html_url":"https://github.com/mozilla/bouncer-tests/pull/71#discussion_r40233604","pull_request_url":"https://api.github.com/repos/mozilla/bouncer-tests/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/mozilla/bouncer-tests/pulls/comments/40233604"},"html":{"href":"https://github.com/mozilla/bouncer-tests/pull/71#discussion_r40233604"},"pull_request":{"href":"https://api.github.com/repos/mozilla/bouncer-tests/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/bouncer-tests/pulls/71","id":45722945,"html_url":"https://github.com/mozilla/bouncer-tests/pull/71","diff_url":"https://github.com/mozilla/bouncer-tests/pull/71.diff","patch_url":"https://github.com/mozilla/bouncer-tests/pull/71.patch","issue_url":"https://api.github.com/repos/mozilla/bouncer-tests/issues/71","number":71,"state":"open","locked":false,"title":"Replace unittestzero with native asserts","user":{"login":"m8ttyB","id":63193,"avatar_url":"https://avatars.githubusercontent.com/u/63193?v=3","gravatar_id":"","url":"https://api.github.com/users/m8ttyB","html_url":"https://github.com/m8ttyB","followers_url":"https://api.github.com/users/m8ttyB/followers","following_url":"https://api.github.com/users/m8ttyB/following{/other_user}","gists_url":"https://api.github.com/users/m8ttyB/gists{/gist_id}","starred_url":"https://api.github.com/users/m8ttyB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m8ttyB/subscriptions","organizations_url":"https://api.github.com/users/m8ttyB/orgs","repos_url":"https://api.github.com/users/m8ttyB/repos","events_url":"https://api.github.com/users/m8ttyB/events{/privacy}","received_events_url":"https://api.github.com/users/m8ttyB/received_events","type":"User","site_admin":false},"body":"Cleanup:\r\n* Pin packages in the the `requirements.txt` to the latest and greatest (addresses issue #70 ) .\r\n* Update tests to use Python's native `assert`.\r\n* Remove `xfails` that are no longer necessary. ","created_at":"2015-09-22T22:02:06Z","updated_at":"2015-09-23T17:42:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3445c6d5f49e247a67a28e89667639aacbdeae04","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/bouncer-tests/pulls/71/commits","review_comments_url":"https://api.github.com/repos/mozilla/bouncer-tests/pulls/71/comments","review_comment_url":"https://api.github.com/repos/mozilla/bouncer-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/bouncer-tests/issues/71/comments","statuses_url":"https://api.github.com/repos/mozilla/bouncer-tests/statuses/3cb9a2fab81a9f0e30ea8be2e7cc896de730c84b","head":{"label":"m8ttyB:clean_up","ref":"clean_up","sha":"3cb9a2fab81a9f0e30ea8be2e7cc896de730c84b","user":{"login":"m8ttyB","id":63193,"avatar_url":"https://avatars.githubusercontent.com/u/63193?v=3","gravatar_id":"","url":"https://api.github.com/users/m8ttyB","html_url":"https://github.com/m8ttyB","followers_url":"https://api.github.com/users/m8ttyB/followers","following_url":"https://api.github.com/users/m8ttyB/following{/other_user}","gists_url":"https://api.github.com/users/m8ttyB/gists{/gist_id}","starred_url":"https://api.github.com/users/m8ttyB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m8ttyB/subscriptions","organizations_url":"https://api.github.com/users/m8ttyB/orgs","repos_url":"https://api.github.com/users/m8ttyB/repos","events_url":"https://api.github.com/users/m8ttyB/events{/privacy}","received_events_url":"https://api.github.com/users/m8ttyB/received_events","type":"User","site_admin":false},"repo":{"id":6166279,"name":"bouncer-tests","full_name":"m8ttyB/bouncer-tests","owner":{"login":"m8ttyB","id":63193,"avatar_url":"https://avatars.githubusercontent.com/u/63193?v=3","gravatar_id":"","url":"https://api.github.com/users/m8ttyB","html_url":"https://github.com/m8ttyB","followers_url":"https://api.github.com/users/m8ttyB/followers","following_url":"https://api.github.com/users/m8ttyB/following{/other_user}","gists_url":"https://api.github.com/users/m8ttyB/gists{/gist_id}","starred_url":"https://api.github.com/users/m8ttyB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m8ttyB/subscriptions","organizations_url":"https://api.github.com/users/m8ttyB/orgs","repos_url":"https://api.github.com/users/m8ttyB/repos","events_url":"https://api.github.com/users/m8ttyB/events{/privacy}","received_events_url":"https://api.github.com/users/m8ttyB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/m8ttyB/bouncer-tests","description":"Tests for Mozilla's Bouncer; see https://github.com/mozilla/tuxedo and https://wiki.mozilla.org/Bouncer","fork":true,"url":"https://api.github.com/repos/m8ttyB/bouncer-tests","forks_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/forks","keys_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/teams","hooks_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/hooks","issue_events_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/issues/events{/number}","events_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/events","assignees_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/assignees{/user}","branches_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/branches{/branch}","tags_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/tags","blobs_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/languages","stargazers_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/stargazers","contributors_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/contributors","subscribers_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/subscribers","subscription_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/subscription","commits_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/contents/{+path}","compare_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/merges","archive_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/downloads","issues_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/issues{/number}","pulls_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/labels{/name}","releases_url":"https://api.github.com/repos/m8ttyB/bouncer-tests/releases{/id}","created_at":"2012-10-10T23:57:33Z","updated_at":"2014-08-19T17:36:04Z","pushed_at":"2015-09-23T00:12:13Z","git_url":"git://github.com/m8ttyB/bouncer-tests.git","ssh_url":"git@github.com:m8ttyB/bouncer-tests.git","clone_url":"https://github.com/m8ttyB/bouncer-tests.git","svn_url":"https://github.com/m8ttyB/bouncer-tests","homepage":"","size":221,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"41a97df4154a84e89801c97a6750827970f77fc1","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":6131595,"name":"bouncer-tests","full_name":"mozilla/bouncer-tests","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/bouncer-tests","description":"Tests for Mozilla's Bouncer; see https://github.com/mozilla/tuxedo and https://wiki.mozilla.org/Bouncer","fork":false,"url":"https://api.github.com/repos/mozilla/bouncer-tests","forks_url":"https://api.github.com/repos/mozilla/bouncer-tests/forks","keys_url":"https://api.github.com/repos/mozilla/bouncer-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/bouncer-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/bouncer-tests/teams","hooks_url":"https://api.github.com/repos/mozilla/bouncer-tests/hooks","issue_events_url":"https://api.github.com/repos/mozilla/bouncer-tests/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/bouncer-tests/events","assignees_url":"https://api.github.com/repos/mozilla/bouncer-tests/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/bouncer-tests/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/bouncer-tests/tags","blobs_url":"https://api.github.com/repos/mozilla/bouncer-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/bouncer-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/bouncer-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/bouncer-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/bouncer-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/bouncer-tests/languages","stargazers_url":"https://api.github.com/repos/mozilla/bouncer-tests/stargazers","contributors_url":"https://api.github.com/repos/mozilla/bouncer-tests/contributors","subscribers_url":"https://api.github.com/repos/mozilla/bouncer-tests/subscribers","subscription_url":"https://api.github.com/repos/mozilla/bouncer-tests/subscription","commits_url":"https://api.github.com/repos/mozilla/bouncer-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/bouncer-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/bouncer-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/bouncer-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/bouncer-tests/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/bouncer-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/bouncer-tests/merges","archive_url":"https://api.github.com/repos/mozilla/bouncer-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/bouncer-tests/downloads","issues_url":"https://api.github.com/repos/mozilla/bouncer-tests/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/bouncer-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/bouncer-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/bouncer-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/bouncer-tests/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/bouncer-tests/releases{/id}","created_at":"2012-10-08T21:30:31Z","updated_at":"2014-11-19T19:54:38Z","pushed_at":"2015-09-23T00:12:13Z","git_url":"git://github.com/mozilla/bouncer-tests.git","ssh_url":"git@github.com:mozilla/bouncer-tests.git","clone_url":"https://github.com/mozilla/bouncer-tests.git","svn_url":"https://github.com/mozilla/bouncer-tests","homepage":"","size":456,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":3,"forks":25,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/bouncer-tests/pulls/71"},"html":{"href":"https://github.com/mozilla/bouncer-tests/pull/71"},"issue":{"href":"https://api.github.com/repos/mozilla/bouncer-tests/issues/71"},"comments":{"href":"https://api.github.com/repos/mozilla/bouncer-tests/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/bouncer-tests/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/bouncer-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/bouncer-tests/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/bouncer-tests/statuses/3cb9a2fab81a9f0e30ea8be2e7cc896de730c84b"}}}}