{"action":"created","issue":{"url":"https://api.github.com/repos/bergie/passport-saml/issues/101","labels_url":"https://api.github.com/repos/bergie/passport-saml/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/bergie/passport-saml/issues/101/comments","events_url":"https://api.github.com/repos/bergie/passport-saml/issues/101/events","html_url":"https://github.com/bergie/passport-saml/pull/101","id":98414397,"number":101,"title":"Specify SingleLogoutService callback url","user":{"login":"achingbrain","id":665810,"avatar_url":"https://avatars.githubusercontent.com/u/665810?v=3","gravatar_id":"","url":"https://api.github.com/users/achingbrain","html_url":"https://github.com/achingbrain","followers_url":"https://api.github.com/users/achingbrain/followers","following_url":"https://api.github.com/users/achingbrain/following{/other_user}","gists_url":"https://api.github.com/users/achingbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/achingbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achingbrain/subscriptions","organizations_url":"https://api.github.com/users/achingbrain/orgs","repos_url":"https://api.github.com/users/achingbrain/repos","events_url":"https://api.github.com/users/achingbrain/events{/privacy}","received_events_url":"https://api.github.com/users/achingbrain/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-07-31T15:34:33Z","updated_at":"2015-10-16T15:15:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bergie/passport-saml/pulls/101","html_url":"https://github.com/bergie/passport-saml/pull/101","diff_url":"https://github.com/bergie/passport-saml/pull/101.diff","patch_url":"https://github.com/bergie/passport-saml/pull/101.patch"},"body":"We're using passport-saml in production and it's great (thanks!).  We've got ADFS automatically updating the service provider metadata, but the current implementation doesn't provide a SingleLogoutService callback URL.\r\n\r\nI've added this information to the generated metadata and added a test for it too.  We've been happily running this in production against ADFS 3.0 for several weeks without issue.\r\n\r\nI found that the order of elements in the metadata file is important, which is why I removed the inline addition of the `NameIDFormat` and `AssertionConsumerService` elements and instead added them after adding the `SingleLogoutService` bindings (if a `logoutCallbackUrl` option is supplied)."},"comment":{"url":"https://api.github.com/repos/bergie/passport-saml/issues/comments/148743521","html_url":"https://github.com/bergie/passport-saml/pull/101#issuecomment-148743521","issue_url":"https://api.github.com/repos/bergie/passport-saml/issues/101","id":148743521,"user":{"login":"cjbarth","id":3049726,"avatar_url":"https://avatars.githubusercontent.com/u/3049726?v=3","gravatar_id":"","url":"https://api.github.com/users/cjbarth","html_url":"https://github.com/cjbarth","followers_url":"https://api.github.com/users/cjbarth/followers","following_url":"https://api.github.com/users/cjbarth/following{/other_user}","gists_url":"https://api.github.com/users/cjbarth/gists{/gist_id}","starred_url":"https://api.github.com/users/cjbarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjbarth/subscriptions","organizations_url":"https://api.github.com/users/cjbarth/orgs","repos_url":"https://api.github.com/users/cjbarth/repos","events_url":"https://api.github.com/users/cjbarth/events{/privacy}","received_events_url":"https://api.github.com/users/cjbarth/received_events","type":"User","site_admin":false},"created_at":"2015-10-16T15:15:25Z","updated_at":"2015-10-16T15:15:25Z","body":"I've created a new pull request that should include all the same changes that PR #101 originally had. If there are any issues, please let me know.\nChris\n\nDate: Fri, 16 Oct 2015 06:50:03 -0700\nFrom: notifications@github.com\nTo: passport-saml@noreply.github.com\nCC: chrisjbarth@hotmail.com\nSubject: Re: [passport-saml] Specify SingleLogoutService callback url (#101)\n\nI no longer have access to the systems this patch was for - otherwise I'd rebase the change and resolve the merge conflicts, sorry.\n\n\n—\nReply to this email directly or view it on GitHub.\n\n\n  \n  \n\n\n \t\t \t   \t\t  "}}