{"action":"created","issue":{"url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1550","labels_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1550/labels{/name}","comments_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1550/comments","events_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1550/events","html_url":"https://github.com/OpenMS/OpenMS/pull/1550","id":98856245,"number":1550,"title":"[FIX]#1509","user":{"login":"mwalzer","id":5859205,"avatar_url":"https://avatars.githubusercontent.com/u/5859205?v=3","gravatar_id":"","url":"https://api.github.com/users/mwalzer","html_url":"https://github.com/mwalzer","followers_url":"https://api.github.com/users/mwalzer/followers","following_url":"https://api.github.com/users/mwalzer/following{/other_user}","gists_url":"https://api.github.com/users/mwalzer/gists{/gist_id}","starred_url":"https://api.github.com/users/mwalzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwalzer/subscriptions","organizations_url":"https://api.github.com/users/mwalzer/orgs","repos_url":"https://api.github.com/users/mwalzer/repos","events_url":"https://api.github.com/users/mwalzer/events{/privacy}","received_events_url":"https://api.github.com/users/mwalzer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-08-03T23:25:17Z","updated_at":"2015-12-04T17:33:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/1550","html_url":"https://github.com/OpenMS/OpenMS/pull/1550","diff_url":"https://github.com/OpenMS/OpenMS/pull/1550.diff","patch_url":"https://github.com/OpenMS/OpenMS/pull/1550.patch"},"body":"this PR fixes #1509"},"comment":{"url":"https://api.github.com/repos/OpenMS/OpenMS/issues/comments/162029823","html_url":"https://github.com/OpenMS/OpenMS/pull/1550#issuecomment-162029823","issue_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/1550","id":162029823,"user":{"login":"mwalzer","id":5859205,"avatar_url":"https://avatars.githubusercontent.com/u/5859205?v=3","gravatar_id":"","url":"https://api.github.com/users/mwalzer","html_url":"https://github.com/mwalzer","followers_url":"https://api.github.com/users/mwalzer/followers","following_url":"https://api.github.com/users/mwalzer/following{/other_user}","gists_url":"https://api.github.com/users/mwalzer/gists{/gist_id}","starred_url":"https://api.github.com/users/mwalzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwalzer/subscriptions","organizations_url":"https://api.github.com/users/mwalzer/orgs","repos_url":"https://api.github.com/users/mwalzer/repos","events_url":"https://api.github.com/users/mwalzer/events{/privacy}","received_events_url":"https://api.github.com/users/mwalzer/received_events","type":"User","site_admin":false},"created_at":"2015-12-04T17:33:41Z","updated_at":"2015-12-04T17:33:41Z","body":"Thanks for the review.\r\nAbout the magic numbers, there were already ModificationsDB queries in the code and I took over the tolerance from there. The default tolerance in the db methods is 0, which is pretty harsh, considering the mods are sometimes registered in 7digit precision.\r\nI found 0.001 acceptable for if the mod might be given in 'just' 3 digit precision in the pep.xml. There seem to be no greater overlaps in the ModificationsDB with that level of tolerance. @timosachsenberg has a better overview on the modifications, do you agree?\r\nBut I totally agree with you about the use of magic numbers in code being evil and I would replace these with a documented var."}}