{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/30939130","id":30939130,"diff_hunk":"@@ -164,6 +164,18 @@ private[v1] class ApiRootResource extends UIRootFromServletContext {\n     }\n   }\n \n+  @Path(\"applications/{appId}/download\")\n+  def getEventLogs(\n+    @PathParam(\"appId\") appId: String): EventLogDownloadResource = {\n+    new EventLogDownloadResource(uiRoot, appId, None)\n+  }\n+\n+  @Path(\"applications/{appId}/{attemptId}/download\")","path":"core/src/main/scala/org/apache/spark/status/api/v1/ApiRootResource.scala","position":10,"original_position":10,"commit_id":"0fc14249c1394ddc043b06cb0c11d4b119eed0da","original_commit_id":"0fc14249c1394ddc043b06cb0c11d4b119eed0da","user":{"login":"vanzin","id":1694083,"avatar_url":"https://avatars.githubusercontent.com/u/1694083?v=3","gravatar_id":"","url":"https://api.github.com/users/vanzin","html_url":"https://github.com/vanzin","followers_url":"https://api.github.com/users/vanzin/followers","following_url":"https://api.github.com/users/vanzin/following{/other_user}","gists_url":"https://api.github.com/users/vanzin/gists{/gist_id}","starred_url":"https://api.github.com/users/vanzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanzin/subscriptions","organizations_url":"https://api.github.com/users/vanzin/orgs","repos_url":"https://api.github.com/users/vanzin/repos","events_url":"https://api.github.com/users/vanzin/events{/privacy}","received_events_url":"https://api.github.com/users/vanzin/received_events","type":"User","site_admin":false},"body":"nit: a more REST-y version would be `applications/{appId}/attempts/{attemptId}/download`","created_at":"2015-05-23T00:08:40Z","updated_at":"2015-05-23T00:08:40Z","html_url":"https://github.com/apache/spark/pull/5792#discussion_r30939130","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/5792","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/30939130"},"html":{"href":"https://github.com/apache/spark/pull/5792#discussion_r30939130"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/5792"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/5792","id":34412673,"html_url":"https://github.com/apache/spark/pull/5792","diff_url":"https://github.com/apache/spark/pull/5792.diff","patch_url":"https://github.com/apache/spark/pull/5792.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/5792","number":5792,"state":"open","locked":false,"title":"[SPARK-7161][History Server] Provide REST api to download event logs fro...","user":{"login":"harishreedharan","id":1481194,"avatar_url":"https://avatars.githubusercontent.com/u/1481194?v=3","gravatar_id":"","url":"https://api.github.com/users/harishreedharan","html_url":"https://github.com/harishreedharan","followers_url":"https://api.github.com/users/harishreedharan/followers","following_url":"https://api.github.com/users/harishreedharan/following{/other_user}","gists_url":"https://api.github.com/users/harishreedharan/gists{/gist_id}","starred_url":"https://api.github.com/users/harishreedharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harishreedharan/subscriptions","organizations_url":"https://api.github.com/users/harishreedharan/orgs","repos_url":"https://api.github.com/users/harishreedharan/repos","events_url":"https://api.github.com/users/harishreedharan/events{/privacy}","received_events_url":"https://api.github.com/users/harishreedharan/received_events","type":"User","site_admin":false},"body":"...m History Server\r\n\r\nThis PR adds a new API that allows the user to download event logs for an application as a zip file.\r\nWe add an additional method to the ApplicationHistoryProvider to get the raw files, zipped. The zipped\r\nfiles are then sent to the client.\r\n\r\nI still need to add tests, but I am submitting this to get a review early since I am not that familiar with this part of the code and servlets.","created_at":"2015-04-29T22:29:06Z","updated_at":"2015-05-23T00:08:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f1bfe7f72402ee4075438f4be368409945d2614","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/5792/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/5792/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/5792/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/0fc14249c1394ddc043b06cb0c11d4b119eed0da","head":{"label":"harishreedharan:eventlog-download","ref":"eventlog-download","sha":"0fc14249c1394ddc043b06cb0c11d4b119eed0da","user":{"login":"harishreedharan","id":1481194,"avatar_url":"https://avatars.githubusercontent.com/u/1481194?v=3","gravatar_id":"","url":"https://api.github.com/users/harishreedharan","html_url":"https://github.com/harishreedharan","followers_url":"https://api.github.com/users/harishreedharan/followers","following_url":"https://api.github.com/users/harishreedharan/following{/other_user}","gists_url":"https://api.github.com/users/harishreedharan/gists{/gist_id}","starred_url":"https://api.github.com/users/harishreedharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harishreedharan/subscriptions","organizations_url":"https://api.github.com/users/harishreedharan/orgs","repos_url":"https://api.github.com/users/harishreedharan/repos","events_url":"https://api.github.com/users/harishreedharan/events{/privacy}","received_events_url":"https://api.github.com/users/harishreedharan/received_events","type":"User","site_admin":false},"repo":{"id":18419952,"name":"spark","full_name":"harishreedharan/spark","owner":{"login":"harishreedharan","id":1481194,"avatar_url":"https://avatars.githubusercontent.com/u/1481194?v=3","gravatar_id":"","url":"https://api.github.com/users/harishreedharan","html_url":"https://github.com/harishreedharan","followers_url":"https://api.github.com/users/harishreedharan/followers","following_url":"https://api.github.com/users/harishreedharan/following{/other_user}","gists_url":"https://api.github.com/users/harishreedharan/gists{/gist_id}","starred_url":"https://api.github.com/users/harishreedharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harishreedharan/subscriptions","organizations_url":"https://api.github.com/users/harishreedharan/orgs","repos_url":"https://api.github.com/users/harishreedharan/repos","events_url":"https://api.github.com/users/harishreedharan/events{/privacy}","received_events_url":"https://api.github.com/users/harishreedharan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harishreedharan/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/harishreedharan/spark","forks_url":"https://api.github.com/repos/harishreedharan/spark/forks","keys_url":"https://api.github.com/repos/harishreedharan/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harishreedharan/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harishreedharan/spark/teams","hooks_url":"https://api.github.com/repos/harishreedharan/spark/hooks","issue_events_url":"https://api.github.com/repos/harishreedharan/spark/issues/events{/number}","events_url":"https://api.github.com/repos/harishreedharan/spark/events","assignees_url":"https://api.github.com/repos/harishreedharan/spark/assignees{/user}","branches_url":"https://api.github.com/repos/harishreedharan/spark/branches{/branch}","tags_url":"https://api.github.com/repos/harishreedharan/spark/tags","blobs_url":"https://api.github.com/repos/harishreedharan/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harishreedharan/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harishreedharan/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/harishreedharan/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harishreedharan/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/harishreedharan/spark/languages","stargazers_url":"https://api.github.com/repos/harishreedharan/spark/stargazers","contributors_url":"https://api.github.com/repos/harishreedharan/spark/contributors","subscribers_url":"https://api.github.com/repos/harishreedharan/spark/subscribers","subscription_url":"https://api.github.com/repos/harishreedharan/spark/subscription","commits_url":"https://api.github.com/repos/harishreedharan/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/harishreedharan/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/harishreedharan/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/harishreedharan/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/harishreedharan/spark/contents/{+path}","compare_url":"https://api.github.com/repos/harishreedharan/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harishreedharan/spark/merges","archive_url":"https://api.github.com/repos/harishreedharan/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harishreedharan/spark/downloads","issues_url":"https://api.github.com/repos/harishreedharan/spark/issues{/number}","pulls_url":"https://api.github.com/repos/harishreedharan/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/harishreedharan/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/harishreedharan/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harishreedharan/spark/labels{/name}","releases_url":"https://api.github.com/repos/harishreedharan/spark/releases{/id}","created_at":"2014-04-03T22:17:22Z","updated_at":"2014-07-10T22:11:34Z","pushed_at":"2015-05-22T23:07:45Z","git_url":"git://github.com/harishreedharan/spark.git","ssh_url":"git@github.com:harishreedharan/spark.git","clone_url":"https://github.com/harishreedharan/spark.git","svn_url":"https://github.com/harishreedharan/spark","homepage":null,"size":102551,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8730fbb47b09fcf955fe16dd03b75596db6d53b6","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-05-22T20:04:35Z","pushed_at":"2015-05-22T23:11:05Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1714892,"stargazers_count":4058,"watchers_count":4058,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3569,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":312,"forks":3569,"open_issues":312,"watchers":4058,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/5792"},"html":{"href":"https://github.com/apache/spark/pull/5792"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/5792"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/5792/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/5792/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/5792/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/0fc14249c1394ddc043b06cb0c11d4b119eed0da"}}}}