{"action":"created","comment":{"url":"https://api.github.com/repos/pydoit/doit/pulls/comments/24554322","id":24554322,"diff_hunk":"@@ -361,6 +338,96 @@ def remove_all(self):\n         self._conn.execute('delete from doit')\n \n \n+class BaseChecker(object):","path":"doit/dependency.py","position":56,"original_position":56,"commit_id":"c7b0e39a754cc265b776e56650ae71c4179d6c96","original_commit_id":"c7b0e39a754cc265b776e56650ae71c4179d6c96","user":{"login":"schettino72","id":138474,"avatar_url":"https://avatars.githubusercontent.com/u/138474?v=3","gravatar_id":"","url":"https://api.github.com/users/schettino72","html_url":"https://github.com/schettino72","followers_url":"https://api.github.com/users/schettino72/followers","following_url":"https://api.github.com/users/schettino72/following{/other_user}","gists_url":"https://api.github.com/users/schettino72/gists{/gist_id}","starred_url":"https://api.github.com/users/schettino72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schettino72/subscriptions","organizations_url":"https://api.github.com/users/schettino72/orgs","repos_url":"https://api.github.com/users/schettino72/repos","events_url":"https://api.github.com/users/schettino72/events{/privacy}","received_events_url":"https://api.github.com/users/schettino72/received_events","type":"User","site_admin":false},"body":"The name `checker` is too generic. Can we use something like `FileChangedChecker` ? It is ugly and long but much more clear. ","created_at":"2015-02-12T02:38:34Z","updated_at":"2015-02-12T02:38:34Z","html_url":"https://github.com/pydoit/doit/pull/23#discussion_r24554322","pull_request_url":"https://api.github.com/repos/pydoit/doit/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/pydoit/doit/pulls/comments/24554322"},"html":{"href":"https://github.com/pydoit/doit/pull/23#discussion_r24554322"},"pull_request":{"href":"https://api.github.com/repos/pydoit/doit/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/pydoit/doit/pulls/23","id":28801609,"html_url":"https://github.com/pydoit/doit/pull/23","diff_url":"https://github.com/pydoit/doit/pull/23.diff","patch_url":"https://github.com/pydoit/doit/pull/23.patch","issue_url":"https://api.github.com/repos/pydoit/doit/issues/23","number":23,"state":"open","locked":false,"title":"Allow to customize how file_dep are checked.","user":{"login":"saimn","id":311639,"avatar_url":"https://avatars.githubusercontent.com/u/311639?v=3","gravatar_id":"","url":"https://api.github.com/users/saimn","html_url":"https://github.com/saimn","followers_url":"https://api.github.com/users/saimn/followers","following_url":"https://api.github.com/users/saimn/following{/other_user}","gists_url":"https://api.github.com/users/saimn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimn/subscriptions","organizations_url":"https://api.github.com/users/saimn/orgs","repos_url":"https://api.github.com/users/saimn/repos","events_url":"https://api.github.com/users/saimn/events{/privacy}","received_events_url":"https://api.github.com/users/saimn/received_events","type":"User","site_admin":false},"body":"Following #22, I tried to do something, but I don't understand clearly how the config / params are handled. Comments welcome ;)\r\n\r\nAdd a `modified_checkers` option which allows to choose how file_dep are checked\r\nto know if they are modified. `modified_checkers` is a dict with boolean values\r\nfor each checker:\r\n```\r\nDOIT_CONFIG = {\r\n    'modified_checkers' : {\r\n        'timestamp': True,\r\n        'size': True,\r\n        'md5': True\r\n    }\r\n}\r\n```","created_at":"2015-02-06T11:21:34Z","updated_at":"2015-02-12T02:38:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2a0a7d9b4d97454afbba5b74b3ab9f734fc0e8c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pydoit/doit/pulls/23/commits","review_comments_url":"https://api.github.com/repos/pydoit/doit/pulls/23/comments","review_comment_url":"https://api.github.com/repos/pydoit/doit/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pydoit/doit/issues/23/comments","statuses_url":"https://api.github.com/repos/pydoit/doit/statuses/c7b0e39a754cc265b776e56650ae71c4179d6c96","head":{"label":"saimn:checker-options","ref":"checker-options","sha":"c7b0e39a754cc265b776e56650ae71c4179d6c96","user":{"login":"saimn","id":311639,"avatar_url":"https://avatars.githubusercontent.com/u/311639?v=3","gravatar_id":"","url":"https://api.github.com/users/saimn","html_url":"https://github.com/saimn","followers_url":"https://api.github.com/users/saimn/followers","following_url":"https://api.github.com/users/saimn/following{/other_user}","gists_url":"https://api.github.com/users/saimn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimn/subscriptions","organizations_url":"https://api.github.com/users/saimn/orgs","repos_url":"https://api.github.com/users/saimn/repos","events_url":"https://api.github.com/users/saimn/events{/privacy}","received_events_url":"https://api.github.com/users/saimn/received_events","type":"User","site_admin":false},"repo":{"id":30408032,"name":"doit","full_name":"saimn/doit","owner":{"login":"saimn","id":311639,"avatar_url":"https://avatars.githubusercontent.com/u/311639?v=3","gravatar_id":"","url":"https://api.github.com/users/saimn","html_url":"https://github.com/saimn","followers_url":"https://api.github.com/users/saimn/followers","following_url":"https://api.github.com/users/saimn/following{/other_user}","gists_url":"https://api.github.com/users/saimn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimn/subscriptions","organizations_url":"https://api.github.com/users/saimn/orgs","repos_url":"https://api.github.com/users/saimn/repos","events_url":"https://api.github.com/users/saimn/events{/privacy}","received_events_url":"https://api.github.com/users/saimn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saimn/doit","description":"automation tool","fork":true,"url":"https://api.github.com/repos/saimn/doit","forks_url":"https://api.github.com/repos/saimn/doit/forks","keys_url":"https://api.github.com/repos/saimn/doit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saimn/doit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saimn/doit/teams","hooks_url":"https://api.github.com/repos/saimn/doit/hooks","issue_events_url":"https://api.github.com/repos/saimn/doit/issues/events{/number}","events_url":"https://api.github.com/repos/saimn/doit/events","assignees_url":"https://api.github.com/repos/saimn/doit/assignees{/user}","branches_url":"https://api.github.com/repos/saimn/doit/branches{/branch}","tags_url":"https://api.github.com/repos/saimn/doit/tags","blobs_url":"https://api.github.com/repos/saimn/doit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saimn/doit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saimn/doit/git/refs{/sha}","trees_url":"https://api.github.com/repos/saimn/doit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saimn/doit/statuses/{sha}","languages_url":"https://api.github.com/repos/saimn/doit/languages","stargazers_url":"https://api.github.com/repos/saimn/doit/stargazers","contributors_url":"https://api.github.com/repos/saimn/doit/contributors","subscribers_url":"https://api.github.com/repos/saimn/doit/subscribers","subscription_url":"https://api.github.com/repos/saimn/doit/subscription","commits_url":"https://api.github.com/repos/saimn/doit/commits{/sha}","git_commits_url":"https://api.github.com/repos/saimn/doit/git/commits{/sha}","comments_url":"https://api.github.com/repos/saimn/doit/comments{/number}","issue_comment_url":"https://api.github.com/repos/saimn/doit/issues/comments/{number}","contents_url":"https://api.github.com/repos/saimn/doit/contents/{+path}","compare_url":"https://api.github.com/repos/saimn/doit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saimn/doit/merges","archive_url":"https://api.github.com/repos/saimn/doit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saimn/doit/downloads","issues_url":"https://api.github.com/repos/saimn/doit/issues{/number}","pulls_url":"https://api.github.com/repos/saimn/doit/pulls{/number}","milestones_url":"https://api.github.com/repos/saimn/doit/milestones{/number}","notifications_url":"https://api.github.com/repos/saimn/doit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saimn/doit/labels{/name}","releases_url":"https://api.github.com/repos/saimn/doit/releases{/id}","created_at":"2015-02-06T10:52:55Z","updated_at":"2015-02-06T10:52:55Z","pushed_at":"2015-02-11T15:32:24Z","git_url":"git://github.com/saimn/doit.git","ssh_url":"git@github.com:saimn/doit.git","clone_url":"https://github.com/saimn/doit.git","svn_url":"https://github.com/saimn/doit","homepage":"http://pydoit.org","size":5870,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydoit:master","ref":"master","sha":"7af7f93353af548ff1882a0f4980f5e2f6e36d0c","user":{"login":"pydoit","id":6440864,"avatar_url":"https://avatars.githubusercontent.com/u/6440864?v=3","gravatar_id":"","url":"https://api.github.com/users/pydoit","html_url":"https://github.com/pydoit","followers_url":"https://api.github.com/users/pydoit/followers","following_url":"https://api.github.com/users/pydoit/following{/other_user}","gists_url":"https://api.github.com/users/pydoit/gists{/gist_id}","starred_url":"https://api.github.com/users/pydoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydoit/subscriptions","organizations_url":"https://api.github.com/users/pydoit/orgs","repos_url":"https://api.github.com/users/pydoit/repos","events_url":"https://api.github.com/users/pydoit/events{/privacy}","received_events_url":"https://api.github.com/users/pydoit/received_events","type":"Organization","site_admin":false},"repo":{"id":16851127,"name":"doit","full_name":"pydoit/doit","owner":{"login":"pydoit","id":6440864,"avatar_url":"https://avatars.githubusercontent.com/u/6440864?v=3","gravatar_id":"","url":"https://api.github.com/users/pydoit","html_url":"https://github.com/pydoit","followers_url":"https://api.github.com/users/pydoit/followers","following_url":"https://api.github.com/users/pydoit/following{/other_user}","gists_url":"https://api.github.com/users/pydoit/gists{/gist_id}","starred_url":"https://api.github.com/users/pydoit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydoit/subscriptions","organizations_url":"https://api.github.com/users/pydoit/orgs","repos_url":"https://api.github.com/users/pydoit/repos","events_url":"https://api.github.com/users/pydoit/events{/privacy}","received_events_url":"https://api.github.com/users/pydoit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydoit/doit","description":"automation tool","fork":false,"url":"https://api.github.com/repos/pydoit/doit","forks_url":"https://api.github.com/repos/pydoit/doit/forks","keys_url":"https://api.github.com/repos/pydoit/doit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydoit/doit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydoit/doit/teams","hooks_url":"https://api.github.com/repos/pydoit/doit/hooks","issue_events_url":"https://api.github.com/repos/pydoit/doit/issues/events{/number}","events_url":"https://api.github.com/repos/pydoit/doit/events","assignees_url":"https://api.github.com/repos/pydoit/doit/assignees{/user}","branches_url":"https://api.github.com/repos/pydoit/doit/branches{/branch}","tags_url":"https://api.github.com/repos/pydoit/doit/tags","blobs_url":"https://api.github.com/repos/pydoit/doit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydoit/doit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydoit/doit/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydoit/doit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydoit/doit/statuses/{sha}","languages_url":"https://api.github.com/repos/pydoit/doit/languages","stargazers_url":"https://api.github.com/repos/pydoit/doit/stargazers","contributors_url":"https://api.github.com/repos/pydoit/doit/contributors","subscribers_url":"https://api.github.com/repos/pydoit/doit/subscribers","subscription_url":"https://api.github.com/repos/pydoit/doit/subscription","commits_url":"https://api.github.com/repos/pydoit/doit/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydoit/doit/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydoit/doit/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydoit/doit/issues/comments/{number}","contents_url":"https://api.github.com/repos/pydoit/doit/contents/{+path}","compare_url":"https://api.github.com/repos/pydoit/doit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydoit/doit/merges","archive_url":"https://api.github.com/repos/pydoit/doit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydoit/doit/downloads","issues_url":"https://api.github.com/repos/pydoit/doit/issues{/number}","pulls_url":"https://api.github.com/repos/pydoit/doit/pulls{/number}","milestones_url":"https://api.github.com/repos/pydoit/doit/milestones{/number}","notifications_url":"https://api.github.com/repos/pydoit/doit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydoit/doit/labels{/name}","releases_url":"https://api.github.com/repos/pydoit/doit/releases{/id}","created_at":"2014-02-14T22:21:23Z","updated_at":"2015-02-11T23:06:13Z","pushed_at":"2015-01-30T09:32:04Z","git_url":"git://github.com/pydoit/doit.git","ssh_url":"git@github.com:pydoit/doit.git","clone_url":"https://github.com/pydoit/doit.git","svn_url":"https://github.com/pydoit/doit","homepage":"http://pydoit.org","size":6385,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":9,"forks":13,"open_issues":9,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydoit/doit/pulls/23"},"html":{"href":"https://github.com/pydoit/doit/pull/23"},"issue":{"href":"https://api.github.com/repos/pydoit/doit/issues/23"},"comments":{"href":"https://api.github.com/repos/pydoit/doit/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/pydoit/doit/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/pydoit/doit/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pydoit/doit/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/pydoit/doit/statuses/c7b0e39a754cc265b776e56650ae71c4179d6c96"}}}}