{"action":"created","issue":{"url":"https://api.github.com/repos/open-keychain/open-keychain/issues/1610","labels_url":"https://api.github.com/repos/open-keychain/open-keychain/issues/1610/labels{/name}","comments_url":"https://api.github.com/repos/open-keychain/open-keychain/issues/1610/comments","events_url":"https://api.github.com/repos/open-keychain/open-keychain/issues/1610/events","html_url":"https://github.com/open-keychain/open-keychain/pull/1610","id":118731130,"number":1610,"title":"Basic Facebook Support","user":{"login":"adithyaphilip","id":5712241,"avatar_url":"https://avatars.githubusercontent.com/u/5712241?v=3","gravatar_id":"","url":"https://api.github.com/users/adithyaphilip","html_url":"https://github.com/adithyaphilip","followers_url":"https://api.github.com/users/adithyaphilip/followers","following_url":"https://api.github.com/users/adithyaphilip/following{/other_user}","gists_url":"https://api.github.com/users/adithyaphilip/gists{/gist_id}","starred_url":"https://api.github.com/users/adithyaphilip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adithyaphilip/subscriptions","organizations_url":"https://api.github.com/users/adithyaphilip/orgs","repos_url":"https://api.github.com/users/adithyaphilip/repos","events_url":"https://api.github.com/users/adithyaphilip/events{/privacy}","received_events_url":"https://api.github.com/users/adithyaphilip/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/open-keychain/open-keychain/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-11-25T00:12:33Z","updated_at":"2015-11-27T18:39:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/open-keychain/open-keychain/pulls/1610","html_url":"https://github.com/open-keychain/open-keychain/pull/1610","diff_url":"https://github.com/open-keychain/open-keychain/pull/1610.diff","patch_url":"https://github.com/open-keychain/open-keychain/pull/1610.patch"},"body":"Related to https://github.com/open-keychain/open-keychain/issues/1321\r\nThis PR adds:\r\n* Support for importing keys from links of the form:\r\nhttps://www.facebook.com/*/publickey/download.\r\ne.g. https://www.facebook.com/adithya.abraham/publickey/download <br>\r\nRequirement: The visibility of the key must be set to \"Public\" on Facebook.\r\n* Reloading of `ImportKeysActivity` if the activity was already open and a new Intent is received.\r\n\r\nTesting Facebook search:\r\n* Clicking on above link in browser (after which you may search for any Facebook username) (or)\r\n* Add https://facebook.com as preferred keyserver (this works because of the URL inspection mentioned below) and searching for a person's Facebook username.\r\n\r\nA query to Facebook is currently identified in `CloudSearch` and `ImportOperation` by URL inspection. I'm guessing this should be changed to something more centralized like adding a new boolean `searchFacebook` to `CloudSearchPrefs`, similar to `searchKeybase`. Working on that right now. Is everything else fine?\r\n"},"comment":{"url":"https://api.github.com/repos/open-keychain/open-keychain/issues/comments/160187149","html_url":"https://github.com/open-keychain/open-keychain/pull/1610#issuecomment-160187149","issue_url":"https://api.github.com/repos/open-keychain/open-keychain/issues/1610","id":160187149,"user":{"login":"adithyaphilip","id":5712241,"avatar_url":"https://avatars.githubusercontent.com/u/5712241?v=3","gravatar_id":"","url":"https://api.github.com/users/adithyaphilip","html_url":"https://github.com/adithyaphilip","followers_url":"https://api.github.com/users/adithyaphilip/followers","following_url":"https://api.github.com/users/adithyaphilip/following{/other_user}","gists_url":"https://api.github.com/users/adithyaphilip/gists{/gist_id}","starred_url":"https://api.github.com/users/adithyaphilip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adithyaphilip/subscriptions","organizations_url":"https://api.github.com/users/adithyaphilip/orgs","repos_url":"https://api.github.com/users/adithyaphilip/repos","events_url":"https://api.github.com/users/adithyaphilip/events{/privacy}","received_events_url":"https://api.github.com/users/adithyaphilip/received_events","type":"User","site_admin":false},"created_at":"2015-11-27T18:39:37Z","updated_at":"2015-11-27T18:39:37Z","body":"Try adithya.abraham and amoghbl1. Isn't *exactly* a search though, since the usernames need to match completely.\r\n\r\nAs for the `commitAllowingStateLoss`, thankyou, that does sound a lot better. Will change and push soon."}}