{"action":"created","comment":{"url":"https://api.github.com/repos/windup/windup/pulls/comments/27087299","id":27087299,"diff_hunk":"@@ -165,6 +165,10 @@ if [ -r \"$WINDUP_HOME/addons/\" ] ; then\n   ADDONS_DIR=\"--immutableAddonDir $WINDUP_HOME/addons/\"\n fi\n \n+if [ -z \"$MAX_MEMORY\" ] ; then\n+  MAX_MEMORY=\"2048m\"\n+fi\n+","path":"dist/src/main/resources/bin/windup","position":7,"original_position":7,"commit_id":"c6d68f869ed1417be2b72d766fc9027b9c0fc9e0","original_commit_id":"c6d68f869ed1417be2b72d766fc9027b9c0fc9e0","user":{"login":"jsight","id":1181549,"avatar_url":"https://avatars.githubusercontent.com/u/1181549?v=3","gravatar_id":"","url":"https://api.github.com/users/jsight","html_url":"https://github.com/jsight","followers_url":"https://api.github.com/users/jsight/followers","following_url":"https://api.github.com/users/jsight/following{/other_user}","gists_url":"https://api.github.com/users/jsight/gists{/gist_id}","starred_url":"https://api.github.com/users/jsight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsight/subscriptions","organizations_url":"https://api.github.com/users/jsight/orgs","repos_url":"https://api.github.com/users/jsight/repos","events_url":"https://api.github.com/users/jsight/events{/privacy}","received_events_url":"https://api.github.com/users/jsight/received_events","type":"User","site_admin":false},"body":"I'm still -1 on this patch (for reasons that I have mentioned previously), but I definitely wouldn't recommend going larger. Swapping and GC'ed languages combine extremely poorly for various reasons, and there are still a lot of 4GB languages out there.","created_at":"2015-03-25T00:44:51Z","updated_at":"2015-03-25T00:44:51Z","html_url":"https://github.com/windup/windup/pull/509#discussion_r27087299","pull_request_url":"https://api.github.com/repos/windup/windup/pulls/509","_links":{"self":{"href":"https://api.github.com/repos/windup/windup/pulls/comments/27087299"},"html":{"href":"https://github.com/windup/windup/pull/509#discussion_r27087299"},"pull_request":{"href":"https://api.github.com/repos/windup/windup/pulls/509"}}},"pull_request":{"url":"https://api.github.com/repos/windup/windup/pulls/509","id":31836244,"html_url":"https://github.com/windup/windup/pull/509","diff_url":"https://github.com/windup/windup/pull/509.diff","patch_url":"https://github.com/windup/windup/pull/509.patch","issue_url":"https://api.github.com/repos/windup/windup/issues/509","number":509,"state":"open","locked":false,"title":"Set default $MAX_MEMORY","user":{"login":"lincolnthree","id":362329,"avatar_url":"https://avatars.githubusercontent.com/u/362329?v=3","gravatar_id":"","url":"https://api.github.com/users/lincolnthree","html_url":"https://github.com/lincolnthree","followers_url":"https://api.github.com/users/lincolnthree/followers","following_url":"https://api.github.com/users/lincolnthree/following{/other_user}","gists_url":"https://api.github.com/users/lincolnthree/gists{/gist_id}","starred_url":"https://api.github.com/users/lincolnthree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lincolnthree/subscriptions","organizations_url":"https://api.github.com/users/lincolnthree/orgs","repos_url":"https://api.github.com/users/lincolnthree/repos","events_url":"https://api.github.com/users/lincolnthree/events{/privacy}","received_events_url":"https://api.github.com/users/lincolnthree/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-24T15:18:13Z","updated_at":"2015-03-25T00:44:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f885f7d15d16debeb7e0e0759769370c515f14b0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/windup/windup/pulls/509/commits","review_comments_url":"https://api.github.com/repos/windup/windup/pulls/509/comments","review_comment_url":"https://api.github.com/repos/windup/windup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/windup/windup/issues/509/comments","statuses_url":"https://api.github.com/repos/windup/windup/statuses/c6d68f869ed1417be2b72d766fc9027b9c0fc9e0","head":{"label":"windup:lincolnthree-maxmem","ref":"lincolnthree-maxmem","sha":"c6d68f869ed1417be2b72d766fc9027b9c0fc9e0","user":{"login":"windup","id":4266383,"avatar_url":"https://avatars.githubusercontent.com/u/4266383?v=3","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"repo":{"id":9702026,"name":"windup","full_name":"windup/windup","owner":{"login":"windup","id":4266383,"avatar_url":"https://avatars.githubusercontent.com/u/4266383?v=3","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/windup/windup","description":"Windup - JBoss Automated Migration Tool","fork":false,"url":"https://api.github.com/repos/windup/windup","forks_url":"https://api.github.com/repos/windup/windup/forks","keys_url":"https://api.github.com/repos/windup/windup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windup/windup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windup/windup/teams","hooks_url":"https://api.github.com/repos/windup/windup/hooks","issue_events_url":"https://api.github.com/repos/windup/windup/issues/events{/number}","events_url":"https://api.github.com/repos/windup/windup/events","assignees_url":"https://api.github.com/repos/windup/windup/assignees{/user}","branches_url":"https://api.github.com/repos/windup/windup/branches{/branch}","tags_url":"https://api.github.com/repos/windup/windup/tags","blobs_url":"https://api.github.com/repos/windup/windup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windup/windup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windup/windup/git/refs{/sha}","trees_url":"https://api.github.com/repos/windup/windup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windup/windup/statuses/{sha}","languages_url":"https://api.github.com/repos/windup/windup/languages","stargazers_url":"https://api.github.com/repos/windup/windup/stargazers","contributors_url":"https://api.github.com/repos/windup/windup/contributors","subscribers_url":"https://api.github.com/repos/windup/windup/subscribers","subscription_url":"https://api.github.com/repos/windup/windup/subscription","commits_url":"https://api.github.com/repos/windup/windup/commits{/sha}","git_commits_url":"https://api.github.com/repos/windup/windup/git/commits{/sha}","comments_url":"https://api.github.com/repos/windup/windup/comments{/number}","issue_comment_url":"https://api.github.com/repos/windup/windup/issues/comments{/number}","contents_url":"https://api.github.com/repos/windup/windup/contents/{+path}","compare_url":"https://api.github.com/repos/windup/windup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windup/windup/merges","archive_url":"https://api.github.com/repos/windup/windup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windup/windup/downloads","issues_url":"https://api.github.com/repos/windup/windup/issues{/number}","pulls_url":"https://api.github.com/repos/windup/windup/pulls{/number}","milestones_url":"https://api.github.com/repos/windup/windup/milestones{/number}","notifications_url":"https://api.github.com/repos/windup/windup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windup/windup/labels{/name}","releases_url":"https://api.github.com/repos/windup/windup/releases{/id}","created_at":"2013-04-26T18:52:08Z","updated_at":"2015-03-24T15:43:12Z","pushed_at":"2015-03-24T23:53:21Z","git_url":"git://github.com/windup/windup.git","ssh_url":"git@github.com:windup/windup.git","clone_url":"https://github.com/windup/windup.git","svn_url":"https://github.com/windup/windup","homepage":"","size":89255,"stargazers_count":34,"watchers_count":34,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":64,"mirror_url":null,"open_issues_count":42,"forks":64,"open_issues":42,"watchers":34,"default_branch":"master"}},"base":{"label":"windup:master","ref":"master","sha":"f073e1ad149e2e7c93f657b3280af2c5cf91a688","user":{"login":"windup","id":4266383,"avatar_url":"https://avatars.githubusercontent.com/u/4266383?v=3","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"repo":{"id":9702026,"name":"windup","full_name":"windup/windup","owner":{"login":"windup","id":4266383,"avatar_url":"https://avatars.githubusercontent.com/u/4266383?v=3","gravatar_id":"","url":"https://api.github.com/users/windup","html_url":"https://github.com/windup","followers_url":"https://api.github.com/users/windup/followers","following_url":"https://api.github.com/users/windup/following{/other_user}","gists_url":"https://api.github.com/users/windup/gists{/gist_id}","starred_url":"https://api.github.com/users/windup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windup/subscriptions","organizations_url":"https://api.github.com/users/windup/orgs","repos_url":"https://api.github.com/users/windup/repos","events_url":"https://api.github.com/users/windup/events{/privacy}","received_events_url":"https://api.github.com/users/windup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/windup/windup","description":"Windup - JBoss Automated Migration Tool","fork":false,"url":"https://api.github.com/repos/windup/windup","forks_url":"https://api.github.com/repos/windup/windup/forks","keys_url":"https://api.github.com/repos/windup/windup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windup/windup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windup/windup/teams","hooks_url":"https://api.github.com/repos/windup/windup/hooks","issue_events_url":"https://api.github.com/repos/windup/windup/issues/events{/number}","events_url":"https://api.github.com/repos/windup/windup/events","assignees_url":"https://api.github.com/repos/windup/windup/assignees{/user}","branches_url":"https://api.github.com/repos/windup/windup/branches{/branch}","tags_url":"https://api.github.com/repos/windup/windup/tags","blobs_url":"https://api.github.com/repos/windup/windup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windup/windup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windup/windup/git/refs{/sha}","trees_url":"https://api.github.com/repos/windup/windup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windup/windup/statuses/{sha}","languages_url":"https://api.github.com/repos/windup/windup/languages","stargazers_url":"https://api.github.com/repos/windup/windup/stargazers","contributors_url":"https://api.github.com/repos/windup/windup/contributors","subscribers_url":"https://api.github.com/repos/windup/windup/subscribers","subscription_url":"https://api.github.com/repos/windup/windup/subscription","commits_url":"https://api.github.com/repos/windup/windup/commits{/sha}","git_commits_url":"https://api.github.com/repos/windup/windup/git/commits{/sha}","comments_url":"https://api.github.com/repos/windup/windup/comments{/number}","issue_comment_url":"https://api.github.com/repos/windup/windup/issues/comments{/number}","contents_url":"https://api.github.com/repos/windup/windup/contents/{+path}","compare_url":"https://api.github.com/repos/windup/windup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windup/windup/merges","archive_url":"https://api.github.com/repos/windup/windup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windup/windup/downloads","issues_url":"https://api.github.com/repos/windup/windup/issues{/number}","pulls_url":"https://api.github.com/repos/windup/windup/pulls{/number}","milestones_url":"https://api.github.com/repos/windup/windup/milestones{/number}","notifications_url":"https://api.github.com/repos/windup/windup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windup/windup/labels{/name}","releases_url":"https://api.github.com/repos/windup/windup/releases{/id}","created_at":"2013-04-26T18:52:08Z","updated_at":"2015-03-24T15:43:12Z","pushed_at":"2015-03-24T23:53:21Z","git_url":"git://github.com/windup/windup.git","ssh_url":"git@github.com:windup/windup.git","clone_url":"https://github.com/windup/windup.git","svn_url":"https://github.com/windup/windup","homepage":"","size":89255,"stargazers_count":34,"watchers_count":34,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":64,"mirror_url":null,"open_issues_count":42,"forks":64,"open_issues":42,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/windup/windup/pulls/509"},"html":{"href":"https://github.com/windup/windup/pull/509"},"issue":{"href":"https://api.github.com/repos/windup/windup/issues/509"},"comments":{"href":"https://api.github.com/repos/windup/windup/issues/509/comments"},"review_comments":{"href":"https://api.github.com/repos/windup/windup/pulls/509/comments"},"review_comment":{"href":"https://api.github.com/repos/windup/windup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/windup/windup/pulls/509/commits"},"statuses":{"href":"https://api.github.com/repos/windup/windup/statuses/c6d68f869ed1417be2b72d766fc9027b9c0fc9e0"}}}}