{"action":"opened","number":1283,"pull_request":{"url":"https://api.github.com/repos/mautic/mautic/pulls/1283","id":54591898,"html_url":"https://github.com/mautic/mautic/pull/1283","diff_url":"https://github.com/mautic/mautic/pull/1283.diff","patch_url":"https://github.com/mautic/mautic/pull/1283.patch","issue_url":"https://api.github.com/repos/mautic/mautic/issues/1283","number":1283,"state":"open","locked":false,"title":"Updates the file manager ACL to use Symfony's session instead of $_SESSION","user":{"login":"alanhartless","id":63312,"avatar_url":"https://avatars.githubusercontent.com/u/63312?v=3","gravatar_id":"","url":"https://api.github.com/users/alanhartless","html_url":"https://github.com/alanhartless","followers_url":"https://api.github.com/users/alanhartless/followers","following_url":"https://api.github.com/users/alanhartless/following{/other_user}","gists_url":"https://api.github.com/users/alanhartless/gists{/gist_id}","starred_url":"https://api.github.com/users/alanhartless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanhartless/subscriptions","organizations_url":"https://api.github.com/users/alanhartless/orgs","repos_url":"https://api.github.com/users/alanhartless/repos","events_url":"https://api.github.com/users/alanhartless/events{/privacy}","received_events_url":"https://api.github.com/users/alanhartless/received_events","type":"User","site_admin":false},"body":"**Description**\r\n\r\nThe filemanager handles ACL through a custom function. Before, we simply checked for a user ID in the session.  This PR hardens security by booting Symfony and checking for an authenticated user.\r\n\r\n**Testing**\r\n\r\nApply the PR. Edit/create a landing page and click the Image button then Browse Server. If logged into Mautic, images should show.  Now, leave the popup/filemanager open and log out of Mautic in the parent window.  Go back to the filemanager and refresh.  You should get an access denied message.","created_at":"2015-12-25T18:29:17Z","updated_at":"2015-12-25T18:29:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mautic/mautic/milestones/10","html_url":"https://github.com/mautic/mautic/milestones/1.3.0","labels_url":"https://api.github.com/repos/mautic/mautic/milestones/10/labels","id":1421814,"number":10,"title":"1.3.0","description":"- [ ] Mautic Marketplace\r\n- [ ] Import/Export\r\n- [ ] AJAX queues and email sending\r\n- [ ] Time (in addition to date) scheduling\r\n- [ ] Custom Lead Field Groups","creator":{"login":"dbhurley","id":5251425,"avatar_url":"https://avatars.githubusercontent.com/u/5251425?v=3","gravatar_id":"","url":"https://api.github.com/users/dbhurley","html_url":"https://github.com/dbhurley","followers_url":"https://api.github.com/users/dbhurley/followers","following_url":"https://api.github.com/users/dbhurley/following{/other_user}","gists_url":"https://api.github.com/users/dbhurley/gists{/gist_id}","starred_url":"https://api.github.com/users/dbhurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbhurley/subscriptions","organizations_url":"https://api.github.com/users/dbhurley/orgs","repos_url":"https://api.github.com/users/dbhurley/repos","events_url":"https://api.github.com/users/dbhurley/events{/privacy}","received_events_url":"https://api.github.com/users/dbhurley/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":0,"state":"open","created_at":"2015-11-20T14:37:25Z","updated_at":"2015-12-25T18:29:17Z","due_on":"2016-03-29T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mautic/mautic/pulls/1283/commits","review_comments_url":"https://api.github.com/repos/mautic/mautic/pulls/1283/comments","review_comment_url":"https://api.github.com/repos/mautic/mautic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mautic/mautic/issues/1283/comments","statuses_url":"https://api.github.com/repos/mautic/mautic/statuses/9cefb8cff06d9429c05ffff588d9d8583f4f85cc","head":{"label":"alanhartless:filemanger-session-change","ref":"filemanger-session-change","sha":"9cefb8cff06d9429c05ffff588d9d8583f4f85cc","user":{"login":"alanhartless","id":63312,"avatar_url":"https://avatars.githubusercontent.com/u/63312?v=3","gravatar_id":"","url":"https://api.github.com/users/alanhartless","html_url":"https://github.com/alanhartless","followers_url":"https://api.github.com/users/alanhartless/followers","following_url":"https://api.github.com/users/alanhartless/following{/other_user}","gists_url":"https://api.github.com/users/alanhartless/gists{/gist_id}","starred_url":"https://api.github.com/users/alanhartless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanhartless/subscriptions","organizations_url":"https://api.github.com/users/alanhartless/orgs","repos_url":"https://api.github.com/users/alanhartless/repos","events_url":"https://api.github.com/users/alanhartless/events{/privacy}","received_events_url":"https://api.github.com/users/alanhartless/received_events","type":"User","site_admin":false},"repo":{"id":31477695,"name":"mautic","full_name":"alanhartless/mautic","owner":{"login":"alanhartless","id":63312,"avatar_url":"https://avatars.githubusercontent.com/u/63312?v=3","gravatar_id":"","url":"https://api.github.com/users/alanhartless","html_url":"https://github.com/alanhartless","followers_url":"https://api.github.com/users/alanhartless/followers","following_url":"https://api.github.com/users/alanhartless/following{/other_user}","gists_url":"https://api.github.com/users/alanhartless/gists{/gist_id}","starred_url":"https://api.github.com/users/alanhartless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanhartless/subscriptions","organizations_url":"https://api.github.com/users/alanhartless/orgs","repos_url":"https://api.github.com/users/alanhartless/repos","events_url":"https://api.github.com/users/alanhartless/events{/privacy}","received_events_url":"https://api.github.com/users/alanhartless/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alanhartless/mautic","description":"Mautic: Open Source Marketing Automation Software.","fork":true,"url":"https://api.github.com/repos/alanhartless/mautic","forks_url":"https://api.github.com/repos/alanhartless/mautic/forks","keys_url":"https://api.github.com/repos/alanhartless/mautic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alanhartless/mautic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alanhartless/mautic/teams","hooks_url":"https://api.github.com/repos/alanhartless/mautic/hooks","issue_events_url":"https://api.github.com/repos/alanhartless/mautic/issues/events{/number}","events_url":"https://api.github.com/repos/alanhartless/mautic/events","assignees_url":"https://api.github.com/repos/alanhartless/mautic/assignees{/user}","branches_url":"https://api.github.com/repos/alanhartless/mautic/branches{/branch}","tags_url":"https://api.github.com/repos/alanhartless/mautic/tags","blobs_url":"https://api.github.com/repos/alanhartless/mautic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alanhartless/mautic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alanhartless/mautic/git/refs{/sha}","trees_url":"https://api.github.com/repos/alanhartless/mautic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alanhartless/mautic/statuses/{sha}","languages_url":"https://api.github.com/repos/alanhartless/mautic/languages","stargazers_url":"https://api.github.com/repos/alanhartless/mautic/stargazers","contributors_url":"https://api.github.com/repos/alanhartless/mautic/contributors","subscribers_url":"https://api.github.com/repos/alanhartless/mautic/subscribers","subscription_url":"https://api.github.com/repos/alanhartless/mautic/subscription","commits_url":"https://api.github.com/repos/alanhartless/mautic/commits{/sha}","git_commits_url":"https://api.github.com/repos/alanhartless/mautic/git/commits{/sha}","comments_url":"https://api.github.com/repos/alanhartless/mautic/comments{/number}","issue_comment_url":"https://api.github.com/repos/alanhartless/mautic/issues/comments{/number}","contents_url":"https://api.github.com/repos/alanhartless/mautic/contents/{+path}","compare_url":"https://api.github.com/repos/alanhartless/mautic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alanhartless/mautic/merges","archive_url":"https://api.github.com/repos/alanhartless/mautic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alanhartless/mautic/downloads","issues_url":"https://api.github.com/repos/alanhartless/mautic/issues{/number}","pulls_url":"https://api.github.com/repos/alanhartless/mautic/pulls{/number}","milestones_url":"https://api.github.com/repos/alanhartless/mautic/milestones{/number}","notifications_url":"https://api.github.com/repos/alanhartless/mautic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alanhartless/mautic/labels{/name}","releases_url":"https://api.github.com/repos/alanhartless/mautic/releases{/id}","created_at":"2015-02-28T21:38:41Z","updated_at":"2015-07-01T19:20:51Z","pushed_at":"2015-12-25T18:25:23Z","git_url":"git://github.com/alanhartless/mautic.git","ssh_url":"git@github.com:alanhartless/mautic.git","clone_url":"https://github.com/alanhartless/mautic.git","svn_url":"https://github.com/alanhartless/mautic","homepage":"http://mautic.org","size":31963,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mautic:staging","ref":"staging","sha":"edd0980186cd45ea28375aa25cc26fa229ec331a","user":{"login":"mautic","id":5257677,"avatar_url":"https://avatars.githubusercontent.com/u/5257677?v=3","gravatar_id":"","url":"https://api.github.com/users/mautic","html_url":"https://github.com/mautic","followers_url":"https://api.github.com/users/mautic/followers","following_url":"https://api.github.com/users/mautic/following{/other_user}","gists_url":"https://api.github.com/users/mautic/gists{/gist_id}","starred_url":"https://api.github.com/users/mautic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mautic/subscriptions","organizations_url":"https://api.github.com/users/mautic/orgs","repos_url":"https://api.github.com/users/mautic/repos","events_url":"https://api.github.com/users/mautic/events{/privacy}","received_events_url":"https://api.github.com/users/mautic/received_events","type":"Organization","site_admin":false},"repo":{"id":12204147,"name":"mautic","full_name":"mautic/mautic","owner":{"login":"mautic","id":5257677,"avatar_url":"https://avatars.githubusercontent.com/u/5257677?v=3","gravatar_id":"","url":"https://api.github.com/users/mautic","html_url":"https://github.com/mautic","followers_url":"https://api.github.com/users/mautic/followers","following_url":"https://api.github.com/users/mautic/following{/other_user}","gists_url":"https://api.github.com/users/mautic/gists{/gist_id}","starred_url":"https://api.github.com/users/mautic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mautic/subscriptions","organizations_url":"https://api.github.com/users/mautic/orgs","repos_url":"https://api.github.com/users/mautic/repos","events_url":"https://api.github.com/users/mautic/events{/privacy}","received_events_url":"https://api.github.com/users/mautic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mautic/mautic","description":"Mautic: Open Source Marketing Automation Software.","fork":false,"url":"https://api.github.com/repos/mautic/mautic","forks_url":"https://api.github.com/repos/mautic/mautic/forks","keys_url":"https://api.github.com/repos/mautic/mautic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mautic/mautic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mautic/mautic/teams","hooks_url":"https://api.github.com/repos/mautic/mautic/hooks","issue_events_url":"https://api.github.com/repos/mautic/mautic/issues/events{/number}","events_url":"https://api.github.com/repos/mautic/mautic/events","assignees_url":"https://api.github.com/repos/mautic/mautic/assignees{/user}","branches_url":"https://api.github.com/repos/mautic/mautic/branches{/branch}","tags_url":"https://api.github.com/repos/mautic/mautic/tags","blobs_url":"https://api.github.com/repos/mautic/mautic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mautic/mautic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mautic/mautic/git/refs{/sha}","trees_url":"https://api.github.com/repos/mautic/mautic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mautic/mautic/statuses/{sha}","languages_url":"https://api.github.com/repos/mautic/mautic/languages","stargazers_url":"https://api.github.com/repos/mautic/mautic/stargazers","contributors_url":"https://api.github.com/repos/mautic/mautic/contributors","subscribers_url":"https://api.github.com/repos/mautic/mautic/subscribers","subscription_url":"https://api.github.com/repos/mautic/mautic/subscription","commits_url":"https://api.github.com/repos/mautic/mautic/commits{/sha}","git_commits_url":"https://api.github.com/repos/mautic/mautic/git/commits{/sha}","comments_url":"https://api.github.com/repos/mautic/mautic/comments{/number}","issue_comment_url":"https://api.github.com/repos/mautic/mautic/issues/comments{/number}","contents_url":"https://api.github.com/repos/mautic/mautic/contents/{+path}","compare_url":"https://api.github.com/repos/mautic/mautic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mautic/mautic/merges","archive_url":"https://api.github.com/repos/mautic/mautic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mautic/mautic/downloads","issues_url":"https://api.github.com/repos/mautic/mautic/issues{/number}","pulls_url":"https://api.github.com/repos/mautic/mautic/pulls{/number}","milestones_url":"https://api.github.com/repos/mautic/mautic/milestones{/number}","notifications_url":"https://api.github.com/repos/mautic/mautic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mautic/mautic/labels{/name}","releases_url":"https://api.github.com/repos/mautic/mautic/releases{/id}","created_at":"2013-08-19T00:36:28Z","updated_at":"2015-12-25T13:09:11Z","pushed_at":"2015-12-25T18:29:17Z","git_url":"git://github.com/mautic/mautic.git","ssh_url":"git@github.com:mautic/mautic.git","clone_url":"https://github.com/mautic/mautic.git","svn_url":"https://github.com/mautic/mautic","homepage":"https://www.mautic.org","size":32288,"stargazers_count":479,"watchers_count":479,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":166,"mirror_url":null,"open_issues_count":280,"forks":166,"open_issues":280,"watchers":479,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/mautic/mautic/pulls/1283"},"html":{"href":"https://github.com/mautic/mautic/pull/1283"},"issue":{"href":"https://api.github.com/repos/mautic/mautic/issues/1283"},"comments":{"href":"https://api.github.com/repos/mautic/mautic/issues/1283/comments"},"review_comments":{"href":"https://api.github.com/repos/mautic/mautic/pulls/1283/comments"},"review_comment":{"href":"https://api.github.com/repos/mautic/mautic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mautic/mautic/pulls/1283/commits"},"statuses":{"href":"https://api.github.com/repos/mautic/mautic/statuses/9cefb8cff06d9429c05ffff588d9d8583f4f85cc"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":19,"deletions":11,"changed_files":1}}