{"action":"created","issue":{"url":"https://api.github.com/repos/d3athrow/vgstation13/issues/6133","labels_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/6133/labels{/name}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/6133/comments","events_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/6133/events","html_url":"https://github.com/d3athrow/vgstation13/pull/6133","id":111427505,"number":6133,"title":"Gunplay Revamp : All that work for the Nuke Ops Rifle, Shotguns and Hostage Taking","user":{"login":"dylanstrategie","id":6137403,"avatar_url":"https://avatars.githubusercontent.com/u/6137403?v=3","gravatar_id":"","url":"https://api.github.com/users/dylanstrategie","html_url":"https://github.com/dylanstrategie","followers_url":"https://api.github.com/users/dylanstrategie/followers","following_url":"https://api.github.com/users/dylanstrategie/following{/other_user}","gists_url":"https://api.github.com/users/dylanstrategie/gists{/gist_id}","starred_url":"https://api.github.com/users/dylanstrategie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylanstrategie/subscriptions","organizations_url":"https://api.github.com/users/dylanstrategie/orgs","repos_url":"https://api.github.com/users/dylanstrategie/repos","events_url":"https://api.github.com/users/dylanstrategie/events{/privacy}","received_events_url":"https://api.github.com/users/dylanstrategie/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/d3athrow/vgstation13/labels/Controversial","name":"Controversial","color":"fef2c0"},{"url":"https://api.github.com/repos/d3athrow/vgstation13/labels/Feature%20Loss","name":"Feature Loss","color":"c7def8"},{"url":"https://api.github.com/repos/d3athrow/vgstation13/labels/Needs%20Final%20Decision","name":"Needs Final Decision","color":"009800"},{"url":"https://api.github.com/repos/d3athrow/vgstation13/labels/Needs%20Review","name":"Needs Review","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":26,"created_at":"2015-10-14T15:47:45Z","updated_at":"2015-10-18T12:57:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/6133","html_url":"https://github.com/d3athrow/vgstation13/pull/6133","diff_url":"https://github.com/d3athrow/vgstation13/pull/6133.diff","patch_url":"https://github.com/d3athrow/vgstation13/pull/6133.patch"},"body":"This took a while, but that's one big step to making gunplay more interesting for everyone involved\r\n\r\nTechnical changes :\r\n\r\n- <s>\"projectiles\" module is now the \"guns\" module. Because there's literally nothing but guns in here, and all files related to guns are named gun everywhere else, notably in the icons folder.</s> This caused a large amount of dirty edits because Github seems to not understand how renaming works\r\n- Reworked all of targeting.dm. This includes getting completely rid of GunTrace, which caused virtually useless calculations when taking hostages just so you could take people hostage by shooting in their direction. Instead of you know, shooting past them\r\n- Large amount of general code reworks, including getting rid of a few obsolete variables (ejectshell notably)\r\n- Ejecting empty casings was moved from the gun to the actual munition, for obvious reasons. This should also go a long way to allow guns to fire multiple munitions properly\r\n- Fixed constant runtimes were reloading firearms due to a completely unneeded update_inv_l/r_hand() instruction\r\n\r\nGeneral projectile weapons changes : \r\n\r\n- Guns now have far sounds. They behave just like explosions, which means ballistic weapons will be heard across the station. This only applies to projectile weapons, and in those weapons only applies to weapons that actually fire munitions (in reality, it excludes some weapons that shouldn't have far sounds like the portal gun, but that's the general idea)\r\n- All far sounds were made with Audacity from existing sounds. Includes gunshot, smg, c20r, shotgun, rocket, the minigun and the sniper rifle\r\n- Most actions now have visible_messages, from selecting fire-rate to loading magazines\r\n- Added casing-in sound (currently a shotgun casing sound, because I couldn't find a decent regular casing one)\r\n- <s>Clumsy check is now split in two. General clumsy check failure happens 25 % of the time and causes the clumsy person to fall and drop the gun (instead of destroying it). Special clumsy check happens on recoil weapons and knocks the clumsy person out cold for a bit</s> Clumsy check knocks the clumsy person out cold for a bit instead of deleting the gun\r\n- Suicide no longer automatically kills for any damage that isn't 0, and instead applies 5 times the weapon's damage. This means extremely weak rounds will likely only seriously maim you\r\n- Suicide is now manual. You stick your gun in your mouth and give yourself ten seconds to pull the trigger (just fire the weapon normally). If you don't, you stop suiciding, simple as that\r\n- Added a bunch of extra information in examine() across the board\r\n- Recoil inertia changed into a loop\r\n- Blue lasertag guns are no longer logged\r\n- Empty click sound has been changed, and the '*click*' message has been removed\r\n- Messages alerting that the user is firing too quickly have been removed. If the gun doesn't fire and doesn't go click, that means you're shooting a bit too fast (somehow, when default fire_delay is 2 ticks)\r\n- attack_self() now systematically unloads the current gun unless overridden (shotguns still pump notably). It is no longer monopolized by hostage taking\r\n\r\nAutomatic weapons changes : \r\n\r\n- Burst-fire now has a lot more parameters. Delay between bursts and delay between burst shots are two notable ones\r\n- All automatic weapons have burst-fire. Weapons that wouldn't burst-fire in real life would simulate controlled automatic fire (or suppression fire from the L6 SAW, which fires 10 rounds per burst)\r\n- The C20R has been resprited to look a lot more like the FN F2000 it was already based on. Now also includes a visual ammo counter (the red band you see depletes as ammo depletes) : \r\n![c20r](https://cloud.githubusercontent.com/assets/6137403/10488304/62ae6b64-7298-11e5-891a-ba0b4ff28179.png)\r\n- The C20R can have a silencer attached. Make of that as you will\r\n- The L6 SAW now has 120 rounds, up from 50 (planned to be 100, but then the sprite looked like it could have 120, so I just went for that and it worked out swell)\r\n- The Mini-Uzi now is a Micro-Uzi. It's still chambered in .45, but now has 12 rounds instead of 16, fires 4-round bursts and fits in your pocket\r\n- The 'Assault Rifle' is now the <s>XCOM</s> Antique Assault Rifle<s>, doesn't hide that it is a nod to XCOM</s> and fires 4 round bursts twice as slow as regular weapons (to stay true to XCOM, turn-based bursts)\r\n- Added mag-in and mag-out sounds\r\n\r\nAmmunition changes : \r\n\r\n- Added 5.56x45 (also known as NATO rounds). The C-20R rifle now uses those (it is clearly based on the FN F2000, which uses this caliber)\r\n- 5.56x45 magazine added. It has 30 rounds and a black plastic finish\r\n- 5.56x45 ammo box added. It has 100 rounds and visible ammo. 9mm ammo box now also has 100 rounds and the same sprite\r\n- Ammunition cross-loading procs have been double-checked. For a reminder, attacking any ammo storage (target) with another ammo storage (from) will load bullets from > target. Notably, it now has proper delays (one bullet every 0.5 seconds until target is full, failing to fill completely will cause bullet spills)\r\n\r\nThis PR aimed to be much more ambitious, but I think that's already good enough\r\n\r\nPlease tell me if there's any code changes you're spotted that seem odd or aren't mentioned above. This was a pretty large labor even without the dirty edits and I might have missed a few things\r\n\r\nFeedback welcome. Note that I did not add any guns, and outside of the Uzi and L6 SAW (admin/wizard weapons), the C-20R and the XCOM Assault Rifle, I avoided changing any existing ones in gameplay terms"},"comment":{"url":"https://api.github.com/repos/d3athrow/vgstation13/issues/comments/149009125","html_url":"https://github.com/d3athrow/vgstation13/pull/6133#issuecomment-149009125","issue_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/6133","id":149009125,"user":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"created_at":"2015-10-18T12:57:13Z","updated_at":"2015-10-18T12:57:13Z","body":">nato\r\n\r\n>in space"}}