{"action":"created","comment":{"url":"https://api.github.com/repos/bonitasoft/bonita-studio/pulls/comments/33911063","id":33911063,"diff_hunk":"@@ -76,7 +68,8 @@ public void should_buildQueryExpressionModel_return_QueryExpressionModel_from_bo\n         assertThat(model.getBusinessObjects()).hasSize(1);\n         final BusinessObjectExpressionQuery businessObjectExpressionQuery = model.getBusinessObjects().get(0);\n         assertThat(businessObjectExpressionQuery.getQualifiedName()).isEqualTo(\"org.bonita.Employee\");\n-        assertThat(businessObjectExpressionQuery.getQueryExpressions()).hasSize(4);\n+        assertThat(businessObjectExpressionQuery.getQueryExpressions()).extracting(\"name\").contains(\"Employee.find\", \"Employee.findByEmployeeId\",","path":"bundles/plugins/org.bonitasoft.studio.businessobject/src-test/java/org/bonitasoft/studio/businessobject/core/expression/QueryExpressionProviderTest.java","position":27,"original_position":27,"commit_id":"4e932f8894ac1d3a2fffe6fbcb779f631f005661","original_commit_id":"4e932f8894ac1d3a2fffe6fbcb779f631f005661","user":{"login":"apupier","id":1105127,"avatar_url":"https://avatars.githubusercontent.com/u/1105127?v=3","gravatar_id":"","url":"https://api.github.com/users/apupier","html_url":"https://github.com/apupier","followers_url":"https://api.github.com/users/apupier/followers","following_url":"https://api.github.com/users/apupier/following{/other_user}","gists_url":"https://api.github.com/users/apupier/gists{/gist_id}","starred_url":"https://api.github.com/users/apupier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apupier/subscriptions","organizations_url":"https://api.github.com/users/apupier/orgs","repos_url":"https://api.github.com/users/apupier/repos","events_url":"https://api.github.com/users/apupier/events{/privacy}","received_events_url":"https://api.github.com/users/apupier/received_events","type":"User","site_admin":false},"body":"previously, we checked that they are 4 elements but now we are checking for 3 names. Shoudln't we check for 4 (or 5 if I understood well and a new request has been added) also or put the 4( or5) names and use a containsExactly?","created_at":"2015-07-06T07:32:13Z","updated_at":"2015-07-06T07:32:13Z","html_url":"https://github.com/bonitasoft/bonita-studio/pull/213#discussion_r33911063","pull_request_url":"https://api.github.com/repos/bonitasoft/bonita-studio/pulls/213","_links":{"self":{"href":"https://api.github.com/repos/bonitasoft/bonita-studio/pulls/comments/33911063"},"html":{"href":"https://github.com/bonitasoft/bonita-studio/pull/213#discussion_r33911063"},"pull_request":{"href":"https://api.github.com/repos/bonitasoft/bonita-studio/pulls/213"}}},"pull_request":{"url":"https://api.github.com/repos/bonitasoft/bonita-studio/pulls/213","id":38884221,"html_url":"https://github.com/bonitasoft/bonita-studio/pull/213","diff_url":"https://github.com/bonitasoft/bonita-studio/pull/213.diff","patch_url":"https://github.com/bonitasoft/bonita-studio/pull/213.patch","issue_url":"https://api.github.com/repos/bonitasoft/bonita-studio/issues/213","number":213,"state":"open","locked":false,"title":"BS-13819 Support aggregated fields","user":{"login":"rbioteau","id":1768761,"avatar_url":"https://avatars.githubusercontent.com/u/1768761?v=3","gravatar_id":"","url":"https://api.github.com/users/rbioteau","html_url":"https://github.com/rbioteau","followers_url":"https://api.github.com/users/rbioteau/followers","following_url":"https://api.github.com/users/rbioteau/following{/other_user}","gists_url":"https://api.github.com/users/rbioteau/gists{/gist_id}","starred_url":"https://api.github.com/users/rbioteau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbioteau/subscriptions","organizations_url":"https://api.github.com/users/rbioteau/orgs","repos_url":"https://api.github.com/users/rbioteau/repos","events_url":"https://api.github.com/users/rbioteau/events{/privacy}","received_events_url":"https://api.github.com/users/rbioteau/received_events","type":"User","site_admin":false},"body":"* Handle aggregated relation field using findByPersistenceId query\r\n* Compute script dependencies","created_at":"2015-06-30T14:32:19Z","updated_at":"2015-07-06T07:32:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d848e8958a4ac85d275f0eaf5190710e725d73f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bonitasoft/bonita-studio/pulls/213/commits","review_comments_url":"https://api.github.com/repos/bonitasoft/bonita-studio/pulls/213/comments","review_comment_url":"https://api.github.com/repos/bonitasoft/bonita-studio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bonitasoft/bonita-studio/issues/213/comments","statuses_url":"https://api.github.com/repos/bonitasoft/bonita-studio/statuses/4e932f8894ac1d3a2fffe6fbcb779f631f005661","head":{"label":"bonitasoft:feat/BS-13819_handle_aggregation_fields","ref":"feat/BS-13819_handle_aggregation_fields","sha":"4e932f8894ac1d3a2fffe6fbcb779f631f005661","user":{"login":"bonitasoft","id":4619712,"avatar_url":"https://avatars.githubusercontent.com/u/4619712?v=3","gravatar_id":"","url":"https://api.github.com/users/bonitasoft","html_url":"https://github.com/bonitasoft","followers_url":"https://api.github.com/users/bonitasoft/followers","following_url":"https://api.github.com/users/bonitasoft/following{/other_user}","gists_url":"https://api.github.com/users/bonitasoft/gists{/gist_id}","starred_url":"https://api.github.com/users/bonitasoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonitasoft/subscriptions","organizations_url":"https://api.github.com/users/bonitasoft/orgs","repos_url":"https://api.github.com/users/bonitasoft/repos","events_url":"https://api.github.com/users/bonitasoft/events{/privacy}","received_events_url":"https://api.github.com/users/bonitasoft/received_events","type":"Organization","site_admin":false},"repo":{"id":11363784,"name":"bonita-studio","full_name":"bonitasoft/bonita-studio","owner":{"login":"bonitasoft","id":4619712,"avatar_url":"https://avatars.githubusercontent.com/u/4619712?v=3","gravatar_id":"","url":"https://api.github.com/users/bonitasoft","html_url":"https://github.com/bonitasoft","followers_url":"https://api.github.com/users/bonitasoft/followers","following_url":"https://api.github.com/users/bonitasoft/following{/other_user}","gists_url":"https://api.github.com/users/bonitasoft/gists{/gist_id}","starred_url":"https://api.github.com/users/bonitasoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonitasoft/subscriptions","organizations_url":"https://api.github.com/users/bonitasoft/orgs","repos_url":"https://api.github.com/users/bonitasoft/repos","events_url":"https://api.github.com/users/bonitasoft/events{/privacy}","received_events_url":"https://api.github.com/users/bonitasoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bonitasoft/bonita-studio","description":"","fork":false,"url":"https://api.github.com/repos/bonitasoft/bonita-studio","forks_url":"https://api.github.com/repos/bonitasoft/bonita-studio/forks","keys_url":"https://api.github.com/repos/bonitasoft/bonita-studio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bonitasoft/bonita-studio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bonitasoft/bonita-studio/teams","hooks_url":"https://api.github.com/repos/bonitasoft/bonita-studio/hooks","issue_events_url":"https://api.github.com/repos/bonitasoft/bonita-studio/issues/events{/number}","events_url":"https://api.github.com/repos/bonitasoft/bonita-studio/events","assignees_url":"https://api.github.com/repos/bonitasoft/bonita-studio/assignees{/user}","branches_url":"https://api.github.com/repos/bonitasoft/bonita-studio/branches{/branch}","tags_url":"https://api.github.com/repos/bonitasoft/bonita-studio/tags","blobs_url":"https://api.github.com/repos/bonitasoft/bonita-studio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bonitasoft/bonita-studio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bonitasoft/bonita-studio/git/refs{/sha}","trees_url":"https://api.github.com/repos/bonitasoft/bonita-studio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bonitasoft/bonita-studio/statuses/{sha}","languages_url":"https://api.github.com/repos/bonitasoft/bonita-studio/languages","stargazers_url":"https://api.github.com/repos/bonitasoft/bonita-studio/stargazers","contributors_url":"https://api.github.com/repos/bonitasoft/bonita-studio/contributors","subscribers_url":"https://api.github.com/repos/bonitasoft/bonita-studio/subscribers","subscription_url":"https://api.github.com/repos/bonitasoft/bonita-studio/subscription","commits_url":"https://api.github.com/repos/bonitasoft/bonita-studio/commits{/sha}","git_commits_url":"https://api.github.com/repos/bonitasoft/bonita-studio/git/commits{/sha}","comments_url":"https://api.github.com/repos/bonitasoft/bonita-studio/comments{/number}","issue_comment_url":"https://api.github.com/repos/bonitasoft/bonita-studio/issues/comments{/number}","contents_url":"https://api.github.com/repos/bonitasoft/bonita-studio/contents/{+path}","compare_url":"https://api.github.com/repos/bonitasoft/bonita-studio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bonitasoft/bonita-studio/merges","archive_url":"https://api.github.com/repos/bonitasoft/bonita-studio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bonitasoft/bonita-studio/downloads","issues_url":"https://api.github.com/repos/bonitasoft/bonita-studio/issues{/number}","pulls_url":"https://api.github.com/repos/bonitasoft/bonita-studio/pulls{/number}","milestones_url":"https://api.github.com/repos/bonitasoft/bonita-studio/milestones{/number}","notifications_url":"https://api.github.com/repos/bonitasoft/bonita-studio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bonitasoft/bonita-studio/labels{/name}","releases_url":"https://api.github.com/repos/bonitasoft/bonita-studio/releases{/id}","created_at":"2013-07-12T08:06:21Z","updated_at":"2015-05-07T16:37:44Z","pushed_at":"2015-07-06T07:30:47Z","git_url":"git://github.com/bonitasoft/bonita-studio.git","ssh_url":"git@github.com:bonitasoft/bonita-studio.git","clone_url":"https://github.com/bonitasoft/bonita-studio.git","svn_url":"https://github.com/bonitasoft/bonita-studio","homepage":"http://community.bonitasoft.com/","size":698790,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":2,"forks":21,"open_issues":2,"watchers":17,"default_branch":"master"}},"base":{"label":"bonitasoft:CP_7.1.0_Sprint_2_Studio","ref":"CP_7.1.0_Sprint_2_Studio","sha":"e4bf28c8f237ba892c37ee4ea5a105a63855a791","user":{"login":"bonitasoft","id":4619712,"avatar_url":"https://avatars.githubusercontent.com/u/4619712?v=3","gravatar_id":"","url":"https://api.github.com/users/bonitasoft","html_url":"https://github.com/bonitasoft","followers_url":"https://api.github.com/users/bonitasoft/followers","following_url":"https://api.github.com/users/bonitasoft/following{/other_user}","gists_url":"https://api.github.com/users/bonitasoft/gists{/gist_id}","starred_url":"https://api.github.com/users/bonitasoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonitasoft/subscriptions","organizations_url":"https://api.github.com/users/bonitasoft/orgs","repos_url":"https://api.github.com/users/bonitasoft/repos","events_url":"https://api.github.com/users/bonitasoft/events{/privacy}","received_events_url":"https://api.github.com/users/bonitasoft/received_events","type":"Organization","site_admin":false},"repo":{"id":11363784,"name":"bonita-studio","full_name":"bonitasoft/bonita-studio","owner":{"login":"bonitasoft","id":4619712,"avatar_url":"https://avatars.githubusercontent.com/u/4619712?v=3","gravatar_id":"","url":"https://api.github.com/users/bonitasoft","html_url":"https://github.com/bonitasoft","followers_url":"https://api.github.com/users/bonitasoft/followers","following_url":"https://api.github.com/users/bonitasoft/following{/other_user}","gists_url":"https://api.github.com/users/bonitasoft/gists{/gist_id}","starred_url":"https://api.github.com/users/bonitasoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bonitasoft/subscriptions","organizations_url":"https://api.github.com/users/bonitasoft/orgs","repos_url":"https://api.github.com/users/bonitasoft/repos","events_url":"https://api.github.com/users/bonitasoft/events{/privacy}","received_events_url":"https://api.github.com/users/bonitasoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bonitasoft/bonita-studio","description":"","fork":false,"url":"https://api.github.com/repos/bonitasoft/bonita-studio","forks_url":"https://api.github.com/repos/bonitasoft/bonita-studio/forks","keys_url":"https://api.github.com/repos/bonitasoft/bonita-studio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bonitasoft/bonita-studio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bonitasoft/bonita-studio/teams","hooks_url":"https://api.github.com/repos/bonitasoft/bonita-studio/hooks","issue_events_url":"https://api.github.com/repos/bonitasoft/bonita-studio/issues/events{/number}","events_url":"https://api.github.com/repos/bonitasoft/bonita-studio/events","assignees_url":"https://api.github.com/repos/bonitasoft/bonita-studio/assignees{/user}","branches_url":"https://api.github.com/repos/bonitasoft/bonita-studio/branches{/branch}","tags_url":"https://api.github.com/repos/bonitasoft/bonita-studio/tags","blobs_url":"https://api.github.com/repos/bonitasoft/bonita-studio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bonitasoft/bonita-studio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bonitasoft/bonita-studio/git/refs{/sha}","trees_url":"https://api.github.com/repos/bonitasoft/bonita-studio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bonitasoft/bonita-studio/statuses/{sha}","languages_url":"https://api.github.com/repos/bonitasoft/bonita-studio/languages","stargazers_url":"https://api.github.com/repos/bonitasoft/bonita-studio/stargazers","contributors_url":"https://api.github.com/repos/bonitasoft/bonita-studio/contributors","subscribers_url":"https://api.github.com/repos/bonitasoft/bonita-studio/subscribers","subscription_url":"https://api.github.com/repos/bonitasoft/bonita-studio/subscription","commits_url":"https://api.github.com/repos/bonitasoft/bonita-studio/commits{/sha}","git_commits_url":"https://api.github.com/repos/bonitasoft/bonita-studio/git/commits{/sha}","comments_url":"https://api.github.com/repos/bonitasoft/bonita-studio/comments{/number}","issue_comment_url":"https://api.github.com/repos/bonitasoft/bonita-studio/issues/comments{/number}","contents_url":"https://api.github.com/repos/bonitasoft/bonita-studio/contents/{+path}","compare_url":"https://api.github.com/repos/bonitasoft/bonita-studio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bonitasoft/bonita-studio/merges","archive_url":"https://api.github.com/repos/bonitasoft/bonita-studio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bonitasoft/bonita-studio/downloads","issues_url":"https://api.github.com/repos/bonitasoft/bonita-studio/issues{/number}","pulls_url":"https://api.github.com/repos/bonitasoft/bonita-studio/pulls{/number}","milestones_url":"https://api.github.com/repos/bonitasoft/bonita-studio/milestones{/number}","notifications_url":"https://api.github.com/repos/bonitasoft/bonita-studio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bonitasoft/bonita-studio/labels{/name}","releases_url":"https://api.github.com/repos/bonitasoft/bonita-studio/releases{/id}","created_at":"2013-07-12T08:06:21Z","updated_at":"2015-05-07T16:37:44Z","pushed_at":"2015-07-06T07:30:47Z","git_url":"git://github.com/bonitasoft/bonita-studio.git","ssh_url":"git@github.com:bonitasoft/bonita-studio.git","clone_url":"https://github.com/bonitasoft/bonita-studio.git","svn_url":"https://github.com/bonitasoft/bonita-studio","homepage":"http://community.bonitasoft.com/","size":698790,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":2,"forks":21,"open_issues":2,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bonitasoft/bonita-studio/pulls/213"},"html":{"href":"https://github.com/bonitasoft/bonita-studio/pull/213"},"issue":{"href":"https://api.github.com/repos/bonitasoft/bonita-studio/issues/213"},"comments":{"href":"https://api.github.com/repos/bonitasoft/bonita-studio/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/bonitasoft/bonita-studio/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/bonitasoft/bonita-studio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bonitasoft/bonita-studio/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/bonitasoft/bonita-studio/statuses/4e932f8894ac1d3a2fffe6fbcb779f631f005661"}}}}