{"action":"created","issue":{"url":"https://api.github.com/repos/Metaswitch/freeDiameter/issues/21","labels_url":"https://api.github.com/repos/Metaswitch/freeDiameter/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/Metaswitch/freeDiameter/issues/21/comments","events_url":"https://api.github.com/repos/Metaswitch/freeDiameter/issues/21/events","html_url":"https://github.com/Metaswitch/freeDiameter/issues/21","id":78931409,"number":21,"title":"freeDiameter generates error logs when there are no session IDs on messages that don't require session IDs","user":{"login":"graemerobertson","id":5907876,"avatar_url":"https://avatars.githubusercontent.com/u/5907876?v=3","gravatar_id":"","url":"https://api.github.com/users/graemerobertson","html_url":"https://github.com/graemerobertson","followers_url":"https://api.github.com/users/graemerobertson/followers","following_url":"https://api.github.com/users/graemerobertson/following{/other_user}","gists_url":"https://api.github.com/users/graemerobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/graemerobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graemerobertson/subscriptions","organizations_url":"https://api.github.com/users/graemerobertson/orgs","repos_url":"https://api.github.com/users/graemerobertson/repos","events_url":"https://api.github.com/users/graemerobertson/events{/privacy}","received_events_url":"https://api.github.com/users/graemerobertson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-21T10:25:27Z","updated_at":"2015-06-05T10:18:05Z","closed_at":null,"body":"I've got freeDiameter running as a client and I'm seeing regular logs that look like\r\n\r\n```\r\n21-05-2015 10:19:40.950 UTC Debug diameterstack.cpp:781: Processing a sent diameter message\r\n21-05-2015 10:19:40.950 UTC Debug diameterstack.cpp:783: Got existing trail ID: 0\r\n21-05-2015 10:19:40.950 UTC Debug freeDiameter: No Session-Id AVP found in message 0x7fa1d0016d70\r\n21-05-2015 10:19:40.950 UTC Error freeDiameter: ERROR: Invalid parameter '(( ((session) != ((void *)0)) && ( ((struct session *)(session))->eyec == 0x53551D) ) && sid)', 22\r\n21-05-2015 10:19:40.950 UTC Debug freeDiameter: Sending 104b data on connection {----} TCP from [10.225.20.196]:35336 (11<-2007)\r\n```\r\n\r\nThey seem to correlate with things like responding to Device-Watchdog-Requests and Capabilities-Exchange-Requests (which don't have session IDs).\r\n\r\nThere doesn't seem to be any impact on behaviour - the error log is just annoying and misleading (and wrong).\r\n\r\nShould be easy to repro since the log seems to be generated on trying to send any DWA or CEA. Next step is probably to work out the code path in freeDiameter that leads to this log being generated (by adding more logs or by running with gdb)."},"comment":{"url":"https://api.github.com/repos/Metaswitch/freeDiameter/issues/comments/109250735","html_url":"https://github.com/Metaswitch/freeDiameter/issues/21#issuecomment-109250735","issue_url":"https://api.github.com/repos/Metaswitch/freeDiameter/issues/21","id":109250735,"user":{"login":"graemerobertson","id":5907876,"avatar_url":"https://avatars.githubusercontent.com/u/5907876?v=3","gravatar_id":"","url":"https://api.github.com/users/graemerobertson","html_url":"https://github.com/graemerobertson","followers_url":"https://api.github.com/users/graemerobertson/followers","following_url":"https://api.github.com/users/graemerobertson/following{/other_user}","gists_url":"https://api.github.com/users/graemerobertson/gists{/gist_id}","starred_url":"https://api.github.com/users/graemerobertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graemerobertson/subscriptions","organizations_url":"https://api.github.com/users/graemerobertson/orgs","repos_url":"https://api.github.com/users/graemerobertson/repos","events_url":"https://api.github.com/users/graemerobertson/events{/privacy}","received_events_url":"https://api.github.com/users/graemerobertson/received_events","type":"User","site_admin":false},"created_at":"2015-06-05T10:18:05Z","updated_at":"2015-06-05T10:18:05Z","body":"I've also seen this log being generated in Ralf, and it seems to be generated very reliably on a DWR/DWA exchange. I am surprised I've never noticed it before though...\r\n\r\n```\r\n05-06-2015 10:16:49.892 UTC Debug diameterstack.cpp:761: Processing a received diameter message\r\n05-06-2015 10:16:49.892 UTC Debug diameterstack.cpp:767: Allocated new trail ID: 51\r\n05-06-2015 10:16:49.892 UTC Debug freeDiameter: No Session-Id AVP found in message 0x7fe784007be0\r\n05-06-2015 10:16:49.892 UTC Error freeDiameter: ERROR: Invalid parameter '(( ((session) != ((void *)0)) && ( ((struct session *)(session))->eyec == 0x53551D) ) && sid)', 22\r\n05-06-2015 10:16:49.892 UTC Debug freeDiameter: Iterating on rules of COMMAND: 'Device-Watchdog-Request'.\r\n05-06-2015 10:16:49.892 UTC Debug freeDiameter: No Session-Id AVP found in message 0x7fe784007be0\r\n05-06-2015 10:16:49.892 UTC Debug freeDiameter: Peer timeout reset to 30 seconds (+/- 2)\r\n05-06-2015 10:16:49.892 UTC Debug freeDiameter: '10.225.20.202' in state 'STATE_OPEN' waiting for next event.\r\n05-06-2015 10:16:49.892 UTC Debug diameterstack.cpp:781: Processing a sent diameter message\r\n05-06-2015 10:16:49.892 UTC Debug diameterstack.cpp:783: Got existing trail ID: 0\r\n05-06-2015 10:16:49.892 UTC Debug freeDiameter: No Session-Id AVP found in message 0x7fe78402b040\r\n05-06-2015 10:16:49.892 UTC Error freeDiameter: ERROR: Invalid parameter '(( ((session) != ((void *)0)) && ( ((struct session *)(session))->eyec == 0x53551D) ) && sid)', 22\r\n05-06-2015 10:16:49.892 UTC Debug freeDiameter: Sending 132b data on connection {----} TCP,#328->10.225.20.202(3868)\r\n```"}}