{"action":"created","issue":{"url":"https://api.github.com/repos/pyca/cryptography/issues/1829","labels_url":"https://api.github.com/repos/pyca/cryptography/issues/1829/labels{/name}","comments_url":"https://api.github.com/repos/pyca/cryptography/issues/1829/comments","events_url":"https://api.github.com/repos/pyca/cryptography/issues/1829/events","html_url":"https://github.com/pyca/cryptography/pull/1829","id":67252779,"number":1829,"title":"PKCS7 signature, encryption and serialization bindings.","user":{"login":"mahmoud","id":130193,"avatar_url":"https://avatars.githubusercontent.com/u/130193?v=3","gravatar_id":"","url":"https://api.github.com/users/mahmoud","html_url":"https://github.com/mahmoud","followers_url":"https://api.github.com/users/mahmoud/followers","following_url":"https://api.github.com/users/mahmoud/following{/other_user}","gists_url":"https://api.github.com/users/mahmoud/gists{/gist_id}","starred_url":"https://api.github.com/users/mahmoud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahmoud/subscriptions","organizations_url":"https://api.github.com/users/mahmoud/orgs","repos_url":"https://api.github.com/users/mahmoud/repos","events_url":"https://api.github.com/users/mahmoud/events{/privacy}","received_events_url":"https://api.github.com/users/mahmoud/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-09T00:47:06Z","updated_at":"2015-04-09T00:48:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pyca/cryptography/pulls/1829","html_url":"https://github.com/pyca/cryptography/pull/1829","diff_url":"https://github.com/pyca/cryptography/pull/1829.diff","patch_url":"https://github.com/pyca/cryptography/pull/1829.patch"},"body":"The first of hopefully several pull requests in reference to #1828 (Adding and enhancing PKCS7 support). This one just adds all the PKCS7 bindings from OpenSSL that were sufficiently documented and seemed to be somewhat commonly used. These cover our use cases at eBay/PayPal, and we believe they'll be sufficient for the SMIME support mentioned in #1621.\r\n\r\nWe did not include bindings for OpenSSL's multiple signature support, such as `PKCS7_add_signer()` and `PKCS7_final()`. The documentation is virtually non existent; in many cases there isn't even anywhere appropriate to link to outside of the OpenSSL code itself. None of the API-level additions we have planned for future PyOpenSSL/cryptography pull requests depend on them, either.\r\n\r\nThese test fine on our systems, though I'm not sure our tests go as far back as the version of 0.9.8 used by Travis. There is one conditional include, for PKCS7_NOSMIMECAP, even though it's present in all our builds.\r\n\r\nLet us (@mahmoud/@mwilliams3) know if there are any questions!"},"comment":{"url":"https://api.github.com/repos/pyca/cryptography/issues/comments/91080077","html_url":"https://github.com/pyca/cryptography/pull/1829#issuecomment-91080077","issue_url":"https://api.github.com/repos/pyca/cryptography/issues/1829","id":91080077,"user":{"login":"alex","id":772,"avatar_url":"https://avatars.githubusercontent.com/u/772?v=3","gravatar_id":"","url":"https://api.github.com/users/alex","html_url":"https://github.com/alex","followers_url":"https://api.github.com/users/alex/followers","following_url":"https://api.github.com/users/alex/following{/other_user}","gists_url":"https://api.github.com/users/alex/gists{/gist_id}","starred_url":"https://api.github.com/users/alex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex/subscriptions","organizations_url":"https://api.github.com/users/alex/orgs","repos_url":"https://api.github.com/users/alex/repos","events_url":"https://api.github.com/users/alex/events{/privacy}","received_events_url":"https://api.github.com/users/alex/received_events","type":"User","site_admin":false},"created_at":"2015-04-09T00:48:50Z","updated_at":"2015-04-09T00:48:50Z","body":"ok to test"}}