{"action":"created","issue":{"url":"https://api.github.com/repos/logstash-plugins/logstash-output-mongodb/issues/19","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-output-mongodb/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-output-mongodb/issues/19/comments","events_url":"https://api.github.com/repos/logstash-plugins/logstash-output-mongodb/issues/19/events","html_url":"https://github.com/logstash-plugins/logstash-output-mongodb/pull/19","id":121060905,"number":19,"title":"Add to_bson methods where missing. New tests and improve current tests.","user":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"milestone":null,"comments":9,"created_at":"2015-12-08T17:45:51Z","updated_at":"2015-12-09T10:37:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-output-mongodb/pulls/19","html_url":"https://github.com/logstash-plugins/logstash-output-mongodb/pull/19","diff_url":"https://github.com/logstash-plugins/logstash-output-mongodb/pull/19.diff","patch_url":"https://github.com/logstash-plugins/logstash-output-mongodb/pull/19.patch"},"body":"NOTES TO REVIEWERS:\r\n- This gives our Event, Timestamp class and BigDecimal proper bson support like the BSON ruby library does.\r\n- There are tests for the bson support.\r\n- We are not currently using the Event bson support at the moment because we mutate the hash before giving it to Mongo\r\n- Improved the `receive(event)` method a bit.\r\n- Minor improvement to the mongo unit test\r\n- major improvement to the the integration test. Used a uuid to search for the document in Mongo because the timestamp may be an ISODate object and not a String. Added a few other objects incl. BigDecimal to the Event content to better test integration.  Although the test does not check the contents of what it reads back from Mongo, I did it manually in the mongo console.\r\n- I have a question: why do we omit the metadata from the document sent to Mongo?\r\n\r\nFrom Mongo console\r\n```\r\nMongoDB shell version: 3.0.7\r\nconnecting to: test\r\nServer has startup warnings:\r\n2015-12-08T12:34:11.589+0000 I CONTROL  [initandlisten]\r\n2015-12-08T12:34:11.589+0000 I CONTROL  [initandlisten] ** WARNING: soft rlimits too low. Number\r\n  of files is 256, should be at least 1000\r\n> use logstash\r\n> db.logs.find()\r\n{ \"_id\" : ObjectId(\"56671628146fbfeff9000001\"), \"message\" : \"This is a message!\",\r\n\"uuid\" : \"3777a8f0-99a5-4df6-8772-d3e9392fd374\", \"number\" : 4321.1234,\r\n\"utf8\" : \"żółć\", \"int\" : 42, \"arry\" : [ 42, \"string\", 4321.1234 ],\r\n\"@version\" : \"1\", \"@timestamp\" : ISODate(\"2015-12-08T17:40:56.932Z\") }\r\n```"},"comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-output-mongodb/issues/comments/163183933","html_url":"https://github.com/logstash-plugins/logstash-output-mongodb/pull/19#issuecomment-163183933","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-output-mongodb/issues/19","id":163183933,"user":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"created_at":"2015-12-09T10:37:58Z","updated_at":"2015-12-09T10:37:58Z","body":"The failing test is timezone related.  I will add `.utc` in the spec."}}