{"action":"created","comment":{"url":"https://api.github.com/repos/nla/amberdb/pulls/comments/37269746","id":37269746,"diff_hunk":"@@ -0,0 +1,41 @@\n+package amberdb.model.builder;\n+\n+import com.google.common.base.Joiner;\n+\n+import java.util.HashSet;\n+import java.util.Iterator;\n+import java.util.List;\n+import java.util.Set;\n+\n+public class EADDuplicateValidator {\n+\n+    public EADDuplicateValidator(XmlDocumentParser parser) {\n+        this.parser = parser;\n+    }\n+\n+    private XmlDocumentParser parser;\n+\n+    public void validate() {","path":"src/amberdb/model/builder/EADDuplicateValidator.java","position":18,"original_position":18,"commit_id":"982e1c212543eba298357bb0475d72357b5ea669","original_commit_id":"982e1c212543eba298357bb0475d72357b5ea669","user":{"login":"AaronCMuller","id":8285023,"avatar_url":"https://avatars.githubusercontent.com/u/8285023?v=3","gravatar_id":"","url":"https://api.github.com/users/AaronCMuller","html_url":"https://github.com/AaronCMuller","followers_url":"https://api.github.com/users/AaronCMuller/followers","following_url":"https://api.github.com/users/AaronCMuller/following{/other_user}","gists_url":"https://api.github.com/users/AaronCMuller/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronCMuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronCMuller/subscriptions","organizations_url":"https://api.github.com/users/AaronCMuller/orgs","repos_url":"https://api.github.com/users/AaronCMuller/repos","events_url":"https://api.github.com/users/AaronCMuller/events{/privacy}","received_events_url":"https://api.github.com/users/AaronCMuller/received_events","type":"User","site_admin":false},"body":"No throws declaration or javadoc? Without this, how are you supposed to know what this actually does without looking at the code.","created_at":"2015-08-18T07:08:53Z","updated_at":"2015-08-18T07:08:53Z","html_url":"https://github.com/nla/amberdb/pull/384#discussion_r37269746","pull_request_url":"https://api.github.com/repos/nla/amberdb/pulls/384","_links":{"self":{"href":"https://api.github.com/repos/nla/amberdb/pulls/comments/37269746"},"html":{"href":"https://github.com/nla/amberdb/pull/384#discussion_r37269746"},"pull_request":{"href":"https://api.github.com/repos/nla/amberdb/pulls/384"}}},"pull_request":{"url":"https://api.github.com/repos/nla/amberdb/pulls/384","id":42666371,"html_url":"https://github.com/nla/amberdb/pull/384","diff_url":"https://github.com/nla/amberdb/pull/384.diff","patch_url":"https://github.com/nla/amberdb/pull/384.patch","issue_url":"https://api.github.com/repos/nla/amberdb/issues/384","number":384,"state":"open","locked":false,"title":"DSCS-269 Improve error handling on EAD uploads","user":{"login":"danielbaker","id":921913,"avatar_url":"https://avatars.githubusercontent.com/u/921913?v=3","gravatar_id":"","url":"https://api.github.com/users/danielbaker","html_url":"https://github.com/danielbaker","followers_url":"https://api.github.com/users/danielbaker/followers","following_url":"https://api.github.com/users/danielbaker/following{/other_user}","gists_url":"https://api.github.com/users/danielbaker/gists{/gist_id}","starred_url":"https://api.github.com/users/danielbaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielbaker/subscriptions","organizations_url":"https://api.github.com/users/danielbaker/orgs","repos_url":"https://api.github.com/users/danielbaker/repos","events_url":"https://api.github.com/users/danielbaker/events{/privacy}","received_events_url":"https://api.github.com/users/danielbaker/received_events","type":"User","site_admin":false},"body":"@JonathanShaw @AaronCMuller @MingtaoSun \r\n\r\nImproved error handling on EAD uploads\r\n - fixed several error messages which didnt work\r\n - Added UUID to some error messages\r\n - Fixed an issue where bad UTF-8 Chars broke the xml parsing","created_at":"2015-08-18T06:49:46Z","updated_at":"2015-08-18T07:08:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77e30a300e6e695fec623e9f89fa1c28eb340899","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nla/amberdb/pulls/384/commits","review_comments_url":"https://api.github.com/repos/nla/amberdb/pulls/384/comments","review_comment_url":"https://api.github.com/repos/nla/amberdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nla/amberdb/issues/384/comments","statuses_url":"https://api.github.com/repos/nla/amberdb/statuses/982e1c212543eba298357bb0475d72357b5ea669","head":{"label":"nla:DSCS-269","ref":"DSCS-269","sha":"982e1c212543eba298357bb0475d72357b5ea669","user":{"login":"nla","id":425006,"avatar_url":"https://avatars.githubusercontent.com/u/425006?v=3","gravatar_id":"","url":"https://api.github.com/users/nla","html_url":"https://github.com/nla","followers_url":"https://api.github.com/users/nla/followers","following_url":"https://api.github.com/users/nla/following{/other_user}","gists_url":"https://api.github.com/users/nla/gists{/gist_id}","starred_url":"https://api.github.com/users/nla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nla/subscriptions","organizations_url":"https://api.github.com/users/nla/orgs","repos_url":"https://api.github.com/users/nla/repos","events_url":"https://api.github.com/users/nla/events{/privacy}","received_events_url":"https://api.github.com/users/nla/received_events","type":"Organization","site_admin":false},"repo":{"id":12777979,"name":"amberdb","full_name":"nla/amberdb","owner":{"login":"nla","id":425006,"avatar_url":"https://avatars.githubusercontent.com/u/425006?v=3","gravatar_id":"","url":"https://api.github.com/users/nla","html_url":"https://github.com/nla","followers_url":"https://api.github.com/users/nla/followers","following_url":"https://api.github.com/users/nla/following{/other_user}","gists_url":"https://api.github.com/users/nla/gists{/gist_id}","starred_url":"https://api.github.com/users/nla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nla/subscriptions","organizations_url":"https://api.github.com/users/nla/orgs","repos_url":"https://api.github.com/users/nla/repos","events_url":"https://api.github.com/users/nla/events{/privacy}","received_events_url":"https://api.github.com/users/nla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nla/amberdb","description":"A digital library domain model","fork":false,"url":"https://api.github.com/repos/nla/amberdb","forks_url":"https://api.github.com/repos/nla/amberdb/forks","keys_url":"https://api.github.com/repos/nla/amberdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nla/amberdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nla/amberdb/teams","hooks_url":"https://api.github.com/repos/nla/amberdb/hooks","issue_events_url":"https://api.github.com/repos/nla/amberdb/issues/events{/number}","events_url":"https://api.github.com/repos/nla/amberdb/events","assignees_url":"https://api.github.com/repos/nla/amberdb/assignees{/user}","branches_url":"https://api.github.com/repos/nla/amberdb/branches{/branch}","tags_url":"https://api.github.com/repos/nla/amberdb/tags","blobs_url":"https://api.github.com/repos/nla/amberdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nla/amberdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nla/amberdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/nla/amberdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nla/amberdb/statuses/{sha}","languages_url":"https://api.github.com/repos/nla/amberdb/languages","stargazers_url":"https://api.github.com/repos/nla/amberdb/stargazers","contributors_url":"https://api.github.com/repos/nla/amberdb/contributors","subscribers_url":"https://api.github.com/repos/nla/amberdb/subscribers","subscription_url":"https://api.github.com/repos/nla/amberdb/subscription","commits_url":"https://api.github.com/repos/nla/amberdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/nla/amberdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/nla/amberdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/nla/amberdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/nla/amberdb/contents/{+path}","compare_url":"https://api.github.com/repos/nla/amberdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nla/amberdb/merges","archive_url":"https://api.github.com/repos/nla/amberdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nla/amberdb/downloads","issues_url":"https://api.github.com/repos/nla/amberdb/issues{/number}","pulls_url":"https://api.github.com/repos/nla/amberdb/pulls{/number}","milestones_url":"https://api.github.com/repos/nla/amberdb/milestones{/number}","notifications_url":"https://api.github.com/repos/nla/amberdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nla/amberdb/labels{/name}","releases_url":"https://api.github.com/repos/nla/amberdb/releases{/id}","created_at":"2013-09-12T07:45:06Z","updated_at":"2015-07-23T02:31:25Z","pushed_at":"2015-08-18T06:49:46Z","git_url":"git://github.com/nla/amberdb.git","ssh_url":"git@github.com:nla/amberdb.git","clone_url":"https://github.com/nla/amberdb.git","svn_url":"https://github.com/nla/amberdb","homepage":"","size":5732,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":1,"default_branch":"master"}},"base":{"label":"nla:master","ref":"master","sha":"77447d49ff6d888fb596fd84126b788e6aaed625","user":{"login":"nla","id":425006,"avatar_url":"https://avatars.githubusercontent.com/u/425006?v=3","gravatar_id":"","url":"https://api.github.com/users/nla","html_url":"https://github.com/nla","followers_url":"https://api.github.com/users/nla/followers","following_url":"https://api.github.com/users/nla/following{/other_user}","gists_url":"https://api.github.com/users/nla/gists{/gist_id}","starred_url":"https://api.github.com/users/nla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nla/subscriptions","organizations_url":"https://api.github.com/users/nla/orgs","repos_url":"https://api.github.com/users/nla/repos","events_url":"https://api.github.com/users/nla/events{/privacy}","received_events_url":"https://api.github.com/users/nla/received_events","type":"Organization","site_admin":false},"repo":{"id":12777979,"name":"amberdb","full_name":"nla/amberdb","owner":{"login":"nla","id":425006,"avatar_url":"https://avatars.githubusercontent.com/u/425006?v=3","gravatar_id":"","url":"https://api.github.com/users/nla","html_url":"https://github.com/nla","followers_url":"https://api.github.com/users/nla/followers","following_url":"https://api.github.com/users/nla/following{/other_user}","gists_url":"https://api.github.com/users/nla/gists{/gist_id}","starred_url":"https://api.github.com/users/nla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nla/subscriptions","organizations_url":"https://api.github.com/users/nla/orgs","repos_url":"https://api.github.com/users/nla/repos","events_url":"https://api.github.com/users/nla/events{/privacy}","received_events_url":"https://api.github.com/users/nla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nla/amberdb","description":"A digital library domain model","fork":false,"url":"https://api.github.com/repos/nla/amberdb","forks_url":"https://api.github.com/repos/nla/amberdb/forks","keys_url":"https://api.github.com/repos/nla/amberdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nla/amberdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nla/amberdb/teams","hooks_url":"https://api.github.com/repos/nla/amberdb/hooks","issue_events_url":"https://api.github.com/repos/nla/amberdb/issues/events{/number}","events_url":"https://api.github.com/repos/nla/amberdb/events","assignees_url":"https://api.github.com/repos/nla/amberdb/assignees{/user}","branches_url":"https://api.github.com/repos/nla/amberdb/branches{/branch}","tags_url":"https://api.github.com/repos/nla/amberdb/tags","blobs_url":"https://api.github.com/repos/nla/amberdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nla/amberdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nla/amberdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/nla/amberdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nla/amberdb/statuses/{sha}","languages_url":"https://api.github.com/repos/nla/amberdb/languages","stargazers_url":"https://api.github.com/repos/nla/amberdb/stargazers","contributors_url":"https://api.github.com/repos/nla/amberdb/contributors","subscribers_url":"https://api.github.com/repos/nla/amberdb/subscribers","subscription_url":"https://api.github.com/repos/nla/amberdb/subscription","commits_url":"https://api.github.com/repos/nla/amberdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/nla/amberdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/nla/amberdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/nla/amberdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/nla/amberdb/contents/{+path}","compare_url":"https://api.github.com/repos/nla/amberdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nla/amberdb/merges","archive_url":"https://api.github.com/repos/nla/amberdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nla/amberdb/downloads","issues_url":"https://api.github.com/repos/nla/amberdb/issues{/number}","pulls_url":"https://api.github.com/repos/nla/amberdb/pulls{/number}","milestones_url":"https://api.github.com/repos/nla/amberdb/milestones{/number}","notifications_url":"https://api.github.com/repos/nla/amberdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nla/amberdb/labels{/name}","releases_url":"https://api.github.com/repos/nla/amberdb/releases{/id}","created_at":"2013-09-12T07:45:06Z","updated_at":"2015-07-23T02:31:25Z","pushed_at":"2015-08-18T06:49:46Z","git_url":"git://github.com/nla/amberdb.git","ssh_url":"git@github.com:nla/amberdb.git","clone_url":"https://github.com/nla/amberdb.git","svn_url":"https://github.com/nla/amberdb","homepage":"","size":5732,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nla/amberdb/pulls/384"},"html":{"href":"https://github.com/nla/amberdb/pull/384"},"issue":{"href":"https://api.github.com/repos/nla/amberdb/issues/384"},"comments":{"href":"https://api.github.com/repos/nla/amberdb/issues/384/comments"},"review_comments":{"href":"https://api.github.com/repos/nla/amberdb/pulls/384/comments"},"review_comment":{"href":"https://api.github.com/repos/nla/amberdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nla/amberdb/pulls/384/commits"},"statuses":{"href":"https://api.github.com/repos/nla/amberdb/statuses/982e1c212543eba298357bb0475d72357b5ea669"}}}}