{"action":"created","issue":{"url":"https://api.github.com/repos/georchestra/georchestra/issues/977","labels_url":"https://api.github.com/repos/georchestra/georchestra/issues/977/labels{/name}","comments_url":"https://api.github.com/repos/georchestra/georchestra/issues/977/comments","events_url":"https://api.github.com/repos/georchestra/georchestra/issues/977/events","html_url":"https://github.com/georchestra/georchestra/pull/977","id":75611488,"number":977,"title":"[Mapfish] Correct bug on editing feature","user":{"login":"jusabatier","id":8310116,"avatar_url":"https://avatars.githubusercontent.com/u/8310116?v=3","gravatar_id":"","url":"https://api.github.com/users/jusabatier","html_url":"https://github.com/jusabatier","followers_url":"https://api.github.com/users/jusabatier/followers","following_url":"https://api.github.com/users/jusabatier/following{/other_user}","gists_url":"https://api.github.com/users/jusabatier/gists{/gist_id}","starred_url":"https://api.github.com/users/jusabatier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jusabatier/subscriptions","organizations_url":"https://api.github.com/users/jusabatier/orgs","repos_url":"https://api.github.com/users/jusabatier/repos","events_url":"https://api.github.com/users/jusabatier/events{/privacy}","received_events_url":"https://api.github.com/users/jusabatier/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/georchestra/georchestra/labels/14.12","name":"14.12","color":"fbca04"},{"url":"https://api.github.com/repos/georchestra/georchestra/labels/2%20-%20Working","name":"2 - Working","color":"CCCCCC"},{"url":"https://api.github.com/repos/georchestra/georchestra/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"fvanderbiest","id":265319,"avatar_url":"https://avatars.githubusercontent.com/u/265319?v=3","gravatar_id":"","url":"https://api.github.com/users/fvanderbiest","html_url":"https://github.com/fvanderbiest","followers_url":"https://api.github.com/users/fvanderbiest/followers","following_url":"https://api.github.com/users/fvanderbiest/following{/other_user}","gists_url":"https://api.github.com/users/fvanderbiest/gists{/gist_id}","starred_url":"https://api.github.com/users/fvanderbiest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvanderbiest/subscriptions","organizations_url":"https://api.github.com/users/fvanderbiest/orgs","repos_url":"https://api.github.com/users/fvanderbiest/repos","events_url":"https://api.github.com/users/fvanderbiest/events{/privacy}","received_events_url":"https://api.github.com/users/fvanderbiest/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/georchestra/georchestra/milestones/7","html_url":"https://github.com/georchestra/georchestra/milestones/15.06","labels_url":"https://api.github.com/repos/georchestra/georchestra/milestones/7/labels","id":697477,"number":7,"title":"15.06","description":"","creator":{"login":"fvanderbiest","id":265319,"avatar_url":"https://avatars.githubusercontent.com/u/265319?v=3","gravatar_id":"","url":"https://api.github.com/users/fvanderbiest","html_url":"https://github.com/fvanderbiest","followers_url":"https://api.github.com/users/fvanderbiest/followers","following_url":"https://api.github.com/users/fvanderbiest/following{/other_user}","gists_url":"https://api.github.com/users/fvanderbiest/gists{/gist_id}","starred_url":"https://api.github.com/users/fvanderbiest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvanderbiest/subscriptions","organizations_url":"https://api.github.com/users/fvanderbiest/orgs","repos_url":"https://api.github.com/users/fvanderbiest/repos","events_url":"https://api.github.com/users/fvanderbiest/events{/privacy}","received_events_url":"https://api.github.com/users/fvanderbiest/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":22,"state":"open","created_at":"2014-06-21T10:10:08Z","updated_at":"2015-05-12T13:55:25Z","due_on":"2015-06-30T07:00:00Z","closed_at":null},"comments":1,"created_at":"2015-05-12T13:52:27Z","updated_at":"2015-05-12T13:59:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/georchestra/georchestra/pulls/977","html_url":"https://github.com/georchestra/georchestra/pull/977","diff_url":"https://github.com/georchestra/georchestra/pull/977.diff","patch_url":"https://github.com/georchestra/georchestra/pull/977.patch"},"body":"When editing a feature (observed on close lines and points), sometimes the hovered feature is not the good one.\r\n\r\nThis problem is due to : \r\n```\r\nmaxFeatures: 1,\r\n```\r\n\r\nBecause the wfs protocol requests a BBOX where more than one feature can be included, and as said in the OL doc, set maxFeatures to more than one allows wfs to return more than one feature. The returned set of features is then used to determine the best match client-side.\r\n\r\nhttp://dev.openlayers.org/apidocs/files/OpenLayers/Control/GetFeature-js.html\r\n\r\nI remove the line because by default, maxFeatures is set to 10, the good value to set there depends on the distance between features in the edited layer, so the default value seems to be a good average.\r\n\r\nAfter doing that, the edit function is repaired."},"comment":{"url":"https://api.github.com/repos/georchestra/georchestra/issues/comments/101293558","html_url":"https://github.com/georchestra/georchestra/pull/977#issuecomment-101293558","issue_url":"https://api.github.com/repos/georchestra/georchestra/issues/977","id":101293558,"user":{"login":"fvanderbiest","id":265319,"avatar_url":"https://avatars.githubusercontent.com/u/265319?v=3","gravatar_id":"","url":"https://api.github.com/users/fvanderbiest","html_url":"https://github.com/fvanderbiest","followers_url":"https://api.github.com/users/fvanderbiest/followers","following_url":"https://api.github.com/users/fvanderbiest/following{/other_user}","gists_url":"https://api.github.com/users/fvanderbiest/gists{/gist_id}","starred_url":"https://api.github.com/users/fvanderbiest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fvanderbiest/subscriptions","organizations_url":"https://api.github.com/users/fvanderbiest/orgs","repos_url":"https://api.github.com/users/fvanderbiest/repos","events_url":"https://api.github.com/users/fvanderbiest/events{/privacy}","received_events_url":"https://api.github.com/users/fvanderbiest/received_events","type":"User","site_admin":false},"created_at":"2015-05-12T13:59:37Z","updated_at":"2015-05-12T13:59:37Z","body":"Thanks a lot for spotting this !\r\n\r\nI'm +1 on changing this value, but having a maximum of ten features returned by the service might hang the client in case of big, complex geometries. I would like this number to be as low as possible.\r\n\r\nIs your issue gone with, eg maxFeatures = 2 or 3 ?"}}