{"action":"closed","number":66,"pull_request":{"url":"https://api.github.com/repos/ably/ably-ruby/pulls/66","id":49644945,"html_url":"https://github.com/ably/ably-ruby/pull/66","diff_url":"https://github.com/ably/ably-ruby/pull/66.diff","patch_url":"https://github.com/ably/ably-ruby/pull/66.patch","issue_url":"https://api.github.com/repos/ably/ably-ruby/issues/66","number":66,"state":"closed","locked":false,"title":"0.8 final spec (98% compliance)","user":{"login":"mattheworiordan","id":43789,"avatar_url":"https://avatars.githubusercontent.com/u/43789?v=3","gravatar_id":"","url":"https://api.github.com/users/mattheworiordan","html_url":"https://github.com/mattheworiordan","followers_url":"https://api.github.com/users/mattheworiordan/followers","following_url":"https://api.github.com/users/mattheworiordan/following{/other_user}","gists_url":"https://api.github.com/users/mattheworiordan/gists{/gist_id}","starred_url":"https://api.github.com/users/mattheworiordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattheworiordan/subscriptions","organizations_url":"https://api.github.com/users/mattheworiordan/orgs","repos_url":"https://api.github.com/users/mattheworiordan/repos","events_url":"https://api.github.com/users/mattheworiordan/events{/privacy}","received_events_url":"https://api.github.com/users/mattheworiordan/received_events","type":"User","site_admin":false},"body":"@SimonWoolf and @paddybyers, over the last 2-3 days I have brought the Ruby spec up to date with the 0.8 spec, see https://docs.google.com/spreadsheets/d/11fxeoCsaW1j5Q5VWtFNf04v6LXFYoHRhVTRgsEysZkU/edit#gid=431008744. Ruby complies with 98% of the specs, which I think is good enough for now.  It was a good exercise to ensure the spec is practically implementable - as you will see in https://github.com/ably/docs/commits/source, there are a few commits I have modified to fix some issues I found along the way.\r\n\r\nI have in fact implemented https://github.com/ably/wiki/issues/31, however it is somewhat blocked by https://github.com/ably/realtime/issues/349.  I would really like to get https://github.com/ably/realtime/issues/349 addressed if possible, so long as it is indeed easy to implement.  \r\n\r\nI will now focus my attention on completing documentation as the implemented spec in Ruby, even if not adhered to correctly in all client libraries, is good enough to work with.\r\n\r\nFYI @lmars if you're interested...","created_at":"2015-11-04T03:38:19Z","updated_at":"2015-12-02T22:52:52Z","closed_at":"2015-12-02T22:52:52Z","merged_at":"2015-12-02T22:52:52Z","merge_commit_sha":"6b6742b020a93c322a49df3cbf9ecd6690254cff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ably/ably-ruby/pulls/66/commits","review_comments_url":"https://api.github.com/repos/ably/ably-ruby/pulls/66/comments","review_comment_url":"https://api.github.com/repos/ably/ably-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ably/ably-ruby/issues/66/comments","statuses_url":"https://api.github.com/repos/ably/ably-ruby/statuses/1b1a039cb79be8290b93525a8f23535aa1612d14","head":{"label":"ably:0.8-final-spec","ref":"0.8-final-spec","sha":"1b1a039cb79be8290b93525a8f23535aa1612d14","user":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"repo":{"id":24370613,"name":"ably-ruby","full_name":"ably/ably-ruby","owner":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ably/ably-ruby","description":"Ruby client for Ably real-time messaging service","fork":false,"url":"https://api.github.com/repos/ably/ably-ruby","forks_url":"https://api.github.com/repos/ably/ably-ruby/forks","keys_url":"https://api.github.com/repos/ably/ably-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ably/ably-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ably/ably-ruby/teams","hooks_url":"https://api.github.com/repos/ably/ably-ruby/hooks","issue_events_url":"https://api.github.com/repos/ably/ably-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/ably/ably-ruby/events","assignees_url":"https://api.github.com/repos/ably/ably-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/ably/ably-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/ably/ably-ruby/tags","blobs_url":"https://api.github.com/repos/ably/ably-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ably/ably-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ably/ably-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/ably/ably-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ably/ably-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/ably/ably-ruby/languages","stargazers_url":"https://api.github.com/repos/ably/ably-ruby/stargazers","contributors_url":"https://api.github.com/repos/ably/ably-ruby/contributors","subscribers_url":"https://api.github.com/repos/ably/ably-ruby/subscribers","subscription_url":"https://api.github.com/repos/ably/ably-ruby/subscription","commits_url":"https://api.github.com/repos/ably/ably-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/ably/ably-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/ably/ably-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/ably/ably-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/ably/ably-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/ably/ably-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ably/ably-ruby/merges","archive_url":"https://api.github.com/repos/ably/ably-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ably/ably-ruby/downloads","issues_url":"https://api.github.com/repos/ably/ably-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/ably/ably-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/ably/ably-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/ably/ably-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ably/ably-ruby/labels{/name}","releases_url":"https://api.github.com/repos/ably/ably-ruby/releases{/id}","created_at":"2014-09-23T12:33:47Z","updated_at":"2015-11-05T16:17:29Z","pushed_at":"2015-12-02T22:52:52Z","git_url":"git://github.com/ably/ably-ruby.git","ssh_url":"git@github.com:ably/ably-ruby.git","clone_url":"https://github.com/ably/ably-ruby.git","svn_url":"https://github.com/ably/ably-ruby","homepage":null,"size":1489,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":4,"default_branch":"master"}},"base":{"label":"ably:master","ref":"master","sha":"21d1a67b24f1b694557c8d7daac90811870b182b","user":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"repo":{"id":24370613,"name":"ably-ruby","full_name":"ably/ably-ruby","owner":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ably/ably-ruby","description":"Ruby client for Ably real-time messaging service","fork":false,"url":"https://api.github.com/repos/ably/ably-ruby","forks_url":"https://api.github.com/repos/ably/ably-ruby/forks","keys_url":"https://api.github.com/repos/ably/ably-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ably/ably-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ably/ably-ruby/teams","hooks_url":"https://api.github.com/repos/ably/ably-ruby/hooks","issue_events_url":"https://api.github.com/repos/ably/ably-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/ably/ably-ruby/events","assignees_url":"https://api.github.com/repos/ably/ably-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/ably/ably-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/ably/ably-ruby/tags","blobs_url":"https://api.github.com/repos/ably/ably-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ably/ably-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ably/ably-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/ably/ably-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ably/ably-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/ably/ably-ruby/languages","stargazers_url":"https://api.github.com/repos/ably/ably-ruby/stargazers","contributors_url":"https://api.github.com/repos/ably/ably-ruby/contributors","subscribers_url":"https://api.github.com/repos/ably/ably-ruby/subscribers","subscription_url":"https://api.github.com/repos/ably/ably-ruby/subscription","commits_url":"https://api.github.com/repos/ably/ably-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/ably/ably-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/ably/ably-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/ably/ably-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/ably/ably-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/ably/ably-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ably/ably-ruby/merges","archive_url":"https://api.github.com/repos/ably/ably-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ably/ably-ruby/downloads","issues_url":"https://api.github.com/repos/ably/ably-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/ably/ably-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/ably/ably-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/ably/ably-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ably/ably-ruby/labels{/name}","releases_url":"https://api.github.com/repos/ably/ably-ruby/releases{/id}","created_at":"2014-09-23T12:33:47Z","updated_at":"2015-11-05T16:17:29Z","pushed_at":"2015-12-02T22:52:52Z","git_url":"git://github.com/ably/ably-ruby.git","ssh_url":"git@github.com:ably/ably-ruby.git","clone_url":"https://github.com/ably/ably-ruby.git","svn_url":"https://github.com/ably/ably-ruby","homepage":null,"size":1489,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ably/ably-ruby/pulls/66"},"html":{"href":"https://github.com/ably/ably-ruby/pull/66"},"issue":{"href":"https://api.github.com/repos/ably/ably-ruby/issues/66"},"comments":{"href":"https://api.github.com/repos/ably/ably-ruby/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/ably/ably-ruby/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/ably/ably-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ably/ably-ruby/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/ably/ably-ruby/statuses/1b1a039cb79be8290b93525a8f23535aa1612d14"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mattheworiordan","id":43789,"avatar_url":"https://avatars.githubusercontent.com/u/43789?v=3","gravatar_id":"","url":"https://api.github.com/users/mattheworiordan","html_url":"https://github.com/mattheworiordan","followers_url":"https://api.github.com/users/mattheworiordan/followers","following_url":"https://api.github.com/users/mattheworiordan/following{/other_user}","gists_url":"https://api.github.com/users/mattheworiordan/gists{/gist_id}","starred_url":"https://api.github.com/users/mattheworiordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattheworiordan/subscriptions","organizations_url":"https://api.github.com/users/mattheworiordan/orgs","repos_url":"https://api.github.com/users/mattheworiordan/repos","events_url":"https://api.github.com/users/mattheworiordan/events{/privacy}","received_events_url":"https://api.github.com/users/mattheworiordan/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":31,"additions":2263,"deletions":402,"changed_files":43}}