{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/26435755","id":26435755,"diff_hunk":"@@ -1467,13 +1467,14 @@ fn full_path(cx: &Context, item: &clean::Item) -> String {\n     return s\n }\n \n-fn shorter<'a>(s: Option<&'a str>) -> &'a str {\n+fn shorter<'a>(s: Option<&'a str>) -> String {\n     match s {\n-        Some(s) => match s.find(\"\\n\\n\") {\n-            Some(pos) => &s[..pos],\n-            None => s,\n-        },\n-        None => \"\"\n+        Some(s) => s.lines().take_while(|x|{\n+            !(*x).chars().all(|c|{","path":"src/librustdoc/html/render.rs","position":31,"original_position":31,"commit_id":"42ac4a77b2db608065f6718bfd903c044c35b0a6","original_commit_id":"42ac4a77b2db608065f6718bfd903c044c35b0a6","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"nit:\r\n```rust\r\n(*x).chars().any(|c|{\r\n  c.is_whitespace()\r\n})\r\n```","created_at":"2015-03-14T05:56:28Z","updated_at":"2015-03-14T05:56:28Z","html_url":"https://github.com/rust-lang/rust/pull/23351#discussion_r26435755","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/23351","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/26435755"},"html":{"href":"https://github.com/rust-lang/rust/pull/23351#discussion_r26435755"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/23351"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/23351","id":31170813,"html_url":"https://github.com/rust-lang/rust/pull/23351","diff_url":"https://github.com/rust-lang/rust/pull/23351.diff","patch_url":"https://github.com/rust-lang/rust/pull/23351.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/23351","number":23351,"state":"open","locked":false,"title":"Split rustdoc summary lines in a smarter way","user":{"login":"nagisa","id":679122,"avatar_url":"https://avatars.githubusercontent.com/u/679122?v=3","gravatar_id":"","url":"https://api.github.com/users/nagisa","html_url":"https://github.com/nagisa","followers_url":"https://api.github.com/users/nagisa/followers","following_url":"https://api.github.com/users/nagisa/following{/other_user}","gists_url":"https://api.github.com/users/nagisa/gists{/gist_id}","starred_url":"https://api.github.com/users/nagisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagisa/subscriptions","organizations_url":"https://api.github.com/users/nagisa/orgs","repos_url":"https://api.github.com/users/nagisa/repos","events_url":"https://api.github.com/users/nagisa/events{/privacy}","received_events_url":"https://api.github.com/users/nagisa/received_events","type":"User","site_admin":false},"body":"Previously it would fail on a trivial case like\r\n\r\n    /// Summary line\r\n    /// <trailing space>\r\n    /// Regular content\r\n\r\nCompliant markdown preprocessor would render that as two separate paragraphs, but our summary line\r\nextractor interprets both lines as the same paragraph and includes both into the short summary resulting in\r\n![screenshot from 2015-03-13 22 47 08](https://cloud.githubusercontent.com/assets/679122/6648596/7ef792b2-c9e4-11e4-9c19-704c288ec4de.png)","created_at":"2015-03-13T22:54:26Z","updated_at":"2015-03-14T05:56:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f1689d36fa37dfa6c0bdee40d68b37c4b5e9033","assignee":{"login":"pcwalton","id":157897,"avatar_url":"https://avatars.githubusercontent.com/u/157897?v=3","gravatar_id":"","url":"https://api.github.com/users/pcwalton","html_url":"https://github.com/pcwalton","followers_url":"https://api.github.com/users/pcwalton/followers","following_url":"https://api.github.com/users/pcwalton/following{/other_user}","gists_url":"https://api.github.com/users/pcwalton/gists{/gist_id}","starred_url":"https://api.github.com/users/pcwalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcwalton/subscriptions","organizations_url":"https://api.github.com/users/pcwalton/orgs","repos_url":"https://api.github.com/users/pcwalton/repos","events_url":"https://api.github.com/users/pcwalton/events{/privacy}","received_events_url":"https://api.github.com/users/pcwalton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/23351/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/23351/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/23351/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/42ac4a77b2db608065f6718bfd903c044c35b0a6","head":{"label":"nagisa:rustdoc-lines-2","ref":"rustdoc-lines-2","sha":"42ac4a77b2db608065f6718bfd903c044c35b0a6","user":{"login":"nagisa","id":679122,"avatar_url":"https://avatars.githubusercontent.com/u/679122?v=3","gravatar_id":"","url":"https://api.github.com/users/nagisa","html_url":"https://github.com/nagisa","followers_url":"https://api.github.com/users/nagisa/followers","following_url":"https://api.github.com/users/nagisa/following{/other_user}","gists_url":"https://api.github.com/users/nagisa/gists{/gist_id}","starred_url":"https://api.github.com/users/nagisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagisa/subscriptions","organizations_url":"https://api.github.com/users/nagisa/orgs","repos_url":"https://api.github.com/users/nagisa/repos","events_url":"https://api.github.com/users/nagisa/events{/privacy}","received_events_url":"https://api.github.com/users/nagisa/received_events","type":"User","site_admin":false},"repo":{"id":28332501,"name":"rust","full_name":"nagisa/rust","owner":{"login":"nagisa","id":679122,"avatar_url":"https://avatars.githubusercontent.com/u/679122?v=3","gravatar_id":"","url":"https://api.github.com/users/nagisa","html_url":"https://github.com/nagisa","followers_url":"https://api.github.com/users/nagisa/followers","following_url":"https://api.github.com/users/nagisa/following{/other_user}","gists_url":"https://api.github.com/users/nagisa/gists{/gist_id}","starred_url":"https://api.github.com/users/nagisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagisa/subscriptions","organizations_url":"https://api.github.com/users/nagisa/orgs","repos_url":"https://api.github.com/users/nagisa/repos","events_url":"https://api.github.com/users/nagisa/events{/privacy}","received_events_url":"https://api.github.com/users/nagisa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nagisa/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/nagisa/rust","forks_url":"https://api.github.com/repos/nagisa/rust/forks","keys_url":"https://api.github.com/repos/nagisa/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nagisa/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nagisa/rust/teams","hooks_url":"https://api.github.com/repos/nagisa/rust/hooks","issue_events_url":"https://api.github.com/repos/nagisa/rust/issues/events{/number}","events_url":"https://api.github.com/repos/nagisa/rust/events","assignees_url":"https://api.github.com/repos/nagisa/rust/assignees{/user}","branches_url":"https://api.github.com/repos/nagisa/rust/branches{/branch}","tags_url":"https://api.github.com/repos/nagisa/rust/tags","blobs_url":"https://api.github.com/repos/nagisa/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nagisa/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nagisa/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/nagisa/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nagisa/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/nagisa/rust/languages","stargazers_url":"https://api.github.com/repos/nagisa/rust/stargazers","contributors_url":"https://api.github.com/repos/nagisa/rust/contributors","subscribers_url":"https://api.github.com/repos/nagisa/rust/subscribers","subscription_url":"https://api.github.com/repos/nagisa/rust/subscription","commits_url":"https://api.github.com/repos/nagisa/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/nagisa/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/nagisa/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/nagisa/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/nagisa/rust/contents/{+path}","compare_url":"https://api.github.com/repos/nagisa/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nagisa/rust/merges","archive_url":"https://api.github.com/repos/nagisa/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nagisa/rust/downloads","issues_url":"https://api.github.com/repos/nagisa/rust/issues{/number}","pulls_url":"https://api.github.com/repos/nagisa/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/nagisa/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/nagisa/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nagisa/rust/labels{/name}","releases_url":"https://api.github.com/repos/nagisa/rust/releases{/id}","created_at":"2014-12-22T09:30:51Z","updated_at":"2015-01-13T13:18:02Z","pushed_at":"2015-03-13T23:33:35Z","git_url":"git://github.com/nagisa/rust.git","ssh_url":"git@github.com:nagisa/rust.git","clone_url":"https://github.com/nagisa/rust.git","svn_url":"https://github.com/nagisa/rust","homepage":"http://www.rust-lang.org","size":249966,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"3e4be02b80a3dd27bce20870958fe0aef7e7336d","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-03-14T01:49:08Z","pushed_at":"2015-03-14T01:04:38Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":504174,"stargazers_count":9725,"watchers_count":9725,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1887,"mirror_url":null,"open_issues_count":2034,"forks":1887,"open_issues":2034,"watchers":9725,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/23351"},"html":{"href":"https://github.com/rust-lang/rust/pull/23351"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/23351"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/23351/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/23351/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/23351/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/42ac4a77b2db608065f6718bfd903c044c35b0a6"}}}}