{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/25125867","id":25125867,"diff_hunk":"@@ -43,13 +43,18 @@ ResultCode GetConfigInfoBlock(u32 block_id, u32 size, u32 flag, u8* output) {\n     SaveFileConfig* config = reinterpret_cast<SaveFileConfig*>(cfg_config_file_buffer.data());\n \n     auto itr = std::find_if(std::begin(config->block_entries), std::end(config->block_entries),\n-            [&](const SaveConfigBlockEntry& entry) {\n-                return entry.block_id == block_id && entry.size == size && (entry.flags & flag);\n-            });\n+        [&](const SaveConfigBlockEntry& entry) {\n+            return entry.block_id == block_id && (entry.flags & flag);\n+        });","path":"src/core/hle/service/cfg/cfg.cpp","position":9,"original_position":9,"commit_id":"a6fdb8f2176e2701c505758237ee96029e97f405","original_commit_id":"a6fdb8f2176e2701c505758237ee96029e97f405","user":{"login":"kevinhartman","id":1374024,"avatar_url":"https://avatars.githubusercontent.com/u/1374024?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinhartman","html_url":"https://github.com/kevinhartman","followers_url":"https://api.github.com/users/kevinhartman/followers","following_url":"https://api.github.com/users/kevinhartman/following{/other_user}","gists_url":"https://api.github.com/users/kevinhartman/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhartman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhartman/subscriptions","organizations_url":"https://api.github.com/users/kevinhartman/orgs","repos_url":"https://api.github.com/users/kevinhartman/repos","events_url":"https://api.github.com/users/kevinhartman/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhartman/received_events","type":"User","site_admin":false},"body":"In the GitHub diff you should see darker areas of the red and green highlights, which should make it clear that I removed one thing from the predicate.","created_at":"2015-02-21T21:13:12Z","updated_at":"2015-02-21T21:13:12Z","html_url":"https://github.com/citra-emu/citra/pull/589#discussion_r25125867","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/589","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/25125867"},"html":{"href":"https://github.com/citra-emu/citra/pull/589#discussion_r25125867"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/589"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/589","id":29671777,"html_url":"https://github.com/citra-emu/citra/pull/589","diff_url":"https://github.com/citra-emu/citra/pull/589.diff","patch_url":"https://github.com/citra-emu/citra/pull/589.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/589","number":589,"state":"open","locked":false,"title":"Fix errorcodes for bad config block request","user":{"login":"kevinhartman","id":1374024,"avatar_url":"https://avatars.githubusercontent.com/u/1374024?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinhartman","html_url":"https://github.com/kevinhartman","followers_url":"https://api.github.com/users/kevinhartman/followers","following_url":"https://api.github.com/users/kevinhartman/following{/other_user}","gists_url":"https://api.github.com/users/kevinhartman/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhartman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhartman/subscriptions","organizations_url":"https://api.github.com/users/kevinhartman/orgs","repos_url":"https://api.github.com/users/kevinhartman/repos","events_url":"https://api.github.com/users/kevinhartman/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhartman/received_events","type":"User","site_admin":false},"body":"Updated GetConfigInfoBlock with actual error codes. Verified with hwtests.","created_at":"2015-02-20T04:05:14Z","updated_at":"2015-02-21T21:13:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5309d3e8f236da59c545c40f4f58ad8e21119a51","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/589/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/589/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/{number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/589/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/a6fdb8f2176e2701c505758237ee96029e97f405","head":{"label":"kevinhartman:config-errors","ref":"config-errors","sha":"a6fdb8f2176e2701c505758237ee96029e97f405","user":{"login":"kevinhartman","id":1374024,"avatar_url":"https://avatars.githubusercontent.com/u/1374024?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinhartman","html_url":"https://github.com/kevinhartman","followers_url":"https://api.github.com/users/kevinhartman/followers","following_url":"https://api.github.com/users/kevinhartman/following{/other_user}","gists_url":"https://api.github.com/users/kevinhartman/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhartman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhartman/subscriptions","organizations_url":"https://api.github.com/users/kevinhartman/orgs","repos_url":"https://api.github.com/users/kevinhartman/repos","events_url":"https://api.github.com/users/kevinhartman/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhartman/received_events","type":"User","site_admin":false},"repo":{"id":22826744,"name":"citra","full_name":"kevinhartman/citra","owner":{"login":"kevinhartman","id":1374024,"avatar_url":"https://avatars.githubusercontent.com/u/1374024?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinhartman","html_url":"https://github.com/kevinhartman","followers_url":"https://api.github.com/users/kevinhartman/followers","following_url":"https://api.github.com/users/kevinhartman/following{/other_user}","gists_url":"https://api.github.com/users/kevinhartman/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhartman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhartman/subscriptions","organizations_url":"https://api.github.com/users/kevinhartman/orgs","repos_url":"https://api.github.com/users/kevinhartman/repos","events_url":"https://api.github.com/users/kevinhartman/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhartman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kevinhartman/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/kevinhartman/citra","forks_url":"https://api.github.com/repos/kevinhartman/citra/forks","keys_url":"https://api.github.com/repos/kevinhartman/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevinhartman/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevinhartman/citra/teams","hooks_url":"https://api.github.com/repos/kevinhartman/citra/hooks","issue_events_url":"https://api.github.com/repos/kevinhartman/citra/issues/events{/number}","events_url":"https://api.github.com/repos/kevinhartman/citra/events","assignees_url":"https://api.github.com/repos/kevinhartman/citra/assignees{/user}","branches_url":"https://api.github.com/repos/kevinhartman/citra/branches{/branch}","tags_url":"https://api.github.com/repos/kevinhartman/citra/tags","blobs_url":"https://api.github.com/repos/kevinhartman/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevinhartman/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevinhartman/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevinhartman/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevinhartman/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/kevinhartman/citra/languages","stargazers_url":"https://api.github.com/repos/kevinhartman/citra/stargazers","contributors_url":"https://api.github.com/repos/kevinhartman/citra/contributors","subscribers_url":"https://api.github.com/repos/kevinhartman/citra/subscribers","subscription_url":"https://api.github.com/repos/kevinhartman/citra/subscription","commits_url":"https://api.github.com/repos/kevinhartman/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevinhartman/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevinhartman/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevinhartman/citra/issues/comments/{number}","contents_url":"https://api.github.com/repos/kevinhartman/citra/contents/{+path}","compare_url":"https://api.github.com/repos/kevinhartman/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevinhartman/citra/merges","archive_url":"https://api.github.com/repos/kevinhartman/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevinhartman/citra/downloads","issues_url":"https://api.github.com/repos/kevinhartman/citra/issues{/number}","pulls_url":"https://api.github.com/repos/kevinhartman/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/kevinhartman/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/kevinhartman/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevinhartman/citra/labels{/name}","releases_url":"https://api.github.com/repos/kevinhartman/citra/releases{/id}","created_at":"2014-08-11T04:25:22Z","updated_at":"2015-02-20T03:52:56Z","pushed_at":"2015-02-21T05:48:09Z","git_url":"git://github.com/kevinhartman/citra.git","ssh_url":"git@github.com:kevinhartman/citra.git","clone_url":"https://github.com/kevinhartman/citra.git","svn_url":"https://github.com/kevinhartman/citra","homepage":null,"size":7881,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"3c5aaafb402dec431517faeb49a4b30c5ac42495","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments/{number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","created_at":"2014-05-16T18:33:15Z","updated_at":"2015-02-21T21:04:10Z","pushed_at":"2015-02-20T18:26:16Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":18829,"stargazers_count":605,"watchers_count":605,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"open_issues_count":46,"forks":151,"open_issues":46,"watchers":605,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/589"},"html":{"href":"https://github.com/citra-emu/citra/pull/589"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/589"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/589/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/589/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/589/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/a6fdb8f2176e2701c505758237ee96029e97f405"}}}}