{"action":"closed","number":14,"pull_request":{"url":"https://api.github.com/repos/example42/puppet-vsftpd/pulls/14","id":47270575,"html_url":"https://github.com/example42/puppet-vsftpd/pull/14","diff_url":"https://github.com/example42/puppet-vsftpd/pull/14.diff","patch_url":"https://github.com/example42/puppet-vsftpd/pull/14.patch","issue_url":"https://api.github.com/repos/example42/puppet-vsftpd/issues/14","number":14,"state":"closed","locked":false,"title":"Additional options, adjusted variable evaluation","user":{"login":"mklette","id":1333486,"avatar_url":"https://avatars.githubusercontent.com/u/1333486?v=3","gravatar_id":"","url":"https://api.github.com/users/mklette","html_url":"https://github.com/mklette","followers_url":"https://api.github.com/users/mklette/followers","following_url":"https://api.github.com/users/mklette/following{/other_user}","gists_url":"https://api.github.com/users/mklette/gists{/gist_id}","starred_url":"https://api.github.com/users/mklette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklette/subscriptions","organizations_url":"https://api.github.com/users/mklette/orgs","repos_url":"https://api.github.com/users/mklette/repos","events_url":"https://api.github.com/users/mklette/events{/privacy}","received_events_url":"https://api.github.com/users/mklette/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nplease cross check these commits. We'd appreciate any comments or even integration into master ;)\r\n\r\n1. variable evaluation:\r\nChanged for specific parameters where the default would use 'YES' but 'NO' is required. Using scope.lookupvar('bool_*') evaluates to false, the parameter is not added and defaults apply - which is 'YES'. Using a defined?() instead allows us to have such parameters be defined with the required 'NO' value.\r\n\r\n2. adding pasv_address and pasv_addr_resolve parameters\r\n\r\n3. adding seccomp_sandbox parameter\r\nWhich seems to be required on some maschines. I.e. https://bugzilla.redhat.com/show_bug.cgi?id=845980\r\n\r\nThanks!\r\nDavid, Jan, Mathias","created_at":"2015-10-09T13:19:55Z","updated_at":"2015-10-12T19:19:44Z","closed_at":"2015-10-12T19:19:44Z","merged_at":"2015-10-12T19:19:44Z","merge_commit_sha":"6a07400e6e841eb7152f017216ecbb0c56e4dac5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/example42/puppet-vsftpd/pulls/14/commits","review_comments_url":"https://api.github.com/repos/example42/puppet-vsftpd/pulls/14/comments","review_comment_url":"https://api.github.com/repos/example42/puppet-vsftpd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/example42/puppet-vsftpd/issues/14/comments","statuses_url":"https://api.github.com/repos/example42/puppet-vsftpd/statuses/670b20b594a32613e908202d74832986c6e5ded2","head":{"label":"mklette:MR","ref":"MR","sha":"670b20b594a32613e908202d74832986c6e5ded2","user":{"login":"mklette","id":1333486,"avatar_url":"https://avatars.githubusercontent.com/u/1333486?v=3","gravatar_id":"","url":"https://api.github.com/users/mklette","html_url":"https://github.com/mklette","followers_url":"https://api.github.com/users/mklette/followers","following_url":"https://api.github.com/users/mklette/following{/other_user}","gists_url":"https://api.github.com/users/mklette/gists{/gist_id}","starred_url":"https://api.github.com/users/mklette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklette/subscriptions","organizations_url":"https://api.github.com/users/mklette/orgs","repos_url":"https://api.github.com/users/mklette/repos","events_url":"https://api.github.com/users/mklette/events{/privacy}","received_events_url":"https://api.github.com/users/mklette/received_events","type":"User","site_admin":false},"repo":{"id":43954190,"name":"puppet-vsftpd","full_name":"mklette/puppet-vsftpd","owner":{"login":"mklette","id":1333486,"avatar_url":"https://avatars.githubusercontent.com/u/1333486?v=3","gravatar_id":"","url":"https://api.github.com/users/mklette","html_url":"https://github.com/mklette","followers_url":"https://api.github.com/users/mklette/followers","following_url":"https://api.github.com/users/mklette/following{/other_user}","gists_url":"https://api.github.com/users/mklette/gists{/gist_id}","starred_url":"https://api.github.com/users/mklette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklette/subscriptions","organizations_url":"https://api.github.com/users/mklette/orgs","repos_url":"https://api.github.com/users/mklette/repos","events_url":"https://api.github.com/users/mklette/events{/privacy}","received_events_url":"https://api.github.com/users/mklette/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mklette/puppet-vsftpd","description":"Puppet module for Vsftpd","fork":true,"url":"https://api.github.com/repos/mklette/puppet-vsftpd","forks_url":"https://api.github.com/repos/mklette/puppet-vsftpd/forks","keys_url":"https://api.github.com/repos/mklette/puppet-vsftpd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mklette/puppet-vsftpd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mklette/puppet-vsftpd/teams","hooks_url":"https://api.github.com/repos/mklette/puppet-vsftpd/hooks","issue_events_url":"https://api.github.com/repos/mklette/puppet-vsftpd/issues/events{/number}","events_url":"https://api.github.com/repos/mklette/puppet-vsftpd/events","assignees_url":"https://api.github.com/repos/mklette/puppet-vsftpd/assignees{/user}","branches_url":"https://api.github.com/repos/mklette/puppet-vsftpd/branches{/branch}","tags_url":"https://api.github.com/repos/mklette/puppet-vsftpd/tags","blobs_url":"https://api.github.com/repos/mklette/puppet-vsftpd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mklette/puppet-vsftpd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mklette/puppet-vsftpd/git/refs{/sha}","trees_url":"https://api.github.com/repos/mklette/puppet-vsftpd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mklette/puppet-vsftpd/statuses/{sha}","languages_url":"https://api.github.com/repos/mklette/puppet-vsftpd/languages","stargazers_url":"https://api.github.com/repos/mklette/puppet-vsftpd/stargazers","contributors_url":"https://api.github.com/repos/mklette/puppet-vsftpd/contributors","subscribers_url":"https://api.github.com/repos/mklette/puppet-vsftpd/subscribers","subscription_url":"https://api.github.com/repos/mklette/puppet-vsftpd/subscription","commits_url":"https://api.github.com/repos/mklette/puppet-vsftpd/commits{/sha}","git_commits_url":"https://api.github.com/repos/mklette/puppet-vsftpd/git/commits{/sha}","comments_url":"https://api.github.com/repos/mklette/puppet-vsftpd/comments{/number}","issue_comment_url":"https://api.github.com/repos/mklette/puppet-vsftpd/issues/comments{/number}","contents_url":"https://api.github.com/repos/mklette/puppet-vsftpd/contents/{+path}","compare_url":"https://api.github.com/repos/mklette/puppet-vsftpd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mklette/puppet-vsftpd/merges","archive_url":"https://api.github.com/repos/mklette/puppet-vsftpd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mklette/puppet-vsftpd/downloads","issues_url":"https://api.github.com/repos/mklette/puppet-vsftpd/issues{/number}","pulls_url":"https://api.github.com/repos/mklette/puppet-vsftpd/pulls{/number}","milestones_url":"https://api.github.com/repos/mklette/puppet-vsftpd/milestones{/number}","notifications_url":"https://api.github.com/repos/mklette/puppet-vsftpd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mklette/puppet-vsftpd/labels{/name}","releases_url":"https://api.github.com/repos/mklette/puppet-vsftpd/releases{/id}","created_at":"2015-10-09T12:31:17Z","updated_at":"2015-10-09T12:31:17Z","pushed_at":"2015-10-12T14:29:00Z","git_url":"git://github.com/mklette/puppet-vsftpd.git","ssh_url":"git@github.com:mklette/puppet-vsftpd.git","clone_url":"https://github.com/mklette/puppet-vsftpd.git","svn_url":"https://github.com/mklette/puppet-vsftpd","homepage":null,"size":147,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"example42:master","ref":"master","sha":"3df546fcdd8194b5d7f34e2a1147ca9f65121a3f","user":{"login":"example42","id":8918984,"avatar_url":"https://avatars.githubusercontent.com/u/8918984?v=3","gravatar_id":"","url":"https://api.github.com/users/example42","html_url":"https://github.com/example42","followers_url":"https://api.github.com/users/example42/followers","following_url":"https://api.github.com/users/example42/following{/other_user}","gists_url":"https://api.github.com/users/example42/gists{/gist_id}","starred_url":"https://api.github.com/users/example42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/example42/subscriptions","organizations_url":"https://api.github.com/users/example42/orgs","repos_url":"https://api.github.com/users/example42/repos","events_url":"https://api.github.com/users/example42/events{/privacy}","received_events_url":"https://api.github.com/users/example42/received_events","type":"Organization","site_admin":false},"repo":{"id":4599750,"name":"puppet-vsftpd","full_name":"example42/puppet-vsftpd","owner":{"login":"example42","id":8918984,"avatar_url":"https://avatars.githubusercontent.com/u/8918984?v=3","gravatar_id":"","url":"https://api.github.com/users/example42","html_url":"https://github.com/example42","followers_url":"https://api.github.com/users/example42/followers","following_url":"https://api.github.com/users/example42/following{/other_user}","gists_url":"https://api.github.com/users/example42/gists{/gist_id}","starred_url":"https://api.github.com/users/example42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/example42/subscriptions","organizations_url":"https://api.github.com/users/example42/orgs","repos_url":"https://api.github.com/users/example42/repos","events_url":"https://api.github.com/users/example42/events{/privacy}","received_events_url":"https://api.github.com/users/example42/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/example42/puppet-vsftpd","description":"Puppet module for Vsftpd","fork":false,"url":"https://api.github.com/repos/example42/puppet-vsftpd","forks_url":"https://api.github.com/repos/example42/puppet-vsftpd/forks","keys_url":"https://api.github.com/repos/example42/puppet-vsftpd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/example42/puppet-vsftpd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/example42/puppet-vsftpd/teams","hooks_url":"https://api.github.com/repos/example42/puppet-vsftpd/hooks","issue_events_url":"https://api.github.com/repos/example42/puppet-vsftpd/issues/events{/number}","events_url":"https://api.github.com/repos/example42/puppet-vsftpd/events","assignees_url":"https://api.github.com/repos/example42/puppet-vsftpd/assignees{/user}","branches_url":"https://api.github.com/repos/example42/puppet-vsftpd/branches{/branch}","tags_url":"https://api.github.com/repos/example42/puppet-vsftpd/tags","blobs_url":"https://api.github.com/repos/example42/puppet-vsftpd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/example42/puppet-vsftpd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/example42/puppet-vsftpd/git/refs{/sha}","trees_url":"https://api.github.com/repos/example42/puppet-vsftpd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/example42/puppet-vsftpd/statuses/{sha}","languages_url":"https://api.github.com/repos/example42/puppet-vsftpd/languages","stargazers_url":"https://api.github.com/repos/example42/puppet-vsftpd/stargazers","contributors_url":"https://api.github.com/repos/example42/puppet-vsftpd/contributors","subscribers_url":"https://api.github.com/repos/example42/puppet-vsftpd/subscribers","subscription_url":"https://api.github.com/repos/example42/puppet-vsftpd/subscription","commits_url":"https://api.github.com/repos/example42/puppet-vsftpd/commits{/sha}","git_commits_url":"https://api.github.com/repos/example42/puppet-vsftpd/git/commits{/sha}","comments_url":"https://api.github.com/repos/example42/puppet-vsftpd/comments{/number}","issue_comment_url":"https://api.github.com/repos/example42/puppet-vsftpd/issues/comments{/number}","contents_url":"https://api.github.com/repos/example42/puppet-vsftpd/contents/{+path}","compare_url":"https://api.github.com/repos/example42/puppet-vsftpd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/example42/puppet-vsftpd/merges","archive_url":"https://api.github.com/repos/example42/puppet-vsftpd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/example42/puppet-vsftpd/downloads","issues_url":"https://api.github.com/repos/example42/puppet-vsftpd/issues{/number}","pulls_url":"https://api.github.com/repos/example42/puppet-vsftpd/pulls{/number}","milestones_url":"https://api.github.com/repos/example42/puppet-vsftpd/milestones{/number}","notifications_url":"https://api.github.com/repos/example42/puppet-vsftpd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/example42/puppet-vsftpd/labels{/name}","releases_url":"https://api.github.com/repos/example42/puppet-vsftpd/releases{/id}","created_at":"2012-06-08T16:49:14Z","updated_at":"2015-04-26T15:00:37Z","pushed_at":"2015-10-12T19:19:44Z","git_url":"git://github.com/example42/puppet-vsftpd.git","ssh_url":"git@github.com:example42/puppet-vsftpd.git","clone_url":"https://github.com/example42/puppet-vsftpd.git","svn_url":"https://github.com/example42/puppet-vsftpd","homepage":null,"size":296,"stargazers_count":3,"watchers_count":3,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":0,"forks":12,"open_issues":0,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/example42/puppet-vsftpd/pulls/14"},"html":{"href":"https://github.com/example42/puppet-vsftpd/pull/14"},"issue":{"href":"https://api.github.com/repos/example42/puppet-vsftpd/issues/14"},"comments":{"href":"https://api.github.com/repos/example42/puppet-vsftpd/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/example42/puppet-vsftpd/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/example42/puppet-vsftpd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/example42/puppet-vsftpd/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/example42/puppet-vsftpd/statuses/670b20b594a32613e908202d74832986c6e5ded2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"alvagante","id":283804,"avatar_url":"https://avatars.githubusercontent.com/u/283804?v=3","gravatar_id":"","url":"https://api.github.com/users/alvagante","html_url":"https://github.com/alvagante","followers_url":"https://api.github.com/users/alvagante/followers","following_url":"https://api.github.com/users/alvagante/following{/other_user}","gists_url":"https://api.github.com/users/alvagante/gists{/gist_id}","starred_url":"https://api.github.com/users/alvagante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvagante/subscriptions","organizations_url":"https://api.github.com/users/alvagante/orgs","repos_url":"https://api.github.com/users/alvagante/repos","events_url":"https://api.github.com/users/alvagante/events{/privacy}","received_events_url":"https://api.github.com/users/alvagante/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"commits":3,"additions":68,"deletions":5,"changed_files":3}}