{"action":"closed","number":467,"pull_request":{"url":"https://api.github.com/repos/janl/mustache.js/pulls/467","id":38468228,"html_url":"https://github.com/janl/mustache.js/pull/467","diff_url":"https://github.com/janl/mustache.js/pull/467.diff","patch_url":"https://github.com/janl/mustache.js/pull/467.patch","issue_url":"https://api.github.com/repos/janl/mustache.js/issues/467","number":467,"state":"closed","locked":false,"title":"Throw error when providing .render() with invalid template type","user":{"login":"phillipj","id":1231635,"avatar_url":"https://avatars.githubusercontent.com/u/1231635?v=3","gravatar_id":"","url":"https://api.github.com/users/phillipj","html_url":"https://github.com/phillipj","followers_url":"https://api.github.com/users/phillipj/followers","following_url":"https://api.github.com/users/phillipj/following{/other_user}","gists_url":"https://api.github.com/users/phillipj/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipj/subscriptions","organizations_url":"https://api.github.com/users/phillipj/orgs","repos_url":"https://api.github.com/users/phillipj/repos","events_url":"https://api.github.com/users/phillipj/events{/privacy}","received_events_url":"https://api.github.com/users/phillipj/received_events","type":"User","site_admin":false},"body":"As we require the template to be a `string` we now throw an error when given any other data type. This should provide the developers with a meaningful error rather than a cryptic TypeError from the murky depths of our source code.\r\n\r\nFixes #464","created_at":"2015-06-24T17:48:14Z","updated_at":"2015-07-04T10:25:01Z","closed_at":"2015-07-04T10:25:01Z","merged_at":"2015-07-04T10:25:01Z","merge_commit_sha":"bd80059bce000aa318b5a961a667b9848041886b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/janl/mustache.js/pulls/467/commits","review_comments_url":"https://api.github.com/repos/janl/mustache.js/pulls/467/comments","review_comment_url":"https://api.github.com/repos/janl/mustache.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/janl/mustache.js/issues/467/comments","statuses_url":"https://api.github.com/repos/janl/mustache.js/statuses/a3f4339c655cdfdb3f16a0a539b0b47c639db264","head":{"label":"janl:feature/meaningful-type-error","ref":"feature/meaningful-type-error","sha":"a3f4339c655cdfdb3f16a0a539b0b47c639db264","user":{"login":"janl","id":11321,"avatar_url":"https://avatars.githubusercontent.com/u/11321?v=3","gravatar_id":"","url":"https://api.github.com/users/janl","html_url":"https://github.com/janl","followers_url":"https://api.github.com/users/janl/followers","following_url":"https://api.github.com/users/janl/following{/other_user}","gists_url":"https://api.github.com/users/janl/gists{/gist_id}","starred_url":"https://api.github.com/users/janl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janl/subscriptions","organizations_url":"https://api.github.com/users/janl/orgs","repos_url":"https://api.github.com/users/janl/repos","events_url":"https://api.github.com/users/janl/events{/privacy}","received_events_url":"https://api.github.com/users/janl/received_events","type":"User","site_admin":false},"repo":{"id":326688,"name":"mustache.js","full_name":"janl/mustache.js","owner":{"login":"janl","id":11321,"avatar_url":"https://avatars.githubusercontent.com/u/11321?v=3","gravatar_id":"","url":"https://api.github.com/users/janl","html_url":"https://github.com/janl","followers_url":"https://api.github.com/users/janl/followers","following_url":"https://api.github.com/users/janl/following{/other_user}","gists_url":"https://api.github.com/users/janl/gists{/gist_id}","starred_url":"https://api.github.com/users/janl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janl/subscriptions","organizations_url":"https://api.github.com/users/janl/orgs","repos_url":"https://api.github.com/users/janl/repos","events_url":"https://api.github.com/users/janl/events{/privacy}","received_events_url":"https://api.github.com/users/janl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janl/mustache.js","description":"Minimal templating with {{mustaches}} in JavaScript","fork":false,"url":"https://api.github.com/repos/janl/mustache.js","forks_url":"https://api.github.com/repos/janl/mustache.js/forks","keys_url":"https://api.github.com/repos/janl/mustache.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janl/mustache.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janl/mustache.js/teams","hooks_url":"https://api.github.com/repos/janl/mustache.js/hooks","issue_events_url":"https://api.github.com/repos/janl/mustache.js/issues/events{/number}","events_url":"https://api.github.com/repos/janl/mustache.js/events","assignees_url":"https://api.github.com/repos/janl/mustache.js/assignees{/user}","branches_url":"https://api.github.com/repos/janl/mustache.js/branches{/branch}","tags_url":"https://api.github.com/repos/janl/mustache.js/tags","blobs_url":"https://api.github.com/repos/janl/mustache.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janl/mustache.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janl/mustache.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/janl/mustache.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janl/mustache.js/statuses/{sha}","languages_url":"https://api.github.com/repos/janl/mustache.js/languages","stargazers_url":"https://api.github.com/repos/janl/mustache.js/stargazers","contributors_url":"https://api.github.com/repos/janl/mustache.js/contributors","subscribers_url":"https://api.github.com/repos/janl/mustache.js/subscribers","subscription_url":"https://api.github.com/repos/janl/mustache.js/subscription","commits_url":"https://api.github.com/repos/janl/mustache.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/janl/mustache.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/janl/mustache.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/janl/mustache.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/janl/mustache.js/contents/{+path}","compare_url":"https://api.github.com/repos/janl/mustache.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janl/mustache.js/merges","archive_url":"https://api.github.com/repos/janl/mustache.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janl/mustache.js/downloads","issues_url":"https://api.github.com/repos/janl/mustache.js/issues{/number}","pulls_url":"https://api.github.com/repos/janl/mustache.js/pulls{/number}","milestones_url":"https://api.github.com/repos/janl/mustache.js/milestones{/number}","notifications_url":"https://api.github.com/repos/janl/mustache.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janl/mustache.js/labels{/name}","releases_url":"https://api.github.com/repos/janl/mustache.js/releases{/id}","created_at":"2009-10-04T23:41:19Z","updated_at":"2015-07-04T02:56:51Z","pushed_at":"2015-07-04T10:25:01Z","git_url":"git://github.com/janl/mustache.js.git","ssh_url":"git@github.com:janl/mustache.js.git","clone_url":"https://github.com/janl/mustache.js.git","svn_url":"https://github.com/janl/mustache.js","homepage":"http://mustache.github.com/","size":3488,"stargazers_count":7922,"watchers_count":7922,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1619,"mirror_url":null,"open_issues_count":40,"forks":1619,"open_issues":40,"watchers":7922,"default_branch":"master"}},"base":{"label":"janl:master","ref":"master","sha":"55c1370a11a34403e804903f713ff76a0c549a40","user":{"login":"janl","id":11321,"avatar_url":"https://avatars.githubusercontent.com/u/11321?v=3","gravatar_id":"","url":"https://api.github.com/users/janl","html_url":"https://github.com/janl","followers_url":"https://api.github.com/users/janl/followers","following_url":"https://api.github.com/users/janl/following{/other_user}","gists_url":"https://api.github.com/users/janl/gists{/gist_id}","starred_url":"https://api.github.com/users/janl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janl/subscriptions","organizations_url":"https://api.github.com/users/janl/orgs","repos_url":"https://api.github.com/users/janl/repos","events_url":"https://api.github.com/users/janl/events{/privacy}","received_events_url":"https://api.github.com/users/janl/received_events","type":"User","site_admin":false},"repo":{"id":326688,"name":"mustache.js","full_name":"janl/mustache.js","owner":{"login":"janl","id":11321,"avatar_url":"https://avatars.githubusercontent.com/u/11321?v=3","gravatar_id":"","url":"https://api.github.com/users/janl","html_url":"https://github.com/janl","followers_url":"https://api.github.com/users/janl/followers","following_url":"https://api.github.com/users/janl/following{/other_user}","gists_url":"https://api.github.com/users/janl/gists{/gist_id}","starred_url":"https://api.github.com/users/janl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janl/subscriptions","organizations_url":"https://api.github.com/users/janl/orgs","repos_url":"https://api.github.com/users/janl/repos","events_url":"https://api.github.com/users/janl/events{/privacy}","received_events_url":"https://api.github.com/users/janl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janl/mustache.js","description":"Minimal templating with {{mustaches}} in JavaScript","fork":false,"url":"https://api.github.com/repos/janl/mustache.js","forks_url":"https://api.github.com/repos/janl/mustache.js/forks","keys_url":"https://api.github.com/repos/janl/mustache.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janl/mustache.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janl/mustache.js/teams","hooks_url":"https://api.github.com/repos/janl/mustache.js/hooks","issue_events_url":"https://api.github.com/repos/janl/mustache.js/issues/events{/number}","events_url":"https://api.github.com/repos/janl/mustache.js/events","assignees_url":"https://api.github.com/repos/janl/mustache.js/assignees{/user}","branches_url":"https://api.github.com/repos/janl/mustache.js/branches{/branch}","tags_url":"https://api.github.com/repos/janl/mustache.js/tags","blobs_url":"https://api.github.com/repos/janl/mustache.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janl/mustache.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janl/mustache.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/janl/mustache.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janl/mustache.js/statuses/{sha}","languages_url":"https://api.github.com/repos/janl/mustache.js/languages","stargazers_url":"https://api.github.com/repos/janl/mustache.js/stargazers","contributors_url":"https://api.github.com/repos/janl/mustache.js/contributors","subscribers_url":"https://api.github.com/repos/janl/mustache.js/subscribers","subscription_url":"https://api.github.com/repos/janl/mustache.js/subscription","commits_url":"https://api.github.com/repos/janl/mustache.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/janl/mustache.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/janl/mustache.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/janl/mustache.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/janl/mustache.js/contents/{+path}","compare_url":"https://api.github.com/repos/janl/mustache.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janl/mustache.js/merges","archive_url":"https://api.github.com/repos/janl/mustache.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janl/mustache.js/downloads","issues_url":"https://api.github.com/repos/janl/mustache.js/issues{/number}","pulls_url":"https://api.github.com/repos/janl/mustache.js/pulls{/number}","milestones_url":"https://api.github.com/repos/janl/mustache.js/milestones{/number}","notifications_url":"https://api.github.com/repos/janl/mustache.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janl/mustache.js/labels{/name}","releases_url":"https://api.github.com/repos/janl/mustache.js/releases{/id}","created_at":"2009-10-04T23:41:19Z","updated_at":"2015-07-04T02:56:51Z","pushed_at":"2015-07-04T10:25:01Z","git_url":"git://github.com/janl/mustache.js.git","ssh_url":"git@github.com:janl/mustache.js.git","clone_url":"https://github.com/janl/mustache.js.git","svn_url":"https://github.com/janl/mustache.js","homepage":"http://mustache.github.com/","size":3488,"stargazers_count":7922,"watchers_count":7922,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1619,"mirror_url":null,"open_issues_count":40,"forks":1619,"open_issues":40,"watchers":7922,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/janl/mustache.js/pulls/467"},"html":{"href":"https://github.com/janl/mustache.js/pull/467"},"issue":{"href":"https://api.github.com/repos/janl/mustache.js/issues/467"},"comments":{"href":"https://api.github.com/repos/janl/mustache.js/issues/467/comments"},"review_comments":{"href":"https://api.github.com/repos/janl/mustache.js/pulls/467/comments"},"review_comment":{"href":"https://api.github.com/repos/janl/mustache.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/janl/mustache.js/pulls/467/commits"},"statuses":{"href":"https://api.github.com/repos/janl/mustache.js/statuses/a3f4339c655cdfdb3f16a0a539b0b47c639db264"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"phillipj","id":1231635,"avatar_url":"https://avatars.githubusercontent.com/u/1231635?v=3","gravatar_id":"","url":"https://api.github.com/users/phillipj","html_url":"https://github.com/phillipj","followers_url":"https://api.github.com/users/phillipj/followers","following_url":"https://api.github.com/users/phillipj/following{/other_user}","gists_url":"https://api.github.com/users/phillipj/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipj/subscriptions","organizations_url":"https://api.github.com/users/phillipj/orgs","repos_url":"https://api.github.com/users/phillipj/repos","events_url":"https://api.github.com/users/phillipj/events{/privacy}","received_events_url":"https://api.github.com/users/phillipj/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":28,"deletions":0,"changed_files":3}}