{"action":"created","issue":{"url":"https://api.github.com/repos/ripple/rippled/issues/1389","labels_url":"https://api.github.com/repos/ripple/rippled/issues/1389/labels{/name}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/1389/comments","events_url":"https://api.github.com/repos/ripple/rippled/issues/1389/events","html_url":"https://github.com/ripple/rippled/pull/1389","id":115944328,"number":1389,"title":"Improve ledger close timing","user":{"login":"JoelKatz","id":877549,"avatar_url":"https://avatars.githubusercontent.com/u/877549?v=3","gravatar_id":"","url":"https://api.github.com/users/JoelKatz","html_url":"https://github.com/JoelKatz","followers_url":"https://api.github.com/users/JoelKatz/followers","following_url":"https://api.github.com/users/JoelKatz/following{/other_user}","gists_url":"https://api.github.com/users/JoelKatz/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelKatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelKatz/subscriptions","organizations_url":"https://api.github.com/users/JoelKatz/orgs","repos_url":"https://api.github.com/users/JoelKatz/repos","events_url":"https://api.github.com/users/JoelKatz/events{/privacy}","received_events_url":"https://api.github.com/users/JoelKatz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ripple/rippled/labels/Howard","name":"Howard","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Nik","name":"Nik","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Passed","name":"Passed","color":"009800"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Rebase","name":"Rebase","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-09T19:13:10Z","updated_at":"2015-11-16T21:46:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/1389","html_url":"https://github.com/ripple/rippled/pull/1389","diff_url":"https://github.com/ripple/rippled/pull/1389.diff","patch_url":"https://github.com/ripple/rippled/pull/1389.patch"},"body":"Do not rely on the rounded close time to enforce the minimum ledger open time. Ensure we close the ledger if we have evidence other validators we trust have closed the ledger. Lead the pack in closing the ledger based on how long we observed the ledger to be open."},"comment":{"url":"https://api.github.com/repos/ripple/rippled/issues/comments/157180462","html_url":"https://github.com/ripple/rippled/pull/1389#issuecomment-157180462","issue_url":"https://api.github.com/repos/ripple/rippled/issues/1389","id":157180462,"user":{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"created_at":"2015-11-16T21:46:05Z","updated_at":"2015-11-16T21:46:05Z","body":"Looks good, and I understand it. I left a minor suggestion above, and this definitely needs to be rebased before it can be merged. Otherwise, :+1: "}}