{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/czos/goamz/pulls/7","id":27699639,"html_url":"https://github.com/czos/goamz/pull/7","diff_url":"https://github.com/czos/goamz/pull/7.diff","patch_url":"https://github.com/czos/goamz/pull/7.patch","issue_url":"https://api.github.com/repos/czos/goamz/issues/7","number":7,"state":"closed","locked":false,"title":"Support timeout based retry","user":{"login":"vgarg","id":520195,"avatar_url":"https://avatars.githubusercontent.com/u/520195?v=3","gravatar_id":"","url":"https://api.github.com/users/vgarg","html_url":"https://github.com/vgarg","followers_url":"https://api.github.com/users/vgarg/followers","following_url":"https://api.github.com/users/vgarg/following{/other_user}","gists_url":"https://api.github.com/users/vgarg/gists{/gist_id}","starred_url":"https://api.github.com/users/vgarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgarg/subscriptions","organizations_url":"https://api.github.com/users/vgarg/orgs","repos_url":"https://api.github.com/users/vgarg/repos","events_url":"https://api.github.com/users/vgarg/events{/privacy}","received_events_url":"https://api.github.com/users/vgarg/received_events","type":"User","site_admin":false},"body":"The AWS RetryingHttpClient currently supports retrying upon network errors and server errors for a fixed number of re-tries. With this approach, especially with exponential backoff, it is hard to know in total for how long requests may be re-tried. It is more useful to be able to say that a request should be re-tried upon error for 120 seconds\r\n\r\nThis pull request changes the client.go implementation to support a time duration as the retry timeout. In addition it also exposes the min and max wait durations for finer control.\r\n\r\nThe changes keep sane defaults. Clients are expected to create their own ResilientTransport instances to tweak various timeouts and behaviors.\r\n\r\nThis change depends on another Pull Request #6 for supporting leveled logging.\r\n\r\n@wes-r please review.","created_at":"2015-01-20T18:18:29Z","updated_at":"2015-01-23T18:37:35Z","closed_at":"2015-01-23T18:37:35Z","merged_at":"2015-01-23T18:37:35Z","merge_commit_sha":"4753968dcae82fec603798db086a305c3179387c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/czos/goamz/pulls/7/commits","review_comments_url":"https://api.github.com/repos/czos/goamz/pulls/7/comments","review_comment_url":"https://api.github.com/repos/czos/goamz/pulls/comments/{number}","comments_url":"https://api.github.com/repos/czos/goamz/issues/7/comments","statuses_url":"https://api.github.com/repos/czos/goamz/statuses/e4e88f4e3a31e471183d43432521792b11da8563","head":{"label":"czos:5xx_retries","ref":"5xx_retries","sha":"e4e88f4e3a31e471183d43432521792b11da8563","user":{"login":"czos","id":8302800,"avatar_url":"https://avatars.githubusercontent.com/u/8302800?v=3","gravatar_id":"","url":"https://api.github.com/users/czos","html_url":"https://github.com/czos","followers_url":"https://api.github.com/users/czos/followers","following_url":"https://api.github.com/users/czos/following{/other_user}","gists_url":"https://api.github.com/users/czos/gists{/gist_id}","starred_url":"https://api.github.com/users/czos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czos/subscriptions","organizations_url":"https://api.github.com/users/czos/orgs","repos_url":"https://api.github.com/users/czos/repos","events_url":"https://api.github.com/users/czos/events{/privacy}","received_events_url":"https://api.github.com/users/czos/received_events","type":"Organization","site_admin":false},"repo":{"id":22401911,"name":"goamz","full_name":"czos/goamz","owner":{"login":"czos","id":8302800,"avatar_url":"https://avatars.githubusercontent.com/u/8302800?v=3","gravatar_id":"","url":"https://api.github.com/users/czos","html_url":"https://github.com/czos","followers_url":"https://api.github.com/users/czos/followers","following_url":"https://api.github.com/users/czos/following{/other_user}","gists_url":"https://api.github.com/users/czos/gists{/gist_id}","starred_url":"https://api.github.com/users/czos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czos/subscriptions","organizations_url":"https://api.github.com/users/czos/orgs","repos_url":"https://api.github.com/users/czos/repos","events_url":"https://api.github.com/users/czos/events{/privacy}","received_events_url":"https://api.github.com/users/czos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/czos/goamz","description":"Amazon Library for Go","fork":true,"url":"https://api.github.com/repos/czos/goamz","forks_url":"https://api.github.com/repos/czos/goamz/forks","keys_url":"https://api.github.com/repos/czos/goamz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/czos/goamz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/czos/goamz/teams","hooks_url":"https://api.github.com/repos/czos/goamz/hooks","issue_events_url":"https://api.github.com/repos/czos/goamz/issues/events{/number}","events_url":"https://api.github.com/repos/czos/goamz/events","assignees_url":"https://api.github.com/repos/czos/goamz/assignees{/user}","branches_url":"https://api.github.com/repos/czos/goamz/branches{/branch}","tags_url":"https://api.github.com/repos/czos/goamz/tags","blobs_url":"https://api.github.com/repos/czos/goamz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/czos/goamz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/czos/goamz/git/refs{/sha}","trees_url":"https://api.github.com/repos/czos/goamz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/czos/goamz/statuses/{sha}","languages_url":"https://api.github.com/repos/czos/goamz/languages","stargazers_url":"https://api.github.com/repos/czos/goamz/stargazers","contributors_url":"https://api.github.com/repos/czos/goamz/contributors","subscribers_url":"https://api.github.com/repos/czos/goamz/subscribers","subscription_url":"https://api.github.com/repos/czos/goamz/subscription","commits_url":"https://api.github.com/repos/czos/goamz/commits{/sha}","git_commits_url":"https://api.github.com/repos/czos/goamz/git/commits{/sha}","comments_url":"https://api.github.com/repos/czos/goamz/comments{/number}","issue_comment_url":"https://api.github.com/repos/czos/goamz/issues/comments/{number}","contents_url":"https://api.github.com/repos/czos/goamz/contents/{+path}","compare_url":"https://api.github.com/repos/czos/goamz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/czos/goamz/merges","archive_url":"https://api.github.com/repos/czos/goamz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/czos/goamz/downloads","issues_url":"https://api.github.com/repos/czos/goamz/issues{/number}","pulls_url":"https://api.github.com/repos/czos/goamz/pulls{/number}","milestones_url":"https://api.github.com/repos/czos/goamz/milestones{/number}","notifications_url":"https://api.github.com/repos/czos/goamz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/czos/goamz/labels{/name}","releases_url":"https://api.github.com/repos/czos/goamz/releases{/id}","created_at":"2014-07-30T00:42:20Z","updated_at":"2015-01-23T18:37:35Z","pushed_at":"2015-01-23T18:37:35Z","git_url":"git://github.com/czos/goamz.git","ssh_url":"git@github.com:czos/goamz.git","clone_url":"https://github.com/czos/goamz.git","svn_url":"https://github.com/czos/goamz","homepage":null,"size":1110,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"czos:master","ref":"master","sha":"15af6f659d12079f3abb93057aa5d180f884ae58","user":{"login":"czos","id":8302800,"avatar_url":"https://avatars.githubusercontent.com/u/8302800?v=3","gravatar_id":"","url":"https://api.github.com/users/czos","html_url":"https://github.com/czos","followers_url":"https://api.github.com/users/czos/followers","following_url":"https://api.github.com/users/czos/following{/other_user}","gists_url":"https://api.github.com/users/czos/gists{/gist_id}","starred_url":"https://api.github.com/users/czos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czos/subscriptions","organizations_url":"https://api.github.com/users/czos/orgs","repos_url":"https://api.github.com/users/czos/repos","events_url":"https://api.github.com/users/czos/events{/privacy}","received_events_url":"https://api.github.com/users/czos/received_events","type":"Organization","site_admin":false},"repo":{"id":22401911,"name":"goamz","full_name":"czos/goamz","owner":{"login":"czos","id":8302800,"avatar_url":"https://avatars.githubusercontent.com/u/8302800?v=3","gravatar_id":"","url":"https://api.github.com/users/czos","html_url":"https://github.com/czos","followers_url":"https://api.github.com/users/czos/followers","following_url":"https://api.github.com/users/czos/following{/other_user}","gists_url":"https://api.github.com/users/czos/gists{/gist_id}","starred_url":"https://api.github.com/users/czos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czos/subscriptions","organizations_url":"https://api.github.com/users/czos/orgs","repos_url":"https://api.github.com/users/czos/repos","events_url":"https://api.github.com/users/czos/events{/privacy}","received_events_url":"https://api.github.com/users/czos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/czos/goamz","description":"Amazon Library for Go","fork":true,"url":"https://api.github.com/repos/czos/goamz","forks_url":"https://api.github.com/repos/czos/goamz/forks","keys_url":"https://api.github.com/repos/czos/goamz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/czos/goamz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/czos/goamz/teams","hooks_url":"https://api.github.com/repos/czos/goamz/hooks","issue_events_url":"https://api.github.com/repos/czos/goamz/issues/events{/number}","events_url":"https://api.github.com/repos/czos/goamz/events","assignees_url":"https://api.github.com/repos/czos/goamz/assignees{/user}","branches_url":"https://api.github.com/repos/czos/goamz/branches{/branch}","tags_url":"https://api.github.com/repos/czos/goamz/tags","blobs_url":"https://api.github.com/repos/czos/goamz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/czos/goamz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/czos/goamz/git/refs{/sha}","trees_url":"https://api.github.com/repos/czos/goamz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/czos/goamz/statuses/{sha}","languages_url":"https://api.github.com/repos/czos/goamz/languages","stargazers_url":"https://api.github.com/repos/czos/goamz/stargazers","contributors_url":"https://api.github.com/repos/czos/goamz/contributors","subscribers_url":"https://api.github.com/repos/czos/goamz/subscribers","subscription_url":"https://api.github.com/repos/czos/goamz/subscription","commits_url":"https://api.github.com/repos/czos/goamz/commits{/sha}","git_commits_url":"https://api.github.com/repos/czos/goamz/git/commits{/sha}","comments_url":"https://api.github.com/repos/czos/goamz/comments{/number}","issue_comment_url":"https://api.github.com/repos/czos/goamz/issues/comments/{number}","contents_url":"https://api.github.com/repos/czos/goamz/contents/{+path}","compare_url":"https://api.github.com/repos/czos/goamz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/czos/goamz/merges","archive_url":"https://api.github.com/repos/czos/goamz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/czos/goamz/downloads","issues_url":"https://api.github.com/repos/czos/goamz/issues{/number}","pulls_url":"https://api.github.com/repos/czos/goamz/pulls{/number}","milestones_url":"https://api.github.com/repos/czos/goamz/milestones{/number}","notifications_url":"https://api.github.com/repos/czos/goamz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/czos/goamz/labels{/name}","releases_url":"https://api.github.com/repos/czos/goamz/releases{/id}","created_at":"2014-07-30T00:42:20Z","updated_at":"2015-01-23T18:37:35Z","pushed_at":"2015-01-23T18:37:35Z","git_url":"git://github.com/czos/goamz.git","ssh_url":"git@github.com:czos/goamz.git","clone_url":"https://github.com/czos/goamz.git","svn_url":"https://github.com/czos/goamz","homepage":null,"size":1110,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/czos/goamz/pulls/7"},"html":{"href":"https://github.com/czos/goamz/pull/7"},"issue":{"href":"https://api.github.com/repos/czos/goamz/issues/7"},"comments":{"href":"https://api.github.com/repos/czos/goamz/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/czos/goamz/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/czos/goamz/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/czos/goamz/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/czos/goamz/statuses/e4e88f4e3a31e471183d43432521792b11da8563"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vgarg","id":520195,"avatar_url":"https://avatars.githubusercontent.com/u/520195?v=3","gravatar_id":"","url":"https://api.github.com/users/vgarg","html_url":"https://github.com/vgarg","followers_url":"https://api.github.com/users/vgarg/followers","following_url":"https://api.github.com/users/vgarg/following{/other_user}","gists_url":"https://api.github.com/users/vgarg/gists{/gist_id}","starred_url":"https://api.github.com/users/vgarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgarg/subscriptions","organizations_url":"https://api.github.com/users/vgarg/orgs","repos_url":"https://api.github.com/users/vgarg/repos","events_url":"https://api.github.com/users/vgarg/events{/privacy}","received_events_url":"https://api.github.com/users/vgarg/received_events","type":"User","site_admin":false},"comments":1,"review_comments":7,"commits":6,"additions":94,"deletions":22,"changed_files":2}}