{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/24711741","id":24711741,"diff_hunk":"@@ -108,47 +131,59 @@ void CEXIAgp::SaveFileFromEEPROM(const std::string& filename)\n \tFile::IOFile pStream(filename, \"wb\");\n \tif (pStream)\n \t{\n-\t\tpStream.WriteBytes(m_eeprom.data(), m_eeprom_size);\n+\t\tif ((m_eeprom_size == 512) || (m_eeprom_size == 8192))\n+\t\t{\n+\t\t\t// Handle endian write - could be done with byte access in 0xAE commands instead\n+\t\t\tstd::vector<u8> temp_eeprom;\n+\t\t\ttemp_eeprom.resize(m_eeprom_size);","path":"Source/Core/Core/HW/EXI_DeviceAGP.cpp","position":50,"original_position":50,"commit_id":"8c55f43d698c929721f6fa40f3a21db2ccc5aa90","original_commit_id":"8c55f43d698c929721f6fa40f3a21db2ccc5aa90","user":{"login":"lioncash","id":712067,"avatar_url":"https://avatars.githubusercontent.com/u/712067?v=3","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"body":"`std::vector<u8> temp_eeprom(m_eeprom_size);`","created_at":"2015-02-14T03:35:32Z","updated_at":"2015-02-14T03:35:32Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/2045#discussion_r24711741","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2045","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/24711741"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/2045#discussion_r24711741"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2045"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2045","id":29261803,"html_url":"https://github.com/dolphin-emu/dolphin/pull/2045","diff_url":"https://github.com/dolphin-emu/dolphin/pull/2045.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/2045.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2045","number":2045,"state":"open","locked":false,"title":"Add Datel AGP save commands for SRAM/FRAM.  Improve EEPROM.","user":{"login":"greyrogue","id":10587275,"avatar_url":"https://avatars.githubusercontent.com/u/10587275?v=3","gravatar_id":"","url":"https://api.github.com/users/greyrogue","html_url":"https://github.com/greyrogue","followers_url":"https://api.github.com/users/greyrogue/followers","following_url":"https://api.github.com/users/greyrogue/following{/other_user}","gists_url":"https://api.github.com/users/greyrogue/gists{/gist_id}","starred_url":"https://api.github.com/users/greyrogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greyrogue/subscriptions","organizations_url":"https://api.github.com/users/greyrogue/orgs","repos_url":"https://api.github.com/users/greyrogue/repos","events_url":"https://api.github.com/users/greyrogue/events{/privacy}","received_events_url":"https://api.github.com/users/greyrogue/received_events","type":"User","site_admin":false},"body":"This adds initial support for the 0xAE04 and 0xAE07 commands of the AGP (doesn't include Flash ROM).","created_at":"2015-02-13T12:46:18Z","updated_at":"2015-02-14T03:35:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c0201d077c6ba3b08ab6915a0048b47b9252575","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2045/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2045/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2045/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/8c55f43d698c929721f6fa40f3a21db2ccc5aa90","head":{"label":"greyrogue:master","ref":"master","sha":"8c55f43d698c929721f6fa40f3a21db2ccc5aa90","user":{"login":"greyrogue","id":10587275,"avatar_url":"https://avatars.githubusercontent.com/u/10587275?v=3","gravatar_id":"","url":"https://api.github.com/users/greyrogue","html_url":"https://github.com/greyrogue","followers_url":"https://api.github.com/users/greyrogue/followers","following_url":"https://api.github.com/users/greyrogue/following{/other_user}","gists_url":"https://api.github.com/users/greyrogue/gists{/gist_id}","starred_url":"https://api.github.com/users/greyrogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greyrogue/subscriptions","organizations_url":"https://api.github.com/users/greyrogue/orgs","repos_url":"https://api.github.com/users/greyrogue/repos","events_url":"https://api.github.com/users/greyrogue/events{/privacy}","received_events_url":"https://api.github.com/users/greyrogue/received_events","type":"User","site_admin":false},"repo":{"id":30755603,"name":"dolphin","full_name":"greyrogue/dolphin","owner":{"login":"greyrogue","id":10587275,"avatar_url":"https://avatars.githubusercontent.com/u/10587275?v=3","gravatar_id":"","url":"https://api.github.com/users/greyrogue","html_url":"https://github.com/greyrogue","followers_url":"https://api.github.com/users/greyrogue/followers","following_url":"https://api.github.com/users/greyrogue/following{/other_user}","gists_url":"https://api.github.com/users/greyrogue/gists{/gist_id}","starred_url":"https://api.github.com/users/greyrogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greyrogue/subscriptions","organizations_url":"https://api.github.com/users/greyrogue/orgs","repos_url":"https://api.github.com/users/greyrogue/repos","events_url":"https://api.github.com/users/greyrogue/events{/privacy}","received_events_url":"https://api.github.com/users/greyrogue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greyrogue/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/greyrogue/dolphin","forks_url":"https://api.github.com/repos/greyrogue/dolphin/forks","keys_url":"https://api.github.com/repos/greyrogue/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greyrogue/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greyrogue/dolphin/teams","hooks_url":"https://api.github.com/repos/greyrogue/dolphin/hooks","issue_events_url":"https://api.github.com/repos/greyrogue/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/greyrogue/dolphin/events","assignees_url":"https://api.github.com/repos/greyrogue/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/greyrogue/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/greyrogue/dolphin/tags","blobs_url":"https://api.github.com/repos/greyrogue/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greyrogue/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greyrogue/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/greyrogue/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greyrogue/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/greyrogue/dolphin/languages","stargazers_url":"https://api.github.com/repos/greyrogue/dolphin/stargazers","contributors_url":"https://api.github.com/repos/greyrogue/dolphin/contributors","subscribers_url":"https://api.github.com/repos/greyrogue/dolphin/subscribers","subscription_url":"https://api.github.com/repos/greyrogue/dolphin/subscription","commits_url":"https://api.github.com/repos/greyrogue/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/greyrogue/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/greyrogue/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/greyrogue/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/greyrogue/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/greyrogue/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greyrogue/dolphin/merges","archive_url":"https://api.github.com/repos/greyrogue/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greyrogue/dolphin/downloads","issues_url":"https://api.github.com/repos/greyrogue/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/greyrogue/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/greyrogue/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/greyrogue/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greyrogue/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/greyrogue/dolphin/releases{/id}","created_at":"2015-02-13T12:33:03Z","updated_at":"2015-02-14T03:25:42Z","pushed_at":"2015-02-14T03:25:41Z","git_url":"git://github.com/greyrogue/dolphin.git","ssh_url":"git@github.com:greyrogue/dolphin.git","clone_url":"https://github.com/greyrogue/dolphin.git","svn_url":"https://github.com/greyrogue/dolphin","homepage":"https://dolphin-emu.org/","size":213778,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"61b19bda3e82b0ed0da4c7a1fabfcf939b0a2ecb","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-02-14T02:46:08Z","pushed_at":"2015-02-14T02:46:07Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":276585,"stargazers_count":1062,"watchers_count":1062,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":332,"mirror_url":null,"open_issues_count":72,"forks":332,"open_issues":72,"watchers":1062,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2045"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/2045"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2045"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2045/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2045/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2045/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/8c55f43d698c929721f6fa40f3a21db2ccc5aa90"}}}}