{"action":"created","comment":{"url":"https://api.github.com/repos/tomcroft/tantrum_elastic/pulls/comments/38277084","id":38277084,"diff_hunk":"@@ -56,11 +57,11 @@ public function getIterator()\n         $documents = $this->createDocuments();\n         $collection = $this->element->buildFromArray($documents);\n         foreach ($collection as $key => $document) {\n-            self::assertTrue($document instanceof Lib\\Document);\n+            self::assertTrue($document instanceof Document);\n         }\n     }\n \n-    /**\n+    /**searchtest","path":"tests/Lib/DocumentCollectionTest.php","position":44,"original_position":44,"commit_id":"41719e59d6951c49212eb034be9c88ee274d7246","original_commit_id":"41719e59d6951c49212eb034be9c88ee274d7246","user":{"login":"TomChaton","id":1395724,"avatar_url":"https://avatars.githubusercontent.com/u/1395724?v=3","gravatar_id":"","url":"https://api.github.com/users/TomChaton","html_url":"https://github.com/TomChaton","followers_url":"https://api.github.com/users/TomChaton/followers","following_url":"https://api.github.com/users/TomChaton/following{/other_user}","gists_url":"https://api.github.com/users/TomChaton/gists{/gist_id}","starred_url":"https://api.github.com/users/TomChaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomChaton/subscriptions","organizations_url":"https://api.github.com/users/TomChaton/orgs","repos_url":"https://api.github.com/users/TomChaton/repos","events_url":"https://api.github.com/users/TomChaton/events{/privacy}","received_events_url":"https://api.github.com/users/TomChaton/received_events","type":"User","site_admin":false},"body":":+1: It looks very much like it. Perhaps I was considering using the @group annotation. Either way, it's going :)","created_at":"2015-08-30T22:52:04Z","updated_at":"2015-08-30T22:52:04Z","html_url":"https://github.com/tomcroft/tantrum_elastic/pull/89#discussion_r38277084","pull_request_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/pulls/89","_links":{"self":{"href":"https://api.github.com/repos/tomcroft/tantrum_elastic/pulls/comments/38277084"},"html":{"href":"https://github.com/tomcroft/tantrum_elastic/pull/89#discussion_r38277084"},"pull_request":{"href":"https://api.github.com/repos/tomcroft/tantrum_elastic/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/tomcroft/tantrum_elastic/pulls/89","id":42724850,"html_url":"https://github.com/tomcroft/tantrum_elastic/pull/89","diff_url":"https://github.com/tomcroft/tantrum_elastic/pull/89.diff","patch_url":"https://github.com/tomcroft/tantrum_elastic/pull/89.patch","issue_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/issues/89","number":89,"state":"open","locked":false,"title":"Refactor Element and jsonSerialize","user":{"login":"TomChaton","id":1395724,"avatar_url":"https://avatars.githubusercontent.com/u/1395724?v=3","gravatar_id":"","url":"https://api.github.com/users/TomChaton","html_url":"https://github.com/TomChaton","followers_url":"https://api.github.com/users/TomChaton/followers","following_url":"https://api.github.com/users/TomChaton/following{/other_user}","gists_url":"https://api.github.com/users/TomChaton/gists{/gist_id}","starred_url":"https://api.github.com/users/TomChaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomChaton/subscriptions","organizations_url":"https://api.github.com/users/TomChaton/orgs","repos_url":"https://api.github.com/users/TomChaton/repos","events_url":"https://api.github.com/users/TomChaton/events{/privacy}","received_events_url":"https://api.github.com/users/TomChaton/received_events","type":"User","site_admin":false},"body":"* jsonSerialize now resides on the base Element class only\r\n* Simplified how objects are built in Element\r\n* Unless the getElementName method is overloaded, the element class names are snake cased and used for object keys\r\n* Arranging elements and options can still be done in decendant classes\r\n* Some unpleasant complexity added for the Sort object /from &  size options\r\n     - Sort ought to be a property of the search query, however it is on the same level as the query\r\n     - Introduced external objects and external elements to facilitate this\r\n     - external objects and elements are set on an object, but then fetched by the containing element and adopted\r\n* Fixed some namespacing issues in Exceptions","created_at":"2015-08-18T17:21:27Z","updated_at":"2015-08-30T22:52:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68b07f19eb238eab42addfac1162f23f20eb5324","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/pulls/89/commits","review_comments_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/pulls/89/comments","review_comment_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/issues/89/comments","statuses_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/statuses/41719e59d6951c49212eb034be9c88ee274d7246","head":{"label":"tomcroft:SimplifyJsonEncoding","ref":"SimplifyJsonEncoding","sha":"41719e59d6951c49212eb034be9c88ee274d7246","user":{"login":"tomcroft","id":9104702,"avatar_url":"https://avatars.githubusercontent.com/u/9104702?v=3","gravatar_id":"","url":"https://api.github.com/users/tomcroft","html_url":"https://github.com/tomcroft","followers_url":"https://api.github.com/users/tomcroft/followers","following_url":"https://api.github.com/users/tomcroft/following{/other_user}","gists_url":"https://api.github.com/users/tomcroft/gists{/gist_id}","starred_url":"https://api.github.com/users/tomcroft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomcroft/subscriptions","organizations_url":"https://api.github.com/users/tomcroft/orgs","repos_url":"https://api.github.com/users/tomcroft/repos","events_url":"https://api.github.com/users/tomcroft/events{/privacy}","received_events_url":"https://api.github.com/users/tomcroft/received_events","type":"Organization","site_admin":false},"repo":{"id":38216561,"name":"tantrum_elastic","full_name":"tomcroft/tantrum_elastic","owner":{"login":"tomcroft","id":9104702,"avatar_url":"https://avatars.githubusercontent.com/u/9104702?v=3","gravatar_id":"","url":"https://api.github.com/users/tomcroft","html_url":"https://github.com/tomcroft","followers_url":"https://api.github.com/users/tomcroft/followers","following_url":"https://api.github.com/users/tomcroft/following{/other_user}","gists_url":"https://api.github.com/users/tomcroft/gists{/gist_id}","starred_url":"https://api.github.com/users/tomcroft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomcroft/subscriptions","organizations_url":"https://api.github.com/users/tomcroft/orgs","repos_url":"https://api.github.com/users/tomcroft/repos","events_url":"https://api.github.com/users/tomcroft/events{/privacy}","received_events_url":"https://api.github.com/users/tomcroft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tomcroft/tantrum_elastic","description":"PHP client library for elastic search","fork":false,"url":"https://api.github.com/repos/tomcroft/tantrum_elastic","forks_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/forks","keys_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/teams","hooks_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/hooks","issue_events_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/issues/events{/number}","events_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/events","assignees_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/assignees{/user}","branches_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/branches{/branch}","tags_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/tags","blobs_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/statuses/{sha}","languages_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/languages","stargazers_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/stargazers","contributors_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/contributors","subscribers_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/subscribers","subscription_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/subscription","commits_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/contents/{+path}","compare_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/merges","archive_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/downloads","issues_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/issues{/number}","pulls_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/pulls{/number}","milestones_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/milestones{/number}","notifications_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/labels{/name}","releases_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/releases{/id}","created_at":"2015-06-28T22:26:35Z","updated_at":"2015-07-07T10:16:02Z","pushed_at":"2015-08-29T21:12:08Z","git_url":"git://github.com/tomcroft/tantrum_elastic.git","ssh_url":"git@github.com:tomcroft/tantrum_elastic.git","clone_url":"https://github.com/tomcroft/tantrum_elastic.git","svn_url":"https://github.com/tomcroft/tantrum_elastic","homepage":null,"size":532,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":63,"forks":2,"open_issues":63,"watchers":0,"default_branch":"dev"}},"base":{"label":"tomcroft:dev","ref":"dev","sha":"3b0cf1de67ed26e02b6efd0b560ccfc8fd5d53dc","user":{"login":"tomcroft","id":9104702,"avatar_url":"https://avatars.githubusercontent.com/u/9104702?v=3","gravatar_id":"","url":"https://api.github.com/users/tomcroft","html_url":"https://github.com/tomcroft","followers_url":"https://api.github.com/users/tomcroft/followers","following_url":"https://api.github.com/users/tomcroft/following{/other_user}","gists_url":"https://api.github.com/users/tomcroft/gists{/gist_id}","starred_url":"https://api.github.com/users/tomcroft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomcroft/subscriptions","organizations_url":"https://api.github.com/users/tomcroft/orgs","repos_url":"https://api.github.com/users/tomcroft/repos","events_url":"https://api.github.com/users/tomcroft/events{/privacy}","received_events_url":"https://api.github.com/users/tomcroft/received_events","type":"Organization","site_admin":false},"repo":{"id":38216561,"name":"tantrum_elastic","full_name":"tomcroft/tantrum_elastic","owner":{"login":"tomcroft","id":9104702,"avatar_url":"https://avatars.githubusercontent.com/u/9104702?v=3","gravatar_id":"","url":"https://api.github.com/users/tomcroft","html_url":"https://github.com/tomcroft","followers_url":"https://api.github.com/users/tomcroft/followers","following_url":"https://api.github.com/users/tomcroft/following{/other_user}","gists_url":"https://api.github.com/users/tomcroft/gists{/gist_id}","starred_url":"https://api.github.com/users/tomcroft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomcroft/subscriptions","organizations_url":"https://api.github.com/users/tomcroft/orgs","repos_url":"https://api.github.com/users/tomcroft/repos","events_url":"https://api.github.com/users/tomcroft/events{/privacy}","received_events_url":"https://api.github.com/users/tomcroft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tomcroft/tantrum_elastic","description":"PHP client library for elastic search","fork":false,"url":"https://api.github.com/repos/tomcroft/tantrum_elastic","forks_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/forks","keys_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/teams","hooks_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/hooks","issue_events_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/issues/events{/number}","events_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/events","assignees_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/assignees{/user}","branches_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/branches{/branch}","tags_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/tags","blobs_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/statuses/{sha}","languages_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/languages","stargazers_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/stargazers","contributors_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/contributors","subscribers_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/subscribers","subscription_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/subscription","commits_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/contents/{+path}","compare_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/merges","archive_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/downloads","issues_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/issues{/number}","pulls_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/pulls{/number}","milestones_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/milestones{/number}","notifications_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/labels{/name}","releases_url":"https://api.github.com/repos/tomcroft/tantrum_elastic/releases{/id}","created_at":"2015-06-28T22:26:35Z","updated_at":"2015-07-07T10:16:02Z","pushed_at":"2015-08-29T21:12:08Z","git_url":"git://github.com/tomcroft/tantrum_elastic.git","ssh_url":"git@github.com:tomcroft/tantrum_elastic.git","clone_url":"https://github.com/tomcroft/tantrum_elastic.git","svn_url":"https://github.com/tomcroft/tantrum_elastic","homepage":null,"size":532,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":63,"forks":2,"open_issues":63,"watchers":0,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/tomcroft/tantrum_elastic/pulls/89"},"html":{"href":"https://github.com/tomcroft/tantrum_elastic/pull/89"},"issue":{"href":"https://api.github.com/repos/tomcroft/tantrum_elastic/issues/89"},"comments":{"href":"https://api.github.com/repos/tomcroft/tantrum_elastic/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/tomcroft/tantrum_elastic/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/tomcroft/tantrum_elastic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tomcroft/tantrum_elastic/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/tomcroft/tantrum_elastic/statuses/41719e59d6951c49212eb034be9c88ee274d7246"}}}}