{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/7065","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/7065/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/7065/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/7065/events","html_url":"https://github.com/edx/edx-platform/pull/7065","id":58579696,"number":7065,"title":"SOL-143 course announcements notifications","user":{"login":"muhhshoaib","id":7291787,"avatar_url":"https://avatars.githubusercontent.com/u/7291787?v=3","gravatar_id":"","url":"https://api.github.com/users/muhhshoaib","html_url":"https://github.com/muhhshoaib","followers_url":"https://api.github.com/users/muhhshoaib/followers","following_url":"https://api.github.com/users/muhhshoaib/following{/other_user}","gists_url":"https://api.github.com/users/muhhshoaib/gists{/gist_id}","starred_url":"https://api.github.com/users/muhhshoaib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muhhshoaib/subscriptions","organizations_url":"https://api.github.com/users/muhhshoaib/orgs","repos_url":"https://api.github.com/users/muhhshoaib/repos","events_url":"https://api.github.com/users/muhhshoaib/events{/privacy}","received_events_url":"https://api.github.com/users/muhhshoaib/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-23T12:29:54Z","updated_at":"2015-02-23T13:53:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/7065","html_url":"https://github.com/edx/edx-platform/pull/7065","diff_url":"https://github.com/edx/edx-platform/pull/7065.diff","patch_url":"https://github.com/edx/edx-platform/pull/7065.patch"},"body":"This PR covers the SOL-143 adding notifications when there is a new course update or announcement.\r\n\r\n- added the Celery task for publishing bulk notifications to the user.\r\n- added the settings in the common.py of SQLStoreProviders and Default Channels.\r\n- added the edx_notifications in the installed_app in the studio test.py envoirnment.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/75543783","html_url":"https://github.com/edx/edx-platform/pull/7065#issuecomment-75543783","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/7065","id":75543783,"user":{"login":"chrisndodge","id":2362917,"avatar_url":"https://avatars.githubusercontent.com/u/2362917?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisndodge","html_url":"https://github.com/chrisndodge","followers_url":"https://api.github.com/users/chrisndodge/followers","following_url":"https://api.github.com/users/chrisndodge/following{/other_user}","gists_url":"https://api.github.com/users/chrisndodge/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisndodge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisndodge/subscriptions","organizations_url":"https://api.github.com/users/chrisndodge/orgs","repos_url":"https://api.github.com/users/chrisndodge/repos","events_url":"https://api.github.com/users/chrisndodge/events{/privacy}","received_events_url":"https://api.github.com/users/chrisndodge/received_events","type":"User","site_admin":false},"created_at":"2015-02-23T13:53:36Z","updated_at":"2015-02-23T13:53:36Z","body":"@muhhshoaib thanks. This basically looks OK, but I think we need to - if we are going to use Celery - move the Django ORM query of the Enrollment table into the task itself, otherwise Celery has to serialize potentially 100,000's of user_ids. Also this \"broadcast this Notification to all students in a course\" will be needed for the LMS, so can you move that task definition into \"common\"?\r\n\r\nAlso, I know there is some Celery task status reporting in the platform, I don't know if we get that \"for free\" or if you have to write out some code to do it. @ziafazal might be able to give you some feedback."}}