{"action":"created","issue":{"url":"https://api.github.com/repos/TheCricket/Chisel-2/issues/297","labels_url":"https://api.github.com/repos/TheCricket/Chisel-2/issues/297/labels{/name}","comments_url":"https://api.github.com/repos/TheCricket/Chisel-2/issues/297/comments","events_url":"https://api.github.com/repos/TheCricket/Chisel-2/issues/297/events","html_url":"https://github.com/TheCricket/Chisel-2/issues/297","id":68739521,"number":297,"title":"onChisel should return an instance of the player who's currently using it.","user":{"login":"CptSpaceToaster","id":5491723,"avatar_url":"https://avatars.githubusercontent.com/u/5491723?v=3","gravatar_id":"","url":"https://api.github.com/users/CptSpaceToaster","html_url":"https://github.com/CptSpaceToaster","followers_url":"https://api.github.com/users/CptSpaceToaster/followers","following_url":"https://api.github.com/users/CptSpaceToaster/following{/other_user}","gists_url":"https://api.github.com/users/CptSpaceToaster/gists{/gist_id}","starred_url":"https://api.github.com/users/CptSpaceToaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CptSpaceToaster/subscriptions","organizations_url":"https://api.github.com/users/CptSpaceToaster/orgs","repos_url":"https://api.github.com/users/CptSpaceToaster/repos","events_url":"https://api.github.com/users/CptSpaceToaster/events{/privacy}","received_events_url":"https://api.github.com/users/CptSpaceToaster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-15T17:21:45Z","updated_at":"2015-04-15T18:04:58Z","closed_at":null,"body":"As per [issue 15](https://github.com/TehNut/MoreChisels/issues/15) from [MoreChisels](https://github.com/TehNut/MoreChisels)\r\n\r\nThe chisel interface we provide can't do some of the cool things that are being discussed.  Since the player instance isn't readily available, we can't make chisels that cost experience, or chisel's that use Botania Mana, etc.\r\n\r\n[Source](https://github.com/TheCricket/Chisel-2/blob/4264a87546eebe13bfc4e461716c8d2cc9a2b148/src/main/java/com/cricketcraft/chisel/api/IChiselItem.java#L39)\r\n\r\nIf we follow semantic-versioning, we might want to consider bumping up a larger increment, versus a patch if this is included.\r\n\r\nWe may need to think about leaving the old method there for compatibility reasons, and just make a second one next to it.  That's what the `@Deprecated` annotation is for... right?  We could make a new method return everything, including the player, and leave the old one, but mark it deprecated with a comment saying to use the new one."},"comment":{"url":"https://api.github.com/repos/TheCricket/Chisel-2/issues/comments/93506806","html_url":"https://github.com/TheCricket/Chisel-2/issues/297#issuecomment-93506806","issue_url":"https://api.github.com/repos/TheCricket/Chisel-2/issues/297","id":93506806,"user":{"login":"tterrag1098","id":3751664,"avatar_url":"https://avatars.githubusercontent.com/u/3751664?v=3","gravatar_id":"","url":"https://api.github.com/users/tterrag1098","html_url":"https://github.com/tterrag1098","followers_url":"https://api.github.com/users/tterrag1098/followers","following_url":"https://api.github.com/users/tterrag1098/following{/other_user}","gists_url":"https://api.github.com/users/tterrag1098/gists{/gist_id}","starred_url":"https://api.github.com/users/tterrag1098/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tterrag1098/subscriptions","organizations_url":"https://api.github.com/users/tterrag1098/orgs","repos_url":"https://api.github.com/users/tterrag1098/repos","events_url":"https://api.github.com/users/tterrag1098/events{/privacy}","received_events_url":"https://api.github.com/users/tterrag1098/received_events","type":"User","site_admin":false},"created_at":"2015-04-15T18:04:58Z","updated_at":"2015-04-15T18:04:58Z","body":"I suppose, but this will be a API breaking change no matter what.\nOn Apr 15, 2015 2:00 PM, \"CptSpaceToaster\" <notifications@github.com> wrote:\n\n> We could send null in that instance?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/TheCricket/Chisel-2/issues/297#issuecomment-93504503>.\n>\n"}}