{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/marketplace-core-modules/issues/23","labels_url":"https://api.github.com/repos/mozilla/marketplace-core-modules/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/marketplace-core-modules/issues/23/comments","events_url":"https://api.github.com/repos/mozilla/marketplace-core-modules/issues/23/events","html_url":"https://github.com/mozilla/marketplace-core-modules/pull/23","id":57266058,"number":23,"title":"v2.0.0 fix and refactor scroll states using events (bug 986625)","user":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-11T01:43:54Z","updated_at":"2015-02-11T18:01:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/marketplace-core-modules/pulls/23","html_url":"https://github.com/mozilla/marketplace-core-modules/pull/23","diff_url":"https://github.com/mozilla/marketplace-core-modules/pull/23.diff","patch_url":"https://github.com/mozilla/marketplace-core-modules/pull/23.patch"},"body":"- add two events to builder: ```builder--pre-render```, ```builder-post-render```. These happen immediately before and Nunjucks rendering.\r\n- add two events to navigation: ```navigation--pop-state``` (clicking back) and ```navigation-pre-navigate``` (clicking a link, before a new state is shifted)\r\n- separate scroll state logic from navigation\r\n- some code clean up\r\n\r\nScroll logic:\r\n\r\n- When navigating (clicking a link for ```navigation-pre-navigate```), save the state and then set the scroll to 0 on ```builder-post-render```.\r\n- When popping (going back for ```navigation--pop-state```), set the scroll to the saved state on ```builder-post-render```"},"comment":{"url":"https://api.github.com/repos/mozilla/marketplace-core-modules/issues/comments/73930421","html_url":"https://github.com/mozilla/marketplace-core-modules/pull/23#issuecomment-73930421","issue_url":"https://api.github.com/repos/mozilla/marketplace-core-modules/issues/23","id":73930421,"user":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"created_at":"2015-02-11T18:01:42Z","updated_at":"2015-02-11T18:01:42Z","body":"Can you give me a really hard case to STR the issues on FxOS? My brief tests showed this worked as expected. Jumping from Feed to app detail and back. \r\n\r\nWhen are content requests an issue? In my mind: when we are navigating to a page, we wouldn't care since we are just scrolling to the top. And when we are popping, then the previous page would have everything cached so there wouldn't be height changes. \r\n"}}