{"action":"closed","number":59,"pull_request":{"url":"https://api.github.com/repos/torch/ezinstall/pulls/59","id":38153804,"html_url":"https://github.com/torch/ezinstall/pull/59","diff_url":"https://github.com/torch/ezinstall/pull/59.diff","patch_url":"https://github.com/torch/ezinstall/pull/59.patch","issue_url":"https://api.github.com/repos/torch/ezinstall/issues/59","number":59,"state":"closed","locked":false,"title":"install-deps: exit with error value if installation fails","user":{"login":"mcsaucy","id":621959,"avatar_url":"https://avatars.githubusercontent.com/u/621959?v=3","gravatar_id":"","url":"https://api.github.com/users/mcsaucy","html_url":"https://github.com/mcsaucy","followers_url":"https://api.github.com/users/mcsaucy/followers","following_url":"https://api.github.com/users/mcsaucy/following{/other_user}","gists_url":"https://api.github.com/users/mcsaucy/gists{/gist_id}","starred_url":"https://api.github.com/users/mcsaucy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcsaucy/subscriptions","organizations_url":"https://api.github.com/users/mcsaucy/orgs","repos_url":"https://api.github.com/users/mcsaucy/repos","events_url":"https://api.github.com/users/mcsaucy/events{/privacy}","received_events_url":"https://api.github.com/users/mcsaucy/received_events","type":"User","site_admin":false},"body":"Currently, most `exit` calls in `install-deps` are responses to error states, yet most of those statements end up returning 0, indicating success.\r\n\r\nWe should return something non-zero if we have to bail out of `install-deps` so the calling script can act on the failure.\r\n\r\nFor example, if I were to run `install-all` on a Solaris machine right now, `install-deps` would lose its mind and scream about an unsupported system, `install-all` would ignore its cries, and then `install-luajit+torch` would bravely attempt to install Torch lacking unknown numbers of dependencies on a completely unsupported platform.\r\n\r\nThis change will at least make `install-all` throw a warning to the user.","created_at":"2015-06-19T22:29:16Z","updated_at":"2015-06-19T22:39:24Z","closed_at":"2015-06-19T22:39:24Z","merged_at":"2015-06-19T22:39:24Z","merge_commit_sha":"998abf0513c10e8b97b705e04fcee217ad44a802","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/torch/ezinstall/pulls/59/commits","review_comments_url":"https://api.github.com/repos/torch/ezinstall/pulls/59/comments","review_comment_url":"https://api.github.com/repos/torch/ezinstall/pulls/comments{/number}","comments_url":"https://api.github.com/repos/torch/ezinstall/issues/59/comments","statuses_url":"https://api.github.com/repos/torch/ezinstall/statuses/9e6ce84ba6eeefa4e28910cc855783063ced8077","head":{"label":"mcsaucy:dep-exit-codes","ref":"dep-exit-codes","sha":"9e6ce84ba6eeefa4e28910cc855783063ced8077","user":{"login":"mcsaucy","id":621959,"avatar_url":"https://avatars.githubusercontent.com/u/621959?v=3","gravatar_id":"","url":"https://api.github.com/users/mcsaucy","html_url":"https://github.com/mcsaucy","followers_url":"https://api.github.com/users/mcsaucy/followers","following_url":"https://api.github.com/users/mcsaucy/following{/other_user}","gists_url":"https://api.github.com/users/mcsaucy/gists{/gist_id}","starred_url":"https://api.github.com/users/mcsaucy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcsaucy/subscriptions","organizations_url":"https://api.github.com/users/mcsaucy/orgs","repos_url":"https://api.github.com/users/mcsaucy/repos","events_url":"https://api.github.com/users/mcsaucy/events{/privacy}","received_events_url":"https://api.github.com/users/mcsaucy/received_events","type":"User","site_admin":false},"repo":{"id":37618991,"name":"ezinstall","full_name":"mcsaucy/ezinstall","owner":{"login":"mcsaucy","id":621959,"avatar_url":"https://avatars.githubusercontent.com/u/621959?v=3","gravatar_id":"","url":"https://api.github.com/users/mcsaucy","html_url":"https://github.com/mcsaucy","followers_url":"https://api.github.com/users/mcsaucy/followers","following_url":"https://api.github.com/users/mcsaucy/following{/other_user}","gists_url":"https://api.github.com/users/mcsaucy/gists{/gist_id}","starred_url":"https://api.github.com/users/mcsaucy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcsaucy/subscriptions","organizations_url":"https://api.github.com/users/mcsaucy/orgs","repos_url":"https://api.github.com/users/mcsaucy/repos","events_url":"https://api.github.com/users/mcsaucy/events{/privacy}","received_events_url":"https://api.github.com/users/mcsaucy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcsaucy/ezinstall","description":"One-line install scripts for Torch.","fork":true,"url":"https://api.github.com/repos/mcsaucy/ezinstall","forks_url":"https://api.github.com/repos/mcsaucy/ezinstall/forks","keys_url":"https://api.github.com/repos/mcsaucy/ezinstall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcsaucy/ezinstall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcsaucy/ezinstall/teams","hooks_url":"https://api.github.com/repos/mcsaucy/ezinstall/hooks","issue_events_url":"https://api.github.com/repos/mcsaucy/ezinstall/issues/events{/number}","events_url":"https://api.github.com/repos/mcsaucy/ezinstall/events","assignees_url":"https://api.github.com/repos/mcsaucy/ezinstall/assignees{/user}","branches_url":"https://api.github.com/repos/mcsaucy/ezinstall/branches{/branch}","tags_url":"https://api.github.com/repos/mcsaucy/ezinstall/tags","blobs_url":"https://api.github.com/repos/mcsaucy/ezinstall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcsaucy/ezinstall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcsaucy/ezinstall/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcsaucy/ezinstall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcsaucy/ezinstall/statuses/{sha}","languages_url":"https://api.github.com/repos/mcsaucy/ezinstall/languages","stargazers_url":"https://api.github.com/repos/mcsaucy/ezinstall/stargazers","contributors_url":"https://api.github.com/repos/mcsaucy/ezinstall/contributors","subscribers_url":"https://api.github.com/repos/mcsaucy/ezinstall/subscribers","subscription_url":"https://api.github.com/repos/mcsaucy/ezinstall/subscription","commits_url":"https://api.github.com/repos/mcsaucy/ezinstall/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcsaucy/ezinstall/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcsaucy/ezinstall/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcsaucy/ezinstall/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcsaucy/ezinstall/contents/{+path}","compare_url":"https://api.github.com/repos/mcsaucy/ezinstall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcsaucy/ezinstall/merges","archive_url":"https://api.github.com/repos/mcsaucy/ezinstall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcsaucy/ezinstall/downloads","issues_url":"https://api.github.com/repos/mcsaucy/ezinstall/issues{/number}","pulls_url":"https://api.github.com/repos/mcsaucy/ezinstall/pulls{/number}","milestones_url":"https://api.github.com/repos/mcsaucy/ezinstall/milestones{/number}","notifications_url":"https://api.github.com/repos/mcsaucy/ezinstall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcsaucy/ezinstall/labels{/name}","releases_url":"https://api.github.com/repos/mcsaucy/ezinstall/releases{/id}","created_at":"2015-06-17T20:26:35Z","updated_at":"2015-06-17T20:26:35Z","pushed_at":"2015-06-19T22:13:08Z","git_url":"git://github.com/mcsaucy/ezinstall.git","ssh_url":"git@github.com:mcsaucy/ezinstall.git","clone_url":"https://github.com/mcsaucy/ezinstall.git","svn_url":"https://github.com/mcsaucy/ezinstall","homepage":null,"size":202,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"torch:master","ref":"master","sha":"94b0ff46beb61b03788e280fb996db656052c070","user":{"login":"torch","id":4978924,"avatar_url":"https://avatars.githubusercontent.com/u/4978924?v=3","gravatar_id":"","url":"https://api.github.com/users/torch","html_url":"https://github.com/torch","followers_url":"https://api.github.com/users/torch/followers","following_url":"https://api.github.com/users/torch/following{/other_user}","gists_url":"https://api.github.com/users/torch/gists{/gist_id}","starred_url":"https://api.github.com/users/torch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch/subscriptions","organizations_url":"https://api.github.com/users/torch/orgs","repos_url":"https://api.github.com/users/torch/repos","events_url":"https://api.github.com/users/torch/events{/privacy}","received_events_url":"https://api.github.com/users/torch/received_events","type":"Organization","site_admin":false},"repo":{"id":11313323,"name":"ezinstall","full_name":"torch/ezinstall","owner":{"login":"torch","id":4978924,"avatar_url":"https://avatars.githubusercontent.com/u/4978924?v=3","gravatar_id":"","url":"https://api.github.com/users/torch","html_url":"https://github.com/torch","followers_url":"https://api.github.com/users/torch/followers","following_url":"https://api.github.com/users/torch/following{/other_user}","gists_url":"https://api.github.com/users/torch/gists{/gist_id}","starred_url":"https://api.github.com/users/torch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch/subscriptions","organizations_url":"https://api.github.com/users/torch/orgs","repos_url":"https://api.github.com/users/torch/repos","events_url":"https://api.github.com/users/torch/events{/privacy}","received_events_url":"https://api.github.com/users/torch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/torch/ezinstall","description":"One-line install scripts for Torch.","fork":false,"url":"https://api.github.com/repos/torch/ezinstall","forks_url":"https://api.github.com/repos/torch/ezinstall/forks","keys_url":"https://api.github.com/repos/torch/ezinstall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/torch/ezinstall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/torch/ezinstall/teams","hooks_url":"https://api.github.com/repos/torch/ezinstall/hooks","issue_events_url":"https://api.github.com/repos/torch/ezinstall/issues/events{/number}","events_url":"https://api.github.com/repos/torch/ezinstall/events","assignees_url":"https://api.github.com/repos/torch/ezinstall/assignees{/user}","branches_url":"https://api.github.com/repos/torch/ezinstall/branches{/branch}","tags_url":"https://api.github.com/repos/torch/ezinstall/tags","blobs_url":"https://api.github.com/repos/torch/ezinstall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/torch/ezinstall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/torch/ezinstall/git/refs{/sha}","trees_url":"https://api.github.com/repos/torch/ezinstall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/torch/ezinstall/statuses/{sha}","languages_url":"https://api.github.com/repos/torch/ezinstall/languages","stargazers_url":"https://api.github.com/repos/torch/ezinstall/stargazers","contributors_url":"https://api.github.com/repos/torch/ezinstall/contributors","subscribers_url":"https://api.github.com/repos/torch/ezinstall/subscribers","subscription_url":"https://api.github.com/repos/torch/ezinstall/subscription","commits_url":"https://api.github.com/repos/torch/ezinstall/commits{/sha}","git_commits_url":"https://api.github.com/repos/torch/ezinstall/git/commits{/sha}","comments_url":"https://api.github.com/repos/torch/ezinstall/comments{/number}","issue_comment_url":"https://api.github.com/repos/torch/ezinstall/issues/comments{/number}","contents_url":"https://api.github.com/repos/torch/ezinstall/contents/{+path}","compare_url":"https://api.github.com/repos/torch/ezinstall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/torch/ezinstall/merges","archive_url":"https://api.github.com/repos/torch/ezinstall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/torch/ezinstall/downloads","issues_url":"https://api.github.com/repos/torch/ezinstall/issues{/number}","pulls_url":"https://api.github.com/repos/torch/ezinstall/pulls{/number}","milestones_url":"https://api.github.com/repos/torch/ezinstall/milestones{/number}","notifications_url":"https://api.github.com/repos/torch/ezinstall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/torch/ezinstall/labels{/name}","releases_url":"https://api.github.com/repos/torch/ezinstall/releases{/id}","created_at":"2013-07-10T13:53:57Z","updated_at":"2015-06-01T21:54:06Z","pushed_at":"2015-06-19T22:39:24Z","git_url":"git://github.com/torch/ezinstall.git","ssh_url":"git@github.com:torch/ezinstall.git","clone_url":"https://github.com/torch/ezinstall.git","svn_url":"https://github.com/torch/ezinstall","homepage":null,"size":583,"stargazers_count":32,"watchers_count":32,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":5,"forks":33,"open_issues":5,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/torch/ezinstall/pulls/59"},"html":{"href":"https://github.com/torch/ezinstall/pull/59"},"issue":{"href":"https://api.github.com/repos/torch/ezinstall/issues/59"},"comments":{"href":"https://api.github.com/repos/torch/ezinstall/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/torch/ezinstall/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/torch/ezinstall/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/torch/ezinstall/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/torch/ezinstall/statuses/9e6ce84ba6eeefa4e28910cc855783063ced8077"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"soumith","id":1310570,"avatar_url":"https://avatars.githubusercontent.com/u/1310570?v=3","gravatar_id":"","url":"https://api.github.com/users/soumith","html_url":"https://github.com/soumith","followers_url":"https://api.github.com/users/soumith/followers","following_url":"https://api.github.com/users/soumith/following{/other_user}","gists_url":"https://api.github.com/users/soumith/gists{/gist_id}","starred_url":"https://api.github.com/users/soumith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soumith/subscriptions","organizations_url":"https://api.github.com/users/soumith/orgs","repos_url":"https://api.github.com/users/soumith/repos","events_url":"https://api.github.com/users/soumith/events{/privacy}","received_events_url":"https://api.github.com/users/soumith/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":5,"changed_files":1}}