{"action":"closed","number":1543,"pull_request":{"url":"https://api.github.com/repos/cylc/cylc/pulls/1543","id":40511652,"html_url":"https://github.com/cylc/cylc/pull/1543","diff_url":"https://github.com/cylc/cylc/pull/1543.diff","patch_url":"https://github.com/cylc/cylc/pull/1543.patch","issue_url":"https://api.github.com/repos/cylc/cylc/issues/1543","number":1543,"state":"closed","locked":false,"title":"Moved call to external trigger matching.","user":{"login":"hjoliver","id":2362137,"avatar_url":"https://avatars.githubusercontent.com/u/2362137?v=3","gravatar_id":"","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"body":"External triggers are similar to clock triggers: they have to be triggered outside of task processing (and if one is triggered, that should stimulate task processing).  The external trigger matching was being done in the task processing block, so task processing wasn't stimulated by an external trigger unless other things were happening in the suite at the same time (else a \"nudge\" was required). \r\n\r\n(yes, we need event-driven processing!)\r\n\r\n@matthewrmshin - please review or reassign.","created_at":"2015-07-21T22:21:21Z","updated_at":"2015-07-28T00:06:27Z","closed_at":"2015-07-28T00:06:27Z","merged_at":"2015-07-28T00:06:27Z","merge_commit_sha":"9f92d3fadfa6544836c03cd4faf3aafe7828ea89","assignee":{"login":"kaday","id":3693326,"avatar_url":"https://avatars.githubusercontent.com/u/3693326?v=3","gravatar_id":"","url":"https://api.github.com/users/kaday","html_url":"https://github.com/kaday","followers_url":"https://api.github.com/users/kaday/followers","following_url":"https://api.github.com/users/kaday/following{/other_user}","gists_url":"https://api.github.com/users/kaday/gists{/gist_id}","starred_url":"https://api.github.com/users/kaday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaday/subscriptions","organizations_url":"https://api.github.com/users/kaday/orgs","repos_url":"https://api.github.com/users/kaday/repos","events_url":"https://api.github.com/users/kaday/events{/privacy}","received_events_url":"https://api.github.com/users/kaday/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/cylc/cylc/milestones/39","html_url":"https://github.com/cylc/cylc/milestones/next%20release","labels_url":"https://api.github.com/repos/cylc/cylc/milestones/39/labels","id":1204475,"number":39,"title":"next release","description":"","creator":{"login":"hjoliver","id":2362137,"avatar_url":"https://avatars.githubusercontent.com/u/2362137?v=3","gravatar_id":"","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":10,"state":"open","created_at":"2015-07-13T04:44:51Z","updated_at":"2015-07-28T00:06:27Z","due_on":"2015-08-02T12:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cylc/cylc/pulls/1543/commits","review_comments_url":"https://api.github.com/repos/cylc/cylc/pulls/1543/comments","review_comment_url":"https://api.github.com/repos/cylc/cylc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cylc/cylc/issues/1543/comments","statuses_url":"https://api.github.com/repos/cylc/cylc/statuses/91fcf882f332f60fc39d24e1a1775588951d332a","head":{"label":"hjoliver:Fix.ext-trigger-retrieval","ref":"Fix.ext-trigger-retrieval","sha":"91fcf882f332f60fc39d24e1a1775588951d332a","user":{"login":"hjoliver","id":2362137,"avatar_url":"https://avatars.githubusercontent.com/u/2362137?v=3","gravatar_id":"","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"repo":{"id":5840564,"name":"cylc","full_name":"hjoliver/cylc","owner":{"login":"hjoliver","id":2362137,"avatar_url":"https://avatars.githubusercontent.com/u/2362137?v=3","gravatar_id":"","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hjoliver/cylc","description":"My fork of the cylc suite engine. The central repository is here:","fork":true,"url":"https://api.github.com/repos/hjoliver/cylc","forks_url":"https://api.github.com/repos/hjoliver/cylc/forks","keys_url":"https://api.github.com/repos/hjoliver/cylc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hjoliver/cylc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hjoliver/cylc/teams","hooks_url":"https://api.github.com/repos/hjoliver/cylc/hooks","issue_events_url":"https://api.github.com/repos/hjoliver/cylc/issues/events{/number}","events_url":"https://api.github.com/repos/hjoliver/cylc/events","assignees_url":"https://api.github.com/repos/hjoliver/cylc/assignees{/user}","branches_url":"https://api.github.com/repos/hjoliver/cylc/branches{/branch}","tags_url":"https://api.github.com/repos/hjoliver/cylc/tags","blobs_url":"https://api.github.com/repos/hjoliver/cylc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hjoliver/cylc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hjoliver/cylc/git/refs{/sha}","trees_url":"https://api.github.com/repos/hjoliver/cylc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hjoliver/cylc/statuses/{sha}","languages_url":"https://api.github.com/repos/hjoliver/cylc/languages","stargazers_url":"https://api.github.com/repos/hjoliver/cylc/stargazers","contributors_url":"https://api.github.com/repos/hjoliver/cylc/contributors","subscribers_url":"https://api.github.com/repos/hjoliver/cylc/subscribers","subscription_url":"https://api.github.com/repos/hjoliver/cylc/subscription","commits_url":"https://api.github.com/repos/hjoliver/cylc/commits{/sha}","git_commits_url":"https://api.github.com/repos/hjoliver/cylc/git/commits{/sha}","comments_url":"https://api.github.com/repos/hjoliver/cylc/comments{/number}","issue_comment_url":"https://api.github.com/repos/hjoliver/cylc/issues/comments{/number}","contents_url":"https://api.github.com/repos/hjoliver/cylc/contents/{+path}","compare_url":"https://api.github.com/repos/hjoliver/cylc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hjoliver/cylc/merges","archive_url":"https://api.github.com/repos/hjoliver/cylc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hjoliver/cylc/downloads","issues_url":"https://api.github.com/repos/hjoliver/cylc/issues{/number}","pulls_url":"https://api.github.com/repos/hjoliver/cylc/pulls{/number}","milestones_url":"https://api.github.com/repos/hjoliver/cylc/milestones{/number}","notifications_url":"https://api.github.com/repos/hjoliver/cylc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hjoliver/cylc/labels{/name}","releases_url":"https://api.github.com/repos/hjoliver/cylc/releases{/id}","created_at":"2012-09-17T12:20:56Z","updated_at":"2015-04-21T21:59:05Z","pushed_at":"2015-07-28T00:02:02Z","git_url":"git://github.com/hjoliver/cylc.git","ssh_url":"git@github.com:hjoliver/cylc.git","clone_url":"https://github.com/hjoliver/cylc.git","svn_url":"https://github.com/hjoliver/cylc","homepage":"http://cylc.github.com/cylc","size":73866,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cylc:master","ref":"master","sha":"e9af9f4ad346121dd0af491ec98ac1072cb264ff","user":{"login":"cylc","id":824878,"avatar_url":"https://avatars.githubusercontent.com/u/824878?v=3","gravatar_id":"","url":"https://api.github.com/users/cylc","html_url":"https://github.com/cylc","followers_url":"https://api.github.com/users/cylc/followers","following_url":"https://api.github.com/users/cylc/following{/other_user}","gists_url":"https://api.github.com/users/cylc/gists{/gist_id}","starred_url":"https://api.github.com/users/cylc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cylc/subscriptions","organizations_url":"https://api.github.com/users/cylc/orgs","repos_url":"https://api.github.com/users/cylc/repos","events_url":"https://api.github.com/users/cylc/events{/privacy}","received_events_url":"https://api.github.com/users/cylc/received_events","type":"Organization","site_admin":false},"repo":{"id":1836229,"name":"cylc","full_name":"cylc/cylc","owner":{"login":"cylc","id":824878,"avatar_url":"https://avatars.githubusercontent.com/u/824878?v=3","gravatar_id":"","url":"https://api.github.com/users/cylc","html_url":"https://github.com/cylc","followers_url":"https://api.github.com/users/cylc/followers","following_url":"https://api.github.com/users/cylc/following{/other_user}","gists_url":"https://api.github.com/users/cylc/gists{/gist_id}","starred_url":"https://api.github.com/users/cylc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cylc/subscriptions","organizations_url":"https://api.github.com/users/cylc/orgs","repos_url":"https://api.github.com/users/cylc/repos","events_url":"https://api.github.com/users/cylc/events{/privacy}","received_events_url":"https://api.github.com/users/cylc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cylc/cylc","description":"This is the official repository of the cylc suite engine. It will normally contain just the master branch, with completed features merged in from feature branches in developer forks.","fork":false,"url":"https://api.github.com/repos/cylc/cylc","forks_url":"https://api.github.com/repos/cylc/cylc/forks","keys_url":"https://api.github.com/repos/cylc/cylc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cylc/cylc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cylc/cylc/teams","hooks_url":"https://api.github.com/repos/cylc/cylc/hooks","issue_events_url":"https://api.github.com/repos/cylc/cylc/issues/events{/number}","events_url":"https://api.github.com/repos/cylc/cylc/events","assignees_url":"https://api.github.com/repos/cylc/cylc/assignees{/user}","branches_url":"https://api.github.com/repos/cylc/cylc/branches{/branch}","tags_url":"https://api.github.com/repos/cylc/cylc/tags","blobs_url":"https://api.github.com/repos/cylc/cylc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cylc/cylc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cylc/cylc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cylc/cylc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cylc/cylc/statuses/{sha}","languages_url":"https://api.github.com/repos/cylc/cylc/languages","stargazers_url":"https://api.github.com/repos/cylc/cylc/stargazers","contributors_url":"https://api.github.com/repos/cylc/cylc/contributors","subscribers_url":"https://api.github.com/repos/cylc/cylc/subscribers","subscription_url":"https://api.github.com/repos/cylc/cylc/subscription","commits_url":"https://api.github.com/repos/cylc/cylc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cylc/cylc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cylc/cylc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cylc/cylc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cylc/cylc/contents/{+path}","compare_url":"https://api.github.com/repos/cylc/cylc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cylc/cylc/merges","archive_url":"https://api.github.com/repos/cylc/cylc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cylc/cylc/downloads","issues_url":"https://api.github.com/repos/cylc/cylc/issues{/number}","pulls_url":"https://api.github.com/repos/cylc/cylc/pulls{/number}","milestones_url":"https://api.github.com/repos/cylc/cylc/milestones{/number}","notifications_url":"https://api.github.com/repos/cylc/cylc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cylc/cylc/labels{/name}","releases_url":"https://api.github.com/repos/cylc/cylc/releases{/id}","created_at":"2011-06-02T08:31:49Z","updated_at":"2015-06-09T12:30:14Z","pushed_at":"2015-07-28T00:06:27Z","git_url":"git://github.com/cylc/cylc.git","ssh_url":"git@github.com:cylc/cylc.git","clone_url":"https://github.com/cylc/cylc.git","svn_url":"https://github.com/cylc/cylc","homepage":"http://cylc.github.com/cylc","size":96177,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":174,"forks":17,"open_issues":174,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cylc/cylc/pulls/1543"},"html":{"href":"https://github.com/cylc/cylc/pull/1543"},"issue":{"href":"https://api.github.com/repos/cylc/cylc/issues/1543"},"comments":{"href":"https://api.github.com/repos/cylc/cylc/issues/1543/comments"},"review_comments":{"href":"https://api.github.com/repos/cylc/cylc/pulls/1543/comments"},"review_comment":{"href":"https://api.github.com/repos/cylc/cylc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cylc/cylc/pulls/1543/commits"},"statuses":{"href":"https://api.github.com/repos/cylc/cylc/statuses/91fcf882f332f60fc39d24e1a1775588951d332a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hjoliver","id":2362137,"avatar_url":"https://avatars.githubusercontent.com/u/2362137?v=3","gravatar_id":"","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":2,"additions":68,"deletions":1,"changed_files":3}}