{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/47101265","id":47101265,"diff_hunk":"@@ -0,0 +1,1275 @@\n+/****************************************************************/\n+/*      Traktor Kontrol S4 MK2 HID controller script v1.00      */\n+/*      Copyright (C) 2015, the Mixxx Team                      */\n+/*      but feel free to tweak this to your heart's content!    */\n+/*      For Mixxx version 2.0                                   */\n+/****************************************************************/\n+\n+\n+// TODO:\n+// * Loop size readout / selection\n+// * Find a use for snap / master / other unused buttons?\n+\n+TraktorS4MK2 = new function() {","path":"res/controllers/Traktor-Kontrol-S4-MK2-hid-scripts.js","position":13,"original_position":13,"commit_id":"cdb0e963cdd014de8275a7750c5baf57a7f34659","original_commit_id":"cdb0e963cdd014de8275a7750c5baf57a7f34659","user":{"login":"ywwg","id":888940,"avatar_url":"https://avatars.githubusercontent.com/u/888940?v=3","gravatar_id":"","url":"https://api.github.com/users/ywwg","html_url":"https://github.com/ywwg","followers_url":"https://api.github.com/users/ywwg/followers","following_url":"https://api.github.com/users/ywwg/following{/other_user}","gists_url":"https://api.github.com/users/ywwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ywwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywwg/subscriptions","organizations_url":"https://api.github.com/users/ywwg/orgs","repos_url":"https://api.github.com/users/ywwg/repos","events_url":"https://api.github.com/users/ywwg/events{/privacy}","received_events_url":"https://api.github.com/users/ywwg/received_events","type":"User","site_admin":false},"body":"if I do then I get an error saying that TraktorS4MK2 is an undefined variable","created_at":"2015-12-09T15:05:44Z","updated_at":"2015-12-09T15:05:44Z","html_url":"https://github.com/mixxxdj/mixxx/pull/799#discussion_r47101265","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/799","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/47101265"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/799#discussion_r47101265"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/799"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/799","id":53069131,"html_url":"https://github.com/mixxxdj/mixxx/pull/799","diff_url":"https://github.com/mixxxdj/mixxx/pull/799.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/799.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/799","number":799,"state":"open","locked":false,"title":"Mapping for Traktor s4 mk2","user":{"login":"ywwg","id":888940,"avatar_url":"https://avatars.githubusercontent.com/u/888940?v=3","gravatar_id":"","url":"https://api.github.com/users/ywwg","html_url":"https://github.com/ywwg","followers_url":"https://api.github.com/users/ywwg/followers","following_url":"https://api.github.com/users/ywwg/following{/other_user}","gists_url":"https://api.github.com/users/ywwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ywwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywwg/subscriptions","organizations_url":"https://api.github.com/users/ywwg/orgs","repos_url":"https://api.github.com/users/ywwg/repos","events_url":"https://api.github.com/users/ywwg/events{/privacy}","received_events_url":"https://api.github.com/users/ywwg/received_events","type":"User","site_admin":false},"body":"I have not tried to do a lot of obvious cleanup of redundant cut-and-paste code or fixing unrolled loops.  This is a first pass so that we can get the map in the builds and out to testers.  ","created_at":"2015-12-09T02:30:43Z","updated_at":"2015-12-09T15:05:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86332be287fb38a47d138eacead48ee473f37f35","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/799/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/799/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/799/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/cdb0e963cdd014de8275a7750c5baf57a7f34659","head":{"label":"ywwg:traktor_s4","ref":"traktor_s4","sha":"cdb0e963cdd014de8275a7750c5baf57a7f34659","user":{"login":"ywwg","id":888940,"avatar_url":"https://avatars.githubusercontent.com/u/888940?v=3","gravatar_id":"","url":"https://api.github.com/users/ywwg","html_url":"https://github.com/ywwg","followers_url":"https://api.github.com/users/ywwg/followers","following_url":"https://api.github.com/users/ywwg/following{/other_user}","gists_url":"https://api.github.com/users/ywwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ywwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywwg/subscriptions","organizations_url":"https://api.github.com/users/ywwg/orgs","repos_url":"https://api.github.com/users/ywwg/repos","events_url":"https://api.github.com/users/ywwg/events{/privacy}","received_events_url":"https://api.github.com/users/ywwg/received_events","type":"User","site_admin":false},"repo":{"id":10135825,"name":"mixxx","full_name":"ywwg/mixxx","owner":{"login":"ywwg","id":888940,"avatar_url":"https://avatars.githubusercontent.com/u/888940?v=3","gravatar_id":"","url":"https://api.github.com/users/ywwg","html_url":"https://github.com/ywwg","followers_url":"https://api.github.com/users/ywwg/followers","following_url":"https://api.github.com/users/ywwg/following{/other_user}","gists_url":"https://api.github.com/users/ywwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ywwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywwg/subscriptions","organizations_url":"https://api.github.com/users/ywwg/orgs","repos_url":"https://api.github.com/users/ywwg/repos","events_url":"https://api.github.com/users/ywwg/events{/privacy}","received_events_url":"https://api.github.com/users/ywwg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ywwg/mixxx","description":"Personal work branches for the mixxx project -- you may be interested in DJO-hacks-trunk, which contains a bunch of UNSUPPORTED tweaks I like","fork":true,"url":"https://api.github.com/repos/ywwg/mixxx","forks_url":"https://api.github.com/repos/ywwg/mixxx/forks","keys_url":"https://api.github.com/repos/ywwg/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ywwg/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ywwg/mixxx/teams","hooks_url":"https://api.github.com/repos/ywwg/mixxx/hooks","issue_events_url":"https://api.github.com/repos/ywwg/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/ywwg/mixxx/events","assignees_url":"https://api.github.com/repos/ywwg/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/ywwg/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/ywwg/mixxx/tags","blobs_url":"https://api.github.com/repos/ywwg/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ywwg/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ywwg/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ywwg/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ywwg/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/ywwg/mixxx/languages","stargazers_url":"https://api.github.com/repos/ywwg/mixxx/stargazers","contributors_url":"https://api.github.com/repos/ywwg/mixxx/contributors","subscribers_url":"https://api.github.com/repos/ywwg/mixxx/subscribers","subscription_url":"https://api.github.com/repos/ywwg/mixxx/subscription","commits_url":"https://api.github.com/repos/ywwg/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ywwg/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ywwg/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ywwg/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ywwg/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/ywwg/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ywwg/mixxx/merges","archive_url":"https://api.github.com/repos/ywwg/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ywwg/mixxx/downloads","issues_url":"https://api.github.com/repos/ywwg/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/ywwg/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/ywwg/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/ywwg/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ywwg/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/ywwg/mixxx/releases{/id}","created_at":"2013-05-18T02:52:01Z","updated_at":"2015-02-20T22:28:35Z","pushed_at":"2015-12-09T03:45:02Z","git_url":"git://github.com/ywwg/mixxx.git","ssh_url":"git@github.com:ywwg/mixxx.git","clone_url":"https://github.com/ywwg/mixxx.git","svn_url":"https://github.com/ywwg/mixxx","homepage":"","size":256490,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:1.12","ref":"1.12","sha":"06f52f93652a238e1fc334c0fc95bf9d3fb6333c","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","created_at":"2013-05-17T15:14:38Z","updated_at":"2015-12-09T01:17:55Z","pushed_at":"2015-12-09T03:45:02Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":262090,"stargazers_count":403,"watchers_count":403,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":267,"mirror_url":null,"open_issues_count":68,"forks":267,"open_issues":68,"watchers":403,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/799"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/799"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/799"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/799/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/799/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/799/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/cdb0e963cdd014de8275a7750c5baf57a7f34659"}}}}