{"action":"created","issue":{"url":"https://api.github.com/repos/divshot/superstatic/issues/151","labels_url":"https://api.github.com/repos/divshot/superstatic/issues/151/labels{/name}","comments_url":"https://api.github.com/repos/divshot/superstatic/issues/151/comments","events_url":"https://api.github.com/repos/divshot/superstatic/issues/151/events","html_url":"https://github.com/divshot/superstatic/issues/151","id":58905724,"number":151,"title":"Caching issues on 2.1.0","user":{"login":"epicbagel","id":469071,"avatar_url":"https://avatars.githubusercontent.com/u/469071?v=3","gravatar_id":"","url":"https://api.github.com/users/epicbagel","html_url":"https://github.com/epicbagel","followers_url":"https://api.github.com/users/epicbagel/followers","following_url":"https://api.github.com/users/epicbagel/following{/other_user}","gists_url":"https://api.github.com/users/epicbagel/gists{/gist_id}","starred_url":"https://api.github.com/users/epicbagel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epicbagel/subscriptions","organizations_url":"https://api.github.com/users/epicbagel/orgs","repos_url":"https://api.github.com/users/epicbagel/repos","events_url":"https://api.github.com/users/epicbagel/events{/privacy}","received_events_url":"https://api.github.com/users/epicbagel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/divshot/superstatic/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/divshot/superstatic/labels/feature","name":"feature","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/divshot/superstatic/milestones/8","html_url":"https://github.com/divshot/superstatic/milestones/2.2","labels_url":"https://api.github.com/repos/divshot/superstatic/milestones/8/labels","id":937440,"number":8,"title":"2.2","description":"","creator":{"login":"scottcorgan","id":974723,"avatar_url":"https://avatars.githubusercontent.com/u/974723?v=3","gravatar_id":"","url":"https://api.github.com/users/scottcorgan","html_url":"https://github.com/scottcorgan","followers_url":"https://api.github.com/users/scottcorgan/followers","following_url":"https://api.github.com/users/scottcorgan/following{/other_user}","gists_url":"https://api.github.com/users/scottcorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/scottcorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottcorgan/subscriptions","organizations_url":"https://api.github.com/users/scottcorgan/orgs","repos_url":"https://api.github.com/users/scottcorgan/repos","events_url":"https://api.github.com/users/scottcorgan/events{/privacy}","received_events_url":"https://api.github.com/users/scottcorgan/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2015-01-15T21:17:46Z","updated_at":"2015-03-04T18:56:28Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2015-02-25T14:03:43Z","updated_at":"2015-03-05T18:21:26Z","closed_at":null,"body":"When creating a server via the API, it appears all files are being cached despite any configuration setting (set via .json or the options object). \r\n\r\nThis appears to be a regression from 2.0.2, as that handles the disabling of caching correctly. On 2.0.2:\r\n\r\n    var superstatic = require('superstatic/lib/server')\r\n    var app = superstatic({\r\n        //config: \"divshot-localdev.json\",\r\n        config: {\r\n            root: \"./build/\",\r\n            debug: true,\r\n            cache_control: {\r\n                \"**\": false\r\n            },\r\n            routes: {\r\n                \"**\": \"index.html\"\r\n            }\r\n        },\r\n        port: 5001\r\n    }).listen() \r\n\r\nOn 2.1.0 I was using the same options object, but used the new import changes:\r\n\r\n    var superstatic = require('superstatic')\r\n    app = superstatic.server({\r\n    ...."},"comment":{"url":"https://api.github.com/repos/divshot/superstatic/issues/comments/77418777","html_url":"https://github.com/divshot/superstatic/issues/151#issuecomment-77418777","issue_url":"https://api.github.com/repos/divshot/superstatic/issues/151","id":77418777,"user":{"login":"mbleigh","id":1022,"avatar_url":"https://avatars.githubusercontent.com/u/1022?v=3","gravatar_id":"","url":"https://api.github.com/users/mbleigh","html_url":"https://github.com/mbleigh","followers_url":"https://api.github.com/users/mbleigh/followers","following_url":"https://api.github.com/users/mbleigh/following{/other_user}","gists_url":"https://api.github.com/users/mbleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/mbleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbleigh/subscriptions","organizations_url":"https://api.github.com/users/mbleigh/orgs","repos_url":"https://api.github.com/users/mbleigh/repos","events_url":"https://api.github.com/users/mbleigh/events{/privacy}","received_events_url":"https://api.github.com/users/mbleigh/received_events","type":"User","site_admin":false},"created_at":"2015-03-05T18:21:26Z","updated_at":"2015-03-05T18:21:26Z","body":"@scottcorgan shouldn't the ETags change whenever file content changes? If the file has changed locally, why would we be sending a 304?"}}