{"action":"created","comment":{"url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/pulls/comments/39109679","id":39109679,"diff_hunk":"@@ -68,7 +70,7 @@ class Terminal {\n \n   setCursorPosition(line, col){\n     const { lines } = this.state;\n-    for(var ix = lines.length; ix <= line; ix++){\n+    for(let ix = lines.length; ix <= line; ix++){","path":"src/lib/terminal.js","position":23,"original_position":23,"commit_id":"d8babb3182cbf7fd1ebe9673509089f463ea4fc1","original_commit_id":"d8babb3182cbf7fd1ebe9673509089f463ea4fc1","user":{"login":"phated","id":992373,"avatar_url":"https://avatars.githubusercontent.com/u/992373?v=3","gravatar_id":"","url":"https://api.github.com/users/phated","html_url":"https://github.com/phated","followers_url":"https://api.github.com/users/phated/followers","following_url":"https://api.github.com/users/phated/following{/other_user}","gists_url":"https://api.github.com/users/phated/gists{/gist_id}","starred_url":"https://api.github.com/users/phated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phated/subscriptions","organizations_url":"https://api.github.com/users/phated/orgs","repos_url":"https://api.github.com/users/phated/repos","events_url":"https://api.github.com/users/phated/events{/privacy}","received_events_url":"https://api.github.com/users/phated/received_events","type":"User","site_admin":false},"body":"makes sense","created_at":"2015-09-09T23:26:22Z","updated_at":"2015-09-09T23:26:22Z","html_url":"https://github.com/parallaxinc/Parallax-IDE/pull/255#discussion_r39109679","pull_request_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/pulls/255","_links":{"self":{"href":"https://api.github.com/repos/parallaxinc/Parallax-IDE/pulls/comments/39109679"},"html":{"href":"https://github.com/parallaxinc/Parallax-IDE/pull/255#discussion_r39109679"},"pull_request":{"href":"https://api.github.com/repos/parallaxinc/Parallax-IDE/pulls/255"}}},"pull_request":{"url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/pulls/255","id":44263174,"html_url":"https://github.com/parallaxinc/Parallax-IDE/pull/255","diff_url":"https://github.com/parallaxinc/Parallax-IDE/pull/255.diff","patch_url":"https://github.com/parallaxinc/Parallax-IDE/pull/255.patch","issue_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/issues/255","number":255,"state":"open","locked":false,"title":"Terminal Receive pane scrolling improvements and buffer increase","user":{"login":"2fast2fourier","id":719569,"avatar_url":"https://avatars.githubusercontent.com/u/719569?v=3","gravatar_id":"","url":"https://api.github.com/users/2fast2fourier","html_url":"https://github.com/2fast2fourier","followers_url":"https://api.github.com/users/2fast2fourier/followers","following_url":"https://api.github.com/users/2fast2fourier/following{/other_user}","gists_url":"https://api.github.com/users/2fast2fourier/gists{/gist_id}","starred_url":"https://api.github.com/users/2fast2fourier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2fast2fourier/subscriptions","organizations_url":"https://api.github.com/users/2fast2fourier/orgs","repos_url":"https://api.github.com/users/2fast2fourier/repos","events_url":"https://api.github.com/users/2fast2fourier/events{/privacy}","received_events_url":"https://api.github.com/users/2fast2fourier/received_events","type":"User","site_admin":false},"body":"#### What's this PR do?\r\nThis PR improves terminal scroll-back to eliminate the performance hit from scrolling backwards in the console. This also increases the buffer size. Additionally, it prevents one form of 'text slipping' when the underlying buffer trims output by maintaining a line offset, now the console text will remain in place as long as the visible text does not fall outside the buffer storage.\r\n#### What are the important parts of the code?\r\nThe primary scrolling changes are in the scrolling management class in `lib/scroller.js`. There were minor changes to the console buffer store, increasing buffer size and tracking trim offsets.\r\n#### How should this be tested by the reviewer?\r\nTry scrolling up and down to see how the console reacts. Here's a simple program to generate constant output:\r\n```\r\n'{$STAMP BS2}\r\n'{$PBASIC 2.5}\r\n\r\n  PAUSE 1000\r\n  ix VAR WORD\r\n  ix = 0\r\n\r\n  DO\r\n    DEBUG \"Loop: \", DEC ix, CR\r\n    ix = ix+1\r\n    PAUSE 5\r\n  LOOP\r\n```\r\n#### What are the relevant tickets?\r\nCloses #202 \r\nCloses #199 ","created_at":"2015-09-04T21:27:08Z","updated_at":"2015-09-09T23:26:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c825d5f563777ee9371ca8f022bbb37ac3ae770b","assignee":{"login":"phated","id":992373,"avatar_url":"https://avatars.githubusercontent.com/u/992373?v=3","gravatar_id":"","url":"https://api.github.com/users/phated","html_url":"https://github.com/phated","followers_url":"https://api.github.com/users/phated/followers","following_url":"https://api.github.com/users/phated/following{/other_user}","gists_url":"https://api.github.com/users/phated/gists{/gist_id}","starred_url":"https://api.github.com/users/phated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phated/subscriptions","organizations_url":"https://api.github.com/users/phated/orgs","repos_url":"https://api.github.com/users/phated/repos","events_url":"https://api.github.com/users/phated/events{/privacy}","received_events_url":"https://api.github.com/users/phated/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/pulls/255/commits","review_comments_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/pulls/255/comments","review_comment_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/issues/255/comments","statuses_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/statuses/d8babb3182cbf7fd1ebe9673509089f463ea4fc1","head":{"label":"parallaxinc:scroll-bottom","ref":"scroll-bottom","sha":"d8babb3182cbf7fd1ebe9673509089f463ea4fc1","user":{"login":"parallaxinc","id":1985825,"avatar_url":"https://avatars.githubusercontent.com/u/1985825?v=3","gravatar_id":"","url":"https://api.github.com/users/parallaxinc","html_url":"https://github.com/parallaxinc","followers_url":"https://api.github.com/users/parallaxinc/followers","following_url":"https://api.github.com/users/parallaxinc/following{/other_user}","gists_url":"https://api.github.com/users/parallaxinc/gists{/gist_id}","starred_url":"https://api.github.com/users/parallaxinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parallaxinc/subscriptions","organizations_url":"https://api.github.com/users/parallaxinc/orgs","repos_url":"https://api.github.com/users/parallaxinc/repos","events_url":"https://api.github.com/users/parallaxinc/events{/privacy}","received_events_url":"https://api.github.com/users/parallaxinc/received_events","type":"Organization","site_admin":false},"repo":{"id":30904895,"name":"Parallax-IDE","full_name":"parallaxinc/Parallax-IDE","owner":{"login":"parallaxinc","id":1985825,"avatar_url":"https://avatars.githubusercontent.com/u/1985825?v=3","gravatar_id":"","url":"https://api.github.com/users/parallaxinc","html_url":"https://github.com/parallaxinc","followers_url":"https://api.github.com/users/parallaxinc/followers","following_url":"https://api.github.com/users/parallaxinc/following{/other_user}","gists_url":"https://api.github.com/users/parallaxinc/gists{/gist_id}","starred_url":"https://api.github.com/users/parallaxinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parallaxinc/subscriptions","organizations_url":"https://api.github.com/users/parallaxinc/orgs","repos_url":"https://api.github.com/users/parallaxinc/repos","events_url":"https://api.github.com/users/parallaxinc/events{/privacy}","received_events_url":"https://api.github.com/users/parallaxinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/parallaxinc/Parallax-IDE","description":"Parallax microcontroller development environment based on Chrome applications.","fork":false,"url":"https://api.github.com/repos/parallaxinc/Parallax-IDE","forks_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/forks","keys_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/teams","hooks_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/hooks","issue_events_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/issues/events{/number}","events_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/events","assignees_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/assignees{/user}","branches_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/branches{/branch}","tags_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/tags","blobs_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/git/refs{/sha}","trees_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/statuses/{sha}","languages_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/languages","stargazers_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/stargazers","contributors_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/contributors","subscribers_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/subscribers","subscription_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/subscription","commits_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/commits{/sha}","git_commits_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/git/commits{/sha}","comments_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/comments{/number}","issue_comment_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/issues/comments{/number}","contents_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/contents/{+path}","compare_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/merges","archive_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/downloads","issues_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/issues{/number}","pulls_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/pulls{/number}","milestones_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/milestones{/number}","notifications_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/labels{/name}","releases_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/releases{/id}","created_at":"2015-02-17T06:05:36Z","updated_at":"2015-08-12T14:37:18Z","pushed_at":"2015-09-08T22:06:21Z","git_url":"git://github.com/parallaxinc/Parallax-IDE.git","ssh_url":"git@github.com:parallaxinc/Parallax-IDE.git","clone_url":"https://github.com/parallaxinc/Parallax-IDE.git","svn_url":"https://github.com/parallaxinc/Parallax-IDE","homepage":null,"size":3451,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":63,"forks":1,"open_issues":63,"watchers":13,"default_branch":"master"}},"base":{"label":"parallaxinc:master","ref":"master","sha":"bfee8aa6c3802d05d282c7f5ee83fd308d2bb628","user":{"login":"parallaxinc","id":1985825,"avatar_url":"https://avatars.githubusercontent.com/u/1985825?v=3","gravatar_id":"","url":"https://api.github.com/users/parallaxinc","html_url":"https://github.com/parallaxinc","followers_url":"https://api.github.com/users/parallaxinc/followers","following_url":"https://api.github.com/users/parallaxinc/following{/other_user}","gists_url":"https://api.github.com/users/parallaxinc/gists{/gist_id}","starred_url":"https://api.github.com/users/parallaxinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parallaxinc/subscriptions","organizations_url":"https://api.github.com/users/parallaxinc/orgs","repos_url":"https://api.github.com/users/parallaxinc/repos","events_url":"https://api.github.com/users/parallaxinc/events{/privacy}","received_events_url":"https://api.github.com/users/parallaxinc/received_events","type":"Organization","site_admin":false},"repo":{"id":30904895,"name":"Parallax-IDE","full_name":"parallaxinc/Parallax-IDE","owner":{"login":"parallaxinc","id":1985825,"avatar_url":"https://avatars.githubusercontent.com/u/1985825?v=3","gravatar_id":"","url":"https://api.github.com/users/parallaxinc","html_url":"https://github.com/parallaxinc","followers_url":"https://api.github.com/users/parallaxinc/followers","following_url":"https://api.github.com/users/parallaxinc/following{/other_user}","gists_url":"https://api.github.com/users/parallaxinc/gists{/gist_id}","starred_url":"https://api.github.com/users/parallaxinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parallaxinc/subscriptions","organizations_url":"https://api.github.com/users/parallaxinc/orgs","repos_url":"https://api.github.com/users/parallaxinc/repos","events_url":"https://api.github.com/users/parallaxinc/events{/privacy}","received_events_url":"https://api.github.com/users/parallaxinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/parallaxinc/Parallax-IDE","description":"Parallax microcontroller development environment based on Chrome applications.","fork":false,"url":"https://api.github.com/repos/parallaxinc/Parallax-IDE","forks_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/forks","keys_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/teams","hooks_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/hooks","issue_events_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/issues/events{/number}","events_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/events","assignees_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/assignees{/user}","branches_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/branches{/branch}","tags_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/tags","blobs_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/git/refs{/sha}","trees_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/statuses/{sha}","languages_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/languages","stargazers_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/stargazers","contributors_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/contributors","subscribers_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/subscribers","subscription_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/subscription","commits_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/commits{/sha}","git_commits_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/git/commits{/sha}","comments_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/comments{/number}","issue_comment_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/issues/comments{/number}","contents_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/contents/{+path}","compare_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/merges","archive_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/downloads","issues_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/issues{/number}","pulls_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/pulls{/number}","milestones_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/milestones{/number}","notifications_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/labels{/name}","releases_url":"https://api.github.com/repos/parallaxinc/Parallax-IDE/releases{/id}","created_at":"2015-02-17T06:05:36Z","updated_at":"2015-08-12T14:37:18Z","pushed_at":"2015-09-08T22:06:21Z","git_url":"git://github.com/parallaxinc/Parallax-IDE.git","ssh_url":"git@github.com:parallaxinc/Parallax-IDE.git","clone_url":"https://github.com/parallaxinc/Parallax-IDE.git","svn_url":"https://github.com/parallaxinc/Parallax-IDE","homepage":null,"size":3451,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":63,"forks":1,"open_issues":63,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/parallaxinc/Parallax-IDE/pulls/255"},"html":{"href":"https://github.com/parallaxinc/Parallax-IDE/pull/255"},"issue":{"href":"https://api.github.com/repos/parallaxinc/Parallax-IDE/issues/255"},"comments":{"href":"https://api.github.com/repos/parallaxinc/Parallax-IDE/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/parallaxinc/Parallax-IDE/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/parallaxinc/Parallax-IDE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/parallaxinc/Parallax-IDE/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/parallaxinc/Parallax-IDE/statuses/d8babb3182cbf7fd1ebe9673509089f463ea4fc1"}}}}