{"action":"created","comment":{"url":"https://api.github.com/repos/thisissoon/FM-Frontend/pulls/comments/32540672","id":32540672,"diff_hunk":"@@ -191,6 +205,10 @@ angular.module(\"FM.player.PlayerCtrl\",[\n         $scope.$on(\"fm:player:setVolume\", $scope.onSetVolume);\n \n         $scope.getAllData();\n+\n+        $scope.$on(\"$destroy\", function(){\n+            $scope.trackPositionTimer.stop();\n+        });","path":"app/js/player/controllers/PlayerCtrl.js","position":68,"original_position":68,"commit_id":"20e0496b3f96c81c776b19854aff2f9a51d0b93d","original_commit_id":"20e0496b3f96c81c776b19854aff2f9a51d0b93d","user":{"login":"bcmrbvm","id":7836746,"avatar_url":"https://avatars.githubusercontent.com/u/7836746?v=3","gravatar_id":"","url":"https://api.github.com/users/bcmrbvm","html_url":"https://github.com/bcmrbvm","followers_url":"https://api.github.com/users/bcmrbvm/followers","following_url":"https://api.github.com/users/bcmrbvm/following{/other_user}","gists_url":"https://api.github.com/users/bcmrbvm/gists{/gist_id}","starred_url":"https://api.github.com/users/bcmrbvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcmrbvm/subscriptions","organizations_url":"https://api.github.com/users/bcmrbvm/orgs","repos_url":"https://api.github.com/users/bcmrbvm/repos","events_url":"https://api.github.com/users/bcmrbvm/events{/privacy}","received_events_url":"https://api.github.com/users/bcmrbvm/received_events","type":"User","site_admin":false},"body":"Not major but here you could just do:\r\n```javascript\r\n$scope.$on(\"$destroy\", $scope.trackPositionTimer.stop);\r\n```","created_at":"2015-06-16T16:40:23Z","updated_at":"2015-06-16T16:40:23Z","html_url":"https://github.com/thisissoon/FM-Frontend/pull/94#discussion_r32540672","pull_request_url":"https://api.github.com/repos/thisissoon/FM-Frontend/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/thisissoon/FM-Frontend/pulls/comments/32540672"},"html":{"href":"https://github.com/thisissoon/FM-Frontend/pull/94#discussion_r32540672"},"pull_request":{"href":"https://api.github.com/repos/thisissoon/FM-Frontend/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/thisissoon/FM-Frontend/pulls/94","id":37814036,"html_url":"https://github.com/thisissoon/FM-Frontend/pull/94","diff_url":"https://github.com/thisissoon/FM-Frontend/pull/94.diff","patch_url":"https://github.com/thisissoon/FM-Frontend/pull/94.patch","issue_url":"https://api.github.com/repos/thisissoon/FM-Frontend/issues/94","number":94,"state":"open","locked":false,"title":"Feature: Playback position","user":{"login":"jamesjwarren","id":1857944,"avatar_url":"https://avatars.githubusercontent.com/u/1857944?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesjwarren","html_url":"https://github.com/jamesjwarren","followers_url":"https://api.github.com/users/jamesjwarren/followers","following_url":"https://api.github.com/users/jamesjwarren/following{/other_user}","gists_url":"https://api.github.com/users/jamesjwarren/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesjwarren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesjwarren/subscriptions","organizations_url":"https://api.github.com/users/jamesjwarren/orgs","repos_url":"https://api.github.com/users/jamesjwarren/repos","events_url":"https://api.github.com/users/jamesjwarren/events{/privacy}","received_events_url":"https://api.github.com/users/jamesjwarren/received_events","type":"User","site_admin":false},"body":"# Feature: Playback position\r\nThis PR adds tracking the elapsed time for currently playing track with progress bar. Closes #84 \r\n\r\n![screenshot 2015-06-16 17 19 54](https://cloud.githubusercontent.com/assets/1857944/8188157/f93b76d6-144b-11e5-81ec-f86f3554f049.png)\r\n\r\n### TODO:\r\n- mobile?\r\n","created_at":"2015-06-16T16:26:44Z","updated_at":"2015-06-16T16:40:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a89078cdb21775d736530fc476ef8682920ad012","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thisissoon/FM-Frontend/pulls/94/commits","review_comments_url":"https://api.github.com/repos/thisissoon/FM-Frontend/pulls/94/comments","review_comment_url":"https://api.github.com/repos/thisissoon/FM-Frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thisissoon/FM-Frontend/issues/94/comments","statuses_url":"https://api.github.com/repos/thisissoon/FM-Frontend/statuses/20e0496b3f96c81c776b19854aff2f9a51d0b93d","head":{"label":"thisissoon:feature/playback-position","ref":"feature/playback-position","sha":"20e0496b3f96c81c776b19854aff2f9a51d0b93d","user":{"login":"thisissoon","id":6976199,"avatar_url":"https://avatars.githubusercontent.com/u/6976199?v=3","gravatar_id":"","url":"https://api.github.com/users/thisissoon","html_url":"https://github.com/thisissoon","followers_url":"https://api.github.com/users/thisissoon/followers","following_url":"https://api.github.com/users/thisissoon/following{/other_user}","gists_url":"https://api.github.com/users/thisissoon/gists{/gist_id}","starred_url":"https://api.github.com/users/thisissoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisissoon/subscriptions","organizations_url":"https://api.github.com/users/thisissoon/orgs","repos_url":"https://api.github.com/users/thisissoon/repos","events_url":"https://api.github.com/users/thisissoon/events{/privacy}","received_events_url":"https://api.github.com/users/thisissoon/received_events","type":"Organization","site_admin":false},"repo":{"id":31653634,"name":"FM-Frontend","full_name":"thisissoon/FM-Frontend","owner":{"login":"thisissoon","id":6976199,"avatar_url":"https://avatars.githubusercontent.com/u/6976199?v=3","gravatar_id":"","url":"https://api.github.com/users/thisissoon","html_url":"https://github.com/thisissoon","followers_url":"https://api.github.com/users/thisissoon/followers","following_url":"https://api.github.com/users/thisissoon/following{/other_user}","gists_url":"https://api.github.com/users/thisissoon/gists{/gist_id}","starred_url":"https://api.github.com/users/thisissoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisissoon/subscriptions","organizations_url":"https://api.github.com/users/thisissoon/orgs","repos_url":"https://api.github.com/users/thisissoon/repos","events_url":"https://api.github.com/users/thisissoon/events{/privacy}","received_events_url":"https://api.github.com/users/thisissoon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thisissoon/FM-Frontend","description":"Frontend for thisissoon.fm","fork":false,"url":"https://api.github.com/repos/thisissoon/FM-Frontend","forks_url":"https://api.github.com/repos/thisissoon/FM-Frontend/forks","keys_url":"https://api.github.com/repos/thisissoon/FM-Frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thisissoon/FM-Frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thisissoon/FM-Frontend/teams","hooks_url":"https://api.github.com/repos/thisissoon/FM-Frontend/hooks","issue_events_url":"https://api.github.com/repos/thisissoon/FM-Frontend/issues/events{/number}","events_url":"https://api.github.com/repos/thisissoon/FM-Frontend/events","assignees_url":"https://api.github.com/repos/thisissoon/FM-Frontend/assignees{/user}","branches_url":"https://api.github.com/repos/thisissoon/FM-Frontend/branches{/branch}","tags_url":"https://api.github.com/repos/thisissoon/FM-Frontend/tags","blobs_url":"https://api.github.com/repos/thisissoon/FM-Frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thisissoon/FM-Frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thisissoon/FM-Frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/thisissoon/FM-Frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thisissoon/FM-Frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/thisissoon/FM-Frontend/languages","stargazers_url":"https://api.github.com/repos/thisissoon/FM-Frontend/stargazers","contributors_url":"https://api.github.com/repos/thisissoon/FM-Frontend/contributors","subscribers_url":"https://api.github.com/repos/thisissoon/FM-Frontend/subscribers","subscription_url":"https://api.github.com/repos/thisissoon/FM-Frontend/subscription","commits_url":"https://api.github.com/repos/thisissoon/FM-Frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/thisissoon/FM-Frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/thisissoon/FM-Frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/thisissoon/FM-Frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/thisissoon/FM-Frontend/contents/{+path}","compare_url":"https://api.github.com/repos/thisissoon/FM-Frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thisissoon/FM-Frontend/merges","archive_url":"https://api.github.com/repos/thisissoon/FM-Frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thisissoon/FM-Frontend/downloads","issues_url":"https://api.github.com/repos/thisissoon/FM-Frontend/issues{/number}","pulls_url":"https://api.github.com/repos/thisissoon/FM-Frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/thisissoon/FM-Frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/thisissoon/FM-Frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thisissoon/FM-Frontend/labels{/name}","releases_url":"https://api.github.com/repos/thisissoon/FM-Frontend/releases{/id}","created_at":"2015-03-04T11:29:44Z","updated_at":"2015-05-07T14:25:01Z","pushed_at":"2015-06-16T16:26:45Z","git_url":"git://github.com/thisissoon/FM-Frontend.git","ssh_url":"git@github.com:thisissoon/FM-Frontend.git","clone_url":"https://github.com/thisissoon/FM-Frontend.git","svn_url":"https://github.com/thisissoon/FM-Frontend","homepage":null,"size":1468,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"base":{"label":"thisissoon:develop","ref":"develop","sha":"e83961b25cb3fd01c465ef11036939a7087ddfe6","user":{"login":"thisissoon","id":6976199,"avatar_url":"https://avatars.githubusercontent.com/u/6976199?v=3","gravatar_id":"","url":"https://api.github.com/users/thisissoon","html_url":"https://github.com/thisissoon","followers_url":"https://api.github.com/users/thisissoon/followers","following_url":"https://api.github.com/users/thisissoon/following{/other_user}","gists_url":"https://api.github.com/users/thisissoon/gists{/gist_id}","starred_url":"https://api.github.com/users/thisissoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisissoon/subscriptions","organizations_url":"https://api.github.com/users/thisissoon/orgs","repos_url":"https://api.github.com/users/thisissoon/repos","events_url":"https://api.github.com/users/thisissoon/events{/privacy}","received_events_url":"https://api.github.com/users/thisissoon/received_events","type":"Organization","site_admin":false},"repo":{"id":31653634,"name":"FM-Frontend","full_name":"thisissoon/FM-Frontend","owner":{"login":"thisissoon","id":6976199,"avatar_url":"https://avatars.githubusercontent.com/u/6976199?v=3","gravatar_id":"","url":"https://api.github.com/users/thisissoon","html_url":"https://github.com/thisissoon","followers_url":"https://api.github.com/users/thisissoon/followers","following_url":"https://api.github.com/users/thisissoon/following{/other_user}","gists_url":"https://api.github.com/users/thisissoon/gists{/gist_id}","starred_url":"https://api.github.com/users/thisissoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisissoon/subscriptions","organizations_url":"https://api.github.com/users/thisissoon/orgs","repos_url":"https://api.github.com/users/thisissoon/repos","events_url":"https://api.github.com/users/thisissoon/events{/privacy}","received_events_url":"https://api.github.com/users/thisissoon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thisissoon/FM-Frontend","description":"Frontend for thisissoon.fm","fork":false,"url":"https://api.github.com/repos/thisissoon/FM-Frontend","forks_url":"https://api.github.com/repos/thisissoon/FM-Frontend/forks","keys_url":"https://api.github.com/repos/thisissoon/FM-Frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thisissoon/FM-Frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thisissoon/FM-Frontend/teams","hooks_url":"https://api.github.com/repos/thisissoon/FM-Frontend/hooks","issue_events_url":"https://api.github.com/repos/thisissoon/FM-Frontend/issues/events{/number}","events_url":"https://api.github.com/repos/thisissoon/FM-Frontend/events","assignees_url":"https://api.github.com/repos/thisissoon/FM-Frontend/assignees{/user}","branches_url":"https://api.github.com/repos/thisissoon/FM-Frontend/branches{/branch}","tags_url":"https://api.github.com/repos/thisissoon/FM-Frontend/tags","blobs_url":"https://api.github.com/repos/thisissoon/FM-Frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thisissoon/FM-Frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thisissoon/FM-Frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/thisissoon/FM-Frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thisissoon/FM-Frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/thisissoon/FM-Frontend/languages","stargazers_url":"https://api.github.com/repos/thisissoon/FM-Frontend/stargazers","contributors_url":"https://api.github.com/repos/thisissoon/FM-Frontend/contributors","subscribers_url":"https://api.github.com/repos/thisissoon/FM-Frontend/subscribers","subscription_url":"https://api.github.com/repos/thisissoon/FM-Frontend/subscription","commits_url":"https://api.github.com/repos/thisissoon/FM-Frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/thisissoon/FM-Frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/thisissoon/FM-Frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/thisissoon/FM-Frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/thisissoon/FM-Frontend/contents/{+path}","compare_url":"https://api.github.com/repos/thisissoon/FM-Frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thisissoon/FM-Frontend/merges","archive_url":"https://api.github.com/repos/thisissoon/FM-Frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thisissoon/FM-Frontend/downloads","issues_url":"https://api.github.com/repos/thisissoon/FM-Frontend/issues{/number}","pulls_url":"https://api.github.com/repos/thisissoon/FM-Frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/thisissoon/FM-Frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/thisissoon/FM-Frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thisissoon/FM-Frontend/labels{/name}","releases_url":"https://api.github.com/repos/thisissoon/FM-Frontend/releases{/id}","created_at":"2015-03-04T11:29:44Z","updated_at":"2015-05-07T14:25:01Z","pushed_at":"2015-06-16T16:26:45Z","git_url":"git://github.com/thisissoon/FM-Frontend.git","ssh_url":"git@github.com:thisissoon/FM-Frontend.git","clone_url":"https://github.com/thisissoon/FM-Frontend.git","svn_url":"https://github.com/thisissoon/FM-Frontend","homepage":null,"size":1468,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/thisissoon/FM-Frontend/pulls/94"},"html":{"href":"https://github.com/thisissoon/FM-Frontend/pull/94"},"issue":{"href":"https://api.github.com/repos/thisissoon/FM-Frontend/issues/94"},"comments":{"href":"https://api.github.com/repos/thisissoon/FM-Frontend/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/thisissoon/FM-Frontend/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/thisissoon/FM-Frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thisissoon/FM-Frontend/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/thisissoon/FM-Frontend/statuses/20e0496b3f96c81c776b19854aff2f9a51d0b93d"}}}}