{"action":"created","comment":{"url":"https://api.github.com/repos/Alfresco/Aikau/pulls/comments/34806899","id":34806899,"diff_hunk":"@@ -1,5 +1,6 @@\n <div class=\"alfresco-notifications-AlfNotification\">\n    <div class=\"alfresco-notifications-AlfNotification__container\">\n+      <div class=\"alfresco-notifications-AlfNotification__close\" data-dojo-attach-event=\"click:_onCloseClick\">&times;</div>","path":"aikau/src/main/resources/alfresco/notifications/templates/AlfNotification.html","position":3,"original_position":3,"commit_id":"5a5351978f1b0b0b1541d47bacdd068146da8cc0","original_commit_id":"5a5351978f1b0b0b1541d47bacdd068146da8cc0","user":{"login":"MartinDoyleUK","id":2427267,"avatar_url":"https://avatars.githubusercontent.com/u/2427267?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinDoyleUK","html_url":"https://github.com/MartinDoyleUK","followers_url":"https://api.github.com/users/MartinDoyleUK/followers","following_url":"https://api.github.com/users/MartinDoyleUK/following{/other_user}","gists_url":"https://api.github.com/users/MartinDoyleUK/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinDoyleUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinDoyleUK/subscriptions","organizations_url":"https://api.github.com/users/MartinDoyleUK/orgs","repos_url":"https://api.github.com/users/MartinDoyleUK/repos","events_url":"https://api.github.com/users/MartinDoyleUK/events{/privacy}","received_events_url":"https://api.github.com/users/MartinDoyleUK/received_events","type":"User","site_admin":false},"body":"This is BEM, which is definitely intended. We use double-underscore to delineate the OO model of the code and double-hyphen to indicate states. It should not be embedding behaviour, but instead annotating by state and item and leaving the CSS to determine how it looks and the JS to determine what it does.","created_at":"2015-07-16T16:20:24Z","updated_at":"2015-07-16T16:20:24Z","html_url":"https://github.com/Alfresco/Aikau/pull/388#discussion_r34806899","pull_request_url":"https://api.github.com/repos/Alfresco/Aikau/pulls/388","_links":{"self":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/comments/34806899"},"html":{"href":"https://github.com/Alfresco/Aikau/pull/388#discussion_r34806899"},"pull_request":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/388"}}},"pull_request":{"url":"https://api.github.com/repos/Alfresco/Aikau/pulls/388","id":40128472,"html_url":"https://github.com/Alfresco/Aikau/pull/388","diff_url":"https://github.com/Alfresco/Aikau/pull/388.diff","patch_url":"https://github.com/Alfresco/Aikau/pull/388.patch","issue_url":"https://api.github.com/repos/Alfresco/Aikau/issues/388","number":388,"state":"open","locked":false,"title":"AKU-436: Notifications show off screen if scrolled","user":{"login":"MartinDoyleUK","id":2427267,"avatar_url":"https://avatars.githubusercontent.com/u/2427267?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinDoyleUK","html_url":"https://github.com/MartinDoyleUK","followers_url":"https://api.github.com/users/MartinDoyleUK/followers","following_url":"https://api.github.com/users/MartinDoyleUK/following{/other_user}","gists_url":"https://api.github.com/users/MartinDoyleUK/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinDoyleUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinDoyleUK/subscriptions","organizations_url":"https://api.github.com/users/MartinDoyleUK/orgs","repos_url":"https://api.github.com/users/MartinDoyleUK/repos","events_url":"https://api.github.com/users/MartinDoyleUK/events{/privacy}","received_events_url":"https://api.github.com/users/MartinDoyleUK/received_events","type":"User","site_admin":false},"body":"This addresses issue [AKU-436](https://issues.alfresco.com/jira/browse/AKU-436) which fixes the notifications showing off screen when scrolled by changing positioning from absolute to fixed. Have also added a requested close button on the notification.","created_at":"2015-07-16T13:25:01Z","updated_at":"2015-07-16T16:20:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15f3e889ef6c816ab32f4aaf41a466c8ca1a8d15","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Alfresco/Aikau/pulls/388/commits","review_comments_url":"https://api.github.com/repos/Alfresco/Aikau/pulls/388/comments","review_comment_url":"https://api.github.com/repos/Alfresco/Aikau/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alfresco/Aikau/issues/388/comments","statuses_url":"https://api.github.com/repos/Alfresco/Aikau/statuses/5a5351978f1b0b0b1541d47bacdd068146da8cc0","head":{"label":"Alfresco:feature/AKU-436_NoficationServiceOffScreen","ref":"feature/AKU-436_NoficationServiceOffScreen","sha":"5a5351978f1b0b0b1541d47bacdd068146da8cc0","user":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":29740360,"name":"Aikau","full_name":"Alfresco/Aikau","owner":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alfresco/Aikau","description":"Aikau UI framework","fork":false,"url":"https://api.github.com/repos/Alfresco/Aikau","forks_url":"https://api.github.com/repos/Alfresco/Aikau/forks","keys_url":"https://api.github.com/repos/Alfresco/Aikau/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/Aikau/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/Aikau/teams","hooks_url":"https://api.github.com/repos/Alfresco/Aikau/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/Aikau/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/Aikau/events","assignees_url":"https://api.github.com/repos/Alfresco/Aikau/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/Aikau/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/Aikau/tags","blobs_url":"https://api.github.com/repos/Alfresco/Aikau/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/Aikau/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/Aikau/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/Aikau/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/Aikau/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/Aikau/languages","stargazers_url":"https://api.github.com/repos/Alfresco/Aikau/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/Aikau/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/Aikau/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/Aikau/subscription","commits_url":"https://api.github.com/repos/Alfresco/Aikau/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/Aikau/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/Aikau/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/Aikau/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/Aikau/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/Aikau/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/Aikau/merges","archive_url":"https://api.github.com/repos/Alfresco/Aikau/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/Aikau/downloads","issues_url":"https://api.github.com/repos/Alfresco/Aikau/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/Aikau/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/Aikau/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/Aikau/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/Aikau/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/Aikau/releases{/id}","created_at":"2015-01-23T16:04:14Z","updated_at":"2015-07-16T06:48:21Z","pushed_at":"2015-07-16T15:43:12Z","git_url":"git://github.com/Alfresco/Aikau.git","ssh_url":"git@github.com:Alfresco/Aikau.git","clone_url":"https://github.com/Alfresco/Aikau.git","svn_url":"https://github.com/Alfresco/Aikau","homepage":null,"size":69612,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":3,"forks":19,"open_issues":3,"watchers":19,"default_branch":"master"}},"base":{"label":"Alfresco:develop","ref":"develop","sha":"da7d02ed7e9d8d5bd89ffc1cd8e359e0889cd5fc","user":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":29740360,"name":"Aikau","full_name":"Alfresco/Aikau","owner":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alfresco/Aikau","description":"Aikau UI framework","fork":false,"url":"https://api.github.com/repos/Alfresco/Aikau","forks_url":"https://api.github.com/repos/Alfresco/Aikau/forks","keys_url":"https://api.github.com/repos/Alfresco/Aikau/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/Aikau/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/Aikau/teams","hooks_url":"https://api.github.com/repos/Alfresco/Aikau/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/Aikau/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/Aikau/events","assignees_url":"https://api.github.com/repos/Alfresco/Aikau/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/Aikau/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/Aikau/tags","blobs_url":"https://api.github.com/repos/Alfresco/Aikau/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/Aikau/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/Aikau/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/Aikau/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/Aikau/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/Aikau/languages","stargazers_url":"https://api.github.com/repos/Alfresco/Aikau/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/Aikau/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/Aikau/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/Aikau/subscription","commits_url":"https://api.github.com/repos/Alfresco/Aikau/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/Aikau/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/Aikau/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/Aikau/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/Aikau/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/Aikau/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/Aikau/merges","archive_url":"https://api.github.com/repos/Alfresco/Aikau/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/Aikau/downloads","issues_url":"https://api.github.com/repos/Alfresco/Aikau/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/Aikau/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/Aikau/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/Aikau/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/Aikau/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/Aikau/releases{/id}","created_at":"2015-01-23T16:04:14Z","updated_at":"2015-07-16T06:48:21Z","pushed_at":"2015-07-16T15:43:12Z","git_url":"git://github.com/Alfresco/Aikau.git","ssh_url":"git@github.com:Alfresco/Aikau.git","clone_url":"https://github.com/Alfresco/Aikau.git","svn_url":"https://github.com/Alfresco/Aikau","homepage":null,"size":69612,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":3,"forks":19,"open_issues":3,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/388"},"html":{"href":"https://github.com/Alfresco/Aikau/pull/388"},"issue":{"href":"https://api.github.com/repos/Alfresco/Aikau/issues/388"},"comments":{"href":"https://api.github.com/repos/Alfresco/Aikau/issues/388/comments"},"review_comments":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/388/comments"},"review_comment":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/388/commits"},"statuses":{"href":"https://api.github.com/repos/Alfresco/Aikau/statuses/5a5351978f1b0b0b1541d47bacdd068146da8cc0"}}}}