{"action":"created","comment":{"url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/pulls/comments/23938606","id":23938606,"diff_hunk":"@@ -15,23 +15,8 @@ import Ember from 'ember';\n  */\n export default DS.RESTAdapter.extend({\n   defaultSerializer: \"DS/djangoREST\",\n-\n-  init: function() {\n-    this._super();\n-\n-    if (this.get('coalesceFindRequests')) {\n-      var error = \"Please ensure coalesceFindRequests is not present or set \" +\n-        \"to false in your adapter. This adapter does not support the \" +\n-        \"coalesceFindRequests option. The Django REST Framework does not \" +\n-        \"offer easy to configure support for N+1 query requests in the \" +\n-        \"format that Ember Data uses (e.g. GET /comments?ids[]=1&ids[]=2) \" +\n-        \"See the Ember documentation about coalesceFindRequests for \" +\n-        \"information about this option: \" +\n-        \"http://emberjs.com/api/data/classes/DS.RESTAdapter.html#property_coalesceFindRequests\";\n-      throw new Ember.Error(error);\n-    }\n-  },","path":"addon/adapters/drf.js","position":19,"original_position":19,"commit_id":"da7854b56e8e69dff0972faebea416ddd3662399","original_commit_id":"da7854b56e8e69dff0972faebea416ddd3662399","user":{"login":"benkonrath","id":494758,"avatar_url":"https://avatars.githubusercontent.com/u/494758?v=3","gravatar_id":"","url":"https://api.github.com/users/benkonrath","html_url":"https://github.com/benkonrath","followers_url":"https://api.github.com/users/benkonrath/followers","following_url":"https://api.github.com/users/benkonrath/following{/other_user}","gists_url":"https://api.github.com/users/benkonrath/gists{/gist_id}","starred_url":"https://api.github.com/users/benkonrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benkonrath/subscriptions","organizations_url":"https://api.github.com/users/benkonrath/orgs","repos_url":"https://api.github.com/users/benkonrath/repos","events_url":"https://api.github.com/users/benkonrath/events{/privacy}","received_events_url":"https://api.github.com/users/benkonrath/received_events","type":"User","site_admin":false},"body":"I think it would be a good idea to display a warning reminding users to implement the back-end properly when `coalesceFindRequests` is set to `true` (as you suggested in an email). There should also be a flag to disable the warning. Something like `CoalesceFilterBackendEnabled = true` could work but feel free to pick something you like (if you agree). ","created_at":"2015-02-02T17:00:11Z","updated_at":"2015-02-02T17:00:11Z","html_url":"https://github.com/dustinfarris/ember-django-adapter/pull/68#discussion_r23938606","pull_request_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/dustinfarris/ember-django-adapter/pulls/comments/23938606"},"html":{"href":"https://github.com/dustinfarris/ember-django-adapter/pull/68#discussion_r23938606"},"pull_request":{"href":"https://api.github.com/repos/dustinfarris/ember-django-adapter/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/pulls/68","id":28431472,"html_url":"https://github.com/dustinfarris/ember-django-adapter/pull/68","diff_url":"https://github.com/dustinfarris/ember-django-adapter/pull/68.diff","patch_url":"https://github.com/dustinfarris/ember-django-adapter/pull/68.patch","issue_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/issues/68","number":68,"state":"open","locked":false,"title":"Add support for coalesceFindRequests","user":{"login":"dustinfarris","id":1087165,"avatar_url":"https://avatars.githubusercontent.com/u/1087165?v=3","gravatar_id":"","url":"https://api.github.com/users/dustinfarris","html_url":"https://github.com/dustinfarris","followers_url":"https://api.github.com/users/dustinfarris/followers","following_url":"https://api.github.com/users/dustinfarris/following{/other_user}","gists_url":"https://api.github.com/users/dustinfarris/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinfarris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinfarris/subscriptions","organizations_url":"https://api.github.com/users/dustinfarris/orgs","repos_url":"https://api.github.com/users/dustinfarris/repos","events_url":"https://api.github.com/users/dustinfarris/events{/privacy}","received_events_url":"https://api.github.com/users/dustinfarris/received_events","type":"User","site_admin":false},"body":"This adds documentation that describes how to write a simple filter in DRF to support coalesced requests.  Additionally, we override `_stripIDFromURL` so that it can handle trailing slashes.\r\n\r\nThe [original `_stripIDFromURL`](https://github.com/emberjs/data/blob/master/packages/ember-data/lib/adapters/rest_adapter.js#L594-L610) implementation seems overly complicated, so I chose to simplify it down to a simple proxy to buildURL call with the record type.\r\n\r\nThanks to @g-cassie for inspiration on the DRF filter.\r\n\r\nFixes #32 ","created_at":"2015-02-01T14:05:55Z","updated_at":"2015-02-02T17:00:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad1170354a8f22307fdc7cd7530ad772d721d8ab","assignee":{"login":"benkonrath","id":494758,"avatar_url":"https://avatars.githubusercontent.com/u/494758?v=3","gravatar_id":"","url":"https://api.github.com/users/benkonrath","html_url":"https://github.com/benkonrath","followers_url":"https://api.github.com/users/benkonrath/followers","following_url":"https://api.github.com/users/benkonrath/following{/other_user}","gists_url":"https://api.github.com/users/benkonrath/gists{/gist_id}","starred_url":"https://api.github.com/users/benkonrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benkonrath/subscriptions","organizations_url":"https://api.github.com/users/benkonrath/orgs","repos_url":"https://api.github.com/users/benkonrath/repos","events_url":"https://api.github.com/users/benkonrath/events{/privacy}","received_events_url":"https://api.github.com/users/benkonrath/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/pulls/68/commits","review_comments_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/pulls/68/comments","review_comment_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/issues/68/comments","statuses_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/statuses/da7854b56e8e69dff0972faebea416ddd3662399","head":{"label":"dustinfarris:coalesce-find-requests","ref":"coalesce-find-requests","sha":"da7854b56e8e69dff0972faebea416ddd3662399","user":{"login":"dustinfarris","id":1087165,"avatar_url":"https://avatars.githubusercontent.com/u/1087165?v=3","gravatar_id":"","url":"https://api.github.com/users/dustinfarris","html_url":"https://github.com/dustinfarris","followers_url":"https://api.github.com/users/dustinfarris/followers","following_url":"https://api.github.com/users/dustinfarris/following{/other_user}","gists_url":"https://api.github.com/users/dustinfarris/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinfarris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinfarris/subscriptions","organizations_url":"https://api.github.com/users/dustinfarris/orgs","repos_url":"https://api.github.com/users/dustinfarris/repos","events_url":"https://api.github.com/users/dustinfarris/events{/privacy}","received_events_url":"https://api.github.com/users/dustinfarris/received_events","type":"User","site_admin":false},"repo":{"id":21357099,"name":"ember-django-adapter","full_name":"dustinfarris/ember-django-adapter","owner":{"login":"dustinfarris","id":1087165,"avatar_url":"https://avatars.githubusercontent.com/u/1087165?v=3","gravatar_id":"","url":"https://api.github.com/users/dustinfarris","html_url":"https://github.com/dustinfarris","followers_url":"https://api.github.com/users/dustinfarris/followers","following_url":"https://api.github.com/users/dustinfarris/following{/other_user}","gists_url":"https://api.github.com/users/dustinfarris/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinfarris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinfarris/subscriptions","organizations_url":"https://api.github.com/users/dustinfarris/orgs","repos_url":"https://api.github.com/users/dustinfarris/repos","events_url":"https://api.github.com/users/dustinfarris/events{/privacy}","received_events_url":"https://api.github.com/users/dustinfarris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dustinfarris/ember-django-adapter","description":"Ember CLI addon adapter for Django REST Framework","fork":false,"url":"https://api.github.com/repos/dustinfarris/ember-django-adapter","forks_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/forks","keys_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/teams","hooks_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/hooks","issue_events_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/events","assignees_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/tags","blobs_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/languages","stargazers_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/stargazers","contributors_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/contributors","subscribers_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/subscribers","subscription_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/subscription","commits_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/issues/comments/{number}","contents_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/merges","archive_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/downloads","issues_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/labels{/name}","releases_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/releases{/id}","created_at":"2014-06-30T15:58:50Z","updated_at":"2015-02-02T15:35:33Z","pushed_at":"2015-02-01T20:14:30Z","git_url":"git://github.com/dustinfarris/ember-django-adapter.git","ssh_url":"git@github.com:dustinfarris/ember-django-adapter.git","clone_url":"https://github.com/dustinfarris/ember-django-adapter.git","svn_url":"https://github.com/dustinfarris/ember-django-adapter","homepage":"http://dustinfarris.com/ember-django-adapter","size":1523,"stargazers_count":43,"watchers_count":43,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":8,"forks":8,"open_issues":8,"watchers":43,"default_branch":"master"}},"base":{"label":"dustinfarris:master","ref":"master","sha":"b6162631b5374ca47492cb135feb86fe97e68158","user":{"login":"dustinfarris","id":1087165,"avatar_url":"https://avatars.githubusercontent.com/u/1087165?v=3","gravatar_id":"","url":"https://api.github.com/users/dustinfarris","html_url":"https://github.com/dustinfarris","followers_url":"https://api.github.com/users/dustinfarris/followers","following_url":"https://api.github.com/users/dustinfarris/following{/other_user}","gists_url":"https://api.github.com/users/dustinfarris/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinfarris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinfarris/subscriptions","organizations_url":"https://api.github.com/users/dustinfarris/orgs","repos_url":"https://api.github.com/users/dustinfarris/repos","events_url":"https://api.github.com/users/dustinfarris/events{/privacy}","received_events_url":"https://api.github.com/users/dustinfarris/received_events","type":"User","site_admin":false},"repo":{"id":21357099,"name":"ember-django-adapter","full_name":"dustinfarris/ember-django-adapter","owner":{"login":"dustinfarris","id":1087165,"avatar_url":"https://avatars.githubusercontent.com/u/1087165?v=3","gravatar_id":"","url":"https://api.github.com/users/dustinfarris","html_url":"https://github.com/dustinfarris","followers_url":"https://api.github.com/users/dustinfarris/followers","following_url":"https://api.github.com/users/dustinfarris/following{/other_user}","gists_url":"https://api.github.com/users/dustinfarris/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinfarris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinfarris/subscriptions","organizations_url":"https://api.github.com/users/dustinfarris/orgs","repos_url":"https://api.github.com/users/dustinfarris/repos","events_url":"https://api.github.com/users/dustinfarris/events{/privacy}","received_events_url":"https://api.github.com/users/dustinfarris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dustinfarris/ember-django-adapter","description":"Ember CLI addon adapter for Django REST Framework","fork":false,"url":"https://api.github.com/repos/dustinfarris/ember-django-adapter","forks_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/forks","keys_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/teams","hooks_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/hooks","issue_events_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/events","assignees_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/tags","blobs_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/languages","stargazers_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/stargazers","contributors_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/contributors","subscribers_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/subscribers","subscription_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/subscription","commits_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/issues/comments/{number}","contents_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/merges","archive_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/downloads","issues_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/labels{/name}","releases_url":"https://api.github.com/repos/dustinfarris/ember-django-adapter/releases{/id}","created_at":"2014-06-30T15:58:50Z","updated_at":"2015-02-02T15:35:33Z","pushed_at":"2015-02-01T20:14:30Z","git_url":"git://github.com/dustinfarris/ember-django-adapter.git","ssh_url":"git@github.com:dustinfarris/ember-django-adapter.git","clone_url":"https://github.com/dustinfarris/ember-django-adapter.git","svn_url":"https://github.com/dustinfarris/ember-django-adapter","homepage":"http://dustinfarris.com/ember-django-adapter","size":1523,"stargazers_count":43,"watchers_count":43,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":8,"forks":8,"open_issues":8,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dustinfarris/ember-django-adapter/pulls/68"},"html":{"href":"https://github.com/dustinfarris/ember-django-adapter/pull/68"},"issue":{"href":"https://api.github.com/repos/dustinfarris/ember-django-adapter/issues/68"},"comments":{"href":"https://api.github.com/repos/dustinfarris/ember-django-adapter/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/dustinfarris/ember-django-adapter/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/dustinfarris/ember-django-adapter/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dustinfarris/ember-django-adapter/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/dustinfarris/ember-django-adapter/statuses/da7854b56e8e69dff0972faebea416ddd3662399"}}}}