{"action":"created","comment":{"url":"https://api.github.com/repos/gearpump/gearpump/pulls/comments/36990536","id":36990536,"diff_hunk":"@@ -2,64 +2,78 @@\n  * Licensed under the Apache License, Version 2.0","path":"services/dashboard/views/apps/apps.js","position":1,"original_position":1,"commit_id":"191bf80bb7603a0c3d9878de23bdfc577c54fd4b","original_commit_id":"191bf80bb7603a0c3d9878de23bdfc577c54fd4b","user":{"login":"kkasravi","id":146453,"avatar_url":"https://avatars.githubusercontent.com/u/146453?v=3","gravatar_id":"","url":"https://api.github.com/users/kkasravi","html_url":"https://github.com/kkasravi","followers_url":"https://api.github.com/users/kkasravi/followers","following_url":"https://api.github.com/users/kkasravi/following{/other_user}","gists_url":"https://api.github.com/users/kkasravi/gists{/gist_id}","starred_url":"https://api.github.com/users/kkasravi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkasravi/subscriptions","organizations_url":"https://api.github.com/users/kkasravi/orgs","repos_url":"https://api.github.com/users/kkasravi/repos","events_url":"https://api.github.com/users/kkasravi/events{/privacy}","received_events_url":"https://api.github.com/users/kkasravi/received_events","type":"User","site_admin":false},"body":"Yes model layer should be first - with perhaps one or two services eg restapi. Controllers could be done in later tasks and probably piecemeal as was done in #952. I know there are concerns related to using scalajs-angular. What it does is fairly straightforward and low risk if we just limit its use to controllers and a few services especially since it has released 0.5. ","created_at":"2015-08-13T15:51:49Z","updated_at":"2015-08-13T15:51:49Z","html_url":"https://github.com/gearpump/gearpump/pull/1310#discussion_r36990536","pull_request_url":"https://api.github.com/repos/gearpump/gearpump/pulls/1310","_links":{"self":{"href":"https://api.github.com/repos/gearpump/gearpump/pulls/comments/36990536"},"html":{"href":"https://github.com/gearpump/gearpump/pull/1310#discussion_r36990536"},"pull_request":{"href":"https://api.github.com/repos/gearpump/gearpump/pulls/1310"}}},"pull_request":{"url":"https://api.github.com/repos/gearpump/gearpump/pulls/1310","id":42318915,"html_url":"https://github.com/gearpump/gearpump/pull/1310","diff_url":"https://github.com/gearpump/gearpump/pull/1310.diff","patch_url":"https://github.com/gearpump/gearpump/pull/1310.patch","issue_url":"https://api.github.com/repos/gearpump/gearpump/issues/1310","number":1310,"state":"open","locked":false,"title":"Ui v2","user":{"login":"stanleyxu2005","id":5162687,"avatar_url":"https://avatars.githubusercontent.com/u/5162687?v=3","gravatar_id":"","url":"https://api.github.com/users/stanleyxu2005","html_url":"https://github.com/stanleyxu2005","followers_url":"https://api.github.com/users/stanleyxu2005/followers","following_url":"https://api.github.com/users/stanleyxu2005/following{/other_user}","gists_url":"https://api.github.com/users/stanleyxu2005/gists{/gist_id}","starred_url":"https://api.github.com/users/stanleyxu2005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanleyxu2005/subscriptions","organizations_url":"https://api.github.com/users/stanleyxu2005/orgs","repos_url":"https://api.github.com/users/stanleyxu2005/repos","events_url":"https://api.github.com/users/stanleyxu2005/events{/privacy}","received_events_url":"https://api.github.com/users/stanleyxu2005/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-13T06:33:07Z","updated_at":"2015-08-13T15:51:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82ab141e932c633f1890af6b37369e713e66d893","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gearpump/gearpump/pulls/1310/commits","review_comments_url":"https://api.github.com/repos/gearpump/gearpump/pulls/1310/comments","review_comment_url":"https://api.github.com/repos/gearpump/gearpump/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gearpump/gearpump/issues/1310/comments","statuses_url":"https://api.github.com/repos/gearpump/gearpump/statuses/191bf80bb7603a0c3d9878de23bdfc577c54fd4b","head":{"label":"stanleyxu2005:ui_v2","ref":"ui_v2","sha":"191bf80bb7603a0c3d9878de23bdfc577c54fd4b","user":{"login":"stanleyxu2005","id":5162687,"avatar_url":"https://avatars.githubusercontent.com/u/5162687?v=3","gravatar_id":"","url":"https://api.github.com/users/stanleyxu2005","html_url":"https://github.com/stanleyxu2005","followers_url":"https://api.github.com/users/stanleyxu2005/followers","following_url":"https://api.github.com/users/stanleyxu2005/following{/other_user}","gists_url":"https://api.github.com/users/stanleyxu2005/gists{/gist_id}","starred_url":"https://api.github.com/users/stanleyxu2005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanleyxu2005/subscriptions","organizations_url":"https://api.github.com/users/stanleyxu2005/orgs","repos_url":"https://api.github.com/users/stanleyxu2005/repos","events_url":"https://api.github.com/users/stanleyxu2005/events{/privacy}","received_events_url":"https://api.github.com/users/stanleyxu2005/received_events","type":"User","site_admin":false},"repo":{"id":30838760,"name":"gearpump","full_name":"stanleyxu2005/gearpump","owner":{"login":"stanleyxu2005","id":5162687,"avatar_url":"https://avatars.githubusercontent.com/u/5162687?v=3","gravatar_id":"","url":"https://api.github.com/users/stanleyxu2005","html_url":"https://github.com/stanleyxu2005","followers_url":"https://api.github.com/users/stanleyxu2005/followers","following_url":"https://api.github.com/users/stanleyxu2005/following{/other_user}","gists_url":"https://api.github.com/users/stanleyxu2005/gists{/gist_id}","starred_url":"https://api.github.com/users/stanleyxu2005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanleyxu2005/subscriptions","organizations_url":"https://api.github.com/users/stanleyxu2005/orgs","repos_url":"https://api.github.com/users/stanleyxu2005/repos","events_url":"https://api.github.com/users/stanleyxu2005/events{/privacy}","received_events_url":"https://api.github.com/users/stanleyxu2005/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stanleyxu2005/gearpump","description":"This is my private working repository for gearpump.","fork":true,"url":"https://api.github.com/repos/stanleyxu2005/gearpump","forks_url":"https://api.github.com/repos/stanleyxu2005/gearpump/forks","keys_url":"https://api.github.com/repos/stanleyxu2005/gearpump/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stanleyxu2005/gearpump/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stanleyxu2005/gearpump/teams","hooks_url":"https://api.github.com/repos/stanleyxu2005/gearpump/hooks","issue_events_url":"https://api.github.com/repos/stanleyxu2005/gearpump/issues/events{/number}","events_url":"https://api.github.com/repos/stanleyxu2005/gearpump/events","assignees_url":"https://api.github.com/repos/stanleyxu2005/gearpump/assignees{/user}","branches_url":"https://api.github.com/repos/stanleyxu2005/gearpump/branches{/branch}","tags_url":"https://api.github.com/repos/stanleyxu2005/gearpump/tags","blobs_url":"https://api.github.com/repos/stanleyxu2005/gearpump/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stanleyxu2005/gearpump/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stanleyxu2005/gearpump/git/refs{/sha}","trees_url":"https://api.github.com/repos/stanleyxu2005/gearpump/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stanleyxu2005/gearpump/statuses/{sha}","languages_url":"https://api.github.com/repos/stanleyxu2005/gearpump/languages","stargazers_url":"https://api.github.com/repos/stanleyxu2005/gearpump/stargazers","contributors_url":"https://api.github.com/repos/stanleyxu2005/gearpump/contributors","subscribers_url":"https://api.github.com/repos/stanleyxu2005/gearpump/subscribers","subscription_url":"https://api.github.com/repos/stanleyxu2005/gearpump/subscription","commits_url":"https://api.github.com/repos/stanleyxu2005/gearpump/commits{/sha}","git_commits_url":"https://api.github.com/repos/stanleyxu2005/gearpump/git/commits{/sha}","comments_url":"https://api.github.com/repos/stanleyxu2005/gearpump/comments{/number}","issue_comment_url":"https://api.github.com/repos/stanleyxu2005/gearpump/issues/comments{/number}","contents_url":"https://api.github.com/repos/stanleyxu2005/gearpump/contents/{+path}","compare_url":"https://api.github.com/repos/stanleyxu2005/gearpump/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stanleyxu2005/gearpump/merges","archive_url":"https://api.github.com/repos/stanleyxu2005/gearpump/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stanleyxu2005/gearpump/downloads","issues_url":"https://api.github.com/repos/stanleyxu2005/gearpump/issues{/number}","pulls_url":"https://api.github.com/repos/stanleyxu2005/gearpump/pulls{/number}","milestones_url":"https://api.github.com/repos/stanleyxu2005/gearpump/milestones{/number}","notifications_url":"https://api.github.com/repos/stanleyxu2005/gearpump/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stanleyxu2005/gearpump/labels{/name}","releases_url":"https://api.github.com/repos/stanleyxu2005/gearpump/releases{/id}","created_at":"2015-02-15T19:21:31Z","updated_at":"2015-05-07T15:45:53Z","pushed_at":"2015-08-13T06:32:11Z","git_url":"git://github.com/stanleyxu2005/gearpump.git","ssh_url":"git@github.com:stanleyxu2005/gearpump.git","clone_url":"https://github.com/stanleyxu2005/gearpump.git","svn_url":"https://github.com/stanleyxu2005/gearpump","homepage":"http://gearpump.io/","size":9536,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gearpump:ui_v2","ref":"ui_v2","sha":"a0d9e178996339655a3a0762114842b198f1114b","user":{"login":"gearpump","id":8586929,"avatar_url":"https://avatars.githubusercontent.com/u/8586929?v=3","gravatar_id":"","url":"https://api.github.com/users/gearpump","html_url":"https://github.com/gearpump","followers_url":"https://api.github.com/users/gearpump/followers","following_url":"https://api.github.com/users/gearpump/following{/other_user}","gists_url":"https://api.github.com/users/gearpump/gists{/gist_id}","starred_url":"https://api.github.com/users/gearpump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gearpump/subscriptions","organizations_url":"https://api.github.com/users/gearpump/orgs","repos_url":"https://api.github.com/users/gearpump/repos","events_url":"https://api.github.com/users/gearpump/events{/privacy}","received_events_url":"https://api.github.com/users/gearpump/received_events","type":"Organization","site_admin":false},"repo":{"id":22139167,"name":"gearpump","full_name":"gearpump/gearpump","owner":{"login":"gearpump","id":8586929,"avatar_url":"https://avatars.githubusercontent.com/u/8586929?v=3","gravatar_id":"","url":"https://api.github.com/users/gearpump","html_url":"https://github.com/gearpump","followers_url":"https://api.github.com/users/gearpump/followers","following_url":"https://api.github.com/users/gearpump/following{/other_user}","gists_url":"https://api.github.com/users/gearpump/gists{/gist_id}","starred_url":"https://api.github.com/users/gearpump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gearpump/subscriptions","organizations_url":"https://api.github.com/users/gearpump/orgs","repos_url":"https://api.github.com/users/gearpump/repos","events_url":"https://api.github.com/users/gearpump/events{/privacy}","received_events_url":"https://api.github.com/users/gearpump/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gearpump/gearpump","description":"Lightweight real-time big data streaming engine","fork":false,"url":"https://api.github.com/repos/gearpump/gearpump","forks_url":"https://api.github.com/repos/gearpump/gearpump/forks","keys_url":"https://api.github.com/repos/gearpump/gearpump/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gearpump/gearpump/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gearpump/gearpump/teams","hooks_url":"https://api.github.com/repos/gearpump/gearpump/hooks","issue_events_url":"https://api.github.com/repos/gearpump/gearpump/issues/events{/number}","events_url":"https://api.github.com/repos/gearpump/gearpump/events","assignees_url":"https://api.github.com/repos/gearpump/gearpump/assignees{/user}","branches_url":"https://api.github.com/repos/gearpump/gearpump/branches{/branch}","tags_url":"https://api.github.com/repos/gearpump/gearpump/tags","blobs_url":"https://api.github.com/repos/gearpump/gearpump/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gearpump/gearpump/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gearpump/gearpump/git/refs{/sha}","trees_url":"https://api.github.com/repos/gearpump/gearpump/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gearpump/gearpump/statuses/{sha}","languages_url":"https://api.github.com/repos/gearpump/gearpump/languages","stargazers_url":"https://api.github.com/repos/gearpump/gearpump/stargazers","contributors_url":"https://api.github.com/repos/gearpump/gearpump/contributors","subscribers_url":"https://api.github.com/repos/gearpump/gearpump/subscribers","subscription_url":"https://api.github.com/repos/gearpump/gearpump/subscription","commits_url":"https://api.github.com/repos/gearpump/gearpump/commits{/sha}","git_commits_url":"https://api.github.com/repos/gearpump/gearpump/git/commits{/sha}","comments_url":"https://api.github.com/repos/gearpump/gearpump/comments{/number}","issue_comment_url":"https://api.github.com/repos/gearpump/gearpump/issues/comments{/number}","contents_url":"https://api.github.com/repos/gearpump/gearpump/contents/{+path}","compare_url":"https://api.github.com/repos/gearpump/gearpump/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gearpump/gearpump/merges","archive_url":"https://api.github.com/repos/gearpump/gearpump/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gearpump/gearpump/downloads","issues_url":"https://api.github.com/repos/gearpump/gearpump/issues{/number}","pulls_url":"https://api.github.com/repos/gearpump/gearpump/pulls{/number}","milestones_url":"https://api.github.com/repos/gearpump/gearpump/milestones{/number}","notifications_url":"https://api.github.com/repos/gearpump/gearpump/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gearpump/gearpump/labels{/name}","releases_url":"https://api.github.com/repos/gearpump/gearpump/releases{/id}","created_at":"2014-07-23T08:55:26Z","updated_at":"2015-08-11T05:57:15Z","pushed_at":"2015-08-13T14:34:04Z","git_url":"git://github.com/gearpump/gearpump.git","ssh_url":"git@github.com:gearpump/gearpump.git","clone_url":"https://github.com/gearpump/gearpump.git","svn_url":"https://github.com/gearpump/gearpump","homepage":"http://gearpump.io","size":14974,"stargazers_count":321,"watchers_count":321,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":68,"forks":66,"open_issues":68,"watchers":321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gearpump/gearpump/pulls/1310"},"html":{"href":"https://github.com/gearpump/gearpump/pull/1310"},"issue":{"href":"https://api.github.com/repos/gearpump/gearpump/issues/1310"},"comments":{"href":"https://api.github.com/repos/gearpump/gearpump/issues/1310/comments"},"review_comments":{"href":"https://api.github.com/repos/gearpump/gearpump/pulls/1310/comments"},"review_comment":{"href":"https://api.github.com/repos/gearpump/gearpump/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gearpump/gearpump/pulls/1310/commits"},"statuses":{"href":"https://api.github.com/repos/gearpump/gearpump/statuses/191bf80bb7603a0c3d9878de23bdfc577c54fd4b"}}}}