{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/9658","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9658/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9658/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9658/events","html_url":"https://github.com/cms-sw/cmssw/pull/9658","id":89041097,"number":9658,"title":"Refactor RecoTrackSelector and RecoTrackRefSelector","user":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fef2c0"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_5_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51/labels","id":982516,"number":51,"title":"Next CMSSW_7_5_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":59,"closed_issues":917,"state":"open","created_at":"2015-02-17T08:21:25Z","updated_at":"2015-06-18T16:17:22Z","due_on":"2015-05-31T22:00:00Z","closed_at":null},"comments":3,"created_at":"2015-06-17T14:59:10Z","updated_at":"2015-06-18T17:27:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/9658","html_url":"https://github.com/cms-sw/cmssw/pull/9658","diff_url":"https://github.com/cms-sw/cmssw/pull/9658.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/9658.patch"},"body":"This PR refactors the commonalities of RecoTrackSelector and RecoTrackRefSelector to a new base class (RecoTrackSelectorBase; as suggested by a comment in RecoTrackRefSelector). I'm planning to add a third variant (reading tracks through View), and without the refactoring the code would become even more messy. I also took the opportunity to do a similar refactoring of the configuration parameters. I took this separate from the other developments in the hope of smoother integration for purely technical changes.\r\n\r\nTested in CMSSW_7_5_X_2015-06-14-2300, no changes expected in results.\r\n\r\n@rovere @VinInn "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/113227351","html_url":"https://github.com/cms-sw/cmssw/pull/9658#issuecomment-113227351","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9658","id":113227351,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2015-06-18T17:27:07Z","updated_at":"2015-06-18T17:27:07Z","body":"The tests are being triggered in jenkins."}}