{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/40335757","id":40335757,"diff_hunk":"@@ -310,19 +312,14 @@ private static IntPtr GetSslMethod(bool isServer, long options)\n             return method;\n         }\n \n-        //TODO See if SSL_CTX_Set_quite_shutdown can be used\n         private static void Disconnect(IntPtr sslPtr)\n         {\n             if (IntPtr.Zero != sslPtr)\n             {\n                 int retVal = libssl.SSL_shutdown(sslPtr);\n-                if (0 == retVal)\n+                if (retVal < 0)\n                 {\n-                    retVal = libssl.SSL_shutdown(sslPtr);\n-                    if (retVal < 0)\n-                    {\n-                        libssl.SSL_get_error(sslPtr, retVal);\n-                    }\n+                    libssl.SSL_get_error(sslPtr, retVal);","path":"src/Common/src/Interop/Unix/libssl/Interop.OpenSsl.cs","position":27,"original_position":27,"commit_id":"2ad4b6274da424878900d3882f1051c5289f1e9e","original_commit_id":"2ad4b6274da424878900d3882f1051c5289f1e9e","user":{"login":"bartonjs","id":10642668,"avatar_url":"https://avatars.githubusercontent.com/u/10642668?v=3","gravatar_id":"","url":"https://api.github.com/users/bartonjs","html_url":"https://github.com/bartonjs","followers_url":"https://api.github.com/users/bartonjs/followers","following_url":"https://api.github.com/users/bartonjs/following{/other_user}","gists_url":"https://api.github.com/users/bartonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bartonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartonjs/subscriptions","organizations_url":"https://api.github.com/users/bartonjs/orgs","repos_url":"https://api.github.com/users/bartonjs/repos","events_url":"https://api.github.com/users/bartonjs/events{/privacy}","received_events_url":"https://api.github.com/users/bartonjs/received_events","type":"User","site_admin":false},"body":"Well, ERR_get_error is a queue.\r\nSSL_get_error mostly reports back information on the internal state of `s` (or `sslPtr` in our calling context); it doesn't do anything with side effects that I see.","created_at":"2015-09-24T15:52:35Z","updated_at":"2015-09-24T15:52:35Z","html_url":"https://github.com/dotnet/corefx/pull/3395#discussion_r40335757","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/3395","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/40335757"},"html":{"href":"https://github.com/dotnet/corefx/pull/3395#discussion_r40335757"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3395"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/3395","id":45757022,"html_url":"https://github.com/dotnet/corefx/pull/3395","diff_url":"https://github.com/dotnet/corefx/pull/3395.diff","patch_url":"https://github.com/dotnet/corefx/pull/3395.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/3395","number":3395,"state":"closed","locked":false,"title":"adding the usage of SSL_CTX_set_quiet_shutdown","user":{"login":"shrutigarg","id":13743289,"avatar_url":"https://avatars.githubusercontent.com/u/13743289?v=3","gravatar_id":"","url":"https://api.github.com/users/shrutigarg","html_url":"https://github.com/shrutigarg","followers_url":"https://api.github.com/users/shrutigarg/followers","following_url":"https://api.github.com/users/shrutigarg/following{/other_user}","gists_url":"https://api.github.com/users/shrutigarg/gists{/gist_id}","starred_url":"https://api.github.com/users/shrutigarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrutigarg/subscriptions","organizations_url":"https://api.github.com/users/shrutigarg/orgs","repos_url":"https://api.github.com/users/shrutigarg/repos","events_url":"https://api.github.com/users/shrutigarg/events{/privacy}","received_events_url":"https://api.github.com/users/shrutigarg/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-23T09:06:51Z","updated_at":"2015-09-24T15:52:35Z","closed_at":"2015-09-23T20:15:25Z","merged_at":"2015-09-23T20:15:24Z","merge_commit_sha":"d07e90d1993719444da73e6e80027ed7348011e1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/3395/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/3395/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/3395/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/2ad4b6274da424878900d3882f1051c5289f1e9e","head":{"label":"shrutigarg:ssl","ref":"ssl","sha":"2ad4b6274da424878900d3882f1051c5289f1e9e","user":{"login":"shrutigarg","id":13743289,"avatar_url":"https://avatars.githubusercontent.com/u/13743289?v=3","gravatar_id":"","url":"https://api.github.com/users/shrutigarg","html_url":"https://github.com/shrutigarg","followers_url":"https://api.github.com/users/shrutigarg/followers","following_url":"https://api.github.com/users/shrutigarg/following{/other_user}","gists_url":"https://api.github.com/users/shrutigarg/gists{/gist_id}","starred_url":"https://api.github.com/users/shrutigarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrutigarg/subscriptions","organizations_url":"https://api.github.com/users/shrutigarg/orgs","repos_url":"https://api.github.com/users/shrutigarg/repos","events_url":"https://api.github.com/users/shrutigarg/events{/privacy}","received_events_url":"https://api.github.com/users/shrutigarg/received_events","type":"User","site_admin":false},"repo":{"id":40525181,"name":"corefx","full_name":"shrutigarg/corefx","owner":{"login":"shrutigarg","id":13743289,"avatar_url":"https://avatars.githubusercontent.com/u/13743289?v=3","gravatar_id":"","url":"https://api.github.com/users/shrutigarg","html_url":"https://github.com/shrutigarg","followers_url":"https://api.github.com/users/shrutigarg/followers","following_url":"https://api.github.com/users/shrutigarg/following{/other_user}","gists_url":"https://api.github.com/users/shrutigarg/gists{/gist_id}","starred_url":"https://api.github.com/users/shrutigarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrutigarg/subscriptions","organizations_url":"https://api.github.com/users/shrutigarg/orgs","repos_url":"https://api.github.com/users/shrutigarg/repos","events_url":"https://api.github.com/users/shrutigarg/events{/privacy}","received_events_url":"https://api.github.com/users/shrutigarg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shrutigarg/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/shrutigarg/corefx","forks_url":"https://api.github.com/repos/shrutigarg/corefx/forks","keys_url":"https://api.github.com/repos/shrutigarg/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shrutigarg/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shrutigarg/corefx/teams","hooks_url":"https://api.github.com/repos/shrutigarg/corefx/hooks","issue_events_url":"https://api.github.com/repos/shrutigarg/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/shrutigarg/corefx/events","assignees_url":"https://api.github.com/repos/shrutigarg/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/shrutigarg/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/shrutigarg/corefx/tags","blobs_url":"https://api.github.com/repos/shrutigarg/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shrutigarg/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shrutigarg/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/shrutigarg/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shrutigarg/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/shrutigarg/corefx/languages","stargazers_url":"https://api.github.com/repos/shrutigarg/corefx/stargazers","contributors_url":"https://api.github.com/repos/shrutigarg/corefx/contributors","subscribers_url":"https://api.github.com/repos/shrutigarg/corefx/subscribers","subscription_url":"https://api.github.com/repos/shrutigarg/corefx/subscription","commits_url":"https://api.github.com/repos/shrutigarg/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/shrutigarg/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/shrutigarg/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/shrutigarg/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/shrutigarg/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/shrutigarg/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shrutigarg/corefx/merges","archive_url":"https://api.github.com/repos/shrutigarg/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shrutigarg/corefx/downloads","issues_url":"https://api.github.com/repos/shrutigarg/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/shrutigarg/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/shrutigarg/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/shrutigarg/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shrutigarg/corefx/labels{/name}","releases_url":"https://api.github.com/repos/shrutigarg/corefx/releases{/id}","created_at":"2015-08-11T06:22:30Z","updated_at":"2015-08-11T06:22:48Z","pushed_at":"2015-09-24T14:47:35Z","git_url":"git://github.com/shrutigarg/corefx.git","ssh_url":"git@github.com:shrutigarg/corefx.git","clone_url":"https://github.com/shrutigarg/corefx.git","svn_url":"https://github.com/shrutigarg/corefx","homepage":"http://dotnet.github.io/core/","size":31482,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:dev-sslstream","ref":"dev-sslstream","sha":"098824a5666f5965fdf711f91b52a83cdf9d7ba7","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-09-24T13:30:32Z","pushed_at":"2015-09-24T15:47:47Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":70183,"stargazers_count":8377,"watchers_count":8377,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1808,"mirror_url":null,"open_issues_count":602,"forks":1808,"open_issues":602,"watchers":8377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3395"},"html":{"href":"https://github.com/dotnet/corefx/pull/3395"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/3395"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/3395/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3395/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3395/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/2ad4b6274da424878900d3882f1051c5289f1e9e"}}}}