{"action":"closed","number":14,"pull_request":{"url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/pulls/14","id":47145062,"html_url":"https://github.com/pofider/phantom-html-to-pdf/pull/14","diff_url":"https://github.com/pofider/phantom-html-to-pdf/pull/14.diff","patch_url":"https://github.com/pofider/phantom-html-to-pdf/pull/14.patch","issue_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/issues/14","number":14,"state":"closed","locked":false,"title":"Support waitFor and waitForTimeout","user":{"login":"PaddyMann","id":362711,"avatar_url":"https://avatars.githubusercontent.com/u/362711?v=3","gravatar_id":"","url":"https://api.github.com/users/PaddyMann","html_url":"https://github.com/PaddyMann","followers_url":"https://api.github.com/users/PaddyMann/followers","following_url":"https://api.github.com/users/PaddyMann/following{/other_user}","gists_url":"https://api.github.com/users/PaddyMann/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddyMann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddyMann/subscriptions","organizations_url":"https://api.github.com/users/PaddyMann/orgs","repos_url":"https://api.github.com/users/PaddyMann/repos","events_url":"https://api.github.com/users/PaddyMann/events{/privacy}","received_events_url":"https://api.github.com/users/PaddyMann/received_events","type":"User","site_admin":false},"body":"Adds support for `waitFor` and `waitForTimeout`:\r\n\r\n```\r\nhtmlToPdf({\r\n    waitFor: 'return window.pageLoaded === true;',\r\n    waitForTimeout: 10000\r\n});\r\n```\r\n\r\n`waitFor` is passed in as a string as it later gets JSON.stringified (and so passing in a function doesn't work).\r\n\r\nSame improvement would need to be reflected in standalone script before release.","created_at":"2015-10-08T12:16:49Z","updated_at":"2015-10-14T08:04:27Z","closed_at":"2015-10-14T08:04:27Z","merged_at":null,"merge_commit_sha":"427f2c65ba418a67dacfc881521f85db40f08b73","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/pulls/14/commits","review_comments_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/pulls/14/comments","review_comment_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/issues/14/comments","statuses_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/statuses/fbe07fb2e9626c49d1e87e83bc847aefd89cd389","head":{"label":"PaddyMann:patch-1","ref":"patch-1","sha":"fbe07fb2e9626c49d1e87e83bc847aefd89cd389","user":{"login":"PaddyMann","id":362711,"avatar_url":"https://avatars.githubusercontent.com/u/362711?v=3","gravatar_id":"","url":"https://api.github.com/users/PaddyMann","html_url":"https://github.com/PaddyMann","followers_url":"https://api.github.com/users/PaddyMann/followers","following_url":"https://api.github.com/users/PaddyMann/following{/other_user}","gists_url":"https://api.github.com/users/PaddyMann/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddyMann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddyMann/subscriptions","organizations_url":"https://api.github.com/users/PaddyMann/orgs","repos_url":"https://api.github.com/users/PaddyMann/repos","events_url":"https://api.github.com/users/PaddyMann/events{/privacy}","received_events_url":"https://api.github.com/users/PaddyMann/received_events","type":"User","site_admin":false},"repo":{"id":43876115,"name":"phantom-html-to-pdf","full_name":"PaddyMann/phantom-html-to-pdf","owner":{"login":"PaddyMann","id":362711,"avatar_url":"https://avatars.githubusercontent.com/u/362711?v=3","gravatar_id":"","url":"https://api.github.com/users/PaddyMann","html_url":"https://github.com/PaddyMann","followers_url":"https://api.github.com/users/PaddyMann/followers","following_url":"https://api.github.com/users/PaddyMann/following{/other_user}","gists_url":"https://api.github.com/users/PaddyMann/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddyMann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddyMann/subscriptions","organizations_url":"https://api.github.com/users/PaddyMann/orgs","repos_url":"https://api.github.com/users/PaddyMann/repos","events_url":"https://api.github.com/users/PaddyMann/events{/privacy}","received_events_url":"https://api.github.com/users/PaddyMann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PaddyMann/phantom-html-to-pdf","description":"Highly scalable html to pdf conversion using phantom workers","fork":true,"url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf","forks_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/forks","keys_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/teams","hooks_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/hooks","issue_events_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/issues/events{/number}","events_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/events","assignees_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/assignees{/user}","branches_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/branches{/branch}","tags_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/tags","blobs_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/statuses/{sha}","languages_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/languages","stargazers_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/stargazers","contributors_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/contributors","subscribers_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/subscribers","subscription_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/subscription","commits_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/contents/{+path}","compare_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/merges","archive_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/downloads","issues_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/issues{/number}","pulls_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/pulls{/number}","milestones_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/milestones{/number}","notifications_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/labels{/name}","releases_url":"https://api.github.com/repos/PaddyMann/phantom-html-to-pdf/releases{/id}","created_at":"2015-10-08T09:06:39Z","updated_at":"2015-10-08T09:06:40Z","pushed_at":"2015-10-08T12:15:40Z","git_url":"git://github.com/PaddyMann/phantom-html-to-pdf.git","ssh_url":"git@github.com:PaddyMann/phantom-html-to-pdf.git","clone_url":"https://github.com/PaddyMann/phantom-html-to-pdf.git","svn_url":"https://github.com/PaddyMann/phantom-html-to-pdf","homepage":null,"size":121,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pofider:master","ref":"master","sha":"021ee5e7ce5e199b0a30a2ea3eeec564927c04c4","user":{"login":"pofider","id":2041960,"avatar_url":"https://avatars.githubusercontent.com/u/2041960?v=3","gravatar_id":"","url":"https://api.github.com/users/pofider","html_url":"https://github.com/pofider","followers_url":"https://api.github.com/users/pofider/followers","following_url":"https://api.github.com/users/pofider/following{/other_user}","gists_url":"https://api.github.com/users/pofider/gists{/gist_id}","starred_url":"https://api.github.com/users/pofider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pofider/subscriptions","organizations_url":"https://api.github.com/users/pofider/orgs","repos_url":"https://api.github.com/users/pofider/repos","events_url":"https://api.github.com/users/pofider/events{/privacy}","received_events_url":"https://api.github.com/users/pofider/received_events","type":"User","site_admin":false},"repo":{"id":31734328,"name":"phantom-html-to-pdf","full_name":"pofider/phantom-html-to-pdf","owner":{"login":"pofider","id":2041960,"avatar_url":"https://avatars.githubusercontent.com/u/2041960?v=3","gravatar_id":"","url":"https://api.github.com/users/pofider","html_url":"https://github.com/pofider","followers_url":"https://api.github.com/users/pofider/followers","following_url":"https://api.github.com/users/pofider/following{/other_user}","gists_url":"https://api.github.com/users/pofider/gists{/gist_id}","starred_url":"https://api.github.com/users/pofider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pofider/subscriptions","organizations_url":"https://api.github.com/users/pofider/orgs","repos_url":"https://api.github.com/users/pofider/repos","events_url":"https://api.github.com/users/pofider/events{/privacy}","received_events_url":"https://api.github.com/users/pofider/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pofider/phantom-html-to-pdf","description":"Highly scalable html to pdf conversion using phantom workers","fork":false,"url":"https://api.github.com/repos/pofider/phantom-html-to-pdf","forks_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/forks","keys_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/teams","hooks_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/hooks","issue_events_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/issues/events{/number}","events_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/events","assignees_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/assignees{/user}","branches_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/branches{/branch}","tags_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/tags","blobs_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/git/refs{/sha}","trees_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/statuses/{sha}","languages_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/languages","stargazers_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/stargazers","contributors_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/contributors","subscribers_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/subscribers","subscription_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/subscription","commits_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/commits{/sha}","git_commits_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/git/commits{/sha}","comments_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/comments{/number}","issue_comment_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/issues/comments{/number}","contents_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/contents/{+path}","compare_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/merges","archive_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/downloads","issues_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/issues{/number}","pulls_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/pulls{/number}","milestones_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/milestones{/number}","notifications_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/labels{/name}","releases_url":"https://api.github.com/repos/pofider/phantom-html-to-pdf/releases{/id}","created_at":"2015-03-05T20:21:17Z","updated_at":"2015-10-08T07:45:09Z","pushed_at":"2015-10-13T04:22:40Z","git_url":"git://github.com/pofider/phantom-html-to-pdf.git","ssh_url":"git@github.com:pofider/phantom-html-to-pdf.git","clone_url":"https://github.com/pofider/phantom-html-to-pdf.git","svn_url":"https://github.com/pofider/phantom-html-to-pdf","homepage":null,"size":340,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pofider/phantom-html-to-pdf/pulls/14"},"html":{"href":"https://github.com/pofider/phantom-html-to-pdf/pull/14"},"issue":{"href":"https://api.github.com/repos/pofider/phantom-html-to-pdf/issues/14"},"comments":{"href":"https://api.github.com/repos/pofider/phantom-html-to-pdf/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/pofider/phantom-html-to-pdf/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/pofider/phantom-html-to-pdf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pofider/phantom-html-to-pdf/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/pofider/phantom-html-to-pdf/statuses/fbe07fb2e9626c49d1e87e83bc847aefd89cd389"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":40,"deletions":3,"changed_files":1}}