{"action":"created","comment":{"url":"https://api.github.com/repos/dpla/heidrun-mappings/pulls/comments/36446944","id":36446944,"diff_hunk":"@@ -42,25 +42,27 @@\n \n     contributor :class => DPLA::MAP::Agent,\n                 :each => record.field('mods:name')\n-                        .select { |name| name['mods:role'].map(&:value).include?('contributor') },\n+                        .select { |name| name['mods:role'].map { |v| v.value.downcase }\n+                                  .include?('contributor') },\n                 :as => :contrib do\n       providedLabel contrib.field('mods:namePart')\n     end\n \n     creator :class => DPLA::MAP::Agent,\n             :each => record.field('mods:name')\n-                    .select { |name| name['mods:role'].map(&:value).include?('creator') },\n+                    .select { |name| name['mods:role'].map { |v| v.value.downcase }\n+                              .include?('creator') },\n             :as => :creator_role do\n       providedLabel creator_role.field('mods:namePart')\n     end\n \n     date :class => DPLA::MAP::TimeSpan,\n-         :each => record.field('mods:originInfo'),\n+         :each => record.field('mods:originInfo', 'mods:dateCreated'),\n          :as => :created do\n-      providedLabel created.field('mods:dateCreated').match_attribute(:keyDate, 'yes')\n+      providedLabel created.match_attribute(:keyDate, 'yes')\n                      .reject { |date| date.attribute? :point }","path":"heidrun/esdn_mods.rb","position":26,"original_position":26,"commit_id":"9068c5bca23aaa76deac21bb0e97bf03a90b22ef","original_commit_id":"9068c5bca23aaa76deac21bb0e97bf03a90b22ef","user":{"login":"guegueng","id":10745028,"avatar_url":"https://avatars.githubusercontent.com/u/10745028?v=3","gravatar_id":"","url":"https://api.github.com/users/guegueng","html_url":"https://github.com/guegueng","followers_url":"https://api.github.com/users/guegueng/followers","following_url":"https://api.github.com/users/guegueng/following{/other_user}","gists_url":"https://api.github.com/users/guegueng/gists{/gist_id}","starred_url":"https://api.github.com/users/guegueng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guegueng/subscriptions","organizations_url":"https://api.github.com/users/guegueng/orgs","repos_url":"https://api.github.com/users/guegueng/repos","events_url":"https://api.github.com/users/guegueng/events{/privacy}","received_events_url":"https://api.github.com/users/guegueng/received_events","type":"User","site_admin":false},"body":"should this be indented further?","created_at":"2015-08-06T18:16:54Z","updated_at":"2015-08-06T18:16:54Z","html_url":"https://github.com/dpla/heidrun-mappings/pull/24#discussion_r36446944","pull_request_url":"https://api.github.com/repos/dpla/heidrun-mappings/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/dpla/heidrun-mappings/pulls/comments/36446944"},"html":{"href":"https://github.com/dpla/heidrun-mappings/pull/24#discussion_r36446944"},"pull_request":{"href":"https://api.github.com/repos/dpla/heidrun-mappings/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/dpla/heidrun-mappings/pulls/24","id":41812492,"html_url":"https://github.com/dpla/heidrun-mappings/pull/24","diff_url":"https://github.com/dpla/heidrun-mappings/pull/24.diff","patch_url":"https://github.com/dpla/heidrun-mappings/pull/24.patch","issue_url":"https://api.github.com/repos/dpla/heidrun-mappings/issues/24","number":24,"state":"open","locked":false,"title":"Adjust ESDN mapping","user":{"login":"no-reply","id":1361776,"avatar_url":"https://avatars.githubusercontent.com/u/1361776?v=3","gravatar_id":"","url":"https://api.github.com/users/no-reply","html_url":"https://github.com/no-reply","followers_url":"https://api.github.com/users/no-reply/followers","following_url":"https://api.github.com/users/no-reply/following{/other_user}","gists_url":"https://api.github.com/users/no-reply/gists{/gist_id}","starred_url":"https://api.github.com/users/no-reply/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no-reply/subscriptions","organizations_url":"https://api.github.com/users/no-reply/orgs","repos_url":"https://api.github.com/users/no-reply/repos","events_url":"https://api.github.com/users/no-reply/events{/privacy}","received_events_url":"https://api.github.com/users/no-reply/received_events","type":"User","site_admin":false},"body":"Handles case insensitivity of MODS role terms and uses correct mappings for several `originInfo` fields.\r\n\r\nThis also moves language mappings to `providedLabel`.","created_at":"2015-08-06T17:23:16Z","updated_at":"2015-08-06T18:16:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d94f7121caf04623b1fb8b90ace37d5819882088","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dpla/heidrun-mappings/pulls/24/commits","review_comments_url":"https://api.github.com/repos/dpla/heidrun-mappings/pulls/24/comments","review_comment_url":"https://api.github.com/repos/dpla/heidrun-mappings/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dpla/heidrun-mappings/issues/24/comments","statuses_url":"https://api.github.com/repos/dpla/heidrun-mappings/statuses/9068c5bca23aaa76deac21bb0e97bf03a90b22ef","head":{"label":"dpla:feature/esdn","ref":"feature/esdn","sha":"9068c5bca23aaa76deac21bb0e97bf03a90b22ef","user":{"login":"dpla","id":1252916,"avatar_url":"https://avatars.githubusercontent.com/u/1252916?v=3","gravatar_id":"","url":"https://api.github.com/users/dpla","html_url":"https://github.com/dpla","followers_url":"https://api.github.com/users/dpla/followers","following_url":"https://api.github.com/users/dpla/following{/other_user}","gists_url":"https://api.github.com/users/dpla/gists{/gist_id}","starred_url":"https://api.github.com/users/dpla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpla/subscriptions","organizations_url":"https://api.github.com/users/dpla/orgs","repos_url":"https://api.github.com/users/dpla/repos","events_url":"https://api.github.com/users/dpla/events{/privacy}","received_events_url":"https://api.github.com/users/dpla/received_events","type":"Organization","site_admin":false},"repo":{"id":31089468,"name":"heidrun-mappings","full_name":"dpla/heidrun-mappings","owner":{"login":"dpla","id":1252916,"avatar_url":"https://avatars.githubusercontent.com/u/1252916?v=3","gravatar_id":"","url":"https://api.github.com/users/dpla","html_url":"https://github.com/dpla","followers_url":"https://api.github.com/users/dpla/followers","following_url":"https://api.github.com/users/dpla/following{/other_user}","gists_url":"https://api.github.com/users/dpla/gists{/gist_id}","starred_url":"https://api.github.com/users/dpla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpla/subscriptions","organizations_url":"https://api.github.com/users/dpla/orgs","repos_url":"https://api.github.com/users/dpla/repos","events_url":"https://api.github.com/users/dpla/events{/privacy}","received_events_url":"https://api.github.com/users/dpla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dpla/heidrun-mappings","description":"Metadata mappings for the DPLA Heidrun deployment","fork":false,"url":"https://api.github.com/repos/dpla/heidrun-mappings","forks_url":"https://api.github.com/repos/dpla/heidrun-mappings/forks","keys_url":"https://api.github.com/repos/dpla/heidrun-mappings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpla/heidrun-mappings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpla/heidrun-mappings/teams","hooks_url":"https://api.github.com/repos/dpla/heidrun-mappings/hooks","issue_events_url":"https://api.github.com/repos/dpla/heidrun-mappings/issues/events{/number}","events_url":"https://api.github.com/repos/dpla/heidrun-mappings/events","assignees_url":"https://api.github.com/repos/dpla/heidrun-mappings/assignees{/user}","branches_url":"https://api.github.com/repos/dpla/heidrun-mappings/branches{/branch}","tags_url":"https://api.github.com/repos/dpla/heidrun-mappings/tags","blobs_url":"https://api.github.com/repos/dpla/heidrun-mappings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpla/heidrun-mappings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpla/heidrun-mappings/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpla/heidrun-mappings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpla/heidrun-mappings/statuses/{sha}","languages_url":"https://api.github.com/repos/dpla/heidrun-mappings/languages","stargazers_url":"https://api.github.com/repos/dpla/heidrun-mappings/stargazers","contributors_url":"https://api.github.com/repos/dpla/heidrun-mappings/contributors","subscribers_url":"https://api.github.com/repos/dpla/heidrun-mappings/subscribers","subscription_url":"https://api.github.com/repos/dpla/heidrun-mappings/subscription","commits_url":"https://api.github.com/repos/dpla/heidrun-mappings/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpla/heidrun-mappings/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpla/heidrun-mappings/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpla/heidrun-mappings/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpla/heidrun-mappings/contents/{+path}","compare_url":"https://api.github.com/repos/dpla/heidrun-mappings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpla/heidrun-mappings/merges","archive_url":"https://api.github.com/repos/dpla/heidrun-mappings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpla/heidrun-mappings/downloads","issues_url":"https://api.github.com/repos/dpla/heidrun-mappings/issues{/number}","pulls_url":"https://api.github.com/repos/dpla/heidrun-mappings/pulls{/number}","milestones_url":"https://api.github.com/repos/dpla/heidrun-mappings/milestones{/number}","notifications_url":"https://api.github.com/repos/dpla/heidrun-mappings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpla/heidrun-mappings/labels{/name}","releases_url":"https://api.github.com/repos/dpla/heidrun-mappings/releases{/id}","created_at":"2015-02-20T23:03:12Z","updated_at":"2015-07-08T13:56:06Z","pushed_at":"2015-08-06T17:55:00Z","git_url":"git://github.com/dpla/heidrun-mappings.git","ssh_url":"git@github.com:dpla/heidrun-mappings.git","clone_url":"https://github.com/dpla/heidrun-mappings.git","svn_url":"https://github.com/dpla/heidrun-mappings","homepage":"https://github.com/dpla/heidrun","size":564,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"dpla:master","ref":"master","sha":"421dcf2673886c5ee70493a7cf8424531cc86041","user":{"login":"dpla","id":1252916,"avatar_url":"https://avatars.githubusercontent.com/u/1252916?v=3","gravatar_id":"","url":"https://api.github.com/users/dpla","html_url":"https://github.com/dpla","followers_url":"https://api.github.com/users/dpla/followers","following_url":"https://api.github.com/users/dpla/following{/other_user}","gists_url":"https://api.github.com/users/dpla/gists{/gist_id}","starred_url":"https://api.github.com/users/dpla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpla/subscriptions","organizations_url":"https://api.github.com/users/dpla/orgs","repos_url":"https://api.github.com/users/dpla/repos","events_url":"https://api.github.com/users/dpla/events{/privacy}","received_events_url":"https://api.github.com/users/dpla/received_events","type":"Organization","site_admin":false},"repo":{"id":31089468,"name":"heidrun-mappings","full_name":"dpla/heidrun-mappings","owner":{"login":"dpla","id":1252916,"avatar_url":"https://avatars.githubusercontent.com/u/1252916?v=3","gravatar_id":"","url":"https://api.github.com/users/dpla","html_url":"https://github.com/dpla","followers_url":"https://api.github.com/users/dpla/followers","following_url":"https://api.github.com/users/dpla/following{/other_user}","gists_url":"https://api.github.com/users/dpla/gists{/gist_id}","starred_url":"https://api.github.com/users/dpla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpla/subscriptions","organizations_url":"https://api.github.com/users/dpla/orgs","repos_url":"https://api.github.com/users/dpla/repos","events_url":"https://api.github.com/users/dpla/events{/privacy}","received_events_url":"https://api.github.com/users/dpla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dpla/heidrun-mappings","description":"Metadata mappings for the DPLA Heidrun deployment","fork":false,"url":"https://api.github.com/repos/dpla/heidrun-mappings","forks_url":"https://api.github.com/repos/dpla/heidrun-mappings/forks","keys_url":"https://api.github.com/repos/dpla/heidrun-mappings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpla/heidrun-mappings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpla/heidrun-mappings/teams","hooks_url":"https://api.github.com/repos/dpla/heidrun-mappings/hooks","issue_events_url":"https://api.github.com/repos/dpla/heidrun-mappings/issues/events{/number}","events_url":"https://api.github.com/repos/dpla/heidrun-mappings/events","assignees_url":"https://api.github.com/repos/dpla/heidrun-mappings/assignees{/user}","branches_url":"https://api.github.com/repos/dpla/heidrun-mappings/branches{/branch}","tags_url":"https://api.github.com/repos/dpla/heidrun-mappings/tags","blobs_url":"https://api.github.com/repos/dpla/heidrun-mappings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpla/heidrun-mappings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpla/heidrun-mappings/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpla/heidrun-mappings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpla/heidrun-mappings/statuses/{sha}","languages_url":"https://api.github.com/repos/dpla/heidrun-mappings/languages","stargazers_url":"https://api.github.com/repos/dpla/heidrun-mappings/stargazers","contributors_url":"https://api.github.com/repos/dpla/heidrun-mappings/contributors","subscribers_url":"https://api.github.com/repos/dpla/heidrun-mappings/subscribers","subscription_url":"https://api.github.com/repos/dpla/heidrun-mappings/subscription","commits_url":"https://api.github.com/repos/dpla/heidrun-mappings/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpla/heidrun-mappings/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpla/heidrun-mappings/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpla/heidrun-mappings/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpla/heidrun-mappings/contents/{+path}","compare_url":"https://api.github.com/repos/dpla/heidrun-mappings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpla/heidrun-mappings/merges","archive_url":"https://api.github.com/repos/dpla/heidrun-mappings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpla/heidrun-mappings/downloads","issues_url":"https://api.github.com/repos/dpla/heidrun-mappings/issues{/number}","pulls_url":"https://api.github.com/repos/dpla/heidrun-mappings/pulls{/number}","milestones_url":"https://api.github.com/repos/dpla/heidrun-mappings/milestones{/number}","notifications_url":"https://api.github.com/repos/dpla/heidrun-mappings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpla/heidrun-mappings/labels{/name}","releases_url":"https://api.github.com/repos/dpla/heidrun-mappings/releases{/id}","created_at":"2015-02-20T23:03:12Z","updated_at":"2015-07-08T13:56:06Z","pushed_at":"2015-08-06T17:55:00Z","git_url":"git://github.com/dpla/heidrun-mappings.git","ssh_url":"git@github.com:dpla/heidrun-mappings.git","clone_url":"https://github.com/dpla/heidrun-mappings.git","svn_url":"https://github.com/dpla/heidrun-mappings","homepage":"https://github.com/dpla/heidrun","size":564,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dpla/heidrun-mappings/pulls/24"},"html":{"href":"https://github.com/dpla/heidrun-mappings/pull/24"},"issue":{"href":"https://api.github.com/repos/dpla/heidrun-mappings/issues/24"},"comments":{"href":"https://api.github.com/repos/dpla/heidrun-mappings/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/dpla/heidrun-mappings/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/dpla/heidrun-mappings/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dpla/heidrun-mappings/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/dpla/heidrun-mappings/statuses/9068c5bca23aaa76deac21bb0e97bf03a90b22ef"}}}}