{"action":"created","comment":{"url":"https://api.github.com/repos/chebfun/chebfun/pulls/comments/38767310","id":38767310,"diff_hunk":"@@ -1,65 +1,65 @@\n-function [isDone, epslevel, vscale, cutoff] = testConvergence(disc, values, vscale, pref)","path":"@opDiscretization/testConvergence.m","position":1,"original_position":1,"commit_id":"79b4f99616336981c6be099412cabb68cf456f48","original_commit_id":"3f6b8089fe173883e9b0776f3a67373b46b671e8","user":{"login":"asgeirbirkis","id":3543429,"avatar_url":"https://avatars.githubusercontent.com/u/3543429?v=3","gravatar_id":"","url":"https://api.github.com/users/asgeirbirkis","html_url":"https://github.com/asgeirbirkis","followers_url":"https://api.github.com/users/asgeirbirkis/followers","following_url":"https://api.github.com/users/asgeirbirkis/following{/other_user}","gists_url":"https://api.github.com/users/asgeirbirkis/gists{/gist_id}","starred_url":"https://api.github.com/users/asgeirbirkis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asgeirbirkis/subscriptions","organizations_url":"https://api.github.com/users/asgeirbirkis/orgs","repos_url":"https://api.github.com/users/asgeirbirkis/repos","events_url":"https://api.github.com/users/asgeirbirkis/events{/privacy}","received_events_url":"https://api.github.com/users/asgeirbirkis/received_events","type":"User","site_admin":false},"body":"Great, thanks for the clarification, happy to let this pass!","created_at":"2015-09-04T16:10:03Z","updated_at":"2015-09-04T16:10:03Z","html_url":"https://github.com/chebfun/chebfun/pull/1496#discussion_r38767310","pull_request_url":"https://api.github.com/repos/chebfun/chebfun/pulls/1496","_links":{"self":{"href":"https://api.github.com/repos/chebfun/chebfun/pulls/comments/38767310"},"html":{"href":"https://github.com/chebfun/chebfun/pull/1496#discussion_r38767310"},"pull_request":{"href":"https://api.github.com/repos/chebfun/chebfun/pulls/1496"}}},"pull_request":{"url":"https://api.github.com/repos/chebfun/chebfun/pulls/1496","id":35354445,"html_url":"https://github.com/chebfun/chebfun/pull/1496","diff_url":"https://github.com/chebfun/chebfun/pull/1496.diff","patch_url":"https://github.com/chebfun/chebfun/pull/1496.patch","issue_url":"https://api.github.com/repos/chebfun/chebfun/issues/1496","number":1496,"state":"open","locked":false,"title":"Feature trigspec","user":{"login":"Hadrien-Montanelli","id":5701816,"avatar_url":"https://avatars.githubusercontent.com/u/5701816?v=3","gravatar_id":"","url":"https://api.github.com/users/Hadrien-Montanelli","html_url":"https://github.com/Hadrien-Montanelli","followers_url":"https://api.github.com/users/Hadrien-Montanelli/followers","following_url":"https://api.github.com/users/Hadrien-Montanelli/following{/other_user}","gists_url":"https://api.github.com/users/Hadrien-Montanelli/gists{/gist_id}","starred_url":"https://api.github.com/users/Hadrien-Montanelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hadrien-Montanelli/subscriptions","organizations_url":"https://api.github.com/users/Hadrien-Montanelli/orgs","repos_url":"https://api.github.com/users/Hadrien-Montanelli/repos","events_url":"https://api.github.com/users/Hadrien-Montanelli/events{/privacy}","received_events_url":"https://api.github.com/users/Hadrien-Montanelli/received_events","type":"User","site_admin":false},"body":"This branch implements a Fourier spectral method in coefficient space for solving linear, nonlinear and system of periodic ODEs. It uses the class `trigspec`, the equivalent of `ultraS` in the Fourier world.\r\nI added a class between `chebDiscretization` and `ultraS`/`trigspec`, called `spec`, because as we could expect, these two classes share many methods.  \r\n\r\nBy default, periodic ODEs will be solved with `trigcolloc`, but one can use `trigpsec` as follows:\r\n```\r\ndom = [0 2*pi];\r\na = chebfun(@(x) sin(x) + 2, dom);\r\nf = chebfun(@(x) cos(10*x), dom, 'periodic');\r\nL = chebop(@(u) diff(u) + a.*u, dom);\r\nL.bc = 'periodic';\r\npref = cheboppref();\r\npref.discretization = 'trigspec';\r\nu = solvebvp(L, f, pref); \r\nnorm(L*u-f,inf)\r\n```\r\n\r\n```\r\nans = 1.0134e-14\r\n```","created_at":"2015-05-13T18:09:40Z","updated_at":"2015-09-04T16:10:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b095299592b1178475fb0b3ea9ca5bc26e46f47d","assignee":{"login":"asgeirbirkis","id":3543429,"avatar_url":"https://avatars.githubusercontent.com/u/3543429?v=3","gravatar_id":"","url":"https://api.github.com/users/asgeirbirkis","html_url":"https://github.com/asgeirbirkis","followers_url":"https://api.github.com/users/asgeirbirkis/followers","following_url":"https://api.github.com/users/asgeirbirkis/following{/other_user}","gists_url":"https://api.github.com/users/asgeirbirkis/gists{/gist_id}","starred_url":"https://api.github.com/users/asgeirbirkis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asgeirbirkis/subscriptions","organizations_url":"https://api.github.com/users/asgeirbirkis/orgs","repos_url":"https://api.github.com/users/asgeirbirkis/repos","events_url":"https://api.github.com/users/asgeirbirkis/events{/privacy}","received_events_url":"https://api.github.com/users/asgeirbirkis/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/chebfun/chebfun/milestones/5","html_url":"https://github.com/chebfun/chebfun/milestones/v5.3","labels_url":"https://api.github.com/repos/chebfun/chebfun/milestones/5/labels","id":945403,"number":5,"title":"v5.3","description":"New features and speeding up Chebfun.\r\n\r\nPotential new features:\r\n* Removal of epslevels and .vscale properties.\r\n* Improvements to Chebfun constructor\r\n* Trigonometrical spectral discretization\r\n* chebfun2/explain movie\r\n* firpm\r\n* NH has observed that for periodic boundary conditions we can use _any_ of the MATLAB ode solvers (for non-periodic conditions we need ODE15S or ODE23T because  they support singular mass matrices).","creator":{"login":"asgeirbirkis","id":3543429,"avatar_url":"https://avatars.githubusercontent.com/u/3543429?v=3","gravatar_id":"","url":"https://api.github.com/users/asgeirbirkis","html_url":"https://github.com/asgeirbirkis","followers_url":"https://api.github.com/users/asgeirbirkis/followers","following_url":"https://api.github.com/users/asgeirbirkis/following{/other_user}","gists_url":"https://api.github.com/users/asgeirbirkis/gists{/gist_id}","starred_url":"https://api.github.com/users/asgeirbirkis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asgeirbirkis/subscriptions","organizations_url":"https://api.github.com/users/asgeirbirkis/orgs","repos_url":"https://api.github.com/users/asgeirbirkis/repos","events_url":"https://api.github.com/users/asgeirbirkis/events{/privacy}","received_events_url":"https://api.github.com/users/asgeirbirkis/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":3,"state":"open","created_at":"2015-01-21T15:43:20Z","updated_at":"2015-08-23T15:56:10Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/chebfun/chebfun/pulls/1496/commits","review_comments_url":"https://api.github.com/repos/chebfun/chebfun/pulls/1496/comments","review_comment_url":"https://api.github.com/repos/chebfun/chebfun/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chebfun/chebfun/issues/1496/comments","statuses_url":"https://api.github.com/repos/chebfun/chebfun/statuses/79b4f99616336981c6be099412cabb68cf456f48","head":{"label":"chebfun:feature-trigspec-new","ref":"feature-trigspec-new","sha":"79b4f99616336981c6be099412cabb68cf456f48","user":{"login":"chebfun","id":3082993,"avatar_url":"https://avatars.githubusercontent.com/u/3082993?v=3","gravatar_id":"","url":"https://api.github.com/users/chebfun","html_url":"https://github.com/chebfun","followers_url":"https://api.github.com/users/chebfun/followers","following_url":"https://api.github.com/users/chebfun/following{/other_user}","gists_url":"https://api.github.com/users/chebfun/gists{/gist_id}","starred_url":"https://api.github.com/users/chebfun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chebfun/subscriptions","organizations_url":"https://api.github.com/users/chebfun/orgs","repos_url":"https://api.github.com/users/chebfun/repos","events_url":"https://api.github.com/users/chebfun/events{/privacy}","received_events_url":"https://api.github.com/users/chebfun/received_events","type":"Organization","site_admin":false},"repo":{"id":7893220,"name":"chebfun","full_name":"chebfun/chebfun","owner":{"login":"chebfun","id":3082993,"avatar_url":"https://avatars.githubusercontent.com/u/3082993?v=3","gravatar_id":"","url":"https://api.github.com/users/chebfun","html_url":"https://github.com/chebfun","followers_url":"https://api.github.com/users/chebfun/followers","following_url":"https://api.github.com/users/chebfun/following{/other_user}","gists_url":"https://api.github.com/users/chebfun/gists{/gist_id}","starred_url":"https://api.github.com/users/chebfun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chebfun/subscriptions","organizations_url":"https://api.github.com/users/chebfun/orgs","repos_url":"https://api.github.com/users/chebfun/repos","events_url":"https://api.github.com/users/chebfun/events{/privacy}","received_events_url":"https://api.github.com/users/chebfun/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chebfun/chebfun","description":"Chebfun is an open-source software system for numerical computing with functions.","fork":false,"url":"https://api.github.com/repos/chebfun/chebfun","forks_url":"https://api.github.com/repos/chebfun/chebfun/forks","keys_url":"https://api.github.com/repos/chebfun/chebfun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chebfun/chebfun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chebfun/chebfun/teams","hooks_url":"https://api.github.com/repos/chebfun/chebfun/hooks","issue_events_url":"https://api.github.com/repos/chebfun/chebfun/issues/events{/number}","events_url":"https://api.github.com/repos/chebfun/chebfun/events","assignees_url":"https://api.github.com/repos/chebfun/chebfun/assignees{/user}","branches_url":"https://api.github.com/repos/chebfun/chebfun/branches{/branch}","tags_url":"https://api.github.com/repos/chebfun/chebfun/tags","blobs_url":"https://api.github.com/repos/chebfun/chebfun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chebfun/chebfun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chebfun/chebfun/git/refs{/sha}","trees_url":"https://api.github.com/repos/chebfun/chebfun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chebfun/chebfun/statuses/{sha}","languages_url":"https://api.github.com/repos/chebfun/chebfun/languages","stargazers_url":"https://api.github.com/repos/chebfun/chebfun/stargazers","contributors_url":"https://api.github.com/repos/chebfun/chebfun/contributors","subscribers_url":"https://api.github.com/repos/chebfun/chebfun/subscribers","subscription_url":"https://api.github.com/repos/chebfun/chebfun/subscription","commits_url":"https://api.github.com/repos/chebfun/chebfun/commits{/sha}","git_commits_url":"https://api.github.com/repos/chebfun/chebfun/git/commits{/sha}","comments_url":"https://api.github.com/repos/chebfun/chebfun/comments{/number}","issue_comment_url":"https://api.github.com/repos/chebfun/chebfun/issues/comments{/number}","contents_url":"https://api.github.com/repos/chebfun/chebfun/contents/{+path}","compare_url":"https://api.github.com/repos/chebfun/chebfun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chebfun/chebfun/merges","archive_url":"https://api.github.com/repos/chebfun/chebfun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chebfun/chebfun/downloads","issues_url":"https://api.github.com/repos/chebfun/chebfun/issues{/number}","pulls_url":"https://api.github.com/repos/chebfun/chebfun/pulls{/number}","milestones_url":"https://api.github.com/repos/chebfun/chebfun/milestones{/number}","notifications_url":"https://api.github.com/repos/chebfun/chebfun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chebfun/chebfun/labels{/name}","releases_url":"https://api.github.com/repos/chebfun/chebfun/releases{/id}","created_at":"2013-01-29T13:59:55Z","updated_at":"2015-09-04T14:25:07Z","pushed_at":"2015-09-04T15:50:10Z","git_url":"git://github.com/chebfun/chebfun.git","ssh_url":"git@github.com:chebfun/chebfun.git","clone_url":"https://github.com/chebfun/chebfun.git","svn_url":"https://github.com/chebfun/chebfun","homepage":"http://www.chebfun.org/","size":39532,"stargazers_count":67,"watchers_count":67,"language":"Matlab","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":176,"forks":13,"open_issues":176,"watchers":67,"default_branch":"development"}},"base":{"label":"chebfun:development","ref":"development","sha":"882e8f32d8355302646d17ef31503588c82bfc8c","user":{"login":"chebfun","id":3082993,"avatar_url":"https://avatars.githubusercontent.com/u/3082993?v=3","gravatar_id":"","url":"https://api.github.com/users/chebfun","html_url":"https://github.com/chebfun","followers_url":"https://api.github.com/users/chebfun/followers","following_url":"https://api.github.com/users/chebfun/following{/other_user}","gists_url":"https://api.github.com/users/chebfun/gists{/gist_id}","starred_url":"https://api.github.com/users/chebfun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chebfun/subscriptions","organizations_url":"https://api.github.com/users/chebfun/orgs","repos_url":"https://api.github.com/users/chebfun/repos","events_url":"https://api.github.com/users/chebfun/events{/privacy}","received_events_url":"https://api.github.com/users/chebfun/received_events","type":"Organization","site_admin":false},"repo":{"id":7893220,"name":"chebfun","full_name":"chebfun/chebfun","owner":{"login":"chebfun","id":3082993,"avatar_url":"https://avatars.githubusercontent.com/u/3082993?v=3","gravatar_id":"","url":"https://api.github.com/users/chebfun","html_url":"https://github.com/chebfun","followers_url":"https://api.github.com/users/chebfun/followers","following_url":"https://api.github.com/users/chebfun/following{/other_user}","gists_url":"https://api.github.com/users/chebfun/gists{/gist_id}","starred_url":"https://api.github.com/users/chebfun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chebfun/subscriptions","organizations_url":"https://api.github.com/users/chebfun/orgs","repos_url":"https://api.github.com/users/chebfun/repos","events_url":"https://api.github.com/users/chebfun/events{/privacy}","received_events_url":"https://api.github.com/users/chebfun/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chebfun/chebfun","description":"Chebfun is an open-source software system for numerical computing with functions.","fork":false,"url":"https://api.github.com/repos/chebfun/chebfun","forks_url":"https://api.github.com/repos/chebfun/chebfun/forks","keys_url":"https://api.github.com/repos/chebfun/chebfun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chebfun/chebfun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chebfun/chebfun/teams","hooks_url":"https://api.github.com/repos/chebfun/chebfun/hooks","issue_events_url":"https://api.github.com/repos/chebfun/chebfun/issues/events{/number}","events_url":"https://api.github.com/repos/chebfun/chebfun/events","assignees_url":"https://api.github.com/repos/chebfun/chebfun/assignees{/user}","branches_url":"https://api.github.com/repos/chebfun/chebfun/branches{/branch}","tags_url":"https://api.github.com/repos/chebfun/chebfun/tags","blobs_url":"https://api.github.com/repos/chebfun/chebfun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chebfun/chebfun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chebfun/chebfun/git/refs{/sha}","trees_url":"https://api.github.com/repos/chebfun/chebfun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chebfun/chebfun/statuses/{sha}","languages_url":"https://api.github.com/repos/chebfun/chebfun/languages","stargazers_url":"https://api.github.com/repos/chebfun/chebfun/stargazers","contributors_url":"https://api.github.com/repos/chebfun/chebfun/contributors","subscribers_url":"https://api.github.com/repos/chebfun/chebfun/subscribers","subscription_url":"https://api.github.com/repos/chebfun/chebfun/subscription","commits_url":"https://api.github.com/repos/chebfun/chebfun/commits{/sha}","git_commits_url":"https://api.github.com/repos/chebfun/chebfun/git/commits{/sha}","comments_url":"https://api.github.com/repos/chebfun/chebfun/comments{/number}","issue_comment_url":"https://api.github.com/repos/chebfun/chebfun/issues/comments{/number}","contents_url":"https://api.github.com/repos/chebfun/chebfun/contents/{+path}","compare_url":"https://api.github.com/repos/chebfun/chebfun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chebfun/chebfun/merges","archive_url":"https://api.github.com/repos/chebfun/chebfun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chebfun/chebfun/downloads","issues_url":"https://api.github.com/repos/chebfun/chebfun/issues{/number}","pulls_url":"https://api.github.com/repos/chebfun/chebfun/pulls{/number}","milestones_url":"https://api.github.com/repos/chebfun/chebfun/milestones{/number}","notifications_url":"https://api.github.com/repos/chebfun/chebfun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chebfun/chebfun/labels{/name}","releases_url":"https://api.github.com/repos/chebfun/chebfun/releases{/id}","created_at":"2013-01-29T13:59:55Z","updated_at":"2015-09-04T14:25:07Z","pushed_at":"2015-09-04T15:50:10Z","git_url":"git://github.com/chebfun/chebfun.git","ssh_url":"git@github.com:chebfun/chebfun.git","clone_url":"https://github.com/chebfun/chebfun.git","svn_url":"https://github.com/chebfun/chebfun","homepage":"http://www.chebfun.org/","size":39532,"stargazers_count":67,"watchers_count":67,"language":"Matlab","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":176,"forks":13,"open_issues":176,"watchers":67,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/chebfun/chebfun/pulls/1496"},"html":{"href":"https://github.com/chebfun/chebfun/pull/1496"},"issue":{"href":"https://api.github.com/repos/chebfun/chebfun/issues/1496"},"comments":{"href":"https://api.github.com/repos/chebfun/chebfun/issues/1496/comments"},"review_comments":{"href":"https://api.github.com/repos/chebfun/chebfun/pulls/1496/comments"},"review_comment":{"href":"https://api.github.com/repos/chebfun/chebfun/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chebfun/chebfun/pulls/1496/commits"},"statuses":{"href":"https://api.github.com/repos/chebfun/chebfun/statuses/79b4f99616336981c6be099412cabb68cf456f48"}}}}