{"action":"created","comment":{"url":"https://api.github.com/repos/c42f/displaz/pulls/comments/31984357","id":31984357,"diff_hunk":"@@ -44,8 +44,8 @@ struct OctreeNode\n     size_t endIndex;         ///< End index of points in this node\n     mutable size_t nextBeginIndex; ///< Next index for incremental rendering\n     Imath::Box3f bbox;       ///< Actual bounding box of points in node\n-    V3f center;              ///< Centre of the node\n-    float radius;            ///< Distance to centre to node edge along an axis\n+    V3f center;              ///< center of the node","path":"src/pointarray.cpp","position":6,"original_position":6,"commit_id":"4a67a7d85421204f4381cc93f5a68f9ca4a3805e","original_commit_id":"4a67a7d85421204f4381cc93f5a68f9ca4a3805e","user":{"login":"c42f","id":601473,"avatar_url":"https://avatars.githubusercontent.com/u/601473?v=3","gravatar_id":"","url":"https://api.github.com/users/c42f","html_url":"https://github.com/c42f","followers_url":"https://api.github.com/users/c42f/followers","following_url":"https://api.github.com/users/c42f/following{/other_user}","gists_url":"https://api.github.com/users/c42f/gists{/gist_id}","starred_url":"https://api.github.com/users/c42f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c42f/subscriptions","organizations_url":"https://api.github.com/users/c42f/orgs","repos_url":"https://api.github.com/users/c42f/repos","events_url":"https://api.github.com/users/c42f/events{/privacy}","received_events_url":"https://api.github.com/users/c42f/received_events","type":"User","site_admin":false},"body":"Ok, I submit to the American spelling :)\r\n\r\n(I do agree it's much better to be consistent here.  American spelling is so ingrained in APIs in general that I've started just using it in code.)","created_at":"2015-06-09T05:56:04Z","updated_at":"2015-06-09T05:56:04Z","html_url":"https://github.com/c42f/displaz/pull/48#discussion_r31984357","pull_request_url":"https://api.github.com/repos/c42f/displaz/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/c42f/displaz/pulls/comments/31984357"},"html":{"href":"https://github.com/c42f/displaz/pull/48#discussion_r31984357"},"pull_request":{"href":"https://api.github.com/repos/c42f/displaz/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/c42f/displaz/pulls/48","id":37220641,"html_url":"https://github.com/c42f/displaz/pull/48","diff_url":"https://github.com/c42f/displaz/pull/48.diff","patch_url":"https://github.com/c42f/displaz/pull/48.patch","issue_url":"https://api.github.com/repos/c42f/displaz/issues/48","number":48,"state":"open","locked":false,"title":"New routine for closest point search","user":{"login":"gphysics","id":12788733,"avatar_url":"https://avatars.githubusercontent.com/u/12788733?v=3","gravatar_id":"","url":"https://api.github.com/users/gphysics","html_url":"https://github.com/gphysics","followers_url":"https://api.github.com/users/gphysics/followers","following_url":"https://api.github.com/users/gphysics/following{/other_user}","gists_url":"https://api.github.com/users/gphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/gphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gphysics/subscriptions","organizations_url":"https://api.github.com/users/gphysics/orgs","repos_url":"https://api.github.com/users/gphysics/repos","events_url":"https://api.github.com/users/gphysics/events{/privacy}","received_events_url":"https://api.github.com/users/gphysics/received_events","type":"User","site_admin":false},"body":"Both old and new methods called for timing comparisons.  Need to delete unnecessary call to old method.","created_at":"2015-06-09T05:30:45Z","updated_at":"2015-06-09T05:56:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16d313b7187a9d7e1ba94cec57f013e832ffdc43","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/c42f/displaz/pulls/48/commits","review_comments_url":"https://api.github.com/repos/c42f/displaz/pulls/48/comments","review_comment_url":"https://api.github.com/repos/c42f/displaz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/c42f/displaz/issues/48/comments","statuses_url":"https://api.github.com/repos/c42f/displaz/statuses/4a67a7d85421204f4381cc93f5a68f9ca4a3805e","head":{"label":"gphysics:closest_point_optimisation","ref":"closest_point_optimisation","sha":"4a67a7d85421204f4381cc93f5a68f9ca4a3805e","user":{"login":"gphysics","id":12788733,"avatar_url":"https://avatars.githubusercontent.com/u/12788733?v=3","gravatar_id":"","url":"https://api.github.com/users/gphysics","html_url":"https://github.com/gphysics","followers_url":"https://api.github.com/users/gphysics/followers","following_url":"https://api.github.com/users/gphysics/following{/other_user}","gists_url":"https://api.github.com/users/gphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/gphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gphysics/subscriptions","organizations_url":"https://api.github.com/users/gphysics/orgs","repos_url":"https://api.github.com/users/gphysics/repos","events_url":"https://api.github.com/users/gphysics/events{/privacy}","received_events_url":"https://api.github.com/users/gphysics/received_events","type":"User","site_admin":false},"repo":{"id":37111413,"name":"displaz","full_name":"gphysics/displaz","owner":{"login":"gphysics","id":12788733,"avatar_url":"https://avatars.githubusercontent.com/u/12788733?v=3","gravatar_id":"","url":"https://api.github.com/users/gphysics","html_url":"https://github.com/gphysics","followers_url":"https://api.github.com/users/gphysics/followers","following_url":"https://api.github.com/users/gphysics/following{/other_user}","gists_url":"https://api.github.com/users/gphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/gphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gphysics/subscriptions","organizations_url":"https://api.github.com/users/gphysics/orgs","repos_url":"https://api.github.com/users/gphysics/repos","events_url":"https://api.github.com/users/gphysics/events{/privacy}","received_events_url":"https://api.github.com/users/gphysics/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gphysics/displaz","description":"A las viewer for geospatial lidar data","fork":true,"url":"https://api.github.com/repos/gphysics/displaz","forks_url":"https://api.github.com/repos/gphysics/displaz/forks","keys_url":"https://api.github.com/repos/gphysics/displaz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gphysics/displaz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gphysics/displaz/teams","hooks_url":"https://api.github.com/repos/gphysics/displaz/hooks","issue_events_url":"https://api.github.com/repos/gphysics/displaz/issues/events{/number}","events_url":"https://api.github.com/repos/gphysics/displaz/events","assignees_url":"https://api.github.com/repos/gphysics/displaz/assignees{/user}","branches_url":"https://api.github.com/repos/gphysics/displaz/branches{/branch}","tags_url":"https://api.github.com/repos/gphysics/displaz/tags","blobs_url":"https://api.github.com/repos/gphysics/displaz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gphysics/displaz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gphysics/displaz/git/refs{/sha}","trees_url":"https://api.github.com/repos/gphysics/displaz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gphysics/displaz/statuses/{sha}","languages_url":"https://api.github.com/repos/gphysics/displaz/languages","stargazers_url":"https://api.github.com/repos/gphysics/displaz/stargazers","contributors_url":"https://api.github.com/repos/gphysics/displaz/contributors","subscribers_url":"https://api.github.com/repos/gphysics/displaz/subscribers","subscription_url":"https://api.github.com/repos/gphysics/displaz/subscription","commits_url":"https://api.github.com/repos/gphysics/displaz/commits{/sha}","git_commits_url":"https://api.github.com/repos/gphysics/displaz/git/commits{/sha}","comments_url":"https://api.github.com/repos/gphysics/displaz/comments{/number}","issue_comment_url":"https://api.github.com/repos/gphysics/displaz/issues/comments{/number}","contents_url":"https://api.github.com/repos/gphysics/displaz/contents/{+path}","compare_url":"https://api.github.com/repos/gphysics/displaz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gphysics/displaz/merges","archive_url":"https://api.github.com/repos/gphysics/displaz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gphysics/displaz/downloads","issues_url":"https://api.github.com/repos/gphysics/displaz/issues{/number}","pulls_url":"https://api.github.com/repos/gphysics/displaz/pulls{/number}","milestones_url":"https://api.github.com/repos/gphysics/displaz/milestones{/number}","notifications_url":"https://api.github.com/repos/gphysics/displaz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gphysics/displaz/labels{/name}","releases_url":"https://api.github.com/repos/gphysics/displaz/releases{/id}","created_at":"2015-06-09T05:06:02Z","updated_at":"2015-06-09T05:06:02Z","pushed_at":"2015-06-09T05:24:06Z","git_url":"git://github.com/gphysics/displaz.git","ssh_url":"git@github.com:gphysics/displaz.git","clone_url":"https://github.com/gphysics/displaz.git","svn_url":"https://github.com/gphysics/displaz","homepage":"http://c42f.github.io/displaz","size":1452,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"c42f:master","ref":"master","sha":"115cb3b8194ac08807c3ce752efc20a2eb7adb40","user":{"login":"c42f","id":601473,"avatar_url":"https://avatars.githubusercontent.com/u/601473?v=3","gravatar_id":"","url":"https://api.github.com/users/c42f","html_url":"https://github.com/c42f","followers_url":"https://api.github.com/users/c42f/followers","following_url":"https://api.github.com/users/c42f/following{/other_user}","gists_url":"https://api.github.com/users/c42f/gists{/gist_id}","starred_url":"https://api.github.com/users/c42f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c42f/subscriptions","organizations_url":"https://api.github.com/users/c42f/orgs","repos_url":"https://api.github.com/users/c42f/repos","events_url":"https://api.github.com/users/c42f/events{/privacy}","received_events_url":"https://api.github.com/users/c42f/received_events","type":"User","site_admin":false},"repo":{"id":6596947,"name":"displaz","full_name":"c42f/displaz","owner":{"login":"c42f","id":601473,"avatar_url":"https://avatars.githubusercontent.com/u/601473?v=3","gravatar_id":"","url":"https://api.github.com/users/c42f","html_url":"https://github.com/c42f","followers_url":"https://api.github.com/users/c42f/followers","following_url":"https://api.github.com/users/c42f/following{/other_user}","gists_url":"https://api.github.com/users/c42f/gists{/gist_id}","starred_url":"https://api.github.com/users/c42f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c42f/subscriptions","organizations_url":"https://api.github.com/users/c42f/orgs","repos_url":"https://api.github.com/users/c42f/repos","events_url":"https://api.github.com/users/c42f/events{/privacy}","received_events_url":"https://api.github.com/users/c42f/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/c42f/displaz","description":"A las viewer for geospatial lidar data","fork":false,"url":"https://api.github.com/repos/c42f/displaz","forks_url":"https://api.github.com/repos/c42f/displaz/forks","keys_url":"https://api.github.com/repos/c42f/displaz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c42f/displaz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c42f/displaz/teams","hooks_url":"https://api.github.com/repos/c42f/displaz/hooks","issue_events_url":"https://api.github.com/repos/c42f/displaz/issues/events{/number}","events_url":"https://api.github.com/repos/c42f/displaz/events","assignees_url":"https://api.github.com/repos/c42f/displaz/assignees{/user}","branches_url":"https://api.github.com/repos/c42f/displaz/branches{/branch}","tags_url":"https://api.github.com/repos/c42f/displaz/tags","blobs_url":"https://api.github.com/repos/c42f/displaz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c42f/displaz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c42f/displaz/git/refs{/sha}","trees_url":"https://api.github.com/repos/c42f/displaz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c42f/displaz/statuses/{sha}","languages_url":"https://api.github.com/repos/c42f/displaz/languages","stargazers_url":"https://api.github.com/repos/c42f/displaz/stargazers","contributors_url":"https://api.github.com/repos/c42f/displaz/contributors","subscribers_url":"https://api.github.com/repos/c42f/displaz/subscribers","subscription_url":"https://api.github.com/repos/c42f/displaz/subscription","commits_url":"https://api.github.com/repos/c42f/displaz/commits{/sha}","git_commits_url":"https://api.github.com/repos/c42f/displaz/git/commits{/sha}","comments_url":"https://api.github.com/repos/c42f/displaz/comments{/number}","issue_comment_url":"https://api.github.com/repos/c42f/displaz/issues/comments{/number}","contents_url":"https://api.github.com/repos/c42f/displaz/contents/{+path}","compare_url":"https://api.github.com/repos/c42f/displaz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c42f/displaz/merges","archive_url":"https://api.github.com/repos/c42f/displaz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c42f/displaz/downloads","issues_url":"https://api.github.com/repos/c42f/displaz/issues{/number}","pulls_url":"https://api.github.com/repos/c42f/displaz/pulls{/number}","milestones_url":"https://api.github.com/repos/c42f/displaz/milestones{/number}","notifications_url":"https://api.github.com/repos/c42f/displaz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c42f/displaz/labels{/name}","releases_url":"https://api.github.com/repos/c42f/displaz/releases{/id}","created_at":"2012-11-08T13:48:08Z","updated_at":"2015-05-17T10:03:24Z","pushed_at":"2015-06-09T05:52:04Z","git_url":"git://github.com/c42f/displaz.git","ssh_url":"git@github.com:c42f/displaz.git","clone_url":"https://github.com/c42f/displaz.git","svn_url":"https://github.com/c42f/displaz","homepage":"http://c42f.github.io/displaz","size":2540,"stargazers_count":18,"watchers_count":18,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":23,"forks":11,"open_issues":23,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/c42f/displaz/pulls/48"},"html":{"href":"https://github.com/c42f/displaz/pull/48"},"issue":{"href":"https://api.github.com/repos/c42f/displaz/issues/48"},"comments":{"href":"https://api.github.com/repos/c42f/displaz/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/c42f/displaz/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/c42f/displaz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/c42f/displaz/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/c42f/displaz/statuses/4a67a7d85421204f4381cc93f5a68f9ca4a3805e"}}}}