{"action":"closed","number":49,"pull_request":{"url":"https://api.github.com/repos/NetEase/Dagger/pulls/49","id":44511424,"html_url":"https://github.com/NetEase/Dagger/pull/49","diff_url":"https://github.com/NetEase/Dagger/pull/49.diff","patch_url":"https://github.com/NetEase/Dagger/pull/49.patch","issue_url":"https://api.github.com/repos/NetEase/Dagger/issues/49","number":49,"state":"closed","locked":false,"title":"add firefox binary path config","user":{"login":"hustcc","id":7856674,"avatar_url":"https://avatars.githubusercontent.com/u/7856674?v=3","gravatar_id":"","url":"https://api.github.com/users/hustcc","html_url":"https://github.com/hustcc","followers_url":"https://api.github.com/users/hustcc/followers","following_url":"https://api.github.com/users/hustcc/following{/other_user}","gists_url":"https://api.github.com/users/hustcc/gists{/gist_id}","starred_url":"https://api.github.com/users/hustcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hustcc/subscriptions","organizations_url":"https://api.github.com/users/hustcc/orgs","repos_url":"https://api.github.com/users/hustcc/repos","events_url":"https://api.github.com/users/hustcc/events{/privacy}","received_events_url":"https://api.github.com/users/hustcc/received_events","type":"User","site_admin":false},"body":"当我使用dagger + firefox来做web自动化的时候，出现错误：\r\nException in thread \"main\" org.openqa.selenium.WebDriverException: Cannot find firefox binary in PATH. Make sure firefox is installed. OS appears to be: VISTA\r\n\r\n这是因为找不到firefox的exe地址（win平台），同时也没有一个地方去配置firefox路径，所以进行上上述修改，增加了firefox binary path配置项，同时修改BrowserEmulator中FirefoxDriver的构造，使用带GlobalSettings的配置参数构造，已经可以使用。","created_at":"2015-09-09T05:17:33Z","updated_at":"2015-11-09T05:25:05Z","closed_at":"2015-11-09T05:25:05Z","merged_at":null,"merge_commit_sha":"674deb3eed02d8e9f7484b66f009a475db396980","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NetEase/Dagger/pulls/49/commits","review_comments_url":"https://api.github.com/repos/NetEase/Dagger/pulls/49/comments","review_comment_url":"https://api.github.com/repos/NetEase/Dagger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NetEase/Dagger/issues/49/comments","statuses_url":"https://api.github.com/repos/NetEase/Dagger/statuses/f7f1831107b43fdaa6a4b6fd56b535b622be8762","head":{"label":"hustcc:dev","ref":"dev","sha":"f7f1831107b43fdaa6a4b6fd56b535b622be8762","user":{"login":"hustcc","id":7856674,"avatar_url":"https://avatars.githubusercontent.com/u/7856674?v=3","gravatar_id":"","url":"https://api.github.com/users/hustcc","html_url":"https://github.com/hustcc","followers_url":"https://api.github.com/users/hustcc/followers","following_url":"https://api.github.com/users/hustcc/following{/other_user}","gists_url":"https://api.github.com/users/hustcc/gists{/gist_id}","starred_url":"https://api.github.com/users/hustcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hustcc/subscriptions","organizations_url":"https://api.github.com/users/hustcc/orgs","repos_url":"https://api.github.com/users/hustcc/repos","events_url":"https://api.github.com/users/hustcc/events{/privacy}","received_events_url":"https://api.github.com/users/hustcc/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"NetEase:master","ref":"master","sha":"e15a51d3068c35263e2dfbe3c45f10644a6abb3c","user":{"login":"NetEase","id":1460597,"avatar_url":"https://avatars.githubusercontent.com/u/1460597?v=3","gravatar_id":"","url":"https://api.github.com/users/NetEase","html_url":"https://github.com/NetEase","followers_url":"https://api.github.com/users/NetEase/followers","following_url":"https://api.github.com/users/NetEase/following{/other_user}","gists_url":"https://api.github.com/users/NetEase/gists{/gist_id}","starred_url":"https://api.github.com/users/NetEase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetEase/subscriptions","organizations_url":"https://api.github.com/users/NetEase/orgs","repos_url":"https://api.github.com/users/NetEase/repos","events_url":"https://api.github.com/users/NetEase/events{/privacy}","received_events_url":"https://api.github.com/users/NetEase/received_events","type":"Organization","site_admin":false},"repo":{"id":7554523,"name":"Dagger","full_name":"NetEase/Dagger","owner":{"login":"NetEase","id":1460597,"avatar_url":"https://avatars.githubusercontent.com/u/1460597?v=3","gravatar_id":"","url":"https://api.github.com/users/NetEase","html_url":"https://github.com/NetEase","followers_url":"https://api.github.com/users/NetEase/followers","following_url":"https://api.github.com/users/NetEase/following{/other_user}","gists_url":"https://api.github.com/users/NetEase/gists{/gist_id}","starred_url":"https://api.github.com/users/NetEase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetEase/subscriptions","organizations_url":"https://api.github.com/users/NetEase/orgs","repos_url":"https://api.github.com/users/NetEase/repos","events_url":"https://api.github.com/users/NetEase/events{/privacy}","received_events_url":"https://api.github.com/users/NetEase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NetEase/Dagger","description":"a Web UI autotest framework based on Selenium and TestNg","fork":true,"url":"https://api.github.com/repos/NetEase/Dagger","forks_url":"https://api.github.com/repos/NetEase/Dagger/forks","keys_url":"https://api.github.com/repos/NetEase/Dagger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetEase/Dagger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetEase/Dagger/teams","hooks_url":"https://api.github.com/repos/NetEase/Dagger/hooks","issue_events_url":"https://api.github.com/repos/NetEase/Dagger/issues/events{/number}","events_url":"https://api.github.com/repos/NetEase/Dagger/events","assignees_url":"https://api.github.com/repos/NetEase/Dagger/assignees{/user}","branches_url":"https://api.github.com/repos/NetEase/Dagger/branches{/branch}","tags_url":"https://api.github.com/repos/NetEase/Dagger/tags","blobs_url":"https://api.github.com/repos/NetEase/Dagger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetEase/Dagger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetEase/Dagger/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetEase/Dagger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetEase/Dagger/statuses/{sha}","languages_url":"https://api.github.com/repos/NetEase/Dagger/languages","stargazers_url":"https://api.github.com/repos/NetEase/Dagger/stargazers","contributors_url":"https://api.github.com/repos/NetEase/Dagger/contributors","subscribers_url":"https://api.github.com/repos/NetEase/Dagger/subscribers","subscription_url":"https://api.github.com/repos/NetEase/Dagger/subscription","commits_url":"https://api.github.com/repos/NetEase/Dagger/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetEase/Dagger/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetEase/Dagger/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetEase/Dagger/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetEase/Dagger/contents/{+path}","compare_url":"https://api.github.com/repos/NetEase/Dagger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetEase/Dagger/merges","archive_url":"https://api.github.com/repos/NetEase/Dagger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetEase/Dagger/downloads","issues_url":"https://api.github.com/repos/NetEase/Dagger/issues{/number}","pulls_url":"https://api.github.com/repos/NetEase/Dagger/pulls{/number}","milestones_url":"https://api.github.com/repos/NetEase/Dagger/milestones{/number}","notifications_url":"https://api.github.com/repos/NetEase/Dagger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetEase/Dagger/labels{/name}","releases_url":"https://api.github.com/repos/NetEase/Dagger/releases{/id}","created_at":"2013-01-11T05:18:47Z","updated_at":"2015-11-02T07:08:01Z","pushed_at":"2015-10-02T08:41:56Z","git_url":"git://github.com/NetEase/Dagger.git","ssh_url":"git@github.com:NetEase/Dagger.git","clone_url":"https://github.com/NetEase/Dagger.git","svn_url":"https://github.com/NetEase/Dagger","homepage":"","size":71952,"stargazers_count":249,"watchers_count":249,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":124,"mirror_url":null,"open_issues_count":17,"forks":124,"open_issues":17,"watchers":249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NetEase/Dagger/pulls/49"},"html":{"href":"https://github.com/NetEase/Dagger/pull/49"},"issue":{"href":"https://api.github.com/repos/NetEase/Dagger/issues/49"},"comments":{"href":"https://api.github.com/repos/NetEase/Dagger/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/NetEase/Dagger/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/NetEase/Dagger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NetEase/Dagger/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/NetEase/Dagger/statuses/f7f1831107b43fdaa6a4b6fd56b535b622be8762"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":1,"commits":1,"additions":14,"deletions":9,"changed_files":3}}