{"action":"opened","number":131,"pull_request":{"url":"https://api.github.com/repos/python-excel/xlrd/pulls/131","id":30584980,"html_url":"https://github.com/python-excel/xlrd/pull/131","diff_url":"https://github.com/python-excel/xlrd/pull/131.diff","patch_url":"https://github.com/python-excel/xlrd/pull/131.patch","issue_url":"https://api.github.com/repos/python-excel/xlrd/issues/131","number":131,"state":"open","locked":false,"title":"NoneType zoom variable causes crash","user":{"login":"patrickfuller","id":1449833,"avatar_url":"https://avatars.githubusercontent.com/u/1449833?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickfuller","html_url":"https://github.com/patrickfuller","followers_url":"https://api.github.com/users/patrickfuller/followers","following_url":"https://api.github.com/users/patrickfuller/following{/other_user}","gists_url":"https://api.github.com/users/patrickfuller/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickfuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickfuller/subscriptions","organizations_url":"https://api.github.com/users/patrickfuller/orgs","repos_url":"https://api.github.com/users/patrickfuller/repos","events_url":"https://api.github.com/users/patrickfuller/events{/privacy}","received_events_url":"https://api.github.com/users/patrickfuller/received_events","type":"User","site_admin":false},"body":"I'm working with some old third-party software that outputs its own flavor of .xls. A sample file can be downloaded with:\r\n\r\n```\r\nwget https://www.dropbox.com/s/japk6uv4u1js7sz/xlrd_test.XLS \r\n```\r\n\r\nTo replicate:\r\n\r\n```python\r\nimport xlrd\r\nwb = xlrd.open_workbook(\"xlrd_test.XLS\", encoding_override=\"latin-1\", verbosity=1)\r\n```\r\n\r\nStack trace:\r\n\r\n```python\r\n---------------------------------------------------------------------------\r\nTypeError                                 Traceback (most recent call last)\r\n<ipython-input-2-22e058971f78> in <module>()\r\n----> 1 wb = xlrd.open_workbook(\"xlrd_test.XLS\", encoding_override=\"latin-1\", verbosity=1)\r\n\r\n/home/patrick/miniconda3/lib/python3.4/site-packages/xlrd/__init__.py in open_workbook(filename, logfile, verbosity, use_mmap, file_contents, encoding_override, formatting_info, on_demand, ragged_rows)\r\n    433         formatting_info=formatting_info,\r\n    434         on_demand=on_demand,\r\n--> 435         ragged_rows=ragged_rows,\r\n    436         )\r\n    437     return bk\r\n\r\n/home/patrick/miniconda3/lib/python3.4/site-packages/xlrd/book.py in open_workbook_xls(filename, logfile, verbosity, use_mmap, file_contents, encoding_override, formatting_info, on_demand, ragged_rows)\r\n    105                     \"*** Setting on_demand to False.\\n\")\r\n    106                 bk.on_demand = on_demand = False\r\n--> 107             bk.fake_globals_get_sheet()\r\n    108         elif biff_version == 45:\r\n    109             # worksheet(s) embedded in global stream\r\n\r\n/home/patrick/miniconda3/lib/python3.4/site-packages/xlrd/book.py in fake_globals_get_sheet(self)\r\n    685         self._sheet_visibility = [0] # one sheet, visible\r\n    686         self._sheet_list.append(None) # get_sheet updates _sheet_list but needs a None beforehand\r\n--> 687         self.get_sheets()\r\n    688 \r\n    689     def handle_boundsheet(self, data):\r\n\r\n/home/patrick/miniconda3/lib/python3.4/site-packages/xlrd/book.py in get_sheets(self)\r\n    676         for sheetno in xrange(len(self._sheet_names)):\r\n    677             if DEBUG: print(\"GET_SHEETS: sheetno =\", sheetno, self._sheet_names, self._sh_abs_posn, file=self.logfile)\r\n--> 678             self.get_sheet(sheetno)\r\n    679 \r\n    680     def fake_globals_get_sheet(self): # for BIFF 4.0 and earlier\r\n\r\n/home/patrick/miniconda3/lib/python3.4/site-packages/xlrd/book.py in get_sheet(self, sh_number, update_pos)\r\n    667                 sh_number,\r\n    668                 )\r\n--> 669         sh.read(self)\r\n    670         self._sheet_list[sh_number] = sh\r\n    671         return sh\r\n\r\n/home/patrick/miniconda3/lib/python3.4/site-packages/xlrd/sheet.py in read(self, bk)\r\n   1468                 % (self.number, self.name))\r\n   1469         self.tidy_dimensions()\r\n-> 1470         self.update_cooked_mag_factors()\r\n   1471         bk._position = oldpos\r\n   1472         return 1\r\n\r\n/home/patrick/miniconda3/lib/python3.4/site-packages/xlrd/sheet.py in update_cooked_mag_factors(self)\r\n   1536                 # VALID, defaults to 60\r\n   1537                 zoom = 60\r\n-> 1538             elif not (10 <= zoom <= 400):\r\n   1539                 if blah:\r\n   1540                     print((\r\n\r\nTypeError: unorderable types: int() <= NoneType()\r\n```\r\n\r\nFixed in this pull request by expanding `zoom == 0` to `not zoom`.","created_at":"2015-03-05T18:58:21Z","updated_at":"2015-03-05T18:58:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/python-excel/xlrd/pulls/131/commits","review_comments_url":"https://api.github.com/repos/python-excel/xlrd/pulls/131/comments","review_comment_url":"https://api.github.com/repos/python-excel/xlrd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python-excel/xlrd/issues/131/comments","statuses_url":"https://api.github.com/repos/python-excel/xlrd/statuses/e9fd4761723bf77babeaaaccd7067dd6cc7d9ec6","head":{"label":"patrickfuller:master","ref":"master","sha":"e9fd4761723bf77babeaaaccd7067dd6cc7d9ec6","user":{"login":"patrickfuller","id":1449833,"avatar_url":"https://avatars.githubusercontent.com/u/1449833?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickfuller","html_url":"https://github.com/patrickfuller","followers_url":"https://api.github.com/users/patrickfuller/followers","following_url":"https://api.github.com/users/patrickfuller/following{/other_user}","gists_url":"https://api.github.com/users/patrickfuller/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickfuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickfuller/subscriptions","organizations_url":"https://api.github.com/users/patrickfuller/orgs","repos_url":"https://api.github.com/users/patrickfuller/repos","events_url":"https://api.github.com/users/patrickfuller/events{/privacy}","received_events_url":"https://api.github.com/users/patrickfuller/received_events","type":"User","site_admin":false},"repo":{"id":31730026,"name":"xlrd","full_name":"patrickfuller/xlrd","owner":{"login":"patrickfuller","id":1449833,"avatar_url":"https://avatars.githubusercontent.com/u/1449833?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickfuller","html_url":"https://github.com/patrickfuller","followers_url":"https://api.github.com/users/patrickfuller/followers","following_url":"https://api.github.com/users/patrickfuller/following{/other_user}","gists_url":"https://api.github.com/users/patrickfuller/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickfuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickfuller/subscriptions","organizations_url":"https://api.github.com/users/patrickfuller/orgs","repos_url":"https://api.github.com/users/patrickfuller/repos","events_url":"https://api.github.com/users/patrickfuller/events{/privacy}","received_events_url":"https://api.github.com/users/patrickfuller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patrickfuller/xlrd","description":"Library for developers to extract data from Microsoft Excel (tm) spreadsheet files","fork":true,"url":"https://api.github.com/repos/patrickfuller/xlrd","forks_url":"https://api.github.com/repos/patrickfuller/xlrd/forks","keys_url":"https://api.github.com/repos/patrickfuller/xlrd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patrickfuller/xlrd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patrickfuller/xlrd/teams","hooks_url":"https://api.github.com/repos/patrickfuller/xlrd/hooks","issue_events_url":"https://api.github.com/repos/patrickfuller/xlrd/issues/events{/number}","events_url":"https://api.github.com/repos/patrickfuller/xlrd/events","assignees_url":"https://api.github.com/repos/patrickfuller/xlrd/assignees{/user}","branches_url":"https://api.github.com/repos/patrickfuller/xlrd/branches{/branch}","tags_url":"https://api.github.com/repos/patrickfuller/xlrd/tags","blobs_url":"https://api.github.com/repos/patrickfuller/xlrd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patrickfuller/xlrd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patrickfuller/xlrd/git/refs{/sha}","trees_url":"https://api.github.com/repos/patrickfuller/xlrd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patrickfuller/xlrd/statuses/{sha}","languages_url":"https://api.github.com/repos/patrickfuller/xlrd/languages","stargazers_url":"https://api.github.com/repos/patrickfuller/xlrd/stargazers","contributors_url":"https://api.github.com/repos/patrickfuller/xlrd/contributors","subscribers_url":"https://api.github.com/repos/patrickfuller/xlrd/subscribers","subscription_url":"https://api.github.com/repos/patrickfuller/xlrd/subscription","commits_url":"https://api.github.com/repos/patrickfuller/xlrd/commits{/sha}","git_commits_url":"https://api.github.com/repos/patrickfuller/xlrd/git/commits{/sha}","comments_url":"https://api.github.com/repos/patrickfuller/xlrd/comments{/number}","issue_comment_url":"https://api.github.com/repos/patrickfuller/xlrd/issues/comments{/number}","contents_url":"https://api.github.com/repos/patrickfuller/xlrd/contents/{+path}","compare_url":"https://api.github.com/repos/patrickfuller/xlrd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patrickfuller/xlrd/merges","archive_url":"https://api.github.com/repos/patrickfuller/xlrd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patrickfuller/xlrd/downloads","issues_url":"https://api.github.com/repos/patrickfuller/xlrd/issues{/number}","pulls_url":"https://api.github.com/repos/patrickfuller/xlrd/pulls{/number}","milestones_url":"https://api.github.com/repos/patrickfuller/xlrd/milestones{/number}","notifications_url":"https://api.github.com/repos/patrickfuller/xlrd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patrickfuller/xlrd/labels{/name}","releases_url":"https://api.github.com/repos/patrickfuller/xlrd/releases{/id}","created_at":"2015-03-05T18:48:47Z","updated_at":"2015-03-05T18:50:42Z","pushed_at":"2015-03-05T18:50:42Z","git_url":"git://github.com/patrickfuller/xlrd.git","ssh_url":"git@github.com:patrickfuller/xlrd.git","clone_url":"https://github.com/patrickfuller/xlrd.git","svn_url":"https://github.com/patrickfuller/xlrd","homepage":"http://www.python-excel.org/","size":3574,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python-excel:master","ref":"master","sha":"9429b4c1cd479830b1ecb08a5e7639244ef8dbcf","user":{"login":"python-excel","id":1507022,"avatar_url":"https://avatars.githubusercontent.com/u/1507022?v=3","gravatar_id":"","url":"https://api.github.com/users/python-excel","html_url":"https://github.com/python-excel","followers_url":"https://api.github.com/users/python-excel/followers","following_url":"https://api.github.com/users/python-excel/following{/other_user}","gists_url":"https://api.github.com/users/python-excel/gists{/gist_id}","starred_url":"https://api.github.com/users/python-excel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-excel/subscriptions","organizations_url":"https://api.github.com/users/python-excel/orgs","repos_url":"https://api.github.com/users/python-excel/repos","events_url":"https://api.github.com/users/python-excel/events{/privacy}","received_events_url":"https://api.github.com/users/python-excel/received_events","type":"Organization","site_admin":false},"repo":{"id":3645885,"name":"xlrd","full_name":"python-excel/xlrd","owner":{"login":"python-excel","id":1507022,"avatar_url":"https://avatars.githubusercontent.com/u/1507022?v=3","gravatar_id":"","url":"https://api.github.com/users/python-excel","html_url":"https://github.com/python-excel","followers_url":"https://api.github.com/users/python-excel/followers","following_url":"https://api.github.com/users/python-excel/following{/other_user}","gists_url":"https://api.github.com/users/python-excel/gists{/gist_id}","starred_url":"https://api.github.com/users/python-excel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-excel/subscriptions","organizations_url":"https://api.github.com/users/python-excel/orgs","repos_url":"https://api.github.com/users/python-excel/repos","events_url":"https://api.github.com/users/python-excel/events{/privacy}","received_events_url":"https://api.github.com/users/python-excel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-excel/xlrd","description":"Library for developers to extract data from Microsoft Excel (tm) spreadsheet files","fork":false,"url":"https://api.github.com/repos/python-excel/xlrd","forks_url":"https://api.github.com/repos/python-excel/xlrd/forks","keys_url":"https://api.github.com/repos/python-excel/xlrd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-excel/xlrd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-excel/xlrd/teams","hooks_url":"https://api.github.com/repos/python-excel/xlrd/hooks","issue_events_url":"https://api.github.com/repos/python-excel/xlrd/issues/events{/number}","events_url":"https://api.github.com/repos/python-excel/xlrd/events","assignees_url":"https://api.github.com/repos/python-excel/xlrd/assignees{/user}","branches_url":"https://api.github.com/repos/python-excel/xlrd/branches{/branch}","tags_url":"https://api.github.com/repos/python-excel/xlrd/tags","blobs_url":"https://api.github.com/repos/python-excel/xlrd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-excel/xlrd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-excel/xlrd/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-excel/xlrd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-excel/xlrd/statuses/{sha}","languages_url":"https://api.github.com/repos/python-excel/xlrd/languages","stargazers_url":"https://api.github.com/repos/python-excel/xlrd/stargazers","contributors_url":"https://api.github.com/repos/python-excel/xlrd/contributors","subscribers_url":"https://api.github.com/repos/python-excel/xlrd/subscribers","subscription_url":"https://api.github.com/repos/python-excel/xlrd/subscription","commits_url":"https://api.github.com/repos/python-excel/xlrd/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-excel/xlrd/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-excel/xlrd/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-excel/xlrd/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-excel/xlrd/contents/{+path}","compare_url":"https://api.github.com/repos/python-excel/xlrd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-excel/xlrd/merges","archive_url":"https://api.github.com/repos/python-excel/xlrd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-excel/xlrd/downloads","issues_url":"https://api.github.com/repos/python-excel/xlrd/issues{/number}","pulls_url":"https://api.github.com/repos/python-excel/xlrd/pulls{/number}","milestones_url":"https://api.github.com/repos/python-excel/xlrd/milestones{/number}","notifications_url":"https://api.github.com/repos/python-excel/xlrd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-excel/xlrd/labels{/name}","releases_url":"https://api.github.com/repos/python-excel/xlrd/releases{/id}","created_at":"2012-03-07T04:50:48Z","updated_at":"2015-03-04T10:27:32Z","pushed_at":"2014-07-07T12:50:32Z","git_url":"git://github.com/python-excel/xlrd.git","ssh_url":"git@github.com:python-excel/xlrd.git","clone_url":"https://github.com/python-excel/xlrd.git","svn_url":"https://github.com/python-excel/xlrd","homepage":"http://www.python-excel.org/","size":3574,"stargazers_count":511,"watchers_count":511,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":48,"forks":136,"open_issues":48,"watchers":511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-excel/xlrd/pulls/131"},"html":{"href":"https://github.com/python-excel/xlrd/pull/131"},"issue":{"href":"https://api.github.com/repos/python-excel/xlrd/issues/131"},"comments":{"href":"https://api.github.com/repos/python-excel/xlrd/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/python-excel/xlrd/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/python-excel/xlrd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python-excel/xlrd/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/python-excel/xlrd/statuses/e9fd4761723bf77babeaaaccd7067dd6cc7d9ec6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}