{"action":"created","comment":{"url":"https://api.github.com/repos/slimta/python-slimta/pulls/comments/44802908","id":44802908,"diff_hunk":"@@ -0,0 +1,9 @@\n+def check_argtype(val, type_, name, or_none=False):","path":"slimta/util/typecheck.py","position":1,"original_position":1,"commit_id":"796ab99cc81dd74d5b0adc7253ff2f9c70b8a2d5","original_commit_id":"796ab99cc81dd74d5b0adc7253ff2f9c70b8a2d5","user":{"login":"JocelynDelalande","id":429633,"avatar_url":"https://avatars.githubusercontent.com/u/429633?v=3","gravatar_id":"","url":"https://api.github.com/users/JocelynDelalande","html_url":"https://github.com/JocelynDelalande","followers_url":"https://api.github.com/users/JocelynDelalande/followers","following_url":"https://api.github.com/users/JocelynDelalande/following{/other_user}","gists_url":"https://api.github.com/users/JocelynDelalande/gists{/gist_id}","starred_url":"https://api.github.com/users/JocelynDelalande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JocelynDelalande/subscriptions","organizations_url":"https://api.github.com/users/JocelynDelalande/orgs","repos_url":"https://api.github.com/users/JocelynDelalande/repos","events_url":"https://api.github.com/users/JocelynDelalande/events{/privacy}","received_events_url":"https://api.github.com/users/JocelynDelalande/received_events","type":"User","site_admin":false},"body":"As I said [before](https://github.com/slimta/python-slimta/pull/34#discussion_r44783331) I think it's a valuable help to developers using slimta, but I will let you the final word on that anyway, so think about it and tell me your final decision :-).","created_at":"2015-11-13T16:35:36Z","updated_at":"2015-11-13T16:35:36Z","html_url":"https://github.com/slimta/python-slimta/pull/34#discussion_r44802908","pull_request_url":"https://api.github.com/repos/slimta/python-slimta/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/slimta/python-slimta/pulls/comments/44802908"},"html":{"href":"https://github.com/slimta/python-slimta/pull/34#discussion_r44802908"},"pull_request":{"href":"https://api.github.com/repos/slimta/python-slimta/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/slimta/python-slimta/pulls/34","id":50289822,"html_url":"https://github.com/slimta/python-slimta/pull/34","diff_url":"https://github.com/slimta/python-slimta/pull/34.diff","patch_url":"https://github.com/slimta/python-slimta/pull/34.patch","issue_url":"https://api.github.com/repos/slimta/python-slimta/issues/34","number":34,"state":"open","locked":false,"title":"WIP − Python3 support","user":{"login":"JocelynDelalande","id":429633,"avatar_url":"https://avatars.githubusercontent.com/u/429633?v=3","gravatar_id":"","url":"https://api.github.com/users/JocelynDelalande","html_url":"https://github.com/JocelynDelalande","followers_url":"https://api.github.com/users/JocelynDelalande/followers","following_url":"https://api.github.com/users/JocelynDelalande/following{/other_user}","gists_url":"https://api.github.com/users/JocelynDelalande/gists{/gist_id}","starred_url":"https://api.github.com/users/JocelynDelalande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JocelynDelalande/subscriptions","organizations_url":"https://api.github.com/users/JocelynDelalande/orgs","repos_url":"https://api.github.com/users/JocelynDelalande/repos","events_url":"https://api.github.com/users/JocelynDelalande/events{/privacy}","received_events_url":"https://api.github.com/users/JocelynDelalande/received_events","type":"User","site_admin":false},"body":"Following discussion on #26, here is my attempt at Python3 support.\r\nThat's quite a big one as bytes/unicode handling is quite central in slimta.\r\n\r\nThat's not ready yet, but hardwork is done.\r\n\r\nMy TODO for this PR before it may get mergeable :\r\n\r\n- [ ] some tests broke during latest rebase (before that, py2 & py3 tests were passing ok)\r\n- [ ] install conditionally either *dnspython* or *dnspython3*\r\n- [ ] some tests are strangely failing sometimes but not all the time with python3\r\n- [ ] include py3 testing in CI\r\n- [ ] update doc\r\n\r\n@icgood if you have some time to start reviewing already, don't hesitate :-)\r\n\r\nPS: sorry if the split into commits is not perfect, I worked \"commitless\" till I reached a working version.","created_at":"2015-11-10T18:12:33Z","updated_at":"2015-11-13T16:35:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5319e41c9fc99282695b3f427aaefc8ada025d11","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/slimta/python-slimta/pulls/34/commits","review_comments_url":"https://api.github.com/repos/slimta/python-slimta/pulls/34/comments","review_comment_url":"https://api.github.com/repos/slimta/python-slimta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slimta/python-slimta/issues/34/comments","statuses_url":"https://api.github.com/repos/slimta/python-slimta/statuses/796ab99cc81dd74d5b0adc7253ff2f9c70b8a2d5","head":{"label":"oasiswork:jd-py3","ref":"jd-py3","sha":"796ab99cc81dd74d5b0adc7253ff2f9c70b8a2d5","user":{"login":"oasiswork","id":1291016,"avatar_url":"https://avatars.githubusercontent.com/u/1291016?v=3","gravatar_id":"","url":"https://api.github.com/users/oasiswork","html_url":"https://github.com/oasiswork","followers_url":"https://api.github.com/users/oasiswork/followers","following_url":"https://api.github.com/users/oasiswork/following{/other_user}","gists_url":"https://api.github.com/users/oasiswork/gists{/gist_id}","starred_url":"https://api.github.com/users/oasiswork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oasiswork/subscriptions","organizations_url":"https://api.github.com/users/oasiswork/orgs","repos_url":"https://api.github.com/users/oasiswork/repos","events_url":"https://api.github.com/users/oasiswork/events{/privacy}","received_events_url":"https://api.github.com/users/oasiswork/received_events","type":"Organization","site_admin":false},"repo":{"id":45106187,"name":"python-slimta","full_name":"oasiswork/python-slimta","owner":{"login":"oasiswork","id":1291016,"avatar_url":"https://avatars.githubusercontent.com/u/1291016?v=3","gravatar_id":"","url":"https://api.github.com/users/oasiswork","html_url":"https://github.com/oasiswork","followers_url":"https://api.github.com/users/oasiswork/followers","following_url":"https://api.github.com/users/oasiswork/following{/other_user}","gists_url":"https://api.github.com/users/oasiswork/gists{/gist_id}","starred_url":"https://api.github.com/users/oasiswork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oasiswork/subscriptions","organizations_url":"https://api.github.com/users/oasiswork/orgs","repos_url":"https://api.github.com/users/oasiswork/repos","events_url":"https://api.github.com/users/oasiswork/events{/privacy}","received_events_url":"https://api.github.com/users/oasiswork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oasiswork/python-slimta","description":"Lightweight, asynchronous SMTP libraries","fork":true,"url":"https://api.github.com/repos/oasiswork/python-slimta","forks_url":"https://api.github.com/repos/oasiswork/python-slimta/forks","keys_url":"https://api.github.com/repos/oasiswork/python-slimta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oasiswork/python-slimta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oasiswork/python-slimta/teams","hooks_url":"https://api.github.com/repos/oasiswork/python-slimta/hooks","issue_events_url":"https://api.github.com/repos/oasiswork/python-slimta/issues/events{/number}","events_url":"https://api.github.com/repos/oasiswork/python-slimta/events","assignees_url":"https://api.github.com/repos/oasiswork/python-slimta/assignees{/user}","branches_url":"https://api.github.com/repos/oasiswork/python-slimta/branches{/branch}","tags_url":"https://api.github.com/repos/oasiswork/python-slimta/tags","blobs_url":"https://api.github.com/repos/oasiswork/python-slimta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oasiswork/python-slimta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oasiswork/python-slimta/git/refs{/sha}","trees_url":"https://api.github.com/repos/oasiswork/python-slimta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oasiswork/python-slimta/statuses/{sha}","languages_url":"https://api.github.com/repos/oasiswork/python-slimta/languages","stargazers_url":"https://api.github.com/repos/oasiswork/python-slimta/stargazers","contributors_url":"https://api.github.com/repos/oasiswork/python-slimta/contributors","subscribers_url":"https://api.github.com/repos/oasiswork/python-slimta/subscribers","subscription_url":"https://api.github.com/repos/oasiswork/python-slimta/subscription","commits_url":"https://api.github.com/repos/oasiswork/python-slimta/commits{/sha}","git_commits_url":"https://api.github.com/repos/oasiswork/python-slimta/git/commits{/sha}","comments_url":"https://api.github.com/repos/oasiswork/python-slimta/comments{/number}","issue_comment_url":"https://api.github.com/repos/oasiswork/python-slimta/issues/comments{/number}","contents_url":"https://api.github.com/repos/oasiswork/python-slimta/contents/{+path}","compare_url":"https://api.github.com/repos/oasiswork/python-slimta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oasiswork/python-slimta/merges","archive_url":"https://api.github.com/repos/oasiswork/python-slimta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oasiswork/python-slimta/downloads","issues_url":"https://api.github.com/repos/oasiswork/python-slimta/issues{/number}","pulls_url":"https://api.github.com/repos/oasiswork/python-slimta/pulls{/number}","milestones_url":"https://api.github.com/repos/oasiswork/python-slimta/milestones{/number}","notifications_url":"https://api.github.com/repos/oasiswork/python-slimta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oasiswork/python-slimta/labels{/name}","releases_url":"https://api.github.com/repos/oasiswork/python-slimta/releases{/id}","created_at":"2015-10-28T10:52:25Z","updated_at":"2015-10-28T10:52:26Z","pushed_at":"2015-11-10T18:05:39Z","git_url":"git://github.com/oasiswork/python-slimta.git","ssh_url":"git@github.com:oasiswork/python-slimta.git","clone_url":"https://github.com/oasiswork/python-slimta.git","svn_url":"https://github.com/oasiswork/python-slimta","homepage":"http://slimta.org/","size":1380,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slimta:master","ref":"master","sha":"7b991bbf26f0c8b61b14dbfae7b36edddb17111e","user":{"login":"slimta","id":5198497,"avatar_url":"https://avatars.githubusercontent.com/u/5198497?v=3","gravatar_id":"","url":"https://api.github.com/users/slimta","html_url":"https://github.com/slimta","followers_url":"https://api.github.com/users/slimta/followers","following_url":"https://api.github.com/users/slimta/following{/other_user}","gists_url":"https://api.github.com/users/slimta/gists{/gist_id}","starred_url":"https://api.github.com/users/slimta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimta/subscriptions","organizations_url":"https://api.github.com/users/slimta/orgs","repos_url":"https://api.github.com/users/slimta/repos","events_url":"https://api.github.com/users/slimta/events{/privacy}","received_events_url":"https://api.github.com/users/slimta/received_events","type":"Organization","site_admin":false},"repo":{"id":7116161,"name":"python-slimta","full_name":"slimta/python-slimta","owner":{"login":"slimta","id":5198497,"avatar_url":"https://avatars.githubusercontent.com/u/5198497?v=3","gravatar_id":"","url":"https://api.github.com/users/slimta","html_url":"https://github.com/slimta","followers_url":"https://api.github.com/users/slimta/followers","following_url":"https://api.github.com/users/slimta/following{/other_user}","gists_url":"https://api.github.com/users/slimta/gists{/gist_id}","starred_url":"https://api.github.com/users/slimta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimta/subscriptions","organizations_url":"https://api.github.com/users/slimta/orgs","repos_url":"https://api.github.com/users/slimta/repos","events_url":"https://api.github.com/users/slimta/events{/privacy}","received_events_url":"https://api.github.com/users/slimta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slimta/python-slimta","description":"Lightweight, asynchronous SMTP libraries","fork":false,"url":"https://api.github.com/repos/slimta/python-slimta","forks_url":"https://api.github.com/repos/slimta/python-slimta/forks","keys_url":"https://api.github.com/repos/slimta/python-slimta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slimta/python-slimta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slimta/python-slimta/teams","hooks_url":"https://api.github.com/repos/slimta/python-slimta/hooks","issue_events_url":"https://api.github.com/repos/slimta/python-slimta/issues/events{/number}","events_url":"https://api.github.com/repos/slimta/python-slimta/events","assignees_url":"https://api.github.com/repos/slimta/python-slimta/assignees{/user}","branches_url":"https://api.github.com/repos/slimta/python-slimta/branches{/branch}","tags_url":"https://api.github.com/repos/slimta/python-slimta/tags","blobs_url":"https://api.github.com/repos/slimta/python-slimta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slimta/python-slimta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slimta/python-slimta/git/refs{/sha}","trees_url":"https://api.github.com/repos/slimta/python-slimta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slimta/python-slimta/statuses/{sha}","languages_url":"https://api.github.com/repos/slimta/python-slimta/languages","stargazers_url":"https://api.github.com/repos/slimta/python-slimta/stargazers","contributors_url":"https://api.github.com/repos/slimta/python-slimta/contributors","subscribers_url":"https://api.github.com/repos/slimta/python-slimta/subscribers","subscription_url":"https://api.github.com/repos/slimta/python-slimta/subscription","commits_url":"https://api.github.com/repos/slimta/python-slimta/commits{/sha}","git_commits_url":"https://api.github.com/repos/slimta/python-slimta/git/commits{/sha}","comments_url":"https://api.github.com/repos/slimta/python-slimta/comments{/number}","issue_comment_url":"https://api.github.com/repos/slimta/python-slimta/issues/comments{/number}","contents_url":"https://api.github.com/repos/slimta/python-slimta/contents/{+path}","compare_url":"https://api.github.com/repos/slimta/python-slimta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slimta/python-slimta/merges","archive_url":"https://api.github.com/repos/slimta/python-slimta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slimta/python-slimta/downloads","issues_url":"https://api.github.com/repos/slimta/python-slimta/issues{/number}","pulls_url":"https://api.github.com/repos/slimta/python-slimta/pulls{/number}","milestones_url":"https://api.github.com/repos/slimta/python-slimta/milestones{/number}","notifications_url":"https://api.github.com/repos/slimta/python-slimta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slimta/python-slimta/labels{/name}","releases_url":"https://api.github.com/repos/slimta/python-slimta/releases{/id}","created_at":"2012-12-11T17:28:45Z","updated_at":"2015-11-05T18:32:09Z","pushed_at":"2015-11-10T18:12:34Z","git_url":"git://github.com/slimta/python-slimta.git","ssh_url":"git@github.com:slimta/python-slimta.git","clone_url":"https://github.com/slimta/python-slimta.git","svn_url":"https://github.com/slimta/python-slimta","homepage":"http://slimta.org/","size":3116,"stargazers_count":44,"watchers_count":44,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":6,"forks":13,"open_issues":6,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slimta/python-slimta/pulls/34"},"html":{"href":"https://github.com/slimta/python-slimta/pull/34"},"issue":{"href":"https://api.github.com/repos/slimta/python-slimta/issues/34"},"comments":{"href":"https://api.github.com/repos/slimta/python-slimta/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/slimta/python-slimta/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/slimta/python-slimta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slimta/python-slimta/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/slimta/python-slimta/statuses/796ab99cc81dd74d5b0adc7253ff2f9c70b8a2d5"}}}}