{"action":"created","issue":{"url":"https://api.github.com/repos/laravel/framework/issues/3864","labels_url":"https://api.github.com/repos/laravel/framework/issues/3864/labels{/name}","comments_url":"https://api.github.com/repos/laravel/framework/issues/3864/comments","events_url":"https://api.github.com/repos/laravel/framework/issues/3864/events","html_url":"https://github.com/laravel/framework/pull/3864","id":29241240,"number":3864,"title":"Unit Tests for SQS - Push support for SQS utilizing SNS - Overhaul of SubscribeCommand - Addition of UnsubscribeCommand and UpdateCommand - Move setContainer to Job base class and more","user":{"login":"dcarrith","id":451869,"avatar_url":"https://avatars.githubusercontent.com/u/451869?v=3","gravatar_id":"","url":"https://api.github.com/users/dcarrith","html_url":"https://github.com/dcarrith","followers_url":"https://api.github.com/users/dcarrith/followers","following_url":"https://api.github.com/users/dcarrith/following{/other_user}","gists_url":"https://api.github.com/users/dcarrith/gists{/gist_id}","starred_url":"https://api.github.com/users/dcarrith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcarrith/subscriptions","organizations_url":"https://api.github.com/users/dcarrith/orgs","repos_url":"https://api.github.com/users/dcarrith/repos","events_url":"https://api.github.com/users/dcarrith/events{/privacy}","received_events_url":"https://api.github.com/users/dcarrith/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2014-03-12T06:52:09Z","updated_at":"2015-09-11T00:09:20Z","closed_at":"2014-06-24T02:26:01Z","pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/3864","html_url":"https://github.com/laravel/framework/pull/3864","diff_url":"https://github.com/laravel/framework/pull/3864.diff","patch_url":"https://github.com/laravel/framework/pull/3864.patch"},"body":"This PR has grown out of a few other proposals/PRs from myself and @SammyK (#3759, #3778, #3784, #3789) so I'd like to get some more eyes on the additions/deletions/changes that are included in the branch.\r\n\r\nFirst, a little background on this. I started out by writing unit tests for SqsQueue and SqsJob since there were none and also made a couple other small changes. @taylorotwell wanted me to submit just 1 PR to cover those few things. Then, @SammyK proposed (and implemented) adding push support for SQS, so I wanted to get that included since there were going to be merge conflicts.  So, I made him a contributor to my fork.  @SammyK  then created a branch and pushed his changes into my fork.  To squash my 23 commits that could be seen in the original PR #3860, I just manually copied over the 19 files and committed to the branch @SammyK had created (this branch).\r\n\r\nI'd like to make sure this is all worthy of being included in the core of the framework and make sure any issues that people see are addressed so I can get everything ready to be merged.  Thanks for taking the time."},"comment":{"url":"https://api.github.com/repos/laravel/framework/issues/comments/139415657","html_url":"https://github.com/laravel/framework/pull/3864#issuecomment-139415657","issue_url":"https://api.github.com/repos/laravel/framework/issues/3864","id":139415657,"user":{"login":"kfuchs","id":2237033,"avatar_url":"https://avatars.githubusercontent.com/u/2237033?v=3","gravatar_id":"","url":"https://api.github.com/users/kfuchs","html_url":"https://github.com/kfuchs","followers_url":"https://api.github.com/users/kfuchs/followers","following_url":"https://api.github.com/users/kfuchs/following{/other_user}","gists_url":"https://api.github.com/users/kfuchs/gists{/gist_id}","starred_url":"https://api.github.com/users/kfuchs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfuchs/subscriptions","organizations_url":"https://api.github.com/users/kfuchs/orgs","repos_url":"https://api.github.com/users/kfuchs/repos","events_url":"https://api.github.com/users/kfuchs/events{/privacy}","received_events_url":"https://api.github.com/users/kfuchs/received_events","type":"User","site_admin":false},"created_at":"2015-09-11T00:09:20Z","updated_at":"2015-09-11T00:09:20Z","body":"So what ever happened to allowing push queue support for SQS?\r\n\r\n@SammyK I'm trying to setup an elastic beanstalk worker tier the same way you describe in your initial proposal. Any suggestions how to get this done with laravel 5.1?"}}