{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/comments/37643361","id":37643361,"diff_hunk":"@@ -86,7 +86,12 @@ public ModuleRegistry moduleRegistry() {\n \tprotected static class LocalConfig {\n \n \t\t@Bean\n-\t\tpublic ModuleDeployer moduleDeployer(ModuleLauncher moduleLauncher) {\n+\t\tpublic ModuleDeployer longRunningModuleDeployer(ModuleLauncher moduleLauncher) {","path":"spring-cloud-data-admin/src/main/java/org/springframework/cloud/data/admin/config/AdminConfiguration.java","position":5,"original_position":5,"commit_id":"89d1791601037342969f1974f2a98b74dbc9f25f","original_commit_id":"89d1791601037342969f1974f2a98b74dbc9f25f","user":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"body":"Those names map to the 2 consumers of the beans: StreamController and TaskController\r\n\r\nIMO, the Qualifier value should be mapped to the target of the bean injection more than the source. We get more opinionated and domain-specific as we move up the layers. Do you have anything specific in mind for how the spring-cloud-data domain itself would be extended beyond \"stream\" and \"task\". I don't want to prematurely over-generalize.","created_at":"2015-08-21T15:07:31Z","updated_at":"2015-08-21T15:07:31Z","html_url":"https://github.com/spring-cloud/spring-cloud-data/pull/54#discussion_r37643361","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/comments/37643361"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-data/pull/54#discussion_r37643361"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/54","id":43002070,"html_url":"https://github.com/spring-cloud/spring-cloud-data/pull/54","diff_url":"https://github.com/spring-cloud/spring-cloud-data/pull/54.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-data/pull/54.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/issues/54","number":54,"state":"open","locked":false,"title":"DO NOT MERGE: Task Launching","user":{"login":"mminella","id":630743,"avatar_url":"https://avatars.githubusercontent.com/u/630743?v=3","gravatar_id":"","url":"https://api.github.com/users/mminella","html_url":"https://github.com/mminella","followers_url":"https://api.github.com/users/mminella/followers","following_url":"https://api.github.com/users/mminella/following{/other_user}","gists_url":"https://api.github.com/users/mminella/gists{/gist_id}","starred_url":"https://api.github.com/users/mminella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mminella/subscriptions","organizations_url":"https://api.github.com/users/mminella/orgs","repos_url":"https://api.github.com/users/mminella/repos","events_url":"https://api.github.com/users/mminella/events{/privacy}","received_events_url":"https://api.github.com/users/mminella/received_events","type":"User","site_admin":false},"body":"This PR is for discussion purposes.  I'm still working on tests for it.  However:\r\n\r\n* This PR will launch modules as tasks via the REST API (both on Lattice and single node).\r\n* Because the ModuleLauncher still runs the jar files as part of the current process while in single node, the module's contexts are not closed in single node.  This can be addressed in a future PR.","created_at":"2015-08-21T03:55:02Z","updated_at":"2015-08-21T15:07:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75eaeb113cd73087f969b209735173e1f70b445d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/54/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/54/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/issues/54/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/statuses/89d1791601037342969f1974f2a98b74dbc9f25f","head":{"label":"mminella:module-launcher-refactor","ref":"module-launcher-refactor","sha":"89d1791601037342969f1974f2a98b74dbc9f25f","user":{"login":"mminella","id":630743,"avatar_url":"https://avatars.githubusercontent.com/u/630743?v=3","gravatar_id":"","url":"https://api.github.com/users/mminella","html_url":"https://github.com/mminella","followers_url":"https://api.github.com/users/mminella/followers","following_url":"https://api.github.com/users/mminella/following{/other_user}","gists_url":"https://api.github.com/users/mminella/gists{/gist_id}","starred_url":"https://api.github.com/users/mminella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mminella/subscriptions","organizations_url":"https://api.github.com/users/mminella/orgs","repos_url":"https://api.github.com/users/mminella/repos","events_url":"https://api.github.com/users/mminella/events{/privacy}","received_events_url":"https://api.github.com/users/mminella/received_events","type":"User","site_admin":false},"repo":{"id":39954448,"name":"spring-cloud-data","full_name":"mminella/spring-cloud-data","owner":{"login":"mminella","id":630743,"avatar_url":"https://avatars.githubusercontent.com/u/630743?v=3","gravatar_id":"","url":"https://api.github.com/users/mminella","html_url":"https://github.com/mminella","followers_url":"https://api.github.com/users/mminella/followers","following_url":"https://api.github.com/users/mminella/following{/other_user}","gists_url":"https://api.github.com/users/mminella/gists{/gist_id}","starred_url":"https://api.github.com/users/mminella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mminella/subscriptions","organizations_url":"https://api.github.com/users/mminella/orgs","repos_url":"https://api.github.com/users/mminella/repos","events_url":"https://api.github.com/users/mminella/events{/privacy}","received_events_url":"https://api.github.com/users/mminella/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mminella/spring-cloud-data","description":"","fork":true,"url":"https://api.github.com/repos/mminella/spring-cloud-data","forks_url":"https://api.github.com/repos/mminella/spring-cloud-data/forks","keys_url":"https://api.github.com/repos/mminella/spring-cloud-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mminella/spring-cloud-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mminella/spring-cloud-data/teams","hooks_url":"https://api.github.com/repos/mminella/spring-cloud-data/hooks","issue_events_url":"https://api.github.com/repos/mminella/spring-cloud-data/issues/events{/number}","events_url":"https://api.github.com/repos/mminella/spring-cloud-data/events","assignees_url":"https://api.github.com/repos/mminella/spring-cloud-data/assignees{/user}","branches_url":"https://api.github.com/repos/mminella/spring-cloud-data/branches{/branch}","tags_url":"https://api.github.com/repos/mminella/spring-cloud-data/tags","blobs_url":"https://api.github.com/repos/mminella/spring-cloud-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mminella/spring-cloud-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mminella/spring-cloud-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/mminella/spring-cloud-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mminella/spring-cloud-data/statuses/{sha}","languages_url":"https://api.github.com/repos/mminella/spring-cloud-data/languages","stargazers_url":"https://api.github.com/repos/mminella/spring-cloud-data/stargazers","contributors_url":"https://api.github.com/repos/mminella/spring-cloud-data/contributors","subscribers_url":"https://api.github.com/repos/mminella/spring-cloud-data/subscribers","subscription_url":"https://api.github.com/repos/mminella/spring-cloud-data/subscription","commits_url":"https://api.github.com/repos/mminella/spring-cloud-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/mminella/spring-cloud-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/mminella/spring-cloud-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/mminella/spring-cloud-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/mminella/spring-cloud-data/contents/{+path}","compare_url":"https://api.github.com/repos/mminella/spring-cloud-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mminella/spring-cloud-data/merges","archive_url":"https://api.github.com/repos/mminella/spring-cloud-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mminella/spring-cloud-data/downloads","issues_url":"https://api.github.com/repos/mminella/spring-cloud-data/issues{/number}","pulls_url":"https://api.github.com/repos/mminella/spring-cloud-data/pulls{/number}","milestones_url":"https://api.github.com/repos/mminella/spring-cloud-data/milestones{/number}","notifications_url":"https://api.github.com/repos/mminella/spring-cloud-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mminella/spring-cloud-data/labels{/name}","releases_url":"https://api.github.com/repos/mminella/spring-cloud-data/releases{/id}","created_at":"2015-07-30T14:20:26Z","updated_at":"2015-07-30T14:20:26Z","pushed_at":"2015-08-21T03:46:37Z","git_url":"git://github.com/mminella/spring-cloud-data.git","ssh_url":"git@github.com:mminella/spring-cloud-data.git","clone_url":"https://github.com/mminella/spring-cloud-data.git","svn_url":"https://github.com/mminella/spring-cloud-data","homepage":null,"size":381,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"fc98144f36961297d1c0f3bdd90468f262289e7b","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":39469487,"name":"spring-cloud-data","full_name":"spring-cloud/spring-cloud-data","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-data","description":"","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-data","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-data/releases{/id}","created_at":"2015-07-21T20:56:11Z","updated_at":"2015-08-07T16:39:03Z","pushed_at":"2015-08-21T14:26:20Z","git_url":"git://github.com/spring-cloud/spring-cloud-data.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-data.git","clone_url":"https://github.com/spring-cloud/spring-cloud-data.git","svn_url":"https://github.com/spring-cloud/spring-cloud-data","homepage":null,"size":1085,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":4,"forks":13,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/54"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-data/pull/54"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/issues/54"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-data/statuses/89d1791601037342969f1974f2a98b74dbc9f25f"}}}}