{"action":"created","issue":{"url":"https://api.github.com/repos/apache/kafka/issues/396","labels_url":"https://api.github.com/repos/apache/kafka/issues/396/labels{/name}","comments_url":"https://api.github.com/repos/apache/kafka/issues/396/comments","events_url":"https://api.github.com/repos/apache/kafka/issues/396/events","html_url":"https://github.com/apache/kafka/pull/396","id":114375370,"number":396,"title":"MINOR: Remove unreachable if check","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-31T00:07:48Z","updated_at":"2015-11-02T19:49:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/396","html_url":"https://github.com/apache/kafka/pull/396","diff_url":"https://github.com/apache/kafka/pull/396.diff","patch_url":"https://github.com/apache/kafka/pull/396.patch"},"body":"@gwenshap @granders could you guys take a look at this trivial change. This piece makes one think that for SSL, not passing `new_consumer=True` should be fine. It was fine until recently, before https://github.com/apache/kafka/commit/e6b343302f3208f7f6e0099fe2a7132ef9eaaafb."},"comment":{"url":"https://api.github.com/repos/apache/kafka/issues/comments/153137858","html_url":"https://github.com/apache/kafka/pull/396#issuecomment-153137858","issue_url":"https://api.github.com/repos/apache/kafka/issues/396","id":153137858,"user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"created_at":"2015-11-02T19:49:14Z","updated_at":"2015-11-02T19:49:14Z","body":"I too agree that it is reasonable behavior :). It is just that it will\nnever be exercised as new_consumer is by default set to false. So, one can\nnot just set security_protocol and expect that new_consumer will be set\nautomatically. It used to be that case, however that changed in\nhttps://github.com/apache/kafka/commit/e6b343302f3208f7f6e0099fe2a7132ef9eaaafb,\nunless I am missing something.\n\nOn Mon, Nov 2, 2015 at 11:41 AM, Geoff <notifications@github.com> wrote:\n\n> I agree with Gwen that this behavior seems reasonable; also it would be\n> good to check usage of the constructor to see if any usages rely on this\n> behavior (I suspect some benchmark tests might rely on this).\n>\n> Perhaps rather than deleting this if block, we could just log the change\n> to make it more visible?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/apache/kafka/pull/396#issuecomment-153135828>.\n>\n\n\n\n-- \n\nRegards,\nAshish\n"}}