{"action":"created","issue":{"url":"https://api.github.com/repos/pandegroup/openmm/issues/1031","labels_url":"https://api.github.com/repos/pandegroup/openmm/issues/1031/labels{/name}","comments_url":"https://api.github.com/repos/pandegroup/openmm/issues/1031/comments","events_url":"https://api.github.com/repos/pandegroup/openmm/issues/1031/events","html_url":"https://github.com/pandegroup/openmm/pull/1031","id":94190378,"number":1031,"title":"WIP: stripUnits","user":{"login":"rmcgibbo","id":641278,"avatar_url":"https://avatars.githubusercontent.com/u/641278?v=3","gravatar_id":"","url":"https://api.github.com/users/rmcgibbo","html_url":"https://github.com/rmcgibbo","followers_url":"https://api.github.com/users/rmcgibbo/followers","following_url":"https://api.github.com/users/rmcgibbo/following{/other_user}","gists_url":"https://api.github.com/users/rmcgibbo/gists{/gist_id}","starred_url":"https://api.github.com/users/rmcgibbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmcgibbo/subscriptions","organizations_url":"https://api.github.com/users/rmcgibbo/orgs","repos_url":"https://api.github.com/users/rmcgibbo/repos","events_url":"https://api.github.com/users/rmcgibbo/events{/privacy}","received_events_url":"https://api.github.com/users/rmcgibbo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-07-10T01:30:45Z","updated_at":"2015-07-10T02:54:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pandegroup/openmm/pulls/1031","html_url":"https://github.com/pandegroup/openmm/pull/1031","diff_url":"https://github.com/pandegroup/openmm/pull/1031.diff","patch_url":"https://github.com/pandegroup/openmm/pull/1031.patch"},"body":"Related to #1027, https://github.com/pandegroup/openmm/pull/1027#issuecomment-119789257. This removes the python `stripUnits` function that was applied indiscriminately to the arguments to every method, and moves this functionality into the swig typemaps. Only OpenMM C++ functions that take `double`, `Vec3`, and `std::vector<Vec3>` get the units stripped off."},"comment":{"url":"https://api.github.com/repos/pandegroup/openmm/issues/comments/120209096","html_url":"https://github.com/pandegroup/openmm/pull/1031#issuecomment-120209096","issue_url":"https://api.github.com/repos/pandegroup/openmm/issues/1031","id":120209096,"user":{"login":"jchodera","id":3656088,"avatar_url":"https://avatars.githubusercontent.com/u/3656088?v=3","gravatar_id":"","url":"https://api.github.com/users/jchodera","html_url":"https://github.com/jchodera","followers_url":"https://api.github.com/users/jchodera/followers","following_url":"https://api.github.com/users/jchodera/following{/other_user}","gists_url":"https://api.github.com/users/jchodera/gists{/gist_id}","starred_url":"https://api.github.com/users/jchodera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchodera/subscriptions","organizations_url":"https://api.github.com/users/jchodera/orgs","repos_url":"https://api.github.com/users/jchodera/repos","events_url":"https://api.github.com/users/jchodera/events{/privacy}","received_events_url":"https://api.github.com/users/jchodera/received_events","type":"User","site_admin":false},"created_at":"2015-07-10T02:54:50Z","updated_at":"2015-07-10T02:54:50Z","body":"> The first step, if you want to take a stab at it, is to write down the expected base dimension for the arguments for every function in a format similar to\r\n\r\nWhy can't we just use that `UNITS` list?"}}