{"action":"created","comment":{"url":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/comments/41916569","id":41916569,"diff_hunk":"@@ -119,9 +118,8 @@ def clone(self):\n         \"\"\"Clones the player without history, reapplying configuration\n         parameters as necessary.\"\"\"\n \n-        cls = self.__class__\n-        new_player = cls(*self.init_args)\n-        new_player.tournament_attributes = copy.copy(self.tournament_attributes)\n+        new_player = copy.copy(self)","path":"axelrod/player.py","position":15,"original_position":15,"commit_id":"e102fed4d561f9c5ddaddef76e064e3ee469ef29","original_commit_id":"e102fed4d561f9c5ddaddef76e064e3ee469ef29","user":{"login":"CamDavidsonPilon","id":884032,"avatar_url":"https://avatars.githubusercontent.com/u/884032?v=3","gravatar_id":"","url":"https://api.github.com/users/CamDavidsonPilon","html_url":"https://github.com/CamDavidsonPilon","followers_url":"https://api.github.com/users/CamDavidsonPilon/followers","following_url":"https://api.github.com/users/CamDavidsonPilon/following{/other_user}","gists_url":"https://api.github.com/users/CamDavidsonPilon/gists{/gist_id}","starred_url":"https://api.github.com/users/CamDavidsonPilon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CamDavidsonPilon/subscriptions","organizations_url":"https://api.github.com/users/CamDavidsonPilon/orgs","repos_url":"https://api.github.com/users/CamDavidsonPilon/repos","events_url":"https://api.github.com/users/CamDavidsonPilon/events{/privacy}","received_events_url":"https://api.github.com/users/CamDavidsonPilon/received_events","type":"User","site_admin":false},"body":"this may need to be `copy.deepcopy` ","created_at":"2015-10-13T20:01:26Z","updated_at":"2015-10-13T20:01:26Z","html_url":"https://github.com/Axelrod-Python/Axelrod/pull/358#discussion_r41916569","pull_request_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/358","_links":{"self":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/comments/41916569"},"html":{"href":"https://github.com/Axelrod-Python/Axelrod/pull/358#discussion_r41916569"},"pull_request":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/358"}}},"pull_request":{"url":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/358","id":47580937,"html_url":"https://github.com/Axelrod-Python/Axelrod/pull/358","diff_url":"https://github.com/Axelrod-Python/Axelrod/pull/358.diff","patch_url":"https://github.com/Axelrod-Python/Axelrod/pull/358.patch","issue_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues/358","number":358,"state":"open","locked":false,"title":"remove self.init_args","user":{"login":"CamDavidsonPilon","id":884032,"avatar_url":"https://avatars.githubusercontent.com/u/884032?v=3","gravatar_id":"","url":"https://api.github.com/users/CamDavidsonPilon","html_url":"https://github.com/CamDavidsonPilon","followers_url":"https://api.github.com/users/CamDavidsonPilon/followers","following_url":"https://api.github.com/users/CamDavidsonPilon/following{/other_user}","gists_url":"https://api.github.com/users/CamDavidsonPilon/gists{/gist_id}","starred_url":"https://api.github.com/users/CamDavidsonPilon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CamDavidsonPilon/subscriptions","organizations_url":"https://api.github.com/users/CamDavidsonPilon/orgs","repos_url":"https://api.github.com/users/CamDavidsonPilon/repos","events_url":"https://api.github.com/users/CamDavidsonPilon/events{/privacy}","received_events_url":"https://api.github.com/users/CamDavidsonPilon/received_events","type":"User","site_admin":false},"body":"Correct me if I am wrong, but I don't think `self.init_args` is needed everywhere. `copy.copy` should transfer the properties over. This improves the maintainability of the code, and makes adding strategies easier. \r\n\r\nFor review @meatballs et al.","created_at":"2015-10-13T20:01:01Z","updated_at":"2015-10-13T20:01:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ca2d6497199cd69a72ca8bc0840883a061dcb69","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/358/commits","review_comments_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/358/comments","review_comment_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues/358/comments","statuses_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/statuses/e102fed4d561f9c5ddaddef76e064e3ee469ef29","head":{"label":"CamDavidsonPilon:remove-init","ref":"remove-init","sha":"e102fed4d561f9c5ddaddef76e064e3ee469ef29","user":{"login":"CamDavidsonPilon","id":884032,"avatar_url":"https://avatars.githubusercontent.com/u/884032?v=3","gravatar_id":"","url":"https://api.github.com/users/CamDavidsonPilon","html_url":"https://github.com/CamDavidsonPilon","followers_url":"https://api.github.com/users/CamDavidsonPilon/followers","following_url":"https://api.github.com/users/CamDavidsonPilon/following{/other_user}","gists_url":"https://api.github.com/users/CamDavidsonPilon/gists{/gist_id}","starred_url":"https://api.github.com/users/CamDavidsonPilon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CamDavidsonPilon/subscriptions","organizations_url":"https://api.github.com/users/CamDavidsonPilon/orgs","repos_url":"https://api.github.com/users/CamDavidsonPilon/repos","events_url":"https://api.github.com/users/CamDavidsonPilon/events{/privacy}","received_events_url":"https://api.github.com/users/CamDavidsonPilon/received_events","type":"User","site_admin":false},"repo":{"id":44200215,"name":"Axelrod","full_name":"CamDavidsonPilon/Axelrod","owner":{"login":"CamDavidsonPilon","id":884032,"avatar_url":"https://avatars.githubusercontent.com/u/884032?v=3","gravatar_id":"","url":"https://api.github.com/users/CamDavidsonPilon","html_url":"https://github.com/CamDavidsonPilon","followers_url":"https://api.github.com/users/CamDavidsonPilon/followers","following_url":"https://api.github.com/users/CamDavidsonPilon/following{/other_user}","gists_url":"https://api.github.com/users/CamDavidsonPilon/gists{/gist_id}","starred_url":"https://api.github.com/users/CamDavidsonPilon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CamDavidsonPilon/subscriptions","organizations_url":"https://api.github.com/users/CamDavidsonPilon/orgs","repos_url":"https://api.github.com/users/CamDavidsonPilon/repos","events_url":"https://api.github.com/users/CamDavidsonPilon/events{/privacy}","received_events_url":"https://api.github.com/users/CamDavidsonPilon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CamDavidsonPilon/Axelrod","description":"A library to run Axelrod tournaments","fork":true,"url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod","forks_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/forks","keys_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/teams","hooks_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/hooks","issue_events_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/issues/events{/number}","events_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/events","assignees_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/assignees{/user}","branches_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/branches{/branch}","tags_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/tags","blobs_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/git/refs{/sha}","trees_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/statuses/{sha}","languages_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/languages","stargazers_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/stargazers","contributors_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/contributors","subscribers_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/subscribers","subscription_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/subscription","commits_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/commits{/sha}","git_commits_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/git/commits{/sha}","comments_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/comments{/number}","issue_comment_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/issues/comments{/number}","contents_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/contents/{+path}","compare_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/merges","archive_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/downloads","issues_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/issues{/number}","pulls_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/pulls{/number}","milestones_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/milestones{/number}","notifications_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/labels{/name}","releases_url":"https://api.github.com/repos/CamDavidsonPilon/Axelrod/releases{/id}","created_at":"2015-10-13T19:39:55Z","updated_at":"2015-10-13T19:40:00Z","pushed_at":"2015-10-13T19:58:42Z","git_url":"git://github.com/CamDavidsonPilon/Axelrod.git","ssh_url":"git@github.com:CamDavidsonPilon/Axelrod.git","clone_url":"https://github.com/CamDavidsonPilon/Axelrod.git","svn_url":"https://github.com/CamDavidsonPilon/Axelrod","homepage":"http://axelrod.readthedocs.org/","size":137693,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Axelrod-Python:master","ref":"master","sha":"6a5cdc85e8c708e93307f46f149862aa02cd777d","user":{"login":"Axelrod-Python","id":11720937,"avatar_url":"https://avatars.githubusercontent.com/u/11720937?v=3","gravatar_id":"","url":"https://api.github.com/users/Axelrod-Python","html_url":"https://github.com/Axelrod-Python","followers_url":"https://api.github.com/users/Axelrod-Python/followers","following_url":"https://api.github.com/users/Axelrod-Python/following{/other_user}","gists_url":"https://api.github.com/users/Axelrod-Python/gists{/gist_id}","starred_url":"https://api.github.com/users/Axelrod-Python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Axelrod-Python/subscriptions","organizations_url":"https://api.github.com/users/Axelrod-Python/orgs","repos_url":"https://api.github.com/users/Axelrod-Python/repos","events_url":"https://api.github.com/users/Axelrod-Python/events{/privacy}","received_events_url":"https://api.github.com/users/Axelrod-Python/received_events","type":"Organization","site_admin":false},"repo":{"id":30959449,"name":"Axelrod","full_name":"Axelrod-Python/Axelrod","owner":{"login":"Axelrod-Python","id":11720937,"avatar_url":"https://avatars.githubusercontent.com/u/11720937?v=3","gravatar_id":"","url":"https://api.github.com/users/Axelrod-Python","html_url":"https://github.com/Axelrod-Python","followers_url":"https://api.github.com/users/Axelrod-Python/followers","following_url":"https://api.github.com/users/Axelrod-Python/following{/other_user}","gists_url":"https://api.github.com/users/Axelrod-Python/gists{/gist_id}","starred_url":"https://api.github.com/users/Axelrod-Python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Axelrod-Python/subscriptions","organizations_url":"https://api.github.com/users/Axelrod-Python/orgs","repos_url":"https://api.github.com/users/Axelrod-Python/repos","events_url":"https://api.github.com/users/Axelrod-Python/events{/privacy}","received_events_url":"https://api.github.com/users/Axelrod-Python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Axelrod-Python/Axelrod","description":"A library to run Axelrod tournaments","fork":false,"url":"https://api.github.com/repos/Axelrod-Python/Axelrod","forks_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/forks","keys_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/teams","hooks_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/hooks","issue_events_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues/events{/number}","events_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/events","assignees_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/assignees{/user}","branches_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/branches{/branch}","tags_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/tags","blobs_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/git/refs{/sha}","trees_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/statuses/{sha}","languages_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/languages","stargazers_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/stargazers","contributors_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/contributors","subscribers_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/subscribers","subscription_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/subscription","commits_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/commits{/sha}","git_commits_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/git/commits{/sha}","comments_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/comments{/number}","issue_comment_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues/comments{/number}","contents_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/contents/{+path}","compare_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/merges","archive_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/downloads","issues_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues{/number}","pulls_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls{/number}","milestones_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/milestones{/number}","notifications_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/labels{/name}","releases_url":"https://api.github.com/repos/Axelrod-Python/Axelrod/releases{/id}","created_at":"2015-02-18T09:37:17Z","updated_at":"2015-10-08T15:19:05Z","pushed_at":"2015-10-13T20:01:02Z","git_url":"git://github.com/Axelrod-Python/Axelrod.git","ssh_url":"git@github.com:Axelrod-Python/Axelrod.git","clone_url":"https://github.com/Axelrod-Python/Axelrod.git","svn_url":"https://github.com/Axelrod-Python/Axelrod","homepage":"http://axelrod.readthedocs.org/","size":137693,"stargazers_count":41,"watchers_count":41,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":21,"forks":37,"open_issues":21,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/358"},"html":{"href":"https://github.com/Axelrod-Python/Axelrod/pull/358"},"issue":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues/358"},"comments":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/issues/358/comments"},"review_comments":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/358/comments"},"review_comment":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/pulls/358/commits"},"statuses":{"href":"https://api.github.com/repos/Axelrod-Python/Axelrod/statuses/e102fed4d561f9c5ddaddef76e064e3ee469ef29"}}}}