{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/comments/36025842","id":36025842,"diff_hunk":"@@ -327,3 +327,126 @@ test(\"getRoles on element with abstract role.\", function() {\n     test(\"getRoles on element with multiple invalid roles.\", multipleRoleTestHelper(['foo', 'fubar', 'bar'], -1));\n \n }());\n+\n+module(\"isValidNumber\");\n+\n+test(\"with integer.\", function() {\n+    var actual = axs.utils.isValidNumber(\"10\");\n+    strictEqual(actual.value, 10, \"Integer should be parsed\");\n+    ok(actual.valid, \"Integer should be valid\");\n+});\n+\n+test(\"with leading and trailing whitespace.\", function() {\n+    var actual = axs.utils.isValidNumber(\" 10 \");\n+    strictEqual(actual.value, 10, \"Integer should be parsed\");\n+    ok(actual.valid, \"Integer should be valid\");\n+});\n+\n+test(\"with zero.\", function() {\n+    var actual = axs.utils.isValidNumber(\"0\");\n+    strictEqual(actual.value, 0, \"Zero should be parsed\");\n+    ok(actual.valid, \"Integer should be valid\");\n+});\n+\n+test(\"with leading zero integer.\", function() {\n+    var actual = axs.utils.isValidNumber(\"09\");","path":"test/js/utils-test.js","position":26,"original_position":26,"commit_id":"dc8195ac2654a19a947883e371b75ae7bbd6d166","original_commit_id":"75de066603d5a2f98f8c1f920ea95b3b3d3a7247","user":{"login":"alice","id":95208,"avatar_url":"https://avatars.githubusercontent.com/u/95208?v=3","gravatar_id":"","url":"https://api.github.com/users/alice","html_url":"https://github.com/alice","followers_url":"https://api.github.com/users/alice/followers","following_url":"https://api.github.com/users/alice/following{/other_user}","gists_url":"https://api.github.com/users/alice/gists{/gist_id}","starred_url":"https://api.github.com/users/alice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alice/subscriptions","organizations_url":"https://api.github.com/users/alice/orgs","repos_url":"https://api.github.com/users/alice/repos","events_url":"https://api.github.com/users/alice/events{/privacy}","received_events_url":"https://api.github.com/users/alice/received_events","type":"User","site_admin":false},"body":"Ok I'm convinced! Thanks for chasing that up.","created_at":"2015-07-31T23:35:24Z","updated_at":"2015-07-31T23:35:24Z","html_url":"https://github.com/GoogleChrome/accessibility-developer-tools/pull/209#discussion_r36025842","pull_request_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/209","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/comments/36025842"},"html":{"href":"https://github.com/GoogleChrome/accessibility-developer-tools/pull/209#discussion_r36025842"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/209"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/209","id":40991854,"html_url":"https://github.com/GoogleChrome/accessibility-developer-tools/pull/209","diff_url":"https://github.com/GoogleChrome/accessibility-developer-tools/pull/209.diff","patch_url":"https://github.com/GoogleChrome/accessibility-developer-tools/pull/209.patch","issue_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/issues/209","number":209,"state":"open","locked":false,"title":"Tighten up axs.utils.isValidNumber","user":{"login":"RickSBrown","id":4993735,"avatar_url":"https://avatars.githubusercontent.com/u/4993735?v=3","gravatar_id":"","url":"https://api.github.com/users/RickSBrown","html_url":"https://github.com/RickSBrown","followers_url":"https://api.github.com/users/RickSBrown/followers","following_url":"https://api.github.com/users/RickSBrown/following{/other_user}","gists_url":"https://api.github.com/users/RickSBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/RickSBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RickSBrown/subscriptions","organizations_url":"https://api.github.com/users/RickSBrown/orgs","repos_url":"https://api.github.com/users/RickSBrown/repos","events_url":"https://api.github.com/users/RickSBrown/events{/privacy}","received_events_url":"https://api.github.com/users/RickSBrown/received_events","type":"User","site_admin":false},"body":"Handles the following edge cases:\r\n* A signed positive number like `+1`\r\n* A float missing its integer part like `.1`\r\n* An integer starting with a leading zero like `01`\r\n\r\nAdded approximately one metric gajillion unit tests.\r\n\r\n@alice PTAL No reported bug on this so I guess it's low priority.","created_at":"2015-07-28T09:33:39Z","updated_at":"2015-07-31T23:35:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e0d78bb519e8232e1f74aaab0de21832a0b4dcf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/209/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/209/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/issues/209/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/statuses/dc8195ac2654a19a947883e371b75ae7bbd6d166","head":{"label":"RickSBrown:numberparser","ref":"numberparser","sha":"dc8195ac2654a19a947883e371b75ae7bbd6d166","user":{"login":"RickSBrown","id":4993735,"avatar_url":"https://avatars.githubusercontent.com/u/4993735?v=3","gravatar_id":"","url":"https://api.github.com/users/RickSBrown","html_url":"https://github.com/RickSBrown","followers_url":"https://api.github.com/users/RickSBrown/followers","following_url":"https://api.github.com/users/RickSBrown/following{/other_user}","gists_url":"https://api.github.com/users/RickSBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/RickSBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RickSBrown/subscriptions","organizations_url":"https://api.github.com/users/RickSBrown/orgs","repos_url":"https://api.github.com/users/RickSBrown/repos","events_url":"https://api.github.com/users/RickSBrown/events{/privacy}","received_events_url":"https://api.github.com/users/RickSBrown/received_events","type":"User","site_admin":false},"repo":{"id":22796885,"name":"accessibility-developer-tools","full_name":"RickSBrown/accessibility-developer-tools","owner":{"login":"RickSBrown","id":4993735,"avatar_url":"https://avatars.githubusercontent.com/u/4993735?v=3","gravatar_id":"","url":"https://api.github.com/users/RickSBrown","html_url":"https://github.com/RickSBrown","followers_url":"https://api.github.com/users/RickSBrown/followers","following_url":"https://api.github.com/users/RickSBrown/following{/other_user}","gists_url":"https://api.github.com/users/RickSBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/RickSBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RickSBrown/subscriptions","organizations_url":"https://api.github.com/users/RickSBrown/orgs","repos_url":"https://api.github.com/users/RickSBrown/repos","events_url":"https://api.github.com/users/RickSBrown/events{/privacy}","received_events_url":"https://api.github.com/users/RickSBrown/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RickSBrown/accessibility-developer-tools","description":"","fork":true,"url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools","forks_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/forks","keys_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/teams","hooks_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/hooks","issue_events_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/events","assignees_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/tags","blobs_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/languages","stargazers_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/stargazers","contributors_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/contributors","subscribers_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/subscribers","subscription_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/subscription","commits_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/merges","archive_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/downloads","issues_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/labels{/name}","releases_url":"https://api.github.com/repos/RickSBrown/accessibility-developer-tools/releases{/id}","created_at":"2014-08-09T22:53:01Z","updated_at":"2015-05-01T23:24:53Z","pushed_at":"2015-07-31T23:01:08Z","git_url":"git://github.com/RickSBrown/accessibility-developer-tools.git","ssh_url":"git@github.com:RickSBrown/accessibility-developer-tools.git","clone_url":"https://github.com/RickSBrown/accessibility-developer-tools.git","svn_url":"https://github.com/RickSBrown/accessibility-developer-tools","homepage":null,"size":1311,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"64a85476c56af6b8db9f02cb1b32e6dd8e5cb002","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":11378642,"name":"accessibility-developer-tools","full_name":"GoogleChrome/accessibility-developer-tools","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars.githubusercontent.com/u/1778935?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/accessibility-developer-tools","description":"jdan","fork":false,"url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools","forks_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/forks","keys_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/events","assignees_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/merges","archive_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/releases{/id}","created_at":"2013-07-12T21:40:22Z","updated_at":"2015-07-30T23:35:44Z","pushed_at":"2015-07-31T23:01:09Z","git_url":"git://github.com/GoogleChrome/accessibility-developer-tools.git","ssh_url":"git@github.com:GoogleChrome/accessibility-developer-tools.git","clone_url":"https://github.com/GoogleChrome/accessibility-developer-tools.git","svn_url":"https://github.com/GoogleChrome/accessibility-developer-tools","homepage":"","size":2763,"stargazers_count":458,"watchers_count":458,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":43,"forks":70,"open_issues":43,"watchers":458,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/209"},"html":{"href":"https://github.com/GoogleChrome/accessibility-developer-tools/pull/209"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/issues/209"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/accessibility-developer-tools/statuses/dc8195ac2654a19a947883e371b75ae7bbd6d166"}}}}