{"push_id":682350476,"size":5,"distinct_size":0,"ref":"refs/heads/release","head":"ba43a42c906164ee9c087faabeda2d904abefe50","before":"f4369b3074d9d115830431479f5fc91a11e4b4bc","commits":[{"sha":"b09900d90b8e22cde3c2e4192b00dd128ff27c69","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Freeze time when generating responses and expected results\n\nThis matches the freezing of time in the smart_answers_regression_test.\n\nI noticed a problem where some of the rendered pages for\ncalculate-agricultural-holiday-entitlement included validation errors. We\nshould only be rendering outcomes, which can never be in an error state, so\nthis was unexpected.\n\nThe problem was caused by us using the current date when generating the\nresponses-and-expected-results, and a fixed date of 1st Jan 2015 when running\nthe regression tests. Responses that lead to valid outcomes based on the\ncurrent date don't necessarily lead to valid outcomes when running on the 1st\nJan 2015. Freezing time in this way should avoid problems like this in future.\n\nThe next step will be to regenerate the responses-and-expected outcomes for all\nof the existing regression tests. If those files change then I'll also need to\nregenerated the rendered outcomes and checksum data.","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/b09900d90b8e22cde3c2e4192b00dd128ff27c69"},{"sha":"1e06063718298b5a3e2662a51efc6f601e934427","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Regenerate calculate-agricultural-holiday-entitlement-responses-and-expected-results.yml\n\nRegenerated using:\n\n    $ rails r script/generate-responses-and-expected-results-for-smart-answer.rb \\\n      calculate-agricultural-holiday-entitlement","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/1e06063718298b5a3e2662a51efc6f601e934427"},{"sha":"35741b84b7b06f58cfb0a9c95c30528260c17744","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Regenerate calculate-agricultural-holiday-entitlement-files.yml\n\nRegenerated using:\n\n    $ rails r script/generate-checksums-for-smart-answer.rb \\\n      calculate-agricultural-holiday-entitlement","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/35741b84b7b06f58cfb0a9c95c30528260c17744"},{"sha":"55a74ffa302765679d262f56d0638852f2cd527c","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Remove old rendered outcomes for calculate-agricultural-holiday-entitlement\n\nThese rendered html pages contain Smart Answer validation errors. They were\nrendered because the responses-and-expected-results data was generated using\nthe current date, while the tests were running with time frozen on 1st Jan\n2015. When the responses-and-expected-results were generated, the responses\nrepresented in the deleted files lead to valid outcomes, while generating them\non 1st Jan 2015 means that these responses lead to validation errors.\n\nI exposed this problematic html files by running:\n\n    $ RUN_REGRESSION_TESTS=calculate-agricultural-holiday-entitlement \\\n      ruby test/regression/smart_answers_regression_test.rb\n\nI confirmed that I'm still getting 100% code coverage by running the same test\nwith the `TEST_COVERAGE=true` environment variable set.","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/55a74ffa302765679d262f56d0638852f2cd527c"},{"sha":"ba43a42c906164ee9c087faabeda2d904abefe50","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Merge branch 'use-timecop-when-generating-responses-and-expected-outcomes'\n\nThe calculate-agricultural-holiday-entitlement responses-and-expected-results\nwere the only ones that changed as part of this branch. I regenerated the\nresponses-and-expected-results for all other regression tested Smart Answers\n(see the list below) but the regenerated files were identical to the originals:\n\n* additional-commodity-code\n* am-i-getting-minimum-wage\n* apply-tier-4-visa\n* benefit-cap-calculator\n* pip-checker\n* plan-adoption-leave\n* report-a-lost-or-stolen-passport\n* state-pension-through-partner\n* state-pension-topup\n* student-finance-calculator\n* towing-rules\n* vat-payment-deadlines","distinct":false,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/ba43a42c906164ee9c087faabeda2d904abefe50"}]}