{"action":"created","issue":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/510","labels_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/510/labels{/name}","comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/510/comments","events_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/510/events","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/510","id":123391157,"number":510,"title":"Revise Records read logic to resolve issue #425","user":{"login":"martinholmer","id":12170745,"avatar_url":"https://avatars.githubusercontent.com/u/12170745?v=3","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-12-22T01:12:28Z","updated_at":"2015-12-22T17:31:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/510","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/510","diff_url":"https://github.com/open-source-economics/Tax-Calculator/pull/510.diff","patch_url":"https://github.com/open-source-economics/Tax-Calculator/pull/510.patch"},"body":"This pull request implements a new way of reading Records data in an attempt to resolve issue #425.\r\n\r\nSome minor revisions to the structure of the fake-data ```tax_all1991_puf.gz``` file and to the unit tests were necessary to make the unit test data and logic consistent with the new Records read logic.  See the commit messages for details.\r\n\r\nThese code changes do not have any effect on the output generated by test.py or test_mtr.py or inctax.py or the validation/tests, and all the py.tests continue to pass after the minor revisions mentioned above.  The test.py and test_mtr.py and inctax.py tests all use a new ```puf.csv``` file generated using the  enhanced ```puf-csv-processing.py``` logic in the pending taxdata pull request 12.\r\n"},"comment":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/comments/166680957","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/510#issuecomment-166680957","issue_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/510","id":166680957,"user":{"login":"martinholmer","id":12170745,"avatar_url":"https://avatars.githubusercontent.com/u/12170745?v=3","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"created_at":"2015-12-22T17:31:33Z","updated_at":"2015-12-22T17:31:33Z","body":"In the ```taxdata``` repository @Amy-Xu has merged pull request 12, which changed some variable names from lowercase to uppercase (in order to be consistent with SOI PUF variable names and with Tax-Calculator code variable names).  And she has used the new ```puf-cps-processing.py``` script to generate a new ```puf.csv``` file, which has been used along with the code in this pull request #510 to run a set of tests.  All the tests (which are enumerated in the lead comment in this conversation) continue to produces the same results as on the master branch using the old ```puf.csv``` file.\r\n\r\n@Amy-Xu will post the diagnostic table produced by the new ```puf.csv``` and the code in this pull request #510.  Assuming the diagnostic table results are unchanged, it would seem as if this pull request would be ready to be merged into the master branch.\r\n\r\ncc @MattHJensen @feenberg @GoFroggyRun @talumbau \r\n\r\nNote that once pull request #510 is merged into the master branch, use of the new ```puf.csv``` file will be necessary for all development work and for TaxBrain operation."}}