{"action":"created","issue":{"url":"https://api.github.com/repos/swipely/docker-api/issues/314","labels_url":"https://api.github.com/repos/swipely/docker-api/issues/314/labels{/name}","comments_url":"https://api.github.com/repos/swipely/docker-api/issues/314/comments","events_url":"https://api.github.com/repos/swipely/docker-api/issues/314/events","html_url":"https://github.com/swipely/docker-api/pull/314","id":104760766,"number":314,"title":"Make Container#wait respect the given timeout.","user":{"login":"pwnall","id":11460,"avatar_url":"https://avatars.githubusercontent.com/u/11460?v=3","gravatar_id":"","url":"https://api.github.com/users/pwnall","html_url":"https://github.com/pwnall","followers_url":"https://api.github.com/users/pwnall/followers","following_url":"https://api.github.com/users/pwnall/following{/other_user}","gists_url":"https://api.github.com/users/pwnall/gists{/gist_id}","starred_url":"https://api.github.com/users/pwnall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwnall/subscriptions","organizations_url":"https://api.github.com/users/pwnall/orgs","repos_url":"https://api.github.com/users/pwnall/repos","events_url":"https://api.github.com/users/pwnall/events{/privacy}","received_events_url":"https://api.github.com/users/pwnall/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-03T19:03:47Z","updated_at":"2015-09-03T20:14:40Z","closed_at":"2015-09-03T20:13:30Z","pull_request":{"url":"https://api.github.com/repos/swipely/docker-api/pulls/314","html_url":"https://github.com/swipely/docker-api/pull/314","diff_url":"https://github.com/swipely/docker-api/pull/314.diff","patch_url":"https://github.com/swipely/docker-api/pull/314.patch"},"body":"Setting `idempotent: true` on the wait request allows excon to retry it. By default, excon seems to retry idempotent failed requests 4 times, and this number can be controlled by the `:retry_limit` option. This means the actual time `Container#wait` waits before giving up is 4 * the given time, on a system without custom Excon options.\r\n\r\nVCR asserts don't seem to include idempotency or timeouts, so there are no changes to the test suite. However, I did test this patch on a live system. The retries can be observed by setting the `EXCON_DEBUG=1` environment variable and running `docker-api`-based tests.\r\n\r\nPlease please please consider merging this or a similar fix. I spent quite a bit of time tracing the root of the timeout issue.\r\n\r\nAlso, as always, many thanks for this wonderful gem! :heart: "},"comment":{"url":"https://api.github.com/repos/swipely/docker-api/issues/comments/137561800","html_url":"https://github.com/swipely/docker-api/pull/314#issuecomment-137561800","issue_url":"https://api.github.com/repos/swipely/docker-api/issues/314","id":137561800,"user":{"login":"tlunter","id":787998,"avatar_url":"https://avatars.githubusercontent.com/u/787998?v=3","gravatar_id":"","url":"https://api.github.com/users/tlunter","html_url":"https://github.com/tlunter","followers_url":"https://api.github.com/users/tlunter/followers","following_url":"https://api.github.com/users/tlunter/following{/other_user}","gists_url":"https://api.github.com/users/tlunter/gists{/gist_id}","starred_url":"https://api.github.com/users/tlunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlunter/subscriptions","organizations_url":"https://api.github.com/users/tlunter/orgs","repos_url":"https://api.github.com/users/tlunter/repos","events_url":"https://api.github.com/users/tlunter/events{/privacy}","received_events_url":"https://api.github.com/users/tlunter/received_events","type":"User","site_admin":false},"created_at":"2015-09-03T20:14:40Z","updated_at":"2015-09-03T20:14:40Z","body":"@pwnall released in v1.22.4"}}