{"action":"created","comment":{"url":"https://api.github.com/repos/talis/talis.github.io/pulls/comments/31729194","id":31729194,"diff_hunk":"@@ -4,4 +4,23 @@ title: Testing\n body_class: testing\n ---\n \n+As with most things, projects at Talis use test frameworks that are appropriate for their tooling - for example: protractor[^1], jasmine[^2] and mocha[^3] for projects containing Javascript/AngularJS.\n \n+More important is the process of inclusion of appropriate tests when creating a new project, and additionally when extending an existing one.\n+\n+Part of the code review process is to ensure that a [pull request](code-reviews.html) that adds new functionality also adds tests where appropriate. Similarly, that the changes made in the PR do not break existing tests, and where they do, that these tests have been fixed up.\n+\n+### Things to consider\n+\n+* choose a test framework that is appropriate to the project tooling","path":"topics/testing.md","position":12,"original_position":12,"commit_id":"f1a906c2ad4a472f97cb4d50ffbb3d4fbb0e88a4","original_commit_id":"f1a906c2ad4a472f97cb4d50ffbb3d4fbb0e88a4","user":{"login":"robotrobot","id":933278,"avatar_url":"https://avatars.githubusercontent.com/u/933278?v=3","gravatar_id":"","url":"https://api.github.com/users/robotrobot","html_url":"https://github.com/robotrobot","followers_url":"https://api.github.com/users/robotrobot/followers","following_url":"https://api.github.com/users/robotrobot/following{/other_user}","gists_url":"https://api.github.com/users/robotrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/robotrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotrobot/subscriptions","organizations_url":"https://api.github.com/users/robotrobot/orgs","repos_url":"https://api.github.com/users/robotrobot/repos","events_url":"https://api.github.com/users/robotrobot/events{/privacy}","received_events_url":"https://api.github.com/users/robotrobot/received_events","type":"User","site_admin":false},"body":"reference stack article and move frameworks there.","created_at":"2015-06-04T15:06:07Z","updated_at":"2015-06-04T15:06:07Z","html_url":"https://github.com/talis/talis.github.io/pull/7#discussion_r31729194","pull_request_url":"https://api.github.com/repos/talis/talis.github.io/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/talis/talis.github.io/pulls/comments/31729194"},"html":{"href":"https://github.com/talis/talis.github.io/pull/7#discussion_r31729194"},"pull_request":{"href":"https://api.github.com/repos/talis/talis.github.io/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/talis/talis.github.io/pulls/7","id":36937022,"html_url":"https://github.com/talis/talis.github.io/pull/7","diff_url":"https://github.com/talis/talis.github.io/pull/7.diff","patch_url":"https://github.com/talis/talis.github.io/pull/7.patch","issue_url":"https://api.github.com/repos/talis/talis.github.io/issues/7","number":7,"state":"open","locked":false,"title":"30% - Add initial content for code style and testing","user":{"login":"russellhill","id":4558976,"avatar_url":"https://avatars.githubusercontent.com/u/4558976?v=3","gravatar_id":"","url":"https://api.github.com/users/russellhill","html_url":"https://github.com/russellhill","followers_url":"https://api.github.com/users/russellhill/followers","following_url":"https://api.github.com/users/russellhill/following{/other_user}","gists_url":"https://api.github.com/users/russellhill/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhill/subscriptions","organizations_url":"https://api.github.com/users/russellhill/orgs","repos_url":"https://api.github.com/users/russellhill/repos","events_url":"https://api.github.com/users/russellhill/events{/privacy}","received_events_url":"https://api.github.com/users/russellhill/received_events","type":"User","site_admin":false},"body":"Just added some initial ideas for code style and testing areas","created_at":"2015-06-04T14:02:57Z","updated_at":"2015-06-04T15:06:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb505c36f210b9b8e4f0f9a576612feabe3cb8bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/talis/talis.github.io/pulls/7/commits","review_comments_url":"https://api.github.com/repos/talis/talis.github.io/pulls/7/comments","review_comment_url":"https://api.github.com/repos/talis/talis.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/talis/talis.github.io/issues/7/comments","statuses_url":"https://api.github.com/repos/talis/talis.github.io/statuses/f1a906c2ad4a472f97cb4d50ffbb3d4fbb0e88a4","head":{"label":"talis:add-initial-content","ref":"add-initial-content","sha":"f1a906c2ad4a472f97cb4d50ffbb3d4fbb0e88a4","user":{"login":"talis","id":181416,"avatar_url":"https://avatars.githubusercontent.com/u/181416?v=3","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"repo":{"id":11351973,"name":"talis.github.io","full_name":"talis/talis.github.io","owner":{"login":"talis","id":181416,"avatar_url":"https://avatars.githubusercontent.com/u/181416?v=3","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/talis/talis.github.io","description":"","fork":false,"url":"https://api.github.com/repos/talis/talis.github.io","forks_url":"https://api.github.com/repos/talis/talis.github.io/forks","keys_url":"https://api.github.com/repos/talis/talis.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talis/talis.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talis/talis.github.io/teams","hooks_url":"https://api.github.com/repos/talis/talis.github.io/hooks","issue_events_url":"https://api.github.com/repos/talis/talis.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/talis/talis.github.io/events","assignees_url":"https://api.github.com/repos/talis/talis.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/talis/talis.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/talis/talis.github.io/tags","blobs_url":"https://api.github.com/repos/talis/talis.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talis/talis.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talis/talis.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/talis/talis.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talis/talis.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/talis/talis.github.io/languages","stargazers_url":"https://api.github.com/repos/talis/talis.github.io/stargazers","contributors_url":"https://api.github.com/repos/talis/talis.github.io/contributors","subscribers_url":"https://api.github.com/repos/talis/talis.github.io/subscribers","subscription_url":"https://api.github.com/repos/talis/talis.github.io/subscription","commits_url":"https://api.github.com/repos/talis/talis.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/talis/talis.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/talis/talis.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/talis/talis.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/talis/talis.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/talis/talis.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talis/talis.github.io/merges","archive_url":"https://api.github.com/repos/talis/talis.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talis/talis.github.io/downloads","issues_url":"https://api.github.com/repos/talis/talis.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/talis/talis.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/talis/talis.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/talis/talis.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talis/talis.github.io/labels{/name}","releases_url":"https://api.github.com/repos/talis/talis.github.io/releases{/id}","created_at":"2013-07-11T20:15:18Z","updated_at":"2015-05-11T10:22:52Z","pushed_at":"2015-06-04T14:02:58Z","git_url":"git://github.com/talis/talis.github.io.git","ssh_url":"git@github.com:talis/talis.github.io.git","clone_url":"https://github.com/talis/talis.github.io.git","svn_url":"https://github.com/talis/talis.github.io","homepage":null,"size":560,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"talis:master","ref":"master","sha":"0447d9779015a499e85b8d310d884585f4ae7aeb","user":{"login":"talis","id":181416,"avatar_url":"https://avatars.githubusercontent.com/u/181416?v=3","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"repo":{"id":11351973,"name":"talis.github.io","full_name":"talis/talis.github.io","owner":{"login":"talis","id":181416,"avatar_url":"https://avatars.githubusercontent.com/u/181416?v=3","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/talis/talis.github.io","description":"","fork":false,"url":"https://api.github.com/repos/talis/talis.github.io","forks_url":"https://api.github.com/repos/talis/talis.github.io/forks","keys_url":"https://api.github.com/repos/talis/talis.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talis/talis.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talis/talis.github.io/teams","hooks_url":"https://api.github.com/repos/talis/talis.github.io/hooks","issue_events_url":"https://api.github.com/repos/talis/talis.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/talis/talis.github.io/events","assignees_url":"https://api.github.com/repos/talis/talis.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/talis/talis.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/talis/talis.github.io/tags","blobs_url":"https://api.github.com/repos/talis/talis.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talis/talis.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talis/talis.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/talis/talis.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talis/talis.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/talis/talis.github.io/languages","stargazers_url":"https://api.github.com/repos/talis/talis.github.io/stargazers","contributors_url":"https://api.github.com/repos/talis/talis.github.io/contributors","subscribers_url":"https://api.github.com/repos/talis/talis.github.io/subscribers","subscription_url":"https://api.github.com/repos/talis/talis.github.io/subscription","commits_url":"https://api.github.com/repos/talis/talis.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/talis/talis.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/talis/talis.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/talis/talis.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/talis/talis.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/talis/talis.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talis/talis.github.io/merges","archive_url":"https://api.github.com/repos/talis/talis.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talis/talis.github.io/downloads","issues_url":"https://api.github.com/repos/talis/talis.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/talis/talis.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/talis/talis.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/talis/talis.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talis/talis.github.io/labels{/name}","releases_url":"https://api.github.com/repos/talis/talis.github.io/releases{/id}","created_at":"2013-07-11T20:15:18Z","updated_at":"2015-05-11T10:22:52Z","pushed_at":"2015-06-04T14:02:58Z","git_url":"git://github.com/talis/talis.github.io.git","ssh_url":"git@github.com:talis/talis.github.io.git","clone_url":"https://github.com/talis/talis.github.io.git","svn_url":"https://github.com/talis/talis.github.io","homepage":null,"size":560,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/talis/talis.github.io/pulls/7"},"html":{"href":"https://github.com/talis/talis.github.io/pull/7"},"issue":{"href":"https://api.github.com/repos/talis/talis.github.io/issues/7"},"comments":{"href":"https://api.github.com/repos/talis/talis.github.io/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/talis/talis.github.io/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/talis/talis.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/talis/talis.github.io/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/talis/talis.github.io/statuses/f1a906c2ad4a472f97cb4d50ffbb3d4fbb0e88a4"}}}}