{"action":"created","comment":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/42025005","id":42025005,"diff_hunk":"@@ -48,7 +49,8 @@ type ssh_daemon_options_type = {\n     \"ClientAliveInterval\"               ? long\n     \"DenyGroups\"                        ? string\n     \"DenyUsers\"                         ? string\n-    \"HostKey\"                           ? string\n+    \"GSSAPIStrictAcceptorCheck\"         ? ssh_yesnostring\n+    \"HostKey\"                           ? string[]","path":"ncm-ssh/src/main/pan/components/ssh/schema.pan","position":25,"original_position":23,"commit_id":"14181fb8d2685d5d38a6ef8597d6d25a8774f03a","original_commit_id":"86e0cd5845ca58c6043db1c246820ba06b015cbe","user":{"login":"ajf8","id":1476635,"avatar_url":"https://avatars.githubusercontent.com/u/1476635?v=3","gravatar_id":"","url":"https://api.github.com/users/ajf8","html_url":"https://github.com/ajf8","followers_url":"https://api.github.com/users/ajf8/followers","following_url":"https://api.github.com/users/ajf8/following{/other_user}","gists_url":"https://api.github.com/users/ajf8/gists{/gist_id}","starred_url":"https://api.github.com/users/ajf8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajf8/subscriptions","organizations_url":"https://api.github.com/users/ajf8/orgs","repos_url":"https://api.github.com/users/ajf8/repos","events_url":"https://api.github.com/users/ajf8/events{/privacy}","received_events_url":"https://api.github.com/users/ajf8/received_events","type":"User","site_admin":false},"body":"I've changed multiline options to have its own type, and options/HostKey back to string. So hopefully this is completely backwards compatible.\r\n\r\nI could do an sshd_hostkeys type, but I guess it would require something specifically for handling HostKey. Would it go under component/ssh/mutliline_options or component/ssh? We could do something slightly more generic when it encounters a hash, but I'm not sure discarding the keys (rsa, dsa etc) is particularly generic. I think I would prefer keeping things simple and consistent (like they are now), but I'm happy to do it this way too.","created_at":"2015-10-14T17:30:39Z","updated_at":"2015-10-14T17:30:39Z","html_url":"https://github.com/quattor/configuration-modules-core/pull/606#discussion_r42025005","pull_request_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/606","_links":{"self":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/42025005"},"html":{"href":"https://github.com/quattor/configuration-modules-core/pull/606#discussion_r42025005"},"pull_request":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/606"}}},"pull_request":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/606","id":47399688,"html_url":"https://github.com/quattor/configuration-modules-core/pull/606","diff_url":"https://github.com/quattor/configuration-modules-core/pull/606.diff","patch_url":"https://github.com/quattor/configuration-modules-core/pull/606.patch","issue_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/606","number":606,"state":"open","locked":false,"title":"ncm-ssh: fix some issues introduced during rewrite.","user":{"login":"ajf8","id":1476635,"avatar_url":"https://avatars.githubusercontent.com/u/1476635?v=3","gravatar_id":"","url":"https://api.github.com/users/ajf8","html_url":"https://github.com/ajf8","followers_url":"https://api.github.com/users/ajf8/followers","following_url":"https://api.github.com/users/ajf8/following{/other_user}","gists_url":"https://api.github.com/users/ajf8/gists{/gist_id}","starred_url":"https://api.github.com/users/ajf8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajf8/subscriptions","organizations_url":"https://api.github.com/users/ajf8/orgs","repos_url":"https://api.github.com/users/ajf8/repos","events_url":"https://api.github.com/users/ajf8/events{/privacy}","received_events_url":"https://api.github.com/users/ajf8/received_events","type":"User","site_admin":false},"body":" * Add GSSAPIKeyExchange, GSSAPIStrictAcceptorCheck,\r\n   KerberosTicketAuthentication back into schema.\r\n\r\n * Use a File::Temp instead of /proc/self, because /proc/self does not\r\n   exist on Solaris and possibly other UNIX.\r\n\r\n(This is a pattern I see used across a number of modules, and it really causes problems for us on Solaris. My File::Temp approach causes problems for the some unit tests, which are relying on knowing the exact command before the code is tested. Test::Quattor letting you set based on a regex could be useful.. I'm currently passing a File::Temp into the code being tested, which isn't so nice. Is there a better way? Maybe something new in FileWriter?)\r\n\r\n * Add support for multiline options back in, for example HostKey.\r\n   Putting lists in options is already being used to generate CSV\r\n   options, so I've added a new section called multiline_options.\r\n\r\n * Don't hardcode the sshd/sshd_config/ssh_config (/usr/sbin/sshd\r\n   doesn't exist for us), make it possible to set through profile.\r\n\r\nThe template changes should be backwards compatible with the old code\r\nto make deployment simple.","created_at":"2015-10-12T09:29:02Z","updated_at":"2015-10-14T17:30:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba519d5878ffe0439dd8a4bc5d91d1fed669bfc3","assignee":null,"milestone":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones/10","html_url":"https://github.com/quattor/configuration-modules-core/milestones/15.10","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones/10/labels","id":866894,"number":10,"title":"15.10","description":null,"creator":{"login":"jrha","id":323309,"avatar_url":"https://avatars.githubusercontent.com/u/323309?v=3","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"open_issues":58,"closed_issues":0,"state":"open","created_at":"2014-11-14T16:49:47Z","updated_at":"2015-10-12T15:00:45Z","due_on":"2015-10-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/606/commits","review_comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/606/comments","review_comment_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/606/comments","statuses_url":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/14181fb8d2685d5d38a6ef8597d6d25a8774f03a","head":{"label":"ajf8:ncm_ssh","ref":"ncm_ssh","sha":"14181fb8d2685d5d38a6ef8597d6d25a8774f03a","user":{"login":"ajf8","id":1476635,"avatar_url":"https://avatars.githubusercontent.com/u/1476635?v=3","gravatar_id":"","url":"https://api.github.com/users/ajf8","html_url":"https://github.com/ajf8","followers_url":"https://api.github.com/users/ajf8/followers","following_url":"https://api.github.com/users/ajf8/following{/other_user}","gists_url":"https://api.github.com/users/ajf8/gists{/gist_id}","starred_url":"https://api.github.com/users/ajf8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajf8/subscriptions","organizations_url":"https://api.github.com/users/ajf8/orgs","repos_url":"https://api.github.com/users/ajf8/repos","events_url":"https://api.github.com/users/ajf8/events{/privacy}","received_events_url":"https://api.github.com/users/ajf8/received_events","type":"User","site_admin":false},"repo":{"id":38760435,"name":"configuration-modules-core","full_name":"ajf8/configuration-modules-core","owner":{"login":"ajf8","id":1476635,"avatar_url":"https://avatars.githubusercontent.com/u/1476635?v=3","gravatar_id":"","url":"https://api.github.com/users/ajf8","html_url":"https://github.com/ajf8","followers_url":"https://api.github.com/users/ajf8/followers","following_url":"https://api.github.com/users/ajf8/following{/other_user}","gists_url":"https://api.github.com/users/ajf8/gists{/gist_id}","starred_url":"https://api.github.com/users/ajf8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajf8/subscriptions","organizations_url":"https://api.github.com/users/ajf8/orgs","repos_url":"https://api.github.com/users/ajf8/repos","events_url":"https://api.github.com/users/ajf8/events{/privacy}","received_events_url":"https://api.github.com/users/ajf8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajf8/configuration-modules-core","description":"Node Configuration Manager Components for Everyone","fork":true,"url":"https://api.github.com/repos/ajf8/configuration-modules-core","forks_url":"https://api.github.com/repos/ajf8/configuration-modules-core/forks","keys_url":"https://api.github.com/repos/ajf8/configuration-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajf8/configuration-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajf8/configuration-modules-core/teams","hooks_url":"https://api.github.com/repos/ajf8/configuration-modules-core/hooks","issue_events_url":"https://api.github.com/repos/ajf8/configuration-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/ajf8/configuration-modules-core/events","assignees_url":"https://api.github.com/repos/ajf8/configuration-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/ajf8/configuration-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/ajf8/configuration-modules-core/tags","blobs_url":"https://api.github.com/repos/ajf8/configuration-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajf8/configuration-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajf8/configuration-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajf8/configuration-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajf8/configuration-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ajf8/configuration-modules-core/languages","stargazers_url":"https://api.github.com/repos/ajf8/configuration-modules-core/stargazers","contributors_url":"https://api.github.com/repos/ajf8/configuration-modules-core/contributors","subscribers_url":"https://api.github.com/repos/ajf8/configuration-modules-core/subscribers","subscription_url":"https://api.github.com/repos/ajf8/configuration-modules-core/subscription","commits_url":"https://api.github.com/repos/ajf8/configuration-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajf8/configuration-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajf8/configuration-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajf8/configuration-modules-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajf8/configuration-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/ajf8/configuration-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajf8/configuration-modules-core/merges","archive_url":"https://api.github.com/repos/ajf8/configuration-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajf8/configuration-modules-core/downloads","issues_url":"https://api.github.com/repos/ajf8/configuration-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/ajf8/configuration-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ajf8/configuration-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ajf8/configuration-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajf8/configuration-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/ajf8/configuration-modules-core/releases{/id}","created_at":"2015-07-08T14:48:23Z","updated_at":"2015-07-08T14:48:26Z","pushed_at":"2015-10-14T17:05:11Z","git_url":"git://github.com/ajf8/configuration-modules-core.git","ssh_url":"git@github.com:ajf8/configuration-modules-core.git","clone_url":"https://github.com/ajf8/configuration-modules-core.git","svn_url":"https://github.com/ajf8/configuration-modules-core","homepage":"www.quattor.org","size":9643,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quattor:master","ref":"master","sha":"6028270d199fa83939125dce5022299702ca3ea8","user":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"repo":{"id":6471233,"name":"configuration-modules-core","full_name":"quattor/configuration-modules-core","owner":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quattor/configuration-modules-core","description":"Node Configuration Manager Components for Everyone","fork":false,"url":"https://api.github.com/repos/quattor/configuration-modules-core","forks_url":"https://api.github.com/repos/quattor/configuration-modules-core/forks","keys_url":"https://api.github.com/repos/quattor/configuration-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quattor/configuration-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quattor/configuration-modules-core/teams","hooks_url":"https://api.github.com/repos/quattor/configuration-modules-core/hooks","issue_events_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/quattor/configuration-modules-core/events","assignees_url":"https://api.github.com/repos/quattor/configuration-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/quattor/configuration-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/quattor/configuration-modules-core/tags","blobs_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/quattor/configuration-modules-core/languages","stargazers_url":"https://api.github.com/repos/quattor/configuration-modules-core/stargazers","contributors_url":"https://api.github.com/repos/quattor/configuration-modules-core/contributors","subscribers_url":"https://api.github.com/repos/quattor/configuration-modules-core/subscribers","subscription_url":"https://api.github.com/repos/quattor/configuration-modules-core/subscription","commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/quattor/configuration-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/quattor/configuration-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quattor/configuration-modules-core/merges","archive_url":"https://api.github.com/repos/quattor/configuration-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quattor/configuration-modules-core/downloads","issues_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/quattor/configuration-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/quattor/configuration-modules-core/releases{/id}","created_at":"2012-10-31T09:08:07Z","updated_at":"2015-05-08T20:51:08Z","pushed_at":"2015-10-14T17:05:11Z","git_url":"git://github.com/quattor/configuration-modules-core.git","ssh_url":"git@github.com:quattor/configuration-modules-core.git","clone_url":"https://github.com/quattor/configuration-modules-core.git","svn_url":"https://github.com/quattor/configuration-modules-core","homepage":"www.quattor.org","size":16239,"stargazers_count":7,"watchers_count":7,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":71,"forks":29,"open_issues":71,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/606"},"html":{"href":"https://github.com/quattor/configuration-modules-core/pull/606"},"issue":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/issues/606"},"comments":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/issues/606/comments"},"review_comments":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/606/comments"},"review_comment":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/606/commits"},"statuses":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/14181fb8d2685d5d38a6ef8597d6d25a8774f03a"}}}}