{"action":"closed","number":10083,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/10083","id":31147655,"html_url":"https://github.com/elastic/elasticsearch/pull/10083","diff_url":"https://github.com/elastic/elasticsearch/pull/10083.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/10083.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/10083","number":10083,"state":"closed","locked":false,"title":"Core: don't rethrow already handled merge exceptions","user":{"login":"mikemccand","id":796508,"avatar_url":"https://avatars.githubusercontent.com/u/796508?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemccand","html_url":"https://github.com/mikemccand","followers_url":"https://api.github.com/users/mikemccand/followers","following_url":"https://api.github.com/users/mikemccand/following{/other_user}","gists_url":"https://api.github.com/users/mikemccand/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemccand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemccand/subscriptions","organizations_url":"https://api.github.com/users/mikemccand/orgs","repos_url":"https://api.github.com/users/mikemccand/repos","events_url":"https://api.github.com/users/mikemccand/events{/privacy}","received_events_url":"https://api.github.com/users/mikemccand/received_events","type":"User","site_admin":false},"body":"ES already has a custom merge exception handler that 1) logs the exception and 2) fails the engine ... and then it calls super, which throws an unhandled exception, which I think is redundant.  The JVM catches that and logs it again (to stderr), and this causes test failures like http://build-us-00.elastic.co/job/es_core_1x_centos/3701\r\n\r\nI think we should remove the super call?","created_at":"2015-03-13T17:41:12Z","updated_at":"2015-03-13T17:59:29Z","closed_at":"2015-03-13T17:59:29Z","merged_at":null,"merge_commit_sha":"403aa6e807a9bb0f5a3bfb65412a535c09309364","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/10083/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/10083/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/10083/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/3fc6d35c60dfb5d53f55da41dff435acf3ec7bd2","head":{"label":"mikemccand:handle_merge_exc","ref":"handle_merge_exc","sha":"3fc6d35c60dfb5d53f55da41dff435acf3ec7bd2","user":{"login":"mikemccand","id":796508,"avatar_url":"https://avatars.githubusercontent.com/u/796508?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemccand","html_url":"https://github.com/mikemccand","followers_url":"https://api.github.com/users/mikemccand/followers","following_url":"https://api.github.com/users/mikemccand/following{/other_user}","gists_url":"https://api.github.com/users/mikemccand/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemccand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemccand/subscriptions","organizations_url":"https://api.github.com/users/mikemccand/orgs","repos_url":"https://api.github.com/users/mikemccand/repos","events_url":"https://api.github.com/users/mikemccand/events{/privacy}","received_events_url":"https://api.github.com/users/mikemccand/received_events","type":"User","site_admin":false},"repo":{"id":18938255,"name":"elasticsearch","full_name":"mikemccand/elasticsearch","owner":{"login":"mikemccand","id":796508,"avatar_url":"https://avatars.githubusercontent.com/u/796508?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemccand","html_url":"https://github.com/mikemccand","followers_url":"https://api.github.com/users/mikemccand/followers","following_url":"https://api.github.com/users/mikemccand/following{/other_user}","gists_url":"https://api.github.com/users/mikemccand/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemccand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemccand/subscriptions","organizations_url":"https://api.github.com/users/mikemccand/orgs","repos_url":"https://api.github.com/users/mikemccand/repos","events_url":"https://api.github.com/users/mikemccand/events{/privacy}","received_events_url":"https://api.github.com/users/mikemccand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikemccand/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/mikemccand/elasticsearch","forks_url":"https://api.github.com/repos/mikemccand/elasticsearch/forks","keys_url":"https://api.github.com/repos/mikemccand/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikemccand/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikemccand/elasticsearch/teams","hooks_url":"https://api.github.com/repos/mikemccand/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/mikemccand/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/mikemccand/elasticsearch/events","assignees_url":"https://api.github.com/repos/mikemccand/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/mikemccand/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/mikemccand/elasticsearch/tags","blobs_url":"https://api.github.com/repos/mikemccand/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikemccand/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikemccand/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikemccand/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikemccand/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/mikemccand/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/mikemccand/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/mikemccand/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/mikemccand/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/mikemccand/elasticsearch/subscription","commits_url":"https://api.github.com/repos/mikemccand/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikemccand/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikemccand/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikemccand/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikemccand/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/mikemccand/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikemccand/elasticsearch/merges","archive_url":"https://api.github.com/repos/mikemccand/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikemccand/elasticsearch/downloads","issues_url":"https://api.github.com/repos/mikemccand/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/mikemccand/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/mikemccand/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/mikemccand/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikemccand/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/mikemccand/elasticsearch/releases{/id}","created_at":"2014-04-19T09:41:16Z","updated_at":"2015-01-16T17:14:14Z","pushed_at":"2015-03-13T17:49:12Z","git_url":"git://github.com/mikemccand/elasticsearch.git","ssh_url":"git@github.com:mikemccand/elasticsearch.git","clone_url":"https://github.com/mikemccand/elasticsearch.git","svn_url":"https://github.com/mikemccand/elasticsearch","homepage":"http://elasticsearch.org","size":88727,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"a8271595dc720b2d33b979ba7bdbf309c2ad68b2","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","created_at":"2010-02-08T13:20:56Z","updated_at":"2015-03-13T17:59:14Z","pushed_at":"2015-03-13T17:59:14Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"http://elasticsearch.org","size":287898,"stargazers_count":10280,"watchers_count":10280,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3197,"mirror_url":null,"open_issues_count":1046,"forks":3197,"open_issues":1046,"watchers":10280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/10083"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/10083"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/10083"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/10083/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/10083/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/10083/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/3fc6d35c60dfb5d53f55da41dff435acf3ec7bd2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":0,"commits":2,"additions":4,"deletions":2,"changed_files":1}}