{"action":"closed","number":201,"pull_request":{"url":"https://api.github.com/repos/nomad/shenzhen/pulls/201","id":28313748,"html_url":"https://github.com/nomad/shenzhen/pull/201","diff_url":"https://github.com/nomad/shenzhen/pull/201.diff","patch_url":"https://github.com/nomad/shenzhen/pull/201.patch","issue_url":"https://api.github.com/repos/nomad/shenzhen/issues/201","number":201,"state":"closed","locked":false,"title":"Remove a useless parameter passed to upload_build","user":{"login":"pedrogimenez","id":2186324,"avatar_url":"https://avatars.githubusercontent.com/u/2186324?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrogimenez","html_url":"https://github.com/pedrogimenez","followers_url":"https://api.github.com/users/pedrogimenez/followers","following_url":"https://api.github.com/users/pedrogimenez/following{/other_user}","gists_url":"https://api.github.com/users/pedrogimenez/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrogimenez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrogimenez/subscriptions","organizations_url":"https://api.github.com/users/pedrogimenez/orgs","repos_url":"https://api.github.com/users/pedrogimenez/repos","events_url":"https://api.github.com/users/pedrogimenez/events{/privacy}","received_events_url":"https://api.github.com/users/pedrogimenez/received_events","type":"User","site_admin":false},"body":"It removes a parameter that the method `upload_build` wasn't using. Also, I've renamed `options` to `parameters` to be consistent with the name given to the variable in the caller.\r\n\r\nWhat do you think?","created_at":"2015-01-29T20:54:33Z","updated_at":"2015-01-30T16:27:47Z","closed_at":"2015-01-30T16:27:47Z","merged_at":null,"merge_commit_sha":"1df0a568ecb2f5827e9ec3f0c411c47a10906bfd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nomad/shenzhen/pulls/201/commits","review_comments_url":"https://api.github.com/repos/nomad/shenzhen/pulls/201/comments","review_comment_url":"https://api.github.com/repos/nomad/shenzhen/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nomad/shenzhen/issues/201/comments","statuses_url":"https://api.github.com/repos/nomad/shenzhen/statuses/5928bf9439ba0b97a6d5c82ea847ca386e412975","head":{"label":"pedrogimenez:remove-useless-parameter","ref":"remove-useless-parameter","sha":"5928bf9439ba0b97a6d5c82ea847ca386e412975","user":{"login":"pedrogimenez","id":2186324,"avatar_url":"https://avatars.githubusercontent.com/u/2186324?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrogimenez","html_url":"https://github.com/pedrogimenez","followers_url":"https://api.github.com/users/pedrogimenez/followers","following_url":"https://api.github.com/users/pedrogimenez/following{/other_user}","gists_url":"https://api.github.com/users/pedrogimenez/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrogimenez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrogimenez/subscriptions","organizations_url":"https://api.github.com/users/pedrogimenez/orgs","repos_url":"https://api.github.com/users/pedrogimenez/repos","events_url":"https://api.github.com/users/pedrogimenez/events{/privacy}","received_events_url":"https://api.github.com/users/pedrogimenez/received_events","type":"User","site_admin":false},"repo":{"id":30040069,"name":"shenzhen","full_name":"pedrogimenez/shenzhen","owner":{"login":"pedrogimenez","id":2186324,"avatar_url":"https://avatars.githubusercontent.com/u/2186324?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrogimenez","html_url":"https://github.com/pedrogimenez","followers_url":"https://api.github.com/users/pedrogimenez/followers","following_url":"https://api.github.com/users/pedrogimenez/following{/other_user}","gists_url":"https://api.github.com/users/pedrogimenez/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrogimenez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrogimenez/subscriptions","organizations_url":"https://api.github.com/users/pedrogimenez/orgs","repos_url":"https://api.github.com/users/pedrogimenez/repos","events_url":"https://api.github.com/users/pedrogimenez/events{/privacy}","received_events_url":"https://api.github.com/users/pedrogimenez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pedrogimenez/shenzhen","description":"CLI for Building & Distributing iOS Apps (.ipa Files)","fork":true,"url":"https://api.github.com/repos/pedrogimenez/shenzhen","forks_url":"https://api.github.com/repos/pedrogimenez/shenzhen/forks","keys_url":"https://api.github.com/repos/pedrogimenez/shenzhen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pedrogimenez/shenzhen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pedrogimenez/shenzhen/teams","hooks_url":"https://api.github.com/repos/pedrogimenez/shenzhen/hooks","issue_events_url":"https://api.github.com/repos/pedrogimenez/shenzhen/issues/events{/number}","events_url":"https://api.github.com/repos/pedrogimenez/shenzhen/events","assignees_url":"https://api.github.com/repos/pedrogimenez/shenzhen/assignees{/user}","branches_url":"https://api.github.com/repos/pedrogimenez/shenzhen/branches{/branch}","tags_url":"https://api.github.com/repos/pedrogimenez/shenzhen/tags","blobs_url":"https://api.github.com/repos/pedrogimenez/shenzhen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pedrogimenez/shenzhen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pedrogimenez/shenzhen/git/refs{/sha}","trees_url":"https://api.github.com/repos/pedrogimenez/shenzhen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pedrogimenez/shenzhen/statuses/{sha}","languages_url":"https://api.github.com/repos/pedrogimenez/shenzhen/languages","stargazers_url":"https://api.github.com/repos/pedrogimenez/shenzhen/stargazers","contributors_url":"https://api.github.com/repos/pedrogimenez/shenzhen/contributors","subscribers_url":"https://api.github.com/repos/pedrogimenez/shenzhen/subscribers","subscription_url":"https://api.github.com/repos/pedrogimenez/shenzhen/subscription","commits_url":"https://api.github.com/repos/pedrogimenez/shenzhen/commits{/sha}","git_commits_url":"https://api.github.com/repos/pedrogimenez/shenzhen/git/commits{/sha}","comments_url":"https://api.github.com/repos/pedrogimenez/shenzhen/comments{/number}","issue_comment_url":"https://api.github.com/repos/pedrogimenez/shenzhen/issues/comments/{number}","contents_url":"https://api.github.com/repos/pedrogimenez/shenzhen/contents/{+path}","compare_url":"https://api.github.com/repos/pedrogimenez/shenzhen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pedrogimenez/shenzhen/merges","archive_url":"https://api.github.com/repos/pedrogimenez/shenzhen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pedrogimenez/shenzhen/downloads","issues_url":"https://api.github.com/repos/pedrogimenez/shenzhen/issues{/number}","pulls_url":"https://api.github.com/repos/pedrogimenez/shenzhen/pulls{/number}","milestones_url":"https://api.github.com/repos/pedrogimenez/shenzhen/milestones{/number}","notifications_url":"https://api.github.com/repos/pedrogimenez/shenzhen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pedrogimenez/shenzhen/labels{/name}","releases_url":"https://api.github.com/repos/pedrogimenez/shenzhen/releases{/id}","created_at":"2015-01-29T20:37:27Z","updated_at":"2015-01-29T20:37:28Z","pushed_at":"2015-01-30T00:00:48Z","git_url":"git://github.com/pedrogimenez/shenzhen.git","ssh_url":"git@github.com:pedrogimenez/shenzhen.git","clone_url":"https://github.com/pedrogimenez/shenzhen.git","svn_url":"https://github.com/pedrogimenez/shenzhen","homepage":"http://nomad-cli.com","size":1164,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nomad:master","ref":"master","sha":"5b208a757df1268ddc342dc99e82dcc0bc1ec8be","user":{"login":"nomad","id":1833193,"avatar_url":"https://avatars.githubusercontent.com/u/1833193?v=3","gravatar_id":"","url":"https://api.github.com/users/nomad","html_url":"https://github.com/nomad","followers_url":"https://api.github.com/users/nomad/followers","following_url":"https://api.github.com/users/nomad/following{/other_user}","gists_url":"https://api.github.com/users/nomad/gists{/gist_id}","starred_url":"https://api.github.com/users/nomad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nomad/subscriptions","organizations_url":"https://api.github.com/users/nomad/orgs","repos_url":"https://api.github.com/users/nomad/repos","events_url":"https://api.github.com/users/nomad/events{/privacy}","received_events_url":"https://api.github.com/users/nomad/received_events","type":"Organization","site_admin":false},"repo":{"id":5992293,"name":"shenzhen","full_name":"nomad/shenzhen","owner":{"login":"nomad","id":1833193,"avatar_url":"https://avatars.githubusercontent.com/u/1833193?v=3","gravatar_id":"","url":"https://api.github.com/users/nomad","html_url":"https://github.com/nomad","followers_url":"https://api.github.com/users/nomad/followers","following_url":"https://api.github.com/users/nomad/following{/other_user}","gists_url":"https://api.github.com/users/nomad/gists{/gist_id}","starred_url":"https://api.github.com/users/nomad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nomad/subscriptions","organizations_url":"https://api.github.com/users/nomad/orgs","repos_url":"https://api.github.com/users/nomad/repos","events_url":"https://api.github.com/users/nomad/events{/privacy}","received_events_url":"https://api.github.com/users/nomad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nomad/shenzhen","description":"CLI for Building & Distributing iOS Apps (.ipa Files)","fork":false,"url":"https://api.github.com/repos/nomad/shenzhen","forks_url":"https://api.github.com/repos/nomad/shenzhen/forks","keys_url":"https://api.github.com/repos/nomad/shenzhen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nomad/shenzhen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nomad/shenzhen/teams","hooks_url":"https://api.github.com/repos/nomad/shenzhen/hooks","issue_events_url":"https://api.github.com/repos/nomad/shenzhen/issues/events{/number}","events_url":"https://api.github.com/repos/nomad/shenzhen/events","assignees_url":"https://api.github.com/repos/nomad/shenzhen/assignees{/user}","branches_url":"https://api.github.com/repos/nomad/shenzhen/branches{/branch}","tags_url":"https://api.github.com/repos/nomad/shenzhen/tags","blobs_url":"https://api.github.com/repos/nomad/shenzhen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nomad/shenzhen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nomad/shenzhen/git/refs{/sha}","trees_url":"https://api.github.com/repos/nomad/shenzhen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nomad/shenzhen/statuses/{sha}","languages_url":"https://api.github.com/repos/nomad/shenzhen/languages","stargazers_url":"https://api.github.com/repos/nomad/shenzhen/stargazers","contributors_url":"https://api.github.com/repos/nomad/shenzhen/contributors","subscribers_url":"https://api.github.com/repos/nomad/shenzhen/subscribers","subscription_url":"https://api.github.com/repos/nomad/shenzhen/subscription","commits_url":"https://api.github.com/repos/nomad/shenzhen/commits{/sha}","git_commits_url":"https://api.github.com/repos/nomad/shenzhen/git/commits{/sha}","comments_url":"https://api.github.com/repos/nomad/shenzhen/comments{/number}","issue_comment_url":"https://api.github.com/repos/nomad/shenzhen/issues/comments/{number}","contents_url":"https://api.github.com/repos/nomad/shenzhen/contents/{+path}","compare_url":"https://api.github.com/repos/nomad/shenzhen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nomad/shenzhen/merges","archive_url":"https://api.github.com/repos/nomad/shenzhen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nomad/shenzhen/downloads","issues_url":"https://api.github.com/repos/nomad/shenzhen/issues{/number}","pulls_url":"https://api.github.com/repos/nomad/shenzhen/pulls{/number}","milestones_url":"https://api.github.com/repos/nomad/shenzhen/milestones{/number}","notifications_url":"https://api.github.com/repos/nomad/shenzhen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nomad/shenzhen/labels{/name}","releases_url":"https://api.github.com/repos/nomad/shenzhen/releases{/id}","created_at":"2012-09-28T03:52:00Z","updated_at":"2015-01-30T16:22:33Z","pushed_at":"2015-01-29T17:15:30Z","git_url":"git://github.com/nomad/shenzhen.git","ssh_url":"git@github.com:nomad/shenzhen.git","clone_url":"https://github.com/nomad/shenzhen.git","svn_url":"https://github.com/nomad/shenzhen","homepage":"http://nomad-cli.com","size":1164,"stargazers_count":2111,"watchers_count":2111,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"open_issues_count":11,"forks":184,"open_issues":11,"watchers":2111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nomad/shenzhen/pulls/201"},"html":{"href":"https://github.com/nomad/shenzhen/pull/201"},"issue":{"href":"https://api.github.com/repos/nomad/shenzhen/issues/201"},"comments":{"href":"https://api.github.com/repos/nomad/shenzhen/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/nomad/shenzhen/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/nomad/shenzhen/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nomad/shenzhen/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/nomad/shenzhen/statuses/5928bf9439ba0b97a6d5c82ea847ca386e412975"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}