{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/37567481","id":37567481,"diff_hunk":"@@ -600,8 +713,17 @@ impl<T> VecDeque<T> {\n     #[stable(feature = \"rust1\", since = \"1.0.0\")]\n     pub fn is_empty(&self) -> bool { self.len() == 0 }\n \n-    /// Creates a draining iterator that clears the `VecDeque` and iterates over\n-    /// the removed items from start to end.\n+    /// Create a draining iterator that removes the specified range in the\n+    /// `VecDeque` and yields the removed items from start to end. The element\n+    /// range is removed even if the iterator is not consumed until the end.\n+    ///\n+    /// Note: It is unspecified how many elements are removed from the deque,\n+    /// if the `Drain` value is leaked.","path":"src/libcollections/vec_deque.rs","position":138,"original_position":138,"commit_id":"ff9793b2817e7cd08c0e5ddb5aa0422bec797646","original_commit_id":"ff9793b2817e7cd08c0e5ddb5aa0422bec797646","user":{"login":"Gankro","id":1136864,"avatar_url":"https://avatars.githubusercontent.com/u/1136864?v=3","gravatar_id":"","url":"https://api.github.com/users/Gankro","html_url":"https://github.com/Gankro","followers_url":"https://api.github.com/users/Gankro/followers","following_url":"https://api.github.com/users/Gankro/following{/other_user}","gists_url":"https://api.github.com/users/Gankro/gists{/gist_id}","starred_url":"https://api.github.com/users/Gankro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gankro/subscriptions","organizations_url":"https://api.github.com/users/Gankro/orgs","repos_url":"https://api.github.com/users/Gankro/repos","events_url":"https://api.github.com/users/Gankro/events{/privacy}","received_events_url":"https://api.github.com/users/Gankro/received_events","type":"User","site_admin":false},"body":"That's a pretty nice guarantee... but you're right that it's not great. OK to punt on, for sure.","created_at":"2015-08-20T18:54:33Z","updated_at":"2015-08-20T18:54:33Z","html_url":"https://github.com/rust-lang/rust/pull/27723#discussion_r37567481","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/27723","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/37567481"},"html":{"href":"https://github.com/rust-lang/rust/pull/27723#discussion_r37567481"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27723"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/27723","id":42269121,"html_url":"https://github.com/rust-lang/rust/pull/27723","diff_url":"https://github.com/rust-lang/rust/pull/27723.diff","patch_url":"https://github.com/rust-lang/rust/pull/27723.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/27723","number":27723,"state":"open","locked":false,"title":"Implement drain over a range for VecDeque","user":{"login":"mystor","id":1261662,"avatar_url":"https://avatars.githubusercontent.com/u/1261662?v=3","gravatar_id":"","url":"https://api.github.com/users/mystor","html_url":"https://github.com/mystor","followers_url":"https://api.github.com/users/mystor/followers","following_url":"https://api.github.com/users/mystor/following{/other_user}","gists_url":"https://api.github.com/users/mystor/gists{/gist_id}","starred_url":"https://api.github.com/users/mystor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mystor/subscriptions","organizations_url":"https://api.github.com/users/mystor/orgs","repos_url":"https://api.github.com/users/mystor/repos","events_url":"https://api.github.com/users/mystor/events{/privacy}","received_events_url":"https://api.github.com/users/mystor/received_events","type":"User","site_admin":false},"body":"This is a WIP PR for my implementation of drain over the VecDeque data structure supporting ranges. It brings the VecDeque drain implementation in line with Vec's.\r\n\r\nTests haven't been written for the new function yet.","created_at":"2015-08-12T18:01:53Z","updated_at":"2015-08-20T18:54:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d25c4b951b8d66d0add45a03e4f1ad8a72ca4ce1","assignee":{"login":"Gankro","id":1136864,"avatar_url":"https://avatars.githubusercontent.com/u/1136864?v=3","gravatar_id":"","url":"https://api.github.com/users/Gankro","html_url":"https://github.com/Gankro","followers_url":"https://api.github.com/users/Gankro/followers","following_url":"https://api.github.com/users/Gankro/following{/other_user}","gists_url":"https://api.github.com/users/Gankro/gists{/gist_id}","starred_url":"https://api.github.com/users/Gankro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gankro/subscriptions","organizations_url":"https://api.github.com/users/Gankro/orgs","repos_url":"https://api.github.com/users/Gankro/repos","events_url":"https://api.github.com/users/Gankro/events{/privacy}","received_events_url":"https://api.github.com/users/Gankro/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/27723/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/27723/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/27723/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/ff9793b2817e7cd08c0e5ddb5aa0422bec797646","head":{"label":"mystor:vecdeque_drain_range","ref":"vecdeque_drain_range","sha":"ff9793b2817e7cd08c0e5ddb5aa0422bec797646","user":{"login":"mystor","id":1261662,"avatar_url":"https://avatars.githubusercontent.com/u/1261662?v=3","gravatar_id":"","url":"https://api.github.com/users/mystor","html_url":"https://github.com/mystor","followers_url":"https://api.github.com/users/mystor/followers","following_url":"https://api.github.com/users/mystor/following{/other_user}","gists_url":"https://api.github.com/users/mystor/gists{/gist_id}","starred_url":"https://api.github.com/users/mystor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mystor/subscriptions","organizations_url":"https://api.github.com/users/mystor/orgs","repos_url":"https://api.github.com/users/mystor/repos","events_url":"https://api.github.com/users/mystor/events{/privacy}","received_events_url":"https://api.github.com/users/mystor/received_events","type":"User","site_admin":false},"repo":{"id":36203359,"name":"rust","full_name":"mystor/rust","owner":{"login":"mystor","id":1261662,"avatar_url":"https://avatars.githubusercontent.com/u/1261662?v=3","gravatar_id":"","url":"https://api.github.com/users/mystor","html_url":"https://github.com/mystor","followers_url":"https://api.github.com/users/mystor/followers","following_url":"https://api.github.com/users/mystor/following{/other_user}","gists_url":"https://api.github.com/users/mystor/gists{/gist_id}","starred_url":"https://api.github.com/users/mystor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mystor/subscriptions","organizations_url":"https://api.github.com/users/mystor/orgs","repos_url":"https://api.github.com/users/mystor/repos","events_url":"https://api.github.com/users/mystor/events{/privacy}","received_events_url":"https://api.github.com/users/mystor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mystor/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/mystor/rust","forks_url":"https://api.github.com/repos/mystor/rust/forks","keys_url":"https://api.github.com/repos/mystor/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mystor/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mystor/rust/teams","hooks_url":"https://api.github.com/repos/mystor/rust/hooks","issue_events_url":"https://api.github.com/repos/mystor/rust/issues/events{/number}","events_url":"https://api.github.com/repos/mystor/rust/events","assignees_url":"https://api.github.com/repos/mystor/rust/assignees{/user}","branches_url":"https://api.github.com/repos/mystor/rust/branches{/branch}","tags_url":"https://api.github.com/repos/mystor/rust/tags","blobs_url":"https://api.github.com/repos/mystor/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mystor/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mystor/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/mystor/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mystor/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/mystor/rust/languages","stargazers_url":"https://api.github.com/repos/mystor/rust/stargazers","contributors_url":"https://api.github.com/repos/mystor/rust/contributors","subscribers_url":"https://api.github.com/repos/mystor/rust/subscribers","subscription_url":"https://api.github.com/repos/mystor/rust/subscription","commits_url":"https://api.github.com/repos/mystor/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/mystor/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/mystor/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/mystor/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/mystor/rust/contents/{+path}","compare_url":"https://api.github.com/repos/mystor/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mystor/rust/merges","archive_url":"https://api.github.com/repos/mystor/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mystor/rust/downloads","issues_url":"https://api.github.com/repos/mystor/rust/issues{/number}","pulls_url":"https://api.github.com/repos/mystor/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/mystor/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/mystor/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mystor/rust/labels{/name}","releases_url":"https://api.github.com/repos/mystor/rust/releases{/id}","created_at":"2015-05-25T01:40:56Z","updated_at":"2015-05-25T01:41:21Z","pushed_at":"2015-08-20T01:32:51Z","git_url":"git://github.com/mystor/rust.git","ssh_url":"git@github.com:mystor/rust.git","clone_url":"https://github.com/mystor/rust.git","svn_url":"https://github.com/mystor/rust","homepage":"http://www.rust-lang.org","size":309814,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"81c9ff24fe6d53eb51d9427302ec842da49b9edc","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-08-20T16:58:02Z","pushed_at":"2015-08-20T17:33:10Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":661160,"stargazers_count":13064,"watchers_count":13064,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2534,"mirror_url":null,"open_issues_count":2225,"forks":2534,"open_issues":2225,"watchers":13064,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27723"},"html":{"href":"https://github.com/rust-lang/rust/pull/27723"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/27723"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/27723/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27723/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27723/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/ff9793b2817e7cd08c0e5ddb5aa0422bec797646"}}}}