{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/40491942","id":40491942,"diff_hunk":"@@ -288,13 +258,11 @@ public function configureOptions(OptionsResolver $resolver)\n \n         $resolver->setDefaults(array(\n             'em' => null,\n-            'property' => null, // deprecated, use \"choice_label\"\n             'query_builder' => null,\n-            'loader' => null, // deprecated, use \"choice_loader\"\n             'choices' => null,\n             'choices_as_values' => true,\n             'choice_loader' => $choiceLoader,\n-            'choice_label' => $choiceLabel,\n+            'choice_label' => array(__CLASS__, 'createChoiceLabel'),","path":"src/Symfony/Bridge/Doctrine/Form/Type/DoctrineType.php","position":71,"original_position":71,"commit_id":"59f454d9b8584882fa1d4d660e3252aecb6fe0d4","original_commit_id":"59f454d9b8584882fa1d4d660e3252aecb6fe0d4","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"I'm not 100% sure about this change, because of this comment above it in the default closure: `// BC: use __toString() by default`\r\n\r\nHowever, I'm unsure what to use as a default value otherwise.","created_at":"2015-09-26T09:12:06Z","updated_at":"2015-09-26T09:12:06Z","html_url":"https://github.com/symfony/symfony/pull/15900#discussion_r40491942","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/15900","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/40491942"},"html":{"href":"https://github.com/symfony/symfony/pull/15900#discussion_r40491942"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15900"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/15900","id":46078604,"html_url":"https://github.com/symfony/symfony/pull/15900","diff_url":"https://github.com/symfony/symfony/pull/15900.diff","patch_url":"https://github.com/symfony/symfony/pull/15900.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/15900","number":15900,"state":"open","locked":false,"title":"[3.0][DoctrineBridge] Removed deprecated features","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | yes\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -","created_at":"2015-09-26T09:06:09Z","updated_at":"2015-09-26T09:12:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18db155c18c4cacef6e10d1c04ae53c48e7bb060","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/15900/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/15900/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/15900/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/59f454d9b8584882fa1d4d660e3252aecb6fe0d4","head":{"label":"WouterJ:doctrine_bridge-deprecations","ref":"doctrine_bridge-deprecations","sha":"59f454d9b8584882fa1d4d660e3252aecb6fe0d4","user":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"repo":{"id":5615183,"name":"symfony","full_name":"WouterJ/symfony","owner":{"login":"WouterJ","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WouterJ/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/WouterJ/symfony","forks_url":"https://api.github.com/repos/WouterJ/symfony/forks","keys_url":"https://api.github.com/repos/WouterJ/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WouterJ/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WouterJ/symfony/teams","hooks_url":"https://api.github.com/repos/WouterJ/symfony/hooks","issue_events_url":"https://api.github.com/repos/WouterJ/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/WouterJ/symfony/events","assignees_url":"https://api.github.com/repos/WouterJ/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/WouterJ/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/WouterJ/symfony/tags","blobs_url":"https://api.github.com/repos/WouterJ/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WouterJ/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WouterJ/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/WouterJ/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WouterJ/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/WouterJ/symfony/languages","stargazers_url":"https://api.github.com/repos/WouterJ/symfony/stargazers","contributors_url":"https://api.github.com/repos/WouterJ/symfony/contributors","subscribers_url":"https://api.github.com/repos/WouterJ/symfony/subscribers","subscription_url":"https://api.github.com/repos/WouterJ/symfony/subscription","commits_url":"https://api.github.com/repos/WouterJ/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/WouterJ/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/WouterJ/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/WouterJ/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/WouterJ/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/WouterJ/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WouterJ/symfony/merges","archive_url":"https://api.github.com/repos/WouterJ/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WouterJ/symfony/downloads","issues_url":"https://api.github.com/repos/WouterJ/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/WouterJ/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/WouterJ/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/WouterJ/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WouterJ/symfony/labels{/name}","releases_url":"https://api.github.com/repos/WouterJ/symfony/releases{/id}","created_at":"2012-08-30T13:24:57Z","updated_at":"2014-08-16T18:38:32Z","pushed_at":"2015-09-26T09:10:41Z","git_url":"git://github.com/WouterJ/symfony.git","ssh_url":"git@github.com:WouterJ/symfony.git","clone_url":"https://github.com/WouterJ/symfony.git","svn_url":"https://github.com/WouterJ/symfony","homepage":"symfony.com","size":59830,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"967c0e439acddd6e82003daf783c70541866a271","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-09-26T08:51:09Z","pushed_at":"2015-09-26T09:10:42Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":246026,"stargazers_count":10838,"watchers_count":10838,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4269,"mirror_url":null,"open_issues_count":909,"forks":4269,"open_issues":909,"watchers":10838,"default_branch":"2.8"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15900"},"html":{"href":"https://github.com/symfony/symfony/pull/15900"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/15900"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/15900/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15900/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/15900/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/59f454d9b8584882fa1d4d660e3252aecb6fe0d4"}}}}