{"action":"created","comment":{"url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/comments/27873821","id":27873821,"diff_hunk":"@@ -28,18 +28,22 @@\n   \"Send value and coordinates to the client through the debug channel.\n   Sends a response to the message stored in debugger-message.\"\n   [value extras]\n-  ;; Notify cider that a (break) is incoming, along with the value of\n-  ;; the instrumented sexp and instructions on how to find it in the\n-  ;; code.\n-  (transport/send\n-   (:transport @debugger-message)\n-   (response-for @debugger-message\n-                 (assoc extras\n-                        :debug-value (pr-str value)\n-                        :breakfunction nil)))\n-  ;; Send the actual break.\n-  (binding [*out* (new java.io.StringWriter)]\n-    (break value)))\n+  ;; Don't debug code being run synchronously. It is probably\n+  ;; unintended and will unexpectedly ask for input.\n+  (if (:sync clojure.tools.nrepl.middleware.interruptible-eval/*msg*)","path":"src/cider/nrepl/middleware/debug.clj","position":18,"original_position":18,"commit_id":"a4c557c74cdefafc5e5a71b334bd69fb803d67aa","original_commit_id":"a4c557c74cdefafc5e5a71b334bd69fb803d67aa","user":{"login":"Malabarba","id":453029,"avatar_url":"https://avatars.githubusercontent.com/u/453029?v=3","gravatar_id":"","url":"https://api.github.com/users/Malabarba","html_url":"https://github.com/Malabarba","followers_url":"https://api.github.com/users/Malabarba/followers","following_url":"https://api.github.com/users/Malabarba/following{/other_user}","gists_url":"https://api.github.com/users/Malabarba/gists{/gist_id}","starred_url":"https://api.github.com/users/Malabarba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Malabarba/subscriptions","organizations_url":"https://api.github.com/users/Malabarba/orgs","repos_url":"https://api.github.com/users/Malabarba/repos","events_url":"https://api.github.com/users/Malabarba/events{/privacy}","received_events_url":"https://api.github.com/users/Malabarba/received_events","type":"User","site_admin":false},"body":"> Not been following the issue too closely, so forgive my ignorance, but shouldn't this really be fixed client-side (i.e. properly handle need-input during synchronous requests) so we don't need this kind of hack?\r\n\r\nYes, this should be fixed client-side, but I'm under the impression that even with the handle-input fix in sync-request the breakpoint will still bug out during a sync eval (because its workings are more complicated than a simple need-input event). Still, I haven't had a chance to test that conjecture yet (busy busy busy :-P).","created_at":"2015-04-07T12:45:59Z","updated_at":"2015-04-07T12:45:59Z","html_url":"https://github.com/clojure-emacs/cider-nrepl/pull/181#discussion_r27873821","pull_request_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/181","_links":{"self":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/comments/27873821"},"html":{"href":"https://github.com/clojure-emacs/cider-nrepl/pull/181#discussion_r27873821"},"pull_request":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/181"}}},"pull_request":{"url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/181","id":32650198,"html_url":"https://github.com/clojure-emacs/cider-nrepl/pull/181","diff_url":"https://github.com/clojure-emacs/cider-nrepl/pull/181.diff","patch_url":"https://github.com/clojure-emacs/cider-nrepl/pull/181.patch","issue_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/181","number":181,"state":"open","locked":false,"title":"[cider#1052] Don't debug synchronous code","user":{"login":"Malabarba","id":453029,"avatar_url":"https://avatars.githubusercontent.com/u/453029?v=3","gravatar_id":"","url":"https://api.github.com/users/Malabarba","html_url":"https://github.com/Malabarba","followers_url":"https://api.github.com/users/Malabarba/followers","following_url":"https://api.github.com/users/Malabarba/following{/other_user}","gists_url":"https://api.github.com/users/Malabarba/gists{/gist_id}","starred_url":"https://api.github.com/users/Malabarba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Malabarba/subscriptions","organizations_url":"https://api.github.com/users/Malabarba/orgs","repos_url":"https://api.github.com/users/Malabarba/repos","events_url":"https://api.github.com/users/Malabarba/events{/privacy}","received_events_url":"https://api.github.com/users/Malabarba/received_events","type":"User","site_admin":false},"body":"Relies on https://github.com/clojure-emacs/cider/pull/1070","created_at":"2015-04-05T15:38:16Z","updated_at":"2015-04-07T12:45:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f903c538e15e8dda1c715b0e7181c9baf6d70bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/181/commits","review_comments_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/181/comments","review_comment_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/181/comments","statuses_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/statuses/a4c557c74cdefafc5e5a71b334bd69fb803d67aa","head":{"label":"Malabarba:master","ref":"master","sha":"a4c557c74cdefafc5e5a71b334bd69fb803d67aa","user":{"login":"Malabarba","id":453029,"avatar_url":"https://avatars.githubusercontent.com/u/453029?v=3","gravatar_id":"","url":"https://api.github.com/users/Malabarba","html_url":"https://github.com/Malabarba","followers_url":"https://api.github.com/users/Malabarba/followers","following_url":"https://api.github.com/users/Malabarba/following{/other_user}","gists_url":"https://api.github.com/users/Malabarba/gists{/gist_id}","starred_url":"https://api.github.com/users/Malabarba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Malabarba/subscriptions","organizations_url":"https://api.github.com/users/Malabarba/orgs","repos_url":"https://api.github.com/users/Malabarba/repos","events_url":"https://api.github.com/users/Malabarba/events{/privacy}","received_events_url":"https://api.github.com/users/Malabarba/received_events","type":"User","site_admin":false},"repo":{"id":32170454,"name":"cider-nrepl","full_name":"Malabarba/cider-nrepl","owner":{"login":"Malabarba","id":453029,"avatar_url":"https://avatars.githubusercontent.com/u/453029?v=3","gravatar_id":"","url":"https://api.github.com/users/Malabarba","html_url":"https://github.com/Malabarba","followers_url":"https://api.github.com/users/Malabarba/followers","following_url":"https://api.github.com/users/Malabarba/following{/other_user}","gists_url":"https://api.github.com/users/Malabarba/gists{/gist_id}","starred_url":"https://api.github.com/users/Malabarba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Malabarba/subscriptions","organizations_url":"https://api.github.com/users/Malabarba/orgs","repos_url":"https://api.github.com/users/Malabarba/repos","events_url":"https://api.github.com/users/Malabarba/events{/privacy}","received_events_url":"https://api.github.com/users/Malabarba/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Malabarba/cider-nrepl","description":"nREPL middleware for CIDER","fork":true,"url":"https://api.github.com/repos/Malabarba/cider-nrepl","forks_url":"https://api.github.com/repos/Malabarba/cider-nrepl/forks","keys_url":"https://api.github.com/repos/Malabarba/cider-nrepl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Malabarba/cider-nrepl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Malabarba/cider-nrepl/teams","hooks_url":"https://api.github.com/repos/Malabarba/cider-nrepl/hooks","issue_events_url":"https://api.github.com/repos/Malabarba/cider-nrepl/issues/events{/number}","events_url":"https://api.github.com/repos/Malabarba/cider-nrepl/events","assignees_url":"https://api.github.com/repos/Malabarba/cider-nrepl/assignees{/user}","branches_url":"https://api.github.com/repos/Malabarba/cider-nrepl/branches{/branch}","tags_url":"https://api.github.com/repos/Malabarba/cider-nrepl/tags","blobs_url":"https://api.github.com/repos/Malabarba/cider-nrepl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Malabarba/cider-nrepl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Malabarba/cider-nrepl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Malabarba/cider-nrepl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Malabarba/cider-nrepl/statuses/{sha}","languages_url":"https://api.github.com/repos/Malabarba/cider-nrepl/languages","stargazers_url":"https://api.github.com/repos/Malabarba/cider-nrepl/stargazers","contributors_url":"https://api.github.com/repos/Malabarba/cider-nrepl/contributors","subscribers_url":"https://api.github.com/repos/Malabarba/cider-nrepl/subscribers","subscription_url":"https://api.github.com/repos/Malabarba/cider-nrepl/subscription","commits_url":"https://api.github.com/repos/Malabarba/cider-nrepl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Malabarba/cider-nrepl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Malabarba/cider-nrepl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Malabarba/cider-nrepl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Malabarba/cider-nrepl/contents/{+path}","compare_url":"https://api.github.com/repos/Malabarba/cider-nrepl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Malabarba/cider-nrepl/merges","archive_url":"https://api.github.com/repos/Malabarba/cider-nrepl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Malabarba/cider-nrepl/downloads","issues_url":"https://api.github.com/repos/Malabarba/cider-nrepl/issues{/number}","pulls_url":"https://api.github.com/repos/Malabarba/cider-nrepl/pulls{/number}","milestones_url":"https://api.github.com/repos/Malabarba/cider-nrepl/milestones{/number}","notifications_url":"https://api.github.com/repos/Malabarba/cider-nrepl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Malabarba/cider-nrepl/labels{/name}","releases_url":"https://api.github.com/repos/Malabarba/cider-nrepl/releases{/id}","created_at":"2015-03-13T17:28:50Z","updated_at":"2015-04-06T15:35:28Z","pushed_at":"2015-04-06T15:35:28Z","git_url":"git://github.com/Malabarba/cider-nrepl.git","ssh_url":"git@github.com:Malabarba/cider-nrepl.git","clone_url":"https://github.com/Malabarba/cider-nrepl.git","svn_url":"https://github.com/Malabarba/cider-nrepl","homepage":null,"size":561,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clojure-emacs:master","ref":"master","sha":"63818ed68e7e427752cd4205b003a857d13e3c71","user":{"login":"clojure-emacs","id":5080083,"avatar_url":"https://avatars.githubusercontent.com/u/5080083?v=3","gravatar_id":"","url":"https://api.github.com/users/clojure-emacs","html_url":"https://github.com/clojure-emacs","followers_url":"https://api.github.com/users/clojure-emacs/followers","following_url":"https://api.github.com/users/clojure-emacs/following{/other_user}","gists_url":"https://api.github.com/users/clojure-emacs/gists{/gist_id}","starred_url":"https://api.github.com/users/clojure-emacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clojure-emacs/subscriptions","organizations_url":"https://api.github.com/users/clojure-emacs/orgs","repos_url":"https://api.github.com/users/clojure-emacs/repos","events_url":"https://api.github.com/users/clojure-emacs/events{/privacy}","received_events_url":"https://api.github.com/users/clojure-emacs/received_events","type":"Organization","site_admin":false},"repo":{"id":15360927,"name":"cider-nrepl","full_name":"clojure-emacs/cider-nrepl","owner":{"login":"clojure-emacs","id":5080083,"avatar_url":"https://avatars.githubusercontent.com/u/5080083?v=3","gravatar_id":"","url":"https://api.github.com/users/clojure-emacs","html_url":"https://github.com/clojure-emacs","followers_url":"https://api.github.com/users/clojure-emacs/followers","following_url":"https://api.github.com/users/clojure-emacs/following{/other_user}","gists_url":"https://api.github.com/users/clojure-emacs/gists{/gist_id}","starred_url":"https://api.github.com/users/clojure-emacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clojure-emacs/subscriptions","organizations_url":"https://api.github.com/users/clojure-emacs/orgs","repos_url":"https://api.github.com/users/clojure-emacs/repos","events_url":"https://api.github.com/users/clojure-emacs/events{/privacy}","received_events_url":"https://api.github.com/users/clojure-emacs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clojure-emacs/cider-nrepl","description":"nREPL middleware for CIDER","fork":false,"url":"https://api.github.com/repos/clojure-emacs/cider-nrepl","forks_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/forks","keys_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/teams","hooks_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/hooks","issue_events_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/events{/number}","events_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/events","assignees_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/assignees{/user}","branches_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/branches{/branch}","tags_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/tags","blobs_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/git/refs{/sha}","trees_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/statuses/{sha}","languages_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/languages","stargazers_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/stargazers","contributors_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/contributors","subscribers_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/subscribers","subscription_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/subscription","commits_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/commits{/sha}","git_commits_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/git/commits{/sha}","comments_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/comments{/number}","issue_comment_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/comments{/number}","contents_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/contents/{+path}","compare_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/merges","archive_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/downloads","issues_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues{/number}","pulls_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls{/number}","milestones_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/milestones{/number}","notifications_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/labels{/name}","releases_url":"https://api.github.com/repos/clojure-emacs/cider-nrepl/releases{/id}","created_at":"2013-12-21T15:27:38Z","updated_at":"2015-04-04T10:55:20Z","pushed_at":"2015-04-06T15:35:28Z","git_url":"git://github.com/clojure-emacs/cider-nrepl.git","ssh_url":"git@github.com:clojure-emacs/cider-nrepl.git","clone_url":"https://github.com/clojure-emacs/cider-nrepl.git","svn_url":"https://github.com/clojure-emacs/cider-nrepl","homepage":null,"size":1778,"stargazers_count":149,"watchers_count":149,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":12,"forks":34,"open_issues":12,"watchers":149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/181"},"html":{"href":"https://github.com/clojure-emacs/cider-nrepl/pull/181"},"issue":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/181"},"comments":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/clojure-emacs/cider-nrepl/statuses/a4c557c74cdefafc5e5a71b334bd69fb803d67aa"}}}}