{"action":"created","issue":{"url":"https://api.github.com/repos/samsara/samsara-clj-sdk/issues/2","labels_url":"https://api.github.com/repos/samsara/samsara-clj-sdk/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/samsara/samsara-clj-sdk/issues/2/comments","events_url":"https://api.github.com/repos/samsara/samsara-clj-sdk/issues/2/events","html_url":"https://github.com/samsara/samsara-clj-sdk/pull/2","id":74674431,"number":2,"title":"Various fixes, please click on the individual commits and see inline comments","user":{"login":"BrunoBonacci","id":1639862,"avatar_url":"https://avatars.githubusercontent.com/u/1639862?v=3","gravatar_id":"","url":"https://api.github.com/users/BrunoBonacci","html_url":"https://github.com/BrunoBonacci","followers_url":"https://api.github.com/users/BrunoBonacci/followers","following_url":"https://api.github.com/users/BrunoBonacci/following{/other_user}","gists_url":"https://api.github.com/users/BrunoBonacci/gists{/gist_id}","starred_url":"https://api.github.com/users/BrunoBonacci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrunoBonacci/subscriptions","organizations_url":"https://api.github.com/users/BrunoBonacci/orgs","repos_url":"https://api.github.com/users/BrunoBonacci/repos","events_url":"https://api.github.com/users/BrunoBonacci/events{/privacy}","received_events_url":"https://api.github.com/users/BrunoBonacci/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-09T13:35:34Z","updated_at":"2015-05-11T13:58:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/samsara/samsara-clj-sdk/pulls/2","html_url":"https://github.com/samsara/samsara-clj-sdk/pull/2","diff_url":"https://github.com/samsara/samsara-clj-sdk/pull/2.diff","patch_url":"https://github.com/samsara/samsara-clj-sdk/pull/2.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/samsara/samsara-clj-sdk/issues/comments/100917101","html_url":"https://github.com/samsara/samsara-clj-sdk/pull/2#issuecomment-100917101","issue_url":"https://api.github.com/repos/samsara/samsara-clj-sdk/issues/2","id":100917101,"user":{"login":"DayoOliyide","id":2631743,"avatar_url":"https://avatars.githubusercontent.com/u/2631743?v=3","gravatar_id":"","url":"https://api.github.com/users/DayoOliyide","html_url":"https://github.com/DayoOliyide","followers_url":"https://api.github.com/users/DayoOliyide/followers","following_url":"https://api.github.com/users/DayoOliyide/following{/other_user}","gists_url":"https://api.github.com/users/DayoOliyide/gists{/gist_id}","starred_url":"https://api.github.com/users/DayoOliyide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DayoOliyide/subscriptions","organizations_url":"https://api.github.com/users/DayoOliyide/orgs","repos_url":"https://api.github.com/users/DayoOliyide/repos","events_url":"https://api.github.com/users/DayoOliyide/events{/privacy}","received_events_url":"https://api.github.com/users/DayoOliyide/received_events","type":"User","site_admin":false},"created_at":"2015-05-11T13:58:54Z","updated_at":"2015-05-11T13:58:54Z","body":"The only other thing I would add to Bruno's feedback is\r\n- The send-events function should throw an Exception that contains the status and any http response message. This would help in diagnosing why the call failed\r\n\r\nTo follow on what Bruno says about immutable data. I wonder if the ring-buffer should be stored in the client namespace ? Whether is something that should be passed in to functions and returned by the functions? "}}