{"action":"created","issue":{"url":"https://api.github.com/repos/vpulim/node-soap/issues/629","labels_url":"https://api.github.com/repos/vpulim/node-soap/issues/629/labels{/name}","comments_url":"https://api.github.com/repos/vpulim/node-soap/issues/629/comments","events_url":"https://api.github.com/repos/vpulim/node-soap/issues/629/events","html_url":"https://github.com/vpulim/node-soap/pull/629","id":68420425,"number":629,"title":"Taking ignoredNamespaces into account for objectToXML","user":{"login":"tobias-neubert","id":5521862,"avatar_url":"https://avatars.githubusercontent.com/u/5521862?v=3","gravatar_id":"","url":"https://api.github.com/users/tobias-neubert","html_url":"https://github.com/tobias-neubert","followers_url":"https://api.github.com/users/tobias-neubert/followers","following_url":"https://api.github.com/users/tobias-neubert/following{/other_user}","gists_url":"https://api.github.com/users/tobias-neubert/gists{/gist_id}","starred_url":"https://api.github.com/users/tobias-neubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobias-neubert/subscriptions","organizations_url":"https://api.github.com/users/tobias-neubert/orgs","repos_url":"https://api.github.com/users/tobias-neubert/repos","events_url":"https://api.github.com/users/tobias-neubert/events{/privacy}","received_events_url":"https://api.github.com/users/tobias-neubert/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-14T15:54:40Z","updated_at":"2015-05-19T22:24:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vpulim/node-soap/pulls/629","html_url":"https://github.com/vpulim/node-soap/pull/629","diff_url":"https://github.com/vpulim/node-soap/pull/629.diff","patch_url":"https://github.com/vpulim/node-soap/pull/629.patch"},"body":"If an object is converted into an xml representation (in wsdl.js, objectToXML) the element will never be prefixed with the namespace, even if one provided the corresponding option to createClient. The function only compares the given namespace with the constant property of wsdl.js.\r\n\r\nThis commit fixes that by comparing this.options.ignoredNamespaces, which is the overridden/concatenated version of this.ignoredNamespaces and the corresponding option, provided to createClient."},"comment":{"url":"https://api.github.com/repos/vpulim/node-soap/issues/comments/103683665","html_url":"https://github.com/vpulim/node-soap/pull/629#issuecomment-103683665","issue_url":"https://api.github.com/repos/vpulim/node-soap/issues/629","id":103683665,"user":{"login":"herom","id":2472487,"avatar_url":"https://avatars.githubusercontent.com/u/2472487?v=3","gravatar_id":"","url":"https://api.github.com/users/herom","html_url":"https://github.com/herom","followers_url":"https://api.github.com/users/herom/followers","following_url":"https://api.github.com/users/herom/following{/other_user}","gists_url":"https://api.github.com/users/herom/gists{/gist_id}","starred_url":"https://api.github.com/users/herom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herom/subscriptions","organizations_url":"https://api.github.com/users/herom/orgs","repos_url":"https://api.github.com/users/herom/repos","events_url":"https://api.github.com/users/herom/events{/privacy}","received_events_url":"https://api.github.com/users/herom/received_events","type":"User","site_admin":false},"created_at":"2015-05-19T22:24:02Z","updated_at":"2015-05-19T22:24:02Z","body":"Hello @tobias-neubert - thanks a lot for your contribution and sorry for the extremely long delay :disappointed: \r\n\r\nIn order to get your PR merged I'll have to ask you to follow our [Guideline on Submitting a Pull Request](https://github.com/vpulim/node-soap/blob/master/CONTRIBUTING.md#submitting-a-pull-request) and work through the open points, which are:\r\n\r\n- Add accompanying tests\r\n- Run `npm test` locally and take a look at the Travis CI logs in order to make the PR pass all the tests\r\n\r\nThanks a lot for your patience :+1:"}}