{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/22403909","id":22403909,"diff_hunk":"@@ -409,10 +413,14 @@ public static function move($src, $dest, $path = '', $use_streams = false)\n \t{\n \t\t$FTPOptions = JClientHelper::getCredentials('ftp');\n \n+\t\t$src = JPath::clean($src);\n+\t\t$dest = JPath::clean($dest);\n+\n \t\tif ($path)\n \t\t{\n-\t\t\t$src = JPath::clean($path . '/' . $src);\n-\t\t\t$dest = JPath::clean($path . '/' . $dest);\n+\t\t\t$path = JPath::clean($path);\n+\t\t\t$src = $path . '/' . $src;","path":"libraries/joomla/filesystem/folder.php","position":36,"original_position":36,"commit_id":"cc73efd457decefe181433de12b45edf0c3743fe","original_commit_id":"cc73efd457decefe181433de12b45edf0c3743fe","user":{"login":"mbabker","id":368545,"avatar_url":"https://avatars.githubusercontent.com/u/368545?v=3","gravatar_id":"","url":"https://api.github.com/users/mbabker","html_url":"https://github.com/mbabker","followers_url":"https://api.github.com/users/mbabker/followers","following_url":"https://api.github.com/users/mbabker/following{/other_user}","gists_url":"https://api.github.com/users/mbabker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbabker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbabker/subscriptions","organizations_url":"https://api.github.com/users/mbabker/orgs","repos_url":"https://api.github.com/users/mbabker/repos","events_url":"https://api.github.com/users/mbabker/events{/privacy}","received_events_url":"https://api.github.com/users/mbabker/received_events","type":"User","site_admin":false},"body":"In theory, I agree totally.  However, there's a reason the policy was written the way it is (something I had a hand in).  There isn't lenience for \"well, it probably won't break anything\" situations like this; it essentially comes down to \"Is this change breaking B/C?  If yes, do this...\" style logic.  It hurts our code base a little during the growth of a major release series, but the intent is to provide a stable API which doesn't introduce breaking changes in the middle of it.\r\n\r\nPerfect example, if you see the first working version of the install adapter code I worked on with a couple others a couple years ago and compare it to what is being proposed now, you'll see a lot more B/C considerations in the PRs; the original code took no consideration for that but having that end state (working code with a desired goal) allowed me to work backwards to integrate it in a B/C manner and introduce a roadmap into v4 (within those classes at least) and what B/C breaking changes are suggested to occur.","created_at":"2015-01-02T03:18:52Z","updated_at":"2015-01-02T03:18:52Z","html_url":"https://github.com/joomla/joomla-cms/pull/5586#discussion_r22403909","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/5586","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/22403909"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/5586#discussion_r22403909"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/5586"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/5586","id":26748523,"html_url":"https://github.com/joomla/joomla-cms/pull/5586","diff_url":"https://github.com/joomla/joomla-cms/pull/5586.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/5586.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/5586","number":5586,"state":"closed","locked":false,"title":"A sister PR to #5569","user":{"login":"smz","id":552475,"avatar_url":"https://avatars.githubusercontent.com/u/552475?v=3","gravatar_id":"","url":"https://api.github.com/users/smz","html_url":"https://github.com/smz","followers_url":"https://api.github.com/users/smz/followers","following_url":"https://api.github.com/users/smz/following{/other_user}","gists_url":"https://api.github.com/users/smz/gists{/gist_id}","starred_url":"https://api.github.com/users/smz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smz/subscriptions","organizations_url":"https://api.github.com/users/smz/orgs","repos_url":"https://api.github.com/users/smz/repos","events_url":"https://api.github.com/users/smz/events{/privacy}","received_events_url":"https://api.github.com/users/smz/received_events","type":"User","site_admin":false},"body":"This is the same as #5569, but with the modified `JPath::clean()` and no `JPath::ux_clean()`","created_at":"2015-01-02T01:46:23Z","updated_at":"2015-01-02T03:18:52Z","closed_at":"2015-01-02T02:33:50Z","merged_at":null,"merge_commit_sha":"f76a744686f28562b1f336e56ae3364fd958ee76","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/5586/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/5586/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/{number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/5586/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/cc73efd457decefe181433de12b45edf0c3743fe","head":{"label":"smz:NoMoreBackSlash-2","ref":"NoMoreBackSlash-2","sha":"cc73efd457decefe181433de12b45edf0c3743fe","user":{"login":"smz","id":552475,"avatar_url":"https://avatars.githubusercontent.com/u/552475?v=3","gravatar_id":"","url":"https://api.github.com/users/smz","html_url":"https://github.com/smz","followers_url":"https://api.github.com/users/smz/followers","following_url":"https://api.github.com/users/smz/following{/other_user}","gists_url":"https://api.github.com/users/smz/gists{/gist_id}","starred_url":"https://api.github.com/users/smz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smz/subscriptions","organizations_url":"https://api.github.com/users/smz/orgs","repos_url":"https://api.github.com/users/smz/repos","events_url":"https://api.github.com/users/smz/events{/privacy}","received_events_url":"https://api.github.com/users/smz/received_events","type":"User","site_admin":false},"repo":{"id":26371167,"name":"joomla-cms","full_name":"smz/joomla-cms","owner":{"login":"smz","id":552475,"avatar_url":"https://avatars.githubusercontent.com/u/552475?v=3","gravatar_id":"","url":"https://api.github.com/users/smz","html_url":"https://github.com/smz","followers_url":"https://api.github.com/users/smz/followers","following_url":"https://api.github.com/users/smz/following{/other_user}","gists_url":"https://api.github.com/users/smz/gists{/gist_id}","starred_url":"https://api.github.com/users/smz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smz/subscriptions","organizations_url":"https://api.github.com/users/smz/orgs","repos_url":"https://api.github.com/users/smz/repos","events_url":"https://api.github.com/users/smz/events{/privacy}","received_events_url":"https://api.github.com/users/smz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smz/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/smz/joomla-cms","forks_url":"https://api.github.com/repos/smz/joomla-cms/forks","keys_url":"https://api.github.com/repos/smz/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smz/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smz/joomla-cms/teams","hooks_url":"https://api.github.com/repos/smz/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/smz/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/smz/joomla-cms/events","assignees_url":"https://api.github.com/repos/smz/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/smz/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/smz/joomla-cms/tags","blobs_url":"https://api.github.com/repos/smz/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smz/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smz/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/smz/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smz/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/smz/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/smz/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/smz/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/smz/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/smz/joomla-cms/subscription","commits_url":"https://api.github.com/repos/smz/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/smz/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/smz/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/smz/joomla-cms/issues/comments/{number}","contents_url":"https://api.github.com/repos/smz/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/smz/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smz/joomla-cms/merges","archive_url":"https://api.github.com/repos/smz/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smz/joomla-cms/downloads","issues_url":"https://api.github.com/repos/smz/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/smz/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/smz/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/smz/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smz/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/smz/joomla-cms/releases{/id}","created_at":"2014-11-08T19:00:02Z","updated_at":"2014-12-31T14:17:03Z","pushed_at":"2015-01-02T01:43:19Z","git_url":"git://github.com/smz/joomla-cms.git","ssh_url":"git@github.com:smz/joomla-cms.git","clone_url":"https://github.com/smz/joomla-cms.git","svn_url":"https://github.com/smz/joomla-cms","homepage":"http://joomla.org","size":122891,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"328811ae61ed2ff87d68005bd30e38b2e31594a6","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/{number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","created_at":"2011-09-27T02:07:38Z","updated_at":"2015-01-02T02:23:57Z","pushed_at":"2015-01-02T02:23:56Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"http://joomla.org","size":287754,"stargazers_count":1389,"watchers_count":1389,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1542,"mirror_url":null,"open_issues_count":456,"forks":1542,"open_issues":456,"watchers":1389,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/5586"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/5586"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/5586"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/5586/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/5586/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/5586/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/cc73efd457decefe181433de12b45edf0c3743fe"}}}}