{"action":"created","issue":{"url":"https://api.github.com/repos/docker/machine/issues/2691","labels_url":"https://api.github.com/repos/docker/machine/issues/2691/labels{/name}","comments_url":"https://api.github.com/repos/docker/machine/issues/2691/comments","events_url":"https://api.github.com/repos/docker/machine/issues/2691/events","html_url":"https://github.com/docker/machine/pull/2691","id":123906090,"number":2691,"title":"Standardize --driver-memory-size flag including ENV vars","user":{"login":"jgeiger","id":10274,"avatar_url":"https://avatars.githubusercontent.com/u/10274?v=3","gravatar_id":"","url":"https://api.github.com/users/jgeiger","html_url":"https://github.com/jgeiger","followers_url":"https://api.github.com/users/jgeiger/followers","following_url":"https://api.github.com/users/jgeiger/following{/other_user}","gists_url":"https://api.github.com/users/jgeiger/gists{/gist_id}","starred_url":"https://api.github.com/users/jgeiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgeiger/subscriptions","organizations_url":"https://api.github.com/users/jgeiger/orgs","repos_url":"https://api.github.com/users/jgeiger/repos","events_url":"https://api.github.com/users/jgeiger/events{/privacy}","received_events_url":"https://api.github.com/users/jgeiger/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/machine/labels/status/0-triage","name":"status/0-triage","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/machine/milestones/11","html_url":"https://github.com/docker/machine/milestones/0.6.0","labels_url":"https://api.github.com/repos/docker/machine/milestones/11/labels","id":1475632,"number":11,"title":"0.6.0","description":"","creator":{"login":"dgageot","id":153495,"avatar_url":"https://avatars.githubusercontent.com/u/153495?v=3","gravatar_id":"","url":"https://api.github.com/users/dgageot","html_url":"https://github.com/dgageot","followers_url":"https://api.github.com/users/dgageot/followers","following_url":"https://api.github.com/users/dgageot/following{/other_user}","gists_url":"https://api.github.com/users/dgageot/gists{/gist_id}","starred_url":"https://api.github.com/users/dgageot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgageot/subscriptions","organizations_url":"https://api.github.com/users/dgageot/orgs","repos_url":"https://api.github.com/users/dgageot/repos","events_url":"https://api.github.com/users/dgageot/events{/privacy}","received_events_url":"https://api.github.com/users/dgageot/received_events","type":"User","site_admin":false},"open_issues":33,"closed_issues":1,"state":"open","created_at":"2015-12-28T08:11:50Z","updated_at":"2015-12-29T08:36:04Z","due_on":"2016-01-10T23:00:00Z","closed_at":null},"comments":5,"created_at":"2015-12-26T03:17:33Z","updated_at":"2015-12-29T09:10:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/machine/pulls/2691","html_url":"https://github.com/docker/machine/pull/2691","diff_url":"https://github.com/docker/machine/pull/2691.diff","patch_url":"https://github.com/docker/machine/pull/2691.patch"},"body":"- Some drivers use --driver-memory but have the ENV variable as\r\n  DRIVER_MEMORY_SIZE. This request makes all drivers use the\r\n  --driver-memory-size flag, but still allows for non-conforming\r\n  drivers to use the --driver-memory flag until deprecated.\r\n  In the case where --driver-memory-size matches the defaultMemory,\r\n  use the --driver-memory flag. If neither flag is used, the\r\n  memory is still set to defaultMemory."},"comment":{"url":"https://api.github.com/repos/docker/machine/issues/comments/167753581","html_url":"https://github.com/docker/machine/pull/2691#issuecomment-167753581","issue_url":"https://api.github.com/repos/docker/machine/issues/2691","id":167753581,"user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"created_at":"2015-12-29T09:10:04Z","updated_at":"2015-12-29T09:10:04Z","body":"From a UX perspective, dropping the prefix would definitively be better. Some things to consider / take into account here;\r\n\r\n- In docker \"engine\", we defined a [deprecation policy](https://docs.docker.com/engine/misc/#feature-deprecation-policy) that allows users to adopt; i.e., announce the old flags as deprecated, but keep them around for 2 more releases\r\n- I suggested the mflags package; it served the engine well, but I haven't looked into the code quality, it may need some TLC (I think it hasn't been updated in a while :smile:)\r\n- If the driver-prefix is dropped, it's important that the flags have the same behavior across drivers (accept the same kind of options / values) to prevent unexpected behavior for the end-user; can we guarantee that? We may need to define that behavior (describe in detail what a flag does, how it should work), so that plugin developers can take that into account.\r\n- Flags that are specific to / only supported on a specific driver, should still be prefixed with the driver-name. Alternatively, introduce a \"generic\" flag that allows passing driver-specific options (e.g. `--driver-opt=somedriver.someopt=somevalue`)\r\n\r\n...Just some thoughts"}}