{"action":"created","comment":{"url":"https://api.github.com/repos/projectjellyfish/api/pulls/comments/25138535","id":25138535,"diff_hunk":"@@ -1,7 +1,7 @@\n class SettingsController < ApplicationController\n   before_action :load_settings, only: [:index]\n   before_action :load_setting, only: [:update, :destroy, :edit]\n-  before_action :load_setting_by_name, only: [:show]\n+  before_action :load_setting_by_hid, only: [:show]","path":"app/controllers/settings_controller.rb","position":5,"original_position":5,"commit_id":"54133ea47cbcf7b8b120f0c3d66242e617f440ef","original_commit_id":"ddf2bc0d93087d98433309b24f7cee7945476ac5","user":{"login":"chriskacerguis","id":2414647,"avatar_url":"https://avatars.githubusercontent.com/u/2414647?v=3","gravatar_id":"","url":"https://api.github.com/users/chriskacerguis","html_url":"https://github.com/chriskacerguis","followers_url":"https://api.github.com/users/chriskacerguis/followers","following_url":"https://api.github.com/users/chriskacerguis/following{/other_user}","gists_url":"https://api.github.com/users/chriskacerguis/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskacerguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskacerguis/subscriptions","organizations_url":"https://api.github.com/users/chriskacerguis/orgs","repos_url":"https://api.github.com/users/chriskacerguis/repos","events_url":"https://api.github.com/users/chriskacerguis/events{/privacy}","received_events_url":"https://api.github.com/users/chriskacerguis/received_events","type":"User","site_admin":false},"body":"@stackus trying to understand things here.  \r\n\r\nNo there is not a \"env_var_name\" on the Settings table, however there IS on the settings_fields table.  \r\n\r\nBased on what I see prior to your commit, there is an \"env_var_name\" on every row.\r\n\r\nRegarding \"exposing system setup, environment var names and values\", could you explain what you mean by that?  Since the project is open source, the ENV vars are public (and they would need to be so people could use them).  \r\n\r\nNot trying to argue, just trying to understand.  :)\r\n","created_at":"2015-02-22T23:34:24Z","updated_at":"2015-02-22T23:34:24Z","html_url":"https://github.com/projectjellyfish/api/pull/265#discussion_r25138535","pull_request_url":"https://api.github.com/repos/projectjellyfish/api/pulls/265","_links":{"self":{"href":"https://api.github.com/repos/projectjellyfish/api/pulls/comments/25138535"},"html":{"href":"https://github.com/projectjellyfish/api/pull/265#discussion_r25138535"},"pull_request":{"href":"https://api.github.com/repos/projectjellyfish/api/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/projectjellyfish/api/pulls/265","id":29749172,"html_url":"https://github.com/projectjellyfish/api/pull/265","diff_url":"https://github.com/projectjellyfish/api/pull/265.diff","patch_url":"https://github.com/projectjellyfish/api/pull/265.patch","issue_url":"https://api.github.com/repos/projectjellyfish/api/issues/265","number":265,"state":"open","locked":false,"title":"Feature/109 sso authentication","user":{"login":"stackus","id":158579,"avatar_url":"https://avatars.githubusercontent.com/u/158579?v=3","gravatar_id":"","url":"https://api.github.com/users/stackus","html_url":"https://github.com/stackus","followers_url":"https://api.github.com/users/stackus/followers","following_url":"https://api.github.com/users/stackus/following{/other_user}","gists_url":"https://api.github.com/users/stackus/gists{/gist_id}","starred_url":"https://api.github.com/users/stackus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stackus/subscriptions","organizations_url":"https://api.github.com/users/stackus/orgs","repos_url":"https://api.github.com/users/stackus/repos","events_url":"https://api.github.com/users/stackus/events{/privacy}","received_events_url":"https://api.github.com/users/stackus/received_events","type":"User","site_admin":false},"body":"#109 \r\nThis PR has a matching PR in UX merge them both after comments and approval.\r\n\r\nMerge before https://github.com/projectjellyfish/ux/pull/209.","created_at":"2015-02-21T05:21:37Z","updated_at":"2015-02-22T23:34:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de9c3fb10cd565d420393180d62181ab7f0372d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projectjellyfish/api/pulls/265/commits","review_comments_url":"https://api.github.com/repos/projectjellyfish/api/pulls/265/comments","review_comment_url":"https://api.github.com/repos/projectjellyfish/api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectjellyfish/api/issues/265/comments","statuses_url":"https://api.github.com/repos/projectjellyfish/api/statuses/54133ea47cbcf7b8b120f0c3d66242e617f440ef","head":{"label":"projectjellyfish:feature/109-sso-authentication","ref":"feature/109-sso-authentication","sha":"54133ea47cbcf7b8b120f0c3d66242e617f440ef","user":{"login":"projectjellyfish","id":10867673,"avatar_url":"https://avatars.githubusercontent.com/u/10867673?v=3","gravatar_id":"","url":"https://api.github.com/users/projectjellyfish","html_url":"https://github.com/projectjellyfish","followers_url":"https://api.github.com/users/projectjellyfish/followers","following_url":"https://api.github.com/users/projectjellyfish/following{/other_user}","gists_url":"https://api.github.com/users/projectjellyfish/gists{/gist_id}","starred_url":"https://api.github.com/users/projectjellyfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectjellyfish/subscriptions","organizations_url":"https://api.github.com/users/projectjellyfish/orgs","repos_url":"https://api.github.com/users/projectjellyfish/repos","events_url":"https://api.github.com/users/projectjellyfish/events{/privacy}","received_events_url":"https://api.github.com/users/projectjellyfish/received_events","type":"Organization","site_admin":false},"repo":{"id":25487089,"name":"api","full_name":"projectjellyfish/api","owner":{"login":"projectjellyfish","id":10867673,"avatar_url":"https://avatars.githubusercontent.com/u/10867673?v=3","gravatar_id":"","url":"https://api.github.com/users/projectjellyfish","html_url":"https://github.com/projectjellyfish","followers_url":"https://api.github.com/users/projectjellyfish/followers","following_url":"https://api.github.com/users/projectjellyfish/following{/other_user}","gists_url":"https://api.github.com/users/projectjellyfish/gists{/gist_id}","starred_url":"https://api.github.com/users/projectjellyfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectjellyfish/subscriptions","organizations_url":"https://api.github.com/users/projectjellyfish/orgs","repos_url":"https://api.github.com/users/projectjellyfish/repos","events_url":"https://api.github.com/users/projectjellyfish/events{/privacy}","received_events_url":"https://api.github.com/users/projectjellyfish/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectjellyfish/api","description":"Project Jellyfish API","fork":false,"url":"https://api.github.com/repos/projectjellyfish/api","forks_url":"https://api.github.com/repos/projectjellyfish/api/forks","keys_url":"https://api.github.com/repos/projectjellyfish/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectjellyfish/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectjellyfish/api/teams","hooks_url":"https://api.github.com/repos/projectjellyfish/api/hooks","issue_events_url":"https://api.github.com/repos/projectjellyfish/api/issues/events{/number}","events_url":"https://api.github.com/repos/projectjellyfish/api/events","assignees_url":"https://api.github.com/repos/projectjellyfish/api/assignees{/user}","branches_url":"https://api.github.com/repos/projectjellyfish/api/branches{/branch}","tags_url":"https://api.github.com/repos/projectjellyfish/api/tags","blobs_url":"https://api.github.com/repos/projectjellyfish/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectjellyfish/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectjellyfish/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectjellyfish/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectjellyfish/api/statuses/{sha}","languages_url":"https://api.github.com/repos/projectjellyfish/api/languages","stargazers_url":"https://api.github.com/repos/projectjellyfish/api/stargazers","contributors_url":"https://api.github.com/repos/projectjellyfish/api/contributors","subscribers_url":"https://api.github.com/repos/projectjellyfish/api/subscribers","subscription_url":"https://api.github.com/repos/projectjellyfish/api/subscription","commits_url":"https://api.github.com/repos/projectjellyfish/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectjellyfish/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectjellyfish/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectjellyfish/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectjellyfish/api/contents/{+path}","compare_url":"https://api.github.com/repos/projectjellyfish/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectjellyfish/api/merges","archive_url":"https://api.github.com/repos/projectjellyfish/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectjellyfish/api/downloads","issues_url":"https://api.github.com/repos/projectjellyfish/api/issues{/number}","pulls_url":"https://api.github.com/repos/projectjellyfish/api/pulls{/number}","milestones_url":"https://api.github.com/repos/projectjellyfish/api/milestones{/number}","notifications_url":"https://api.github.com/repos/projectjellyfish/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectjellyfish/api/labels{/name}","releases_url":"https://api.github.com/repos/projectjellyfish/api/releases{/id}","created_at":"2014-10-20T21:17:09Z","updated_at":"2015-02-20T12:41:44Z","pushed_at":"2015-02-22T21:17:10Z","git_url":"git://github.com/projectjellyfish/api.git","ssh_url":"git@github.com:projectjellyfish/api.git","clone_url":"https://github.com/projectjellyfish/api.git","svn_url":"https://github.com/projectjellyfish/api","homepage":"","size":4632,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":63,"forks":2,"open_issues":63,"watchers":14,"default_branch":"master"}},"base":{"label":"projectjellyfish:master","ref":"master","sha":"18ff845d036d01b0ae49d057193f5b551464c69f","user":{"login":"projectjellyfish","id":10867673,"avatar_url":"https://avatars.githubusercontent.com/u/10867673?v=3","gravatar_id":"","url":"https://api.github.com/users/projectjellyfish","html_url":"https://github.com/projectjellyfish","followers_url":"https://api.github.com/users/projectjellyfish/followers","following_url":"https://api.github.com/users/projectjellyfish/following{/other_user}","gists_url":"https://api.github.com/users/projectjellyfish/gists{/gist_id}","starred_url":"https://api.github.com/users/projectjellyfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectjellyfish/subscriptions","organizations_url":"https://api.github.com/users/projectjellyfish/orgs","repos_url":"https://api.github.com/users/projectjellyfish/repos","events_url":"https://api.github.com/users/projectjellyfish/events{/privacy}","received_events_url":"https://api.github.com/users/projectjellyfish/received_events","type":"Organization","site_admin":false},"repo":{"id":25487089,"name":"api","full_name":"projectjellyfish/api","owner":{"login":"projectjellyfish","id":10867673,"avatar_url":"https://avatars.githubusercontent.com/u/10867673?v=3","gravatar_id":"","url":"https://api.github.com/users/projectjellyfish","html_url":"https://github.com/projectjellyfish","followers_url":"https://api.github.com/users/projectjellyfish/followers","following_url":"https://api.github.com/users/projectjellyfish/following{/other_user}","gists_url":"https://api.github.com/users/projectjellyfish/gists{/gist_id}","starred_url":"https://api.github.com/users/projectjellyfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectjellyfish/subscriptions","organizations_url":"https://api.github.com/users/projectjellyfish/orgs","repos_url":"https://api.github.com/users/projectjellyfish/repos","events_url":"https://api.github.com/users/projectjellyfish/events{/privacy}","received_events_url":"https://api.github.com/users/projectjellyfish/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectjellyfish/api","description":"Project Jellyfish API","fork":false,"url":"https://api.github.com/repos/projectjellyfish/api","forks_url":"https://api.github.com/repos/projectjellyfish/api/forks","keys_url":"https://api.github.com/repos/projectjellyfish/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectjellyfish/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectjellyfish/api/teams","hooks_url":"https://api.github.com/repos/projectjellyfish/api/hooks","issue_events_url":"https://api.github.com/repos/projectjellyfish/api/issues/events{/number}","events_url":"https://api.github.com/repos/projectjellyfish/api/events","assignees_url":"https://api.github.com/repos/projectjellyfish/api/assignees{/user}","branches_url":"https://api.github.com/repos/projectjellyfish/api/branches{/branch}","tags_url":"https://api.github.com/repos/projectjellyfish/api/tags","blobs_url":"https://api.github.com/repos/projectjellyfish/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectjellyfish/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectjellyfish/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectjellyfish/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectjellyfish/api/statuses/{sha}","languages_url":"https://api.github.com/repos/projectjellyfish/api/languages","stargazers_url":"https://api.github.com/repos/projectjellyfish/api/stargazers","contributors_url":"https://api.github.com/repos/projectjellyfish/api/contributors","subscribers_url":"https://api.github.com/repos/projectjellyfish/api/subscribers","subscription_url":"https://api.github.com/repos/projectjellyfish/api/subscription","commits_url":"https://api.github.com/repos/projectjellyfish/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectjellyfish/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectjellyfish/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectjellyfish/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectjellyfish/api/contents/{+path}","compare_url":"https://api.github.com/repos/projectjellyfish/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectjellyfish/api/merges","archive_url":"https://api.github.com/repos/projectjellyfish/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectjellyfish/api/downloads","issues_url":"https://api.github.com/repos/projectjellyfish/api/issues{/number}","pulls_url":"https://api.github.com/repos/projectjellyfish/api/pulls{/number}","milestones_url":"https://api.github.com/repos/projectjellyfish/api/milestones{/number}","notifications_url":"https://api.github.com/repos/projectjellyfish/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectjellyfish/api/labels{/name}","releases_url":"https://api.github.com/repos/projectjellyfish/api/releases{/id}","created_at":"2014-10-20T21:17:09Z","updated_at":"2015-02-20T12:41:44Z","pushed_at":"2015-02-22T21:17:10Z","git_url":"git://github.com/projectjellyfish/api.git","ssh_url":"git@github.com:projectjellyfish/api.git","clone_url":"https://github.com/projectjellyfish/api.git","svn_url":"https://github.com/projectjellyfish/api","homepage":"","size":4632,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":63,"forks":2,"open_issues":63,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectjellyfish/api/pulls/265"},"html":{"href":"https://github.com/projectjellyfish/api/pull/265"},"issue":{"href":"https://api.github.com/repos/projectjellyfish/api/issues/265"},"comments":{"href":"https://api.github.com/repos/projectjellyfish/api/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/projectjellyfish/api/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/projectjellyfish/api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectjellyfish/api/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/projectjellyfish/api/statuses/54133ea47cbcf7b8b120f0c3d66242e617f440ef"}}}}