{"action":"created","comment":{"url":"https://api.github.com/repos/NodeRedis/node_redis/pulls/comments/39356880","id":39356880,"diff_hunk":"@@ -64,9 +64,9 @@ describe(\"The 'multi' method\", function () {\n                     // Provoke an error at queue time\n                     multi1 = client.MULTI();\n                     multi1.mset(\"multifoo\", \"10\", \"multibar\", \"20\", helper.isString(\"OK\"));\n-                    multi1.set(\"foo2\", helper.isError());\n-                    multi1.incr(\"multifoo\", helper.isNumber(11));\n-                    multi1.incr(\"multibar\", helper.isNumber(21));\n+                    multi1.set(\"foo2\");\n+                    multi1.incr(\"multifoo\");\n+                    multi1.incr(\"multibar\");","path":"test/commands/multi.spec.js","position":18,"original_position":18,"commit_id":"bb1ab1498bf7666c2d5bec6c613797018ca113b7","original_commit_id":"224aff9cee64123680732587f906617fcfab8cf2","user":{"login":"bcoe","id":194609,"avatar_url":"https://avatars.githubusercontent.com/u/194609?v=3","gravatar_id":"","url":"https://api.github.com/users/bcoe","html_url":"https://github.com/bcoe","followers_url":"https://api.github.com/users/bcoe/followers","following_url":"https://api.github.com/users/bcoe/following{/other_user}","gists_url":"https://api.github.com/users/bcoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoe/subscriptions","organizations_url":"https://api.github.com/users/bcoe/orgs","repos_url":"https://api.github.com/users/bcoe/repos","events_url":"https://api.github.com/users/bcoe/events{/privacy}","received_events_url":"https://api.github.com/users/bcoe/received_events","type":"User","site_admin":false},"body":"I did some further testing, `multi1.incr(\"multibar\")` doesn't ever invoke a callback -- this test was a noop.\r\n\r\n`multi1.set(\"foo2\")` does result in an error being returned on both old and new redis', so I'm adding this back.\r\n","created_at":"2015-09-14T02:07:55Z","updated_at":"2015-09-14T02:07:55Z","html_url":"https://github.com/NodeRedis/node_redis/pull/837#discussion_r39356880","pull_request_url":"https://api.github.com/repos/NodeRedis/node_redis/pulls/837","_links":{"self":{"href":"https://api.github.com/repos/NodeRedis/node_redis/pulls/comments/39356880"},"html":{"href":"https://github.com/NodeRedis/node_redis/pull/837#discussion_r39356880"},"pull_request":{"href":"https://api.github.com/repos/NodeRedis/node_redis/pulls/837"}}},"pull_request":{"url":"https://api.github.com/repos/NodeRedis/node_redis/pulls/837","id":44867800,"html_url":"https://github.com/NodeRedis/node_redis/pull/837","diff_url":"https://github.com/NodeRedis/node_redis/pull/837.diff","patch_url":"https://github.com/NodeRedis/node_redis/pull/837.patch","issue_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/837","number":837,"state":"open","locked":false,"title":"retrofit tests so that they work on Windows","user":{"login":"bcoe","id":194609,"avatar_url":"https://avatars.githubusercontent.com/u/194609?v=3","gravatar_id":"","url":"https://api.github.com/users/bcoe","html_url":"https://github.com/bcoe","followers_url":"https://api.github.com/users/bcoe/followers","following_url":"https://api.github.com/users/bcoe/following{/other_user}","gists_url":"https://api.github.com/users/bcoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoe/subscriptions","organizations_url":"https://api.github.com/users/bcoe/orgs","repos_url":"https://api.github.com/users/bcoe/repos","events_url":"https://api.github.com/users/bcoe/events{/privacy}","received_events_url":"https://api.github.com/users/bcoe/received_events","type":"User","site_admin":false},"body":"* added appveyor configuration (a Windows CI server).\r\n* hiredis is now installed as an optional dev dependency (since Windows machines have trouble building it with node-gyp).\r\n* auth-spec is now skipped if we fail to spawn a Redis (in our Windows CI we assume a Redis is provisioned by the CI environment, not that we can spawn it using a `redis` bin).\r\n* Windows tests run on an older Redis, I fixed up some of the tests that were conditional based on which Redis version was being used.\r\n* found a single test that behaves weirdly on Windows, and added a  TODO (relates to an error being returned even though the operation should simply be enqueued).","created_at":"2015-09-13T06:22:43Z","updated_at":"2015-09-14T02:07:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9017f4b46e766a94586c929ac4aa0111b4b03512","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NodeRedis/node_redis/pulls/837/commits","review_comments_url":"https://api.github.com/repos/NodeRedis/node_redis/pulls/837/comments","review_comment_url":"https://api.github.com/repos/NodeRedis/node_redis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/837/comments","statuses_url":"https://api.github.com/repos/NodeRedis/node_redis/statuses/bb1ab1498bf7666c2d5bec6c613797018ca113b7","head":{"label":"NodeRedis:windows-tests","ref":"windows-tests","sha":"bb1ab1498bf7666c2d5bec6c613797018ca113b7","user":{"login":"NodeRedis","id":5845577,"avatar_url":"https://avatars.githubusercontent.com/u/5845577?v=3","gravatar_id":"","url":"https://api.github.com/users/NodeRedis","html_url":"https://github.com/NodeRedis","followers_url":"https://api.github.com/users/NodeRedis/followers","following_url":"https://api.github.com/users/NodeRedis/following{/other_user}","gists_url":"https://api.github.com/users/NodeRedis/gists{/gist_id}","starred_url":"https://api.github.com/users/NodeRedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NodeRedis/subscriptions","organizations_url":"https://api.github.com/users/NodeRedis/orgs","repos_url":"https://api.github.com/users/NodeRedis/repos","events_url":"https://api.github.com/users/NodeRedis/events{/privacy}","received_events_url":"https://api.github.com/users/NodeRedis/received_events","type":"Organization","site_admin":false},"repo":{"id":908893,"name":"node_redis","full_name":"NodeRedis/node_redis","owner":{"login":"NodeRedis","id":5845577,"avatar_url":"https://avatars.githubusercontent.com/u/5845577?v=3","gravatar_id":"","url":"https://api.github.com/users/NodeRedis","html_url":"https://github.com/NodeRedis","followers_url":"https://api.github.com/users/NodeRedis/followers","following_url":"https://api.github.com/users/NodeRedis/following{/other_user}","gists_url":"https://api.github.com/users/NodeRedis/gists{/gist_id}","starred_url":"https://api.github.com/users/NodeRedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NodeRedis/subscriptions","organizations_url":"https://api.github.com/users/NodeRedis/orgs","repos_url":"https://api.github.com/users/NodeRedis/repos","events_url":"https://api.github.com/users/NodeRedis/events{/privacy}","received_events_url":"https://api.github.com/users/NodeRedis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NodeRedis/node_redis","description":"redis client for node","fork":false,"url":"https://api.github.com/repos/NodeRedis/node_redis","forks_url":"https://api.github.com/repos/NodeRedis/node_redis/forks","keys_url":"https://api.github.com/repos/NodeRedis/node_redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NodeRedis/node_redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NodeRedis/node_redis/teams","hooks_url":"https://api.github.com/repos/NodeRedis/node_redis/hooks","issue_events_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/events{/number}","events_url":"https://api.github.com/repos/NodeRedis/node_redis/events","assignees_url":"https://api.github.com/repos/NodeRedis/node_redis/assignees{/user}","branches_url":"https://api.github.com/repos/NodeRedis/node_redis/branches{/branch}","tags_url":"https://api.github.com/repos/NodeRedis/node_redis/tags","blobs_url":"https://api.github.com/repos/NodeRedis/node_redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NodeRedis/node_redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NodeRedis/node_redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/NodeRedis/node_redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NodeRedis/node_redis/statuses/{sha}","languages_url":"https://api.github.com/repos/NodeRedis/node_redis/languages","stargazers_url":"https://api.github.com/repos/NodeRedis/node_redis/stargazers","contributors_url":"https://api.github.com/repos/NodeRedis/node_redis/contributors","subscribers_url":"https://api.github.com/repos/NodeRedis/node_redis/subscribers","subscription_url":"https://api.github.com/repos/NodeRedis/node_redis/subscription","commits_url":"https://api.github.com/repos/NodeRedis/node_redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/NodeRedis/node_redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/NodeRedis/node_redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/comments{/number}","contents_url":"https://api.github.com/repos/NodeRedis/node_redis/contents/{+path}","compare_url":"https://api.github.com/repos/NodeRedis/node_redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NodeRedis/node_redis/merges","archive_url":"https://api.github.com/repos/NodeRedis/node_redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NodeRedis/node_redis/downloads","issues_url":"https://api.github.com/repos/NodeRedis/node_redis/issues{/number}","pulls_url":"https://api.github.com/repos/NodeRedis/node_redis/pulls{/number}","milestones_url":"https://api.github.com/repos/NodeRedis/node_redis/milestones{/number}","notifications_url":"https://api.github.com/repos/NodeRedis/node_redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NodeRedis/node_redis/labels{/name}","releases_url":"https://api.github.com/repos/NodeRedis/node_redis/releases{/id}","created_at":"2010-09-14T02:05:09Z","updated_at":"2015-09-13T20:50:10Z","pushed_at":"2015-09-13T17:02:37Z","git_url":"git://github.com/NodeRedis/node_redis.git","ssh_url":"git@github.com:NodeRedis/node_redis.git","clone_url":"https://github.com/NodeRedis/node_redis.git","svn_url":"https://github.com/NodeRedis/node_redis","homepage":"http://redis.js.org/","size":3823,"stargazers_count":5047,"watchers_count":5047,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":722,"mirror_url":null,"open_issues_count":87,"forks":722,"open_issues":87,"watchers":5047,"default_branch":"master"}},"base":{"label":"NodeRedis:master","ref":"master","sha":"06121a65c476a16e18e59b139319f07dc91bcdad","user":{"login":"NodeRedis","id":5845577,"avatar_url":"https://avatars.githubusercontent.com/u/5845577?v=3","gravatar_id":"","url":"https://api.github.com/users/NodeRedis","html_url":"https://github.com/NodeRedis","followers_url":"https://api.github.com/users/NodeRedis/followers","following_url":"https://api.github.com/users/NodeRedis/following{/other_user}","gists_url":"https://api.github.com/users/NodeRedis/gists{/gist_id}","starred_url":"https://api.github.com/users/NodeRedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NodeRedis/subscriptions","organizations_url":"https://api.github.com/users/NodeRedis/orgs","repos_url":"https://api.github.com/users/NodeRedis/repos","events_url":"https://api.github.com/users/NodeRedis/events{/privacy}","received_events_url":"https://api.github.com/users/NodeRedis/received_events","type":"Organization","site_admin":false},"repo":{"id":908893,"name":"node_redis","full_name":"NodeRedis/node_redis","owner":{"login":"NodeRedis","id":5845577,"avatar_url":"https://avatars.githubusercontent.com/u/5845577?v=3","gravatar_id":"","url":"https://api.github.com/users/NodeRedis","html_url":"https://github.com/NodeRedis","followers_url":"https://api.github.com/users/NodeRedis/followers","following_url":"https://api.github.com/users/NodeRedis/following{/other_user}","gists_url":"https://api.github.com/users/NodeRedis/gists{/gist_id}","starred_url":"https://api.github.com/users/NodeRedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NodeRedis/subscriptions","organizations_url":"https://api.github.com/users/NodeRedis/orgs","repos_url":"https://api.github.com/users/NodeRedis/repos","events_url":"https://api.github.com/users/NodeRedis/events{/privacy}","received_events_url":"https://api.github.com/users/NodeRedis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NodeRedis/node_redis","description":"redis client for node","fork":false,"url":"https://api.github.com/repos/NodeRedis/node_redis","forks_url":"https://api.github.com/repos/NodeRedis/node_redis/forks","keys_url":"https://api.github.com/repos/NodeRedis/node_redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NodeRedis/node_redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NodeRedis/node_redis/teams","hooks_url":"https://api.github.com/repos/NodeRedis/node_redis/hooks","issue_events_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/events{/number}","events_url":"https://api.github.com/repos/NodeRedis/node_redis/events","assignees_url":"https://api.github.com/repos/NodeRedis/node_redis/assignees{/user}","branches_url":"https://api.github.com/repos/NodeRedis/node_redis/branches{/branch}","tags_url":"https://api.github.com/repos/NodeRedis/node_redis/tags","blobs_url":"https://api.github.com/repos/NodeRedis/node_redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NodeRedis/node_redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NodeRedis/node_redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/NodeRedis/node_redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NodeRedis/node_redis/statuses/{sha}","languages_url":"https://api.github.com/repos/NodeRedis/node_redis/languages","stargazers_url":"https://api.github.com/repos/NodeRedis/node_redis/stargazers","contributors_url":"https://api.github.com/repos/NodeRedis/node_redis/contributors","subscribers_url":"https://api.github.com/repos/NodeRedis/node_redis/subscribers","subscription_url":"https://api.github.com/repos/NodeRedis/node_redis/subscription","commits_url":"https://api.github.com/repos/NodeRedis/node_redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/NodeRedis/node_redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/NodeRedis/node_redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/comments{/number}","contents_url":"https://api.github.com/repos/NodeRedis/node_redis/contents/{+path}","compare_url":"https://api.github.com/repos/NodeRedis/node_redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NodeRedis/node_redis/merges","archive_url":"https://api.github.com/repos/NodeRedis/node_redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NodeRedis/node_redis/downloads","issues_url":"https://api.github.com/repos/NodeRedis/node_redis/issues{/number}","pulls_url":"https://api.github.com/repos/NodeRedis/node_redis/pulls{/number}","milestones_url":"https://api.github.com/repos/NodeRedis/node_redis/milestones{/number}","notifications_url":"https://api.github.com/repos/NodeRedis/node_redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NodeRedis/node_redis/labels{/name}","releases_url":"https://api.github.com/repos/NodeRedis/node_redis/releases{/id}","created_at":"2010-09-14T02:05:09Z","updated_at":"2015-09-13T20:50:10Z","pushed_at":"2015-09-13T17:02:37Z","git_url":"git://github.com/NodeRedis/node_redis.git","ssh_url":"git@github.com:NodeRedis/node_redis.git","clone_url":"https://github.com/NodeRedis/node_redis.git","svn_url":"https://github.com/NodeRedis/node_redis","homepage":"http://redis.js.org/","size":3823,"stargazers_count":5047,"watchers_count":5047,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":722,"mirror_url":null,"open_issues_count":87,"forks":722,"open_issues":87,"watchers":5047,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NodeRedis/node_redis/pulls/837"},"html":{"href":"https://github.com/NodeRedis/node_redis/pull/837"},"issue":{"href":"https://api.github.com/repos/NodeRedis/node_redis/issues/837"},"comments":{"href":"https://api.github.com/repos/NodeRedis/node_redis/issues/837/comments"},"review_comments":{"href":"https://api.github.com/repos/NodeRedis/node_redis/pulls/837/comments"},"review_comment":{"href":"https://api.github.com/repos/NodeRedis/node_redis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NodeRedis/node_redis/pulls/837/commits"},"statuses":{"href":"https://api.github.com/repos/NodeRedis/node_redis/statuses/bb1ab1498bf7666c2d5bec6c613797018ca113b7"}}}}