{"action":"created","issue":{"url":"https://api.github.com/repos/emberjs/ember.js/issues/12370","labels_url":"https://api.github.com/repos/emberjs/ember.js/issues/12370/labels{/name}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/12370/comments","events_url":"https://api.github.com/repos/emberjs/ember.js/issues/12370/events","html_url":"https://github.com/emberjs/ember.js/pull/12370","id":107295044,"number":12370,"title":"[BUGFIX release] Deprecate passing function as test argument to deprecate/warn/assert","user":{"login":"Kuzirashi","id":4950658,"avatar_url":"https://avatars.githubusercontent.com/u/4950658?v=3","gravatar_id":"","url":"https://api.github.com/users/Kuzirashi","html_url":"https://github.com/Kuzirashi","followers_url":"https://api.github.com/users/Kuzirashi/followers","following_url":"https://api.github.com/users/Kuzirashi/following{/other_user}","gists_url":"https://api.github.com/users/Kuzirashi/gists{/gist_id}","starred_url":"https://api.github.com/users/Kuzirashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kuzirashi/subscriptions","organizations_url":"https://api.github.com/users/Kuzirashi/orgs","repos_url":"https://api.github.com/users/Kuzirashi/repos","events_url":"https://api.github.com/users/Kuzirashi/events{/privacy}","received_events_url":"https://api.github.com/users/Kuzirashi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-09-18T23:32:41Z","updated_at":"2015-09-29T15:38:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/12370","html_url":"https://github.com/emberjs/ember.js/pull/12370","diff_url":"https://github.com/emberjs/ember.js/pull/12370.diff","patch_url":"https://github.com/emberjs/ember.js/pull/12370.patch"},"body":"This PR attempts to deprecate using function as test argument in: `Ember.deprecate`, `Ember.warn` and `Ember.assert`. It's first part of closing issue #11898. Tests for `ember-debug` pass, but I still have to fix other tests and code, which trigger deprecation with function as test argument. Seems like this behavior is used in many places in application lifecycle. It's my first attempt to commit actual code to Ember.js so I appreciate any help.\r\n\r\n@mmun, @rwjblue "},"comment":{"url":"https://api.github.com/repos/emberjs/ember.js/issues/comments/144097012","html_url":"https://github.com/emberjs/ember.js/pull/12370#issuecomment-144097012","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/12370","id":144097012,"user":{"login":"Kuzirashi","id":4950658,"avatar_url":"https://avatars.githubusercontent.com/u/4950658?v=3","gravatar_id":"","url":"https://api.github.com/users/Kuzirashi","html_url":"https://github.com/Kuzirashi","followers_url":"https://api.github.com/users/Kuzirashi/followers","following_url":"https://api.github.com/users/Kuzirashi/following{/other_user}","gists_url":"https://api.github.com/users/Kuzirashi/gists{/gist_id}","starred_url":"https://api.github.com/users/Kuzirashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kuzirashi/subscriptions","organizations_url":"https://api.github.com/users/Kuzirashi/orgs","repos_url":"https://api.github.com/users/Kuzirashi/repos","events_url":"https://api.github.com/users/Kuzirashi/events{/privacy}","received_events_url":"https://api.github.com/users/Kuzirashi/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T15:38:12Z","updated_at":"2015-09-29T15:38:12Z","body":"I'll find the time. I'll mention you when it's all ready. Thanks for review. ;)"}}