{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/28160523","id":28160523,"diff_hunk":"@@ -631,6 +634,21 @@ func printResourceQuotaList(list *api.ResourceQuotaList, w io.Writer) error {\n \treturn nil\n }\n \n+func printServerStatus(item *api.ServerStatus, w io.Writer) error {\n+\t_, err := fmt.Fprintf(w, \"%s\\t%s\\t%d\\t%s\\t%s\\n\", item.Component, item.Health, item.HealthCode, item.Msg, item.Err)\n+\treturn err\n+}\n+\n+func printServerStatusList(list *api.ServerStatusList, w io.Writer) error {\n+\tfor _, item := range list.Items {\n+\t\tif err := printServerStatus(&item, w); err != nil {","path":"pkg/kubectl/resource_printer.go","position":28,"original_position":28,"commit_id":"f410b6010e775eab0560cbaf054e57419f6800ba","original_commit_id":"f410b6010e775eab0560cbaf054e57419f6800ba","user":{"login":"fabioy","id":6294975,"avatar_url":"https://avatars.githubusercontent.com/u/6294975?v=3","gravatar_id":"","url":"https://api.github.com/users/fabioy","html_url":"https://github.com/fabioy","followers_url":"https://api.github.com/users/fabioy/followers","following_url":"https://api.github.com/users/fabioy/following{/other_user}","gists_url":"https://api.github.com/users/fabioy/gists{/gist_id}","starred_url":"https://api.github.com/users/fabioy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabioy/subscriptions","organizations_url":"https://api.github.com/users/fabioy/orgs","repos_url":"https://api.github.com/users/fabioy/repos","events_url":"https://api.github.com/users/fabioy/events{/privacy}","received_events_url":"https://api.github.com/users/fabioy/received_events","type":"User","site_admin":false},"body":"This was the pattern for the other resource printers, which I followed. Also, an error in the \"printServerStatus\" call would generally mean that there was an error in Fprintf, which means the data returned didn't quite match the expected types. Continuing to attempt to print the other lines seems...redundant (the given line probably wasn't printed as well).\r\n\r\nA final argument against doing this is that the user may be able to get at the data by requesting an output of YAML or JSON.","created_at":"2015-04-10T16:46:57Z","updated_at":"2015-04-10T16:46:57Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6597#discussion_r28160523","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6597","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/28160523"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6597#discussion_r28160523"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6597"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6597","id":32906541,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6597","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6597.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6597.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6597","number":6597,"state":"open","locked":false,"title":"Add \"kubectl validate\" command to do a cluster health check.","user":{"login":"fabioy","id":6294975,"avatar_url":"https://avatars.githubusercontent.com/u/6294975?v=3","gravatar_id":"","url":"https://api.github.com/users/fabioy","html_url":"https://github.com/fabioy","followers_url":"https://api.github.com/users/fabioy/followers","following_url":"https://api.github.com/users/fabioy/following{/other_user}","gists_url":"https://api.github.com/users/fabioy/gists{/gist_id}","starred_url":"https://api.github.com/users/fabioy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabioy/subscriptions","organizations_url":"https://api.github.com/users/fabioy/orgs","repos_url":"https://api.github.com/users/fabioy/repos","events_url":"https://api.github.com/users/fabioy/events{/privacy}","received_events_url":"https://api.github.com/users/fabioy/received_events","type":"User","site_admin":false},"body":"This is the first step to resolving issue #5946.","created_at":"2015-04-08T21:59:21Z","updated_at":"2015-04-10T16:46:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a4dbd26c080d85916c8674311299948ec7fbca7","assignee":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6597/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6597/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6597/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/f410b6010e775eab0560cbaf054e57419f6800ba","head":{"label":"fabioy:kubectl-validate","ref":"kubectl-validate","sha":"f410b6010e775eab0560cbaf054e57419f6800ba","user":{"login":"fabioy","id":6294975,"avatar_url":"https://avatars.githubusercontent.com/u/6294975?v=3","gravatar_id":"","url":"https://api.github.com/users/fabioy","html_url":"https://github.com/fabioy","followers_url":"https://api.github.com/users/fabioy/followers","following_url":"https://api.github.com/users/fabioy/following{/other_user}","gists_url":"https://api.github.com/users/fabioy/gists{/gist_id}","starred_url":"https://api.github.com/users/fabioy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabioy/subscriptions","organizations_url":"https://api.github.com/users/fabioy/orgs","repos_url":"https://api.github.com/users/fabioy/repos","events_url":"https://api.github.com/users/fabioy/events{/privacy}","received_events_url":"https://api.github.com/users/fabioy/received_events","type":"User","site_admin":false},"repo":{"id":30671784,"name":"kubernetes","full_name":"fabioy/kubernetes","owner":{"login":"fabioy","id":6294975,"avatar_url":"https://avatars.githubusercontent.com/u/6294975?v=3","gravatar_id":"","url":"https://api.github.com/users/fabioy","html_url":"https://github.com/fabioy","followers_url":"https://api.github.com/users/fabioy/followers","following_url":"https://api.github.com/users/fabioy/following{/other_user}","gists_url":"https://api.github.com/users/fabioy/gists{/gist_id}","starred_url":"https://api.github.com/users/fabioy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabioy/subscriptions","organizations_url":"https://api.github.com/users/fabioy/orgs","repos_url":"https://api.github.com/users/fabioy/repos","events_url":"https://api.github.com/users/fabioy/events{/privacy}","received_events_url":"https://api.github.com/users/fabioy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabioy/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/fabioy/kubernetes","forks_url":"https://api.github.com/repos/fabioy/kubernetes/forks","keys_url":"https://api.github.com/repos/fabioy/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabioy/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabioy/kubernetes/teams","hooks_url":"https://api.github.com/repos/fabioy/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/fabioy/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/fabioy/kubernetes/events","assignees_url":"https://api.github.com/repos/fabioy/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/fabioy/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/fabioy/kubernetes/tags","blobs_url":"https://api.github.com/repos/fabioy/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabioy/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabioy/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabioy/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabioy/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/fabioy/kubernetes/languages","stargazers_url":"https://api.github.com/repos/fabioy/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/fabioy/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/fabioy/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/fabioy/kubernetes/subscription","commits_url":"https://api.github.com/repos/fabioy/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabioy/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabioy/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabioy/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabioy/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/fabioy/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabioy/kubernetes/merges","archive_url":"https://api.github.com/repos/fabioy/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabioy/kubernetes/downloads","issues_url":"https://api.github.com/repos/fabioy/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/fabioy/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/fabioy/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/fabioy/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabioy/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/fabioy/kubernetes/releases{/id}","created_at":"2015-02-11T21:55:17Z","updated_at":"2015-04-09T17:15:19Z","pushed_at":"2015-04-10T00:22:25Z","git_url":"git://github.com/fabioy/kubernetes.git","ssh_url":"git@github.com:fabioy/kubernetes.git","clone_url":"https://github.com/fabioy/kubernetes.git","svn_url":"https://github.com/fabioy/kubernetes","homepage":"http://kubernetes.io","size":42339,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"094cbcc6fe8bd26fdd2a07701a6ea6f594b1956e","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-04-10T16:34:54Z","pushed_at":"2015-04-10T16:46:49Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":143870,"stargazers_count":7036,"watchers_count":7036,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1373,"mirror_url":null,"open_issues_count":876,"forks":1373,"open_issues":876,"watchers":7036,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6597"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6597"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6597"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6597/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6597/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6597/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/f410b6010e775eab0560cbaf054e57419f6800ba"}}}}