{"action":"opened","number":1560,"pull_request":{"url":"https://api.github.com/repos/inliniac/suricata/pulls/1560","id":37986995,"html_url":"https://github.com/inliniac/suricata/pull/1560","diff_url":"https://github.com/inliniac/suricata/pull/1560.diff","patch_url":"https://github.com/inliniac/suricata/pull/1560.patch","issue_url":"https://api.github.com/repos/inliniac/suricata/issues/1560","number":1560,"state":"open","locked":false,"title":"stream_size operator comparison (fix issue #1488)","user":{"login":"Zopieux","id":81353,"avatar_url":"https://avatars.githubusercontent.com/u/81353?v=3","gravatar_id":"","url":"https://api.github.com/users/Zopieux","html_url":"https://github.com/Zopieux","followers_url":"https://api.github.com/users/Zopieux/followers","following_url":"https://api.github.com/users/Zopieux/following{/other_user}","gists_url":"https://api.github.com/users/Zopieux/gists{/gist_id}","starred_url":"https://api.github.com/users/Zopieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zopieux/subscriptions","organizations_url":"https://api.github.com/users/Zopieux/orgs","repos_url":"https://api.github.com/users/Zopieux/repos","events_url":"https://api.github.com/users/Zopieux/events{/privacy}","received_events_url":"https://api.github.com/users/Zopieux/received_events","type":"User","site_admin":false},"body":"Funny bug.\r\n\r\n`DetectStreamSizeParse` was first checking if `mode[0] == '<'`, which is true for both `<` and `<=`, thus `<=` (resp. `>=`) is never matched. This patch does the `strcmp` to `<=` (resp. `>=`) within the if block of `<` (resp. `>`) to fix [#1488](https://redmine.openinfosecfoundation.org/issues/1488).","created_at":"2015-06-18T09:29:02Z","updated_at":"2015-06-18T09:29:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inliniac/suricata/pulls/1560/commits","review_comments_url":"https://api.github.com/repos/inliniac/suricata/pulls/1560/comments","review_comment_url":"https://api.github.com/repos/inliniac/suricata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inliniac/suricata/issues/1560/comments","statuses_url":"https://api.github.com/repos/inliniac/suricata/statuses/fbf418ce9d6acd2299117421a6ebb6e44bb99a2e","head":{"label":"Zopieux:patch-1","ref":"patch-1","sha":"fbf418ce9d6acd2299117421a6ebb6e44bb99a2e","user":{"login":"Zopieux","id":81353,"avatar_url":"https://avatars.githubusercontent.com/u/81353?v=3","gravatar_id":"","url":"https://api.github.com/users/Zopieux","html_url":"https://github.com/Zopieux","followers_url":"https://api.github.com/users/Zopieux/followers","following_url":"https://api.github.com/users/Zopieux/following{/other_user}","gists_url":"https://api.github.com/users/Zopieux/gists{/gist_id}","starred_url":"https://api.github.com/users/Zopieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zopieux/subscriptions","organizations_url":"https://api.github.com/users/Zopieux/orgs","repos_url":"https://api.github.com/users/Zopieux/repos","events_url":"https://api.github.com/users/Zopieux/events{/privacy}","received_events_url":"https://api.github.com/users/Zopieux/received_events","type":"User","site_admin":false},"repo":{"id":37649930,"name":"suricata","full_name":"Zopieux/suricata","owner":{"login":"Zopieux","id":81353,"avatar_url":"https://avatars.githubusercontent.com/u/81353?v=3","gravatar_id":"","url":"https://api.github.com/users/Zopieux","html_url":"https://github.com/Zopieux","followers_url":"https://api.github.com/users/Zopieux/followers","following_url":"https://api.github.com/users/Zopieux/following{/other_user}","gists_url":"https://api.github.com/users/Zopieux/gists{/gist_id}","starred_url":"https://api.github.com/users/Zopieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zopieux/subscriptions","organizations_url":"https://api.github.com/users/Zopieux/orgs","repos_url":"https://api.github.com/users/Zopieux/repos","events_url":"https://api.github.com/users/Zopieux/events{/privacy}","received_events_url":"https://api.github.com/users/Zopieux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zopieux/suricata","description":"Mirror of the official OISF Suricata git repository","fork":true,"url":"https://api.github.com/repos/Zopieux/suricata","forks_url":"https://api.github.com/repos/Zopieux/suricata/forks","keys_url":"https://api.github.com/repos/Zopieux/suricata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zopieux/suricata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zopieux/suricata/teams","hooks_url":"https://api.github.com/repos/Zopieux/suricata/hooks","issue_events_url":"https://api.github.com/repos/Zopieux/suricata/issues/events{/number}","events_url":"https://api.github.com/repos/Zopieux/suricata/events","assignees_url":"https://api.github.com/repos/Zopieux/suricata/assignees{/user}","branches_url":"https://api.github.com/repos/Zopieux/suricata/branches{/branch}","tags_url":"https://api.github.com/repos/Zopieux/suricata/tags","blobs_url":"https://api.github.com/repos/Zopieux/suricata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zopieux/suricata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zopieux/suricata/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zopieux/suricata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zopieux/suricata/statuses/{sha}","languages_url":"https://api.github.com/repos/Zopieux/suricata/languages","stargazers_url":"https://api.github.com/repos/Zopieux/suricata/stargazers","contributors_url":"https://api.github.com/repos/Zopieux/suricata/contributors","subscribers_url":"https://api.github.com/repos/Zopieux/suricata/subscribers","subscription_url":"https://api.github.com/repos/Zopieux/suricata/subscription","commits_url":"https://api.github.com/repos/Zopieux/suricata/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zopieux/suricata/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zopieux/suricata/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zopieux/suricata/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zopieux/suricata/contents/{+path}","compare_url":"https://api.github.com/repos/Zopieux/suricata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zopieux/suricata/merges","archive_url":"https://api.github.com/repos/Zopieux/suricata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zopieux/suricata/downloads","issues_url":"https://api.github.com/repos/Zopieux/suricata/issues{/number}","pulls_url":"https://api.github.com/repos/Zopieux/suricata/pulls{/number}","milestones_url":"https://api.github.com/repos/Zopieux/suricata/milestones{/number}","notifications_url":"https://api.github.com/repos/Zopieux/suricata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zopieux/suricata/labels{/name}","releases_url":"https://api.github.com/repos/Zopieux/suricata/releases{/id}","created_at":"2015-06-18T09:20:21Z","updated_at":"2015-06-18T09:20:27Z","pushed_at":"2015-06-18T09:26:53Z","git_url":"git://github.com/Zopieux/suricata.git","ssh_url":"git@github.com:Zopieux/suricata.git","clone_url":"https://github.com/Zopieux/suricata.git","svn_url":"https://github.com/Zopieux/suricata","homepage":"http://suricata-ids.org/","size":61961,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inliniac:master","ref":"master","sha":"80615f7d43f500b6ca64324dcfd0b43cecea164f","user":{"login":"inliniac","id":719366,"avatar_url":"https://avatars.githubusercontent.com/u/719366?v=3","gravatar_id":"","url":"https://api.github.com/users/inliniac","html_url":"https://github.com/inliniac","followers_url":"https://api.github.com/users/inliniac/followers","following_url":"https://api.github.com/users/inliniac/following{/other_user}","gists_url":"https://api.github.com/users/inliniac/gists{/gist_id}","starred_url":"https://api.github.com/users/inliniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inliniac/subscriptions","organizations_url":"https://api.github.com/users/inliniac/orgs","repos_url":"https://api.github.com/users/inliniac/repos","events_url":"https://api.github.com/users/inliniac/events{/privacy}","received_events_url":"https://api.github.com/users/inliniac/received_events","type":"User","site_admin":false},"repo":{"id":5410234,"name":"suricata","full_name":"inliniac/suricata","owner":{"login":"inliniac","id":719366,"avatar_url":"https://avatars.githubusercontent.com/u/719366?v=3","gravatar_id":"","url":"https://api.github.com/users/inliniac","html_url":"https://github.com/inliniac","followers_url":"https://api.github.com/users/inliniac/followers","following_url":"https://api.github.com/users/inliniac/following{/other_user}","gists_url":"https://api.github.com/users/inliniac/gists{/gist_id}","starred_url":"https://api.github.com/users/inliniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inliniac/subscriptions","organizations_url":"https://api.github.com/users/inliniac/orgs","repos_url":"https://api.github.com/users/inliniac/repos","events_url":"https://api.github.com/users/inliniac/events{/privacy}","received_events_url":"https://api.github.com/users/inliniac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inliniac/suricata","description":"Mirror of the official OISF Suricata git repository","fork":false,"url":"https://api.github.com/repos/inliniac/suricata","forks_url":"https://api.github.com/repos/inliniac/suricata/forks","keys_url":"https://api.github.com/repos/inliniac/suricata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inliniac/suricata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inliniac/suricata/teams","hooks_url":"https://api.github.com/repos/inliniac/suricata/hooks","issue_events_url":"https://api.github.com/repos/inliniac/suricata/issues/events{/number}","events_url":"https://api.github.com/repos/inliniac/suricata/events","assignees_url":"https://api.github.com/repos/inliniac/suricata/assignees{/user}","branches_url":"https://api.github.com/repos/inliniac/suricata/branches{/branch}","tags_url":"https://api.github.com/repos/inliniac/suricata/tags","blobs_url":"https://api.github.com/repos/inliniac/suricata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inliniac/suricata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inliniac/suricata/git/refs{/sha}","trees_url":"https://api.github.com/repos/inliniac/suricata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inliniac/suricata/statuses/{sha}","languages_url":"https://api.github.com/repos/inliniac/suricata/languages","stargazers_url":"https://api.github.com/repos/inliniac/suricata/stargazers","contributors_url":"https://api.github.com/repos/inliniac/suricata/contributors","subscribers_url":"https://api.github.com/repos/inliniac/suricata/subscribers","subscription_url":"https://api.github.com/repos/inliniac/suricata/subscription","commits_url":"https://api.github.com/repos/inliniac/suricata/commits{/sha}","git_commits_url":"https://api.github.com/repos/inliniac/suricata/git/commits{/sha}","comments_url":"https://api.github.com/repos/inliniac/suricata/comments{/number}","issue_comment_url":"https://api.github.com/repos/inliniac/suricata/issues/comments{/number}","contents_url":"https://api.github.com/repos/inliniac/suricata/contents/{+path}","compare_url":"https://api.github.com/repos/inliniac/suricata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inliniac/suricata/merges","archive_url":"https://api.github.com/repos/inliniac/suricata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inliniac/suricata/downloads","issues_url":"https://api.github.com/repos/inliniac/suricata/issues{/number}","pulls_url":"https://api.github.com/repos/inliniac/suricata/pulls{/number}","milestones_url":"https://api.github.com/repos/inliniac/suricata/milestones{/number}","notifications_url":"https://api.github.com/repos/inliniac/suricata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inliniac/suricata/labels{/name}","releases_url":"https://api.github.com/repos/inliniac/suricata/releases{/id}","created_at":"2012-08-14T08:30:06Z","updated_at":"2015-06-16T18:45:50Z","pushed_at":"2015-06-18T09:29:03Z","git_url":"git://github.com/inliniac/suricata.git","ssh_url":"git@github.com:inliniac/suricata.git","clone_url":"https://github.com/inliniac/suricata.git","svn_url":"https://github.com/inliniac/suricata","homepage":"http://suricata-ids.org/","size":61961,"stargazers_count":180,"watchers_count":180,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":29,"forks":168,"open_issues":29,"watchers":180,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/1560"},"html":{"href":"https://github.com/inliniac/suricata/pull/1560"},"issue":{"href":"https://api.github.com/repos/inliniac/suricata/issues/1560"},"comments":{"href":"https://api.github.com/repos/inliniac/suricata/issues/1560/comments"},"review_comments":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/1560/comments"},"review_comment":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/1560/commits"},"statuses":{"href":"https://api.github.com/repos/inliniac/suricata/statuses/fbf418ce9d6acd2299117421a6ebb6e44bb99a2e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":10,"changed_files":1}}