{"action":"created","comment":{"url":"https://api.github.com/repos/pika/pika/pulls/comments/31994719","id":31994719,"diff_hunk":"@@ -476,13 +469,13 @@ def test(self):\n         self.assertIsInstance(method, pika.spec.Basic.GetOk)\n         self.assertEqual(method.delivery_tag, 1)\n         self.assertFalse(method.redelivered)\n-        self.assertEqual(method.exchange, _p3_as_bytes(''))\n-        self.assertEqual(method.routing_key, q_name)\n+        self.assertEqual(method.exchange, as_bytes(''))\n+        self.assertEqual(method.routing_key, as_bytes(q_name))","path":"tests/acceptance/blocking_adapter_test.py","position":74,"original_position":74,"commit_id":"ad485b7cee34f733ab82b6781b519ed555eb7b6a","original_commit_id":"ad485b7cee34f733ab82b6781b519ed555eb7b6a","user":{"login":"everilae","id":531665,"avatar_url":"https://avatars.githubusercontent.com/u/531665?v=3","gravatar_id":"","url":"https://api.github.com/users/everilae","html_url":"https://github.com/everilae","followers_url":"https://api.github.com/users/everilae/followers","following_url":"https://api.github.com/users/everilae/following{/other_user}","gists_url":"https://api.github.com/users/everilae/gists{/gist_id}","starred_url":"https://api.github.com/users/everilae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everilae/subscriptions","organizations_url":"https://api.github.com/users/everilae/orgs","repos_url":"https://api.github.com/users/everilae/repos","events_url":"https://api.github.com/users/everilae/events{/privacy}","received_events_url":"https://api.github.com/users/everilae/received_events","type":"User","site_admin":false},"body":"Yeah, forgot those callbacks receiving ``method``. That's a bit evil, I agree.\r\n\r\nStrings are certainly not \"UTF-8\" in python3. They are unicode codepoints. The internal encoding varies on string to string basis and cannot be relied upon / used in any meaningful manner.\r\n\r\n\"Strings\" in python2 are byte data with unknown encoding. Usually it's ASCII.","created_at":"2015-06-09T09:05:54Z","updated_at":"2015-06-09T09:05:54Z","html_url":"https://github.com/pika/pika/pull/598#discussion_r31994719","pull_request_url":"https://api.github.com/repos/pika/pika/pulls/598","_links":{"self":{"href":"https://api.github.com/repos/pika/pika/pulls/comments/31994719"},"html":{"href":"https://github.com/pika/pika/pull/598#discussion_r31994719"},"pull_request":{"href":"https://api.github.com/repos/pika/pika/pulls/598"}}},"pull_request":{"url":"https://api.github.com/repos/pika/pika/pulls/598","id":37228337,"html_url":"https://github.com/pika/pika/pull/598","diff_url":"https://github.com/pika/pika/pull/598.diff","patch_url":"https://github.com/pika/pika/pull/598.patch","issue_url":"https://api.github.com/repos/pika/pika/issues/598","number":598,"state":"open","locked":false,"title":"Allow passing exchange, queue and routing_key as text","user":{"login":"everilae","id":531665,"avatar_url":"https://avatars.githubusercontent.com/u/531665?v=3","gravatar_id":"","url":"https://api.github.com/users/everilae","html_url":"https://github.com/everilae","followers_url":"https://api.github.com/users/everilae/followers","following_url":"https://api.github.com/users/everilae/following{/other_user}","gists_url":"https://api.github.com/users/everilae/gists{/gist_id}","starred_url":"https://api.github.com/users/everilae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everilae/subscriptions","organizations_url":"https://api.github.com/users/everilae/orgs","repos_url":"https://api.github.com/users/everilae/repos","events_url":"https://api.github.com/users/everilae/events{/privacy}","received_events_url":"https://api.github.com/users/everilae/received_events","type":"User","site_admin":false},"body":"It turned out that ``queue`` argument was the reason why methods like ``queue_declare`` etc. seemed to require ``bytes`` values. This was due to the callback handling that compares frames/methods and stored arguments.\r\n\r\nWith these changes channel methods accept text (``str``) arguments in python3.\r\n\r\n+  No new tests failed, the 5 failures (that Travis doesn't seem to produce) were present in the pika/master.\r\n\r\nping @ztane \r\n","created_at":"2015-06-09T08:03:37Z","updated_at":"2015-06-09T09:05:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0e72a1450d734bb615fb3623b82423b6dcce025","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pika/pika/pulls/598/commits","review_comments_url":"https://api.github.com/repos/pika/pika/pulls/598/comments","review_comment_url":"https://api.github.com/repos/pika/pika/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pika/pika/issues/598/comments","statuses_url":"https://api.github.com/repos/pika/pika/statuses/ad485b7cee34f733ab82b6781b519ed555eb7b6a","head":{"label":"everilae:bytesfixes","ref":"bytesfixes","sha":"ad485b7cee34f733ab82b6781b519ed555eb7b6a","user":{"login":"everilae","id":531665,"avatar_url":"https://avatars.githubusercontent.com/u/531665?v=3","gravatar_id":"","url":"https://api.github.com/users/everilae","html_url":"https://github.com/everilae","followers_url":"https://api.github.com/users/everilae/followers","following_url":"https://api.github.com/users/everilae/following{/other_user}","gists_url":"https://api.github.com/users/everilae/gists{/gist_id}","starred_url":"https://api.github.com/users/everilae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everilae/subscriptions","organizations_url":"https://api.github.com/users/everilae/orgs","repos_url":"https://api.github.com/users/everilae/repos","events_url":"https://api.github.com/users/everilae/events{/privacy}","received_events_url":"https://api.github.com/users/everilae/received_events","type":"User","site_admin":false},"repo":{"id":36993872,"name":"pika","full_name":"everilae/pika","owner":{"login":"everilae","id":531665,"avatar_url":"https://avatars.githubusercontent.com/u/531665?v=3","gravatar_id":"","url":"https://api.github.com/users/everilae","html_url":"https://github.com/everilae","followers_url":"https://api.github.com/users/everilae/followers","following_url":"https://api.github.com/users/everilae/following{/other_user}","gists_url":"https://api.github.com/users/everilae/gists{/gist_id}","starred_url":"https://api.github.com/users/everilae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everilae/subscriptions","organizations_url":"https://api.github.com/users/everilae/orgs","repos_url":"https://api.github.com/users/everilae/repos","events_url":"https://api.github.com/users/everilae/events{/privacy}","received_events_url":"https://api.github.com/users/everilae/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/everilae/pika","description":"Pure Python RabbitMQ/AMQP 0-9-1 client library","fork":true,"url":"https://api.github.com/repos/everilae/pika","forks_url":"https://api.github.com/repos/everilae/pika/forks","keys_url":"https://api.github.com/repos/everilae/pika/keys{/key_id}","collaborators_url":"https://api.github.com/repos/everilae/pika/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/everilae/pika/teams","hooks_url":"https://api.github.com/repos/everilae/pika/hooks","issue_events_url":"https://api.github.com/repos/everilae/pika/issues/events{/number}","events_url":"https://api.github.com/repos/everilae/pika/events","assignees_url":"https://api.github.com/repos/everilae/pika/assignees{/user}","branches_url":"https://api.github.com/repos/everilae/pika/branches{/branch}","tags_url":"https://api.github.com/repos/everilae/pika/tags","blobs_url":"https://api.github.com/repos/everilae/pika/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/everilae/pika/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/everilae/pika/git/refs{/sha}","trees_url":"https://api.github.com/repos/everilae/pika/git/trees{/sha}","statuses_url":"https://api.github.com/repos/everilae/pika/statuses/{sha}","languages_url":"https://api.github.com/repos/everilae/pika/languages","stargazers_url":"https://api.github.com/repos/everilae/pika/stargazers","contributors_url":"https://api.github.com/repos/everilae/pika/contributors","subscribers_url":"https://api.github.com/repos/everilae/pika/subscribers","subscription_url":"https://api.github.com/repos/everilae/pika/subscription","commits_url":"https://api.github.com/repos/everilae/pika/commits{/sha}","git_commits_url":"https://api.github.com/repos/everilae/pika/git/commits{/sha}","comments_url":"https://api.github.com/repos/everilae/pika/comments{/number}","issue_comment_url":"https://api.github.com/repos/everilae/pika/issues/comments{/number}","contents_url":"https://api.github.com/repos/everilae/pika/contents/{+path}","compare_url":"https://api.github.com/repos/everilae/pika/compare/{base}...{head}","merges_url":"https://api.github.com/repos/everilae/pika/merges","archive_url":"https://api.github.com/repos/everilae/pika/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/everilae/pika/downloads","issues_url":"https://api.github.com/repos/everilae/pika/issues{/number}","pulls_url":"https://api.github.com/repos/everilae/pika/pulls{/number}","milestones_url":"https://api.github.com/repos/everilae/pika/milestones{/number}","notifications_url":"https://api.github.com/repos/everilae/pika/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/everilae/pika/labels{/name}","releases_url":"https://api.github.com/repos/everilae/pika/releases{/id}","created_at":"2015-06-06T20:15:56Z","updated_at":"2015-06-06T20:15:58Z","pushed_at":"2015-06-09T08:29:12Z","git_url":"git://github.com/everilae/pika.git","ssh_url":"git@github.com:everilae/pika.git","clone_url":"https://github.com/everilae/pika.git","svn_url":"https://github.com/everilae/pika","homepage":"http://pika.readthedocs.org","size":5520,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pika:master","ref":"master","sha":"ce6ea930d26a37976a91546707b2e6163e69d83e","user":{"login":"pika","id":660428,"avatar_url":"https://avatars.githubusercontent.com/u/660428?v=3","gravatar_id":"","url":"https://api.github.com/users/pika","html_url":"https://github.com/pika","followers_url":"https://api.github.com/users/pika/followers","following_url":"https://api.github.com/users/pika/following{/other_user}","gists_url":"https://api.github.com/users/pika/gists{/gist_id}","starred_url":"https://api.github.com/users/pika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pika/subscriptions","organizations_url":"https://api.github.com/users/pika/orgs","repos_url":"https://api.github.com/users/pika/repos","events_url":"https://api.github.com/users/pika/events{/privacy}","received_events_url":"https://api.github.com/users/pika/received_events","type":"Organization","site_admin":false},"repo":{"id":342869,"name":"pika","full_name":"pika/pika","owner":{"login":"pika","id":660428,"avatar_url":"https://avatars.githubusercontent.com/u/660428?v=3","gravatar_id":"","url":"https://api.github.com/users/pika","html_url":"https://github.com/pika","followers_url":"https://api.github.com/users/pika/followers","following_url":"https://api.github.com/users/pika/following{/other_user}","gists_url":"https://api.github.com/users/pika/gists{/gist_id}","starred_url":"https://api.github.com/users/pika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pika/subscriptions","organizations_url":"https://api.github.com/users/pika/orgs","repos_url":"https://api.github.com/users/pika/repos","events_url":"https://api.github.com/users/pika/events{/privacy}","received_events_url":"https://api.github.com/users/pika/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pika/pika","description":"Pure Python RabbitMQ/AMQP 0-9-1 client library","fork":false,"url":"https://api.github.com/repos/pika/pika","forks_url":"https://api.github.com/repos/pika/pika/forks","keys_url":"https://api.github.com/repos/pika/pika/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pika/pika/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pika/pika/teams","hooks_url":"https://api.github.com/repos/pika/pika/hooks","issue_events_url":"https://api.github.com/repos/pika/pika/issues/events{/number}","events_url":"https://api.github.com/repos/pika/pika/events","assignees_url":"https://api.github.com/repos/pika/pika/assignees{/user}","branches_url":"https://api.github.com/repos/pika/pika/branches{/branch}","tags_url":"https://api.github.com/repos/pika/pika/tags","blobs_url":"https://api.github.com/repos/pika/pika/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pika/pika/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pika/pika/git/refs{/sha}","trees_url":"https://api.github.com/repos/pika/pika/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pika/pika/statuses/{sha}","languages_url":"https://api.github.com/repos/pika/pika/languages","stargazers_url":"https://api.github.com/repos/pika/pika/stargazers","contributors_url":"https://api.github.com/repos/pika/pika/contributors","subscribers_url":"https://api.github.com/repos/pika/pika/subscribers","subscription_url":"https://api.github.com/repos/pika/pika/subscription","commits_url":"https://api.github.com/repos/pika/pika/commits{/sha}","git_commits_url":"https://api.github.com/repos/pika/pika/git/commits{/sha}","comments_url":"https://api.github.com/repos/pika/pika/comments{/number}","issue_comment_url":"https://api.github.com/repos/pika/pika/issues/comments{/number}","contents_url":"https://api.github.com/repos/pika/pika/contents/{+path}","compare_url":"https://api.github.com/repos/pika/pika/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pika/pika/merges","archive_url":"https://api.github.com/repos/pika/pika/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pika/pika/downloads","issues_url":"https://api.github.com/repos/pika/pika/issues{/number}","pulls_url":"https://api.github.com/repos/pika/pika/pulls{/number}","milestones_url":"https://api.github.com/repos/pika/pika/milestones{/number}","notifications_url":"https://api.github.com/repos/pika/pika/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pika/pika/labels{/name}","releases_url":"https://api.github.com/repos/pika/pika/releases{/id}","created_at":"2009-10-19T23:22:02Z","updated_at":"2015-06-05T23:04:06Z","pushed_at":"2015-06-09T08:29:13Z","git_url":"git://github.com/pika/pika.git","ssh_url":"git@github.com:pika/pika.git","clone_url":"https://github.com/pika/pika.git","svn_url":"https://github.com/pika/pika","homepage":"http://pika.readthedocs.org","size":19631,"stargazers_count":796,"watchers_count":796,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":300,"mirror_url":null,"open_issues_count":39,"forks":300,"open_issues":39,"watchers":796,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pika/pika/pulls/598"},"html":{"href":"https://github.com/pika/pika/pull/598"},"issue":{"href":"https://api.github.com/repos/pika/pika/issues/598"},"comments":{"href":"https://api.github.com/repos/pika/pika/issues/598/comments"},"review_comments":{"href":"https://api.github.com/repos/pika/pika/pulls/598/comments"},"review_comment":{"href":"https://api.github.com/repos/pika/pika/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pika/pika/pulls/598/commits"},"statuses":{"href":"https://api.github.com/repos/pika/pika/statuses/ad485b7cee34f733ab82b6781b519ed555eb7b6a"}}}}