{"action":"closed","number":156,"pull_request":{"url":"https://api.github.com/repos/fs/rails-base-api/pulls/156","id":36194026,"html_url":"https://github.com/fs/rails-base-api/pull/156","diff_url":"https://github.com/fs/rails-base-api/pull/156.diff","patch_url":"https://github.com/fs/rails-base-api/pull/156.patch","issue_url":"https://api.github.com/repos/fs/rails-base-api/issues/156","number":156,"state":"closed","locked":false,"title":"fix incorrect CORS response for sign_in","user":{"login":"antonfefilov","id":1530097,"avatar_url":"https://avatars.githubusercontent.com/u/1530097?v=3","gravatar_id":"","url":"https://api.github.com/users/antonfefilov","html_url":"https://github.com/antonfefilov","followers_url":"https://api.github.com/users/antonfefilov/followers","following_url":"https://api.github.com/users/antonfefilov/following{/other_user}","gists_url":"https://api.github.com/users/antonfefilov/gists{/gist_id}","starred_url":"https://api.github.com/users/antonfefilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonfefilov/subscriptions","organizations_url":"https://api.github.com/users/antonfefilov/orgs","repos_url":"https://api.github.com/users/antonfefilov/repos","events_url":"https://api.github.com/users/antonfefilov/events{/privacy}","received_events_url":"https://api.github.com/users/antonfefilov/received_events","type":"User","site_admin":false},"body":"When you will try to get error message from server during signing in with Devise, you will receive broken response without message, so move `Rack::Cors` before `Warden::Manager` in the middleware stack to prevent it.\r\n\r\nProof: https://github.com/cyu/rack-cors\r\n\r\n> Warden will return immediately if a resource that requires authentication is accessed without authentication. If `Warden::Manager` is in the stack before `Rack::Cors`, it will return without the correct CORS headers being applied, resulting in a failed CORS request. Be sure to\r\ninsert this middleware before `Warden::Manager`.","created_at":"2015-05-26T11:45:22Z","updated_at":"2015-06-19T13:55:50Z","closed_at":"2015-06-19T13:55:50Z","merged_at":"2015-06-19T13:55:50Z","merge_commit_sha":"1d9e901b50e73ed52ebefd4f655ea3c7e163e7dc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fs/rails-base-api/pulls/156/commits","review_comments_url":"https://api.github.com/repos/fs/rails-base-api/pulls/156/comments","review_comment_url":"https://api.github.com/repos/fs/rails-base-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fs/rails-base-api/issues/156/comments","statuses_url":"https://api.github.com/repos/fs/rails-base-api/statuses/9a2fc70d617d1c8eb6fa1a8ab7444197ffd8383a","head":{"label":"antonfefilov:patch-2","ref":"patch-2","sha":"9a2fc70d617d1c8eb6fa1a8ab7444197ffd8383a","user":{"login":"antonfefilov","id":1530097,"avatar_url":"https://avatars.githubusercontent.com/u/1530097?v=3","gravatar_id":"","url":"https://api.github.com/users/antonfefilov","html_url":"https://github.com/antonfefilov","followers_url":"https://api.github.com/users/antonfefilov/followers","following_url":"https://api.github.com/users/antonfefilov/following{/other_user}","gists_url":"https://api.github.com/users/antonfefilov/gists{/gist_id}","starred_url":"https://api.github.com/users/antonfefilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonfefilov/subscriptions","organizations_url":"https://api.github.com/users/antonfefilov/orgs","repos_url":"https://api.github.com/users/antonfefilov/repos","events_url":"https://api.github.com/users/antonfefilov/events{/privacy}","received_events_url":"https://api.github.com/users/antonfefilov/received_events","type":"User","site_admin":false},"repo":{"id":36015229,"name":"rails-base-api","full_name":"antonfefilov/rails-base-api","owner":{"login":"antonfefilov","id":1530097,"avatar_url":"https://avatars.githubusercontent.com/u/1530097?v=3","gravatar_id":"","url":"https://api.github.com/users/antonfefilov","html_url":"https://github.com/antonfefilov","followers_url":"https://api.github.com/users/antonfefilov/followers","following_url":"https://api.github.com/users/antonfefilov/following{/other_user}","gists_url":"https://api.github.com/users/antonfefilov/gists{/gist_id}","starred_url":"https://api.github.com/users/antonfefilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonfefilov/subscriptions","organizations_url":"https://api.github.com/users/antonfefilov/orgs","repos_url":"https://api.github.com/users/antonfefilov/repos","events_url":"https://api.github.com/users/antonfefilov/events{/privacy}","received_events_url":"https://api.github.com/users/antonfefilov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antonfefilov/rails-base-api","description":"Base Rails application for REST API","fork":true,"url":"https://api.github.com/repos/antonfefilov/rails-base-api","forks_url":"https://api.github.com/repos/antonfefilov/rails-base-api/forks","keys_url":"https://api.github.com/repos/antonfefilov/rails-base-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antonfefilov/rails-base-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antonfefilov/rails-base-api/teams","hooks_url":"https://api.github.com/repos/antonfefilov/rails-base-api/hooks","issue_events_url":"https://api.github.com/repos/antonfefilov/rails-base-api/issues/events{/number}","events_url":"https://api.github.com/repos/antonfefilov/rails-base-api/events","assignees_url":"https://api.github.com/repos/antonfefilov/rails-base-api/assignees{/user}","branches_url":"https://api.github.com/repos/antonfefilov/rails-base-api/branches{/branch}","tags_url":"https://api.github.com/repos/antonfefilov/rails-base-api/tags","blobs_url":"https://api.github.com/repos/antonfefilov/rails-base-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antonfefilov/rails-base-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antonfefilov/rails-base-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/antonfefilov/rails-base-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antonfefilov/rails-base-api/statuses/{sha}","languages_url":"https://api.github.com/repos/antonfefilov/rails-base-api/languages","stargazers_url":"https://api.github.com/repos/antonfefilov/rails-base-api/stargazers","contributors_url":"https://api.github.com/repos/antonfefilov/rails-base-api/contributors","subscribers_url":"https://api.github.com/repos/antonfefilov/rails-base-api/subscribers","subscription_url":"https://api.github.com/repos/antonfefilov/rails-base-api/subscription","commits_url":"https://api.github.com/repos/antonfefilov/rails-base-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/antonfefilov/rails-base-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/antonfefilov/rails-base-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/antonfefilov/rails-base-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/antonfefilov/rails-base-api/contents/{+path}","compare_url":"https://api.github.com/repos/antonfefilov/rails-base-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antonfefilov/rails-base-api/merges","archive_url":"https://api.github.com/repos/antonfefilov/rails-base-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antonfefilov/rails-base-api/downloads","issues_url":"https://api.github.com/repos/antonfefilov/rails-base-api/issues{/number}","pulls_url":"https://api.github.com/repos/antonfefilov/rails-base-api/pulls{/number}","milestones_url":"https://api.github.com/repos/antonfefilov/rails-base-api/milestones{/number}","notifications_url":"https://api.github.com/repos/antonfefilov/rails-base-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antonfefilov/rails-base-api/labels{/name}","releases_url":"https://api.github.com/repos/antonfefilov/rails-base-api/releases{/id}","created_at":"2015-05-21T13:46:13Z","updated_at":"2015-05-21T13:46:13Z","pushed_at":"2015-05-26T11:44:10Z","git_url":"git://github.com/antonfefilov/rails-base-api.git","ssh_url":"git@github.com:antonfefilov/rails-base-api.git","clone_url":"https://github.com/antonfefilov/rails-base-api.git","svn_url":"https://github.com/antonfefilov/rails-base-api","homepage":"","size":559,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fs:master","ref":"master","sha":"38f8fa7824296a776fb85dd72ccd48c2f29b0c62","user":{"login":"fs","id":15136,"avatar_url":"https://avatars.githubusercontent.com/u/15136?v=3","gravatar_id":"","url":"https://api.github.com/users/fs","html_url":"https://github.com/fs","followers_url":"https://api.github.com/users/fs/followers","following_url":"https://api.github.com/users/fs/following{/other_user}","gists_url":"https://api.github.com/users/fs/gists{/gist_id}","starred_url":"https://api.github.com/users/fs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fs/subscriptions","organizations_url":"https://api.github.com/users/fs/orgs","repos_url":"https://api.github.com/users/fs/repos","events_url":"https://api.github.com/users/fs/events{/privacy}","received_events_url":"https://api.github.com/users/fs/received_events","type":"Organization","site_admin":false},"repo":{"id":8722795,"name":"rails-base-api","full_name":"fs/rails-base-api","owner":{"login":"fs","id":15136,"avatar_url":"https://avatars.githubusercontent.com/u/15136?v=3","gravatar_id":"","url":"https://api.github.com/users/fs","html_url":"https://github.com/fs","followers_url":"https://api.github.com/users/fs/followers","following_url":"https://api.github.com/users/fs/following{/other_user}","gists_url":"https://api.github.com/users/fs/gists{/gist_id}","starred_url":"https://api.github.com/users/fs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fs/subscriptions","organizations_url":"https://api.github.com/users/fs/orgs","repos_url":"https://api.github.com/users/fs/repos","events_url":"https://api.github.com/users/fs/events{/privacy}","received_events_url":"https://api.github.com/users/fs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fs/rails-base-api","description":"Base Rails application for REST API","fork":false,"url":"https://api.github.com/repos/fs/rails-base-api","forks_url":"https://api.github.com/repos/fs/rails-base-api/forks","keys_url":"https://api.github.com/repos/fs/rails-base-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fs/rails-base-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fs/rails-base-api/teams","hooks_url":"https://api.github.com/repos/fs/rails-base-api/hooks","issue_events_url":"https://api.github.com/repos/fs/rails-base-api/issues/events{/number}","events_url":"https://api.github.com/repos/fs/rails-base-api/events","assignees_url":"https://api.github.com/repos/fs/rails-base-api/assignees{/user}","branches_url":"https://api.github.com/repos/fs/rails-base-api/branches{/branch}","tags_url":"https://api.github.com/repos/fs/rails-base-api/tags","blobs_url":"https://api.github.com/repos/fs/rails-base-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fs/rails-base-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fs/rails-base-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/fs/rails-base-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fs/rails-base-api/statuses/{sha}","languages_url":"https://api.github.com/repos/fs/rails-base-api/languages","stargazers_url":"https://api.github.com/repos/fs/rails-base-api/stargazers","contributors_url":"https://api.github.com/repos/fs/rails-base-api/contributors","subscribers_url":"https://api.github.com/repos/fs/rails-base-api/subscribers","subscription_url":"https://api.github.com/repos/fs/rails-base-api/subscription","commits_url":"https://api.github.com/repos/fs/rails-base-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/fs/rails-base-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/fs/rails-base-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/fs/rails-base-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/fs/rails-base-api/contents/{+path}","compare_url":"https://api.github.com/repos/fs/rails-base-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fs/rails-base-api/merges","archive_url":"https://api.github.com/repos/fs/rails-base-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fs/rails-base-api/downloads","issues_url":"https://api.github.com/repos/fs/rails-base-api/issues{/number}","pulls_url":"https://api.github.com/repos/fs/rails-base-api/pulls{/number}","milestones_url":"https://api.github.com/repos/fs/rails-base-api/milestones{/number}","notifications_url":"https://api.github.com/repos/fs/rails-base-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fs/rails-base-api/labels{/name}","releases_url":"https://api.github.com/repos/fs/rails-base-api/releases{/id}","created_at":"2013-03-12T07:57:35Z","updated_at":"2015-05-15T00:25:31Z","pushed_at":"2015-06-19T13:55:50Z","git_url":"git://github.com/fs/rails-base-api.git","ssh_url":"git@github.com:fs/rails-base-api.git","clone_url":"https://github.com/fs/rails-base-api.git","svn_url":"https://github.com/fs/rails-base-api","homepage":"","size":1570,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":22,"forks":11,"open_issues":22,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fs/rails-base-api/pulls/156"},"html":{"href":"https://github.com/fs/rails-base-api/pull/156"},"issue":{"href":"https://api.github.com/repos/fs/rails-base-api/issues/156"},"comments":{"href":"https://api.github.com/repos/fs/rails-base-api/issues/156/comments"},"review_comments":{"href":"https://api.github.com/repos/fs/rails-base-api/pulls/156/comments"},"review_comment":{"href":"https://api.github.com/repos/fs/rails-base-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fs/rails-base-api/pulls/156/commits"},"statuses":{"href":"https://api.github.com/repos/fs/rails-base-api/statuses/9a2fc70d617d1c8eb6fa1a8ab7444197ffd8383a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"vast","id":25136,"avatar_url":"https://avatars.githubusercontent.com/u/25136?v=3","gravatar_id":"","url":"https://api.github.com/users/vast","html_url":"https://github.com/vast","followers_url":"https://api.github.com/users/vast/followers","following_url":"https://api.github.com/users/vast/following{/other_user}","gists_url":"https://api.github.com/users/vast/gists{/gist_id}","starred_url":"https://api.github.com/users/vast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vast/subscriptions","organizations_url":"https://api.github.com/users/vast/orgs","repos_url":"https://api.github.com/users/vast/repos","events_url":"https://api.github.com/users/vast/events{/privacy}","received_events_url":"https://api.github.com/users/vast/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}