{"action":"created","comment":{"url":"https://api.github.com/repos/softdevteam/krun/pulls/comments/46051372","id":46051372,"diff_hunk":"@@ -86,3 +86,23 @@ def test_tickless0004(self, monkeypatch, platform):\n \n         with pytest.raises(SystemExit):\n             krun.platform.LinuxPlatform._check_tickless_kernel(platform)\n+\n+    def test_bench_cmdline_adjust0001(self, platform):\n+        expect = ['sudo', '-u', 'krun', 'nice', '-20', 'taskset', '0x8',\n+                  'env', 'LD_LIBRARY_PATH=']\n+\n+        platform.isolated_cpu = 3\n+\n+        args = subst_env_arg(platform.bench_cmdline_adjust([], {}), \"LD_LIBRARY_PATH\")\n+        assert args == expect\n+\n+    def test_bench_cmdline_adjust0002(self, platform):\n+        expect = ['sudo', '-u', 'krun', 'nice', '-20', 'taskset', '0x8',\n+                       'env', 'MYENV=some_value', 'LD_LIBRARY_PATH=', 'myarg']","path":"krun/tests/test_linuxplatform.py","position":24,"original_position":24,"commit_id":"42a9f48d1968f3ddb69a197440296e840e3b79a4","original_commit_id":"42a9f48d1968f3ddb69a197440296e840e3b79a4","user":{"login":"ltratt","id":20318,"avatar_url":"https://avatars.githubusercontent.com/u/20318?v=3","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"body":"Broken indent.","created_at":"2015-11-27T14:35:30Z","updated_at":"2015-11-27T14:35:30Z","html_url":"https://github.com/softdevteam/krun/pull/122#discussion_r46051372","pull_request_url":"https://api.github.com/repos/softdevteam/krun/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/softdevteam/krun/pulls/comments/46051372"},"html":{"href":"https://github.com/softdevteam/krun/pull/122#discussion_r46051372"},"pull_request":{"href":"https://api.github.com/repos/softdevteam/krun/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/softdevteam/krun/pulls/122","id":51999374,"html_url":"https://github.com/softdevteam/krun/pull/122","diff_url":"https://github.com/softdevteam/krun/pull/122.diff","patch_url":"https://github.com/softdevteam/krun/pull/122.patch","issue_url":"https://api.github.com/repos/softdevteam/krun/issues/122","number":122,"state":"open","locked":false,"title":"Set Openbsd malloc flags and other bits.","user":{"login":"vext01","id":604955,"avatar_url":"https://avatars.githubusercontent.com/u/604955?v=3","gravatar_id":"","url":"https://api.github.com/users/vext01","html_url":"https://github.com/vext01","followers_url":"https://api.github.com/users/vext01/followers","following_url":"https://api.github.com/users/vext01/following{/other_user}","gists_url":"https://api.github.com/users/vext01/gists{/gist_id}","starred_url":"https://api.github.com/users/vext01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vext01/subscriptions","organizations_url":"https://api.github.com/users/vext01/orgs","repos_url":"https://api.github.com/users/vext01/repos","events_url":"https://api.github.com/users/vext01/events{/privacy}","received_events_url":"https://api.github.com/users/vext01/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nAs mentioned yesterday in-person, in hindsight this would be a series of smaller PRs. Sorry about that.\r\n\r\n * Set OpenBSD's `MALLOC_OPTIONS` to sane \"as deterministic as possible\" values.\r\n * Add a sanity check for the above.\r\n * Unify all sanity checks so they all call a since function `spawn_sanity_check()`.\r\n * Rename \"misc sanity checks\" to \"platform sanity checks.\r\n * Add more tests to make sections of code I touched more robust.\r\n * Attach log file earlier.\r\n * Improve logging messages.\r\n\r\nClearly some squashing can be done.\r\n\r\nOK?","created_at":"2015-11-27T14:21:28Z","updated_at":"2015-11-27T14:35:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e898306f909782fc27cc2b820c8f5cf223491e59","assignee":{"login":"ltratt","id":20318,"avatar_url":"https://avatars.githubusercontent.com/u/20318?v=3","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/softdevteam/krun/milestones/1","html_url":"https://github.com/softdevteam/krun/milestones/initial%20submission","labels_url":"https://api.github.com/repos/softdevteam/krun/milestones/1/labels","id":1359102,"number":1,"title":"initial submission","description":"","creator":{"login":"snim2","id":97674,"avatar_url":"https://avatars.githubusercontent.com/u/97674?v=3","gravatar_id":"","url":"https://api.github.com/users/snim2","html_url":"https://github.com/snim2","followers_url":"https://api.github.com/users/snim2/followers","following_url":"https://api.github.com/users/snim2/following{/other_user}","gists_url":"https://api.github.com/users/snim2/gists{/gist_id}","starred_url":"https://api.github.com/users/snim2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snim2/subscriptions","organizations_url":"https://api.github.com/users/snim2/orgs","repos_url":"https://api.github.com/users/snim2/repos","events_url":"https://api.github.com/users/snim2/events{/privacy}","received_events_url":"https://api.github.com/users/snim2/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":24,"state":"open","created_at":"2015-10-16T09:50:59Z","updated_at":"2015-11-27T14:21:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/softdevteam/krun/pulls/122/commits","review_comments_url":"https://api.github.com/repos/softdevteam/krun/pulls/122/comments","review_comment_url":"https://api.github.com/repos/softdevteam/krun/pulls/comments{/number}","comments_url":"https://api.github.com/repos/softdevteam/krun/issues/122/comments","statuses_url":"https://api.github.com/repos/softdevteam/krun/statuses/42a9f48d1968f3ddb69a197440296e840e3b79a4","head":{"label":"softdevteam:openbsd_malloc_flags","ref":"openbsd_malloc_flags","sha":"42a9f48d1968f3ddb69a197440296e840e3b79a4","user":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars.githubusercontent.com/u/10271085?v=3","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":36661834,"name":"krun","full_name":"softdevteam/krun","owner":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars.githubusercontent.com/u/10271085?v=3","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/krun","description":"Soft-dev kalibera benchmark runner in Python.","fork":false,"url":"https://api.github.com/repos/softdevteam/krun","forks_url":"https://api.github.com/repos/softdevteam/krun/forks","keys_url":"https://api.github.com/repos/softdevteam/krun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/krun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/krun/teams","hooks_url":"https://api.github.com/repos/softdevteam/krun/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/krun/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/krun/events","assignees_url":"https://api.github.com/repos/softdevteam/krun/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/krun/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/krun/tags","blobs_url":"https://api.github.com/repos/softdevteam/krun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/krun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/krun/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/krun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/krun/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/krun/languages","stargazers_url":"https://api.github.com/repos/softdevteam/krun/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/krun/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/krun/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/krun/subscription","commits_url":"https://api.github.com/repos/softdevteam/krun/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/krun/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/krun/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/krun/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/krun/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/krun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/krun/merges","archive_url":"https://api.github.com/repos/softdevteam/krun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/krun/downloads","issues_url":"https://api.github.com/repos/softdevteam/krun/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/krun/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/krun/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/krun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/krun/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/krun/releases{/id}","created_at":"2015-06-01T13:17:06Z","updated_at":"2015-09-28T18:29:45Z","pushed_at":"2015-11-27T14:21:29Z","git_url":"git://github.com/softdevteam/krun.git","ssh_url":"git@github.com:softdevteam/krun.git","clone_url":"https://github.com/softdevteam/krun.git","svn_url":"https://github.com/softdevteam/krun","homepage":null,"size":1000,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":1,"default_branch":"master"}},"base":{"label":"softdevteam:master","ref":"master","sha":"ed06bb00406f13e3cd3d97cc6e4f20fb65a47e97","user":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars.githubusercontent.com/u/10271085?v=3","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":36661834,"name":"krun","full_name":"softdevteam/krun","owner":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars.githubusercontent.com/u/10271085?v=3","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/krun","description":"Soft-dev kalibera benchmark runner in Python.","fork":false,"url":"https://api.github.com/repos/softdevteam/krun","forks_url":"https://api.github.com/repos/softdevteam/krun/forks","keys_url":"https://api.github.com/repos/softdevteam/krun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/krun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/krun/teams","hooks_url":"https://api.github.com/repos/softdevteam/krun/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/krun/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/krun/events","assignees_url":"https://api.github.com/repos/softdevteam/krun/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/krun/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/krun/tags","blobs_url":"https://api.github.com/repos/softdevteam/krun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/krun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/krun/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/krun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/krun/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/krun/languages","stargazers_url":"https://api.github.com/repos/softdevteam/krun/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/krun/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/krun/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/krun/subscription","commits_url":"https://api.github.com/repos/softdevteam/krun/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/krun/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/krun/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/krun/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/krun/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/krun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/krun/merges","archive_url":"https://api.github.com/repos/softdevteam/krun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/krun/downloads","issues_url":"https://api.github.com/repos/softdevteam/krun/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/krun/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/krun/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/krun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/krun/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/krun/releases{/id}","created_at":"2015-06-01T13:17:06Z","updated_at":"2015-09-28T18:29:45Z","pushed_at":"2015-11-27T14:21:29Z","git_url":"git://github.com/softdevteam/krun.git","ssh_url":"git@github.com:softdevteam/krun.git","clone_url":"https://github.com/softdevteam/krun.git","svn_url":"https://github.com/softdevteam/krun","homepage":null,"size":1000,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/softdevteam/krun/pulls/122"},"html":{"href":"https://github.com/softdevteam/krun/pull/122"},"issue":{"href":"https://api.github.com/repos/softdevteam/krun/issues/122"},"comments":{"href":"https://api.github.com/repos/softdevteam/krun/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/softdevteam/krun/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/softdevteam/krun/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/softdevteam/krun/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/softdevteam/krun/statuses/42a9f48d1968f3ddb69a197440296e840e3b79a4"}}}}