{"action":"created","issue":{"url":"https://api.github.com/repos/tavendo/AutobahnPython/issues/341","labels_url":"https://api.github.com/repos/tavendo/AutobahnPython/issues/341/labels{/name}","comments_url":"https://api.github.com/repos/tavendo/AutobahnPython/issues/341/comments","events_url":"https://api.github.com/repos/tavendo/AutobahnPython/issues/341/events","html_url":"https://github.com/tavendo/AutobahnPython/pull/341","id":57515728,"number":341,"title":"Handle connection errors","user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-12T20:35:51Z","updated_at":"2015-02-12T21:49:58Z","closed_at":"2015-02-12T21:42:01Z","pull_request":{"url":"https://api.github.com/repos/tavendo/AutobahnPython/pulls/341","html_url":"https://github.com/tavendo/AutobahnPython/pull/341","diff_url":"https://github.com/tavendo/AutobahnPython/pull/341.diff","patch_url":"https://github.com/tavendo/AutobahnPython/pull/341.patch"},"body":"ApplicationRunner.run() ignores the Deferred from .connect() which means if there's a connection problem, run() won't exit the event-loop and no exception will be raised to the caller. Minimal test-case:\r\n\r\n```python\r\nfrom autobahn.twisted.wamp import ApplicationSession\r\nfrom autobahn.twisted.wamp import ApplicationRunner\r\n\r\nclass Session(ApplicationSession):\r\n    pass\r\n\r\nrunner = ApplicationRunner('ws://localhost:1', 'realm')\r\nrunner.run(Session) \r\n```"},"comment":{"url":"https://api.github.com/repos/tavendo/AutobahnPython/issues/comments/74160402","html_url":"https://github.com/tavendo/AutobahnPython/pull/341#issuecomment-74160402","issue_url":"https://api.github.com/repos/tavendo/AutobahnPython/issues/341","id":74160402,"user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"created_at":"2015-02-12T21:49:58Z","updated_at":"2015-02-12T21:49:58Z","body":"@oberstet see #342 "}}