{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/10237","labels_url":"https://api.github.com/repos/apache/spark/issues/10237/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/10237/comments","events_url":"https://api.github.com/repos/apache/spark/issues/10237/events","html_url":"https://github.com/apache/spark/pull/10237","id":121386885,"number":10237,"title":"[SPARK-12251] Document and improve off-heap memory configurations","user":{"login":"JoshRosen","id":50748,"avatar_url":"https://avatars.githubusercontent.com/u/50748?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshRosen","html_url":"https://github.com/JoshRosen","followers_url":"https://api.github.com/users/JoshRosen/followers","following_url":"https://api.github.com/users/JoshRosen/following{/other_user}","gists_url":"https://api.github.com/users/JoshRosen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshRosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshRosen/subscriptions","organizations_url":"https://api.github.com/users/JoshRosen/orgs","repos_url":"https://api.github.com/users/JoshRosen/repos","events_url":"https://api.github.com/users/JoshRosen/events{/privacy}","received_events_url":"https://api.github.com/users/JoshRosen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-12-10T02:23:00Z","updated_at":"2015-12-10T07:04:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/10237","html_url":"https://github.com/apache/spark/pull/10237","diff_url":"https://github.com/apache/spark/pull/10237.diff","patch_url":"https://github.com/apache/spark/pull/10237.patch"},"body":"This patch adds documentation for Spark configurations that affect off-heap memory and makes some naming and validation improvements for those configs.\r\n\r\n- Change `spark.memory.offHeapSize` to `spark.memory.offHeap.size`. This is fine because this configuration has not shipped in any Spark release yet (it's new in Spark 1.6).\r\n- Deprecated `spark.unsafe.offHeap` in favor of a new `spark.memory.offHeap.enabled` configuration. The motivation behind this change is to gather all memory-related configurations under the same prefix.\r\n- Add a check which prevents users from setting `spark.memory.offHeap.enabled=true` when `spark.memory.offHeap.size == 0`. After SPARK-11389 (#9344), which was committed in Spark 1.6, Spark enforces a hard limit on the amount of off-heap memory that it will allocate to tasks. As a result, enabling off-heap execution memory without setting `spark.memory.offHeap.size` will lead to immediate OOMs. The new configuration validation makes this scenario easier to diagnose, helping to avoid user confusion.\r\n- Document these configurations on the configuration page."},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/163519491","html_url":"https://github.com/apache/spark/pull/10237#issuecomment-163519491","issue_url":"https://api.github.com/repos/apache/spark/issues/10237","id":163519491,"user":{"login":"AmplabJenkins","id":4031291,"avatar_url":"https://avatars.githubusercontent.com/u/4031291?v=3","gravatar_id":"","url":"https://api.github.com/users/AmplabJenkins","html_url":"https://github.com/AmplabJenkins","followers_url":"https://api.github.com/users/AmplabJenkins/followers","following_url":"https://api.github.com/users/AmplabJenkins/following{/other_user}","gists_url":"https://api.github.com/users/AmplabJenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/AmplabJenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmplabJenkins/subscriptions","organizations_url":"https://api.github.com/users/AmplabJenkins/orgs","repos_url":"https://api.github.com/users/AmplabJenkins/repos","events_url":"https://api.github.com/users/AmplabJenkins/events{/privacy}","received_events_url":"https://api.github.com/users/AmplabJenkins/received_events","type":"User","site_admin":false},"created_at":"2015-12-10T07:04:47Z","updated_at":"2015-12-10T07:04:47Z","body":"Test FAILed.\nRefer to this link for build results (access rights to CI server needed): \nhttps://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47486/\nTest FAILed."}}