{"action":"created","comment":{"url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/pulls/comments/42566793","id":42566793,"diff_hunk":"@@ -0,0 +1,51 @@\n+package piconot\n+import scalafx.application.JFXApp\n+import picolib.semantics._\n+/**\n+ * @author justisallen\n+ */\n+trait language extends JFXApp{","path":"src/main/scala/language.scala","position":7,"original_position":7,"commit_id":"041ea0919adfb5f6d031ae56f75255494174f2fd","original_commit_id":"041ea0919adfb5f6d031ae56f75255494174f2fd","user":{"login":"JustisAllen","id":6563083,"avatar_url":"https://avatars.githubusercontent.com/u/6563083?v=3","gravatar_id":"","url":"https://api.github.com/users/JustisAllen","html_url":"https://github.com/JustisAllen","followers_url":"https://api.github.com/users/JustisAllen/followers","following_url":"https://api.github.com/users/JustisAllen/following{/other_user}","gists_url":"https://api.github.com/users/JustisAllen/gists{/gist_id}","starred_url":"https://api.github.com/users/JustisAllen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustisAllen/subscriptions","organizations_url":"https://api.github.com/users/JustisAllen/orgs","repos_url":"https://api.github.com/users/JustisAllen/repos","events_url":"https://api.github.com/users/JustisAllen/events{/privacy}","received_events_url":"https://api.github.com/users/JustisAllen/received_events","type":"User","site_admin":false},"body":"I think the reasoning was that if we extend `JFXApp`, then the user can just extend `language` and not worry about extending `JFXApp`; but this probably brings about coupling concerns.","created_at":"2015-10-20T23:11:42Z","updated_at":"2015-10-20T23:11:42Z","html_url":"https://github.com/hmc-cs111-fall2015/piconot/pull/4#discussion_r42566793","pull_request_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/pulls/comments/42566793"},"html":{"href":"https://github.com/hmc-cs111-fall2015/piconot/pull/4#discussion_r42566793"},"pull_request":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/pulls/4","id":46738260,"html_url":"https://github.com/hmc-cs111-fall2015/piconot/pull/4","diff_url":"https://github.com/hmc-cs111-fall2015/piconot/pull/4.diff","patch_url":"https://github.com/hmc-cs111-fall2015/piconot/pull/4.patch","issue_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/issues/4","number":4,"state":"open","locked":false,"title":"Robin & Justis' Submission","user":{"login":"JustisAllen","id":6563083,"avatar_url":"https://avatars.githubusercontent.com/u/6563083?v=3","gravatar_id":"","url":"https://api.github.com/users/JustisAllen","html_url":"https://github.com/JustisAllen","followers_url":"https://api.github.com/users/JustisAllen/followers","following_url":"https://api.github.com/users/JustisAllen/following{/other_user}","gists_url":"https://api.github.com/users/JustisAllen/gists{/gist_id}","starred_url":"https://api.github.com/users/JustisAllen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustisAllen/subscriptions","organizations_url":"https://api.github.com/users/JustisAllen/orgs","repos_url":"https://api.github.com/users/JustisAllen/repos","events_url":"https://api.github.com/users/JustisAllen/events{/privacy}","received_events_url":"https://api.github.com/users/JustisAllen/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-05T01:18:07Z","updated_at":"2015-10-20T23:11:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c9ad7bcdddcf9f540cf941063fcab022dcd83d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/pulls/4/commits","review_comments_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/pulls/4/comments","review_comment_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/issues/4/comments","statuses_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/statuses/041ea0919adfb5f6d031ae56f75255494174f2fd","head":{"label":"JustisAllen:master","ref":"master","sha":"041ea0919adfb5f6d031ae56f75255494174f2fd","user":{"login":"JustisAllen","id":6563083,"avatar_url":"https://avatars.githubusercontent.com/u/6563083?v=3","gravatar_id":"","url":"https://api.github.com/users/JustisAllen","html_url":"https://github.com/JustisAllen","followers_url":"https://api.github.com/users/JustisAllen/followers","following_url":"https://api.github.com/users/JustisAllen/following{/other_user}","gists_url":"https://api.github.com/users/JustisAllen/gists{/gist_id}","starred_url":"https://api.github.com/users/JustisAllen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustisAllen/subscriptions","organizations_url":"https://api.github.com/users/JustisAllen/orgs","repos_url":"https://api.github.com/users/JustisAllen/repos","events_url":"https://api.github.com/users/JustisAllen/events{/privacy}","received_events_url":"https://api.github.com/users/JustisAllen/received_events","type":"User","site_admin":false},"repo":{"id":43580054,"name":"piconot","full_name":"JustisAllen/piconot","owner":{"login":"JustisAllen","id":6563083,"avatar_url":"https://avatars.githubusercontent.com/u/6563083?v=3","gravatar_id":"","url":"https://api.github.com/users/JustisAllen","html_url":"https://github.com/JustisAllen","followers_url":"https://api.github.com/users/JustisAllen/followers","following_url":"https://api.github.com/users/JustisAllen/following{/other_user}","gists_url":"https://api.github.com/users/JustisAllen/gists{/gist_id}","starred_url":"https://api.github.com/users/JustisAllen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustisAllen/subscriptions","organizations_url":"https://api.github.com/users/JustisAllen/orgs","repos_url":"https://api.github.com/users/JustisAllen/repos","events_url":"https://api.github.com/users/JustisAllen/events{/privacy}","received_events_url":"https://api.github.com/users/JustisAllen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JustisAllen/piconot","description":"","fork":true,"url":"https://api.github.com/repos/JustisAllen/piconot","forks_url":"https://api.github.com/repos/JustisAllen/piconot/forks","keys_url":"https://api.github.com/repos/JustisAllen/piconot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JustisAllen/piconot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JustisAllen/piconot/teams","hooks_url":"https://api.github.com/repos/JustisAllen/piconot/hooks","issue_events_url":"https://api.github.com/repos/JustisAllen/piconot/issues/events{/number}","events_url":"https://api.github.com/repos/JustisAllen/piconot/events","assignees_url":"https://api.github.com/repos/JustisAllen/piconot/assignees{/user}","branches_url":"https://api.github.com/repos/JustisAllen/piconot/branches{/branch}","tags_url":"https://api.github.com/repos/JustisAllen/piconot/tags","blobs_url":"https://api.github.com/repos/JustisAllen/piconot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JustisAllen/piconot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JustisAllen/piconot/git/refs{/sha}","trees_url":"https://api.github.com/repos/JustisAllen/piconot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JustisAllen/piconot/statuses/{sha}","languages_url":"https://api.github.com/repos/JustisAllen/piconot/languages","stargazers_url":"https://api.github.com/repos/JustisAllen/piconot/stargazers","contributors_url":"https://api.github.com/repos/JustisAllen/piconot/contributors","subscribers_url":"https://api.github.com/repos/JustisAllen/piconot/subscribers","subscription_url":"https://api.github.com/repos/JustisAllen/piconot/subscription","commits_url":"https://api.github.com/repos/JustisAllen/piconot/commits{/sha}","git_commits_url":"https://api.github.com/repos/JustisAllen/piconot/git/commits{/sha}","comments_url":"https://api.github.com/repos/JustisAllen/piconot/comments{/number}","issue_comment_url":"https://api.github.com/repos/JustisAllen/piconot/issues/comments{/number}","contents_url":"https://api.github.com/repos/JustisAllen/piconot/contents/{+path}","compare_url":"https://api.github.com/repos/JustisAllen/piconot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JustisAllen/piconot/merges","archive_url":"https://api.github.com/repos/JustisAllen/piconot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JustisAllen/piconot/downloads","issues_url":"https://api.github.com/repos/JustisAllen/piconot/issues{/number}","pulls_url":"https://api.github.com/repos/JustisAllen/piconot/pulls{/number}","milestones_url":"https://api.github.com/repos/JustisAllen/piconot/milestones{/number}","notifications_url":"https://api.github.com/repos/JustisAllen/piconot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JustisAllen/piconot/labels{/name}","releases_url":"https://api.github.com/repos/JustisAllen/piconot/releases{/id}","created_at":"2015-10-02T22:55:01Z","updated_at":"2015-10-02T22:55:02Z","pushed_at":"2015-10-05T03:38:25Z","git_url":"git://github.com/JustisAllen/piconot.git","ssh_url":"git@github.com:JustisAllen/piconot.git","clone_url":"https://github.com/JustisAllen/piconot.git","svn_url":"https://github.com/JustisAllen/piconot","homepage":null,"size":200,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hmc-cs111-fall2015:master","ref":"master","sha":"0b871fc667be2a1e7e9e207ffa8099332f3dc297","user":{"login":"hmc-cs111-fall2015","id":12563789,"avatar_url":"https://avatars.githubusercontent.com/u/12563789?v=3","gravatar_id":"","url":"https://api.github.com/users/hmc-cs111-fall2015","html_url":"https://github.com/hmc-cs111-fall2015","followers_url":"https://api.github.com/users/hmc-cs111-fall2015/followers","following_url":"https://api.github.com/users/hmc-cs111-fall2015/following{/other_user}","gists_url":"https://api.github.com/users/hmc-cs111-fall2015/gists{/gist_id}","starred_url":"https://api.github.com/users/hmc-cs111-fall2015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmc-cs111-fall2015/subscriptions","organizations_url":"https://api.github.com/users/hmc-cs111-fall2015/orgs","repos_url":"https://api.github.com/users/hmc-cs111-fall2015/repos","events_url":"https://api.github.com/users/hmc-cs111-fall2015/events{/privacy}","received_events_url":"https://api.github.com/users/hmc-cs111-fall2015/received_events","type":"Organization","site_admin":false},"repo":{"id":43472993,"name":"piconot","full_name":"hmc-cs111-fall2015/piconot","owner":{"login":"hmc-cs111-fall2015","id":12563789,"avatar_url":"https://avatars.githubusercontent.com/u/12563789?v=3","gravatar_id":"","url":"https://api.github.com/users/hmc-cs111-fall2015","html_url":"https://github.com/hmc-cs111-fall2015","followers_url":"https://api.github.com/users/hmc-cs111-fall2015/followers","following_url":"https://api.github.com/users/hmc-cs111-fall2015/following{/other_user}","gists_url":"https://api.github.com/users/hmc-cs111-fall2015/gists{/gist_id}","starred_url":"https://api.github.com/users/hmc-cs111-fall2015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmc-cs111-fall2015/subscriptions","organizations_url":"https://api.github.com/users/hmc-cs111-fall2015/orgs","repos_url":"https://api.github.com/users/hmc-cs111-fall2015/repos","events_url":"https://api.github.com/users/hmc-cs111-fall2015/events{/privacy}","received_events_url":"https://api.github.com/users/hmc-cs111-fall2015/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmc-cs111-fall2015/piconot","description":"","fork":false,"url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot","forks_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/forks","keys_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/teams","hooks_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/hooks","issue_events_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/issues/events{/number}","events_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/events","assignees_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/assignees{/user}","branches_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/branches{/branch}","tags_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/tags","blobs_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/statuses/{sha}","languages_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/languages","stargazers_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/stargazers","contributors_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/contributors","subscribers_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/subscribers","subscription_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/subscription","commits_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/contents/{+path}","compare_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/merges","archive_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/downloads","issues_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/issues{/number}","pulls_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/pulls{/number}","milestones_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/milestones{/number}","notifications_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/labels{/name}","releases_url":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/releases{/id}","created_at":"2015-10-01T01:43:03Z","updated_at":"2015-10-01T03:29:04Z","pushed_at":"2015-10-14T19:28:35Z","git_url":"git://github.com/hmc-cs111-fall2015/piconot.git","ssh_url":"git@github.com:hmc-cs111-fall2015/piconot.git","clone_url":"https://github.com/hmc-cs111-fall2015/piconot.git","svn_url":"https://github.com/hmc-cs111-fall2015/piconot","homepage":null,"size":448,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":6,"forks":8,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/pulls/4"},"html":{"href":"https://github.com/hmc-cs111-fall2015/piconot/pull/4"},"issue":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/issues/4"},"comments":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/hmc-cs111-fall2015/piconot/statuses/041ea0919adfb5f6d031ae56f75255494174f2fd"}}}}