{"action":"opened","number":17,"pull_request":{"url":"https://api.github.com/repos/plone/plone.app.iterate/pulls/17","id":50683749,"html_url":"https://github.com/plone/plone.app.iterate/pull/17","diff_url":"https://github.com/plone/plone.app.iterate/pull/17.diff","patch_url":"https://github.com/plone/plone.app.iterate/pull/17.patch","issue_url":"https://api.github.com/repos/plone/plone.app.iterate/issues/17","number":17,"state":"open","locked":false,"title":"Keep default page on checkin (Plone 4.3)","user":{"login":"mauritsvanrees","id":210587,"avatar_url":"https://avatars.githubusercontent.com/u/210587?v=3","gravatar_id":"","url":"https://api.github.com/users/mauritsvanrees","html_url":"https://github.com/mauritsvanrees","followers_url":"https://api.github.com/users/mauritsvanrees/followers","following_url":"https://api.github.com/users/mauritsvanrees/following{/other_user}","gists_url":"https://api.github.com/users/mauritsvanrees/gists{/gist_id}","starred_url":"https://api.github.com/users/mauritsvanrees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauritsvanrees/subscriptions","organizations_url":"https://api.github.com/users/mauritsvanrees/orgs","repos_url":"https://api.github.com/users/mauritsvanrees/repos","events_url":"https://api.github.com/users/mauritsvanrees/events{/privacy}","received_events_url":"https://api.github.com/users/mauritsvanrees/received_events","type":"User","site_admin":false},"body":"This pull request in CMFDynamicViewFTI introduced event handlers that clean up the default_page property when deleting a page:ttps://github.com/plone/Products.CMFDynamicViewFTI/pull/4\r\nGood.\r\nThen this fix came along, which made it function better (not only in tests but for real I think):\r\nhttps://github.com/plone/Products.CMFDynamicViewFTI/commit/6ecdf22593f13ac0bc5bf546b5ce92e2bfa7a6e8\r\nVery good.\r\n\r\nBut now the following scenario in plone.app.iterate 'breaks'.\r\n- Activate plone.app.iterate.\r\n- Create a folder.\r\n- Create a page.\r\n- Make this page the default_page of the folder.\r\n- Check out the page.\r\n- Check in the page.\r\nBug: the default_page property is gone: the folder shows the standard folder listing.\r\nThis works fine with Plone 4.3.5 and fails in Plone 4.3.6 (and 4.3.7 and current coredev).\r\n\r\nThe problem is that in the checkin phase this happens:\r\n1. plone.app.iterate removes the original page\r\n2. In CMFDynamicViewFTI the `check_default_page` event handler is triggered and removes the default_page property.\r\n3. plone.app.iterate adds the updated page.\r\n\r\nThis pull requests saves the default_page property and restores it if needed.","created_at":"2015-11-13T19:51:55Z","updated_at":"2015-11-13T19:51:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/plone/plone.app.iterate/pulls/17/commits","review_comments_url":"https://api.github.com/repos/plone/plone.app.iterate/pulls/17/comments","review_comment_url":"https://api.github.com/repos/plone/plone.app.iterate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plone/plone.app.iterate/issues/17/comments","statuses_url":"https://api.github.com/repos/plone/plone.app.iterate/statuses/66662998949806498619fff4dd244bba0cc1d25a","head":{"label":"plone:maurits-keep-default-page-43","ref":"maurits-keep-default-page-43","sha":"66662998949806498619fff4dd244bba0cc1d25a","user":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"repo":{"id":2432580,"name":"plone.app.iterate","full_name":"plone/plone.app.iterate","owner":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plone/plone.app.iterate","description":"Checkin/ checkout procedure for content editing (working copy) for Plone","fork":false,"url":"https://api.github.com/repos/plone/plone.app.iterate","forks_url":"https://api.github.com/repos/plone/plone.app.iterate/forks","keys_url":"https://api.github.com/repos/plone/plone.app.iterate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plone/plone.app.iterate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plone/plone.app.iterate/teams","hooks_url":"https://api.github.com/repos/plone/plone.app.iterate/hooks","issue_events_url":"https://api.github.com/repos/plone/plone.app.iterate/issues/events{/number}","events_url":"https://api.github.com/repos/plone/plone.app.iterate/events","assignees_url":"https://api.github.com/repos/plone/plone.app.iterate/assignees{/user}","branches_url":"https://api.github.com/repos/plone/plone.app.iterate/branches{/branch}","tags_url":"https://api.github.com/repos/plone/plone.app.iterate/tags","blobs_url":"https://api.github.com/repos/plone/plone.app.iterate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plone/plone.app.iterate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plone/plone.app.iterate/git/refs{/sha}","trees_url":"https://api.github.com/repos/plone/plone.app.iterate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plone/plone.app.iterate/statuses/{sha}","languages_url":"https://api.github.com/repos/plone/plone.app.iterate/languages","stargazers_url":"https://api.github.com/repos/plone/plone.app.iterate/stargazers","contributors_url":"https://api.github.com/repos/plone/plone.app.iterate/contributors","subscribers_url":"https://api.github.com/repos/plone/plone.app.iterate/subscribers","subscription_url":"https://api.github.com/repos/plone/plone.app.iterate/subscription","commits_url":"https://api.github.com/repos/plone/plone.app.iterate/commits{/sha}","git_commits_url":"https://api.github.com/repos/plone/plone.app.iterate/git/commits{/sha}","comments_url":"https://api.github.com/repos/plone/plone.app.iterate/comments{/number}","issue_comment_url":"https://api.github.com/repos/plone/plone.app.iterate/issues/comments{/number}","contents_url":"https://api.github.com/repos/plone/plone.app.iterate/contents/{+path}","compare_url":"https://api.github.com/repos/plone/plone.app.iterate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plone/plone.app.iterate/merges","archive_url":"https://api.github.com/repos/plone/plone.app.iterate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plone/plone.app.iterate/downloads","issues_url":"https://api.github.com/repos/plone/plone.app.iterate/issues{/number}","pulls_url":"https://api.github.com/repos/plone/plone.app.iterate/pulls{/number}","milestones_url":"https://api.github.com/repos/plone/plone.app.iterate/milestones{/number}","notifications_url":"https://api.github.com/repos/plone/plone.app.iterate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plone/plone.app.iterate/labels{/name}","releases_url":"https://api.github.com/repos/plone/plone.app.iterate/releases{/id}","created_at":"2011-09-21T20:21:13Z","updated_at":"2015-03-12T14:28:48Z","pushed_at":"2015-11-13T19:30:21Z","git_url":"git://github.com/plone/plone.app.iterate.git","ssh_url":"git@github.com:plone/plone.app.iterate.git","clone_url":"https://github.com/plone/plone.app.iterate.git","svn_url":"https://github.com/plone/plone.app.iterate","homepage":"","size":643,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"plone:2.1.x","ref":"2.1.x","sha":"0b6ae86c019f933256fba129675d414d87d9e76b","user":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"repo":{"id":2432580,"name":"plone.app.iterate","full_name":"plone/plone.app.iterate","owner":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plone/plone.app.iterate","description":"Checkin/ checkout procedure for content editing (working copy) for Plone","fork":false,"url":"https://api.github.com/repos/plone/plone.app.iterate","forks_url":"https://api.github.com/repos/plone/plone.app.iterate/forks","keys_url":"https://api.github.com/repos/plone/plone.app.iterate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plone/plone.app.iterate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plone/plone.app.iterate/teams","hooks_url":"https://api.github.com/repos/plone/plone.app.iterate/hooks","issue_events_url":"https://api.github.com/repos/plone/plone.app.iterate/issues/events{/number}","events_url":"https://api.github.com/repos/plone/plone.app.iterate/events","assignees_url":"https://api.github.com/repos/plone/plone.app.iterate/assignees{/user}","branches_url":"https://api.github.com/repos/plone/plone.app.iterate/branches{/branch}","tags_url":"https://api.github.com/repos/plone/plone.app.iterate/tags","blobs_url":"https://api.github.com/repos/plone/plone.app.iterate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plone/plone.app.iterate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plone/plone.app.iterate/git/refs{/sha}","trees_url":"https://api.github.com/repos/plone/plone.app.iterate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plone/plone.app.iterate/statuses/{sha}","languages_url":"https://api.github.com/repos/plone/plone.app.iterate/languages","stargazers_url":"https://api.github.com/repos/plone/plone.app.iterate/stargazers","contributors_url":"https://api.github.com/repos/plone/plone.app.iterate/contributors","subscribers_url":"https://api.github.com/repos/plone/plone.app.iterate/subscribers","subscription_url":"https://api.github.com/repos/plone/plone.app.iterate/subscription","commits_url":"https://api.github.com/repos/plone/plone.app.iterate/commits{/sha}","git_commits_url":"https://api.github.com/repos/plone/plone.app.iterate/git/commits{/sha}","comments_url":"https://api.github.com/repos/plone/plone.app.iterate/comments{/number}","issue_comment_url":"https://api.github.com/repos/plone/plone.app.iterate/issues/comments{/number}","contents_url":"https://api.github.com/repos/plone/plone.app.iterate/contents/{+path}","compare_url":"https://api.github.com/repos/plone/plone.app.iterate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plone/plone.app.iterate/merges","archive_url":"https://api.github.com/repos/plone/plone.app.iterate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plone/plone.app.iterate/downloads","issues_url":"https://api.github.com/repos/plone/plone.app.iterate/issues{/number}","pulls_url":"https://api.github.com/repos/plone/plone.app.iterate/pulls{/number}","milestones_url":"https://api.github.com/repos/plone/plone.app.iterate/milestones{/number}","notifications_url":"https://api.github.com/repos/plone/plone.app.iterate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plone/plone.app.iterate/labels{/name}","releases_url":"https://api.github.com/repos/plone/plone.app.iterate/releases{/id}","created_at":"2011-09-21T20:21:13Z","updated_at":"2015-03-12T14:28:48Z","pushed_at":"2015-11-13T19:30:21Z","git_url":"git://github.com/plone/plone.app.iterate.git","ssh_url":"git@github.com:plone/plone.app.iterate.git","clone_url":"https://github.com/plone/plone.app.iterate.git","svn_url":"https://github.com/plone/plone.app.iterate","homepage":"","size":643,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plone/plone.app.iterate/pulls/17"},"html":{"href":"https://github.com/plone/plone.app.iterate/pull/17"},"issue":{"href":"https://api.github.com/repos/plone/plone.app.iterate/issues/17"},"comments":{"href":"https://api.github.com/repos/plone/plone.app.iterate/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/plone/plone.app.iterate/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/plone/plone.app.iterate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plone/plone.app.iterate/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/plone/plone.app.iterate/statuses/66662998949806498619fff4dd244bba0cc1d25a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":33,"deletions":1,"changed_files":3}}