{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/ring-middleware/pulls/comments/34101425","id":34101425,"diff_hunk":"@@ -70,15 +76,11 @@\n                    :ssl-key  \"./dev-resources/config/jetty/ssl/private_keys/localhost.pem\"\n                    :ssl-ca-cert \"./dev-resources/config/jetty/ssl/certs/ca.pem\"})))\n \n-(def proxy-wrapped-app-no-redirect\n-  (-> proxy-error-handler\n-      (core/wrap-proxy \"/hello-proxy\" \"http://localhost:9000/hello\"\n-                  {:follow-redirects false})))\n-\n-(def proxy-wrapped-app-no-post-redirect\n+(def proxy-wrapped-app-post-redirect\n   (-> proxy-error-handler\n       (core/wrap-proxy \"/hello-proxy\" \"http://localhost:9000/hello\"\n-                  {:force-redirects false})))\n+                  {:force-redirects true\n+                   :follow-redirects true})))","path":"test/puppetlabs/ring_middleware/core_test.clj","position":28,"original_position":28,"commit_id":"7b0e3dd8363a166f3d331a3f7dd31bc65058efd1","original_commit_id":"7b0e3dd8363a166f3d331a3f7dd31bc65058efd1","user":{"login":"KevinCorcoran","id":2945462,"avatar_url":"https://avatars.githubusercontent.com/u/2945462?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinCorcoran","html_url":"https://github.com/KevinCorcoran","followers_url":"https://api.github.com/users/KevinCorcoran/followers","following_url":"https://api.github.com/users/KevinCorcoran/following{/other_user}","gists_url":"https://api.github.com/users/KevinCorcoran/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinCorcoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinCorcoran/subscriptions","organizations_url":"https://api.github.com/users/KevinCorcoran/orgs","repos_url":"https://api.github.com/users/KevinCorcoran/repos","events_url":"https://api.github.com/users/KevinCorcoran/events{/privacy}","received_events_url":"https://api.github.com/users/KevinCorcoran/received_events","type":"User","site_admin":false},"body":"This is identical to `proxy-wrapped-app-redirects`.","created_at":"2015-07-07T23:01:42Z","updated_at":"2015-07-07T23:01:42Z","html_url":"https://github.com/puppetlabs/ring-middleware/pull/25#discussion_r34101425","pull_request_url":"https://api.github.com/repos/puppetlabs/ring-middleware/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/ring-middleware/pulls/comments/34101425"},"html":{"href":"https://github.com/puppetlabs/ring-middleware/pull/25#discussion_r34101425"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/ring-middleware/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/ring-middleware/pulls/25","id":39297536,"html_url":"https://github.com/puppetlabs/ring-middleware/pull/25","diff_url":"https://github.com/puppetlabs/ring-middleware/pull/25.diff","patch_url":"https://github.com/puppetlabs/ring-middleware/pull/25.patch","issue_url":"https://api.github.com/repos/puppetlabs/ring-middleware/issues/25","number":25,"state":"open","locked":false,"title":"(TK-228) Change redirect default","user":{"login":"fpringvaldsen","id":5620801,"avatar_url":"https://avatars.githubusercontent.com/u/5620801?v=3","gravatar_id":"","url":"https://api.github.com/users/fpringvaldsen","html_url":"https://github.com/fpringvaldsen","followers_url":"https://api.github.com/users/fpringvaldsen/followers","following_url":"https://api.github.com/users/fpringvaldsen/following{/other_user}","gists_url":"https://api.github.com/users/fpringvaldsen/gists{/gist_id}","starred_url":"https://api.github.com/users/fpringvaldsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpringvaldsen/subscriptions","organizations_url":"https://api.github.com/users/fpringvaldsen/orgs","repos_url":"https://api.github.com/users/fpringvaldsen/repos","events_url":"https://api.github.com/users/fpringvaldsen/events{/privacy}","received_events_url":"https://api.github.com/users/fpringvaldsen/received_events","type":"User","site_admin":false},"body":"Previously, ring-middleware would follow all redirects by default\r\non the proxy-side when a proxy response was returned by whatever\r\nwas being proxied to. Change this so that by default the\r\nproxy will not follow redirects unless explicitly told to.","created_at":"2015-07-06T18:40:47Z","updated_at":"2015-07-07T23:01:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f4c6b1ca7b6857a510e6514e16e7304fde84cde","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/ring-middleware/pulls/25/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/ring-middleware/pulls/25/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/ring-middleware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/ring-middleware/issues/25/comments","statuses_url":"https://api.github.com/repos/puppetlabs/ring-middleware/statuses/7b0e3dd8363a166f3d331a3f7dd31bc65058efd1","head":{"label":"fpringvaldsen:bug/TK-228/redirects","ref":"bug/TK-228/redirects","sha":"7b0e3dd8363a166f3d331a3f7dd31bc65058efd1","user":{"login":"fpringvaldsen","id":5620801,"avatar_url":"https://avatars.githubusercontent.com/u/5620801?v=3","gravatar_id":"","url":"https://api.github.com/users/fpringvaldsen","html_url":"https://github.com/fpringvaldsen","followers_url":"https://api.github.com/users/fpringvaldsen/followers","following_url":"https://api.github.com/users/fpringvaldsen/following{/other_user}","gists_url":"https://api.github.com/users/fpringvaldsen/gists{/gist_id}","starred_url":"https://api.github.com/users/fpringvaldsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpringvaldsen/subscriptions","organizations_url":"https://api.github.com/users/fpringvaldsen/orgs","repos_url":"https://api.github.com/users/fpringvaldsen/repos","events_url":"https://api.github.com/users/fpringvaldsen/events{/privacy}","received_events_url":"https://api.github.com/users/fpringvaldsen/received_events","type":"User","site_admin":false},"repo":{"id":23204978,"name":"ring-middleware","full_name":"fpringvaldsen/ring-middleware","owner":{"login":"fpringvaldsen","id":5620801,"avatar_url":"https://avatars.githubusercontent.com/u/5620801?v=3","gravatar_id":"","url":"https://api.github.com/users/fpringvaldsen","html_url":"https://github.com/fpringvaldsen","followers_url":"https://api.github.com/users/fpringvaldsen/followers","following_url":"https://api.github.com/users/fpringvaldsen/following{/other_user}","gists_url":"https://api.github.com/users/fpringvaldsen/gists{/gist_id}","starred_url":"https://api.github.com/users/fpringvaldsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpringvaldsen/subscriptions","organizations_url":"https://api.github.com/users/fpringvaldsen/orgs","repos_url":"https://api.github.com/users/fpringvaldsen/repos","events_url":"https://api.github.com/users/fpringvaldsen/events{/privacy}","received_events_url":"https://api.github.com/users/fpringvaldsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fpringvaldsen/ring-middleware","description":"","fork":true,"url":"https://api.github.com/repos/fpringvaldsen/ring-middleware","forks_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/forks","keys_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/teams","hooks_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/hooks","issue_events_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/issues/events{/number}","events_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/events","assignees_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/assignees{/user}","branches_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/branches{/branch}","tags_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/tags","blobs_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/git/refs{/sha}","trees_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/statuses/{sha}","languages_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/languages","stargazers_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/stargazers","contributors_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/contributors","subscribers_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/subscribers","subscription_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/subscription","commits_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/commits{/sha}","git_commits_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/git/commits{/sha}","comments_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/comments{/number}","issue_comment_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/issues/comments{/number}","contents_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/contents/{+path}","compare_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/merges","archive_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/downloads","issues_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/issues{/number}","pulls_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/pulls{/number}","milestones_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/milestones{/number}","notifications_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/labels{/name}","releases_url":"https://api.github.com/repos/fpringvaldsen/ring-middleware/releases{/id}","created_at":"2014-08-21T22:24:39Z","updated_at":"2014-08-25T20:42:44Z","pushed_at":"2015-07-06T18:40:38Z","git_url":"git://github.com/fpringvaldsen/ring-middleware.git","ssh_url":"git@github.com:fpringvaldsen/ring-middleware.git","clone_url":"https://github.com/fpringvaldsen/ring-middleware.git","svn_url":"https://github.com/fpringvaldsen/ring-middleware","homepage":null,"size":314,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"cda0a9e5886bf7b673477f2c9b1d4317bf0f0801","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":23202876,"name":"ring-middleware","full_name":"puppetlabs/ring-middleware","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/ring-middleware","description":"","fork":false,"url":"https://api.github.com/repos/puppetlabs/ring-middleware","forks_url":"https://api.github.com/repos/puppetlabs/ring-middleware/forks","keys_url":"https://api.github.com/repos/puppetlabs/ring-middleware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/ring-middleware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/ring-middleware/teams","hooks_url":"https://api.github.com/repos/puppetlabs/ring-middleware/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/ring-middleware/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/ring-middleware/events","assignees_url":"https://api.github.com/repos/puppetlabs/ring-middleware/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/ring-middleware/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/ring-middleware/tags","blobs_url":"https://api.github.com/repos/puppetlabs/ring-middleware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/ring-middleware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/ring-middleware/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/ring-middleware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/ring-middleware/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/ring-middleware/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/ring-middleware/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/ring-middleware/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/ring-middleware/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/ring-middleware/subscription","commits_url":"https://api.github.com/repos/puppetlabs/ring-middleware/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/ring-middleware/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/ring-middleware/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/ring-middleware/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/ring-middleware/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/ring-middleware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/ring-middleware/merges","archive_url":"https://api.github.com/repos/puppetlabs/ring-middleware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/ring-middleware/downloads","issues_url":"https://api.github.com/repos/puppetlabs/ring-middleware/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/ring-middleware/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/ring-middleware/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/ring-middleware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/ring-middleware/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/ring-middleware/releases{/id}","created_at":"2014-08-21T21:00:08Z","updated_at":"2015-03-16T21:38:44Z","pushed_at":"2015-07-06T18:40:47Z","git_url":"git://github.com/puppetlabs/ring-middleware.git","ssh_url":"git@github.com:puppetlabs/ring-middleware.git","clone_url":"https://github.com/puppetlabs/ring-middleware.git","svn_url":"https://github.com/puppetlabs/ring-middleware","homepage":null,"size":370,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":1,"forks":12,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/ring-middleware/pulls/25"},"html":{"href":"https://github.com/puppetlabs/ring-middleware/pull/25"},"issue":{"href":"https://api.github.com/repos/puppetlabs/ring-middleware/issues/25"},"comments":{"href":"https://api.github.com/repos/puppetlabs/ring-middleware/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/ring-middleware/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/ring-middleware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/ring-middleware/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/ring-middleware/statuses/7b0e3dd8363a166f3d331a3f7dd31bc65058efd1"}}}}