{"action":"created","comment":{"url":"https://api.github.com/repos/socrata/balboa/pulls/comments/26766785","id":26766785,"diff_hunk":"@@ -0,0 +1,71 @@\n+package com.socrata.metrics.producer\n+\n+import java.util.Properties\n+import com.socrata.balboa.common.kafka.Constants\n+import com.socrata.balboa.common.kafka.util.AddressAndPort\n+import kafka.producer.{KeyedMessage, Producer, ProducerConfig}\n+import kafka.serializer.Encoder\n+\n+/**\n+ * A wrapper around Kafka [[Producer]].  This Producer is restricted to exactly one Kafka Topic.  This\n+ * producers responsibility is to provide many of the default properties for Kafka [[Producer]].  To see the\n+ * current default settings reference [[Constants.producerDefaultProps]].  You can override any of the default\n+ * properties with passing in your own properties.\n+ *\n+ * @param topic Kafka topic to produce to.\n+ * @param brokers Kafka Broker metadata list.\n+ * @param properties Producer properties.\n+ * @tparam K Kafka \"Key\" type\n+ * @tparam M Kafka \"Message\" type\n+ * @tparam KE Encoder for K. Must have a constructor argument signature of `properties: VerifiableProperties = null`\n+ * @tparam ME Encoder for M. Must have a constructor argument signature of `properties: VerifiableProperties = null`\n+ */\n+class GenericKafkaProducer[K,M,KE <: Encoder[K]: Manifest,ME <: Encoder[M]: Manifest](topic: String,\n+                                                                                      brokers: List[AddressAndPort] = List.empty,","path":"balboa-client-kafka/src/main/scala/com/socrata/metrics/producer/GenericKafkaProducer.scala","position":24,"original_position":24,"commit_id":"f1dba6f24ed4f554f46ae2a0a334bc7630b8fdbb","original_commit_id":"f1dba6f24ed4f554f46ae2a0a334bc7630b8fdbb","user":{"login":"jkew","id":723652,"avatar_url":"https://avatars.githubusercontent.com/u/723652?v=3","gravatar_id":"","url":"https://api.github.com/users/jkew","html_url":"https://github.com/jkew","followers_url":"https://api.github.com/users/jkew/followers","following_url":"https://api.github.com/users/jkew/following{/other_user}","gists_url":"https://api.github.com/users/jkew/gists{/gist_id}","starred_url":"https://api.github.com/users/jkew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkew/subscriptions","organizations_url":"https://api.github.com/users/jkew/orgs","repos_url":"https://api.github.com/users/jkew/repos","events_url":"https://api.github.com/users/jkew/events{/privacy}","received_events_url":"https://api.github.com/users/jkew/received_events","type":"User","site_admin":false},"body":"producers take lists of brokers; consumers connect to zk. I would choose one way or other.","created_at":"2015-03-19T15:48:02Z","updated_at":"2015-03-19T15:48:02Z","html_url":"https://github.com/socrata/balboa/pull/4#discussion_r26766785","pull_request_url":"https://api.github.com/repos/socrata/balboa/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/socrata/balboa/pulls/comments/26766785"},"html":{"href":"https://github.com/socrata/balboa/pull/4#discussion_r26766785"},"pull_request":{"href":"https://api.github.com/repos/socrata/balboa/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/socrata/balboa/pulls/4","id":31256219,"html_url":"https://github.com/socrata/balboa/pull/4","diff_url":"https://github.com/socrata/balboa/pull/4.diff","patch_url":"https://github.com/socrata/balboa/pull/4.patch","issue_url":"https://api.github.com/repos/socrata/balboa/issues/4","number":4,"state":"open","locked":false,"title":"Balboa Kafka Client and Kafka Service updates","user":{"login":"mhotan-s","id":10618614,"avatar_url":"https://avatars.githubusercontent.com/u/10618614?v=3","gravatar_id":"","url":"https://api.github.com/users/mhotan-s","html_url":"https://github.com/mhotan-s","followers_url":"https://api.github.com/users/mhotan-s/followers","following_url":"https://api.github.com/users/mhotan-s/following{/other_user}","gists_url":"https://api.github.com/users/mhotan-s/gists{/gist_id}","starred_url":"https://api.github.com/users/mhotan-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhotan-s/subscriptions","organizations_url":"https://api.github.com/users/mhotan-s/orgs","repos_url":"https://api.github.com/users/mhotan-s/repos","events_url":"https://api.github.com/users/mhotan-s/events{/privacy}","received_events_url":"https://api.github.com/users/mhotan-s/received_events","type":"User","site_admin":false},"body":"- Refactor of core client libraries.\r\n- Updated SBT and Scala versions.\r\n- Created MetricLoggerToKafka and related components.  This included a slight modification to the core library.  Specifically had MetricLoggerComponent's MetricLogger producer method have a declared returned type of MetricLoggerLike instead of MetricLogger.\r\n- Created KafkaTestHarness and implemented Balboa Kafka tests.  Its the current best we can do with out full dynamic cloud environment creation.  \r\n\r\nTODO: Balboa is getting large enough to where we need to refactor the documentation to clearly identify the Core, Common, HTTP, Client, Service structure. ","created_at":"2015-03-16T15:54:31Z","updated_at":"2015-03-19T15:48:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8895218c55cb875b34ee3f72a2a900ec019fbe50","assignee":{"login":"jkew","id":723652,"avatar_url":"https://avatars.githubusercontent.com/u/723652?v=3","gravatar_id":"","url":"https://api.github.com/users/jkew","html_url":"https://github.com/jkew","followers_url":"https://api.github.com/users/jkew/followers","following_url":"https://api.github.com/users/jkew/following{/other_user}","gists_url":"https://api.github.com/users/jkew/gists{/gist_id}","starred_url":"https://api.github.com/users/jkew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkew/subscriptions","organizations_url":"https://api.github.com/users/jkew/orgs","repos_url":"https://api.github.com/users/jkew/repos","events_url":"https://api.github.com/users/jkew/events{/privacy}","received_events_url":"https://api.github.com/users/jkew/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/socrata/balboa/pulls/4/commits","review_comments_url":"https://api.github.com/repos/socrata/balboa/pulls/4/comments","review_comment_url":"https://api.github.com/repos/socrata/balboa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/socrata/balboa/issues/4/comments","statuses_url":"https://api.github.com/repos/socrata/balboa/statuses/f1dba6f24ed4f554f46ae2a0a334bc7630b8fdbb","head":{"label":"socrata:feature/balboa-kafka-wip","ref":"feature/balboa-kafka-wip","sha":"f1dba6f24ed4f554f46ae2a0a334bc7630b8fdbb","user":{"login":"socrata","id":57695,"avatar_url":"https://avatars.githubusercontent.com/u/57695?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata","html_url":"https://github.com/socrata","followers_url":"https://api.github.com/users/socrata/followers","following_url":"https://api.github.com/users/socrata/following{/other_user}","gists_url":"https://api.github.com/users/socrata/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata/subscriptions","organizations_url":"https://api.github.com/users/socrata/orgs","repos_url":"https://api.github.com/users/socrata/repos","events_url":"https://api.github.com/users/socrata/events{/privacy}","received_events_url":"https://api.github.com/users/socrata/received_events","type":"Organization","site_admin":false},"repo":{"id":22198167,"name":"balboa","full_name":"socrata/balboa","owner":{"login":"socrata","id":57695,"avatar_url":"https://avatars.githubusercontent.com/u/57695?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata","html_url":"https://github.com/socrata","followers_url":"https://api.github.com/users/socrata/followers","following_url":"https://api.github.com/users/socrata/following{/other_user}","gists_url":"https://api.github.com/users/socrata/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata/subscriptions","organizations_url":"https://api.github.com/users/socrata/orgs","repos_url":"https://api.github.com/users/socrata/repos","events_url":"https://api.github.com/users/socrata/events{/privacy}","received_events_url":"https://api.github.com/users/socrata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socrata/balboa","description":"Socrata's internal metrics service","fork":false,"url":"https://api.github.com/repos/socrata/balboa","forks_url":"https://api.github.com/repos/socrata/balboa/forks","keys_url":"https://api.github.com/repos/socrata/balboa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socrata/balboa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socrata/balboa/teams","hooks_url":"https://api.github.com/repos/socrata/balboa/hooks","issue_events_url":"https://api.github.com/repos/socrata/balboa/issues/events{/number}","events_url":"https://api.github.com/repos/socrata/balboa/events","assignees_url":"https://api.github.com/repos/socrata/balboa/assignees{/user}","branches_url":"https://api.github.com/repos/socrata/balboa/branches{/branch}","tags_url":"https://api.github.com/repos/socrata/balboa/tags","blobs_url":"https://api.github.com/repos/socrata/balboa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socrata/balboa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socrata/balboa/git/refs{/sha}","trees_url":"https://api.github.com/repos/socrata/balboa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socrata/balboa/statuses/{sha}","languages_url":"https://api.github.com/repos/socrata/balboa/languages","stargazers_url":"https://api.github.com/repos/socrata/balboa/stargazers","contributors_url":"https://api.github.com/repos/socrata/balboa/contributors","subscribers_url":"https://api.github.com/repos/socrata/balboa/subscribers","subscription_url":"https://api.github.com/repos/socrata/balboa/subscription","commits_url":"https://api.github.com/repos/socrata/balboa/commits{/sha}","git_commits_url":"https://api.github.com/repos/socrata/balboa/git/commits{/sha}","comments_url":"https://api.github.com/repos/socrata/balboa/comments{/number}","issue_comment_url":"https://api.github.com/repos/socrata/balboa/issues/comments{/number}","contents_url":"https://api.github.com/repos/socrata/balboa/contents/{+path}","compare_url":"https://api.github.com/repos/socrata/balboa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socrata/balboa/merges","archive_url":"https://api.github.com/repos/socrata/balboa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socrata/balboa/downloads","issues_url":"https://api.github.com/repos/socrata/balboa/issues{/number}","pulls_url":"https://api.github.com/repos/socrata/balboa/pulls{/number}","milestones_url":"https://api.github.com/repos/socrata/balboa/milestones{/number}","notifications_url":"https://api.github.com/repos/socrata/balboa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socrata/balboa/labels{/name}","releases_url":"https://api.github.com/repos/socrata/balboa/releases{/id}","created_at":"2014-07-24T03:54:29Z","updated_at":"2015-02-27T02:11:51Z","pushed_at":"2015-03-19T02:01:48Z","git_url":"git://github.com/socrata/balboa.git","ssh_url":"git@github.com:socrata/balboa.git","clone_url":"https://github.com/socrata/balboa.git","svn_url":"https://github.com/socrata/balboa","homepage":null,"size":29187,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"socrata:master","ref":"master","sha":"9e020f8e082aa2d6d15612b28fec9791c91a3faa","user":{"login":"socrata","id":57695,"avatar_url":"https://avatars.githubusercontent.com/u/57695?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata","html_url":"https://github.com/socrata","followers_url":"https://api.github.com/users/socrata/followers","following_url":"https://api.github.com/users/socrata/following{/other_user}","gists_url":"https://api.github.com/users/socrata/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata/subscriptions","organizations_url":"https://api.github.com/users/socrata/orgs","repos_url":"https://api.github.com/users/socrata/repos","events_url":"https://api.github.com/users/socrata/events{/privacy}","received_events_url":"https://api.github.com/users/socrata/received_events","type":"Organization","site_admin":false},"repo":{"id":22198167,"name":"balboa","full_name":"socrata/balboa","owner":{"login":"socrata","id":57695,"avatar_url":"https://avatars.githubusercontent.com/u/57695?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata","html_url":"https://github.com/socrata","followers_url":"https://api.github.com/users/socrata/followers","following_url":"https://api.github.com/users/socrata/following{/other_user}","gists_url":"https://api.github.com/users/socrata/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata/subscriptions","organizations_url":"https://api.github.com/users/socrata/orgs","repos_url":"https://api.github.com/users/socrata/repos","events_url":"https://api.github.com/users/socrata/events{/privacy}","received_events_url":"https://api.github.com/users/socrata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socrata/balboa","description":"Socrata's internal metrics service","fork":false,"url":"https://api.github.com/repos/socrata/balboa","forks_url":"https://api.github.com/repos/socrata/balboa/forks","keys_url":"https://api.github.com/repos/socrata/balboa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socrata/balboa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socrata/balboa/teams","hooks_url":"https://api.github.com/repos/socrata/balboa/hooks","issue_events_url":"https://api.github.com/repos/socrata/balboa/issues/events{/number}","events_url":"https://api.github.com/repos/socrata/balboa/events","assignees_url":"https://api.github.com/repos/socrata/balboa/assignees{/user}","branches_url":"https://api.github.com/repos/socrata/balboa/branches{/branch}","tags_url":"https://api.github.com/repos/socrata/balboa/tags","blobs_url":"https://api.github.com/repos/socrata/balboa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socrata/balboa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socrata/balboa/git/refs{/sha}","trees_url":"https://api.github.com/repos/socrata/balboa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socrata/balboa/statuses/{sha}","languages_url":"https://api.github.com/repos/socrata/balboa/languages","stargazers_url":"https://api.github.com/repos/socrata/balboa/stargazers","contributors_url":"https://api.github.com/repos/socrata/balboa/contributors","subscribers_url":"https://api.github.com/repos/socrata/balboa/subscribers","subscription_url":"https://api.github.com/repos/socrata/balboa/subscription","commits_url":"https://api.github.com/repos/socrata/balboa/commits{/sha}","git_commits_url":"https://api.github.com/repos/socrata/balboa/git/commits{/sha}","comments_url":"https://api.github.com/repos/socrata/balboa/comments{/number}","issue_comment_url":"https://api.github.com/repos/socrata/balboa/issues/comments{/number}","contents_url":"https://api.github.com/repos/socrata/balboa/contents/{+path}","compare_url":"https://api.github.com/repos/socrata/balboa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socrata/balboa/merges","archive_url":"https://api.github.com/repos/socrata/balboa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socrata/balboa/downloads","issues_url":"https://api.github.com/repos/socrata/balboa/issues{/number}","pulls_url":"https://api.github.com/repos/socrata/balboa/pulls{/number}","milestones_url":"https://api.github.com/repos/socrata/balboa/milestones{/number}","notifications_url":"https://api.github.com/repos/socrata/balboa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socrata/balboa/labels{/name}","releases_url":"https://api.github.com/repos/socrata/balboa/releases{/id}","created_at":"2014-07-24T03:54:29Z","updated_at":"2015-02-27T02:11:51Z","pushed_at":"2015-03-19T02:01:48Z","git_url":"git://github.com/socrata/balboa.git","ssh_url":"git@github.com:socrata/balboa.git","clone_url":"https://github.com/socrata/balboa.git","svn_url":"https://github.com/socrata/balboa","homepage":null,"size":29187,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/socrata/balboa/pulls/4"},"html":{"href":"https://github.com/socrata/balboa/pull/4"},"issue":{"href":"https://api.github.com/repos/socrata/balboa/issues/4"},"comments":{"href":"https://api.github.com/repos/socrata/balboa/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/socrata/balboa/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/socrata/balboa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/socrata/balboa/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/socrata/balboa/statuses/f1dba6f24ed4f554f46ae2a0a334bc7630b8fdbb"}}}}