{"action":"created","issue":{"url":"https://api.github.com/repos/spark/spark-setup-ios/issues/11","labels_url":"https://api.github.com/repos/spark/spark-setup-ios/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/spark/spark-setup-ios/issues/11/comments","events_url":"https://api.github.com/repos/spark/spark-setup-ios/issues/11/events","html_url":"https://github.com/spark/spark-setup-ios/issues/11","id":67415958,"number":11,"title":"UI improvements","user":{"login":"idokleinman","id":6490062,"avatar_url":"https://avatars.githubusercontent.com/u/6490062?v=3","gravatar_id":"","url":"https://api.github.com/users/idokleinman","html_url":"https://github.com/idokleinman","followers_url":"https://api.github.com/users/idokleinman/followers","following_url":"https://api.github.com/users/idokleinman/following{/other_user}","gists_url":"https://api.github.com/users/idokleinman/gists{/gist_id}","starred_url":"https://api.github.com/users/idokleinman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idokleinman/subscriptions","organizations_url":"https://api.github.com/users/idokleinman/orgs","repos_url":"https://api.github.com/users/idokleinman/repos","events_url":"https://api.github.com/users/idokleinman/events{/privacy}","received_events_url":"https://api.github.com/users/idokleinman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/spark/spark-setup-ios/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"idokleinman","id":6490062,"avatar_url":"https://avatars.githubusercontent.com/u/6490062?v=3","gravatar_id":"","url":"https://api.github.com/users/idokleinman","html_url":"https://github.com/idokleinman","followers_url":"https://api.github.com/users/idokleinman/followers","following_url":"https://api.github.com/users/idokleinman/following{/other_user}","gists_url":"https://api.github.com/users/idokleinman/gists{/gist_id}","starred_url":"https://api.github.com/users/idokleinman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idokleinman/subscriptions","organizations_url":"https://api.github.com/users/idokleinman/orgs","repos_url":"https://api.github.com/users/idokleinman/repos","events_url":"https://api.github.com/users/idokleinman/events{/privacy}","received_events_url":"https://api.github.com/users/idokleinman/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2015-04-09T17:51:29Z","updated_at":"2015-04-09T17:51:32Z","closed_at":null,"body":"_From @zsup on January 14, 2015 9:8_\n\nJust did a comprehensive review of the app to pull together a list of UI tweaks. Overall I'd say we're about 75% there; it needs a bunch of clean-up and polish, but the structure's there.\r\n\r\nThere are a few places where this diverges significantly from the spec (entire views are missing and replaced with pop ups), and I think what's done here is more confusing and more difficult to use. I'd like to see a flow that is more like what's described in the \"Spark Mobile SDK Views\" Google Doc.\r\n\r\nOverall I saw a few patterns that should be fixed throughout the app:\r\n- In general we want more whitespace to make the whole thing feel simpler and easier to follow\r\n- Elements should be better centered, both horizontally and vertically\r\n- Text should be a little bigger so it's more readable, and should use the custom font throughout\r\n- We should avoid jargony terms like \"SSID\" that most people don't know, and instead use English. We should also use full sentences with punctuation rather than shorthand, which feels unprofessional to me. Tell a story instead of giving a list!\r\n\r\nHere are a bunch of specific fixes:\r\n\r\nFlash screen\r\n- [x] Should this exist?\r\n- [x] Button at the bottom should be ~10px taller\r\n- [x] Text in the button is not properly vertically centered\r\n- [x] Version number in the bottom corner should use the custom font\r\n- [x] The button should be 10% darkened when tapped\r\n\r\nCreate account\r\n- [x] Increase spacing both above and below the logo in the top section (but a bit more above)\r\n- [x] \"Create {company} account\" should also bolded like a header\r\n- [x] Text boxes should be vertically centered on the screen\r\n- [x] When I type in the text boxes, the text is aligned all the way to the left; it should be spaced out better (like the placeholder text is)\r\n- [x] I already have an account should be underlined but not bolded; will help it look like a link\r\n- [x] Text at the bottom should be aligned to the bottom of the screen\r\n- [x] All text should be in the custom font\r\n- [x] The button should be 10% darkened when tapped\r\n- [x] Clicking away from the text boxes should make the keyboard go away\r\n\r\nLogin\r\n- [x] \"Login\" should be bolded like a header and spaced like a header (closer to the top)\r\n- [x] Same general spacing and formatting changes from the previous screen\r\n- [x] After I hit 'Log in' the 'create account' view pops up for just a moment\r\n- [x] All text should be in the custom font\r\n\r\nGet Ready\r\n- [x] Where is this page? Need to add it. There should be instructions for preparing the hardware before the user gets to the instructions they need to follow on the phone.\r\n\r\nSet up instructions\r\n- [x] This page has diverged a lot from the spec, which was a lot simpler. This page is confusing. We need to eliminate content and make this more visual.\r\n- [x] Device icon should be spaced further from the topic\r\n- [x] This view has too much content on it, and so it's confusing. All of the 'troubleshooting' content should move on to the previous 'Get Ready' page, so this page should just be instructions (which should then be larger and more spaced out, whitespace please!)\r\n\r\n- [x] Take off the spinner, which is confusing here (because it makes the user think they should be just sitting around waiting for something to happen)\r\n- [ ] The 'log out' and 'cancel' buttons at the bottom in the same color are a bit confusing. can we make them two different colors?\r\n- [x] All text should be in the custom font\r\n- [x] In general, please revert the design of this page to better align with the spec: https://docs.google.com/a/spark.io/presentation/d/1WrIhPIoY2keRxlKurJDsF02_dAq8w5Zys0URCHsTwPE/edit#slide=id.g5539d65f3_017\r\n\r\nSelect network\r\n- [x] More whitespace around everything. Make the scrolling box smaller in exchange for more space around all of the elements.\r\n- [x] Heading at the beginning should be a larger font\r\n- [x] All text should be in the custom font\r\n- [x] Icons aren't rendering cleanly (they're jagged, not smooth curves)\r\n- [x] Sort networks alphabetically. I think. actually I'd love feedback on this, I find the current order confusing, and my Mac laptop sorts networks alphabetically, which feels like it makes sense to me\r\n- [ ] Multiple networks with the same SSID should be eliminated. You should only see one of each\r\n- [x] The scrolling box needs something around it to show that it's scrollable; a border or a background or something to separate it from the rest of the screen\r\n- [x] Button text should be bolded\r\n- [x] \"Manual SSID\" should instead say \"Type network name manually\"\r\n- [ ] Also, \"Manual SSID\" should actually do something :-)\r\n- [x] Scrolling box should be horizontally centered (it's too far to the right)\r\n\r\nConnect to Network\r\n- [x] Doesn't exist at all, instead replaced by a pop-up. I don't like the pop-up because it doesn't provide us the option to make the Wi-Fi password unobscured (which will reduce fat finger issues). Let's make this its own view.\r\n\r\nConnecting\r\n- [x] More whitespace around the whole top section\r\n- [x] Add punctuation to the top section (connecting to: and \"This can take about a minute.\")\r\n- [x] There shouldn't be a separate background on the checkboxes section, and the horizontal lines also feel like they're spaced wrong and shouldn't exist at all\r\n- [ ] Spinners should be smaller so they're not bigger than the check marks\r\n- [x] Error message for a failed connection should be in English. \"Claiming\" a device does not mean anything to the end user. In fact the error message shouldn't exist at all, and should be replaced by the view below.\r\n\r\nConnection Failed\r\n- [x] Where is this view? Replaced with an error message, which is too brief and confusing. Please build out the view instead.\r\n\r\nSuccess\r\n- [x] Unfortunately never saw it! Got an error message instead. Looking forward to seeing it though :-)\n\n_Copied from original issue: spark/mobile-sdk-ios#39_"},"comment":{"url":"https://api.github.com/repos/spark/spark-setup-ios/issues/comments/91308660","html_url":"https://github.com/spark/spark-setup-ios/issues/11#issuecomment-91308660","issue_url":"https://api.github.com/repos/spark/spark-setup-ios/issues/11","id":91308660,"user":{"login":"idokleinman","id":6490062,"avatar_url":"https://avatars.githubusercontent.com/u/6490062?v=3","gravatar_id":"","url":"https://api.github.com/users/idokleinman","html_url":"https://github.com/idokleinman","followers_url":"https://api.github.com/users/idokleinman/followers","following_url":"https://api.github.com/users/idokleinman/following{/other_user}","gists_url":"https://api.github.com/users/idokleinman/gists{/gist_id}","starred_url":"https://api.github.com/users/idokleinman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idokleinman/subscriptions","organizations_url":"https://api.github.com/users/idokleinman/orgs","repos_url":"https://api.github.com/users/idokleinman/repos","events_url":"https://api.github.com/users/idokleinman/events{/privacy}","received_events_url":"https://api.github.com/users/idokleinman/received_events","type":"User","site_admin":false},"created_at":"2015-04-09T17:51:32Z","updated_at":"2015-04-09T17:51:32Z","body":"We should discuss the two possible failures - both give suboptimal user experience -  \r\n1. device should not be owned - app do not know if the device connected to the cloud or failed because it cannot poll the device list for the user (it wouldn't appear there anyway)\r\n2. device *should* be owned by user - polling device list timeouts - now is the problem bad wifi credentials? or is the problem error in claiming process? how do you suggest user to solve it? (iphone no longer on soft AP wifi and probably can't connect to it either because device already switch to internet wifi and not broadcasting its SSID)"}}