{"action":"opened","number":687,"pull_request":{"url":"https://api.github.com/repos/wocommunity/wonder/pulls/687","id":46849352,"html_url":"https://github.com/wocommunity/wonder/pull/687","diff_url":"https://github.com/wocommunity/wonder/pull/687.diff","patch_url":"https://github.com/wocommunity/wonder/pull/687.patch","issue_url":"https://api.github.com/repos/wocommunity/wonder/issues/687","number":687,"state":"open","locked":false,"title":"Move ERJavaMail framework and re-factor ERCMail out of the business logic framework.","user":{"login":"rkiddy","id":691368,"avatar_url":"https://avatars.githubusercontent.com/u/691368?v=3","gravatar_id":"","url":"https://api.github.com/users/rkiddy","html_url":"https://github.com/rkiddy","followers_url":"https://api.github.com/users/rkiddy/followers","following_url":"https://api.github.com/users/rkiddy/following{/other_user}","gists_url":"https://api.github.com/users/rkiddy/gists{/gist_id}","starred_url":"https://api.github.com/users/rkiddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkiddy/subscriptions","organizations_url":"https://api.github.com/users/rkiddy/orgs","repos_url":"https://api.github.com/users/rkiddy/repos","events_url":"https://api.github.com/users/rkiddy/events{/privacy}","received_events_url":"https://api.github.com/users/rkiddy/received_events","type":"User","site_admin":false},"body":"Some questions and to-dos in re this change.\r\n\r\n1. The ERJavaMail move should be low-impact, yes?\r\n2. Re-factoring the ERCMail code out of the business logic frameworks means that people will have to fix their imports, I think. Anything else?\r\n3. ToDo: There is no pom.xml file in the ERCMail framework\r\n4. ToDo: It would be nice to have test code.\r\n5. Can the ERCMail code in the business logic framework be removed, or does it need to be deprecated first?\r\n6. Both ERCMail and ERJavaMail can use some java-8-ish love.\r\n7. Are both of these current enough to move? Were either of them heading to the Archives?\r\n","created_at":"2015-10-06T00:04:35Z","updated_at":"2015-10-06T00:04:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wocommunity/wonder/pulls/687/commits","review_comments_url":"https://api.github.com/repos/wocommunity/wonder/pulls/687/comments","review_comment_url":"https://api.github.com/repos/wocommunity/wonder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wocommunity/wonder/issues/687/comments","statuses_url":"https://api.github.com/repos/wocommunity/wonder/statuses/fe953bf8a16f6af3ebd42065a576ec3846b6f80e","head":{"label":"rkiddy:master","ref":"master","sha":"fe953bf8a16f6af3ebd42065a576ec3846b6f80e","user":{"login":"rkiddy","id":691368,"avatar_url":"https://avatars.githubusercontent.com/u/691368?v=3","gravatar_id":"","url":"https://api.github.com/users/rkiddy","html_url":"https://github.com/rkiddy","followers_url":"https://api.github.com/users/rkiddy/followers","following_url":"https://api.github.com/users/rkiddy/following{/other_user}","gists_url":"https://api.github.com/users/rkiddy/gists{/gist_id}","starred_url":"https://api.github.com/users/rkiddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkiddy/subscriptions","organizations_url":"https://api.github.com/users/rkiddy/orgs","repos_url":"https://api.github.com/users/rkiddy/repos","events_url":"https://api.github.com/users/rkiddy/events{/privacy}","received_events_url":"https://api.github.com/users/rkiddy/received_events","type":"User","site_admin":false},"repo":{"id":43718743,"name":"wonder","full_name":"rkiddy/wonder","owner":{"login":"rkiddy","id":691368,"avatar_url":"https://avatars.githubusercontent.com/u/691368?v=3","gravatar_id":"","url":"https://api.github.com/users/rkiddy","html_url":"https://github.com/rkiddy","followers_url":"https://api.github.com/users/rkiddy/followers","following_url":"https://api.github.com/users/rkiddy/following{/other_user}","gists_url":"https://api.github.com/users/rkiddy/gists{/gist_id}","starred_url":"https://api.github.com/users/rkiddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkiddy/subscriptions","organizations_url":"https://api.github.com/users/rkiddy/orgs","repos_url":"https://api.github.com/users/rkiddy/repos","events_url":"https://api.github.com/users/rkiddy/events{/privacy}","received_events_url":"https://api.github.com/users/rkiddy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rkiddy/wonder","description":"Project Wonder","fork":true,"url":"https://api.github.com/repos/rkiddy/wonder","forks_url":"https://api.github.com/repos/rkiddy/wonder/forks","keys_url":"https://api.github.com/repos/rkiddy/wonder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rkiddy/wonder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rkiddy/wonder/teams","hooks_url":"https://api.github.com/repos/rkiddy/wonder/hooks","issue_events_url":"https://api.github.com/repos/rkiddy/wonder/issues/events{/number}","events_url":"https://api.github.com/repos/rkiddy/wonder/events","assignees_url":"https://api.github.com/repos/rkiddy/wonder/assignees{/user}","branches_url":"https://api.github.com/repos/rkiddy/wonder/branches{/branch}","tags_url":"https://api.github.com/repos/rkiddy/wonder/tags","blobs_url":"https://api.github.com/repos/rkiddy/wonder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rkiddy/wonder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rkiddy/wonder/git/refs{/sha}","trees_url":"https://api.github.com/repos/rkiddy/wonder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rkiddy/wonder/statuses/{sha}","languages_url":"https://api.github.com/repos/rkiddy/wonder/languages","stargazers_url":"https://api.github.com/repos/rkiddy/wonder/stargazers","contributors_url":"https://api.github.com/repos/rkiddy/wonder/contributors","subscribers_url":"https://api.github.com/repos/rkiddy/wonder/subscribers","subscription_url":"https://api.github.com/repos/rkiddy/wonder/subscription","commits_url":"https://api.github.com/repos/rkiddy/wonder/commits{/sha}","git_commits_url":"https://api.github.com/repos/rkiddy/wonder/git/commits{/sha}","comments_url":"https://api.github.com/repos/rkiddy/wonder/comments{/number}","issue_comment_url":"https://api.github.com/repos/rkiddy/wonder/issues/comments{/number}","contents_url":"https://api.github.com/repos/rkiddy/wonder/contents/{+path}","compare_url":"https://api.github.com/repos/rkiddy/wonder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rkiddy/wonder/merges","archive_url":"https://api.github.com/repos/rkiddy/wonder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rkiddy/wonder/downloads","issues_url":"https://api.github.com/repos/rkiddy/wonder/issues{/number}","pulls_url":"https://api.github.com/repos/rkiddy/wonder/pulls{/number}","milestones_url":"https://api.github.com/repos/rkiddy/wonder/milestones{/number}","notifications_url":"https://api.github.com/repos/rkiddy/wonder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rkiddy/wonder/labels{/name}","releases_url":"https://api.github.com/repos/rkiddy/wonder/releases{/id}","created_at":"2015-10-05T23:02:00Z","updated_at":"2015-10-05T23:02:29Z","pushed_at":"2015-10-05T23:57:18Z","git_url":"git://github.com/rkiddy/wonder.git","ssh_url":"git@github.com:rkiddy/wonder.git","clone_url":"https://github.com/rkiddy/wonder.git","svn_url":"https://github.com/rkiddy/wonder","homepage":"http://wiki.wocommunity.org/","size":337792,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wocommunity:master","ref":"master","sha":"c9eb74022bdfff9baa52e4438a87f65b18186acc","user":{"login":"wocommunity","id":690954,"avatar_url":"https://avatars.githubusercontent.com/u/690954?v=3","gravatar_id":"","url":"https://api.github.com/users/wocommunity","html_url":"https://github.com/wocommunity","followers_url":"https://api.github.com/users/wocommunity/followers","following_url":"https://api.github.com/users/wocommunity/following{/other_user}","gists_url":"https://api.github.com/users/wocommunity/gists{/gist_id}","starred_url":"https://api.github.com/users/wocommunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wocommunity/subscriptions","organizations_url":"https://api.github.com/users/wocommunity/orgs","repos_url":"https://api.github.com/users/wocommunity/repos","events_url":"https://api.github.com/users/wocommunity/events{/privacy}","received_events_url":"https://api.github.com/users/wocommunity/received_events","type":"Organization","site_admin":false},"repo":{"id":1520916,"name":"wonder","full_name":"wocommunity/wonder","owner":{"login":"wocommunity","id":690954,"avatar_url":"https://avatars.githubusercontent.com/u/690954?v=3","gravatar_id":"","url":"https://api.github.com/users/wocommunity","html_url":"https://github.com/wocommunity","followers_url":"https://api.github.com/users/wocommunity/followers","following_url":"https://api.github.com/users/wocommunity/following{/other_user}","gists_url":"https://api.github.com/users/wocommunity/gists{/gist_id}","starred_url":"https://api.github.com/users/wocommunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wocommunity/subscriptions","organizations_url":"https://api.github.com/users/wocommunity/orgs","repos_url":"https://api.github.com/users/wocommunity/repos","events_url":"https://api.github.com/users/wocommunity/events{/privacy}","received_events_url":"https://api.github.com/users/wocommunity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wocommunity/wonder","description":"Project Wonder","fork":false,"url":"https://api.github.com/repos/wocommunity/wonder","forks_url":"https://api.github.com/repos/wocommunity/wonder/forks","keys_url":"https://api.github.com/repos/wocommunity/wonder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wocommunity/wonder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wocommunity/wonder/teams","hooks_url":"https://api.github.com/repos/wocommunity/wonder/hooks","issue_events_url":"https://api.github.com/repos/wocommunity/wonder/issues/events{/number}","events_url":"https://api.github.com/repos/wocommunity/wonder/events","assignees_url":"https://api.github.com/repos/wocommunity/wonder/assignees{/user}","branches_url":"https://api.github.com/repos/wocommunity/wonder/branches{/branch}","tags_url":"https://api.github.com/repos/wocommunity/wonder/tags","blobs_url":"https://api.github.com/repos/wocommunity/wonder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wocommunity/wonder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wocommunity/wonder/git/refs{/sha}","trees_url":"https://api.github.com/repos/wocommunity/wonder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wocommunity/wonder/statuses/{sha}","languages_url":"https://api.github.com/repos/wocommunity/wonder/languages","stargazers_url":"https://api.github.com/repos/wocommunity/wonder/stargazers","contributors_url":"https://api.github.com/repos/wocommunity/wonder/contributors","subscribers_url":"https://api.github.com/repos/wocommunity/wonder/subscribers","subscription_url":"https://api.github.com/repos/wocommunity/wonder/subscription","commits_url":"https://api.github.com/repos/wocommunity/wonder/commits{/sha}","git_commits_url":"https://api.github.com/repos/wocommunity/wonder/git/commits{/sha}","comments_url":"https://api.github.com/repos/wocommunity/wonder/comments{/number}","issue_comment_url":"https://api.github.com/repos/wocommunity/wonder/issues/comments{/number}","contents_url":"https://api.github.com/repos/wocommunity/wonder/contents/{+path}","compare_url":"https://api.github.com/repos/wocommunity/wonder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wocommunity/wonder/merges","archive_url":"https://api.github.com/repos/wocommunity/wonder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wocommunity/wonder/downloads","issues_url":"https://api.github.com/repos/wocommunity/wonder/issues{/number}","pulls_url":"https://api.github.com/repos/wocommunity/wonder/pulls{/number}","milestones_url":"https://api.github.com/repos/wocommunity/wonder/milestones{/number}","notifications_url":"https://api.github.com/repos/wocommunity/wonder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wocommunity/wonder/labels{/name}","releases_url":"https://api.github.com/repos/wocommunity/wonder/releases{/id}","created_at":"2011-03-24T13:30:25Z","updated_at":"2015-10-03T14:05:56Z","pushed_at":"2015-10-02T12:36:43Z","git_url":"git://github.com/wocommunity/wonder.git","ssh_url":"git@github.com:wocommunity/wonder.git","clone_url":"https://github.com/wocommunity/wonder.git","svn_url":"https://github.com/wocommunity/wonder","homepage":"http://wiki.wocommunity.org/","size":337792,"stargazers_count":184,"watchers_count":184,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":37,"forks":145,"open_issues":37,"watchers":184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wocommunity/wonder/pulls/687"},"html":{"href":"https://github.com/wocommunity/wonder/pull/687"},"issue":{"href":"https://api.github.com/repos/wocommunity/wonder/issues/687"},"comments":{"href":"https://api.github.com/repos/wocommunity/wonder/issues/687/comments"},"review_comments":{"href":"https://api.github.com/repos/wocommunity/wonder/pulls/687/comments"},"review_comment":{"href":"https://api.github.com/repos/wocommunity/wonder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wocommunity/wonder/pulls/687/commits"},"statuses":{"href":"https://api.github.com/repos/wocommunity/wonder/statuses/fe953bf8a16f6af3ebd42065a576ec3846b6f80e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7687,"deletions":2,"changed_files":84}}