{"action":"created","issue":{"url":"https://api.github.com/repos/graphhopper/graphhopper/issues/320","labels_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/320/labels{/name}","comments_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/320/comments","events_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/320/events","html_url":"https://github.com/graphhopper/graphhopper/pull/320","id":56966902,"number":320,"title":"Support fords","user":{"login":"florent-morel","id":1312828,"avatar_url":"https://avatars.githubusercontent.com/u/1312828?v=3","gravatar_id":"","url":"https://api.github.com/users/florent-morel","html_url":"https://github.com/florent-morel","followers_url":"https://api.github.com/users/florent-morel/followers","following_url":"https://api.github.com/users/florent-morel/following{/other_user}","gists_url":"https://api.github.com/users/florent-morel/gists{/gist_id}","starred_url":"https://api.github.com/users/florent-morel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florent-morel/subscriptions","organizations_url":"https://api.github.com/users/florent-morel/orgs","repos_url":"https://api.github.com/users/florent-morel/repos","events_url":"https://api.github.com/users/florent-morel/events{/privacy}","received_events_url":"https://api.github.com/users/florent-morel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-08T20:45:48Z","updated_at":"2015-02-10T07:58:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/graphhopper/graphhopper/pulls/320","html_url":"https://github.com/graphhopper/graphhopper/pull/320","diff_url":"https://github.com/graphhopper/graphhopper/pull/320.diff","patch_url":"https://github.com/graphhopper/graphhopper/pull/320.patch"},"body":"PR for ford support.\r\nDuring graph creation, I check config.properties for FlagEncoder allowing crossing fords.\r\n\r\nTo enable ford crossing for a given FlagEncoder, amend config.properties with:\r\ngraph.flagEncoders.supportFord=foot\r\n\r\nAs for graph.flagEncoders, possible options are: car,foot,bike,bike2,mtb,racingbike,motorcycle (comma separated). A non-existing value will throw an Exception.\r\n\r\nNote\r\nI'm building a Map<String, FlagEncoder> mapEncoder to iterate over instantiated FlagEncoder to set BlockFords to false. Not sure the map is the most efficient way though, any suggestion?\r\n\r\nCould you check this PR please?\r\nFlorent."},"comment":{"url":"https://api.github.com/repos/graphhopper/graphhopper/issues/comments/73658526","html_url":"https://github.com/graphhopper/graphhopper/pull/320#issuecomment-73658526","issue_url":"https://api.github.com/repos/graphhopper/graphhopper/issues/320","id":73658526,"user":{"login":"karussell","id":129644,"avatar_url":"https://avatars.githubusercontent.com/u/129644?v=3","gravatar_id":"","url":"https://api.github.com/users/karussell","html_url":"https://github.com/karussell","followers_url":"https://api.github.com/users/karussell/followers","following_url":"https://api.github.com/users/karussell/following{/other_user}","gists_url":"https://api.github.com/users/karussell/gists{/gist_id}","starred_url":"https://api.github.com/users/karussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karussell/subscriptions","organizations_url":"https://api.github.com/users/karussell/orgs","repos_url":"https://api.github.com/users/karussell/repos","events_url":"https://api.github.com/users/karussell/events{/privacy}","received_events_url":"https://api.github.com/users/karussell/received_events","type":"User","site_admin":false},"created_at":"2015-02-10T07:58:54Z","updated_at":"2015-02-10T07:58:54Z","body":"Thanks!\r\n\r\nSome minor things: Instead of creating an additional parameter in the AbstractFlagEncoder constructor just set the variable within the 'string'-constructors:\r\n\r\n```java\r\nthis(bla, blup);\r\nthis.setBlockFords(parseBoolean(propertiesStr, \"blockFords\", false))\r\n```\r\n\r\nand either use blockFords as variable AND as configuration option or allowFords for both. Also remove `setBlockFords` and `isBlockFords` methods from the FlagEncoder interface. These should stay just public or even better protected methods in AbstractFlagEncoder."}}