{"action":"created","comment":{"url":"https://api.github.com/repos/ros/console_bridge/pulls/comments/47725578","id":47725578,"diff_hunk":"@@ -82,7 +82,7 @@ if (NOT MSVC)\n   set(pkg_conf_file \"console_bridge.pc\")\n   configure_file(\"${pkg_conf_file}.in\" \"${CMAKE_BINARY_DIR}/${pkg_conf_file}\" @ONLY)\n   install(FILES \"${CMAKE_BINARY_DIR}/${pkg_conf_file}\"\n-    DESTINATION lib/pkgconfig/ COMPONENT pkgconfig)\n+    DESTINATION ${CMAKE_INSTALL_LIBDIR}/pkgconfig/ COMPONENT pkgconfig)","path":"CMakeLists.txt","position":20,"original_position":20,"commit_id":"00a941f134cb31706ca4c2a408a45f32aeefebb3","original_commit_id":"00a941f134cb31706ca4c2a408a45f32aeefebb3","user":{"login":"j-rivero","id":2098802,"avatar_url":"https://avatars.githubusercontent.com/u/2098802?v=3","gravatar_id":"","url":"https://api.github.com/users/j-rivero","html_url":"https://github.com/j-rivero","followers_url":"https://api.github.com/users/j-rivero/followers","following_url":"https://api.github.com/users/j-rivero/following{/other_user}","gists_url":"https://api.github.com/users/j-rivero/gists{/gist_id}","starred_url":"https://api.github.com/users/j-rivero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-rivero/subscriptions","organizations_url":"https://api.github.com/users/j-rivero/orgs","repos_url":"https://api.github.com/users/j-rivero/repos","events_url":"https://api.github.com/users/j-rivero/events{/privacy}","received_events_url":"https://api.github.com/users/j-rivero/received_events","type":"User","site_admin":false},"body":"We probably need to use `CMAKE_INSTALL_LIBDIR` with the cmake module, line 72","created_at":"2015-12-16T01:21:15Z","updated_at":"2015-12-16T01:21:15Z","html_url":"https://github.com/ros/console_bridge/pull/19#discussion_r47725578","pull_request_url":"https://api.github.com/repos/ros/console_bridge/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/ros/console_bridge/pulls/comments/47725578"},"html":{"href":"https://github.com/ros/console_bridge/pull/19#discussion_r47725578"},"pull_request":{"href":"https://api.github.com/repos/ros/console_bridge/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/ros/console_bridge/pulls/19","id":20211224,"html_url":"https://github.com/ros/console_bridge/pull/19","diff_url":"https://github.com/ros/console_bridge/pull/19.diff","patch_url":"https://github.com/ros/console_bridge/pull/19.patch","issue_url":"https://api.github.com/repos/ros/console_bridge/issues/19","number":19,"state":"open","locked":false,"title":"Add option to enable GNU Install Dirs","user":{"login":"jpgr87","id":301868,"avatar_url":"https://avatars.githubusercontent.com/u/301868?v=3","gravatar_id":"","url":"https://api.github.com/users/jpgr87","html_url":"https://github.com/jpgr87","followers_url":"https://api.github.com/users/jpgr87/followers","following_url":"https://api.github.com/users/jpgr87/following{/other_user}","gists_url":"https://api.github.com/users/jpgr87/gists{/gist_id}","starred_url":"https://api.github.com/users/jpgr87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpgr87/subscriptions","organizations_url":"https://api.github.com/users/jpgr87/orgs","repos_url":"https://api.github.com/users/jpgr87/repos","events_url":"https://api.github.com/users/jpgr87/events{/privacy}","received_events_url":"https://api.github.com/users/jpgr87/received_events","type":"User","site_admin":false},"body":"The way issue 15 was solved made it very difficult to install console_bridge system-wide on a distribution that does not use /usr/lib as the library installation path. This patch is a better way to solve the issue 15: rather than just nuking the GNUInstallDirs logic from orbit, it adds a configuration switch to optionally enable the functionality, leaving it disabled by default so ROS doesn't break.","created_at":"2014-08-23T16:18:04Z","updated_at":"2015-12-16T01:21:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa845cd193cc13ab8b0f06f11f983f58b4068987","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ros/console_bridge/pulls/19/commits","review_comments_url":"https://api.github.com/repos/ros/console_bridge/pulls/19/comments","review_comment_url":"https://api.github.com/repos/ros/console_bridge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros/console_bridge/issues/19/comments","statuses_url":"https://api.github.com/repos/ros/console_bridge/statuses/00a941f134cb31706ca4c2a408a45f32aeefebb3","head":{"label":"jpgr87:enable_gnuinstalldirs","ref":"enable_gnuinstalldirs","sha":"00a941f134cb31706ca4c2a408a45f32aeefebb3","user":{"login":"jpgr87","id":301868,"avatar_url":"https://avatars.githubusercontent.com/u/301868?v=3","gravatar_id":"","url":"https://api.github.com/users/jpgr87","html_url":"https://github.com/jpgr87","followers_url":"https://api.github.com/users/jpgr87/followers","following_url":"https://api.github.com/users/jpgr87/following{/other_user}","gists_url":"https://api.github.com/users/jpgr87/gists{/gist_id}","starred_url":"https://api.github.com/users/jpgr87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpgr87/subscriptions","organizations_url":"https://api.github.com/users/jpgr87/orgs","repos_url":"https://api.github.com/users/jpgr87/repos","events_url":"https://api.github.com/users/jpgr87/events{/privacy}","received_events_url":"https://api.github.com/users/jpgr87/received_events","type":"User","site_admin":false},"repo":{"id":23259860,"name":"console_bridge","full_name":"jpgr87/console_bridge","owner":{"login":"jpgr87","id":301868,"avatar_url":"https://avatars.githubusercontent.com/u/301868?v=3","gravatar_id":"","url":"https://api.github.com/users/jpgr87","html_url":"https://github.com/jpgr87","followers_url":"https://api.github.com/users/jpgr87/followers","following_url":"https://api.github.com/users/jpgr87/following{/other_user}","gists_url":"https://api.github.com/users/jpgr87/gists{/gist_id}","starred_url":"https://api.github.com/users/jpgr87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpgr87/subscriptions","organizations_url":"https://api.github.com/users/jpgr87/orgs","repos_url":"https://api.github.com/users/jpgr87/repos","events_url":"https://api.github.com/users/jpgr87/events{/privacy}","received_events_url":"https://api.github.com/users/jpgr87/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpgr87/console_bridge","description":"A ROS-independent package for logging that seamlessly pipes into rosconsole/rosout for ROS-dependent packages.","fork":true,"url":"https://api.github.com/repos/jpgr87/console_bridge","forks_url":"https://api.github.com/repos/jpgr87/console_bridge/forks","keys_url":"https://api.github.com/repos/jpgr87/console_bridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpgr87/console_bridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpgr87/console_bridge/teams","hooks_url":"https://api.github.com/repos/jpgr87/console_bridge/hooks","issue_events_url":"https://api.github.com/repos/jpgr87/console_bridge/issues/events{/number}","events_url":"https://api.github.com/repos/jpgr87/console_bridge/events","assignees_url":"https://api.github.com/repos/jpgr87/console_bridge/assignees{/user}","branches_url":"https://api.github.com/repos/jpgr87/console_bridge/branches{/branch}","tags_url":"https://api.github.com/repos/jpgr87/console_bridge/tags","blobs_url":"https://api.github.com/repos/jpgr87/console_bridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpgr87/console_bridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpgr87/console_bridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpgr87/console_bridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpgr87/console_bridge/statuses/{sha}","languages_url":"https://api.github.com/repos/jpgr87/console_bridge/languages","stargazers_url":"https://api.github.com/repos/jpgr87/console_bridge/stargazers","contributors_url":"https://api.github.com/repos/jpgr87/console_bridge/contributors","subscribers_url":"https://api.github.com/repos/jpgr87/console_bridge/subscribers","subscription_url":"https://api.github.com/repos/jpgr87/console_bridge/subscription","commits_url":"https://api.github.com/repos/jpgr87/console_bridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpgr87/console_bridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpgr87/console_bridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpgr87/console_bridge/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpgr87/console_bridge/contents/{+path}","compare_url":"https://api.github.com/repos/jpgr87/console_bridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpgr87/console_bridge/merges","archive_url":"https://api.github.com/repos/jpgr87/console_bridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpgr87/console_bridge/downloads","issues_url":"https://api.github.com/repos/jpgr87/console_bridge/issues{/number}","pulls_url":"https://api.github.com/repos/jpgr87/console_bridge/pulls{/number}","milestones_url":"https://api.github.com/repos/jpgr87/console_bridge/milestones{/number}","notifications_url":"https://api.github.com/repos/jpgr87/console_bridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpgr87/console_bridge/labels{/name}","releases_url":"https://api.github.com/repos/jpgr87/console_bridge/releases{/id}","created_at":"2014-08-23T15:57:26Z","updated_at":"2014-06-23T22:53:29Z","pushed_at":"2015-12-16T00:37:58Z","git_url":"git://github.com/jpgr87/console_bridge.git","ssh_url":"git@github.com:jpgr87/console_bridge.git","clone_url":"https://github.com/jpgr87/console_bridge.git","svn_url":"https://github.com/jpgr87/console_bridge","homepage":"","size":31,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ros:master","ref":"master","sha":"39bc1a526c949324f244038a50c9c7cea8c66926","user":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"repo":{"id":6767610,"name":"console_bridge","full_name":"ros/console_bridge","owner":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros/console_bridge","description":"A ROS-independent package for logging that seamlessly pipes into rosconsole/rosout for ROS-dependent packages.","fork":false,"url":"https://api.github.com/repos/ros/console_bridge","forks_url":"https://api.github.com/repos/ros/console_bridge/forks","keys_url":"https://api.github.com/repos/ros/console_bridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros/console_bridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros/console_bridge/teams","hooks_url":"https://api.github.com/repos/ros/console_bridge/hooks","issue_events_url":"https://api.github.com/repos/ros/console_bridge/issues/events{/number}","events_url":"https://api.github.com/repos/ros/console_bridge/events","assignees_url":"https://api.github.com/repos/ros/console_bridge/assignees{/user}","branches_url":"https://api.github.com/repos/ros/console_bridge/branches{/branch}","tags_url":"https://api.github.com/repos/ros/console_bridge/tags","blobs_url":"https://api.github.com/repos/ros/console_bridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros/console_bridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros/console_bridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros/console_bridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros/console_bridge/statuses/{sha}","languages_url":"https://api.github.com/repos/ros/console_bridge/languages","stargazers_url":"https://api.github.com/repos/ros/console_bridge/stargazers","contributors_url":"https://api.github.com/repos/ros/console_bridge/contributors","subscribers_url":"https://api.github.com/repos/ros/console_bridge/subscribers","subscription_url":"https://api.github.com/repos/ros/console_bridge/subscription","commits_url":"https://api.github.com/repos/ros/console_bridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros/console_bridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros/console_bridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros/console_bridge/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros/console_bridge/contents/{+path}","compare_url":"https://api.github.com/repos/ros/console_bridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros/console_bridge/merges","archive_url":"https://api.github.com/repos/ros/console_bridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros/console_bridge/downloads","issues_url":"https://api.github.com/repos/ros/console_bridge/issues{/number}","pulls_url":"https://api.github.com/repos/ros/console_bridge/pulls{/number}","milestones_url":"https://api.github.com/repos/ros/console_bridge/milestones{/number}","notifications_url":"https://api.github.com/repos/ros/console_bridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros/console_bridge/labels{/name}","releases_url":"https://api.github.com/repos/ros/console_bridge/releases{/id}","created_at":"2012-11-19T21:27:51Z","updated_at":"2015-01-11T14:01:15Z","pushed_at":"2015-12-16T00:37:59Z","git_url":"git://github.com/ros/console_bridge.git","ssh_url":"git@github.com:ros/console_bridge.git","clone_url":"https://github.com/ros/console_bridge.git","svn_url":"https://github.com/ros/console_bridge","homepage":"","size":67,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":7,"forks":12,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros/console_bridge/pulls/19"},"html":{"href":"https://github.com/ros/console_bridge/pull/19"},"issue":{"href":"https://api.github.com/repos/ros/console_bridge/issues/19"},"comments":{"href":"https://api.github.com/repos/ros/console_bridge/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/ros/console_bridge/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/ros/console_bridge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros/console_bridge/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/ros/console_bridge/statuses/00a941f134cb31706ca4c2a408a45f32aeefebb3"}}}}