{"action":"created","comment":{"url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/comments/37638192","id":37638192,"diff_hunk":"@@ -41,8 +47,17 @@ public void execute(JobExecutionContext context) throws JobExecutionException {\n \n \t\tJMXConnector conn = null;\n \t\tJMXConnectionParams connectionParams = null;\n+\n \t\ttry {\n-\t\t\tconnectionParams = new JMXConnectionParams(server.getJmxServiceURL(), server.getEnvironment());\n+\t\t\tJMXServiceURL jmxUrl;","path":"jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java","position":34,"original_position":34,"commit_id":"78ffb8d977b124942c043d579b6b2c8765cf5f47","original_commit_id":"7b22832e52d81d76258df0f1d6b93f10681e33fd","user":{"login":"gehel","id":1415765,"avatar_url":"https://avatars.githubusercontent.com/u/1415765?v=3","gravatar_id":"","url":"https://api.github.com/users/gehel","html_url":"https://github.com/gehel","followers_url":"https://api.github.com/users/gehel/followers","following_url":"https://api.github.com/users/gehel/following{/other_user}","gists_url":"https://api.github.com/users/gehel/gists{/gist_id}","starred_url":"https://api.github.com/users/gehel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gehel/subscriptions","organizations_url":"https://api.github.com/users/gehel/orgs","repos_url":"https://api.github.com/users/gehel/repos","events_url":"https://api.github.com/users/gehel/events{/privacy}","received_events_url":"https://api.github.com/users/gehel/received_events","type":"User","site_admin":false},"body":"Disregard this comment and move the implementation in `Server`\r\n\r\n:+1: ","created_at":"2015-08-21T14:18:23Z","updated_at":"2015-08-21T14:18:23Z","html_url":"https://github.com/jmxtrans/jmxtrans/pull/323#discussion_r37638192","pull_request_url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/323","_links":{"self":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/comments/37638192"},"html":{"href":"https://github.com/jmxtrans/jmxtrans/pull/323#discussion_r37638192"},"pull_request":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/323"}}},"pull_request":{"url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/323","id":43003838,"html_url":"https://github.com/jmxtrans/jmxtrans/pull/323","diff_url":"https://github.com/jmxtrans/jmxtrans/pull/323.diff","patch_url":"https://github.com/jmxtrans/jmxtrans/pull/323.patch","issue_url":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/323","number":323,"state":"open","locked":false,"title":"Allow to connect to a local PID","user":{"login":"henri-tremblay","id":1216819,"avatar_url":"https://avatars.githubusercontent.com/u/1216819?v=3","gravatar_id":"","url":"https://api.github.com/users/henri-tremblay","html_url":"https://github.com/henri-tremblay","followers_url":"https://api.github.com/users/henri-tremblay/followers","following_url":"https://api.github.com/users/henri-tremblay/following{/other_user}","gists_url":"https://api.github.com/users/henri-tremblay/gists{/gist_id}","starred_url":"https://api.github.com/users/henri-tremblay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henri-tremblay/subscriptions","organizations_url":"https://api.github.com/users/henri-tremblay/orgs","repos_url":"https://api.github.com/users/henri-tremblay/repos","events_url":"https://api.github.com/users/henri-tremblay/events{/privacy}","received_events_url":"https://api.github.com/users/henri-tremblay/received_events","type":"User","site_admin":false},"body":"This patch allow jmxtrans to connect to a local process using its PID.  This is useful if you want to have a local jmxtrans but don't want to embed it or use a java agent.\r\n\r\nI've noticed 2 things  that I want to raise to your attention:\r\n* Writer tend to use the server and port in their messages. Those are null in my case. However, they also must be null when jmxtrans is embedded. It seems that jmxtrans-embedded has its own writer. We could probably mutualize them by adding a Server.getIdentity method\r\n* tools.jar must be in the classpath to make it works. An attempt to add it can probably be done in the jmxtrans.sh script\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37627417%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37627551%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37627647%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37627650%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37627658%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37627729%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37627873%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37628270%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37628360%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37628419%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37628491%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37628520%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37636918%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37636920%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37636922%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37637037%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37637038%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37637039%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37637041%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37637042%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37637043%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37637372%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37637528%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37637614%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37637976%22%2C%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37638192%22%5D%2C%20%22comments%22%3A%20%7B%22Pull%207b22832e52d81d76258df0f1d6b93f10681e33fd%20pom.xml%2039%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37628491%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22The%20group%20is%20not%20aligned%20anymore%20with%20the%20pluginManagement%20section.%22%2C%20%22created_at%22%3A%20%222015-08-21T12%3A14%3A20Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1415765%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/gehel%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20pom.xml%3AL834-842%22%7D%2C%20%22Pull%207b22832e52d81d76258df0f1d6b93f10681e33fd%20jmxtrans-output/jmxtrans-output-core/src/test/java/com/googlecode/jmxtrans/model/output/OpenTSDBWriterTests.java%2045%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37628419%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22The%20test%20of%20%60OpenTSDBWriter%60%20should%20have%20nothing%20to%20do%20with%20pid.%20So%20there%20should%20be%20no%20reason%20to%20update%20it.%22%2C%20%22created_at%22%3A%20%222015-08-21T12%3A13%3A06Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1415765%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/gehel%22%7D%7D%2C%20%7B%22body%22%3A%20%22Precondition%20in%20Server%20are%20requiring%20to%20have%20a%20pid%20or%20a%20url.%20I%20picked%20the%20pid.%20Removing%20this%20will%20mean%20removing%20the%20preconditions%22%2C%20%22created_at%22%3A%20%222015-08-21T14%3A12%3A30Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1216819%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/henri-tremblay%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20jmxtrans-output/jmxtrans-output-core/src/test/java/com/googlecode/jmxtrans/model/output/OpenTSDBWriterTests.java%3AL95-102%22%7D%2C%20%22Pull%207b22832e52d81d76258df0f1d6b93f10681e33fd%20jmxtrans-core/pom.xml%2027%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37627417%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22It%20seems%20that%20at%20the%20moment%2C%20all%20those%20different%20profiles%20set%20the%20same%20value%20to%20%60toolsjar%60.%20So%20we%20can%20inline%20this%20property%20for%20the%20moment%2C%20and%20introduce%20profiles%20once%20we%20know%20about%20an%20actual%20difference%20between%20OS.%22%2C%20%22created_at%22%3A%20%222015-08-21T11%3A54%3A35Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1415765%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/gehel%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-08-21T14%3A07%3A06Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1216819%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/henri-tremblay%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20jmxtrans-core/pom.xml%3AL139-179%22%7D%2C%20%22Pull%207b22832e52d81d76258df0f1d6b93f10681e33fd%20jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java%2034%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37627551%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22It%20seems%20that%20we%20now%20have%20the%20concept%20of%20a%20%60ServerJob%60%20and%20a%20%60LocalJob%60.%20Could%20we%20reflect%20this%20in%20the%20class%20hierarchy%20instead%20of%20increasing%20the%20cyclomatic%20complexity%20of%20%60ServerJob%60%20%3F%20Or%20at%20least%20encapsulate%20the%20construction%20of%20the%20jmxUrl%20a%20bit%20better%20%3F%22%2C%20%22created_at%22%3A%20%222015-08-21T11%3A56%3A41Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1415765%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/gehel%22%7D%7D%2C%20%7B%22body%22%3A%20%22LocalJob%20doesn%27t%20exist.%20This%20comment%20is%20incompatible%20with%20the%20one%20on%20getJmxServiceURL.%20You%20need%20to%20pick%20one%20way.%22%2C%20%22created_at%22%3A%20%222015-08-21T14%3A10%3A10Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1216819%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/henri-tremblay%22%7D%7D%2C%20%7B%22body%22%3A%20%22Disregard%20this%20comment%20and%20move%20the%20implementation%20in%20%60Server%60%5Cr%5Cn%5Cr%5Cn%3A%2B1%3A%20%22%2C%20%22created_at%22%3A%20%222015-08-21T14%3A18%3A23Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1415765%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/gehel%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java%3AL47-64%22%7D%2C%20%22Pull%207b22832e52d81d76258df0f1d6b93f10681e33fd%20jmxtrans-core/src/main/java/com/googlecode/jmxtrans/model/Server.java%20104%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37628270%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Instead%20of%20removing%20this%20method%2C%20we%20should%20actually%20start%20using%20it.%20If%20we%20encapsulate%20the%20JMX%20URL%20here%2C%20we%20can%20have%20a%20%60ServerJob%60%20class%20that%20is%20completely%20agnostic%20of%20where%20the%20JMX%20values%20are%20coming%20from.%20Much%20much%20cleaner%20...%22%2C%20%22created_at%22%3A%20%222015-08-21T12%3A10%3A46Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1415765%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/gehel%22%7D%7D%2C%20%7B%22body%22%3A%20%22Can%20do.%20However%2C%20the%20exception%20will%20change%20since%20I%20will%20need%20to%20throw%20IOException%2C%20AttachNotSupportedException%2C%20AgentLoadException%2C%20AgentInitializationException%22%2C%20%22created_at%22%3A%20%222015-08-21T14%3A11%3A40Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1216819%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/henri-tremblay%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20jmxtrans-core/src/main/java/com/googlecode/jmxtrans/model/Server.java%3AL239-245%22%7D%2C%20%22Pull%207b22832e52d81d76258df0f1d6b93f10681e33fd%20jmxtrans-core/src/main/java/com/googlecode/jmxtrans/model/Server.java%2078%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37627873%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%20really%20dislike%20methods%20returning%20null%20%28there%20are%20a%20lot%20of%20them%20for%20%5C%22historical%20reasons%5C%22%29.%20Still%2C%20let%27s%20try%20not%20to%20introduce%20new%20ones.%20In%20the%20case%20of%20a%20local%20JVM%20accessed%20by%20PID%2C%20the%20hostname%20of%20the%20JVM%20is%20the%20hostname%20of%20the%20machine%20on%20which%20JmxTrans%20runs.%20So%20we%20have%20a%20way%20to%20cleanly%20expose%20a%20hostname%20also%20in%20this%20case.%20So%20let%27s%20not%20break%20the%20contract%20unless%20we%20really%20have%20to.%22%2C%20%22created_at%22%3A%20%222015-08-21T12%3A02%3A57Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1415765%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/gehel%22%7D%7D%2C%20%7B%22body%22%3A%20%22I%20almost%20did%20that.%20However%2C%20the%20port%20would%20stay%20null.%20This%20is%20also%20why%20I%20was%20talking%20about%20getIdentity.%20That%20would%20return%20host%3Aport%20or%20pid%40host%20depending%20on%20the%20use-case%22%2C%20%22created_at%22%3A%20%222015-08-21T14%3A16%3A07Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1216819%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/henri-tremblay%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20jmxtrans-core/src/main/java/com/googlecode/jmxtrans/model/Server.java%3AL155-176%22%7D%2C%20%22Pull%207b22832e52d81d76258df0f1d6b93f10681e33fd%20jmxtrans-core/src/main/java/com/googlecode/jmxtrans/model/Server.java%2068%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37627729%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22This%20%60if%60%20is%20useless%2C%20if%20you%20remove%20it%20you%20will%20get%20the%20exact%20same%20behaviour.%22%2C%20%22created_at%22%3A%20%222015-08-21T12%3A00%3A07Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1415765%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/gehel%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-08-21T14%3A07%3A05Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1216819%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/henri-tremblay%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20jmxtrans-core/src/main/java/com/googlecode/jmxtrans/model/Server.java%3AL155-176%22%7D%2C%20%22Pull%207b22832e52d81d76258df0f1d6b93f10681e33fd%20jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java%2070%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37627658%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Comment%20is%20redundant%20with%20the%20line%20of%20code%20below%2C%20it%20should%20be%20removed.%22%2C%20%22created_at%22%3A%20%222015-08-21T11%3A58%3A34Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1415765%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/gehel%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-08-21T14%3A05%3A49Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1216819%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/henri-tremblay%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-08-21T14%3A07%3A05Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1216819%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/henri-tremblay%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java%3AL75-107%22%7D%2C%20%22Pull%207b22832e52d81d76258df0f1d6b93f10681e33fd%20jmxtrans-output/jmxtrans-output-core/src/test/java/com/googlecode/jmxtrans/model/output/OpenTSDBWriterTests.java%2035%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37628360%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22We%20tend%20to%20dislike%20star%20imports%20...%22%2C%20%22created_at%22%3A%20%222015-08-21T12%3A12%3A07Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1415765%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/gehel%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-08-21T14%3A07%3A05Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1216819%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/henri-tremblay%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20jmxtrans-output/jmxtrans-output-core/src/test/java/com/googlecode/jmxtrans/model/output/OpenTSDBWriterTests.java%3AL1-24%22%7D%2C%20%22Pull%207b22832e52d81d76258df0f1d6b93f10681e33fd%20jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java%2053%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37627650%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Comment%20is%20redundant%20with%20the%20line%20of%20code%20below%2C%20it%20should%20be%20removed.%22%2C%20%22created_at%22%3A%20%222015-08-21T11%3A58%3A22Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1415765%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/gehel%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-08-21T14%3A05%3A49Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1216819%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/henri-tremblay%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-08-21T14%3A07%3A05Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1216819%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/henri-tremblay%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java%3AL75-107%22%7D%2C%20%22Pull%207b22832e52d81d76258df0f1d6b93f10681e33fd%20jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java%2057%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37627647%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Comment%20is%20redundant%20with%20the%20line%20of%20code%20below%2C%20it%20should%20be%20removed.%22%2C%20%22created_at%22%3A%20%222015-08-21T11%3A58%3A19Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1415765%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/gehel%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-complete%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-08-21T14%3A05%3A49Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1216819%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/henri-tremblay%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-complete%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-08-21T14%3A07%3A06Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1216819%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/henri-tremblay%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java%3AL75-107%22%7D%2C%20%22Pull%207b22832e52d81d76258df0f1d6b93f10681e33fd%20pom.xml%205%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/jmxtrans/jmxtrans/pull/323%23discussion_r37628520%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22While%20it%20is%20a%20good%20idea%20to%20update%20dependencies%2C%20this%20is%20not%20related%20to%20your%20PR%20%28as%20far%20as%20I%20can%20see%29%2C%20so%20it%20should%20be%20part%20of%20another%20PR.%22%2C%20%22created_at%22%3A%20%222015-08-21T12%3A14%3A55Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1415765%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/gehel%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20pom.xml%3AL476-483%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-Pull 7b22832e52d81d76258df0f1d6b93f10681e33fd jmxtrans-core/src/main/java/com/googlecode/jmxtrans/model/Server.java 78'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/jmxtrans/jmxtrans/pull/323#discussion_r37627873'>File: jmxtrans-core/src/main/java/com/googlecode/jmxtrans/model/Server.java:L155-176</a></b>\n- <a href='https://github.com/gehel'><img border=0 src='https://avatars.githubusercontent.com/u/1415765?v=3' height=16 width=16'></a> I really dislike methods returning null (there are a lot of them for \"historical reasons\"). Still, let's try not to introduce new ones. In the case of a local JVM accessed by PID, the hostname of the JVM is the hostname of the machine on which JmxTrans runs. So we have a way to cleanly expose a hostname also in this case. So let's not break the contract unless we really have to.\n- <a href='https://github.com/henri-tremblay'><img border=0 src='https://avatars.githubusercontent.com/u/1216819?v=3' height=16 width=16'></a> I almost did that. However, the port would stay null. This is also why I was talking about getIdentity. That would return host:port or pid@host depending on the use-case\n- [ ] <a href='#crh-comment-Pull 7b22832e52d81d76258df0f1d6b93f10681e33fd jmxtrans-core/src/main/java/com/googlecode/jmxtrans/model/Server.java 104'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/jmxtrans/jmxtrans/pull/323#discussion_r37628270'>File: jmxtrans-core/src/main/java/com/googlecode/jmxtrans/model/Server.java:L239-245</a></b>\n- <a href='https://github.com/gehel'><img border=0 src='https://avatars.githubusercontent.com/u/1415765?v=3' height=16 width=16'></a> Instead of removing this method, we should actually start using it. If we encapsulate the JMX URL here, we can have a `ServerJob` class that is completely agnostic of where the JMX values are coming from. Much much cleaner ...\n- <a href='https://github.com/henri-tremblay'><img border=0 src='https://avatars.githubusercontent.com/u/1216819?v=3' height=16 width=16'></a> Can do. However, the exception will change since I will need to throw IOException, AttachNotSupportedException, AgentLoadException, AgentInitializationException\n- [ ] <a href='#crh-comment-Pull 7b22832e52d81d76258df0f1d6b93f10681e33fd jmxtrans-output/jmxtrans-output-core/src/test/java/com/googlecode/jmxtrans/model/output/OpenTSDBWriterTests.java 45'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/jmxtrans/jmxtrans/pull/323#discussion_r37628419'>File: jmxtrans-output/jmxtrans-output-core/src/test/java/com/googlecode/jmxtrans/model/output/OpenTSDBWriterTests.java:L95-102</a></b>\n- <a href='https://github.com/gehel'><img border=0 src='https://avatars.githubusercontent.com/u/1415765?v=3' height=16 width=16'></a> The test of `OpenTSDBWriter` should have nothing to do with pid. So there should be no reason to update it.\n- <a href='https://github.com/henri-tremblay'><img border=0 src='https://avatars.githubusercontent.com/u/1216819?v=3' height=16 width=16'></a> Precondition in Server are requiring to have a pid or a url. I picked the pid. Removing this will mean removing the preconditions\n- [ ] <a href='#crh-comment-Pull 7b22832e52d81d76258df0f1d6b93f10681e33fd pom.xml 39'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/jmxtrans/jmxtrans/pull/323#discussion_r37628491'>File: pom.xml:L834-842</a></b>\n- <a href='https://github.com/gehel'><img border=0 src='https://avatars.githubusercontent.com/u/1415765?v=3' height=16 width=16'></a> The group is not aligned anymore with the pluginManagement section.\n- [ ] <a href='#crh-comment-Pull 7b22832e52d81d76258df0f1d6b93f10681e33fd pom.xml 5'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/jmxtrans/jmxtrans/pull/323#discussion_r37628520'>File: pom.xml:L476-483</a></b>\n- <a href='https://github.com/gehel'><img border=0 src='https://avatars.githubusercontent.com/u/1415765?v=3' height=16 width=16'></a> While it is a good idea to update dependencies, this is not related to your PR (as far as I can see), so it should be part of another PR.\n- [x] <a href='#crh-comment-Pull 7b22832e52d81d76258df0f1d6b93f10681e33fd jmxtrans-core/pom.xml 27'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/jmxtrans/jmxtrans/pull/323#discussion_r37627417'>File: jmxtrans-core/pom.xml:L139-179</a></b>\n- <a href='https://github.com/gehel'><img border=0 src='https://avatars.githubusercontent.com/u/1415765?v=3' height=16 width=16'></a> It seems that at the moment, all those different profiles set the same value to `toolsjar`. So we can inline this property for the moment, and introduce profiles once we know about an actual difference between OS.\n- [x] <a href='#crh-comment-Pull 7b22832e52d81d76258df0f1d6b93f10681e33fd jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java 34'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/jmxtrans/jmxtrans/pull/323#discussion_r37627551'>File: jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java:L47-64</a></b>\n- <a href='https://github.com/gehel'><img border=0 src='https://avatars.githubusercontent.com/u/1415765?v=3' height=16 width=16'></a> It seems that we now have the concept of a `ServerJob` and a `LocalJob`. Could we reflect this in the class hierarchy instead of increasing the cyclomatic complexity of `ServerJob` ? Or at least encapsulate the construction of the jmxUrl a bit better ?\n- <a href='https://github.com/henri-tremblay'><img border=0 src='https://avatars.githubusercontent.com/u/1216819?v=3' height=16 width=16'></a> LocalJob doesn't exist. This comment is incompatible with the one on getJmxServiceURL. You need to pick one way.\n- <a href='https://github.com/gehel'><img border=0 src='https://avatars.githubusercontent.com/u/1415765?v=3' height=16 width=16'></a> Disregard this comment and move the implementation in `Server`\n:+1:\n- [x] <a href='#crh-comment-Pull 7b22832e52d81d76258df0f1d6b93f10681e33fd jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java 57'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/jmxtrans/jmxtrans/pull/323#discussion_r37627647'>File: jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java:L75-107</a></b>\n- <a href='https://github.com/gehel'><img border=0 src='https://avatars.githubusercontent.com/u/1415765?v=3' height=16 width=16'></a> Comment is redundant with the line of code below, it should be removed.\n- [x] <a href='#crh-comment-Pull 7b22832e52d81d76258df0f1d6b93f10681e33fd jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java 53'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/jmxtrans/jmxtrans/pull/323#discussion_r37627650'>File: jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java:L75-107</a></b>\n- <a href='https://github.com/gehel'><img border=0 src='https://avatars.githubusercontent.com/u/1415765?v=3' height=16 width=16'></a> Comment is redundant with the line of code below, it should be removed.\n- [x] <a href='#crh-comment-Pull 7b22832e52d81d76258df0f1d6b93f10681e33fd jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java 70'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/jmxtrans/jmxtrans/pull/323#discussion_r37627658'>File: jmxtrans-core/src/main/java/com/googlecode/jmxtrans/jobs/ServerJob.java:L75-107</a></b>\n- <a href='https://github.com/gehel'><img border=0 src='https://avatars.githubusercontent.com/u/1415765?v=3' height=16 width=16'></a> Comment is redundant with the line of code below, it should be removed.\n- [x] <a href='#crh-comment-Pull 7b22832e52d81d76258df0f1d6b93f10681e33fd jmxtrans-core/src/main/java/com/googlecode/jmxtrans/model/Server.java 68'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/jmxtrans/jmxtrans/pull/323#discussion_r37627729'>File: jmxtrans-core/src/main/java/com/googlecode/jmxtrans/model/Server.java:L155-176</a></b>\n- <a href='https://github.com/gehel'><img border=0 src='https://avatars.githubusercontent.com/u/1415765?v=3' height=16 width=16'></a> This `if` is useless, if you remove it you will get the exact same behaviour.\n- [x] <a href='#crh-comment-Pull 7b22832e52d81d76258df0f1d6b93f10681e33fd jmxtrans-output/jmxtrans-output-core/src/test/java/com/googlecode/jmxtrans/model/output/OpenTSDBWriterTests.java 35'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/jmxtrans/jmxtrans/pull/323#discussion_r37628360'>File: jmxtrans-output/jmxtrans-output-core/src/test/java/com/googlecode/jmxtrans/model/output/OpenTSDBWriterTests.java:L1-24</a></b>\n- <a href='https://github.com/gehel'><img border=0 src='https://avatars.githubusercontent.com/u/1415765?v=3' height=16 width=16'></a> We tend to dislike star imports ...\n\n\n<a href='https://www.codereviewhub.com/jmxtrans/jmxtrans/pull/323?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/jmxtrans/jmxtrans/pull/323?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/jmxtrans/jmxtrans/pull/323'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2015-08-21T04:45:26Z","updated_at":"2015-08-21T14:18:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc0c769365971debdc2f80209d62a2b5027bf7e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/323/commits","review_comments_url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/323/comments","review_comment_url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/323/comments","statuses_url":"https://api.github.com/repos/jmxtrans/jmxtrans/statuses/78ffb8d977b124942c043d579b6b2c8765cf5f47","head":{"label":"henri-tremblay:pid","ref":"pid","sha":"78ffb8d977b124942c043d579b6b2c8765cf5f47","user":{"login":"henri-tremblay","id":1216819,"avatar_url":"https://avatars.githubusercontent.com/u/1216819?v=3","gravatar_id":"","url":"https://api.github.com/users/henri-tremblay","html_url":"https://github.com/henri-tremblay","followers_url":"https://api.github.com/users/henri-tremblay/followers","following_url":"https://api.github.com/users/henri-tremblay/following{/other_user}","gists_url":"https://api.github.com/users/henri-tremblay/gists{/gist_id}","starred_url":"https://api.github.com/users/henri-tremblay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henri-tremblay/subscriptions","organizations_url":"https://api.github.com/users/henri-tremblay/orgs","repos_url":"https://api.github.com/users/henri-tremblay/repos","events_url":"https://api.github.com/users/henri-tremblay/events{/privacy}","received_events_url":"https://api.github.com/users/henri-tremblay/received_events","type":"User","site_admin":false},"repo":{"id":41135045,"name":"jmxtrans","full_name":"henri-tremblay/jmxtrans","owner":{"login":"henri-tremblay","id":1216819,"avatar_url":"https://avatars.githubusercontent.com/u/1216819?v=3","gravatar_id":"","url":"https://api.github.com/users/henri-tremblay","html_url":"https://github.com/henri-tremblay","followers_url":"https://api.github.com/users/henri-tremblay/followers","following_url":"https://api.github.com/users/henri-tremblay/following{/other_user}","gists_url":"https://api.github.com/users/henri-tremblay/gists{/gist_id}","starred_url":"https://api.github.com/users/henri-tremblay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henri-tremblay/subscriptions","organizations_url":"https://api.github.com/users/henri-tremblay/orgs","repos_url":"https://api.github.com/users/henri-tremblay/repos","events_url":"https://api.github.com/users/henri-tremblay/events{/privacy}","received_events_url":"https://api.github.com/users/henri-tremblay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/henri-tremblay/jmxtrans","description":"jmxtrans","fork":true,"url":"https://api.github.com/repos/henri-tremblay/jmxtrans","forks_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/forks","keys_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/teams","hooks_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/hooks","issue_events_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/issues/events{/number}","events_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/events","assignees_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/assignees{/user}","branches_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/branches{/branch}","tags_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/tags","blobs_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/git/refs{/sha}","trees_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/statuses/{sha}","languages_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/languages","stargazers_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/stargazers","contributors_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/contributors","subscribers_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/subscribers","subscription_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/subscription","commits_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/commits{/sha}","git_commits_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/git/commits{/sha}","comments_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/comments{/number}","issue_comment_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/issues/comments{/number}","contents_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/contents/{+path}","compare_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/merges","archive_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/downloads","issues_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/issues{/number}","pulls_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/pulls{/number}","milestones_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/milestones{/number}","notifications_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/labels{/name}","releases_url":"https://api.github.com/repos/henri-tremblay/jmxtrans/releases{/id}","created_at":"2015-08-21T04:35:17Z","updated_at":"2015-08-21T04:35:18Z","pushed_at":"2015-08-21T14:05:10Z","git_url":"git://github.com/henri-tremblay/jmxtrans.git","ssh_url":"git@github.com:henri-tremblay/jmxtrans.git","clone_url":"https://github.com/henri-tremblay/jmxtrans.git","svn_url":"https://github.com/henri-tremblay/jmxtrans","homepage":"","size":35442,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmxtrans:master","ref":"master","sha":"dc14a55cffb1931087582c4e44e5d1bb5e2cdc7a","user":{"login":"jmxtrans","id":3198433,"avatar_url":"https://avatars.githubusercontent.com/u/3198433?v=3","gravatar_id":"","url":"https://api.github.com/users/jmxtrans","html_url":"https://github.com/jmxtrans","followers_url":"https://api.github.com/users/jmxtrans/followers","following_url":"https://api.github.com/users/jmxtrans/following{/other_user}","gists_url":"https://api.github.com/users/jmxtrans/gists{/gist_id}","starred_url":"https://api.github.com/users/jmxtrans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmxtrans/subscriptions","organizations_url":"https://api.github.com/users/jmxtrans/orgs","repos_url":"https://api.github.com/users/jmxtrans/repos","events_url":"https://api.github.com/users/jmxtrans/events{/privacy}","received_events_url":"https://api.github.com/users/jmxtrans/received_events","type":"Organization","site_admin":false},"repo":{"id":2934254,"name":"jmxtrans","full_name":"jmxtrans/jmxtrans","owner":{"login":"jmxtrans","id":3198433,"avatar_url":"https://avatars.githubusercontent.com/u/3198433?v=3","gravatar_id":"","url":"https://api.github.com/users/jmxtrans","html_url":"https://github.com/jmxtrans","followers_url":"https://api.github.com/users/jmxtrans/followers","following_url":"https://api.github.com/users/jmxtrans/following{/other_user}","gists_url":"https://api.github.com/users/jmxtrans/gists{/gist_id}","starred_url":"https://api.github.com/users/jmxtrans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmxtrans/subscriptions","organizations_url":"https://api.github.com/users/jmxtrans/orgs","repos_url":"https://api.github.com/users/jmxtrans/repos","events_url":"https://api.github.com/users/jmxtrans/events{/privacy}","received_events_url":"https://api.github.com/users/jmxtrans/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jmxtrans/jmxtrans","description":"jmxtrans","fork":false,"url":"https://api.github.com/repos/jmxtrans/jmxtrans","forks_url":"https://api.github.com/repos/jmxtrans/jmxtrans/forks","keys_url":"https://api.github.com/repos/jmxtrans/jmxtrans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmxtrans/jmxtrans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmxtrans/jmxtrans/teams","hooks_url":"https://api.github.com/repos/jmxtrans/jmxtrans/hooks","issue_events_url":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/events{/number}","events_url":"https://api.github.com/repos/jmxtrans/jmxtrans/events","assignees_url":"https://api.github.com/repos/jmxtrans/jmxtrans/assignees{/user}","branches_url":"https://api.github.com/repos/jmxtrans/jmxtrans/branches{/branch}","tags_url":"https://api.github.com/repos/jmxtrans/jmxtrans/tags","blobs_url":"https://api.github.com/repos/jmxtrans/jmxtrans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmxtrans/jmxtrans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmxtrans/jmxtrans/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmxtrans/jmxtrans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmxtrans/jmxtrans/statuses/{sha}","languages_url":"https://api.github.com/repos/jmxtrans/jmxtrans/languages","stargazers_url":"https://api.github.com/repos/jmxtrans/jmxtrans/stargazers","contributors_url":"https://api.github.com/repos/jmxtrans/jmxtrans/contributors","subscribers_url":"https://api.github.com/repos/jmxtrans/jmxtrans/subscribers","subscription_url":"https://api.github.com/repos/jmxtrans/jmxtrans/subscription","commits_url":"https://api.github.com/repos/jmxtrans/jmxtrans/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmxtrans/jmxtrans/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmxtrans/jmxtrans/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmxtrans/jmxtrans/contents/{+path}","compare_url":"https://api.github.com/repos/jmxtrans/jmxtrans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmxtrans/jmxtrans/merges","archive_url":"https://api.github.com/repos/jmxtrans/jmxtrans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmxtrans/jmxtrans/downloads","issues_url":"https://api.github.com/repos/jmxtrans/jmxtrans/issues{/number}","pulls_url":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls{/number}","milestones_url":"https://api.github.com/repos/jmxtrans/jmxtrans/milestones{/number}","notifications_url":"https://api.github.com/repos/jmxtrans/jmxtrans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmxtrans/jmxtrans/labels{/name}","releases_url":"https://api.github.com/repos/jmxtrans/jmxtrans/releases{/id}","created_at":"2011-12-07T17:24:36Z","updated_at":"2015-08-17T04:09:22Z","pushed_at":"2015-08-21T14:05:11Z","git_url":"git://github.com/jmxtrans/jmxtrans.git","ssh_url":"git@github.com:jmxtrans/jmxtrans.git","clone_url":"https://github.com/jmxtrans/jmxtrans.git","svn_url":"https://github.com/jmxtrans/jmxtrans","homepage":"","size":35442,"stargazers_count":727,"watchers_count":727,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":244,"mirror_url":null,"open_issues_count":18,"forks":244,"open_issues":18,"watchers":727,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/323"},"html":{"href":"https://github.com/jmxtrans/jmxtrans/pull/323"},"issue":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/323"},"comments":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/issues/323/comments"},"review_comments":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/323/comments"},"review_comment":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/pulls/323/commits"},"statuses":{"href":"https://api.github.com/repos/jmxtrans/jmxtrans/statuses/78ffb8d977b124942c043d579b6b2c8765cf5f47"}}}}