{"action":"created","issue":{"url":"https://api.github.com/repos/vivo-project/Vitro/issues/23","labels_url":"https://api.github.com/repos/vivo-project/Vitro/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/vivo-project/Vitro/issues/23/comments","events_url":"https://api.github.com/repos/vivo-project/Vitro/issues/23/events","html_url":"https://github.com/vivo-project/Vitro/pull/23","id":101346858,"number":23,"title":"simplified getConfigFromSession logic with ternary operator","user":{"login":"zednis","id":1057295,"avatar_url":"https://avatars.githubusercontent.com/u/1057295?v=3","gravatar_id":"","url":"https://api.github.com/users/zednis","html_url":"https://github.com/zednis","followers_url":"https://api.github.com/users/zednis/followers","following_url":"https://api.github.com/users/zednis/following{/other_user}","gists_url":"https://api.github.com/users/zednis/gists{/gist_id}","starred_url":"https://api.github.com/users/zednis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zednis/subscriptions","organizations_url":"https://api.github.com/users/zednis/orgs","repos_url":"https://api.github.com/users/zednis/repos","events_url":"https://api.github.com/users/zednis/events{/privacy}","received_events_url":"https://api.github.com/users/zednis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-17T06:05:55Z","updated_at":"2015-08-17T14:07:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vivo-project/Vitro/pulls/23","html_url":"https://github.com/vivo-project/Vitro/pull/23","diff_url":"https://github.com/vivo-project/Vitro/pull/23.diff","patch_url":"https://github.com/vivo-project/Vitro/pull/23.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/vivo-project/Vitro/issues/comments/131829237","html_url":"https://github.com/vivo-project/Vitro/pull/23#issuecomment-131829237","issue_url":"https://api.github.com/repos/vivo-project/Vitro/issues/23","id":131829237,"user":{"login":"j2blake","id":1633937,"avatar_url":"https://avatars.githubusercontent.com/u/1633937?v=3","gravatar_id":"","url":"https://api.github.com/users/j2blake","html_url":"https://github.com/j2blake","followers_url":"https://api.github.com/users/j2blake/followers","following_url":"https://api.github.com/users/j2blake/following{/other_user}","gists_url":"https://api.github.com/users/j2blake/gists{/gist_id}","starred_url":"https://api.github.com/users/j2blake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j2blake/subscriptions","organizations_url":"https://api.github.com/users/j2blake/orgs","repos_url":"https://api.github.com/users/j2blake/repos","events_url":"https://api.github.com/users/j2blake/events{/privacy}","received_events_url":"https://api.github.com/users/j2blake/received_events","type":"User","site_admin":false},"created_at":"2015-08-17T14:07:27Z","updated_at":"2015-08-17T14:07:27Z","body":"Stephan - Thanks for the pull request. I'll merge it in.\r\n\r\nIn the future, it might be better to avoid pull requests that are purely stylistic in nature, since they are so subjective. For example, some instructors teach that the ternary operator is inherently less clear than if/then/else, and should never be used. Like you, I disagree with that. \r\n\r\nAs another example, I try to avoid \"negative logic\", so I would have written this\r\n```return (configs != null) ? configs.get( editKey ) : null;```\r\nas this\r\n```return (configs == null) ? null : configs.get( editKey );```\r\nThis avoids the verbalization, *\"else, if configs is not not equal to null...\"*. Again, it is a matter of preference, and open to debate.\r\n\r\nAnd of course, our soon-to-be tech lead may have different opinions.\r\n\r\nI would have enjoyed seeing you at the conference. - Jim"}}