{"action":"created","issue":{"url":"https://api.github.com/repos/yeoman/generator-generator/issues/119","labels_url":"https://api.github.com/repos/yeoman/generator-generator/issues/119/labels{/name}","comments_url":"https://api.github.com/repos/yeoman/generator-generator/issues/119/comments","events_url":"https://api.github.com/repos/yeoman/generator-generator/issues/119/events","html_url":"https://github.com/yeoman/generator-generator/pull/119","id":96108912,"number":119,"title":"Improved the generator of yeoman generator","user":{"login":"zckrs","id":3020368,"avatar_url":"https://avatars.githubusercontent.com/u/3020368?v=3","gravatar_id":"","url":"https://api.github.com/users/zckrs","html_url":"https://github.com/zckrs","followers_url":"https://api.github.com/users/zckrs/followers","following_url":"https://api.github.com/users/zckrs/following{/other_user}","gists_url":"https://api.github.com/users/zckrs/gists{/gist_id}","starred_url":"https://api.github.com/users/zckrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zckrs/subscriptions","organizations_url":"https://api.github.com/users/zckrs/orgs","repos_url":"https://api.github.com/users/zckrs/repos","events_url":"https://api.github.com/users/zckrs/events{/privacy}","received_events_url":"https://api.github.com/users/zckrs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-20T16:56:28Z","updated_at":"2015-07-20T23:49:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/yeoman/generator-generator/pulls/119","html_url":"https://github.com/yeoman/generator-generator/pull/119","diff_url":"https://github.com/yeoman/generator-generator/pull/119.diff","patch_url":"https://github.com/yeoman/generator-generator/pull/119.patch"},"body":"## Removed\r\n\r\n* subgenerator was removed at the moment. It is not a mandatory feature while my refactoring.\r\n* superb was removed. Superb is not useful. And more often it will removed after generation. Less dependence for more maintainability.\r\n* mockery was removed.\r\n* npm-name was removed. All generators should be publish on NPM :-/ ? IMO, no. This check on NPM slows the generator by network latency.\r\n* `app/templates/app/templates/_bower.json` was removed.\r\n\r\n\r\n## Edited\r\n\r\n* Rename **generator-generator** to **generator-yeoman-generator**.\r\n* Splits generator process in multiple files (one by priorities related to the run loop).\r\n* Completes the 3 `package.json` (generator, generated generator, and final application example).\r\n* Fetch GitHub username and Git name/email from Generator instead of GitHub's API. fix #24\r\n* JSHint was replaced by ESLint inside of the generator and the generated generators. :clap:\r\n* Rewrite [README.md](https://github.com/zckrs/generator-yeoman-generator/blob/master/README.md)\r\n* Update NPM dependencies and devDependencies :tada:\r\n\r\n\r\n## Added\r\n\r\n* Generator and the generated generators are totally tested with Sinon Chai and covered by Istanbul. :clap:\r\n* Travis build will launch a suite  test called \"inception\" to create a example generator and run these unit tests. :tada:\r\n* Add some classic dotfiles in final application example (editorconfig, gitattribute, gitignore).\r\n* Add README.md, CONTRIBUTING.md in final application example.\r\n\r\n\r\n## Questions\r\n\r\n* Should I restore subgenertor ? (with `composeWith()` example ?)\r\n* I saw many discussions about directory structure and I'm confused. Should I move the `app` folder to `generator/app` folder ?\r\n\r\n\r\n## Notes\r\n\r\n* Any comments are welcome.\r\n* Need a maintainer. I'm interested. :smile:\r\n* If you think this PR is too heavy to be merged, I would publish on NPM like a new generator.\r\n* I'm sorry for my imperfect English :disappointed: "},"comment":{"url":"https://api.github.com/repos/yeoman/generator-generator/issues/comments/123096834","html_url":"https://github.com/yeoman/generator-generator/pull/119#issuecomment-123096834","issue_url":"https://api.github.com/repos/yeoman/generator-generator/issues/119","id":123096834,"user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"created_at":"2015-07-20T23:49:48Z","updated_at":"2015-07-20T23:49:48Z","body":"Awesome!\r\n\r\n> superb was removed. Superb is not useful. And more often it will removed after generation. Less dependence for more maintainability.\r\n\r\nTrue it's not practically useful, but it's fun. It's important to inject a bit of fun into programming. Also deps are cheap, so that's a bad argument.\r\n\r\n> npm-name was removed. All generators should be publish on NPM :-/ ? IMO, no. This check on NPM slows the generator by network latency.\r\n\r\nMost generators are published on npm though. We optimize for the common case. Ans the network latency isn't that bad.\r\n\r\n> Rename generator-generator to generator-yeoman-generator.\r\n\r\nWhy?"}}