{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/40321935","id":40321935,"diff_hunk":"@@ -25,7 +25,6 @@ public class Watch3DViewModelStartupParams\n         public IRenderPackageFactory RenderPackageFactory { get; set; }\n         public IDynamoViewModel ViewModel { get; set; }\n         public INotifyPropertyChanged RenderPackageFactoryViewModel { get;set; }\n-        public bool IsActiveAtStart { get; set; }","path":"src/DynamoCoreWpf/ViewModels/Watch3D/Watch3DViewModelBase.cs","position":4,"original_position":4,"commit_id":"088e9b11bc7388c260f2927081df337f8d666c9e","original_commit_id":"088e9b11bc7388c260f2927081df337f8d666c9e","user":{"login":"ikeough","id":1139788,"avatar_url":"https://avatars.githubusercontent.com/u/1139788?v=3","gravatar_id":"","url":"https://api.github.com/users/ikeough","html_url":"https://github.com/ikeough","followers_url":"https://api.github.com/users/ikeough/followers","following_url":"https://api.github.com/users/ikeough/following{/other_user}","gists_url":"https://api.github.com/users/ikeough/gists{/gist_id}","starred_url":"https://api.github.com/users/ikeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikeough/subscriptions","organizations_url":"https://api.github.com/users/ikeough/orgs","repos_url":"https://api.github.com/users/ikeough/repos","events_url":"https://api.github.com/users/ikeough/events{/privacy}","received_events_url":"https://api.github.com/users/ikeough/received_events","type":"User","site_admin":false},"body":"This property is not required as we can already get at the pref. setting through the `IPreferences` object.","created_at":"2015-09-24T14:06:29Z","updated_at":"2015-09-24T14:06:29Z","html_url":"https://github.com/DynamoDS/Dynamo/pull/5350#discussion_r40321935","pull_request_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5350","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/40321935"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/5350#discussion_r40321935"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5350"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5350","id":45812651,"html_url":"https://github.com/DynamoDS/Dynamo/pull/5350","diff_url":"https://github.com/DynamoDS/Dynamo/pull/5350.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/5350.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5350","number":5350,"state":"open","locked":false,"title":"MAGN-8388 Toggling the Dynamo Background Preview is not sticky \"inter-session\"","user":{"login":"ikeough","id":1139788,"avatar_url":"https://avatars.githubusercontent.com/u/1139788?v=3","gravatar_id":"","url":"https://api.github.com/users/ikeough","html_url":"https://github.com/ikeough","followers_url":"https://api.github.com/users/ikeough/followers","following_url":"https://api.github.com/users/ikeough/following{/other_user}","gists_url":"https://api.github.com/users/ikeough/gists{/gist_id}","starred_url":"https://api.github.com/users/ikeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikeough/subscriptions","organizations_url":"https://api.github.com/users/ikeough/orgs","repos_url":"https://api.github.com/users/ikeough/repos","events_url":"https://api.github.com/users/ikeough/events{/privacy}","received_events_url":"https://api.github.com/users/ikeough/received_events","type":"User","site_admin":false},"body":"### Purpose\r\n\r\nFix [MAGN-8388](http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-8388) by doing the following:\r\n- Remove an extraneous property `Watch3DViewModelStartupParams.IsActiveAtStart` which was always being set to true, and was unneccessary because we already get a reference to an `IPreferences` object which can be used to get the `IsBackgroundPreviewActive` property.\r\n- Set `IPreferences.IsBackgroundPreviewActive` when `Watch3DViewModelBase.Active` is set.\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [x] The code base is in a better state after this PR\r\n- [ ] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n  - No new strings added.\r\n- [x] The level of testing this PR includes is appropriate\r\n- [ ] User facing strings, if any, are extracted into `*.resx` files\r\n  - No new strings added.\r\n### Reviewers\r\n\r\n@mjkkirschner \r\n","created_at":"2015-09-23T18:18:05Z","updated_at":"2015-09-24T14:06:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90e625bb05345d7571f5795f65415c2bc7eeddb7","assignee":{"login":"mjkkirschner","id":508936,"avatar_url":"https://avatars.githubusercontent.com/u/508936?v=3","gravatar_id":"","url":"https://api.github.com/users/mjkkirschner","html_url":"https://github.com/mjkkirschner","followers_url":"https://api.github.com/users/mjkkirschner/followers","following_url":"https://api.github.com/users/mjkkirschner/following{/other_user}","gists_url":"https://api.github.com/users/mjkkirschner/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkkirschner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkkirschner/subscriptions","organizations_url":"https://api.github.com/users/mjkkirschner/orgs","repos_url":"https://api.github.com/users/mjkkirschner/repos","events_url":"https://api.github.com/users/mjkkirschner/events{/privacy}","received_events_url":"https://api.github.com/users/mjkkirschner/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5350/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5350/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5350/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/088e9b11bc7388c260f2927081df337f8d666c9e","head":{"label":"ikeough:MAGN-8388","ref":"MAGN-8388","sha":"088e9b11bc7388c260f2927081df337f8d666c9e","user":{"login":"ikeough","id":1139788,"avatar_url":"https://avatars.githubusercontent.com/u/1139788?v=3","gravatar_id":"","url":"https://api.github.com/users/ikeough","html_url":"https://github.com/ikeough","followers_url":"https://api.github.com/users/ikeough/followers","following_url":"https://api.github.com/users/ikeough/following{/other_user}","gists_url":"https://api.github.com/users/ikeough/gists{/gist_id}","starred_url":"https://api.github.com/users/ikeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikeough/subscriptions","organizations_url":"https://api.github.com/users/ikeough/orgs","repos_url":"https://api.github.com/users/ikeough/repos","events_url":"https://api.github.com/users/ikeough/events{/privacy}","received_events_url":"https://api.github.com/users/ikeough/received_events","type":"User","site_admin":false},"repo":{"id":37068216,"name":"Dynamo","full_name":"ikeough/Dynamo","owner":{"login":"ikeough","id":1139788,"avatar_url":"https://avatars.githubusercontent.com/u/1139788?v=3","gravatar_id":"","url":"https://api.github.com/users/ikeough","html_url":"https://github.com/ikeough","followers_url":"https://api.github.com/users/ikeough/followers","following_url":"https://api.github.com/users/ikeough/following{/other_user}","gists_url":"https://api.github.com/users/ikeough/gists{/gist_id}","starred_url":"https://api.github.com/users/ikeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikeough/subscriptions","organizations_url":"https://api.github.com/users/ikeough/orgs","repos_url":"https://api.github.com/users/ikeough/repos","events_url":"https://api.github.com/users/ikeough/events{/privacy}","received_events_url":"https://api.github.com/users/ikeough/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ikeough/Dynamo","description":"Visual Programming","fork":true,"url":"https://api.github.com/repos/ikeough/Dynamo","forks_url":"https://api.github.com/repos/ikeough/Dynamo/forks","keys_url":"https://api.github.com/repos/ikeough/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ikeough/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ikeough/Dynamo/teams","hooks_url":"https://api.github.com/repos/ikeough/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/ikeough/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/ikeough/Dynamo/events","assignees_url":"https://api.github.com/repos/ikeough/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/ikeough/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/ikeough/Dynamo/tags","blobs_url":"https://api.github.com/repos/ikeough/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ikeough/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ikeough/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ikeough/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ikeough/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/ikeough/Dynamo/languages","stargazers_url":"https://api.github.com/repos/ikeough/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/ikeough/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/ikeough/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/ikeough/Dynamo/subscription","commits_url":"https://api.github.com/repos/ikeough/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ikeough/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ikeough/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ikeough/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ikeough/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/ikeough/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ikeough/Dynamo/merges","archive_url":"https://api.github.com/repos/ikeough/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ikeough/Dynamo/downloads","issues_url":"https://api.github.com/repos/ikeough/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/ikeough/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/ikeough/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/ikeough/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ikeough/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/ikeough/Dynamo/releases{/id}","created_at":"2015-06-08T13:21:59Z","updated_at":"2015-08-04T20:52:36Z","pushed_at":"2015-09-23T18:50:56Z","git_url":"git://github.com/ikeough/Dynamo.git","ssh_url":"git@github.com:ikeough/Dynamo.git","clone_url":"https://github.com/ikeough/Dynamo.git","svn_url":"https://github.com/ikeough/Dynamo","homepage":"http://dynamobim.org","size":808241,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"1ee9627780b88c057c007dcc8e0884eeac8ef349","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"name":"Dynamo","full_name":"DynamoDS/Dynamo","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/Dynamo","description":"Visual Programming","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","created_at":"2012-02-09T07:35:33Z","updated_at":"2015-09-24T01:48:11Z","pushed_at":"2015-09-24T13:09:27Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":1042093,"stargazers_count":264,"watchers_count":264,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":201,"mirror_url":null,"open_issues_count":744,"forks":201,"open_issues":744,"watchers":264,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5350"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/5350"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5350"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/5350/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5350/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/5350/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/088e9b11bc7388c260f2927081df337f8d666c9e"}}}}