{"action":"closed","number":115,"pull_request":{"url":"https://api.github.com/repos/cisco/libsrtp/pulls/115","id":45247872,"html_url":"https://github.com/cisco/libsrtp/pull/115","diff_url":"https://github.com/cisco/libsrtp/pull/115.diff","patch_url":"https://github.com/cisco/libsrtp/pull/115.patch","issue_url":"https://api.github.com/repos/cisco/libsrtp/issues/115","number":115,"state":"closed","locked":false,"title":"Perform const-correctness to global data, test cases, \"virtual tables\", discriptions, and pointers to them.","user":{"login":"persmule","id":6374734,"avatar_url":"https://avatars.githubusercontent.com/u/6374734?v=3","gravatar_id":"","url":"https://api.github.com/users/persmule","html_url":"https://github.com/persmule","followers_url":"https://api.github.com/users/persmule/followers","following_url":"https://api.github.com/users/persmule/following{/other_user}","gists_url":"https://api.github.com/users/persmule/gists{/gist_id}","starred_url":"https://api.github.com/users/persmule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/persmule/subscriptions","organizations_url":"https://api.github.com/users/persmule/orgs","repos_url":"https://api.github.com/users/persmule/repos","events_url":"https://api.github.com/users/persmule/events{/privacy}","received_events_url":"https://api.github.com/users/persmule/received_events","type":"User","site_admin":false},"body":"Many global data (e.g. tables for aes), test case objects and their data, \"virtual tables\" (srtp_cipher_type_t and srtp_auth_type_t, since they contain many function pointers able to override, just as virtual tables in C++), descriptions do and should not be changed during their lifetime, so I believe it is better to qualify them, as well as any pointers to them read-only (const). If so, compilers can put them into rodata segments and prevent any writing attempt to them. Anyone wants to override default functions should never modify those existing global \"virtual tables\", but make their own copies of the original, and adjust pointers to them.","created_at":"2015-09-17T03:12:34Z","updated_at":"2015-09-29T12:56:18Z","closed_at":"2015-09-29T12:56:18Z","merged_at":"2015-09-29T12:56:18Z","merge_commit_sha":"56b1d691bab55aa0774940a873cf34315831bcce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cisco/libsrtp/pulls/115/commits","review_comments_url":"https://api.github.com/repos/cisco/libsrtp/pulls/115/comments","review_comment_url":"https://api.github.com/repos/cisco/libsrtp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/libsrtp/issues/115/comments","statuses_url":"https://api.github.com/repos/cisco/libsrtp/statuses/effe49b5f68a2b78c3db91bc363d4c2c7f40e513","head":{"label":"persmule:master","ref":"master","sha":"effe49b5f68a2b78c3db91bc363d4c2c7f40e513","user":{"login":"persmule","id":6374734,"avatar_url":"https://avatars.githubusercontent.com/u/6374734?v=3","gravatar_id":"","url":"https://api.github.com/users/persmule","html_url":"https://github.com/persmule","followers_url":"https://api.github.com/users/persmule/followers","following_url":"https://api.github.com/users/persmule/following{/other_user}","gists_url":"https://api.github.com/users/persmule/gists{/gist_id}","starred_url":"https://api.github.com/users/persmule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/persmule/subscriptions","organizations_url":"https://api.github.com/users/persmule/orgs","repos_url":"https://api.github.com/users/persmule/repos","events_url":"https://api.github.com/users/persmule/events{/privacy}","received_events_url":"https://api.github.com/users/persmule/received_events","type":"User","site_admin":false},"repo":{"id":42628137,"name":"libsrtp","full_name":"persmule/libsrtp","owner":{"login":"persmule","id":6374734,"avatar_url":"https://avatars.githubusercontent.com/u/6374734?v=3","gravatar_id":"","url":"https://api.github.com/users/persmule","html_url":"https://github.com/persmule","followers_url":"https://api.github.com/users/persmule/followers","following_url":"https://api.github.com/users/persmule/following{/other_user}","gists_url":"https://api.github.com/users/persmule/gists{/gist_id}","starred_url":"https://api.github.com/users/persmule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/persmule/subscriptions","organizations_url":"https://api.github.com/users/persmule/orgs","repos_url":"https://api.github.com/users/persmule/repos","events_url":"https://api.github.com/users/persmule/events{/privacy}","received_events_url":"https://api.github.com/users/persmule/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/persmule/libsrtp","description":"Library for SRTP (Secure Realtime Transport Protocol) ","fork":true,"url":"https://api.github.com/repos/persmule/libsrtp","forks_url":"https://api.github.com/repos/persmule/libsrtp/forks","keys_url":"https://api.github.com/repos/persmule/libsrtp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/persmule/libsrtp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/persmule/libsrtp/teams","hooks_url":"https://api.github.com/repos/persmule/libsrtp/hooks","issue_events_url":"https://api.github.com/repos/persmule/libsrtp/issues/events{/number}","events_url":"https://api.github.com/repos/persmule/libsrtp/events","assignees_url":"https://api.github.com/repos/persmule/libsrtp/assignees{/user}","branches_url":"https://api.github.com/repos/persmule/libsrtp/branches{/branch}","tags_url":"https://api.github.com/repos/persmule/libsrtp/tags","blobs_url":"https://api.github.com/repos/persmule/libsrtp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/persmule/libsrtp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/persmule/libsrtp/git/refs{/sha}","trees_url":"https://api.github.com/repos/persmule/libsrtp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/persmule/libsrtp/statuses/{sha}","languages_url":"https://api.github.com/repos/persmule/libsrtp/languages","stargazers_url":"https://api.github.com/repos/persmule/libsrtp/stargazers","contributors_url":"https://api.github.com/repos/persmule/libsrtp/contributors","subscribers_url":"https://api.github.com/repos/persmule/libsrtp/subscribers","subscription_url":"https://api.github.com/repos/persmule/libsrtp/subscription","commits_url":"https://api.github.com/repos/persmule/libsrtp/commits{/sha}","git_commits_url":"https://api.github.com/repos/persmule/libsrtp/git/commits{/sha}","comments_url":"https://api.github.com/repos/persmule/libsrtp/comments{/number}","issue_comment_url":"https://api.github.com/repos/persmule/libsrtp/issues/comments{/number}","contents_url":"https://api.github.com/repos/persmule/libsrtp/contents/{+path}","compare_url":"https://api.github.com/repos/persmule/libsrtp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/persmule/libsrtp/merges","archive_url":"https://api.github.com/repos/persmule/libsrtp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/persmule/libsrtp/downloads","issues_url":"https://api.github.com/repos/persmule/libsrtp/issues{/number}","pulls_url":"https://api.github.com/repos/persmule/libsrtp/pulls{/number}","milestones_url":"https://api.github.com/repos/persmule/libsrtp/milestones{/number}","notifications_url":"https://api.github.com/repos/persmule/libsrtp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/persmule/libsrtp/labels{/name}","releases_url":"https://api.github.com/repos/persmule/libsrtp/releases{/id}","created_at":"2015-09-17T02:07:02Z","updated_at":"2015-09-17T02:07:03Z","pushed_at":"2015-09-17T02:53:22Z","git_url":"git://github.com/persmule/libsrtp.git","ssh_url":"git@github.com:persmule/libsrtp.git","clone_url":"https://github.com/persmule/libsrtp.git","svn_url":"https://github.com/persmule/libsrtp","homepage":null,"size":3868,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cisco:master","ref":"master","sha":"6ce36b2b82325e391b1793399670204510b70820","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":9087423,"name":"libsrtp","full_name":"cisco/libsrtp","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/libsrtp","description":"Library for SRTP (Secure Realtime Transport Protocol) ","fork":false,"url":"https://api.github.com/repos/cisco/libsrtp","forks_url":"https://api.github.com/repos/cisco/libsrtp/forks","keys_url":"https://api.github.com/repos/cisco/libsrtp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/libsrtp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/libsrtp/teams","hooks_url":"https://api.github.com/repos/cisco/libsrtp/hooks","issue_events_url":"https://api.github.com/repos/cisco/libsrtp/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/libsrtp/events","assignees_url":"https://api.github.com/repos/cisco/libsrtp/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/libsrtp/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/libsrtp/tags","blobs_url":"https://api.github.com/repos/cisco/libsrtp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/libsrtp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/libsrtp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/libsrtp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/libsrtp/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/libsrtp/languages","stargazers_url":"https://api.github.com/repos/cisco/libsrtp/stargazers","contributors_url":"https://api.github.com/repos/cisco/libsrtp/contributors","subscribers_url":"https://api.github.com/repos/cisco/libsrtp/subscribers","subscription_url":"https://api.github.com/repos/cisco/libsrtp/subscription","commits_url":"https://api.github.com/repos/cisco/libsrtp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/libsrtp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/libsrtp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/libsrtp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/libsrtp/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/libsrtp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/libsrtp/merges","archive_url":"https://api.github.com/repos/cisco/libsrtp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/libsrtp/downloads","issues_url":"https://api.github.com/repos/cisco/libsrtp/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/libsrtp/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/libsrtp/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/libsrtp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/libsrtp/labels{/name}","releases_url":"https://api.github.com/repos/cisco/libsrtp/releases{/id}","created_at":"2013-03-28T22:08:25Z","updated_at":"2015-09-21T07:53:31Z","pushed_at":"2015-09-29T12:56:18Z","git_url":"git://github.com/cisco/libsrtp.git","ssh_url":"git@github.com:cisco/libsrtp.git","clone_url":"https://github.com/cisco/libsrtp.git","svn_url":"https://github.com/cisco/libsrtp","homepage":null,"size":4716,"stargazers_count":160,"watchers_count":160,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":81,"mirror_url":null,"open_issues_count":7,"forks":81,"open_issues":7,"watchers":160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/libsrtp/pulls/115"},"html":{"href":"https://github.com/cisco/libsrtp/pull/115"},"issue":{"href":"https://api.github.com/repos/cisco/libsrtp/issues/115"},"comments":{"href":"https://api.github.com/repos/cisco/libsrtp/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/libsrtp/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/libsrtp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/libsrtp/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/libsrtp/statuses/effe49b5f68a2b78c3db91bc363d4c2c7f40e513"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jfigus","id":3186778,"avatar_url":"https://avatars.githubusercontent.com/u/3186778?v=3","gravatar_id":"","url":"https://api.github.com/users/jfigus","html_url":"https://github.com/jfigus","followers_url":"https://api.github.com/users/jfigus/followers","following_url":"https://api.github.com/users/jfigus/following{/other_user}","gists_url":"https://api.github.com/users/jfigus/gists{/gist_id}","starred_url":"https://api.github.com/users/jfigus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfigus/subscriptions","organizations_url":"https://api.github.com/users/jfigus/orgs","repos_url":"https://api.github.com/users/jfigus/repos","events_url":"https://api.github.com/users/jfigus/events{/privacy}","received_events_url":"https://api.github.com/users/jfigus/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":169,"deletions":162,"changed_files":13}}