{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/jetpack/pulls/comments/34737095","id":34737095,"diff_hunk":"@@ -245,7 +245,12 @@ function jetpack_og_get_image( $width = 200, $height = 200, $max_images = 4 ) {\n \t\t$image['src'] = jetpack_site_icon_url( null, '512' );\n \t}\n \n-\t// Fourth fall back, blank image\n+\t// Fourth fall back, Core Site Icon. Added in WP 4.3.\n+\tif ( empty( $image ) && ( function_exists( 'has_site_icon') && has_site_icon() ) ) {","path":"functions.opengraph.php","position":6,"original_position":6,"commit_id":"4b401a78a95bec5e31f2d7df317c87c7cdde8e9f","original_commit_id":"4b401a78a95bec5e31f2d7df317c87c7cdde8e9f","user":{"login":"enejb","id":115071,"avatar_url":"https://avatars.githubusercontent.com/u/115071?v=3","gravatar_id":"","url":"https://api.github.com/users/enejb","html_url":"https://github.com/enejb","followers_url":"https://api.github.com/users/enejb/followers","following_url":"https://api.github.com/users/enejb/following{/other_user}","gists_url":"https://api.github.com/users/enejb/gists{/gist_id}","starred_url":"https://api.github.com/users/enejb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enejb/subscriptions","organizations_url":"https://api.github.com/users/enejb/orgs","repos_url":"https://api.github.com/users/enejb/repos","events_url":"https://api.github.com/users/enejb/events{/privacy}","received_events_url":"https://api.github.com/users/enejb/received_events","type":"User","site_admin":false},"body":"I think this could be done a bit better since jetpack_site_icon_url and get_site_icon_url should always return the same thing. \r\n\r\nWe can do a check if one exist and it it doesn't call the `jetpack_site_icon_url` function. \r\n\r\n","created_at":"2015-07-15T22:25:39Z","updated_at":"2015-07-15T22:25:39Z","html_url":"https://github.com/Automattic/jetpack/pull/2402#discussion_r34737095","pull_request_url":"https://api.github.com/repos/Automattic/jetpack/pulls/2402","_links":{"self":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/comments/34737095"},"html":{"href":"https://github.com/Automattic/jetpack/pull/2402#discussion_r34737095"},"pull_request":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/2402"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/jetpack/pulls/2402","id":39967082,"html_url":"https://github.com/Automattic/jetpack/pull/2402","diff_url":"https://github.com/Automattic/jetpack/pull/2402.diff","patch_url":"https://github.com/Automattic/jetpack/pull/2402.patch","issue_url":"https://api.github.com/repos/Automattic/jetpack/issues/2402","number":2402,"state":"open","locked":false,"title":"Site Icon: Start using core's Site Icon","user":{"login":"dereksmart","id":7129409,"avatar_url":"https://avatars.githubusercontent.com/u/7129409?v=3","gravatar_id":"","url":"https://api.github.com/users/dereksmart","html_url":"https://github.com/dereksmart","followers_url":"https://api.github.com/users/dereksmart/followers","following_url":"https://api.github.com/users/dereksmart/following{/other_user}","gists_url":"https://api.github.com/users/dereksmart/gists{/gist_id}","starred_url":"https://api.github.com/users/dereksmart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dereksmart/subscriptions","organizations_url":"https://api.github.com/users/dereksmart/orgs","repos_url":"https://api.github.com/users/dereksmart/repos","events_url":"https://api.github.com/users/dereksmart/events{/privacy}","received_events_url":"https://api.github.com/users/dereksmart/received_events","type":"User","site_admin":false},"body":"This is meant to be a seamless under-the-hood transition to deprecating Jetpack's site icon in favor of core.  \r\n\r\n- If user already has Jetpack Site Icon set, this will take that icon, transfer it to core's version, and deactivate Jetpack's Site Icon.\r\n\r\n- Modifies the Module list on the Jetpack Settings page so Site Icon cannot be activated.  Instead, we tell them about Core's new Site Icon and a link to configure it.  \r\n\r\n- Makes sure that core's site icon also gets synced back to wpcom\r\n\r\nMy thinking is that we'll leave it like this until 4.3 is the minimum supported WP version.  Then we can remove the module completely.  \r\n\r\nThis includes @kraftbj's commits from #2328 as well, so that PR can be discarded.  \r\n\r\nfixes #2326","created_at":"2015-07-14T21:50:23Z","updated_at":"2015-07-15T22:25:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97a2591da58d3cf55ff61fff3de5703a7489dcf5","assignee":null,"milestone":{"url":"https://api.github.com/repos/Automattic/jetpack/milestones/22","html_url":"https://github.com/Automattic/jetpack/milestones/3.6.1","labels_url":"https://api.github.com/repos/Automattic/jetpack/milestones/22/labels","id":1175945,"number":22,"title":"3.6.1","description":null,"creator":{"login":"roccotripaldi","id":2694219,"avatar_url":"https://avatars.githubusercontent.com/u/2694219?v=3","gravatar_id":"","url":"https://api.github.com/users/roccotripaldi","html_url":"https://github.com/roccotripaldi","followers_url":"https://api.github.com/users/roccotripaldi/followers","following_url":"https://api.github.com/users/roccotripaldi/following{/other_user}","gists_url":"https://api.github.com/users/roccotripaldi/gists{/gist_id}","starred_url":"https://api.github.com/users/roccotripaldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roccotripaldi/subscriptions","organizations_url":"https://api.github.com/users/roccotripaldi/orgs","repos_url":"https://api.github.com/users/roccotripaldi/repos","events_url":"https://api.github.com/users/roccotripaldi/events{/privacy}","received_events_url":"https://api.github.com/users/roccotripaldi/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":19,"state":"open","created_at":"2015-06-22T19:59:13Z","updated_at":"2015-07-15T21:27:13Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Automattic/jetpack/pulls/2402/commits","review_comments_url":"https://api.github.com/repos/Automattic/jetpack/pulls/2402/comments","review_comment_url":"https://api.github.com/repos/Automattic/jetpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/jetpack/issues/2402/comments","statuses_url":"https://api.github.com/repos/Automattic/jetpack/statuses/4b401a78a95bec5e31f2d7df317c87c7cdde8e9f","head":{"label":"Automattic:fix/site-icon-use-core","ref":"fix/site-icon-use-core","sha":"4b401a78a95bec5e31f2d7df317c87c7cdde8e9f","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":15231212,"name":"jetpack","full_name":"Automattic/jetpack","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/jetpack","description":"Your WordPress, Streamlined.","fork":false,"url":"https://api.github.com/repos/Automattic/jetpack","forks_url":"https://api.github.com/repos/Automattic/jetpack/forks","keys_url":"https://api.github.com/repos/Automattic/jetpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/jetpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/jetpack/teams","hooks_url":"https://api.github.com/repos/Automattic/jetpack/hooks","issue_events_url":"https://api.github.com/repos/Automattic/jetpack/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/jetpack/events","assignees_url":"https://api.github.com/repos/Automattic/jetpack/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/jetpack/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/jetpack/tags","blobs_url":"https://api.github.com/repos/Automattic/jetpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/jetpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/jetpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/jetpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/jetpack/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/jetpack/languages","stargazers_url":"https://api.github.com/repos/Automattic/jetpack/stargazers","contributors_url":"https://api.github.com/repos/Automattic/jetpack/contributors","subscribers_url":"https://api.github.com/repos/Automattic/jetpack/subscribers","subscription_url":"https://api.github.com/repos/Automattic/jetpack/subscription","commits_url":"https://api.github.com/repos/Automattic/jetpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/jetpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/jetpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/jetpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/jetpack/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/jetpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/jetpack/merges","archive_url":"https://api.github.com/repos/Automattic/jetpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/jetpack/downloads","issues_url":"https://api.github.com/repos/Automattic/jetpack/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/jetpack/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/jetpack/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/jetpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/jetpack/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/jetpack/releases{/id}","created_at":"2013-12-16T16:43:01Z","updated_at":"2015-07-14T11:45:16Z","pushed_at":"2015-07-15T21:27:14Z","git_url":"git://github.com/Automattic/jetpack.git","ssh_url":"git@github.com:Automattic/jetpack.git","clone_url":"https://github.com/Automattic/jetpack.git","svn_url":"https://github.com/Automattic/jetpack","homepage":"http://jetpack.me","size":296821,"stargazers_count":371,"watchers_count":371,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":246,"mirror_url":null,"open_issues_count":620,"forks":246,"open_issues":620,"watchers":371,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"e20d33abdcd198e7b228f69f5f1525e6838bd29f","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":15231212,"name":"jetpack","full_name":"Automattic/jetpack","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/jetpack","description":"Your WordPress, Streamlined.","fork":false,"url":"https://api.github.com/repos/Automattic/jetpack","forks_url":"https://api.github.com/repos/Automattic/jetpack/forks","keys_url":"https://api.github.com/repos/Automattic/jetpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/jetpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/jetpack/teams","hooks_url":"https://api.github.com/repos/Automattic/jetpack/hooks","issue_events_url":"https://api.github.com/repos/Automattic/jetpack/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/jetpack/events","assignees_url":"https://api.github.com/repos/Automattic/jetpack/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/jetpack/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/jetpack/tags","blobs_url":"https://api.github.com/repos/Automattic/jetpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/jetpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/jetpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/jetpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/jetpack/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/jetpack/languages","stargazers_url":"https://api.github.com/repos/Automattic/jetpack/stargazers","contributors_url":"https://api.github.com/repos/Automattic/jetpack/contributors","subscribers_url":"https://api.github.com/repos/Automattic/jetpack/subscribers","subscription_url":"https://api.github.com/repos/Automattic/jetpack/subscription","commits_url":"https://api.github.com/repos/Automattic/jetpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/jetpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/jetpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/jetpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/jetpack/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/jetpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/jetpack/merges","archive_url":"https://api.github.com/repos/Automattic/jetpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/jetpack/downloads","issues_url":"https://api.github.com/repos/Automattic/jetpack/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/jetpack/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/jetpack/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/jetpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/jetpack/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/jetpack/releases{/id}","created_at":"2013-12-16T16:43:01Z","updated_at":"2015-07-14T11:45:16Z","pushed_at":"2015-07-15T21:27:14Z","git_url":"git://github.com/Automattic/jetpack.git","ssh_url":"git@github.com:Automattic/jetpack.git","clone_url":"https://github.com/Automattic/jetpack.git","svn_url":"https://github.com/Automattic/jetpack","homepage":"http://jetpack.me","size":296821,"stargazers_count":371,"watchers_count":371,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":246,"mirror_url":null,"open_issues_count":620,"forks":246,"open_issues":620,"watchers":371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/2402"},"html":{"href":"https://github.com/Automattic/jetpack/pull/2402"},"issue":{"href":"https://api.github.com/repos/Automattic/jetpack/issues/2402"},"comments":{"href":"https://api.github.com/repos/Automattic/jetpack/issues/2402/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/2402/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/jetpack/pulls/2402/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/jetpack/statuses/4b401a78a95bec5e31f2d7df317c87c7cdde8e9f"}}}}