{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/46070011","id":46070011,"diff_hunk":"@@ -302,3 +307,49 @@ func TestBackoff(t *testing.T) {\n \t\tt.Errorf(\"expected: 1, got %s\", duration.String())\n \t}\n }\n+\n+// TestPodFitScheduler tests if a pod with certain annotation should be picked","path":"plugin/pkg/scheduler/factory/factory_test.go","position":53,"original_position":53,"commit_id":"ac38cf755bf7ba4d13611632d2086079c3330c9f","original_commit_id":"ac38cf755bf7ba4d13611632d2086079c3330c9f","user":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"body":"I would write this as \"tests if a pod with an annotation that should cause it to be picked by the default scheduler, is in fact picked by the default scheduler\"","created_at":"2015-11-27T21:03:42Z","updated_at":"2015-11-27T21:03:42Z","html_url":"https://github.com/kubernetes/kubernetes/pull/17865#discussion_r46070011","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17865","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/46070011"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17865#discussion_r46070011"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17865"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17865","id":51974090,"html_url":"https://github.com/kubernetes/kubernetes/pull/17865","diff_url":"https://github.com/kubernetes/kubernetes/pull/17865.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/17865.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17865","number":17865,"state":"open","locked":false,"title":"Implement multi-scheduler:","user":{"login":"HaiyangDING","id":11399486,"avatar_url":"https://avatars.githubusercontent.com/u/11399486?v=3","gravatar_id":"","url":"https://api.github.com/users/HaiyangDING","html_url":"https://github.com/HaiyangDING","followers_url":"https://api.github.com/users/HaiyangDING/followers","following_url":"https://api.github.com/users/HaiyangDING/following{/other_user}","gists_url":"https://api.github.com/users/HaiyangDING/gists{/gist_id}","starred_url":"https://api.github.com/users/HaiyangDING/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaiyangDING/subscriptions","organizations_url":"https://api.github.com/users/HaiyangDING/orgs","repos_url":"https://api.github.com/users/HaiyangDING/repos","events_url":"https://api.github.com/users/HaiyangDING/events{/privacy}","received_events_url":"https://api.github.com/users/HaiyangDING/received_events","type":"User","site_admin":false},"body":"@davidopp @bgrant0607  @brendandburns @hurf @timothysc @cameronbrunner @thockin \r\n\r\nThis PR partially implements multi-scheduler, including:\r\n1. Name default scheduler with name `kube-scheduler`\r\n2. The default scheduler only schedules the pods meeting the following condition:\r\n\t- the pod has no annotation `scheduler.alpha.kubernetes.io/name: scheduler-name`\r\n\t- the pod has annotation `scheduler.alpha.kubernetes.io/name: kube-scheduler`\r\n\r\nSee proposal [here](https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/multiple-schedulers.md)\r\n\r\nOne thing that is not included is \"move predicates into library\" (see #12744) and I will send another PR to implement that.\r\n\r\nThis PR is not the ideal implementation. Ideally, scheduler should only add pods meeting the above conditions when doing Watch&List from the client, however, currently we do not support query annotations from the client (Correct me if I am wrong). I will file another issue to state why we need something like \"annotationSelector\" or extending the current fieldSelector to support querying the annotations.","created_at":"2015-11-27T09:23:20Z","updated_at":"2015-11-27T21:03:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f05b6a2514fa5f3e37ad0f4459b93f0b69704eb","assignee":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17865/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17865/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17865/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ac38cf755bf7ba4d13611632d2086079c3330c9f","head":{"label":"HaiyangDING:multi-scheduler-phase-1","ref":"multi-scheduler-phase-1","sha":"ac38cf755bf7ba4d13611632d2086079c3330c9f","user":{"login":"HaiyangDING","id":11399486,"avatar_url":"https://avatars.githubusercontent.com/u/11399486?v=3","gravatar_id":"","url":"https://api.github.com/users/HaiyangDING","html_url":"https://github.com/HaiyangDING","followers_url":"https://api.github.com/users/HaiyangDING/followers","following_url":"https://api.github.com/users/HaiyangDING/following{/other_user}","gists_url":"https://api.github.com/users/HaiyangDING/gists{/gist_id}","starred_url":"https://api.github.com/users/HaiyangDING/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaiyangDING/subscriptions","organizations_url":"https://api.github.com/users/HaiyangDING/orgs","repos_url":"https://api.github.com/users/HaiyangDING/repos","events_url":"https://api.github.com/users/HaiyangDING/events{/privacy}","received_events_url":"https://api.github.com/users/HaiyangDING/received_events","type":"User","site_admin":false},"repo":{"id":33019331,"name":"kubernetes","full_name":"HaiyangDING/kubernetes","owner":{"login":"HaiyangDING","id":11399486,"avatar_url":"https://avatars.githubusercontent.com/u/11399486?v=3","gravatar_id":"","url":"https://api.github.com/users/HaiyangDING","html_url":"https://github.com/HaiyangDING","followers_url":"https://api.github.com/users/HaiyangDING/followers","following_url":"https://api.github.com/users/HaiyangDING/following{/other_user}","gists_url":"https://api.github.com/users/HaiyangDING/gists{/gist_id}","starred_url":"https://api.github.com/users/HaiyangDING/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaiyangDING/subscriptions","organizations_url":"https://api.github.com/users/HaiyangDING/orgs","repos_url":"https://api.github.com/users/HaiyangDING/repos","events_url":"https://api.github.com/users/HaiyangDING/events{/privacy}","received_events_url":"https://api.github.com/users/HaiyangDING/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HaiyangDING/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/HaiyangDING/kubernetes","forks_url":"https://api.github.com/repos/HaiyangDING/kubernetes/forks","keys_url":"https://api.github.com/repos/HaiyangDING/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HaiyangDING/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HaiyangDING/kubernetes/teams","hooks_url":"https://api.github.com/repos/HaiyangDING/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/HaiyangDING/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/HaiyangDING/kubernetes/events","assignees_url":"https://api.github.com/repos/HaiyangDING/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/HaiyangDING/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/HaiyangDING/kubernetes/tags","blobs_url":"https://api.github.com/repos/HaiyangDING/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HaiyangDING/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HaiyangDING/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/HaiyangDING/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HaiyangDING/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/HaiyangDING/kubernetes/languages","stargazers_url":"https://api.github.com/repos/HaiyangDING/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/HaiyangDING/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/HaiyangDING/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/HaiyangDING/kubernetes/subscription","commits_url":"https://api.github.com/repos/HaiyangDING/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/HaiyangDING/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/HaiyangDING/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/HaiyangDING/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/HaiyangDING/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/HaiyangDING/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HaiyangDING/kubernetes/merges","archive_url":"https://api.github.com/repos/HaiyangDING/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HaiyangDING/kubernetes/downloads","issues_url":"https://api.github.com/repos/HaiyangDING/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/HaiyangDING/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/HaiyangDING/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/HaiyangDING/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HaiyangDING/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/HaiyangDING/kubernetes/releases{/id}","created_at":"2015-03-28T03:14:48Z","updated_at":"2015-04-21T06:20:07Z","pushed_at":"2015-11-27T09:33:53Z","git_url":"git://github.com/HaiyangDING/kubernetes.git","ssh_url":"git@github.com:HaiyangDING/kubernetes.git","clone_url":"https://github.com/HaiyangDING/kubernetes.git","svn_url":"https://github.com/HaiyangDING/kubernetes","homepage":"http://kubernetes.io","size":137221,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"3cc588b5beaa296b6d9b95c3a1ddb050c80da000","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-11-27T17:33:22Z","pushed_at":"2015-11-27T21:01:42Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":289777,"stargazers_count":11498,"watchers_count":11498,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3079,"mirror_url":null,"open_issues_count":2430,"forks":3079,"open_issues":2430,"watchers":11498,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17865"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17865"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17865"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17865/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17865/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17865/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ac38cf755bf7ba4d13611632d2086079c3330c9f"}}}}