{"action":"created","comment":{"url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/pulls/comments/34096615","id":34096615,"diff_hunk":"@@ -6,6 +6,7 @@ EsriLeafletGeocoding.Services.Geocoding = Esri.Services.Service.extend({\n     options = options || {};\n     options.url = options.url || EsriLeafletGeocoding.WorldGeocodingService;\n     Esri.Services.Service.prototype.initialize.call(this, options);\n+    this._confirmSuggestSupport();","path":"src/Services/Geocoding.js","position":4,"original_position":4,"commit_id":"5dac4a1ef52ecaca76bae22095e6e9c36aca3dda","original_commit_id":"5dac4a1ef52ecaca76bae22095e6e9c36aca3dda","user":{"login":"patrickarlt","id":378557,"avatar_url":"https://avatars.githubusercontent.com/u/378557?v=3","gravatar_id":"","url":"https://api.github.com/users/patrickarlt","html_url":"https://github.com/patrickarlt","followers_url":"https://api.github.com/users/patrickarlt/followers","following_url":"https://api.github.com/users/patrickarlt/following{/other_user}","gists_url":"https://api.github.com/users/patrickarlt/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickarlt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickarlt/subscriptions","organizations_url":"https://api.github.com/users/patrickarlt/orgs","repos_url":"https://api.github.com/users/patrickarlt/repos","events_url":"https://api.github.com/users/patrickarlt/events{/privacy}","received_events_url":"https://api.github.com/users/patrickarlt/received_events","type":"User","site_admin":false},"body":"And this.","created_at":"2015-07-07T22:03:28Z","updated_at":"2015-07-07T22:03:28Z","html_url":"https://github.com/Esri/esri-leaflet-geocoder/pull/65#discussion_r34096615","pull_request_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/pulls/comments/34096615"},"html":{"href":"https://github.com/Esri/esri-leaflet-geocoder/pull/65#discussion_r34096615"},"pull_request":{"href":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/pulls/65","id":35854787,"html_url":"https://github.com/Esri/esri-leaflet-geocoder/pull/65","diff_url":"https://github.com/Esri/esri-leaflet-geocoder/pull/65.diff","patch_url":"https://github.com/Esri/esri-leaflet-geocoder/pull/65.patch","issue_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/issues/65","number":65,"state":"open","locked":false,"title":"added support for custom 10.3 geocoding services that support 'suggest'","user":{"login":"jgravois","id":3011734,"avatar_url":"https://avatars.githubusercontent.com/u/3011734?v=3","gravatar_id":"","url":"https://api.github.com/users/jgravois","html_url":"https://github.com/jgravois","followers_url":"https://api.github.com/users/jgravois/followers","following_url":"https://api.github.com/users/jgravois/following{/other_user}","gists_url":"https://api.github.com/users/jgravois/gists{/gist_id}","starred_url":"https://api.github.com/users/jgravois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgravois/subscriptions","organizations_url":"https://api.github.com/users/jgravois/orgs","repos_url":"https://api.github.com/users/jgravois/repos","events_url":"https://api.github.com/users/jgravois/events{/privacy}","received_events_url":"https://api.github.com/users/jgravois/received_events","type":"User","site_admin":false},"body":"closes #64\r\n\r\n### whats included?\r\n* fixed `FeatureLayer` provider instantiation syntax in 'debug/sample.html' (unrelated)\r\n* a few copyedits in doc\r\n* added a quick metadata request during initialization for the `Geocoding` service to determine whether or not 'Suggest' is a supported capability.\r\n* added logic to the provider to hook things up\r\n\r\n### to do:\r\n- [x] test with a few more functioning geocoders to confirm all is well. (see [below](https://github.com/Esri/esri-leaflet-geocoder/pull/65#issuecomment-104377200))\r\n- [x] make sure no more doc updates are required\r\n- [x] figure out what to do when the geocoding service `find` operation can't match an address presented by its own `suggest` operation (i've seen this several times now)","created_at":"2015-05-20T17:13:12Z","updated_at":"2015-07-07T22:03:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d29af225af38b48b87ba16f351a5ab94b1960b7d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/pulls/65/commits","review_comments_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/pulls/65/comments","review_comment_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/issues/65/comments","statuses_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/statuses/5dac4a1ef52ecaca76bae22095e6e9c36aca3dda","head":{"label":"jgravois:patch-64","ref":"patch-64","sha":"5dac4a1ef52ecaca76bae22095e6e9c36aca3dda","user":{"login":"jgravois","id":3011734,"avatar_url":"https://avatars.githubusercontent.com/u/3011734?v=3","gravatar_id":"","url":"https://api.github.com/users/jgravois","html_url":"https://github.com/jgravois","followers_url":"https://api.github.com/users/jgravois/followers","following_url":"https://api.github.com/users/jgravois/following{/other_user}","gists_url":"https://api.github.com/users/jgravois/gists{/gist_id}","starred_url":"https://api.github.com/users/jgravois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgravois/subscriptions","organizations_url":"https://api.github.com/users/jgravois/orgs","repos_url":"https://api.github.com/users/jgravois/repos","events_url":"https://api.github.com/users/jgravois/events{/privacy}","received_events_url":"https://api.github.com/users/jgravois/received_events","type":"User","site_admin":false},"repo":{"id":24666627,"name":"esri-leaflet-geocoder","full_name":"jgravois/esri-leaflet-geocoder","owner":{"login":"jgravois","id":3011734,"avatar_url":"https://avatars.githubusercontent.com/u/3011734?v=3","gravatar_id":"","url":"https://api.github.com/users/jgravois","html_url":"https://github.com/jgravois","followers_url":"https://api.github.com/users/jgravois/followers","following_url":"https://api.github.com/users/jgravois/following{/other_user}","gists_url":"https://api.github.com/users/jgravois/gists{/gist_id}","starred_url":"https://api.github.com/users/jgravois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgravois/subscriptions","organizations_url":"https://api.github.com/users/jgravois/orgs","repos_url":"https://api.github.com/users/jgravois/repos","events_url":"https://api.github.com/users/jgravois/events{/privacy}","received_events_url":"https://api.github.com/users/jgravois/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgravois/esri-leaflet-geocoder","description":"API helpers and UI controls for geocoding with the ArcGIS Geocoding Service with Leaflet.","fork":true,"url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder","forks_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/forks","keys_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/teams","hooks_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/hooks","issue_events_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/issues/events{/number}","events_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/events","assignees_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/assignees{/user}","branches_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/branches{/branch}","tags_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/tags","blobs_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/statuses/{sha}","languages_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/languages","stargazers_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/stargazers","contributors_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/contributors","subscribers_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/subscribers","subscription_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/subscription","commits_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/contents/{+path}","compare_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/merges","archive_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/downloads","issues_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/issues{/number}","pulls_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/pulls{/number}","milestones_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/milestones{/number}","notifications_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/labels{/name}","releases_url":"https://api.github.com/repos/jgravois/esri-leaflet-geocoder/releases{/id}","created_at":"2014-10-01T05:13:15Z","updated_at":"2015-03-14T14:26:05Z","pushed_at":"2015-07-07T20:38:48Z","git_url":"git://github.com/jgravois/esri-leaflet-geocoder.git","ssh_url":"git@github.com:jgravois/esri-leaflet-geocoder.git","clone_url":"https://github.com/jgravois/esri-leaflet-geocoder.git","svn_url":"https://github.com/jgravois/esri-leaflet-geocoder","homepage":"http://esri.github.io/esri-leaflet/examples/geocoding-control.html","size":1105,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Esri:master","ref":"master","sha":"f435a4b01f81b0cedec8918e409bb7d4e38bbc70","user":{"login":"Esri","id":628795,"avatar_url":"https://avatars.githubusercontent.com/u/628795?v=3","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"repo":{"id":14119537,"name":"esri-leaflet-geocoder","full_name":"Esri/esri-leaflet-geocoder","owner":{"login":"Esri","id":628795,"avatar_url":"https://avatars.githubusercontent.com/u/628795?v=3","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Esri/esri-leaflet-geocoder","description":"API helpers and UI controls for geocoding with the ArcGIS Geocoding Service with Leaflet.","fork":false,"url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder","forks_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/forks","keys_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/teams","hooks_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/hooks","issue_events_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/issues/events{/number}","events_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/events","assignees_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/assignees{/user}","branches_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/branches{/branch}","tags_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/tags","blobs_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/statuses/{sha}","languages_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/languages","stargazers_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/stargazers","contributors_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/contributors","subscribers_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/subscribers","subscription_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/subscription","commits_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/contents/{+path}","compare_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/merges","archive_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/downloads","issues_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/issues{/number}","pulls_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/pulls{/number}","milestones_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/milestones{/number}","notifications_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/labels{/name}","releases_url":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/releases{/id}","created_at":"2013-11-04T18:24:46Z","updated_at":"2015-07-03T15:22:28Z","pushed_at":"2015-07-07T20:38:48Z","git_url":"git://github.com/Esri/esri-leaflet-geocoder.git","ssh_url":"git@github.com:Esri/esri-leaflet-geocoder.git","clone_url":"https://github.com/Esri/esri-leaflet-geocoder.git","svn_url":"https://github.com/Esri/esri-leaflet-geocoder","homepage":"http://esri.github.io/esri-leaflet/examples/geocoding-control.html","size":1500,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":6,"forks":31,"open_issues":6,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/pulls/65"},"html":{"href":"https://github.com/Esri/esri-leaflet-geocoder/pull/65"},"issue":{"href":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/issues/65"},"comments":{"href":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/Esri/esri-leaflet-geocoder/statuses/5dac4a1ef52ecaca76bae22095e6e9c36aca3dda"}}}}