{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corert/pulls/comments/47203832","id":47203832,"diff_hunk":"@@ -375,7 +389,7 @@ private void OutputRelatedType(NodeFactory factory, ref ObjectDataBuilder objDat\n             {\n                 relatedType = ((ParameterizedType)_type).ParameterType;\n             }\n-            \n+\n             if (relatedType != null)\n             {\n                 if (_constructed)","path":"src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/EETypeNode.cs","position":160,"original_position":160,"commit_id":"3c6a79fa783ecc7b89ff4d690f60f565a59e49c4","original_commit_id":"3c6a79fa783ecc7b89ff4d690f60f565a59e49c4","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"Unrelated to this change - for arrays and pointers, it should be always NecessaryTypeSymbol (e.g. creating array of valuetype that is never boxed should not cause the full vtable generated to be generated for the valuetype).","created_at":"2015-12-10T09:22:18Z","updated_at":"2015-12-10T09:22:18Z","html_url":"https://github.com/dotnet/corert/pull/507#discussion_r47203832","pull_request_url":"https://api.github.com/repos/dotnet/corert/pulls/507","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments/47203832"},"html":{"href":"https://github.com/dotnet/corert/pull/507#discussion_r47203832"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corert/pulls/507"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corert/pulls/507","id":53207302,"html_url":"https://github.com/dotnet/corert/pull/507","diff_url":"https://github.com/dotnet/corert/pull/507.diff","patch_url":"https://github.com/dotnet/corert/pull/507.patch","issue_url":"https://api.github.com/repos/dotnet/corert/issues/507","number":507,"state":"open","locked":false,"title":"Populate EEType Optional Fields","user":{"login":"nattress","id":116900,"avatar_url":"https://avatars.githubusercontent.com/u/116900?v=3","gravatar_id":"","url":"https://api.github.com/users/nattress","html_url":"https://github.com/nattress","followers_url":"https://api.github.com/users/nattress/followers","following_url":"https://api.github.com/users/nattress/following{/other_user}","gists_url":"https://api.github.com/users/nattress/gists{/gist_id}","starred_url":"https://api.github.com/users/nattress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nattress/subscriptions","organizations_url":"https://api.github.com/users/nattress/orgs","repos_url":"https://api.github.com/users/nattress/repos","events_url":"https://api.github.com/users/nattress/events{/privacy}","received_events_url":"https://api.github.com/users/nattress/received_events","type":"User","site_admin":false},"body":"Add rare flags, value type field padding, nullable type value offset.\r\nAdd ICastable method slots - untested since code using interfaces will not compile yet.\r\nDispatchMap remains, which we need interface support for first.","created_at":"2015-12-10T02:17:39Z","updated_at":"2015-12-10T09:22:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67794482562f0a41a401e9588f58b8e4b7927434","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corert/pulls/507/commits","review_comments_url":"https://api.github.com/repos/dotnet/corert/pulls/507/comments","review_comment_url":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corert/issues/507/comments","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/3c6a79fa783ecc7b89ff4d690f60f565a59e49c4","head":{"label":"nattress:eetype_optional_fields","ref":"eetype_optional_fields","sha":"3c6a79fa783ecc7b89ff4d690f60f565a59e49c4","user":{"login":"nattress","id":116900,"avatar_url":"https://avatars.githubusercontent.com/u/116900?v=3","gravatar_id":"","url":"https://api.github.com/users/nattress","html_url":"https://github.com/nattress","followers_url":"https://api.github.com/users/nattress/followers","following_url":"https://api.github.com/users/nattress/following{/other_user}","gists_url":"https://api.github.com/users/nattress/gists{/gist_id}","starred_url":"https://api.github.com/users/nattress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nattress/subscriptions","organizations_url":"https://api.github.com/users/nattress/orgs","repos_url":"https://api.github.com/users/nattress/repos","events_url":"https://api.github.com/users/nattress/events{/privacy}","received_events_url":"https://api.github.com/users/nattress/received_events","type":"User","site_admin":false},"repo":{"id":46596706,"name":"corert","full_name":"nattress/corert","owner":{"login":"nattress","id":116900,"avatar_url":"https://avatars.githubusercontent.com/u/116900?v=3","gravatar_id":"","url":"https://api.github.com/users/nattress","html_url":"https://github.com/nattress","followers_url":"https://api.github.com/users/nattress/followers","following_url":"https://api.github.com/users/nattress/following{/other_user}","gists_url":"https://api.github.com/users/nattress/gists{/gist_id}","starred_url":"https://api.github.com/users/nattress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nattress/subscriptions","organizations_url":"https://api.github.com/users/nattress/orgs","repos_url":"https://api.github.com/users/nattress/repos","events_url":"https://api.github.com/users/nattress/events{/privacy}","received_events_url":"https://api.github.com/users/nattress/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nattress/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":true,"url":"https://api.github.com/repos/nattress/corert","forks_url":"https://api.github.com/repos/nattress/corert/forks","keys_url":"https://api.github.com/repos/nattress/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nattress/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nattress/corert/teams","hooks_url":"https://api.github.com/repos/nattress/corert/hooks","issue_events_url":"https://api.github.com/repos/nattress/corert/issues/events{/number}","events_url":"https://api.github.com/repos/nattress/corert/events","assignees_url":"https://api.github.com/repos/nattress/corert/assignees{/user}","branches_url":"https://api.github.com/repos/nattress/corert/branches{/branch}","tags_url":"https://api.github.com/repos/nattress/corert/tags","blobs_url":"https://api.github.com/repos/nattress/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nattress/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nattress/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/nattress/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nattress/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/nattress/corert/languages","stargazers_url":"https://api.github.com/repos/nattress/corert/stargazers","contributors_url":"https://api.github.com/repos/nattress/corert/contributors","subscribers_url":"https://api.github.com/repos/nattress/corert/subscribers","subscription_url":"https://api.github.com/repos/nattress/corert/subscription","commits_url":"https://api.github.com/repos/nattress/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/nattress/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/nattress/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/nattress/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/nattress/corert/contents/{+path}","compare_url":"https://api.github.com/repos/nattress/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nattress/corert/merges","archive_url":"https://api.github.com/repos/nattress/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nattress/corert/downloads","issues_url":"https://api.github.com/repos/nattress/corert/issues{/number}","pulls_url":"https://api.github.com/repos/nattress/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/nattress/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/nattress/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nattress/corert/labels{/name}","releases_url":"https://api.github.com/repos/nattress/corert/releases{/id}","created_at":"2015-11-21T01:52:47Z","updated_at":"2015-12-03T20:54:22Z","pushed_at":"2015-12-10T02:12:39Z","git_url":"git://github.com/nattress/corert.git","ssh_url":"git@github.com:nattress/corert.git","clone_url":"https://github.com/nattress/corert.git","svn_url":"https://github.com/nattress/corert","homepage":"http://dotnet.github.io/","size":4612,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9db9fed459641938d630eada66817b19b6f03d9b","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42552143,"name":"corert","full_name":"dotnet/corert","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":false,"url":"https://api.github.com/repos/dotnet/corert","forks_url":"https://api.github.com/repos/dotnet/corert/forks","keys_url":"https://api.github.com/repos/dotnet/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corert/teams","hooks_url":"https://api.github.com/repos/dotnet/corert/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corert/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corert/events","assignees_url":"https://api.github.com/repos/dotnet/corert/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corert/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corert/tags","blobs_url":"https://api.github.com/repos/dotnet/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corert/languages","stargazers_url":"https://api.github.com/repos/dotnet/corert/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corert/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corert/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corert/subscription","commits_url":"https://api.github.com/repos/dotnet/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corert/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corert/merges","archive_url":"https://api.github.com/repos/dotnet/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corert/downloads","issues_url":"https://api.github.com/repos/dotnet/corert/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corert/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corert/releases{/id}","created_at":"2015-09-15T23:10:53Z","updated_at":"2015-12-09T20:57:42Z","pushed_at":"2015-12-10T02:17:40Z","git_url":"git://github.com/dotnet/corert.git","ssh_url":"git@github.com:dotnet/corert.git","clone_url":"https://github.com/dotnet/corert.git","svn_url":"https://github.com/dotnet/corert","homepage":"http://dotnet.github.io/","size":5033,"stargazers_count":117,"watchers_count":117,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":104,"forks":45,"open_issues":104,"watchers":117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/507"},"html":{"href":"https://github.com/dotnet/corert/pull/507"},"issue":{"href":"https://api.github.com/repos/dotnet/corert/issues/507"},"comments":{"href":"https://api.github.com/repos/dotnet/corert/issues/507/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corert/pulls/507/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corert/pulls/507/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corert/statuses/3c6a79fa783ecc7b89ff4d690f60f565a59e49c4"}}}}