{"action":"created","issue":{"url":"https://api.github.com/repos/rzwitserloot/lombok/issues/72","labels_url":"https://api.github.com/repos/rzwitserloot/lombok/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/rzwitserloot/lombok/issues/72/comments","events_url":"https://api.github.com/repos/rzwitserloot/lombok/issues/72/events","html_url":"https://github.com/rzwitserloot/lombok/pull/72","id":93003676,"number":72,"title":"JUnit: Runner should not invoke fireTestFinished if test was ignored.","user":{"login":"Fuud","id":283980,"avatar_url":"https://avatars.githubusercontent.com/u/283980?v=3","gravatar_id":"","url":"https://api.github.com/users/Fuud","html_url":"https://github.com/Fuud","followers_url":"https://api.github.com/users/Fuud/followers","following_url":"https://api.github.com/users/Fuud/following{/other_user}","gists_url":"https://api.github.com/users/Fuud/gists{/gist_id}","starred_url":"https://api.github.com/users/Fuud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fuud/subscriptions","organizations_url":"https://api.github.com/users/Fuud/orgs","repos_url":"https://api.github.com/users/Fuud/repos","events_url":"https://api.github.com/users/Fuud/events{/privacy}","received_events_url":"https://api.github.com/users/Fuud/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-04T11:24:26Z","updated_at":"2015-09-25T17:18:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rzwitserloot/lombok/pulls/72","html_url":"https://github.com/rzwitserloot/lombok/pull/72","diff_url":"https://github.com/rzwitserloot/lombok/pull/72.diff","patch_url":"https://github.com/rzwitserloot/lombok/pull/72.patch"},"body":"As done in `org.junit.runners.BlockJUnit4ClassRunner.runIgnored` if test is ignored, `Runner` should not invoke `fireTestStarted` and `fireTestFinished`. \r\nThis issue leads to problems when running tests in IntelliJ Idea (see https://youtrack.jetbrains.com/issue/IDEA-142279)\r\n\r\nCorrect alghorithm:\r\n1. Read LombokTestSources\r\n2. If test should be ignored - invoke fireTestIgnored\r\n3. Otherwice: invoke fireTestStarted, run test, invoke fireTestFinished"},"comment":{"url":"https://api.github.com/repos/rzwitserloot/lombok/issues/comments/143292312","html_url":"https://github.com/rzwitserloot/lombok/pull/72#issuecomment-143292312","issue_url":"https://api.github.com/repos/rzwitserloot/lombok/issues/72","id":143292312,"user":{"login":"rspilker","id":93318,"avatar_url":"https://avatars.githubusercontent.com/u/93318?v=3","gravatar_id":"","url":"https://api.github.com/users/rspilker","html_url":"https://github.com/rspilker","followers_url":"https://api.github.com/users/rspilker/followers","following_url":"https://api.github.com/users/rspilker/following{/other_user}","gists_url":"https://api.github.com/users/rspilker/gists{/gist_id}","starred_url":"https://api.github.com/users/rspilker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rspilker/subscriptions","organizations_url":"https://api.github.com/users/rspilker/orgs","repos_url":"https://api.github.com/users/rspilker/repos","events_url":"https://api.github.com/users/rspilker/events{/privacy}","received_events_url":"https://api.github.com/users/rspilker/received_events","type":"User","site_admin":false},"created_at":"2015-09-25T17:18:37Z","updated_at":"2015-09-25T17:18:37Z","body":"Thanks for addressing this. I don't have IntelliJ so I cannot verify if it solves the problem.\r\n\r\nFor legal reasons we also need you to add you name in the right location to the AUTHORS file.\r\n\r\nAlso, it seems that you've also used a different code format that we do. For simple ifs and fors we don't use blocks, but place the content on the same line as the if/for. But I'm happy to correct that if you don't have the time to do that.\r\n\r\nAlso, you forgot to update the copyright years. But I can do that as well. "}}