{"action":"created","comment":{"url":"https://api.github.com/repos/epicodus/epicenter/pulls/comments/27808473","id":27808473,"diff_hunk":"@@ -1,23 +1,25 @@\n-feature 'Student signs up' do\n+feature 'Student signs up via invitation' do\n   before do\n-    @plan = FactoryGirl.create :recurring_plan_with_upfront_payment\n-    @cohort = FactoryGirl.create :future_cohort\n-    visit new_student_registration_path\n-    fill_in 'Email', with: 'example_user@example.com'\n+    @student = FactoryGirl.create(:student)\n+    @student.invite!\n+    visit accept_student_invitation_path(@student, invitation_token: @student.raw_invitation_token)\n     fill_in 'Password', with: 'password'\n     fill_in 'Password confirmation', with: 'password'\n   end","path":"spec/features/students_pages_spec.rb","position":13,"original_position":13,"commit_id":"0a3764aa4a1446a95dd486ea0605bc3d9931e795","original_commit_id":"0a3764aa4a1446a95dd486ea0605bc3d9931e795","user":{"login":"michaelrkn","id":1266530,"avatar_url":"https://avatars.githubusercontent.com/u/1266530?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelrkn","html_url":"https://github.com/michaelrkn","followers_url":"https://api.github.com/users/michaelrkn/followers","following_url":"https://api.github.com/users/michaelrkn/following{/other_user}","gists_url":"https://api.github.com/users/michaelrkn/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelrkn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelrkn/subscriptions","organizations_url":"https://api.github.com/users/michaelrkn/orgs","repos_url":"https://api.github.com/users/michaelrkn/repos","events_url":"https://api.github.com/users/michaelrkn/events{/privacy}","received_events_url":"https://api.github.com/users/michaelrkn/received_events","type":"User","site_admin":false},"body":"there's no assertion in this test","created_at":"2015-04-06T16:34:02Z","updated_at":"2015-04-06T16:34:02Z","html_url":"https://github.com/epicodus/epicenter/pull/146#discussion_r27808473","pull_request_url":"https://api.github.com/repos/epicodus/epicenter/pulls/146","_links":{"self":{"href":"https://api.github.com/repos/epicodus/epicenter/pulls/comments/27808473"},"html":{"href":"https://github.com/epicodus/epicenter/pull/146#discussion_r27808473"},"pull_request":{"href":"https://api.github.com/repos/epicodus/epicenter/pulls/146"}}},"pull_request":{"url":"https://api.github.com/repos/epicodus/epicenter/pulls/146","id":32606753,"html_url":"https://github.com/epicodus/epicenter/pull/146","diff_url":"https://github.com/epicodus/epicenter/pull/146.diff","patch_url":"https://github.com/epicodus/epicenter/pull/146.patch","issue_url":"https://api.github.com/repos/epicodus/epicenter/issues/146","number":146,"state":"open","locked":false,"title":"Inviting users","user":{"login":"jenmccarthy","id":7583165,"avatar_url":"https://avatars.githubusercontent.com/u/7583165?v=3","gravatar_id":"","url":"https://api.github.com/users/jenmccarthy","html_url":"https://github.com/jenmccarthy","followers_url":"https://api.github.com/users/jenmccarthy/followers","following_url":"https://api.github.com/users/jenmccarthy/following{/other_user}","gists_url":"https://api.github.com/users/jenmccarthy/gists{/gist_id}","starred_url":"https://api.github.com/users/jenmccarthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenmccarthy/subscriptions","organizations_url":"https://api.github.com/users/jenmccarthy/orgs","repos_url":"https://api.github.com/users/jenmccarthy/repos","events_url":"https://api.github.com/users/jenmccarthy/events{/privacy}","received_events_url":"https://api.github.com/users/jenmccarthy/received_events","type":"User","site_admin":false},"body":"An admin has the ability to invite a student to use epicenter. Let me know about the testing coverage...I've tested the integration features, but I did not test the ability for an admin to create a student. The actual inviting and accepting an invite are done magically with devise_invitable and the docs say that a Rails app won't need to include the methods to handle that.  But that means I didn't test for the functionality of that. \r\n\r\nI've removed the ability for someone to visit the new_student_registration path (student/sign_up), but that route is the ugly action controller routing error page...is there a way to build in a better error view page for that? Or does it matter?\r\n","created_at":"2015-04-03T18:30:02Z","updated_at":"2015-04-06T16:34:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/epicodus/epicenter/pulls/146/commits","review_comments_url":"https://api.github.com/repos/epicodus/epicenter/pulls/146/comments","review_comment_url":"https://api.github.com/repos/epicodus/epicenter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/epicodus/epicenter/issues/146/comments","statuses_url":"https://api.github.com/repos/epicodus/epicenter/statuses/0a3764aa4a1446a95dd486ea0605bc3d9931e795","head":{"label":"epicodus:inviting_users","ref":"inviting_users","sha":"0a3764aa4a1446a95dd486ea0605bc3d9931e795","user":{"login":"epicodus","id":3527941,"avatar_url":"https://avatars.githubusercontent.com/u/3527941?v=3","gravatar_id":"","url":"https://api.github.com/users/epicodus","html_url":"https://github.com/epicodus","followers_url":"https://api.github.com/users/epicodus/followers","following_url":"https://api.github.com/users/epicodus/following{/other_user}","gists_url":"https://api.github.com/users/epicodus/gists{/gist_id}","starred_url":"https://api.github.com/users/epicodus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epicodus/subscriptions","organizations_url":"https://api.github.com/users/epicodus/orgs","repos_url":"https://api.github.com/users/epicodus/repos","events_url":"https://api.github.com/users/epicodus/events{/privacy}","received_events_url":"https://api.github.com/users/epicodus/received_events","type":"Organization","site_admin":false},"repo":{"id":21055360,"name":"epicenter","full_name":"epicodus/epicenter","owner":{"login":"epicodus","id":3527941,"avatar_url":"https://avatars.githubusercontent.com/u/3527941?v=3","gravatar_id":"","url":"https://api.github.com/users/epicodus","html_url":"https://github.com/epicodus","followers_url":"https://api.github.com/users/epicodus/followers","following_url":"https://api.github.com/users/epicodus/following{/other_user}","gists_url":"https://api.github.com/users/epicodus/gists{/gist_id}","starred_url":"https://api.github.com/users/epicodus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epicodus/subscriptions","organizations_url":"https://api.github.com/users/epicodus/orgs","repos_url":"https://api.github.com/users/epicodus/repos","events_url":"https://api.github.com/users/epicodus/events{/privacy}","received_events_url":"https://api.github.com/users/epicodus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/epicodus/epicenter","description":"Student portal of sorts","fork":false,"url":"https://api.github.com/repos/epicodus/epicenter","forks_url":"https://api.github.com/repos/epicodus/epicenter/forks","keys_url":"https://api.github.com/repos/epicodus/epicenter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/epicodus/epicenter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/epicodus/epicenter/teams","hooks_url":"https://api.github.com/repos/epicodus/epicenter/hooks","issue_events_url":"https://api.github.com/repos/epicodus/epicenter/issues/events{/number}","events_url":"https://api.github.com/repos/epicodus/epicenter/events","assignees_url":"https://api.github.com/repos/epicodus/epicenter/assignees{/user}","branches_url":"https://api.github.com/repos/epicodus/epicenter/branches{/branch}","tags_url":"https://api.github.com/repos/epicodus/epicenter/tags","blobs_url":"https://api.github.com/repos/epicodus/epicenter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/epicodus/epicenter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/epicodus/epicenter/git/refs{/sha}","trees_url":"https://api.github.com/repos/epicodus/epicenter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/epicodus/epicenter/statuses/{sha}","languages_url":"https://api.github.com/repos/epicodus/epicenter/languages","stargazers_url":"https://api.github.com/repos/epicodus/epicenter/stargazers","contributors_url":"https://api.github.com/repos/epicodus/epicenter/contributors","subscribers_url":"https://api.github.com/repos/epicodus/epicenter/subscribers","subscription_url":"https://api.github.com/repos/epicodus/epicenter/subscription","commits_url":"https://api.github.com/repos/epicodus/epicenter/commits{/sha}","git_commits_url":"https://api.github.com/repos/epicodus/epicenter/git/commits{/sha}","comments_url":"https://api.github.com/repos/epicodus/epicenter/comments{/number}","issue_comment_url":"https://api.github.com/repos/epicodus/epicenter/issues/comments{/number}","contents_url":"https://api.github.com/repos/epicodus/epicenter/contents/{+path}","compare_url":"https://api.github.com/repos/epicodus/epicenter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/epicodus/epicenter/merges","archive_url":"https://api.github.com/repos/epicodus/epicenter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/epicodus/epicenter/downloads","issues_url":"https://api.github.com/repos/epicodus/epicenter/issues{/number}","pulls_url":"https://api.github.com/repos/epicodus/epicenter/pulls{/number}","milestones_url":"https://api.github.com/repos/epicodus/epicenter/milestones{/number}","notifications_url":"https://api.github.com/repos/epicodus/epicenter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/epicodus/epicenter/labels{/name}","releases_url":"https://api.github.com/repos/epicodus/epicenter/releases{/id}","created_at":"2014-06-20T23:19:33Z","updated_at":"2015-04-04T22:12:57Z","pushed_at":"2015-04-03T23:59:56Z","git_url":"git://github.com/epicodus/epicenter.git","ssh_url":"git@github.com:epicodus/epicenter.git","clone_url":"https://github.com/epicodus/epicenter.git","svn_url":"https://github.com/epicodus/epicenter","homepage":"","size":4622,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":19,"forks":10,"open_issues":19,"watchers":3,"default_branch":"master"}},"base":{"label":"epicodus:master","ref":"master","sha":"8a6c6cbc38149573d2bf9247e5f727cc00d8bfde","user":{"login":"epicodus","id":3527941,"avatar_url":"https://avatars.githubusercontent.com/u/3527941?v=3","gravatar_id":"","url":"https://api.github.com/users/epicodus","html_url":"https://github.com/epicodus","followers_url":"https://api.github.com/users/epicodus/followers","following_url":"https://api.github.com/users/epicodus/following{/other_user}","gists_url":"https://api.github.com/users/epicodus/gists{/gist_id}","starred_url":"https://api.github.com/users/epicodus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epicodus/subscriptions","organizations_url":"https://api.github.com/users/epicodus/orgs","repos_url":"https://api.github.com/users/epicodus/repos","events_url":"https://api.github.com/users/epicodus/events{/privacy}","received_events_url":"https://api.github.com/users/epicodus/received_events","type":"Organization","site_admin":false},"repo":{"id":21055360,"name":"epicenter","full_name":"epicodus/epicenter","owner":{"login":"epicodus","id":3527941,"avatar_url":"https://avatars.githubusercontent.com/u/3527941?v=3","gravatar_id":"","url":"https://api.github.com/users/epicodus","html_url":"https://github.com/epicodus","followers_url":"https://api.github.com/users/epicodus/followers","following_url":"https://api.github.com/users/epicodus/following{/other_user}","gists_url":"https://api.github.com/users/epicodus/gists{/gist_id}","starred_url":"https://api.github.com/users/epicodus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epicodus/subscriptions","organizations_url":"https://api.github.com/users/epicodus/orgs","repos_url":"https://api.github.com/users/epicodus/repos","events_url":"https://api.github.com/users/epicodus/events{/privacy}","received_events_url":"https://api.github.com/users/epicodus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/epicodus/epicenter","description":"Student portal of sorts","fork":false,"url":"https://api.github.com/repos/epicodus/epicenter","forks_url":"https://api.github.com/repos/epicodus/epicenter/forks","keys_url":"https://api.github.com/repos/epicodus/epicenter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/epicodus/epicenter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/epicodus/epicenter/teams","hooks_url":"https://api.github.com/repos/epicodus/epicenter/hooks","issue_events_url":"https://api.github.com/repos/epicodus/epicenter/issues/events{/number}","events_url":"https://api.github.com/repos/epicodus/epicenter/events","assignees_url":"https://api.github.com/repos/epicodus/epicenter/assignees{/user}","branches_url":"https://api.github.com/repos/epicodus/epicenter/branches{/branch}","tags_url":"https://api.github.com/repos/epicodus/epicenter/tags","blobs_url":"https://api.github.com/repos/epicodus/epicenter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/epicodus/epicenter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/epicodus/epicenter/git/refs{/sha}","trees_url":"https://api.github.com/repos/epicodus/epicenter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/epicodus/epicenter/statuses/{sha}","languages_url":"https://api.github.com/repos/epicodus/epicenter/languages","stargazers_url":"https://api.github.com/repos/epicodus/epicenter/stargazers","contributors_url":"https://api.github.com/repos/epicodus/epicenter/contributors","subscribers_url":"https://api.github.com/repos/epicodus/epicenter/subscribers","subscription_url":"https://api.github.com/repos/epicodus/epicenter/subscription","commits_url":"https://api.github.com/repos/epicodus/epicenter/commits{/sha}","git_commits_url":"https://api.github.com/repos/epicodus/epicenter/git/commits{/sha}","comments_url":"https://api.github.com/repos/epicodus/epicenter/comments{/number}","issue_comment_url":"https://api.github.com/repos/epicodus/epicenter/issues/comments{/number}","contents_url":"https://api.github.com/repos/epicodus/epicenter/contents/{+path}","compare_url":"https://api.github.com/repos/epicodus/epicenter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/epicodus/epicenter/merges","archive_url":"https://api.github.com/repos/epicodus/epicenter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/epicodus/epicenter/downloads","issues_url":"https://api.github.com/repos/epicodus/epicenter/issues{/number}","pulls_url":"https://api.github.com/repos/epicodus/epicenter/pulls{/number}","milestones_url":"https://api.github.com/repos/epicodus/epicenter/milestones{/number}","notifications_url":"https://api.github.com/repos/epicodus/epicenter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/epicodus/epicenter/labels{/name}","releases_url":"https://api.github.com/repos/epicodus/epicenter/releases{/id}","created_at":"2014-06-20T23:19:33Z","updated_at":"2015-04-04T22:12:57Z","pushed_at":"2015-04-03T23:59:56Z","git_url":"git://github.com/epicodus/epicenter.git","ssh_url":"git@github.com:epicodus/epicenter.git","clone_url":"https://github.com/epicodus/epicenter.git","svn_url":"https://github.com/epicodus/epicenter","homepage":"","size":4622,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":19,"forks":10,"open_issues":19,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/epicodus/epicenter/pulls/146"},"html":{"href":"https://github.com/epicodus/epicenter/pull/146"},"issue":{"href":"https://api.github.com/repos/epicodus/epicenter/issues/146"},"comments":{"href":"https://api.github.com/repos/epicodus/epicenter/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/epicodus/epicenter/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/epicodus/epicenter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/epicodus/epicenter/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/epicodus/epicenter/statuses/0a3764aa4a1446a95dd486ea0605bc3d9931e795"}}}}