{"action":"opened","number":171,"pull_request":{"url":"https://api.github.com/repos/sonyxperiadev/kernel/pulls/171","id":29469717,"html_url":"https://github.com/sonyxperiadev/kernel/pull/171","diff_url":"https://github.com/sonyxperiadev/kernel/pull/171.diff","patch_url":"https://github.com/sonyxperiadev/kernel/pull/171.patch","issue_url":"https://api.github.com/repos/sonyxperiadev/kernel/issues/171","number":171,"state":"open","locked":false,"title":"ARM: 8062/1: Modify ldrt fixup handler to re-execute the userspace instruction","user":{"login":"kholk","id":1922359,"avatar_url":"https://avatars.githubusercontent.com/u/1922359?v=3","gravatar_id":"","url":"https://api.github.com/users/kholk","html_url":"https://github.com/kholk","followers_url":"https://api.github.com/users/kholk/followers","following_url":"https://api.github.com/users/kholk/following{/other_user}","gists_url":"https://api.github.com/users/kholk/gists{/gist_id}","starred_url":"https://api.github.com/users/kholk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kholk/subscriptions","organizations_url":"https://api.github.com/users/kholk/orgs","repos_url":"https://api.github.com/users/kholk/repos","events_url":"https://api.github.com/users/kholk/events{/privacy}","received_events_url":"https://api.github.com/users/kholk/received_events","type":"User","site_admin":false},"body":"We will reach fixup handler when one thread(say cpu0) caused an undefined exception, while another thread(say cpu1) is unmmaping the page.\r\n\r\nFixup handler returns to the next userspace instruction which has caused the undef execption, rather than going to the same instruction.\r\n\r\nARM ARM says that after undefined exception, the PC will be pointing\r\nto the next instruction. ie +4 offset in case of ARM and +2 in case of Thumb\r\n\r\nAnd there is no correction offset passed to vector_stub in case of\r\nundef exception.\r\n\r\nFile: arch/arm/kernel/entry-armv.S +1085\r\nvector_stub     und, UND_MODE\r\n\r\nDuring an undefined exception, in normal scenario(ie when ldrt\r\ninstruction does not cause an abort) after resorting the context in\r\nVFP hardware, the PC is modified as show below before jumping to\r\nret_from_exception which is in r9.\r\n\r\nFile: arch/arm/vfp/vfphw.S +169\r\n@ The context stored in the VFP hardware is up to date with this thread\r\nvfp_hw_state_valid:\r\n   tst     r1, #FPEXC_EX\r\n   bne     process_exception     @ might as well handle the pending\r\n                                 @ exception before retrying branch\r\n                                 @ out before setting an FPEXC that\r\n                                 @ stops us reading stuff\r\n        VFPFMXR FPEXC, r1        @ Restore FPEXC last\r\n        sub     r2, r2, #4       @ Retry current instruction - if Thumb\r\n        str     r2, [sp, #S_PC]  @ mode it's two 16-bit instructions,\r\n                                 @ else it's one 32-bit instruction, so\r\n                                 @ always subtract 4 from the following\r\n                                 @ instruction address.\r\n\r\nBut if ldrt results in an abort, we reach the fixup handler and return\r\nto ret_from_execption without correcting the pc.\r\n\r\nThis patch modifes the fixup handler to re-execute the same instruction which caused undefined execption.\r\n\r\nSigned-off-by: Vinayak Menon <vinayakm.list@gmail.com>\r\nSigned-off-by: Arun KS <getarunks@gmail.com>\r\nAcked-by: Catalin Marinas <catalin.marinas@arm.com>\r\nSigned-off-by: Russell King <rmk+kernel@arm.linux.org.uk>\r\n(cherry picked from commit 3780f7ab4928bc05897a7e30cf102c20045823ef)\r\nReviewed-by: Yuanyuan Zhong <zyy@motorola.com>\r\nReviewed-by: Ye Ouyang <yeouyang@motorola.com>\r\nReviewed-by: Igor Kovalenko <igork@motorola.com>","created_at":"2015-02-17T19:24:13Z","updated_at":"2015-02-17T19:24:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sonyxperiadev/kernel/pulls/171/commits","review_comments_url":"https://api.github.com/repos/sonyxperiadev/kernel/pulls/171/comments","review_comment_url":"https://api.github.com/repos/sonyxperiadev/kernel/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sonyxperiadev/kernel/issues/171/comments","statuses_url":"https://api.github.com/repos/sonyxperiadev/kernel/statuses/74df6719577897cbf9269fe74e34e6a12f4566b3","head":{"label":"kholk:3.10_experimental","ref":"3.10_experimental","sha":"74df6719577897cbf9269fe74e34e6a12f4566b3","user":{"login":"kholk","id":1922359,"avatar_url":"https://avatars.githubusercontent.com/u/1922359?v=3","gravatar_id":"","url":"https://api.github.com/users/kholk","html_url":"https://github.com/kholk","followers_url":"https://api.github.com/users/kholk/followers","following_url":"https://api.github.com/users/kholk/following{/other_user}","gists_url":"https://api.github.com/users/kholk/gists{/gist_id}","starred_url":"https://api.github.com/users/kholk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kholk/subscriptions","organizations_url":"https://api.github.com/users/kholk/orgs","repos_url":"https://api.github.com/users/kholk/repos","events_url":"https://api.github.com/users/kholk/events{/privacy}","received_events_url":"https://api.github.com/users/kholk/received_events","type":"User","site_admin":false},"repo":{"id":29392436,"name":"kernel","full_name":"kholk/kernel","owner":{"login":"kholk","id":1922359,"avatar_url":"https://avatars.githubusercontent.com/u/1922359?v=3","gravatar_id":"","url":"https://api.github.com/users/kholk","html_url":"https://github.com/kholk","followers_url":"https://api.github.com/users/kholk/followers","following_url":"https://api.github.com/users/kholk/following{/other_user}","gists_url":"https://api.github.com/users/kholk/gists{/gist_id}","starred_url":"https://api.github.com/users/kholk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kholk/subscriptions","organizations_url":"https://api.github.com/users/kholk/orgs","repos_url":"https://api.github.com/users/kholk/repos","events_url":"https://api.github.com/users/kholk/events{/privacy}","received_events_url":"https://api.github.com/users/kholk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kholk/kernel","description":"","fork":true,"url":"https://api.github.com/repos/kholk/kernel","forks_url":"https://api.github.com/repos/kholk/kernel/forks","keys_url":"https://api.github.com/repos/kholk/kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kholk/kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kholk/kernel/teams","hooks_url":"https://api.github.com/repos/kholk/kernel/hooks","issue_events_url":"https://api.github.com/repos/kholk/kernel/issues/events{/number}","events_url":"https://api.github.com/repos/kholk/kernel/events","assignees_url":"https://api.github.com/repos/kholk/kernel/assignees{/user}","branches_url":"https://api.github.com/repos/kholk/kernel/branches{/branch}","tags_url":"https://api.github.com/repos/kholk/kernel/tags","blobs_url":"https://api.github.com/repos/kholk/kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kholk/kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kholk/kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/kholk/kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kholk/kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/kholk/kernel/languages","stargazers_url":"https://api.github.com/repos/kholk/kernel/stargazers","contributors_url":"https://api.github.com/repos/kholk/kernel/contributors","subscribers_url":"https://api.github.com/repos/kholk/kernel/subscribers","subscription_url":"https://api.github.com/repos/kholk/kernel/subscription","commits_url":"https://api.github.com/repos/kholk/kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/kholk/kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/kholk/kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/kholk/kernel/issues/comments/{number}","contents_url":"https://api.github.com/repos/kholk/kernel/contents/{+path}","compare_url":"https://api.github.com/repos/kholk/kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kholk/kernel/merges","archive_url":"https://api.github.com/repos/kholk/kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kholk/kernel/downloads","issues_url":"https://api.github.com/repos/kholk/kernel/issues{/number}","pulls_url":"https://api.github.com/repos/kholk/kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/kholk/kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/kholk/kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kholk/kernel/labels{/name}","releases_url":"https://api.github.com/repos/kholk/kernel/releases{/id}","created_at":"2015-01-17T13:47:52Z","updated_at":"2015-02-15T06:55:58Z","pushed_at":"2015-02-17T19:23:00Z","git_url":"git://github.com/kholk/kernel.git","ssh_url":"git@github.com:kholk/kernel.git","clone_url":"https://github.com/kholk/kernel.git","svn_url":"https://github.com/kholk/kernel","homepage":null,"size":831535,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"aosp/LNX.LA.3.5.2.2-03010-8x74.0"}},"base":{"label":"sonyxperiadev:aosp/AU_LINUX_ANDROID_LA.BF.2.1_RB1.05.00.00.173.012","ref":"aosp/AU_LINUX_ANDROID_LA.BF.2.1_RB1.05.00.00.173.012","sha":"5582c5699fa79f33d70a7964f4a9c3806df7e777","user":{"login":"sonyxperiadev","id":487469,"avatar_url":"https://avatars.githubusercontent.com/u/487469?v=3","gravatar_id":"","url":"https://api.github.com/users/sonyxperiadev","html_url":"https://github.com/sonyxperiadev","followers_url":"https://api.github.com/users/sonyxperiadev/followers","following_url":"https://api.github.com/users/sonyxperiadev/following{/other_user}","gists_url":"https://api.github.com/users/sonyxperiadev/gists{/gist_id}","starred_url":"https://api.github.com/users/sonyxperiadev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonyxperiadev/subscriptions","organizations_url":"https://api.github.com/users/sonyxperiadev/orgs","repos_url":"https://api.github.com/users/sonyxperiadev/repos","events_url":"https://api.github.com/users/sonyxperiadev/events{/privacy}","received_events_url":"https://api.github.com/users/sonyxperiadev/received_events","type":"User","site_admin":false},"repo":{"id":9492125,"name":"kernel","full_name":"sonyxperiadev/kernel","owner":{"login":"sonyxperiadev","id":487469,"avatar_url":"https://avatars.githubusercontent.com/u/487469?v=3","gravatar_id":"","url":"https://api.github.com/users/sonyxperiadev","html_url":"https://github.com/sonyxperiadev","followers_url":"https://api.github.com/users/sonyxperiadev/followers","following_url":"https://api.github.com/users/sonyxperiadev/following{/other_user}","gists_url":"https://api.github.com/users/sonyxperiadev/gists{/gist_id}","starred_url":"https://api.github.com/users/sonyxperiadev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonyxperiadev/subscriptions","organizations_url":"https://api.github.com/users/sonyxperiadev/orgs","repos_url":"https://api.github.com/users/sonyxperiadev/repos","events_url":"https://api.github.com/users/sonyxperiadev/events{/privacy}","received_events_url":"https://api.github.com/users/sonyxperiadev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sonyxperiadev/kernel","description":"","fork":false,"url":"https://api.github.com/repos/sonyxperiadev/kernel","forks_url":"https://api.github.com/repos/sonyxperiadev/kernel/forks","keys_url":"https://api.github.com/repos/sonyxperiadev/kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonyxperiadev/kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonyxperiadev/kernel/teams","hooks_url":"https://api.github.com/repos/sonyxperiadev/kernel/hooks","issue_events_url":"https://api.github.com/repos/sonyxperiadev/kernel/issues/events{/number}","events_url":"https://api.github.com/repos/sonyxperiadev/kernel/events","assignees_url":"https://api.github.com/repos/sonyxperiadev/kernel/assignees{/user}","branches_url":"https://api.github.com/repos/sonyxperiadev/kernel/branches{/branch}","tags_url":"https://api.github.com/repos/sonyxperiadev/kernel/tags","blobs_url":"https://api.github.com/repos/sonyxperiadev/kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonyxperiadev/kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonyxperiadev/kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonyxperiadev/kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonyxperiadev/kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/sonyxperiadev/kernel/languages","stargazers_url":"https://api.github.com/repos/sonyxperiadev/kernel/stargazers","contributors_url":"https://api.github.com/repos/sonyxperiadev/kernel/contributors","subscribers_url":"https://api.github.com/repos/sonyxperiadev/kernel/subscribers","subscription_url":"https://api.github.com/repos/sonyxperiadev/kernel/subscription","commits_url":"https://api.github.com/repos/sonyxperiadev/kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonyxperiadev/kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonyxperiadev/kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonyxperiadev/kernel/issues/comments/{number}","contents_url":"https://api.github.com/repos/sonyxperiadev/kernel/contents/{+path}","compare_url":"https://api.github.com/repos/sonyxperiadev/kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonyxperiadev/kernel/merges","archive_url":"https://api.github.com/repos/sonyxperiadev/kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonyxperiadev/kernel/downloads","issues_url":"https://api.github.com/repos/sonyxperiadev/kernel/issues{/number}","pulls_url":"https://api.github.com/repos/sonyxperiadev/kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/sonyxperiadev/kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/sonyxperiadev/kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonyxperiadev/kernel/labels{/name}","releases_url":"https://api.github.com/repos/sonyxperiadev/kernel/releases{/id}","created_at":"2013-04-17T07:47:42Z","updated_at":"2015-02-16T08:19:41Z","pushed_at":"2015-02-17T18:07:06Z","git_url":"git://github.com/sonyxperiadev/kernel.git","ssh_url":"git@github.com:sonyxperiadev/kernel.git","clone_url":"https://github.com/sonyxperiadev/kernel.git","svn_url":"https://github.com/sonyxperiadev/kernel","homepage":null,"size":1122234,"stargazers_count":39,"watchers_count":39,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":5,"forks":61,"open_issues":5,"watchers":39,"default_branch":"aosp/LNX.LA.3.5.2.2-03010-8x74.0"}},"_links":{"self":{"href":"https://api.github.com/repos/sonyxperiadev/kernel/pulls/171"},"html":{"href":"https://github.com/sonyxperiadev/kernel/pull/171"},"issue":{"href":"https://api.github.com/repos/sonyxperiadev/kernel/issues/171"},"comments":{"href":"https://api.github.com/repos/sonyxperiadev/kernel/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/sonyxperiadev/kernel/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/sonyxperiadev/kernel/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sonyxperiadev/kernel/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/sonyxperiadev/kernel/statuses/74df6719577897cbf9269fe74e34e6a12f4566b3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}