{"action":"created","issue":{"url":"https://api.github.com/repos/psi46/pxar/issues/395","labels_url":"https://api.github.com/repos/psi46/pxar/issues/395/labels{/name}","comments_url":"https://api.github.com/repos/psi46/pxar/issues/395/comments","events_url":"https://api.github.com/repos/psi46/pxar/issues/395/events","html_url":"https://github.com/psi46/pxar/pull/395","id":103279834,"number":395,"title":"Update Production from master","user":{"login":"simonspa","id":1677436,"avatar_url":"https://avatars.githubusercontent.com/u/1677436?v=3","gravatar_id":"","url":"https://api.github.com/users/simonspa","html_url":"https://github.com/simonspa","followers_url":"https://api.github.com/users/simonspa/followers","following_url":"https://api.github.com/users/simonspa/following{/other_user}","gists_url":"https://api.github.com/users/simonspa/gists{/gist_id}","starred_url":"https://api.github.com/users/simonspa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonspa/subscriptions","organizations_url":"https://api.github.com/users/simonspa/orgs","repos_url":"https://api.github.com/users/simonspa/repos","events_url":"https://api.github.com/users/simonspa/events{/privacy}","received_events_url":"https://api.github.com/users/simonspa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-08-26T14:12:51Z","updated_at":"2015-08-27T07:09:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/psi46/pxar/pulls/395","html_url":"https://github.com/psi46/pxar/pull/395","diff_url":"https://github.com/psi46/pxar/pull/395.diff","patch_url":"https://github.com/psi46/pxar/pull/395.patch"},"body":"I guess this should be fine, then we're up to the same level again."},"comment":{"url":"https://api.github.com/repos/psi46/pxar/issues/comments/135317042","html_url":"https://github.com/psi46/pxar/pull/395#issuecomment-135317042","issue_url":"https://api.github.com/repos/psi46/pxar/issues/395","id":135317042,"user":{"login":"ursl","id":5073648,"avatar_url":"https://avatars.githubusercontent.com/u/5073648?v=3","gravatar_id":"","url":"https://api.github.com/users/ursl","html_url":"https://github.com/ursl","followers_url":"https://api.github.com/users/ursl/followers","following_url":"https://api.github.com/users/ursl/following{/other_user}","gists_url":"https://api.github.com/users/ursl/gists{/gist_id}","starred_url":"https://api.github.com/users/ursl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ursl/subscriptions","organizations_url":"https://api.github.com/users/ursl/orgs","repos_url":"https://api.github.com/users/ursl/repos","events_url":"https://api.github.com/users/ursl/events{/privacy}","received_events_url":"https://api.github.com/users/ursl/received_events","type":"User","site_admin":false},"created_at":"2015-08-27T07:09:41Z","updated_at":"2015-08-27T07:09:41Z","body":"Hi Simon,\n\nthanks.\n\nThe BB and BB3 mod was pushed.\n\nFor the gain/pedestal test the current code is not the original one.\nIt is not clear that it will stay in its current form. (It seems that\neven the current \"fine-grained\" low-VCAL scan is not removing the\nspikes in the low charge range completely. But maybe I am wrong here.)\nThe original setup, still present in the high range and formerly also\nin the low range, was not relying on equidistant separation between\nthe points. Hence the loop.\n\nThis is off-topic: it is not clear to me that the \"best\" calibrations\nshould be done in the fulltest. It may be better to do them in the\n(preparation for the) xray tests, since [at least at ETH] the time\nspent in the xray setup is much less compared to the coldbox\nqualification. That could considerably speed up the fulltest. I.e. one\ncould run the trim test with ntrig = 5-10 or so and the gain/pedestal\ntest with the old settings. Only for the xray setup one would rerun\nthose tests with the required precision. The down-side of this is that\nthe -20 calibration would suffer somewhat. However, there is no reason\nwhy ntrig must be the same for both temperature ranges.\n\nCheers,\n--U.\n"}}