{"action":"created","issue":{"url":"https://api.github.com/repos/cppformat/cppformat/issues/230","labels_url":"https://api.github.com/repos/cppformat/cppformat/issues/230/labels{/name}","comments_url":"https://api.github.com/repos/cppformat/cppformat/issues/230/comments","events_url":"https://api.github.com/repos/cppformat/cppformat/issues/230/events","html_url":"https://github.com/cppformat/cppformat/pull/230","id":117406531,"number":230,"title":"fmt::format<Char, T> inefficiency #92","user":{"login":"NotImplemented","id":7337332,"avatar_url":"https://avatars.githubusercontent.com/u/7337332?v=3","gravatar_id":"","url":"https://api.github.com/users/NotImplemented","html_url":"https://github.com/NotImplemented","followers_url":"https://api.github.com/users/NotImplemented/followers","following_url":"https://api.github.com/users/NotImplemented/following{/other_user}","gists_url":"https://api.github.com/users/NotImplemented/gists{/gist_id}","starred_url":"https://api.github.com/users/NotImplemented/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NotImplemented/subscriptions","organizations_url":"https://api.github.com/users/NotImplemented/orgs","repos_url":"https://api.github.com/users/NotImplemented/repos","events_url":"https://api.github.com/users/NotImplemented/events{/privacy}","received_events_url":"https://api.github.com/users/NotImplemented/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-17T17:28:14Z","updated_at":"2015-11-18T14:55:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cppformat/cppformat/pulls/230","html_url":"https://github.com/cppformat/cppformat/pull/230","diff_url":"https://github.com/cppformat/cppformat/pull/230.diff","patch_url":"https://github.com/cppformat/cppformat/pull/230.patch"},"body":"Should we write some tests for this item? What is a proper way to run tests locally? "},"comment":{"url":"https://api.github.com/repos/cppformat/cppformat/issues/comments/157739369","html_url":"https://github.com/cppformat/cppformat/pull/230#issuecomment-157739369","issue_url":"https://api.github.com/repos/cppformat/cppformat/issues/230","id":157739369,"user":{"login":"vitaut","id":576385,"avatar_url":"https://avatars.githubusercontent.com/u/576385?v=3","gravatar_id":"","url":"https://api.github.com/users/vitaut","html_url":"https://github.com/vitaut","followers_url":"https://api.github.com/users/vitaut/followers","following_url":"https://api.github.com/users/vitaut/following{/other_user}","gists_url":"https://api.github.com/users/vitaut/gists{/gist_id}","starred_url":"https://api.github.com/users/vitaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitaut/subscriptions","organizations_url":"https://api.github.com/users/vitaut/orgs","repos_url":"https://api.github.com/users/vitaut/repos","events_url":"https://api.github.com/users/vitaut/events{/privacy}","received_events_url":"https://api.github.com/users/vitaut/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T14:55:56Z","updated_at":"2015-11-18T14:55:56Z","body":"@NotImplemented Thanks for the PR, Mike! Just two minor comments in addition to what @mwinterb wrote. The `format` function should be covered by existing tests, but it might be useful to test `basic_formatbuf`. You can run the tests locally via the `test` target (`RUN_TESTS` in MSVC), e.g.\r\n\r\n```\r\n> make test\r\n```"}}