{"action":"created","issue":{"url":"https://api.github.com/repos/stripe/stripe-ruby/issues/351","labels_url":"https://api.github.com/repos/stripe/stripe-ruby/issues/351/labels{/name}","comments_url":"https://api.github.com/repos/stripe/stripe-ruby/issues/351/comments","events_url":"https://api.github.com/repos/stripe/stripe-ruby/issues/351/events","html_url":"https://github.com/stripe/stripe-ruby/pull/351","id":117195946,"number":351,"title":"Correct URL used for refunding application fees","user":{"login":"brandur","id":96890,"avatar_url":"https://avatars.githubusercontent.com/u/96890?v=3","gravatar_id":"","url":"https://api.github.com/users/brandur","html_url":"https://github.com/brandur","followers_url":"https://api.github.com/users/brandur/followers","following_url":"https://api.github.com/users/brandur/following{/other_user}","gists_url":"https://api.github.com/users/brandur/gists{/gist_id}","starred_url":"https://api.github.com/users/brandur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandur/subscriptions","organizations_url":"https://api.github.com/users/brandur/orgs","repos_url":"https://api.github.com/users/brandur/repos","events_url":"https://api.github.com/users/brandur/events{/privacy}","received_events_url":"https://api.github.com/users/brandur/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-11-16T19:08:58Z","updated_at":"2015-11-18T23:30:04Z","closed_at":"2015-11-16T21:06:26Z","pull_request":{"url":"https://api.github.com/repos/stripe/stripe-ruby/pulls/351","html_url":"https://github.com/stripe/stripe-ruby/pull/351","diff_url":"https://github.com/stripe/stripe-ruby/pull/351.diff","patch_url":"https://github.com/stripe/stripe-ruby/pull/351.patch"},"body":"This uses the new endpoint instead of the deprecated one.\n\nRelated to stripe/stripe-php#208.\n\n/cc @russelldavies It seems like you have a fair bit of context on this one.\nWould you mind taking a look? Thanks!"},"comment":{"url":"https://api.github.com/repos/stripe/stripe-ruby/issues/comments/157898050","html_url":"https://github.com/stripe/stripe-ruby/pull/351#issuecomment-157898050","issue_url":"https://api.github.com/repos/stripe/stripe-ruby/issues/351","id":157898050,"user":{"login":"russelldavis","id":551404,"avatar_url":"https://avatars.githubusercontent.com/u/551404?v=3","gravatar_id":"","url":"https://api.github.com/users/russelldavis","html_url":"https://github.com/russelldavis","followers_url":"https://api.github.com/users/russelldavis/followers","following_url":"https://api.github.com/users/russelldavis/following{/other_user}","gists_url":"https://api.github.com/users/russelldavis/gists{/gist_id}","starred_url":"https://api.github.com/users/russelldavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russelldavis/subscriptions","organizations_url":"https://api.github.com/users/russelldavis/orgs","repos_url":"https://api.github.com/users/russelldavis/repos","events_url":"https://api.github.com/users/russelldavis/events{/privacy}","received_events_url":"https://api.github.com/users/russelldavis/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T23:30:04Z","updated_at":"2015-11-18T23:30:04Z","body":"> I think it would be much clearer to remove the method, since changing how it works would be more likely to break upgrades in a subtle way.\r\n\r\nTrue. On the other hand, if we kept the method around, it would actually turn this into a non-breaking change for any integrations that aren't using the return value of the method (if we do what I propose in #354; for example, `charge.refund; puts \"refunded #{charge.amount_refunded}\"` would continue to work). I suspect a large number of integrations would be in that camp. That alone might make it worth keeping this around.\r\n\r\n> Does this mean we should do a major-version pass to remove/cleanup all of our deprecated singular endpoints (Charge#refund, Transfer#cancel, ApplicationFee#refund, etc)?\r\n\r\nAgreed, either way we should make a major-version change consistently across all those endpoints."}}