{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/29960404","id":29960404,"diff_hunk":"@@ -204,26 +204,18 @@ internal BoundExpression AddConditionSequencePoint(BoundExpression condition, Bo\n             // EnC source mapping only operates on statements.\n             var local = _factory.SynthesizedLocal(condition.Type, containingStatement.Syntax, kind: SynthesizedLocalKind.ConditionalBranchDiscriminator);\n \n-            var condConst = condition.ConstantValue;\n-            if (condConst == null)\n-            {\n-                return new BoundSequence(\n-                    condition.Syntax,\n-                    ImmutableArray.Create(local),\n-                    ImmutableArray.Create<BoundExpression>(_factory.AssignmentExpression(_factory.Local(local), condition)),\n-                    new BoundSequencePointExpression(syntax: null, expression: _factory.Local(local), type: condition.Type),\n-                    condition.Type);\n-            }\n-            else\n-            {\n-                // const expression must stay a const to not invalidate results of control flow analysis\n-                return new BoundSequence(\n-                    condition.Syntax,\n-                    ImmutableArray.Create(local),\n-                    ImmutableArray.Create<BoundExpression>(_factory.AssignmentExpression(_factory.Local(local), condition)),\n-                    condition,\n-                    condition.Type);\n-            }\n+            // Add hidden sequence point unless the condition is a constant expression.\n+            // Constant expression must stay a const to not invalidate results of control flow analysis.\n+            var valueExpression = (condition.ConstantValue == null) ?\n+                new BoundSequencePointExpression(syntax: null, expression: _factory.Local(local), type: condition.Type) :\n+                condition;\n+\n+            return new BoundSequence(\n+                condition.Syntax,\n+                ImmutableArray.Create(local),\n+                ImmutableArray.Create<BoundExpression>(_factory.AssignmentExpression(_factory.Local(local), condition)),","path":"src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_SequencePoints.cs","position":33,"original_position":33,"commit_id":"fb7aa0f26437aac9b689d306b8bdcd2908b82966","original_commit_id":"fb7aa0f26437aac9b689d306b8bdcd2908b82966","user":{"login":"AlekseyTs","id":10522107,"avatar_url":"https://avatars.githubusercontent.com/u/10522107?v=3","gravatar_id":"","url":"https://api.github.com/users/AlekseyTs","html_url":"https://github.com/AlekseyTs","followers_url":"https://api.github.com/users/AlekseyTs/followers","following_url":"https://api.github.com/users/AlekseyTs/following{/other_user}","gists_url":"https://api.github.com/users/AlekseyTs/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseyTs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseyTs/subscriptions","organizations_url":"https://api.github.com/users/AlekseyTs/orgs","repos_url":"https://api.github.com/users/AlekseyTs/repos","events_url":"https://api.github.com/users/AlekseyTs/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseyTs/received_events","type":"User","site_admin":false},"body":"Could you please create an issue for this work then?","created_at":"2015-05-08T17:46:26Z","updated_at":"2015-05-08T17:46:26Z","html_url":"https://github.com/dotnet/roslyn/pull/2588#discussion_r29960404","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2588","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/29960404"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2588#discussion_r29960404"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2588"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/2588","id":34962784,"html_url":"https://github.com/dotnet/roslyn/pull/2588","diff_url":"https://github.com/dotnet/roslyn/pull/2588.diff","patch_url":"https://github.com/dotnet/roslyn/pull/2588.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/2588","number":2588,"state":"open","locked":false,"title":"VB EnC: when lowering conditional branches produce a pattern that allows the debugger to perform function remapping","user":{"login":"tmat","id":41759,"avatar_url":"https://avatars.githubusercontent.com/u/41759?v=3","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"body":"Mostly just porting the corresponding changes from C# with small VB specific tweaks.\r\n\r\nFixes #2411.","created_at":"2015-05-07T21:58:54Z","updated_at":"2015-05-08T17:46:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f1734e8c6280d9cb1dd9d10ebc2f40d81cfea77","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2588/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2588/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/2588/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/fb7aa0f26437aac9b689d306b8bdcd2908b82966","head":{"label":"tmat:VBConditions","ref":"VBConditions","sha":"fb7aa0f26437aac9b689d306b8bdcd2908b82966","user":{"login":"tmat","id":41759,"avatar_url":"https://avatars.githubusercontent.com/u/41759?v=3","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"repo":{"id":30440379,"name":"roslyn","full_name":"tmat/roslyn","owner":{"login":"tmat","id":41759,"avatar_url":"https://avatars.githubusercontent.com/u/41759?v=3","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmat/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/tmat/roslyn","forks_url":"https://api.github.com/repos/tmat/roslyn/forks","keys_url":"https://api.github.com/repos/tmat/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmat/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmat/roslyn/teams","hooks_url":"https://api.github.com/repos/tmat/roslyn/hooks","issue_events_url":"https://api.github.com/repos/tmat/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/tmat/roslyn/events","assignees_url":"https://api.github.com/repos/tmat/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/tmat/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/tmat/roslyn/tags","blobs_url":"https://api.github.com/repos/tmat/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmat/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmat/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmat/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmat/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/tmat/roslyn/languages","stargazers_url":"https://api.github.com/repos/tmat/roslyn/stargazers","contributors_url":"https://api.github.com/repos/tmat/roslyn/contributors","subscribers_url":"https://api.github.com/repos/tmat/roslyn/subscribers","subscription_url":"https://api.github.com/repos/tmat/roslyn/subscription","commits_url":"https://api.github.com/repos/tmat/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmat/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmat/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmat/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmat/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/tmat/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmat/roslyn/merges","archive_url":"https://api.github.com/repos/tmat/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmat/roslyn/downloads","issues_url":"https://api.github.com/repos/tmat/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/tmat/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/tmat/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/tmat/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmat/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/tmat/roslyn/releases{/id}","created_at":"2015-02-07T01:09:01Z","updated_at":"2015-05-07T22:23:32Z","pushed_at":"2015-05-08T02:31:10Z","git_url":"git://github.com/tmat/roslyn.git","ssh_url":"git@github.com:tmat/roslyn.git","clone_url":"https://github.com/tmat/roslyn.git","svn_url":"https://github.com/tmat/roslyn","homepage":"","size":75410,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"f07c32aa3e7e138ab3810267efa23529d7286aef","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-05-08T16:43:30Z","pushed_at":"2015-05-08T16:43:32Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":127358,"stargazers_count":2233,"watchers_count":2233,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":469,"mirror_url":null,"open_issues_count":787,"forks":469,"open_issues":787,"watchers":2233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2588"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2588"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2588"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2588/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2588/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2588/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/fb7aa0f26437aac9b689d306b8bdcd2908b82966"}}}}