{"action":"created","issue":{"url":"https://api.github.com/repos/uikit/uikit/issues/1025","labels_url":"https://api.github.com/repos/uikit/uikit/issues/1025/labels{/name}","comments_url":"https://api.github.com/repos/uikit/uikit/issues/1025/comments","events_url":"https://api.github.com/repos/uikit/uikit/issues/1025/events","html_url":"https://github.com/uikit/uikit/issues/1025","id":59254208,"number":1025,"title":"Button: Padding instead of line-height for top/bottom","user":{"login":"zslabs","id":1018402,"avatar_url":"https://avatars.githubusercontent.com/u/1018402?v=3","gravatar_id":"","url":"https://api.github.com/users/zslabs","html_url":"https://github.com/zslabs","followers_url":"https://api.github.com/users/zslabs/followers","following_url":"https://api.github.com/users/zslabs/following{/other_user}","gists_url":"https://api.github.com/users/zslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/zslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zslabs/subscriptions","organizations_url":"https://api.github.com/users/zslabs/orgs","repos_url":"https://api.github.com/users/zslabs/repos","events_url":"https://api.github.com/users/zslabs/events{/privacy}","received_events_url":"https://api.github.com/users/zslabs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-27T15:54:51Z","updated_at":"2015-02-27T16:39:04Z","closed_at":null,"body":"I'd much rather prefer a button's top/bottom padding to be set than by line-height. If your text wraps to two lines... it's pretty darn ugly."},"comment":{"url":"https://api.github.com/repos/uikit/uikit/issues/comments/76425197","html_url":"https://github.com/uikit/uikit/issues/1025#issuecomment-76425197","issue_url":"https://api.github.com/repos/uikit/uikit/issues/1025","id":76425197,"user":{"login":"mcraiganthony","id":1093578,"avatar_url":"https://avatars.githubusercontent.com/u/1093578?v=3","gravatar_id":"","url":"https://api.github.com/users/mcraiganthony","html_url":"https://github.com/mcraiganthony","followers_url":"https://api.github.com/users/mcraiganthony/followers","following_url":"https://api.github.com/users/mcraiganthony/following{/other_user}","gists_url":"https://api.github.com/users/mcraiganthony/gists{/gist_id}","starred_url":"https://api.github.com/users/mcraiganthony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcraiganthony/subscriptions","organizations_url":"https://api.github.com/users/mcraiganthony/orgs","repos_url":"https://api.github.com/users/mcraiganthony/repos","events_url":"https://api.github.com/users/mcraiganthony/events{/privacy}","received_events_url":"https://api.github.com/users/mcraiganthony/received_events","type":"User","site_admin":false},"created_at":"2015-02-27T16:39:04Z","updated_at":"2015-02-27T16:39:04Z","body":"Using line-height and min-height to set the heights of buttons is problematic. As @zslabs mentioned, if text wraps within a button you are screwed.\r\n\r\nWith unitless line-height and top/bottom padding, buttons will be significantly more flexible. This allows the button heights to fall where they may ... based on font and font-size.\r\n\r\nBelow is a comparison between Bootstrap and UIKit. Stylistic differences aside, you can see that the stacked text inside of the Bootstrap button is more presentable.\r\n\r\n![btns](https://cloud.githubusercontent.com/assets/1093578/6416540/ddd75d4c-be74-11e4-837e-c18f4d8ac3be.png)\r\n\r\nThanks!\r\n"}}