{"action":"created","issue":{"url":"https://api.github.com/repos/angular/tactical/issues/25","labels_url":"https://api.github.com/repos/angular/tactical/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/angular/tactical/issues/25/comments","events_url":"https://api.github.com/repos/angular/tactical/issues/25/events","html_url":"https://github.com/angular/tactical/pull/25","id":93341547,"number":25,"title":"Integrate Tactical Store and Data Manager","user":{"login":"alxhub","id":4175141,"avatar_url":"https://avatars.githubusercontent.com/u/4175141?v=3","gravatar_id":"","url":"https://api.github.com/users/alxhub","html_url":"https://github.com/alxhub","followers_url":"https://api.github.com/users/alxhub/followers","following_url":"https://api.github.com/users/alxhub/following{/other_user}","gists_url":"https://api.github.com/users/alxhub/gists{/gist_id}","starred_url":"https://api.github.com/users/alxhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxhub/subscriptions","organizations_url":"https://api.github.com/users/alxhub/orgs","repos_url":"https://api.github.com/users/alxhub/repos","events_url":"https://api.github.com/users/alxhub/events{/privacy}","received_events_url":"https://api.github.com/users/alxhub/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ttowncompiled","id":4161445,"avatar_url":"https://avatars.githubusercontent.com/u/4161445?v=3","gravatar_id":"","url":"https://api.github.com/users/ttowncompiled","html_url":"https://github.com/ttowncompiled","followers_url":"https://api.github.com/users/ttowncompiled/followers","following_url":"https://api.github.com/users/ttowncompiled/following{/other_user}","gists_url":"https://api.github.com/users/ttowncompiled/gists{/gist_id}","starred_url":"https://api.github.com/users/ttowncompiled/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttowncompiled/subscriptions","organizations_url":"https://api.github.com/users/ttowncompiled/orgs","repos_url":"https://api.github.com/users/ttowncompiled/repos","events_url":"https://api.github.com/users/ttowncompiled/events{/privacy}","received_events_url":"https://api.github.com/users/ttowncompiled/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/angular/tactical/milestones/3","html_url":"https://github.com/angular/tactical/milestones/M3:%20Read-only%20integration","labels_url":"https://api.github.com/repos/angular/tactical/milestones/3/labels","id":1171425,"number":3,"title":"M3: Read-only integration","description":"Components work together to support offline read-only access to data from a live backend.","creator":{"login":"alxhub","id":4175141,"avatar_url":"https://avatars.githubusercontent.com/u/4175141?v=3","gravatar_id":"","url":"https://api.github.com/users/alxhub","html_url":"https://github.com/alxhub","followers_url":"https://api.github.com/users/alxhub/followers","following_url":"https://api.github.com/users/alxhub/following{/other_user}","gists_url":"https://api.github.com/users/alxhub/gists{/gist_id}","starred_url":"https://api.github.com/users/alxhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxhub/subscriptions","organizations_url":"https://api.github.com/users/alxhub/orgs","repos_url":"https://api.github.com/users/alxhub/repos","events_url":"https://api.github.com/users/alxhub/events{/privacy}","received_events_url":"https://api.github.com/users/alxhub/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2015-06-18T20:47:46Z","updated_at":"2015-07-06T18:35:40Z","due_on":"2015-07-10T07:00:00Z","closed_at":null},"comments":5,"created_at":"2015-07-06T18:20:35Z","updated_at":"2015-07-06T22:29:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular/tactical/pulls/25","html_url":"https://github.com/angular/tactical/pull/25","diff_url":"https://github.com/angular/tactical/pull/25.diff","patch_url":"https://github.com/angular/tactical/pull/25.patch"},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/angular/tactical/25)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/angular/tactical/issues/comments/119016333","html_url":"https://github.com/angular/tactical/pull/25#issuecomment-119016333","issue_url":"https://api.github.com/repos/angular/tactical/issues/25","id":119016333,"user":{"login":"alxhub","id":4175141,"avatar_url":"https://avatars.githubusercontent.com/u/4175141?v=3","gravatar_id":"","url":"https://api.github.com/users/alxhub","html_url":"https://github.com/alxhub","followers_url":"https://api.github.com/users/alxhub/followers","following_url":"https://api.github.com/users/alxhub/following{/other_user}","gists_url":"https://api.github.com/users/alxhub/gists{/gist_id}","starred_url":"https://api.github.com/users/alxhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxhub/subscriptions","organizations_url":"https://api.github.com/users/alxhub/orgs","repos_url":"https://api.github.com/users/alxhub/repos","events_url":"https://api.github.com/users/alxhub/events{/privacy}","received_events_url":"https://api.github.com/users/alxhub/received_events","type":"User","site_admin":false},"created_at":"2015-07-06T22:29:16Z","updated_at":"2015-07-06T22:29:16Z","body":"\n\n\n\nReview status: 0 of 3 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.\n\n---\n\n<sup>**[modules/tactical/src/data_manager.ts, line 34 \\[r1\\]](https://reviewable.io:443/reviews/angular/tactical/25#-Jt_MsSpBwkGUlTeoGi1-r1-34)** ([raw file](https://github.com/angular/tactical/blob/cb754ccb86d914aef86c30fbaf8499e64783faee/modules/tactical/src/data_manager.ts#L34)):</sup>\nIn general I believe in documenting internal members where it makes sense - when their usage or purpose may not be obvious to someone unfamiliar with the code. I believe that makes projects more friendly for \"light\" contributors or new team members. (Internal documentation would be a huge improvement to the Angular2 repo, in my opinion).\n\n---\n\n<sup>**[modules/tactical/src/data_manager.ts, line 43 \\[r1\\]](https://reviewable.io:443/reviews/angular/tactical/25#-Jt_MsSpBwkGUlTeoGi1-r1-43)** ([raw file](https://github.com/angular/tactical/blob/cb754ccb86d914aef86c30fbaf8499e64783faee/modules/tactical/src/data_manager.ts#L43)):</sup>\nI didn't, the API from Tactical Store is Ian's. I think we need to have a more detailed discussion of when to use hot or cold observables.\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/angular/tactical/25)\n<!-- Sent from Reviewable.io -->\n"}}