{"action":"created","comment":{"url":"https://api.github.com/repos/pushtorefresh/storio/pulls/comments/32786400","id":32786400,"diff_hunk":"@@ -98,11 +97,23 @@ static DeleteObjectsStub newInstanceForDeleteMultipleObjectsWithTypeMapping() {\n     }\n \n     @NonNull\n-    static DeleteObjectsStub newInstanceForDeleteOneObject() {\n+    static DeleteObjectsStub newInstanceForDeleteOneObjectWithoutTypeMapping() {\n         return new DeleteObjectsStub(false, 1);\n     }\n \n+    @NonNull\n+    static DeleteObjectsStub newInstanceForDeleteOneObjectWithTypeMapping() {\n+        return new DeleteObjectsStub(true, 1);\n+    }\n+\n     void verifyBehaviorForDeleteMultipleObjects(@NonNull DeleteResults<TestItem> deleteResults) {\n+        verify(storIOContentResolver).delete();\n+\n+        if (withTypeMapping || items.size() > 1) {\n+            // should be called only once because of Performance!\n+            verify(storIOContentResolver).internal();\n+        }","path":"storio-content-resolver/src/test/java/com/pushtorefresh/storio/contentresolver/operation/delete/DeleteObjectsStub.java","position":59,"original_position":59,"commit_id":"cdf64d596ee79ede68126a784014a0102cddd1c2","original_commit_id":"cdf64d596ee79ede68126a784014a0102cddd1c2","user":{"login":"nikitin-da","id":7294857,"avatar_url":"https://avatars.githubusercontent.com/u/7294857?v=3","gravatar_id":"","url":"https://api.github.com/users/nikitin-da","html_url":"https://github.com/nikitin-da","followers_url":"https://api.github.com/users/nikitin-da/followers","following_url":"https://api.github.com/users/nikitin-da/following{/other_user}","gists_url":"https://api.github.com/users/nikitin-da/gists{/gist_id}","starred_url":"https://api.github.com/users/nikitin-da/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikitin-da/subscriptions","organizations_url":"https://api.github.com/users/nikitin-da/orgs","repos_url":"https://api.github.com/users/nikitin-da/repos","events_url":"https://api.github.com/users/nikitin-da/events{/privacy}","received_events_url":"https://api.github.com/users/nikitin-da/received_events","type":"User","site_admin":false},"body":"In `PutObjectStub` you could also check that otherwise `internal()` was never call. \r\nIs it also possible for delete?","created_at":"2015-06-18T22:38:25Z","updated_at":"2015-06-18T22:38:25Z","html_url":"https://github.com/pushtorefresh/storio/pull/402#discussion_r32786400","pull_request_url":"https://api.github.com/repos/pushtorefresh/storio/pulls/402","_links":{"self":{"href":"https://api.github.com/repos/pushtorefresh/storio/pulls/comments/32786400"},"html":{"href":"https://github.com/pushtorefresh/storio/pull/402#discussion_r32786400"},"pull_request":{"href":"https://api.github.com/repos/pushtorefresh/storio/pulls/402"}}},"pull_request":{"url":"https://api.github.com/repos/pushtorefresh/storio/pulls/402","id":38059723,"html_url":"https://github.com/pushtorefresh/storio/pull/402","diff_url":"https://github.com/pushtorefresh/storio/pull/402.diff","patch_url":"https://github.com/pushtorefresh/storio/pull/402.patch","issue_url":"https://api.github.com/repos/pushtorefresh/storio/issues/402","number":402,"state":"open","locked":false,"title":"Delete object type mapping error handling","user":{"login":"artem-zinnatullin","id":967132,"avatar_url":"https://avatars.githubusercontent.com/u/967132?v=3","gravatar_id":"","url":"https://api.github.com/users/artem-zinnatullin","html_url":"https://github.com/artem-zinnatullin","followers_url":"https://api.github.com/users/artem-zinnatullin/followers","following_url":"https://api.github.com/users/artem-zinnatullin/following{/other_user}","gists_url":"https://api.github.com/users/artem-zinnatullin/gists{/gist_id}","starred_url":"https://api.github.com/users/artem-zinnatullin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artem-zinnatullin/subscriptions","organizations_url":"https://api.github.com/users/artem-zinnatullin/orgs","repos_url":"https://api.github.com/users/artem-zinnatullin/repos","events_url":"https://api.github.com/users/artem-zinnatullin/events{/privacy}","received_events_url":"https://api.github.com/users/artem-zinnatullin/received_events","type":"User","site_admin":false},"body":"Part of #396.\r\n\r\n@nikitin-da PTAL","created_at":"2015-06-18T22:23:32Z","updated_at":"2015-06-18T22:38:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"316ab49d2f882cc6785b735438430ea49238bf1d","assignee":{"login":"nikitin-da","id":7294857,"avatar_url":"https://avatars.githubusercontent.com/u/7294857?v=3","gravatar_id":"","url":"https://api.github.com/users/nikitin-da","html_url":"https://github.com/nikitin-da","followers_url":"https://api.github.com/users/nikitin-da/followers","following_url":"https://api.github.com/users/nikitin-da/following{/other_user}","gists_url":"https://api.github.com/users/nikitin-da/gists{/gist_id}","starred_url":"https://api.github.com/users/nikitin-da/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikitin-da/subscriptions","organizations_url":"https://api.github.com/users/nikitin-da/orgs","repos_url":"https://api.github.com/users/nikitin-da/repos","events_url":"https://api.github.com/users/nikitin-da/events{/privacy}","received_events_url":"https://api.github.com/users/nikitin-da/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/pushtorefresh/storio/milestones/6","html_url":"https://github.com/pushtorefresh/storio/milestones/v1.0.0","labels_url":"https://api.github.com/repos/pushtorefresh/storio/milestones/6/labels","id":789775,"number":6,"title":"v1.0.0","description":"","creator":{"login":"artem-zinnatullin","id":967132,"avatar_url":"https://avatars.githubusercontent.com/u/967132?v=3","gravatar_id":"","url":"https://api.github.com/users/artem-zinnatullin","html_url":"https://github.com/artem-zinnatullin","followers_url":"https://api.github.com/users/artem-zinnatullin/followers","following_url":"https://api.github.com/users/artem-zinnatullin/following{/other_user}","gists_url":"https://api.github.com/users/artem-zinnatullin/gists{/gist_id}","starred_url":"https://api.github.com/users/artem-zinnatullin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artem-zinnatullin/subscriptions","organizations_url":"https://api.github.com/users/artem-zinnatullin/orgs","repos_url":"https://api.github.com/users/artem-zinnatullin/repos","events_url":"https://api.github.com/users/artem-zinnatullin/events{/privacy}","received_events_url":"https://api.github.com/users/artem-zinnatullin/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":312,"state":"open","created_at":"2014-09-15T11:57:16Z","updated_at":"2015-06-18T22:31:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/pushtorefresh/storio/pulls/402/commits","review_comments_url":"https://api.github.com/repos/pushtorefresh/storio/pulls/402/comments","review_comment_url":"https://api.github.com/repos/pushtorefresh/storio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pushtorefresh/storio/issues/402/comments","statuses_url":"https://api.github.com/repos/pushtorefresh/storio/statuses/cdf64d596ee79ede68126a784014a0102cddd1c2","head":{"label":"pushtorefresh:storio-content-resolver-delete-object","ref":"storio-content-resolver-delete-object","sha":"cdf64d596ee79ede68126a784014a0102cddd1c2","user":{"login":"pushtorefresh","id":7294803,"avatar_url":"https://avatars.githubusercontent.com/u/7294803?v=3","gravatar_id":"","url":"https://api.github.com/users/pushtorefresh","html_url":"https://github.com/pushtorefresh","followers_url":"https://api.github.com/users/pushtorefresh/followers","following_url":"https://api.github.com/users/pushtorefresh/following{/other_user}","gists_url":"https://api.github.com/users/pushtorefresh/gists{/gist_id}","starred_url":"https://api.github.com/users/pushtorefresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pushtorefresh/subscriptions","organizations_url":"https://api.github.com/users/pushtorefresh/orgs","repos_url":"https://api.github.com/users/pushtorefresh/repos","events_url":"https://api.github.com/users/pushtorefresh/events{/privacy}","received_events_url":"https://api.github.com/users/pushtorefresh/received_events","type":"Organization","site_admin":false},"repo":{"id":23502577,"name":"storio","full_name":"pushtorefresh/storio","owner":{"login":"pushtorefresh","id":7294803,"avatar_url":"https://avatars.githubusercontent.com/u/7294803?v=3","gravatar_id":"","url":"https://api.github.com/users/pushtorefresh","html_url":"https://github.com/pushtorefresh","followers_url":"https://api.github.com/users/pushtorefresh/followers","following_url":"https://api.github.com/users/pushtorefresh/following{/other_user}","gists_url":"https://api.github.com/users/pushtorefresh/gists{/gist_id}","starred_url":"https://api.github.com/users/pushtorefresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pushtorefresh/subscriptions","organizations_url":"https://api.github.com/users/pushtorefresh/orgs","repos_url":"https://api.github.com/users/pushtorefresh/repos","events_url":"https://api.github.com/users/pushtorefresh/events{/privacy}","received_events_url":"https://api.github.com/users/pushtorefresh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pushtorefresh/storio","description":"Modern API for SQLiteDatabase and ContentResolver","fork":false,"url":"https://api.github.com/repos/pushtorefresh/storio","forks_url":"https://api.github.com/repos/pushtorefresh/storio/forks","keys_url":"https://api.github.com/repos/pushtorefresh/storio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pushtorefresh/storio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pushtorefresh/storio/teams","hooks_url":"https://api.github.com/repos/pushtorefresh/storio/hooks","issue_events_url":"https://api.github.com/repos/pushtorefresh/storio/issues/events{/number}","events_url":"https://api.github.com/repos/pushtorefresh/storio/events","assignees_url":"https://api.github.com/repos/pushtorefresh/storio/assignees{/user}","branches_url":"https://api.github.com/repos/pushtorefresh/storio/branches{/branch}","tags_url":"https://api.github.com/repos/pushtorefresh/storio/tags","blobs_url":"https://api.github.com/repos/pushtorefresh/storio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pushtorefresh/storio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pushtorefresh/storio/git/refs{/sha}","trees_url":"https://api.github.com/repos/pushtorefresh/storio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pushtorefresh/storio/statuses/{sha}","languages_url":"https://api.github.com/repos/pushtorefresh/storio/languages","stargazers_url":"https://api.github.com/repos/pushtorefresh/storio/stargazers","contributors_url":"https://api.github.com/repos/pushtorefresh/storio/contributors","subscribers_url":"https://api.github.com/repos/pushtorefresh/storio/subscribers","subscription_url":"https://api.github.com/repos/pushtorefresh/storio/subscription","commits_url":"https://api.github.com/repos/pushtorefresh/storio/commits{/sha}","git_commits_url":"https://api.github.com/repos/pushtorefresh/storio/git/commits{/sha}","comments_url":"https://api.github.com/repos/pushtorefresh/storio/comments{/number}","issue_comment_url":"https://api.github.com/repos/pushtorefresh/storio/issues/comments{/number}","contents_url":"https://api.github.com/repos/pushtorefresh/storio/contents/{+path}","compare_url":"https://api.github.com/repos/pushtorefresh/storio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pushtorefresh/storio/merges","archive_url":"https://api.github.com/repos/pushtorefresh/storio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pushtorefresh/storio/downloads","issues_url":"https://api.github.com/repos/pushtorefresh/storio/issues{/number}","pulls_url":"https://api.github.com/repos/pushtorefresh/storio/pulls{/number}","milestones_url":"https://api.github.com/repos/pushtorefresh/storio/milestones{/number}","notifications_url":"https://api.github.com/repos/pushtorefresh/storio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pushtorefresh/storio/labels{/name}","releases_url":"https://api.github.com/repos/pushtorefresh/storio/releases{/id}","created_at":"2014-08-30T23:23:41Z","updated_at":"2015-06-18T10:28:34Z","pushed_at":"2015-06-18T22:31:11Z","git_url":"git://github.com/pushtorefresh/storio.git","ssh_url":"git@github.com:pushtorefresh/storio.git","clone_url":"https://github.com/pushtorefresh/storio.git","svn_url":"https://github.com/pushtorefresh/storio","homepage":"","size":4096,"stargazers_count":282,"watchers_count":282,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":24,"forks":13,"open_issues":24,"watchers":282,"default_branch":"master"}},"base":{"label":"pushtorefresh:master","ref":"master","sha":"369e6d0209228e3e15b6ac08957a52265d9a2b51","user":{"login":"pushtorefresh","id":7294803,"avatar_url":"https://avatars.githubusercontent.com/u/7294803?v=3","gravatar_id":"","url":"https://api.github.com/users/pushtorefresh","html_url":"https://github.com/pushtorefresh","followers_url":"https://api.github.com/users/pushtorefresh/followers","following_url":"https://api.github.com/users/pushtorefresh/following{/other_user}","gists_url":"https://api.github.com/users/pushtorefresh/gists{/gist_id}","starred_url":"https://api.github.com/users/pushtorefresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pushtorefresh/subscriptions","organizations_url":"https://api.github.com/users/pushtorefresh/orgs","repos_url":"https://api.github.com/users/pushtorefresh/repos","events_url":"https://api.github.com/users/pushtorefresh/events{/privacy}","received_events_url":"https://api.github.com/users/pushtorefresh/received_events","type":"Organization","site_admin":false},"repo":{"id":23502577,"name":"storio","full_name":"pushtorefresh/storio","owner":{"login":"pushtorefresh","id":7294803,"avatar_url":"https://avatars.githubusercontent.com/u/7294803?v=3","gravatar_id":"","url":"https://api.github.com/users/pushtorefresh","html_url":"https://github.com/pushtorefresh","followers_url":"https://api.github.com/users/pushtorefresh/followers","following_url":"https://api.github.com/users/pushtorefresh/following{/other_user}","gists_url":"https://api.github.com/users/pushtorefresh/gists{/gist_id}","starred_url":"https://api.github.com/users/pushtorefresh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pushtorefresh/subscriptions","organizations_url":"https://api.github.com/users/pushtorefresh/orgs","repos_url":"https://api.github.com/users/pushtorefresh/repos","events_url":"https://api.github.com/users/pushtorefresh/events{/privacy}","received_events_url":"https://api.github.com/users/pushtorefresh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pushtorefresh/storio","description":"Modern API for SQLiteDatabase and ContentResolver","fork":false,"url":"https://api.github.com/repos/pushtorefresh/storio","forks_url":"https://api.github.com/repos/pushtorefresh/storio/forks","keys_url":"https://api.github.com/repos/pushtorefresh/storio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pushtorefresh/storio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pushtorefresh/storio/teams","hooks_url":"https://api.github.com/repos/pushtorefresh/storio/hooks","issue_events_url":"https://api.github.com/repos/pushtorefresh/storio/issues/events{/number}","events_url":"https://api.github.com/repos/pushtorefresh/storio/events","assignees_url":"https://api.github.com/repos/pushtorefresh/storio/assignees{/user}","branches_url":"https://api.github.com/repos/pushtorefresh/storio/branches{/branch}","tags_url":"https://api.github.com/repos/pushtorefresh/storio/tags","blobs_url":"https://api.github.com/repos/pushtorefresh/storio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pushtorefresh/storio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pushtorefresh/storio/git/refs{/sha}","trees_url":"https://api.github.com/repos/pushtorefresh/storio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pushtorefresh/storio/statuses/{sha}","languages_url":"https://api.github.com/repos/pushtorefresh/storio/languages","stargazers_url":"https://api.github.com/repos/pushtorefresh/storio/stargazers","contributors_url":"https://api.github.com/repos/pushtorefresh/storio/contributors","subscribers_url":"https://api.github.com/repos/pushtorefresh/storio/subscribers","subscription_url":"https://api.github.com/repos/pushtorefresh/storio/subscription","commits_url":"https://api.github.com/repos/pushtorefresh/storio/commits{/sha}","git_commits_url":"https://api.github.com/repos/pushtorefresh/storio/git/commits{/sha}","comments_url":"https://api.github.com/repos/pushtorefresh/storio/comments{/number}","issue_comment_url":"https://api.github.com/repos/pushtorefresh/storio/issues/comments{/number}","contents_url":"https://api.github.com/repos/pushtorefresh/storio/contents/{+path}","compare_url":"https://api.github.com/repos/pushtorefresh/storio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pushtorefresh/storio/merges","archive_url":"https://api.github.com/repos/pushtorefresh/storio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pushtorefresh/storio/downloads","issues_url":"https://api.github.com/repos/pushtorefresh/storio/issues{/number}","pulls_url":"https://api.github.com/repos/pushtorefresh/storio/pulls{/number}","milestones_url":"https://api.github.com/repos/pushtorefresh/storio/milestones{/number}","notifications_url":"https://api.github.com/repos/pushtorefresh/storio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pushtorefresh/storio/labels{/name}","releases_url":"https://api.github.com/repos/pushtorefresh/storio/releases{/id}","created_at":"2014-08-30T23:23:41Z","updated_at":"2015-06-18T10:28:34Z","pushed_at":"2015-06-18T22:31:11Z","git_url":"git://github.com/pushtorefresh/storio.git","ssh_url":"git@github.com:pushtorefresh/storio.git","clone_url":"https://github.com/pushtorefresh/storio.git","svn_url":"https://github.com/pushtorefresh/storio","homepage":"","size":4096,"stargazers_count":282,"watchers_count":282,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":24,"forks":13,"open_issues":24,"watchers":282,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pushtorefresh/storio/pulls/402"},"html":{"href":"https://github.com/pushtorefresh/storio/pull/402"},"issue":{"href":"https://api.github.com/repos/pushtorefresh/storio/issues/402"},"comments":{"href":"https://api.github.com/repos/pushtorefresh/storio/issues/402/comments"},"review_comments":{"href":"https://api.github.com/repos/pushtorefresh/storio/pulls/402/comments"},"review_comment":{"href":"https://api.github.com/repos/pushtorefresh/storio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pushtorefresh/storio/pulls/402/commits"},"statuses":{"href":"https://api.github.com/repos/pushtorefresh/storio/statuses/cdf64d596ee79ede68126a784014a0102cddd1c2"}}}}