{"action":"closed","number":23,"pull_request":{"url":"https://api.github.com/repos/github/generator-hubot/pulls/23","id":28401572,"html_url":"https://github.com/github/generator-hubot/pull/23","diff_url":"https://github.com/github/generator-hubot/pull/23.diff","patch_url":"https://github.com/github/generator-hubot/pull/23.patch","issue_url":"https://api.github.com/repos/github/generator-hubot/issues/23","number":23,"state":"closed","locked":false,"title":"Fix option parsing to prevent trying to install `hubot-true`","user":{"login":"technicalpickles","id":159,"avatar_url":"https://avatars.githubusercontent.com/u/159?v=3","gravatar_id":"","url":"https://api.github.com/users/technicalpickles","html_url":"https://github.com/technicalpickles","followers_url":"https://api.github.com/users/technicalpickles/followers","following_url":"https://api.github.com/users/technicalpickles/following{/other_user}","gists_url":"https://api.github.com/users/technicalpickles/gists{/gist_id}","starred_url":"https://api.github.com/users/technicalpickles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technicalpickles/subscriptions","organizations_url":"https://api.github.com/users/technicalpickles/orgs","repos_url":"https://api.github.com/users/technicalpickles/repos","events_url":"https://api.github.com/users/technicalpickles/events{/privacy}","received_events_url":"https://api.github.com/users/technicalpickles/received_events","type":"User","site_admin":true},"body":"This is a possible fix to https://github.com/github/hubot/issues/838 . Currently, if you say `yo hubot --adapter slack`, the adapter ends up being set to `true`.\r\n\r\nThis PR specifies a type for each option to String or Boolean. It doesn't seem to quite prevent the bad behavior yet, so needs some work:\r\n\r\n```\r\n2.1.4-github ~/src/scratchbot \r\n$ yo hubot --adapter\r\n                     _____________________________\r\n                    /                             \\\r\n   //\\              |      Extracting input for    |\r\n  ////\\    _____    |   self-replication process   |\r\n //////\\  /_____\\   \\                             /\r\n ======= |[^_/\\_]|   /----------------------------\r\n  |   | _|___@@__|__\r\n  +===+/  ///     \\_\\\r\n   | |_\\ /// HUBOT/\\\\\r\n   |___/\\//      /  \\\\\r\n         \\      /   +---+\r\n          \\____/    |   |\r\n           | //|    +===+\r\n            \\//      |xx|\r\n\r\n? Owner: Josh Nichols <technicalpickles@github.com>\r\n? Bot name: scratchbot\r\n? Description: A simple helpful robot for your Company\r\nidentical bin/hubot\r\nidentical bin/hubot.cmd\r\nidentical Procfile\r\nidentical README.md\r\nidentical external-scripts.json\r\nidentical hubot-scripts.json\r\nidentical .editorconfig\r\n                     _____________________________\r\n _____              /                             \\\r\n \\    \\             |   Self-replication process   |\r\n |    |    _____    |          complete...         |\r\n |__\\\\|   /_____\\   \\     Good luck with that.    /\r\n   |//+  |[^_/\\_]|   /----------------------------\r\n  |   | _|___@@__|__\r\n  +===+/  ///     \\_\\\r\n   | |_\\ /// HUBOT/\\\\\r\n   |___/\\//      /  \\\\\r\n         \\      /   +---+\r\n          \\____/    |   |\r\n           | //|    +===+\r\n            \\//      |xx|\r\n\r\nnpm ERR! Darwin 14.0.0\r\nnpm ERR! argv \"node\" \"/opt/boxen/nodenv/versions/v0.10/bin/npm\" \"install\" \"hubot\" \"hubot-scripts\" \"hubot-diagnostics\" \"hubot-help\" \"hubot-heroku-keepalive\" \"hubot-google-images\" \"hubot-google-translate\" \"hubot-pugme\" \"hubot-maps\" \"hubot-redis-brain\" \"hubot-rules\" \"hubot-shipit\" \"hubot-youtube\" \"hubot-true\" \"--save\"\r\nnpm ERR! node v0.10.21\r\nnpm ERR! npm  v2.1.11\r\nnpm ERR! code E404\r\n\r\nnpm ERR! 404 Not Found: hubot-true\r\nnpm ERR! 404\r\nnpm ERR! 404 'hubot-true' is not in the npm registry.\r\nnpm ERR! 404 You should bug the author to publish it (or use the name yourself!)\r\nnpm ERR! 404 It was specified as a dependency of 'scratchbot'\r\nnpm ERR! 404\r\nnpm ERR! 404 Note that you can also install from a\r\nnpm ERR! 404 tarball, folder, http url, or git url.\r\n```","created_at":"2015-01-30T23:17:04Z","updated_at":"2015-01-30T23:36:57Z","closed_at":"2015-01-30T23:36:57Z","merged_at":"2015-01-30T23:36:57Z","merge_commit_sha":"2fc8b1e1981eeae242f95c9e6442cbc98b0d40e0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/github/generator-hubot/pulls/23/commits","review_comments_url":"https://api.github.com/repos/github/generator-hubot/pulls/23/comments","review_comment_url":"https://api.github.com/repos/github/generator-hubot/pulls/comments/{number}","comments_url":"https://api.github.com/repos/github/generator-hubot/issues/23/comments","statuses_url":"https://api.github.com/repos/github/generator-hubot/statuses/b3ead6c4db5f671397461f38abecda32753af69b","head":{"label":"github:specify-option-types","ref":"specify-option-types","sha":"b3ead6c4db5f671397461f38abecda32753af69b","user":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":23335023,"name":"generator-hubot","full_name":"github/generator-hubot","owner":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/generator-hubot","description":"Hubot generator for Yeoman","fork":false,"url":"https://api.github.com/repos/github/generator-hubot","forks_url":"https://api.github.com/repos/github/generator-hubot/forks","keys_url":"https://api.github.com/repos/github/generator-hubot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/generator-hubot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/generator-hubot/teams","hooks_url":"https://api.github.com/repos/github/generator-hubot/hooks","issue_events_url":"https://api.github.com/repos/github/generator-hubot/issues/events{/number}","events_url":"https://api.github.com/repos/github/generator-hubot/events","assignees_url":"https://api.github.com/repos/github/generator-hubot/assignees{/user}","branches_url":"https://api.github.com/repos/github/generator-hubot/branches{/branch}","tags_url":"https://api.github.com/repos/github/generator-hubot/tags","blobs_url":"https://api.github.com/repos/github/generator-hubot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/generator-hubot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/generator-hubot/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/generator-hubot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/generator-hubot/statuses/{sha}","languages_url":"https://api.github.com/repos/github/generator-hubot/languages","stargazers_url":"https://api.github.com/repos/github/generator-hubot/stargazers","contributors_url":"https://api.github.com/repos/github/generator-hubot/contributors","subscribers_url":"https://api.github.com/repos/github/generator-hubot/subscribers","subscription_url":"https://api.github.com/repos/github/generator-hubot/subscription","commits_url":"https://api.github.com/repos/github/generator-hubot/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/generator-hubot/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/generator-hubot/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/generator-hubot/issues/comments/{number}","contents_url":"https://api.github.com/repos/github/generator-hubot/contents/{+path}","compare_url":"https://api.github.com/repos/github/generator-hubot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/generator-hubot/merges","archive_url":"https://api.github.com/repos/github/generator-hubot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/generator-hubot/downloads","issues_url":"https://api.github.com/repos/github/generator-hubot/issues{/number}","pulls_url":"https://api.github.com/repos/github/generator-hubot/pulls{/number}","milestones_url":"https://api.github.com/repos/github/generator-hubot/milestones{/number}","notifications_url":"https://api.github.com/repos/github/generator-hubot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/generator-hubot/labels{/name}","releases_url":"https://api.github.com/repos/github/generator-hubot/releases{/id}","created_at":"2014-08-26T01:48:28Z","updated_at":"2015-01-30T23:36:58Z","pushed_at":"2015-01-30T23:36:58Z","git_url":"git://github.com/github/generator-hubot.git","ssh_url":"git@github.com:github/generator-hubot.git","clone_url":"https://github.com/github/generator-hubot.git","svn_url":"https://github.com/github/generator-hubot","homepage":null,"size":496,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":7,"forks":11,"open_issues":7,"watchers":27,"default_branch":"master"}},"base":{"label":"github:master","ref":"master","sha":"c63f8c52c6b07a03a8291c088abab72bd0b7af5b","user":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":23335023,"name":"generator-hubot","full_name":"github/generator-hubot","owner":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/generator-hubot","description":"Hubot generator for Yeoman","fork":false,"url":"https://api.github.com/repos/github/generator-hubot","forks_url":"https://api.github.com/repos/github/generator-hubot/forks","keys_url":"https://api.github.com/repos/github/generator-hubot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/generator-hubot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/generator-hubot/teams","hooks_url":"https://api.github.com/repos/github/generator-hubot/hooks","issue_events_url":"https://api.github.com/repos/github/generator-hubot/issues/events{/number}","events_url":"https://api.github.com/repos/github/generator-hubot/events","assignees_url":"https://api.github.com/repos/github/generator-hubot/assignees{/user}","branches_url":"https://api.github.com/repos/github/generator-hubot/branches{/branch}","tags_url":"https://api.github.com/repos/github/generator-hubot/tags","blobs_url":"https://api.github.com/repos/github/generator-hubot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/generator-hubot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/generator-hubot/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/generator-hubot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/generator-hubot/statuses/{sha}","languages_url":"https://api.github.com/repos/github/generator-hubot/languages","stargazers_url":"https://api.github.com/repos/github/generator-hubot/stargazers","contributors_url":"https://api.github.com/repos/github/generator-hubot/contributors","subscribers_url":"https://api.github.com/repos/github/generator-hubot/subscribers","subscription_url":"https://api.github.com/repos/github/generator-hubot/subscription","commits_url":"https://api.github.com/repos/github/generator-hubot/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/generator-hubot/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/generator-hubot/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/generator-hubot/issues/comments/{number}","contents_url":"https://api.github.com/repos/github/generator-hubot/contents/{+path}","compare_url":"https://api.github.com/repos/github/generator-hubot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/generator-hubot/merges","archive_url":"https://api.github.com/repos/github/generator-hubot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/generator-hubot/downloads","issues_url":"https://api.github.com/repos/github/generator-hubot/issues{/number}","pulls_url":"https://api.github.com/repos/github/generator-hubot/pulls{/number}","milestones_url":"https://api.github.com/repos/github/generator-hubot/milestones{/number}","notifications_url":"https://api.github.com/repos/github/generator-hubot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/generator-hubot/labels{/name}","releases_url":"https://api.github.com/repos/github/generator-hubot/releases{/id}","created_at":"2014-08-26T01:48:28Z","updated_at":"2015-01-30T23:36:58Z","pushed_at":"2015-01-30T23:36:58Z","git_url":"git://github.com/github/generator-hubot.git","ssh_url":"git@github.com:github/generator-hubot.git","clone_url":"https://github.com/github/generator-hubot.git","svn_url":"https://github.com/github/generator-hubot","homepage":null,"size":496,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":7,"forks":11,"open_issues":7,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/github/generator-hubot/pulls/23"},"html":{"href":"https://github.com/github/generator-hubot/pull/23"},"issue":{"href":"https://api.github.com/repos/github/generator-hubot/issues/23"},"comments":{"href":"https://api.github.com/repos/github/generator-hubot/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/github/generator-hubot/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/github/generator-hubot/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/github/generator-hubot/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/github/generator-hubot/statuses/b3ead6c4db5f671397461f38abecda32753af69b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"technicalpickles","id":159,"avatar_url":"https://avatars.githubusercontent.com/u/159?v=3","gravatar_id":"","url":"https://api.github.com/users/technicalpickles","html_url":"https://github.com/technicalpickles","followers_url":"https://api.github.com/users/technicalpickles/followers","following_url":"https://api.github.com/users/technicalpickles/following{/other_user}","gists_url":"https://api.github.com/users/technicalpickles/gists{/gist_id}","starred_url":"https://api.github.com/users/technicalpickles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technicalpickles/subscriptions","organizations_url":"https://api.github.com/users/technicalpickles/orgs","repos_url":"https://api.github.com/users/technicalpickles/repos","events_url":"https://api.github.com/users/technicalpickles/events{/privacy}","received_events_url":"https://api.github.com/users/technicalpickles/received_events","type":"User","site_admin":true},"comments":1,"review_comments":0,"commits":2,"additions":40,"deletions":5,"changed_files":1}}