{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/files_antivirus/pulls/comments/36509130","id":36509130,"diff_hunk":"@@ -14,6 +14,15 @@ public static function sendMail($path){\n \t\t\treturn;\n \t\t}\n \t\t$email = \\OCP\\Config::getUserValue(\\OCP\\User::getUser(), 'settings', 'email', '');\n+\t\tif (\\OCP\\App::isEnabled(user_ldap)){","path":"lib/notification.php","position":4,"original_position":4,"commit_id":"aed8076965a6ffe06f57ac39b0f93880eeb92b10","original_commit_id":"aed8076965a6ffe06f57ac39b0f93880eeb92b10","user":{"login":"RostC","id":7700349,"avatar_url":"https://avatars.githubusercontent.com/u/7700349?v=3","gravatar_id":"","url":"https://api.github.com/users/RostC","html_url":"https://github.com/RostC","followers_url":"https://api.github.com/users/RostC/followers","following_url":"https://api.github.com/users/RostC/following{/other_user}","gists_url":"https://api.github.com/users/RostC/gists{/gist_id}","starred_url":"https://api.github.com/users/RostC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RostC/subscriptions","organizations_url":"https://api.github.com/users/RostC/orgs","repos_url":"https://api.github.com/users/RostC/repos","events_url":"https://api.github.com/users/RostC/events{/privacy}","received_events_url":"https://api.github.com/users/RostC/received_events","type":"User","site_admin":false},"body":"I think it depends on what's the correct value in database. It is not helpful (in my opinion) if the mailheader looks like \r\nD14AB3F9-08F1-43AE-B83D-1D678A8A5416 <mail@myhost.com>\r\nshould be\r\nMy Name <mail@myhost.com>","created_at":"2015-08-07T10:59:54Z","updated_at":"2015-08-07T10:59:54Z","html_url":"https://github.com/owncloud/files_antivirus/pull/67#discussion_r36509130","pull_request_url":"https://api.github.com/repos/owncloud/files_antivirus/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/owncloud/files_antivirus/pulls/comments/36509130"},"html":{"href":"https://github.com/owncloud/files_antivirus/pull/67#discussion_r36509130"},"pull_request":{"href":"https://api.github.com/repos/owncloud/files_antivirus/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/files_antivirus/pulls/67","id":41732643,"html_url":"https://github.com/owncloud/files_antivirus/pull/67","diff_url":"https://github.com/owncloud/files_antivirus/pull/67.diff","patch_url":"https://github.com/owncloud/files_antivirus/pull/67.patch","issue_url":"https://api.github.com/repos/owncloud/files_antivirus/issues/67","number":67,"state":"open","locked":false,"title":"change recipient name if user_ldap is used","user":{"login":"RostC","id":7700349,"avatar_url":"https://avatars.githubusercontent.com/u/7700349?v=3","gravatar_id":"","url":"https://api.github.com/users/RostC","html_url":"https://github.com/RostC","followers_url":"https://api.github.com/users/RostC/followers","following_url":"https://api.github.com/users/RostC/following{/other_user}","gists_url":"https://api.github.com/users/RostC/gists{/gist_id}","starred_url":"https://api.github.com/users/RostC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RostC/subscriptions","organizations_url":"https://api.github.com/users/RostC/orgs","repos_url":"https://api.github.com/users/RostC/repos","events_url":"https://api.github.com/users/RostC/events{/privacy}","received_events_url":"https://api.github.com/users/RostC/received_events","type":"User","site_admin":false},"body":"fixes: #66 \r\nPossible solution to check if user_ldap is used and use then an other attribute as recipient name","created_at":"2015-08-05T22:15:33Z","updated_at":"2015-08-07T10:59:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97b10ea9f6cb341bcf0a2506a348cbcaae93edec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/files_antivirus/pulls/67/commits","review_comments_url":"https://api.github.com/repos/owncloud/files_antivirus/pulls/67/comments","review_comment_url":"https://api.github.com/repos/owncloud/files_antivirus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/files_antivirus/issues/67/comments","statuses_url":"https://api.github.com/repos/owncloud/files_antivirus/statuses/aed8076965a6ffe06f57ac39b0f93880eeb92b10","head":{"label":"RostC:master","ref":"master","sha":"aed8076965a6ffe06f57ac39b0f93880eeb92b10","user":{"login":"RostC","id":7700349,"avatar_url":"https://avatars.githubusercontent.com/u/7700349?v=3","gravatar_id":"","url":"https://api.github.com/users/RostC","html_url":"https://github.com/RostC","followers_url":"https://api.github.com/users/RostC/followers","following_url":"https://api.github.com/users/RostC/following{/other_user}","gists_url":"https://api.github.com/users/RostC/gists{/gist_id}","starred_url":"https://api.github.com/users/RostC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RostC/subscriptions","organizations_url":"https://api.github.com/users/RostC/orgs","repos_url":"https://api.github.com/users/RostC/repos","events_url":"https://api.github.com/users/RostC/events{/privacy}","received_events_url":"https://api.github.com/users/RostC/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"owncloud:master","ref":"master","sha":"7d69e6ab28db2d6f1e8d5e97bbe5899288dab893","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":26599712,"name":"files_antivirus","full_name":"owncloud/files_antivirus","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/files_antivirus","description":"","fork":false,"url":"https://api.github.com/repos/owncloud/files_antivirus","forks_url":"https://api.github.com/repos/owncloud/files_antivirus/forks","keys_url":"https://api.github.com/repos/owncloud/files_antivirus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/files_antivirus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/files_antivirus/teams","hooks_url":"https://api.github.com/repos/owncloud/files_antivirus/hooks","issue_events_url":"https://api.github.com/repos/owncloud/files_antivirus/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/files_antivirus/events","assignees_url":"https://api.github.com/repos/owncloud/files_antivirus/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/files_antivirus/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/files_antivirus/tags","blobs_url":"https://api.github.com/repos/owncloud/files_antivirus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/files_antivirus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/files_antivirus/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/files_antivirus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/files_antivirus/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/files_antivirus/languages","stargazers_url":"https://api.github.com/repos/owncloud/files_antivirus/stargazers","contributors_url":"https://api.github.com/repos/owncloud/files_antivirus/contributors","subscribers_url":"https://api.github.com/repos/owncloud/files_antivirus/subscribers","subscription_url":"https://api.github.com/repos/owncloud/files_antivirus/subscription","commits_url":"https://api.github.com/repos/owncloud/files_antivirus/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/files_antivirus/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/files_antivirus/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/files_antivirus/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/files_antivirus/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/files_antivirus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/files_antivirus/merges","archive_url":"https://api.github.com/repos/owncloud/files_antivirus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/files_antivirus/downloads","issues_url":"https://api.github.com/repos/owncloud/files_antivirus/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/files_antivirus/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/files_antivirus/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/files_antivirus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/files_antivirus/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/files_antivirus/releases{/id}","created_at":"2014-11-13T17:40:58Z","updated_at":"2015-06-28T23:30:22Z","pushed_at":"2015-08-05T22:15:33Z","git_url":"git://github.com/owncloud/files_antivirus.git","ssh_url":"git@github.com:owncloud/files_antivirus.git","clone_url":"https://github.com/owncloud/files_antivirus.git","svn_url":"https://github.com/owncloud/files_antivirus","homepage":null,"size":1463,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/files_antivirus/pulls/67"},"html":{"href":"https://github.com/owncloud/files_antivirus/pull/67"},"issue":{"href":"https://api.github.com/repos/owncloud/files_antivirus/issues/67"},"comments":{"href":"https://api.github.com/repos/owncloud/files_antivirus/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/files_antivirus/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/files_antivirus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/files_antivirus/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/files_antivirus/statuses/aed8076965a6ffe06f57ac39b0f93880eeb92b10"}}}}