{"action":"closed","number":4108,"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4108","id":34120284,"html_url":"https://github.com/silverstripe/silverstripe-framework/pull/4108","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/4108.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/4108.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4108","number":4108,"state":"closed","locked":false,"title":"Fix/Performance: Combine multiple queries into one for ManyManyList::getExtraData","user":{"login":"Turnerj","id":904226,"avatar_url":"https://avatars.githubusercontent.com/u/904226?v=3","gravatar_id":"","url":"https://api.github.com/users/Turnerj","html_url":"https://github.com/Turnerj","followers_url":"https://api.github.com/users/Turnerj/followers","following_url":"https://api.github.com/users/Turnerj/following{/other_user}","gists_url":"https://api.github.com/users/Turnerj/gists{/gist_id}","starred_url":"https://api.github.com/users/Turnerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turnerj/subscriptions","organizations_url":"https://api.github.com/users/Turnerj/orgs","repos_url":"https://api.github.com/users/Turnerj/repos","events_url":"https://api.github.com/users/Turnerj/events{/privacy}","received_events_url":"https://api.github.com/users/Turnerj/received_events","type":"User","site_admin":false},"body":"Previously when calling `getExtraData`, it would take an individual query per extra field to get the data. This PR adjusts that to combine each field into the single query. Beyond passing an array to the `SQLQuery` and looping over the columns in the result, the functionality hasn't changed.\r\n\r\n`GridFieldDetailForm_ItemRequest` is the only reference in Framework or CMS that actually uses the `getExtraData` function.","created_at":"2015-04-26T09:16:19Z","updated_at":"2015-05-28T22:26:56Z","closed_at":"2015-05-28T22:26:56Z","merged_at":"2015-05-28T22:26:56Z","merge_commit_sha":"0e2c8e6e020970845c5c937b93c0c273b3efaed1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4108/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4108/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4108/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/485f4c3b18cd49793d540030b7a1fdf0f0ac26c6","head":{"label":"Turnerj:fix/many-many-extrafields-performance","ref":"fix/many-many-extrafields-performance","sha":"485f4c3b18cd49793d540030b7a1fdf0f0ac26c6","user":{"login":"Turnerj","id":904226,"avatar_url":"https://avatars.githubusercontent.com/u/904226?v=3","gravatar_id":"","url":"https://api.github.com/users/Turnerj","html_url":"https://github.com/Turnerj","followers_url":"https://api.github.com/users/Turnerj/followers","following_url":"https://api.github.com/users/Turnerj/following{/other_user}","gists_url":"https://api.github.com/users/Turnerj/gists{/gist_id}","starred_url":"https://api.github.com/users/Turnerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turnerj/subscriptions","organizations_url":"https://api.github.com/users/Turnerj/orgs","repos_url":"https://api.github.com/users/Turnerj/repos","events_url":"https://api.github.com/users/Turnerj/events{/privacy}","received_events_url":"https://api.github.com/users/Turnerj/received_events","type":"User","site_admin":false},"repo":{"id":31801167,"name":"silverstripe-framework","full_name":"Turnerj/silverstripe-framework","owner":{"login":"Turnerj","id":904226,"avatar_url":"https://avatars.githubusercontent.com/u/904226?v=3","gravatar_id":"","url":"https://api.github.com/users/Turnerj","html_url":"https://github.com/Turnerj","followers_url":"https://api.github.com/users/Turnerj/followers","following_url":"https://api.github.com/users/Turnerj/following{/other_user}","gists_url":"https://api.github.com/users/Turnerj/gists{/gist_id}","starred_url":"https://api.github.com/users/Turnerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turnerj/subscriptions","organizations_url":"https://api.github.com/users/Turnerj/orgs","repos_url":"https://api.github.com/users/Turnerj/repos","events_url":"https://api.github.com/users/Turnerj/events{/privacy}","received_events_url":"https://api.github.com/users/Turnerj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Turnerj/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":true,"url":"https://api.github.com/repos/Turnerj/silverstripe-framework","forks_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/Turnerj/silverstripe-framework/releases{/id}","created_at":"2015-03-07T04:38:30Z","updated_at":"2015-03-07T04:38:34Z","pushed_at":"2015-04-26T09:04:57Z","git_url":"git://github.com/Turnerj/silverstripe-framework.git","ssh_url":"git@github.com:Turnerj/silverstripe-framework.git","clone_url":"https://github.com/Turnerj/silverstripe-framework.git","svn_url":"https://github.com/Turnerj/silverstripe-framework","homepage":"http://silverstripe.org/","size":50301,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.1"}},"base":{"label":"silverstripe:3","ref":"3","sha":"6c069ce7d51a2042f5600291309955f7278968ce","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1318892,"name":"silverstripe-framework","full_name":"silverstripe/silverstripe-framework","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-framework","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/releases{/id}","created_at":"2011-02-02T02:04:13Z","updated_at":"2015-05-24T15:08:47Z","pushed_at":"2015-05-28T22:26:56Z","git_url":"git://github.com/silverstripe/silverstripe-framework.git","ssh_url":"git@github.com:silverstripe/silverstripe-framework.git","clone_url":"https://github.com/silverstripe/silverstripe-framework.git","svn_url":"https://github.com/silverstripe/silverstripe-framework","homepage":"http://silverstripe.org/","size":105690,"stargazers_count":447,"watchers_count":447,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":495,"mirror_url":null,"open_issues_count":629,"forks":495,"open_issues":629,"watchers":447,"default_branch":"3.1"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4108"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/4108"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4108"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4108/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4108/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4108/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/485f4c3b18cd49793d540030b7a1fdf0f0ac26c6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":14,"deletions":10,"changed_files":1}}