{"action":"created","comment":{"url":"https://api.github.com/repos/codemix/yii2-localeurls/pulls/comments/29554338","id":29554338,"diff_hunk":"@@ -356,7 +360,7 @@ protected function redirectToLanguage($language)\n \n         Yii::$app->getResponse()->redirect($redirectUrl);\n         if (YII_ENV_TEST) {\n-            throw new \\yii\\base\\Exception($redirectUrl);\n+            throw new \\yii\\base\\Exception(\\yii\\helpers\\Url::to($redirectUrl));","path":"UrlManager.php","position":16,"original_position":16,"commit_id":"18e929fd10de343ffb2089757804af1e435257d8","original_commit_id":"18e929fd10de343ffb2089757804af1e435257d8","user":{"login":"MetalGuardian","id":1168520,"avatar_url":"https://avatars.githubusercontent.com/u/1168520?v=3","gravatar_id":"","url":"https://api.github.com/users/MetalGuardian","html_url":"https://github.com/MetalGuardian","followers_url":"https://api.github.com/users/MetalGuardian/followers","following_url":"https://api.github.com/users/MetalGuardian/following{/other_user}","gists_url":"https://api.github.com/users/MetalGuardian/gists{/gist_id}","starred_url":"https://api.github.com/users/MetalGuardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetalGuardian/subscriptions","organizations_url":"https://api.github.com/users/MetalGuardian/orgs","repos_url":"https://api.github.com/users/MetalGuardian/repos","events_url":"https://api.github.com/users/MetalGuardian/events{/privacy}","received_events_url":"https://api.github.com/users/MetalGuardian/received_events","type":"User","site_admin":false},"body":"this is for correct test assert, because redirect call this function and change the result url","created_at":"2015-05-03T09:17:16Z","updated_at":"2015-05-03T09:17:16Z","html_url":"https://github.com/codemix/yii2-localeurls/pull/18#discussion_r29554338","pull_request_url":"https://api.github.com/repos/codemix/yii2-localeurls/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/codemix/yii2-localeurls/pulls/comments/29554338"},"html":{"href":"https://github.com/codemix/yii2-localeurls/pull/18#discussion_r29554338"},"pull_request":{"href":"https://api.github.com/repos/codemix/yii2-localeurls/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/codemix/yii2-localeurls/pulls/18","id":34589179,"html_url":"https://github.com/codemix/yii2-localeurls/pull/18","diff_url":"https://github.com/codemix/yii2-localeurls/pull/18.diff","patch_url":"https://github.com/codemix/yii2-localeurls/pull/18.patch","issue_url":"https://api.github.com/repos/codemix/yii2-localeurls/issues/18","number":18,"state":"open","locked":false,"title":"fix infinity redirects","user":{"login":"MetalGuardian","id":1168520,"avatar_url":"https://avatars.githubusercontent.com/u/1168520?v=3","gravatar_id":"","url":"https://api.github.com/users/MetalGuardian","html_url":"https://github.com/MetalGuardian","followers_url":"https://api.github.com/users/MetalGuardian/followers","following_url":"https://api.github.com/users/MetalGuardian/following{/other_user}","gists_url":"https://api.github.com/users/MetalGuardian/gists{/gist_id}","starred_url":"https://api.github.com/users/MetalGuardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetalGuardian/subscriptions","organizations_url":"https://api.github.com/users/MetalGuardian/orgs","repos_url":"https://api.github.com/users/MetalGuardian/repos","events_url":"https://api.github.com/users/MetalGuardian/events{/privacy}","received_events_url":"https://api.github.com/users/MetalGuardian/received_events","type":"User","site_admin":false},"body":"Hi\r\nthis is fix infinity redirects, when i put default language in url: http://example.com/en\r\nbecause of [this](https://github.com/yiisoft/yii2/blob/master/framework/helpers/BaseUrl.php#L207) redirectUrl changes back to /en and go in redirection loop","created_at":"2015-05-02T18:00:00Z","updated_at":"2015-05-03T09:17:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b3e9d1b58681c7ddd78b0a45c583e453aed1506","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/codemix/yii2-localeurls/pulls/18/commits","review_comments_url":"https://api.github.com/repos/codemix/yii2-localeurls/pulls/18/comments","review_comment_url":"https://api.github.com/repos/codemix/yii2-localeurls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codemix/yii2-localeurls/issues/18/comments","statuses_url":"https://api.github.com/repos/codemix/yii2-localeurls/statuses/18e929fd10de343ffb2089757804af1e435257d8","head":{"label":"MetalGuardian:master","ref":"master","sha":"18e929fd10de343ffb2089757804af1e435257d8","user":{"login":"MetalGuardian","id":1168520,"avatar_url":"https://avatars.githubusercontent.com/u/1168520?v=3","gravatar_id":"","url":"https://api.github.com/users/MetalGuardian","html_url":"https://github.com/MetalGuardian","followers_url":"https://api.github.com/users/MetalGuardian/followers","following_url":"https://api.github.com/users/MetalGuardian/following{/other_user}","gists_url":"https://api.github.com/users/MetalGuardian/gists{/gist_id}","starred_url":"https://api.github.com/users/MetalGuardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetalGuardian/subscriptions","organizations_url":"https://api.github.com/users/MetalGuardian/orgs","repos_url":"https://api.github.com/users/MetalGuardian/repos","events_url":"https://api.github.com/users/MetalGuardian/events{/privacy}","received_events_url":"https://api.github.com/users/MetalGuardian/received_events","type":"User","site_admin":false},"repo":{"id":34957579,"name":"yii2-localeurls","full_name":"MetalGuardian/yii2-localeurls","owner":{"login":"MetalGuardian","id":1168520,"avatar_url":"https://avatars.githubusercontent.com/u/1168520?v=3","gravatar_id":"","url":"https://api.github.com/users/MetalGuardian","html_url":"https://github.com/MetalGuardian","followers_url":"https://api.github.com/users/MetalGuardian/followers","following_url":"https://api.github.com/users/MetalGuardian/following{/other_user}","gists_url":"https://api.github.com/users/MetalGuardian/gists{/gist_id}","starred_url":"https://api.github.com/users/MetalGuardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetalGuardian/subscriptions","organizations_url":"https://api.github.com/users/MetalGuardian/orgs","repos_url":"https://api.github.com/users/MetalGuardian/repos","events_url":"https://api.github.com/users/MetalGuardian/events{/privacy}","received_events_url":"https://api.github.com/users/MetalGuardian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MetalGuardian/yii2-localeurls","description":"Automatic locale/language management for URLs","fork":true,"url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls","forks_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/forks","keys_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/teams","hooks_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/hooks","issue_events_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/issues/events{/number}","events_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/events","assignees_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/assignees{/user}","branches_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/branches{/branch}","tags_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/tags","blobs_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/git/refs{/sha}","trees_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/statuses/{sha}","languages_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/languages","stargazers_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/stargazers","contributors_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/contributors","subscribers_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/subscribers","subscription_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/subscription","commits_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/commits{/sha}","git_commits_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/git/commits{/sha}","comments_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/comments{/number}","issue_comment_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/issues/comments{/number}","contents_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/contents/{+path}","compare_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/merges","archive_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/downloads","issues_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/issues{/number}","pulls_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/pulls{/number}","milestones_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/milestones{/number}","notifications_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/labels{/name}","releases_url":"https://api.github.com/repos/MetalGuardian/yii2-localeurls/releases{/id}","created_at":"2015-05-02T17:52:39Z","updated_at":"2015-05-02T18:45:15Z","pushed_at":"2015-05-02T18:45:14Z","git_url":"git://github.com/MetalGuardian/yii2-localeurls.git","ssh_url":"git@github.com:MetalGuardian/yii2-localeurls.git","clone_url":"https://github.com/MetalGuardian/yii2-localeurls.git","svn_url":"https://github.com/MetalGuardian/yii2-localeurls","homepage":null,"size":443,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codemix:master","ref":"master","sha":"81dc6600934b4c90983db995311a87c69826c702","user":{"login":"codemix","id":4009461,"avatar_url":"https://avatars.githubusercontent.com/u/4009461?v=3","gravatar_id":"","url":"https://api.github.com/users/codemix","html_url":"https://github.com/codemix","followers_url":"https://api.github.com/users/codemix/followers","following_url":"https://api.github.com/users/codemix/following{/other_user}","gists_url":"https://api.github.com/users/codemix/gists{/gist_id}","starred_url":"https://api.github.com/users/codemix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemix/subscriptions","organizations_url":"https://api.github.com/users/codemix/orgs","repos_url":"https://api.github.com/users/codemix/repos","events_url":"https://api.github.com/users/codemix/events{/privacy}","received_events_url":"https://api.github.com/users/codemix/received_events","type":"Organization","site_admin":false},"repo":{"id":25207823,"name":"yii2-localeurls","full_name":"codemix/yii2-localeurls","owner":{"login":"codemix","id":4009461,"avatar_url":"https://avatars.githubusercontent.com/u/4009461?v=3","gravatar_id":"","url":"https://api.github.com/users/codemix","html_url":"https://github.com/codemix","followers_url":"https://api.github.com/users/codemix/followers","following_url":"https://api.github.com/users/codemix/following{/other_user}","gists_url":"https://api.github.com/users/codemix/gists{/gist_id}","starred_url":"https://api.github.com/users/codemix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemix/subscriptions","organizations_url":"https://api.github.com/users/codemix/orgs","repos_url":"https://api.github.com/users/codemix/repos","events_url":"https://api.github.com/users/codemix/events{/privacy}","received_events_url":"https://api.github.com/users/codemix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codemix/yii2-localeurls","description":"Automatic locale/language management for URLs","fork":false,"url":"https://api.github.com/repos/codemix/yii2-localeurls","forks_url":"https://api.github.com/repos/codemix/yii2-localeurls/forks","keys_url":"https://api.github.com/repos/codemix/yii2-localeurls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codemix/yii2-localeurls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codemix/yii2-localeurls/teams","hooks_url":"https://api.github.com/repos/codemix/yii2-localeurls/hooks","issue_events_url":"https://api.github.com/repos/codemix/yii2-localeurls/issues/events{/number}","events_url":"https://api.github.com/repos/codemix/yii2-localeurls/events","assignees_url":"https://api.github.com/repos/codemix/yii2-localeurls/assignees{/user}","branches_url":"https://api.github.com/repos/codemix/yii2-localeurls/branches{/branch}","tags_url":"https://api.github.com/repos/codemix/yii2-localeurls/tags","blobs_url":"https://api.github.com/repos/codemix/yii2-localeurls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codemix/yii2-localeurls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codemix/yii2-localeurls/git/refs{/sha}","trees_url":"https://api.github.com/repos/codemix/yii2-localeurls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codemix/yii2-localeurls/statuses/{sha}","languages_url":"https://api.github.com/repos/codemix/yii2-localeurls/languages","stargazers_url":"https://api.github.com/repos/codemix/yii2-localeurls/stargazers","contributors_url":"https://api.github.com/repos/codemix/yii2-localeurls/contributors","subscribers_url":"https://api.github.com/repos/codemix/yii2-localeurls/subscribers","subscription_url":"https://api.github.com/repos/codemix/yii2-localeurls/subscription","commits_url":"https://api.github.com/repos/codemix/yii2-localeurls/commits{/sha}","git_commits_url":"https://api.github.com/repos/codemix/yii2-localeurls/git/commits{/sha}","comments_url":"https://api.github.com/repos/codemix/yii2-localeurls/comments{/number}","issue_comment_url":"https://api.github.com/repos/codemix/yii2-localeurls/issues/comments{/number}","contents_url":"https://api.github.com/repos/codemix/yii2-localeurls/contents/{+path}","compare_url":"https://api.github.com/repos/codemix/yii2-localeurls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codemix/yii2-localeurls/merges","archive_url":"https://api.github.com/repos/codemix/yii2-localeurls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codemix/yii2-localeurls/downloads","issues_url":"https://api.github.com/repos/codemix/yii2-localeurls/issues{/number}","pulls_url":"https://api.github.com/repos/codemix/yii2-localeurls/pulls{/number}","milestones_url":"https://api.github.com/repos/codemix/yii2-localeurls/milestones{/number}","notifications_url":"https://api.github.com/repos/codemix/yii2-localeurls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codemix/yii2-localeurls/labels{/name}","releases_url":"https://api.github.com/repos/codemix/yii2-localeurls/releases{/id}","created_at":"2014-10-14T13:20:42Z","updated_at":"2015-05-02T07:45:28Z","pushed_at":"2015-05-02T18:45:15Z","git_url":"git://github.com/codemix/yii2-localeurls.git","ssh_url":"git@github.com:codemix/yii2-localeurls.git","clone_url":"https://github.com/codemix/yii2-localeurls.git","svn_url":"https://github.com/codemix/yii2-localeurls","homepage":null,"size":443,"stargazers_count":57,"watchers_count":57,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codemix/yii2-localeurls/pulls/18"},"html":{"href":"https://github.com/codemix/yii2-localeurls/pull/18"},"issue":{"href":"https://api.github.com/repos/codemix/yii2-localeurls/issues/18"},"comments":{"href":"https://api.github.com/repos/codemix/yii2-localeurls/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/codemix/yii2-localeurls/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/codemix/yii2-localeurls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codemix/yii2-localeurls/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/codemix/yii2-localeurls/statuses/18e929fd10de343ffb2089757804af1e435257d8"}}}}