{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/30275619","id":30275619,"diff_hunk":"@@ -389,4 +389,16 @@ def test_to_s__injected_on_proper_types\n   def test_in_milliseconds\n     assert_equal 10_000, 10.seconds.in_milliseconds\n   end\n+\n+  def test_positive","path":"activesupport/test/core_ext/numeric_ext_test.rb","position":5,"original_position":5,"commit_id":"ed83f90d6124c4185a6d31010770e3c84d6be5fc","original_commit_id":"ed83f90d6124c4185a6d31010770e3c84d6be5fc","user":{"login":"egilburg","id":242532,"avatar_url":"https://avatars.githubusercontent.com/u/242532?v=3","gravatar_id":"","url":"https://api.github.com/users/egilburg","html_url":"https://github.com/egilburg","followers_url":"https://api.github.com/users/egilburg/followers","following_url":"https://api.github.com/users/egilburg/following{/other_user}","gists_url":"https://api.github.com/users/egilburg/gists{/gist_id}","starred_url":"https://api.github.com/users/egilburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egilburg/subscriptions","organizations_url":"https://api.github.com/users/egilburg/orgs","repos_url":"https://api.github.com/users/egilburg/repos","events_url":"https://api.github.com/users/egilburg/events{/privacy}","received_events_url":"https://api.github.com/users/egilburg/received_events","type":"User","site_admin":false},"body":"You'll want to add test coverage for all the expected classes, e.g. `0`, `0.0`, rationals etc","created_at":"2015-05-13T21:01:29Z","updated_at":"2015-05-13T21:01:29Z","html_url":"https://github.com/rails/rails/pull/20143#discussion_r30275619","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/20143","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/30275619"},"html":{"href":"https://github.com/rails/rails/pull/20143#discussion_r30275619"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/20143"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/20143","id":35354202,"html_url":"https://github.com/rails/rails/pull/20143","diff_url":"https://github.com/rails/rails/pull/20143.diff","patch_url":"https://github.com/rails/rails/pull/20143.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/20143","number":20143,"state":"open","locked":false,"title":"Move Integer#positive? and Integer#negative? query methods to Numeric","user":{"login":"meinac","id":1840945,"avatar_url":"https://avatars.githubusercontent.com/u/1840945?v=3","gravatar_id":"","url":"https://api.github.com/users/meinac","html_url":"https://github.com/meinac","followers_url":"https://api.github.com/users/meinac/followers","following_url":"https://api.github.com/users/meinac/following{/other_user}","gists_url":"https://api.github.com/users/meinac/gists{/gist_id}","starred_url":"https://api.github.com/users/meinac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meinac/subscriptions","organizations_url":"https://api.github.com/users/meinac/orgs","repos_url":"https://api.github.com/users/meinac/repos","events_url":"https://api.github.com/users/meinac/events{/privacy}","received_events_url":"https://api.github.com/users/meinac/received_events","type":"User","site_admin":false},"body":"By this way Integer, Rational, Float, Fixnum, Bignum classes have the same behaviour","created_at":"2015-05-13T18:06:56Z","updated_at":"2015-05-13T21:01:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42211c70223133103bf004b58f2bd32575817d0b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/20143/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/20143/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/20143/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/ed83f90d6124c4185a6d31010770e3c84d6be5fc","head":{"label":"vngrs:move_integer_positive_negative_to_numeric","ref":"move_integer_positive_negative_to_numeric","sha":"ed83f90d6124c4185a6d31010770e3c84d6be5fc","user":{"login":"vngrs","id":5415987,"avatar_url":"https://avatars.githubusercontent.com/u/5415987?v=3","gravatar_id":"","url":"https://api.github.com/users/vngrs","html_url":"https://github.com/vngrs","followers_url":"https://api.github.com/users/vngrs/followers","following_url":"https://api.github.com/users/vngrs/following{/other_user}","gists_url":"https://api.github.com/users/vngrs/gists{/gist_id}","starred_url":"https://api.github.com/users/vngrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vngrs/subscriptions","organizations_url":"https://api.github.com/users/vngrs/orgs","repos_url":"https://api.github.com/users/vngrs/repos","events_url":"https://api.github.com/users/vngrs/events{/privacy}","received_events_url":"https://api.github.com/users/vngrs/received_events","type":"Organization","site_admin":false},"repo":{"id":33334101,"name":"rails","full_name":"vngrs/rails","owner":{"login":"vngrs","id":5415987,"avatar_url":"https://avatars.githubusercontent.com/u/5415987?v=3","gravatar_id":"","url":"https://api.github.com/users/vngrs","html_url":"https://github.com/vngrs","followers_url":"https://api.github.com/users/vngrs/followers","following_url":"https://api.github.com/users/vngrs/following{/other_user}","gists_url":"https://api.github.com/users/vngrs/gists{/gist_id}","starred_url":"https://api.github.com/users/vngrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vngrs/subscriptions","organizations_url":"https://api.github.com/users/vngrs/orgs","repos_url":"https://api.github.com/users/vngrs/repos","events_url":"https://api.github.com/users/vngrs/events{/privacy}","received_events_url":"https://api.github.com/users/vngrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vngrs/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/vngrs/rails","forks_url":"https://api.github.com/repos/vngrs/rails/forks","keys_url":"https://api.github.com/repos/vngrs/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vngrs/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vngrs/rails/teams","hooks_url":"https://api.github.com/repos/vngrs/rails/hooks","issue_events_url":"https://api.github.com/repos/vngrs/rails/issues/events{/number}","events_url":"https://api.github.com/repos/vngrs/rails/events","assignees_url":"https://api.github.com/repos/vngrs/rails/assignees{/user}","branches_url":"https://api.github.com/repos/vngrs/rails/branches{/branch}","tags_url":"https://api.github.com/repos/vngrs/rails/tags","blobs_url":"https://api.github.com/repos/vngrs/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vngrs/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vngrs/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/vngrs/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vngrs/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/vngrs/rails/languages","stargazers_url":"https://api.github.com/repos/vngrs/rails/stargazers","contributors_url":"https://api.github.com/repos/vngrs/rails/contributors","subscribers_url":"https://api.github.com/repos/vngrs/rails/subscribers","subscription_url":"https://api.github.com/repos/vngrs/rails/subscription","commits_url":"https://api.github.com/repos/vngrs/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/vngrs/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/vngrs/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/vngrs/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/vngrs/rails/contents/{+path}","compare_url":"https://api.github.com/repos/vngrs/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vngrs/rails/merges","archive_url":"https://api.github.com/repos/vngrs/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vngrs/rails/downloads","issues_url":"https://api.github.com/repos/vngrs/rails/issues{/number}","pulls_url":"https://api.github.com/repos/vngrs/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/vngrs/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/vngrs/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vngrs/rails/labels{/name}","releases_url":"https://api.github.com/repos/vngrs/rails/releases{/id}","created_at":"2015-04-02T22:05:32Z","updated_at":"2015-04-11T02:08:30Z","pushed_at":"2015-05-13T20:36:00Z","git_url":"git://github.com/vngrs/rails.git","ssh_url":"git@github.com:vngrs/rails.git","clone_url":"https://github.com/vngrs/rails.git","svn_url":"https://github.com/vngrs/rails","homepage":"http://rubyonrails.org","size":142387,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"94025927d79cbdbaf3b6e41fb2112d086f21dea3","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2015-05-13T20:58:57Z","pushed_at":"2015-05-13T20:37:12Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":432651,"stargazers_count":26095,"watchers_count":26095,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10340,"mirror_url":null,"open_issues_count":787,"forks":10340,"open_issues":787,"watchers":26095,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/20143"},"html":{"href":"https://github.com/rails/rails/pull/20143"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/20143"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/20143/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/20143/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/20143/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/ed83f90d6124c4185a6d31010770e3c84d6be5fc"}}}}