{"action":"created","comment":{"url":"https://api.github.com/repos/vispy/vispy/pulls/comments/36589625","id":36589625,"diff_hunk":"@@ -5,6 +5,7 @@\n from __future__ import division\n \n import numpy as np\n+from vispy.visuals import _BorderVisual","path":"vispy/scene/widgets/widget.py","position":4,"original_position":4,"commit_id":"b3e5927c562b74089fa1c539ad6471eab5b411ef","original_commit_id":"b3e5927c562b74089fa1c539ad6471eab5b411ef","user":{"login":"bollu","id":1694861,"avatar_url":"https://avatars.githubusercontent.com/u/1694861?v=3","gravatar_id":"","url":"https://api.github.com/users/bollu","html_url":"https://github.com/bollu","followers_url":"https://api.github.com/users/bollu/followers","following_url":"https://api.github.com/users/bollu/following{/other_user}","gists_url":"https://api.github.com/users/bollu/gists{/gist_id}","starred_url":"https://api.github.com/users/bollu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollu/subscriptions","organizations_url":"https://api.github.com/users/bollu/orgs","repos_url":"https://api.github.com/users/bollu/repos","events_url":"https://api.github.com/users/bollu/events{/privacy}","received_events_url":"https://api.github.com/users/bollu/received_events","type":"User","site_admin":false},"body":"The thought was that `BorderVisual` would be used by some of vispy's visuals, but that no one \"externally\" would really need it, so it wouldn't show up in Intellisense / autocompletion.","created_at":"2015-08-09T15:44:07Z","updated_at":"2015-08-09T15:44:07Z","html_url":"https://github.com/vispy/vispy/pull/1038#discussion_r36589625","pull_request_url":"https://api.github.com/repos/vispy/vispy/pulls/1038","_links":{"self":{"href":"https://api.github.com/repos/vispy/vispy/pulls/comments/36589625"},"html":{"href":"https://github.com/vispy/vispy/pull/1038#discussion_r36589625"},"pull_request":{"href":"https://api.github.com/repos/vispy/vispy/pulls/1038"}}},"pull_request":{"url":"https://api.github.com/repos/vispy/vispy/pulls/1038","id":41395542,"html_url":"https://github.com/vispy/vispy/pull/1038","diff_url":"https://github.com/vispy/vispy/pull/1038.diff","patch_url":"https://github.com/vispy/vispy/pull/1038.patch","issue_url":"https://api.github.com/repos/vispy/vispy/issues/1038","number":1038,"state":"open","locked":false,"title":"[WIP] Colorbar -  vispy.plot","user":{"login":"bollu","id":1694861,"avatar_url":"https://avatars.githubusercontent.com/u/1694861?v=3","gravatar_id":"","url":"https://api.github.com/users/bollu","html_url":"https://github.com/bollu","followers_url":"https://api.github.com/users/bollu/followers","following_url":"https://api.github.com/users/bollu/following{/other_user}","gists_url":"https://api.github.com/users/bollu/gists{/gist_id}","starred_url":"https://api.github.com/users/bollu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollu/subscriptions","organizations_url":"https://api.github.com/users/bollu/orgs","repos_url":"https://api.github.com/users/bollu/repos","events_url":"https://api.github.com/users/bollu/events{/privacy}","received_events_url":"https://api.github.com/users/bollu/received_events","type":"User","site_admin":false},"body":"Checklist:\r\n\r\n- [x] add a `colorbar` function to `PlotWidget`\r\n- [x] separate out border rendering into `BorderVisual`\r\n- [x] integrate border rendering to `ViewBox`\r\n- [x] fix coordinate systems for `ColorBar`\r\n- [x] fix text overlapping\r\n- [x] add an example of using `plotwidget.colorbar` with `vispy.plot`\r\n- [x] change ticks orientation so they are always left-to-right\r\n- [x] create a new `ColorBarWidget`\r\n- [x] add an example for `ColorBarWidget`\r\n- [x] write docs on `PlotWidget.colorbar(..)`\r\n- [x] write docs on `ColorBarWidget`\r\n- [x] fix overlap in `examples/basics/visuals/colorbar_visual.py`\r\n- [ ] implement `viridis` colormap for VisPy (in separate PR)\r\n- [ ] write test cases for `ColorBarWidget`","created_at":"2015-08-01T03:27:41Z","updated_at":"2015-08-09T15:44:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4be6db9f415078671e23af478d1b744b5ffdbac4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vispy/vispy/pulls/1038/commits","review_comments_url":"https://api.github.com/repos/vispy/vispy/pulls/1038/comments","review_comment_url":"https://api.github.com/repos/vispy/vispy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vispy/vispy/issues/1038/comments","statuses_url":"https://api.github.com/repos/vispy/vispy/statuses/b3e5927c562b74089fa1c539ad6471eab5b411ef","head":{"label":"bollu:colorbar-vispy-plot","ref":"colorbar-vispy-plot","sha":"b3e5927c562b74089fa1c539ad6471eab5b411ef","user":{"login":"bollu","id":1694861,"avatar_url":"https://avatars.githubusercontent.com/u/1694861?v=3","gravatar_id":"","url":"https://api.github.com/users/bollu","html_url":"https://github.com/bollu","followers_url":"https://api.github.com/users/bollu/followers","following_url":"https://api.github.com/users/bollu/following{/other_user}","gists_url":"https://api.github.com/users/bollu/gists{/gist_id}","starred_url":"https://api.github.com/users/bollu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollu/subscriptions","organizations_url":"https://api.github.com/users/bollu/orgs","repos_url":"https://api.github.com/users/bollu/repos","events_url":"https://api.github.com/users/bollu/events{/privacy}","received_events_url":"https://api.github.com/users/bollu/received_events","type":"User","site_admin":false},"repo":{"id":31825193,"name":"vispy","full_name":"bollu/vispy","owner":{"login":"bollu","id":1694861,"avatar_url":"https://avatars.githubusercontent.com/u/1694861?v=3","gravatar_id":"","url":"https://api.github.com/users/bollu","html_url":"https://github.com/bollu","followers_url":"https://api.github.com/users/bollu/followers","following_url":"https://api.github.com/users/bollu/following{/other_user}","gists_url":"https://api.github.com/users/bollu/gists{/gist_id}","starred_url":"https://api.github.com/users/bollu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bollu/subscriptions","organizations_url":"https://api.github.com/users/bollu/orgs","repos_url":"https://api.github.com/users/bollu/repos","events_url":"https://api.github.com/users/bollu/events{/privacy}","received_events_url":"https://api.github.com/users/bollu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bollu/vispy","description":"Main repository for Vispy","fork":true,"url":"https://api.github.com/repos/bollu/vispy","forks_url":"https://api.github.com/repos/bollu/vispy/forks","keys_url":"https://api.github.com/repos/bollu/vispy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bollu/vispy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bollu/vispy/teams","hooks_url":"https://api.github.com/repos/bollu/vispy/hooks","issue_events_url":"https://api.github.com/repos/bollu/vispy/issues/events{/number}","events_url":"https://api.github.com/repos/bollu/vispy/events","assignees_url":"https://api.github.com/repos/bollu/vispy/assignees{/user}","branches_url":"https://api.github.com/repos/bollu/vispy/branches{/branch}","tags_url":"https://api.github.com/repos/bollu/vispy/tags","blobs_url":"https://api.github.com/repos/bollu/vispy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bollu/vispy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bollu/vispy/git/refs{/sha}","trees_url":"https://api.github.com/repos/bollu/vispy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bollu/vispy/statuses/{sha}","languages_url":"https://api.github.com/repos/bollu/vispy/languages","stargazers_url":"https://api.github.com/repos/bollu/vispy/stargazers","contributors_url":"https://api.github.com/repos/bollu/vispy/contributors","subscribers_url":"https://api.github.com/repos/bollu/vispy/subscribers","subscription_url":"https://api.github.com/repos/bollu/vispy/subscription","commits_url":"https://api.github.com/repos/bollu/vispy/commits{/sha}","git_commits_url":"https://api.github.com/repos/bollu/vispy/git/commits{/sha}","comments_url":"https://api.github.com/repos/bollu/vispy/comments{/number}","issue_comment_url":"https://api.github.com/repos/bollu/vispy/issues/comments{/number}","contents_url":"https://api.github.com/repos/bollu/vispy/contents/{+path}","compare_url":"https://api.github.com/repos/bollu/vispy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bollu/vispy/merges","archive_url":"https://api.github.com/repos/bollu/vispy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bollu/vispy/downloads","issues_url":"https://api.github.com/repos/bollu/vispy/issues{/number}","pulls_url":"https://api.github.com/repos/bollu/vispy/pulls{/number}","milestones_url":"https://api.github.com/repos/bollu/vispy/milestones{/number}","notifications_url":"https://api.github.com/repos/bollu/vispy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bollu/vispy/labels{/name}","releases_url":"https://api.github.com/repos/bollu/vispy/releases{/id}","created_at":"2015-03-07T19:53:28Z","updated_at":"2015-03-07T19:53:30Z","pushed_at":"2015-08-06T17:14:50Z","git_url":"git://github.com/bollu/vispy.git","ssh_url":"git@github.com:bollu/vispy.git","clone_url":"https://github.com/bollu/vispy.git","svn_url":"https://github.com/bollu/vispy","homepage":"http://vispy.org","size":9922,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vispy:master","ref":"master","sha":"6834a2b89e4a218f1c1783c588d5f47a781a2f7f","user":{"login":"vispy","id":3934254,"avatar_url":"https://avatars.githubusercontent.com/u/3934254?v=3","gravatar_id":"","url":"https://api.github.com/users/vispy","html_url":"https://github.com/vispy","followers_url":"https://api.github.com/users/vispy/followers","following_url":"https://api.github.com/users/vispy/following{/other_user}","gists_url":"https://api.github.com/users/vispy/gists{/gist_id}","starred_url":"https://api.github.com/users/vispy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vispy/subscriptions","organizations_url":"https://api.github.com/users/vispy/orgs","repos_url":"https://api.github.com/users/vispy/repos","events_url":"https://api.github.com/users/vispy/events{/privacy}","received_events_url":"https://api.github.com/users/vispy/received_events","type":"Organization","site_admin":false},"repo":{"id":8935948,"name":"vispy","full_name":"vispy/vispy","owner":{"login":"vispy","id":3934254,"avatar_url":"https://avatars.githubusercontent.com/u/3934254?v=3","gravatar_id":"","url":"https://api.github.com/users/vispy","html_url":"https://github.com/vispy","followers_url":"https://api.github.com/users/vispy/followers","following_url":"https://api.github.com/users/vispy/following{/other_user}","gists_url":"https://api.github.com/users/vispy/gists{/gist_id}","starred_url":"https://api.github.com/users/vispy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vispy/subscriptions","organizations_url":"https://api.github.com/users/vispy/orgs","repos_url":"https://api.github.com/users/vispy/repos","events_url":"https://api.github.com/users/vispy/events{/privacy}","received_events_url":"https://api.github.com/users/vispy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vispy/vispy","description":"Main repository for Vispy","fork":false,"url":"https://api.github.com/repos/vispy/vispy","forks_url":"https://api.github.com/repos/vispy/vispy/forks","keys_url":"https://api.github.com/repos/vispy/vispy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vispy/vispy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vispy/vispy/teams","hooks_url":"https://api.github.com/repos/vispy/vispy/hooks","issue_events_url":"https://api.github.com/repos/vispy/vispy/issues/events{/number}","events_url":"https://api.github.com/repos/vispy/vispy/events","assignees_url":"https://api.github.com/repos/vispy/vispy/assignees{/user}","branches_url":"https://api.github.com/repos/vispy/vispy/branches{/branch}","tags_url":"https://api.github.com/repos/vispy/vispy/tags","blobs_url":"https://api.github.com/repos/vispy/vispy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vispy/vispy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vispy/vispy/git/refs{/sha}","trees_url":"https://api.github.com/repos/vispy/vispy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vispy/vispy/statuses/{sha}","languages_url":"https://api.github.com/repos/vispy/vispy/languages","stargazers_url":"https://api.github.com/repos/vispy/vispy/stargazers","contributors_url":"https://api.github.com/repos/vispy/vispy/contributors","subscribers_url":"https://api.github.com/repos/vispy/vispy/subscribers","subscription_url":"https://api.github.com/repos/vispy/vispy/subscription","commits_url":"https://api.github.com/repos/vispy/vispy/commits{/sha}","git_commits_url":"https://api.github.com/repos/vispy/vispy/git/commits{/sha}","comments_url":"https://api.github.com/repos/vispy/vispy/comments{/number}","issue_comment_url":"https://api.github.com/repos/vispy/vispy/issues/comments{/number}","contents_url":"https://api.github.com/repos/vispy/vispy/contents/{+path}","compare_url":"https://api.github.com/repos/vispy/vispy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vispy/vispy/merges","archive_url":"https://api.github.com/repos/vispy/vispy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vispy/vispy/downloads","issues_url":"https://api.github.com/repos/vispy/vispy/issues{/number}","pulls_url":"https://api.github.com/repos/vispy/vispy/pulls{/number}","milestones_url":"https://api.github.com/repos/vispy/vispy/milestones{/number}","notifications_url":"https://api.github.com/repos/vispy/vispy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vispy/vispy/labels{/name}","releases_url":"https://api.github.com/repos/vispy/vispy/releases{/id}","created_at":"2013-03-21T18:43:22Z","updated_at":"2015-08-08T16:22:31Z","pushed_at":"2015-08-09T12:20:13Z","git_url":"git://github.com/vispy/vispy.git","ssh_url":"git@github.com:vispy/vispy.git","clone_url":"https://github.com/vispy/vispy.git","svn_url":"https://github.com/vispy/vispy","homepage":"http://vispy.org","size":18784,"stargazers_count":694,"watchers_count":694,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":123,"mirror_url":null,"open_issues_count":155,"forks":123,"open_issues":155,"watchers":694,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vispy/vispy/pulls/1038"},"html":{"href":"https://github.com/vispy/vispy/pull/1038"},"issue":{"href":"https://api.github.com/repos/vispy/vispy/issues/1038"},"comments":{"href":"https://api.github.com/repos/vispy/vispy/issues/1038/comments"},"review_comments":{"href":"https://api.github.com/repos/vispy/vispy/pulls/1038/comments"},"review_comment":{"href":"https://api.github.com/repos/vispy/vispy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vispy/vispy/pulls/1038/commits"},"statuses":{"href":"https://api.github.com/repos/vispy/vispy/statuses/b3e5927c562b74089fa1c539ad6471eab5b411ef"}}}}