{"action":"created","issue":{"url":"https://api.github.com/repos/plaidchat/plaidchat/issues/94","labels_url":"https://api.github.com/repos/plaidchat/plaidchat/issues/94/labels{/name}","comments_url":"https://api.github.com/repos/plaidchat/plaidchat/issues/94/comments","events_url":"https://api.github.com/repos/plaidchat/plaidchat/issues/94/events","html_url":"https://github.com/plaidchat/plaidchat/pull/94","id":91185719,"number":94,"title":"Added unread triangle and fixed notification count","user":{"login":"twolfson","id":902488,"avatar_url":"https://avatars.githubusercontent.com/u/902488?v=3","gravatar_id":"","url":"https://api.github.com/users/twolfson","html_url":"https://github.com/twolfson","followers_url":"https://api.github.com/users/twolfson/followers","following_url":"https://api.github.com/users/twolfson/following{/other_user}","gists_url":"https://api.github.com/users/twolfson/gists{/gist_id}","starred_url":"https://api.github.com/users/twolfson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twolfson/subscriptions","organizations_url":"https://api.github.com/users/twolfson/orgs","repos_url":"https://api.github.com/users/twolfson/repos","events_url":"https://api.github.com/users/twolfson/events{/privacy}","received_events_url":"https://api.github.com/users/twolfson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"wlaurance","id":1059214,"avatar_url":"https://avatars.githubusercontent.com/u/1059214?v=3","gravatar_id":"","url":"https://api.github.com/users/wlaurance","html_url":"https://github.com/wlaurance","followers_url":"https://api.github.com/users/wlaurance/followers","following_url":"https://api.github.com/users/wlaurance/following{/other_user}","gists_url":"https://api.github.com/users/wlaurance/gists{/gist_id}","starred_url":"https://api.github.com/users/wlaurance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wlaurance/subscriptions","organizations_url":"https://api.github.com/users/wlaurance/orgs","repos_url":"https://api.github.com/users/wlaurance/repos","events_url":"https://api.github.com/users/wlaurance/events{/privacy}","received_events_url":"https://api.github.com/users/wlaurance/received_events","type":"User","site_admin":false},"milestone":null,"comments":12,"created_at":"2015-06-26T08:10:43Z","updated_at":"2015-06-30T05:33:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/plaidchat/plaidchat/pulls/94","html_url":"https://github.com/plaidchat/plaidchat/pull/94","diff_url":"https://github.com/plaidchat/plaidchat/pull/94.diff","patch_url":"https://github.com/plaidchat/plaidchat/pull/94.patch"},"body":"As reported in #93 and in #39, we are missing an \"unread triangle/blob\" and our notification count isn't accurate at the moment. This PR aims to make those accurate (and make `plaidchat` seem less noisy). In this PR:\r\n\r\n- Broke down notifications into `unreadCount` and `unreadHighlightsCount`\r\n- Added \"unread\" state for tray icon\r\n- Capped highlight counts to \"9+\" as with Slack\r\n- Added \"unread triangle\" to team sidebar\r\n- Caught/patched bug with inactive iframes acknowledging notifications\r\n\r\n![selection_146](https://cloud.githubusercontent.com/assets/902488/8373275/e78210c8-1bb0-11e5-9f83-ed8af30a7868.png)\r\n\r\n![selection_145](https://cloud.githubusercontent.com/assets/902488/8373278/eaeef67c-1bb0-11e5-85cd-0182895e704f.png)\r\n\r\n/cc @wlaurance "},"comment":{"url":"https://api.github.com/repos/plaidchat/plaidchat/issues/comments/116973068","html_url":"https://github.com/plaidchat/plaidchat/pull/94#issuecomment-116973068","issue_url":"https://api.github.com/repos/plaidchat/plaidchat/issues/94","id":116973068,"user":{"login":"twolfson","id":902488,"avatar_url":"https://avatars.githubusercontent.com/u/902488?v=3","gravatar_id":"","url":"https://api.github.com/users/twolfson","html_url":"https://github.com/twolfson","followers_url":"https://api.github.com/users/twolfson/followers","following_url":"https://api.github.com/users/twolfson/following{/other_user}","gists_url":"https://api.github.com/users/twolfson/gists{/gist_id}","starred_url":"https://api.github.com/users/twolfson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twolfson/subscriptions","organizations_url":"https://api.github.com/users/twolfson/orgs","repos_url":"https://api.github.com/users/twolfson/repos","events_url":"https://api.github.com/users/twolfson/events{/privacy}","received_events_url":"https://api.github.com/users/twolfson/received_events","type":"User","site_admin":false},"created_at":"2015-06-30T05:33:49Z","updated_at":"2015-06-30T05:33:49Z","body":"After further research, it looks like we can't pass in `w`/`h` =(\r\n\r\nhttps://github.com/ejci/favico.js/blob/0.3.7/favico.js#L298-L325\r\n\r\n@mathieumg @wlaurance Are we fine with landing this PR as is?"}}