{"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/36270575","id":36270575,"diff_hunk":"@@ -802,8 +801,29 @@ Language changes listed by -transition=id:\\n\\\n             }\n             else if (strcmp(p + 1, \"ignore\") == 0)\n                 global.params.ignoreUnsupportedPragmas = true;\n+\n             else if (strcmp(p + 1, \"property\") == 0)\n-                global.params.enforcePropertySyntax = true;\n+            {\n+                /*NOTE: -property used to disallow calling non-properties\n+                without parentheses. This behaviour has fallen from grace.\n+                Phobos dropped support for it while dmd still recognized it, so\n+                that the switch has effectively not been supported. Time to\n+                remove it from dmd.\n+                Step 1 (2.068): Ignore -property and warn about it. */\n+                warning(Loc(), \"The -property switch has no effect since \"\n+                    \"version 2.068.0. It's going to be deprecated and \"\n+                    \"eventually removed in future versions.\");","path":"src/mars.c","position":24,"original_position":24,"commit_id":"611b9359d14b1fe3f67b6bdadc3923faabb6e396","original_commit_id":"611b9359d14b1fe3f67b6bdadc3923faabb6e396","user":{"login":"MartinNowak","id":288976,"avatar_url":"https://avatars.githubusercontent.com/u/288976?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinNowak","html_url":"https://github.com/MartinNowak","followers_url":"https://api.github.com/users/MartinNowak/followers","following_url":"https://api.github.com/users/MartinNowak/following{/other_user}","gists_url":"https://api.github.com/users/MartinNowak/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinNowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinNowak/subscriptions","organizations_url":"https://api.github.com/users/MartinNowak/orgs","repos_url":"https://api.github.com/users/MartinNowak/repos","events_url":"https://api.github.com/users/MartinNowak/events{/privacy}","received_events_url":"https://api.github.com/users/MartinNowak/received_events","type":"User","site_admin":false},"body":"You have to warn after the whole argument parsing is done b/c they way it's done now `-w -property` would warn while `-property -w` wouldn't, i.e. `global.params.warning` might still be false.","created_at":"2015-08-05T05:29:58Z","updated_at":"2015-08-05T05:29:58Z","html_url":"https://github.com/D-Programming-Language/dmd/pull/4850#discussion_r36270575","pull_request_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4850","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/36270575"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/4850#discussion_r36270575"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4850"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4850","id":41270537,"html_url":"https://github.com/D-Programming-Language/dmd/pull/4850","diff_url":"https://github.com/D-Programming-Language/dmd/pull/4850.diff","patch_url":"https://github.com/D-Programming-Language/dmd/pull/4850.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/4850","number":4850,"state":"open","locked":false,"title":"issue 14564 - [REG2.067] dmd -property -unittest combination causes compiler error","user":{"login":"aG0aep6G","id":9287500,"avatar_url":"https://avatars.githubusercontent.com/u/9287500?v=3","gravatar_id":"","url":"https://api.github.com/users/aG0aep6G","html_url":"https://github.com/aG0aep6G","followers_url":"https://api.github.com/users/aG0aep6G/followers","following_url":"https://api.github.com/users/aG0aep6G/following{/other_user}","gists_url":"https://api.github.com/users/aG0aep6G/gists{/gist_id}","starred_url":"https://api.github.com/users/aG0aep6G/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aG0aep6G/subscriptions","organizations_url":"https://api.github.com/users/aG0aep6G/orgs","repos_url":"https://api.github.com/users/aG0aep6G/repos","events_url":"https://api.github.com/users/aG0aep6G/events{/privacy}","received_events_url":"https://api.github.com/users/aG0aep6G/received_events","type":"User","site_admin":false},"body":"fixes issue 14564 - [REG2.067] dmd -property -unittest combination causes\r\ncompiler error\r\n\r\nhttps://issues.dlang.org/show_bug.cgi?id=14564\r\n\r\nThe problem is that phobos isn't compatible with `-property`. And it looks like `-property`'s current behaviour isn't desired anymore.\r\n\r\nThe plan (also in `mars.c`):\r\n* Step 1 (2.068): Ignore -property and warn about it.\r\n* Step 2: Deprecate -property.\r\n* Step 3: Remove -property. Throw an error when it's set.\r\n* Step 4: Possibly reintroduce -property with different semantics.\r\n\r\nTo do if this gets agreed upon:\r\n* update http://dlang.org/dmd-windows.html and friends,\r\n* changelog entry.\r\n\r\nAn alternative way to fix issue 14564 would be to make phobos compatible with the current `-property`.\r\n","created_at":"2015-07-30T19:10:38Z","updated_at":"2015-08-05T05:29:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b58cc16900904b26aa990f18d0afff7a0c2fe65f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4850/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4850/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/4850/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/611b9359d14b1fe3f67b6bdadc3923faabb6e396","head":{"label":"aG0aep6G:property-switch","ref":"property-switch","sha":"611b9359d14b1fe3f67b6bdadc3923faabb6e396","user":{"login":"aG0aep6G","id":9287500,"avatar_url":"https://avatars.githubusercontent.com/u/9287500?v=3","gravatar_id":"","url":"https://api.github.com/users/aG0aep6G","html_url":"https://github.com/aG0aep6G","followers_url":"https://api.github.com/users/aG0aep6G/followers","following_url":"https://api.github.com/users/aG0aep6G/following{/other_user}","gists_url":"https://api.github.com/users/aG0aep6G/gists{/gist_id}","starred_url":"https://api.github.com/users/aG0aep6G/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aG0aep6G/subscriptions","organizations_url":"https://api.github.com/users/aG0aep6G/orgs","repos_url":"https://api.github.com/users/aG0aep6G/repos","events_url":"https://api.github.com/users/aG0aep6G/events{/privacy}","received_events_url":"https://api.github.com/users/aG0aep6G/received_events","type":"User","site_admin":false},"repo":{"id":38547001,"name":"dmd","full_name":"aG0aep6G/dmd","owner":{"login":"aG0aep6G","id":9287500,"avatar_url":"https://avatars.githubusercontent.com/u/9287500?v=3","gravatar_id":"","url":"https://api.github.com/users/aG0aep6G","html_url":"https://github.com/aG0aep6G","followers_url":"https://api.github.com/users/aG0aep6G/followers","following_url":"https://api.github.com/users/aG0aep6G/following{/other_user}","gists_url":"https://api.github.com/users/aG0aep6G/gists{/gist_id}","starred_url":"https://api.github.com/users/aG0aep6G/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aG0aep6G/subscriptions","organizations_url":"https://api.github.com/users/aG0aep6G/orgs","repos_url":"https://api.github.com/users/aG0aep6G/repos","events_url":"https://api.github.com/users/aG0aep6G/events{/privacy}","received_events_url":"https://api.github.com/users/aG0aep6G/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aG0aep6G/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/aG0aep6G/dmd","forks_url":"https://api.github.com/repos/aG0aep6G/dmd/forks","keys_url":"https://api.github.com/repos/aG0aep6G/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aG0aep6G/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aG0aep6G/dmd/teams","hooks_url":"https://api.github.com/repos/aG0aep6G/dmd/hooks","issue_events_url":"https://api.github.com/repos/aG0aep6G/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/aG0aep6G/dmd/events","assignees_url":"https://api.github.com/repos/aG0aep6G/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/aG0aep6G/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/aG0aep6G/dmd/tags","blobs_url":"https://api.github.com/repos/aG0aep6G/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aG0aep6G/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aG0aep6G/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/aG0aep6G/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aG0aep6G/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/aG0aep6G/dmd/languages","stargazers_url":"https://api.github.com/repos/aG0aep6G/dmd/stargazers","contributors_url":"https://api.github.com/repos/aG0aep6G/dmd/contributors","subscribers_url":"https://api.github.com/repos/aG0aep6G/dmd/subscribers","subscription_url":"https://api.github.com/repos/aG0aep6G/dmd/subscription","commits_url":"https://api.github.com/repos/aG0aep6G/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/aG0aep6G/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/aG0aep6G/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/aG0aep6G/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/aG0aep6G/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/aG0aep6G/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aG0aep6G/dmd/merges","archive_url":"https://api.github.com/repos/aG0aep6G/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aG0aep6G/dmd/downloads","issues_url":"https://api.github.com/repos/aG0aep6G/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/aG0aep6G/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/aG0aep6G/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/aG0aep6G/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aG0aep6G/dmd/labels{/name}","releases_url":"https://api.github.com/repos/aG0aep6G/dmd/releases{/id}","created_at":"2015-07-04T20:36:52Z","updated_at":"2015-07-04T20:37:00Z","pushed_at":"2015-07-30T22:01:38Z","git_url":"git://github.com/aG0aep6G/dmd.git","ssh_url":"git@github.com:aG0aep6G/dmd.git","clone_url":"https://github.com/aG0aep6G/dmd.git","svn_url":"https://github.com/aG0aep6G/dmd","homepage":"dlang.org","size":56197,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"D-Programming-Language:stable","ref":"stable","sha":"d69289bb56952a1e259fd2e6f07b8b7d4fad9d16","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"name":"dmd","full_name":"D-Programming-Language/dmd","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/dmd","forks_url":"https://api.github.com/repos/D-Programming-Language/dmd/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/dmd/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/dmd/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/dmd/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/dmd/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/dmd/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/dmd/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/D-Programming-Language/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/dmd/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/dmd/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/dmd/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/dmd/releases{/id}","created_at":"2011-01-15T06:53:53Z","updated_at":"2015-08-03T08:45:49Z","pushed_at":"2015-08-05T05:29:34Z","git_url":"git://github.com/D-Programming-Language/dmd.git","ssh_url":"git@github.com:D-Programming-Language/dmd.git","clone_url":"https://github.com/D-Programming-Language/dmd.git","svn_url":"https://github.com/D-Programming-Language/dmd","homepage":"dlang.org","size":100055,"stargazers_count":1044,"watchers_count":1044,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":331,"mirror_url":null,"open_issues_count":132,"forks":331,"open_issues":132,"watchers":1044,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4850"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/4850"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/4850"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/4850/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4850/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4850/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/611b9359d14b1fe3f67b6bdadc3923faabb6e396"}}}}