{"action":"created","comment":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/comments/40161596","id":40161596,"diff_hunk":"@@ -0,0 +1,266 @@\n+var emscripten_cpuprofiler = {","path":"src/cpuprofiler.js","position":1,"original_position":1,"commit_id":"41b9bb8d45dfbd580ee02010cf1b3ab5dac2d820","original_commit_id":"41b9bb8d45dfbd580ee02010cf1b3ab5dac2d820","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"body":"How about `CpuProfiler`?","created_at":"2015-09-23T00:32:13Z","updated_at":"2015-09-23T00:32:13Z","html_url":"https://github.com/kripken/emscripten/pull/3781#discussion_r40161596","pull_request_url":"https://api.github.com/repos/kripken/emscripten/pulls/3781","_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments/40161596"},"html":{"href":"https://github.com/kripken/emscripten/pull/3781#discussion_r40161596"},"pull_request":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/3781"}}},"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/3781","id":45207997,"html_url":"https://github.com/kripken/emscripten/pull/3781","diff_url":"https://github.com/kripken/emscripten/pull/3781.diff","patch_url":"https://github.com/kripken/emscripten/pull/3781.patch","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/3781","number":3781,"state":"open","locked":false,"title":"--cpuprofiler & --memoryprofiler","user":{"login":"juj","id":225351,"avatar_url":"https://avatars.githubusercontent.com/u/225351?v=3","gravatar_id":"","url":"https://api.github.com/users/juj","html_url":"https://github.com/juj","followers_url":"https://api.github.com/users/juj/followers","following_url":"https://api.github.com/users/juj/following{/other_user}","gists_url":"https://api.github.com/users/juj/gists{/gist_id}","starred_url":"https://api.github.com/users/juj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juj/subscriptions","organizations_url":"https://api.github.com/users/juj/orgs","repos_url":"https://api.github.com/users/juj/repos","events_url":"https://api.github.com/users/juj/events{/privacy}","received_events_url":"https://api.github.com/users/juj/received_events","type":"User","site_admin":false},"body":"This pull request supersedes #3178 (partially) and #3179. Putting it up for looks to show the intent here on how these are designed to integrate.\r\n\r\nThe linker flag --cpuprofiler adds a compact & simple cpuprofiler \"panel\" into the generated html page. Likewise, the linker flag --memoryprofiler adds a Emscripten heap profiler into the generated html page.\r\n\r\nAlso this removes the need to clear the cache between enabling and disabling --tracing.\r\n\r\nAn online demo can be viewed at http://clb.demon.fi/emcc/cpu_mem_profiler/hello_world_gles_cpu_mem_profiled.html\r\n\r\nThe value of having these tools integrated tightly into Emscripten are follows:\r\n   - Very easy way to enable - no extra files to host or server hosting configuration to set up, or external tools to run (compared to e.g. browser-specific profiling tools). Just adding a single linker flag is enough.\r\n   - As opposed to browser-specific profiling tools, these work the same on all browsers, so they can potentially be used to profile per-browser differences.\r\n   - The cpu profiler is very fine-grained/interactive and well highlights per-frame stuttering, which current browser profilers don't do that well.\r\n   - The memory profiler shows inside the Emscripten heap, which browser profilers don't do.\r\n\r\nThe contents of src/cpuprofiler.js and src/memoryprofiler.js are very unkempt, didn't pay attention to them much at this point, but focused on the build settings and command line usage. Later work improves and cleans up these two .js files of old code and the visual appearance.\r\n\r\nCC @kripken , @nickdesaulniers , @waywardmonkeys .","created_at":"2015-09-16T18:36:48Z","updated_at":"2015-09-23T00:32:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01ac238fd25bdccdf946c4f26552311927960c95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kripken/emscripten/pulls/3781/commits","review_comments_url":"https://api.github.com/repos/kripken/emscripten/pulls/3781/comments","review_comment_url":"https://api.github.com/repos/kripken/emscripten/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/3781/comments","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/41b9bb8d45dfbd580ee02010cf1b3ab5dac2d820","head":{"label":"juj:cpuprofiler","ref":"cpuprofiler","sha":"41b9bb8d45dfbd580ee02010cf1b3ab5dac2d820","user":{"login":"juj","id":225351,"avatar_url":"https://avatars.githubusercontent.com/u/225351?v=3","gravatar_id":"","url":"https://api.github.com/users/juj","html_url":"https://github.com/juj","followers_url":"https://api.github.com/users/juj/followers","following_url":"https://api.github.com/users/juj/following{/other_user}","gists_url":"https://api.github.com/users/juj/gists{/gist_id}","starred_url":"https://api.github.com/users/juj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juj/subscriptions","organizations_url":"https://api.github.com/users/juj/orgs","repos_url":"https://api.github.com/users/juj/repos","events_url":"https://api.github.com/users/juj/events{/privacy}","received_events_url":"https://api.github.com/users/juj/received_events","type":"User","site_admin":false},"repo":{"id":4149606,"name":"emscripten","full_name":"juj/emscripten","owner":{"login":"juj","id":225351,"avatar_url":"https://avatars.githubusercontent.com/u/225351?v=3","gravatar_id":"","url":"https://api.github.com/users/juj","html_url":"https://github.com/juj","followers_url":"https://api.github.com/users/juj/followers","following_url":"https://api.github.com/users/juj/following{/other_user}","gists_url":"https://api.github.com/users/juj/gists{/gist_id}","starred_url":"https://api.github.com/users/juj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juj/subscriptions","organizations_url":"https://api.github.com/users/juj/orgs","repos_url":"https://api.github.com/users/juj/repos","events_url":"https://api.github.com/users/juj/events{/privacy}","received_events_url":"https://api.github.com/users/juj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juj/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":true,"url":"https://api.github.com/repos/juj/emscripten","forks_url":"https://api.github.com/repos/juj/emscripten/forks","keys_url":"https://api.github.com/repos/juj/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juj/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juj/emscripten/teams","hooks_url":"https://api.github.com/repos/juj/emscripten/hooks","issue_events_url":"https://api.github.com/repos/juj/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/juj/emscripten/events","assignees_url":"https://api.github.com/repos/juj/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/juj/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/juj/emscripten/tags","blobs_url":"https://api.github.com/repos/juj/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juj/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juj/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/juj/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juj/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/juj/emscripten/languages","stargazers_url":"https://api.github.com/repos/juj/emscripten/stargazers","contributors_url":"https://api.github.com/repos/juj/emscripten/contributors","subscribers_url":"https://api.github.com/repos/juj/emscripten/subscribers","subscription_url":"https://api.github.com/repos/juj/emscripten/subscription","commits_url":"https://api.github.com/repos/juj/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/juj/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/juj/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/juj/emscripten/issues/comments{/number}","contents_url":"https://api.github.com/repos/juj/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/juj/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juj/emscripten/merges","archive_url":"https://api.github.com/repos/juj/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juj/emscripten/downloads","issues_url":"https://api.github.com/repos/juj/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/juj/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/juj/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/juj/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juj/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/juj/emscripten/releases{/id}","created_at":"2012-04-26T16:19:07Z","updated_at":"2015-04-19T08:53:37Z","pushed_at":"2015-09-22T21:23:50Z","git_url":"git://github.com/juj/emscripten.git","ssh_url":"git@github.com:juj/emscripten.git","clone_url":"https://github.com/juj/emscripten.git","svn_url":"https://github.com/juj/emscripten","homepage":"","size":130841,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"kripken:incoming","ref":"incoming","sha":"182795eb4d20f2719d9dc4cb4e5a70d8cdce6b29","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"repo":{"id":1357796,"name":"emscripten","full_name":"kripken/emscripten","owner":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kripken/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":false,"url":"https://api.github.com/repos/kripken/emscripten","forks_url":"https://api.github.com/repos/kripken/emscripten/forks","keys_url":"https://api.github.com/repos/kripken/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kripken/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kripken/emscripten/teams","hooks_url":"https://api.github.com/repos/kripken/emscripten/hooks","issue_events_url":"https://api.github.com/repos/kripken/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/kripken/emscripten/events","assignees_url":"https://api.github.com/repos/kripken/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/kripken/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/kripken/emscripten/tags","blobs_url":"https://api.github.com/repos/kripken/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kripken/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kripken/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/kripken/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/kripken/emscripten/languages","stargazers_url":"https://api.github.com/repos/kripken/emscripten/stargazers","contributors_url":"https://api.github.com/repos/kripken/emscripten/contributors","subscribers_url":"https://api.github.com/repos/kripken/emscripten/subscribers","subscription_url":"https://api.github.com/repos/kripken/emscripten/subscription","commits_url":"https://api.github.com/repos/kripken/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/kripken/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/kripken/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/kripken/emscripten/issues/comments{/number}","contents_url":"https://api.github.com/repos/kripken/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/kripken/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kripken/emscripten/merges","archive_url":"https://api.github.com/repos/kripken/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kripken/emscripten/downloads","issues_url":"https://api.github.com/repos/kripken/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/kripken/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/kripken/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/kripken/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kripken/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/kripken/emscripten/releases{/id}","created_at":"2011-02-12T05:23:30Z","updated_at":"2015-09-22T19:13:41Z","pushed_at":"2015-09-22T22:43:30Z","git_url":"git://github.com/kripken/emscripten.git","ssh_url":"git@github.com:kripken/emscripten.git","clone_url":"https://github.com/kripken/emscripten.git","svn_url":"https://github.com/kripken/emscripten","homepage":"","size":238412,"stargazers_count":8868,"watchers_count":8868,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1051,"mirror_url":null,"open_issues_count":684,"forks":1051,"open_issues":684,"watchers":8868,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/3781"},"html":{"href":"https://github.com/kripken/emscripten/pull/3781"},"issue":{"href":"https://api.github.com/repos/kripken/emscripten/issues/3781"},"comments":{"href":"https://api.github.com/repos/kripken/emscripten/issues/3781/comments"},"review_comments":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/3781/comments"},"review_comment":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/3781/commits"},"statuses":{"href":"https://api.github.com/repos/kripken/emscripten/statuses/41b9bb8d45dfbd580ee02010cf1b3ab5dac2d820"}}}}