{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/whitehall/pulls/comments/31238335","id":31238335,"diff_hunk":"@@ -47,4 +47,26 @@ def organisation\n     assert_equal MinisterialRole.whip.order(:seniority).to_a, [role_2, role_1]\n     assert_equal MinisterialRole.whip.order(:whip_ordering).to_a, [role_1, role_2]\n   end\n+\n+  test 'should list ministerial organisations in ministerial order' do\n+    org_1 = create(:ministerial_department, ministerial_ordering: 0)\n+    org_2 = create(:ministerial_department, ministerial_ordering: 2)\n+    org_3 = create(:ministerial_department, ministerial_ordering: 1)\n+\n+    get :show\n+\n+    assert_equal assigns(:organisations).to_a, [org_1, org_3, org_2]","path":"test/functional/admin/cabinet_ministers_controller_test.rb","position":12,"original_position":12,"commit_id":"9f9c64a4c9fd1b24ffe6634e1ee54fc5497a32e6","original_commit_id":"9f9c64a4c9fd1b24ffe6634e1ee54fc5497a32e6","user":{"login":"tekin","id":3687,"avatar_url":"https://avatars.githubusercontent.com/u/3687?v=3","gravatar_id":"","url":"https://api.github.com/users/tekin","html_url":"https://github.com/tekin","followers_url":"https://api.github.com/users/tekin/followers","following_url":"https://api.github.com/users/tekin/following{/other_user}","gists_url":"https://api.github.com/users/tekin/gists{/gist_id}","starred_url":"https://api.github.com/users/tekin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tekin/subscriptions","organizations_url":"https://api.github.com/users/tekin/orgs","repos_url":"https://api.github.com/users/tekin/repos","events_url":"https://api.github.com/users/tekin/events{/privacy}","received_events_url":"https://api.github.com/users/tekin/received_events","type":"User","site_admin":false},"body":"It's worth noting that Rails 5 [deprecates `assigns`](https://github.com/rails/rails/issues/18950) so ideally we should be moving away from this style of testing.","created_at":"2015-05-28T14:26:58Z","updated_at":"2015-05-28T14:26:58Z","html_url":"https://github.com/alphagov/whitehall/pull/2199#discussion_r31238335","pull_request_url":"https://api.github.com/repos/alphagov/whitehall/pulls/2199","_links":{"self":{"href":"https://api.github.com/repos/alphagov/whitehall/pulls/comments/31238335"},"html":{"href":"https://github.com/alphagov/whitehall/pull/2199#discussion_r31238335"},"pull_request":{"href":"https://api.github.com/repos/alphagov/whitehall/pulls/2199"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/whitehall/pulls/2199","id":36390449,"html_url":"https://github.com/alphagov/whitehall/pull/2199","diff_url":"https://github.com/alphagov/whitehall/pull/2199.diff","patch_url":"https://github.com/alphagov/whitehall/pull/2199.patch","issue_url":"https://api.github.com/repos/alphagov/whitehall/issues/2199","number":2199,"state":"open","locked":false,"title":"Add ordering to ministerial departments","user":{"login":"edds","id":35035,"avatar_url":"https://avatars.githubusercontent.com/u/35035?v=3","gravatar_id":"","url":"https://api.github.com/users/edds","html_url":"https://github.com/edds","followers_url":"https://api.github.com/users/edds/followers","following_url":"https://api.github.com/users/edds/following{/other_user}","gists_url":"https://api.github.com/users/edds/gists{/gist_id}","starred_url":"https://api.github.com/users/edds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edds/subscriptions","organizations_url":"https://api.github.com/users/edds/orgs","repos_url":"https://api.github.com/users/edds/repos","events_url":"https://api.github.com/users/edds/events{/privacy}","received_events_url":"https://api.github.com/users/edds/received_events","type":"User","site_admin":false},"body":"There is a need to manually curate the order which departments are\r\nlisted on the ministers page. This adds a ministerial ordering to\r\norganisations which can be updated on the cabinet ministers page.\r\n\r\nAlso updated the prefix on the ministers by org objects on the ministers\r\npage as some ministers were appearing twice and causing the same html ID\r\nto be used twice. As this is invalid markup nokogiri was failing.","created_at":"2015-05-28T10:05:58Z","updated_at":"2015-05-28T14:26:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb634e0e248696533f57fd022768816c7c5cdb98","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/whitehall/pulls/2199/commits","review_comments_url":"https://api.github.com/repos/alphagov/whitehall/pulls/2199/comments","review_comment_url":"https://api.github.com/repos/alphagov/whitehall/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/whitehall/issues/2199/comments","statuses_url":"https://api.github.com/repos/alphagov/whitehall/statuses/9f9c64a4c9fd1b24ffe6634e1ee54fc5497a32e6","head":{"label":"alphagov:add-org-ordering","ref":"add-org-ordering","sha":"9f9c64a4c9fd1b24ffe6634e1ee54fc5497a32e6","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2416064,"name":"whitehall","full_name":"alphagov/whitehall","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/whitehall","description":"Inside Government: how the UK Government works, what it's doing, and how you can get involved.","fork":false,"url":"https://api.github.com/repos/alphagov/whitehall","forks_url":"https://api.github.com/repos/alphagov/whitehall/forks","keys_url":"https://api.github.com/repos/alphagov/whitehall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/whitehall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/whitehall/teams","hooks_url":"https://api.github.com/repos/alphagov/whitehall/hooks","issue_events_url":"https://api.github.com/repos/alphagov/whitehall/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/whitehall/events","assignees_url":"https://api.github.com/repos/alphagov/whitehall/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/whitehall/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/whitehall/tags","blobs_url":"https://api.github.com/repos/alphagov/whitehall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/whitehall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/whitehall/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/whitehall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/whitehall/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/whitehall/languages","stargazers_url":"https://api.github.com/repos/alphagov/whitehall/stargazers","contributors_url":"https://api.github.com/repos/alphagov/whitehall/contributors","subscribers_url":"https://api.github.com/repos/alphagov/whitehall/subscribers","subscription_url":"https://api.github.com/repos/alphagov/whitehall/subscription","commits_url":"https://api.github.com/repos/alphagov/whitehall/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/whitehall/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/whitehall/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/whitehall/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/whitehall/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/whitehall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/whitehall/merges","archive_url":"https://api.github.com/repos/alphagov/whitehall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/whitehall/downloads","issues_url":"https://api.github.com/repos/alphagov/whitehall/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/whitehall/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/whitehall/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/whitehall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/whitehall/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/whitehall/releases{/id}","created_at":"2011-09-19T15:10:49Z","updated_at":"2015-05-27T13:31:37Z","pushed_at":"2015-05-28T14:20:54Z","git_url":"git://github.com/alphagov/whitehall.git","ssh_url":"git@github.com:alphagov/whitehall.git","clone_url":"https://github.com/alphagov/whitehall.git","svn_url":"https://github.com/alphagov/whitehall","homepage":"https://www.gov.uk/government/","size":377775,"stargazers_count":296,"watchers_count":296,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"open_issues_count":6,"forks":126,"open_issues":6,"watchers":296,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"8941f7abe2c1c7247c407204c06bed1668216f62","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2416064,"name":"whitehall","full_name":"alphagov/whitehall","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/whitehall","description":"Inside Government: how the UK Government works, what it's doing, and how you can get involved.","fork":false,"url":"https://api.github.com/repos/alphagov/whitehall","forks_url":"https://api.github.com/repos/alphagov/whitehall/forks","keys_url":"https://api.github.com/repos/alphagov/whitehall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/whitehall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/whitehall/teams","hooks_url":"https://api.github.com/repos/alphagov/whitehall/hooks","issue_events_url":"https://api.github.com/repos/alphagov/whitehall/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/whitehall/events","assignees_url":"https://api.github.com/repos/alphagov/whitehall/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/whitehall/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/whitehall/tags","blobs_url":"https://api.github.com/repos/alphagov/whitehall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/whitehall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/whitehall/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/whitehall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/whitehall/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/whitehall/languages","stargazers_url":"https://api.github.com/repos/alphagov/whitehall/stargazers","contributors_url":"https://api.github.com/repos/alphagov/whitehall/contributors","subscribers_url":"https://api.github.com/repos/alphagov/whitehall/subscribers","subscription_url":"https://api.github.com/repos/alphagov/whitehall/subscription","commits_url":"https://api.github.com/repos/alphagov/whitehall/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/whitehall/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/whitehall/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/whitehall/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/whitehall/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/whitehall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/whitehall/merges","archive_url":"https://api.github.com/repos/alphagov/whitehall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/whitehall/downloads","issues_url":"https://api.github.com/repos/alphagov/whitehall/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/whitehall/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/whitehall/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/whitehall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/whitehall/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/whitehall/releases{/id}","created_at":"2011-09-19T15:10:49Z","updated_at":"2015-05-27T13:31:37Z","pushed_at":"2015-05-28T14:20:54Z","git_url":"git://github.com/alphagov/whitehall.git","ssh_url":"git@github.com:alphagov/whitehall.git","clone_url":"https://github.com/alphagov/whitehall.git","svn_url":"https://github.com/alphagov/whitehall","homepage":"https://www.gov.uk/government/","size":377775,"stargazers_count":296,"watchers_count":296,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"open_issues_count":6,"forks":126,"open_issues":6,"watchers":296,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/whitehall/pulls/2199"},"html":{"href":"https://github.com/alphagov/whitehall/pull/2199"},"issue":{"href":"https://api.github.com/repos/alphagov/whitehall/issues/2199"},"comments":{"href":"https://api.github.com/repos/alphagov/whitehall/issues/2199/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/whitehall/pulls/2199/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/whitehall/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/whitehall/pulls/2199/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/whitehall/statuses/9f9c64a4c9fd1b24ffe6634e1ee54fc5497a32e6"}}}}