{"action":"closed","issue":{"url":"https://api.github.com/repos/Dean177/lunch/issues/12","labels_url":"https://api.github.com/repos/Dean177/lunch/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/Dean177/lunch/issues/12/comments","events_url":"https://api.github.com/repos/Dean177/lunch/issues/12/events","html_url":"https://github.com/Dean177/lunch/issues/12","id":111900784,"number":12,"title":"Deployment/production issues","user":{"login":"olevett","id":8627917,"avatar_url":"https://avatars.githubusercontent.com/u/8627917?v=3","gravatar_id":"","url":"https://api.github.com/users/olevett","html_url":"https://github.com/olevett","followers_url":"https://api.github.com/users/olevett/followers","following_url":"https://api.github.com/users/olevett/following{/other_user}","gists_url":"https://api.github.com/users/olevett/gists{/gist_id}","starred_url":"https://api.github.com/users/olevett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olevett/subscriptions","organizations_url":"https://api.github.com/users/olevett/orgs","repos_url":"https://api.github.com/users/olevett/repos","events_url":"https://api.github.com/users/olevett/events{/privacy}","received_events_url":"https://api.github.com/users/olevett/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-16T20:01:15Z","updated_at":"2015-10-17T12:13:24Z","closed_at":"2015-10-17T12:13:24Z","body":"When doing a deployment/production release, there are a couple of issues\r\n- [x] Gulp requires Babel, which is a dev-dependency, so isn't available when doing `npm install --production`. The make command then fails preventing building\r\n- [ ] `SET` in package.json (`SET NODE_ENV...`) is a Windowsy thing, so on a linux box just breaks things. I think setting environment variables should be handled by the OS running the app/outside of the Node script, and this might also simplify running things"}}