{"action":"created","comment":{"url":"https://api.github.com/repos/control-center/serviced/pulls/comments/41634181","id":41634181,"diff_hunk":"@@ -267,6 +267,7 @@ func (l *ServiceListener) sync(svc *service.Service, rss []dao.RunningService) b\n \t\t// resumeInstance updates the service state ONLY if it has a PAUSED DesiredState\n \t\tif err := resumeInstance(l.conn, state.HostID, state.ID); err != nil {\n \t\t\tglog.Warningf(\"Could not resume paused service instance %s (%s) for service %s on host %s: %s\", state.ID, state.Name, state.ServiceID, state.HostID, err)\n+\t\t\treturn false","path":"zzk/service/service.go","position":4,"original_position":4,"commit_id":"a5ec5e00a9d724b8718b67252857059903562043","original_commit_id":"a5ec5e00a9d724b8718b67252857059903562043","user":{"login":"tgjonestx","id":2204589,"avatar_url":"https://avatars.githubusercontent.com/u/2204589?v=3","gravatar_id":"","url":"https://api.github.com/users/tgjonestx","html_url":"https://github.com/tgjonestx","followers_url":"https://api.github.com/users/tgjonestx/followers","following_url":"https://api.github.com/users/tgjonestx/following{/other_user}","gists_url":"https://api.github.com/users/tgjonestx/gists{/gist_id}","starred_url":"https://api.github.com/users/tgjonestx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgjonestx/subscriptions","organizations_url":"https://api.github.com/users/tgjonestx/orgs","repos_url":"https://api.github.com/users/tgjonestx/repos","events_url":"https://api.github.com/users/tgjonestx/events{/privacy}","received_events_url":"https://api.github.com/users/tgjonestx/received_events","type":"User","site_admin":false},"body":"Talked to Summer - the changes are fine, but Github says the code needs to be merged first","created_at":"2015-10-09T14:15:49Z","updated_at":"2015-10-09T14:15:49Z","html_url":"https://github.com/control-center/serviced/pull/2039#discussion_r41634181","pull_request_url":"https://api.github.com/repos/control-center/serviced/pulls/2039","_links":{"self":{"href":"https://api.github.com/repos/control-center/serviced/pulls/comments/41634181"},"html":{"href":"https://github.com/control-center/serviced/pull/2039#discussion_r41634181"},"pull_request":{"href":"https://api.github.com/repos/control-center/serviced/pulls/2039"}}},"pull_request":{"url":"https://api.github.com/repos/control-center/serviced/pulls/2039","id":47216507,"html_url":"https://github.com/control-center/serviced/pull/2039","diff_url":"https://github.com/control-center/serviced/pull/2039.diff","patch_url":"https://github.com/control-center/serviced/pull/2039.patch","issue_url":"https://api.github.com/repos/control-center/serviced/issues/2039","number":2039,"state":"open","locked":false,"title":"CC-1354: Retry sync() if resuming instances fails","user":{"login":"kwalkerz","id":12804807,"avatar_url":"https://avatars.githubusercontent.com/u/12804807?v=3","gravatar_id":"","url":"https://api.github.com/users/kwalkerz","html_url":"https://github.com/kwalkerz","followers_url":"https://api.github.com/users/kwalkerz/followers","following_url":"https://api.github.com/users/kwalkerz/following{/other_user}","gists_url":"https://api.github.com/users/kwalkerz/gists{/gist_id}","starred_url":"https://api.github.com/users/kwalkerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwalkerz/subscriptions","organizations_url":"https://api.github.com/users/kwalkerz/orgs","repos_url":"https://api.github.com/users/kwalkerz/repos","events_url":"https://api.github.com/users/kwalkerz/events{/privacy}","received_events_url":"https://api.github.com/users/kwalkerz/received_events","type":"User","site_admin":false},"body":"sync() was not returning false in this case, so the caller was not\r\nsetting the retry timer.  Which led to the test case timing out.","created_at":"2015-10-08T22:51:47Z","updated_at":"2015-10-09T14:15:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"029583cc8e9e281be401ce8fe9573973267fe405","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/control-center/serviced/pulls/2039/commits","review_comments_url":"https://api.github.com/repos/control-center/serviced/pulls/2039/comments","review_comment_url":"https://api.github.com/repos/control-center/serviced/pulls/comments{/number}","comments_url":"https://api.github.com/repos/control-center/serviced/issues/2039/comments","statuses_url":"https://api.github.com/repos/control-center/serviced/statuses/a5ec5e00a9d724b8718b67252857059903562043","head":{"label":"control-center:feature/CC-1354.2","ref":"feature/CC-1354.2","sha":"a5ec5e00a9d724b8718b67252857059903562043","user":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"repo":{"id":11929217,"name":"serviced","full_name":"control-center/serviced","owner":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/control-center/serviced","description":"Serviced is a PaaS runtime. It allows users to create, manage and scale services in a uniform way.","fork":false,"url":"https://api.github.com/repos/control-center/serviced","forks_url":"https://api.github.com/repos/control-center/serviced/forks","keys_url":"https://api.github.com/repos/control-center/serviced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/control-center/serviced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/control-center/serviced/teams","hooks_url":"https://api.github.com/repos/control-center/serviced/hooks","issue_events_url":"https://api.github.com/repos/control-center/serviced/issues/events{/number}","events_url":"https://api.github.com/repos/control-center/serviced/events","assignees_url":"https://api.github.com/repos/control-center/serviced/assignees{/user}","branches_url":"https://api.github.com/repos/control-center/serviced/branches{/branch}","tags_url":"https://api.github.com/repos/control-center/serviced/tags","blobs_url":"https://api.github.com/repos/control-center/serviced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/control-center/serviced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/control-center/serviced/git/refs{/sha}","trees_url":"https://api.github.com/repos/control-center/serviced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/control-center/serviced/statuses/{sha}","languages_url":"https://api.github.com/repos/control-center/serviced/languages","stargazers_url":"https://api.github.com/repos/control-center/serviced/stargazers","contributors_url":"https://api.github.com/repos/control-center/serviced/contributors","subscribers_url":"https://api.github.com/repos/control-center/serviced/subscribers","subscription_url":"https://api.github.com/repos/control-center/serviced/subscription","commits_url":"https://api.github.com/repos/control-center/serviced/commits{/sha}","git_commits_url":"https://api.github.com/repos/control-center/serviced/git/commits{/sha}","comments_url":"https://api.github.com/repos/control-center/serviced/comments{/number}","issue_comment_url":"https://api.github.com/repos/control-center/serviced/issues/comments{/number}","contents_url":"https://api.github.com/repos/control-center/serviced/contents/{+path}","compare_url":"https://api.github.com/repos/control-center/serviced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/control-center/serviced/merges","archive_url":"https://api.github.com/repos/control-center/serviced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/control-center/serviced/downloads","issues_url":"https://api.github.com/repos/control-center/serviced/issues{/number}","pulls_url":"https://api.github.com/repos/control-center/serviced/pulls{/number}","milestones_url":"https://api.github.com/repos/control-center/serviced/milestones{/number}","notifications_url":"https://api.github.com/repos/control-center/serviced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/control-center/serviced/labels{/name}","releases_url":"https://api.github.com/repos/control-center/serviced/releases{/id}","created_at":"2013-08-06T16:45:00Z","updated_at":"2015-10-05T03:26:17Z","pushed_at":"2015-10-09T14:07:07Z","git_url":"git://github.com/control-center/serviced.git","ssh_url":"git@github.com:control-center/serviced.git","clone_url":"https://github.com/control-center/serviced.git","svn_url":"https://github.com/control-center/serviced","homepage":null,"size":77516,"stargazers_count":73,"watchers_count":73,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":8,"forks":9,"open_issues":8,"watchers":73,"default_branch":"develop"}},"base":{"label":"control-center:develop","ref":"develop","sha":"223b2b8466916c8ae99d4c1bb4cb7403c983589f","user":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"repo":{"id":11929217,"name":"serviced","full_name":"control-center/serviced","owner":{"login":"control-center","id":8160673,"avatar_url":"https://avatars.githubusercontent.com/u/8160673?v=3","gravatar_id":"","url":"https://api.github.com/users/control-center","html_url":"https://github.com/control-center","followers_url":"https://api.github.com/users/control-center/followers","following_url":"https://api.github.com/users/control-center/following{/other_user}","gists_url":"https://api.github.com/users/control-center/gists{/gist_id}","starred_url":"https://api.github.com/users/control-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/control-center/subscriptions","organizations_url":"https://api.github.com/users/control-center/orgs","repos_url":"https://api.github.com/users/control-center/repos","events_url":"https://api.github.com/users/control-center/events{/privacy}","received_events_url":"https://api.github.com/users/control-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/control-center/serviced","description":"Serviced is a PaaS runtime. It allows users to create, manage and scale services in a uniform way.","fork":false,"url":"https://api.github.com/repos/control-center/serviced","forks_url":"https://api.github.com/repos/control-center/serviced/forks","keys_url":"https://api.github.com/repos/control-center/serviced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/control-center/serviced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/control-center/serviced/teams","hooks_url":"https://api.github.com/repos/control-center/serviced/hooks","issue_events_url":"https://api.github.com/repos/control-center/serviced/issues/events{/number}","events_url":"https://api.github.com/repos/control-center/serviced/events","assignees_url":"https://api.github.com/repos/control-center/serviced/assignees{/user}","branches_url":"https://api.github.com/repos/control-center/serviced/branches{/branch}","tags_url":"https://api.github.com/repos/control-center/serviced/tags","blobs_url":"https://api.github.com/repos/control-center/serviced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/control-center/serviced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/control-center/serviced/git/refs{/sha}","trees_url":"https://api.github.com/repos/control-center/serviced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/control-center/serviced/statuses/{sha}","languages_url":"https://api.github.com/repos/control-center/serviced/languages","stargazers_url":"https://api.github.com/repos/control-center/serviced/stargazers","contributors_url":"https://api.github.com/repos/control-center/serviced/contributors","subscribers_url":"https://api.github.com/repos/control-center/serviced/subscribers","subscription_url":"https://api.github.com/repos/control-center/serviced/subscription","commits_url":"https://api.github.com/repos/control-center/serviced/commits{/sha}","git_commits_url":"https://api.github.com/repos/control-center/serviced/git/commits{/sha}","comments_url":"https://api.github.com/repos/control-center/serviced/comments{/number}","issue_comment_url":"https://api.github.com/repos/control-center/serviced/issues/comments{/number}","contents_url":"https://api.github.com/repos/control-center/serviced/contents/{+path}","compare_url":"https://api.github.com/repos/control-center/serviced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/control-center/serviced/merges","archive_url":"https://api.github.com/repos/control-center/serviced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/control-center/serviced/downloads","issues_url":"https://api.github.com/repos/control-center/serviced/issues{/number}","pulls_url":"https://api.github.com/repos/control-center/serviced/pulls{/number}","milestones_url":"https://api.github.com/repos/control-center/serviced/milestones{/number}","notifications_url":"https://api.github.com/repos/control-center/serviced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/control-center/serviced/labels{/name}","releases_url":"https://api.github.com/repos/control-center/serviced/releases{/id}","created_at":"2013-08-06T16:45:00Z","updated_at":"2015-10-05T03:26:17Z","pushed_at":"2015-10-09T14:07:07Z","git_url":"git://github.com/control-center/serviced.git","ssh_url":"git@github.com:control-center/serviced.git","clone_url":"https://github.com/control-center/serviced.git","svn_url":"https://github.com/control-center/serviced","homepage":null,"size":77516,"stargazers_count":73,"watchers_count":73,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":8,"forks":9,"open_issues":8,"watchers":73,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/control-center/serviced/pulls/2039"},"html":{"href":"https://github.com/control-center/serviced/pull/2039"},"issue":{"href":"https://api.github.com/repos/control-center/serviced/issues/2039"},"comments":{"href":"https://api.github.com/repos/control-center/serviced/issues/2039/comments"},"review_comments":{"href":"https://api.github.com/repos/control-center/serviced/pulls/2039/comments"},"review_comment":{"href":"https://api.github.com/repos/control-center/serviced/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/control-center/serviced/pulls/2039/commits"},"statuses":{"href":"https://api.github.com/repos/control-center/serviced/statuses/a5ec5e00a9d724b8718b67252857059903562043"}}}}