{"action":"created","comment":{"url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/pulls/comments/24931486","id":24931486,"diff_hunk":"@@ -84,12 +84,42 @@ public final void testWeightLoss() throws Exception\n                 3.0f,\n                 rule.apply(new Rule.EvaluationContext(3.0f, values)),\n                 0.0);\n-\n         values.put(currWeight, currWeight.makeValue(140));\n         assertEquals(\n                 0.0f,\n                 rule.apply(new Rule.EvaluationContext(3.0f, values)),\n                 0.0f);\n+        values.clear();\n+        values.put(currWeight, currWeight.makeValue(140));\n+        assertEquals(\n+        \t\t0.0f,\n+                rule.apply(new Rule.EvaluationContext(3.0f, values)),\n+                0.0f);\n+    }\n+    \n+    @Test(expected=MissingValueException.class)\n+    public final void testRequired() throws Exception","path":"srcalc/src/test/java/gov/va/med/srcalc/domain/model/RuleTest.java","position":46,"original_position":46,"commit_id":"d80c2a4aa0a2ec6380ba2e2ed66343a0684a0bb4","original_commit_id":"d80c2a4aa0a2ec6380ba2e2ed66343a0684a0bb4","user":{"login":"dgtombs","id":5116096,"avatar_url":"https://avatars.githubusercontent.com/u/5116096?v=3","gravatar_id":"","url":"https://api.github.com/users/dgtombs","html_url":"https://github.com/dgtombs","followers_url":"https://api.github.com/users/dgtombs/followers","following_url":"https://api.github.com/users/dgtombs/following{/other_user}","gists_url":"https://api.github.com/users/dgtombs/gists{/gist_id}","starred_url":"https://api.github.com/users/dgtombs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgtombs/subscriptions","organizations_url":"https://api.github.com/users/dgtombs/orgs","repos_url":"https://api.github.com/users/dgtombs/repos","events_url":"https://api.github.com/users/dgtombs/events{/privacy}","received_events_url":"https://api.github.com/users/dgtombs/received_events","type":"User","site_admin":false},"body":"It looks like this test tests both required=false and required=true. We should split this into two tests to avoid false positives (if the first call to `apply()` throws `MissingValueException`).","created_at":"2015-02-18T19:20:21Z","updated_at":"2015-02-18T19:20:21Z","html_url":"https://github.com/VHAINNOVATIONS/ASRCM/pull/18#discussion_r24931486","pull_request_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/pulls/comments/24931486"},"html":{"href":"https://github.com/VHAINNOVATIONS/ASRCM/pull/18#discussion_r24931486"},"pull_request":{"href":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/pulls/18","id":29544103,"html_url":"https://github.com/VHAINNOVATIONS/ASRCM/pull/18","diff_url":"https://github.com/VHAINNOVATIONS/ASRCM/pull/18.diff","patch_url":"https://github.com/VHAINNOVATIONS/ASRCM/pull/18.patch","issue_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/issues/18","number":18,"state":"open","locked":false,"title":"Variables now have the option to either be required or not required for","user":{"login":"jamesbigmac","id":10212113,"avatar_url":"https://avatars.githubusercontent.com/u/10212113?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesbigmac","html_url":"https://github.com/jamesbigmac","followers_url":"https://api.github.com/users/jamesbigmac/followers","following_url":"https://api.github.com/users/jamesbigmac/following{/other_user}","gists_url":"https://api.github.com/users/jamesbigmac/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesbigmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesbigmac/subscriptions","organizations_url":"https://api.github.com/users/jamesbigmac/orgs","repos_url":"https://api.github.com/users/jamesbigmac/repos","events_url":"https://api.github.com/users/jamesbigmac/events{/privacy}","received_events_url":"https://api.github.com/users/jamesbigmac/received_events","type":"User","site_admin":false},"body":"a calculation. Rules can also be required or not required.","created_at":"2015-02-18T17:18:06Z","updated_at":"2015-02-18T19:20:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e11afc0f7f7ce62a0a75394bca2dfb6fccb317d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/pulls/18/commits","review_comments_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/pulls/18/comments","review_comment_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/pulls/comments/{number}","comments_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/issues/18/comments","statuses_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/statuses/d80c2a4aa0a2ec6380ba2e2ed66343a0684a0bb4","head":{"label":"VHAINNOVATIONS:ASRC-27clean","ref":"ASRC-27clean","sha":"d80c2a4aa0a2ec6380ba2e2ed66343a0684a0bb4","user":{"login":"VHAINNOVATIONS","id":1252476,"avatar_url":"https://avatars.githubusercontent.com/u/1252476?v=3","gravatar_id":"","url":"https://api.github.com/users/VHAINNOVATIONS","html_url":"https://github.com/VHAINNOVATIONS","followers_url":"https://api.github.com/users/VHAINNOVATIONS/followers","following_url":"https://api.github.com/users/VHAINNOVATIONS/following{/other_user}","gists_url":"https://api.github.com/users/VHAINNOVATIONS/gists{/gist_id}","starred_url":"https://api.github.com/users/VHAINNOVATIONS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VHAINNOVATIONS/subscriptions","organizations_url":"https://api.github.com/users/VHAINNOVATIONS/orgs","repos_url":"https://api.github.com/users/VHAINNOVATIONS/repos","events_url":"https://api.github.com/users/VHAINNOVATIONS/events{/privacy}","received_events_url":"https://api.github.com/users/VHAINNOVATIONS/received_events","type":"Organization","site_admin":false},"repo":{"id":26819438,"name":"ASRCM","full_name":"VHAINNOVATIONS/ASRCM","owner":{"login":"VHAINNOVATIONS","id":1252476,"avatar_url":"https://avatars.githubusercontent.com/u/1252476?v=3","gravatar_id":"","url":"https://api.github.com/users/VHAINNOVATIONS","html_url":"https://github.com/VHAINNOVATIONS","followers_url":"https://api.github.com/users/VHAINNOVATIONS/followers","following_url":"https://api.github.com/users/VHAINNOVATIONS/following{/other_user}","gists_url":"https://api.github.com/users/VHAINNOVATIONS/gists{/gist_id}","starred_url":"https://api.github.com/users/VHAINNOVATIONS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VHAINNOVATIONS/subscriptions","organizations_url":"https://api.github.com/users/VHAINNOVATIONS/orgs","repos_url":"https://api.github.com/users/VHAINNOVATIONS/repos","events_url":"https://api.github.com/users/VHAINNOVATIONS/events{/privacy}","received_events_url":"https://api.github.com/users/VHAINNOVATIONS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VHAINNOVATIONS/ASRCM","description":"The Automated Surgical Risk Calculator for Mortality Innovation is a project to develop a tool from CPRS through the “Tools” drop down that will auto-fill pertinent information into the developed risk calculator.  The Automated Risk Calculator will utilize the generated data and allow for the user to manually input required information to support clinical decision-making regarding perioperative risk.  The tool will then allow for information to be written back to the patients file in CPRS.  In addition, a secondary tool will be created to store and develop a repository for research of risk calculations developed.  ","fork":false,"url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM","forks_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/forks","keys_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/teams","hooks_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/hooks","issue_events_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/issues/events{/number}","events_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/events","assignees_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/assignees{/user}","branches_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/branches{/branch}","tags_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/tags","blobs_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/git/refs{/sha}","trees_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/statuses/{sha}","languages_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/languages","stargazers_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/stargazers","contributors_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/contributors","subscribers_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/subscribers","subscription_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/subscription","commits_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/commits{/sha}","git_commits_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/git/commits{/sha}","comments_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/comments{/number}","issue_comment_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/issues/comments/{number}","contents_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/contents/{+path}","compare_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/merges","archive_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/downloads","issues_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/issues{/number}","pulls_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/pulls{/number}","milestones_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/milestones{/number}","notifications_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/labels{/name}","releases_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/releases{/id}","created_at":"2014-11-18T16:48:50Z","updated_at":"2015-02-17T20:34:56Z","pushed_at":"2015-02-18T18:44:08Z","git_url":"git://github.com/VHAINNOVATIONS/ASRCM.git","ssh_url":"git@github.com:VHAINNOVATIONS/ASRCM.git","clone_url":"https://github.com/VHAINNOVATIONS/ASRCM.git","svn_url":"https://github.com/VHAINNOVATIONS/ASRCM","homepage":null,"size":3872,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"VHAINNOVATIONS:master","ref":"master","sha":"264ffebf6f0494e6e08c89a81975702041501a26","user":{"login":"VHAINNOVATIONS","id":1252476,"avatar_url":"https://avatars.githubusercontent.com/u/1252476?v=3","gravatar_id":"","url":"https://api.github.com/users/VHAINNOVATIONS","html_url":"https://github.com/VHAINNOVATIONS","followers_url":"https://api.github.com/users/VHAINNOVATIONS/followers","following_url":"https://api.github.com/users/VHAINNOVATIONS/following{/other_user}","gists_url":"https://api.github.com/users/VHAINNOVATIONS/gists{/gist_id}","starred_url":"https://api.github.com/users/VHAINNOVATIONS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VHAINNOVATIONS/subscriptions","organizations_url":"https://api.github.com/users/VHAINNOVATIONS/orgs","repos_url":"https://api.github.com/users/VHAINNOVATIONS/repos","events_url":"https://api.github.com/users/VHAINNOVATIONS/events{/privacy}","received_events_url":"https://api.github.com/users/VHAINNOVATIONS/received_events","type":"Organization","site_admin":false},"repo":{"id":26819438,"name":"ASRCM","full_name":"VHAINNOVATIONS/ASRCM","owner":{"login":"VHAINNOVATIONS","id":1252476,"avatar_url":"https://avatars.githubusercontent.com/u/1252476?v=3","gravatar_id":"","url":"https://api.github.com/users/VHAINNOVATIONS","html_url":"https://github.com/VHAINNOVATIONS","followers_url":"https://api.github.com/users/VHAINNOVATIONS/followers","following_url":"https://api.github.com/users/VHAINNOVATIONS/following{/other_user}","gists_url":"https://api.github.com/users/VHAINNOVATIONS/gists{/gist_id}","starred_url":"https://api.github.com/users/VHAINNOVATIONS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VHAINNOVATIONS/subscriptions","organizations_url":"https://api.github.com/users/VHAINNOVATIONS/orgs","repos_url":"https://api.github.com/users/VHAINNOVATIONS/repos","events_url":"https://api.github.com/users/VHAINNOVATIONS/events{/privacy}","received_events_url":"https://api.github.com/users/VHAINNOVATIONS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VHAINNOVATIONS/ASRCM","description":"The Automated Surgical Risk Calculator for Mortality Innovation is a project to develop a tool from CPRS through the “Tools” drop down that will auto-fill pertinent information into the developed risk calculator.  The Automated Risk Calculator will utilize the generated data and allow for the user to manually input required information to support clinical decision-making regarding perioperative risk.  The tool will then allow for information to be written back to the patients file in CPRS.  In addition, a secondary tool will be created to store and develop a repository for research of risk calculations developed.  ","fork":false,"url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM","forks_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/forks","keys_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/teams","hooks_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/hooks","issue_events_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/issues/events{/number}","events_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/events","assignees_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/assignees{/user}","branches_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/branches{/branch}","tags_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/tags","blobs_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/git/refs{/sha}","trees_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/statuses/{sha}","languages_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/languages","stargazers_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/stargazers","contributors_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/contributors","subscribers_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/subscribers","subscription_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/subscription","commits_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/commits{/sha}","git_commits_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/git/commits{/sha}","comments_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/comments{/number}","issue_comment_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/issues/comments/{number}","contents_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/contents/{+path}","compare_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/merges","archive_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/downloads","issues_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/issues{/number}","pulls_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/pulls{/number}","milestones_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/milestones{/number}","notifications_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/labels{/name}","releases_url":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/releases{/id}","created_at":"2014-11-18T16:48:50Z","updated_at":"2015-02-17T20:34:56Z","pushed_at":"2015-02-18T18:44:08Z","git_url":"git://github.com/VHAINNOVATIONS/ASRCM.git","ssh_url":"git@github.com:VHAINNOVATIONS/ASRCM.git","clone_url":"https://github.com/VHAINNOVATIONS/ASRCM.git","svn_url":"https://github.com/VHAINNOVATIONS/ASRCM","homepage":null,"size":3872,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/pulls/18"},"html":{"href":"https://github.com/VHAINNOVATIONS/ASRCM/pull/18"},"issue":{"href":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/issues/18"},"comments":{"href":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/VHAINNOVATIONS/ASRCM/statuses/d80c2a4aa0a2ec6380ba2e2ed66343a0684a0bb4"}}}}