{"action":"created","issue":{"url":"https://api.github.com/repos/Slicer/Slicer/issues/386","labels_url":"https://api.github.com/repos/Slicer/Slicer/issues/386/labels{/name}","comments_url":"https://api.github.com/repos/Slicer/Slicer/issues/386/comments","events_url":"https://api.github.com/repos/Slicer/Slicer/issues/386/events","html_url":"https://github.com/Slicer/Slicer/pull/386","id":113109050,"number":386,"title":"BUG: Preserve custom color tables on scene view restore","user":{"login":"naucoin","id":289054,"avatar_url":"https://avatars.githubusercontent.com/u/289054?v=3","gravatar_id":"","url":"https://api.github.com/users/naucoin","html_url":"https://github.com/naucoin","followers_url":"https://api.github.com/users/naucoin/followers","following_url":"https://api.github.com/users/naucoin/following{/other_user}","gists_url":"https://api.github.com/users/naucoin/gists{/gist_id}","starred_url":"https://api.github.com/users/naucoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naucoin/subscriptions","organizations_url":"https://api.github.com/users/naucoin/orgs","repos_url":"https://api.github.com/users/naucoin/repos","events_url":"https://api.github.com/users/naucoin/events{/privacy}","received_events_url":"https://api.github.com/users/naucoin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-10-23T22:12:46Z","updated_at":"2015-10-28T00:13:02Z","closed_at":"2015-10-28T00:12:54Z","pull_request":{"url":"https://api.github.com/repos/Slicer/Slicer/pulls/386","html_url":"https://github.com/Slicer/Slicer/pull/386","diff_url":"https://github.com/Slicer/Slicer/pull/386.diff","patch_url":"https://github.com/Slicer/Slicer/pull/386.patch"},"body":"Moving the color table information into files on disk created\r\na bug (analogous to the same situation with fiducials[1]) that when\r\na scene contains scene views that contain custom color tables\r\nthe scene view restore wipes out the colors in the color node\r\nin the main scene. When a MRML file is read, the files on disk\r\nare not reread to fill in scene view nodes, so the scene view\r\ncolor table node is empty. This fix adds a check for if the\r\nscene is currently restoring a scene view, and if so, don't\r\nproceed with the copy as it will result in an color table\r\nwith the correct number of entries (as the number of colors is\r\nsaved in the MRML file) but all black and unamed.\r\n\r\n[1] fiducials were fixed in this commit:\r\nhttp://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24376\r\nhttps://github.com/Slicer/Slicer/commit/1440084bbdd9d11c1e9e1f195087f521a91af186\r\n\r\nIssue #3992"},"comment":{"url":"https://api.github.com/repos/Slicer/Slicer/issues/comments/151680975","html_url":"https://github.com/Slicer/Slicer/pull/386#issuecomment-151680975","issue_url":"https://api.github.com/repos/Slicer/Slicer/issues/386","id":151680975,"user":{"login":"jcfr","id":219043,"avatar_url":"https://avatars.githubusercontent.com/u/219043?v=3","gravatar_id":"","url":"https://api.github.com/users/jcfr","html_url":"https://github.com/jcfr","followers_url":"https://api.github.com/users/jcfr/followers","following_url":"https://api.github.com/users/jcfr/following{/other_user}","gists_url":"https://api.github.com/users/jcfr/gists{/gist_id}","starred_url":"https://api.github.com/users/jcfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcfr/subscriptions","organizations_url":"https://api.github.com/users/jcfr/orgs","repos_url":"https://api.github.com/users/jcfr/repos","events_url":"https://api.github.com/users/jcfr/events{/privacy}","received_events_url":"https://api.github.com/users/jcfr/received_events","type":"User","site_admin":false},"created_at":"2015-10-28T00:13:02Z","updated_at":"2015-10-28T00:13:02Z","body":":+1: "}}