{"action":"created","issue":{"url":"https://api.github.com/repos/container-interop/definition-interop/issues/14","labels_url":"https://api.github.com/repos/container-interop/definition-interop/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/container-interop/definition-interop/issues/14/comments","events_url":"https://api.github.com/repos/container-interop/definition-interop/issues/14/events","html_url":"https://github.com/container-interop/definition-interop/pull/14","id":119304495,"number":14,"title":"Remove identifiers from definitions, allow nested definitions instead","user":{"login":"mnapoli","id":720328,"avatar_url":"https://avatars.githubusercontent.com/u/720328?v=3","gravatar_id":"","url":"https://api.github.com/users/mnapoli","html_url":"https://github.com/mnapoli","followers_url":"https://api.github.com/users/mnapoli/followers","following_url":"https://api.github.com/users/mnapoli/following{/other_user}","gists_url":"https://api.github.com/users/mnapoli/gists{/gist_id}","starred_url":"https://api.github.com/users/mnapoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnapoli/subscriptions","organizations_url":"https://api.github.com/users/mnapoli/orgs","repos_url":"https://api.github.com/users/mnapoli/repos","events_url":"https://api.github.com/users/mnapoli/events{/privacy}","received_events_url":"https://api.github.com/users/mnapoli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-11-28T16:18:05Z","updated_at":"2015-11-29T21:52:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/container-interop/definition-interop/pulls/14","html_url":"https://github.com/container-interop/definition-interop/pull/14","diff_url":"https://github.com/container-interop/definition-interop/pull/14.diff","patch_url":"https://github.com/container-interop/definition-interop/pull/14.patch"},"body":"This was discussion via hangout today. The idea is that `DefinitionProviderInterface` should return definitions indexed by definition IDs. This makes much more sense, and is much more optimized for real scenarios (even though it's an implementation detail, it's a major detail if we have to call `getIdentifier` on 100+ objects every single time).\r\n\r\nThat also allows definitions to be nested (since they have no names anymore), instead of having to expose them through the container via a definition name. This is the equivalent of \"private services\" in Symfony for example, or nested definitions in PHP-DI.\r\n\r\nThat had the effect of making alias definitions and references identical => the reference became a definition and aliases are not needed anymore. I don't know if it's obvious, feedback welcome."},"comment":{"url":"https://api.github.com/repos/container-interop/definition-interop/issues/comments/160474695","html_url":"https://github.com/container-interop/definition-interop/pull/14#issuecomment-160474695","issue_url":"https://api.github.com/repos/container-interop/definition-interop/issues/14","id":160474695,"user":{"login":"moufmouf","id":1290952,"avatar_url":"https://avatars.githubusercontent.com/u/1290952?v=3","gravatar_id":"","url":"https://api.github.com/users/moufmouf","html_url":"https://github.com/moufmouf","followers_url":"https://api.github.com/users/moufmouf/followers","following_url":"https://api.github.com/users/moufmouf/following{/other_user}","gists_url":"https://api.github.com/users/moufmouf/gists{/gist_id}","starred_url":"https://api.github.com/users/moufmouf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moufmouf/subscriptions","organizations_url":"https://api.github.com/users/moufmouf/orgs","repos_url":"https://api.github.com/users/moufmouf/repos","events_url":"https://api.github.com/users/moufmouf/events{/privacy}","received_events_url":"https://api.github.com/users/moufmouf/received_events","type":"User","site_admin":false},"created_at":"2015-11-29T21:52:55Z","updated_at":"2015-11-29T21:52:55Z","body":"I'd like to try implementing this first in Yaco and YamlDefinitionLoader before merging (just to see how it feels). Do you mind if we wait one day or two before merging?"}}