{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/24587526","id":24587526,"diff_hunk":"@@ -69,10 +69,14 @@ Examples:\n \t\t\t\tNamespaceParam(cmdNamespace).DefaultNamespace().\n \t\t\t\tFilenameParam(flags.Filenames...).\n \t\t\t\tSelectorParam(cmdutil.GetFlagString(cmd, \"selector\")).\n-\t\t\t\tResourceTypeOrNameArgs(args...).\n+\t\t\t\tSelectedResourceTypeOrNameArgs(args...).\n \t\t\t\tFlatten().\n \t\t\t\tDo()\n-\t\t\tcheckErr(r.Err())\n+\n+\t\t\tif r.Err() != nil {","path":"pkg/kubectl/cmd/delete.go","position":10,"original_position":10,"commit_id":"58a5f2b1a3363d2824fcbc0185ba865bf64fa30a","original_commit_id":"58a5f2b1a3363d2824fcbc0185ba865bf64fa30a","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"body":"Ah - this is a more general problem with our client tools.  Since we have this problem everywhere in kubectl (we can't test failures) I'd probably prefer to use `checkErr` for here and do the test in hack/test-cmd.sh (which can test failure).  We do need to correct that problem in kubectl eventually, but I'm a bit worried about having two different ways of checking errors start creeping into the code.","created_at":"2015-02-12T15:16:33Z","updated_at":"2015-02-12T15:16:33Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4381#discussion_r24587526","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4381","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/24587526"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4381#discussion_r24587526"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4381"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4381","id":29185904,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4381","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4381.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4381.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4381","number":4381,"state":"open","locked":false,"title":"kubectl delete resource : remove all resources","user":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars.githubusercontent.com/u/9527409?v=3","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"body":"To fix issue https://github.com/GoogleCloudPlatform/kubernetes/issues/4380","created_at":"2015-02-12T15:05:56Z","updated_at":"2015-02-12T15:16:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d04182306d710b5fe51ec7fa255b3c8348a41d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4381/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4381/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4381/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/58a5f2b1a3363d2824fcbc0185ba865bf64fa30a","head":{"label":"sdminonne:bug_fix","ref":"bug_fix","sha":"58a5f2b1a3363d2824fcbc0185ba865bf64fa30a","user":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars.githubusercontent.com/u/9527409?v=3","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"repo":{"id":27047169,"name":"kubernetes","full_name":"sdminonne/kubernetes","owner":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars.githubusercontent.com/u/9527409?v=3","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdminonne/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/sdminonne/kubernetes","forks_url":"https://api.github.com/repos/sdminonne/kubernetes/forks","keys_url":"https://api.github.com/repos/sdminonne/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdminonne/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdminonne/kubernetes/teams","hooks_url":"https://api.github.com/repos/sdminonne/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/sdminonne/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/sdminonne/kubernetes/events","assignees_url":"https://api.github.com/repos/sdminonne/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/sdminonne/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/sdminonne/kubernetes/tags","blobs_url":"https://api.github.com/repos/sdminonne/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdminonne/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdminonne/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdminonne/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdminonne/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/sdminonne/kubernetes/languages","stargazers_url":"https://api.github.com/repos/sdminonne/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/sdminonne/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/sdminonne/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/sdminonne/kubernetes/subscription","commits_url":"https://api.github.com/repos/sdminonne/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdminonne/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdminonne/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdminonne/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/sdminonne/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/sdminonne/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdminonne/kubernetes/merges","archive_url":"https://api.github.com/repos/sdminonne/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdminonne/kubernetes/downloads","issues_url":"https://api.github.com/repos/sdminonne/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/sdminonne/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/sdminonne/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/sdminonne/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdminonne/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/sdminonne/kubernetes/releases{/id}","created_at":"2014-11-23T20:52:45Z","updated_at":"2015-02-12T08:19:18Z","pushed_at":"2015-02-12T15:00:32Z","git_url":"git://github.com/sdminonne/kubernetes.git","ssh_url":"git@github.com:sdminonne/kubernetes.git","clone_url":"https://github.com/sdminonne/kubernetes.git","svn_url":"https://github.com/sdminonne/kubernetes","homepage":null,"size":29511,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"0a2d713803a467edd2d40afc3ee030f804df4e33","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-02-12T15:09:23Z","pushed_at":"2015-02-12T15:09:22Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":73991,"stargazers_count":6183,"watchers_count":6183,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1076,"mirror_url":null,"open_issues_count":689,"forks":1076,"open_issues":689,"watchers":6183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4381"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/4381"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4381"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4381/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4381/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/4381/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/58a5f2b1a3363d2824fcbc0185ba865bf64fa30a"}}}}