{"action":"created","comment":{"url":"https://api.github.com/repos/bitpay/bitcore/pulls/comments/24904956","id":24904956,"diff_hunk":"@@ -401,6 +401,17 @@ describe('Transaction', function() {\n         transaction.addInput(new Transaction.Input(), Script.empty(), 0);\n       }).to.not.throw();\n     });\n+    it('does not allow a threshold number greater than the amount of public keys', function() {\n+      expect(function() {\n+        transaction = new Transaction();\n+        return transaction.from({\n+          txId: '0000000000000000000000000000000000000000000000000000000000000000',\n+          outputIndex: 0,\n+          script: Script.buildMultisigOut([public1, public2], 2).toScriptHashOut(),","path":"test/transaction/transaction.js","position":32,"original_position":32,"commit_id":"48afacecb3bc9b4a86d6a6527a02afff416b42c0","original_commit_id":"48afacecb3bc9b4a86d6a6527a02afff416b42c0","user":{"login":"eordano","id":42750,"avatar_url":"https://avatars.githubusercontent.com/u/42750?v=3","gravatar_id":"","url":"https://api.github.com/users/eordano","html_url":"https://github.com/eordano","followers_url":"https://api.github.com/users/eordano/followers","following_url":"https://api.github.com/users/eordano/following{/other_user}","gists_url":"https://api.github.com/users/eordano/gists{/gist_id}","starred_url":"https://api.github.com/users/eordano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eordano/subscriptions","organizations_url":"https://api.github.com/users/eordano/orgs","repos_url":"https://api.github.com/users/eordano/repos","events_url":"https://api.github.com/users/eordano/events{/privacy}","received_events_url":"https://api.github.com/users/eordano/received_events","type":"User","site_admin":false},"body":"This should be a different test (the call to `from` is expected to fail, not the creation of the multisig)","created_at":"2015-02-18T14:43:01Z","updated_at":"2015-02-18T14:43:01Z","html_url":"https://github.com/bitpay/bitcore/pull/1083#discussion_r24904956","pull_request_url":"https://api.github.com/repos/bitpay/bitcore/pulls/1083","_links":{"self":{"href":"https://api.github.com/repos/bitpay/bitcore/pulls/comments/24904956"},"html":{"href":"https://github.com/bitpay/bitcore/pull/1083#discussion_r24904956"},"pull_request":{"href":"https://api.github.com/repos/bitpay/bitcore/pulls/1083"}}},"pull_request":{"url":"https://api.github.com/repos/bitpay/bitcore/pulls/1083","id":29522881,"html_url":"https://github.com/bitpay/bitcore/pull/1083","diff_url":"https://github.com/bitpay/bitcore/pull/1083.diff","patch_url":"https://github.com/bitpay/bitcore/pull/1083.patch","issue_url":"https://api.github.com/repos/bitpay/bitcore/issues/1083","number":1083,"state":"open","locked":false,"title":"Transaction: Check that threshold is less than amount of signatures","user":{"login":"eordano","id":42750,"avatar_url":"https://avatars.githubusercontent.com/u/42750?v=3","gravatar_id":"","url":"https://api.github.com/users/eordano","html_url":"https://github.com/eordano","followers_url":"https://api.github.com/users/eordano/followers","following_url":"https://api.github.com/users/eordano/following{/other_user}","gists_url":"https://api.github.com/users/eordano/gists{/gist_id}","starred_url":"https://api.github.com/users/eordano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eordano/subscriptions","organizations_url":"https://api.github.com/users/eordano/orgs","repos_url":"https://api.github.com/users/eordano/repos","events_url":"https://api.github.com/users/eordano/events{/privacy}","received_events_url":"https://api.github.com/users/eordano/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-18T12:55:01Z","updated_at":"2015-02-18T14:43:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0ed82b8cdbce81c8ea1957e86fe329e3d20b5e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitpay/bitcore/pulls/1083/commits","review_comments_url":"https://api.github.com/repos/bitpay/bitcore/pulls/1083/comments","review_comment_url":"https://api.github.com/repos/bitpay/bitcore/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bitpay/bitcore/issues/1083/comments","statuses_url":"https://api.github.com/repos/bitpay/bitcore/statuses/48afacecb3bc9b4a86d6a6527a02afff416b42c0","head":{"label":"eordano:feature/multisigchecks","ref":"feature/multisigchecks","sha":"48afacecb3bc9b4a86d6a6527a02afff416b42c0","user":{"login":"eordano","id":42750,"avatar_url":"https://avatars.githubusercontent.com/u/42750?v=3","gravatar_id":"","url":"https://api.github.com/users/eordano","html_url":"https://github.com/eordano","followers_url":"https://api.github.com/users/eordano/followers","following_url":"https://api.github.com/users/eordano/following{/other_user}","gists_url":"https://api.github.com/users/eordano/gists{/gist_id}","starred_url":"https://api.github.com/users/eordano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eordano/subscriptions","organizations_url":"https://api.github.com/users/eordano/orgs","repos_url":"https://api.github.com/users/eordano/repos","events_url":"https://api.github.com/users/eordano/events{/privacy}","received_events_url":"https://api.github.com/users/eordano/received_events","type":"User","site_admin":false},"repo":{"id":24699467,"name":"bitcore","full_name":"eordano/bitcore","owner":{"login":"eordano","id":42750,"avatar_url":"https://avatars.githubusercontent.com/u/42750?v=3","gravatar_id":"","url":"https://api.github.com/users/eordano","html_url":"https://github.com/eordano","followers_url":"https://api.github.com/users/eordano/followers","following_url":"https://api.github.com/users/eordano/following{/other_user}","gists_url":"https://api.github.com/users/eordano/gists{/gist_id}","starred_url":"https://api.github.com/users/eordano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eordano/subscriptions","organizations_url":"https://api.github.com/users/eordano/orgs","repos_url":"https://api.github.com/users/eordano/repos","events_url":"https://api.github.com/users/eordano/events{/privacy}","received_events_url":"https://api.github.com/users/eordano/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eordano/bitcore","description":"A bitcoin library.","fork":true,"url":"https://api.github.com/repos/eordano/bitcore","forks_url":"https://api.github.com/repos/eordano/bitcore/forks","keys_url":"https://api.github.com/repos/eordano/bitcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eordano/bitcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eordano/bitcore/teams","hooks_url":"https://api.github.com/repos/eordano/bitcore/hooks","issue_events_url":"https://api.github.com/repos/eordano/bitcore/issues/events{/number}","events_url":"https://api.github.com/repos/eordano/bitcore/events","assignees_url":"https://api.github.com/repos/eordano/bitcore/assignees{/user}","branches_url":"https://api.github.com/repos/eordano/bitcore/branches{/branch}","tags_url":"https://api.github.com/repos/eordano/bitcore/tags","blobs_url":"https://api.github.com/repos/eordano/bitcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eordano/bitcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eordano/bitcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/eordano/bitcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eordano/bitcore/statuses/{sha}","languages_url":"https://api.github.com/repos/eordano/bitcore/languages","stargazers_url":"https://api.github.com/repos/eordano/bitcore/stargazers","contributors_url":"https://api.github.com/repos/eordano/bitcore/contributors","subscribers_url":"https://api.github.com/repos/eordano/bitcore/subscribers","subscription_url":"https://api.github.com/repos/eordano/bitcore/subscription","commits_url":"https://api.github.com/repos/eordano/bitcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/eordano/bitcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/eordano/bitcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/eordano/bitcore/issues/comments/{number}","contents_url":"https://api.github.com/repos/eordano/bitcore/contents/{+path}","compare_url":"https://api.github.com/repos/eordano/bitcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eordano/bitcore/merges","archive_url":"https://api.github.com/repos/eordano/bitcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eordano/bitcore/downloads","issues_url":"https://api.github.com/repos/eordano/bitcore/issues{/number}","pulls_url":"https://api.github.com/repos/eordano/bitcore/pulls{/number}","milestones_url":"https://api.github.com/repos/eordano/bitcore/milestones{/number}","notifications_url":"https://api.github.com/repos/eordano/bitcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eordano/bitcore/labels{/name}","releases_url":"https://api.github.com/repos/eordano/bitcore/releases{/id}","created_at":"2014-10-01T23:33:31Z","updated_at":"2015-02-13T12:26:14Z","pushed_at":"2015-02-18T13:46:50Z","git_url":"git://github.com/eordano/bitcore.git","ssh_url":"git@github.com:eordano/bitcore.git","clone_url":"https://github.com/eordano/bitcore.git","svn_url":"https://github.com/eordano/bitcore","homepage":"http://bitcore.io","size":11085,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitpay:master","ref":"master","sha":"a844664481008a95f00c5ba8b455edfbcb98fd7d","user":{"login":"bitpay","id":2554930,"avatar_url":"https://avatars.githubusercontent.com/u/2554930?v=3","gravatar_id":"","url":"https://api.github.com/users/bitpay","html_url":"https://github.com/bitpay","followers_url":"https://api.github.com/users/bitpay/followers","following_url":"https://api.github.com/users/bitpay/following{/other_user}","gists_url":"https://api.github.com/users/bitpay/gists{/gist_id}","starred_url":"https://api.github.com/users/bitpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitpay/subscriptions","organizations_url":"https://api.github.com/users/bitpay/orgs","repos_url":"https://api.github.com/users/bitpay/repos","events_url":"https://api.github.com/users/bitpay/events{/privacy}","received_events_url":"https://api.github.com/users/bitpay/received_events","type":"Organization","site_admin":false},"repo":{"id":15259244,"name":"bitcore","full_name":"bitpay/bitcore","owner":{"login":"bitpay","id":2554930,"avatar_url":"https://avatars.githubusercontent.com/u/2554930?v=3","gravatar_id":"","url":"https://api.github.com/users/bitpay","html_url":"https://github.com/bitpay","followers_url":"https://api.github.com/users/bitpay/followers","following_url":"https://api.github.com/users/bitpay/following{/other_user}","gists_url":"https://api.github.com/users/bitpay/gists{/gist_id}","starred_url":"https://api.github.com/users/bitpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitpay/subscriptions","organizations_url":"https://api.github.com/users/bitpay/orgs","repos_url":"https://api.github.com/users/bitpay/repos","events_url":"https://api.github.com/users/bitpay/events{/privacy}","received_events_url":"https://api.github.com/users/bitpay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitpay/bitcore","description":"A pure and powerful JavaScript Bitcoin library","fork":false,"url":"https://api.github.com/repos/bitpay/bitcore","forks_url":"https://api.github.com/repos/bitpay/bitcore/forks","keys_url":"https://api.github.com/repos/bitpay/bitcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitpay/bitcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitpay/bitcore/teams","hooks_url":"https://api.github.com/repos/bitpay/bitcore/hooks","issue_events_url":"https://api.github.com/repos/bitpay/bitcore/issues/events{/number}","events_url":"https://api.github.com/repos/bitpay/bitcore/events","assignees_url":"https://api.github.com/repos/bitpay/bitcore/assignees{/user}","branches_url":"https://api.github.com/repos/bitpay/bitcore/branches{/branch}","tags_url":"https://api.github.com/repos/bitpay/bitcore/tags","blobs_url":"https://api.github.com/repos/bitpay/bitcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitpay/bitcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitpay/bitcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitpay/bitcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitpay/bitcore/statuses/{sha}","languages_url":"https://api.github.com/repos/bitpay/bitcore/languages","stargazers_url":"https://api.github.com/repos/bitpay/bitcore/stargazers","contributors_url":"https://api.github.com/repos/bitpay/bitcore/contributors","subscribers_url":"https://api.github.com/repos/bitpay/bitcore/subscribers","subscription_url":"https://api.github.com/repos/bitpay/bitcore/subscription","commits_url":"https://api.github.com/repos/bitpay/bitcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitpay/bitcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitpay/bitcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitpay/bitcore/issues/comments/{number}","contents_url":"https://api.github.com/repos/bitpay/bitcore/contents/{+path}","compare_url":"https://api.github.com/repos/bitpay/bitcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitpay/bitcore/merges","archive_url":"https://api.github.com/repos/bitpay/bitcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitpay/bitcore/downloads","issues_url":"https://api.github.com/repos/bitpay/bitcore/issues{/number}","pulls_url":"https://api.github.com/repos/bitpay/bitcore/pulls{/number}","milestones_url":"https://api.github.com/repos/bitpay/bitcore/milestones{/number}","notifications_url":"https://api.github.com/repos/bitpay/bitcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitpay/bitcore/labels{/name}","releases_url":"https://api.github.com/repos/bitpay/bitcore/releases{/id}","created_at":"2013-12-17T16:10:28Z","updated_at":"2015-02-18T14:30:22Z","pushed_at":"2015-02-18T14:30:21Z","git_url":"git://github.com/bitpay/bitcore.git","ssh_url":"git@github.com:bitpay/bitcore.git","clone_url":"https://github.com/bitpay/bitcore.git","svn_url":"https://github.com/bitpay/bitcore","homepage":"","size":21680,"stargazers_count":1449,"watchers_count":1449,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":321,"mirror_url":null,"open_issues_count":55,"forks":321,"open_issues":55,"watchers":1449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitpay/bitcore/pulls/1083"},"html":{"href":"https://github.com/bitpay/bitcore/pull/1083"},"issue":{"href":"https://api.github.com/repos/bitpay/bitcore/issues/1083"},"comments":{"href":"https://api.github.com/repos/bitpay/bitcore/issues/1083/comments"},"review_comments":{"href":"https://api.github.com/repos/bitpay/bitcore/pulls/1083/comments"},"review_comment":{"href":"https://api.github.com/repos/bitpay/bitcore/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bitpay/bitcore/pulls/1083/commits"},"statuses":{"href":"https://api.github.com/repos/bitpay/bitcore/statuses/48afacecb3bc9b4a86d6a6527a02afff416b42c0"}}}}