{"action":"closed","number":344,"pull_request":{"url":"https://api.github.com/repos/twitter/twemproxy/pulls/344","id":32761168,"html_url":"https://github.com/twitter/twemproxy/pull/344","diff_url":"https://github.com/twitter/twemproxy/pull/344.diff","patch_url":"https://github.com/twitter/twemproxy/pull/344.patch","issue_url":"https://api.github.com/repos/twitter/twemproxy/issues/344","number":344,"state":"closed","locked":false,"title":"Support \"touch\" command for memcached and allow negative exptime","user":{"login":"mckelvin","id":865677,"avatar_url":"https://avatars.githubusercontent.com/u/865677?v=3","gravatar_id":"","url":"https://api.github.com/users/mckelvin","html_url":"https://github.com/mckelvin","followers_url":"https://api.github.com/users/mckelvin/followers","following_url":"https://api.github.com/users/mckelvin/following{/other_user}","gists_url":"https://api.github.com/users/mckelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/mckelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckelvin/subscriptions","organizations_url":"https://api.github.com/users/mckelvin/orgs","repos_url":"https://api.github.com/users/mckelvin/repos","events_url":"https://api.github.com/users/mckelvin/events{/privacy}","received_events_url":"https://api.github.com/users/mckelvin/received_events","type":"User","site_admin":false},"body":"The PR is similar to https://github.com/Netflix/dynomite/pull/76\r\n\r\n* * *\r\n\r\nThe [touch command](https://github.com/memcached/memcached/blob/master/doc/protocol.txt#L318) is not supported in twemproxy. I'm not sure if there's any deliberate purpose, if so, please tell me.\r\n\r\nTouch with negative exptime is supported by memcached while not well documented. I'm not familiar with its inner implements but I guess the proxy should better transport without any interruption.\r\n\r\n```\r\n telnet localhost 11211\r\nTrying 127.0.0.1...\r\nConnected to localhost.\r\nEscape character is '^]'.\r\nset foo 0 0 2\r\n10\r\nSTORED\r\nget foo\r\nVALUE foo 0 2\r\n10\r\nEND\r\ntouch foo -1\r\nTOUCHED\r\nget foo\r\nEND\r\n```\r\n","created_at":"2015-04-07T12:59:19Z","updated_at":"2015-04-08T15:14:45Z","closed_at":"2015-04-08T15:14:45Z","merged_at":"2015-04-08T15:14:45Z","merge_commit_sha":"ff9251d192d2d484002957b3cd5ff6c8d3bea991","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/twemproxy/pulls/344/commits","review_comments_url":"https://api.github.com/repos/twitter/twemproxy/pulls/344/comments","review_comment_url":"https://api.github.com/repos/twitter/twemproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/twemproxy/issues/344/comments","statuses_url":"https://api.github.com/repos/twitter/twemproxy/statuses/d17cdf46eb98bb110287d582d953c21baaac164d","head":{"label":"mckelvin:touch","ref":"touch","sha":"d17cdf46eb98bb110287d582d953c21baaac164d","user":{"login":"mckelvin","id":865677,"avatar_url":"https://avatars.githubusercontent.com/u/865677?v=3","gravatar_id":"","url":"https://api.github.com/users/mckelvin","html_url":"https://github.com/mckelvin","followers_url":"https://api.github.com/users/mckelvin/followers","following_url":"https://api.github.com/users/mckelvin/following{/other_user}","gists_url":"https://api.github.com/users/mckelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/mckelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckelvin/subscriptions","organizations_url":"https://api.github.com/users/mckelvin/orgs","repos_url":"https://api.github.com/users/mckelvin/repos","events_url":"https://api.github.com/users/mckelvin/events{/privacy}","received_events_url":"https://api.github.com/users/mckelvin/received_events","type":"User","site_admin":false},"repo":{"id":29283548,"name":"twemproxy","full_name":"mckelvin/twemproxy","owner":{"login":"mckelvin","id":865677,"avatar_url":"https://avatars.githubusercontent.com/u/865677?v=3","gravatar_id":"","url":"https://api.github.com/users/mckelvin","html_url":"https://github.com/mckelvin","followers_url":"https://api.github.com/users/mckelvin/followers","following_url":"https://api.github.com/users/mckelvin/following{/other_user}","gists_url":"https://api.github.com/users/mckelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/mckelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckelvin/subscriptions","organizations_url":"https://api.github.com/users/mckelvin/orgs","repos_url":"https://api.github.com/users/mckelvin/repos","events_url":"https://api.github.com/users/mckelvin/events{/privacy}","received_events_url":"https://api.github.com/users/mckelvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mckelvin/twemproxy","description":"A fast, light-weight proxy for memcached and redis","fork":true,"url":"https://api.github.com/repos/mckelvin/twemproxy","forks_url":"https://api.github.com/repos/mckelvin/twemproxy/forks","keys_url":"https://api.github.com/repos/mckelvin/twemproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mckelvin/twemproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mckelvin/twemproxy/teams","hooks_url":"https://api.github.com/repos/mckelvin/twemproxy/hooks","issue_events_url":"https://api.github.com/repos/mckelvin/twemproxy/issues/events{/number}","events_url":"https://api.github.com/repos/mckelvin/twemproxy/events","assignees_url":"https://api.github.com/repos/mckelvin/twemproxy/assignees{/user}","branches_url":"https://api.github.com/repos/mckelvin/twemproxy/branches{/branch}","tags_url":"https://api.github.com/repos/mckelvin/twemproxy/tags","blobs_url":"https://api.github.com/repos/mckelvin/twemproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mckelvin/twemproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mckelvin/twemproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mckelvin/twemproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mckelvin/twemproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/mckelvin/twemproxy/languages","stargazers_url":"https://api.github.com/repos/mckelvin/twemproxy/stargazers","contributors_url":"https://api.github.com/repos/mckelvin/twemproxy/contributors","subscribers_url":"https://api.github.com/repos/mckelvin/twemproxy/subscribers","subscription_url":"https://api.github.com/repos/mckelvin/twemproxy/subscription","commits_url":"https://api.github.com/repos/mckelvin/twemproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mckelvin/twemproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mckelvin/twemproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mckelvin/twemproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mckelvin/twemproxy/contents/{+path}","compare_url":"https://api.github.com/repos/mckelvin/twemproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mckelvin/twemproxy/merges","archive_url":"https://api.github.com/repos/mckelvin/twemproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mckelvin/twemproxy/downloads","issues_url":"https://api.github.com/repos/mckelvin/twemproxy/issues{/number}","pulls_url":"https://api.github.com/repos/mckelvin/twemproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/mckelvin/twemproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/mckelvin/twemproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mckelvin/twemproxy/labels{/name}","releases_url":"https://api.github.com/repos/mckelvin/twemproxy/releases{/id}","created_at":"2015-01-15T06:11:11Z","updated_at":"2015-01-15T06:11:12Z","pushed_at":"2015-04-08T02:03:08Z","git_url":"git://github.com/mckelvin/twemproxy.git","ssh_url":"git@github.com:mckelvin/twemproxy.git","clone_url":"https://github.com/mckelvin/twemproxy.git","svn_url":"https://github.com/mckelvin/twemproxy","homepage":"","size":3048,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"fbe945c96780cb64e72d927c18fbbbb8bf4b8664","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":3516624,"name":"twemproxy","full_name":"twitter/twemproxy","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/twemproxy","description":"A fast, light-weight proxy for memcached and redis","fork":false,"url":"https://api.github.com/repos/twitter/twemproxy","forks_url":"https://api.github.com/repos/twitter/twemproxy/forks","keys_url":"https://api.github.com/repos/twitter/twemproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/twemproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/twemproxy/teams","hooks_url":"https://api.github.com/repos/twitter/twemproxy/hooks","issue_events_url":"https://api.github.com/repos/twitter/twemproxy/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/twemproxy/events","assignees_url":"https://api.github.com/repos/twitter/twemproxy/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/twemproxy/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/twemproxy/tags","blobs_url":"https://api.github.com/repos/twitter/twemproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/twemproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/twemproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/twemproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/twemproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/twemproxy/languages","stargazers_url":"https://api.github.com/repos/twitter/twemproxy/stargazers","contributors_url":"https://api.github.com/repos/twitter/twemproxy/contributors","subscribers_url":"https://api.github.com/repos/twitter/twemproxy/subscribers","subscription_url":"https://api.github.com/repos/twitter/twemproxy/subscription","commits_url":"https://api.github.com/repos/twitter/twemproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/twemproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/twemproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/twemproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/twemproxy/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/twemproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/twemproxy/merges","archive_url":"https://api.github.com/repos/twitter/twemproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/twemproxy/downloads","issues_url":"https://api.github.com/repos/twitter/twemproxy/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/twemproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/twemproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/twemproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/twemproxy/labels{/name}","releases_url":"https://api.github.com/repos/twitter/twemproxy/releases{/id}","created_at":"2012-02-22T16:53:58Z","updated_at":"2015-04-08T07:41:53Z","pushed_at":"2015-04-08T15:14:45Z","git_url":"git://github.com/twitter/twemproxy.git","ssh_url":"git@github.com:twitter/twemproxy.git","clone_url":"https://github.com/twitter/twemproxy.git","svn_url":"https://github.com/twitter/twemproxy","homepage":"","size":5363,"stargazers_count":3746,"watchers_count":3746,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":718,"mirror_url":null,"open_issues_count":73,"forks":718,"open_issues":73,"watchers":3746,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/twemproxy/pulls/344"},"html":{"href":"https://github.com/twitter/twemproxy/pull/344"},"issue":{"href":"https://api.github.com/repos/twitter/twemproxy/issues/344"},"comments":{"href":"https://api.github.com/repos/twitter/twemproxy/issues/344/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/twemproxy/pulls/344/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/twemproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/twemproxy/pulls/344/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/twemproxy/statuses/d17cdf46eb98bb110287d582d953c21baaac164d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"manjuraj","id":349696,"avatar_url":"https://avatars.githubusercontent.com/u/349696?v=3","gravatar_id":"","url":"https://api.github.com/users/manjuraj","html_url":"https://github.com/manjuraj","followers_url":"https://api.github.com/users/manjuraj/followers","following_url":"https://api.github.com/users/manjuraj/following{/other_user}","gists_url":"https://api.github.com/users/manjuraj/gists{/gist_id}","starred_url":"https://api.github.com/users/manjuraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manjuraj/subscriptions","organizations_url":"https://api.github.com/users/manjuraj/orgs","repos_url":"https://api.github.com/users/manjuraj/repos","events_url":"https://api.github.com/users/manjuraj/events{/privacy}","received_events_url":"https://api.github.com/users/manjuraj/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":46,"deletions":6,"changed_files":3}}