{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/40754840","id":40754840,"diff_hunk":"@@ -0,0 +1,31 @@\n+#include \"node.h\"\n+#include \"v8.h\"\n+#include \"env.h\"\n+#include \"env-inl.h\"\n+\n+namespace node {\n+namespace util {\n+\n+using v8::Context;\n+using v8::FunctionCallbackInfo;\n+using v8::Local;\n+using v8::Object;\n+using v8::Value;\n+\n+static void IsMapOrSetIterator(const FunctionCallbackInfo<Value>& args) {\n+  CHECK_EQ(1, args.Length());\n+  args.GetReturnValue().Set(args[0]->IsSetIterator()\n+                            || args[0]->IsMapIterator());","path":"src/node_util.cc","position":18,"original_position":18,"commit_id":"04b8de39e43258f9003dea84c544831c0d68870d","original_commit_id":"04b8de39e43258f9003dea84c544831c0d68870d","user":{"login":"ChALkeR","id":291301,"avatar_url":"https://avatars.githubusercontent.com/u/291301?v=3","gravatar_id":"","url":"https://api.github.com/users/ChALkeR","html_url":"https://github.com/ChALkeR","followers_url":"https://api.github.com/users/ChALkeR/followers","following_url":"https://api.github.com/users/ChALkeR/following{/other_user}","gists_url":"https://api.github.com/users/ChALkeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ChALkeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChALkeR/subscriptions","organizations_url":"https://api.github.com/users/ChALkeR/orgs","repos_url":"https://api.github.com/users/ChALkeR/repos","events_url":"https://api.github.com/users/ChALkeR/events{/privacy}","received_events_url":"https://api.github.com/users/ChALkeR/received_events","type":"User","site_admin":false},"body":"@thefourtheye Do we have an eslint rule for that, btw?","created_at":"2015-09-30T03:06:50Z","updated_at":"2015-09-30T03:06:50Z","html_url":"https://github.com/nodejs/node/pull/3119#discussion_r40754840","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/3119","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/40754840"},"html":{"href":"https://github.com/nodejs/node/pull/3119#discussion_r40754840"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/3119"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/3119","id":46321493,"html_url":"https://github.com/nodejs/node/pull/3119","diff_url":"https://github.com/nodejs/node/pull/3119.diff","patch_url":"https://github.com/nodejs/node/pull/3119.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/3119","number":3119,"state":"open","locked":false,"title":"util: correctly inspect Map/Set Iterators","user":{"login":"evanlucas","id":677994,"avatar_url":"https://avatars.githubusercontent.com/u/677994?v=3","gravatar_id":"","url":"https://api.github.com/users/evanlucas","html_url":"https://github.com/evanlucas","followers_url":"https://api.github.com/users/evanlucas/followers","following_url":"https://api.github.com/users/evanlucas/following{/other_user}","gists_url":"https://api.github.com/users/evanlucas/gists{/gist_id}","starred_url":"https://api.github.com/users/evanlucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanlucas/subscriptions","organizations_url":"https://api.github.com/users/evanlucas/orgs","repos_url":"https://api.github.com/users/evanlucas/repos","events_url":"https://api.github.com/users/evanlucas/events{/privacy}","received_events_url":"https://api.github.com/users/evanlucas/received_events","type":"User","site_admin":false},"body":"Currently, inspecting `new Map().keys()` or other iterators will return an empty object.\r\n\r\nI am opening more for discussion of how we want (if at all) to address not being able to inspect map and set iterators. I first had first attempting using `Debug.MakeMirror` but the performance of doing it this way was about 10x better.\r\n\r\nRelated: https://github.com/nodejs/node/issues/3107","created_at":"2015-09-29T19:34:46Z","updated_at":"2015-09-30T03:06:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9dfe7f48af0d5cad449a20cedc1de126ffa6709","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/3119/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/3119/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/3119/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/04b8de39e43258f9003dea84c544831c0d68870d","head":{"label":"evanlucas:iterators","ref":"iterators","sha":"04b8de39e43258f9003dea84c544831c0d68870d","user":{"login":"evanlucas","id":677994,"avatar_url":"https://avatars.githubusercontent.com/u/677994?v=3","gravatar_id":"","url":"https://api.github.com/users/evanlucas","html_url":"https://github.com/evanlucas","followers_url":"https://api.github.com/users/evanlucas/followers","following_url":"https://api.github.com/users/evanlucas/following{/other_user}","gists_url":"https://api.github.com/users/evanlucas/gists{/gist_id}","starred_url":"https://api.github.com/users/evanlucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanlucas/subscriptions","organizations_url":"https://api.github.com/users/evanlucas/orgs","repos_url":"https://api.github.com/users/evanlucas/repos","events_url":"https://api.github.com/users/evanlucas/events{/privacy}","received_events_url":"https://api.github.com/users/evanlucas/received_events","type":"User","site_admin":false},"repo":{"id":27466639,"name":"node","full_name":"evanlucas/node","owner":{"login":"evanlucas","id":677994,"avatar_url":"https://avatars.githubusercontent.com/u/677994?v=3","gravatar_id":"","url":"https://api.github.com/users/evanlucas","html_url":"https://github.com/evanlucas","followers_url":"https://api.github.com/users/evanlucas/followers","following_url":"https://api.github.com/users/evanlucas/following{/other_user}","gists_url":"https://api.github.com/users/evanlucas/gists{/gist_id}","starred_url":"https://api.github.com/users/evanlucas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanlucas/subscriptions","organizations_url":"https://api.github.com/users/evanlucas/orgs","repos_url":"https://api.github.com/users/evanlucas/repos","events_url":"https://api.github.com/users/evanlucas/events{/privacy}","received_events_url":"https://api.github.com/users/evanlucas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evanlucas/node","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/evanlucas/node","forks_url":"https://api.github.com/repos/evanlucas/node/forks","keys_url":"https://api.github.com/repos/evanlucas/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evanlucas/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evanlucas/node/teams","hooks_url":"https://api.github.com/repos/evanlucas/node/hooks","issue_events_url":"https://api.github.com/repos/evanlucas/node/issues/events{/number}","events_url":"https://api.github.com/repos/evanlucas/node/events","assignees_url":"https://api.github.com/repos/evanlucas/node/assignees{/user}","branches_url":"https://api.github.com/repos/evanlucas/node/branches{/branch}","tags_url":"https://api.github.com/repos/evanlucas/node/tags","blobs_url":"https://api.github.com/repos/evanlucas/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evanlucas/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evanlucas/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/evanlucas/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evanlucas/node/statuses/{sha}","languages_url":"https://api.github.com/repos/evanlucas/node/languages","stargazers_url":"https://api.github.com/repos/evanlucas/node/stargazers","contributors_url":"https://api.github.com/repos/evanlucas/node/contributors","subscribers_url":"https://api.github.com/repos/evanlucas/node/subscribers","subscription_url":"https://api.github.com/repos/evanlucas/node/subscription","commits_url":"https://api.github.com/repos/evanlucas/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/evanlucas/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/evanlucas/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/evanlucas/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/evanlucas/node/contents/{+path}","compare_url":"https://api.github.com/repos/evanlucas/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evanlucas/node/merges","archive_url":"https://api.github.com/repos/evanlucas/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evanlucas/node/downloads","issues_url":"https://api.github.com/repos/evanlucas/node/issues{/number}","pulls_url":"https://api.github.com/repos/evanlucas/node/pulls{/number}","milestones_url":"https://api.github.com/repos/evanlucas/node/milestones{/number}","notifications_url":"https://api.github.com/repos/evanlucas/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evanlucas/node/labels{/name}","releases_url":"https://api.github.com/repos/evanlucas/node/releases{/id}","created_at":"2014-12-03T03:07:41Z","updated_at":"2015-09-28T19:22:55Z","pushed_at":"2015-09-30T03:03:10Z","git_url":"git://github.com/evanlucas/node.git","ssh_url":"git@github.com:evanlucas/node.git","clone_url":"https://github.com/evanlucas/node.git","svn_url":"https://github.com/evanlucas/node","homepage":null,"size":144511,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"f1d27d27f59a14dbe561aa4b8bf403484ba97e36","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"✨Node.js  ✨","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-09-30T02:58:39Z","pushed_at":"2015-09-30T03:03:11Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":366198,"stargazers_count":15640,"watchers_count":15640,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1425,"mirror_url":null,"open_issues_count":485,"forks":1425,"open_issues":485,"watchers":15640,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/3119"},"html":{"href":"https://github.com/nodejs/node/pull/3119"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/3119"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/3119/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/3119/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/3119/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/04b8de39e43258f9003dea84c544831c0d68870d"}}}}