{"action":"created","comment":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/comments/43802293","id":43802293,"diff_hunk":"@@ -265,18 +281,18 @@ let Dialog = React.createClass({\n     return this.state.open;\n   },\n \n-  dismiss() {\n-    CssEvent.onTransitionEnd(ReactDOM.findDOMNode(this), () => {\n-      this.refs.dialogOverlay.allowScrolling();\n-    });\n+  _testDeprecations() {\n+    warning(!this.props.hasOwnProperty('openImmediately'),","path":"src/dialog.jsx","position":82,"original_position":82,"commit_id":"a86fd3a48c4682b984e391043f7fa974a6063a9c","original_commit_id":"a86fd3a48c4682b984e391043f7fa974a6063a9c","user":{"login":"oliviertassinari","id":3165635,"avatar_url":"https://avatars.githubusercontent.com/u/3165635?v=3","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"body":"Can we wrap this method inside `process.env.NODE_ENV !== 'production'` (for dead code elimination by uglify)?","created_at":"2015-11-03T20:28:19Z","updated_at":"2015-11-03T20:28:19Z","html_url":"https://github.com/callemall/material-ui/pull/1996#discussion_r43802293","pull_request_url":"https://api.github.com/repos/callemall/material-ui/pulls/1996","_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments/43802293"},"html":{"href":"https://github.com/callemall/material-ui/pull/1996#discussion_r43802293"},"pull_request":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/1996"}}},"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/1996","id":48937618,"html_url":"https://github.com/callemall/material-ui/pull/1996","diff_url":"https://github.com/callemall/material-ui/pull/1996.diff","patch_url":"https://github.com/callemall/material-ui/pull/1996.patch","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/1996","number":1996,"state":"open","locked":false,"title":"Allow open state of dialog to be controlled through the show prop.","user":{"login":"JorgenEvens","id":223318,"avatar_url":"https://avatars.githubusercontent.com/u/223318?v=3","gravatar_id":"","url":"https://api.github.com/users/JorgenEvens","html_url":"https://github.com/JorgenEvens","followers_url":"https://api.github.com/users/JorgenEvens/followers","following_url":"https://api.github.com/users/JorgenEvens/following{/other_user}","gists_url":"https://api.github.com/users/JorgenEvens/gists{/gist_id}","starred_url":"https://api.github.com/users/JorgenEvens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JorgenEvens/subscriptions","organizations_url":"https://api.github.com/users/JorgenEvens/orgs","repos_url":"https://api.github.com/users/JorgenEvens/repos","events_url":"https://api.github.com/users/JorgenEvens/events{/privacy}","received_events_url":"https://api.github.com/users/JorgenEvens/received_events","type":"User","site_admin":false},"body":"Resolves https://github.com/callemall/material-ui/issues/1682","created_at":"2015-10-27T21:49:10Z","updated_at":"2015-11-03T20:28:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"add1a2e066427027ab01279d73ad6269b0bbb75c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/callemall/material-ui/pulls/1996/commits","review_comments_url":"https://api.github.com/repos/callemall/material-ui/pulls/1996/comments","review_comment_url":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/1996/comments","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/a86fd3a48c4682b984e391043f7fa974a6063a9c","head":{"label":"JorgenEvens:feature/dialog-show-prop","ref":"feature/dialog-show-prop","sha":"a86fd3a48c4682b984e391043f7fa974a6063a9c","user":{"login":"JorgenEvens","id":223318,"avatar_url":"https://avatars.githubusercontent.com/u/223318?v=3","gravatar_id":"","url":"https://api.github.com/users/JorgenEvens","html_url":"https://github.com/JorgenEvens","followers_url":"https://api.github.com/users/JorgenEvens/followers","following_url":"https://api.github.com/users/JorgenEvens/following{/other_user}","gists_url":"https://api.github.com/users/JorgenEvens/gists{/gist_id}","starred_url":"https://api.github.com/users/JorgenEvens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JorgenEvens/subscriptions","organizations_url":"https://api.github.com/users/JorgenEvens/orgs","repos_url":"https://api.github.com/users/JorgenEvens/repos","events_url":"https://api.github.com/users/JorgenEvens/events{/privacy}","received_events_url":"https://api.github.com/users/JorgenEvens/received_events","type":"User","site_admin":false},"repo":{"id":45070158,"name":"material-ui","full_name":"JorgenEvens/material-ui","owner":{"login":"JorgenEvens","id":223318,"avatar_url":"https://avatars.githubusercontent.com/u/223318?v=3","gravatar_id":"","url":"https://api.github.com/users/JorgenEvens","html_url":"https://github.com/JorgenEvens","followers_url":"https://api.github.com/users/JorgenEvens/followers","following_url":"https://api.github.com/users/JorgenEvens/following{/other_user}","gists_url":"https://api.github.com/users/JorgenEvens/gists{/gist_id}","starred_url":"https://api.github.com/users/JorgenEvens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JorgenEvens/subscriptions","organizations_url":"https://api.github.com/users/JorgenEvens/orgs","repos_url":"https://api.github.com/users/JorgenEvens/repos","events_url":"https://api.github.com/users/JorgenEvens/events{/privacy}","received_events_url":"https://api.github.com/users/JorgenEvens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JorgenEvens/material-ui","description":"React Components that Implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/JorgenEvens/material-ui","forks_url":"https://api.github.com/repos/JorgenEvens/material-ui/forks","keys_url":"https://api.github.com/repos/JorgenEvens/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JorgenEvens/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JorgenEvens/material-ui/teams","hooks_url":"https://api.github.com/repos/JorgenEvens/material-ui/hooks","issue_events_url":"https://api.github.com/repos/JorgenEvens/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/JorgenEvens/material-ui/events","assignees_url":"https://api.github.com/repos/JorgenEvens/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/JorgenEvens/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/JorgenEvens/material-ui/tags","blobs_url":"https://api.github.com/repos/JorgenEvens/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JorgenEvens/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JorgenEvens/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/JorgenEvens/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JorgenEvens/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/JorgenEvens/material-ui/languages","stargazers_url":"https://api.github.com/repos/JorgenEvens/material-ui/stargazers","contributors_url":"https://api.github.com/repos/JorgenEvens/material-ui/contributors","subscribers_url":"https://api.github.com/repos/JorgenEvens/material-ui/subscribers","subscription_url":"https://api.github.com/repos/JorgenEvens/material-ui/subscription","commits_url":"https://api.github.com/repos/JorgenEvens/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/JorgenEvens/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/JorgenEvens/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/JorgenEvens/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/JorgenEvens/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/JorgenEvens/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JorgenEvens/material-ui/merges","archive_url":"https://api.github.com/repos/JorgenEvens/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JorgenEvens/material-ui/downloads","issues_url":"https://api.github.com/repos/JorgenEvens/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/JorgenEvens/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/JorgenEvens/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/JorgenEvens/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JorgenEvens/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/JorgenEvens/material-ui/releases{/id}","created_at":"2015-10-27T21:08:45Z","updated_at":"2015-10-27T21:08:49Z","pushed_at":"2015-10-29T19:34:33Z","git_url":"git://github.com/JorgenEvens/material-ui.git","ssh_url":"git@github.com:JorgenEvens/material-ui.git","clone_url":"https://github.com/JorgenEvens/material-ui.git","svn_url":"https://github.com/JorgenEvens/material-ui","homepage":"http://material-ui.com","size":30656,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"callemall:master","ref":"master","sha":"02959ea5663169cf31d6cfb17af048310638e351","user":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"name":"material-ui","full_name":"callemall/material-ui","owner":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callemall/material-ui","description":"React Components that Implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/callemall/material-ui","forks_url":"https://api.github.com/repos/callemall/material-ui/forks","keys_url":"https://api.github.com/repos/callemall/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callemall/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callemall/material-ui/teams","hooks_url":"https://api.github.com/repos/callemall/material-ui/hooks","issue_events_url":"https://api.github.com/repos/callemall/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/callemall/material-ui/events","assignees_url":"https://api.github.com/repos/callemall/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/callemall/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/callemall/material-ui/tags","blobs_url":"https://api.github.com/repos/callemall/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callemall/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callemall/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/callemall/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/callemall/material-ui/languages","stargazers_url":"https://api.github.com/repos/callemall/material-ui/stargazers","contributors_url":"https://api.github.com/repos/callemall/material-ui/contributors","subscribers_url":"https://api.github.com/repos/callemall/material-ui/subscribers","subscription_url":"https://api.github.com/repos/callemall/material-ui/subscription","commits_url":"https://api.github.com/repos/callemall/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/callemall/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/callemall/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/callemall/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/callemall/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/callemall/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callemall/material-ui/merges","archive_url":"https://api.github.com/repos/callemall/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callemall/material-ui/downloads","issues_url":"https://api.github.com/repos/callemall/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/callemall/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/callemall/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/callemall/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callemall/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/callemall/material-ui/releases{/id}","created_at":"2014-08-18T19:11:54Z","updated_at":"2015-11-03T20:26:26Z","pushed_at":"2015-11-03T18:33:30Z","git_url":"git://github.com/callemall/material-ui.git","ssh_url":"git@github.com:callemall/material-ui.git","clone_url":"https://github.com/callemall/material-ui.git","svn_url":"https://github.com/callemall/material-ui","homepage":"http://material-ui.com","size":43130,"stargazers_count":11525,"watchers_count":11525,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1818,"mirror_url":null,"open_issues_count":499,"forks":1818,"open_issues":499,"watchers":11525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/1996"},"html":{"href":"https://github.com/callemall/material-ui/pull/1996"},"issue":{"href":"https://api.github.com/repos/callemall/material-ui/issues/1996"},"comments":{"href":"https://api.github.com/repos/callemall/material-ui/issues/1996/comments"},"review_comments":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/1996/comments"},"review_comment":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/1996/commits"},"statuses":{"href":"https://api.github.com/repos/callemall/material-ui/statuses/a86fd3a48c4682b984e391043f7fa974a6063a9c"}}}}