{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2028","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2028/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2028/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2028/events","html_url":"https://github.com/ManageIQ/manageiq/pull/2028","id":60043343,"number":2028,"title":"[WIP depends on: #1797] UI changes to support scaling OpenStack Infrastructure Provider","user":{"login":"rwsu","id":974403,"avatar_url":"https://avatars.githubusercontent.com/u/974403?v=3","gravatar_id":"","url":"https://api.github.com/users/rwsu","html_url":"https://github.com/rwsu","followers_url":"https://api.github.com/users/rwsu/followers","following_url":"https://api.github.com/users/rwsu/following{/other_user}","gists_url":"https://api.github.com/users/rwsu/gists{/gist_id}","starred_url":"https://api.github.com/users/rwsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwsu/subscriptions","organizations_url":"https://api.github.com/users/rwsu/orgs","repos_url":"https://api.github.com/users/rwsu/repos","events_url":"https://api.github.com/users/rwsu/events{/privacy}","received_events_url":"https://api.github.com/users/rwsu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/providers/infra","name":"providers/infra","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/WIP","name":"WIP","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-03-06T01:05:19Z","updated_at":"2015-03-27T16:12:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2028","html_url":"https://github.com/ManageIQ/manageiq/pull/2028","diff_url":"https://github.com/ManageIQ/manageiq/pull/2028.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/2028.patch"},"body":"Only last 3 commits are relevant the rest comes from #1797.\r\n\r\nThis change also depends on a change to Fog: https://github.com/fog/fog/pull/3440\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/86991889","html_url":"https://github.com/ManageIQ/manageiq/pull/2028#issuecomment-86991889","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2028","id":86991889,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2015-03-27T16:12:32Z","updated_at":"2015-03-27T16:12:32Z","body":"<rubocop />Checked commits https://github.com/rwsu/manageiq/commit/9bab58f91c608b86f5021b0c3000f23f3c3c2d7e .. https://github.com/rwsu/manageiq/commit/739d14fea26e03b55cd97d3ab5beb5f9f768f24d with rubocop 0.27.1\n9 files checked, 30 offenses detected\n\n**vmdb/app/controllers/ems_infra_controller.rb**\n- [ ] :red_circle: **Warn** - [Line 36](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L36), Col 43 - [Lint/UnusedBlockArgument](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Lint/UnusedBlockArgument) - Unused block argument - `v`. If it's necessary, use `_` or `_v` as an argument name to indicate that it won't be used.\n- [ ] :large_orange_diamond: - [Line 20](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L20), Col 1 - [Style/TrailingWhitespace](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/TrailingWhitespace) - Trailing whitespace detected.\n- [ ] :large_orange_diamond: - [Line 23](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L23), Col 5 - [Style/IfUnlessModifier](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/IfUnlessModifier) - Favor modifier `if` usage when having a single-line body. Another good alternative is the usage of control flow `&&`/`||`.\n- [ ] :large_orange_diamond: - [Line 26](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L26), Col 1 - [Style/TrailingWhitespace](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/TrailingWhitespace) - Trailing whitespace detected.\n- [ ] :large_orange_diamond: - [Line 30](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L30), Col 50 - [Style/SpaceInsideBlockBraces](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/SpaceInsideBlockBraces) - Space between { and | missing.\n- [ ] :large_orange_diamond: - [Line 30](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L30), Col 86 - [Style/SpaceInsideBlockBraces](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/SpaceInsideBlockBraces) - Space missing inside }.\n- [ ] :large_orange_diamond: - [Line 31](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L31), Col 1 - [Style/TrailingWhitespace](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/TrailingWhitespace) - Trailing whitespace detected.\n- [ ] :large_orange_diamond: - [Line 32](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L32), Col 5 - [Style/IfUnlessModifier](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/IfUnlessModifier) - Favor modifier `if` usage when having a single-line body. Another good alternative is the usage of control flow `&&`/`||`.\n- [ ] :large_orange_diamond: - [Line 32](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L32), Col 5 - [Style/NegatedIf](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/NegatedIf) - Favor `unless` over `if` for negative conditions.\n- [ ] :large_orange_diamond: - [Line 36](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L36), Col 42 - [Style/SpaceAfterComma](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/SpaceAfterComma) - Space missing after comma.\n- [ ] :large_orange_diamond: - [Line 36](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L36), Col 67 - [Style/SpaceInsideBlockBraces](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/SpaceInsideBlockBraces) - Space missing inside }.\n- [ ] :large_orange_diamond: - [Line 37](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L37), Col 1 - [Style/TrailingWhitespace](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/TrailingWhitespace) - Trailing whitespace detected.\n- [ ] :large_orange_diamond: - [Line 43](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L43), Col 76 - [Style/FormatString](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/FormatString) - Favor `format` over `String#%`.\n- [ ] :large_orange_diamond: - [Line 44](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L44), Col 77 - [Style/FormatString](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/FormatString) - Favor `format` over `String#%`.\n- [ ] :large_orange_diamond: - [Line 48](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L48), Col 7 - [Style/For](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/For) - Prefer `each` over `for`.\n- [ ] :large_orange_diamond: - [Line 50](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L50), Col 9 - [Style/IndentationWidth](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/IndentationWidth) - Use 2 (not 3) spaces for indentation.\n- [ ] :small_blue_diamond: - [Line 21](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L21), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for scaling is too high. [70.75/15]\n- [ ] :small_blue_diamond: - [Line 21](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L21), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for scaling is too high. [8/6]\n- [ ] :small_blue_diamond: - [Line 21](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L21), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [35/25]\n- [ ] :small_blue_diamond: - [Line 21](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L21), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for scaling is too high. [10/7]\n- [ ] :small_blue_diamond: - [Line 43](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L43), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [138/120]\n- [ ] :small_blue_diamond: - [Line 44](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/controllers/ems_infra_controller.rb#L44), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [131/120]\n\n**vmdb/app/models/orchestration_stack_openstack_infra.rb**\n- [ ] :small_blue_diamond: - [Line 2](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/app/models/orchestration_stack_openstack_infra.rb#L2), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for raw_update_stack is too high. [20.4/15]\n\n**vmdb/spec/controllers/ems_infra_controller_spec.rb**\n- [ ] :large_orange_diamond: - [Line 84](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/spec/controllers/ems_infra_controller_spec.rb#L84), Col 75 - [Style/SpaceAroundOperators](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/SpaceAroundOperators) - Surrounding space missing for operator '*'.\n- [ ] :large_orange_diamond: - [Line 88](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/spec/controllers/ems_infra_controller_spec.rb#L88), Col 66 - [Style/FormatString](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/FormatString) - Favor `format` over `String#%`.\n- [ ] :large_orange_diamond: - [Line 88](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/spec/controllers/ems_infra_controller_spec.rb#L88), Col 93 - [Style/SpaceAroundOperators](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/SpaceAroundOperators) - Surrounding space missing for operator '*'.\n- [ ] :small_blue_diamond: - [Line 72](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/spec/controllers/ems_infra_controller_spec.rb#L72), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [121/120]\n- [ ] :small_blue_diamond: - [Line 88](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/spec/controllers/ems_infra_controller_spec.rb#L88), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [123/120]\n\n**vmdb/spec/factories/orchestration_stack.rb**\n- [ ] :small_blue_diamond: - [Line 15](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/spec/factories/orchestration_stack.rb#L15), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [126/120]\n- [ ] :small_blue_diamond: - [Line 22](https://github.com/rwsu/manageiq/blob/739d14fea26e03b55cd97d3ab5beb5f9f768f24d/vmdb/spec/factories/orchestration_stack.rb#L22), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [129/120]\n"}}