{"action":"created","issue":{"url":"https://api.github.com/repos/Misiur/YSI-Includes/issues/64","labels_url":"https://api.github.com/repos/Misiur/YSI-Includes/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/Misiur/YSI-Includes/issues/64/comments","events_url":"https://api.github.com/repos/Misiur/YSI-Includes/issues/64/events","html_url":"https://github.com/Misiur/YSI-Includes/pull/64","id":120465702,"number":64,"title":"variable fix","user":{"login":"pds2k12","id":6224863,"avatar_url":"https://avatars.githubusercontent.com/u/6224863?v=3","gravatar_id":"","url":"https://api.github.com/users/pds2k12","html_url":"https://github.com/pds2k12","followers_url":"https://api.github.com/users/pds2k12/followers","following_url":"https://api.github.com/users/pds2k12/following{/other_user}","gists_url":"https://api.github.com/users/pds2k12/gists{/gist_id}","starred_url":"https://api.github.com/users/pds2k12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pds2k12/subscriptions","organizations_url":"https://api.github.com/users/pds2k12/orgs","repos_url":"https://api.github.com/users/pds2k12/repos","events_url":"https://api.github.com/users/pds2k12/events{/privacy}","received_events_url":"https://api.github.com/users/pds2k12/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-12-04T19:07:33Z","updated_at":"2015-12-05T07:18:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Misiur/YSI-Includes/pulls/64","html_url":"https://github.com/Misiur/YSI-Includes/pull/64","diff_url":"https://github.com/Misiur/YSI-Includes/pull/64.diff","patch_url":"https://github.com/Misiur/YSI-Includes/pull/64.patch"},"body":"including y_timers causes 'warning 219: local variable \"time\" shadows a variable at a preceding level' warning. Just a simple fix and changing variable name."},"comment":{"url":"https://api.github.com/repos/Misiur/YSI-Includes/issues/comments/162157767","html_url":"https://github.com/Misiur/YSI-Includes/pull/64#issuecomment-162157767","issue_url":"https://api.github.com/repos/Misiur/YSI-Includes/issues/64","id":162157767,"user":{"login":"Y-Less","id":991078,"avatar_url":"https://avatars.githubusercontent.com/u/991078?v=3","gravatar_id":"","url":"https://api.github.com/users/Y-Less","html_url":"https://github.com/Y-Less","followers_url":"https://api.github.com/users/Y-Less/followers","following_url":"https://api.github.com/users/Y-Less/following{/other_user}","gists_url":"https://api.github.com/users/Y-Less/gists{/gist_id}","starred_url":"https://api.github.com/users/Y-Less/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Y-Less/subscriptions","organizations_url":"https://api.github.com/users/Y-Less/orgs","repos_url":"https://api.github.com/users/Y-Less/repos","events_url":"https://api.github.com/users/Y-Less/events{/privacy}","received_events_url":"https://api.github.com/users/Y-Less/received_events","type":"User","site_admin":false},"created_at":"2015-12-05T07:18:48Z","updated_at":"2015-12-05T07:18:48Z","body":"YSI has a very strict variable naming convention, designed to reduce the chance of conflicts with other code, but this does rely on that other code using a vaguely sensible naming scheme as well.  If global symbols (functions, variables, macros, etc) can be literally anything, then there is no way to ensure that nothing will ever clash.  A lot of code uses some system for identifying globals (especially variables) in their name, such as \"g\" prefixes/suffixes or other things.  YSI uses the \"YSI_g_\" prefix (\"YSI_g_s\" for global statics).\r\n\r\nLocal variables on the other hand, have much laxer rules in a whole load of code, YSI included, but not exclusively.  Thus, I've always taken the view that if YSI can take the time and effort to use a sensible naming convention on globals, and other people can do the same, then locals are free and easy because there is very little chance of a collision.  If third-party code just throws all sensibilities out the window, then it is a little unfair to blame YSI.\r\n\r\nThe naming conventions were based on those established in the SA:MP includes to some extent:\r\n\r\n```pawn\r\nALL_CAPS_MACROS\r\nLibraryPrefixed_PascalCaseFunctionNames\r\nYSI_g_sGlobalNames\r\ncamelCaseLocals\r\nsnake_case_labels\r\nE_PREFIXED_ENUMS\r\n```\r\n\r\nThere are exceptions, but they are rare.  In this case, \"time\" is an incredibly generic name which really shouldn't be in the global namespace regardless of whether or not you are using YSI."}}