{"action":"created","issue":{"url":"https://api.github.com/repos/mono/MonoGame/issues/3472","labels_url":"https://api.github.com/repos/mono/MonoGame/issues/3472/labels{/name}","comments_url":"https://api.github.com/repos/mono/MonoGame/issues/3472/comments","events_url":"https://api.github.com/repos/mono/MonoGame/issues/3472/events","html_url":"https://github.com/mono/MonoGame/pull/3472","id":55904331,"number":3472,"title":"Move EffectCache and default render states into GraphicsDevice [WIP]","user":{"login":"tgjones","id":102049,"avatar_url":"https://avatars.githubusercontent.com/u/102049?v=3","gravatar_id":"","url":"https://api.github.com/users/tgjones","html_url":"https://github.com/tgjones","followers_url":"https://api.github.com/users/tgjones/followers","following_url":"https://api.github.com/users/tgjones/following{/other_user}","gists_url":"https://api.github.com/users/tgjones/gists{/gist_id}","starred_url":"https://api.github.com/users/tgjones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgjones/subscriptions","organizations_url":"https://api.github.com/users/tgjones/orgs","repos_url":"https://api.github.com/users/tgjones/repos","events_url":"https://api.github.com/users/tgjones/events{/privacy}","received_events_url":"https://api.github.com/users/tgjones/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-01-29T14:20:06Z","updated_at":"2015-02-02T16:00:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mono/MonoGame/pulls/3472","html_url":"https://github.com/mono/MonoGame/pull/3472","diff_url":"https://github.com/mono/MonoGame/pull/3472.diff","patch_url":"https://github.com/mono/MonoGame/pull/3472.patch"},"body":"When this PR is finished, it will provide a fix for #3449.\r\n\r\nThis first batch of commits only affects `BlendState` - if this looks good, then I'll carry on with the other render states, and finally the effect cache.\r\n\r\nI have added some tests and tightened up `BlendState` mutability.\r\n\r\nI have refactored how blend states get applied, which required some changes to the platform-specific `GraphicsDevice` files. This allows us to centralise the handling of `GraphicsDevice`-specific clones of render states. (I actually wanted to have a `BlendState.Apply` method, which had the `if`/`else` for default blend states, and then called `BlendState.PlatformApply`, but this broke when compiled in 2MGFX, since there are no platform-specific files there. So for now, that code is in `GraphicsDevice.Apply`.)"},"comment":{"url":"https://api.github.com/repos/mono/MonoGame/issues/comments/72481602","html_url":"https://github.com/mono/MonoGame/pull/3472#issuecomment-72481602","issue_url":"https://api.github.com/repos/mono/MonoGame/issues/3472","id":72481602,"user":{"login":"tomspilman","id":103522,"avatar_url":"https://avatars.githubusercontent.com/u/103522?v=3","gravatar_id":"","url":"https://api.github.com/users/tomspilman","html_url":"https://github.com/tomspilman","followers_url":"https://api.github.com/users/tomspilman/followers","following_url":"https://api.github.com/users/tomspilman/following{/other_user}","gists_url":"https://api.github.com/users/tomspilman/gists{/gist_id}","starred_url":"https://api.github.com/users/tomspilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomspilman/subscriptions","organizations_url":"https://api.github.com/users/tomspilman/orgs","repos_url":"https://api.github.com/users/tomspilman/repos","events_url":"https://api.github.com/users/tomspilman/events{/privacy}","received_events_url":"https://api.github.com/users/tomspilman/received_events","type":"User","site_admin":false},"created_at":"2015-02-02T16:00:11Z","updated_at":"2015-02-02T16:00:11Z","body":"> Should I be doing a rebase?\r\n\r\nOr merge from develop.  It will mark conflicted files and you just go fix them up.\r\n\r\nIt happens when some other PR makes a change to the same lines of code as you do."}}