{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-http-server/pulls/comments/23158629","id":23158629,"diff_hunk":"@@ -203,7 +216,60 @@ without installing the package.\"), \"apache2\" ) );\n     YaST::HTTPDData::ReadModules();\n     YaST::HTTPDData::ReadService();\n \n-    if (!FileChanges::CheckFiles( files_to_check )) return false;\n+    list<string> dynamic_files_to_check = DynamicFilesToCheck();\n+\n+    if (!FileChanges::CheckFiles( (list<string>)merge( files_to_check, dynamic_files_to_check ))) return false;\n+\n+    // FIXME: following functionality should be generic in FileChanges\n+\n+    map<string,string> file_checksums = $[];\n+    if ((integer)SCR::Read (.target.size, \"/var/lib/YaST2/file_checksums.ycp\") > 0) {\n+        file_checksums = (map<string,string>)SCR::Read (.target.ycp,  \"/var/lib/YaST2/file_checksums.ycp\");\n+        if (file_checksums == nil) {\n+            file_checksums = $[];\n+        }\n+    }\n+\n+    list<string> new_files = filter (string file, dynamic_files_to_check, {\n+        return ! haskey (file_checksums, file);\n+    });\n+\n+    if (size (new_files) > 0)\n+    {\n+        // Continue/Cancel question, %1 is a file name\n+        string msg = _(\"File %1 has been created manually.\\nYaST might lose this file\");\n+        if (size (new_files) > 1)\n+            // Continue/Cancel question, %1 is a comna separated list of file names","path":"src/HttpServer.ycp","position":55,"original_position":55,"commit_id":"0554cdeab780ce4089f7076ef5e3c9f417373d4f","original_commit_id":"0554cdeab780ce4089f7076ef5e3c9f417373d4f","user":{"login":"lslezak","id":907998,"avatar_url":"https://avatars.githubusercontent.com/u/907998?v=3","gravatar_id":"","url":"https://api.github.com/users/lslezak","html_url":"https://github.com/lslezak","followers_url":"https://api.github.com/users/lslezak/followers","following_url":"https://api.github.com/users/lslezak/following{/other_user}","gists_url":"https://api.github.com/users/lslezak/gists{/gist_id}","starred_url":"https://api.github.com/users/lslezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lslezak/subscriptions","organizations_url":"https://api.github.com/users/lslezak/orgs","repos_url":"https://api.github.com/users/lslezak/repos","events_url":"https://api.github.com/users/lslezak/events{/privacy}","received_events_url":"https://api.github.com/users/lslezak/received_events","type":"User","site_admin":false},"body":"Yes, `comma` here...","created_at":"2015-01-19T13:03:18Z","updated_at":"2015-01-19T13:03:18Z","html_url":"https://github.com/yast/yast-http-server/pull/13#discussion_r23158629","pull_request_url":"https://api.github.com/repos/yast/yast-http-server/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-http-server/pulls/comments/23158629"},"html":{"href":"https://github.com/yast/yast-http-server/pull/13#discussion_r23158629"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-http-server/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-http-server/pulls/13","id":27596345,"html_url":"https://github.com/yast/yast-http-server/pull/13","diff_url":"https://github.com/yast/yast-http-server/pull/13.diff","patch_url":"https://github.com/yast/yast-http-server/pull/13.patch","issue_url":"https://api.github.com/repos/yast/yast-http-server/issues/13","number":13,"state":"open","locked":false,"title":"check for manually created files in order to prevent data loss (bsc#8608...","user":{"login":"jsrain","id":914664,"avatar_url":"https://avatars.githubusercontent.com/u/914664?v=3","gravatar_id":"","url":"https://api.github.com/users/jsrain","html_url":"https://github.com/jsrain","followers_url":"https://api.github.com/users/jsrain/followers","following_url":"https://api.github.com/users/jsrain/following{/other_user}","gists_url":"https://api.github.com/users/jsrain/gists{/gist_id}","starred_url":"https://api.github.com/users/jsrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsrain/subscriptions","organizations_url":"https://api.github.com/users/jsrain/orgs","repos_url":"https://api.github.com/users/jsrain/repos","events_url":"https://api.github.com/users/jsrain/events{/privacy}","received_events_url":"https://api.github.com/users/jsrain/received_events","type":"User","site_admin":false},"body":"...56)","created_at":"2015-01-19T10:16:43Z","updated_at":"2015-01-19T13:03:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ee961a53808facc085029cea4f5772a2db4fc6b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-http-server/pulls/13/commits","review_comments_url":"https://api.github.com/repos/yast/yast-http-server/pulls/13/comments","review_comment_url":"https://api.github.com/repos/yast/yast-http-server/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yast/yast-http-server/issues/13/comments","statuses_url":"https://api.github.com/repos/yast/yast-http-server/statuses/0554cdeab780ce4089f7076ef5e3c9f417373d4f","head":{"label":"jsrain:Code-11-SP2","ref":"Code-11-SP2","sha":"0554cdeab780ce4089f7076ef5e3c9f417373d4f","user":{"login":"jsrain","id":914664,"avatar_url":"https://avatars.githubusercontent.com/u/914664?v=3","gravatar_id":"","url":"https://api.github.com/users/jsrain","html_url":"https://github.com/jsrain","followers_url":"https://api.github.com/users/jsrain/followers","following_url":"https://api.github.com/users/jsrain/following{/other_user}","gists_url":"https://api.github.com/users/jsrain/gists{/gist_id}","starred_url":"https://api.github.com/users/jsrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsrain/subscriptions","organizations_url":"https://api.github.com/users/jsrain/orgs","repos_url":"https://api.github.com/users/jsrain/repos","events_url":"https://api.github.com/users/jsrain/events{/privacy}","received_events_url":"https://api.github.com/users/jsrain/received_events","type":"User","site_admin":false},"repo":{"id":16370546,"name":"yast-http-server","full_name":"jsrain/yast-http-server","owner":{"login":"jsrain","id":914664,"avatar_url":"https://avatars.githubusercontent.com/u/914664?v=3","gravatar_id":"","url":"https://api.github.com/users/jsrain","html_url":"https://github.com/jsrain","followers_url":"https://api.github.com/users/jsrain/followers","following_url":"https://api.github.com/users/jsrain/following{/other_user}","gists_url":"https://api.github.com/users/jsrain/gists{/gist_id}","starred_url":"https://api.github.com/users/jsrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsrain/subscriptions","organizations_url":"https://api.github.com/users/jsrain/orgs","repos_url":"https://api.github.com/users/jsrain/repos","events_url":"https://api.github.com/users/jsrain/events{/privacy}","received_events_url":"https://api.github.com/users/jsrain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsrain/yast-http-server","description":"YaST module http-server","fork":true,"url":"https://api.github.com/repos/jsrain/yast-http-server","forks_url":"https://api.github.com/repos/jsrain/yast-http-server/forks","keys_url":"https://api.github.com/repos/jsrain/yast-http-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsrain/yast-http-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsrain/yast-http-server/teams","hooks_url":"https://api.github.com/repos/jsrain/yast-http-server/hooks","issue_events_url":"https://api.github.com/repos/jsrain/yast-http-server/issues/events{/number}","events_url":"https://api.github.com/repos/jsrain/yast-http-server/events","assignees_url":"https://api.github.com/repos/jsrain/yast-http-server/assignees{/user}","branches_url":"https://api.github.com/repos/jsrain/yast-http-server/branches{/branch}","tags_url":"https://api.github.com/repos/jsrain/yast-http-server/tags","blobs_url":"https://api.github.com/repos/jsrain/yast-http-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsrain/yast-http-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsrain/yast-http-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsrain/yast-http-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsrain/yast-http-server/statuses/{sha}","languages_url":"https://api.github.com/repos/jsrain/yast-http-server/languages","stargazers_url":"https://api.github.com/repos/jsrain/yast-http-server/stargazers","contributors_url":"https://api.github.com/repos/jsrain/yast-http-server/contributors","subscribers_url":"https://api.github.com/repos/jsrain/yast-http-server/subscribers","subscription_url":"https://api.github.com/repos/jsrain/yast-http-server/subscription","commits_url":"https://api.github.com/repos/jsrain/yast-http-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsrain/yast-http-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsrain/yast-http-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsrain/yast-http-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/jsrain/yast-http-server/contents/{+path}","compare_url":"https://api.github.com/repos/jsrain/yast-http-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsrain/yast-http-server/merges","archive_url":"https://api.github.com/repos/jsrain/yast-http-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsrain/yast-http-server/downloads","issues_url":"https://api.github.com/repos/jsrain/yast-http-server/issues{/number}","pulls_url":"https://api.github.com/repos/jsrain/yast-http-server/pulls{/number}","milestones_url":"https://api.github.com/repos/jsrain/yast-http-server/milestones{/number}","notifications_url":"https://api.github.com/repos/jsrain/yast-http-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsrain/yast-http-server/labels{/name}","releases_url":"https://api.github.com/repos/jsrain/yast-http-server/releases{/id}","created_at":"2014-01-30T06:58:31Z","updated_at":"2014-01-30T06:58:32Z","pushed_at":"2015-01-19T12:55:35Z","git_url":"git://github.com/jsrain/yast-http-server.git","ssh_url":"git@github.com:jsrain/yast-http-server.git","clone_url":"https://github.com/jsrain/yast-http-server.git","svn_url":"https://github.com/jsrain/yast-http-server","homepage":"http://en.opensuse.org/Portal:YaST","size":1340,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:Code-11-SP2","ref":"Code-11-SP2","sha":"8799a548874339948bd0fa9d80200268e5c29ec1","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368117,"name":"yast-http-server","full_name":"yast/yast-http-server","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-http-server","description":"YaST module http-server","fork":false,"url":"https://api.github.com/repos/yast/yast-http-server","forks_url":"https://api.github.com/repos/yast/yast-http-server/forks","keys_url":"https://api.github.com/repos/yast/yast-http-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-http-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-http-server/teams","hooks_url":"https://api.github.com/repos/yast/yast-http-server/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-http-server/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-http-server/events","assignees_url":"https://api.github.com/repos/yast/yast-http-server/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-http-server/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-http-server/tags","blobs_url":"https://api.github.com/repos/yast/yast-http-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-http-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-http-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-http-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-http-server/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-http-server/languages","stargazers_url":"https://api.github.com/repos/yast/yast-http-server/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-http-server/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-http-server/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-http-server/subscription","commits_url":"https://api.github.com/repos/yast/yast-http-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-http-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-http-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-http-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/yast/yast-http-server/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-http-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-http-server/merges","archive_url":"https://api.github.com/repos/yast/yast-http-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-http-server/downloads","issues_url":"https://api.github.com/repos/yast/yast-http-server/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-http-server/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-http-server/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-http-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-http-server/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-http-server/releases{/id}","created_at":"2012-05-18T10:23:48Z","updated_at":"2014-12-04T12:29:50Z","pushed_at":"2014-12-04T12:29:49Z","git_url":"git://github.com/yast/yast-http-server.git","ssh_url":"git@github.com:yast/yast-http-server.git","clone_url":"https://github.com/yast/yast-http-server.git","svn_url":"https://github.com/yast/yast-http-server","homepage":"http://en.opensuse.org/Portal:YaST","size":1629,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-http-server/pulls/13"},"html":{"href":"https://github.com/yast/yast-http-server/pull/13"},"issue":{"href":"https://api.github.com/repos/yast/yast-http-server/issues/13"},"comments":{"href":"https://api.github.com/repos/yast/yast-http-server/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-http-server/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-http-server/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-http-server/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-http-server/statuses/0554cdeab780ce4089f7076ef5e3c9f417373d4f"}}}}