{"action":"closed","number":93,"pull_request":{"url":"https://api.github.com/repos/gorgias/gorgias-chrome/pulls/93","id":28848294,"html_url":"https://github.com/gorgias/gorgias-chrome/pull/93","diff_url":"https://github.com/gorgias/gorgias-chrome/pull/93.diff","patch_url":"https://github.com/gorgias/gorgias-chrome/pull/93.patch","issue_url":"https://api.github.com/repos/gorgias/gorgias-chrome/issues/93","number":93,"state":"closed","locked":false,"title":"Dialog positioning improvements","user":{"login":"ghinda","id":325171,"avatar_url":"https://avatars.githubusercontent.com/u/325171?v=3","gravatar_id":"","url":"https://api.github.com/users/ghinda","html_url":"https://github.com/ghinda","followers_url":"https://api.github.com/users/ghinda/followers","following_url":"https://api.github.com/users/ghinda/following{/other_user}","gists_url":"https://api.github.com/users/ghinda/gists{/gist_id}","starred_url":"https://api.github.com/users/ghinda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghinda/subscriptions","organizations_url":"https://api.github.com/users/ghinda/orgs","repos_url":"https://api.github.com/users/ghinda/repos","events_url":"https://api.github.com/users/ghinda/events{/privacy}","received_events_url":"https://api.github.com/users/ghinda/received_events","type":"User","site_admin":false},"body":"Improvements on the dialog positioning functionality.\r\n\r\n* If there isn't enough space at the bottom of the window (between the point where the caret is and the bottom of the viewport) to fit the dialog, the dialog will be placed at the top of the caret.\r\n* The dialog's position, when the dialog is visible, will change when scrolling the page or the content element. \r\n\r\nThis doesn't work in Gmail, because it relies on the standard element `scroll` event. Gmail seems to be using custom js-based elements for scrolling, and not standard `overflow: auto` functionality.\r\n\r\nAnother small fix:\r\n* Don't display an empty `.qt-shortcut` element in the quicktexts listing in the dialog, if the qt does not have a shortcut set.","created_at":"2015-02-06T22:39:00Z","updated_at":"2015-02-09T10:01:13Z","closed_at":"2015-02-09T10:01:12Z","merged_at":"2015-02-09T10:01:12Z","merge_commit_sha":"7a1a97f5928b467840905cb29cdc169ac03a28c1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gorgias/gorgias-chrome/pulls/93/commits","review_comments_url":"https://api.github.com/repos/gorgias/gorgias-chrome/pulls/93/comments","review_comment_url":"https://api.github.com/repos/gorgias/gorgias-chrome/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gorgias/gorgias-chrome/issues/93/comments","statuses_url":"https://api.github.com/repos/gorgias/gorgias-chrome/statuses/51c5694f9dc3936af1eb4f9271eb621fe8797b86","head":{"label":"gorgias:80-dialog-bottom-fix","ref":"80-dialog-bottom-fix","sha":"51c5694f9dc3936af1eb4f9271eb621fe8797b86","user":{"login":"gorgias","id":9865930,"avatar_url":"https://avatars.githubusercontent.com/u/9865930?v=3","gravatar_id":"","url":"https://api.github.com/users/gorgias","html_url":"https://github.com/gorgias","followers_url":"https://api.github.com/users/gorgias/followers","following_url":"https://api.github.com/users/gorgias/following{/other_user}","gists_url":"https://api.github.com/users/gorgias/gists{/gist_id}","starred_url":"https://api.github.com/users/gorgias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorgias/subscriptions","organizations_url":"https://api.github.com/users/gorgias/orgs","repos_url":"https://api.github.com/users/gorgias/repos","events_url":"https://api.github.com/users/gorgias/events{/privacy}","received_events_url":"https://api.github.com/users/gorgias/received_events","type":"Organization","site_admin":false},"repo":{"id":9097294,"name":"gorgias-chrome","full_name":"gorgias/gorgias-chrome","owner":{"login":"gorgias","id":9865930,"avatar_url":"https://avatars.githubusercontent.com/u/9865930?v=3","gravatar_id":"","url":"https://api.github.com/users/gorgias","html_url":"https://github.com/gorgias","followers_url":"https://api.github.com/users/gorgias/followers","following_url":"https://api.github.com/users/gorgias/following{/other_user}","gists_url":"https://api.github.com/users/gorgias/gists{/gist_id}","starred_url":"https://api.github.com/users/gorgias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorgias/subscriptions","organizations_url":"https://api.github.com/users/gorgias/orgs","repos_url":"https://api.github.com/users/gorgias/repos","events_url":"https://api.github.com/users/gorgias/events{/privacy}","received_events_url":"https://api.github.com/users/gorgias/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gorgias/gorgias-chrome","description":"Write faster using templates and keyboard shortcuts.","fork":false,"url":"https://api.github.com/repos/gorgias/gorgias-chrome","forks_url":"https://api.github.com/repos/gorgias/gorgias-chrome/forks","keys_url":"https://api.github.com/repos/gorgias/gorgias-chrome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gorgias/gorgias-chrome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gorgias/gorgias-chrome/teams","hooks_url":"https://api.github.com/repos/gorgias/gorgias-chrome/hooks","issue_events_url":"https://api.github.com/repos/gorgias/gorgias-chrome/issues/events{/number}","events_url":"https://api.github.com/repos/gorgias/gorgias-chrome/events","assignees_url":"https://api.github.com/repos/gorgias/gorgias-chrome/assignees{/user}","branches_url":"https://api.github.com/repos/gorgias/gorgias-chrome/branches{/branch}","tags_url":"https://api.github.com/repos/gorgias/gorgias-chrome/tags","blobs_url":"https://api.github.com/repos/gorgias/gorgias-chrome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gorgias/gorgias-chrome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gorgias/gorgias-chrome/git/refs{/sha}","trees_url":"https://api.github.com/repos/gorgias/gorgias-chrome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gorgias/gorgias-chrome/statuses/{sha}","languages_url":"https://api.github.com/repos/gorgias/gorgias-chrome/languages","stargazers_url":"https://api.github.com/repos/gorgias/gorgias-chrome/stargazers","contributors_url":"https://api.github.com/repos/gorgias/gorgias-chrome/contributors","subscribers_url":"https://api.github.com/repos/gorgias/gorgias-chrome/subscribers","subscription_url":"https://api.github.com/repos/gorgias/gorgias-chrome/subscription","commits_url":"https://api.github.com/repos/gorgias/gorgias-chrome/commits{/sha}","git_commits_url":"https://api.github.com/repos/gorgias/gorgias-chrome/git/commits{/sha}","comments_url":"https://api.github.com/repos/gorgias/gorgias-chrome/comments{/number}","issue_comment_url":"https://api.github.com/repos/gorgias/gorgias-chrome/issues/comments/{number}","contents_url":"https://api.github.com/repos/gorgias/gorgias-chrome/contents/{+path}","compare_url":"https://api.github.com/repos/gorgias/gorgias-chrome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gorgias/gorgias-chrome/merges","archive_url":"https://api.github.com/repos/gorgias/gorgias-chrome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gorgias/gorgias-chrome/downloads","issues_url":"https://api.github.com/repos/gorgias/gorgias-chrome/issues{/number}","pulls_url":"https://api.github.com/repos/gorgias/gorgias-chrome/pulls{/number}","milestones_url":"https://api.github.com/repos/gorgias/gorgias-chrome/milestones{/number}","notifications_url":"https://api.github.com/repos/gorgias/gorgias-chrome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gorgias/gorgias-chrome/labels{/name}","releases_url":"https://api.github.com/repos/gorgias/gorgias-chrome/releases{/id}","created_at":"2013-03-29T11:33:24Z","updated_at":"2015-02-02T11:27:14Z","pushed_at":"2015-02-09T10:01:12Z","git_url":"git://github.com/gorgias/gorgias-chrome.git","ssh_url":"git@github.com:gorgias/gorgias-chrome.git","clone_url":"https://github.com/gorgias/gorgias-chrome.git","svn_url":"https://github.com/gorgias/gorgias-chrome","homepage":"https://chrome.google.com/webstore/detail/quicktext-for-chrome/lmcngpkjkplipamgflhioabnhnopeabf","size":6713,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":6,"default_branch":"master"}},"base":{"label":"gorgias:master","ref":"master","sha":"d4e0c7c1d986467dd839d30e5a28d134e633e7cd","user":{"login":"gorgias","id":9865930,"avatar_url":"https://avatars.githubusercontent.com/u/9865930?v=3","gravatar_id":"","url":"https://api.github.com/users/gorgias","html_url":"https://github.com/gorgias","followers_url":"https://api.github.com/users/gorgias/followers","following_url":"https://api.github.com/users/gorgias/following{/other_user}","gists_url":"https://api.github.com/users/gorgias/gists{/gist_id}","starred_url":"https://api.github.com/users/gorgias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorgias/subscriptions","organizations_url":"https://api.github.com/users/gorgias/orgs","repos_url":"https://api.github.com/users/gorgias/repos","events_url":"https://api.github.com/users/gorgias/events{/privacy}","received_events_url":"https://api.github.com/users/gorgias/received_events","type":"Organization","site_admin":false},"repo":{"id":9097294,"name":"gorgias-chrome","full_name":"gorgias/gorgias-chrome","owner":{"login":"gorgias","id":9865930,"avatar_url":"https://avatars.githubusercontent.com/u/9865930?v=3","gravatar_id":"","url":"https://api.github.com/users/gorgias","html_url":"https://github.com/gorgias","followers_url":"https://api.github.com/users/gorgias/followers","following_url":"https://api.github.com/users/gorgias/following{/other_user}","gists_url":"https://api.github.com/users/gorgias/gists{/gist_id}","starred_url":"https://api.github.com/users/gorgias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorgias/subscriptions","organizations_url":"https://api.github.com/users/gorgias/orgs","repos_url":"https://api.github.com/users/gorgias/repos","events_url":"https://api.github.com/users/gorgias/events{/privacy}","received_events_url":"https://api.github.com/users/gorgias/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gorgias/gorgias-chrome","description":"Write faster using templates and keyboard shortcuts.","fork":false,"url":"https://api.github.com/repos/gorgias/gorgias-chrome","forks_url":"https://api.github.com/repos/gorgias/gorgias-chrome/forks","keys_url":"https://api.github.com/repos/gorgias/gorgias-chrome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gorgias/gorgias-chrome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gorgias/gorgias-chrome/teams","hooks_url":"https://api.github.com/repos/gorgias/gorgias-chrome/hooks","issue_events_url":"https://api.github.com/repos/gorgias/gorgias-chrome/issues/events{/number}","events_url":"https://api.github.com/repos/gorgias/gorgias-chrome/events","assignees_url":"https://api.github.com/repos/gorgias/gorgias-chrome/assignees{/user}","branches_url":"https://api.github.com/repos/gorgias/gorgias-chrome/branches{/branch}","tags_url":"https://api.github.com/repos/gorgias/gorgias-chrome/tags","blobs_url":"https://api.github.com/repos/gorgias/gorgias-chrome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gorgias/gorgias-chrome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gorgias/gorgias-chrome/git/refs{/sha}","trees_url":"https://api.github.com/repos/gorgias/gorgias-chrome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gorgias/gorgias-chrome/statuses/{sha}","languages_url":"https://api.github.com/repos/gorgias/gorgias-chrome/languages","stargazers_url":"https://api.github.com/repos/gorgias/gorgias-chrome/stargazers","contributors_url":"https://api.github.com/repos/gorgias/gorgias-chrome/contributors","subscribers_url":"https://api.github.com/repos/gorgias/gorgias-chrome/subscribers","subscription_url":"https://api.github.com/repos/gorgias/gorgias-chrome/subscription","commits_url":"https://api.github.com/repos/gorgias/gorgias-chrome/commits{/sha}","git_commits_url":"https://api.github.com/repos/gorgias/gorgias-chrome/git/commits{/sha}","comments_url":"https://api.github.com/repos/gorgias/gorgias-chrome/comments{/number}","issue_comment_url":"https://api.github.com/repos/gorgias/gorgias-chrome/issues/comments/{number}","contents_url":"https://api.github.com/repos/gorgias/gorgias-chrome/contents/{+path}","compare_url":"https://api.github.com/repos/gorgias/gorgias-chrome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gorgias/gorgias-chrome/merges","archive_url":"https://api.github.com/repos/gorgias/gorgias-chrome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gorgias/gorgias-chrome/downloads","issues_url":"https://api.github.com/repos/gorgias/gorgias-chrome/issues{/number}","pulls_url":"https://api.github.com/repos/gorgias/gorgias-chrome/pulls{/number}","milestones_url":"https://api.github.com/repos/gorgias/gorgias-chrome/milestones{/number}","notifications_url":"https://api.github.com/repos/gorgias/gorgias-chrome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gorgias/gorgias-chrome/labels{/name}","releases_url":"https://api.github.com/repos/gorgias/gorgias-chrome/releases{/id}","created_at":"2013-03-29T11:33:24Z","updated_at":"2015-02-02T11:27:14Z","pushed_at":"2015-02-09T10:01:12Z","git_url":"git://github.com/gorgias/gorgias-chrome.git","ssh_url":"git@github.com:gorgias/gorgias-chrome.git","clone_url":"https://github.com/gorgias/gorgias-chrome.git","svn_url":"https://github.com/gorgias/gorgias-chrome","homepage":"https://chrome.google.com/webstore/detail/quicktext-for-chrome/lmcngpkjkplipamgflhioabnhnopeabf","size":6713,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gorgias/gorgias-chrome/pulls/93"},"html":{"href":"https://github.com/gorgias/gorgias-chrome/pull/93"},"issue":{"href":"https://api.github.com/repos/gorgias/gorgias-chrome/issues/93"},"comments":{"href":"https://api.github.com/repos/gorgias/gorgias-chrome/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/gorgias/gorgias-chrome/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/gorgias/gorgias-chrome/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gorgias/gorgias-chrome/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/gorgias/gorgias-chrome/statuses/51c5694f9dc3936af1eb4f9271eb621fe8797b86"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"xarg","id":94721,"avatar_url":"https://avatars.githubusercontent.com/u/94721?v=3","gravatar_id":"","url":"https://api.github.com/users/xarg","html_url":"https://github.com/xarg","followers_url":"https://api.github.com/users/xarg/followers","following_url":"https://api.github.com/users/xarg/following{/other_user}","gists_url":"https://api.github.com/users/xarg/gists{/gist_id}","starred_url":"https://api.github.com/users/xarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xarg/subscriptions","organizations_url":"https://api.github.com/users/xarg/orgs","repos_url":"https://api.github.com/users/xarg/repos","events_url":"https://api.github.com/users/xarg/events{/privacy}","received_events_url":"https://api.github.com/users/xarg/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":5,"additions":64,"deletions":16,"changed_files":2}}