{"action":"created","comment":{"url":"https://api.github.com/repos/librenms/librenms/pulls/comments/48680246","id":48680246,"diff_hunk":"@@ -558,8 +559,10 @@\n \n         // Update Database\n         if (count($port['update'])) {\n-            $updated = dbUpdate($port['update'], 'ports', '`port_id` = ?', array($port['port_id']));\n-            d_echo(\"$updated updated\");\n+            //$updated = dbUpdate($port['update'], 'ports', '`port_id` = ?', array($port['port_id']));","path":"includes/polling/ports.inc.php","position":23,"original_position":23,"commit_id":"b3d4d7a3883874a40a3295e7f3160c2b99a0a92d","original_commit_id":"b3d4d7a3883874a40a3295e7f3160c2b99a0a92d","user":{"login":"paulgear","id":107222,"avatar_url":"https://avatars.githubusercontent.com/u/107222?v=3","gravatar_id":"","url":"https://api.github.com/users/paulgear","html_url":"https://github.com/paulgear","followers_url":"https://api.github.com/users/paulgear/followers","following_url":"https://api.github.com/users/paulgear/following{/other_user}","gists_url":"https://api.github.com/users/paulgear/gists{/gist_id}","starred_url":"https://api.github.com/users/paulgear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulgear/subscriptions","organizations_url":"https://api.github.com/users/paulgear/orgs","repos_url":"https://api.github.com/users/paulgear/repos","events_url":"https://api.github.com/users/paulgear/events{/privacy}","received_events_url":"https://api.github.com/users/paulgear/received_events","type":"User","site_admin":false},"body":"Delete","created_at":"2016-01-01T20:49:12Z","updated_at":"2016-01-01T20:49:12Z","html_url":"https://github.com/librenms/librenms/pull/2577#discussion_r48680246","pull_request_url":"https://api.github.com/repos/librenms/librenms/pulls/2577","_links":{"self":{"href":"https://api.github.com/repos/librenms/librenms/pulls/comments/48680246"},"html":{"href":"https://github.com/librenms/librenms/pull/2577#discussion_r48680246"},"pull_request":{"href":"https://api.github.com/repos/librenms/librenms/pulls/2577"}}},"pull_request":{"url":"https://api.github.com/repos/librenms/librenms/pulls/2577","id":53009389,"html_url":"https://github.com/librenms/librenms/pull/2577","diff_url":"https://github.com/librenms/librenms/pull/2577.diff","patch_url":"https://github.com/librenms/librenms/pull/2577.patch","issue_url":"https://api.github.com/repos/librenms/librenms/issues/2577","number":2577,"state":"open","locked":false,"title":"Drnet performance updates","user":{"login":"greggcz","id":9813886,"avatar_url":"https://avatars.githubusercontent.com/u/9813886?v=3","gravatar_id":"","url":"https://api.github.com/users/greggcz","html_url":"https://github.com/greggcz","followers_url":"https://api.github.com/users/greggcz/followers","following_url":"https://api.github.com/users/greggcz/following{/other_user}","gists_url":"https://api.github.com/users/greggcz/gists{/gist_id}","starred_url":"https://api.github.com/users/greggcz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greggcz/subscriptions","organizations_url":"https://api.github.com/users/greggcz/orgs","repos_url":"https://api.github.com/users/greggcz/repos","events_url":"https://api.github.com/users/greggcz/events{/privacy}","received_events_url":"https://api.github.com/users/greggcz/received_events","type":"User","site_admin":false},"body":"Fixes SQL port update (deleted=>1, port_id = '') which should not happen\r\nIntroduces dbBulkInsertUpdate to optimize SQL queries (devices with large amount of ports & using remote database with higher latency suffer from SQL roundtrip issues resulting in never ending discover and polls) see ports.inc.php and dbFacile.mysql.inc.php\r\n\r\n-Gregg","created_at":"2015-12-08T17:11:12Z","updated_at":"2016-01-01T20:49:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f22bd9c1d562ee94a0af3d06eae91dcb8ecf18e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/librenms/librenms/pulls/2577/commits","review_comments_url":"https://api.github.com/repos/librenms/librenms/pulls/2577/comments","review_comment_url":"https://api.github.com/repos/librenms/librenms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/2577/comments","statuses_url":"https://api.github.com/repos/librenms/librenms/statuses/b3d4d7a3883874a40a3295e7f3160c2b99a0a92d","head":{"label":"greggcz:drnet-performance-updates","ref":"drnet-performance-updates","sha":"b3d4d7a3883874a40a3295e7f3160c2b99a0a92d","user":{"login":"greggcz","id":9813886,"avatar_url":"https://avatars.githubusercontent.com/u/9813886?v=3","gravatar_id":"","url":"https://api.github.com/users/greggcz","html_url":"https://github.com/greggcz","followers_url":"https://api.github.com/users/greggcz/followers","following_url":"https://api.github.com/users/greggcz/following{/other_user}","gists_url":"https://api.github.com/users/greggcz/gists{/gist_id}","starred_url":"https://api.github.com/users/greggcz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greggcz/subscriptions","organizations_url":"https://api.github.com/users/greggcz/orgs","repos_url":"https://api.github.com/users/greggcz/repos","events_url":"https://api.github.com/users/greggcz/events{/privacy}","received_events_url":"https://api.github.com/users/greggcz/received_events","type":"User","site_admin":false},"repo":{"id":47635742,"name":"librenms","full_name":"greggcz/librenms","owner":{"login":"greggcz","id":9813886,"avatar_url":"https://avatars.githubusercontent.com/u/9813886?v=3","gravatar_id":"","url":"https://api.github.com/users/greggcz","html_url":"https://github.com/greggcz","followers_url":"https://api.github.com/users/greggcz/followers","following_url":"https://api.github.com/users/greggcz/following{/other_user}","gists_url":"https://api.github.com/users/greggcz/gists{/gist_id}","starred_url":"https://api.github.com/users/greggcz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greggcz/subscriptions","organizations_url":"https://api.github.com/users/greggcz/orgs","repos_url":"https://api.github.com/users/greggcz/repos","events_url":"https://api.github.com/users/greggcz/events{/privacy}","received_events_url":"https://api.github.com/users/greggcz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greggcz/librenms","description":"Community-based GPL-licensed network monitoring system","fork":true,"url":"https://api.github.com/repos/greggcz/librenms","forks_url":"https://api.github.com/repos/greggcz/librenms/forks","keys_url":"https://api.github.com/repos/greggcz/librenms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greggcz/librenms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greggcz/librenms/teams","hooks_url":"https://api.github.com/repos/greggcz/librenms/hooks","issue_events_url":"https://api.github.com/repos/greggcz/librenms/issues/events{/number}","events_url":"https://api.github.com/repos/greggcz/librenms/events","assignees_url":"https://api.github.com/repos/greggcz/librenms/assignees{/user}","branches_url":"https://api.github.com/repos/greggcz/librenms/branches{/branch}","tags_url":"https://api.github.com/repos/greggcz/librenms/tags","blobs_url":"https://api.github.com/repos/greggcz/librenms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greggcz/librenms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greggcz/librenms/git/refs{/sha}","trees_url":"https://api.github.com/repos/greggcz/librenms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greggcz/librenms/statuses/{sha}","languages_url":"https://api.github.com/repos/greggcz/librenms/languages","stargazers_url":"https://api.github.com/repos/greggcz/librenms/stargazers","contributors_url":"https://api.github.com/repos/greggcz/librenms/contributors","subscribers_url":"https://api.github.com/repos/greggcz/librenms/subscribers","subscription_url":"https://api.github.com/repos/greggcz/librenms/subscription","commits_url":"https://api.github.com/repos/greggcz/librenms/commits{/sha}","git_commits_url":"https://api.github.com/repos/greggcz/librenms/git/commits{/sha}","comments_url":"https://api.github.com/repos/greggcz/librenms/comments{/number}","issue_comment_url":"https://api.github.com/repos/greggcz/librenms/issues/comments{/number}","contents_url":"https://api.github.com/repos/greggcz/librenms/contents/{+path}","compare_url":"https://api.github.com/repos/greggcz/librenms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greggcz/librenms/merges","archive_url":"https://api.github.com/repos/greggcz/librenms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greggcz/librenms/downloads","issues_url":"https://api.github.com/repos/greggcz/librenms/issues{/number}","pulls_url":"https://api.github.com/repos/greggcz/librenms/pulls{/number}","milestones_url":"https://api.github.com/repos/greggcz/librenms/milestones{/number}","notifications_url":"https://api.github.com/repos/greggcz/librenms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greggcz/librenms/labels{/name}","releases_url":"https://api.github.com/repos/greggcz/librenms/releases{/id}","created_at":"2015-12-08T16:50:52Z","updated_at":"2015-12-08T16:51:33Z","pushed_at":"2015-12-10T23:26:42Z","git_url":"git://github.com/greggcz/librenms.git","ssh_url":"git@github.com:greggcz/librenms.git","clone_url":"https://github.com/greggcz/librenms.git","svn_url":"https://github.com/greggcz/librenms","homepage":"http://www.librenms.org/","size":62618,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"librenms:master","ref":"master","sha":"a2d97f4283c7a920904fa953cf677db92df189e8","user":{"login":"librenms","id":5791783,"avatar_url":"https://avatars.githubusercontent.com/u/5791783?v=3","gravatar_id":"","url":"https://api.github.com/users/librenms","html_url":"https://github.com/librenms","followers_url":"https://api.github.com/users/librenms/followers","following_url":"https://api.github.com/users/librenms/following{/other_user}","gists_url":"https://api.github.com/users/librenms/gists{/gist_id}","starred_url":"https://api.github.com/users/librenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librenms/subscriptions","organizations_url":"https://api.github.com/users/librenms/orgs","repos_url":"https://api.github.com/users/librenms/repos","events_url":"https://api.github.com/users/librenms/events{/privacy}","received_events_url":"https://api.github.com/users/librenms/received_events","type":"Organization","site_admin":false},"repo":{"id":13914116,"name":"librenms","full_name":"librenms/librenms","owner":{"login":"librenms","id":5791783,"avatar_url":"https://avatars.githubusercontent.com/u/5791783?v=3","gravatar_id":"","url":"https://api.github.com/users/librenms","html_url":"https://github.com/librenms","followers_url":"https://api.github.com/users/librenms/followers","following_url":"https://api.github.com/users/librenms/following{/other_user}","gists_url":"https://api.github.com/users/librenms/gists{/gist_id}","starred_url":"https://api.github.com/users/librenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librenms/subscriptions","organizations_url":"https://api.github.com/users/librenms/orgs","repos_url":"https://api.github.com/users/librenms/repos","events_url":"https://api.github.com/users/librenms/events{/privacy}","received_events_url":"https://api.github.com/users/librenms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/librenms/librenms","description":"Community-based GPL-licensed network monitoring system","fork":false,"url":"https://api.github.com/repos/librenms/librenms","forks_url":"https://api.github.com/repos/librenms/librenms/forks","keys_url":"https://api.github.com/repos/librenms/librenms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/librenms/librenms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/librenms/librenms/teams","hooks_url":"https://api.github.com/repos/librenms/librenms/hooks","issue_events_url":"https://api.github.com/repos/librenms/librenms/issues/events{/number}","events_url":"https://api.github.com/repos/librenms/librenms/events","assignees_url":"https://api.github.com/repos/librenms/librenms/assignees{/user}","branches_url":"https://api.github.com/repos/librenms/librenms/branches{/branch}","tags_url":"https://api.github.com/repos/librenms/librenms/tags","blobs_url":"https://api.github.com/repos/librenms/librenms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/librenms/librenms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/librenms/librenms/git/refs{/sha}","trees_url":"https://api.github.com/repos/librenms/librenms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/librenms/librenms/statuses/{sha}","languages_url":"https://api.github.com/repos/librenms/librenms/languages","stargazers_url":"https://api.github.com/repos/librenms/librenms/stargazers","contributors_url":"https://api.github.com/repos/librenms/librenms/contributors","subscribers_url":"https://api.github.com/repos/librenms/librenms/subscribers","subscription_url":"https://api.github.com/repos/librenms/librenms/subscription","commits_url":"https://api.github.com/repos/librenms/librenms/commits{/sha}","git_commits_url":"https://api.github.com/repos/librenms/librenms/git/commits{/sha}","comments_url":"https://api.github.com/repos/librenms/librenms/comments{/number}","issue_comment_url":"https://api.github.com/repos/librenms/librenms/issues/comments{/number}","contents_url":"https://api.github.com/repos/librenms/librenms/contents/{+path}","compare_url":"https://api.github.com/repos/librenms/librenms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/librenms/librenms/merges","archive_url":"https://api.github.com/repos/librenms/librenms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/librenms/librenms/downloads","issues_url":"https://api.github.com/repos/librenms/librenms/issues{/number}","pulls_url":"https://api.github.com/repos/librenms/librenms/pulls{/number}","milestones_url":"https://api.github.com/repos/librenms/librenms/milestones{/number}","notifications_url":"https://api.github.com/repos/librenms/librenms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/librenms/librenms/labels{/name}","releases_url":"https://api.github.com/repos/librenms/librenms/releases{/id}","created_at":"2013-10-28T01:37:13Z","updated_at":"2016-01-01T04:30:49Z","pushed_at":"2016-01-01T20:19:41Z","git_url":"git://github.com/librenms/librenms.git","ssh_url":"git@github.com:librenms/librenms.git","clone_url":"https://github.com/librenms/librenms.git","svn_url":"https://github.com/librenms/librenms","homepage":"http://www.librenms.org/","size":88158,"stargazers_count":295,"watchers_count":295,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":197,"mirror_url":null,"open_issues_count":247,"forks":197,"open_issues":247,"watchers":295,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/librenms/librenms/pulls/2577"},"html":{"href":"https://github.com/librenms/librenms/pull/2577"},"issue":{"href":"https://api.github.com/repos/librenms/librenms/issues/2577"},"comments":{"href":"https://api.github.com/repos/librenms/librenms/issues/2577/comments"},"review_comments":{"href":"https://api.github.com/repos/librenms/librenms/pulls/2577/comments"},"review_comment":{"href":"https://api.github.com/repos/librenms/librenms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/librenms/librenms/pulls/2577/commits"},"statuses":{"href":"https://api.github.com/repos/librenms/librenms/statuses/b3d4d7a3883874a40a3295e7f3160c2b99a0a92d"}}}}