{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/beaker/pulls/comments/25623339","id":25623339,"diff_hunk":"@@ -300,7 +300,7 @@ def exec command, options={}\n     # @param [String] dir The directory structure to create on the host\n     # @return [Boolean] True, if directory construction succeeded, otherwise False\n     def mkdir_p dir\n-      if host['is_cygwin'].nil? or host['is_cygwin'] == true\n+      if @options['is_cygwin'].nil? or @options['is_cygwin'] == true","path":"lib/beaker/host.rb","position":5,"original_position":5,"commit_id":"377231420fcbd6afa227468b26211c12d2c1a560","original_commit_id":"8f7e0e66e996235ee03af166f27864a299d9cb9b","user":{"login":"anodelman","id":4140109,"avatar_url":"https://avatars.githubusercontent.com/u/4140109?v=3","gravatar_id":"","url":"https://api.github.com/users/anodelman","html_url":"https://github.com/anodelman","followers_url":"https://api.github.com/users/anodelman/followers","following_url":"https://api.github.com/users/anodelman/following{/other_user}","gists_url":"https://api.github.com/users/anodelman/gists{/gist_id}","starred_url":"https://api.github.com/users/anodelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anodelman/subscriptions","organizations_url":"https://api.github.com/users/anodelman/orgs","repos_url":"https://api.github.com/users/anodelman/repos","events_url":"https://api.github.com/users/anodelman/events{/privacy}","received_events_url":"https://api.github.com/users/anodelman/received_events","type":"User","site_admin":false},"body":"Looking over this again, we should use the host object inheritance to avoid doing an is_cygwin at all.  The 'mkdir -p' should be used by unix type hosts and the 'if not exists' should be pushed into the pswindows host.","created_at":"2015-03-02T18:27:47Z","updated_at":"2015-03-02T18:27:47Z","html_url":"https://github.com/puppetlabs/beaker/pull/666#discussion_r25623339","pull_request_url":"https://api.github.com/repos/puppetlabs/beaker/pulls/666","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/beaker/pulls/comments/25623339"},"html":{"href":"https://github.com/puppetlabs/beaker/pull/666#discussion_r25623339"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/beaker/pulls/666"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/beaker/pulls/666","id":28542267,"html_url":"https://github.com/puppetlabs/beaker/pull/666","diff_url":"https://github.com/puppetlabs/beaker/pull/666.diff","patch_url":"https://github.com/puppetlabs/beaker/pull/666.patch","issue_url":"https://api.github.com/repos/puppetlabs/beaker/issues/666","number":666,"state":"open","locked":false,"title":"(MAINT) Fix mkdir bug and add test for the future","user":{"login":"petems","id":1064715,"avatar_url":"https://avatars.githubusercontent.com/u/1064715?v=3","gravatar_id":"","url":"https://api.github.com/users/petems","html_url":"https://github.com/petems","followers_url":"https://api.github.com/users/petems/followers","following_url":"https://api.github.com/users/petems/following{/other_user}","gists_url":"https://api.github.com/users/petems/gists{/gist_id}","starred_url":"https://api.github.com/users/petems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petems/subscriptions","organizations_url":"https://api.github.com/users/petems/orgs","repos_url":"https://api.github.com/users/petems/repos","events_url":"https://api.github.com/users/petems/events{/privacy}","received_events_url":"https://api.github.com/users/petems/received_events","type":"User","site_admin":false},"body":"Introduced in f551c0ad124bb8ab782f7dd90ab30ae9cc49fafa\r\n\r\n\r\nThis actually breaks Beaker, because the host variable is nil:\r\n\r\n```\r\n/opt/rubies/2.1.2/lib/ruby/gems/2.1.0/bundler/gems/beaker-136d9c3cccbc/lib/beaker/host.rb:305:in `mkdir_p': undefined local variable or method `host' for #<FreeBSD::Host:0x007f8abe0e20b8> (NameError)\r\n\tfrom /opt/rubies/2.1.2/lib/ruby/gems/2.1.0/bundler/gems/beaker-136d9c3cccbc/lib/beaker/host.rb:364:in `block in do_scp_to'\r\n\tfrom /opt/rubies/2.1.2/lib/ruby/gems/2.1.0/bundler/gems/beaker-136d9c3cccbc/lib/beaker/host.rb:361:in `each'\r\n\tfrom /opt/rubies/2.1.2/lib/ruby/gems/2.1.0/bundler/gems/beaker-136d9c3cccbc/lib/beaker/host.rb:361:in `do_scp_to'\r\n\tfrom /opt/rubies/2.1.2/lib/ruby/gems/2.1.0/bundler/gems/beaker-136d9c3cccbc/lib/beaker/dsl/helpers.rb:207:in `block in scp_to'\r\n```","created_at":"2015-02-03T10:44:20Z","updated_at":"2015-03-02T18:27:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62731dbadc5fb142f6ddc313720d0c782e861158","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/beaker/pulls/666/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/beaker/pulls/666/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/beaker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/beaker/issues/666/comments","statuses_url":"https://api.github.com/repos/puppetlabs/beaker/statuses/377231420fcbd6afa227468b26211c12d2c1a560","head":{"label":"petems:MAINT-fix_mkdir_bug","ref":"MAINT-fix_mkdir_bug","sha":"377231420fcbd6afa227468b26211c12d2c1a560","user":{"login":"petems","id":1064715,"avatar_url":"https://avatars.githubusercontent.com/u/1064715?v=3","gravatar_id":"","url":"https://api.github.com/users/petems","html_url":"https://github.com/petems","followers_url":"https://api.github.com/users/petems/followers","following_url":"https://api.github.com/users/petems/following{/other_user}","gists_url":"https://api.github.com/users/petems/gists{/gist_id}","starred_url":"https://api.github.com/users/petems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petems/subscriptions","organizations_url":"https://api.github.com/users/petems/orgs","repos_url":"https://api.github.com/users/petems/repos","events_url":"https://api.github.com/users/petems/events{/privacy}","received_events_url":"https://api.github.com/users/petems/received_events","type":"User","site_admin":false},"repo":{"id":16768481,"name":"beaker","full_name":"petems/beaker","owner":{"login":"petems","id":1064715,"avatar_url":"https://avatars.githubusercontent.com/u/1064715?v=3","gravatar_id":"","url":"https://api.github.com/users/petems","html_url":"https://github.com/petems","followers_url":"https://api.github.com/users/petems/followers","following_url":"https://api.github.com/users/petems/following{/other_user}","gists_url":"https://api.github.com/users/petems/gists{/gist_id}","starred_url":"https://api.github.com/users/petems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petems/subscriptions","organizations_url":"https://api.github.com/users/petems/orgs","repos_url":"https://api.github.com/users/petems/repos","events_url":"https://api.github.com/users/petems/events{/privacy}","received_events_url":"https://api.github.com/users/petems/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petems/beaker","description":"Puppet acceptance testing harness","fork":true,"url":"https://api.github.com/repos/petems/beaker","forks_url":"https://api.github.com/repos/petems/beaker/forks","keys_url":"https://api.github.com/repos/petems/beaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petems/beaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petems/beaker/teams","hooks_url":"https://api.github.com/repos/petems/beaker/hooks","issue_events_url":"https://api.github.com/repos/petems/beaker/issues/events{/number}","events_url":"https://api.github.com/repos/petems/beaker/events","assignees_url":"https://api.github.com/repos/petems/beaker/assignees{/user}","branches_url":"https://api.github.com/repos/petems/beaker/branches{/branch}","tags_url":"https://api.github.com/repos/petems/beaker/tags","blobs_url":"https://api.github.com/repos/petems/beaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petems/beaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petems/beaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/petems/beaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petems/beaker/statuses/{sha}","languages_url":"https://api.github.com/repos/petems/beaker/languages","stargazers_url":"https://api.github.com/repos/petems/beaker/stargazers","contributors_url":"https://api.github.com/repos/petems/beaker/contributors","subscribers_url":"https://api.github.com/repos/petems/beaker/subscribers","subscription_url":"https://api.github.com/repos/petems/beaker/subscription","commits_url":"https://api.github.com/repos/petems/beaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/petems/beaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/petems/beaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/petems/beaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/petems/beaker/contents/{+path}","compare_url":"https://api.github.com/repos/petems/beaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petems/beaker/merges","archive_url":"https://api.github.com/repos/petems/beaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petems/beaker/downloads","issues_url":"https://api.github.com/repos/petems/beaker/issues{/number}","pulls_url":"https://api.github.com/repos/petems/beaker/pulls{/number}","milestones_url":"https://api.github.com/repos/petems/beaker/milestones{/number}","notifications_url":"https://api.github.com/repos/petems/beaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petems/beaker/labels{/name}","releases_url":"https://api.github.com/repos/petems/beaker/releases{/id}","created_at":"2014-02-12T13:46:02Z","updated_at":"2015-02-10T20:35:09Z","pushed_at":"2015-02-24T19:10:34Z","git_url":"git://github.com/petems/beaker.git","ssh_url":"git@github.com:petems/beaker.git","clone_url":"https://github.com/petems/beaker.git","svn_url":"https://github.com/petems/beaker","homepage":null,"size":9022,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"b7612cf36bd02e5ca4dd6cc40164b2e04d532300","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":12164675,"name":"beaker","full_name":"puppetlabs/beaker","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/beaker","description":"Puppet Acceptance Testing Harness","fork":false,"url":"https://api.github.com/repos/puppetlabs/beaker","forks_url":"https://api.github.com/repos/puppetlabs/beaker/forks","keys_url":"https://api.github.com/repos/puppetlabs/beaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/beaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/beaker/teams","hooks_url":"https://api.github.com/repos/puppetlabs/beaker/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/beaker/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/beaker/events","assignees_url":"https://api.github.com/repos/puppetlabs/beaker/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/beaker/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/beaker/tags","blobs_url":"https://api.github.com/repos/puppetlabs/beaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/beaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/beaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/beaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/beaker/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/beaker/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/beaker/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/beaker/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/beaker/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/beaker/subscription","commits_url":"https://api.github.com/repos/puppetlabs/beaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/beaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/beaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/beaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/beaker/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/beaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/beaker/merges","archive_url":"https://api.github.com/repos/puppetlabs/beaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/beaker/downloads","issues_url":"https://api.github.com/repos/puppetlabs/beaker/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/beaker/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/beaker/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/beaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/beaker/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/beaker/releases{/id}","created_at":"2013-08-16T17:57:03Z","updated_at":"2015-03-02T18:17:26Z","pushed_at":"2015-03-02T18:17:24Z","git_url":"git://github.com/puppetlabs/beaker.git","ssh_url":"git@github.com:puppetlabs/beaker.git","clone_url":"https://github.com/puppetlabs/beaker.git","svn_url":"https://github.com/puppetlabs/beaker","homepage":"https://groups.google.com/forum/#!forum/puppet-beaker","size":15729,"stargazers_count":152,"watchers_count":152,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":50,"forks":115,"open_issues":50,"watchers":152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/beaker/pulls/666"},"html":{"href":"https://github.com/puppetlabs/beaker/pull/666"},"issue":{"href":"https://api.github.com/repos/puppetlabs/beaker/issues/666"},"comments":{"href":"https://api.github.com/repos/puppetlabs/beaker/issues/666/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/beaker/pulls/666/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/beaker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/beaker/pulls/666/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/beaker/statuses/377231420fcbd6afa227468b26211c12d2c1a560"}}}}