{"action":"closed","number":95,"pull_request":{"url":"https://api.github.com/repos/UniversalViewer/universalviewer/pulls/95","id":38654771,"html_url":"https://github.com/UniversalViewer/universalviewer/pull/95","diff_url":"https://github.com/UniversalViewer/universalviewer/pull/95.diff","patch_url":"https://github.com/UniversalViewer/universalviewer/pull/95.patch","issue_url":"https://api.github.com/repos/UniversalViewer/universalviewer/issues/95","number":95,"state":"closed","locked":false,"title":"PDF fixes","user":{"login":"demiankatz","id":309069,"avatar_url":"https://avatars.githubusercontent.com/u/309069?v=3","gravatar_id":"","url":"https://api.github.com/users/demiankatz","html_url":"https://github.com/demiankatz","followers_url":"https://api.github.com/users/demiankatz/followers","following_url":"https://api.github.com/users/demiankatz/following{/other_user}","gists_url":"https://api.github.com/users/demiankatz/gists{/gist_id}","starred_url":"https://api.github.com/users/demiankatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demiankatz/subscriptions","organizations_url":"https://api.github.com/users/demiankatz/orgs","repos_url":"https://api.github.com/users/demiankatz/repos","events_url":"https://api.github.com/users/demiankatz/events{/privacy}","received_events_url":"https://api.github.com/users/demiankatz/received_events","type":"User","site_admin":false},"body":"I spent a little time today learning more about the PDF module. In the process, I've made some fixes. I've left my changes as separate commits in this PR so you can see my step-by-step work, which might be easier to review than one big lump of diffs.\r\n\r\nMy main objective was to make the left sidebar work correctly so that multiple PDFs could be supported; that goal is met here. Along the way, I removed some apparently obsolete code, fixed an IE bug and moved the THUMB_SELECTED command into the shared area since I expect this will be needed by most extensions.\r\n\r\nAs always, please let me know if I can be of any help in revising my work if it is unsatisfactory.\r\n\r\nAlso note that there's still a lot more work to do here. A couple of issues I noticed along the way but have not yet had time to address:\r\n\r\n- Thumbnails do not display appropriately in the left sidebar (probably because there aren't any image URIs in the manifest); a `<div>` is created with `height: NaNpx;`. We should find a better generic solution to missing/undefined thumbs.\r\n\r\n- Something is not quite right with the panel logic. If you expand and collapse the left panel a few times, it gets the whole viewer into a bad state from which you cannot recover without a page refresh. It also appears that in Firefox, the PDF viewer does not adjust correctly to account for the expanded left panel, though Chrome does not display the same problem for me.\r\n\r\nI might try to investigate these some more next week, though it will depend on available time -- I'll soon be leaving for vacation and will be out of the office from 7/2-7/13 with limited access to email.","created_at":"2015-06-26T14:30:24Z","updated_at":"2015-06-26T16:04:10Z","closed_at":"2015-06-26T16:04:10Z","merged_at":"2015-06-26T16:04:10Z","merge_commit_sha":"2fc4ed6ae8c1a92ecab658a5e234aa58dff38967","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/UniversalViewer/universalviewer/pulls/95/commits","review_comments_url":"https://api.github.com/repos/UniversalViewer/universalviewer/pulls/95/comments","review_comment_url":"https://api.github.com/repos/UniversalViewer/universalviewer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UniversalViewer/universalviewer/issues/95/comments","statuses_url":"https://api.github.com/repos/UniversalViewer/universalviewer/statuses/2cb2838b09267edc0fa817a3ac4f2e97c9ea90ec","head":{"label":"FalveyLibraryTechnology:pdf-fixes","ref":"pdf-fixes","sha":"2cb2838b09267edc0fa817a3ac4f2e97c9ea90ec","user":{"login":"FalveyLibraryTechnology","id":8671874,"avatar_url":"https://avatars.githubusercontent.com/u/8671874?v=3","gravatar_id":"","url":"https://api.github.com/users/FalveyLibraryTechnology","html_url":"https://github.com/FalveyLibraryTechnology","followers_url":"https://api.github.com/users/FalveyLibraryTechnology/followers","following_url":"https://api.github.com/users/FalveyLibraryTechnology/following{/other_user}","gists_url":"https://api.github.com/users/FalveyLibraryTechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/FalveyLibraryTechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FalveyLibraryTechnology/subscriptions","organizations_url":"https://api.github.com/users/FalveyLibraryTechnology/orgs","repos_url":"https://api.github.com/users/FalveyLibraryTechnology/repos","events_url":"https://api.github.com/users/FalveyLibraryTechnology/events{/privacy}","received_events_url":"https://api.github.com/users/FalveyLibraryTechnology/received_events","type":"Organization","site_admin":false},"repo":{"id":35961591,"name":"universalviewer","full_name":"FalveyLibraryTechnology/universalviewer","owner":{"login":"FalveyLibraryTechnology","id":8671874,"avatar_url":"https://avatars.githubusercontent.com/u/8671874?v=3","gravatar_id":"","url":"https://api.github.com/users/FalveyLibraryTechnology","html_url":"https://github.com/FalveyLibraryTechnology","followers_url":"https://api.github.com/users/FalveyLibraryTechnology/followers","following_url":"https://api.github.com/users/FalveyLibraryTechnology/following{/other_user}","gists_url":"https://api.github.com/users/FalveyLibraryTechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/FalveyLibraryTechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FalveyLibraryTechnology/subscriptions","organizations_url":"https://api.github.com/users/FalveyLibraryTechnology/orgs","repos_url":"https://api.github.com/users/FalveyLibraryTechnology/repos","events_url":"https://api.github.com/users/FalveyLibraryTechnology/events{/privacy}","received_events_url":"https://api.github.com/users/FalveyLibraryTechnology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FalveyLibraryTechnology/universalviewer","description":"","fork":true,"url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer","forks_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/forks","keys_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/teams","hooks_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/hooks","issue_events_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/issues/events{/number}","events_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/events","assignees_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/assignees{/user}","branches_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/branches{/branch}","tags_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/tags","blobs_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/statuses/{sha}","languages_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/languages","stargazers_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/stargazers","contributors_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/contributors","subscribers_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/subscribers","subscription_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/subscription","commits_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/contents/{+path}","compare_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/merges","archive_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/downloads","issues_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/issues{/number}","pulls_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/pulls{/number}","milestones_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/milestones{/number}","notifications_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/labels{/name}","releases_url":"https://api.github.com/repos/FalveyLibraryTechnology/universalviewer/releases{/id}","created_at":"2015-05-20T16:56:35Z","updated_at":"2015-06-23T13:49:17Z","pushed_at":"2015-06-26T14:24:03Z","git_url":"git://github.com/FalveyLibraryTechnology/universalviewer.git","ssh_url":"git@github.com:FalveyLibraryTechnology/universalviewer.git","clone_url":"https://github.com/FalveyLibraryTechnology/universalviewer.git","svn_url":"https://github.com/FalveyLibraryTechnology/universalviewer","homepage":"","size":5365,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"UniversalViewer:master","ref":"master","sha":"50de3d23e7326ffeb210e2ffcbe50e062efdd60c","user":{"login":"UniversalViewer","id":9430521,"avatar_url":"https://avatars.githubusercontent.com/u/9430521?v=3","gravatar_id":"","url":"https://api.github.com/users/UniversalViewer","html_url":"https://github.com/UniversalViewer","followers_url":"https://api.github.com/users/UniversalViewer/followers","following_url":"https://api.github.com/users/UniversalViewer/following{/other_user}","gists_url":"https://api.github.com/users/UniversalViewer/gists{/gist_id}","starred_url":"https://api.github.com/users/UniversalViewer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniversalViewer/subscriptions","organizations_url":"https://api.github.com/users/UniversalViewer/orgs","repos_url":"https://api.github.com/users/UniversalViewer/repos","events_url":"https://api.github.com/users/UniversalViewer/events{/privacy}","received_events_url":"https://api.github.com/users/UniversalViewer/received_events","type":"Organization","site_admin":false},"repo":{"id":30561727,"name":"universalviewer","full_name":"UniversalViewer/universalviewer","owner":{"login":"UniversalViewer","id":9430521,"avatar_url":"https://avatars.githubusercontent.com/u/9430521?v=3","gravatar_id":"","url":"https://api.github.com/users/UniversalViewer","html_url":"https://github.com/UniversalViewer","followers_url":"https://api.github.com/users/UniversalViewer/followers","following_url":"https://api.github.com/users/UniversalViewer/following{/other_user}","gists_url":"https://api.github.com/users/UniversalViewer/gists{/gist_id}","starred_url":"https://api.github.com/users/UniversalViewer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UniversalViewer/subscriptions","organizations_url":"https://api.github.com/users/UniversalViewer/orgs","repos_url":"https://api.github.com/users/UniversalViewer/repos","events_url":"https://api.github.com/users/UniversalViewer/events{/privacy}","received_events_url":"https://api.github.com/users/UniversalViewer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UniversalViewer/universalviewer","description":"","fork":false,"url":"https://api.github.com/repos/UniversalViewer/universalviewer","forks_url":"https://api.github.com/repos/UniversalViewer/universalviewer/forks","keys_url":"https://api.github.com/repos/UniversalViewer/universalviewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UniversalViewer/universalviewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UniversalViewer/universalviewer/teams","hooks_url":"https://api.github.com/repos/UniversalViewer/universalviewer/hooks","issue_events_url":"https://api.github.com/repos/UniversalViewer/universalviewer/issues/events{/number}","events_url":"https://api.github.com/repos/UniversalViewer/universalviewer/events","assignees_url":"https://api.github.com/repos/UniversalViewer/universalviewer/assignees{/user}","branches_url":"https://api.github.com/repos/UniversalViewer/universalviewer/branches{/branch}","tags_url":"https://api.github.com/repos/UniversalViewer/universalviewer/tags","blobs_url":"https://api.github.com/repos/UniversalViewer/universalviewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UniversalViewer/universalviewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UniversalViewer/universalviewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/UniversalViewer/universalviewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UniversalViewer/universalviewer/statuses/{sha}","languages_url":"https://api.github.com/repos/UniversalViewer/universalviewer/languages","stargazers_url":"https://api.github.com/repos/UniversalViewer/universalviewer/stargazers","contributors_url":"https://api.github.com/repos/UniversalViewer/universalviewer/contributors","subscribers_url":"https://api.github.com/repos/UniversalViewer/universalviewer/subscribers","subscription_url":"https://api.github.com/repos/UniversalViewer/universalviewer/subscription","commits_url":"https://api.github.com/repos/UniversalViewer/universalviewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/UniversalViewer/universalviewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/UniversalViewer/universalviewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/UniversalViewer/universalviewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/UniversalViewer/universalviewer/contents/{+path}","compare_url":"https://api.github.com/repos/UniversalViewer/universalviewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UniversalViewer/universalviewer/merges","archive_url":"https://api.github.com/repos/UniversalViewer/universalviewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UniversalViewer/universalviewer/downloads","issues_url":"https://api.github.com/repos/UniversalViewer/universalviewer/issues{/number}","pulls_url":"https://api.github.com/repos/UniversalViewer/universalviewer/pulls{/number}","milestones_url":"https://api.github.com/repos/UniversalViewer/universalviewer/milestones{/number}","notifications_url":"https://api.github.com/repos/UniversalViewer/universalviewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UniversalViewer/universalviewer/labels{/name}","releases_url":"https://api.github.com/repos/UniversalViewer/universalviewer/releases{/id}","created_at":"2015-02-09T22:19:19Z","updated_at":"2015-06-25T11:13:55Z","pushed_at":"2015-06-26T16:04:10Z","git_url":"git://github.com/UniversalViewer/universalviewer.git","ssh_url":"git@github.com:UniversalViewer/universalviewer.git","clone_url":"https://github.com/UniversalViewer/universalviewer.git","svn_url":"https://github.com/UniversalViewer/universalviewer","homepage":"","size":6482,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":25,"forks":5,"open_issues":25,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UniversalViewer/universalviewer/pulls/95"},"html":{"href":"https://github.com/UniversalViewer/universalviewer/pull/95"},"issue":{"href":"https://api.github.com/repos/UniversalViewer/universalviewer/issues/95"},"comments":{"href":"https://api.github.com/repos/UniversalViewer/universalviewer/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/UniversalViewer/universalviewer/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/UniversalViewer/universalviewer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UniversalViewer/universalviewer/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/UniversalViewer/universalviewer/statuses/2cb2838b09267edc0fa817a3ac4f2e97c9ea90ec"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"edsilv","id":1334393,"avatar_url":"https://avatars.githubusercontent.com/u/1334393?v=3","gravatar_id":"","url":"https://api.github.com/users/edsilv","html_url":"https://github.com/edsilv","followers_url":"https://api.github.com/users/edsilv/followers","following_url":"https://api.github.com/users/edsilv/following{/other_user}","gists_url":"https://api.github.com/users/edsilv/gists{/gist_id}","starred_url":"https://api.github.com/users/edsilv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsilv/subscriptions","organizations_url":"https://api.github.com/users/edsilv/orgs","repos_url":"https://api.github.com/users/edsilv/repos","events_url":"https://api.github.com/users/edsilv/events{/privacy}","received_events_url":"https://api.github.com/users/edsilv/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":27,"deletions":19,"changed_files":11}}