{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/24285626","id":24285626,"diff_hunk":"@@ -359,7 +359,7 @@ static CFStringRef CFStringCreateMacFormattedLocaleName(LPCWSTR lpLocaleName)\n         return NULL;\n     }\n \n-    CFStringAppendCharacters(cfMutableLocaleName, lpLocaleName, PAL_wcslen(lpLocaleName));\n+    CFStringAppendCharacters(cfMutableLocaleName, (const UniChar*)lpLocaleName, PAL_wcslen(lpLocaleName));","path":"src/pal/src/locale/locale.cpp","position":5,"original_position":5,"commit_id":"d2888133afb5eb7790a2030fbef3bd9137d3d97e","original_commit_id":"d2888133afb5eb7790a2030fbef3bd9137d3d97e","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"Could you please create UniChar * ToUniChar(WCHAR * ) helper method (or operator) and use it instead of the hard casts, so that we still get the types checked by the compiler?","created_at":"2015-02-07T02:14:26Z","updated_at":"2015-02-07T02:14:26Z","html_url":"https://github.com/dotnet/coreclr/pull/117#discussion_r24285626","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/117","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/24285626"},"html":{"href":"https://github.com/dotnet/coreclr/pull/117#discussion_r24285626"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/117","id":28853908,"html_url":"https://github.com/dotnet/coreclr/pull/117","diff_url":"https://github.com/dotnet/coreclr/pull/117.diff","patch_url":"https://github.com/dotnet/coreclr/pull/117.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/117","number":117,"state":"open","locked":false,"title":"Initial Mac OSX Support","user":{"login":"kangaroo","id":151532,"avatar_url":"https://avatars.githubusercontent.com/u/151532?v=3","gravatar_id":"","url":"https://api.github.com/users/kangaroo","html_url":"https://github.com/kangaroo","followers_url":"https://api.github.com/users/kangaroo/followers","following_url":"https://api.github.com/users/kangaroo/following{/other_user}","gists_url":"https://api.github.com/users/kangaroo/gists{/gist_id}","starred_url":"https://api.github.com/users/kangaroo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kangaroo/subscriptions","organizations_url":"https://api.github.com/users/kangaroo/orgs","repos_url":"https://api.github.com/users/kangaroo/repos","events_url":"https://api.github.com/users/kangaroo/events{/privacy}","received_events_url":"https://api.github.com/users/kangaroo/received_events","type":"User","site_admin":false},"body":"Supports building up the VM, PAL and various components on Mac OSX 10.10\r\nThere are some oddities with the Apple assembler not generating short jumps\r\nand not supporting 1 byte relocs.\r\n\r\nThis is a continuation of https://github.com/dotnet/coreclr/pull/105 since GitHub cannot detect my new squashed commit.","created_at":"2015-02-07T00:30:11Z","updated_at":"2015-02-07T02:14:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f95a5bf9c3020b7f1c178c35f35190adfcb8772","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/117/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/117/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/117/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/d2888133afb5eb7790a2030fbef3bd9137d3d97e","head":{"label":"kangaroo:osx","ref":"osx","sha":"d2888133afb5eb7790a2030fbef3bd9137d3d97e","user":{"login":"kangaroo","id":151532,"avatar_url":"https://avatars.githubusercontent.com/u/151532?v=3","gravatar_id":"","url":"https://api.github.com/users/kangaroo","html_url":"https://github.com/kangaroo","followers_url":"https://api.github.com/users/kangaroo/followers","following_url":"https://api.github.com/users/kangaroo/following{/other_user}","gists_url":"https://api.github.com/users/kangaroo/gists{/gist_id}","starred_url":"https://api.github.com/users/kangaroo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kangaroo/subscriptions","organizations_url":"https://api.github.com/users/kangaroo/orgs","repos_url":"https://api.github.com/users/kangaroo/repos","events_url":"https://api.github.com/users/kangaroo/events{/privacy}","received_events_url":"https://api.github.com/users/kangaroo/received_events","type":"User","site_admin":false},"repo":{"id":30268501,"name":"coreclr","full_name":"kangaroo/coreclr","owner":{"login":"kangaroo","id":151532,"avatar_url":"https://avatars.githubusercontent.com/u/151532?v=3","gravatar_id":"","url":"https://api.github.com/users/kangaroo","html_url":"https://github.com/kangaroo","followers_url":"https://api.github.com/users/kangaroo/followers","following_url":"https://api.github.com/users/kangaroo/following{/other_user}","gists_url":"https://api.github.com/users/kangaroo/gists{/gist_id}","starred_url":"https://api.github.com/users/kangaroo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kangaroo/subscriptions","organizations_url":"https://api.github.com/users/kangaroo/orgs","repos_url":"https://api.github.com/users/kangaroo/repos","events_url":"https://api.github.com/users/kangaroo/events{/privacy}","received_events_url":"https://api.github.com/users/kangaroo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kangaroo/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/kangaroo/coreclr","forks_url":"https://api.github.com/repos/kangaroo/coreclr/forks","keys_url":"https://api.github.com/repos/kangaroo/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kangaroo/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kangaroo/coreclr/teams","hooks_url":"https://api.github.com/repos/kangaroo/coreclr/hooks","issue_events_url":"https://api.github.com/repos/kangaroo/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/kangaroo/coreclr/events","assignees_url":"https://api.github.com/repos/kangaroo/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/kangaroo/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/kangaroo/coreclr/tags","blobs_url":"https://api.github.com/repos/kangaroo/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kangaroo/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kangaroo/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/kangaroo/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kangaroo/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/kangaroo/coreclr/languages","stargazers_url":"https://api.github.com/repos/kangaroo/coreclr/stargazers","contributors_url":"https://api.github.com/repos/kangaroo/coreclr/contributors","subscribers_url":"https://api.github.com/repos/kangaroo/coreclr/subscribers","subscription_url":"https://api.github.com/repos/kangaroo/coreclr/subscription","commits_url":"https://api.github.com/repos/kangaroo/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/kangaroo/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/kangaroo/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/kangaroo/coreclr/issues/comments/{number}","contents_url":"https://api.github.com/repos/kangaroo/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/kangaroo/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kangaroo/coreclr/merges","archive_url":"https://api.github.com/repos/kangaroo/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kangaroo/coreclr/downloads","issues_url":"https://api.github.com/repos/kangaroo/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/kangaroo/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/kangaroo/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/kangaroo/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kangaroo/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/kangaroo/coreclr/releases{/id}","created_at":"2015-02-03T22:39:58Z","updated_at":"2015-02-03T22:40:17Z","pushed_at":"2015-02-07T01:09:35Z","git_url":"git://github.com/kangaroo/coreclr.git","ssh_url":"git@github.com:kangaroo/coreclr.git","clone_url":"https://github.com/kangaroo/coreclr.git","svn_url":"https://github.com/kangaroo/coreclr","homepage":"","size":25215,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"a85beebc633d373bf3df4241ce7f86d76d7690ec","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/{number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","created_at":"2015-01-30T22:10:02Z","updated_at":"2015-02-07T01:54:25Z","pushed_at":"2015-02-06T23:14:48Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"","size":27204,"stargazers_count":2849,"watchers_count":2849,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":409,"mirror_url":null,"open_issues_count":33,"forks":409,"open_issues":33,"watchers":2849,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/117"},"html":{"href":"https://github.com/dotnet/coreclr/pull/117"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/117"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/d2888133afb5eb7790a2030fbef3bd9137d3d97e"}}}}