{"action":"created","issue":{"url":"https://api.github.com/repos/winstonjs/winston/issues/703","labels_url":"https://api.github.com/repos/winstonjs/winston/issues/703/labels{/name}","comments_url":"https://api.github.com/repos/winstonjs/winston/issues/703/comments","events_url":"https://api.github.com/repos/winstonjs/winston/issues/703/events","html_url":"https://github.com/winstonjs/winston/pull/703","id":104345089,"number":703,"title":"Do not modify Error or Date objects when logging. Fixes #610","user":{"login":"harriha","id":101693,"avatar_url":"https://avatars.githubusercontent.com/u/101693?v=3","gravatar_id":"","url":"https://api.github.com/users/harriha","html_url":"https://github.com/harriha","followers_url":"https://api.github.com/users/harriha/followers","following_url":"https://api.github.com/users/harriha/following{/other_user}","gists_url":"https://api.github.com/users/harriha/gists{/gist_id}","starred_url":"https://api.github.com/users/harriha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harriha/subscriptions","organizations_url":"https://api.github.com/users/harriha/orgs","repos_url":"https://api.github.com/users/harriha/repos","events_url":"https://api.github.com/users/harriha/events{/privacy}","received_events_url":"https://api.github.com/users/harriha/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/winstonjs/winston/labels/needs-investigation","name":"needs-investigation","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-01T20:13:40Z","updated_at":"2015-10-09T14:19:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/winstonjs/winston/pulls/703","html_url":"https://github.com/winstonjs/winston/pull/703","diff_url":"https://github.com/winstonjs/winston/pull/703.diff","patch_url":"https://github.com/winstonjs/winston/pull/703.patch"},"body":"Hi,\r\n\r\nEnded up taking a stab on this issue, but not 100% sure if this is the best way to do it (and is this all) since I'm not that familiar with this lib - review welcome, luckily there's not much changes.\r\n\r\nMy concerns/notes:\r\n\r\n- I'm on Windows, where a bunch of tests fails locally, but I'm sure travis will tell if things are ok or not\r\n- Are there perf concerns here in some envs since now creating new `Error`/`Date` objects - probably not a real issue\r\n- Are tests in logical places and as good as they can be (not familiar with vows previously either)\r\n\r\nThe fact that these types of objects were returned as-is from `clone()` in the first place puzzles me a bit, wonder if there was something non-obvious behind that approach.\r\n\r\nIn case there's something to fix, please let me know.\r\n"},"comment":{"url":"https://api.github.com/repos/winstonjs/winston/issues/comments/146884686","html_url":"https://github.com/winstonjs/winston/pull/703#issuecomment-146884686","issue_url":"https://api.github.com/repos/winstonjs/winston/issues/703","id":146884686,"user":{"login":"indexzero","id":4624,"avatar_url":"https://avatars.githubusercontent.com/u/4624?v=3","gravatar_id":"","url":"https://api.github.com/users/indexzero","html_url":"https://github.com/indexzero","followers_url":"https://api.github.com/users/indexzero/followers","following_url":"https://api.github.com/users/indexzero/following{/other_user}","gists_url":"https://api.github.com/users/indexzero/gists{/gist_id}","starred_url":"https://api.github.com/users/indexzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indexzero/subscriptions","organizations_url":"https://api.github.com/users/indexzero/orgs","repos_url":"https://api.github.com/users/indexzero/repos","events_url":"https://api.github.com/users/indexzero/events{/privacy}","received_events_url":"https://api.github.com/users/indexzero/received_events","type":"User","site_admin":false},"created_at":"2015-10-09T14:19:53Z","updated_at":"2015-10-09T14:19:53Z","body":"Thank you for your contribution. The inner working of `clone` is going to change significantly in `winston@3.0.0`, but this may land in the `2.x` branch."}}