{"action":"created","issue":{"url":"https://api.github.com/repos/transientskp/tkp/issues/421","labels_url":"https://api.github.com/repos/transientskp/tkp/issues/421/labels{/name}","comments_url":"https://api.github.com/repos/transientskp/tkp/issues/421/comments","events_url":"https://api.github.com/repos/transientskp/tkp/issues/421/events","html_url":"https://github.com/transientskp/tkp/issues/421","id":84361214,"number":421,"title":"Source Association Problem","user":{"login":"AntoniaR","id":1759492,"avatar_url":"https://avatars.githubusercontent.com/u/1759492?v=3","gravatar_id":"","url":"https://api.github.com/users/AntoniaR","html_url":"https://github.com/AntoniaR","followers_url":"https://api.github.com/users/AntoniaR/followers","following_url":"https://api.github.com/users/AntoniaR/following{/other_user}","gists_url":"https://api.github.com/users/AntoniaR/gists{/gist_id}","starred_url":"https://api.github.com/users/AntoniaR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntoniaR/subscriptions","organizations_url":"https://api.github.com/users/AntoniaR/orgs","repos_url":"https://api.github.com/users/AntoniaR/repos","events_url":"https://api.github.com/users/AntoniaR/events{/privacy}","received_events_url":"https://api.github.com/users/AntoniaR/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/transientskp/tkp/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/transientskp/tkp/labels/priority%20high","name":"priority high","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"bartscheers","id":1759451,"avatar_url":"https://avatars.githubusercontent.com/u/1759451?v=3","gravatar_id":"","url":"https://api.github.com/users/bartscheers","html_url":"https://github.com/bartscheers","followers_url":"https://api.github.com/users/bartscheers/followers","following_url":"https://api.github.com/users/bartscheers/following{/other_user}","gists_url":"https://api.github.com/users/bartscheers/gists{/gist_id}","starred_url":"https://api.github.com/users/bartscheers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartscheers/subscriptions","organizations_url":"https://api.github.com/users/bartscheers/orgs","repos_url":"https://api.github.com/users/bartscheers/repos","events_url":"https://api.github.com/users/bartscheers/events{/privacy}","received_events_url":"https://api.github.com/users/bartscheers/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/transientskp/tkp/milestones/7","html_url":"https://github.com/transientskp/tkp/milestones/Release%202.0","labels_url":"https://api.github.com/repos/transientskp/tkp/milestones/7/labels","id":1146414,"number":7,"title":"Release 2.0","description":null,"creator":{"login":"AntoniaR","id":1759492,"avatar_url":"https://avatars.githubusercontent.com/u/1759492?v=3","gravatar_id":"","url":"https://api.github.com/users/AntoniaR","html_url":"https://github.com/AntoniaR","followers_url":"https://api.github.com/users/AntoniaR/followers","following_url":"https://api.github.com/users/AntoniaR/following{/other_user}","gists_url":"https://api.github.com/users/AntoniaR/gists{/gist_id}","starred_url":"https://api.github.com/users/AntoniaR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntoniaR/subscriptions","organizations_url":"https://api.github.com/users/AntoniaR/orgs","repos_url":"https://api.github.com/users/AntoniaR/repos","events_url":"https://api.github.com/users/AntoniaR/events{/privacy}","received_events_url":"https://api.github.com/users/AntoniaR/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2015-06-03T03:21:10Z","updated_at":"2015-06-03T04:56:19Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-06-03T04:56:19Z","updated_at":"2015-06-05T09:33:51Z","closed_at":null,"body":"There appears to be a bug in source association in Release 2.0. Sources do not appear to be always associated correctly by Release 2.0 and this is causing major issues with TraP use on large datasets.\r\n\r\nI have identified an example of this in action in one of my datasets. The three sources in this issue should all be the same source (using de Ruiter radius). There is one relatively constant runcat source (multiple detections, id 33589) with two \"new sources\". The two new sources listed below are only detected once each and hence the two runcat positions remain constant after detection. \u0014One of the two new sources is detected when the runcat source 33589 is not blindly detected in the image - so should have been associated. The other, 35391, should be a 1-to-many source association type but this does not seem to be the case in the catalogue.\r\n\r\nThe database details and Banana URLs for the relevant sources have been pasted into HipChat. The de Ruiter radius was set to ~5.6 in the job parameters file.\r\n\r\n- Runcat source, 33589, detected 468 times. Position (354.039°, -26.551°) ± (28.941″, 25.889″)\r\n\r\n- Runcat source, 34809, detected once in image 12060 (33589 was not detected). Position (353.942°, -26.554°) ± (626.074″, 560.032″). de Ruiter radius from source 33589 (calculated manually) 0.55751549. Expected to have been a 1-to-1 association with 33589.\r\n\r\n- Runcat source, 35391, detected once in image 12381 (33589 was detected in same image). Position (353.897°, -26.559°) ± (626.173″, 560.095″). de Ruiter radius from source 33589 (calculated manually) 0.817202247. Expected to have been a 1-to-many association with 33589, but does not appear to be recorded as such in the assocxtrsource table.\r\n\r\nThere are 2 faint sources in this region of the image; 1 easily detected - source 33589 - and a probably confusing source a small distance away, likely causing the sources 34809 and 35391. However, the de Ruiter radius calculations show that these sources should be associated (as it doesn't care about the actual image properties, just the source positions and errors).\r\n\r\nWhy were these sources not associated? Caused by the runcat position of 33589 at the time of source association step (I think unlikely due to the big systematic error inserted in the job parameters to force the association) or a bug in the code?"},"comment":{"url":"https://api.github.com/repos/transientskp/tkp/issues/comments/109217405","html_url":"https://github.com/transientskp/tkp/issues/421#issuecomment-109217405","issue_url":"https://api.github.com/repos/transientskp/tkp/issues/421","id":109217405,"user":{"login":"bartscheers","id":1759451,"avatar_url":"https://avatars.githubusercontent.com/u/1759451?v=3","gravatar_id":"","url":"https://api.github.com/users/bartscheers","html_url":"https://github.com/bartscheers","followers_url":"https://api.github.com/users/bartscheers/followers","following_url":"https://api.github.com/users/bartscheers/following{/other_user}","gists_url":"https://api.github.com/users/bartscheers/gists{/gist_id}","starred_url":"https://api.github.com/users/bartscheers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartscheers/subscriptions","organizations_url":"https://api.github.com/users/bartscheers/orgs","repos_url":"https://api.github.com/users/bartscheers/repos","events_url":"https://api.github.com/users/bartscheers/events{/privacy}","received_events_url":"https://api.github.com/users/bartscheers/received_events","type":"User","site_admin":false},"created_at":"2015-06-05T09:33:51Z","updated_at":"2015-06-05T09:33:51Z","body":"I pushed the changes to branch prob421 in my fork: https://github.com/bartscheers/tkp/tree/prob421, but did not send a pull request.\r\nYou can pull it from there to where you want. Let me know if I need to do anything more."}}