{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4645","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4645/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4645/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4645/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4645","id":71938088,"number":4645,"title":"[MRG+1] Astype fix","user":{"login":"TomDLT","id":11065596,"avatar_url":"https://avatars.githubusercontent.com/u/11065596?v=3","gravatar_id":"","url":"https://api.github.com/users/TomDLT","html_url":"https://github.com/TomDLT","followers_url":"https://api.github.com/users/TomDLT/followers","following_url":"https://api.github.com/users/TomDLT/following{/other_user}","gists_url":"https://api.github.com/users/TomDLT/gists{/gist_id}","starred_url":"https://api.github.com/users/TomDLT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomDLT/subscriptions","organizations_url":"https://api.github.com/users/TomDLT/orgs","repos_url":"https://api.github.com/users/TomDLT/repos","events_url":"https://api.github.com/users/TomDLT/events{/privacy}","received_events_url":"https://api.github.com/users/TomDLT/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":23,"created_at":"2015-04-29T17:32:23Z","updated_at":"2015-05-07T16:34:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4645","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4645","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/4645.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/4645.patch"},"body":"I extended `check_array` to add support for `accept_sparse=True`\r\nand solve the 3 errors by changing `astype` into `check_array` when sparse matrix are possible\r\n\r\nI will check the other uses of `astype` tomorrow.\r\n\r\nTODO:\r\n\r\n- [x] fix the test error\r\n- [x] finish changing astype to check_array, when we may have a sparse matrix\r\n- [x] clean some remaining usage of warn_if_not_float to use check_array instead"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/99931528","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4645#issuecomment-99931528","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4645","id":99931528,"user":{"login":"ogrisel","id":89061,"avatar_url":"https://avatars.githubusercontent.com/u/89061?v=3","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T16:34:19Z","updated_at":"2015-05-07T16:34:19Z","body":"Maybe we should deprecate `warn_if_not_float` instead of removing it. I know those utilities are not supposed to be part of the public API but... Any opinion @amueller ?"}}