{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/betajs/betajs-dynamics/pulls/10","id":37416687,"html_url":"https://github.com/betajs/betajs-dynamics/pull/10","diff_url":"https://github.com/betajs/betajs-dynamics/pull/10.diff","patch_url":"https://github.com/betajs/betajs-dynamics/pull/10.patch","issue_url":"https://api.github.com/repos/betajs/betajs-dynamics/issues/10","number":10,"state":"closed","locked":false,"title":"Fix overshadowing of events variable.","user":{"login":"mattjmcnaughton","id":3269376,"avatar_url":"https://avatars.githubusercontent.com/u/3269376?v=3","gravatar_id":"","url":"https://api.github.com/users/mattjmcnaughton","html_url":"https://github.com/mattjmcnaughton","followers_url":"https://api.github.com/users/mattjmcnaughton/followers","following_url":"https://api.github.com/users/mattjmcnaughton/following{/other_user}","gists_url":"https://api.github.com/users/mattjmcnaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/mattjmcnaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattjmcnaughton/subscriptions","organizations_url":"https://api.github.com/users/mattjmcnaughton/orgs","repos_url":"https://api.github.com/users/mattjmcnaughton/repos","events_url":"https://api.github.com/users/mattjmcnaughton/events{/privacy}","received_events_url":"https://api.github.com/users/mattjmcnaughton/received_events","type":"User","site_admin":false},"body":"Just for history in case this bug comes back.\r\n\r\nConsider an instance of the `Attr` class\r\nconstructed with a node and an event attribute,\r\nsuch as `onkeyup`. Previously, calling `updateElement` on this instance\r\ninserted the DOM event object into the local mesh with the name `event`.\r\nEven after the event callback finished, the DOM event object remained in the\r\nlocal mesh. As the local mesh has priority, the variable name event\r\ncould not be used in other places.\r\n\r\nThis commit makes two changes to fix this bug.\r\n* Give the DOM event object in the local mesh a more specific name. (`domElement`)\r\n* Return domElement to its initial state after the event callback\r\n  finishes execution.\r\n\r\nAdding a test, `tests/handlers/attr.js`, although the test\r\ndoes not entirely replicate the error. If this\r\nbug continues to be troublesome, this test is a good\r\nstarting point.","created_at":"2015-06-10T23:46:49Z","updated_at":"2015-06-11T01:28:54Z","closed_at":"2015-06-11T01:28:54Z","merged_at":"2015-06-11T01:28:54Z","merge_commit_sha":"0692a88d9e76f315c68531874103b5921e7d57ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/betajs/betajs-dynamics/pulls/10/commits","review_comments_url":"https://api.github.com/repos/betajs/betajs-dynamics/pulls/10/comments","review_comment_url":"https://api.github.com/repos/betajs/betajs-dynamics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/betajs/betajs-dynamics/issues/10/comments","statuses_url":"https://api.github.com/repos/betajs/betajs-dynamics/statuses/edec9ce11a8d681164aa266921abeb45893fc22a","head":{"label":"betajs:matt-fix-event-variable-overshadowing","ref":"matt-fix-event-variable-overshadowing","sha":"edec9ce11a8d681164aa266921abeb45893fc22a","user":{"login":"betajs","id":5783641,"avatar_url":"https://avatars.githubusercontent.com/u/5783641?v=3","gravatar_id":"","url":"https://api.github.com/users/betajs","html_url":"https://github.com/betajs","followers_url":"https://api.github.com/users/betajs/followers","following_url":"https://api.github.com/users/betajs/following{/other_user}","gists_url":"https://api.github.com/users/betajs/gists{/gist_id}","starred_url":"https://api.github.com/users/betajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betajs/subscriptions","organizations_url":"https://api.github.com/users/betajs/orgs","repos_url":"https://api.github.com/users/betajs/repos","events_url":"https://api.github.com/users/betajs/events{/privacy}","received_events_url":"https://api.github.com/users/betajs/received_events","type":"Organization","site_admin":false},"repo":{"id":28966084,"name":"betajs-dynamics","full_name":"betajs/betajs-dynamics","owner":{"login":"betajs","id":5783641,"avatar_url":"https://avatars.githubusercontent.com/u/5783641?v=3","gravatar_id":"","url":"https://api.github.com/users/betajs","html_url":"https://github.com/betajs","followers_url":"https://api.github.com/users/betajs/followers","following_url":"https://api.github.com/users/betajs/following{/other_user}","gists_url":"https://api.github.com/users/betajs/gists{/gist_id}","starred_url":"https://api.github.com/users/betajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betajs/subscriptions","organizations_url":"https://api.github.com/users/betajs/orgs","repos_url":"https://api.github.com/users/betajs/repos","events_url":"https://api.github.com/users/betajs/events{/privacy}","received_events_url":"https://api.github.com/users/betajs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/betajs/betajs-dynamics","description":"BetaJS-Dynamics is a dynamic dom templating engine.","fork":false,"url":"https://api.github.com/repos/betajs/betajs-dynamics","forks_url":"https://api.github.com/repos/betajs/betajs-dynamics/forks","keys_url":"https://api.github.com/repos/betajs/betajs-dynamics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betajs/betajs-dynamics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betajs/betajs-dynamics/teams","hooks_url":"https://api.github.com/repos/betajs/betajs-dynamics/hooks","issue_events_url":"https://api.github.com/repos/betajs/betajs-dynamics/issues/events{/number}","events_url":"https://api.github.com/repos/betajs/betajs-dynamics/events","assignees_url":"https://api.github.com/repos/betajs/betajs-dynamics/assignees{/user}","branches_url":"https://api.github.com/repos/betajs/betajs-dynamics/branches{/branch}","tags_url":"https://api.github.com/repos/betajs/betajs-dynamics/tags","blobs_url":"https://api.github.com/repos/betajs/betajs-dynamics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betajs/betajs-dynamics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betajs/betajs-dynamics/git/refs{/sha}","trees_url":"https://api.github.com/repos/betajs/betajs-dynamics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betajs/betajs-dynamics/statuses/{sha}","languages_url":"https://api.github.com/repos/betajs/betajs-dynamics/languages","stargazers_url":"https://api.github.com/repos/betajs/betajs-dynamics/stargazers","contributors_url":"https://api.github.com/repos/betajs/betajs-dynamics/contributors","subscribers_url":"https://api.github.com/repos/betajs/betajs-dynamics/subscribers","subscription_url":"https://api.github.com/repos/betajs/betajs-dynamics/subscription","commits_url":"https://api.github.com/repos/betajs/betajs-dynamics/commits{/sha}","git_commits_url":"https://api.github.com/repos/betajs/betajs-dynamics/git/commits{/sha}","comments_url":"https://api.github.com/repos/betajs/betajs-dynamics/comments{/number}","issue_comment_url":"https://api.github.com/repos/betajs/betajs-dynamics/issues/comments{/number}","contents_url":"https://api.github.com/repos/betajs/betajs-dynamics/contents/{+path}","compare_url":"https://api.github.com/repos/betajs/betajs-dynamics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betajs/betajs-dynamics/merges","archive_url":"https://api.github.com/repos/betajs/betajs-dynamics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betajs/betajs-dynamics/downloads","issues_url":"https://api.github.com/repos/betajs/betajs-dynamics/issues{/number}","pulls_url":"https://api.github.com/repos/betajs/betajs-dynamics/pulls{/number}","milestones_url":"https://api.github.com/repos/betajs/betajs-dynamics/milestones{/number}","notifications_url":"https://api.github.com/repos/betajs/betajs-dynamics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betajs/betajs-dynamics/labels{/name}","releases_url":"https://api.github.com/repos/betajs/betajs-dynamics/releases{/id}","created_at":"2015-01-08T13:00:52Z","updated_at":"2015-05-07T22:43:50Z","pushed_at":"2015-06-11T01:28:54Z","git_url":"git://github.com/betajs/betajs-dynamics.git","ssh_url":"git@github.com:betajs/betajs-dynamics.git","clone_url":"https://github.com/betajs/betajs-dynamics.git","svn_url":"https://github.com/betajs/betajs-dynamics","homepage":null,"size":916,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"betajs:master","ref":"master","sha":"10935d99c63ef366df0ae3819b422453d0fcc4e5","user":{"login":"betajs","id":5783641,"avatar_url":"https://avatars.githubusercontent.com/u/5783641?v=3","gravatar_id":"","url":"https://api.github.com/users/betajs","html_url":"https://github.com/betajs","followers_url":"https://api.github.com/users/betajs/followers","following_url":"https://api.github.com/users/betajs/following{/other_user}","gists_url":"https://api.github.com/users/betajs/gists{/gist_id}","starred_url":"https://api.github.com/users/betajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betajs/subscriptions","organizations_url":"https://api.github.com/users/betajs/orgs","repos_url":"https://api.github.com/users/betajs/repos","events_url":"https://api.github.com/users/betajs/events{/privacy}","received_events_url":"https://api.github.com/users/betajs/received_events","type":"Organization","site_admin":false},"repo":{"id":28966084,"name":"betajs-dynamics","full_name":"betajs/betajs-dynamics","owner":{"login":"betajs","id":5783641,"avatar_url":"https://avatars.githubusercontent.com/u/5783641?v=3","gravatar_id":"","url":"https://api.github.com/users/betajs","html_url":"https://github.com/betajs","followers_url":"https://api.github.com/users/betajs/followers","following_url":"https://api.github.com/users/betajs/following{/other_user}","gists_url":"https://api.github.com/users/betajs/gists{/gist_id}","starred_url":"https://api.github.com/users/betajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betajs/subscriptions","organizations_url":"https://api.github.com/users/betajs/orgs","repos_url":"https://api.github.com/users/betajs/repos","events_url":"https://api.github.com/users/betajs/events{/privacy}","received_events_url":"https://api.github.com/users/betajs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/betajs/betajs-dynamics","description":"BetaJS-Dynamics is a dynamic dom templating engine.","fork":false,"url":"https://api.github.com/repos/betajs/betajs-dynamics","forks_url":"https://api.github.com/repos/betajs/betajs-dynamics/forks","keys_url":"https://api.github.com/repos/betajs/betajs-dynamics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betajs/betajs-dynamics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betajs/betajs-dynamics/teams","hooks_url":"https://api.github.com/repos/betajs/betajs-dynamics/hooks","issue_events_url":"https://api.github.com/repos/betajs/betajs-dynamics/issues/events{/number}","events_url":"https://api.github.com/repos/betajs/betajs-dynamics/events","assignees_url":"https://api.github.com/repos/betajs/betajs-dynamics/assignees{/user}","branches_url":"https://api.github.com/repos/betajs/betajs-dynamics/branches{/branch}","tags_url":"https://api.github.com/repos/betajs/betajs-dynamics/tags","blobs_url":"https://api.github.com/repos/betajs/betajs-dynamics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betajs/betajs-dynamics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betajs/betajs-dynamics/git/refs{/sha}","trees_url":"https://api.github.com/repos/betajs/betajs-dynamics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betajs/betajs-dynamics/statuses/{sha}","languages_url":"https://api.github.com/repos/betajs/betajs-dynamics/languages","stargazers_url":"https://api.github.com/repos/betajs/betajs-dynamics/stargazers","contributors_url":"https://api.github.com/repos/betajs/betajs-dynamics/contributors","subscribers_url":"https://api.github.com/repos/betajs/betajs-dynamics/subscribers","subscription_url":"https://api.github.com/repos/betajs/betajs-dynamics/subscription","commits_url":"https://api.github.com/repos/betajs/betajs-dynamics/commits{/sha}","git_commits_url":"https://api.github.com/repos/betajs/betajs-dynamics/git/commits{/sha}","comments_url":"https://api.github.com/repos/betajs/betajs-dynamics/comments{/number}","issue_comment_url":"https://api.github.com/repos/betajs/betajs-dynamics/issues/comments{/number}","contents_url":"https://api.github.com/repos/betajs/betajs-dynamics/contents/{+path}","compare_url":"https://api.github.com/repos/betajs/betajs-dynamics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betajs/betajs-dynamics/merges","archive_url":"https://api.github.com/repos/betajs/betajs-dynamics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betajs/betajs-dynamics/downloads","issues_url":"https://api.github.com/repos/betajs/betajs-dynamics/issues{/number}","pulls_url":"https://api.github.com/repos/betajs/betajs-dynamics/pulls{/number}","milestones_url":"https://api.github.com/repos/betajs/betajs-dynamics/milestones{/number}","notifications_url":"https://api.github.com/repos/betajs/betajs-dynamics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betajs/betajs-dynamics/labels{/name}","releases_url":"https://api.github.com/repos/betajs/betajs-dynamics/releases{/id}","created_at":"2015-01-08T13:00:52Z","updated_at":"2015-05-07T22:43:50Z","pushed_at":"2015-06-11T01:28:54Z","git_url":"git://github.com/betajs/betajs-dynamics.git","ssh_url":"git@github.com:betajs/betajs-dynamics.git","clone_url":"https://github.com/betajs/betajs-dynamics.git","svn_url":"https://github.com/betajs/betajs-dynamics","homepage":null,"size":916,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/betajs/betajs-dynamics/pulls/10"},"html":{"href":"https://github.com/betajs/betajs-dynamics/pull/10"},"issue":{"href":"https://api.github.com/repos/betajs/betajs-dynamics/issues/10"},"comments":{"href":"https://api.github.com/repos/betajs/betajs-dynamics/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/betajs/betajs-dynamics/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/betajs/betajs-dynamics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/betajs/betajs-dynamics/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/betajs/betajs-dynamics/statuses/edec9ce11a8d681164aa266921abeb45893fc22a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"oliverfriedmann","id":1974785,"avatar_url":"https://avatars.githubusercontent.com/u/1974785?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverfriedmann","html_url":"https://github.com/oliverfriedmann","followers_url":"https://api.github.com/users/oliverfriedmann/followers","following_url":"https://api.github.com/users/oliverfriedmann/following{/other_user}","gists_url":"https://api.github.com/users/oliverfriedmann/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverfriedmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverfriedmann/subscriptions","organizations_url":"https://api.github.com/users/oliverfriedmann/orgs","repos_url":"https://api.github.com/users/oliverfriedmann/repos","events_url":"https://api.github.com/users/oliverfriedmann/events{/privacy}","received_events_url":"https://api.github.com/users/oliverfriedmann/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":58,"deletions":14,"changed_files":7}}