{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/9117","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9117/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9117/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9117/events","html_url":"https://github.com/cms-sw/cmssw/pull/9117","id":77004672,"number":9117,"title":"New MET correction/uncertainty tool","user":{"login":"mmarionncern","id":5114248,"avatar_url":"https://avatars.githubusercontent.com/u/5114248?v=3","gravatar_id":"","url":"https://api.github.com/users/mmarionncern","html_url":"https://github.com/mmarionncern","followers_url":"https://api.github.com/users/mmarionncern/followers","following_url":"https://api.github.com/users/mmarionncern/following{/other_user}","gists_url":"https://api.github.com/users/mmarionncern/gists{/gist_id}","starred_url":"https://api.github.com/users/mmarionncern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmarionncern/subscriptions","organizations_url":"https://api.github.com/users/mmarionncern/orgs","repos_url":"https://api.github.com/users/mmarionncern/repos","events_url":"https://api.github.com/users/mmarionncern/events{/privacy}","received_events_url":"https://api.github.com/users/mmarionncern/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-rejected","name":"tests-rejected","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_5_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51/labels","id":982516,"number":51,"title":"Next CMSSW_7_5_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":57,"closed_issues":922,"state":"open","created_at":"2015-02-17T08:21:25Z","updated_at":"2015-06-19T02:41:59Z","due_on":"2015-05-31T22:00:00Z","closed_at":null},"comments":19,"created_at":"2015-05-16T10:25:36Z","updated_at":"2015-06-19T06:43:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/9117","html_url":"https://github.com/cms-sw/cmssw/pull/9117","diff_url":"https://github.com/cms-sw/cmssw/pull/9117.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/9117.patch"},"body":"This PR contains the new MET correction and uncertainty tool. It can be used for both miniAOD production and MET reprocessing on top of miniAOD.\r\nNew features :\r\n- new pat::MET format,, takes benefit of the additional MET properties (for both corrections and uncertainties)\r\n- 74X backward compatibility, the pat::MET format is able to read the 74X MET format and reprocess the 74X MET in 75X with e.g. new JEC. The 74X pat::MET content is empty with a 75X production.\r\n- ME phi correction new code implemented, corrections are stored in pat::MET and can be reprocessed on top of the miniAOD\r\n- type0 MET correction stored\r\n- smeared MET correction stored (not up to date! still 8 TeV smearing, kept for experts)\r\n- preparation for storage of the MET significance in miniAOD (currently not enabled per default)\r\n- Type2 MET discarded, not supported for an analysis use\r\n- added warning when negative JEC corrections are used in Type1MET computation\r\n\r\nExpected changes in performances : \r\n- size of pat::MET should be smaller than before (less uncertainty variables stored)\r\n- no change in MET contents, physics observables are the same\r\n- could be a bit faster than the previous tool (less modules called), but not checked\r\n\r\nPackages changed : \r\n- DataFormats/PatCandidates\r\n- JetMETCorrections/Type1MET\r\n- PhysicsTools/PatAlgos\r\n- PhysicsTools/PatUtils\r\n\r\n@arizzi @gpetruc, you may want to check the performances on miniAODs, let me know if you request modifications or extra checks\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/113395760","html_url":"https://github.com/cms-sw/cmssw/pull/9117#issuecomment-113395760","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9117","id":113395760,"user":{"login":"mmarionncern","id":5114248,"avatar_url":"https://avatars.githubusercontent.com/u/5114248?v=3","gravatar_id":"","url":"https://api.github.com/users/mmarionncern","html_url":"https://github.com/mmarionncern","followers_url":"https://api.github.com/users/mmarionncern/followers","following_url":"https://api.github.com/users/mmarionncern/following{/other_user}","gists_url":"https://api.github.com/users/mmarionncern/gists{/gist_id}","starred_url":"https://api.github.com/users/mmarionncern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmarionncern/subscriptions","organizations_url":"https://api.github.com/users/mmarionncern/orgs","repos_url":"https://api.github.com/users/mmarionncern/repos","events_url":"https://api.github.com/users/mmarionncern/events{/privacy}","received_events_url":"https://api.github.com/users/mmarionncern/received_events","type":"User","site_admin":false},"created_at":"2015-06-19T06:43:13Z","updated_at":"2015-06-19T06:43:13Z","body":"The error in the test refers to : \r\n---- Begin Fatal Exception 18-Jun-2015 17:55:58 CEST-----------------------\r\nAn exception of category 'ConfigFileReadError' occurred while\r\n   [0] Processing the python configuration file named /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-06-18-1100/src/JetMETCorrections/Type1MET/test/corrMET_pfMet_cfg.py\r\nException Message:\r\npython encountered the error: <type 'exceptions.KeyError'>\r\n'mongo_query'\r\n----- End Fatal Exception -------------------------------------------------\r\nFailure using corrMET_pfMet_cfg.py: status 90\r\nstatus = 23040\r\n\r\nAnd the matrix test failed due to issue of DAS access.\r\n\r\nNot sure what the first error means, and the matrix tests did not failed due to the PR.\r\n"}}