{"action":"created","comment":{"url":"https://api.github.com/repos/pipelinedb/pipelinedb/pulls/comments/39573558","id":39573558,"diff_hunk":"@@ -4170,12 +4170,11 @@ Datum\n timestamptz_floor(PG_FUNCTION_ARGS)\n {\n \tTimestampTz timestamp = PG_GETARG_TIMESTAMPTZ(0);\n-\tInterval *span = PG_GETARG_INTERVAL_P(1);\n-\tfsec_t fsec;\n-\tstruct pg_tm i_tm;\n-\tstruct pg_tm ts_tm;\n-\tint tz;\n-\tint nset;\n+\tTimestampTz interval_ts;\n+\n+#ifndef HAVE_INT64_TIMESTAMP","path":"src/backend/utils/adt/timestamp.c","position":12,"original_position":12,"commit_id":"92a9a1ab3f5e30e64a5a90fc1cf633d4a28669cc","original_commit_id":"92a9a1ab3f5e30e64a5a90fc1cf633d4a28669cc","user":{"login":"usmanm","id":853039,"avatar_url":"https://avatars.githubusercontent.com/u/853039?v=3","gravatar_id":"","url":"https://api.github.com/users/usmanm","html_url":"https://github.com/usmanm","followers_url":"https://api.github.com/users/usmanm/followers","following_url":"https://api.github.com/users/usmanm/following{/other_user}","gists_url":"https://api.github.com/users/usmanm/gists{/gist_id}","starred_url":"https://api.github.com/users/usmanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usmanm/subscriptions","organizations_url":"https://api.github.com/users/usmanm/orgs","repos_url":"https://api.github.com/users/usmanm/repos","events_url":"https://api.github.com/users/usmanm/events{/privacy}","received_events_url":"https://api.github.com/users/usmanm/received_events","type":"User","site_admin":false},"body":"Figured this is kosher to do since all modern machines support 64-bit integers. If someone doesn't have them, then they're in bad luck.","created_at":"2015-09-15T22:23:16Z","updated_at":"2015-09-15T22:23:16Z","html_url":"https://github.com/pipelinedb/pipelinedb/pull/1171#discussion_r39573558","pull_request_url":"https://api.github.com/repos/pipelinedb/pipelinedb/pulls/1171","_links":{"self":{"href":"https://api.github.com/repos/pipelinedb/pipelinedb/pulls/comments/39573558"},"html":{"href":"https://github.com/pipelinedb/pipelinedb/pull/1171#discussion_r39573558"},"pull_request":{"href":"https://api.github.com/repos/pipelinedb/pipelinedb/pulls/1171"}}},"pull_request":{"url":"https://api.github.com/repos/pipelinedb/pipelinedb/pulls/1171","id":45110108,"html_url":"https://github.com/pipelinedb/pipelinedb/pull/1171","diff_url":"https://github.com/pipelinedb/pipelinedb/pull/1171.diff","patch_url":"https://github.com/pipelinedb/pipelinedb/pull/1171.patch","issue_url":"https://api.github.com/repos/pipelinedb/pipelinedb/issues/1171","number":1171,"state":"open","locked":false,"title":"date_floor should allow any interval span","user":{"login":"usmanm","id":853039,"avatar_url":"https://avatars.githubusercontent.com/u/853039?v=3","gravatar_id":"","url":"https://api.github.com/users/usmanm","html_url":"https://github.com/usmanm","followers_url":"https://api.github.com/users/usmanm/followers","following_url":"https://api.github.com/users/usmanm/following{/other_user}","gists_url":"https://api.github.com/users/usmanm/gists{/gist_id}","starred_url":"https://api.github.com/users/usmanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usmanm/subscriptions","organizations_url":"https://api.github.com/users/usmanm/orgs","repos_url":"https://api.github.com/users/usmanm/repos","events_url":"https://api.github.com/users/usmanm/events{/privacy}","received_events_url":"https://api.github.com/users/usmanm/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-15T22:22:00Z","updated_at":"2015-09-15T22:23:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d405ced0758f495c8be2526d363fc6da903e54e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pipelinedb/pipelinedb/pulls/1171/commits","review_comments_url":"https://api.github.com/repos/pipelinedb/pipelinedb/pulls/1171/comments","review_comment_url":"https://api.github.com/repos/pipelinedb/pipelinedb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pipelinedb/pipelinedb/issues/1171/comments","statuses_url":"https://api.github.com/repos/pipelinedb/pipelinedb/statuses/92a9a1ab3f5e30e64a5a90fc1cf633d4a28669cc","head":{"label":"pipelinedb:1155-floor","ref":"1155-floor","sha":"92a9a1ab3f5e30e64a5a90fc1cf633d4a28669cc","user":{"login":"pipelinedb","id":5367380,"avatar_url":"https://avatars.githubusercontent.com/u/5367380?v=3","gravatar_id":"","url":"https://api.github.com/users/pipelinedb","html_url":"https://github.com/pipelinedb","followers_url":"https://api.github.com/users/pipelinedb/followers","following_url":"https://api.github.com/users/pipelinedb/following{/other_user}","gists_url":"https://api.github.com/users/pipelinedb/gists{/gist_id}","starred_url":"https://api.github.com/users/pipelinedb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipelinedb/subscriptions","organizations_url":"https://api.github.com/users/pipelinedb/orgs","repos_url":"https://api.github.com/users/pipelinedb/repos","events_url":"https://api.github.com/users/pipelinedb/events{/privacy}","received_events_url":"https://api.github.com/users/pipelinedb/received_events","type":"Organization","site_admin":false},"repo":{"id":14702444,"name":"pipelinedb","full_name":"pipelinedb/pipelinedb","owner":{"login":"pipelinedb","id":5367380,"avatar_url":"https://avatars.githubusercontent.com/u/5367380?v=3","gravatar_id":"","url":"https://api.github.com/users/pipelinedb","html_url":"https://github.com/pipelinedb","followers_url":"https://api.github.com/users/pipelinedb/followers","following_url":"https://api.github.com/users/pipelinedb/following{/other_user}","gists_url":"https://api.github.com/users/pipelinedb/gists{/gist_id}","starred_url":"https://api.github.com/users/pipelinedb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipelinedb/subscriptions","organizations_url":"https://api.github.com/users/pipelinedb/orgs","repos_url":"https://api.github.com/users/pipelinedb/repos","events_url":"https://api.github.com/users/pipelinedb/events{/privacy}","received_events_url":"https://api.github.com/users/pipelinedb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pipelinedb/pipelinedb","description":"The Streaming SQL Database","fork":false,"url":"https://api.github.com/repos/pipelinedb/pipelinedb","forks_url":"https://api.github.com/repos/pipelinedb/pipelinedb/forks","keys_url":"https://api.github.com/repos/pipelinedb/pipelinedb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pipelinedb/pipelinedb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pipelinedb/pipelinedb/teams","hooks_url":"https://api.github.com/repos/pipelinedb/pipelinedb/hooks","issue_events_url":"https://api.github.com/repos/pipelinedb/pipelinedb/issues/events{/number}","events_url":"https://api.github.com/repos/pipelinedb/pipelinedb/events","assignees_url":"https://api.github.com/repos/pipelinedb/pipelinedb/assignees{/user}","branches_url":"https://api.github.com/repos/pipelinedb/pipelinedb/branches{/branch}","tags_url":"https://api.github.com/repos/pipelinedb/pipelinedb/tags","blobs_url":"https://api.github.com/repos/pipelinedb/pipelinedb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pipelinedb/pipelinedb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pipelinedb/pipelinedb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pipelinedb/pipelinedb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pipelinedb/pipelinedb/statuses/{sha}","languages_url":"https://api.github.com/repos/pipelinedb/pipelinedb/languages","stargazers_url":"https://api.github.com/repos/pipelinedb/pipelinedb/stargazers","contributors_url":"https://api.github.com/repos/pipelinedb/pipelinedb/contributors","subscribers_url":"https://api.github.com/repos/pipelinedb/pipelinedb/subscribers","subscription_url":"https://api.github.com/repos/pipelinedb/pipelinedb/subscription","commits_url":"https://api.github.com/repos/pipelinedb/pipelinedb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pipelinedb/pipelinedb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pipelinedb/pipelinedb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pipelinedb/pipelinedb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pipelinedb/pipelinedb/contents/{+path}","compare_url":"https://api.github.com/repos/pipelinedb/pipelinedb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pipelinedb/pipelinedb/merges","archive_url":"https://api.github.com/repos/pipelinedb/pipelinedb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pipelinedb/pipelinedb/downloads","issues_url":"https://api.github.com/repos/pipelinedb/pipelinedb/issues{/number}","pulls_url":"https://api.github.com/repos/pipelinedb/pipelinedb/pulls{/number}","milestones_url":"https://api.github.com/repos/pipelinedb/pipelinedb/milestones{/number}","notifications_url":"https://api.github.com/repos/pipelinedb/pipelinedb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pipelinedb/pipelinedb/labels{/name}","releases_url":"https://api.github.com/repos/pipelinedb/pipelinedb/releases{/id}","created_at":"2013-11-26T00:11:48Z","updated_at":"2015-09-15T13:58:36Z","pushed_at":"2015-09-15T22:22:01Z","git_url":"git://github.com/pipelinedb/pipelinedb.git","ssh_url":"git@github.com:pipelinedb/pipelinedb.git","clone_url":"https://github.com/pipelinedb/pipelinedb.git","svn_url":"https://github.com/pipelinedb/pipelinedb","homepage":"https://www.pipelinedb.com","size":59608,"stargazers_count":638,"watchers_count":638,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":55,"forks":23,"open_issues":55,"watchers":638,"default_branch":"master"}},"base":{"label":"pipelinedb:master","ref":"master","sha":"a8f01e30ad4a5faad775e5dc618fe7665f288a60","user":{"login":"pipelinedb","id":5367380,"avatar_url":"https://avatars.githubusercontent.com/u/5367380?v=3","gravatar_id":"","url":"https://api.github.com/users/pipelinedb","html_url":"https://github.com/pipelinedb","followers_url":"https://api.github.com/users/pipelinedb/followers","following_url":"https://api.github.com/users/pipelinedb/following{/other_user}","gists_url":"https://api.github.com/users/pipelinedb/gists{/gist_id}","starred_url":"https://api.github.com/users/pipelinedb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipelinedb/subscriptions","organizations_url":"https://api.github.com/users/pipelinedb/orgs","repos_url":"https://api.github.com/users/pipelinedb/repos","events_url":"https://api.github.com/users/pipelinedb/events{/privacy}","received_events_url":"https://api.github.com/users/pipelinedb/received_events","type":"Organization","site_admin":false},"repo":{"id":14702444,"name":"pipelinedb","full_name":"pipelinedb/pipelinedb","owner":{"login":"pipelinedb","id":5367380,"avatar_url":"https://avatars.githubusercontent.com/u/5367380?v=3","gravatar_id":"","url":"https://api.github.com/users/pipelinedb","html_url":"https://github.com/pipelinedb","followers_url":"https://api.github.com/users/pipelinedb/followers","following_url":"https://api.github.com/users/pipelinedb/following{/other_user}","gists_url":"https://api.github.com/users/pipelinedb/gists{/gist_id}","starred_url":"https://api.github.com/users/pipelinedb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipelinedb/subscriptions","organizations_url":"https://api.github.com/users/pipelinedb/orgs","repos_url":"https://api.github.com/users/pipelinedb/repos","events_url":"https://api.github.com/users/pipelinedb/events{/privacy}","received_events_url":"https://api.github.com/users/pipelinedb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pipelinedb/pipelinedb","description":"The Streaming SQL Database","fork":false,"url":"https://api.github.com/repos/pipelinedb/pipelinedb","forks_url":"https://api.github.com/repos/pipelinedb/pipelinedb/forks","keys_url":"https://api.github.com/repos/pipelinedb/pipelinedb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pipelinedb/pipelinedb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pipelinedb/pipelinedb/teams","hooks_url":"https://api.github.com/repos/pipelinedb/pipelinedb/hooks","issue_events_url":"https://api.github.com/repos/pipelinedb/pipelinedb/issues/events{/number}","events_url":"https://api.github.com/repos/pipelinedb/pipelinedb/events","assignees_url":"https://api.github.com/repos/pipelinedb/pipelinedb/assignees{/user}","branches_url":"https://api.github.com/repos/pipelinedb/pipelinedb/branches{/branch}","tags_url":"https://api.github.com/repos/pipelinedb/pipelinedb/tags","blobs_url":"https://api.github.com/repos/pipelinedb/pipelinedb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pipelinedb/pipelinedb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pipelinedb/pipelinedb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pipelinedb/pipelinedb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pipelinedb/pipelinedb/statuses/{sha}","languages_url":"https://api.github.com/repos/pipelinedb/pipelinedb/languages","stargazers_url":"https://api.github.com/repos/pipelinedb/pipelinedb/stargazers","contributors_url":"https://api.github.com/repos/pipelinedb/pipelinedb/contributors","subscribers_url":"https://api.github.com/repos/pipelinedb/pipelinedb/subscribers","subscription_url":"https://api.github.com/repos/pipelinedb/pipelinedb/subscription","commits_url":"https://api.github.com/repos/pipelinedb/pipelinedb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pipelinedb/pipelinedb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pipelinedb/pipelinedb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pipelinedb/pipelinedb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pipelinedb/pipelinedb/contents/{+path}","compare_url":"https://api.github.com/repos/pipelinedb/pipelinedb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pipelinedb/pipelinedb/merges","archive_url":"https://api.github.com/repos/pipelinedb/pipelinedb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pipelinedb/pipelinedb/downloads","issues_url":"https://api.github.com/repos/pipelinedb/pipelinedb/issues{/number}","pulls_url":"https://api.github.com/repos/pipelinedb/pipelinedb/pulls{/number}","milestones_url":"https://api.github.com/repos/pipelinedb/pipelinedb/milestones{/number}","notifications_url":"https://api.github.com/repos/pipelinedb/pipelinedb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pipelinedb/pipelinedb/labels{/name}","releases_url":"https://api.github.com/repos/pipelinedb/pipelinedb/releases{/id}","created_at":"2013-11-26T00:11:48Z","updated_at":"2015-09-15T13:58:36Z","pushed_at":"2015-09-15T22:22:01Z","git_url":"git://github.com/pipelinedb/pipelinedb.git","ssh_url":"git@github.com:pipelinedb/pipelinedb.git","clone_url":"https://github.com/pipelinedb/pipelinedb.git","svn_url":"https://github.com/pipelinedb/pipelinedb","homepage":"https://www.pipelinedb.com","size":59608,"stargazers_count":638,"watchers_count":638,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":55,"forks":23,"open_issues":55,"watchers":638,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pipelinedb/pipelinedb/pulls/1171"},"html":{"href":"https://github.com/pipelinedb/pipelinedb/pull/1171"},"issue":{"href":"https://api.github.com/repos/pipelinedb/pipelinedb/issues/1171"},"comments":{"href":"https://api.github.com/repos/pipelinedb/pipelinedb/issues/1171/comments"},"review_comments":{"href":"https://api.github.com/repos/pipelinedb/pipelinedb/pulls/1171/comments"},"review_comment":{"href":"https://api.github.com/repos/pipelinedb/pipelinedb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pipelinedb/pipelinedb/pulls/1171/commits"},"statuses":{"href":"https://api.github.com/repos/pipelinedb/pipelinedb/statuses/92a9a1ab3f5e30e64a5a90fc1cf633d4a28669cc"}}}}