{"action":"created","issue":{"url":"https://api.github.com/repos/weppos/publicsuffix-ruby/issues/77","labels_url":"https://api.github.com/repos/weppos/publicsuffix-ruby/issues/77/labels{/name}","comments_url":"https://api.github.com/repos/weppos/publicsuffix-ruby/issues/77/comments","events_url":"https://api.github.com/repos/weppos/publicsuffix-ruby/issues/77/events","html_url":"https://github.com/weppos/publicsuffix-ruby/pull/77","id":72061105,"number":77,"title":"Don't duplicate rule indices when creating index.","user":{"login":"ags","id":299431,"avatar_url":"https://avatars.githubusercontent.com/u/299431?v=3","gravatar_id":"","url":"https://api.github.com/users/ags","html_url":"https://github.com/ags","followers_url":"https://api.github.com/users/ags/followers","following_url":"https://api.github.com/users/ags/following{/other_user}","gists_url":"https://api.github.com/users/ags/gists{/gist_id}","starred_url":"https://api.github.com/users/ags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ags/subscriptions","organizations_url":"https://api.github.com/users/ags/orgs","repos_url":"https://api.github.com/users/ags/repos","events_url":"https://api.github.com/users/ags/events{/privacy}","received_events_url":"https://api.github.com/users/ags/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-30T04:37:13Z","updated_at":"2015-10-05T22:19:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/weppos/publicsuffix-ruby/pulls/77","html_url":"https://github.com/weppos/publicsuffix-ruby/pull/77","diff_url":"https://github.com/weppos/publicsuffix-ruby/pull/77.diff","patch_url":"https://github.com/weppos/publicsuffix-ruby/pull/77.patch"},"body":"By default, the rule index is re-created when new rules are added to a list.\r\n\r\nThe index isn't cleared when this happens, so the index allows repeated addition of the same indices for the same rule. This in turn slows down `List.find`.\r\n\r\nWe (Flippa) add 39 new rules to the default list, which means for a TLD like '.it', 15,129 rules are checked instead of the 369 unique ones."},"comment":{"url":"https://api.github.com/repos/weppos/publicsuffix-ruby/issues/comments/145685934","html_url":"https://github.com/weppos/publicsuffix-ruby/pull/77#issuecomment-145685934","issue_url":"https://api.github.com/repos/weppos/publicsuffix-ruby/issues/77","id":145685934,"user":{"login":"ags","id":299431,"avatar_url":"https://avatars.githubusercontent.com/u/299431?v=3","gravatar_id":"","url":"https://api.github.com/users/ags","html_url":"https://github.com/ags","followers_url":"https://api.github.com/users/ags/followers","following_url":"https://api.github.com/users/ags/following{/other_user}","gists_url":"https://api.github.com/users/ags/gists{/gist_id}","starred_url":"https://api.github.com/users/ags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ags/subscriptions","organizations_url":"https://api.github.com/users/ags/orgs","repos_url":"https://api.github.com/users/ags/repos","events_url":"https://api.github.com/users/ags/events{/privacy}","received_events_url":"https://api.github.com/users/ags/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T22:19:34Z","updated_at":"2015-10-05T22:19:34Z","body":"@weppos Is there any chance this could be looked at? We were seeing frequent `SystemStackError`s in production until this change.\r\n\r\nIf this gem needs help with maintenance, I'll happily lend a hand :)\r\n\r\nThanks!"}}