{"push_id":868575743,"size":2,"distinct_size":2,"ref":"refs/heads/develop","head":"694e8d23ed83512cfbdc11aa12a425624d281cd7","before":"38ef4e92dea5c44b048d9720a1567e9e4e0dd763","commits":[{"sha":"e708744a907a2fb52d399df98a481ff8392f6785","author":{"email":"43af82ef30812a20fbcf38b99a6f72cdd3a89ac1@gmail.com","name":"thc202"},"message":"Fix issues with installation of passive and active scanners\n\nChange to load and set the quality of the passive and active scanners\nduring installation of the add-on, preventing the quality from being\n\"Unknown\". The loading/instantiation of the scanners is now done by the\nsame code (refactored to new class AddOnLoaderUtils, also refactored the\ncode that loads/instantiates a class, or classes, from an add-on). The\nmethods previously used during the installation, ExtensionPassiveScan.\naddPassiveScanner(String) and PluginFactory.loadedPlugin(String), are\nnow deprecated as the quality is not correctly set. The method\nPluginFactory.unloadedPlugin(String) is also deprecated, no longer used\nby core code (the active scanners are now removed using the loaded\ninstances).\nChange to load the active scanners just once by checking that the\nscanners were not already loaded/added. The active scanners were being\nadded twice because the method PluginFactory.loadedPlugin(String) called\nthe method that initialised the list of scanners which was being\ninitialised with the add-ons already loaded, which included the add-on\nbeing installed. The PluginFactory now checks if a scanner is already\nloaded by reference and when removing, to make sure that's checking and\nremoving the exact instance (added). Previously it was using the equals\nof the default implementation (AbstractPlugin) which checked the\nequality by using the ID of the scanner, which would lead to unexpected\nresults when different scanners have (wrongly) the same ID (as it could\nremove the other scanner).\nThe AddOn now keeps references to the scanners loaded, which is used to\nprevent loading the scanners more than once and are used during the\nuninstallation of the add-on.\nFix #1969 - Issues with installation of scanners","distinct":true,"url":"https://api.github.com/repos/zapbot/zaproxy/commits/e708744a907a2fb52d399df98a481ff8392f6785"},{"sha":"694e8d23ed83512cfbdc11aa12a425624d281cd7","author":{"email":"86dd6fc569bc24d96c23727e2734cc63308a81de@gmail.com","name":"psiinon"},"message":"Merge pull request #2018 from thc202/issue/1969\n\nFix issues with installation of passive and active scanners","distinct":true,"url":"https://api.github.com/repos/zapbot/zaproxy/commits/694e8d23ed83512cfbdc11aa12a425624d281cd7"}]}