{"action":"opened","number":128,"pull_request":{"url":"https://api.github.com/repos/uber/hyperbahn/pulls/128","id":49896609,"html_url":"https://github.com/uber/hyperbahn/pull/128","diff_url":"https://github.com/uber/hyperbahn/pull/128.diff","patch_url":"https://github.com/uber/hyperbahn/pull/128.patch","issue_url":"https://api.github.com/repos/uber/hyperbahn/issues/128","number":128,"state":"open","locked":false,"title":"test: Remove flap by improving assert","user":{"login":"Raynos","id":479538,"avatar_url":"https://avatars.githubusercontent.com/u/479538?v=3","gravatar_id":"","url":"https://api.github.com/users/Raynos","html_url":"https://github.com/Raynos","followers_url":"https://api.github.com/users/Raynos/followers","following_url":"https://api.github.com/users/Raynos/following{/other_user}","gists_url":"https://api.github.com/users/Raynos/gists{/gist_id}","starred_url":"https://api.github.com/users/Raynos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raynos/subscriptions","organizations_url":"https://api.github.com/users/Raynos/orgs","repos_url":"https://api.github.com/users/Raynos/repos","events_url":"https://api.github.com/users/Raynos/events{/privacy}","received_events_url":"https://api.github.com/users/Raynos/received_events","type":"User","site_admin":false},"body":"This was flapping because non-deterministic log statement.\nI added another case to catch the connection error\nshape.\n\nObservation: We could use an `extendLogInfo()` like\nconsistency for fields on error instance or stop asserting\non error fields and continue asserting on meta fields.\n\nr: @jcorbin @rf","created_at":"2015-11-05T23:30:50Z","updated_at":"2015-11-05T23:30:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/hyperbahn/pulls/128/commits","review_comments_url":"https://api.github.com/repos/uber/hyperbahn/pulls/128/comments","review_comment_url":"https://api.github.com/repos/uber/hyperbahn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/hyperbahn/issues/128/comments","statuses_url":"https://api.github.com/repos/uber/hyperbahn/statuses/98ed3ef6880bbe97dbdbdc671d0146211e140671","head":{"label":"uber:no-moer-flaps","ref":"no-moer-flaps","sha":"98ed3ef6880bbe97dbdbdc671d0146211e140671","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":41167537,"name":"hyperbahn","full_name":"uber/hyperbahn","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/hyperbahn","description":"Service discovery and routing for large scale microservice operations","fork":false,"url":"https://api.github.com/repos/uber/hyperbahn","forks_url":"https://api.github.com/repos/uber/hyperbahn/forks","keys_url":"https://api.github.com/repos/uber/hyperbahn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/hyperbahn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/hyperbahn/teams","hooks_url":"https://api.github.com/repos/uber/hyperbahn/hooks","issue_events_url":"https://api.github.com/repos/uber/hyperbahn/issues/events{/number}","events_url":"https://api.github.com/repos/uber/hyperbahn/events","assignees_url":"https://api.github.com/repos/uber/hyperbahn/assignees{/user}","branches_url":"https://api.github.com/repos/uber/hyperbahn/branches{/branch}","tags_url":"https://api.github.com/repos/uber/hyperbahn/tags","blobs_url":"https://api.github.com/repos/uber/hyperbahn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/hyperbahn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/hyperbahn/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/hyperbahn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/hyperbahn/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/hyperbahn/languages","stargazers_url":"https://api.github.com/repos/uber/hyperbahn/stargazers","contributors_url":"https://api.github.com/repos/uber/hyperbahn/contributors","subscribers_url":"https://api.github.com/repos/uber/hyperbahn/subscribers","subscription_url":"https://api.github.com/repos/uber/hyperbahn/subscription","commits_url":"https://api.github.com/repos/uber/hyperbahn/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/hyperbahn/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/hyperbahn/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/hyperbahn/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/hyperbahn/contents/{+path}","compare_url":"https://api.github.com/repos/uber/hyperbahn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/hyperbahn/merges","archive_url":"https://api.github.com/repos/uber/hyperbahn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/hyperbahn/downloads","issues_url":"https://api.github.com/repos/uber/hyperbahn/issues{/number}","pulls_url":"https://api.github.com/repos/uber/hyperbahn/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/hyperbahn/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/hyperbahn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/hyperbahn/labels{/name}","releases_url":"https://api.github.com/repos/uber/hyperbahn/releases{/id}","created_at":"2015-08-21T17:04:51Z","updated_at":"2015-11-05T20:46:50Z","pushed_at":"2015-11-05T23:30:03Z","git_url":"git://github.com/uber/hyperbahn.git","ssh_url":"git@github.com:uber/hyperbahn.git","clone_url":"https://github.com/uber/hyperbahn.git","svn_url":"https://github.com/uber/hyperbahn","homepage":"","size":3155,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":24,"forks":3,"open_issues":24,"watchers":19,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"84c4f7c6e3443cedcf3c308091974d9df8b1a29e","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":41167537,"name":"hyperbahn","full_name":"uber/hyperbahn","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/hyperbahn","description":"Service discovery and routing for large scale microservice operations","fork":false,"url":"https://api.github.com/repos/uber/hyperbahn","forks_url":"https://api.github.com/repos/uber/hyperbahn/forks","keys_url":"https://api.github.com/repos/uber/hyperbahn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/hyperbahn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/hyperbahn/teams","hooks_url":"https://api.github.com/repos/uber/hyperbahn/hooks","issue_events_url":"https://api.github.com/repos/uber/hyperbahn/issues/events{/number}","events_url":"https://api.github.com/repos/uber/hyperbahn/events","assignees_url":"https://api.github.com/repos/uber/hyperbahn/assignees{/user}","branches_url":"https://api.github.com/repos/uber/hyperbahn/branches{/branch}","tags_url":"https://api.github.com/repos/uber/hyperbahn/tags","blobs_url":"https://api.github.com/repos/uber/hyperbahn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/hyperbahn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/hyperbahn/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/hyperbahn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/hyperbahn/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/hyperbahn/languages","stargazers_url":"https://api.github.com/repos/uber/hyperbahn/stargazers","contributors_url":"https://api.github.com/repos/uber/hyperbahn/contributors","subscribers_url":"https://api.github.com/repos/uber/hyperbahn/subscribers","subscription_url":"https://api.github.com/repos/uber/hyperbahn/subscription","commits_url":"https://api.github.com/repos/uber/hyperbahn/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/hyperbahn/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/hyperbahn/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/hyperbahn/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/hyperbahn/contents/{+path}","compare_url":"https://api.github.com/repos/uber/hyperbahn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/hyperbahn/merges","archive_url":"https://api.github.com/repos/uber/hyperbahn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/hyperbahn/downloads","issues_url":"https://api.github.com/repos/uber/hyperbahn/issues{/number}","pulls_url":"https://api.github.com/repos/uber/hyperbahn/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/hyperbahn/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/hyperbahn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/hyperbahn/labels{/name}","releases_url":"https://api.github.com/repos/uber/hyperbahn/releases{/id}","created_at":"2015-08-21T17:04:51Z","updated_at":"2015-11-05T20:46:50Z","pushed_at":"2015-11-05T23:30:03Z","git_url":"git://github.com/uber/hyperbahn.git","ssh_url":"git@github.com:uber/hyperbahn.git","clone_url":"https://github.com/uber/hyperbahn.git","svn_url":"https://github.com/uber/hyperbahn","homepage":"","size":3155,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":24,"forks":3,"open_issues":24,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/hyperbahn/pulls/128"},"html":{"href":"https://github.com/uber/hyperbahn/pull/128"},"issue":{"href":"https://api.github.com/repos/uber/hyperbahn/issues/128"},"comments":{"href":"https://api.github.com/repos/uber/hyperbahn/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/hyperbahn/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/hyperbahn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/hyperbahn/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/uber/hyperbahn/statuses/98ed3ef6880bbe97dbdbdc671d0146211e140671"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":1,"changed_files":1}}