{"action":"created","comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/29304815","id":29304815,"diff_hunk":"@@ -34,15 +34,28 @@\n     singlePartition = false\n )\n public class AllTypesMultiOpsJavaError extends VoltProcedure {\n-    public final static int INSERT = 0;\n-    public final static int UPDATE = 1;\n-    public final static int DELETE = 2;\n-    public final SQLStmt[] statements =\n-        {new SQLStmt(\"INSERT INTO ALL_TYPES VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?);\"),\n-         new SQLStmt(\"UPDATE ALL_TYPES SET TINY = ?, SMALL = ?, BIG = ?,\"\n+    public final static int INSERT   = 0;\n+    public final static int UPDATE   = 1;\n+    public final static int DELETE   = 2;\n+    public final static int TRUNCATE = 3;\n+    // Note: Need to make these all:\n+    //          public static final SQLStmt XXX_STMT = new SQLStmt(\"...\");\n+    //       The reflection mechanism can't find them if they are in\n+    //       non-static member functions like this, so they don't get","path":"tests/testprocs/org/voltdb_testprocs/regressionsuites/rollbackprocs/AllTypesMultiOpsJavaError.java","position":17,"original_position":17,"commit_id":"860ef4ffcdcd129cf8664fbecfb43de9bdbe34db","original_commit_id":"860ef4ffcdcd129cf8664fbecfb43de9bdbe34db","user":{"login":"paulmartel","id":1512099,"avatar_url":"https://avatars.githubusercontent.com/u/1512099?v=3","gravatar_id":"","url":"https://api.github.com/users/paulmartel","html_url":"https://github.com/paulmartel","followers_url":"https://api.github.com/users/paulmartel/followers","following_url":"https://api.github.com/users/paulmartel/following{/other_user}","gists_url":"https://api.github.com/users/paulmartel/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmartel/subscriptions","organizations_url":"https://api.github.com/users/paulmartel/orgs","repos_url":"https://api.github.com/users/paulmartel/repos","events_url":"https://api.github.com/users/paulmartel/events{/privacy}","received_events_url":"https://api.github.com/users/paulmartel/received_events","type":"User","site_admin":false},"body":"the comment seems a little confused/confusing: replace: \"in non-static member functions like this\" w/ \"anonymous elements in the initializer of an array attribute like 'statements' \" -- the real issue, as far as I understand.\r\n\r\nGood catch, BTW.","created_at":"2015-04-29T01:29:43Z","updated_at":"2015-04-29T01:29:43Z","html_url":"https://github.com/VoltDB/voltdb/pull/2283#discussion_r29304815","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2283","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/29304815"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/2283#discussion_r29304815"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2283"}}},"pull_request":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2283","id":34320399,"html_url":"https://github.com/VoltDB/voltdb/pull/2283","diff_url":"https://github.com/VoltDB/voltdb/pull/2283.diff","patch_url":"https://github.com/VoltDB/voltdb/pull/2283.patch","issue_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2283","number":2283,"state":"open","locked":false,"title":"Add a java unit test for rolling back truncate table.","user":{"login":"BillWhite","id":924098,"avatar_url":"https://avatars.githubusercontent.com/u/924098?v=3","gravatar_id":"","url":"https://api.github.com/users/BillWhite","html_url":"https://github.com/BillWhite","followers_url":"https://api.github.com/users/BillWhite/followers","following_url":"https://api.github.com/users/BillWhite/following{/other_user}","gists_url":"https://api.github.com/users/BillWhite/gists{/gist_id}","starred_url":"https://api.github.com/users/BillWhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillWhite/subscriptions","organizations_url":"https://api.github.com/users/BillWhite/orgs","repos_url":"https://api.github.com/users/BillWhite/repos","events_url":"https://api.github.com/users/BillWhite/events{/privacy}","received_events_url":"https://api.github.com/users/BillWhite/received_events","type":"User","site_admin":false},"body":"Also, fixed a bug in allTypesMultiOpsJavaError which caused nothing to actually be tested.","created_at":"2015-04-28T23:03:46Z","updated_at":"2015-04-29T01:29:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7eb74626fc6175ee081fdb87fc4bca0d7fdda7b0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2283/commits","review_comments_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2283/comments","review_comment_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2283/comments","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/860ef4ffcdcd129cf8664fbecfb43de9bdbe34db","head":{"label":"VoltDB:ENG-7919-JUnitTestsTruncateRollbackOrder","ref":"ENG-7919-JUnitTestsTruncateRollbackOrder","sha":"860ef4ffcdcd129cf8664fbecfb43de9bdbe34db","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2015-04-29T00:40:09Z","pushed_at":"2015-04-29T00:40:09Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":666304,"stargazers_count":527,"watchers_count":527,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"open_issues_count":25,"forks":151,"open_issues":25,"watchers":527,"default_branch":"master"}},"base":{"label":"VoltDB:master","ref":"master","sha":"0465edb2bd9f07138f330520ca8979117455a77a","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2015-04-29T00:40:09Z","pushed_at":"2015-04-29T00:40:09Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":666304,"stargazers_count":527,"watchers_count":527,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"open_issues_count":25,"forks":151,"open_issues":25,"watchers":527,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2283"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/2283"},"issue":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/2283"},"comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/2283/comments"},"review_comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2283/comments"},"review_comment":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2283/commits"},"statuses":{"href":"https://api.github.com/repos/VoltDB/voltdb/statuses/860ef4ffcdcd129cf8664fbecfb43de9bdbe34db"}}}}