{"push_id":563679876,"size":2,"distinct_size":0,"ref":"refs/heads/tmp","head":"3d072a193bfcb76206aab576049e696d6d8db25d","before":"cfc91090e9676104b7a9a7c707ea70f0842ed6de","commits":[{"sha":"e81ae40770a74dbdeb70a5abcb41e1eb3cc2a584","author":{"email":"19e794c1bad8f0914a9eb04e9876660727aa8f3b@gmail.com","name":"Huon Wilson"},"message":"Try to only suggest implementable traits for method calls.\n\nThat is, when offering suggestions for unresolved method calls, avoid\nsuggesting traits for which implementing the trait for the receiver type\neither makes little sense (e.g. type errors, or sugared unboxed\nclosures), or violates coherence.\n\nThe latter is approximated by ensuring that at least one of `{receiver\ntype, trait}` is local. This isn't precisely correct due to\nmultidispatch, but the error messages one encounters in such situation\nare useless more often than not; it is better to be conservative and\nmiss some cases, than have overly many false positives (e.g. writing\n`some_slice.map(|x| ...)` uselessly suggested that one should implement\n`IteratorExt` for `&[T]`, while the correct fix is to call `.iter()`).\n\nCloses #21420.","distinct":false,"url":"https://api.github.com/repos/rust-lang/rust/commits/e81ae40770a74dbdeb70a5abcb41e1eb3cc2a584"},{"sha":"3d072a193bfcb76206aab576049e696d6d8db25d","author":{"email":"3a2c29237f73c7cf88424b80e427b1884f346b35@rust-lang.org","name":"bors"},"message":"Auto merge of #21675 - huonw:less-false-positives, r=nikomatsakis\n\nThat is, when offering suggestions for unresolved method calls, avoid\r\nsuggesting traits for which implementing the trait for the receiver type\r\neither makes little sense (e.g. type errors, or sugared unboxed\r\nclosures), or violates coherence.\r\n\r\nThe latter is approximated by ensuring that at least one of `{receiver\r\ntype, trait}` is local. This isn't precisely correct due to\r\nmultidispatch, but the error messages one encounters in such situation\r\nare useless more often than not; it is better to be conservative and\r\nmiss some cases, than have overly many false positives (e.g. writing\r\n`some_slice.map(|x| ...)` uselessly suggested that one should implement\r\n`IteratorExt` for `&[T]`, while the correct fix is to call `.iter()`).\r\n\r\nCloses #21420.","distinct":false,"url":"https://api.github.com/repos/rust-lang/rust/commits/3d072a193bfcb76206aab576049e696d6d8db25d"}]}