{"action":"created","comment":{"url":"https://api.github.com/repos/angular-ui/ui-router/pulls/comments/41325729","id":41325729,"diff_hunk":"@@ -520,6 +520,21 @@ describe(\"urlMatcherFactory\", function () {\n       expect(m.format({ foo: 5, flag: true })).toBe(\"/5/1\");\n     });\n \n+    it(\"should match types named only in params\", function () {\n+      var m = new UrlMatcher(\"/{foo}/{flag}\", {\n+        params: {\n+          foo: {\n+            type: 'int'\n+          },\n+          flag: {\n+            type: 'bool'\n+          }\n+        }\n+      });\n+      expect(m.exec(\"/1138/1\")).toEqual({ foo: 1138, flag: true });\n+      expect(m.format({ foo: 5, flag: true })).toBe(\"/5/1\");\n+    });\n+","path":"test/urlMatcherFactorySpec.js","position":18,"original_position":18,"commit_id":"6a371f9b70e37a82eb324122879e4473c3f6d526","original_commit_id":"6a371f9b70e37a82eb324122879e4473c3f6d526","user":{"login":"christopherthielen","id":2053478,"avatar_url":"https://avatars.githubusercontent.com/u/2053478?v=3","gravatar_id":"","url":"https://api.github.com/users/christopherthielen","html_url":"https://github.com/christopherthielen","followers_url":"https://api.github.com/users/christopherthielen/followers","following_url":"https://api.github.com/users/christopherthielen/following{/other_user}","gists_url":"https://api.github.com/users/christopherthielen/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherthielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherthielen/subscriptions","organizations_url":"https://api.github.com/users/christopherthielen/orgs","repos_url":"https://api.github.com/users/christopherthielen/repos","events_url":"https://api.github.com/users/christopherthielen/events{/privacy}","received_events_url":"https://api.github.com/users/christopherthielen/received_events","type":"User","site_admin":false},"body":"Please add a test for url-less parameters, like our discussion in issue #983 \r\n","created_at":"2015-10-06T21:34:44Z","updated_at":"2015-10-06T21:34:44Z","html_url":"https://github.com/angular-ui/ui-router/pull/2289#discussion_r41325729","pull_request_url":"https://api.github.com/repos/angular-ui/ui-router/pulls/2289","_links":{"self":{"href":"https://api.github.com/repos/angular-ui/ui-router/pulls/comments/41325729"},"html":{"href":"https://github.com/angular-ui/ui-router/pull/2289#discussion_r41325729"},"pull_request":{"href":"https://api.github.com/repos/angular-ui/ui-router/pulls/2289"}}},"pull_request":{"url":"https://api.github.com/repos/angular-ui/ui-router/pulls/2289","id":46922668,"html_url":"https://github.com/angular-ui/ui-router/pull/2289","diff_url":"https://github.com/angular-ui/ui-router/pull/2289.diff","patch_url":"https://github.com/angular-ui/ui-router/pull/2289.patch","issue_url":"https://api.github.com/repos/angular-ui/ui-router/issues/2289","number":2289,"state":"closed","locked":false,"title":"feat(UrlMatcher): Add param only type names","user":{"login":"filipesilva","id":4172079,"avatar_url":"https://avatars.githubusercontent.com/u/4172079?v=3","gravatar_id":"","url":"https://api.github.com/users/filipesilva","html_url":"https://github.com/filipesilva","followers_url":"https://api.github.com/users/filipesilva/followers","following_url":"https://api.github.com/users/filipesilva/following{/other_user}","gists_url":"https://api.github.com/users/filipesilva/gists{/gist_id}","starred_url":"https://api.github.com/users/filipesilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipesilva/subscriptions","organizations_url":"https://api.github.com/users/filipesilva/orgs","repos_url":"https://api.github.com/users/filipesilva/repos","events_url":"https://api.github.com/users/filipesilva/events{/privacy}","received_events_url":"https://api.github.com/users/filipesilva/received_events","type":"User","site_admin":false},"body":"As per https://github.com/angular-ui/ui-router/issues/983#issuecomment-145288637","created_at":"2015-10-06T16:03:05Z","updated_at":"2015-10-06T21:34:44Z","closed_at":"2015-10-06T19:03:30Z","merged_at":"2015-10-06T19:03:30Z","merge_commit_sha":"eb333841a08295053013cab6b621c0f09016e57f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular-ui/ui-router/pulls/2289/commits","review_comments_url":"https://api.github.com/repos/angular-ui/ui-router/pulls/2289/comments","review_comment_url":"https://api.github.com/repos/angular-ui/ui-router/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/ui-router/issues/2289/comments","statuses_url":"https://api.github.com/repos/angular-ui/ui-router/statuses/6a371f9b70e37a82eb324122879e4473c3f6d526","head":{"label":"filipesilva:add-param-config-to-options","ref":"add-param-config-to-options","sha":"6a371f9b70e37a82eb324122879e4473c3f6d526","user":{"login":"filipesilva","id":4172079,"avatar_url":"https://avatars.githubusercontent.com/u/4172079?v=3","gravatar_id":"","url":"https://api.github.com/users/filipesilva","html_url":"https://github.com/filipesilva","followers_url":"https://api.github.com/users/filipesilva/followers","following_url":"https://api.github.com/users/filipesilva/following{/other_user}","gists_url":"https://api.github.com/users/filipesilva/gists{/gist_id}","starred_url":"https://api.github.com/users/filipesilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipesilva/subscriptions","organizations_url":"https://api.github.com/users/filipesilva/orgs","repos_url":"https://api.github.com/users/filipesilva/repos","events_url":"https://api.github.com/users/filipesilva/events{/privacy}","received_events_url":"https://api.github.com/users/filipesilva/received_events","type":"User","site_admin":false},"repo":{"id":43615722,"name":"ui-router","full_name":"filipesilva/ui-router","owner":{"login":"filipesilva","id":4172079,"avatar_url":"https://avatars.githubusercontent.com/u/4172079?v=3","gravatar_id":"","url":"https://api.github.com/users/filipesilva","html_url":"https://github.com/filipesilva","followers_url":"https://api.github.com/users/filipesilva/followers","following_url":"https://api.github.com/users/filipesilva/following{/other_user}","gists_url":"https://api.github.com/users/filipesilva/gists{/gist_id}","starred_url":"https://api.github.com/users/filipesilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipesilva/subscriptions","organizations_url":"https://api.github.com/users/filipesilva/orgs","repos_url":"https://api.github.com/users/filipesilva/repos","events_url":"https://api.github.com/users/filipesilva/events{/privacy}","received_events_url":"https://api.github.com/users/filipesilva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/filipesilva/ui-router","description":"The de-facto solution to flexible routing with nested views in AngularJS","fork":true,"url":"https://api.github.com/repos/filipesilva/ui-router","forks_url":"https://api.github.com/repos/filipesilva/ui-router/forks","keys_url":"https://api.github.com/repos/filipesilva/ui-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filipesilva/ui-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filipesilva/ui-router/teams","hooks_url":"https://api.github.com/repos/filipesilva/ui-router/hooks","issue_events_url":"https://api.github.com/repos/filipesilva/ui-router/issues/events{/number}","events_url":"https://api.github.com/repos/filipesilva/ui-router/events","assignees_url":"https://api.github.com/repos/filipesilva/ui-router/assignees{/user}","branches_url":"https://api.github.com/repos/filipesilva/ui-router/branches{/branch}","tags_url":"https://api.github.com/repos/filipesilva/ui-router/tags","blobs_url":"https://api.github.com/repos/filipesilva/ui-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filipesilva/ui-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filipesilva/ui-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/filipesilva/ui-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filipesilva/ui-router/statuses/{sha}","languages_url":"https://api.github.com/repos/filipesilva/ui-router/languages","stargazers_url":"https://api.github.com/repos/filipesilva/ui-router/stargazers","contributors_url":"https://api.github.com/repos/filipesilva/ui-router/contributors","subscribers_url":"https://api.github.com/repos/filipesilva/ui-router/subscribers","subscription_url":"https://api.github.com/repos/filipesilva/ui-router/subscription","commits_url":"https://api.github.com/repos/filipesilva/ui-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/filipesilva/ui-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/filipesilva/ui-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/filipesilva/ui-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/filipesilva/ui-router/contents/{+path}","compare_url":"https://api.github.com/repos/filipesilva/ui-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filipesilva/ui-router/merges","archive_url":"https://api.github.com/repos/filipesilva/ui-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filipesilva/ui-router/downloads","issues_url":"https://api.github.com/repos/filipesilva/ui-router/issues{/number}","pulls_url":"https://api.github.com/repos/filipesilva/ui-router/pulls{/number}","milestones_url":"https://api.github.com/repos/filipesilva/ui-router/milestones{/number}","notifications_url":"https://api.github.com/repos/filipesilva/ui-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filipesilva/ui-router/labels{/name}","releases_url":"https://api.github.com/repos/filipesilva/ui-router/releases{/id}","created_at":"2015-10-03T21:31:58Z","updated_at":"2015-10-03T21:32:00Z","pushed_at":"2015-10-06T16:00:08Z","git_url":"git://github.com/filipesilva/ui-router.git","ssh_url":"git@github.com:filipesilva/ui-router.git","clone_url":"https://github.com/filipesilva/ui-router.git","svn_url":"https://github.com/filipesilva/ui-router","homepage":"http://angular-ui.github.io/ui-router/site","size":5251,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"6f723a599dfab6399cff5528877e892d63c11832","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":7693799,"name":"ui-router","full_name":"angular-ui/ui-router","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/ui-router","description":"The de-facto solution to flexible routing with nested views in AngularJS","fork":false,"url":"https://api.github.com/repos/angular-ui/ui-router","forks_url":"https://api.github.com/repos/angular-ui/ui-router/forks","keys_url":"https://api.github.com/repos/angular-ui/ui-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/ui-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/ui-router/teams","hooks_url":"https://api.github.com/repos/angular-ui/ui-router/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/ui-router/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/ui-router/events","assignees_url":"https://api.github.com/repos/angular-ui/ui-router/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/ui-router/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/ui-router/tags","blobs_url":"https://api.github.com/repos/angular-ui/ui-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/ui-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/ui-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/ui-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/ui-router/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/ui-router/languages","stargazers_url":"https://api.github.com/repos/angular-ui/ui-router/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/ui-router/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/ui-router/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/ui-router/subscription","commits_url":"https://api.github.com/repos/angular-ui/ui-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/ui-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/ui-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/ui-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/ui-router/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/ui-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/ui-router/merges","archive_url":"https://api.github.com/repos/angular-ui/ui-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/ui-router/downloads","issues_url":"https://api.github.com/repos/angular-ui/ui-router/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/ui-router/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/ui-router/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/ui-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/ui-router/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/ui-router/releases{/id}","created_at":"2013-01-18T20:26:29Z","updated_at":"2015-10-06T17:35:51Z","pushed_at":"2015-10-06T21:31:02Z","git_url":"git://github.com/angular-ui/ui-router.git","ssh_url":"git@github.com:angular-ui/ui-router.git","clone_url":"https://github.com/angular-ui/ui-router.git","svn_url":"https://github.com/angular-ui/ui-router","homepage":"http://angular-ui.github.io/ui-router/site","size":13916,"stargazers_count":8540,"watchers_count":8540,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2063,"mirror_url":null,"open_issues_count":216,"forks":2063,"open_issues":216,"watchers":8540,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/ui-router/pulls/2289"},"html":{"href":"https://github.com/angular-ui/ui-router/pull/2289"},"issue":{"href":"https://api.github.com/repos/angular-ui/ui-router/issues/2289"},"comments":{"href":"https://api.github.com/repos/angular-ui/ui-router/issues/2289/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/ui-router/pulls/2289/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/ui-router/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/ui-router/pulls/2289/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/ui-router/statuses/6a371f9b70e37a82eb324122879e4473c3f6d526"}}}}