{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/32579826","id":32579826,"diff_hunk":"@@ -1342,18 +1358,15 @@ void Model::snapToRegistrationPoint() {\n }\n \n void Model::simulate(float deltaTime, bool fullUpdate) {\n-    /*\n-    qDebug() << \"Model::simulate()\";\n-    qDebug() << \"   _translation:\" << _translation;\n-    qDebug() << \"   _rotation:\" << _rotation;\n-    */\n-    \n     fullUpdate = updateGeometry() || fullUpdate || (_scaleToFit && !_scaledToFit)\n                     || (_snapModelToRegistrationPoint && !_snappedToRegistrationPoint);\n                     \n     if (isActive() && fullUpdate) {\n-        // NOTE: this seems problematic... need to review\n-        _calculatedMeshBoxesValid = false; // if we have to simulate, we need to assume our mesh boxes are all invalid\n+        // NOTE: This is overly aggressive and we are invalidating the MeshBoxes when in fact they may not be invalid\n+        //       they really only become invalid if something about the transform to world space has changed. This is\n+        //       not too bad at this point, because it doesn't impact rendering. However it does slow down ray picking\n+        //       because ray picking needs valid boxes to work\n+        _calculatedMeshBoxesValid = false;","path":"libraries/render-utils/src/Model.cpp","position":98,"original_position":98,"commit_id":"1beb95cfe7a74cde650c4edff43d70818d075adb","original_commit_id":"1beb95cfe7a74cde650c4edff43d70818d075adb","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"body":"similar note as above, this doesn't hurt our FPS per se, but there are cases where we really don't need to invalidate the mesh boxes just because we simulated... it would be best to not do pay this price if we don't have to.","created_at":"2015-06-16T22:45:14Z","updated_at":"2015-06-16T22:45:14Z","html_url":"https://github.com/highfidelity/hifi/pull/5139#discussion_r32579826","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5139","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/32579826"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5139#discussion_r32579826"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5139"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/5139","id":37849513,"html_url":"https://github.com/highfidelity/hifi/pull/5139","diff_url":"https://github.com/highfidelity/hifi/pull/5139.diff","patch_url":"https://github.com/highfidelity/hifi/pull/5139.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/5139","number":5139,"state":"open","locked":false,"title":"fix FPS while still maintaining ray picking","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"body":"Fix the FPS problems caused by recent ray picking fix\r\n* only calculate the mesh part offsets inside of renderPart() that's all we really needed\r\n* don't call recalculateMeshBoxes() especially recalculateMeshBoxes(true) in lots of per frame places\r\n* do make sure to call recalculateMeshBoxes() in the findRayIntersection() method in the event that the boxes have been invalidated by some change in transform","created_at":"2015-06-16T22:38:34Z","updated_at":"2015-06-16T22:45:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd3600fa58d897b70c50f289a5a109754a014117","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5139/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5139/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/5139/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/1beb95cfe7a74cde650c4edff43d70818d075adb","head":{"label":"ZappoMan:fixRayPicking","ref":"fixRayPicking","sha":"1beb95cfe7a74cde650c4edff43d70818d075adb","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"repo":{"id":9376434,"name":"hifi","full_name":"ZappoMan/hifi","owner":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZappoMan/hifi","description":"Test platform for various render and interface tests for next-gen VR system","fork":true,"url":"https://api.github.com/repos/ZappoMan/hifi","forks_url":"https://api.github.com/repos/ZappoMan/hifi/forks","keys_url":"https://api.github.com/repos/ZappoMan/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZappoMan/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZappoMan/hifi/teams","hooks_url":"https://api.github.com/repos/ZappoMan/hifi/hooks","issue_events_url":"https://api.github.com/repos/ZappoMan/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/ZappoMan/hifi/events","assignees_url":"https://api.github.com/repos/ZappoMan/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/ZappoMan/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/ZappoMan/hifi/tags","blobs_url":"https://api.github.com/repos/ZappoMan/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZappoMan/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZappoMan/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZappoMan/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZappoMan/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/ZappoMan/hifi/languages","stargazers_url":"https://api.github.com/repos/ZappoMan/hifi/stargazers","contributors_url":"https://api.github.com/repos/ZappoMan/hifi/contributors","subscribers_url":"https://api.github.com/repos/ZappoMan/hifi/subscribers","subscription_url":"https://api.github.com/repos/ZappoMan/hifi/subscription","commits_url":"https://api.github.com/repos/ZappoMan/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZappoMan/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZappoMan/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZappoMan/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZappoMan/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/ZappoMan/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZappoMan/hifi/merges","archive_url":"https://api.github.com/repos/ZappoMan/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZappoMan/hifi/downloads","issues_url":"https://api.github.com/repos/ZappoMan/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/ZappoMan/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/ZappoMan/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/ZappoMan/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZappoMan/hifi/labels{/name}","releases_url":"https://api.github.com/repos/ZappoMan/hifi/releases{/id}","created_at":"2013-04-11T17:41:25Z","updated_at":"2015-05-08T15:39:03Z","pushed_at":"2015-06-16T22:38:23Z","git_url":"git://github.com/ZappoMan/hifi.git","ssh_url":"git@github.com:ZappoMan/hifi.git","clone_url":"https://github.com/ZappoMan/hifi.git","svn_url":"https://github.com/ZappoMan/hifi","homepage":null,"size":165598,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"49a68b4565a461642334b3c32d31d2a794b07721","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-06-11T10:17:07Z","pushed_at":"2015-06-16T22:38:34Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":211946,"stargazers_count":276,"watchers_count":276,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":157,"mirror_url":null,"open_issues_count":57,"forks":157,"open_issues":57,"watchers":276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5139"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5139"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5139"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5139/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5139/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5139/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/1beb95cfe7a74cde650c4edff43d70818d075adb"}}}}