{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/45894174","id":45894174,"diff_hunk":"@@ -44,16 +45,30 @@\n \t/** The schema (ie, ordered field names) of the tuple */\n \tprivate final Fields schema;\n \n+\tprivate final int taskId;\n+\tprivate final String producerStreamId;\n+\tprivate final MessageId id;\n+\tprivate final String producerComponentId;\n+\n+\n+\t/**\n+\t * Constructor which sets defaults for producerComponentId, taskId, and componentID\n+\t * @param flinkTuple the Flink tuple\n+\t * @param schema The schema of the storm fields\n+\t */\n+\tStormTuple(final IN flinkTuple, final Fields schema) {\n+\t\tthis(flinkTuple, schema, -1, \"testStream\", \"componentID\");\n+\t}","path":"flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java","position":25,"original_position":25,"commit_id":"d73468d047e10f443d627ea1a50dd70b0e42c57c","original_commit_id":"9fa66a67b8a44e46ba78a1f503b87ea3fa0f4b31","user":{"login":"mjsax","id":8959638,"avatar_url":"https://avatars.githubusercontent.com/u/8959638?v=3","gravatar_id":"","url":"https://api.github.com/users/mjsax","html_url":"https://github.com/mjsax","followers_url":"https://api.github.com/users/mjsax/followers","following_url":"https://api.github.com/users/mjsax/following{/other_user}","gists_url":"https://api.github.com/users/mjsax/gists{/gist_id}","starred_url":"https://api.github.com/users/mjsax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjsax/subscriptions","organizations_url":"https://api.github.com/users/mjsax/orgs","repos_url":"https://api.github.com/users/mjsax/repos","events_url":"https://api.github.com/users/mjsax/events{/privacy}","received_events_url":"https://api.github.com/users/mjsax/received_events","type":"User","site_admin":false},"body":"Are this meaningful/helpful defaults? Why not just set it to `null`?","created_at":"2015-11-25T17:18:56Z","updated_at":"2015-11-25T17:18:56Z","html_url":"https://github.com/apache/flink/pull/1398#discussion_r45894174","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/1398","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/45894174"},"html":{"href":"https://github.com/apache/flink/pull/1398#discussion_r45894174"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/1398"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/1398","id":51638971,"html_url":"https://github.com/apache/flink/pull/1398","diff_url":"https://github.com/apache/flink/pull/1398.diff","patch_url":"https://github.com/apache/flink/pull/1398.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/1398","number":1398,"state":"open","locked":false,"title":"[FLINK-2837][storm] various improvements for Storm compatibility","user":{"login":"mxm","id":837221,"avatar_url":"https://avatars.githubusercontent.com/u/837221?v=3","gravatar_id":"","url":"https://api.github.com/users/mxm","html_url":"https://github.com/mxm","followers_url":"https://api.github.com/users/mxm/followers","following_url":"https://api.github.com/users/mxm/following{/other_user}","gists_url":"https://api.github.com/users/mxm/gists{/gist_id}","starred_url":"https://api.github.com/users/mxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxm/subscriptions","organizations_url":"https://api.github.com/users/mxm/orgs","repos_url":"https://api.github.com/users/mxm/repos","events_url":"https://api.github.com/users/mxm/events{/privacy}","received_events_url":"https://api.github.com/users/mxm/received_events","type":"User","site_admin":false},"body":"This pull request contains various fixes. Most prominently, the parsing logic for Storm topologies has been changed to support multiple inputs. The API has been redone slightly. Two new examples have been added.\r\n\r\n- refactor to use Storm's topology builder\r\n\r\n- remove FlinkTopologyBuilder\r\n\r\n- instantiate context-based StreamExecutionEnvironment (local or remote)\r\n\r\n- remove Flink and Storm behavior replicating classes\r\n\r\n- modify FlinkTopology to parse Storm topology directly\r\n\r\n- replace StormTestBase with StreamingTestBase\r\n\r\n- let the FiniteFileSpout finish in corner cases\r\n\r\n- expose taskId, fix off by one task id\r\n\r\n- add print example\r\n\r\n- FlinkTopologyBuilder changes (check if all inputs are available before processing)\r\n\r\n- correct package typo\r\n\r\n- support getter methods on TupleWrapper\r\n\r\n- two input support\r\n\r\n- add join example\r\n\r\n- update docs\r\n\r\n- use Flink file system access","created_at":"2015-11-24T10:09:02Z","updated_at":"2015-11-25T17:18:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee12675c12da1175bd8cb62570930e363ae0fedd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/1398/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/1398/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/1398/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/d73468d047e10f443d627ea1a50dd70b0e42c57c","head":{"label":"mxm:storm-dev-dev","ref":"storm-dev-dev","sha":"d73468d047e10f443d627ea1a50dd70b0e42c57c","user":{"login":"mxm","id":837221,"avatar_url":"https://avatars.githubusercontent.com/u/837221?v=3","gravatar_id":"","url":"https://api.github.com/users/mxm","html_url":"https://github.com/mxm","followers_url":"https://api.github.com/users/mxm/followers","following_url":"https://api.github.com/users/mxm/following{/other_user}","gists_url":"https://api.github.com/users/mxm/gists{/gist_id}","starred_url":"https://api.github.com/users/mxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxm/subscriptions","organizations_url":"https://api.github.com/users/mxm/orgs","repos_url":"https://api.github.com/users/mxm/repos","events_url":"https://api.github.com/users/mxm/events{/privacy}","received_events_url":"https://api.github.com/users/mxm/received_events","type":"User","site_admin":false},"repo":{"id":25965625,"name":"flink","full_name":"mxm/flink","owner":{"login":"mxm","id":837221,"avatar_url":"https://avatars.githubusercontent.com/u/837221?v=3","gravatar_id":"","url":"https://api.github.com/users/mxm","html_url":"https://github.com/mxm","followers_url":"https://api.github.com/users/mxm/followers","following_url":"https://api.github.com/users/mxm/following{/other_user}","gists_url":"https://api.github.com/users/mxm/gists{/gist_id}","starred_url":"https://api.github.com/users/mxm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxm/subscriptions","organizations_url":"https://api.github.com/users/mxm/orgs","repos_url":"https://api.github.com/users/mxm/repos","events_url":"https://api.github.com/users/mxm/events{/privacy}","received_events_url":"https://api.github.com/users/mxm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mxm/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/mxm/flink","forks_url":"https://api.github.com/repos/mxm/flink/forks","keys_url":"https://api.github.com/repos/mxm/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mxm/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mxm/flink/teams","hooks_url":"https://api.github.com/repos/mxm/flink/hooks","issue_events_url":"https://api.github.com/repos/mxm/flink/issues/events{/number}","events_url":"https://api.github.com/repos/mxm/flink/events","assignees_url":"https://api.github.com/repos/mxm/flink/assignees{/user}","branches_url":"https://api.github.com/repos/mxm/flink/branches{/branch}","tags_url":"https://api.github.com/repos/mxm/flink/tags","blobs_url":"https://api.github.com/repos/mxm/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mxm/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mxm/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/mxm/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mxm/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/mxm/flink/languages","stargazers_url":"https://api.github.com/repos/mxm/flink/stargazers","contributors_url":"https://api.github.com/repos/mxm/flink/contributors","subscribers_url":"https://api.github.com/repos/mxm/flink/subscribers","subscription_url":"https://api.github.com/repos/mxm/flink/subscription","commits_url":"https://api.github.com/repos/mxm/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/mxm/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/mxm/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/mxm/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/mxm/flink/contents/{+path}","compare_url":"https://api.github.com/repos/mxm/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mxm/flink/merges","archive_url":"https://api.github.com/repos/mxm/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mxm/flink/downloads","issues_url":"https://api.github.com/repos/mxm/flink/issues{/number}","pulls_url":"https://api.github.com/repos/mxm/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/mxm/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/mxm/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mxm/flink/labels{/name}","releases_url":"https://api.github.com/repos/mxm/flink/releases{/id}","created_at":"2014-10-30T10:24:48Z","updated_at":"2015-04-29T12:00:18Z","pushed_at":"2015-11-25T17:18:50Z","git_url":"git://github.com/mxm/flink.git","ssh_url":"git@github.com:mxm/flink.git","clone_url":"https://github.com/mxm/flink.git","svn_url":"https://github.com/mxm/flink","homepage":null,"size":69159,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8fddbf06c14965ba06cd8135a09ca4aa0a65aea5","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","created_at":"2014-06-07T07:00:10Z","updated_at":"2015-11-24T15:03:26Z","pushed_at":"2015-11-25T17:18:51Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":85278,"stargazers_count":761,"watchers_count":761,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":512,"mirror_url":"git://git.apache.org/incubator-flink.git","open_issues_count":72,"forks":512,"open_issues":72,"watchers":761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/1398"},"html":{"href":"https://github.com/apache/flink/pull/1398"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/1398"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/1398/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/1398/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/1398/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/d73468d047e10f443d627ea1a50dd70b0e42c57c"}}}}