{"action":"created","comment":{"url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/comments/32040685","id":32040685,"diff_hunk":"@@ -450,8 +450,11 @@ typedef enum _sai_acl_entry_attr_t\n     /* Set egress packet sampling (samplepacket session id) [sai_object_id_t] */\n     SAI_ACL_ENTRY_ATTR_ACTION_EGRESS_SAMPLEPACKET_ENABLE,\n \n+    /* Set CPU Queue for CPU bound traffic [sai_uint16_t] */\n+    SAI_ACL_ENTRY_ATTR_ACTION_SET_CPU_QUEUE,","path":"sai/inc/saiacl.h","position":5,"original_position":5,"commit_id":"22d42d71cf02d376a8a50035ee92face739fba42","original_commit_id":"22d42d71cf02d376a8a50035ee92face739fba42","user":{"login":"lguohan","id":2293967,"avatar_url":"https://avatars.githubusercontent.com/u/2293967?v=3","gravatar_id":"","url":"https://api.github.com/users/lguohan","html_url":"https://github.com/lguohan","followers_url":"https://api.github.com/users/lguohan/followers","following_url":"https://api.github.com/users/lguohan/following{/other_user}","gists_url":"https://api.github.com/users/lguohan/gists{/gist_id}","starred_url":"https://api.github.com/users/lguohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lguohan/subscriptions","organizations_url":"https://api.github.com/users/lguohan/orgs","repos_url":"https://api.github.com/users/lguohan/repos","events_url":"https://api.github.com/users/lguohan/events{/privacy}","received_events_url":"https://api.github.com/users/lguohan/received_events","type":"User","site_admin":false},"body":"in the qos proposal, we have TC_2_EGRESS_QUEUE mapping, is it ok to use TC instead of set the CPU queue directly? the current SAI_ACL_ENTRY_ATTR_ACTION_SET_TC is for forwarded packet, is it ok to use SAI_ACL_ENTRY_ATTR_ACTION_SET_CPU_TC instead of SAI_ACL_ENTRY_ATTR_ACTION_SET_CPU_QUEUE here?","created_at":"2015-06-09T17:36:19Z","updated_at":"2015-06-09T17:36:19Z","html_url":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions/pull/97#discussion_r32040685","pull_request_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/comments/32040685"},"html":{"href":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions/pull/97#discussion_r32040685"},"pull_request":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/97","id":36697991,"html_url":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions/pull/97","diff_url":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions/pull/97.diff","patch_url":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions/pull/97.patch","issue_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/issues/97","number":97,"state":"open","locked":false,"title":"New SAI ACL Action Proposed to set CPU Queue","user":{"login":"ramangupta","id":11197048,"avatar_url":"https://avatars.githubusercontent.com/u/11197048?v=3","gravatar_id":"","url":"https://api.github.com/users/ramangupta","html_url":"https://github.com/ramangupta","followers_url":"https://api.github.com/users/ramangupta/followers","following_url":"https://api.github.com/users/ramangupta/following{/other_user}","gists_url":"https://api.github.com/users/ramangupta/gists{/gist_id}","starred_url":"https://api.github.com/users/ramangupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramangupta/subscriptions","organizations_url":"https://api.github.com/users/ramangupta/orgs","repos_url":"https://api.github.com/users/ramangupta/repos","events_url":"https://api.github.com/users/ramangupta/events{/privacy}","received_events_url":"https://api.github.com/users/ramangupta/received_events","type":"User","site_admin":false},"body":"The CPU is responsible for processing control plane traffic. Control plane traffic consists of transmit/receive protocol packets or CPU bound traffic. \r\n\r\nPackets are checked against CAM entries and a packet may be identified as CPU bound based on protocols configured within the system. These CPU bound packets needs to be marked for certain ingress CPU Queues for processing. Each of these CPU Queues is rate limited and would help in avoiding protocol flaps due to heavy CPU bound traffic. \r\n\r\nAn additional ACL entry action is needed to specify the CPU queue to which packets need to be sent to the CPU.\r\n","created_at":"2015-06-02T06:27:14Z","updated_at":"2015-06-09T17:36:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a0966a3c0cd8f4c2ba78b58cd82f12873a483d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/97/commits","review_comments_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/97/comments","review_comment_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/issues/97/comments","statuses_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/statuses/22d42d71cf02d376a8a50035ee92face739fba42","head":{"label":"ramangupta:master","ref":"master","sha":"22d42d71cf02d376a8a50035ee92face739fba42","user":{"login":"ramangupta","id":11197048,"avatar_url":"https://avatars.githubusercontent.com/u/11197048?v=3","gravatar_id":"","url":"https://api.github.com/users/ramangupta","html_url":"https://github.com/ramangupta","followers_url":"https://api.github.com/users/ramangupta/followers","following_url":"https://api.github.com/users/ramangupta/following{/other_user}","gists_url":"https://api.github.com/users/ramangupta/gists{/gist_id}","starred_url":"https://api.github.com/users/ramangupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramangupta/subscriptions","organizations_url":"https://api.github.com/users/ramangupta/orgs","repos_url":"https://api.github.com/users/ramangupta/repos","events_url":"https://api.github.com/users/ramangupta/events{/privacy}","received_events_url":"https://api.github.com/users/ramangupta/received_events","type":"User","site_admin":false},"repo":{"id":36712198,"name":"OCP-Networking-Project-Community-Contributions","full_name":"ramangupta/OCP-Networking-Project-Community-Contributions","owner":{"login":"ramangupta","id":11197048,"avatar_url":"https://avatars.githubusercontent.com/u/11197048?v=3","gravatar_id":"","url":"https://api.github.com/users/ramangupta","html_url":"https://github.com/ramangupta","followers_url":"https://api.github.com/users/ramangupta/followers","following_url":"https://api.github.com/users/ramangupta/following{/other_user}","gists_url":"https://api.github.com/users/ramangupta/gists{/gist_id}","starred_url":"https://api.github.com/users/ramangupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramangupta/subscriptions","organizations_url":"https://api.github.com/users/ramangupta/orgs","repos_url":"https://api.github.com/users/ramangupta/repos","events_url":"https://api.github.com/users/ramangupta/events{/privacy}","received_events_url":"https://api.github.com/users/ramangupta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ramangupta/OCP-Networking-Project-Community-Contributions","description":"WARNING: This repository will hold software contributions that are being worked on collaboratively by the OCP Networking Community. Code in this repository has not yet been approved and accepted by the OCP Incubation Committee.  Software in this repository should be not be used on production machines and should be treated as you would any Alpha/Beta release or any software that is in development.","fork":true,"url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions","forks_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/forks","keys_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/teams","hooks_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/hooks","issue_events_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/issues/events{/number}","events_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/events","assignees_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/assignees{/user}","branches_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/branches{/branch}","tags_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/tags","blobs_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/statuses/{sha}","languages_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/languages","stargazers_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/stargazers","contributors_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/contributors","subscribers_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/subscribers","subscription_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/subscription","commits_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/contents/{+path}","compare_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/merges","archive_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/downloads","issues_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/issues{/number}","pulls_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/pulls{/number}","milestones_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/milestones{/number}","notifications_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/labels{/name}","releases_url":"https://api.github.com/repos/ramangupta/OCP-Networking-Project-Community-Contributions/releases{/id}","created_at":"2015-06-02T06:14:31Z","updated_at":"2015-06-02T06:14:31Z","pushed_at":"2015-06-02T06:19:26Z","git_url":"git://github.com/ramangupta/OCP-Networking-Project-Community-Contributions.git","ssh_url":"git@github.com:ramangupta/OCP-Networking-Project-Community-Contributions.git","clone_url":"https://github.com/ramangupta/OCP-Networking-Project-Community-Contributions.git","svn_url":"https://github.com/ramangupta/OCP-Networking-Project-Community-Contributions","homepage":"","size":5651,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencomputeproject:master","ref":"master","sha":"effefc6b40061e203f3965aac7e58b20489141d4","user":{"login":"opencomputeproject","id":4722382,"avatar_url":"https://avatars.githubusercontent.com/u/4722382?v=3","gravatar_id":"","url":"https://api.github.com/users/opencomputeproject","html_url":"https://github.com/opencomputeproject","followers_url":"https://api.github.com/users/opencomputeproject/followers","following_url":"https://api.github.com/users/opencomputeproject/following{/other_user}","gists_url":"https://api.github.com/users/opencomputeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/opencomputeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencomputeproject/subscriptions","organizations_url":"https://api.github.com/users/opencomputeproject/orgs","repos_url":"https://api.github.com/users/opencomputeproject/repos","events_url":"https://api.github.com/users/opencomputeproject/events{/privacy}","received_events_url":"https://api.github.com/users/opencomputeproject/received_events","type":"User","site_admin":false},"repo":{"id":27199774,"name":"OCP-Networking-Project-Community-Contributions","full_name":"opencomputeproject/OCP-Networking-Project-Community-Contributions","owner":{"login":"opencomputeproject","id":4722382,"avatar_url":"https://avatars.githubusercontent.com/u/4722382?v=3","gravatar_id":"","url":"https://api.github.com/users/opencomputeproject","html_url":"https://github.com/opencomputeproject","followers_url":"https://api.github.com/users/opencomputeproject/followers","following_url":"https://api.github.com/users/opencomputeproject/following{/other_user}","gists_url":"https://api.github.com/users/opencomputeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/opencomputeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencomputeproject/subscriptions","organizations_url":"https://api.github.com/users/opencomputeproject/orgs","repos_url":"https://api.github.com/users/opencomputeproject/repos","events_url":"https://api.github.com/users/opencomputeproject/events{/privacy}","received_events_url":"https://api.github.com/users/opencomputeproject/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions","description":"WARNING: This repository will hold software contributions that are being worked on collaboratively by the OCP Networking Community. Code in this repository has not yet been approved and accepted by the OCP Incubation Committee.  Software in this repository should be not be used on production machines and should be treated as you would any Alpha/Beta release or any software that is in development.","fork":false,"url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions","forks_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/forks","keys_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/teams","hooks_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/hooks","issue_events_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/issues/events{/number}","events_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/events","assignees_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/assignees{/user}","branches_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/branches{/branch}","tags_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/tags","blobs_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/statuses/{sha}","languages_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/languages","stargazers_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/stargazers","contributors_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/contributors","subscribers_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/subscribers","subscription_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/subscription","commits_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/contents/{+path}","compare_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/merges","archive_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/downloads","issues_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/issues{/number}","pulls_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls{/number}","milestones_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/milestones{/number}","notifications_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/labels{/name}","releases_url":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/releases{/id}","created_at":"2014-11-26T22:53:43Z","updated_at":"2015-05-08T01:51:19Z","pushed_at":"2015-06-08T08:58:16Z","git_url":"git://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions.git","ssh_url":"git@github.com:opencomputeproject/OCP-Networking-Project-Community-Contributions.git","clone_url":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions.git","svn_url":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions","homepage":"","size":8400,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":18,"forks":31,"open_issues":18,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/97"},"html":{"href":"https://github.com/opencomputeproject/OCP-Networking-Project-Community-Contributions/pull/97"},"issue":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/issues/97"},"comments":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/opencomputeproject/OCP-Networking-Project-Community-Contributions/statuses/22d42d71cf02d376a8a50035ee92face739fba42"}}}}