{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/238","labels_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/238/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/238/comments","events_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/238/events","html_url":"https://github.com/apache/incubator-zeppelin/pull/238","id":102411272,"number":238,"title":"Adding leaflet and data validator - Testing CI","user":{"login":"Madhuka","id":1180128,"avatar_url":"https://avatars.githubusercontent.com/u/1180128?v=3","gravatar_id":"","url":"https://api.github.com/users/Madhuka","html_url":"https://github.com/Madhuka","followers_url":"https://api.github.com/users/Madhuka/followers","following_url":"https://api.github.com/users/Madhuka/following{/other_user}","gists_url":"https://api.github.com/users/Madhuka/gists{/gist_id}","starred_url":"https://api.github.com/users/Madhuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Madhuka/subscriptions","organizations_url":"https://api.github.com/users/Madhuka/orgs","repos_url":"https://api.github.com/users/Madhuka/repos","events_url":"https://api.github.com/users/Madhuka/events{/privacy}","received_events_url":"https://api.github.com/users/Madhuka/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-21T16:03:59Z","updated_at":"2015-09-29T14:11:00Z","closed_at":"2015-09-08T03:59:44Z","pull_request":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/pulls/238","html_url":"https://github.com/apache/incubator-zeppelin/pull/238","diff_url":"https://github.com/apache/incubator-zeppelin/pull/238.diff","patch_url":"https://github.com/apache/incubator-zeppelin/pull/238.patch"},"body":" - [x] Adding leaflet for map\r\n - [x]  Adding map UI for zeppelin\r\n - [x] Adding map chart for zeppelin\r\n - [x] Adding sample tutorial for notebook on map\r\n - [x] Adding SQL for tutorial\r\n - [x] Adding data validation \r\n - [x] Test Cases\r\n\r\nThis PR is CI fixing for PR#152 for data validation and adding leaflet map for zeppelin"},"comment":{"url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/comments/144072730","html_url":"https://github.com/apache/incubator-zeppelin/pull/238#issuecomment-144072730","issue_url":"https://api.github.com/repos/apache/incubator-zeppelin/issues/238","id":144072730,"user":{"login":"datagiraffe","id":1486265,"avatar_url":"https://avatars.githubusercontent.com/u/1486265?v=3","gravatar_id":"","url":"https://api.github.com/users/datagiraffe","html_url":"https://github.com/datagiraffe","followers_url":"https://api.github.com/users/datagiraffe/followers","following_url":"https://api.github.com/users/datagiraffe/following{/other_user}","gists_url":"https://api.github.com/users/datagiraffe/gists{/gist_id}","starred_url":"https://api.github.com/users/datagiraffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datagiraffe/subscriptions","organizations_url":"https://api.github.com/users/datagiraffe/orgs","repos_url":"https://api.github.com/users/datagiraffe/repos","events_url":"https://api.github.com/users/datagiraffe/events{/privacy}","received_events_url":"https://api.github.com/users/datagiraffe/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T14:11:00Z","updated_at":"2015-09-29T14:11:00Z","body":"Map Visualization for Zeppelin would be a great addition!\r\nI've tried the code and ran into several problems.\r\n\r\nI don't think it's good to select the lat and lon statically like so:\r\nhttps://github.com/Madhuka/incubator-zeppelin/blob/milestone05-map/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js#L866\r\nIt would be nice if they were detected automatically. Maybe if there are columns lat, latitude, lon, long or longitude, pick them?\r\n\r\nThe same goes for the key:\r\nhttps://github.com/Madhuka/incubator-zeppelin/blob/milestone05-map/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js#L863\r\nIf a key exists twice, it obviously breaks. Key and message are the same though, but I may be interested in the same message at different locations.\r\n\r\nThere should be a settings drop down like for the other chart types where this can be configured. With the current version, that doesn't seem to work. (Only for me?)"}}