{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/galleryplus/issues/160","labels_url":"https://api.github.com/repos/owncloud/galleryplus/issues/160/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/galleryplus/issues/160/comments","events_url":"https://api.github.com/repos/owncloud/galleryplus/issues/160/events","html_url":"https://github.com/owncloud/galleryplus/issues/160","id":80689703,"number":160,"title":"Slideshow: should the browser back button behave the same as the X icon? [$5]","user":{"login":"setnes","id":12475102,"avatar_url":"https://avatars.githubusercontent.com/u/12475102?v=3","gravatar_id":"","url":"https://api.github.com/users/setnes","html_url":"https://github.com/setnes","followers_url":"https://api.github.com/users/setnes/followers","following_url":"https://api.github.com/users/setnes/following{/other_user}","gists_url":"https://api.github.com/users/setnes/gists{/gist_id}","starred_url":"https://api.github.com/users/setnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/setnes/subscriptions","organizations_url":"https://api.github.com/users/setnes/orgs","repos_url":"https://api.github.com/users/setnes/repos","events_url":"https://api.github.com/users/setnes/events{/privacy}","received_events_url":"https://api.github.com/users/setnes/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/galleryplus/labels/8.0","name":"8.0","color":"5C3D1F"},{"url":"https://api.github.com/repos/owncloud/galleryplus/labels/8.1","name":"8.1","color":"7A5229"},{"url":"https://api.github.com/repos/owncloud/galleryplus/labels/bounty","name":"bounty","color":"9e9012"},{"url":"https://api.github.com/repos/owncloud/galleryplus/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/owncloud/galleryplus/labels/enhancement","name":"enhancement","color":"02e10c"},{"url":"https://api.github.com/repos/owncloud/galleryplus/labels/feature:slideshow","name":"feature:slideshow","color":"d4c5f9"},{"url":"https://api.github.com/repos/owncloud/galleryplus/labels/QA%20-%20Testing","name":"QA - Testing","color":"02d7e1"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/galleryplus/milestones/11","html_url":"https://github.com/owncloud/galleryplus/milestones/13%20(2015-07-12)","labels_url":"https://api.github.com/repos/owncloud/galleryplus/milestones/11/labels","id":1174265,"number":11,"title":"13 (2015-07-12)","description":"","creator":{"login":"oparoz","id":323220,"avatar_url":"https://avatars.githubusercontent.com/u/323220?v=3","gravatar_id":"","url":"https://api.github.com/users/oparoz","html_url":"https://github.com/oparoz","followers_url":"https://api.github.com/users/oparoz/followers","following_url":"https://api.github.com/users/oparoz/following{/other_user}","gists_url":"https://api.github.com/users/oparoz/gists{/gist_id}","starred_url":"https://api.github.com/users/oparoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oparoz/subscriptions","organizations_url":"https://api.github.com/users/oparoz/orgs","repos_url":"https://api.github.com/users/oparoz/repos","events_url":"https://api.github.com/users/oparoz/events{/privacy}","received_events_url":"https://api.github.com/users/oparoz/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":1,"state":"open","created_at":"2015-06-21T23:02:55Z","updated_at":"2015-07-08T17:22:08Z","due_on":"2015-07-11T22:00:00Z","closed_at":null},"comments":22,"created_at":"2015-05-25T22:28:37Z","updated_at":"2015-07-10T11:29:08Z","closed_at":null,"body":"The browser's back button doesn't behave as expected.  If clicking the big X in the upper right side of the screen exits the slide show, perhaps the back button should do the same thing.  I feel a bit trapped in the slide show on a mobile device if the back button doesn't actually exit.  I'm not sure what is correct here from a UI standpoint though.  One could also make a case that back should just go to the previous image.\r\n\r\n## @oparoz's assessment of the situation\r\n### Files\r\n\r\nHow it works\r\n* Folder1->Folder2.\r\n* Slideshow is launched. Folder2 is renamed Folder2#slideshow, but it's the same position in the history\r\n* Pressing close rewrites the URL again, back to Folder2, but pressing back goes back to Folder1!\r\n\r\nPressing on \"close\":\r\n* keeps the position in the files list\r\n* \"erases\" the slideshow from history by rewriting the URL\r\n\r\nPressing on \"back\":\r\n* gives the impression of going two steps back since the slideshow doesn't modify the history.\r\n*  loses both the position in the list and the folder from which the slideshow was launched\r\n\r\n## @oparoz's acceptance criteria\r\n### Files\r\n\r\n- [x] Exact vertical position in Files is not lost when exiting the slideshow via the back button\r\n- [ ] Files app is not reloaded when exiting the slideshow via the back button. **Blocked by owncloud/core#14828**\r\n- [x] Pressing back several times goes through the entire history\r\n- [ ] Pressing forward after exiting the slideshow reloads the last slide which was in view in the slideshow. **Blocked by owncloud/core#14828**\r\n\r\n### Photowall\r\n\r\n- [x] Exact vertical position in Photowall is not lost when exiting the slideshow via the back button\r\n- [x] Current album is not reloaded when exiting the slideshow via the back button\r\n- [x] Reloading the app while browsing the slideshow should load the exact same slide\r\n- [x] Pressing back several times goes through the entire history\r\n- [x] Pressing forward after exiting the slideshow reloads the last slide which was in view in the slideshow\r\n\r\n### General\r\n- [ ] Everything above works both in the private and public spaces\r\n\r\n<bountysource-plugin>\r\n---\r\nThere is a **[$5 open bounty](https://www.bountysource.com/issues/17669693-slideshow-should-the-browser-back-button-behave-the-same-as-the-x-icon?utm_campaign=plugin&utm_content=tracker%2F9328526&utm_medium=issues&utm_source=github)** on this issue. Add to the bounty at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F9328526&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"},"comment":{"url":"https://api.github.com/repos/owncloud/galleryplus/issues/comments/120389308","html_url":"https://github.com/owncloud/galleryplus/issues/160#issuecomment-120389308","issue_url":"https://api.github.com/repos/owncloud/galleryplus/issues/160","id":120389308,"user":{"login":"oparoz","id":323220,"avatar_url":"https://avatars.githubusercontent.com/u/323220?v=3","gravatar_id":"","url":"https://api.github.com/users/oparoz","html_url":"https://github.com/oparoz","followers_url":"https://api.github.com/users/oparoz/followers","following_url":"https://api.github.com/users/oparoz/following{/other_user}","gists_url":"https://api.github.com/users/oparoz/gists{/gist_id}","starred_url":"https://api.github.com/users/oparoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oparoz/subscriptions","organizations_url":"https://api.github.com/users/oparoz/orgs","repos_url":"https://api.github.com/users/oparoz/repos","events_url":"https://api.github.com/users/oparoz/events{/privacy}","received_events_url":"https://api.github.com/users/oparoz/received_events","type":"User","site_admin":false},"created_at":"2015-07-10T11:29:08Z","updated_at":"2015-07-10T11:29:08Z","body":"Good eye. It's always been there on Firefox and I didn't care much for it, but now that I'm trying to harmonize the apps' behaviour, I should take care of this.\r\n\r\nWe will need a new ticket so that designers can help me decide which option is best."}}