{"action":"created","comment":{"url":"https://api.github.com/repos/opf/openproject/pulls/comments/34070149","id":34070149,"diff_hunk":"@@ -36,17 +36,19 @@\n Project\n \n PlanningElementTypeColor.colors.map(&:save)\n-default_color = PlanningElementTypeColor.find_by_name('Grey-light')\n+default_color = PlanningElementTypeColor.find_by(name: 'Grey-light')\n \n-::Type.find_or_create_by_is_standard(true, name: 'none',\n-                                         position: 0,\n-                                         color_id: default_color.id,\n-                                         is_default: true,\n-                                         is_in_roadmap: true,\n-                                         in_aggregation: true,\n-                                         is_milestone: false)\n+::Type.find_or_create_by(is_standard: true) do |type|\n+  type.name           = 'none'\n+  type.position       = 0\n+  type.color_id       = default_color.id\n+  type.is_default     = true\n+  type.is_in_roadmap  = true\n+  type.in_aggregation = true\n+  type.is_milestone   = false","path":"db/seeds/all.rb","position":21,"original_position":21,"commit_id":"8b4be7f749fbe577cfc563224734d3ebd705d38b","original_commit_id":"8b4be7f749fbe577cfc563224734d3ebd705d38b","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Unnecessary spacing detected.","created_at":"2015-07-07T18:02:23Z","updated_at":"2015-07-07T18:02:23Z","html_url":"https://github.com/opf/openproject/pull/3194#discussion_r34070149","pull_request_url":"https://api.github.com/repos/opf/openproject/pulls/3194","_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/34070149"},"html":{"href":"https://github.com/opf/openproject/pull/3194#discussion_r34070149"},"pull_request":{"href":"https://api.github.com/repos/opf/openproject/pulls/3194"}}},"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/3194","id":38769157,"html_url":"https://github.com/opf/openproject/pull/3194","diff_url":"https://github.com/opf/openproject/pull/3194.diff","patch_url":"https://github.com/opf/openproject/pull/3194.patch","issue_url":"https://api.github.com/repos/opf/openproject/issues/3194","number":3194,"state":"open","locked":false,"title":"[20325][20701] Replace dynamic finders, fix ActiveRecord deprecation warnings","user":{"login":"myabc","id":755,"avatar_url":"https://avatars.githubusercontent.com/u/755?v=3","gravatar_id":"","url":"https://api.github.com/users/myabc","html_url":"https://github.com/myabc","followers_url":"https://api.github.com/users/myabc/followers","following_url":"https://api.github.com/users/myabc/following{/other_user}","gists_url":"https://api.github.com/users/myabc/gists{/gist_id}","starred_url":"https://api.github.com/users/myabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myabc/subscriptions","organizations_url":"https://api.github.com/users/myabc/orgs","repos_url":"https://api.github.com/users/myabc/repos","events_url":"https://api.github.com/users/myabc/events{/privacy}","received_events_url":"https://api.github.com/users/myabc/received_events","type":"User","site_admin":false},"body":":information_desk_person: **This PR doesn't deal with deprecation warnings that are not ActiveRecord related.** \r\n\r\nSupercedes #3186\r\n\r\nhttps://community.openproject.org/work_packages/20325\r\nhttps://community.openproject.org/work_packages/20701","created_at":"2015-06-29T12:39:32Z","updated_at":"2015-07-07T18:02:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b3f1747596b279391ba7805cf7f5415828ae397","assignee":{"login":"NobodysNightmare","id":453584,"avatar_url":"https://avatars.githubusercontent.com/u/453584?v=3","gravatar_id":"","url":"https://api.github.com/users/NobodysNightmare","html_url":"https://github.com/NobodysNightmare","followers_url":"https://api.github.com/users/NobodysNightmare/followers","following_url":"https://api.github.com/users/NobodysNightmare/following{/other_user}","gists_url":"https://api.github.com/users/NobodysNightmare/gists{/gist_id}","starred_url":"https://api.github.com/users/NobodysNightmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NobodysNightmare/subscriptions","organizations_url":"https://api.github.com/users/NobodysNightmare/orgs","repos_url":"https://api.github.com/users/NobodysNightmare/repos","events_url":"https://api.github.com/users/NobodysNightmare/events{/privacy}","received_events_url":"https://api.github.com/users/NobodysNightmare/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/opf/openproject/milestones/3","html_url":"https://github.com/opf/openproject/milestones/4.3","labels_url":"https://api.github.com/repos/opf/openproject/milestones/3/labels","id":1104474,"number":3,"title":"4.3","description":"","creator":{"login":"myabc","id":755,"avatar_url":"https://avatars.githubusercontent.com/u/755?v=3","gravatar_id":"","url":"https://api.github.com/users/myabc","html_url":"https://github.com/myabc","followers_url":"https://api.github.com/users/myabc/followers","following_url":"https://api.github.com/users/myabc/following{/other_user}","gists_url":"https://api.github.com/users/myabc/gists{/gist_id}","starred_url":"https://api.github.com/users/myabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myabc/subscriptions","organizations_url":"https://api.github.com/users/myabc/orgs","repos_url":"https://api.github.com/users/myabc/repos","events_url":"https://api.github.com/users/myabc/events{/privacy}","received_events_url":"https://api.github.com/users/myabc/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":1,"state":"open","created_at":"2015-05-11T10:04:28Z","updated_at":"2015-07-06T12:36:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/opf/openproject/pulls/3194/commits","review_comments_url":"https://api.github.com/repos/opf/openproject/pulls/3194/comments","review_comment_url":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opf/openproject/issues/3194/comments","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/8b4be7f749fbe577cfc563224734d3ebd705d38b","head":{"label":"myabc:feature/20325-rails4-deprecated-dynamic-finders","ref":"feature/20325-rails4-deprecated-dynamic-finders","sha":"8b4be7f749fbe577cfc563224734d3ebd705d38b","user":{"login":"myabc","id":755,"avatar_url":"https://avatars.githubusercontent.com/u/755?v=3","gravatar_id":"","url":"https://api.github.com/users/myabc","html_url":"https://github.com/myabc","followers_url":"https://api.github.com/users/myabc/followers","following_url":"https://api.github.com/users/myabc/following{/other_user}","gists_url":"https://api.github.com/users/myabc/gists{/gist_id}","starred_url":"https://api.github.com/users/myabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myabc/subscriptions","organizations_url":"https://api.github.com/users/myabc/orgs","repos_url":"https://api.github.com/users/myabc/repos","events_url":"https://api.github.com/users/myabc/events{/privacy}","received_events_url":"https://api.github.com/users/myabc/received_events","type":"User","site_admin":false},"repo":{"id":31470518,"name":"openproject","full_name":"myabc/openproject","owner":{"login":"myabc","id":755,"avatar_url":"https://avatars.githubusercontent.com/u/755?v=3","gravatar_id":"","url":"https://api.github.com/users/myabc","html_url":"https://github.com/myabc","followers_url":"https://api.github.com/users/myabc/followers","following_url":"https://api.github.com/users/myabc/following{/other_user}","gists_url":"https://api.github.com/users/myabc/gists{/gist_id}","starred_url":"https://api.github.com/users/myabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myabc/subscriptions","organizations_url":"https://api.github.com/users/myabc/orgs","repos_url":"https://api.github.com/users/myabc/repos","events_url":"https://api.github.com/users/myabc/events{/privacy}","received_events_url":"https://api.github.com/users/myabc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/myabc/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":true,"url":"https://api.github.com/repos/myabc/openproject","forks_url":"https://api.github.com/repos/myabc/openproject/forks","keys_url":"https://api.github.com/repos/myabc/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/myabc/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/myabc/openproject/teams","hooks_url":"https://api.github.com/repos/myabc/openproject/hooks","issue_events_url":"https://api.github.com/repos/myabc/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/myabc/openproject/events","assignees_url":"https://api.github.com/repos/myabc/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/myabc/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/myabc/openproject/tags","blobs_url":"https://api.github.com/repos/myabc/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/myabc/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/myabc/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/myabc/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/myabc/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/myabc/openproject/languages","stargazers_url":"https://api.github.com/repos/myabc/openproject/stargazers","contributors_url":"https://api.github.com/repos/myabc/openproject/contributors","subscribers_url":"https://api.github.com/repos/myabc/openproject/subscribers","subscription_url":"https://api.github.com/repos/myabc/openproject/subscription","commits_url":"https://api.github.com/repos/myabc/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/myabc/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/myabc/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/myabc/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/myabc/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/myabc/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/myabc/openproject/merges","archive_url":"https://api.github.com/repos/myabc/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/myabc/openproject/downloads","issues_url":"https://api.github.com/repos/myabc/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/myabc/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/myabc/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/myabc/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/myabc/openproject/labels{/name}","releases_url":"https://api.github.com/repos/myabc/openproject/releases{/id}","created_at":"2015-02-28T17:43:54Z","updated_at":"2015-03-21T23:11:24Z","pushed_at":"2015-07-07T18:01:09Z","git_url":"git://github.com/myabc/openproject.git","ssh_url":"git@github.com:myabc/openproject.git","clone_url":"https://github.com/myabc/openproject.git","svn_url":"https://github.com/myabc/openproject","homepage":"https://www.openproject.org","size":67487,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"opf:feature/rails4","ref":"feature/rails4","sha":"dabb98a871cfb6bf1f226eef14535b3cf7c10568","user":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"repo":{"id":6899875,"name":"openproject","full_name":"opf/openproject","owner":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opf/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/opf/openproject","forks_url":"https://api.github.com/repos/opf/openproject/forks","keys_url":"https://api.github.com/repos/opf/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opf/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opf/openproject/teams","hooks_url":"https://api.github.com/repos/opf/openproject/hooks","issue_events_url":"https://api.github.com/repos/opf/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/opf/openproject/events","assignees_url":"https://api.github.com/repos/opf/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/opf/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/opf/openproject/tags","blobs_url":"https://api.github.com/repos/opf/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opf/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opf/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/opf/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/opf/openproject/languages","stargazers_url":"https://api.github.com/repos/opf/openproject/stargazers","contributors_url":"https://api.github.com/repos/opf/openproject/contributors","subscribers_url":"https://api.github.com/repos/opf/openproject/subscribers","subscription_url":"https://api.github.com/repos/opf/openproject/subscription","commits_url":"https://api.github.com/repos/opf/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/opf/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/opf/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/opf/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/opf/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/opf/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opf/openproject/merges","archive_url":"https://api.github.com/repos/opf/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opf/openproject/downloads","issues_url":"https://api.github.com/repos/opf/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/opf/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/opf/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/opf/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opf/openproject/labels{/name}","releases_url":"https://api.github.com/repos/opf/openproject/releases{/id}","created_at":"2012-11-28T09:59:11Z","updated_at":"2015-07-07T13:42:30Z","pushed_at":"2015-07-07T18:01:10Z","git_url":"git://github.com/opf/openproject.git","ssh_url":"git@github.com:opf/openproject.git","clone_url":"https://github.com/opf/openproject.git","svn_url":"https://github.com/opf/openproject","homepage":"https://www.openproject.org","size":202045,"stargazers_count":658,"watchers_count":658,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":284,"mirror_url":null,"open_issues_count":41,"forks":284,"open_issues":41,"watchers":658,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/3194"},"html":{"href":"https://github.com/opf/openproject/pull/3194"},"issue":{"href":"https://api.github.com/repos/opf/openproject/issues/3194"},"comments":{"href":"https://api.github.com/repos/opf/openproject/issues/3194/comments"},"review_comments":{"href":"https://api.github.com/repos/opf/openproject/pulls/3194/comments"},"review_comment":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opf/openproject/pulls/3194/commits"},"statuses":{"href":"https://api.github.com/repos/opf/openproject/statuses/8b4be7f749fbe577cfc563224734d3ebd705d38b"}}}}