{"action":"created","issue":{"url":"https://api.github.com/repos/undeadlabs/discovery/issues/13","labels_url":"https://api.github.com/repos/undeadlabs/discovery/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/undeadlabs/discovery/issues/13/comments","events_url":"https://api.github.com/repos/undeadlabs/discovery/issues/13/events","html_url":"https://github.com/undeadlabs/discovery/pull/13","id":66011263,"number":13,"title":"Added a default \"otp_name\" if not defined","user":{"login":"cjimison","id":356626,"avatar_url":"https://avatars.githubusercontent.com/u/356626?v=3","gravatar_id":"","url":"https://api.github.com/users/cjimison","html_url":"https://github.com/cjimison","followers_url":"https://api.github.com/users/cjimison/followers","following_url":"https://api.github.com/users/cjimison/following{/other_user}","gists_url":"https://api.github.com/users/cjimison/gists{/gist_id}","starred_url":"https://api.github.com/users/cjimison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjimison/subscriptions","organizations_url":"https://api.github.com/users/cjimison/orgs","repos_url":"https://api.github.com/users/cjimison/repos","events_url":"https://api.github.com/users/cjimison/events{/privacy}","received_events_url":"https://api.github.com/users/cjimison/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-02T21:04:56Z","updated_at":"2015-04-03T01:21:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/undeadlabs/discovery/pulls/13","html_url":"https://github.com/undeadlabs/discovery/pull/13","diff_url":"https://github.com/undeadlabs/discovery/pull/13.diff","patch_url":"https://github.com/undeadlabs/discovery/pull/13.patch"},"body":"The idea here is I may have many VM's or other services defined where I don't want to modify the serviceX.json file for each.  With this change, if there is no tags or no otp_name defined it will assume that the otp_name should be Discovery.Node.name@Discovery.Node.Address.\r\n\r\nI can see where this is very situational and it works for us, so you will not hurt my feelings if you reject this pull request :)"},"comment":{"url":"https://api.github.com/repos/undeadlabs/discovery/issues/comments/89106688","html_url":"https://github.com/undeadlabs/discovery/pull/13#issuecomment-89106688","issue_url":"https://api.github.com/repos/undeadlabs/discovery/issues/13","id":89106688,"user":{"login":"reset","id":54036,"avatar_url":"https://avatars.githubusercontent.com/u/54036?v=3","gravatar_id":"","url":"https://api.github.com/users/reset","html_url":"https://github.com/reset","followers_url":"https://api.github.com/users/reset/followers","following_url":"https://api.github.com/users/reset/following{/other_user}","gists_url":"https://api.github.com/users/reset/gists{/gist_id}","starred_url":"https://api.github.com/users/reset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reset/subscriptions","organizations_url":"https://api.github.com/users/reset/orgs","repos_url":"https://api.github.com/users/reset/repos","events_url":"https://api.github.com/users/reset/events{/privacy}","received_events_url":"https://api.github.com/users/reset/received_events","type":"User","site_admin":false},"created_at":"2015-04-03T01:21:20Z","updated_at":"2015-04-03T01:21:20Z","body":"@cjimison I think it's perfectly reasonable to provide a default otp_name when one is not specified. It would be great if you could get some test coverage on this before we merge it in! Thanks for the PR :)"}}