{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/45914202","id":45914202,"diff_hunk":"@@ -0,0 +1,128 @@\n+/*\n+ * Copyright © 2015 Cask Data, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not\n+ * use this file except in compliance with the License. You may obtain a copy of\n+ * the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+\n+package co.cask.cdap.api.dataset.lib.partitioned;\n+\n+import co.cask.cdap.api.Predicate;\n+import co.cask.cdap.api.dataset.lib.PartitionDetail;\n+\n+import java.util.concurrent.TimeUnit;\n+import javax.annotation.Nullable;\n+\n+/**\n+ * Configuration parameters to be used by a {@link PartitionConsumer}.\n+ */\n+public class ConsumerConfiguration {\n+  /**\n+   * Instance of ConsumerConfiguration with default parameters\n+   */\n+  public static final ConsumerConfiguration DEFAULT = builder().build();\n+\n+  private final Predicate<PartitionDetail> partitionPredicate;\n+  private final int maxWorkingSetSize;\n+  private final long timeout;\n+\n+  private ConsumerConfiguration(Predicate<PartitionDetail> partitionPredicate,\n+                                int maxWorkingSetSize, long timeout) {\n+    this.partitionPredicate = partitionPredicate;\n+    this.maxWorkingSetSize = maxWorkingSetSize;\n+    this.timeout = timeout;\n+  }\n+\n+  /**\n+   * @return A predicate to be applied on {@link PartitionDetail}s to determine which partitions to include in the\n+   *         partition consumption.\n+   */\n+  public Predicate<PartitionDetail> getPartitionPredicate() {\n+    return partitionPredicate;\n+  }\n+\n+  /**\n+   * @return An upper bound on the size of the working set of partitions that get serialized as part of the consumer's\n+   *         state.\n+   */\n+  public int getMaxWorkingSetSize() {\n+    return maxWorkingSetSize;\n+  }\n+\n+  /**\n+   * Defines an expiration timeout, in seconds, of IN_PROGRESS partitions\n+   * @return number of seconds that a partition can be in progress before it is deemed failed.\n+   */\n+  public long getTimeout() {\n+    return timeout;\n+  }\n+\n+  /**\n+   * @return a {@link Builder} instance to build an instance of a ConsumerConfiguration.\n+   */\n+  public static Builder builder() {\n+    return new Builder();\n+  }\n+\n+  /**\n+   * A Builder to construct ConsumerConfiguration instances.\n+   */\n+  public static class Builder {\n+    /**\n+     * Default values\n+     */\n+    private Predicate<PartitionDetail> partitionPredicate = new Predicate<PartitionDetail>() {\n+      @Override\n+      public boolean apply(@Nullable PartitionDetail input) {\n+        return true;\n+      }\n+    };\n+    private int maxWorkingSetSize = 1000;\n+    // 12 hour timeout\n+    private long timeout = TimeUnit.HOURS.toSeconds(12);;\n+\n+    private Builder() {\n+    }\n+\n+    /**\n+     * Sets the Predicate of the ConsumerConfiguration.\n+     */\n+    public Builder setPartitionPredicate(Predicate<PartitionDetail> partitionPredicate) {\n+      this.partitionPredicate = partitionPredicate;\n+      return this;\n+    }\n+\n+    /**\n+     * Sets the maximum working set size of the ConsumerConfiguration.\n+     */\n+    public Builder setMaxWorkingSetSize(int maxWorkingSetSize) {\n+      this.maxWorkingSetSize = maxWorkingSetSize;\n+      return this;\n+    }\n+\n+    /**\n+     * Sets the timeout of the ConsumerConfiguration.\n+     */\n+    public Builder setTimeout(long timeout) {","path":"cdap-api/src/main/java/co/cask/cdap/api/dataset/lib/partitioned/ConsumerConfiguration.java","position":115,"original_position":115,"commit_id":"910083356fa17ed413ea716d72a48fabfb39d45d","original_commit_id":"910083356fa17ed413ea716d72a48fabfb39d45d","user":{"login":"anew","id":483004,"avatar_url":"https://avatars.githubusercontent.com/u/483004?v=3","gravatar_id":"","url":"https://api.github.com/users/anew","html_url":"https://github.com/anew","followers_url":"https://api.github.com/users/anew/followers","following_url":"https://api.github.com/users/anew/following{/other_user}","gists_url":"https://api.github.com/users/anew/gists{/gist_id}","starred_url":"https://api.github.com/users/anew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anew/subscriptions","organizations_url":"https://api.github.com/users/anew/orgs","repos_url":"https://api.github.com/users/anew/repos","events_url":"https://api.github.com/users/anew/events{/privacy}","received_events_url":"https://api.github.com/users/anew/received_events","type":"User","site_admin":false},"body":"It is not clear to me what the timeout means. If a partition in marked as in-progress, and it times out, what happens? Is it considered new again? Or is it discarded from the working set? Is that documented somewhere?\r\n ","created_at":"2015-11-25T20:12:58Z","updated_at":"2015-11-25T20:12:58Z","html_url":"https://github.com/caskdata/cdap/pull/4621#discussion_r45914202","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/4621","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/45914202"},"html":{"href":"https://github.com/caskdata/cdap/pull/4621#discussion_r45914202"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/4621"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/4621","id":51605742,"html_url":"https://github.com/caskdata/cdap/pull/4621","diff_url":"https://github.com/caskdata/cdap/pull/4621.diff","patch_url":"https://github.com/caskdata/cdap/pull/4621.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/4621","number":4621,"state":"open","locked":false,"title":"Feature/cdap 3944 multiple partition consumers part 2","user":{"login":"anwar6953","id":2440977,"avatar_url":"https://avatars.githubusercontent.com/u/2440977?v=3","gravatar_id":"","url":"https://api.github.com/users/anwar6953","html_url":"https://github.com/anwar6953","followers_url":"https://api.github.com/users/anwar6953/followers","following_url":"https://api.github.com/users/anwar6953/following{/other_user}","gists_url":"https://api.github.com/users/anwar6953/gists{/gist_id}","starred_url":"https://api.github.com/users/anwar6953/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anwar6953/subscriptions","organizations_url":"https://api.github.com/users/anwar6953/orgs","repos_url":"https://api.github.com/users/anwar6953/repos","events_url":"https://api.github.com/users/anwar6953/events{/privacy}","received_events_url":"https://api.github.com/users/anwar6953/received_events","type":"User","site_admin":false},"body":"This PR contains changes required to support multiple, concurrent partition consumers. A summary is below.\r\n\r\nDepends on: https://github.com/caskdata/cdap/pull/4620 (so review only the last commit of this PR).\r\n\r\nhttps://issues.cask.co/browse/CDAP-3944\r\nhttp://builds.cask.co/browse/CDAP-DUT3216\r\nhttps://wiki.cask.co/display/CE/Multiple+Partition+Consumers+and+Other+Customizability\r\n\r\nSummary:\r\nIncremental consuming of partitions was serial. The consuming state only allowed for one consumer.\r\nIn order to have multiple (potentially-longrunning) consumers, the state that is kept is a working set of partitions (and their state - `NEW` or `IN_PROGRESS`).\r\nNow, when consuming clients ask for partitions, this working set will be populated with new partitions from the partitioned file set, and the partitions (up to a given limit) will be returned from this working set of partitions, and accordingly marked as `IN_PROGRESS`.\r\nThere is a `ConsumerConfiguration` class which defines parameters for this querying pipeline.\r\n\r\nNote: a follow up PR will have utility classes for use of this functionality from a Worker and a MapReduce, as well as example usage.","created_at":"2015-11-24T01:28:45Z","updated_at":"2015-11-25T20:12:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61db593ecc28cafa26b33be4743958b145e7cd36","assignee":{"login":"anew","id":483004,"avatar_url":"https://avatars.githubusercontent.com/u/483004?v=3","gravatar_id":"","url":"https://api.github.com/users/anew","html_url":"https://github.com/anew","followers_url":"https://api.github.com/users/anew/followers","following_url":"https://api.github.com/users/anew/following{/other_user}","gists_url":"https://api.github.com/users/anew/gists{/gist_id}","starred_url":"https://api.github.com/users/anew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anew/subscriptions","organizations_url":"https://api.github.com/users/anew/orgs","repos_url":"https://api.github.com/users/anew/repos","events_url":"https://api.github.com/users/anew/events{/privacy}","received_events_url":"https://api.github.com/users/anew/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/4621/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/4621/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/4621/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/910083356fa17ed413ea716d72a48fabfb39d45d","head":{"label":"caskdata:feature/CDAP-3944-multiple-partition-consumers-part-2","ref":"feature/CDAP-3944-multiple-partition-consumers-part-2","sha":"910083356fa17ed413ea716d72a48fabfb39d45d","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-11-19T21:25:40Z","pushed_at":"2015-11-25T19:48:32Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":514401,"stargazers_count":84,"watchers_count":84,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":22,"forks":27,"open_issues":22,"watchers":84,"default_branch":"develop"}},"base":{"label":"caskdata:develop","ref":"develop","sha":"a5cc5a4f5abde6b4c9a3cc7763d1fb3bdaf33803","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-11-19T21:25:40Z","pushed_at":"2015-11-25T19:48:32Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":514401,"stargazers_count":84,"watchers_count":84,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":22,"forks":27,"open_issues":22,"watchers":84,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/4621"},"html":{"href":"https://github.com/caskdata/cdap/pull/4621"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/4621"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/4621/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/4621/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/4621/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/910083356fa17ed413ea716d72a48fabfb39d45d"}}}}