{"action":"created","comment":{"url":"https://api.github.com/repos/SpongePowered/Sponge/pulls/comments/23987774","id":23987774,"diff_hunk":"@@ -97,7 +101,24 @@ public String getImplementationVersion() {\n \n     @Override\n     public MinecraftVersion getMinecraftVersion() {\n-        throw new UnsupportedOperationException(); // TODO\n+\t    MinecraftVersion mcvToReturn;\n+\n+\t    // Get the MC version and protocol version from the MC server, then parse it so we can use it earlier\n+\t    ServerStatusResponse.MinecraftProtocolVersionIdentifier protocolVersionInfo = MinecraftServer.getServer().getServerStatusResponse().getProtocolVersionInfo();\n+\t    String name = protocolVersionInfo.getName();\n+\t    int protocolVersion = protocolVersionInfo.getProtocol();\n+\t    double numberVersion = Double.valueOf(name);\n+\n+\t    // If the version is less than 1.7 it is considered legacy and must be handled differently\n+\t    if (numberVersion < 1.7) {","path":"src/main/java/org/spongepowered/mod/SpongeGame.java","position":42,"original_position":42,"commit_id":"640dc4da9ff4dd78eb0d44e4259b004d2c28055e","original_commit_id":"640dc4da9ff4dd78eb0d44e4259b004d2c28055e","user":{"login":"bloodmc","id":2998171,"avatar_url":"https://avatars.githubusercontent.com/u/2998171?v=3","gravatar_id":"","url":"https://api.github.com/users/bloodmc","html_url":"https://github.com/bloodmc","followers_url":"https://api.github.com/users/bloodmc/followers","following_url":"https://api.github.com/users/bloodmc/following{/other_user}","gists_url":"https://api.github.com/users/bloodmc/gists{/gist_id}","starred_url":"https://api.github.com/users/bloodmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloodmc/subscriptions","organizations_url":"https://api.github.com/users/bloodmc/orgs","repos_url":"https://api.github.com/users/bloodmc/repos","events_url":"https://api.github.com/users/bloodmc/events{/privacy}","received_events_url":"https://api.github.com/users/bloodmc/received_events","type":"User","site_admin":false},"body":"Our implementation will never support legacy so there is no need to check for 1.7 and under.","created_at":"2015-02-03T07:59:40Z","updated_at":"2015-02-03T07:59:40Z","html_url":"https://github.com/SpongePowered/Sponge/pull/157#discussion_r23987774","pull_request_url":"https://api.github.com/repos/SpongePowered/Sponge/pulls/157","_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/Sponge/pulls/comments/23987774"},"html":{"href":"https://github.com/SpongePowered/Sponge/pull/157#discussion_r23987774"},"pull_request":{"href":"https://api.github.com/repos/SpongePowered/Sponge/pulls/157"}}},"pull_request":{"url":"https://api.github.com/repos/SpongePowered/Sponge/pulls/157","id":28523592,"html_url":"https://github.com/SpongePowered/Sponge/pull/157","diff_url":"https://github.com/SpongePowered/Sponge/pull/157.diff","patch_url":"https://github.com/SpongePowered/Sponge/pull/157.patch","issue_url":"https://api.github.com/repos/SpongePowered/Sponge/issues/157","number":157,"state":"open","locked":false,"title":"Add code for getMinecraftVersion() and fix \"gradle javadoc\"","user":{"login":"sirsavary","id":718338,"avatar_url":"https://avatars.githubusercontent.com/u/718338?v=3","gravatar_id":"","url":"https://api.github.com/users/sirsavary","html_url":"https://github.com/sirsavary","followers_url":"https://api.github.com/users/sirsavary/followers","following_url":"https://api.github.com/users/sirsavary/following{/other_user}","gists_url":"https://api.github.com/users/sirsavary/gists{/gist_id}","starred_url":"https://api.github.com/users/sirsavary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirsavary/subscriptions","organizations_url":"https://api.github.com/users/sirsavary/orgs","repos_url":"https://api.github.com/users/sirsavary/repos","events_url":"https://api.github.com/users/sirsavary/events{/privacy}","received_events_url":"https://api.github.com/users/sirsavary/received_events","type":"User","site_admin":false},"body":"With the help of Sibomots I wrote some code so getMinecraftVersion() in SpongeGame would work. However, we're not sure if the singleton approach is the best.\r\n\r\nI also fixed \"gradle javadoc\" from throwing errors but there is a file that needs to be fixed. I removed a \"@see\" annotation thinking it was invalid when really the error was caused by the annotation being immediately followed by a \"@link\" annotation.","created_at":"2015-02-03T03:12:49Z","updated_at":"2015-02-03T07:59:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3456972c6cd3e45c7c66f7d01094ba2ef13d67f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SpongePowered/Sponge/pulls/157/commits","review_comments_url":"https://api.github.com/repos/SpongePowered/Sponge/pulls/157/comments","review_comment_url":"https://api.github.com/repos/SpongePowered/Sponge/pulls/comments/{number}","comments_url":"https://api.github.com/repos/SpongePowered/Sponge/issues/157/comments","statuses_url":"https://api.github.com/repos/SpongePowered/Sponge/statuses/640dc4da9ff4dd78eb0d44e4259b004d2c28055e","head":{"label":"sirsavary:master","ref":"master","sha":"640dc4da9ff4dd78eb0d44e4259b004d2c28055e","user":{"login":"sirsavary","id":718338,"avatar_url":"https://avatars.githubusercontent.com/u/718338?v=3","gravatar_id":"","url":"https://api.github.com/users/sirsavary","html_url":"https://github.com/sirsavary","followers_url":"https://api.github.com/users/sirsavary/followers","following_url":"https://api.github.com/users/sirsavary/following{/other_user}","gists_url":"https://api.github.com/users/sirsavary/gists{/gist_id}","starred_url":"https://api.github.com/users/sirsavary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirsavary/subscriptions","organizations_url":"https://api.github.com/users/sirsavary/orgs","repos_url":"https://api.github.com/users/sirsavary/repos","events_url":"https://api.github.com/users/sirsavary/events{/privacy}","received_events_url":"https://api.github.com/users/sirsavary/received_events","type":"User","site_admin":false},"repo":{"id":30096843,"name":"Sponge","full_name":"sirsavary/Sponge","owner":{"login":"sirsavary","id":718338,"avatar_url":"https://avatars.githubusercontent.com/u/718338?v=3","gravatar_id":"","url":"https://api.github.com/users/sirsavary","html_url":"https://github.com/sirsavary","followers_url":"https://api.github.com/users/sirsavary/followers","following_url":"https://api.github.com/users/sirsavary/following{/other_user}","gists_url":"https://api.github.com/users/sirsavary/gists{/gist_id}","starred_url":"https://api.github.com/users/sirsavary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirsavary/subscriptions","organizations_url":"https://api.github.com/users/sirsavary/orgs","repos_url":"https://api.github.com/users/sirsavary/repos","events_url":"https://api.github.com/users/sirsavary/events{/privacy}","received_events_url":"https://api.github.com/users/sirsavary/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sirsavary/Sponge","description":"A Forge mod that implements SpongeAPI","fork":true,"url":"https://api.github.com/repos/sirsavary/Sponge","forks_url":"https://api.github.com/repos/sirsavary/Sponge/forks","keys_url":"https://api.github.com/repos/sirsavary/Sponge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sirsavary/Sponge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sirsavary/Sponge/teams","hooks_url":"https://api.github.com/repos/sirsavary/Sponge/hooks","issue_events_url":"https://api.github.com/repos/sirsavary/Sponge/issues/events{/number}","events_url":"https://api.github.com/repos/sirsavary/Sponge/events","assignees_url":"https://api.github.com/repos/sirsavary/Sponge/assignees{/user}","branches_url":"https://api.github.com/repos/sirsavary/Sponge/branches{/branch}","tags_url":"https://api.github.com/repos/sirsavary/Sponge/tags","blobs_url":"https://api.github.com/repos/sirsavary/Sponge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sirsavary/Sponge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sirsavary/Sponge/git/refs{/sha}","trees_url":"https://api.github.com/repos/sirsavary/Sponge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sirsavary/Sponge/statuses/{sha}","languages_url":"https://api.github.com/repos/sirsavary/Sponge/languages","stargazers_url":"https://api.github.com/repos/sirsavary/Sponge/stargazers","contributors_url":"https://api.github.com/repos/sirsavary/Sponge/contributors","subscribers_url":"https://api.github.com/repos/sirsavary/Sponge/subscribers","subscription_url":"https://api.github.com/repos/sirsavary/Sponge/subscription","commits_url":"https://api.github.com/repos/sirsavary/Sponge/commits{/sha}","git_commits_url":"https://api.github.com/repos/sirsavary/Sponge/git/commits{/sha}","comments_url":"https://api.github.com/repos/sirsavary/Sponge/comments{/number}","issue_comment_url":"https://api.github.com/repos/sirsavary/Sponge/issues/comments/{number}","contents_url":"https://api.github.com/repos/sirsavary/Sponge/contents/{+path}","compare_url":"https://api.github.com/repos/sirsavary/Sponge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sirsavary/Sponge/merges","archive_url":"https://api.github.com/repos/sirsavary/Sponge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sirsavary/Sponge/downloads","issues_url":"https://api.github.com/repos/sirsavary/Sponge/issues{/number}","pulls_url":"https://api.github.com/repos/sirsavary/Sponge/pulls{/number}","milestones_url":"https://api.github.com/repos/sirsavary/Sponge/milestones{/number}","notifications_url":"https://api.github.com/repos/sirsavary/Sponge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sirsavary/Sponge/labels{/name}","releases_url":"https://api.github.com/repos/sirsavary/Sponge/releases{/id}","created_at":"2015-01-31T00:21:36Z","updated_at":"2015-02-03T07:36:24Z","pushed_at":"2015-02-03T07:36:23Z","git_url":"git://github.com/sirsavary/Sponge.git","ssh_url":"git@github.com:sirsavary/Sponge.git","clone_url":"https://github.com/sirsavary/Sponge.git","svn_url":"https://github.com/sirsavary/Sponge","homepage":"http://www.spongepowered.org/","size":5234,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SpongePowered:master","ref":"master","sha":"cdf7868c462d05782599e909915060dbe41950ef","user":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":23774298,"name":"Sponge","full_name":"SpongePowered/Sponge","owner":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/Sponge","description":"A Forge mod that implements SpongeAPI","fork":false,"url":"https://api.github.com/repos/SpongePowered/Sponge","forks_url":"https://api.github.com/repos/SpongePowered/Sponge/forks","keys_url":"https://api.github.com/repos/SpongePowered/Sponge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/Sponge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/Sponge/teams","hooks_url":"https://api.github.com/repos/SpongePowered/Sponge/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/Sponge/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/Sponge/events","assignees_url":"https://api.github.com/repos/SpongePowered/Sponge/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/Sponge/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/Sponge/tags","blobs_url":"https://api.github.com/repos/SpongePowered/Sponge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/Sponge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/Sponge/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/Sponge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/Sponge/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/Sponge/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/Sponge/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/Sponge/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/Sponge/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/Sponge/subscription","commits_url":"https://api.github.com/repos/SpongePowered/Sponge/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/Sponge/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/Sponge/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/Sponge/issues/comments/{number}","contents_url":"https://api.github.com/repos/SpongePowered/Sponge/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/Sponge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/Sponge/merges","archive_url":"https://api.github.com/repos/SpongePowered/Sponge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/Sponge/downloads","issues_url":"https://api.github.com/repos/SpongePowered/Sponge/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/Sponge/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/Sponge/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/Sponge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/Sponge/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/Sponge/releases{/id}","created_at":"2014-09-08T00:01:33Z","updated_at":"2015-02-02T09:22:50Z","pushed_at":"2015-02-03T07:32:58Z","git_url":"git://github.com/SpongePowered/Sponge.git","ssh_url":"git@github.com:SpongePowered/Sponge.git","clone_url":"https://github.com/SpongePowered/Sponge.git","svn_url":"https://github.com/SpongePowered/Sponge","homepage":"http://www.spongepowered.org/","size":5234,"stargazers_count":724,"watchers_count":724,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":292,"mirror_url":null,"open_issues_count":13,"forks":292,"open_issues":13,"watchers":724,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/Sponge/pulls/157"},"html":{"href":"https://github.com/SpongePowered/Sponge/pull/157"},"issue":{"href":"https://api.github.com/repos/SpongePowered/Sponge/issues/157"},"comments":{"href":"https://api.github.com/repos/SpongePowered/Sponge/issues/157/comments"},"review_comments":{"href":"https://api.github.com/repos/SpongePowered/Sponge/pulls/157/comments"},"review_comment":{"href":"https://api.github.com/repos/SpongePowered/Sponge/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/SpongePowered/Sponge/pulls/157/commits"},"statuses":{"href":"https://api.github.com/repos/SpongePowered/Sponge/statuses/640dc4da9ff4dd78eb0d44e4259b004d2c28055e"}}}}