{"action":"created","issue":{"url":"https://api.github.com/repos/rails/rails/issues/21218","labels_url":"https://api.github.com/repos/rails/rails/issues/21218/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/21218/comments","events_url":"https://api.github.com/repos/rails/rails/issues/21218/events","html_url":"https://github.com/rails/rails/pull/21218","id":100668861,"number":21218,"title":"WIP: Fix the AS::Callbacks terminator regression from 4.2.3","user":{"login":"repinel","id":1685896,"avatar_url":"https://avatars.githubusercontent.com/u/1685896?v=3","gravatar_id":"","url":"https://api.github.com/users/repinel","html_url":"https://github.com/repinel","followers_url":"https://api.github.com/users/repinel/followers","following_url":"https://api.github.com/users/repinel/following{/other_user}","gists_url":"https://api.github.com/users/repinel/gists{/gist_id}","starred_url":"https://api.github.com/users/repinel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/repinel/subscriptions","organizations_url":"https://api.github.com/users/repinel/orgs","repos_url":"https://api.github.com/users/repinel/repos","events_url":"https://api.github.com/users/repinel/events{/privacy}","received_events_url":"https://api.github.com/users/repinel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rails/rails/labels/activesupport","name":"activesupport","color":"FC9300"}],"state":"open","locked":false,"assignee":{"login":"claudiob","id":10076,"avatar_url":"https://avatars.githubusercontent.com/u/10076?v=3","gravatar_id":"","url":"https://api.github.com/users/claudiob","html_url":"https://github.com/claudiob","followers_url":"https://api.github.com/users/claudiob/followers","following_url":"https://api.github.com/users/claudiob/following{/other_user}","gists_url":"https://api.github.com/users/claudiob/gists{/gist_id}","starred_url":"https://api.github.com/users/claudiob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudiob/subscriptions","organizations_url":"https://api.github.com/users/claudiob/orgs","repos_url":"https://api.github.com/users/claudiob/repos","events_url":"https://api.github.com/users/claudiob/events{/privacy}","received_events_url":"https://api.github.com/users/claudiob/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/rails/rails/milestones/34","html_url":"https://github.com/rails/rails/milestones/5.0.0","labels_url":"https://api.github.com/repos/rails/rails/milestones/34/labels","id":665192,"number":34,"title":"5.0.0","description":null,"creator":{"login":"rafaelfranca","id":47848,"avatar_url":"https://avatars.githubusercontent.com/u/47848?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelfranca","html_url":"https://github.com/rafaelfranca","followers_url":"https://api.github.com/users/rafaelfranca/followers","following_url":"https://api.github.com/users/rafaelfranca/following{/other_user}","gists_url":"https://api.github.com/users/rafaelfranca/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelfranca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelfranca/subscriptions","organizations_url":"https://api.github.com/users/rafaelfranca/orgs","repos_url":"https://api.github.com/users/rafaelfranca/repos","events_url":"https://api.github.com/users/rafaelfranca/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelfranca/received_events","type":"User","site_admin":false},"open_issues":93,"closed_issues":146,"state":"open","created_at":"2014-05-21T00:58:22Z","updated_at":"2015-09-21T19:22:45Z","due_on":null,"closed_at":null},"comments":13,"created_at":"2015-08-13T01:11:50Z","updated_at":"2015-09-23T17:04:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/21218","html_url":"https://github.com/rails/rails/pull/21218","diff_url":"https://github.com/rails/rails/pull/21218.diff","patch_url":"https://github.com/rails/rails/pull/21218.patch"},"body":"Rails 4.2.3 AS::Callbacks will not halt chain if `false` is returned. That is the behavior of specific callbacks like AR::Callbacks and AM::Callbacks.\r\n\r\nThe two test cases from https://gist.github.com/repinel/93ab39881825d913466d might illustrate my point.\r\n\r\nFixes #21122\r\n\r\n@claudiob @kaspth What do you think?"},"comment":{"url":"https://api.github.com/repos/rails/rails/issues/comments/142664544","html_url":"https://github.com/rails/rails/pull/21218#issuecomment-142664544","issue_url":"https://api.github.com/repos/rails/rails/issues/21218","id":142664544,"user":{"login":"claudiob","id":10076,"avatar_url":"https://avatars.githubusercontent.com/u/10076?v=3","gravatar_id":"","url":"https://api.github.com/users/claudiob","html_url":"https://github.com/claudiob","followers_url":"https://api.github.com/users/claudiob/followers","following_url":"https://api.github.com/users/claudiob/following{/other_user}","gists_url":"https://api.github.com/users/claudiob/gists{/gist_id}","starred_url":"https://api.github.com/users/claudiob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudiob/subscriptions","organizations_url":"https://api.github.com/users/claudiob/orgs","repos_url":"https://api.github.com/users/claudiob/repos","events_url":"https://api.github.com/users/claudiob/events{/privacy}","received_events_url":"https://api.github.com/users/claudiob/received_events","type":"User","site_admin":false},"created_at":"2015-09-23T17:04:50Z","updated_at":"2015-09-23T17:04:50Z","body":"@repinel This looks good to me.\r\n\r\n@kaspth Do you want to give it a look? If you are also fine, just merge :grinning: "}}