{"action":"created","issue":{"url":"https://api.github.com/repos/Elgg/Elgg/issues/8124","labels_url":"https://api.github.com/repos/Elgg/Elgg/issues/8124/labels{/name}","comments_url":"https://api.github.com/repos/Elgg/Elgg/issues/8124/comments","events_url":"https://api.github.com/repos/Elgg/Elgg/issues/8124/events","html_url":"https://github.com/Elgg/Elgg/issues/8124","id":67295289,"number":8124,"title":"Refinement of elgg-list-river margin","user":{"login":"PerJensen","id":1220345,"avatar_url":"https://avatars.githubusercontent.com/u/1220345?v=3","gravatar_id":"","url":"https://api.github.com/users/PerJensen","html_url":"https://github.com/PerJensen","followers_url":"https://api.github.com/users/PerJensen/followers","following_url":"https://api.github.com/users/PerJensen/following{/other_user}","gists_url":"https://api.github.com/users/PerJensen/gists{/gist_id}","starred_url":"https://api.github.com/users/PerJensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PerJensen/subscriptions","organizations_url":"https://api.github.com/users/PerJensen/orgs","repos_url":"https://api.github.com/users/PerJensen/repos","events_url":"https://api.github.com/users/PerJensen/events{/privacy}","received_events_url":"https://api.github.com/users/PerJensen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-09T07:04:57Z","updated_at":"2015-04-09T07:08:13Z","closed_at":null,"body":"The thing is that the new layout of elgg-river-responses has led to an unwanted margin, as seen here:\r\n![elgg-river-responses](https://cloud.githubusercontent.com/assets/1220345/7061806/959afdb2-de96-11e4-99c6-2634c323c258.jpg)\r\nSo we have to remove:\r\n```CSS\r\n.elgg-river-responses {\r\n\tmargin-top: 15px;\r\n}\r\n```\r\nThe declaration, however, was added (wrongly) to adjust the elgg-river-responses margin-top in widgets because of a few other declarations:\r\n```CSS\r\n.elgg-list-river {\r\n\tmargin-top: -10px;\r\n}\r\n.elgg-module .elgg-list {\r\n\tmargin-top: 0;\r\n}\r\n```\r\nI suggest that we remove all and adjusts for margin-top in widgets like this:\r\n```CSS\r\n/* Group modules */\r\n.elgg-module > .elgg-body > .elgg-list,\r\n/* Profile and dashboard widgets */\r\n.elgg-module .elgg-widget-content > .elgg-list {\r\n\tmargin-top: 0;\r\n}\r\n```\r\nHope the explanation makes sense, try adding the changes.\r\n"},"comment":{"url":"https://api.github.com/repos/Elgg/Elgg/issues/comments/91132337","html_url":"https://github.com/Elgg/Elgg/issues/8124#issuecomment-91132337","issue_url":"https://api.github.com/repos/Elgg/Elgg/issues/8124","id":91132337,"user":{"login":"hypeJunction","id":1202761,"avatar_url":"https://avatars.githubusercontent.com/u/1202761?v=3","gravatar_id":"","url":"https://api.github.com/users/hypeJunction","html_url":"https://github.com/hypeJunction","followers_url":"https://api.github.com/users/hypeJunction/followers","following_url":"https://api.github.com/users/hypeJunction/following{/other_user}","gists_url":"https://api.github.com/users/hypeJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/hypeJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypeJunction/subscriptions","organizations_url":"https://api.github.com/users/hypeJunction/orgs","repos_url":"https://api.github.com/users/hypeJunction/repos","events_url":"https://api.github.com/users/hypeJunction/events{/privacy}","received_events_url":"https://api.github.com/users/hypeJunction/received_events","type":"User","site_admin":false},"created_at":"2015-04-09T07:08:13Z","updated_at":"2015-04-09T07:08:13Z","body":"I think we need to look at the river views that generate empty tags. I think they expect false to not generate markup. I remember stripping tags in one of my projects to see if there is any content before rendering them."}}