{"action":"created","issue":{"url":"https://api.github.com/repos/libgit2/libgit2/issues/3448","labels_url":"https://api.github.com/repos/libgit2/libgit2/issues/3448/labels{/name}","comments_url":"https://api.github.com/repos/libgit2/libgit2/issues/3448/comments","events_url":"https://api.github.com/repos/libgit2/libgit2/issues/3448/events","html_url":"https://github.com/libgit2/libgit2/pull/3448","id":109418062,"number":3448,"title":"Support setting custom user-agent","user":{"login":"carlosmn","id":335443,"avatar_url":"https://avatars.githubusercontent.com/u/335443?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosmn","html_url":"https://github.com/carlosmn","followers_url":"https://api.github.com/users/carlosmn/followers","following_url":"https://api.github.com/users/carlosmn/following{/other_user}","gists_url":"https://api.github.com/users/carlosmn/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosmn/subscriptions","organizations_url":"https://api.github.com/users/carlosmn/orgs","repos_url":"https://api.github.com/users/carlosmn/repos","events_url":"https://api.github.com/users/carlosmn/events{/privacy}","received_events_url":"https://api.github.com/users/carlosmn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-02T02:06:52Z","updated_at":"2015-11-12T16:00:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/3448","html_url":"https://github.com/libgit2/libgit2/pull/3448","diff_url":"https://github.com/libgit2/libgit2/pull/3448.diff","patch_url":"https://github.com/libgit2/libgit2/pull/3448.patch"},"body":"It's not just us who wants fame and notoriety, some tools using the library want it to, and want their name in the User-Agent field; let's let them do that.\r\n\r\nWe do have to keep the \"git/1.0\" so that web servers still recognise us as wishing to talk to Git rather than a web server.\r\n\r\nThis is missing the plain/ssh support, since we don't currently send the agent over there. We should also add this capability, which might happen in this PR or not. It would be a new behaviour rather than a change, and would require us to potentially change the string given by the user, as we'd need a slug rather than a generic string."},"comment":{"url":"https://api.github.com/repos/libgit2/libgit2/issues/comments/156148431","html_url":"https://github.com/libgit2/libgit2/pull/3448#issuecomment-156148431","issue_url":"https://api.github.com/repos/libgit2/libgit2/issues/3448","id":156148431,"user":{"login":"ethomson","id":1130014,"avatar_url":"https://avatars.githubusercontent.com/u/1130014?v=3","gravatar_id":"","url":"https://api.github.com/users/ethomson","html_url":"https://github.com/ethomson","followers_url":"https://api.github.com/users/ethomson/followers","following_url":"https://api.github.com/users/ethomson/following{/other_user}","gists_url":"https://api.github.com/users/ethomson/gists{/gist_id}","starred_url":"https://api.github.com/users/ethomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethomson/subscriptions","organizations_url":"https://api.github.com/users/ethomson/orgs","repos_url":"https://api.github.com/users/ethomson/repos","events_url":"https://api.github.com/users/ethomson/events{/privacy}","received_events_url":"https://api.github.com/users/ethomson/received_events","type":"User","site_admin":false},"created_at":"2015-11-12T16:00:40Z","updated_at":"2015-11-12T16:00:40Z","body":":+1:  Let's commit to getting some broader test coverage here for things like custom headers, the user agent, etc.  In the meantime, this is nice and useful and let's merge it and circle back on the tests.\r\n\r\n(How many Microsoft-isms did I fit in to that one sentence?  Hehe.)"}}