{"push_id":698850913,"size":18,"distinct_size":2,"ref":"refs/heads/artifact_cache_subsystem","head":"f6b60416cb011a1512397c9d1093e6170fdf7636","before":"8d7475c00770ae1db5ccf596d7c49dfb203c171f","commits":[{"sha":"ed7ee23f1148762603652bdde8ad7debdd3c0532","author":{"email":"86f39098c3d6e8fa24cceea9f4753c2782977b2d@gmail.com","name":"John Sirois"},"message":"Upgrade to RBTools latest.\n\nTesting Done:\nPosted this review using `./rbt`.\n\nFor full disclosure, actually:\n```console\n./rbt post \\\n  -o \\\n  --target-groups=pants-reviews \\\n  --branch=\"$(git branch | grep \"*\" | cut -d \" \" -f2)\" \\\n  --description=\"$(git slog -1 --format=format:%b)\" \\\n  --summary=\"$(git log -1 --pretty=format:%s)\" \\\n  --bugs=1676 \\\n  --parent=HEAD~1\n```\n\nCI went green here:\n  https://travis-ci.org/pantsbuild/pants/builds/66607040\n\nBugs closed: 1676\n\nReviewed at https://rbcommons.com/s/twitter/r/2360/","distinct":false,"url":"https://api.github.com/repos/benjyw/pants/commits/ed7ee23f1148762603652bdde8ad7debdd3c0532"},{"sha":"37b41b73a53e3c4726296bc143c747950869f9d0","author":{"email":"695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","name":"Eric Ayers"},"message":"pants build committing publish data for push of org.pantsbuild#zinc;1.0.6\n# Prevent Travis-CI from running for this automated jar publish commit:\n#   http://docs.travis-ci.com/user/how-to-skip-a-build/\n[ci skip]","distinct":false,"url":"https://api.github.com/repos/benjyw/pants/commits/37b41b73a53e3c4726296bc143c747950869f9d0"},{"sha":"29b44b8d15016cea4dffa9a611906f1312b2c1dc","author":{"email":"5496d4fd32b46dcb22e495b96a73063ce8ea956b@gmail.com","name":"Garrett Malmquist"},"message":"Fixed errors in how arguments are passed to wire_gen.\n\nArguments such as 'roots' and 'enum_options' are expected to\nbe comma-delimited when multiple arguments exist, not added by repeated\nspecifications of the --roots or --enum_options flags.\n\nTesting Done:\nWire_integration tests (including new test for --roots) pass.\n\nCI went green here: https://travis-ci.org/pantsbuild/pants/builds/66615227\n\nBugs closed: 1664\n\nReviewed at https://rbcommons.com/s/twitter/r/2354/","distinct":false,"url":"https://api.github.com/repos/benjyw/pants/commits/29b44b8d15016cea4dffa9a611906f1312b2c1dc"},{"sha":"6c1ac098535f453af47656cf132a047724c2de5c","author":{"email":"040cff05bd320eb0560246813fe142b421636f09@gmail.com","name":"Benjy Weinberger"},"message":"Add a global --tag option to filter targets based on their tags.\n\n--tag=foo,bar includes only targets that have at least one of those tags.\n--tag=-foo,bar includes only targets that have none of those tags.\n--tag=foo,bar --tag=-baz includes only targets that have at least one\n  of the tags foo or bar, and do not have the tag baz.\n\nThe filtering is on target roots, of course, similar to spec_excludes and\nexclude_target_regexp. Dependencies are included in the targets passed to\nTask.execute() regardless of their tags.\n\nWe already had similar filtering functionality in the Filter task. So I\nrefactored some of that into a new filtering.py file under util.\n\nWhile doing so, I noticed that the help text on Filter's options was wrong:\nIn --tag=-foo,bar the '-' prefix applies to both foo and bar, and\n--tag=-foo,+bar is not sensible. While fixing up the help strings I realized\nthat it would be more succinct to move the common help text (the part\nexplaining about the prefix and how multiple filters are specified) into the\ngoal description.  Then I realized that it would be pretty verbose to put that\nin the with_description() text in register.py, so I added a little thing that\nuses the task's docstring as the description, if one isn't provided explicitly.\n\nNote that Filter still has its own --tag option, which we can think\nabout deprecating in a future change.\n\nIMPORTANT: While testing, I noticed that we had a longstanding bug, where\nmultiple filters of the same type wouldn't work, because in the loop the\nfilter() function was capturing the same references in its closure on each\niteration. See the test I added in test_filter.py - that test fails with no\nother changes at HEAD.\n\nAlso note that the test marked as xfail is behaving as intended: according to\nthe implementation, separate specifications of the same option are ANDed\n(while comma-separated values in a single specification are ORed). If we want\nthe behavior to be different then we can discuss, but for now at least that xfail\nwas inappropriate and misleading.\n\nTesting Done:\nCI passes: https://travis-ci.org/pantsbuild/pants/builds/66695055\n\nReviewed at https://rbcommons.com/s/twitter/r/2362/","distinct":false,"url":"https://api.github.com/repos/benjyw/pants/commits/6c1ac098535f453af47656cf132a047724c2de5c"},{"sha":"80a24682e3c7fe16a0323219cd4b07819c30714b","author":{"email":"695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","name":"Eric Ayers"},"message":"Prepare for release 0.0.33\n\nPrepare changelog and increment pants version to 0.0.33\nRemoved deprecated --project-info related flags from depmap.\n\nTesting Done:\nCI green at https://travis-ci.org/pantsbuild/pants/builds/66739561\n\nBugs closed: 1678\n\nReviewed at https://rbcommons.com/s/twitter/r/2363/","distinct":false,"url":"https://api.github.com/repos/benjyw/pants/commits/80a24682e3c7fe16a0323219cd4b07819c30714b"},{"sha":"3a15b9323ff09e2b5092398bef7f3dd39b076caa","author":{"email":"040cff05bd320eb0560246813fe142b421636f09@gmail.com","name":"Benjy Weinberger"},"message":"Make goal listing use only the first sentence of the description.\n\nNow that the description can be inferred from a task docstring,\nthis is pertinent.\n\nTesting Done:\nManual testing before and after. Ran the list_goals tests.\n\nBugs closed: 1682\n\nReviewed at https://rbcommons.com/s/twitter/r/2366/","distinct":false,"url":"https://api.github.com/repos/benjyw/pants/commits/3a15b9323ff09e2b5092398bef7f3dd39b076caa"},{"sha":"5e2a16f79525c3cc4d3258353ce64e18ab0ea268","author":{"email":"8a48ad68f751b273a85583580b85b5eceb3e5ac9@twopensource.com","name":"Kris Wilson"},"message":"Repair depmap --graph\n\n- Simplify depmap text and graph handlers\n- Make depmap --graph work again\n- Add tests for depmap --graph\n- Eliminate extraneous/duplicated code\n- Convert to generators for immediate output/memory efficiency on larger\n  projects\n\nTesting Done:\nhttps://travis-ci.org/pantsbuild/pants/builds/66331926\n\n+ manual testing in birdcage, reviewing graphviz generated graphs, etc\n\nBugs closed: 1648\n\nReviewed at https://rbcommons.com/s/twitter/r/2345/","distinct":false,"url":"https://api.github.com/repos/benjyw/pants/commits/5e2a16f79525c3cc4d3258353ce64e18ab0ea268"},{"sha":"2da2619c07d88aad116f2c39e81f36766a603bcf","author":{"email":"695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","name":"Eric Ayers"},"message":"Documenetation update for debugging a JVM tool\n\nDocumentation update adds ivysettings.xml information for debugging a tool.\n\nTesting Done:\nI didn't have this stanza in our ivysettings.xml by default, so I added it to my build environment to test some code in junit-runner and zinc.\n\nBugs closed: 1681\n\nReviewed at https://rbcommons.com/s/twitter/r/2365/","distinct":false,"url":"https://api.github.com/repos/benjyw/pants/commits/2da2619c07d88aad116f2c39e81f36766a603bcf"},{"sha":"1cf240b11551840cd84838288c155fd412301eb5","author":{"email":"695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","name":"Eric Ayers"},"message":"typo in the changelog screwed it up for the 0.0.33 release Also fixed formatting of globs and rglobs which were reporting errors from publish_docs\n\nA typo in the changelog screwed it up for the 0.0.33 release.\nAlso sort of fixed formatting of globs and rglobs which were reporting errors from publish_docs, but they still don't look great in the BUILD dictionary.\n\nTesting Done:\nRan ./build-support/bin/publish-docs.sh.  Staged at http://pantsbuild.github.io/staging/zundel\n\nBugs closed: 1691\n\nReviewed at https://rbcommons.com/s/twitter/r/2376/","distinct":false,"url":"https://api.github.com/repos/benjyw/pants/commits/1cf240b11551840cd84838288c155fd412301eb5"},{"sha":"cb0cc7a6517f996a162027dab17c083fa9990bf3","author":{"email":"ae9e2289bfb86617e7df55ccf6837bd754e6357f@twopensource.com","name":"Nick Howard (Twitter)"},"message":"Ensure caliper is shaded in bench, add bench desc, use RUN so that output is printed\n\ncaliper depends on guava 11 which is incompatible with guavas above 15 due to deprecated method removals, adding main to the jvm tool registration causes it to be shaded, which means the older guava won't interfer with code under test that depends on newer guava versions.\n\nI also added a description and set the WorkUnit.RUN label so that the caliper output will be printed to the console by default.\n\nTesting Done:\ntested against a target with a dependency on guava 16, which failed to run without shading. CI in PR\n\nBugs closed: 1674\n\nReviewed at https://rbcommons.com/s/twitter/r/2353/","distinct":false,"url":"https://api.github.com/repos/benjyw/pants/commits/cb0cc7a6517f996a162027dab17c083fa9990bf3"},{"sha":"8b1706ea43dca4875905b2f00c0f42b50a438079","author":{"email":"86f39098c3d6e8fa24cceea9f4753c2782977b2d@gmail.com","name":"John Sirois"},"message":"Add a CONTRIBUTORS maintenance script.\n\nThis includes a .mailmap for regularizing contributor ids as well as\nhandling of the portion of the zinc subtree history before-pants.\n\nTesting Done:\nUsed the script to re-generate the CONTRIBUTORS.md as seen in this\nchange.  Also ran the the script to get the contribution roster since\nthe 0.0.33 release and verified it was accurate by hand:\n```console\n$ ./build-support/bin/contributors.sh -s release_0.0.33\n      2 Eric Ayers\n      1 Nick Howard\n      1 Kris Wilson\n      1 John Sirois\n      1 Benjy Weinberger\n```\n\nCI went green here:\n  https://travis-ci.org/pantsbuild/pants/builds/67089966\n\nBugs closed: 1695\n\nReviewed at https://rbcommons.com/s/twitter/r/2377/","distinct":false,"url":"https://api.github.com/repos/benjyw/pants/commits/8b1706ea43dca4875905b2f00c0f42b50a438079"},{"sha":"8d017956688f791ef68a773d6ce0f63a14af559f","author":{"email":"86f39098c3d6e8fa24cceea9f4753c2782977b2d@gmail.com","name":"John Sirois"},"message":"Fixup formatting of CONTRIBUTORS.md.\n\nThis aligns the contributors vertically via a bulleted list.\n\nThe change also adds some explanation to `.mailmap` about its purpose.\n\nTesting Done:\nThe CONTRIBUTORS.md rendered before:\n  https://github.com/pantsbuild/pants/blob/8b1706ea43dca4875905b2f00c0f42b50a438079/CONTRIBUTORS.md\n\nAnd after:\n  https://github.com/pantsbuild/pants/blob/24075b1cc4e73ab1c7269d6419755766cd20dcc8/CONTRIBUTORS.md\n\nCI is away here:\n  https://travis-ci.org/pantsbuild/pants/builds/67101062\n\nBugs closed: 1696\n\nReviewed at https://rbcommons.com/s/twitter/r/2378/","distinct":false,"url":"https://api.github.com/repos/benjyw/pants/commits/8d017956688f791ef68a773d6ce0f63a14af559f"},{"sha":"09904d7b3b7fbf82541da6a44a378853c65104bc","author":{"email":"86f39098c3d6e8fa24cceea9f4753c2782977b2d@gmail.com","name":"John Sirois"},"message":"Fixup the Git Scm detection of server_url.\n\nPreviously any remote with origin in its name would suffice, leading to\na failure to detect remotes actually named 'origin' or else\nmis-identifying an un-intended server_url.\n\nTesting Done:\nCI went green here:\n  https://travis-ci.org/pantsbuild/pants/builds/67116155\n\nBugs closed: 1444, 1699\n\nReviewed at https://rbcommons.com/s/twitter/r/2379/","distinct":false,"url":"https://api.github.com/repos/benjyw/pants/commits/09904d7b3b7fbf82541da6a44a378853c65104bc"},{"sha":"5a55b2229d3e4fb10d0f71cd608ce5b69b5c3768","author":{"email":"5496d4fd32b46dcb22e495b96a73063ce8ea956b@gmail.com","name":"Garrett Malmquist"},"message":"Fixed a bug where codegen would crash due to a missing flag.\n\nSpecifically, the error message (or warning, depending on the flag) printed if a\ntarget generates the same sources as one of its parents.\n\nAlso fixed a bug where an exception message was in the wrong namespace, which would\nhave crashed nastily if it was ever thrown.\n\nAdded/updated simple_codegen_task test-cases to cover these things.\n\nTesting Done:\nAdded tests in test_simple_codegen_task.py.\n\nCI went green: https://travis-ci.org/pantsbuild/pants/builds/66922872\n\nBugs closed: 1683\n\nReviewed at https://rbcommons.com/s/twitter/r/2368/","distinct":false,"url":"https://api.github.com/repos/benjyw/pants/commits/5a55b2229d3e4fb10d0f71cd608ce5b69b5c3768"},{"sha":"5f6626c12248e94d9d00928219737d07b0f845b6","author":{"email":"86f39098c3d6e8fa24cceea9f4753c2782977b2d@gmail.com","name":"John Sirois"},"message":"Add support for restricting push remotes.\n\nThis adds a new advanced `--restrict-push-urls` option that can be used\nto restrict the set of valid remote scm urls that can be published to.\n\nPants immediately dogfoods this to restrict jar publishing from master\nto pantsbuild/pants.\n\nTest coverage is added for the ScmPublishMixin clean master check.\n\nTesting Done:\nCI went green here:\n  https://travis-ci.org/pantsbuild/pants/builds/67122873\n\nBugs closed: 1680, 1702\n\nReviewed at https://rbcommons.com/s/twitter/r/2383/","distinct":false,"url":"https://api.github.com/repos/benjyw/pants/commits/5f6626c12248e94d9d00928219737d07b0f845b6"},{"sha":"3b38c063a3d7fe23bd0af9a4be9e1814eb294e77","author":{"email":"040cff05bd320eb0560246813fe142b421636f09@gmail.com","name":"Benjy Weinberger"},"message":"Simplify subsystem option scoping.\n\nThis gets rid of the concept of \"scope qualifiers\", which was mostly just confusing.\nNow subsystems just have scopes ('ivy', 'scala-platform' etc.) and task-specific\ninstances have options in the appropriate subscope (e.g., `cache.compile.java` instead of\n`compile.java.cache` as it was previously). This has many advantages:\n  - Option value inheritance \"just works\": `cache.compile.java` will inherit values from\n   `cache`, in the usual way.\n  - Overriding values in the subscope will also work as it does today - by registering\n    the option as recursive=True.\n  - Code is simpler, with a net reduction in LoC: \"82 insertions(+), 114 deletions(-)\".\n  - Subsystems and tasks are now more uniform. For example, both just have an options_scope\n     property, instead of one having a scope_qualifier() method.\n\nThis change doesn't affect any existing pants.ini or flags because we don't have any\ntask-specific subsystem instances yet.\n\nIt does mean that the section name for a task-specific config would be\n[cache.compile.java], not [compile.java.cache], but that doesn't seem like a big deal.\n\nTesting Done:\nAll unit tests pass locally.\n\nCI passes here: https://travis-ci.org/pantsbuild/pants/builds/67110458.\n\nReviewed at https://rbcommons.com/s/twitter/r/2380/","distinct":false,"url":"https://api.github.com/repos/benjyw/pants/commits/3b38c063a3d7fe23bd0af9a4be9e1814eb294e77"},{"sha":"e14eadf0e5e14683f9d7195fd93427dff13968b8","author":{"email":"2e951f4de4089b8fc584f3a65157d85fa8514ef1@foursquare.com","name":"Benjy"},"message":"Merge branch 'master' into artifact_cache_subsystem\n\nConflicts:\n\ttests/python/pants_test/base_test.py","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/e14eadf0e5e14683f9d7195fd93427dff13968b8"},{"sha":"f6b60416cb011a1512397c9d1093e6170fdf7636","author":{"email":"2e951f4de4089b8fc584f3a65157d85fa8514ef1@foursquare.com","name":"Benjy"},"message":"WIP","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/f6b60416cb011a1512397c9d1093e6170fdf7636"}]}