{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/42024035","id":42024035,"diff_hunk":"@@ -27,17 +28,30 @@ foreach (var file in files)\n {\n     var nugetArgs = $@\"pack {file} \" +\n         $@\"-BasePath \"\"{binDir}\"\" \" +\n+        $@\"-OutputDirectory \"\"{outDir}\"\" \" +\n         \"-ExcludeEmptyDirectories \" +\n         $@\"-prop licenseUrl=\"\"{licenseUrl}\"\" \" +\n         $@\"-prop version=\"\"{buildVersion}\"\" \" +\n         $\"-prop authors={authors} \" +\n         $@\"-prop projectURL=\"\"{projectURL}\"\" \" +\n         $@\"-prop tags=\"\"{tags}\"\"\";\n-    Console.WriteLine(nugetArgs);\n-    var p = Process.Start(Path.GetFullPath(\"../../nuget.exe\"), nugetArgs);\n+    var nugetExePath = Path.GetFullPath(\"../../nuget.exe\");","path":"build/BuildNuGets.csx","position":35,"original_position":35,"commit_id":"ba725fd5d9ab7483b7a5112211ae93cca2176633","original_commit_id":"ba725fd5d9ab7483b7a5112211ae93cca2176633","user":{"login":"genlu","id":788783,"avatar_url":"https://avatars.githubusercontent.com/u/788783?v=3","gravatar_id":"","url":"https://api.github.com/users/genlu","html_url":"https://github.com/genlu","followers_url":"https://api.github.com/users/genlu/followers","following_url":"https://api.github.com/users/genlu/following{/other_user}","gists_url":"https://api.github.com/users/genlu/gists{/gist_id}","starred_url":"https://api.github.com/users/genlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genlu/subscriptions","organizations_url":"https://api.github.com/users/genlu/orgs","repos_url":"https://api.github.com/users/genlu/repos","events_url":"https://api.github.com/users/genlu/events{/privacy}","received_events_url":"https://api.github.com/users/genlu/received_events","type":"User","site_admin":false},"body":"I found relative paths in this script a little confusing since I couldn't figure out the working directory just by looking at it. What about adding a `project-root` parameter and deriving both paths from it?","created_at":"2015-10-14T17:22:56Z","updated_at":"2015-10-14T17:22:56Z","html_url":"https://github.com/dotnet/roslyn/pull/5939#discussion_r42024035","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/5939","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/42024035"},"html":{"href":"https://github.com/dotnet/roslyn/pull/5939#discussion_r42024035"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/5939"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/5939","id":47601698,"html_url":"https://github.com/dotnet/roslyn/pull/5939","diff_url":"https://github.com/dotnet/roslyn/pull/5939.diff","patch_url":"https://github.com/dotnet/roslyn/pull/5939.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/5939","number":5939,"state":"open","locked":false,"title":"Add outdir parameter to BuildNuGets.csx","user":{"login":"agocke","id":515774,"avatar_url":"https://avatars.githubusercontent.com/u/515774?v=3","gravatar_id":"","url":"https://api.github.com/users/agocke","html_url":"https://github.com/agocke","followers_url":"https://api.github.com/users/agocke/followers","following_url":"https://api.github.com/users/agocke/following{/other_user}","gists_url":"https://api.github.com/users/agocke/gists{/gist_id}","starred_url":"https://api.github.com/users/agocke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agocke/subscriptions","organizations_url":"https://api.github.com/users/agocke/orgs","repos_url":"https://api.github.com/users/agocke/repos","events_url":"https://api.github.com/users/agocke/events{/privacy}","received_events_url":"https://api.github.com/users/agocke/received_events","type":"User","site_admin":false},"body":"The NuGet build script should explicitly take a directory to which we\r\nwrite the built package.\r\n\r\n@dotnet/roslyn-compiler Please review","created_at":"2015-10-13T23:25:07Z","updated_at":"2015-10-14T17:22:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfd6be49ef13aa816860b6d2e8fab6f7057b5407","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/5939/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/5939/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/5939/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/ba725fd5d9ab7483b7a5112211ae93cca2176633","head":{"label":"agocke:AddOutputDirToBuildNuGetsCsx","ref":"AddOutputDirToBuildNuGetsCsx","sha":"ba725fd5d9ab7483b7a5112211ae93cca2176633","user":{"login":"agocke","id":515774,"avatar_url":"https://avatars.githubusercontent.com/u/515774?v=3","gravatar_id":"","url":"https://api.github.com/users/agocke","html_url":"https://github.com/agocke","followers_url":"https://api.github.com/users/agocke/followers","following_url":"https://api.github.com/users/agocke/following{/other_user}","gists_url":"https://api.github.com/users/agocke/gists{/gist_id}","starred_url":"https://api.github.com/users/agocke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agocke/subscriptions","organizations_url":"https://api.github.com/users/agocke/orgs","repos_url":"https://api.github.com/users/agocke/repos","events_url":"https://api.github.com/users/agocke/events{/privacy}","received_events_url":"https://api.github.com/users/agocke/received_events","type":"User","site_admin":false},"repo":{"id":30560754,"name":"roslyn","full_name":"agocke/roslyn","owner":{"login":"agocke","id":515774,"avatar_url":"https://avatars.githubusercontent.com/u/515774?v=3","gravatar_id":"","url":"https://api.github.com/users/agocke","html_url":"https://github.com/agocke","followers_url":"https://api.github.com/users/agocke/followers","following_url":"https://api.github.com/users/agocke/following{/other_user}","gists_url":"https://api.github.com/users/agocke/gists{/gist_id}","starred_url":"https://api.github.com/users/agocke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agocke/subscriptions","organizations_url":"https://api.github.com/users/agocke/orgs","repos_url":"https://api.github.com/users/agocke/repos","events_url":"https://api.github.com/users/agocke/events{/privacy}","received_events_url":"https://api.github.com/users/agocke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agocke/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/agocke/roslyn","forks_url":"https://api.github.com/repos/agocke/roslyn/forks","keys_url":"https://api.github.com/repos/agocke/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agocke/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agocke/roslyn/teams","hooks_url":"https://api.github.com/repos/agocke/roslyn/hooks","issue_events_url":"https://api.github.com/repos/agocke/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/agocke/roslyn/events","assignees_url":"https://api.github.com/repos/agocke/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/agocke/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/agocke/roslyn/tags","blobs_url":"https://api.github.com/repos/agocke/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agocke/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agocke/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/agocke/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agocke/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/agocke/roslyn/languages","stargazers_url":"https://api.github.com/repos/agocke/roslyn/stargazers","contributors_url":"https://api.github.com/repos/agocke/roslyn/contributors","subscribers_url":"https://api.github.com/repos/agocke/roslyn/subscribers","subscription_url":"https://api.github.com/repos/agocke/roslyn/subscription","commits_url":"https://api.github.com/repos/agocke/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/agocke/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/agocke/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/agocke/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/agocke/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/agocke/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agocke/roslyn/merges","archive_url":"https://api.github.com/repos/agocke/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agocke/roslyn/downloads","issues_url":"https://api.github.com/repos/agocke/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/agocke/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/agocke/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/agocke/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agocke/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/agocke/roslyn/releases{/id}","created_at":"2015-02-09T21:57:03Z","updated_at":"2015-09-11T07:31:39Z","pushed_at":"2015-10-13T23:24:39Z","git_url":"git://github.com/agocke/roslyn.git","ssh_url":"git@github.com:agocke/roslyn.git","clone_url":"https://github.com/agocke/roslyn.git","svn_url":"https://github.com/agocke/roslyn","homepage":"","size":102419,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"89bbad575083719ecfc7909e8480bc6457fa9d55","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-10-14T15:15:03Z","pushed_at":"2015-10-14T17:05:09Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":209986,"stargazers_count":3494,"watchers_count":3494,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":818,"mirror_url":null,"open_issues_count":1510,"forks":818,"open_issues":1510,"watchers":3494,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/5939"},"html":{"href":"https://github.com/dotnet/roslyn/pull/5939"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/5939"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/5939/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/5939/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/5939/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/ba725fd5d9ab7483b7a5112211ae93cca2176633"}}}}