{"action":"opened","number":65,"pull_request":{"url":"https://api.github.com/repos/uber/npm-shrinkwrap/pulls/65","id":30339924,"html_url":"https://github.com/uber/npm-shrinkwrap/pull/65","diff_url":"https://github.com/uber/npm-shrinkwrap/pull/65.diff","patch_url":"https://github.com/uber/npm-shrinkwrap/pull/65.patch","issue_url":"https://api.github.com/repos/uber/npm-shrinkwrap/issues/65","number":65,"state":"open","locked":false,"title":"`1.3.7` is valid version","user":{"login":"robario","id":1733867,"avatar_url":"https://avatars.githubusercontent.com/u/1733867?v=3","gravatar_id":"","url":"https://api.github.com/users/robario","html_url":"https://github.com/robario","followers_url":"https://api.github.com/users/robario/followers","following_url":"https://api.github.com/users/robario/following{/other_user}","gists_url":"https://api.github.com/users/robario/gists{/gist_id}","starred_url":"https://api.github.com/users/robario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robario/subscriptions","organizations_url":"https://api.github.com/users/robario/orgs","repos_url":"https://api.github.com/users/robario/repos","events_url":"https://api.github.com/users/robario/events{/privacy}","received_events_url":"https://api.github.com/users/robario/received_events","type":"User","site_admin":false},"body":"I have got this warning.\r\n> WARN: Expected the git dependency WanaKana to have a valid version tag;\r\n>  instead I found 1.3.7 for the dependency WaniKani/WanaKana#1.3.7\r\n\r\nHowever, the `1.3.7` is valid version, isn't it?\r\n\r\n----\r\n\r\nsemver ignores the leading `v`.\r\n\r\n```\r\n$ node -pe 'v=require(\"semver\");v.valid(\"1.3.7\")'\r\n1.3.7\r\n$ node -pe 'v=require(\"semver\");v.valid(\"v1.3.7\")'\r\n1.3.7\r\n$ node -pe 'v=require(\"semver\");v.valid(\"a1.3.7\")'\r\nnull\r\n```\r\n\r\nI think it can be written more simply.\r\n\r\n```\r\nfunction parseVersion(tag) {\r\n    return validSemver(tag);\r\n}\r\n```\r\n\r\nAnd also,\r\n\r\n```\r\nvar parseVersion = require('semver').valid;\r\n```\r\n","created_at":"2015-03-03T01:51:20Z","updated_at":"2015-03-03T01:51:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bd5648ba94b07b56005b08030cd37bf9b204aaa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/npm-shrinkwrap/pulls/65/commits","review_comments_url":"https://api.github.com/repos/uber/npm-shrinkwrap/pulls/65/comments","review_comment_url":"https://api.github.com/repos/uber/npm-shrinkwrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/npm-shrinkwrap/issues/65/comments","statuses_url":"https://api.github.com/repos/uber/npm-shrinkwrap/statuses/6aa0f9ba06c4ea8a89375b96362427a52902fd9b","head":{"label":"robario:patch-1","ref":"patch-1","sha":"6aa0f9ba06c4ea8a89375b96362427a52902fd9b","user":{"login":"robario","id":1733867,"avatar_url":"https://avatars.githubusercontent.com/u/1733867?v=3","gravatar_id":"","url":"https://api.github.com/users/robario","html_url":"https://github.com/robario","followers_url":"https://api.github.com/users/robario/followers","following_url":"https://api.github.com/users/robario/following{/other_user}","gists_url":"https://api.github.com/users/robario/gists{/gist_id}","starred_url":"https://api.github.com/users/robario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robario/subscriptions","organizations_url":"https://api.github.com/users/robario/orgs","repos_url":"https://api.github.com/users/robario/repos","events_url":"https://api.github.com/users/robario/events{/privacy}","received_events_url":"https://api.github.com/users/robario/received_events","type":"User","site_admin":false},"repo":{"id":31573285,"name":"npm-shrinkwrap","full_name":"robario/npm-shrinkwrap","owner":{"login":"robario","id":1733867,"avatar_url":"https://avatars.githubusercontent.com/u/1733867?v=3","gravatar_id":"","url":"https://api.github.com/users/robario","html_url":"https://github.com/robario","followers_url":"https://api.github.com/users/robario/followers","following_url":"https://api.github.com/users/robario/following{/other_user}","gists_url":"https://api.github.com/users/robario/gists{/gist_id}","starred_url":"https://api.github.com/users/robario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robario/subscriptions","organizations_url":"https://api.github.com/users/robario/orgs","repos_url":"https://api.github.com/users/robario/repos","events_url":"https://api.github.com/users/robario/events{/privacy}","received_events_url":"https://api.github.com/users/robario/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robario/npm-shrinkwrap","description":"A consistent shrinkwrap tool","fork":true,"url":"https://api.github.com/repos/robario/npm-shrinkwrap","forks_url":"https://api.github.com/repos/robario/npm-shrinkwrap/forks","keys_url":"https://api.github.com/repos/robario/npm-shrinkwrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robario/npm-shrinkwrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robario/npm-shrinkwrap/teams","hooks_url":"https://api.github.com/repos/robario/npm-shrinkwrap/hooks","issue_events_url":"https://api.github.com/repos/robario/npm-shrinkwrap/issues/events{/number}","events_url":"https://api.github.com/repos/robario/npm-shrinkwrap/events","assignees_url":"https://api.github.com/repos/robario/npm-shrinkwrap/assignees{/user}","branches_url":"https://api.github.com/repos/robario/npm-shrinkwrap/branches{/branch}","tags_url":"https://api.github.com/repos/robario/npm-shrinkwrap/tags","blobs_url":"https://api.github.com/repos/robario/npm-shrinkwrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robario/npm-shrinkwrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robario/npm-shrinkwrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/robario/npm-shrinkwrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robario/npm-shrinkwrap/statuses/{sha}","languages_url":"https://api.github.com/repos/robario/npm-shrinkwrap/languages","stargazers_url":"https://api.github.com/repos/robario/npm-shrinkwrap/stargazers","contributors_url":"https://api.github.com/repos/robario/npm-shrinkwrap/contributors","subscribers_url":"https://api.github.com/repos/robario/npm-shrinkwrap/subscribers","subscription_url":"https://api.github.com/repos/robario/npm-shrinkwrap/subscription","commits_url":"https://api.github.com/repos/robario/npm-shrinkwrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/robario/npm-shrinkwrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/robario/npm-shrinkwrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/robario/npm-shrinkwrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/robario/npm-shrinkwrap/contents/{+path}","compare_url":"https://api.github.com/repos/robario/npm-shrinkwrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robario/npm-shrinkwrap/merges","archive_url":"https://api.github.com/repos/robario/npm-shrinkwrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robario/npm-shrinkwrap/downloads","issues_url":"https://api.github.com/repos/robario/npm-shrinkwrap/issues{/number}","pulls_url":"https://api.github.com/repos/robario/npm-shrinkwrap/pulls{/number}","milestones_url":"https://api.github.com/repos/robario/npm-shrinkwrap/milestones{/number}","notifications_url":"https://api.github.com/repos/robario/npm-shrinkwrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robario/npm-shrinkwrap/labels{/name}","releases_url":"https://api.github.com/repos/robario/npm-shrinkwrap/releases{/id}","created_at":"2015-03-03T01:34:37Z","updated_at":"2015-03-03T01:34:38Z","pushed_at":"2015-03-03T01:50:12Z","git_url":"git://github.com/robario/npm-shrinkwrap.git","ssh_url":"git@github.com:robario/npm-shrinkwrap.git","clone_url":"https://github.com/robario/npm-shrinkwrap.git","svn_url":"https://github.com/robario/npm-shrinkwrap","homepage":null,"size":792,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"5b231589894394a044694121e38231cfd7184eec","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":17725723,"name":"npm-shrinkwrap","full_name":"uber/npm-shrinkwrap","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/npm-shrinkwrap","description":"A consistent shrinkwrap tool","fork":false,"url":"https://api.github.com/repos/uber/npm-shrinkwrap","forks_url":"https://api.github.com/repos/uber/npm-shrinkwrap/forks","keys_url":"https://api.github.com/repos/uber/npm-shrinkwrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/npm-shrinkwrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/npm-shrinkwrap/teams","hooks_url":"https://api.github.com/repos/uber/npm-shrinkwrap/hooks","issue_events_url":"https://api.github.com/repos/uber/npm-shrinkwrap/issues/events{/number}","events_url":"https://api.github.com/repos/uber/npm-shrinkwrap/events","assignees_url":"https://api.github.com/repos/uber/npm-shrinkwrap/assignees{/user}","branches_url":"https://api.github.com/repos/uber/npm-shrinkwrap/branches{/branch}","tags_url":"https://api.github.com/repos/uber/npm-shrinkwrap/tags","blobs_url":"https://api.github.com/repos/uber/npm-shrinkwrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/npm-shrinkwrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/npm-shrinkwrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/npm-shrinkwrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/npm-shrinkwrap/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/npm-shrinkwrap/languages","stargazers_url":"https://api.github.com/repos/uber/npm-shrinkwrap/stargazers","contributors_url":"https://api.github.com/repos/uber/npm-shrinkwrap/contributors","subscribers_url":"https://api.github.com/repos/uber/npm-shrinkwrap/subscribers","subscription_url":"https://api.github.com/repos/uber/npm-shrinkwrap/subscription","commits_url":"https://api.github.com/repos/uber/npm-shrinkwrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/npm-shrinkwrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/npm-shrinkwrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/npm-shrinkwrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/npm-shrinkwrap/contents/{+path}","compare_url":"https://api.github.com/repos/uber/npm-shrinkwrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/npm-shrinkwrap/merges","archive_url":"https://api.github.com/repos/uber/npm-shrinkwrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/npm-shrinkwrap/downloads","issues_url":"https://api.github.com/repos/uber/npm-shrinkwrap/issues{/number}","pulls_url":"https://api.github.com/repos/uber/npm-shrinkwrap/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/npm-shrinkwrap/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/npm-shrinkwrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/npm-shrinkwrap/labels{/name}","releases_url":"https://api.github.com/repos/uber/npm-shrinkwrap/releases{/id}","created_at":"2014-03-13T20:56:02Z","updated_at":"2015-03-01T19:22:17Z","pushed_at":"2015-02-17T05:00:24Z","git_url":"git://github.com/uber/npm-shrinkwrap.git","ssh_url":"git@github.com:uber/npm-shrinkwrap.git","clone_url":"https://github.com/uber/npm-shrinkwrap.git","svn_url":"https://github.com/uber/npm-shrinkwrap","homepage":null,"size":792,"stargazers_count":59,"watchers_count":59,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":21,"forks":13,"open_issues":21,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/npm-shrinkwrap/pulls/65"},"html":{"href":"https://github.com/uber/npm-shrinkwrap/pull/65"},"issue":{"href":"https://api.github.com/repos/uber/npm-shrinkwrap/issues/65"},"comments":{"href":"https://api.github.com/repos/uber/npm-shrinkwrap/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/npm-shrinkwrap/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/npm-shrinkwrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/npm-shrinkwrap/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/uber/npm-shrinkwrap/statuses/6aa0f9ba06c4ea8a89375b96362427a52902fd9b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}