{"action":"created","comment":{"url":"https://api.github.com/repos/orocrm/platform/pulls/comments/43813968","id":43813968,"diff_hunk":"@@ -182,8 +182,8 @@ public function getAccessLevelNames($object)\n      */\n     public function supports($type, $id)\n     {\n-        if ($type === ObjectIdentityFactory::ROOT_IDENTITY_TYPE && $id === $this->getExtensionKey()) {\n-            return true;\n+        if ($type === ObjectIdentityFactory::ROOT_IDENTITY_TYPE) {\n+            return $id === $this->getExtensionKey();","path":"src/Oro/Bundle/SecurityBundle/Acl/Extension/EntityAclExtension.php","position":7,"original_position":7,"commit_id":"2a69a59946571e62c07742446a4160dfc208f3fd","original_commit_id":"2a69a59946571e62c07742446a4160dfc208f3fd","user":{"login":"parnas","id":152811,"avatar_url":"https://avatars.githubusercontent.com/u/152811?v=3","gravatar_id":"","url":"https://api.github.com/users/parnas","html_url":"https://github.com/parnas","followers_url":"https://api.github.com/users/parnas/followers","following_url":"https://api.github.com/users/parnas/following{/other_user}","gists_url":"https://api.github.com/users/parnas/gists{/gist_id}","starred_url":"https://api.github.com/users/parnas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parnas/subscriptions","organizations_url":"https://api.github.com/users/parnas/orgs","repos_url":"https://api.github.com/users/parnas/repos","events_url":"https://api.github.com/users/parnas/events{/privacy}","received_events_url":"https://api.github.com/users/parnas/received_events","type":"User","site_admin":false},"body":"That either was a bug, or is a bug now. Because logic is different from it was before.","created_at":"2015-11-03T22:05:37Z","updated_at":"2015-11-03T22:05:37Z","html_url":"https://github.com/orocrm/platform/pull/337#discussion_r43813968","pull_request_url":"https://api.github.com/repos/orocrm/platform/pulls/337","_links":{"self":{"href":"https://api.github.com/repos/orocrm/platform/pulls/comments/43813968"},"html":{"href":"https://github.com/orocrm/platform/pull/337#discussion_r43813968"},"pull_request":{"href":"https://api.github.com/repos/orocrm/platform/pulls/337"}}},"pull_request":{"url":"https://api.github.com/repos/orocrm/platform/pulls/337","id":49570550,"html_url":"https://github.com/orocrm/platform/pull/337","diff_url":"https://github.com/orocrm/platform/pull/337.diff","patch_url":"https://github.com/orocrm/platform/pull/337.patch","issue_url":"https://api.github.com/repos/orocrm/platform/issues/337","number":337,"state":"open","locked":false,"title":"Field Level ACL","user":{"login":"ishakuta","id":193552,"avatar_url":"https://avatars.githubusercontent.com/u/193552?v=3","gravatar_id":"","url":"https://api.github.com/users/ishakuta","html_url":"https://github.com/ishakuta","followers_url":"https://api.github.com/users/ishakuta/followers","following_url":"https://api.github.com/users/ishakuta/following{/other_user}","gists_url":"https://api.github.com/users/ishakuta/gists{/gist_id}","starred_url":"https://api.github.com/users/ishakuta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishakuta/subscriptions","organizations_url":"https://api.github.com/users/ishakuta/orgs","repos_url":"https://api.github.com/users/ishakuta/repos","events_url":"https://api.github.com/users/ishakuta/events{/privacy}","received_events_url":"https://api.github.com/users/ishakuta/received_events","type":"User","site_admin":false},"body":"Field level ACL:\r\n- filter REST API responses from restricted fields (supported for controllers extended from RestGetController)\r\n- remove restricted fields from API and regular forms on preSubmit and on finishView for rendering\r\n- UI: similar to role-entity, as a separate view\r\n\r\nNot supported:\r\n- SOAP API (cause of problems with wsdl generation for each user and cache invalidation)\r\n- Regular Twig UI (as there's no simple way hide label widget with value widget automatically without changing templates)\r\n","created_at":"2015-11-03T15:39:48Z","updated_at":"2015-11-03T22:05:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04da91bab486920fc881c1548f15d6b934c4d5ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/orocrm/platform/pulls/337/commits","review_comments_url":"https://api.github.com/repos/orocrm/platform/pulls/337/comments","review_comment_url":"https://api.github.com/repos/orocrm/platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/orocrm/platform/issues/337/comments","statuses_url":"https://api.github.com/repos/orocrm/platform/statuses/2a69a59946571e62c07742446a4160dfc208f3fd","head":{"label":"trustify:feature/field-acl_master","ref":"feature/field-acl_master","sha":"2a69a59946571e62c07742446a4160dfc208f3fd","user":{"login":"trustify","id":11923723,"avatar_url":"https://avatars.githubusercontent.com/u/11923723?v=3","gravatar_id":"","url":"https://api.github.com/users/trustify","html_url":"https://github.com/trustify","followers_url":"https://api.github.com/users/trustify/followers","following_url":"https://api.github.com/users/trustify/following{/other_user}","gists_url":"https://api.github.com/users/trustify/gists{/gist_id}","starred_url":"https://api.github.com/users/trustify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustify/subscriptions","organizations_url":"https://api.github.com/users/trustify/orgs","repos_url":"https://api.github.com/users/trustify/repos","events_url":"https://api.github.com/users/trustify/events{/privacy}","received_events_url":"https://api.github.com/users/trustify/received_events","type":"Organization","site_admin":false},"repo":{"id":39975403,"name":"oroplatform","full_name":"trustify/oroplatform","owner":{"login":"trustify","id":11923723,"avatar_url":"https://avatars.githubusercontent.com/u/11923723?v=3","gravatar_id":"","url":"https://api.github.com/users/trustify","html_url":"https://github.com/trustify","followers_url":"https://api.github.com/users/trustify/followers","following_url":"https://api.github.com/users/trustify/following{/other_user}","gists_url":"https://api.github.com/users/trustify/gists{/gist_id}","starred_url":"https://api.github.com/users/trustify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustify/subscriptions","organizations_url":"https://api.github.com/users/trustify/orgs","repos_url":"https://api.github.com/users/trustify/repos","events_url":"https://api.github.com/users/trustify/events{/privacy}","received_events_url":"https://api.github.com/users/trustify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trustify/oroplatform","description":"The Oro Platform - Business Application Platform (BAP)","fork":true,"url":"https://api.github.com/repos/trustify/oroplatform","forks_url":"https://api.github.com/repos/trustify/oroplatform/forks","keys_url":"https://api.github.com/repos/trustify/oroplatform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trustify/oroplatform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trustify/oroplatform/teams","hooks_url":"https://api.github.com/repos/trustify/oroplatform/hooks","issue_events_url":"https://api.github.com/repos/trustify/oroplatform/issues/events{/number}","events_url":"https://api.github.com/repos/trustify/oroplatform/events","assignees_url":"https://api.github.com/repos/trustify/oroplatform/assignees{/user}","branches_url":"https://api.github.com/repos/trustify/oroplatform/branches{/branch}","tags_url":"https://api.github.com/repos/trustify/oroplatform/tags","blobs_url":"https://api.github.com/repos/trustify/oroplatform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trustify/oroplatform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trustify/oroplatform/git/refs{/sha}","trees_url":"https://api.github.com/repos/trustify/oroplatform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trustify/oroplatform/statuses/{sha}","languages_url":"https://api.github.com/repos/trustify/oroplatform/languages","stargazers_url":"https://api.github.com/repos/trustify/oroplatform/stargazers","contributors_url":"https://api.github.com/repos/trustify/oroplatform/contributors","subscribers_url":"https://api.github.com/repos/trustify/oroplatform/subscribers","subscription_url":"https://api.github.com/repos/trustify/oroplatform/subscription","commits_url":"https://api.github.com/repos/trustify/oroplatform/commits{/sha}","git_commits_url":"https://api.github.com/repos/trustify/oroplatform/git/commits{/sha}","comments_url":"https://api.github.com/repos/trustify/oroplatform/comments{/number}","issue_comment_url":"https://api.github.com/repos/trustify/oroplatform/issues/comments{/number}","contents_url":"https://api.github.com/repos/trustify/oroplatform/contents/{+path}","compare_url":"https://api.github.com/repos/trustify/oroplatform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trustify/oroplatform/merges","archive_url":"https://api.github.com/repos/trustify/oroplatform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trustify/oroplatform/downloads","issues_url":"https://api.github.com/repos/trustify/oroplatform/issues{/number}","pulls_url":"https://api.github.com/repos/trustify/oroplatform/pulls{/number}","milestones_url":"https://api.github.com/repos/trustify/oroplatform/milestones{/number}","notifications_url":"https://api.github.com/repos/trustify/oroplatform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trustify/oroplatform/labels{/name}","releases_url":"https://api.github.com/repos/trustify/oroplatform/releases{/id}","created_at":"2015-07-30T22:37:13Z","updated_at":"2015-07-30T23:06:49Z","pushed_at":"2015-11-03T16:22:10Z","git_url":"git://github.com/trustify/oroplatform.git","ssh_url":"git@github.com:trustify/oroplatform.git","clone_url":"https://github.com/trustify/oroplatform.git","svn_url":"https://github.com/trustify/oroplatform","homepage":"","size":79414,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"orocrm:master","ref":"master","sha":"95d7d0854727b83434566c2bba916df5b5232de8","user":{"login":"orocrm","id":4165718,"avatar_url":"https://avatars.githubusercontent.com/u/4165718?v=3","gravatar_id":"","url":"https://api.github.com/users/orocrm","html_url":"https://github.com/orocrm","followers_url":"https://api.github.com/users/orocrm/followers","following_url":"https://api.github.com/users/orocrm/following{/other_user}","gists_url":"https://api.github.com/users/orocrm/gists{/gist_id}","starred_url":"https://api.github.com/users/orocrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orocrm/subscriptions","organizations_url":"https://api.github.com/users/orocrm/orgs","repos_url":"https://api.github.com/users/orocrm/repos","events_url":"https://api.github.com/users/orocrm/events{/privacy}","received_events_url":"https://api.github.com/users/orocrm/received_events","type":"Organization","site_admin":false},"repo":{"id":10450961,"name":"platform","full_name":"orocrm/platform","owner":{"login":"orocrm","id":4165718,"avatar_url":"https://avatars.githubusercontent.com/u/4165718?v=3","gravatar_id":"","url":"https://api.github.com/users/orocrm","html_url":"https://github.com/orocrm","followers_url":"https://api.github.com/users/orocrm/followers","following_url":"https://api.github.com/users/orocrm/following{/other_user}","gists_url":"https://api.github.com/users/orocrm/gists{/gist_id}","starred_url":"https://api.github.com/users/orocrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orocrm/subscriptions","organizations_url":"https://api.github.com/users/orocrm/orgs","repos_url":"https://api.github.com/users/orocrm/repos","events_url":"https://api.github.com/users/orocrm/events{/privacy}","received_events_url":"https://api.github.com/users/orocrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/orocrm/platform","description":"The OroPlatform - Business Application Platform (BAP)","fork":false,"url":"https://api.github.com/repos/orocrm/platform","forks_url":"https://api.github.com/repos/orocrm/platform/forks","keys_url":"https://api.github.com/repos/orocrm/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orocrm/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orocrm/platform/teams","hooks_url":"https://api.github.com/repos/orocrm/platform/hooks","issue_events_url":"https://api.github.com/repos/orocrm/platform/issues/events{/number}","events_url":"https://api.github.com/repos/orocrm/platform/events","assignees_url":"https://api.github.com/repos/orocrm/platform/assignees{/user}","branches_url":"https://api.github.com/repos/orocrm/platform/branches{/branch}","tags_url":"https://api.github.com/repos/orocrm/platform/tags","blobs_url":"https://api.github.com/repos/orocrm/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orocrm/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orocrm/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/orocrm/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orocrm/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/orocrm/platform/languages","stargazers_url":"https://api.github.com/repos/orocrm/platform/stargazers","contributors_url":"https://api.github.com/repos/orocrm/platform/contributors","subscribers_url":"https://api.github.com/repos/orocrm/platform/subscribers","subscription_url":"https://api.github.com/repos/orocrm/platform/subscription","commits_url":"https://api.github.com/repos/orocrm/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/orocrm/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/orocrm/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/orocrm/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/orocrm/platform/contents/{+path}","compare_url":"https://api.github.com/repos/orocrm/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orocrm/platform/merges","archive_url":"https://api.github.com/repos/orocrm/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orocrm/platform/downloads","issues_url":"https://api.github.com/repos/orocrm/platform/issues{/number}","pulls_url":"https://api.github.com/repos/orocrm/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/orocrm/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/orocrm/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orocrm/platform/labels{/name}","releases_url":"https://api.github.com/repos/orocrm/platform/releases{/id}","created_at":"2013-06-03T09:06:52Z","updated_at":"2015-11-02T13:13:32Z","pushed_at":"2015-11-03T16:22:10Z","git_url":"git://github.com/orocrm/platform.git","ssh_url":"git@github.com:orocrm/platform.git","clone_url":"https://github.com/orocrm/platform.git","svn_url":"https://github.com/orocrm/platform","homepage":"","size":94164,"stargazers_count":331,"watchers_count":331,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":115,"forks":145,"open_issues":115,"watchers":331,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/orocrm/platform/pulls/337"},"html":{"href":"https://github.com/orocrm/platform/pull/337"},"issue":{"href":"https://api.github.com/repos/orocrm/platform/issues/337"},"comments":{"href":"https://api.github.com/repos/orocrm/platform/issues/337/comments"},"review_comments":{"href":"https://api.github.com/repos/orocrm/platform/pulls/337/comments"},"review_comment":{"href":"https://api.github.com/repos/orocrm/platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/orocrm/platform/pulls/337/commits"},"statuses":{"href":"https://api.github.com/repos/orocrm/platform/statuses/2a69a59946571e62c07742446a4160dfc208f3fd"}}}}