{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/brand/issues/16","labels_url":"https://api.github.com/repos/phetsims/brand/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/brand/issues/16/comments","events_url":"https://api.github.com/repos/phetsims/brand/issues/16/events","html_url":"https://github.com/phetsims/brand/issues/16","id":94758818,"number":16,"title":"Allow logos of any width","user":{"login":"samreid","id":679486,"avatar_url":"https://avatars.githubusercontent.com/u/679486?v=3","gravatar_id":"","url":"https://api.github.com/users/samreid","html_url":"https://github.com/samreid","followers_url":"https://api.github.com/users/samreid/followers","following_url":"https://api.github.com/users/samreid/following{/other_user}","gists_url":"https://api.github.com/users/samreid/gists{/gist_id}","starred_url":"https://api.github.com/users/samreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samreid/subscriptions","organizations_url":"https://api.github.com/users/samreid/orgs","repos_url":"https://api.github.com/users/samreid/repos","events_url":"https://api.github.com/users/samreid/events{/privacy}","received_events_url":"https://api.github.com/users/samreid/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"pixelzoom","id":3046552,"avatar_url":"https://avatars.githubusercontent.com/u/3046552?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-07-13T16:19:23Z","updated_at":"2015-08-05T18:06:26Z","closed_at":null,"body":"It makes sense for us to suggest (and possibly even enforce) the logo height since it will appear in the navbar, but we should lift the restriction of the required width as well."},"comment":{"url":"https://api.github.com/repos/phetsims/brand/issues/comments/128094187","html_url":"https://github.com/phetsims/brand/issues/16#issuecomment-128094187","issue_url":"https://api.github.com/repos/phetsims/brand/issues/16","id":128094187,"user":{"login":"pixelzoom","id":3046552,"avatar_url":"https://avatars.githubusercontent.com/u/3046552?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false},"created_at":"2015-08-05T18:06:26Z","updated_at":"2015-08-05T18:06:26Z","body":"I would probably factor out magic numbers like this:\r\n\r\n```js\r\nvar PHET_LOGO_HEIGHT = 108;  // height of the PhET logo, brand/phet/images/logo.png\r\nvar PHET_LOGO_SCALE = 0.28; // scale applied to the PhET logo\r\n// Scale to the same height as the PhET logo, so that layout code works correctly.\r\nvar DEFAULT_LOGO_SCALE = PHET_LOGO_SCALE / logo[ 0 ].height * PHET_LOGO_HEIGHT; \r\n\r\nfunction PhetButton( ... ) {\r\n\r\n  options = _.extend( {\r\n     logoScale: DEFAULT_LOGO_SCALE\r\n  }, options );\r\n\r\n}\r\n```\r\n\r\nThis also makes me wonder why `logoScale` is an option.  I don't see it used anywhere, and setting it to something other than DEFAULT_LOGO_SCALE will may break layout.  Should we remove it?"}}