{"action":"opened","number":124,"pull_request":{"url":"https://api.github.com/repos/NYULibraries/ichabod/pulls/124","id":27141001,"html_url":"https://github.com/NYULibraries/ichabod/pull/124","diff_url":"https://github.com/NYULibraries/ichabod/pull/124.diff","patch_url":"https://github.com/NYULibraries/ichabod/pull/124.patch","issue_url":"https://api.github.com/repos/NYULibraries/ichabod/issues/124","number":124,"state":"open","locked":false,"title":"Feature/action buttons","user":{"login":"ekate","id":2539494,"avatar_url":"https://avatars.githubusercontent.com/u/2539494?v=3","gravatar_id":"","url":"https://api.github.com/users/ekate","html_url":"https://github.com/ekate","followers_url":"https://api.github.com/users/ekate/followers","following_url":"https://api.github.com/users/ekate/following{/other_user}","gists_url":"https://api.github.com/users/ekate/gists{/gist_id}","starred_url":"https://api.github.com/users/ekate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekate/subscriptions","organizations_url":"https://api.github.com/users/ekate/orgs","repos_url":"https://api.github.com/users/ekate/repos","events_url":"https://api.github.com/users/ekate/events{/privacy}","received_events_url":"https://api.github.com/users/ekate/received_events","type":"User","site_admin":false},"body":"New version of Edit button pull request, which addresses the folowing issues:\r\n1. I had trouble figuring out the logic in get_page_number.\r\nCould you add some comments explaining the code?\r\nIs it possible to simplify using if and && or a case statement?\r\n\r\n2. It wasn't clear to me what this step in the scenario was doing until I looked at the step definition.\r\ncould you reword your step definition to something like one of the following?\r\nGiven(/^\"(.*?)\" records with the title \"(.*?)\" exist$/) do |number_of_records, title|\r\nor\r\nGiven(/^\"(.*?)\" records of \"(.*?)\" exist$/) do |number_of_records, title|\r\n3. Destroy vs. Delete consistency\r\nsome scenario titles here and here still have destroy in them. Could you change to delete?\r\nshould this be Delete?","created_at":"2015-01-10T01:01:33Z","updated_at":"2015-01-10T01:01:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NYULibraries/ichabod/pulls/124/commits","review_comments_url":"https://api.github.com/repos/NYULibraries/ichabod/pulls/124/comments","review_comment_url":"https://api.github.com/repos/NYULibraries/ichabod/pulls/comments/{number}","comments_url":"https://api.github.com/repos/NYULibraries/ichabod/issues/124/comments","statuses_url":"https://api.github.com/repos/NYULibraries/ichabod/statuses/3a06c37d214f7c99f5fc5c25c5e53b6d4b62b932","head":{"label":"NYULibraries:feature/action_buttons","ref":"feature/action_buttons","sha":"3a06c37d214f7c99f5fc5c25c5e53b6d4b62b932","user":{"login":"NYULibraries","id":1707000,"avatar_url":"https://avatars.githubusercontent.com/u/1707000?v=3","gravatar_id":"","url":"https://api.github.com/users/NYULibraries","html_url":"https://github.com/NYULibraries","followers_url":"https://api.github.com/users/NYULibraries/followers","following_url":"https://api.github.com/users/NYULibraries/following{/other_user}","gists_url":"https://api.github.com/users/NYULibraries/gists{/gist_id}","starred_url":"https://api.github.com/users/NYULibraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYULibraries/subscriptions","organizations_url":"https://api.github.com/users/NYULibraries/orgs","repos_url":"https://api.github.com/users/NYULibraries/repos","events_url":"https://api.github.com/users/NYULibraries/events{/privacy}","received_events_url":"https://api.github.com/users/NYULibraries/received_events","type":"Organization","site_admin":false},"repo":{"id":15267587,"name":"ichabod","full_name":"NYULibraries/ichabod","owner":{"login":"NYULibraries","id":1707000,"avatar_url":"https://avatars.githubusercontent.com/u/1707000?v=3","gravatar_id":"","url":"https://api.github.com/users/NYULibraries","html_url":"https://github.com/NYULibraries","followers_url":"https://api.github.com/users/NYULibraries/followers","following_url":"https://api.github.com/users/NYULibraries/following{/other_user}","gists_url":"https://api.github.com/users/NYULibraries/gists{/gist_id}","starred_url":"https://api.github.com/users/NYULibraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYULibraries/subscriptions","organizations_url":"https://api.github.com/users/NYULibraries/orgs","repos_url":"https://api.github.com/users/NYULibraries/repos","events_url":"https://api.github.com/users/NYULibraries/events{/privacy}","received_events_url":"https://api.github.com/users/NYULibraries/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYULibraries/ichabod","description":"","fork":false,"url":"https://api.github.com/repos/NYULibraries/ichabod","forks_url":"https://api.github.com/repos/NYULibraries/ichabod/forks","keys_url":"https://api.github.com/repos/NYULibraries/ichabod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYULibraries/ichabod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYULibraries/ichabod/teams","hooks_url":"https://api.github.com/repos/NYULibraries/ichabod/hooks","issue_events_url":"https://api.github.com/repos/NYULibraries/ichabod/issues/events{/number}","events_url":"https://api.github.com/repos/NYULibraries/ichabod/events","assignees_url":"https://api.github.com/repos/NYULibraries/ichabod/assignees{/user}","branches_url":"https://api.github.com/repos/NYULibraries/ichabod/branches{/branch}","tags_url":"https://api.github.com/repos/NYULibraries/ichabod/tags","blobs_url":"https://api.github.com/repos/NYULibraries/ichabod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYULibraries/ichabod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYULibraries/ichabod/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYULibraries/ichabod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYULibraries/ichabod/statuses/{sha}","languages_url":"https://api.github.com/repos/NYULibraries/ichabod/languages","stargazers_url":"https://api.github.com/repos/NYULibraries/ichabod/stargazers","contributors_url":"https://api.github.com/repos/NYULibraries/ichabod/contributors","subscribers_url":"https://api.github.com/repos/NYULibraries/ichabod/subscribers","subscription_url":"https://api.github.com/repos/NYULibraries/ichabod/subscription","commits_url":"https://api.github.com/repos/NYULibraries/ichabod/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYULibraries/ichabod/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYULibraries/ichabod/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYULibraries/ichabod/issues/comments/{number}","contents_url":"https://api.github.com/repos/NYULibraries/ichabod/contents/{+path}","compare_url":"https://api.github.com/repos/NYULibraries/ichabod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYULibraries/ichabod/merges","archive_url":"https://api.github.com/repos/NYULibraries/ichabod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYULibraries/ichabod/downloads","issues_url":"https://api.github.com/repos/NYULibraries/ichabod/issues{/number}","pulls_url":"https://api.github.com/repos/NYULibraries/ichabod/pulls{/number}","milestones_url":"https://api.github.com/repos/NYULibraries/ichabod/milestones{/number}","notifications_url":"https://api.github.com/repos/NYULibraries/ichabod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYULibraries/ichabod/labels{/name}","releases_url":"https://api.github.com/repos/NYULibraries/ichabod/releases{/id}","created_at":"2013-12-17T22:20:49Z","updated_at":"2014-12-14T02:18:18Z","pushed_at":"2015-01-10T00:55:45Z","git_url":"git://github.com/NYULibraries/ichabod.git","ssh_url":"git@github.com:NYULibraries/ichabod.git","clone_url":"https://github.com/NYULibraries/ichabod.git","svn_url":"https://github.com/NYULibraries/ichabod","homepage":"","size":176226,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":3,"default_branch":"development"}},"base":{"label":"NYULibraries:development","ref":"development","sha":"f967def21ec0f145c0f317b748e7909ed618308c","user":{"login":"NYULibraries","id":1707000,"avatar_url":"https://avatars.githubusercontent.com/u/1707000?v=3","gravatar_id":"","url":"https://api.github.com/users/NYULibraries","html_url":"https://github.com/NYULibraries","followers_url":"https://api.github.com/users/NYULibraries/followers","following_url":"https://api.github.com/users/NYULibraries/following{/other_user}","gists_url":"https://api.github.com/users/NYULibraries/gists{/gist_id}","starred_url":"https://api.github.com/users/NYULibraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYULibraries/subscriptions","organizations_url":"https://api.github.com/users/NYULibraries/orgs","repos_url":"https://api.github.com/users/NYULibraries/repos","events_url":"https://api.github.com/users/NYULibraries/events{/privacy}","received_events_url":"https://api.github.com/users/NYULibraries/received_events","type":"Organization","site_admin":false},"repo":{"id":15267587,"name":"ichabod","full_name":"NYULibraries/ichabod","owner":{"login":"NYULibraries","id":1707000,"avatar_url":"https://avatars.githubusercontent.com/u/1707000?v=3","gravatar_id":"","url":"https://api.github.com/users/NYULibraries","html_url":"https://github.com/NYULibraries","followers_url":"https://api.github.com/users/NYULibraries/followers","following_url":"https://api.github.com/users/NYULibraries/following{/other_user}","gists_url":"https://api.github.com/users/NYULibraries/gists{/gist_id}","starred_url":"https://api.github.com/users/NYULibraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYULibraries/subscriptions","organizations_url":"https://api.github.com/users/NYULibraries/orgs","repos_url":"https://api.github.com/users/NYULibraries/repos","events_url":"https://api.github.com/users/NYULibraries/events{/privacy}","received_events_url":"https://api.github.com/users/NYULibraries/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYULibraries/ichabod","description":"","fork":false,"url":"https://api.github.com/repos/NYULibraries/ichabod","forks_url":"https://api.github.com/repos/NYULibraries/ichabod/forks","keys_url":"https://api.github.com/repos/NYULibraries/ichabod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYULibraries/ichabod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYULibraries/ichabod/teams","hooks_url":"https://api.github.com/repos/NYULibraries/ichabod/hooks","issue_events_url":"https://api.github.com/repos/NYULibraries/ichabod/issues/events{/number}","events_url":"https://api.github.com/repos/NYULibraries/ichabod/events","assignees_url":"https://api.github.com/repos/NYULibraries/ichabod/assignees{/user}","branches_url":"https://api.github.com/repos/NYULibraries/ichabod/branches{/branch}","tags_url":"https://api.github.com/repos/NYULibraries/ichabod/tags","blobs_url":"https://api.github.com/repos/NYULibraries/ichabod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYULibraries/ichabod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYULibraries/ichabod/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYULibraries/ichabod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYULibraries/ichabod/statuses/{sha}","languages_url":"https://api.github.com/repos/NYULibraries/ichabod/languages","stargazers_url":"https://api.github.com/repos/NYULibraries/ichabod/stargazers","contributors_url":"https://api.github.com/repos/NYULibraries/ichabod/contributors","subscribers_url":"https://api.github.com/repos/NYULibraries/ichabod/subscribers","subscription_url":"https://api.github.com/repos/NYULibraries/ichabod/subscription","commits_url":"https://api.github.com/repos/NYULibraries/ichabod/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYULibraries/ichabod/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYULibraries/ichabod/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYULibraries/ichabod/issues/comments/{number}","contents_url":"https://api.github.com/repos/NYULibraries/ichabod/contents/{+path}","compare_url":"https://api.github.com/repos/NYULibraries/ichabod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYULibraries/ichabod/merges","archive_url":"https://api.github.com/repos/NYULibraries/ichabod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYULibraries/ichabod/downloads","issues_url":"https://api.github.com/repos/NYULibraries/ichabod/issues{/number}","pulls_url":"https://api.github.com/repos/NYULibraries/ichabod/pulls{/number}","milestones_url":"https://api.github.com/repos/NYULibraries/ichabod/milestones{/number}","notifications_url":"https://api.github.com/repos/NYULibraries/ichabod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYULibraries/ichabod/labels{/name}","releases_url":"https://api.github.com/repos/NYULibraries/ichabod/releases{/id}","created_at":"2013-12-17T22:20:49Z","updated_at":"2014-12-14T02:18:18Z","pushed_at":"2015-01-10T00:55:45Z","git_url":"git://github.com/NYULibraries/ichabod.git","ssh_url":"git@github.com:NYULibraries/ichabod.git","clone_url":"https://github.com/NYULibraries/ichabod.git","svn_url":"https://github.com/NYULibraries/ichabod","homepage":"","size":176226,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":3,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/NYULibraries/ichabod/pulls/124"},"html":{"href":"https://github.com/NYULibraries/ichabod/pull/124"},"issue":{"href":"https://api.github.com/repos/NYULibraries/ichabod/issues/124"},"comments":{"href":"https://api.github.com/repos/NYULibraries/ichabod/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/NYULibraries/ichabod/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/NYULibraries/ichabod/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/NYULibraries/ichabod/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/NYULibraries/ichabod/statuses/3a06c37d214f7c99f5fc5c25c5e53b6d4b62b932"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":3702,"deletions":1169,"changed_files":18}}