{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/37394140","id":37394140,"diff_hunk":"@@ -314,4 +316,19 @@ public function displayNamesInGroup($gid, $search = '', $limit = -1, $offset = 0\n \t\t}\n \t\treturn $matchingUsers;\n \t}\n+\n+\t/**\n+\t * @return \\OC\\SubAdmin\n+\t */\n+\tpublic function getSubAdmin() {","path":"lib/private/group/manager.php","position":23,"original_position":23,"commit_id":"26f7755e2480ddcf5d1da3bfd1bca80b39ce8077","original_commit_id":"02b15e0a6d0fe6edbf10ef180848d8c57490e063","user":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"body":"@rullzer Isn't that actually the usecase of the app code checker ;)","created_at":"2015-08-19T09:10:07Z","updated_at":"2015-08-19T09:10:07Z","html_url":"https://github.com/owncloud/core/pull/17773#discussion_r37394140","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/17773","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/37394140"},"html":{"href":"https://github.com/owncloud/core/pull/17773#discussion_r37394140"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/17773"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/17773","id":40431104,"html_url":"https://github.com/owncloud/core/pull/17773","diff_url":"https://github.com/owncloud/core/pull/17773.diff","patch_url":"https://github.com/owncloud/core/pull/17773.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/17773","number":17773,"state":"open","locked":false,"title":"Make OC_SubAdmin non static","user":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"body":"While trying to get the core apps more compliant I can across OC_SubAdmin. Which is not only static in its current form (so no proper testing :( ) but also lacks an OCP interface. So no change in passing the tests in its current form.\r\n\r\nFirst commit moves from a static OC_SubAdmin to OC\\SubAdmin.\r\n\r\nLot of files are modified to still pass the unit tests. But even after that grep still showed a lot of occurences of OC_SubAdmin :( (so we have still to much untested code...)\r\n\r\nTODO:\r\n- [x] DI\r\n- [ ] ~~OCP Interface~~\r\n- [x] Add unit tests\r\n- [x] Still fire original hooks\r\n- [x] Move out of servercontainer\r\n\r\nCC: @LukasReschke @DeepDiver1975\r\n","created_at":"2015-07-21T07:56:39Z","updated_at":"2015-08-19T09:10:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7896bb100aed4c758a0f543650eee713bd586ce","assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/37","html_url":"https://github.com/owncloud/core/milestones/8.2-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/37/labels","id":993629,"number":37,"title":"8.2-current","description":"","creator":{"login":"craigpg","id":160667,"avatar_url":"https://avatars.githubusercontent.com/u/160667?v=3","gravatar_id":"","url":"https://api.github.com/users/craigpg","html_url":"https://github.com/craigpg","followers_url":"https://api.github.com/users/craigpg/followers","following_url":"https://api.github.com/users/craigpg/following{/other_user}","gists_url":"https://api.github.com/users/craigpg/gists{/gist_id}","starred_url":"https://api.github.com/users/craigpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigpg/subscriptions","organizations_url":"https://api.github.com/users/craigpg/orgs","repos_url":"https://api.github.com/users/craigpg/repos","events_url":"https://api.github.com/users/craigpg/events{/privacy}","received_events_url":"https://api.github.com/users/craigpg/received_events","type":"User","site_admin":false},"open_issues":642,"closed_issues":396,"state":"open","created_at":"2015-02-24T16:19:37Z","updated_at":"2015-08-19T09:00:43Z","due_on":"2015-10-20T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/owncloud/core/pulls/17773/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/17773/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/17773/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/26f7755e2480ddcf5d1da3bfd1bca80b39ce8077","head":{"label":"rullzer:subadmin_non_static","ref":"subadmin_non_static","sha":"26f7755e2480ddcf5d1da3bfd1bca80b39ce8077","user":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"repo":{"id":29611886,"name":"core","full_name":"rullzer/core","owner":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rullzer/core","description":"The ownCloud core","fork":true,"url":"https://api.github.com/repos/rullzer/core","forks_url":"https://api.github.com/repos/rullzer/core/forks","keys_url":"https://api.github.com/repos/rullzer/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rullzer/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rullzer/core/teams","hooks_url":"https://api.github.com/repos/rullzer/core/hooks","issue_events_url":"https://api.github.com/repos/rullzer/core/issues/events{/number}","events_url":"https://api.github.com/repos/rullzer/core/events","assignees_url":"https://api.github.com/repos/rullzer/core/assignees{/user}","branches_url":"https://api.github.com/repos/rullzer/core/branches{/branch}","tags_url":"https://api.github.com/repos/rullzer/core/tags","blobs_url":"https://api.github.com/repos/rullzer/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rullzer/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rullzer/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/rullzer/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rullzer/core/statuses/{sha}","languages_url":"https://api.github.com/repos/rullzer/core/languages","stargazers_url":"https://api.github.com/repos/rullzer/core/stargazers","contributors_url":"https://api.github.com/repos/rullzer/core/contributors","subscribers_url":"https://api.github.com/repos/rullzer/core/subscribers","subscription_url":"https://api.github.com/repos/rullzer/core/subscription","commits_url":"https://api.github.com/repos/rullzer/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/rullzer/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/rullzer/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/rullzer/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/rullzer/core/contents/{+path}","compare_url":"https://api.github.com/repos/rullzer/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rullzer/core/merges","archive_url":"https://api.github.com/repos/rullzer/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rullzer/core/downloads","issues_url":"https://api.github.com/repos/rullzer/core/issues{/number}","pulls_url":"https://api.github.com/repos/rullzer/core/pulls{/number}","milestones_url":"https://api.github.com/repos/rullzer/core/milestones{/number}","notifications_url":"https://api.github.com/repos/rullzer/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rullzer/core/labels{/name}","releases_url":"https://api.github.com/repos/rullzer/core/releases{/id}","created_at":"2015-01-21T20:40:40Z","updated_at":"2015-05-06T17:12:09Z","pushed_at":"2015-08-18T16:26:33Z","git_url":"git://github.com/rullzer/core.git","ssh_url":"git@github.com:rullzer/core.git","clone_url":"https://github.com/rullzer/core.git","svn_url":"https://github.com/rullzer/core","homepage":null,"size":173977,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"ddc7f668e59223d95cb42e4f0281d5dab5888d79","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","created_at":"2012-08-25T10:32:48Z","updated_at":"2015-08-19T03:32:18Z","pushed_at":"2015-08-19T09:09:32Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":1080658,"stargazers_count":3577,"watchers_count":3577,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1142,"mirror_url":null,"open_issues_count":1985,"forks":1142,"open_issues":1985,"watchers":3577,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/17773"},"html":{"href":"https://github.com/owncloud/core/pull/17773"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/17773"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/17773/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/17773/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/17773/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/26f7755e2480ddcf5d1da3bfd1bca80b39ce8077"}}}}