{"action":"created","comment":{"url":"https://api.github.com/repos/martinisgroup/servers/pulls/comments/34734901","id":34734901,"diff_hunk":"@@ -765,21 +782,33 @@ def setPolarity(self, chan, invert):\n         return self.testMode(self._setPolarity, chan, invert)\n \n     def setLVDS(self, cmd, sd, optimizeSD):\n-        \"\"\"\n-        INPUTS\n-        cmd - int: 2 for DAC A, 3 for DAC B\n-        sd - :\n-        optimizeSD - bool:\n-        \n-        Returns (success, MSD, MHD, t, (range(16), MSDbits, MHDbits), checkHex)\n-        success - bool: \n-        MSD - int:\n-        MHD - int:\n-        t - :\n-        range(16)\n-        MSDbits - :\n-        MHDbits - :\n-        checkHes - :\n+        \"\"\" Calibrate DAC LVDS\n+        Align DAC clocks for LVDS, varying SD (sample delay).\n+        :param int cmd: 2 for DAC A, 3 for DAC B\n+        :param int/None sd: If int, SD value to be set. If None, SD\n+                            set to value in registry. Ignored if\n+                            optimizeSD=True.\n+        :param bool optimizeSD: Whether to follow procedure from data\n+                                sheet to determine SD\n+        :return: success - If LVDS bringup successfull. MSD and MHD\n+                           should only flip once with flip locations\n+                           within one bit of each other. If varies,\n+                           could mean clock noise.\n+                 MSD - Measured sample delay. If optimizeSD, where MSD\n+                       flips when MHD=SD=0. Else -1.\n+                 MHD - Measured hold delay. If optimizeSD, where MHD\n+                       flips when MSD=SD=0. Else -1.\n+                 t - SD value set\n+                 tuple - Transpose of [SD, MSD(SD), MHD(SD) for SD in range(16)]\n+                 checkHex - In binary, '0bABC', where\n+                            A=1: An LVDS input above the IEEE input\n+                                 voltage specification limit\n+                            B=1: An LVDS input below the IEEE input\n+                                 voltage specification limit\n+                            C=1: Sampling in correct data cycle","path":"GHzDACs/Cleanup/dac.py","position":70,"original_position":70,"commit_id":"2116461800efb585401f7e357394800754c655a0","original_commit_id":"2116461800efb585401f7e357394800754c655a0","user":{"login":"pomalley","id":1106276,"avatar_url":"https://avatars.githubusercontent.com/u/1106276?v=3","gravatar_id":"","url":"https://api.github.com/users/pomalley","html_url":"https://github.com/pomalley","followers_url":"https://api.github.com/users/pomalley/followers","following_url":"https://api.github.com/users/pomalley/following{/other_user}","gists_url":"https://api.github.com/users/pomalley/gists{/gist_id}","starred_url":"https://api.github.com/users/pomalley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pomalley/subscriptions","organizations_url":"https://api.github.com/users/pomalley/orgs","repos_url":"https://api.github.com/users/pomalley/repos","events_url":"https://api.github.com/users/pomalley/events{/privacy}","received_events_url":"https://api.github.com/users/pomalley/received_events","type":"User","site_admin":false},"body":"What does this mean?","created_at":"2015-07-15T22:00:32Z","updated_at":"2015-07-15T22:00:32Z","html_url":"https://github.com/martinisgroup/servers/pull/200#discussion_r34734901","pull_request_url":"https://api.github.com/repos/martinisgroup/servers/pulls/200","_links":{"self":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/comments/34734901"},"html":{"href":"https://github.com/martinisgroup/servers/pull/200#discussion_r34734901"},"pull_request":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/200"}}},"pull_request":{"url":"https://api.github.com/repos/martinisgroup/servers/pulls/200","id":39875556,"html_url":"https://github.com/martinisgroup/servers/pull/200","diff_url":"https://github.com/martinisgroup/servers/pull/200.diff","patch_url":"https://github.com/martinisgroup/servers/pull/200.patch","issue_url":"https://api.github.com/repos/martinisgroup/servers/issues/200","number":200,"state":"open","locked":false,"title":"FPGA: Fill out docstrings for LVDS,FIFO Bringup","user":{"login":"jwenner","id":8183919,"avatar_url":"https://avatars.githubusercontent.com/u/8183919?v=3","gravatar_id":"","url":"https://api.github.com/users/jwenner","html_url":"https://github.com/jwenner","followers_url":"https://api.github.com/users/jwenner/followers","following_url":"https://api.github.com/users/jwenner/following{/other_user}","gists_url":"https://api.github.com/users/jwenner/gists{/gist_id}","starred_url":"https://api.github.com/users/jwenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwenner/subscriptions","organizations_url":"https://api.github.com/users/jwenner/orgs","repos_url":"https://api.github.com/users/jwenner/repos","events_url":"https://api.github.com/users/jwenner/events{/privacy}","received_events_url":"https://api.github.com/users/jwenner/received_events","type":"User","site_admin":false},"body":"Fill out docstrings for functions used in DAC LVDS and FIFO bringup.","created_at":"2015-07-14T02:06:10Z","updated_at":"2015-07-15T22:00:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae5383e15dce02e6c54b7d62fa762185038e11fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/martinisgroup/servers/pulls/200/commits","review_comments_url":"https://api.github.com/repos/martinisgroup/servers/pulls/200/comments","review_comment_url":"https://api.github.com/repos/martinisgroup/servers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/martinisgroup/servers/issues/200/comments","statuses_url":"https://api.github.com/repos/martinisgroup/servers/statuses/2116461800efb585401f7e357394800754c655a0","head":{"label":"martinisgroup:u/jwenner/doc_lvds_fifo","ref":"u/jwenner/doc_lvds_fifo","sha":"2116461800efb585401f7e357394800754c655a0","user":{"login":"martinisgroup","id":5026004,"avatar_url":"https://avatars.githubusercontent.com/u/5026004?v=3","gravatar_id":"","url":"https://api.github.com/users/martinisgroup","html_url":"https://github.com/martinisgroup","followers_url":"https://api.github.com/users/martinisgroup/followers","following_url":"https://api.github.com/users/martinisgroup/following{/other_user}","gists_url":"https://api.github.com/users/martinisgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/martinisgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinisgroup/subscriptions","organizations_url":"https://api.github.com/users/martinisgroup/orgs","repos_url":"https://api.github.com/users/martinisgroup/repos","events_url":"https://api.github.com/users/martinisgroup/events{/privacy}","received_events_url":"https://api.github.com/users/martinisgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":21184808,"name":"servers","full_name":"martinisgroup/servers","owner":{"login":"martinisgroup","id":5026004,"avatar_url":"https://avatars.githubusercontent.com/u/5026004?v=3","gravatar_id":"","url":"https://api.github.com/users/martinisgroup","html_url":"https://github.com/martinisgroup","followers_url":"https://api.github.com/users/martinisgroup/followers","following_url":"https://api.github.com/users/martinisgroup/following{/other_user}","gists_url":"https://api.github.com/users/martinisgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/martinisgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinisgroup/subscriptions","organizations_url":"https://api.github.com/users/martinisgroup/orgs","repos_url":"https://api.github.com/users/martinisgroup/repos","events_url":"https://api.github.com/users/martinisgroup/events{/privacy}","received_events_url":"https://api.github.com/users/martinisgroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/martinisgroup/servers","description":"","fork":false,"url":"https://api.github.com/repos/martinisgroup/servers","forks_url":"https://api.github.com/repos/martinisgroup/servers/forks","keys_url":"https://api.github.com/repos/martinisgroup/servers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinisgroup/servers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinisgroup/servers/teams","hooks_url":"https://api.github.com/repos/martinisgroup/servers/hooks","issue_events_url":"https://api.github.com/repos/martinisgroup/servers/issues/events{/number}","events_url":"https://api.github.com/repos/martinisgroup/servers/events","assignees_url":"https://api.github.com/repos/martinisgroup/servers/assignees{/user}","branches_url":"https://api.github.com/repos/martinisgroup/servers/branches{/branch}","tags_url":"https://api.github.com/repos/martinisgroup/servers/tags","blobs_url":"https://api.github.com/repos/martinisgroup/servers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinisgroup/servers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinisgroup/servers/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinisgroup/servers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinisgroup/servers/statuses/{sha}","languages_url":"https://api.github.com/repos/martinisgroup/servers/languages","stargazers_url":"https://api.github.com/repos/martinisgroup/servers/stargazers","contributors_url":"https://api.github.com/repos/martinisgroup/servers/contributors","subscribers_url":"https://api.github.com/repos/martinisgroup/servers/subscribers","subscription_url":"https://api.github.com/repos/martinisgroup/servers/subscription","commits_url":"https://api.github.com/repos/martinisgroup/servers/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinisgroup/servers/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinisgroup/servers/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinisgroup/servers/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinisgroup/servers/contents/{+path}","compare_url":"https://api.github.com/repos/martinisgroup/servers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinisgroup/servers/merges","archive_url":"https://api.github.com/repos/martinisgroup/servers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinisgroup/servers/downloads","issues_url":"https://api.github.com/repos/martinisgroup/servers/issues{/number}","pulls_url":"https://api.github.com/repos/martinisgroup/servers/pulls{/number}","milestones_url":"https://api.github.com/repos/martinisgroup/servers/milestones{/number}","notifications_url":"https://api.github.com/repos/martinisgroup/servers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinisgroup/servers/labels{/name}","releases_url":"https://api.github.com/repos/martinisgroup/servers/releases{/id}","created_at":"2014-06-25T00:07:25Z","updated_at":"2015-05-08T02:18:50Z","pushed_at":"2015-07-15T21:34:15Z","git_url":"git://github.com/martinisgroup/servers.git","ssh_url":"git@github.com:martinisgroup/servers.git","clone_url":"https://github.com/martinisgroup/servers.git","svn_url":"https://github.com/martinisgroup/servers","homepage":null,"size":54130,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":56,"forks":4,"open_issues":56,"watchers":2,"default_branch":"master"}},"base":{"label":"martinisgroup:master","ref":"master","sha":"828716c21a841325486195474996e887aa91b67e","user":{"login":"martinisgroup","id":5026004,"avatar_url":"https://avatars.githubusercontent.com/u/5026004?v=3","gravatar_id":"","url":"https://api.github.com/users/martinisgroup","html_url":"https://github.com/martinisgroup","followers_url":"https://api.github.com/users/martinisgroup/followers","following_url":"https://api.github.com/users/martinisgroup/following{/other_user}","gists_url":"https://api.github.com/users/martinisgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/martinisgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinisgroup/subscriptions","organizations_url":"https://api.github.com/users/martinisgroup/orgs","repos_url":"https://api.github.com/users/martinisgroup/repos","events_url":"https://api.github.com/users/martinisgroup/events{/privacy}","received_events_url":"https://api.github.com/users/martinisgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":21184808,"name":"servers","full_name":"martinisgroup/servers","owner":{"login":"martinisgroup","id":5026004,"avatar_url":"https://avatars.githubusercontent.com/u/5026004?v=3","gravatar_id":"","url":"https://api.github.com/users/martinisgroup","html_url":"https://github.com/martinisgroup","followers_url":"https://api.github.com/users/martinisgroup/followers","following_url":"https://api.github.com/users/martinisgroup/following{/other_user}","gists_url":"https://api.github.com/users/martinisgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/martinisgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinisgroup/subscriptions","organizations_url":"https://api.github.com/users/martinisgroup/orgs","repos_url":"https://api.github.com/users/martinisgroup/repos","events_url":"https://api.github.com/users/martinisgroup/events{/privacy}","received_events_url":"https://api.github.com/users/martinisgroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/martinisgroup/servers","description":"","fork":false,"url":"https://api.github.com/repos/martinisgroup/servers","forks_url":"https://api.github.com/repos/martinisgroup/servers/forks","keys_url":"https://api.github.com/repos/martinisgroup/servers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinisgroup/servers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinisgroup/servers/teams","hooks_url":"https://api.github.com/repos/martinisgroup/servers/hooks","issue_events_url":"https://api.github.com/repos/martinisgroup/servers/issues/events{/number}","events_url":"https://api.github.com/repos/martinisgroup/servers/events","assignees_url":"https://api.github.com/repos/martinisgroup/servers/assignees{/user}","branches_url":"https://api.github.com/repos/martinisgroup/servers/branches{/branch}","tags_url":"https://api.github.com/repos/martinisgroup/servers/tags","blobs_url":"https://api.github.com/repos/martinisgroup/servers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinisgroup/servers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinisgroup/servers/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinisgroup/servers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinisgroup/servers/statuses/{sha}","languages_url":"https://api.github.com/repos/martinisgroup/servers/languages","stargazers_url":"https://api.github.com/repos/martinisgroup/servers/stargazers","contributors_url":"https://api.github.com/repos/martinisgroup/servers/contributors","subscribers_url":"https://api.github.com/repos/martinisgroup/servers/subscribers","subscription_url":"https://api.github.com/repos/martinisgroup/servers/subscription","commits_url":"https://api.github.com/repos/martinisgroup/servers/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinisgroup/servers/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinisgroup/servers/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinisgroup/servers/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinisgroup/servers/contents/{+path}","compare_url":"https://api.github.com/repos/martinisgroup/servers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinisgroup/servers/merges","archive_url":"https://api.github.com/repos/martinisgroup/servers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinisgroup/servers/downloads","issues_url":"https://api.github.com/repos/martinisgroup/servers/issues{/number}","pulls_url":"https://api.github.com/repos/martinisgroup/servers/pulls{/number}","milestones_url":"https://api.github.com/repos/martinisgroup/servers/milestones{/number}","notifications_url":"https://api.github.com/repos/martinisgroup/servers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinisgroup/servers/labels{/name}","releases_url":"https://api.github.com/repos/martinisgroup/servers/releases{/id}","created_at":"2014-06-25T00:07:25Z","updated_at":"2015-05-08T02:18:50Z","pushed_at":"2015-07-15T21:34:15Z","git_url":"git://github.com/martinisgroup/servers.git","ssh_url":"git@github.com:martinisgroup/servers.git","clone_url":"https://github.com/martinisgroup/servers.git","svn_url":"https://github.com/martinisgroup/servers","homepage":null,"size":54130,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":56,"forks":4,"open_issues":56,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/200"},"html":{"href":"https://github.com/martinisgroup/servers/pull/200"},"issue":{"href":"https://api.github.com/repos/martinisgroup/servers/issues/200"},"comments":{"href":"https://api.github.com/repos/martinisgroup/servers/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/martinisgroup/servers/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/martinisgroup/servers/statuses/2116461800efb585401f7e357394800754c655a0"}}}}