{"action":"created","comment":{"url":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/comments/39030064","id":39030064,"diff_hunk":"@@ -24,7 +24,10 @@ public function modifyAction(Request $request) {\n \t\t\t'settings' => $allStoredSettings,\n \t\t);\n \n-\t\t$form = $this->createForm(new ModifySettingsForm(), $formData);\n+\t\t$form = Kernel::VERSION_ID < 20800\n+\t\t\t? $this->createForm(new LegacyModifySettingsForm(), $formData)\n+\t\t\t: $this->get('form.factory')->createNamed('craue_config_modifySettings', 'Craue\\ConfigBundle\\Form\\ModifySettingsForm', $formData);","path":"Controller/SettingsController.php","position":16,"original_position":16,"commit_id":"058289ef8160f4c9c8540598be39df1e7a1ab86b","original_commit_id":"058289ef8160f4c9c8540598be39df1e7a1ab86b","user":{"login":"craue","id":800119,"avatar_url":"https://avatars.githubusercontent.com/u/800119?v=3","gravatar_id":"","url":"https://api.github.com/users/craue","html_url":"https://github.com/craue","followers_url":"https://api.github.com/users/craue/followers","following_url":"https://api.github.com/users/craue/following{/other_user}","gists_url":"https://api.github.com/users/craue/gists{/gist_id}","starred_url":"https://api.github.com/users/craue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craue/subscriptions","organizations_url":"https://api.github.com/users/craue/orgs","repos_url":"https://api.github.com/users/craue/repos","events_url":"https://api.github.com/users/craue/events{/privacy}","received_events_url":"https://api.github.com/users/craue/received_events","type":"User","site_admin":false},"body":"@stof, that would change the rendered ids and names from `craue_config_modifySettings...` to `modify_settings_form...`.","created_at":"2015-09-09T11:07:44Z","updated_at":"2015-09-09T11:07:44Z","html_url":"https://github.com/craue/CraueConfigBundle/pull/22#discussion_r39030064","pull_request_url":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/comments/39030064"},"html":{"href":"https://github.com/craue/CraueConfigBundle/pull/22#discussion_r39030064"},"pull_request":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/22","id":41463029,"html_url":"https://github.com/craue/CraueConfigBundle/pull/22","diff_url":"https://github.com/craue/CraueConfigBundle/pull/22.diff","patch_url":"https://github.com/craue/CraueConfigBundle/pull/22.patch","issue_url":"https://api.github.com/repos/craue/CraueConfigBundle/issues/22","number":22,"state":"closed","locked":false,"title":"avoid deprecation notices with Symfony 2.8","user":{"login":"craue","id":800119,"avatar_url":"https://avatars.githubusercontent.com/u/800119?v=3","gravatar_id":"","url":"https://api.github.com/users/craue","html_url":"https://github.com/craue","followers_url":"https://api.github.com/users/craue/followers","following_url":"https://api.github.com/users/craue/following{/other_user}","gists_url":"https://api.github.com/users/craue/gists{/gist_id}","starred_url":"https://api.github.com/users/craue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craue/subscriptions","organizations_url":"https://api.github.com/users/craue/orgs","repos_url":"https://api.github.com/users/craue/repos","events_url":"https://api.github.com/users/craue/events{/privacy}","received_events_url":"https://api.github.com/users/craue/received_events","type":"User","site_admin":false},"body":"This PR is meant for trying to avoid as many deprecation notices as possible introduced by symfony/symfony#15079.\r\n\r\nI'm pretty sure I've updated all relevant code to not use deprecated functionality while keeping BC. The remaining notices seem to be triggered by Symfony itself.\r\n\r\nTravis log:\r\n- pre-PR: https://travis-ci.org/craue/CraueConfigBundle/jobs/73882235\r\n- post-PR: https://travis-ci.org/craue/CraueConfigBundle/jobs/73882878","created_at":"2015-08-03T12:44:49Z","updated_at":"2015-09-09T11:07:44Z","closed_at":"2015-08-05T15:52:52Z","merged_at":"2015-08-05T15:52:52Z","merge_commit_sha":"4b0406d6798d30865affe01d81617910891c2026","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/22/commits","review_comments_url":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/22/comments","review_comment_url":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/craue/CraueConfigBundle/issues/22/comments","statuses_url":"https://api.github.com/repos/craue/CraueConfigBundle/statuses/058289ef8160f4c9c8540598be39df1e7a1ab86b","head":{"label":"craue:avoid-deprecation-notices","ref":"avoid-deprecation-notices","sha":"058289ef8160f4c9c8540598be39df1e7a1ab86b","user":{"login":"craue","id":800119,"avatar_url":"https://avatars.githubusercontent.com/u/800119?v=3","gravatar_id":"","url":"https://api.github.com/users/craue","html_url":"https://github.com/craue","followers_url":"https://api.github.com/users/craue/followers","following_url":"https://api.github.com/users/craue/following{/other_user}","gists_url":"https://api.github.com/users/craue/gists{/gist_id}","starred_url":"https://api.github.com/users/craue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craue/subscriptions","organizations_url":"https://api.github.com/users/craue/orgs","repos_url":"https://api.github.com/users/craue/repos","events_url":"https://api.github.com/users/craue/events{/privacy}","received_events_url":"https://api.github.com/users/craue/received_events","type":"User","site_admin":false},"repo":{"id":2011216,"name":"CraueConfigBundle","full_name":"craue/CraueConfigBundle","owner":{"login":"craue","id":800119,"avatar_url":"https://avatars.githubusercontent.com/u/800119?v=3","gravatar_id":"","url":"https://api.github.com/users/craue","html_url":"https://github.com/craue","followers_url":"https://api.github.com/users/craue/followers","following_url":"https://api.github.com/users/craue/following{/other_user}","gists_url":"https://api.github.com/users/craue/gists{/gist_id}","starred_url":"https://api.github.com/users/craue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craue/subscriptions","organizations_url":"https://api.github.com/users/craue/orgs","repos_url":"https://api.github.com/users/craue/repos","events_url":"https://api.github.com/users/craue/events{/privacy}","received_events_url":"https://api.github.com/users/craue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/craue/CraueConfigBundle","description":"Database-stored settings made available via a service for your Symfony2 project.","fork":false,"url":"https://api.github.com/repos/craue/CraueConfigBundle","forks_url":"https://api.github.com/repos/craue/CraueConfigBundle/forks","keys_url":"https://api.github.com/repos/craue/CraueConfigBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/craue/CraueConfigBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/craue/CraueConfigBundle/teams","hooks_url":"https://api.github.com/repos/craue/CraueConfigBundle/hooks","issue_events_url":"https://api.github.com/repos/craue/CraueConfigBundle/issues/events{/number}","events_url":"https://api.github.com/repos/craue/CraueConfigBundle/events","assignees_url":"https://api.github.com/repos/craue/CraueConfigBundle/assignees{/user}","branches_url":"https://api.github.com/repos/craue/CraueConfigBundle/branches{/branch}","tags_url":"https://api.github.com/repos/craue/CraueConfigBundle/tags","blobs_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/craue/CraueConfigBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/craue/CraueConfigBundle/languages","stargazers_url":"https://api.github.com/repos/craue/CraueConfigBundle/stargazers","contributors_url":"https://api.github.com/repos/craue/CraueConfigBundle/contributors","subscribers_url":"https://api.github.com/repos/craue/CraueConfigBundle/subscribers","subscription_url":"https://api.github.com/repos/craue/CraueConfigBundle/subscription","commits_url":"https://api.github.com/repos/craue/CraueConfigBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/craue/CraueConfigBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/craue/CraueConfigBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/craue/CraueConfigBundle/contents/{+path}","compare_url":"https://api.github.com/repos/craue/CraueConfigBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/craue/CraueConfigBundle/merges","archive_url":"https://api.github.com/repos/craue/CraueConfigBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/craue/CraueConfigBundle/downloads","issues_url":"https://api.github.com/repos/craue/CraueConfigBundle/issues{/number}","pulls_url":"https://api.github.com/repos/craue/CraueConfigBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/craue/CraueConfigBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/craue/CraueConfigBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/craue/CraueConfigBundle/labels{/name}","releases_url":"https://api.github.com/repos/craue/CraueConfigBundle/releases{/id}","created_at":"2011-07-07T08:39:50Z","updated_at":"2015-08-13T10:28:05Z","pushed_at":"2015-09-08T18:10:45Z","git_url":"git://github.com/craue/CraueConfigBundle.git","ssh_url":"git@github.com:craue/CraueConfigBundle.git","clone_url":"https://github.com/craue/CraueConfigBundle.git","svn_url":"https://github.com/craue/CraueConfigBundle","homepage":"","size":517,"stargazers_count":51,"watchers_count":51,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":5,"forks":15,"open_issues":5,"watchers":51,"default_branch":"master"}},"base":{"label":"craue:master","ref":"master","sha":"88f764d88582549d1b246ce4b8078b649b7248e6","user":{"login":"craue","id":800119,"avatar_url":"https://avatars.githubusercontent.com/u/800119?v=3","gravatar_id":"","url":"https://api.github.com/users/craue","html_url":"https://github.com/craue","followers_url":"https://api.github.com/users/craue/followers","following_url":"https://api.github.com/users/craue/following{/other_user}","gists_url":"https://api.github.com/users/craue/gists{/gist_id}","starred_url":"https://api.github.com/users/craue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craue/subscriptions","organizations_url":"https://api.github.com/users/craue/orgs","repos_url":"https://api.github.com/users/craue/repos","events_url":"https://api.github.com/users/craue/events{/privacy}","received_events_url":"https://api.github.com/users/craue/received_events","type":"User","site_admin":false},"repo":{"id":2011216,"name":"CraueConfigBundle","full_name":"craue/CraueConfigBundle","owner":{"login":"craue","id":800119,"avatar_url":"https://avatars.githubusercontent.com/u/800119?v=3","gravatar_id":"","url":"https://api.github.com/users/craue","html_url":"https://github.com/craue","followers_url":"https://api.github.com/users/craue/followers","following_url":"https://api.github.com/users/craue/following{/other_user}","gists_url":"https://api.github.com/users/craue/gists{/gist_id}","starred_url":"https://api.github.com/users/craue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craue/subscriptions","organizations_url":"https://api.github.com/users/craue/orgs","repos_url":"https://api.github.com/users/craue/repos","events_url":"https://api.github.com/users/craue/events{/privacy}","received_events_url":"https://api.github.com/users/craue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/craue/CraueConfigBundle","description":"Database-stored settings made available via a service for your Symfony2 project.","fork":false,"url":"https://api.github.com/repos/craue/CraueConfigBundle","forks_url":"https://api.github.com/repos/craue/CraueConfigBundle/forks","keys_url":"https://api.github.com/repos/craue/CraueConfigBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/craue/CraueConfigBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/craue/CraueConfigBundle/teams","hooks_url":"https://api.github.com/repos/craue/CraueConfigBundle/hooks","issue_events_url":"https://api.github.com/repos/craue/CraueConfigBundle/issues/events{/number}","events_url":"https://api.github.com/repos/craue/CraueConfigBundle/events","assignees_url":"https://api.github.com/repos/craue/CraueConfigBundle/assignees{/user}","branches_url":"https://api.github.com/repos/craue/CraueConfigBundle/branches{/branch}","tags_url":"https://api.github.com/repos/craue/CraueConfigBundle/tags","blobs_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/craue/CraueConfigBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/craue/CraueConfigBundle/languages","stargazers_url":"https://api.github.com/repos/craue/CraueConfigBundle/stargazers","contributors_url":"https://api.github.com/repos/craue/CraueConfigBundle/contributors","subscribers_url":"https://api.github.com/repos/craue/CraueConfigBundle/subscribers","subscription_url":"https://api.github.com/repos/craue/CraueConfigBundle/subscription","commits_url":"https://api.github.com/repos/craue/CraueConfigBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/craue/CraueConfigBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/craue/CraueConfigBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/craue/CraueConfigBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/craue/CraueConfigBundle/contents/{+path}","compare_url":"https://api.github.com/repos/craue/CraueConfigBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/craue/CraueConfigBundle/merges","archive_url":"https://api.github.com/repos/craue/CraueConfigBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/craue/CraueConfigBundle/downloads","issues_url":"https://api.github.com/repos/craue/CraueConfigBundle/issues{/number}","pulls_url":"https://api.github.com/repos/craue/CraueConfigBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/craue/CraueConfigBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/craue/CraueConfigBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/craue/CraueConfigBundle/labels{/name}","releases_url":"https://api.github.com/repos/craue/CraueConfigBundle/releases{/id}","created_at":"2011-07-07T08:39:50Z","updated_at":"2015-08-13T10:28:05Z","pushed_at":"2015-09-08T18:10:45Z","git_url":"git://github.com/craue/CraueConfigBundle.git","ssh_url":"git@github.com:craue/CraueConfigBundle.git","clone_url":"https://github.com/craue/CraueConfigBundle.git","svn_url":"https://github.com/craue/CraueConfigBundle","homepage":"","size":517,"stargazers_count":51,"watchers_count":51,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":5,"forks":15,"open_issues":5,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/22"},"html":{"href":"https://github.com/craue/CraueConfigBundle/pull/22"},"issue":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/issues/22"},"comments":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/craue/CraueConfigBundle/statuses/058289ef8160f4c9c8540598be39df1e7a1ab86b"}}}}