{"action":"created","issue":{"url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/1638","labels_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/1638/labels{/name}","comments_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/1638/comments","events_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/1638/events","html_url":"https://github.com/duckduckgo/zeroclickinfo-spice/issues/1638","id":61905353,"number":1638,"title":"Switch \"String::Trim\" to \"Text::Trim\"","user":{"login":"moollaza","id":873785,"avatar_url":"https://avatars.githubusercontent.com/u/873785?v=3","gravatar_id":"","url":"https://api.github.com/users/moollaza","html_url":"https://github.com/moollaza","followers_url":"https://api.github.com/users/moollaza/followers","following_url":"https://api.github.com/users/moollaza/following{/other_user}","gists_url":"https://api.github.com/users/moollaza/gists{/gist_id}","starred_url":"https://api.github.com/users/moollaza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moollaza/subscriptions","organizations_url":"https://api.github.com/users/moollaza/orgs","repos_url":"https://api.github.com/users/moollaza/repos","events_url":"https://api.github.com/users/moollaza/events{/privacy}","received_events_url":"https://api.github.com/users/moollaza/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/labels/Improvement","name":"Improvement","color":"d7e102"},{"url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/labels/Low-Hanging%20Fruit","name":"Low-Hanging Fruit","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-03-15T21:40:45Z","updated_at":"2015-03-16T15:53:07Z","closed_at":null,"body":"We're currently using both `Text::Trim` and `String::Trim` in various Spices. This seems unnecessary and I believe we might as well choose one lib and just use that one. I vote for `Text::Trim`, but I don't think one is much better than the other - any opinions on which to choose?\r\n\r\nOnce we decide, let's updated the Goodies so that they're all using the same package.\r\n\r\nAlso, some other Goodies define a `trim` sub or use a regex to trim leading/trailing spaces. We should probably update those to use a more robust `trim` sub provided by the package we choose."},"comment":{"url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/comments/81756512","html_url":"https://github.com/duckduckgo/zeroclickinfo-spice/issues/1638#issuecomment-81756512","issue_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-spice/issues/1638","id":81756512,"user":{"login":"MrChrisW","id":5282264,"avatar_url":"https://avatars.githubusercontent.com/u/5282264?v=3","gravatar_id":"","url":"https://api.github.com/users/MrChrisW","html_url":"https://github.com/MrChrisW","followers_url":"https://api.github.com/users/MrChrisW/followers","following_url":"https://api.github.com/users/MrChrisW/following{/other_user}","gists_url":"https://api.github.com/users/MrChrisW/gists{/gist_id}","starred_url":"https://api.github.com/users/MrChrisW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrChrisW/subscriptions","organizations_url":"https://api.github.com/users/MrChrisW/orgs","repos_url":"https://api.github.com/users/MrChrisW/repos","events_url":"https://api.github.com/users/MrChrisW/events{/privacy}","received_events_url":"https://api.github.com/users/MrChrisW/received_events","type":"User","site_admin":false},"created_at":"2015-03-16T15:53:07Z","updated_at":"2015-03-16T15:53:07Z","body":"[Text::Trim](https://metacpan.org/pod/Text::Trim) looks good to me! After a little research there's no performance difference between the above mentioned packages however I believe `String::Strip` can be faster as its implemented in XS however unmaintained."}}