{"action":"created","issue":{"url":"https://api.github.com/repos/purescript/purescript-foldable-traversable/issues/30","labels_url":"https://api.github.com/repos/purescript/purescript-foldable-traversable/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/purescript/purescript-foldable-traversable/issues/30/comments","events_url":"https://api.github.com/repos/purescript/purescript-foldable-traversable/issues/30/events","html_url":"https://github.com/purescript/purescript-foldable-traversable/pull/30","id":92556525,"number":30,"title":"Default impls for Foldable & Traversable methods","user":{"login":"LiamGoodacre","id":1189645,"avatar_url":"https://avatars.githubusercontent.com/u/1189645?v=3","gravatar_id":"","url":"https://api.github.com/users/LiamGoodacre","html_url":"https://github.com/LiamGoodacre","followers_url":"https://api.github.com/users/LiamGoodacre/followers","following_url":"https://api.github.com/users/LiamGoodacre/following{/other_user}","gists_url":"https://api.github.com/users/LiamGoodacre/gists{/gist_id}","starred_url":"https://api.github.com/users/LiamGoodacre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiamGoodacre/subscriptions","organizations_url":"https://api.github.com/users/LiamGoodacre/orgs","repos_url":"https://api.github.com/users/LiamGoodacre/repos","events_url":"https://api.github.com/users/LiamGoodacre/events{/privacy}","received_events_url":"https://api.github.com/users/LiamGoodacre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-07-02T05:59:28Z","updated_at":"2015-07-02T16:41:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/purescript/purescript-foldable-traversable/pulls/30","html_url":"https://github.com/purescript/purescript-foldable-traversable/pull/30","diff_url":"https://github.com/purescript/purescript-foldable-traversable/pull/30.diff","patch_url":"https://github.com/purescript/purescript-foldable-traversable/pull/30.patch"},"body":"[Ticket #27](https://github.com/purescript/purescript-foldable-traversable/issues/27)\r\n\r\nFunctions added:\r\n\r\n* foldMapDefaultL\r\n* foldMapDefaultR\r\n* foldlDefault\r\n* foldrDefault\r\n* traverseDefault\r\n* sequenceDefault\r\n\r\nAdded tests for each new function.\r\n\r\nPlus regenerated docs.\r\n\r\n---\r\n\r\nAdded two `foldMap` defaults because if you're using the defaults you'll probably only implement one of the three methods and if you only had `foldMapDefault` defined in terms of `foldr` and tried to use both `foldrDefault` and `foldMapDefault`, you'd get a stack overflow due to non-termination (which I got initially when writing the tests).  So now you can pick `foldMapDefaultL`/`foldMapDefaultR`, which are respectively defined in terms of `foldl`/`foldr`.\r\n\r\nAny thoughts/feedback?"},"comment":{"url":"https://api.github.com/repos/purescript/purescript-foldable-traversable/issues/comments/118089163","html_url":"https://github.com/purescript/purescript-foldable-traversable/pull/30#issuecomment-118089163","issue_url":"https://api.github.com/repos/purescript/purescript-foldable-traversable/issues/30","id":118089163,"user":{"login":"garyb","id":693642,"avatar_url":"https://avatars.githubusercontent.com/u/693642?v=3","gravatar_id":"","url":"https://api.github.com/users/garyb","html_url":"https://github.com/garyb","followers_url":"https://api.github.com/users/garyb/followers","following_url":"https://api.github.com/users/garyb/following{/other_user}","gists_url":"https://api.github.com/users/garyb/gists{/gist_id}","starred_url":"https://api.github.com/users/garyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyb/subscriptions","organizations_url":"https://api.github.com/users/garyb/orgs","repos_url":"https://api.github.com/users/garyb/repos","events_url":"https://api.github.com/users/garyb/events{/privacy}","received_events_url":"https://api.github.com/users/garyb/received_events","type":"User","site_admin":false},"created_at":"2015-07-02T16:41:37Z","updated_at":"2015-07-02T16:41:37Z","body":"Sure. It's a little bit of a shame `pulp` generates folders for the namespaces actually, I think it's more convenient to navigate just a list of files for the docs rather than a tree, but I guess since we provide the list in the readme it negates that.\r\n\r\nI'll be going through and updating all the gulp files now the new plugin is done, shall I change everything over to use the hierarchical paths?"}}