{"action":"created","issue":{"url":"https://api.github.com/repos/dreamwidth/dw-free/issues/1357","labels_url":"https://api.github.com/repos/dreamwidth/dw-free/issues/1357/labels{/name}","comments_url":"https://api.github.com/repos/dreamwidth/dw-free/issues/1357/comments","events_url":"https://api.github.com/repos/dreamwidth/dw-free/issues/1357/events","html_url":"https://github.com/dreamwidth/dw-free/pull/1357","id":70804160,"number":1357,"title":"[#772] English-stripping and refactoring for OpenID account creation","user":{"login":"kareila","id":1976742,"avatar_url":"https://avatars.githubusercontent.com/u/1976742?v=3","gravatar_id":"","url":"https://api.github.com/users/kareila","html_url":"https://github.com/kareila","followers_url":"https://api.github.com/users/kareila/followers","following_url":"https://api.github.com/users/kareila/following{/other_user}","gists_url":"https://api.github.com/users/kareila/gists{/gist_id}","starred_url":"https://api.github.com/users/kareila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kareila/subscriptions","organizations_url":"https://api.github.com/users/kareila/orgs","repos_url":"https://api.github.com/users/kareila/repos","events_url":"https://api.github.com/users/kareila/events{/privacy}","received_events_url":"https://api.github.com/users/kareila/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dreamwidth/dw-free/labels/status:%20untriaged","name":"status: untriaged","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-04-24T21:53:54Z","updated_at":"2015-04-24T23:03:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dreamwidth/dw-free/pulls/1357","html_url":"https://github.com/dreamwidth/dw-free/pull/1357","diff_url":"https://github.com/dreamwidth/dw-free/pull/1357.diff","patch_url":"https://github.com/dreamwidth/dw-free/pull/1357.patch"},"body":"It was pointed out that some obscure OpenID account creation errors\r\nwere English-stripped in one place (/openid/login.bml) and not another\r\n(/talkpost_do.bml).  This updates the English-stripping in both places\r\nto be consistent and slightly more user-comprehensible.\r\n\r\nSome of the validation process has been refactored into a new class\r\nfunction, LJ::User::load_from_consumer, to reduce code duplication.\r\n\r\nFixes #772."},"comment":{"url":"https://api.github.com/repos/dreamwidth/dw-free/issues/comments/96091249","html_url":"https://github.com/dreamwidth/dw-free/pull/1357#issuecomment-96091249","issue_url":"https://api.github.com/repos/dreamwidth/dw-free/issues/1357","id":96091249,"user":{"login":"kareila","id":1976742,"avatar_url":"https://avatars.githubusercontent.com/u/1976742?v=3","gravatar_id":"","url":"https://api.github.com/users/kareila","html_url":"https://github.com/kareila","followers_url":"https://api.github.com/users/kareila/followers","following_url":"https://api.github.com/users/kareila/following{/other_user}","gists_url":"https://api.github.com/users/kareila/gists{/gist_id}","starred_url":"https://api.github.com/users/kareila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kareila/subscriptions","organizations_url":"https://api.github.com/users/kareila/orgs","repos_url":"https://api.github.com/users/kareila/repos","events_url":"https://api.github.com/users/kareila/events{/privacy}","received_events_url":"https://api.github.com/users/kareila/received_events","type":"User","site_admin":false},"created_at":"2015-04-24T23:03:44Z","updated_at":"2015-04-24T23:03:44Z","body":"I will do that.\r\n\r\n@afuna, do you want to commit this as is or do you want me to pull out the changes to talkpost_do and undo the refactoring?"}}