{"action":"closed","number":16,"pull_request":{"url":"https://api.github.com/repos/dbachelder/CreditCardEntry/pulls/16","id":39970033,"html_url":"https://github.com/dbachelder/CreditCardEntry/pull/16","diff_url":"https://github.com/dbachelder/CreditCardEntry/pull/16.diff","patch_url":"https://github.com/dbachelder/CreditCardEntry/pull/16.patch","issue_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/issues/16","number":16,"state":"closed","locked":false,"title":"Fix CreditCardForm#isCreditCardValid().","user":{"login":"kojustin","id":965243,"avatar_url":"https://avatars.githubusercontent.com/u/965243?v=3","gravatar_id":"","url":"https://api.github.com/users/kojustin","html_url":"https://github.com/kojustin","followers_url":"https://api.github.com/users/kojustin/followers","following_url":"https://api.github.com/users/kojustin/following{/other_user}","gists_url":"https://api.github.com/users/kojustin/gists{/gist_id}","starred_url":"https://api.github.com/users/kojustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kojustin/subscriptions","organizations_url":"https://api.github.com/users/kojustin/orgs","repos_url":"https://api.github.com/users/kojustin/repos","events_url":"https://api.github.com/users/kojustin/events{/privacy}","received_events_url":"https://api.github.com/users/kojustin/received_events","type":"User","site_admin":false},"body":"CreditCardForm#isCreditCardValid() always returns if called from the CardValidCallback#cardValid(). This is because the base credit cards fields are not calling `setValid()` until AFTER they call the delegate's update methods. This patch just reverses the order of the delegate and `setValid()` calls.","created_at":"2015-07-14T22:25:42Z","updated_at":"2015-07-14T22:26:53Z","closed_at":"2015-07-14T22:26:53Z","merged_at":"2015-07-14T22:26:53Z","merge_commit_sha":"3a397af203fa769ef5ac3a70e12bda6cb003ecc4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/pulls/16/commits","review_comments_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/pulls/16/comments","review_comment_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/issues/16/comments","statuses_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/statuses/836cfed7f88a8d92f64c65664855472921956af4","head":{"label":"kojustin:master","ref":"master","sha":"836cfed7f88a8d92f64c65664855472921956af4","user":{"login":"kojustin","id":965243,"avatar_url":"https://avatars.githubusercontent.com/u/965243?v=3","gravatar_id":"","url":"https://api.github.com/users/kojustin","html_url":"https://github.com/kojustin","followers_url":"https://api.github.com/users/kojustin/followers","following_url":"https://api.github.com/users/kojustin/following{/other_user}","gists_url":"https://api.github.com/users/kojustin/gists{/gist_id}","starred_url":"https://api.github.com/users/kojustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kojustin/subscriptions","organizations_url":"https://api.github.com/users/kojustin/orgs","repos_url":"https://api.github.com/users/kojustin/repos","events_url":"https://api.github.com/users/kojustin/events{/privacy}","received_events_url":"https://api.github.com/users/kojustin/received_events","type":"User","site_admin":false},"repo":{"id":39102980,"name":"CreditCardEntry","full_name":"kojustin/CreditCardEntry","owner":{"login":"kojustin","id":965243,"avatar_url":"https://avatars.githubusercontent.com/u/965243?v=3","gravatar_id":"","url":"https://api.github.com/users/kojustin","html_url":"https://github.com/kojustin","followers_url":"https://api.github.com/users/kojustin/followers","following_url":"https://api.github.com/users/kojustin/following{/other_user}","gists_url":"https://api.github.com/users/kojustin/gists{/gist_id}","starred_url":"https://api.github.com/users/kojustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kojustin/subscriptions","organizations_url":"https://api.github.com/users/kojustin/orgs","repos_url":"https://api.github.com/users/kojustin/repos","events_url":"https://api.github.com/users/kojustin/events{/privacy}","received_events_url":"https://api.github.com/users/kojustin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kojustin/CreditCardEntry","description":"Smooth UI for Credit Card Entry on Android device, regex check for supported credit card types and luhn check. Inspired by Square credit card entry interface","fork":true,"url":"https://api.github.com/repos/kojustin/CreditCardEntry","forks_url":"https://api.github.com/repos/kojustin/CreditCardEntry/forks","keys_url":"https://api.github.com/repos/kojustin/CreditCardEntry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kojustin/CreditCardEntry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kojustin/CreditCardEntry/teams","hooks_url":"https://api.github.com/repos/kojustin/CreditCardEntry/hooks","issue_events_url":"https://api.github.com/repos/kojustin/CreditCardEntry/issues/events{/number}","events_url":"https://api.github.com/repos/kojustin/CreditCardEntry/events","assignees_url":"https://api.github.com/repos/kojustin/CreditCardEntry/assignees{/user}","branches_url":"https://api.github.com/repos/kojustin/CreditCardEntry/branches{/branch}","tags_url":"https://api.github.com/repos/kojustin/CreditCardEntry/tags","blobs_url":"https://api.github.com/repos/kojustin/CreditCardEntry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kojustin/CreditCardEntry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kojustin/CreditCardEntry/git/refs{/sha}","trees_url":"https://api.github.com/repos/kojustin/CreditCardEntry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kojustin/CreditCardEntry/statuses/{sha}","languages_url":"https://api.github.com/repos/kojustin/CreditCardEntry/languages","stargazers_url":"https://api.github.com/repos/kojustin/CreditCardEntry/stargazers","contributors_url":"https://api.github.com/repos/kojustin/CreditCardEntry/contributors","subscribers_url":"https://api.github.com/repos/kojustin/CreditCardEntry/subscribers","subscription_url":"https://api.github.com/repos/kojustin/CreditCardEntry/subscription","commits_url":"https://api.github.com/repos/kojustin/CreditCardEntry/commits{/sha}","git_commits_url":"https://api.github.com/repos/kojustin/CreditCardEntry/git/commits{/sha}","comments_url":"https://api.github.com/repos/kojustin/CreditCardEntry/comments{/number}","issue_comment_url":"https://api.github.com/repos/kojustin/CreditCardEntry/issues/comments{/number}","contents_url":"https://api.github.com/repos/kojustin/CreditCardEntry/contents/{+path}","compare_url":"https://api.github.com/repos/kojustin/CreditCardEntry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kojustin/CreditCardEntry/merges","archive_url":"https://api.github.com/repos/kojustin/CreditCardEntry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kojustin/CreditCardEntry/downloads","issues_url":"https://api.github.com/repos/kojustin/CreditCardEntry/issues{/number}","pulls_url":"https://api.github.com/repos/kojustin/CreditCardEntry/pulls{/number}","milestones_url":"https://api.github.com/repos/kojustin/CreditCardEntry/milestones{/number}","notifications_url":"https://api.github.com/repos/kojustin/CreditCardEntry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kojustin/CreditCardEntry/labels{/name}","releases_url":"https://api.github.com/repos/kojustin/CreditCardEntry/releases{/id}","created_at":"2015-07-14T22:10:17Z","updated_at":"2015-07-14T22:10:17Z","pushed_at":"2015-07-14T22:22:36Z","git_url":"git://github.com/kojustin/CreditCardEntry.git","ssh_url":"git@github.com:kojustin/CreditCardEntry.git","clone_url":"https://github.com/kojustin/CreditCardEntry.git","svn_url":"https://github.com/kojustin/CreditCardEntry","homepage":null,"size":1943,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dbachelder:master","ref":"master","sha":"7df7f3750d9fbdcef77f0a63806f1a485e3f75a8","user":{"login":"dbachelder","id":325706,"avatar_url":"https://avatars.githubusercontent.com/u/325706?v=3","gravatar_id":"","url":"https://api.github.com/users/dbachelder","html_url":"https://github.com/dbachelder","followers_url":"https://api.github.com/users/dbachelder/followers","following_url":"https://api.github.com/users/dbachelder/following{/other_user}","gists_url":"https://api.github.com/users/dbachelder/gists{/gist_id}","starred_url":"https://api.github.com/users/dbachelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbachelder/subscriptions","organizations_url":"https://api.github.com/users/dbachelder/orgs","repos_url":"https://api.github.com/users/dbachelder/repos","events_url":"https://api.github.com/users/dbachelder/events{/privacy}","received_events_url":"https://api.github.com/users/dbachelder/received_events","type":"User","site_admin":false},"repo":{"id":9172467,"name":"CreditCardEntry","full_name":"dbachelder/CreditCardEntry","owner":{"login":"dbachelder","id":325706,"avatar_url":"https://avatars.githubusercontent.com/u/325706?v=3","gravatar_id":"","url":"https://api.github.com/users/dbachelder","html_url":"https://github.com/dbachelder","followers_url":"https://api.github.com/users/dbachelder/followers","following_url":"https://api.github.com/users/dbachelder/following{/other_user}","gists_url":"https://api.github.com/users/dbachelder/gists{/gist_id}","starred_url":"https://api.github.com/users/dbachelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbachelder/subscriptions","organizations_url":"https://api.github.com/users/dbachelder/orgs","repos_url":"https://api.github.com/users/dbachelder/repos","events_url":"https://api.github.com/users/dbachelder/events{/privacy}","received_events_url":"https://api.github.com/users/dbachelder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dbachelder/CreditCardEntry","description":"Smooth UI for Credit Card Entry on Android device, regex check for supported credit card types and luhn check. Inspired by Square credit card entry interface","fork":false,"url":"https://api.github.com/repos/dbachelder/CreditCardEntry","forks_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/forks","keys_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/teams","hooks_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/hooks","issue_events_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/issues/events{/number}","events_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/events","assignees_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/assignees{/user}","branches_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/branches{/branch}","tags_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/tags","blobs_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/statuses/{sha}","languages_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/languages","stargazers_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/stargazers","contributors_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/contributors","subscribers_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/subscribers","subscription_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/subscription","commits_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/contents/{+path}","compare_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/merges","archive_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/downloads","issues_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/issues{/number}","pulls_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/pulls{/number}","milestones_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/milestones{/number}","notifications_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/labels{/name}","releases_url":"https://api.github.com/repos/dbachelder/CreditCardEntry/releases{/id}","created_at":"2013-04-02T14:47:18Z","updated_at":"2015-07-09T01:41:36Z","pushed_at":"2015-07-14T22:26:53Z","git_url":"git://github.com/dbachelder/CreditCardEntry.git","ssh_url":"git@github.com:dbachelder/CreditCardEntry.git","clone_url":"https://github.com/dbachelder/CreditCardEntry.git","svn_url":"https://github.com/dbachelder/CreditCardEntry","homepage":null,"size":1943,"stargazers_count":293,"watchers_count":293,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":3,"forks":63,"open_issues":3,"watchers":293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dbachelder/CreditCardEntry/pulls/16"},"html":{"href":"https://github.com/dbachelder/CreditCardEntry/pull/16"},"issue":{"href":"https://api.github.com/repos/dbachelder/CreditCardEntry/issues/16"},"comments":{"href":"https://api.github.com/repos/dbachelder/CreditCardEntry/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/dbachelder/CreditCardEntry/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/dbachelder/CreditCardEntry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dbachelder/CreditCardEntry/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/dbachelder/CreditCardEntry/statuses/836cfed7f88a8d92f64c65664855472921956af4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dbachelder","id":325706,"avatar_url":"https://avatars.githubusercontent.com/u/325706?v=3","gravatar_id":"","url":"https://api.github.com/users/dbachelder","html_url":"https://github.com/dbachelder","followers_url":"https://api.github.com/users/dbachelder/followers","following_url":"https://api.github.com/users/dbachelder/following{/other_user}","gists_url":"https://api.github.com/users/dbachelder/gists{/gist_id}","starred_url":"https://api.github.com/users/dbachelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbachelder/subscriptions","organizations_url":"https://api.github.com/users/dbachelder/orgs","repos_url":"https://api.github.com/users/dbachelder/repos","events_url":"https://api.github.com/users/dbachelder/events{/privacy}","received_events_url":"https://api.github.com/users/dbachelder/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":7,"deletions":7,"changed_files":4}}