{"action":"created","comment":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/46433839","id":46433839,"diff_hunk":"@@ -212,6 +227,8 @@ def manually_collect_submission(grouping, rev_num, async=true)\n     grouping.save\n \n     new_submission = Submission.create_by_revision_number(grouping, rev_num)\n+    new_submission = apply_penalty_or_add_grace_credits(grouping, \n+      apply_late_penalty, new_submission)","path":"app/models/submission_collector.rb","position":39,"original_position":39,"commit_id":"313d138c07543b6a2e21b322dbafcc894d4b6397","original_commit_id":"313d138c07543b6a2e21b322dbafcc894d4b6397","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Align the parameters of a method call if they span more than one line.","created_at":"2015-12-02T16:08:49Z","updated_at":"2015-12-02T16:08:49Z","html_url":"https://github.com/MarkUsProject/Markus/pull/2282#discussion_r46433839","pull_request_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2282","_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/46433839"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/2282#discussion_r46433839"},"pull_request":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2282"}}},"pull_request":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2282","id":45500711,"html_url":"https://github.com/MarkUsProject/Markus/pull/2282","diff_url":"https://github.com/MarkUsProject/Markus/pull/2282.diff","patch_url":"https://github.com/MarkUsProject/Markus/pull/2282.patch","issue_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/2282","number":2282,"state":"open","locked":false,"title":"add apply on late penalty option on manual collection","user":{"login":"wkwan","id":2907892,"avatar_url":"https://avatars.githubusercontent.com/u/2907892?v=3","gravatar_id":"","url":"https://api.github.com/users/wkwan","html_url":"https://github.com/wkwan","followers_url":"https://api.github.com/users/wkwan/followers","following_url":"https://api.github.com/users/wkwan/following{/other_user}","gists_url":"https://api.github.com/users/wkwan/gists{/gist_id}","starred_url":"https://api.github.com/users/wkwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkwan/subscriptions","organizations_url":"https://api.github.com/users/wkwan/orgs","repos_url":"https://api.github.com/users/wkwan/repos","events_url":"https://api.github.com/users/wkwan/events{/privacy}","received_events_url":"https://api.github.com/users/wkwan/received_events","type":"User","site_admin":false},"body":"This is related to issue 2136 as it involves the late penalty originally not being applied on manual collection, but I haven't yet reproduced the bug where the late penalty was not applied because of a remark request without manual collection.","created_at":"2015-09-20T17:52:25Z","updated_at":"2015-12-02T16:08:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"793f6f9d83412d4ba4734f0308898f1764c107bb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2282/commits","review_comments_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2282/comments","review_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/2282/comments","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/313d138c07543b6a2e21b322dbafcc894d4b6397","head":{"label":"wkwan:issue-2136","ref":"issue-2136","sha":"313d138c07543b6a2e21b322dbafcc894d4b6397","user":{"login":"wkwan","id":2907892,"avatar_url":"https://avatars.githubusercontent.com/u/2907892?v=3","gravatar_id":"","url":"https://api.github.com/users/wkwan","html_url":"https://github.com/wkwan","followers_url":"https://api.github.com/users/wkwan/followers","following_url":"https://api.github.com/users/wkwan/following{/other_user}","gists_url":"https://api.github.com/users/wkwan/gists{/gist_id}","starred_url":"https://api.github.com/users/wkwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkwan/subscriptions","organizations_url":"https://api.github.com/users/wkwan/orgs","repos_url":"https://api.github.com/users/wkwan/repos","events_url":"https://api.github.com/users/wkwan/events{/privacy}","received_events_url":"https://api.github.com/users/wkwan/received_events","type":"User","site_admin":false},"repo":{"id":42268223,"name":"Markus","full_name":"wkwan/Markus","owner":{"login":"wkwan","id":2907892,"avatar_url":"https://avatars.githubusercontent.com/u/2907892?v=3","gravatar_id":"","url":"https://api.github.com/users/wkwan","html_url":"https://github.com/wkwan","followers_url":"https://api.github.com/users/wkwan/followers","following_url":"https://api.github.com/users/wkwan/following{/other_user}","gists_url":"https://api.github.com/users/wkwan/gists{/gist_id}","starred_url":"https://api.github.com/users/wkwan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkwan/subscriptions","organizations_url":"https://api.github.com/users/wkwan/orgs","repos_url":"https://api.github.com/users/wkwan/repos","events_url":"https://api.github.com/users/wkwan/events{/privacy}","received_events_url":"https://api.github.com/users/wkwan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wkwan/Markus","description":"Git repository of MarkUs","fork":true,"url":"https://api.github.com/repos/wkwan/Markus","forks_url":"https://api.github.com/repos/wkwan/Markus/forks","keys_url":"https://api.github.com/repos/wkwan/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wkwan/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wkwan/Markus/teams","hooks_url":"https://api.github.com/repos/wkwan/Markus/hooks","issue_events_url":"https://api.github.com/repos/wkwan/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/wkwan/Markus/events","assignees_url":"https://api.github.com/repos/wkwan/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/wkwan/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/wkwan/Markus/tags","blobs_url":"https://api.github.com/repos/wkwan/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wkwan/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wkwan/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/wkwan/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wkwan/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/wkwan/Markus/languages","stargazers_url":"https://api.github.com/repos/wkwan/Markus/stargazers","contributors_url":"https://api.github.com/repos/wkwan/Markus/contributors","subscribers_url":"https://api.github.com/repos/wkwan/Markus/subscribers","subscription_url":"https://api.github.com/repos/wkwan/Markus/subscription","commits_url":"https://api.github.com/repos/wkwan/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/wkwan/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/wkwan/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/wkwan/Markus/issues/comments{/number}","contents_url":"https://api.github.com/repos/wkwan/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/wkwan/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wkwan/Markus/merges","archive_url":"https://api.github.com/repos/wkwan/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wkwan/Markus/downloads","issues_url":"https://api.github.com/repos/wkwan/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/wkwan/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/wkwan/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/wkwan/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wkwan/Markus/labels{/name}","releases_url":"https://api.github.com/repos/wkwan/Markus/releases{/id}","created_at":"2015-09-10T20:12:01Z","updated_at":"2015-09-10T20:12:04Z","pushed_at":"2015-12-02T16:08:43Z","git_url":"git://github.com/wkwan/Markus.git","ssh_url":"git@github.com:wkwan/Markus.git","clone_url":"https://github.com/wkwan/Markus.git","svn_url":"https://github.com/wkwan/Markus","homepage":"http://www.markusproject.org","size":23585,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MarkUsProject:master","ref":"master","sha":"6c2456f1f765cca505baab58ddb97eb7824c33bf","user":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":940538,"name":"Markus","full_name":"MarkUsProject/Markus","owner":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarkUsProject/Markus","description":"Git repository of MarkUs","fork":false,"url":"https://api.github.com/repos/MarkUsProject/Markus","forks_url":"https://api.github.com/repos/MarkUsProject/Markus/forks","keys_url":"https://api.github.com/repos/MarkUsProject/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkUsProject/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkUsProject/Markus/teams","hooks_url":"https://api.github.com/repos/MarkUsProject/Markus/hooks","issue_events_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/MarkUsProject/Markus/events","assignees_url":"https://api.github.com/repos/MarkUsProject/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/MarkUsProject/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/MarkUsProject/Markus/tags","blobs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkUsProject/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkUsProject/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkUsProject/Markus/languages","stargazers_url":"https://api.github.com/repos/MarkUsProject/Markus/stargazers","contributors_url":"https://api.github.com/repos/MarkUsProject/Markus/contributors","subscribers_url":"https://api.github.com/repos/MarkUsProject/Markus/subscribers","subscription_url":"https://api.github.com/repos/MarkUsProject/Markus/subscription","commits_url":"https://api.github.com/repos/MarkUsProject/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkUsProject/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarkUsProject/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/MarkUsProject/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkUsProject/Markus/merges","archive_url":"https://api.github.com/repos/MarkUsProject/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkUsProject/Markus/downloads","issues_url":"https://api.github.com/repos/MarkUsProject/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkUsProject/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkUsProject/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkUsProject/Markus/labels{/name}","releases_url":"https://api.github.com/repos/MarkUsProject/Markus/releases{/id}","created_at":"2010-09-26T16:18:08Z","updated_at":"2015-11-29T21:43:17Z","pushed_at":"2015-12-02T16:08:43Z","git_url":"git://github.com/MarkUsProject/Markus.git","ssh_url":"git@github.com:MarkUsProject/Markus.git","clone_url":"https://github.com/MarkUsProject/Markus.git","svn_url":"https://github.com/MarkUsProject/Markus","homepage":"http://www.markusproject.org","size":32168,"stargazers_count":131,"watchers_count":131,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":163,"mirror_url":null,"open_issues_count":106,"forks":163,"open_issues":106,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2282"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/2282"},"issue":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/2282"},"comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/2282/comments"},"review_comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2282/comments"},"review_comment":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2282/commits"},"statuses":{"href":"https://api.github.com/repos/MarkUsProject/Markus/statuses/313d138c07543b6a2e21b322dbafcc894d4b6397"}}}}