{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/hdfs/pulls/comments/31191668","id":31191668,"diff_hunk":"@@ -1,5 +1,39 @@\n #!/bin/bash\n \n+FRAMEWORK_DIR=\"$( cd \"$( dirname \"${BASH_SOURCE[0]}\" )\" && pwd )/..\"\n+\n+export MESOS_HDFS_DATA_DIR=${MESOS_HDFS_DATA_DIR:-\"/tmp/hdfs/data\"}\n+export MESOS_HDFS_SECONDARY_DATA_DIR=${MESOS_HDFS_SECONDARY_DATA_DIR:-\"/var/run/hadoop-hdfs\"}\n+export MESOS_HDFS_NATIVE_HADOOP_BINARIES=${MESOS_HDFS_NATIVE_HADOOP_BINARIES:-false}\n+export MESOS_HDFS_FRAMEWORK_MNT_PATH=${MESOS_HDFS_FRAMEWORK_MNT_PATH:-\"/opt/mesosphere\"}\n+export MESOS_HDFS_STATE_ZK=${MESOS_HDFS_STATE_ZK:-\"localhost:2181\"}\n+export MESOS_MASTER_URI=${MESOS_MASTER_URI:-\"zk://localhost:2181/mesos\"}\n+export MESOS_HDFS_ZKFC_HA_ZOOKEEPER_QUORUM=${MESOS_HDFS_ZKFC_HA_ZOOKEEPER_QUORUM:-\"localhost:2181\"}\n+export MESOS_HDFS_FRAMEWORK_NAME=${MESOS_HDFS_FRAMEWORK_NAME:-\"hdfs\"}\n+export MESOS_HDFS_MESOSDNS=${MESOS_HDFS_MESOSDNS:-false}\n+export MESOS_HDFS_MESOSDNS_DOMAIN=${MESOS_HDFS_MESOSDNS_DOMAIN:-\"mesos\"}\n+export MESOS_NATIVE_LIBRARY=${MESOS_NATIVE_LIBRARY:-\"/usr/local/lib/libmesos.so\"}\n+export MESOS_HDFS_JOURNALNODE_COUNT=${MESOS_HDFS_JOURNALNODE_COUNT:-3}\n+export MESOS_HDFS_JVM_OVERHEAD=${MESOS_HDFS_JVM_OVERHEAD:-1.35}\n+export MESOS_HDFS_HADOOP_HEAP_SIZE=${MESOS_HDFS_HADOOP_HEAP_SIZE:-512}\n+export MESOS_HDFS_NAMENODE_HEAP_SIZE=${MESOS_HDFS_NAMENODE_HEAP_SIZE:-4096}\n+export MESOS_HDFS_DATANODE_HEAP_SIZE=${MESOS_HDFS_DATANODE_HEAP_SIZE:-1024}\n+export MESOS_HDFS_EXECUTOR_HEAP_SIZE=${MESOS_HDFS_EXECUTOR_HEAP_SIZE:-256}\n+export MESOS_HDFS_EXECUTOR_CPUS=${MESOS_HDFS_EXECUTOR_CPUS:-0.5}\n+export MESOS_HDFS_NAMENODE_CPUS=${MESOS_HDFS_NAMENODE_CPUS:-1}\n+export MESOS_HDFS_JOURNALNODE_CPUS=${MESOS_HDFS_JOURNALNODE_CPUS:-1}\n+export MESOS_HDFS_DATANODE_CPUS=${MESOS_HDFS_DATANODE_CPUS:-1}\n+export MESOS_HDFS_USER=${MESOS_HDFS_USER:-\"root\"}","path":"bin/hdfs-mesos","position":26,"original_position":26,"commit_id":"a94e48c24240982dcc429dd96e34c856dffd6ebd","original_commit_id":"a94e48c24240982dcc429dd96e34c856dffd6ebd","user":{"login":"adam-mesos","id":6456528,"avatar_url":"https://avatars.githubusercontent.com/u/6456528?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-mesos","html_url":"https://github.com/adam-mesos","followers_url":"https://api.github.com/users/adam-mesos/followers","following_url":"https://api.github.com/users/adam-mesos/following{/other_user}","gists_url":"https://api.github.com/users/adam-mesos/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-mesos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-mesos/subscriptions","organizations_url":"https://api.github.com/users/adam-mesos/orgs","repos_url":"https://api.github.com/users/adam-mesos/repos","events_url":"https://api.github.com/users/adam-mesos/events{/privacy}","received_events_url":"https://api.github.com/users/adam-mesos/received_events","type":"User","site_admin":false},"body":"Would it make sense to just default this to empty string (\"\") so it inherits whatever user launched the hdfs-mesos scheduler?","created_at":"2015-05-27T23:40:00Z","updated_at":"2015-05-27T23:40:00Z","html_url":"https://github.com/mesosphere/hdfs/pull/123#discussion_r31191668","pull_request_url":"https://api.github.com/repos/mesosphere/hdfs/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/comments/31191668"},"html":{"href":"https://github.com/mesosphere/hdfs/pull/123#discussion_r31191668"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/hdfs/pulls/123","id":33292306,"html_url":"https://github.com/mesosphere/hdfs/pull/123","diff_url":"https://github.com/mesosphere/hdfs/pull/123.diff","patch_url":"https://github.com/mesosphere/hdfs/pull/123.patch","issue_url":"https://api.github.com/repos/mesosphere/hdfs/issues/123","number":123,"state":"open","locked":false,"title":"Dockerfile for scheduler","user":{"login":"nicgrayson","id":793886,"avatar_url":"https://avatars.githubusercontent.com/u/793886?v=3","gravatar_id":"","url":"https://api.github.com/users/nicgrayson","html_url":"https://github.com/nicgrayson","followers_url":"https://api.github.com/users/nicgrayson/followers","following_url":"https://api.github.com/users/nicgrayson/following{/other_user}","gists_url":"https://api.github.com/users/nicgrayson/gists{/gist_id}","starred_url":"https://api.github.com/users/nicgrayson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicgrayson/subscriptions","organizations_url":"https://api.github.com/users/nicgrayson/orgs","repos_url":"https://api.github.com/users/nicgrayson/repos","events_url":"https://api.github.com/users/nicgrayson/events{/privacy}","received_events_url":"https://api.github.com/users/nicgrayson/received_events","type":"User","site_admin":false},"body":"1. Provides Dockerfile for building the scheduler docker image\r\n2. Hooks into existing build script\r\n3. Added usage to Readme\r\n\r\nLet me know if you have any questions.\u0010","created_at":"2015-04-14T19:40:51Z","updated_at":"2015-05-27T23:40:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1b4cf75ab44aed2d07929682c486eaa3fe64310","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/hdfs/pulls/123/commits","review_comments_url":"https://api.github.com/repos/mesosphere/hdfs/pulls/123/comments","review_comment_url":"https://api.github.com/repos/mesosphere/hdfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/hdfs/issues/123/comments","statuses_url":"https://api.github.com/repos/mesosphere/hdfs/statuses/a94e48c24240982dcc429dd96e34c856dffd6ebd","head":{"label":"Banno:docker-scheduler","ref":"docker-scheduler","sha":"a94e48c24240982dcc429dd96e34c856dffd6ebd","user":{"login":"Banno","id":371161,"avatar_url":"https://avatars.githubusercontent.com/u/371161?v=3","gravatar_id":"","url":"https://api.github.com/users/Banno","html_url":"https://github.com/Banno","followers_url":"https://api.github.com/users/Banno/followers","following_url":"https://api.github.com/users/Banno/following{/other_user}","gists_url":"https://api.github.com/users/Banno/gists{/gist_id}","starred_url":"https://api.github.com/users/Banno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Banno/subscriptions","organizations_url":"https://api.github.com/users/Banno/orgs","repos_url":"https://api.github.com/users/Banno/repos","events_url":"https://api.github.com/users/Banno/events{/privacy}","received_events_url":"https://api.github.com/users/Banno/received_events","type":"Organization","site_admin":false},"repo":{"id":29147330,"name":"hdfs","full_name":"Banno/hdfs","owner":{"login":"Banno","id":371161,"avatar_url":"https://avatars.githubusercontent.com/u/371161?v=3","gravatar_id":"","url":"https://api.github.com/users/Banno","html_url":"https://github.com/Banno","followers_url":"https://api.github.com/users/Banno/followers","following_url":"https://api.github.com/users/Banno/following{/other_user}","gists_url":"https://api.github.com/users/Banno/gists{/gist_id}","starred_url":"https://api.github.com/users/Banno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Banno/subscriptions","organizations_url":"https://api.github.com/users/Banno/orgs","repos_url":"https://api.github.com/users/Banno/repos","events_url":"https://api.github.com/users/Banno/events{/privacy}","received_events_url":"https://api.github.com/users/Banno/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Banno/hdfs","description":"HA HDFS on Apache Mesos  ~~~  aka 'Super Available' HDFS","fork":true,"url":"https://api.github.com/repos/Banno/hdfs","forks_url":"https://api.github.com/repos/Banno/hdfs/forks","keys_url":"https://api.github.com/repos/Banno/hdfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Banno/hdfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Banno/hdfs/teams","hooks_url":"https://api.github.com/repos/Banno/hdfs/hooks","issue_events_url":"https://api.github.com/repos/Banno/hdfs/issues/events{/number}","events_url":"https://api.github.com/repos/Banno/hdfs/events","assignees_url":"https://api.github.com/repos/Banno/hdfs/assignees{/user}","branches_url":"https://api.github.com/repos/Banno/hdfs/branches{/branch}","tags_url":"https://api.github.com/repos/Banno/hdfs/tags","blobs_url":"https://api.github.com/repos/Banno/hdfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Banno/hdfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Banno/hdfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Banno/hdfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Banno/hdfs/statuses/{sha}","languages_url":"https://api.github.com/repos/Banno/hdfs/languages","stargazers_url":"https://api.github.com/repos/Banno/hdfs/stargazers","contributors_url":"https://api.github.com/repos/Banno/hdfs/contributors","subscribers_url":"https://api.github.com/repos/Banno/hdfs/subscribers","subscription_url":"https://api.github.com/repos/Banno/hdfs/subscription","commits_url":"https://api.github.com/repos/Banno/hdfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Banno/hdfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Banno/hdfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Banno/hdfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Banno/hdfs/contents/{+path}","compare_url":"https://api.github.com/repos/Banno/hdfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Banno/hdfs/merges","archive_url":"https://api.github.com/repos/Banno/hdfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Banno/hdfs/downloads","issues_url":"https://api.github.com/repos/Banno/hdfs/issues{/number}","pulls_url":"https://api.github.com/repos/Banno/hdfs/pulls{/number}","milestones_url":"https://api.github.com/repos/Banno/hdfs/milestones{/number}","notifications_url":"https://api.github.com/repos/Banno/hdfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Banno/hdfs/labels{/name}","releases_url":"https://api.github.com/repos/Banno/hdfs/releases{/id}","created_at":"2015-01-12T17:26:37Z","updated_at":"2015-03-19T14:48:26Z","pushed_at":"2015-05-27T14:51:43Z","git_url":"git://github.com/Banno/hdfs.git","ssh_url":"git@github.com:Banno/hdfs.git","clone_url":"https://github.com/Banno/hdfs.git","svn_url":"https://github.com/Banno/hdfs","homepage":"","size":1017,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"f7df3e388bf5ff150e64a08eb315c041486e6b6d","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":25594400,"name":"hdfs","full_name":"mesosphere/hdfs","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/hdfs","description":"HA HDFS on Apache Mesos  ~~~  aka 'Super Available' HDFS","fork":true,"url":"https://api.github.com/repos/mesosphere/hdfs","forks_url":"https://api.github.com/repos/mesosphere/hdfs/forks","keys_url":"https://api.github.com/repos/mesosphere/hdfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/hdfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/hdfs/teams","hooks_url":"https://api.github.com/repos/mesosphere/hdfs/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/hdfs/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/hdfs/events","assignees_url":"https://api.github.com/repos/mesosphere/hdfs/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/hdfs/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/hdfs/tags","blobs_url":"https://api.github.com/repos/mesosphere/hdfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/hdfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/hdfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/hdfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/hdfs/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/hdfs/languages","stargazers_url":"https://api.github.com/repos/mesosphere/hdfs/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/hdfs/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/hdfs/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/hdfs/subscription","commits_url":"https://api.github.com/repos/mesosphere/hdfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/hdfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/hdfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/hdfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/hdfs/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/hdfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/hdfs/merges","archive_url":"https://api.github.com/repos/mesosphere/hdfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/hdfs/downloads","issues_url":"https://api.github.com/repos/mesosphere/hdfs/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/hdfs/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/hdfs/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/hdfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/hdfs/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/hdfs/releases{/id}","created_at":"2014-10-22T17:21:52Z","updated_at":"2015-05-16T17:41:25Z","pushed_at":"2015-05-27T14:51:44Z","git_url":"git://github.com/mesosphere/hdfs.git","ssh_url":"git@github.com:mesosphere/hdfs.git","clone_url":"https://github.com/mesosphere/hdfs.git","svn_url":"https://github.com/mesosphere/hdfs","homepage":"","size":3357,"stargazers_count":64,"watchers_count":64,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":36,"forks":11,"open_issues":36,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/123"},"html":{"href":"https://github.com/mesosphere/hdfs/pull/123"},"issue":{"href":"https://api.github.com/repos/mesosphere/hdfs/issues/123"},"comments":{"href":"https://api.github.com/repos/mesosphere/hdfs/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/hdfs/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/hdfs/statuses/a94e48c24240982dcc429dd96e34c856dffd6ebd"}}}}