{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/35710593","id":35710593,"diff_hunk":"@@ -865,6 +874,114 @@ impl LayoutTask {\n         rw_data.client_rect_response = iterator.client_rect;\n     }\n \n+    fn process_resolved_style_request<'a>(&'a self,\n+                                          requested_node: TrustedNodeAddress,\n+                                          property: &Atom,\n+                                          //pseudo: &PseudoElementType,\n+                                          layout_root: &mut FlowRef,\n+                                          rw_data: &mut RWGuard<'a>) {\n+        // FIXME: Isolate this transmutation into a \"bridge\" module.\n+        // FIXME(rust#16366): The following line had to be moved because of a\n+        // rustc bug. It should be in the next unsafe block.\n+        let node: LayoutJS<Node> = unsafe {\n+            LayoutJS::from_trusted_node_address(requested_node)\n+        };\n+        let node: &LayoutNode = unsafe {\n+            transmute(&node)\n+        };\n+\n+        let layout_node = ThreadSafeLayoutNode::new(node);\n+        /*let layout_node = match pseudo {\n+            PseudoElementType::Before => node.get_before_pseudo().unwrap(),\n+            PseudoElementType::After => node.get_after_pseudo().unwrap(),\n+            _ => layout_node\n+        };*/","path":"components/layout/layout_task.rs","position":86,"original_position":86,"commit_id":"7f45bf2b557048bf4325ff7ae560effa9d637a9a","original_commit_id":"5bd3677c88aa9993924d5667a5db8b2391964095","user":{"login":"dzbarsky","id":1565842,"avatar_url":"https://avatars.githubusercontent.com/u/1565842?v=3","gravatar_id":"","url":"https://api.github.com/users/dzbarsky","html_url":"https://github.com/dzbarsky","followers_url":"https://api.github.com/users/dzbarsky/followers","following_url":"https://api.github.com/users/dzbarsky/following{/other_user}","gists_url":"https://api.github.com/users/dzbarsky/gists{/gist_id}","starred_url":"https://api.github.com/users/dzbarsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzbarsky/subscriptions","organizations_url":"https://api.github.com/users/dzbarsky/orgs","repos_url":"https://api.github.com/users/dzbarsky/repos","events_url":"https://api.github.com/users/dzbarsky/events{/privacy}","received_events_url":"https://api.github.com/users/dzbarsky/received_events","type":"User","site_admin":false},"body":"Just fixed it instead.","created_at":"2015-07-28T22:44:34Z","updated_at":"2015-07-28T22:44:34Z","html_url":"https://github.com/servo/servo/pull/6798#discussion_r35710593","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/6798","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/35710593"},"html":{"href":"https://github.com/servo/servo/pull/6798#discussion_r35710593"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/6798"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/6798","id":40971587,"html_url":"https://github.com/servo/servo/pull/6798","diff_url":"https://github.com/servo/servo/pull/6798.diff","patch_url":"https://github.com/servo/servo/pull/6798.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/6798","number":6798,"state":"open","locked":false,"title":"Implement getComputedStyle","user":{"login":"dzbarsky","id":1565842,"avatar_url":"https://avatars.githubusercontent.com/u/1565842?v=3","gravatar_id":"","url":"https://api.github.com/users/dzbarsky","html_url":"https://github.com/dzbarsky","followers_url":"https://api.github.com/users/dzbarsky/followers","following_url":"https://api.github.com/users/dzbarsky/following{/other_user}","gists_url":"https://api.github.com/users/dzbarsky/gists{/gist_id}","starred_url":"https://api.github.com/users/dzbarsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzbarsky/subscriptions","organizations_url":"https://api.github.com/users/dzbarsky/orgs","repos_url":"https://api.github.com/users/dzbarsky/repos","events_url":"https://api.github.com/users/dzbarsky/events{/privacy}","received_events_url":"https://api.github.com/users/dzbarsky/received_events","type":"User","site_admin":false},"body":"It's not quite done but can probably be reviewed anyway.\r\nI still need to finish up a few of the ToCss impls, I just got lazy and wanted to make sure things worked.\r\n\r\nThe computation of the used values is definitely not right, I'm going to investigate that.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/6798)\n<!-- Reviewable:end -->\n","created_at":"2015-07-28T03:10:14Z","updated_at":"2015-07-28T22:44:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad2bdf3d6d338da361c26cfbf81b3355caaee4c6","assignee":{"login":"pcwalton","id":157897,"avatar_url":"https://avatars.githubusercontent.com/u/157897?v=3","gravatar_id":"","url":"https://api.github.com/users/pcwalton","html_url":"https://github.com/pcwalton","followers_url":"https://api.github.com/users/pcwalton/followers","following_url":"https://api.github.com/users/pcwalton/following{/other_user}","gists_url":"https://api.github.com/users/pcwalton/gists{/gist_id}","starred_url":"https://api.github.com/users/pcwalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcwalton/subscriptions","organizations_url":"https://api.github.com/users/pcwalton/orgs","repos_url":"https://api.github.com/users/pcwalton/repos","events_url":"https://api.github.com/users/pcwalton/events{/privacy}","received_events_url":"https://api.github.com/users/pcwalton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/6798/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/6798/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/6798/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/7f45bf2b557048bf4325ff7ae560effa9d637a9a","head":{"label":"dzbarsky:gCS","ref":"gCS","sha":"7f45bf2b557048bf4325ff7ae560effa9d637a9a","user":{"login":"dzbarsky","id":1565842,"avatar_url":"https://avatars.githubusercontent.com/u/1565842?v=3","gravatar_id":"","url":"https://api.github.com/users/dzbarsky","html_url":"https://github.com/dzbarsky","followers_url":"https://api.github.com/users/dzbarsky/followers","following_url":"https://api.github.com/users/dzbarsky/following{/other_user}","gists_url":"https://api.github.com/users/dzbarsky/gists{/gist_id}","starred_url":"https://api.github.com/users/dzbarsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzbarsky/subscriptions","organizations_url":"https://api.github.com/users/dzbarsky/orgs","repos_url":"https://api.github.com/users/dzbarsky/repos","events_url":"https://api.github.com/users/dzbarsky/events{/privacy}","received_events_url":"https://api.github.com/users/dzbarsky/received_events","type":"User","site_admin":false},"repo":{"id":38519530,"name":"servo","full_name":"dzbarsky/servo","owner":{"login":"dzbarsky","id":1565842,"avatar_url":"https://avatars.githubusercontent.com/u/1565842?v=3","gravatar_id":"","url":"https://api.github.com/users/dzbarsky","html_url":"https://github.com/dzbarsky","followers_url":"https://api.github.com/users/dzbarsky/followers","following_url":"https://api.github.com/users/dzbarsky/following{/other_user}","gists_url":"https://api.github.com/users/dzbarsky/gists{/gist_id}","starred_url":"https://api.github.com/users/dzbarsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzbarsky/subscriptions","organizations_url":"https://api.github.com/users/dzbarsky/orgs","repos_url":"https://api.github.com/users/dzbarsky/repos","events_url":"https://api.github.com/users/dzbarsky/events{/privacy}","received_events_url":"https://api.github.com/users/dzbarsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dzbarsky/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/dzbarsky/servo","forks_url":"https://api.github.com/repos/dzbarsky/servo/forks","keys_url":"https://api.github.com/repos/dzbarsky/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dzbarsky/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dzbarsky/servo/teams","hooks_url":"https://api.github.com/repos/dzbarsky/servo/hooks","issue_events_url":"https://api.github.com/repos/dzbarsky/servo/issues/events{/number}","events_url":"https://api.github.com/repos/dzbarsky/servo/events","assignees_url":"https://api.github.com/repos/dzbarsky/servo/assignees{/user}","branches_url":"https://api.github.com/repos/dzbarsky/servo/branches{/branch}","tags_url":"https://api.github.com/repos/dzbarsky/servo/tags","blobs_url":"https://api.github.com/repos/dzbarsky/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dzbarsky/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dzbarsky/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/dzbarsky/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dzbarsky/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/dzbarsky/servo/languages","stargazers_url":"https://api.github.com/repos/dzbarsky/servo/stargazers","contributors_url":"https://api.github.com/repos/dzbarsky/servo/contributors","subscribers_url":"https://api.github.com/repos/dzbarsky/servo/subscribers","subscription_url":"https://api.github.com/repos/dzbarsky/servo/subscription","commits_url":"https://api.github.com/repos/dzbarsky/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/dzbarsky/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/dzbarsky/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/dzbarsky/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/dzbarsky/servo/contents/{+path}","compare_url":"https://api.github.com/repos/dzbarsky/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dzbarsky/servo/merges","archive_url":"https://api.github.com/repos/dzbarsky/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dzbarsky/servo/downloads","issues_url":"https://api.github.com/repos/dzbarsky/servo/issues{/number}","pulls_url":"https://api.github.com/repos/dzbarsky/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/dzbarsky/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/dzbarsky/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dzbarsky/servo/labels{/name}","releases_url":"https://api.github.com/repos/dzbarsky/servo/releases{/id}","created_at":"2015-07-04T03:03:35Z","updated_at":"2015-07-04T03:03:43Z","pushed_at":"2015-07-28T22:36:46Z","git_url":"git://github.com/dzbarsky/servo.git","ssh_url":"git@github.com:dzbarsky/servo.git","clone_url":"https://github.com/dzbarsky/servo.git","svn_url":"https://github.com/dzbarsky/servo","homepage":"","size":113967,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"14ccb22e679722ed3374c8facec21adcf0f2b247","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","created_at":"2012-02-08T19:07:25Z","updated_at":"2015-07-28T20:23:29Z","pushed_at":"2015-07-28T22:00:06Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"","size":1900674,"stargazers_count":4519,"watchers_count":4519,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":708,"mirror_url":null,"open_issues_count":1008,"forks":708,"open_issues":1008,"watchers":4519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/6798"},"html":{"href":"https://github.com/servo/servo/pull/6798"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/6798"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/6798/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/6798/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/6798/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/7f45bf2b557048bf4325ff7ae560effa9d637a9a"}}}}