{"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid/pulls/comments/29865281","id":29865281,"diff_hunk":"@@ -0,0 +1,82 @@\n+2011-04-10T00:00:00.000Z\tspot\tautomotive\tpreferred\ta\u0001preferred\t113.221448","path":"indexing-hadoop/src/test/resources/druid.test.data.tsv","position":1,"original_position":1,"commit_id":"1294ae12a5b703d2e03fc069d7a921992d5e4eee","original_commit_id":"1294ae12a5b703d2e03fc069d7a921992d5e4eee","user":{"login":"pjain1","id":11787983,"avatar_url":"https://avatars.githubusercontent.com/u/11787983?v=3","gravatar_id":"","url":"https://api.github.com/users/pjain1","html_url":"https://github.com/pjain1","followers_url":"https://api.github.com/users/pjain1/followers","following_url":"https://api.github.com/users/pjain1/following{/other_user}","gists_url":"https://api.github.com/users/pjain1/gists{/gist_id}","starred_url":"https://api.github.com/users/pjain1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjain1/subscriptions","organizations_url":"https://api.github.com/users/pjain1/orgs","repos_url":"https://api.github.com/users/pjain1/repos","events_url":"https://api.github.com/users/pjain1/events{/privacy}","received_events_url":"https://api.github.com/users/pjain1/received_events","type":"User","site_admin":false},"body":"First I tested with the existing druid.sample.tsv file but then I thought the sample data should have some duplicate rows for a shard so that HyperLogLog unique count feature can be tested. If the files are kept separate, more interesting tests can be added in future. However, I am fine with any approach.","created_at":"2015-05-07T15:48:35Z","updated_at":"2015-05-07T15:48:35Z","html_url":"https://github.com/druid-io/druid/pull/1345#discussion_r29865281","pull_request_url":"https://api.github.com/repos/druid-io/druid/pulls/1345","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/29865281"},"html":{"href":"https://github.com/druid-io/druid/pull/1345#discussion_r29865281"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid/pulls/1345"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/1345","id":34857254,"html_url":"https://github.com/druid-io/druid/pull/1345","diff_url":"https://github.com/druid-io/druid/pull/1345.diff","patch_url":"https://github.com/druid-io/druid/pull/1345.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/1345","number":1345,"state":"open","locked":false,"title":"fix warn msg and some unit tests","user":{"login":"pjain1","id":11787983,"avatar_url":"https://avatars.githubusercontent.com/u/11787983?v=3","gravatar_id":"","url":"https://api.github.com/users/pjain1","html_url":"https://github.com/pjain1","followers_url":"https://api.github.com/users/pjain1/followers","following_url":"https://api.github.com/users/pjain1/following{/other_user}","gists_url":"https://api.github.com/users/pjain1/gists{/gist_id}","starred_url":"https://api.github.com/users/pjain1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjain1/subscriptions","organizations_url":"https://api.github.com/users/pjain1/orgs","repos_url":"https://api.github.com/users/pjain1/repos","events_url":"https://api.github.com/users/pjain1/events{/privacy}","received_events_url":"https://api.github.com/users/pjain1/received_events","type":"User","site_admin":false},"body":"- Corrected the warn message in RealtimePlumber class\r\n- Added unit test for DetermineHashedPartitionsJob class. Sample data is mostly similar to druid.sample.tsv apart from the fact that it is smaller in size and there are duplicate events for a Time Bucket to test HyperLogLog unique count feature.\r\n- Added unit test for LocalDataSegmentPusher\r\n- Added unit test for DatasourcesResource","created_at":"2015-05-06T20:35:59Z","updated_at":"2015-05-07T15:48:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e96459facfdc5cdf229691e6d3d21813d88e8e1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/1345/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/1345/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/1345/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/1294ae12a5b703d2e03fc069d7a921992d5e4eee","head":{"label":"pjain1:unit_test_warn_fix","ref":"unit_test_warn_fix","sha":"1294ae12a5b703d2e03fc069d7a921992d5e4eee","user":{"login":"pjain1","id":11787983,"avatar_url":"https://avatars.githubusercontent.com/u/11787983?v=3","gravatar_id":"","url":"https://api.github.com/users/pjain1","html_url":"https://github.com/pjain1","followers_url":"https://api.github.com/users/pjain1/followers","following_url":"https://api.github.com/users/pjain1/following{/other_user}","gists_url":"https://api.github.com/users/pjain1/gists{/gist_id}","starred_url":"https://api.github.com/users/pjain1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjain1/subscriptions","organizations_url":"https://api.github.com/users/pjain1/orgs","repos_url":"https://api.github.com/users/pjain1/repos","events_url":"https://api.github.com/users/pjain1/events{/privacy}","received_events_url":"https://api.github.com/users/pjain1/received_events","type":"User","site_admin":false},"repo":{"id":33489992,"name":"druid","full_name":"pjain1/druid","owner":{"login":"pjain1","id":11787983,"avatar_url":"https://avatars.githubusercontent.com/u/11787983?v=3","gravatar_id":"","url":"https://api.github.com/users/pjain1","html_url":"https://github.com/pjain1","followers_url":"https://api.github.com/users/pjain1/followers","following_url":"https://api.github.com/users/pjain1/following{/other_user}","gists_url":"https://api.github.com/users/pjain1/gists{/gist_id}","starred_url":"https://api.github.com/users/pjain1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjain1/subscriptions","organizations_url":"https://api.github.com/users/pjain1/orgs","repos_url":"https://api.github.com/users/pjain1/repos","events_url":"https://api.github.com/users/pjain1/events{/privacy}","received_events_url":"https://api.github.com/users/pjain1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pjain1/druid","description":"Real²time Exploratory Analytics on Large Datasets","fork":true,"url":"https://api.github.com/repos/pjain1/druid","forks_url":"https://api.github.com/repos/pjain1/druid/forks","keys_url":"https://api.github.com/repos/pjain1/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pjain1/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pjain1/druid/teams","hooks_url":"https://api.github.com/repos/pjain1/druid/hooks","issue_events_url":"https://api.github.com/repos/pjain1/druid/issues/events{/number}","events_url":"https://api.github.com/repos/pjain1/druid/events","assignees_url":"https://api.github.com/repos/pjain1/druid/assignees{/user}","branches_url":"https://api.github.com/repos/pjain1/druid/branches{/branch}","tags_url":"https://api.github.com/repos/pjain1/druid/tags","blobs_url":"https://api.github.com/repos/pjain1/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pjain1/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pjain1/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/pjain1/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pjain1/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/pjain1/druid/languages","stargazers_url":"https://api.github.com/repos/pjain1/druid/stargazers","contributors_url":"https://api.github.com/repos/pjain1/druid/contributors","subscribers_url":"https://api.github.com/repos/pjain1/druid/subscribers","subscription_url":"https://api.github.com/repos/pjain1/druid/subscription","commits_url":"https://api.github.com/repos/pjain1/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/pjain1/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/pjain1/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/pjain1/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/pjain1/druid/contents/{+path}","compare_url":"https://api.github.com/repos/pjain1/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pjain1/druid/merges","archive_url":"https://api.github.com/repos/pjain1/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pjain1/druid/downloads","issues_url":"https://api.github.com/repos/pjain1/druid/issues{/number}","pulls_url":"https://api.github.com/repos/pjain1/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/pjain1/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/pjain1/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pjain1/druid/labels{/name}","releases_url":"https://api.github.com/repos/pjain1/druid/releases{/id}","created_at":"2015-04-06T15:44:13Z","updated_at":"2015-05-06T21:31:13Z","pushed_at":"2015-05-06T20:31:28Z","git_url":"git://github.com/pjain1/druid.git","ssh_url":"git@github.com:pjain1/druid.git","clone_url":"https://github.com/pjain1/druid.git","svn_url":"https://github.com/pjain1/druid","homepage":"http://druid.io","size":92748,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"7b649f699333341d483e61c26c1546f8e07c4b66","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Real²time Exploratory Analytics on Large Datasets","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","created_at":"2012-10-23T19:08:07Z","updated_at":"2015-05-07T12:48:34Z","pushed_at":"2015-05-07T15:44:51Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"git@github.com:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":172941,"stargazers_count":1693,"watchers_count":1693,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":362,"mirror_url":null,"open_issues_count":136,"forks":362,"open_issues":136,"watchers":1693,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/1345"},"html":{"href":"https://github.com/druid-io/druid/pull/1345"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/1345"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/1345/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/1345/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/1345/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/1294ae12a5b703d2e03fc069d7a921992d5e4eee"}}}}