{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments/43622489","id":43622489,"diff_hunk":"@@ -88,14 +94,12 @@ static const std::string AGENT_CLIENT_TYPE { \"agent\" };\n // Public interface\n //\n \n-void Configuration::reset() {\n+void Configuration::initialize(\n+        std::function<int(std::vector<std::string>)> start_function) {\n+    // Ensure the state is reset (useful for testing)\n     HW::Reset();\n-    setDefaultValues();\n-    initialized_ = false;\n-}\n+    valid_ = false;","path":"lib/src/configuration.cc","position":32,"original_position":32,"commit_id":"a51a7e093f8e364319da5bcc722d2e0828941164","original_commit_id":"a51a7e093f8e364319da5bcc722d2e0828941164","user":{"login":"parisiale","id":7150922,"avatar_url":"https://avatars.githubusercontent.com/u/7150922?v=3","gravatar_id":"","url":"https://api.github.com/users/parisiale","html_url":"https://github.com/parisiale","followers_url":"https://api.github.com/users/parisiale/followers","following_url":"https://api.github.com/users/parisiale/following{/other_user}","gists_url":"https://api.github.com/users/parisiale/gists{/gist_id}","starred_url":"https://api.github.com/users/parisiale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parisiale/subscriptions","organizations_url":"https://api.github.com/users/parisiale/orgs","repos_url":"https://api.github.com/users/parisiale/repos","events_url":"https://api.github.com/users/parisiale/events{/privacy}","received_events_url":"https://api.github.com/users/parisiale/received_events","type":"User","site_admin":false},"body":"We want to make sure this state var is reset that for the unit tests.","created_at":"2015-11-02T12:17:39Z","updated_at":"2015-11-02T12:17:39Z","html_url":"https://github.com/puppetlabs/pxp-agent/pull/210#discussion_r43622489","pull_request_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/210","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments/43622489"},"html":{"href":"https://github.com/puppetlabs/pxp-agent/pull/210#discussion_r43622489"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/210"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/210","id":49424451,"html_url":"https://github.com/puppetlabs/pxp-agent/pull/210","diff_url":"https://github.com/puppetlabs/pxp-agent/pull/210.diff","patch_url":"https://github.com/puppetlabs/pxp-agent/pull/210.patch","issue_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/210","number":210,"state":"open","locked":false,"title":"(PCP-125) Configuration refactor; \"unconfigured\" after TLS init failure","user":{"login":"parisiale","id":7150922,"avatar_url":"https://avatars.githubusercontent.com/u/7150922?v=3","gravatar_id":"","url":"https://api.github.com/users/parisiale","html_url":"https://github.com/parisiale","followers_url":"https://api.github.com/users/parisiale/followers","following_url":"https://api.github.com/users/parisiale/following{/other_user}","gists_url":"https://api.github.com/users/parisiale/gists{/gist_id}","starred_url":"https://api.github.com/users/parisiale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parisiale/subscriptions","organizations_url":"https://api.github.com/users/parisiale/orgs","repos_url":"https://api.github.com/users/parisiale/repos","events_url":"https://api.github.com/users/parisiale/events{/privacy}","received_events_url":"https://api.github.com/users/parisiale/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-02T12:09:55Z","updated_at":"2015-11-02T12:17:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86f403ac04b502bf01960d2b957e317fb8acfaea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/210/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/210/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/210/comments","statuses_url":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/a51a7e093f8e364319da5bcc722d2e0828941164","head":{"label":"parisiale:PCP-125","ref":"PCP-125","sha":"a51a7e093f8e364319da5bcc722d2e0828941164","user":{"login":"parisiale","id":7150922,"avatar_url":"https://avatars.githubusercontent.com/u/7150922?v=3","gravatar_id":"","url":"https://api.github.com/users/parisiale","html_url":"https://github.com/parisiale","followers_url":"https://api.github.com/users/parisiale/followers","following_url":"https://api.github.com/users/parisiale/following{/other_user}","gists_url":"https://api.github.com/users/parisiale/gists{/gist_id}","starred_url":"https://api.github.com/users/parisiale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parisiale/subscriptions","organizations_url":"https://api.github.com/users/parisiale/orgs","repos_url":"https://api.github.com/users/parisiale/repos","events_url":"https://api.github.com/users/parisiale/events{/privacy}","received_events_url":"https://api.github.com/users/parisiale/received_events","type":"User","site_admin":false},"repo":{"id":43742732,"name":"pxp-agent","full_name":"parisiale/pxp-agent","owner":{"login":"parisiale","id":7150922,"avatar_url":"https://avatars.githubusercontent.com/u/7150922?v=3","gravatar_id":"","url":"https://api.github.com/users/parisiale","html_url":"https://github.com/parisiale","followers_url":"https://api.github.com/users/parisiale/followers","following_url":"https://api.github.com/users/parisiale/following{/other_user}","gists_url":"https://api.github.com/users/parisiale/gists{/gist_id}","starred_url":"https://api.github.com/users/parisiale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parisiale/subscriptions","organizations_url":"https://api.github.com/users/parisiale/orgs","repos_url":"https://api.github.com/users/parisiale/repos","events_url":"https://api.github.com/users/parisiale/events{/privacy}","received_events_url":"https://api.github.com/users/parisiale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/parisiale/pxp-agent","description":"Puppet eXecution Protocol Agent","fork":true,"url":"https://api.github.com/repos/parisiale/pxp-agent","forks_url":"https://api.github.com/repos/parisiale/pxp-agent/forks","keys_url":"https://api.github.com/repos/parisiale/pxp-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parisiale/pxp-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parisiale/pxp-agent/teams","hooks_url":"https://api.github.com/repos/parisiale/pxp-agent/hooks","issue_events_url":"https://api.github.com/repos/parisiale/pxp-agent/issues/events{/number}","events_url":"https://api.github.com/repos/parisiale/pxp-agent/events","assignees_url":"https://api.github.com/repos/parisiale/pxp-agent/assignees{/user}","branches_url":"https://api.github.com/repos/parisiale/pxp-agent/branches{/branch}","tags_url":"https://api.github.com/repos/parisiale/pxp-agent/tags","blobs_url":"https://api.github.com/repos/parisiale/pxp-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parisiale/pxp-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parisiale/pxp-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/parisiale/pxp-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parisiale/pxp-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/parisiale/pxp-agent/languages","stargazers_url":"https://api.github.com/repos/parisiale/pxp-agent/stargazers","contributors_url":"https://api.github.com/repos/parisiale/pxp-agent/contributors","subscribers_url":"https://api.github.com/repos/parisiale/pxp-agent/subscribers","subscription_url":"https://api.github.com/repos/parisiale/pxp-agent/subscription","commits_url":"https://api.github.com/repos/parisiale/pxp-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/parisiale/pxp-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/parisiale/pxp-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/parisiale/pxp-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/parisiale/pxp-agent/contents/{+path}","compare_url":"https://api.github.com/repos/parisiale/pxp-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parisiale/pxp-agent/merges","archive_url":"https://api.github.com/repos/parisiale/pxp-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parisiale/pxp-agent/downloads","issues_url":"https://api.github.com/repos/parisiale/pxp-agent/issues{/number}","pulls_url":"https://api.github.com/repos/parisiale/pxp-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/parisiale/pxp-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/parisiale/pxp-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parisiale/pxp-agent/labels{/name}","releases_url":"https://api.github.com/repos/parisiale/pxp-agent/releases{/id}","created_at":"2015-10-06T09:59:49Z","updated_at":"2015-10-06T09:59:50Z","pushed_at":"2015-11-02T12:08:56Z","git_url":"git://github.com/parisiale/pxp-agent.git","ssh_url":"git@github.com:parisiale/pxp-agent.git","clone_url":"https://github.com/parisiale/pxp-agent.git","svn_url":"https://github.com/parisiale/pxp-agent","homepage":"","size":8719,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"bbb274000c14d7eb784d40a6aad93e8da6c6086c","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":23231786,"name":"pxp-agent","full_name":"puppetlabs/pxp-agent","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/pxp-agent","description":"PCP eXecution Protocol Agent","fork":false,"url":"https://api.github.com/repos/puppetlabs/pxp-agent","forks_url":"https://api.github.com/repos/puppetlabs/pxp-agent/forks","keys_url":"https://api.github.com/repos/puppetlabs/pxp-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/pxp-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/pxp-agent/teams","hooks_url":"https://api.github.com/repos/puppetlabs/pxp-agent/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/pxp-agent/events","assignees_url":"https://api.github.com/repos/puppetlabs/pxp-agent/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/pxp-agent/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/pxp-agent/tags","blobs_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/pxp-agent/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/pxp-agent/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/pxp-agent/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/pxp-agent/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/pxp-agent/subscription","commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/pxp-agent/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/pxp-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/pxp-agent/merges","archive_url":"https://api.github.com/repos/puppetlabs/pxp-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/pxp-agent/downloads","issues_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/pxp-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/pxp-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/pxp-agent/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/pxp-agent/releases{/id}","created_at":"2014-08-22T16:25:01Z","updated_at":"2015-10-19T23:27:50Z","pushed_at":"2015-11-02T12:09:55Z","git_url":"git://github.com/puppetlabs/pxp-agent.git","ssh_url":"git@github.com:puppetlabs/pxp-agent.git","clone_url":"https://github.com/puppetlabs/pxp-agent.git","svn_url":"https://github.com/puppetlabs/pxp-agent","homepage":"","size":10506,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":2,"forks":11,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/210"},"html":{"href":"https://github.com/puppetlabs/pxp-agent/pull/210"},"issue":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/210"},"comments":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/a51a7e093f8e364319da5bcc722d2e0828941164"}}}}