{"action":"created","issue":{"url":"https://api.github.com/repos/nutanix/passport-wso2/issues/2","labels_url":"https://api.github.com/repos/nutanix/passport-wso2/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/nutanix/passport-wso2/issues/2/comments","events_url":"https://api.github.com/repos/nutanix/passport-wso2/issues/2/events","html_url":"https://github.com/nutanix/passport-wso2/pull/2","id":108218348,"number":2,"title":"Fix state being persisted in wso2 by returning a copy of authorizationParams","user":{"login":"ShajiThiyarathodi","id":6589552,"avatar_url":"https://avatars.githubusercontent.com/u/6589552?v=3","gravatar_id":"","url":"https://api.github.com/users/ShajiThiyarathodi","html_url":"https://github.com/ShajiThiyarathodi","followers_url":"https://api.github.com/users/ShajiThiyarathodi/followers","following_url":"https://api.github.com/users/ShajiThiyarathodi/following{/other_user}","gists_url":"https://api.github.com/users/ShajiThiyarathodi/gists{/gist_id}","starred_url":"https://api.github.com/users/ShajiThiyarathodi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShajiThiyarathodi/subscriptions","organizations_url":"https://api.github.com/users/ShajiThiyarathodi/orgs","repos_url":"https://api.github.com/users/ShajiThiyarathodi/repos","events_url":"https://api.github.com/users/ShajiThiyarathodi/events{/privacy}","received_events_url":"https://api.github.com/users/ShajiThiyarathodi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nutanix/passport-wso2/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"Harishgolla","id":7939684,"avatar_url":"https://avatars.githubusercontent.com/u/7939684?v=3","gravatar_id":"","url":"https://api.github.com/users/Harishgolla","html_url":"https://github.com/Harishgolla","followers_url":"https://api.github.com/users/Harishgolla/followers","following_url":"https://api.github.com/users/Harishgolla/following{/other_user}","gists_url":"https://api.github.com/users/Harishgolla/gists{/gist_id}","starred_url":"https://api.github.com/users/Harishgolla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harishgolla/subscriptions","organizations_url":"https://api.github.com/users/Harishgolla/orgs","repos_url":"https://api.github.com/users/Harishgolla/repos","events_url":"https://api.github.com/users/Harishgolla/events{/privacy}","received_events_url":"https://api.github.com/users/Harishgolla/received_events","type":"User","site_admin":false},"milestone":null,"comments":11,"created_at":"2015-09-24T21:32:05Z","updated_at":"2015-09-25T22:55:12Z","closed_at":"2015-09-25T06:17:37Z","pull_request":{"url":"https://api.github.com/repos/nutanix/passport-wso2/pulls/2","html_url":"https://github.com/nutanix/passport-wso2/pull/2","diff_url":"https://github.com/nutanix/passport-wso2/pull/2.diff","patch_url":"https://github.com/nutanix/passport-wso2/pull/2.patch"},"body":"This commit addresses the redirect issue on portal access through gatekeeper. The user was getting redirected to urls based on state parameter set in wso2 strategy object. The state parameter was getting set by previous requests to portal and login redirects associated with it. The fix is to return a copy of startegy object's properties instead of returning reference, so that requests do not update the strategy object directly."},"comment":{"url":"https://api.github.com/repos/nutanix/passport-wso2/issues/comments/143371312","html_url":"https://github.com/nutanix/passport-wso2/pull/2#issuecomment-143371312","issue_url":"https://api.github.com/repos/nutanix/passport-wso2/issues/2","id":143371312,"user":{"login":"Samrudhi","id":4511845,"avatar_url":"https://avatars.githubusercontent.com/u/4511845?v=3","gravatar_id":"","url":"https://api.github.com/users/Samrudhi","html_url":"https://github.com/Samrudhi","followers_url":"https://api.github.com/users/Samrudhi/followers","following_url":"https://api.github.com/users/Samrudhi/following{/other_user}","gists_url":"https://api.github.com/users/Samrudhi/gists{/gist_id}","starred_url":"https://api.github.com/users/Samrudhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samrudhi/subscriptions","organizations_url":"https://api.github.com/users/Samrudhi/orgs","repos_url":"https://api.github.com/users/Samrudhi/repos","events_url":"https://api.github.com/users/Samrudhi/events{/privacy}","received_events_url":"https://api.github.com/users/Samrudhi/received_events","type":"User","site_admin":false},"created_at":"2015-09-25T22:55:12Z","updated_at":"2015-09-25T22:55:12Z","body":"@Harishgolla I am not very clear on \"No, while rebuilding shrinkwrap all the major versions will get updated. You can try and check.This needs one more round of e2e testing.\"\r\n\r\nIf you follow the steps below are only the required dependency will be updated and not all:\r\n1. git pull on master\r\n2. remove all the existing node modules\r\n3. run `npm install` [This will build the node modules from the npm-shrinkwrap.json file present in master. So NO major versions will get updated.]\r\n4. Now remove the npm-shrinkwrap.json file\r\n5. npm install <module-name> --save [This will get the latest module. You can remove the module from package.json before this install, in case it is a git url that we are pointing to in package.json]\r\n6. Build the new shrinkwrap file `npm shrinkwrap --dev`\r\n\r\nSo in this process only the module we want is upgraded in shrinkwrap.json and package.json. It will not update all the major version.\r\n\r\nIf we delete the npm-shrinkwrap.json file before doing a `npm install` then technically we are getting all new version every time and not honoring the locked down version at all. Does this make sense?\r\n\r\nLet us know your thoughts no this.\r\nThanks!"}}