{"action":"created","issue":{"url":"https://api.github.com/repos/sagemath/sagenb/issues/120","labels_url":"https://api.github.com/repos/sagemath/sagenb/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/sagemath/sagenb/issues/120/comments","events_url":"https://api.github.com/repos/sagemath/sagenb/issues/120/events","html_url":"https://github.com/sagemath/sagenb/pull/120","id":8980821,"number":120,"title":"Send e-mail notifications to configured address(es)","user":{"login":"rmartinjak","id":1429028,"avatar_url":"https://avatars.githubusercontent.com/u/1429028?v=3","gravatar_id":"","url":"https://api.github.com/users/rmartinjak","html_url":"https://github.com/rmartinjak","followers_url":"https://api.github.com/users/rmartinjak/followers","following_url":"https://api.github.com/users/rmartinjak/following{/other_user}","gists_url":"https://api.github.com/users/rmartinjak/gists{/gist_id}","starred_url":"https://api.github.com/users/rmartinjak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmartinjak/subscriptions","organizations_url":"https://api.github.com/users/rmartinjak/orgs","repos_url":"https://api.github.com/users/rmartinjak/repos","events_url":"https://api.github.com/users/rmartinjak/events{/privacy}","received_events_url":"https://api.github.com/users/rmartinjak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sagemath/sagenb/labels/Enhancement","name":"Enhancement","color":"009800"},{"url":"https://api.github.com/repos/sagemath/sagenb/labels/Major","name":"Major","color":"eb6420"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":24,"created_at":"2012-12-04T11:31:48Z","updated_at":"2015-01-27T13:05:54Z","closed_at":"2014-12-17T21:10:16Z","pull_request":{"url":"https://api.github.com/repos/sagemath/sagenb/pulls/120","html_url":"https://github.com/sagemath/sagenb/pull/120","diff_url":"https://github.com/sagemath/sagenb/pull/120.diff","patch_url":"https://github.com/sagemath/sagenb/pull/120.patch"},"body":"Let's be honest, how often do you log in to check a running notebook's output for errors?\n\nWith the code attached,\n* the admin(s) can configure a list of notification recipients in \"Settings -> Notebook Settings\"\n* uncaught exceptions automatically produce a notification and present the user a \"500: Internal server error\" page\n* sending a notification e-mail to the admin(s) can be done with e.g.\n\n```python\nfrom sagenb.notebook.notification import logger\nlogger.error(\"something went wrong!\")\n```\nor simply by throwing an exception (that is not caught).\n\nNote: I had to remove the forking-related code in `sagenb.notebook.sage_email` in order to get this to work. This shouldn't be a problem since twisted sends e-mails asynchronously."},"comment":{"url":"https://api.github.com/repos/sagemath/sagenb/issues/comments/71644536","html_url":"https://github.com/sagemath/sagenb/pull/120#issuecomment-71644536","issue_url":"https://api.github.com/repos/sagemath/sagenb/issues/120","id":71644536,"user":{"login":"jdemeyer","id":3625785,"avatar_url":"https://avatars.githubusercontent.com/u/3625785?v=3","gravatar_id":"","url":"https://api.github.com/users/jdemeyer","html_url":"https://github.com/jdemeyer","followers_url":"https://api.github.com/users/jdemeyer/followers","following_url":"https://api.github.com/users/jdemeyer/following{/other_user}","gists_url":"https://api.github.com/users/jdemeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/jdemeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdemeyer/subscriptions","organizations_url":"https://api.github.com/users/jdemeyer/orgs","repos_url":"https://api.github.com/users/jdemeyer/repos","events_url":"https://api.github.com/users/jdemeyer/events{/privacy}","received_events_url":"https://api.github.com/users/jdemeyer/received_events","type":"User","site_admin":false},"created_at":"2015-01-27T13:05:54Z","updated_at":"2015-01-27T13:05:54Z","body":"I am a bit worried about who could receive this `root@localhost` e-mail. Imagine users on a shared server using their own personal Sage running their own personal Notebook. Then it's probably not appropriate to send e-mail to `root@localhost`.\r\n\r\nI would much prefer to send no e-mails by default."}}