{"action":"closed","number":132,"pull_request":{"url":"https://api.github.com/repos/nviennot/nobrainer/pulls/132","id":32262933,"html_url":"https://github.com/nviennot/nobrainer/pull/132","diff_url":"https://github.com/nviennot/nobrainer/pull/132.diff","patch_url":"https://github.com/nviennot/nobrainer/pull/132.patch","issue_url":"https://api.github.com/repos/nviennot/nobrainer/issues/132","number":132,"state":"closed","locked":false,"title":"Specs for association options (and bug fixes) and Model.find(multiple pks)","user":{"login":"jh125486","id":1824797,"avatar_url":"https://avatars.githubusercontent.com/u/1824797?v=3","gravatar_id":"","url":"https://api.github.com/users/jh125486","html_url":"https://github.com/jh125486","followers_url":"https://api.github.com/users/jh125486/followers","following_url":"https://api.github.com/users/jh125486/following{/other_user}","gists_url":"https://api.github.com/users/jh125486/gists{/gist_id}","starred_url":"https://api.github.com/users/jh125486/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jh125486/subscriptions","organizations_url":"https://api.github.com/users/jh125486/orgs","repos_url":"https://api.github.com/users/jh125486/repos","events_url":"https://api.github.com/users/jh125486/events{/privacy}","received_events_url":"https://api.github.com/users/jh125486/received_events","type":"User","site_admin":false},"body":"Sorry both these commits are in one pull request, it's my first time with git in a team environment.\r\n\r\nI was converting over a Rails app to use rethinkdb and the belongs_to/has_many association options were not working as I expected.  I think I fixed where the problems were and wrote tests to support.\r\n\r\nAfter that I tried to pass an array to Model.find() and tracked down where that failed.  I used the AR find method as a example for all the cases.\r\n\r\nAlso it's my first time using rspec, so if the syntax isn't right or something please send me on the right path.","created_at":"2015-03-30T20:17:14Z","updated_at":"2015-07-03T00:56:46Z","closed_at":"2015-07-03T00:56:46Z","merged_at":null,"merge_commit_sha":"65b84e48dc40af799140113a1c958f4e6e89d93e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nviennot/nobrainer/pulls/132/commits","review_comments_url":"https://api.github.com/repos/nviennot/nobrainer/pulls/132/comments","review_comment_url":"https://api.github.com/repos/nviennot/nobrainer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nviennot/nobrainer/issues/132/comments","statuses_url":"https://api.github.com/repos/nviennot/nobrainer/statuses/d3117462c11f1d75281ca42b05b66ef0e6377c10","head":{"label":"jh125486:master","ref":"master","sha":"d3117462c11f1d75281ca42b05b66ef0e6377c10","user":{"login":"jh125486","id":1824797,"avatar_url":"https://avatars.githubusercontent.com/u/1824797?v=3","gravatar_id":"","url":"https://api.github.com/users/jh125486","html_url":"https://github.com/jh125486","followers_url":"https://api.github.com/users/jh125486/followers","following_url":"https://api.github.com/users/jh125486/following{/other_user}","gists_url":"https://api.github.com/users/jh125486/gists{/gist_id}","starred_url":"https://api.github.com/users/jh125486/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jh125486/subscriptions","organizations_url":"https://api.github.com/users/jh125486/orgs","repos_url":"https://api.github.com/users/jh125486/repos","events_url":"https://api.github.com/users/jh125486/events{/privacy}","received_events_url":"https://api.github.com/users/jh125486/received_events","type":"User","site_admin":false},"repo":{"id":33130663,"name":"nobrainer","full_name":"jh125486/nobrainer","owner":{"login":"jh125486","id":1824797,"avatar_url":"https://avatars.githubusercontent.com/u/1824797?v=3","gravatar_id":"","url":"https://api.github.com/users/jh125486","html_url":"https://github.com/jh125486","followers_url":"https://api.github.com/users/jh125486/followers","following_url":"https://api.github.com/users/jh125486/following{/other_user}","gists_url":"https://api.github.com/users/jh125486/gists{/gist_id}","starred_url":"https://api.github.com/users/jh125486/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jh125486/subscriptions","organizations_url":"https://api.github.com/users/jh125486/orgs","repos_url":"https://api.github.com/users/jh125486/repos","events_url":"https://api.github.com/users/jh125486/events{/privacy}","received_events_url":"https://api.github.com/users/jh125486/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jh125486/nobrainer","description":"Ruby ORM for RethinkDB","fork":true,"url":"https://api.github.com/repos/jh125486/nobrainer","forks_url":"https://api.github.com/repos/jh125486/nobrainer/forks","keys_url":"https://api.github.com/repos/jh125486/nobrainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jh125486/nobrainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jh125486/nobrainer/teams","hooks_url":"https://api.github.com/repos/jh125486/nobrainer/hooks","issue_events_url":"https://api.github.com/repos/jh125486/nobrainer/issues/events{/number}","events_url":"https://api.github.com/repos/jh125486/nobrainer/events","assignees_url":"https://api.github.com/repos/jh125486/nobrainer/assignees{/user}","branches_url":"https://api.github.com/repos/jh125486/nobrainer/branches{/branch}","tags_url":"https://api.github.com/repos/jh125486/nobrainer/tags","blobs_url":"https://api.github.com/repos/jh125486/nobrainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jh125486/nobrainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jh125486/nobrainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jh125486/nobrainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jh125486/nobrainer/statuses/{sha}","languages_url":"https://api.github.com/repos/jh125486/nobrainer/languages","stargazers_url":"https://api.github.com/repos/jh125486/nobrainer/stargazers","contributors_url":"https://api.github.com/repos/jh125486/nobrainer/contributors","subscribers_url":"https://api.github.com/repos/jh125486/nobrainer/subscribers","subscription_url":"https://api.github.com/repos/jh125486/nobrainer/subscription","commits_url":"https://api.github.com/repos/jh125486/nobrainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jh125486/nobrainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jh125486/nobrainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jh125486/nobrainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jh125486/nobrainer/contents/{+path}","compare_url":"https://api.github.com/repos/jh125486/nobrainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jh125486/nobrainer/merges","archive_url":"https://api.github.com/repos/jh125486/nobrainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jh125486/nobrainer/downloads","issues_url":"https://api.github.com/repos/jh125486/nobrainer/issues{/number}","pulls_url":"https://api.github.com/repos/jh125486/nobrainer/pulls{/number}","milestones_url":"https://api.github.com/repos/jh125486/nobrainer/milestones{/number}","notifications_url":"https://api.github.com/repos/jh125486/nobrainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jh125486/nobrainer/labels{/name}","releases_url":"https://api.github.com/repos/jh125486/nobrainer/releases{/id}","created_at":"2015-03-30T15:14:20Z","updated_at":"2015-03-30T20:04:37Z","pushed_at":"2015-03-30T20:04:37Z","git_url":"git://github.com/jh125486/nobrainer.git","ssh_url":"git@github.com:jh125486/nobrainer.git","clone_url":"https://github.com/jh125486/nobrainer.git","svn_url":"https://github.com/jh125486/nobrainer","homepage":"http://nobrainer.io/","size":944,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nviennot:master","ref":"master","sha":"10387d9ffdbcc58ba25c8ff25da0b54c95b04d7f","user":{"login":"nviennot","id":297060,"avatar_url":"https://avatars.githubusercontent.com/u/297060?v=3","gravatar_id":"","url":"https://api.github.com/users/nviennot","html_url":"https://github.com/nviennot","followers_url":"https://api.github.com/users/nviennot/followers","following_url":"https://api.github.com/users/nviennot/following{/other_user}","gists_url":"https://api.github.com/users/nviennot/gists{/gist_id}","starred_url":"https://api.github.com/users/nviennot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nviennot/subscriptions","organizations_url":"https://api.github.com/users/nviennot/orgs","repos_url":"https://api.github.com/users/nviennot/repos","events_url":"https://api.github.com/users/nviennot/events{/privacy}","received_events_url":"https://api.github.com/users/nviennot/received_events","type":"User","site_admin":false},"repo":{"id":7284265,"name":"nobrainer","full_name":"nviennot/nobrainer","owner":{"login":"nviennot","id":297060,"avatar_url":"https://avatars.githubusercontent.com/u/297060?v=3","gravatar_id":"","url":"https://api.github.com/users/nviennot","html_url":"https://github.com/nviennot","followers_url":"https://api.github.com/users/nviennot/followers","following_url":"https://api.github.com/users/nviennot/following{/other_user}","gists_url":"https://api.github.com/users/nviennot/gists{/gist_id}","starred_url":"https://api.github.com/users/nviennot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nviennot/subscriptions","organizations_url":"https://api.github.com/users/nviennot/orgs","repos_url":"https://api.github.com/users/nviennot/repos","events_url":"https://api.github.com/users/nviennot/events{/privacy}","received_events_url":"https://api.github.com/users/nviennot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nviennot/nobrainer","description":"Ruby ORM for RethinkDB","fork":false,"url":"https://api.github.com/repos/nviennot/nobrainer","forks_url":"https://api.github.com/repos/nviennot/nobrainer/forks","keys_url":"https://api.github.com/repos/nviennot/nobrainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nviennot/nobrainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nviennot/nobrainer/teams","hooks_url":"https://api.github.com/repos/nviennot/nobrainer/hooks","issue_events_url":"https://api.github.com/repos/nviennot/nobrainer/issues/events{/number}","events_url":"https://api.github.com/repos/nviennot/nobrainer/events","assignees_url":"https://api.github.com/repos/nviennot/nobrainer/assignees{/user}","branches_url":"https://api.github.com/repos/nviennot/nobrainer/branches{/branch}","tags_url":"https://api.github.com/repos/nviennot/nobrainer/tags","blobs_url":"https://api.github.com/repos/nviennot/nobrainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nviennot/nobrainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nviennot/nobrainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/nviennot/nobrainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nviennot/nobrainer/statuses/{sha}","languages_url":"https://api.github.com/repos/nviennot/nobrainer/languages","stargazers_url":"https://api.github.com/repos/nviennot/nobrainer/stargazers","contributors_url":"https://api.github.com/repos/nviennot/nobrainer/contributors","subscribers_url":"https://api.github.com/repos/nviennot/nobrainer/subscribers","subscription_url":"https://api.github.com/repos/nviennot/nobrainer/subscription","commits_url":"https://api.github.com/repos/nviennot/nobrainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/nviennot/nobrainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/nviennot/nobrainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/nviennot/nobrainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/nviennot/nobrainer/contents/{+path}","compare_url":"https://api.github.com/repos/nviennot/nobrainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nviennot/nobrainer/merges","archive_url":"https://api.github.com/repos/nviennot/nobrainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nviennot/nobrainer/downloads","issues_url":"https://api.github.com/repos/nviennot/nobrainer/issues{/number}","pulls_url":"https://api.github.com/repos/nviennot/nobrainer/pulls{/number}","milestones_url":"https://api.github.com/repos/nviennot/nobrainer/milestones{/number}","notifications_url":"https://api.github.com/repos/nviennot/nobrainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nviennot/nobrainer/labels{/name}","releases_url":"https://api.github.com/repos/nviennot/nobrainer/releases{/id}","created_at":"2012-12-22T09:12:52Z","updated_at":"2015-07-02T05:01:32Z","pushed_at":"2015-07-03T00:56:46Z","git_url":"git://github.com/nviennot/nobrainer.git","ssh_url":"git@github.com:nviennot/nobrainer.git","clone_url":"https://github.com/nviennot/nobrainer.git","svn_url":"https://github.com/nviennot/nobrainer","homepage":"http://nobrainer.io/","size":2436,"stargazers_count":232,"watchers_count":232,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":0,"forks":38,"open_issues":0,"watchers":232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nviennot/nobrainer/pulls/132"},"html":{"href":"https://github.com/nviennot/nobrainer/pull/132"},"issue":{"href":"https://api.github.com/repos/nviennot/nobrainer/issues/132"},"comments":{"href":"https://api.github.com/repos/nviennot/nobrainer/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/nviennot/nobrainer/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/nviennot/nobrainer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nviennot/nobrainer/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/nviennot/nobrainer/statuses/d3117462c11f1d75281ca42b05b66ef0e6377c10"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":7,"review_comments":0,"commits":2,"additions":180,"deletions":15,"changed_files":7}}