{"action":"created","comment":{"url":"https://api.github.com/repos/genome/genome/pulls/comments/24247595","id":24247595,"diff_hunk":"@@ -1522,10 +1528,15 @@ sub shellcmd {\n                 {   # POE sets a handler to ignore SIG{PIPE}, that makes the\n                     # pipefail option useless.\n                     local $SIG{PIPE} = 'DEFAULT';\n-                    $system_retval = system('bash', '-c', \"$shellopts_part $cmd\");\n+                    my @cmdline = ('bash', '-c', \"$shellopts_part $cmd\");\n+                    exec(@cmdline)\n+                        or do {","path":"lib/perl/Genome/Sys.pm","position":50,"original_position":50,"commit_id":"74edb34dd55c51a01768361206c9e266b83a4553","original_commit_id":"98c0aa2d38122d8b16119cd8f0980560f2b541bd","user":{"login":"brummett","id":111808,"avatar_url":"https://avatars.githubusercontent.com/u/111808?v=3","gravatar_id":"","url":"https://api.github.com/users/brummett","html_url":"https://github.com/brummett","followers_url":"https://api.github.com/users/brummett/followers","following_url":"https://api.github.com/users/brummett/following{/other_user}","gists_url":"https://api.github.com/users/brummett/gists{/gist_id}","starred_url":"https://api.github.com/users/brummett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brummett/subscriptions","organizations_url":"https://api.github.com/users/brummett/orgs","repos_url":"https://api.github.com/users/brummett/repos","events_url":"https://api.github.com/users/brummett/events{/privacy}","received_events_url":"https://api.github.com/users/brummett/received_events","type":"User","site_admin":false},"body":"Not necessary, but it matches the pattern I try to use for these kinds of syscalls\r\n```\r\nfunction() or die '...';\r\n```\r\nSince there's 2 steps to \"die\" here, I put it in a do {} block.","created_at":"2015-02-06T15:35:56Z","updated_at":"2015-02-06T15:35:56Z","html_url":"https://github.com/genome/genome/pull/455#discussion_r24247595","pull_request_url":"https://api.github.com/repos/genome/genome/pulls/455","_links":{"self":{"href":"https://api.github.com/repos/genome/genome/pulls/comments/24247595"},"html":{"href":"https://github.com/genome/genome/pull/455#discussion_r24247595"},"pull_request":{"href":"https://api.github.com/repos/genome/genome/pulls/455"}}},"pull_request":{"url":"https://api.github.com/repos/genome/genome/pulls/455","id":28773632,"html_url":"https://github.com/genome/genome/pull/455","diff_url":"https://github.com/genome/genome/pull/455.diff","patch_url":"https://github.com/genome/genome/pull/455.patch","issue_url":"https://api.github.com/repos/genome/genome/issues/455","number":455,"state":"open","locked":false,"title":"Another try at fixing STDOUT and STDERR redirection","user":{"login":"brummett","id":111808,"avatar_url":"https://avatars.githubusercontent.com/u/111808?v=3","gravatar_id":"","url":"https://api.github.com/users/brummett","html_url":"https://github.com/brummett","followers_url":"https://api.github.com/users/brummett/followers","following_url":"https://api.github.com/users/brummett/following{/other_user}","gists_url":"https://api.github.com/users/brummett/gists{/gist_id}","starred_url":"https://api.github.com/users/brummett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brummett/subscriptions","organizations_url":"https://api.github.com/users/brummett/orgs","repos_url":"https://api.github.com/users/brummett/repos","events_url":"https://api.github.com/users/brummett/events{/privacy}","received_events_url":"https://api.github.com/users/brummett/received_events","type":"User","site_admin":false},"body":"This supercedes e4ae511.  The previous commit would have caused our\r\nweb server to wig out.  See the message in commit 0d56bbc for why.","created_at":"2015-02-05T23:56:47Z","updated_at":"2015-02-06T15:35:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1c9640a03fb2124fa3c07f13345d22bc5106864","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/genome/genome/pulls/455/commits","review_comments_url":"https://api.github.com/repos/genome/genome/pulls/455/comments","review_comment_url":"https://api.github.com/repos/genome/genome/pulls/comments/{number}","comments_url":"https://api.github.com/repos/genome/genome/issues/455/comments","statuses_url":"https://api.github.com/repos/genome/genome/statuses/74edb34dd55c51a01768361206c9e266b83a4553","head":{"label":"brummett:redirect-redux","ref":"redirect-redux","sha":"74edb34dd55c51a01768361206c9e266b83a4553","user":{"login":"brummett","id":111808,"avatar_url":"https://avatars.githubusercontent.com/u/111808?v=3","gravatar_id":"","url":"https://api.github.com/users/brummett","html_url":"https://github.com/brummett","followers_url":"https://api.github.com/users/brummett/followers","following_url":"https://api.github.com/users/brummett/following{/other_user}","gists_url":"https://api.github.com/users/brummett/gists{/gist_id}","starred_url":"https://api.github.com/users/brummett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brummett/subscriptions","organizations_url":"https://api.github.com/users/brummett/orgs","repos_url":"https://api.github.com/users/brummett/repos","events_url":"https://api.github.com/users/brummett/events{/privacy}","received_events_url":"https://api.github.com/users/brummett/received_events","type":"User","site_admin":false},"repo":{"id":24347156,"name":"genome","full_name":"brummett/genome","owner":{"login":"brummett","id":111808,"avatar_url":"https://avatars.githubusercontent.com/u/111808?v=3","gravatar_id":"","url":"https://api.github.com/users/brummett","html_url":"https://github.com/brummett","followers_url":"https://api.github.com/users/brummett/followers","following_url":"https://api.github.com/users/brummett/following{/other_user}","gists_url":"https://api.github.com/users/brummett/gists{/gist_id}","starred_url":"https://api.github.com/users/brummett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brummett/subscriptions","organizations_url":"https://api.github.com/users/brummett/orgs","repos_url":"https://api.github.com/users/brummett/repos","events_url":"https://api.github.com/users/brummett/events{/privacy}","received_events_url":"https://api.github.com/users/brummett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brummett/genome","description":"","fork":true,"url":"https://api.github.com/repos/brummett/genome","forks_url":"https://api.github.com/repos/brummett/genome/forks","keys_url":"https://api.github.com/repos/brummett/genome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brummett/genome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brummett/genome/teams","hooks_url":"https://api.github.com/repos/brummett/genome/hooks","issue_events_url":"https://api.github.com/repos/brummett/genome/issues/events{/number}","events_url":"https://api.github.com/repos/brummett/genome/events","assignees_url":"https://api.github.com/repos/brummett/genome/assignees{/user}","branches_url":"https://api.github.com/repos/brummett/genome/branches{/branch}","tags_url":"https://api.github.com/repos/brummett/genome/tags","blobs_url":"https://api.github.com/repos/brummett/genome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brummett/genome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brummett/genome/git/refs{/sha}","trees_url":"https://api.github.com/repos/brummett/genome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brummett/genome/statuses/{sha}","languages_url":"https://api.github.com/repos/brummett/genome/languages","stargazers_url":"https://api.github.com/repos/brummett/genome/stargazers","contributors_url":"https://api.github.com/repos/brummett/genome/contributors","subscribers_url":"https://api.github.com/repos/brummett/genome/subscribers","subscription_url":"https://api.github.com/repos/brummett/genome/subscription","commits_url":"https://api.github.com/repos/brummett/genome/commits{/sha}","git_commits_url":"https://api.github.com/repos/brummett/genome/git/commits{/sha}","comments_url":"https://api.github.com/repos/brummett/genome/comments{/number}","issue_comment_url":"https://api.github.com/repos/brummett/genome/issues/comments/{number}","contents_url":"https://api.github.com/repos/brummett/genome/contents/{+path}","compare_url":"https://api.github.com/repos/brummett/genome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brummett/genome/merges","archive_url":"https://api.github.com/repos/brummett/genome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brummett/genome/downloads","issues_url":"https://api.github.com/repos/brummett/genome/issues{/number}","pulls_url":"https://api.github.com/repos/brummett/genome/pulls{/number}","milestones_url":"https://api.github.com/repos/brummett/genome/milestones{/number}","notifications_url":"https://api.github.com/repos/brummett/genome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brummett/genome/labels{/name}","releases_url":"https://api.github.com/repos/brummett/genome/releases{/id}","created_at":"2014-09-22T21:57:53Z","updated_at":"2014-10-07T22:49:38Z","pushed_at":"2015-02-06T15:33:34Z","git_url":"git://github.com/brummett/genome.git","ssh_url":"git@github.com:brummett/genome.git","clone_url":"https://github.com/brummett/genome.git","svn_url":"https://github.com/brummett/genome","homepage":"","size":110731,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"genome:master","ref":"master","sha":"d0972393ddcd56ece31653ead0bb254471150329","user":{"login":"genome","id":318108,"avatar_url":"https://avatars.githubusercontent.com/u/318108?v=3","gravatar_id":"","url":"https://api.github.com/users/genome","html_url":"https://github.com/genome","followers_url":"https://api.github.com/users/genome/followers","following_url":"https://api.github.com/users/genome/following{/other_user}","gists_url":"https://api.github.com/users/genome/gists{/gist_id}","starred_url":"https://api.github.com/users/genome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genome/subscriptions","organizations_url":"https://api.github.com/users/genome/orgs","repos_url":"https://api.github.com/users/genome/repos","events_url":"https://api.github.com/users/genome/events{/privacy}","received_events_url":"https://api.github.com/users/genome/received_events","type":"Organization","site_admin":false},"repo":{"id":23442737,"name":"genome","full_name":"genome/genome","owner":{"login":"genome","id":318108,"avatar_url":"https://avatars.githubusercontent.com/u/318108?v=3","gravatar_id":"","url":"https://api.github.com/users/genome","html_url":"https://github.com/genome","followers_url":"https://api.github.com/users/genome/followers","following_url":"https://api.github.com/users/genome/following{/other_user}","gists_url":"https://api.github.com/users/genome/gists{/gist_id}","starred_url":"https://api.github.com/users/genome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genome/subscriptions","organizations_url":"https://api.github.com/users/genome/orgs","repos_url":"https://api.github.com/users/genome/repos","events_url":"https://api.github.com/users/genome/events{/privacy}","received_events_url":"https://api.github.com/users/genome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/genome/genome","description":"Core modules used by the GMS","fork":false,"url":"https://api.github.com/repos/genome/genome","forks_url":"https://api.github.com/repos/genome/genome/forks","keys_url":"https://api.github.com/repos/genome/genome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genome/genome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genome/genome/teams","hooks_url":"https://api.github.com/repos/genome/genome/hooks","issue_events_url":"https://api.github.com/repos/genome/genome/issues/events{/number}","events_url":"https://api.github.com/repos/genome/genome/events","assignees_url":"https://api.github.com/repos/genome/genome/assignees{/user}","branches_url":"https://api.github.com/repos/genome/genome/branches{/branch}","tags_url":"https://api.github.com/repos/genome/genome/tags","blobs_url":"https://api.github.com/repos/genome/genome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genome/genome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genome/genome/git/refs{/sha}","trees_url":"https://api.github.com/repos/genome/genome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genome/genome/statuses/{sha}","languages_url":"https://api.github.com/repos/genome/genome/languages","stargazers_url":"https://api.github.com/repos/genome/genome/stargazers","contributors_url":"https://api.github.com/repos/genome/genome/contributors","subscribers_url":"https://api.github.com/repos/genome/genome/subscribers","subscription_url":"https://api.github.com/repos/genome/genome/subscription","commits_url":"https://api.github.com/repos/genome/genome/commits{/sha}","git_commits_url":"https://api.github.com/repos/genome/genome/git/commits{/sha}","comments_url":"https://api.github.com/repos/genome/genome/comments{/number}","issue_comment_url":"https://api.github.com/repos/genome/genome/issues/comments/{number}","contents_url":"https://api.github.com/repos/genome/genome/contents/{+path}","compare_url":"https://api.github.com/repos/genome/genome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genome/genome/merges","archive_url":"https://api.github.com/repos/genome/genome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genome/genome/downloads","issues_url":"https://api.github.com/repos/genome/genome/issues{/number}","pulls_url":"https://api.github.com/repos/genome/genome/pulls{/number}","milestones_url":"https://api.github.com/repos/genome/genome/milestones{/number}","notifications_url":"https://api.github.com/repos/genome/genome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genome/genome/labels{/name}","releases_url":"https://api.github.com/repos/genome/genome/releases{/id}","created_at":"2014-08-28T20:59:19Z","updated_at":"2015-02-06T13:16:35Z","pushed_at":"2015-02-06T13:16:35Z","git_url":"git://github.com/genome/genome.git","ssh_url":"git@github.com:genome/genome.git","clone_url":"https://github.com/genome/genome.git","svn_url":"https://github.com/genome/genome","homepage":"","size":120469,"stargazers_count":4,"watchers_count":4,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":11,"forks":32,"open_issues":11,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/genome/genome/pulls/455"},"html":{"href":"https://github.com/genome/genome/pull/455"},"issue":{"href":"https://api.github.com/repos/genome/genome/issues/455"},"comments":{"href":"https://api.github.com/repos/genome/genome/issues/455/comments"},"review_comments":{"href":"https://api.github.com/repos/genome/genome/pulls/455/comments"},"review_comment":{"href":"https://api.github.com/repos/genome/genome/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/genome/genome/pulls/455/commits"},"statuses":{"href":"https://api.github.com/repos/genome/genome/statuses/74edb34dd55c51a01768361206c9e266b83a4553"}}}}