{"action":"created","issue":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/6745","labels_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/6745/labels{/name}","comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/6745/comments","events_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/6745/events","html_url":"https://github.com/gitlabhq/gitlabhq/issues/6745","id":31243025,"number":6745,"title":"New comment on merge request do not trigger web hook","user":{"login":"blackeyedboy","id":3263734,"avatar_url":"https://avatars.githubusercontent.com/u/3263734?v=3","gravatar_id":"","url":"https://api.github.com/users/blackeyedboy","html_url":"https://github.com/blackeyedboy","followers_url":"https://api.github.com/users/blackeyedboy/followers","following_url":"https://api.github.com/users/blackeyedboy/following{/other_user}","gists_url":"https://api.github.com/users/blackeyedboy/gists{/gist_id}","starred_url":"https://api.github.com/users/blackeyedboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackeyedboy/subscriptions","organizations_url":"https://api.github.com/users/blackeyedboy/orgs","repos_url":"https://api.github.com/users/blackeyedboy/repos","events_url":"https://api.github.com/users/blackeyedboy/events{/privacy}","received_events_url":"https://api.github.com/users/blackeyedboy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2014-04-10T13:37:40Z","updated_at":"2015-05-17T19:00:26Z","closed_at":null,"body":"**Summary :** when a user add a comment to a merge request, the web hook is not triggered for a merge_request event.\r\n\r\n**Steps to reproduce :** open a merge request (the web hook is triggered), add a comment to this merge request (the web hook is NOT triggered).\r\n\r\n**Expected behavior :** trigger the web hook when any user add a comment to a merge_request !\r\nNote that if I add a comment through a `POST /projects/:id/merge_request/:merge_request_id/comments` API call, the merge_request web hook is correctly triggered on the comment add !\r\n\r\n**Possible fixes :** I've little or no experience with ruby nor gitlab internal architecture, but maybe just a `execute_hooks(merge_request)` with the relevant `merge_request` on which the comment has been posted in the [app/observers/note_observer.rb](https://github.com/gitlabhq/gitlabhq/blob/master/app/observers/note_observer.rb) ?\r\n\r\nI've seen in the [app/observers](https://github.com/gitlabhq/gitlabhq/commits/master/app/observers) folder history that the observers get removed one by one (mergerequest, keys, emails, issue, etc...), so maybe you are getting to a new way of triggering web hooks that I don't see for now, and my \"possible fix\" just sucks.\r\n\r\nI'm sorry to say I haven't managed to find out how the `note.save` in [lib/api/merge_requests.rb](https://github.com/gitlabhq/gitlabhq/blob/master/lib/api/merge_requests.rb) trigger the web hook.\r\n\r\n**Checks :** GitLab 6.7.3 f88d30f with tests full ok, see below.\r\n```\r\nSystem information\r\nSystem:\t\t\r\nCurrent User:\tgit\r\nUsing RVM:\tno\r\nRuby Version:\t1.9.3p194\r\nGem Version:\t1.8.23\r\nBundler Version:1.6.1\r\nRake Version:\t10.1.1\r\n```\r\n```\r\nChecking Environment ...\r\n\r\nGit configured for git user? ... yes\r\n\r\nChecking Environment ... Finished\r\n\r\nChecking GitLab Shell ...\r\n\r\nGitLab Shell version >= 1.9.1 ? ... OK (1.9.1)\r\nRepo base directory exists? ... yes\r\nRepo base directory is a symlink? ... no\r\nRepo base owned by git:git? ... yes\r\nRepo base access is drwxrws---? ... yes\r\nupdate hook up-to-date? ... yes\r\nupdate hooks in repos are links: ... \r\nXXX / Testing Purpose ... ok\r\nRunning /home/git/gitlab-shell/bin/check\r\nCheck GitLab API access: OK\r\nCheck directories and files: \r\n\t/home/git/repositories: OK\r\n\t/home/git/.ssh/authorized_keys: OK\r\nTest redis-cli executable: redis-cli 2.4.14\r\nSend ping to redis server: PONG\r\ngitlab-shell self-check successful\r\n\r\nChecking GitLab Shell ... Finished\r\n\r\nChecking Sidekiq ...\r\n\r\nRunning? ... yes\r\nNumber of Sidekiq processes ... 1\r\n\r\nChecking Sidekiq ... Finished\r\n\r\nChecking LDAP ...\r\n\r\nLDAP is disabled in config/gitlab.yml\r\n\r\nChecking LDAP ... Finished\r\n\r\nChecking GitLab ...\r\n\r\nDatabase config exists? ... yes\r\nDatabase is SQLite ... no\r\nAll migrations up? ... yes\r\nDatabase contains orphaned UsersGroups? ... no\r\nGitLab config exists? ... yes\r\nGitLab config outdated? ... no\r\nLog directory writable? ... yes\r\nTmp directory writable? ... yes\r\nInit script exists? ... yes\r\nInit script up-to-date? ... yes\r\nprojects have namespace: ... \r\nXXX / Testing Purpose ... yes\r\nProjects have satellites? ... \r\nXXX / Testing Purpose ... yes\r\nRedis version >= 2.0.0? ... yes\r\nYour git bin path is \"/usr/bin/git\"\r\nGit version >= 1.7.10 ? ... yes (1.7.10)\r\n\r\nChecking GitLab ... Finished\r\n```\r\n\r\n**Just a side note :** *Gitlab rocks !*"},"comment":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/comments/102835611","html_url":"https://github.com/gitlabhq/gitlabhq/issues/6745#issuecomment-102835611","issue_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/6745","id":102835611,"user":{"login":"stanhu","id":963826,"avatar_url":"https://avatars.githubusercontent.com/u/963826?v=3","gravatar_id":"","url":"https://api.github.com/users/stanhu","html_url":"https://github.com/stanhu","followers_url":"https://api.github.com/users/stanhu/followers","following_url":"https://api.github.com/users/stanhu/following{/other_user}","gists_url":"https://api.github.com/users/stanhu/gists{/gist_id}","starred_url":"https://api.github.com/users/stanhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanhu/subscriptions","organizations_url":"https://api.github.com/users/stanhu/orgs","repos_url":"https://api.github.com/users/stanhu/repos","events_url":"https://api.github.com/users/stanhu/events{/privacy}","received_events_url":"https://api.github.com/users/stanhu/received_events","type":"User","site_admin":false},"created_at":"2015-05-17T19:00:26Z","updated_at":"2015-05-17T19:00:26Z","body":"@mathstuf I'm not quite sure if I understand--can you explain this issue?\r\n\r\nI've submitted a merge request here:\r\n\r\nhttps://gitlab.com/gitlab-org/gitlab-ce/merge_requests/673\r\n"}}