{"action":"opened","number":13680,"pull_request":{"url":"https://api.github.com/repos/ariya/phantomjs/pulls/13680","id":48682950,"html_url":"https://github.com/ariya/phantomjs/pull/13680","diff_url":"https://github.com/ariya/phantomjs/pull/13680.diff","patch_url":"https://github.com/ariya/phantomjs/pull/13680.patch","issue_url":"https://api.github.com/repos/ariya/phantomjs/issues/13680","number":13680,"state":"open","locked":false,"title":"Fix for #13638","user":{"login":"tmallery","id":4738335,"avatar_url":"https://avatars.githubusercontent.com/u/4738335?v=3","gravatar_id":"","url":"https://api.github.com/users/tmallery","html_url":"https://github.com/tmallery","followers_url":"https://api.github.com/users/tmallery/followers","following_url":"https://api.github.com/users/tmallery/following{/other_user}","gists_url":"https://api.github.com/users/tmallery/gists{/gist_id}","starred_url":"https://api.github.com/users/tmallery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmallery/subscriptions","organizations_url":"https://api.github.com/users/tmallery/orgs","repos_url":"https://api.github.com/users/tmallery/repos","events_url":"https://api.github.com/users/tmallery/events{/privacy}","received_events_url":"https://api.github.com/users/tmallery/received_events","type":"User","site_admin":false},"body":"https://github.com/ariya/phantomjs/issues/13638\r\n\r\nThe origin of this issue is CookieUtil.cookiesToMap does not clear the contents the cookie map before it fills a cookies value and expiration dates are only added if they are present. The result is if the first cookie filled has an expiration date and then the second cookie filled does not, the produced JSON for the second cookie will have the expiration date from the first cookie.\r\n\r\nThe fix is to clear out the contents of the map before writing the cookies value to it.","created_at":"2015-10-25T17:23:19Z","updated_at":"2015-10-25T17:23:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ariya/phantomjs/pulls/13680/commits","review_comments_url":"https://api.github.com/repos/ariya/phantomjs/pulls/13680/comments","review_comment_url":"https://api.github.com/repos/ariya/phantomjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ariya/phantomjs/issues/13680/comments","statuses_url":"https://api.github.com/repos/ariya/phantomjs/statuses/26ed3360eff05cbf35462e78cff007f40c3ade34","head":{"label":"ariya:2.0","ref":"2.0","sha":"26ed3360eff05cbf35462e78cff007f40c3ade34","user":{"login":"ariya","id":7288,"avatar_url":"https://avatars.githubusercontent.com/u/7288?v=3","gravatar_id":"","url":"https://api.github.com/users/ariya","html_url":"https://github.com/ariya","followers_url":"https://api.github.com/users/ariya/followers","following_url":"https://api.github.com/users/ariya/following{/other_user}","gists_url":"https://api.github.com/users/ariya/gists{/gist_id}","starred_url":"https://api.github.com/users/ariya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariya/subscriptions","organizations_url":"https://api.github.com/users/ariya/orgs","repos_url":"https://api.github.com/users/ariya/repos","events_url":"https://api.github.com/users/ariya/events{/privacy}","received_events_url":"https://api.github.com/users/ariya/received_events","type":"User","site_admin":false},"repo":{"id":1200050,"name":"phantomjs","full_name":"ariya/phantomjs","owner":{"login":"ariya","id":7288,"avatar_url":"https://avatars.githubusercontent.com/u/7288?v=3","gravatar_id":"","url":"https://api.github.com/users/ariya","html_url":"https://github.com/ariya","followers_url":"https://api.github.com/users/ariya/followers","following_url":"https://api.github.com/users/ariya/following{/other_user}","gists_url":"https://api.github.com/users/ariya/gists{/gist_id}","starred_url":"https://api.github.com/users/ariya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariya/subscriptions","organizations_url":"https://api.github.com/users/ariya/orgs","repos_url":"https://api.github.com/users/ariya/repos","events_url":"https://api.github.com/users/ariya/events{/privacy}","received_events_url":"https://api.github.com/users/ariya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ariya/phantomjs","description":"Scriptable Headless WebKit","fork":false,"url":"https://api.github.com/repos/ariya/phantomjs","forks_url":"https://api.github.com/repos/ariya/phantomjs/forks","keys_url":"https://api.github.com/repos/ariya/phantomjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ariya/phantomjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ariya/phantomjs/teams","hooks_url":"https://api.github.com/repos/ariya/phantomjs/hooks","issue_events_url":"https://api.github.com/repos/ariya/phantomjs/issues/events{/number}","events_url":"https://api.github.com/repos/ariya/phantomjs/events","assignees_url":"https://api.github.com/repos/ariya/phantomjs/assignees{/user}","branches_url":"https://api.github.com/repos/ariya/phantomjs/branches{/branch}","tags_url":"https://api.github.com/repos/ariya/phantomjs/tags","blobs_url":"https://api.github.com/repos/ariya/phantomjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ariya/phantomjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ariya/phantomjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ariya/phantomjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ariya/phantomjs/statuses/{sha}","languages_url":"https://api.github.com/repos/ariya/phantomjs/languages","stargazers_url":"https://api.github.com/repos/ariya/phantomjs/stargazers","contributors_url":"https://api.github.com/repos/ariya/phantomjs/contributors","subscribers_url":"https://api.github.com/repos/ariya/phantomjs/subscribers","subscription_url":"https://api.github.com/repos/ariya/phantomjs/subscription","commits_url":"https://api.github.com/repos/ariya/phantomjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ariya/phantomjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ariya/phantomjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ariya/phantomjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ariya/phantomjs/contents/{+path}","compare_url":"https://api.github.com/repos/ariya/phantomjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ariya/phantomjs/merges","archive_url":"https://api.github.com/repos/ariya/phantomjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ariya/phantomjs/downloads","issues_url":"https://api.github.com/repos/ariya/phantomjs/issues{/number}","pulls_url":"https://api.github.com/repos/ariya/phantomjs/pulls{/number}","milestones_url":"https://api.github.com/repos/ariya/phantomjs/milestones{/number}","notifications_url":"https://api.github.com/repos/ariya/phantomjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ariya/phantomjs/labels{/name}","releases_url":"https://api.github.com/repos/ariya/phantomjs/releases{/id}","created_at":"2010-12-27T08:18:58Z","updated_at":"2015-10-25T16:17:28Z","pushed_at":"2015-10-25T17:23:19Z","git_url":"git://github.com/ariya/phantomjs.git","ssh_url":"git@github.com:ariya/phantomjs.git","clone_url":"https://github.com/ariya/phantomjs.git","svn_url":"https://github.com/ariya/phantomjs","homepage":"http://phantomjs.org","size":171472,"stargazers_count":15679,"watchers_count":15679,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3100,"mirror_url":null,"open_issues_count":1730,"forks":3100,"open_issues":1730,"watchers":15679,"default_branch":"master"}},"base":{"label":"ariya:master","ref":"master","sha":"0ba13ec57c2454926c00293db5146a4b60edd62f","user":{"login":"ariya","id":7288,"avatar_url":"https://avatars.githubusercontent.com/u/7288?v=3","gravatar_id":"","url":"https://api.github.com/users/ariya","html_url":"https://github.com/ariya","followers_url":"https://api.github.com/users/ariya/followers","following_url":"https://api.github.com/users/ariya/following{/other_user}","gists_url":"https://api.github.com/users/ariya/gists{/gist_id}","starred_url":"https://api.github.com/users/ariya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariya/subscriptions","organizations_url":"https://api.github.com/users/ariya/orgs","repos_url":"https://api.github.com/users/ariya/repos","events_url":"https://api.github.com/users/ariya/events{/privacy}","received_events_url":"https://api.github.com/users/ariya/received_events","type":"User","site_admin":false},"repo":{"id":1200050,"name":"phantomjs","full_name":"ariya/phantomjs","owner":{"login":"ariya","id":7288,"avatar_url":"https://avatars.githubusercontent.com/u/7288?v=3","gravatar_id":"","url":"https://api.github.com/users/ariya","html_url":"https://github.com/ariya","followers_url":"https://api.github.com/users/ariya/followers","following_url":"https://api.github.com/users/ariya/following{/other_user}","gists_url":"https://api.github.com/users/ariya/gists{/gist_id}","starred_url":"https://api.github.com/users/ariya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariya/subscriptions","organizations_url":"https://api.github.com/users/ariya/orgs","repos_url":"https://api.github.com/users/ariya/repos","events_url":"https://api.github.com/users/ariya/events{/privacy}","received_events_url":"https://api.github.com/users/ariya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ariya/phantomjs","description":"Scriptable Headless WebKit","fork":false,"url":"https://api.github.com/repos/ariya/phantomjs","forks_url":"https://api.github.com/repos/ariya/phantomjs/forks","keys_url":"https://api.github.com/repos/ariya/phantomjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ariya/phantomjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ariya/phantomjs/teams","hooks_url":"https://api.github.com/repos/ariya/phantomjs/hooks","issue_events_url":"https://api.github.com/repos/ariya/phantomjs/issues/events{/number}","events_url":"https://api.github.com/repos/ariya/phantomjs/events","assignees_url":"https://api.github.com/repos/ariya/phantomjs/assignees{/user}","branches_url":"https://api.github.com/repos/ariya/phantomjs/branches{/branch}","tags_url":"https://api.github.com/repos/ariya/phantomjs/tags","blobs_url":"https://api.github.com/repos/ariya/phantomjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ariya/phantomjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ariya/phantomjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ariya/phantomjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ariya/phantomjs/statuses/{sha}","languages_url":"https://api.github.com/repos/ariya/phantomjs/languages","stargazers_url":"https://api.github.com/repos/ariya/phantomjs/stargazers","contributors_url":"https://api.github.com/repos/ariya/phantomjs/contributors","subscribers_url":"https://api.github.com/repos/ariya/phantomjs/subscribers","subscription_url":"https://api.github.com/repos/ariya/phantomjs/subscription","commits_url":"https://api.github.com/repos/ariya/phantomjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ariya/phantomjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ariya/phantomjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ariya/phantomjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ariya/phantomjs/contents/{+path}","compare_url":"https://api.github.com/repos/ariya/phantomjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ariya/phantomjs/merges","archive_url":"https://api.github.com/repos/ariya/phantomjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ariya/phantomjs/downloads","issues_url":"https://api.github.com/repos/ariya/phantomjs/issues{/number}","pulls_url":"https://api.github.com/repos/ariya/phantomjs/pulls{/number}","milestones_url":"https://api.github.com/repos/ariya/phantomjs/milestones{/number}","notifications_url":"https://api.github.com/repos/ariya/phantomjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ariya/phantomjs/labels{/name}","releases_url":"https://api.github.com/repos/ariya/phantomjs/releases{/id}","created_at":"2010-12-27T08:18:58Z","updated_at":"2015-10-25T16:17:28Z","pushed_at":"2015-10-25T17:23:19Z","git_url":"git://github.com/ariya/phantomjs.git","ssh_url":"git@github.com:ariya/phantomjs.git","clone_url":"https://github.com/ariya/phantomjs.git","svn_url":"https://github.com/ariya/phantomjs","homepage":"http://phantomjs.org","size":171472,"stargazers_count":15679,"watchers_count":15679,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3100,"mirror_url":null,"open_issues_count":1730,"forks":3100,"open_issues":1730,"watchers":15679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ariya/phantomjs/pulls/13680"},"html":{"href":"https://github.com/ariya/phantomjs/pull/13680"},"issue":{"href":"https://api.github.com/repos/ariya/phantomjs/issues/13680"},"comments":{"href":"https://api.github.com/repos/ariya/phantomjs/issues/13680/comments"},"review_comments":{"href":"https://api.github.com/repos/ariya/phantomjs/pulls/13680/comments"},"review_comment":{"href":"https://api.github.com/repos/ariya/phantomjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ariya/phantomjs/pulls/13680/commits"},"statuses":{"href":"https://api.github.com/repos/ariya/phantomjs/statuses/26ed3360eff05cbf35462e78cff007f40c3ade34"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":14,"deletions":8,"changed_files":4}}