{"action":"created","issue":{"url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/3857","labels_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/3857/labels{/name}","comments_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/3857/comments","events_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/3857/events","html_url":"https://github.com/ankidroid/Anki-Android/pull/3857","id":118069285,"number":3857,"title":"Limit tags in custom study dialog to those in the selected deck","user":{"login":"bogdanteleaga","id":6207800,"avatar_url":"https://avatars.githubusercontent.com/u/6207800?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdanteleaga","html_url":"https://github.com/bogdanteleaga","followers_url":"https://api.github.com/users/bogdanteleaga/followers","following_url":"https://api.github.com/users/bogdanteleaga/following{/other_user}","gists_url":"https://api.github.com/users/bogdanteleaga/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanteleaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanteleaga/subscriptions","organizations_url":"https://api.github.com/users/bogdanteleaga/orgs","repos_url":"https://api.github.com/users/bogdanteleaga/repos","events_url":"https://api.github.com/users/bogdanteleaga/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanteleaga/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-11-20T15:55:28Z","updated_at":"2015-11-20T17:57:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ankidroid/Anki-Android/pulls/3857","html_url":"https://github.com/ankidroid/Anki-Android/pull/3857","diff_url":"https://github.com/ankidroid/Anki-Android/pull/3857.diff","patch_url":"https://github.com/ankidroid/Anki-Android/pull/3857.patch"},"body":"This PR is mainly looking to fix https://github.com/ankidroid/Anki-Android/issues/3791.\r\n\r\nSome issues I discovered along the way:\r\n\r\n1. Tags seem to be quite weird. I have a deck that has tags separated with space. I'm not sure how anki wants to differentiate through tags(I'm guessing anki uses spaces and the author wanted to use tags containing spaces). They do get saved properly in the database, but I am unable to create a deck from them. If anki does not allow spaces in tags I guess it's just a limitation that the author wasn't aware of, if not, this might be a bug.\r\n\r\n2. I'm trying to use `activity.getCol().getDecks().selected();` to get the current deck id, but it doesn't seem to work properly. I need to start reviews in a deck for it to be considered selected. \r\nFor example:\r\n  - Make reviews in deck A\r\n  - Long press deck B and try to filter through it's tags\r\n  - A's tags show up\r\n\r\nUntil 2 is somehow fixed, I think it'd be a bad idea to merge this since it's rather confusing.\r\n\r\nAlso I'm sorry for any bad practices regarding java, I haven't written any in quite a while. I'm open to any suggestions."},"comment":{"url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/comments/158474858","html_url":"https://github.com/ankidroid/Anki-Android/pull/3857#issuecomment-158474858","issue_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/3857","id":158474858,"user":{"login":"timrae","id":2818274,"avatar_url":"https://avatars.githubusercontent.com/u/2818274?v=3","gravatar_id":"","url":"https://api.github.com/users/timrae","html_url":"https://github.com/timrae","followers_url":"https://api.github.com/users/timrae/followers","following_url":"https://api.github.com/users/timrae/following{/other_user}","gists_url":"https://api.github.com/users/timrae/gists{/gist_id}","starred_url":"https://api.github.com/users/timrae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timrae/subscriptions","organizations_url":"https://api.github.com/users/timrae/orgs","repos_url":"https://api.github.com/users/timrae/repos","events_url":"https://api.github.com/users/timrae/events{/privacy}","received_events_url":"https://api.github.com/users/timrae/received_events","type":"User","site_admin":false},"created_at":"2015-11-20T17:57:58Z","updated_at":"2015-11-20T17:57:58Z","body":"I probably should have recommended that you send a PR to Anki Desktop as well, in which case refactoring would definitely make sense"}}