{"action":"created","issue":{"url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2289","labels_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2289/labels{/name}","comments_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2289/comments","events_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2289/events","html_url":"https://github.com/concrete5/concrete5-5.7.0/pull/2289","id":69527534,"number":2289,"title":"Avoid problems in ResponseAssetGroup::requireAsset","user":{"login":"mlocati","id":928116,"avatar_url":"https://avatars.githubusercontent.com/u/928116?v=3","gravatar_id":"","url":"https://api.github.com/users/mlocati","html_url":"https://github.com/mlocati","followers_url":"https://api.github.com/users/mlocati/followers","following_url":"https://api.github.com/users/mlocati/following{/other_user}","gists_url":"https://api.github.com/users/mlocati/gists{/gist_id}","starred_url":"https://api.github.com/users/mlocati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlocati/subscriptions","organizations_url":"https://api.github.com/users/mlocati/orgs","repos_url":"https://api.github.com/users/mlocati/repos","events_url":"https://api.github.com/users/mlocati/events{/privacy}","received_events_url":"https://api.github.com/users/mlocati/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-20T07:41:19Z","updated_at":"2015-04-20T19:38:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/pulls/2289","html_url":"https://github.com/concrete5/concrete5-5.7.0/pull/2289","diff_url":"https://github.com/concrete5/concrete5-5.7.0/pull/2289.diff","patch_url":"https://github.com/concrete5/concrete5-5.7.0/pull/2289.patch"},"body":"If the code requires an invalid asset group, the site breaks.\r\nWe have two alternatives: we can ignore this error (like in this PR) or we can throw an Exception with a description of the problem. Since both have downsides I'll leave this choice to the core team :wink:\r\n\r\nFurthermore, the class-level static variable `$group` was just defined as `static $group = null;`, without any accessibility specifications: I marked it as `protected`."},"comment":{"url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/comments/94549623","html_url":"https://github.com/concrete5/concrete5-5.7.0/pull/2289#issuecomment-94549623","issue_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2289","id":94549623,"user":{"login":"aembler","id":527809,"avatar_url":"https://avatars.githubusercontent.com/u/527809?v=3","gravatar_id":"","url":"https://api.github.com/users/aembler","html_url":"https://github.com/aembler","followers_url":"https://api.github.com/users/aembler/followers","following_url":"https://api.github.com/users/aembler/following{/other_user}","gists_url":"https://api.github.com/users/aembler/gists{/gist_id}","starred_url":"https://api.github.com/users/aembler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aembler/subscriptions","organizations_url":"https://api.github.com/users/aembler/orgs","repos_url":"https://api.github.com/users/aembler/repos","events_url":"https://api.github.com/users/aembler/events{/privacy}","received_events_url":"https://api.github.com/users/aembler/received_events","type":"User","site_admin":false},"created_at":"2015-04-20T19:38:22Z","updated_at":"2015-04-20T19:38:22Z","body":"It's definitely not good that it just breaks with no explanation right now, but I think hiding isn't right either. I think we ought to throw an exception that shows the handle of the asset you were trying to require. "}}