{"action":"created","comment":{"url":"https://api.github.com/repos/ros2/rmw_connext/pulls/comments/38824038","id":38824038,"diff_hunk":"@@ -42,7 +44,7 @@ if(WIN32)\n     PRIVATE \"ROSIDL_TYPESUPPORT_CONNEXT_CPP_BUILDING_DLL\")\n endif()\n \n-ament_export_libraries(rmw_connext_cpp ${Connext_LIBRARIES})\n+ament_export_libraries(rmw_connext_cpp ${rmw_connext_shared_cpp_LIBRARIES})","path":"rmw_connext_cpp/CMakeLists.txt","position":28,"original_position":28,"commit_id":"99a739c4bd2b449db483f607fcc961d9aadee4cf","original_commit_id":"99a739c4bd2b449db483f607fcc961d9aadee4cf","user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"body":"Instead of using:\r\n\r\n* `ament_export_definitions`\r\n* `ament_export_include_directories`\r\n* `ament_export_libraries`\r\n\r\nfor `rmw_connext_shared_cpp_*` it should simply use:\r\n\r\n* `ament_export_dependencies`","created_at":"2015-09-06T17:48:27Z","updated_at":"2015-09-06T17:48:27Z","html_url":"https://github.com/ros2/rmw_connext/pull/93#discussion_r38824038","pull_request_url":"https://api.github.com/repos/ros2/rmw_connext/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/ros2/rmw_connext/pulls/comments/38824038"},"html":{"href":"https://github.com/ros2/rmw_connext/pull/93#discussion_r38824038"},"pull_request":{"href":"https://api.github.com/repos/ros2/rmw_connext/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/ros2/rmw_connext/pulls/93","id":42980327,"html_url":"https://github.com/ros2/rmw_connext/pull/93","diff_url":"https://github.com/ros2/rmw_connext/pull/93.diff","patch_url":"https://github.com/ros2/rmw_connext/pull/93.patch","issue_url":"https://api.github.com/repos/ros2/rmw_connext/issues/93","number":93,"state":"open","locked":false,"title":"Package for sharing code between rmw_connext_cpp and rmw_connext_dynamic_cpp","user":{"login":"jacquelinekay","id":495933,"avatar_url":"https://avatars.githubusercontent.com/u/495933?v=3","gravatar_id":"","url":"https://api.github.com/users/jacquelinekay","html_url":"https://github.com/jacquelinekay","followers_url":"https://api.github.com/users/jacquelinekay/followers","following_url":"https://api.github.com/users/jacquelinekay/following{/other_user}","gists_url":"https://api.github.com/users/jacquelinekay/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquelinekay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquelinekay/subscriptions","organizations_url":"https://api.github.com/users/jacquelinekay/orgs","repos_url":"https://api.github.com/users/jacquelinekay/repos","events_url":"https://api.github.com/users/jacquelinekay/events{/privacy}","received_events_url":"https://api.github.com/users/jacquelinekay/received_events","type":"User","site_admin":false},"body":"I recently complained about the amount of duplicated code between the two rmw implementations in this repo. This is what it could look like to share code between the two packages.\r\n\r\nThere's probably more that could be done to reduce code duplication here. The functions that I didn't touch still have similar structure between the two packages (`create/destroy_subscription, create/destroy_service, create/destroy_client`, etc.).","created_at":"2015-08-20T21:25:41Z","updated_at":"2015-09-06T17:48:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fbc7c1855fbbd3534c301ff68b613247380e086","assignee":{"login":"jacquelinekay","id":495933,"avatar_url":"https://avatars.githubusercontent.com/u/495933?v=3","gravatar_id":"","url":"https://api.github.com/users/jacquelinekay","html_url":"https://github.com/jacquelinekay","followers_url":"https://api.github.com/users/jacquelinekay/followers","following_url":"https://api.github.com/users/jacquelinekay/following{/other_user}","gists_url":"https://api.github.com/users/jacquelinekay/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquelinekay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquelinekay/subscriptions","organizations_url":"https://api.github.com/users/jacquelinekay/orgs","repos_url":"https://api.github.com/users/jacquelinekay/repos","events_url":"https://api.github.com/users/jacquelinekay/events{/privacy}","received_events_url":"https://api.github.com/users/jacquelinekay/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ros2/rmw_connext/pulls/93/commits","review_comments_url":"https://api.github.com/repos/ros2/rmw_connext/pulls/93/comments","review_comment_url":"https://api.github.com/repos/ros2/rmw_connext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/rmw_connext/issues/93/comments","statuses_url":"https://api.github.com/repos/ros2/rmw_connext/statuses/99a739c4bd2b449db483f607fcc961d9aadee4cf","head":{"label":"ros2:share_code_dynamic","ref":"share_code_dynamic","sha":"99a739c4bd2b449db483f607fcc961d9aadee4cf","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":22737329,"name":"rmw_connext","full_name":"ros2/rmw_connext","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/rmw_connext","description":"Implementation of the ROS Middleware (rmw) Interface using RTI's Connext DDS.","fork":false,"url":"https://api.github.com/repos/ros2/rmw_connext","forks_url":"https://api.github.com/repos/ros2/rmw_connext/forks","keys_url":"https://api.github.com/repos/ros2/rmw_connext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rmw_connext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rmw_connext/teams","hooks_url":"https://api.github.com/repos/ros2/rmw_connext/hooks","issue_events_url":"https://api.github.com/repos/ros2/rmw_connext/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rmw_connext/events","assignees_url":"https://api.github.com/repos/ros2/rmw_connext/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rmw_connext/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rmw_connext/tags","blobs_url":"https://api.github.com/repos/ros2/rmw_connext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rmw_connext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rmw_connext/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rmw_connext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rmw_connext/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rmw_connext/languages","stargazers_url":"https://api.github.com/repos/ros2/rmw_connext/stargazers","contributors_url":"https://api.github.com/repos/ros2/rmw_connext/contributors","subscribers_url":"https://api.github.com/repos/ros2/rmw_connext/subscribers","subscription_url":"https://api.github.com/repos/ros2/rmw_connext/subscription","commits_url":"https://api.github.com/repos/ros2/rmw_connext/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rmw_connext/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rmw_connext/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rmw_connext/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rmw_connext/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rmw_connext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rmw_connext/merges","archive_url":"https://api.github.com/repos/ros2/rmw_connext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rmw_connext/downloads","issues_url":"https://api.github.com/repos/ros2/rmw_connext/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rmw_connext/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rmw_connext/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rmw_connext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rmw_connext/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rmw_connext/releases{/id}","created_at":"2014-08-07T21:36:18Z","updated_at":"2015-05-06T00:39:16Z","pushed_at":"2015-09-04T01:55:32Z","git_url":"git://github.com/ros2/rmw_connext.git","ssh_url":"git@github.com:ros2/rmw_connext.git","clone_url":"https://github.com/ros2/rmw_connext.git","svn_url":"https://github.com/ros2/rmw_connext","homepage":"","size":2640,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":18,"forks":1,"open_issues":18,"watchers":1,"default_branch":"master"}},"base":{"label":"ros2:master","ref":"master","sha":"304a5ab2f943f64f6e5b2c503ffc765d8eb38b51","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":22737329,"name":"rmw_connext","full_name":"ros2/rmw_connext","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/rmw_connext","description":"Implementation of the ROS Middleware (rmw) Interface using RTI's Connext DDS.","fork":false,"url":"https://api.github.com/repos/ros2/rmw_connext","forks_url":"https://api.github.com/repos/ros2/rmw_connext/forks","keys_url":"https://api.github.com/repos/ros2/rmw_connext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/rmw_connext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/rmw_connext/teams","hooks_url":"https://api.github.com/repos/ros2/rmw_connext/hooks","issue_events_url":"https://api.github.com/repos/ros2/rmw_connext/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/rmw_connext/events","assignees_url":"https://api.github.com/repos/ros2/rmw_connext/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/rmw_connext/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/rmw_connext/tags","blobs_url":"https://api.github.com/repos/ros2/rmw_connext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/rmw_connext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/rmw_connext/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/rmw_connext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/rmw_connext/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/rmw_connext/languages","stargazers_url":"https://api.github.com/repos/ros2/rmw_connext/stargazers","contributors_url":"https://api.github.com/repos/ros2/rmw_connext/contributors","subscribers_url":"https://api.github.com/repos/ros2/rmw_connext/subscribers","subscription_url":"https://api.github.com/repos/ros2/rmw_connext/subscription","commits_url":"https://api.github.com/repos/ros2/rmw_connext/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/rmw_connext/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/rmw_connext/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/rmw_connext/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/rmw_connext/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/rmw_connext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/rmw_connext/merges","archive_url":"https://api.github.com/repos/ros2/rmw_connext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/rmw_connext/downloads","issues_url":"https://api.github.com/repos/ros2/rmw_connext/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/rmw_connext/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/rmw_connext/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/rmw_connext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/rmw_connext/labels{/name}","releases_url":"https://api.github.com/repos/ros2/rmw_connext/releases{/id}","created_at":"2014-08-07T21:36:18Z","updated_at":"2015-05-06T00:39:16Z","pushed_at":"2015-09-04T01:55:32Z","git_url":"git://github.com/ros2/rmw_connext.git","ssh_url":"git@github.com:ros2/rmw_connext.git","clone_url":"https://github.com/ros2/rmw_connext.git","svn_url":"https://github.com/ros2/rmw_connext","homepage":"","size":2640,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":18,"forks":1,"open_issues":18,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/rmw_connext/pulls/93"},"html":{"href":"https://github.com/ros2/rmw_connext/pull/93"},"issue":{"href":"https://api.github.com/repos/ros2/rmw_connext/issues/93"},"comments":{"href":"https://api.github.com/repos/ros2/rmw_connext/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/rmw_connext/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/rmw_connext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/rmw_connext/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/rmw_connext/statuses/99a739c4bd2b449db483f607fcc961d9aadee4cf"}}}}