{"action":"created","issue":{"url":"https://api.github.com/repos/keybase/client/issues/1365","labels_url":"https://api.github.com/repos/keybase/client/issues/1365/labels{/name}","comments_url":"https://api.github.com/repos/keybase/client/issues/1365/comments","events_url":"https://api.github.com/repos/keybase/client/issues/1365/events","html_url":"https://github.com/keybase/client/pull/1365","id":117874390,"number":1365,"title":"Don't use a goroutine for logging to external loggers","user":{"login":"cjb","id":21217,"avatar_url":"https://avatars.githubusercontent.com/u/21217?v=3","gravatar_id":"","url":"https://api.github.com/users/cjb","html_url":"https://github.com/cjb","followers_url":"https://api.github.com/users/cjb/followers","following_url":"https://api.github.com/users/cjb/following{/other_user}","gists_url":"https://api.github.com/users/cjb/gists{/gist_id}","starred_url":"https://api.github.com/users/cjb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjb/subscriptions","organizations_url":"https://api.github.com/users/cjb/orgs","repos_url":"https://api.github.com/users/cjb/repos","events_url":"https://api.github.com/users/cjb/events{/privacy}","received_events_url":"https://api.github.com/users/cjb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-11-19T18:15:01Z","updated_at":"2015-11-19T21:35:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/keybase/client/pulls/1365","html_url":"https://github.com/keybase/client/pull/1365","diff_url":"https://github.com/keybase/client/pull/1365.diff","patch_url":"https://github.com/keybase/client/pull/1365.patch"},"body":"We made log forwarding from service to client happen asynchronously due to some potential performance concerns, but this has the retrospectively-predictable consequences that:\r\n\r\n* messages arrive out of order to the client!\r\n* the client completes a command and exits, but how many of the log messages from that command we see at the client's end depends on a race between the client process exiting, and receiving messages.\r\n\r\nThe result is that log forwarding's pretty useless.  I think we should either disable the asynchrony (as in this PR) or do something more drastic to log forwarding itself.\r\n\r\n@oconnor663 @patrickxb @maxtaco What do you think?"},"comment":{"url":"https://api.github.com/repos/keybase/client/issues/comments/158204973","html_url":"https://github.com/keybase/client/pull/1365#issuecomment-158204973","issue_url":"https://api.github.com/repos/keybase/client/issues/1365","id":158204973,"user":{"login":"cjb","id":21217,"avatar_url":"https://avatars.githubusercontent.com/u/21217?v=3","gravatar_id":"","url":"https://api.github.com/users/cjb","html_url":"https://github.com/cjb","followers_url":"https://api.github.com/users/cjb/followers","following_url":"https://api.github.com/users/cjb/following{/other_user}","gists_url":"https://api.github.com/users/cjb/gists{/gist_id}","starred_url":"https://api.github.com/users/cjb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjb/subscriptions","organizations_url":"https://api.github.com/users/cjb/orgs","repos_url":"https://api.github.com/users/cjb/repos","events_url":"https://api.github.com/users/cjb/events{/privacy}","received_events_url":"https://api.github.com/users/cjb/received_events","type":"User","site_admin":false},"created_at":"2015-11-19T21:35:48Z","updated_at":"2015-11-19T21:35:48Z","body":"Okay, thanks."}}