{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/webappsec/pulls/comments/31457195","id":31457195,"diff_hunk":"@@ -595,15 +577,15 @@ failed resource with a different one.\n \n Whenever a user agent attempts to [obtain a resource][] pointed to by a\n `link` element that has a `rel` attribute with the value of `stylesheet`,\n-insert the following step between steps 1 and 2:\n+modify step 4 to read:\n \n-1.  Set the [integrity metadata][] of the request to the value\n-    of the element's `integrity` attribute.\n-{:start=\"2\"}\n+Do a potentially CORS-enabled fetch of the resulting absolute URL, with the\n+mode being the current state of the element's crossorigin content attribute,","path":"specs/subresourceintegrity/spec.markdown","position":77,"original_position":77,"commit_id":"9df8a3c5a88fc7b9da2c29e6f532c07ba0e8f456","original_commit_id":"9df8a3c5a88fc7b9da2c29e6f532c07ba0e8f456","user":{"login":"metromoxie","id":401207,"avatar_url":"https://avatars.githubusercontent.com/u/401207?v=3","gravatar_id":"","url":"https://api.github.com/users/metromoxie","html_url":"https://github.com/metromoxie","followers_url":"https://api.github.com/users/metromoxie/followers","following_url":"https://api.github.com/users/metromoxie/following{/other_user}","gists_url":"https://api.github.com/users/metromoxie/gists{/gist_id}","starred_url":"https://api.github.com/users/metromoxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metromoxie/subscriptions","organizations_url":"https://api.github.com/users/metromoxie/orgs","repos_url":"https://api.github.com/users/metromoxie/repos","events_url":"https://api.github.com/users/metromoxie/events{/privacy}","received_events_url":"https://api.github.com/users/metromoxie/received_events","type":"User","site_admin":false},"body":"As a clarification, this is an exact copy of the text already present in http://www.w3.org/TR/html5/document-metadata.html#concept-link-obtain, just extended with \", and the [integrity metadata][] of the request to the\r\n+value of the element's `integrity` attribute\", so really the only part of this up for debate is that last clause :-)\r\n\r\nAnd, yes, this still requires CORS because the \"match\" algorithm still does the \"Is resource eligible for integrity validation check,\" which will return \"false\" if resource is not same origin or CORS enabled.","created_at":"2015-06-01T18:50:59Z","updated_at":"2015-06-01T18:50:59Z","html_url":"https://github.com/w3c/webappsec/pull/391#discussion_r31457195","pull_request_url":"https://api.github.com/repos/w3c/webappsec/pulls/391","_links":{"self":{"href":"https://api.github.com/repos/w3c/webappsec/pulls/comments/31457195"},"html":{"href":"https://github.com/w3c/webappsec/pull/391#discussion_r31457195"},"pull_request":{"href":"https://api.github.com/repos/w3c/webappsec/pulls/391"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/webappsec/pulls/391","id":36471404,"html_url":"https://github.com/w3c/webappsec/pull/391","diff_url":"https://github.com/w3c/webappsec/pull/391.diff","patch_url":"https://github.com/w3c/webappsec/pull/391.patch","issue_url":"https://api.github.com/repos/w3c/webappsec/issues/391","number":391,"state":"open","locked":false,"title":"SRI: Simplify the element modifications to just set integrity metadata","user":{"login":"metromoxie","id":401207,"avatar_url":"https://avatars.githubusercontent.com/u/401207?v=3","gravatar_id":"","url":"https://api.github.com/users/metromoxie","html_url":"https://github.com/metromoxie","followers_url":"https://api.github.com/users/metromoxie/followers","following_url":"https://api.github.com/users/metromoxie/following{/other_user}","gists_url":"https://api.github.com/users/metromoxie/gists{/gist_id}","starred_url":"https://api.github.com/users/metromoxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metromoxie/subscriptions","organizations_url":"https://api.github.com/users/metromoxie/orgs","repos_url":"https://api.github.com/users/metromoxie/repos","events_url":"https://api.github.com/users/metromoxie/events{/privacy}","received_events_url":"https://api.github.com/users/metromoxie/received_events","type":"User","site_admin":false},"body":"This modifies the algorithms to more closely integrate with Fetch, as discussed in #238. This makes several relevant changes:\r\n   1. Adds modifications to main Fetch, after the Mixed Content check, to check for valid integrity. If it fails, it returns a network error.\r\n   2. It removes the \"integrity state\" on the response, as this state doesn't need to be passed around anymore (everything is done in main fetch). This removes a bunch of text from various algorithms.\r\n   3. It simplifies the element modifications to just set `integrity metadata` on the request before Fetch occurs.","created_at":"2015-05-29T03:32:43Z","updated_at":"2015-06-01T18:50:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0faa18b77670aaa9237f8b7d2c79b6083bfdfe56","assignee":null,"milestone":{"url":"https://api.github.com/repos/w3c/webappsec/milestones/3","html_url":"https://github.com/w3c/webappsec/milestones/SRI-v1-LC","labels_url":"https://api.github.com/repos/w3c/webappsec/milestones/3/labels","id":895505,"number":3,"title":"SRI-v1-LC","description":"Let's conservatively try to include things for the \"minimum viable\" SRI into this milestone. Last Call should happen in January 2015 according to the (draft) charter's milestones.","creator":{"login":"mozfreddyb","id":5418775,"avatar_url":"https://avatars.githubusercontent.com/u/5418775?v=3","gravatar_id":"","url":"https://api.github.com/users/mozfreddyb","html_url":"https://github.com/mozfreddyb","followers_url":"https://api.github.com/users/mozfreddyb/followers","following_url":"https://api.github.com/users/mozfreddyb/following{/other_user}","gists_url":"https://api.github.com/users/mozfreddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/mozfreddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozfreddyb/subscriptions","organizations_url":"https://api.github.com/users/mozfreddyb/orgs","repos_url":"https://api.github.com/users/mozfreddyb/repos","events_url":"https://api.github.com/users/mozfreddyb/events{/privacy}","received_events_url":"https://api.github.com/users/mozfreddyb/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":67,"state":"open","created_at":"2014-12-08T10:39:40Z","updated_at":"2015-05-29T09:33:50Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/w3c/webappsec/pulls/391/commits","review_comments_url":"https://api.github.com/repos/w3c/webappsec/pulls/391/comments","review_comment_url":"https://api.github.com/repos/w3c/webappsec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/webappsec/issues/391/comments","statuses_url":"https://api.github.com/repos/w3c/webappsec/statuses/9df8a3c5a88fc7b9da2c29e6f532c07ba0e8f456","head":{"label":"metromoxie:fetch-integration","ref":"fetch-integration","sha":"9df8a3c5a88fc7b9da2c29e6f532c07ba0e8f456","user":{"login":"metromoxie","id":401207,"avatar_url":"https://avatars.githubusercontent.com/u/401207?v=3","gravatar_id":"","url":"https://api.github.com/users/metromoxie","html_url":"https://github.com/metromoxie","followers_url":"https://api.github.com/users/metromoxie/followers","following_url":"https://api.github.com/users/metromoxie/following{/other_user}","gists_url":"https://api.github.com/users/metromoxie/gists{/gist_id}","starred_url":"https://api.github.com/users/metromoxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metromoxie/subscriptions","organizations_url":"https://api.github.com/users/metromoxie/orgs","repos_url":"https://api.github.com/users/metromoxie/repos","events_url":"https://api.github.com/users/metromoxie/events{/privacy}","received_events_url":"https://api.github.com/users/metromoxie/received_events","type":"User","site_admin":false},"repo":{"id":26143612,"name":"webappsec","full_name":"metromoxie/webappsec","owner":{"login":"metromoxie","id":401207,"avatar_url":"https://avatars.githubusercontent.com/u/401207?v=3","gravatar_id":"","url":"https://api.github.com/users/metromoxie","html_url":"https://github.com/metromoxie","followers_url":"https://api.github.com/users/metromoxie/followers","following_url":"https://api.github.com/users/metromoxie/following{/other_user}","gists_url":"https://api.github.com/users/metromoxie/gists{/gist_id}","starred_url":"https://api.github.com/users/metromoxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metromoxie/subscriptions","organizations_url":"https://api.github.com/users/metromoxie/orgs","repos_url":"https://api.github.com/users/metromoxie/repos","events_url":"https://api.github.com/users/metromoxie/events{/privacy}","received_events_url":"https://api.github.com/users/metromoxie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/metromoxie/webappsec","description":"","fork":true,"url":"https://api.github.com/repos/metromoxie/webappsec","forks_url":"https://api.github.com/repos/metromoxie/webappsec/forks","keys_url":"https://api.github.com/repos/metromoxie/webappsec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metromoxie/webappsec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metromoxie/webappsec/teams","hooks_url":"https://api.github.com/repos/metromoxie/webappsec/hooks","issue_events_url":"https://api.github.com/repos/metromoxie/webappsec/issues/events{/number}","events_url":"https://api.github.com/repos/metromoxie/webappsec/events","assignees_url":"https://api.github.com/repos/metromoxie/webappsec/assignees{/user}","branches_url":"https://api.github.com/repos/metromoxie/webappsec/branches{/branch}","tags_url":"https://api.github.com/repos/metromoxie/webappsec/tags","blobs_url":"https://api.github.com/repos/metromoxie/webappsec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metromoxie/webappsec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metromoxie/webappsec/git/refs{/sha}","trees_url":"https://api.github.com/repos/metromoxie/webappsec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metromoxie/webappsec/statuses/{sha}","languages_url":"https://api.github.com/repos/metromoxie/webappsec/languages","stargazers_url":"https://api.github.com/repos/metromoxie/webappsec/stargazers","contributors_url":"https://api.github.com/repos/metromoxie/webappsec/contributors","subscribers_url":"https://api.github.com/repos/metromoxie/webappsec/subscribers","subscription_url":"https://api.github.com/repos/metromoxie/webappsec/subscription","commits_url":"https://api.github.com/repos/metromoxie/webappsec/commits{/sha}","git_commits_url":"https://api.github.com/repos/metromoxie/webappsec/git/commits{/sha}","comments_url":"https://api.github.com/repos/metromoxie/webappsec/comments{/number}","issue_comment_url":"https://api.github.com/repos/metromoxie/webappsec/issues/comments{/number}","contents_url":"https://api.github.com/repos/metromoxie/webappsec/contents/{+path}","compare_url":"https://api.github.com/repos/metromoxie/webappsec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metromoxie/webappsec/merges","archive_url":"https://api.github.com/repos/metromoxie/webappsec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metromoxie/webappsec/downloads","issues_url":"https://api.github.com/repos/metromoxie/webappsec/issues{/number}","pulls_url":"https://api.github.com/repos/metromoxie/webappsec/pulls{/number}","milestones_url":"https://api.github.com/repos/metromoxie/webappsec/milestones{/number}","notifications_url":"https://api.github.com/repos/metromoxie/webappsec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metromoxie/webappsec/labels{/name}","releases_url":"https://api.github.com/repos/metromoxie/webappsec/releases{/id}","created_at":"2014-11-03T23:21:54Z","updated_at":"2015-04-18T00:34:34Z","pushed_at":"2015-05-31T07:39:50Z","git_url":"git://github.com/metromoxie/webappsec.git","ssh_url":"git@github.com:metromoxie/webappsec.git","clone_url":"https://github.com/metromoxie/webappsec.git","svn_url":"https://github.com/metromoxie/webappsec","homepage":null,"size":7421,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"8e1cbbab9720812d935593c537f43c525f4bd808","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":15536087,"name":"webappsec","full_name":"w3c/webappsec","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/webappsec","description":"","fork":false,"url":"https://api.github.com/repos/w3c/webappsec","forks_url":"https://api.github.com/repos/w3c/webappsec/forks","keys_url":"https://api.github.com/repos/w3c/webappsec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/webappsec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/webappsec/teams","hooks_url":"https://api.github.com/repos/w3c/webappsec/hooks","issue_events_url":"https://api.github.com/repos/w3c/webappsec/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/webappsec/events","assignees_url":"https://api.github.com/repos/w3c/webappsec/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/webappsec/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/webappsec/tags","blobs_url":"https://api.github.com/repos/w3c/webappsec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/webappsec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/webappsec/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/webappsec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/webappsec/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/webappsec/languages","stargazers_url":"https://api.github.com/repos/w3c/webappsec/stargazers","contributors_url":"https://api.github.com/repos/w3c/webappsec/contributors","subscribers_url":"https://api.github.com/repos/w3c/webappsec/subscribers","subscription_url":"https://api.github.com/repos/w3c/webappsec/subscription","commits_url":"https://api.github.com/repos/w3c/webappsec/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/webappsec/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/webappsec/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/webappsec/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/webappsec/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/webappsec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/webappsec/merges","archive_url":"https://api.github.com/repos/w3c/webappsec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/webappsec/downloads","issues_url":"https://api.github.com/repos/w3c/webappsec/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/webappsec/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/webappsec/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/webappsec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/webappsec/labels{/name}","releases_url":"https://api.github.com/repos/w3c/webappsec/releases{/id}","created_at":"2013-12-30T20:39:16Z","updated_at":"2015-05-28T16:09:02Z","pushed_at":"2015-06-01T13:08:55Z","git_url":"git://github.com/w3c/webappsec.git","ssh_url":"git@github.com:w3c/webappsec.git","clone_url":"https://github.com/w3c/webappsec.git","svn_url":"https://github.com/w3c/webappsec","homepage":null,"size":14093,"stargazers_count":114,"watchers_count":114,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"open_issues_count":82,"forks":49,"open_issues":82,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/webappsec/pulls/391"},"html":{"href":"https://github.com/w3c/webappsec/pull/391"},"issue":{"href":"https://api.github.com/repos/w3c/webappsec/issues/391"},"comments":{"href":"https://api.github.com/repos/w3c/webappsec/issues/391/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/webappsec/pulls/391/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/webappsec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/webappsec/pulls/391/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/webappsec/statuses/9df8a3c5a88fc7b9da2c29e6f532c07ba0e8f456"}}}}