{"action":"opened","number":5,"pull_request":{"url":"https://api.github.com/repos/deis/workflow/pulls/5","id":50580301,"html_url":"https://github.com/deis/workflow/pull/5","diff_url":"https://github.com/deis/workflow/pull/5.diff","patch_url":"https://github.com/deis/workflow/pull/5.patch","issue_url":"https://api.github.com/repos/deis/workflow/issues/5","number":5,"state":"open","locked":false,"title":"[WIP] ref(controller): tons of breaking changes","user":{"login":"bacongobbler","id":1360539,"avatar_url":"https://avatars.githubusercontent.com/u/1360539?v=3","gravatar_id":"","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"body":"List of changes are as follows:\r\n\r\n - removed legacy web UI\r\n - added ADMIN_ENABLED flag for /admin endpoint\r\n - replaced confd with kubernetes service discovery (PoC)\r\n - removed LDAP auth (for now)\r\n - removed etcd data migrations (v2 = code cleanup)\r\n - docker client now reads DOCKER_URL via service discovery\r\n - refactored rootfs to reflect final filesystem layout\r\n\r\nTODO:\r\n\r\n - remove database schema migrations, start from clean slate\r\n - fix up scheduler tests to use scheduler.mock\r\n - add back LDAP auth if user opts in\r\n - fix tests\r\n - m0ar cleanup\r\n\r\nMain motivation for removing confd entirely is so that the controller can take over PID 1 after we're done all the database migrations. That way we don't require all that `trap` logic. However that means we won't have a way to configure LDAP auth on the fly, which may or may not be important.","created_at":"2015-11-12T22:51:31Z","updated_at":"2015-11-12T22:51:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7560ac9d0437f724c08ce57292a99fb248e4e8e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/deis/workflow/pulls/5/commits","review_comments_url":"https://api.github.com/repos/deis/workflow/pulls/5/comments","review_comment_url":"https://api.github.com/repos/deis/workflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deis/workflow/issues/5/comments","statuses_url":"https://api.github.com/repos/deis/workflow/statuses/800bc2db02db46a161f443057cc5fb0abee00605","head":{"label":"bacongobbler:refactor-confd-controller","ref":"refactor-confd-controller","sha":"800bc2db02db46a161f443057cc5fb0abee00605","user":{"login":"bacongobbler","id":1360539,"avatar_url":"https://avatars.githubusercontent.com/u/1360539?v=3","gravatar_id":"","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"repo":{"id":46071766,"name":"workflow","full_name":"bacongobbler/workflow","owner":{"login":"bacongobbler","id":1360539,"avatar_url":"https://avatars.githubusercontent.com/u/1360539?v=3","gravatar_id":"","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bacongobbler/workflow","description":"PaaS workflow controller and client for Deis v2","fork":true,"url":"https://api.github.com/repos/bacongobbler/workflow","forks_url":"https://api.github.com/repos/bacongobbler/workflow/forks","keys_url":"https://api.github.com/repos/bacongobbler/workflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bacongobbler/workflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bacongobbler/workflow/teams","hooks_url":"https://api.github.com/repos/bacongobbler/workflow/hooks","issue_events_url":"https://api.github.com/repos/bacongobbler/workflow/issues/events{/number}","events_url":"https://api.github.com/repos/bacongobbler/workflow/events","assignees_url":"https://api.github.com/repos/bacongobbler/workflow/assignees{/user}","branches_url":"https://api.github.com/repos/bacongobbler/workflow/branches{/branch}","tags_url":"https://api.github.com/repos/bacongobbler/workflow/tags","blobs_url":"https://api.github.com/repos/bacongobbler/workflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bacongobbler/workflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bacongobbler/workflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/bacongobbler/workflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bacongobbler/workflow/statuses/{sha}","languages_url":"https://api.github.com/repos/bacongobbler/workflow/languages","stargazers_url":"https://api.github.com/repos/bacongobbler/workflow/stargazers","contributors_url":"https://api.github.com/repos/bacongobbler/workflow/contributors","subscribers_url":"https://api.github.com/repos/bacongobbler/workflow/subscribers","subscription_url":"https://api.github.com/repos/bacongobbler/workflow/subscription","commits_url":"https://api.github.com/repos/bacongobbler/workflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/bacongobbler/workflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/bacongobbler/workflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/bacongobbler/workflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/bacongobbler/workflow/contents/{+path}","compare_url":"https://api.github.com/repos/bacongobbler/workflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bacongobbler/workflow/merges","archive_url":"https://api.github.com/repos/bacongobbler/workflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bacongobbler/workflow/downloads","issues_url":"https://api.github.com/repos/bacongobbler/workflow/issues{/number}","pulls_url":"https://api.github.com/repos/bacongobbler/workflow/pulls{/number}","milestones_url":"https://api.github.com/repos/bacongobbler/workflow/milestones{/number}","notifications_url":"https://api.github.com/repos/bacongobbler/workflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bacongobbler/workflow/labels{/name}","releases_url":"https://api.github.com/repos/bacongobbler/workflow/releases{/id}","created_at":"2015-11-12T18:19:50Z","updated_at":"2015-11-12T18:19:53Z","pushed_at":"2015-11-12T22:51:25Z","git_url":"git://github.com/bacongobbler/workflow.git","ssh_url":"git@github.com:bacongobbler/workflow.git","clone_url":"https://github.com/bacongobbler/workflow.git","svn_url":"https://github.com/bacongobbler/workflow","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"8ed73db9cfaea9c48c985e298c0eb26c733b90bc","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":45704630,"name":"workflow","full_name":"deis/workflow","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/workflow","description":"PaaS workflow controller and client for Deis v2","fork":false,"url":"https://api.github.com/repos/deis/workflow","forks_url":"https://api.github.com/repos/deis/workflow/forks","keys_url":"https://api.github.com/repos/deis/workflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/workflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/workflow/teams","hooks_url":"https://api.github.com/repos/deis/workflow/hooks","issue_events_url":"https://api.github.com/repos/deis/workflow/issues/events{/number}","events_url":"https://api.github.com/repos/deis/workflow/events","assignees_url":"https://api.github.com/repos/deis/workflow/assignees{/user}","branches_url":"https://api.github.com/repos/deis/workflow/branches{/branch}","tags_url":"https://api.github.com/repos/deis/workflow/tags","blobs_url":"https://api.github.com/repos/deis/workflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/workflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/workflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/workflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/workflow/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/workflow/languages","stargazers_url":"https://api.github.com/repos/deis/workflow/stargazers","contributors_url":"https://api.github.com/repos/deis/workflow/contributors","subscribers_url":"https://api.github.com/repos/deis/workflow/subscribers","subscription_url":"https://api.github.com/repos/deis/workflow/subscription","commits_url":"https://api.github.com/repos/deis/workflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/workflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/workflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/workflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/deis/workflow/contents/{+path}","compare_url":"https://api.github.com/repos/deis/workflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/workflow/merges","archive_url":"https://api.github.com/repos/deis/workflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/workflow/downloads","issues_url":"https://api.github.com/repos/deis/workflow/issues{/number}","pulls_url":"https://api.github.com/repos/deis/workflow/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/workflow/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/workflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/workflow/labels{/name}","releases_url":"https://api.github.com/repos/deis/workflow/releases{/id}","created_at":"2015-11-06T20:06:05Z","updated_at":"2015-11-11T04:41:18Z","pushed_at":"2015-11-12T22:51:31Z","git_url":"git://github.com/deis/workflow.git","ssh_url":"git@github.com:deis/workflow.git","clone_url":"https://github.com/deis/workflow.git","svn_url":"https://github.com/deis/workflow","homepage":null,"size":0,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/workflow/pulls/5"},"html":{"href":"https://github.com/deis/workflow/pull/5"},"issue":{"href":"https://api.github.com/repos/deis/workflow/issues/5"},"comments":{"href":"https://api.github.com/repos/deis/workflow/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/workflow/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/workflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deis/workflow/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/deis/workflow/statuses/800bc2db02db46a161f443057cc5fb0abee00605"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":53,"deletions":2462,"changed_files":137}}