{"action":"created","comment":{"url":"https://api.github.com/repos/maxeler/maxpower/pulls/comments/45622083","id":45622083,"diff_hunk":"@@ -35,14 +35,14 @@ public class VariableWidthIO extends KernelLib {\n \tpublic <T extends KernelObjectVectorizable<T,?>> DFEVector<T> input(String name, DFEVectorType<T> wideInputType, DFEVar numToRead) {\n \t\tint maxWidth = wideInputType.getSize();\n \t\tint shiftBits = MathUtils.bitsToAddress(maxWidth);\n+\t\tDFEType shiftType = dfeUInt(shiftBits);\n \t\tDFEType doubleShiftType = dfeUInt(shiftBits + 1);","path":"src/maxpower/kernel/io/VariableWidthIO.maxj","position":5,"original_position":5,"commit_id":"f693a178f3b6d87932cf176b9479cbd873c50838","original_commit_id":"f693a178f3b6d87932cf176b9479cbd873c50838","user":{"login":"stepeh","id":12087956,"avatar_url":"https://avatars.githubusercontent.com/u/12087956?v=3","gravatar_id":"","url":"https://api.github.com/users/stepeh","html_url":"https://github.com/stepeh","followers_url":"https://api.github.com/users/stepeh/followers","following_url":"https://api.github.com/users/stepeh/following{/other_user}","gists_url":"https://api.github.com/users/stepeh/gists{/gist_id}","starred_url":"https://api.github.com/users/stepeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stepeh/subscriptions","organizations_url":"https://api.github.com/users/stepeh/orgs","repos_url":"https://api.github.com/users/stepeh/repos","events_url":"https://api.github.com/users/stepeh/events{/privacy}","received_events_url":"https://api.github.com/users/stepeh/received_events","type":"User","site_admin":false},"body":"Since we don't do a double wide shift, this isn't a great name. Maybe carryType or something.","created_at":"2015-11-23T16:12:35Z","updated_at":"2015-11-23T16:12:35Z","html_url":"https://github.com/maxeler/maxpower/pull/37#discussion_r45622083","pull_request_url":"https://api.github.com/repos/maxeler/maxpower/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/maxeler/maxpower/pulls/comments/45622083"},"html":{"href":"https://github.com/maxeler/maxpower/pull/37#discussion_r45622083"},"pull_request":{"href":"https://api.github.com/repos/maxeler/maxpower/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/maxeler/maxpower/pulls/37","id":50668328,"html_url":"https://github.com/maxeler/maxpower/pull/37","diff_url":"https://github.com/maxeler/maxpower/pull/37.diff","patch_url":"https://github.com/maxeler/maxpower/pull/37.patch","issue_url":"https://api.github.com/repos/maxeler/maxpower/issues/37","number":37,"state":"open","locked":false,"title":"added output to VariableWidthIO","user":{"login":"dpackwood","id":13117660,"avatar_url":"https://avatars.githubusercontent.com/u/13117660?v=3","gravatar_id":"","url":"https://api.github.com/users/dpackwood","html_url":"https://github.com/dpackwood","followers_url":"https://api.github.com/users/dpackwood/followers","following_url":"https://api.github.com/users/dpackwood/following{/other_user}","gists_url":"https://api.github.com/users/dpackwood/gists{/gist_id}","starred_url":"https://api.github.com/users/dpackwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpackwood/subscriptions","organizations_url":"https://api.github.com/users/dpackwood/orgs","repos_url":"https://api.github.com/users/dpackwood/repos","events_url":"https://api.github.com/users/dpackwood/events{/privacy}","received_events_url":"https://api.github.com/users/dpackwood/received_events","type":"User","site_admin":false},"body":"added output and corresponding tests to VariableWidth IO, reworked some other tests a little bit also","created_at":"2015-11-13T17:31:09Z","updated_at":"2015-11-23T16:12:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c96bc89129a022f496c6489fa61a32a68abd45f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/maxeler/maxpower/pulls/37/commits","review_comments_url":"https://api.github.com/repos/maxeler/maxpower/pulls/37/comments","review_comment_url":"https://api.github.com/repos/maxeler/maxpower/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maxeler/maxpower/issues/37/comments","statuses_url":"https://api.github.com/repos/maxeler/maxpower/statuses/f693a178f3b6d87932cf176b9479cbd873c50838","head":{"label":"dpackwood:master","ref":"master","sha":"f693a178f3b6d87932cf176b9479cbd873c50838","user":{"login":"dpackwood","id":13117660,"avatar_url":"https://avatars.githubusercontent.com/u/13117660?v=3","gravatar_id":"","url":"https://api.github.com/users/dpackwood","html_url":"https://github.com/dpackwood","followers_url":"https://api.github.com/users/dpackwood/followers","following_url":"https://api.github.com/users/dpackwood/following{/other_user}","gists_url":"https://api.github.com/users/dpackwood/gists{/gist_id}","starred_url":"https://api.github.com/users/dpackwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpackwood/subscriptions","organizations_url":"https://api.github.com/users/dpackwood/orgs","repos_url":"https://api.github.com/users/dpackwood/repos","events_url":"https://api.github.com/users/dpackwood/events{/privacy}","received_events_url":"https://api.github.com/users/dpackwood/received_events","type":"User","site_admin":false},"repo":{"id":43893860,"name":"maxpower","full_name":"dpackwood/maxpower","owner":{"login":"dpackwood","id":13117660,"avatar_url":"https://avatars.githubusercontent.com/u/13117660?v=3","gravatar_id":"","url":"https://api.github.com/users/dpackwood","html_url":"https://github.com/dpackwood","followers_url":"https://api.github.com/users/dpackwood/followers","following_url":"https://api.github.com/users/dpackwood/following{/other_user}","gists_url":"https://api.github.com/users/dpackwood/gists{/gist_id}","starred_url":"https://api.github.com/users/dpackwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpackwood/subscriptions","organizations_url":"https://api.github.com/users/dpackwood/orgs","repos_url":"https://api.github.com/users/dpackwood/repos","events_url":"https://api.github.com/users/dpackwood/events{/privacy}","received_events_url":"https://api.github.com/users/dpackwood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpackwood/maxpower","description":"Maxeler standard library","fork":true,"url":"https://api.github.com/repos/dpackwood/maxpower","forks_url":"https://api.github.com/repos/dpackwood/maxpower/forks","keys_url":"https://api.github.com/repos/dpackwood/maxpower/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpackwood/maxpower/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpackwood/maxpower/teams","hooks_url":"https://api.github.com/repos/dpackwood/maxpower/hooks","issue_events_url":"https://api.github.com/repos/dpackwood/maxpower/issues/events{/number}","events_url":"https://api.github.com/repos/dpackwood/maxpower/events","assignees_url":"https://api.github.com/repos/dpackwood/maxpower/assignees{/user}","branches_url":"https://api.github.com/repos/dpackwood/maxpower/branches{/branch}","tags_url":"https://api.github.com/repos/dpackwood/maxpower/tags","blobs_url":"https://api.github.com/repos/dpackwood/maxpower/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpackwood/maxpower/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpackwood/maxpower/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpackwood/maxpower/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpackwood/maxpower/statuses/{sha}","languages_url":"https://api.github.com/repos/dpackwood/maxpower/languages","stargazers_url":"https://api.github.com/repos/dpackwood/maxpower/stargazers","contributors_url":"https://api.github.com/repos/dpackwood/maxpower/contributors","subscribers_url":"https://api.github.com/repos/dpackwood/maxpower/subscribers","subscription_url":"https://api.github.com/repos/dpackwood/maxpower/subscription","commits_url":"https://api.github.com/repos/dpackwood/maxpower/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpackwood/maxpower/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpackwood/maxpower/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpackwood/maxpower/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpackwood/maxpower/contents/{+path}","compare_url":"https://api.github.com/repos/dpackwood/maxpower/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpackwood/maxpower/merges","archive_url":"https://api.github.com/repos/dpackwood/maxpower/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpackwood/maxpower/downloads","issues_url":"https://api.github.com/repos/dpackwood/maxpower/issues{/number}","pulls_url":"https://api.github.com/repos/dpackwood/maxpower/pulls{/number}","milestones_url":"https://api.github.com/repos/dpackwood/maxpower/milestones{/number}","notifications_url":"https://api.github.com/repos/dpackwood/maxpower/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpackwood/maxpower/labels{/name}","releases_url":"https://api.github.com/repos/dpackwood/maxpower/releases{/id}","created_at":"2015-10-08T14:24:44Z","updated_at":"2015-10-08T14:24:45Z","pushed_at":"2015-11-18T16:40:16Z","git_url":"git://github.com/dpackwood/maxpower.git","ssh_url":"git@github.com:dpackwood/maxpower.git","clone_url":"https://github.com/dpackwood/maxpower.git","svn_url":"https://github.com/dpackwood/maxpower","homepage":null,"size":796,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maxeler:master","ref":"master","sha":"4ce9d7b463451520fd94e848ba0f8e02f771b6e6","user":{"login":"maxeler","id":10088478,"avatar_url":"https://avatars.githubusercontent.com/u/10088478?v=3","gravatar_id":"","url":"https://api.github.com/users/maxeler","html_url":"https://github.com/maxeler","followers_url":"https://api.github.com/users/maxeler/followers","following_url":"https://api.github.com/users/maxeler/following{/other_user}","gists_url":"https://api.github.com/users/maxeler/gists{/gist_id}","starred_url":"https://api.github.com/users/maxeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxeler/subscriptions","organizations_url":"https://api.github.com/users/maxeler/orgs","repos_url":"https://api.github.com/users/maxeler/repos","events_url":"https://api.github.com/users/maxeler/events{/privacy}","received_events_url":"https://api.github.com/users/maxeler/received_events","type":"Organization","site_admin":false},"repo":{"id":27921920,"name":"maxpower","full_name":"maxeler/maxpower","owner":{"login":"maxeler","id":10088478,"avatar_url":"https://avatars.githubusercontent.com/u/10088478?v=3","gravatar_id":"","url":"https://api.github.com/users/maxeler","html_url":"https://github.com/maxeler","followers_url":"https://api.github.com/users/maxeler/followers","following_url":"https://api.github.com/users/maxeler/following{/other_user}","gists_url":"https://api.github.com/users/maxeler/gists{/gist_id}","starred_url":"https://api.github.com/users/maxeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxeler/subscriptions","organizations_url":"https://api.github.com/users/maxeler/orgs","repos_url":"https://api.github.com/users/maxeler/repos","events_url":"https://api.github.com/users/maxeler/events{/privacy}","received_events_url":"https://api.github.com/users/maxeler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/maxeler/maxpower","description":"Maxeler standard library","fork":false,"url":"https://api.github.com/repos/maxeler/maxpower","forks_url":"https://api.github.com/repos/maxeler/maxpower/forks","keys_url":"https://api.github.com/repos/maxeler/maxpower/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxeler/maxpower/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxeler/maxpower/teams","hooks_url":"https://api.github.com/repos/maxeler/maxpower/hooks","issue_events_url":"https://api.github.com/repos/maxeler/maxpower/issues/events{/number}","events_url":"https://api.github.com/repos/maxeler/maxpower/events","assignees_url":"https://api.github.com/repos/maxeler/maxpower/assignees{/user}","branches_url":"https://api.github.com/repos/maxeler/maxpower/branches{/branch}","tags_url":"https://api.github.com/repos/maxeler/maxpower/tags","blobs_url":"https://api.github.com/repos/maxeler/maxpower/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxeler/maxpower/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxeler/maxpower/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxeler/maxpower/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxeler/maxpower/statuses/{sha}","languages_url":"https://api.github.com/repos/maxeler/maxpower/languages","stargazers_url":"https://api.github.com/repos/maxeler/maxpower/stargazers","contributors_url":"https://api.github.com/repos/maxeler/maxpower/contributors","subscribers_url":"https://api.github.com/repos/maxeler/maxpower/subscribers","subscription_url":"https://api.github.com/repos/maxeler/maxpower/subscription","commits_url":"https://api.github.com/repos/maxeler/maxpower/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxeler/maxpower/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxeler/maxpower/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxeler/maxpower/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxeler/maxpower/contents/{+path}","compare_url":"https://api.github.com/repos/maxeler/maxpower/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxeler/maxpower/merges","archive_url":"https://api.github.com/repos/maxeler/maxpower/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxeler/maxpower/downloads","issues_url":"https://api.github.com/repos/maxeler/maxpower/issues{/number}","pulls_url":"https://api.github.com/repos/maxeler/maxpower/pulls{/number}","milestones_url":"https://api.github.com/repos/maxeler/maxpower/milestones{/number}","notifications_url":"https://api.github.com/repos/maxeler/maxpower/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxeler/maxpower/labels{/name}","releases_url":"https://api.github.com/repos/maxeler/maxpower/releases{/id}","created_at":"2014-12-12T13:40:35Z","updated_at":"2015-10-13T09:44:13Z","pushed_at":"2015-11-23T15:34:36Z","git_url":"git://github.com/maxeler/maxpower.git","ssh_url":"git@github.com:maxeler/maxpower.git","clone_url":"https://github.com/maxeler/maxpower.git","svn_url":"https://github.com/maxeler/maxpower","homepage":null,"size":2668,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":12,"forks":7,"open_issues":12,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maxeler/maxpower/pulls/37"},"html":{"href":"https://github.com/maxeler/maxpower/pull/37"},"issue":{"href":"https://api.github.com/repos/maxeler/maxpower/issues/37"},"comments":{"href":"https://api.github.com/repos/maxeler/maxpower/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/maxeler/maxpower/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/maxeler/maxpower/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maxeler/maxpower/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/maxeler/maxpower/statuses/f693a178f3b6d87932cf176b9479cbd873c50838"}}}}