{"action":"created","issue":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/2546","labels_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/2546/labels{/name}","comments_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/2546/comments","events_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/2546/events","html_url":"https://github.com/OpenRCT2/OpenRCT2/pull/2546","id":123693459,"number":2546,"title":"Proper font support for Linux and OS X","user":{"login":"AaronVanGeffen","id":604665,"avatar_url":"https://avatars.githubusercontent.com/u/604665?v=3","gravatar_id":"","url":"https://api.github.com/users/AaronVanGeffen","html_url":"https://github.com/AaronVanGeffen","followers_url":"https://api.github.com/users/AaronVanGeffen/followers","following_url":"https://api.github.com/users/AaronVanGeffen/following{/other_user}","gists_url":"https://api.github.com/users/AaronVanGeffen/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronVanGeffen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronVanGeffen/subscriptions","organizations_url":"https://api.github.com/users/AaronVanGeffen/orgs","repos_url":"https://api.github.com/users/AaronVanGeffen/repos","events_url":"https://api.github.com/users/AaronVanGeffen/events{/privacy}","received_events_url":"https://api.github.com/users/AaronVanGeffen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/labels/pending%20improvement","name":"pending improvement","color":"fbca04"},{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/labels/testing%20required","name":"testing required","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-12-23T17:11:06Z","updated_at":"2015-12-25T16:17:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/pulls/2546","html_url":"https://github.com/OpenRCT2/OpenRCT2/pull/2546","diff_url":"https://github.com/OpenRCT2/OpenRCT2/pull/2546.diff","patch_url":"https://github.com/OpenRCT2/OpenRCT2/pull/2546.patch"},"body":"This introduces proper font support for both Linux and OS X through the use of FontConfig.\r\n\r\nFontConfig is pretty standard on Linux, but on OS X it will need to be installed through e.g. Homebrew. For this reason, it may be better to replace it with an Objective-C implementation. I know nothing about Cocoa, though -- maybe someone else would like to pick that up?\r\n\r\nAs FontConfig makes use of a font's real name instead of a filename, I have amended the `TTFFontDescriptor` struct to contain names as well.\r\n\r\nI don't know what the conventions are regarding `cmake`, but I may have put the FontConfig dependency in the wrong place. It works as is, however.\r\n\r\nFor Windows, this means the existing implementation is pretty much retained as it was -- the relevant bits have just been moved to `windows.c` instead."},"comment":{"url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/comments/167248383","html_url":"https://github.com/OpenRCT2/OpenRCT2/pull/2546#issuecomment-167248383","issue_url":"https://api.github.com/repos/OpenRCT2/OpenRCT2/issues/2546","id":167248383,"user":{"login":"AaronVanGeffen","id":604665,"avatar_url":"https://avatars.githubusercontent.com/u/604665?v=3","gravatar_id":"","url":"https://api.github.com/users/AaronVanGeffen","html_url":"https://github.com/AaronVanGeffen","followers_url":"https://api.github.com/users/AaronVanGeffen/followers","following_url":"https://api.github.com/users/AaronVanGeffen/following{/other_user}","gists_url":"https://api.github.com/users/AaronVanGeffen/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronVanGeffen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronVanGeffen/subscriptions","organizations_url":"https://api.github.com/users/AaronVanGeffen/orgs","repos_url":"https://api.github.com/users/AaronVanGeffen/repos","events_url":"https://api.github.com/users/AaronVanGeffen/events{/privacy}","received_events_url":"https://api.github.com/users/AaronVanGeffen/received_events","type":"User","site_admin":false},"created_at":"2015-12-25T16:17:24Z","updated_at":"2015-12-25T16:17:24Z","body":"The hack sounds like a good compromise -- I agree it would be a shame to lose MINGW compatibility over something like this. eda7331 introduces one that can easily be removed if/when MINGW introduces the API in their compiler. Looks like Travis is happy now, too.\r\n\r\nOn an unrelated note: Merry Christmas, everyone."}}