{"action":"created","issue":{"url":"https://api.github.com/repos/matthieugrieger/mumbledj/issues/100","labels_url":"https://api.github.com/repos/matthieugrieger/mumbledj/issues/100/labels{/name}","comments_url":"https://api.github.com/repos/matthieugrieger/mumbledj/issues/100/comments","events_url":"https://api.github.com/repos/matthieugrieger/mumbledj/issues/100/events","html_url":"https://github.com/matthieugrieger/mumbledj/pull/100","id":117762915,"number":100,"title":"Use config vars instead of env vars","user":{"login":"Gamah","id":8608532,"avatar_url":"https://avatars.githubusercontent.com/u/8608532?v=3","gravatar_id":"","url":"https://api.github.com/users/Gamah","html_url":"https://github.com/Gamah","followers_url":"https://api.github.com/users/Gamah/followers","following_url":"https://api.github.com/users/Gamah/following{/other_user}","gists_url":"https://api.github.com/users/Gamah/gists{/gist_id}","starred_url":"https://api.github.com/users/Gamah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gamah/subscriptions","organizations_url":"https://api.github.com/users/Gamah/orgs","repos_url":"https://api.github.com/users/Gamah/repos","events_url":"https://api.github.com/users/Gamah/events{/privacy}","received_events_url":"https://api.github.com/users/Gamah/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/matthieugrieger/mumbledj/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-11-19T08:07:23Z","updated_at":"2015-11-19T23:33:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/matthieugrieger/mumbledj/pulls/100","html_url":"https://github.com/matthieugrieger/mumbledj/pull/100","diff_url":"https://github.com/matthieugrieger/mumbledj/pull/100.diff","patch_url":"https://github.com/matthieugrieger/mumbledj/pull/100.patch"},"body":"Felt compelled to clean this up, if you're interested."},"comment":{"url":"https://api.github.com/repos/matthieugrieger/mumbledj/issues/comments/158233896","html_url":"https://github.com/matthieugrieger/mumbledj/pull/100#issuecomment-158233896","issue_url":"https://api.github.com/repos/matthieugrieger/mumbledj/issues/100","id":158233896,"user":{"login":"Gamah","id":8608532,"avatar_url":"https://avatars.githubusercontent.com/u/8608532?v=3","gravatar_id":"","url":"https://api.github.com/users/Gamah","html_url":"https://github.com/Gamah","followers_url":"https://api.github.com/users/Gamah/followers","following_url":"https://api.github.com/users/Gamah/following{/other_user}","gists_url":"https://api.github.com/users/Gamah/gists{/gist_id}","starred_url":"https://api.github.com/users/Gamah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gamah/subscriptions","organizations_url":"https://api.github.com/users/Gamah/orgs","repos_url":"https://api.github.com/users/Gamah/repos","events_url":"https://api.github.com/users/Gamah/events{/privacy}","received_events_url":"https://api.github.com/users/Gamah/received_events","type":"User","site_admin":false},"created_at":"2015-11-19T23:33:07Z","updated_at":"2015-11-19T23:33:07Z","body":"I suppose I tried too hard to explain the third point. The gist of it is if there's no env vars, the new config file will be generated with neither key set, but of course this is only after backing up the existing file.\r\n\r\nThe only issue I could predict is someone removing their API key env vars before first pulling down these changes and running a make install, though I'd argue any user competent enough to understand the changes well enough to do that is probably also equipped enough to go ahead and move them to their config file as well.\r\n\r\ntl;dr: Don't remove your env vars unless you know what you're doing.\r\n\r\nI appreciate your reconsideration, and will now poke around the refactoring branch too! Golang looks interesting and this is a lovely project."}}