{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/chronicle/issues/232","labels_url":"https://api.github.com/repos/mozilla/chronicle/issues/232/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/chronicle/issues/232/comments","events_url":"https://api.github.com/repos/mozilla/chronicle/issues/232/events","html_url":"https://github.com/mozilla/chronicle/pull/232","id":56084245,"number":232,"title":"WIP: send welcome email","user":{"login":"pdehaan","id":557895,"avatar_url":"https://avatars.githubusercontent.com/u/557895?v=3","gravatar_id":"","url":"https://api.github.com/users/pdehaan","html_url":"https://github.com/pdehaan","followers_url":"https://api.github.com/users/pdehaan/followers","following_url":"https://api.github.com/users/pdehaan/following{/other_user}","gists_url":"https://api.github.com/users/pdehaan/gists{/gist_id}","starred_url":"https://api.github.com/users/pdehaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdehaan/subscriptions","organizations_url":"https://api.github.com/users/pdehaan/orgs","repos_url":"https://api.github.com/users/pdehaan/repos","events_url":"https://api.github.com/users/pdehaan/events{/privacy}","received_events_url":"https://api.github.com/users/pdehaan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/chronicle/labels/question","name":"question","color":"cc317c"},{"url":"https://api.github.com/repos/mozilla/chronicle/labels/server","name":"server","color":"207de5"},{"url":"https://api.github.com/repos/mozilla/chronicle/labels/WIP","name":"WIP","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-01-30T21:01:46Z","updated_at":"2015-01-30T22:59:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/chronicle/pulls/232","html_url":"https://github.com/mozilla/chronicle/pull/232","diff_url":"https://github.com/mozilla/chronicle/pull/232.diff","patch_url":"https://github.com/mozilla/chronicle/pull/232.patch"},"body":"Questions:\r\n- [**sendmail**](https://www.npmjs.com/package/sendmail) vs [**nodemailer**](https://www.npmjs.com/package/nodemailer) -- It looks like nodemailer has support for different transport options (such as Amazon SES via [**nodemailer-ses-transport**](https://github.com/andris9/nodemailer-ses-transport)), plugins (DKIM), HTML+plaintext...\r\n- When should we use SES vs just SMTP? Currently just has a big `if (config.get('env') === 'local') {...}` block, but not sure if we should use SMTP when `env` is \"test\".\r\n- There has to be a better way of doing templates than my hacky thing of using `_.template` (since we were already requiring underscore in package.json). Not sure if we should be using Handlebars or something else. I need to dig into what content/auth server is doing to see if there is a more official way.\r\n- Should we have different queue tasks for welcome emails vs other emails, or just switch statements in the server/work-queue/jobs/send-email.js to say `if (o.type === 'welcome') {...}` versus just having specific jobs like \"send-welcome-email.js\"."},"comment":{"url":"https://api.github.com/repos/mozilla/chronicle/issues/comments/72285691","html_url":"https://github.com/mozilla/chronicle/pull/232#issuecomment-72285691","issue_url":"https://api.github.com/repos/mozilla/chronicle/issues/232","id":72285691,"user":{"login":"6a68","id":96396,"avatar_url":"https://avatars.githubusercontent.com/u/96396?v=3","gravatar_id":"","url":"https://api.github.com/users/6a68","html_url":"https://github.com/6a68","followers_url":"https://api.github.com/users/6a68/followers","following_url":"https://api.github.com/users/6a68/following{/other_user}","gists_url":"https://api.github.com/users/6a68/gists{/gist_id}","starred_url":"https://api.github.com/users/6a68/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/6a68/subscriptions","organizations_url":"https://api.github.com/users/6a68/orgs","repos_url":"https://api.github.com/users/6a68/repos","events_url":"https://api.github.com/users/6a68/events{/privacy}","received_events_url":"https://api.github.com/users/6a68/received_events","type":"User","site_admin":false},"created_at":"2015-01-30T22:59:35Z","updated_at":"2015-01-30T22:59:35Z","body":"@pdehaan looks great, works for me, feel free to rebase + merge"}}