{"action":"created","comment":{"url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/comments/25092580","id":25092580,"diff_hunk":"@@ -122,10 +126,8 @@ def do_install(self, install_type):\n                     self.MultiInstallNewMaas(\n                         self.loop, self.ui, self.config).run()\n             else:\n-                self.ui.set_openstack_rel(\"Icehouse (2014.1.3)\")","path":"cloudinstall/install.py","position":24,"original_position":24,"commit_id":"90e3ee0985ca73bb6ddc7ae15b2440d12a322d88","original_commit_id":"90e3ee0985ca73bb6ddc7ae15b2440d12a322d88","user":{"login":"mikemccracken","id":1768106,"avatar_url":"https://avatars.githubusercontent.com/u/1768106?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemccracken","html_url":"https://github.com/mikemccracken","followers_url":"https://api.github.com/users/mikemccracken/followers","following_url":"https://api.github.com/users/mikemccracken/following{/other_user}","gists_url":"https://api.github.com/users/mikemccracken/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemccracken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemccracken/subscriptions","organizations_url":"https://api.github.com/users/mikemccracken/orgs","repos_url":"https://api.github.com/users/mikemccracken/repos","events_url":"https://api.github.com/users/mikemccracken/events{/privacy}","received_events_url":"https://api.github.com/users/mikemccracken/received_events","type":"User","site_admin":false},"body":"it looks like @battlemidget  didn't want to call ui.set_openstack_rel when headless==true. if that's the case, maybe we shouldn't move it up above? I'll let him comment…","created_at":"2015-02-20T18:50:57Z","updated_at":"2015-02-20T18:50:57Z","html_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer/pull/409#discussion_r25092580","pull_request_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/409","_links":{"self":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/comments/25092580"},"html":{"href":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer/pull/409#discussion_r25092580"},"pull_request":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/409"}}},"pull_request":{"url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/409","id":29720118,"html_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer/pull/409","diff_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer/pull/409.diff","patch_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer/pull/409.patch","issue_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues/409","number":409,"state":"open","locked":false,"title":"Openstack release cleanup","user":{"login":"jamesbeedy","id":5590546,"avatar_url":"https://avatars.githubusercontent.com/u/5590546?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesbeedy","html_url":"https://github.com/jamesbeedy","followers_url":"https://api.github.com/users/jamesbeedy/followers","following_url":"https://api.github.com/users/jamesbeedy/following{/other_user}","gists_url":"https://api.github.com/users/jamesbeedy/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesbeedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesbeedy/subscriptions","organizations_url":"https://api.github.com/users/jamesbeedy/orgs","repos_url":"https://api.github.com/users/jamesbeedy/repos","events_url":"https://api.github.com/users/jamesbeedy/events{/privacy}","received_events_url":"https://api.github.com/users/jamesbeedy/received_events","type":"User","site_admin":false},"body":"Refactor how set_openstack_rel() is called, removed unneeded conditional in openstack-install. ","created_at":"2015-02-20T18:46:29Z","updated_at":"2015-02-20T18:50:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84c30d44c254080a7802be667b0f893392907ca7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/409/commits","review_comments_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/409/comments","review_comment_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues/409/comments","statuses_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/statuses/90e3ee0985ca73bb6ddc7ae15b2440d12a322d88","head":{"label":"jamesbeedy:master","ref":"master","sha":"90e3ee0985ca73bb6ddc7ae15b2440d12a322d88","user":{"login":"jamesbeedy","id":5590546,"avatar_url":"https://avatars.githubusercontent.com/u/5590546?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesbeedy","html_url":"https://github.com/jamesbeedy","followers_url":"https://api.github.com/users/jamesbeedy/followers","following_url":"https://api.github.com/users/jamesbeedy/following{/other_user}","gists_url":"https://api.github.com/users/jamesbeedy/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesbeedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesbeedy/subscriptions","organizations_url":"https://api.github.com/users/jamesbeedy/orgs","repos_url":"https://api.github.com/users/jamesbeedy/repos","events_url":"https://api.github.com/users/jamesbeedy/events{/privacy}","received_events_url":"https://api.github.com/users/jamesbeedy/received_events","type":"User","site_admin":false},"repo":{"id":31077727,"name":"openstack-installer","full_name":"jamesbeedy/openstack-installer","owner":{"login":"jamesbeedy","id":5590546,"avatar_url":"https://avatars.githubusercontent.com/u/5590546?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesbeedy","html_url":"https://github.com/jamesbeedy","followers_url":"https://api.github.com/users/jamesbeedy/followers","following_url":"https://api.github.com/users/jamesbeedy/following{/other_user}","gists_url":"https://api.github.com/users/jamesbeedy/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesbeedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesbeedy/subscriptions","organizations_url":"https://api.github.com/users/jamesbeedy/orgs","repos_url":"https://api.github.com/users/jamesbeedy/repos","events_url":"https://api.github.com/users/jamesbeedy/events{/privacy}","received_events_url":"https://api.github.com/users/jamesbeedy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamesbeedy/openstack-installer","description":"Ubuntu OpenStack Installer","fork":true,"url":"https://api.github.com/repos/jamesbeedy/openstack-installer","forks_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/forks","keys_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/teams","hooks_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/hooks","issue_events_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/issues/events{/number}","events_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/events","assignees_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/assignees{/user}","branches_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/branches{/branch}","tags_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/tags","blobs_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/languages","stargazers_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/stargazers","contributors_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/contributors","subscribers_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/subscribers","subscription_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/subscription","commits_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/issues/comments/{number}","contents_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/contents/{+path}","compare_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/merges","archive_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/downloads","issues_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/issues{/number}","pulls_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/labels{/name}","releases_url":"https://api.github.com/repos/jamesbeedy/openstack-installer/releases{/id}","created_at":"2015-02-20T18:11:04Z","updated_at":"2015-02-20T18:29:28Z","pushed_at":"2015-02-20T18:29:25Z","git_url":"git://github.com/jamesbeedy/openstack-installer.git","ssh_url":"git@github.com:jamesbeedy/openstack-installer.git","clone_url":"https://github.com/jamesbeedy/openstack-installer.git","svn_url":"https://github.com/jamesbeedy/openstack-installer","homepage":"http://j.mp/ubuntu-openstack-installer","size":7259,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ubuntu-Solutions-Engineering:master","ref":"master","sha":"ad578723dea4335aaa1960fca09ee1209bfc473b","user":{"login":"Ubuntu-Solutions-Engineering","id":6772632,"avatar_url":"https://avatars.githubusercontent.com/u/6772632?v=3","gravatar_id":"","url":"https://api.github.com/users/Ubuntu-Solutions-Engineering","html_url":"https://github.com/Ubuntu-Solutions-Engineering","followers_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/followers","following_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/following{/other_user}","gists_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/subscriptions","organizations_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/orgs","repos_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/repos","events_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/events{/privacy}","received_events_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/received_events","type":"Organization","site_admin":false},"repo":{"id":17140192,"name":"openstack-installer","full_name":"Ubuntu-Solutions-Engineering/openstack-installer","owner":{"login":"Ubuntu-Solutions-Engineering","id":6772632,"avatar_url":"https://avatars.githubusercontent.com/u/6772632?v=3","gravatar_id":"","url":"https://api.github.com/users/Ubuntu-Solutions-Engineering","html_url":"https://github.com/Ubuntu-Solutions-Engineering","followers_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/followers","following_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/following{/other_user}","gists_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/subscriptions","organizations_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/orgs","repos_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/repos","events_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/events{/privacy}","received_events_url":"https://api.github.com/users/Ubuntu-Solutions-Engineering/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer","description":"Ubuntu OpenStack Installer","fork":false,"url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer","forks_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/forks","keys_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/teams","hooks_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/hooks","issue_events_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues/events{/number}","events_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/events","assignees_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/assignees{/user}","branches_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/branches{/branch}","tags_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/tags","blobs_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/languages","stargazers_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/stargazers","contributors_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/contributors","subscribers_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/subscribers","subscription_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/subscription","commits_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues/comments/{number}","contents_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/contents/{+path}","compare_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/merges","archive_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/downloads","issues_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues{/number}","pulls_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/labels{/name}","releases_url":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/releases{/id}","created_at":"2014-02-24T15:17:19Z","updated_at":"2015-02-20T15:44:01Z","pushed_at":"2015-02-20T18:46:47Z","git_url":"git://github.com/Ubuntu-Solutions-Engineering/openstack-installer.git","ssh_url":"git@github.com:Ubuntu-Solutions-Engineering/openstack-installer.git","clone_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer.git","svn_url":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer","homepage":"http://j.mp/ubuntu-openstack-installer","size":7259,"stargazers_count":33,"watchers_count":33,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":29,"forks":19,"open_issues":29,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/409"},"html":{"href":"https://github.com/Ubuntu-Solutions-Engineering/openstack-installer/pull/409"},"issue":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues/409"},"comments":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/issues/409/comments"},"review_comments":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/409/comments"},"review_comment":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/pulls/409/commits"},"statuses":{"href":"https://api.github.com/repos/Ubuntu-Solutions-Engineering/openstack-installer/statuses/90e3ee0985ca73bb6ddc7ae15b2440d12a322d88"}}}}