{"action":"created","comment":{"url":"https://api.github.com/repos/gchp/iota/pulls/comments/22519749","id":22519749,"diff_hunk":"@@ -211,6 +247,40 @@ impl Buffer {\n \n }\n \n+fn is_alphanumeric_or_(c: char) -> bool {\n+    c.is_alphanumeric() || c == '_'\n+}\n+\n+impl WordEdgeMatch {\n+    /// If c1 -> c2 is the start of a word.\n+    /// If end of word matching is wanted then pass the chars in reversed.\n+    fn is_word_edge(&self, c1: &u8, c2: &u8) -> bool {\n+        match (self, char::from_u32(*c1 as u32).unwrap(), char::from_u32(*c2 as u32).unwrap()) {","path":"src/iota/buffer.rs","position":95,"original_position":95,"commit_id":"e2c7ce0ffb1601c1f838b03d4041e111bf2acbc8","original_commit_id":"e2c7ce0ffb1601c1f838b03d4041e111bf2acbc8","user":{"login":"gchp","id":1315394,"avatar_url":"https://avatars.githubusercontent.com/u/1315394?v=3","gravatar_id":"","url":"https://api.github.com/users/gchp","html_url":"https://github.com/gchp","followers_url":"https://api.github.com/users/gchp/followers","following_url":"https://api.github.com/users/gchp/following{/other_user}","gists_url":"https://api.github.com/users/gchp/gists{/gist_id}","starred_url":"https://api.github.com/users/gchp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchp/subscriptions","organizations_url":"https://api.github.com/users/gchp/orgs","repos_url":"https://api.github.com/users/gchp/repos","events_url":"https://api.github.com/users/gchp/events{/privacy}","received_events_url":"https://api.github.com/users/gchp/received_events","type":"User","site_admin":false},"body":"Yeah, our unicode support is broken right now. @P1start fixed it previously, but it broke when we converted Buffers to use a gapbuffer. There's a ticket here for fixing it: #69 ","created_at":"2015-01-06T11:55:06Z","updated_at":"2015-01-06T11:55:06Z","html_url":"https://github.com/gchp/iota/pull/76#discussion_r22519749","pull_request_url":"https://api.github.com/repos/gchp/iota/pulls/76","_links":{"self":{"href":"https://api.github.com/repos/gchp/iota/pulls/comments/22519749"},"html":{"href":"https://github.com/gchp/iota/pull/76#discussion_r22519749"},"pull_request":{"href":"https://api.github.com/repos/gchp/iota/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/gchp/iota/pulls/76","id":26778121,"html_url":"https://github.com/gchp/iota/pull/76","diff_url":"https://github.com/gchp/iota/pull/76.diff","patch_url":"https://github.com/gchp/iota/pull/76.patch","issue_url":"https://api.github.com/repos/gchp/iota/issues/76","number":76,"state":"open","locked":false,"title":"Word movement & deletion vi commands","user":{"login":"Nemo157","id":81079,"avatar_url":"https://avatars.githubusercontent.com/u/81079?v=3","gravatar_id":"","url":"https://api.github.com/users/Nemo157","html_url":"https://github.com/Nemo157","followers_url":"https://api.github.com/users/Nemo157/followers","following_url":"https://api.github.com/users/Nemo157/following{/other_user}","gists_url":"https://api.github.com/users/Nemo157/gists{/gist_id}","starred_url":"https://api.github.com/users/Nemo157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nemo157/subscriptions","organizations_url":"https://api.github.com/users/Nemo157/orgs","repos_url":"https://api.github.com/users/Nemo157/repos","events_url":"https://api.github.com/users/Nemo157/events{/privacy}","received_events_url":"https://api.github.com/users/Nemo157/received_events","type":"User","site_admin":false},"body":"Still slightly inconsistent with `vim` with deleting words at the end of a line/blank lines. Also I'm not very happy about using a boolean in the `Direction` enum for the different `vim` word matching types, thinking maybe adding another enum that defines the word edge matching might be the way to go. Would allow for adding in whatever emacs bindings there are for moving by word easily.\r\n\r\nSo, with those above caveats this is more of a review/discussion request than a serious pull request, yet.","created_at":"2015-01-03T02:06:43Z","updated_at":"2015-01-06T11:55:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2de3c5308a6f9ebac7921b3300400bfb6aa12076","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gchp/iota/pulls/76/commits","review_comments_url":"https://api.github.com/repos/gchp/iota/pulls/76/comments","review_comment_url":"https://api.github.com/repos/gchp/iota/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gchp/iota/issues/76/comments","statuses_url":"https://api.github.com/repos/gchp/iota/statuses/e2c7ce0ffb1601c1f838b03d4041e111bf2acbc8","head":{"label":"Nemo157:word_movement","ref":"word_movement","sha":"e2c7ce0ffb1601c1f838b03d4041e111bf2acbc8","user":{"login":"Nemo157","id":81079,"avatar_url":"https://avatars.githubusercontent.com/u/81079?v=3","gravatar_id":"","url":"https://api.github.com/users/Nemo157","html_url":"https://github.com/Nemo157","followers_url":"https://api.github.com/users/Nemo157/followers","following_url":"https://api.github.com/users/Nemo157/following{/other_user}","gists_url":"https://api.github.com/users/Nemo157/gists{/gist_id}","starred_url":"https://api.github.com/users/Nemo157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nemo157/subscriptions","organizations_url":"https://api.github.com/users/Nemo157/orgs","repos_url":"https://api.github.com/users/Nemo157/repos","events_url":"https://api.github.com/users/Nemo157/events{/privacy}","received_events_url":"https://api.github.com/users/Nemo157/received_events","type":"User","site_admin":false},"repo":{"id":28732034,"name":"iota","full_name":"Nemo157/iota","owner":{"login":"Nemo157","id":81079,"avatar_url":"https://avatars.githubusercontent.com/u/81079?v=3","gravatar_id":"","url":"https://api.github.com/users/Nemo157","html_url":"https://github.com/Nemo157","followers_url":"https://api.github.com/users/Nemo157/followers","following_url":"https://api.github.com/users/Nemo157/following{/other_user}","gists_url":"https://api.github.com/users/Nemo157/gists{/gist_id}","starred_url":"https://api.github.com/users/Nemo157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nemo157/subscriptions","organizations_url":"https://api.github.com/users/Nemo157/orgs","repos_url":"https://api.github.com/users/Nemo157/repos","events_url":"https://api.github.com/users/Nemo157/events{/privacy}","received_events_url":"https://api.github.com/users/Nemo157/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nemo157/iota","description":"A terminal-based text editor written in Rust","fork":true,"url":"https://api.github.com/repos/Nemo157/iota","forks_url":"https://api.github.com/repos/Nemo157/iota/forks","keys_url":"https://api.github.com/repos/Nemo157/iota/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nemo157/iota/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nemo157/iota/teams","hooks_url":"https://api.github.com/repos/Nemo157/iota/hooks","issue_events_url":"https://api.github.com/repos/Nemo157/iota/issues/events{/number}","events_url":"https://api.github.com/repos/Nemo157/iota/events","assignees_url":"https://api.github.com/repos/Nemo157/iota/assignees{/user}","branches_url":"https://api.github.com/repos/Nemo157/iota/branches{/branch}","tags_url":"https://api.github.com/repos/Nemo157/iota/tags","blobs_url":"https://api.github.com/repos/Nemo157/iota/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nemo157/iota/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nemo157/iota/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nemo157/iota/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nemo157/iota/statuses/{sha}","languages_url":"https://api.github.com/repos/Nemo157/iota/languages","stargazers_url":"https://api.github.com/repos/Nemo157/iota/stargazers","contributors_url":"https://api.github.com/repos/Nemo157/iota/contributors","subscribers_url":"https://api.github.com/repos/Nemo157/iota/subscribers","subscription_url":"https://api.github.com/repos/Nemo157/iota/subscription","commits_url":"https://api.github.com/repos/Nemo157/iota/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nemo157/iota/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nemo157/iota/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nemo157/iota/issues/comments/{number}","contents_url":"https://api.github.com/repos/Nemo157/iota/contents/{+path}","compare_url":"https://api.github.com/repos/Nemo157/iota/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nemo157/iota/merges","archive_url":"https://api.github.com/repos/Nemo157/iota/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nemo157/iota/downloads","issues_url":"https://api.github.com/repos/Nemo157/iota/issues{/number}","pulls_url":"https://api.github.com/repos/Nemo157/iota/pulls{/number}","milestones_url":"https://api.github.com/repos/Nemo157/iota/milestones{/number}","notifications_url":"https://api.github.com/repos/Nemo157/iota/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nemo157/iota/labels{/name}","releases_url":"https://api.github.com/repos/Nemo157/iota/releases{/id}","created_at":"2015-01-03T01:52:27Z","updated_at":"2015-01-03T01:52:29Z","pushed_at":"2015-01-04T07:53:15Z","git_url":"git://github.com/Nemo157/iota.git","ssh_url":"git@github.com:Nemo157/iota.git","clone_url":"https://github.com/Nemo157/iota.git","svn_url":"https://github.com/Nemo157/iota","homepage":"","size":1839,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gchp:master","ref":"master","sha":"680fd4a650b6eee20e785773d6ee3c00506d552c","user":{"login":"gchp","id":1315394,"avatar_url":"https://avatars.githubusercontent.com/u/1315394?v=3","gravatar_id":"","url":"https://api.github.com/users/gchp","html_url":"https://github.com/gchp","followers_url":"https://api.github.com/users/gchp/followers","following_url":"https://api.github.com/users/gchp/following{/other_user}","gists_url":"https://api.github.com/users/gchp/gists{/gist_id}","starred_url":"https://api.github.com/users/gchp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchp/subscriptions","organizations_url":"https://api.github.com/users/gchp/orgs","repos_url":"https://api.github.com/users/gchp/repos","events_url":"https://api.github.com/users/gchp/events{/privacy}","received_events_url":"https://api.github.com/users/gchp/received_events","type":"User","site_admin":false},"repo":{"id":24936564,"name":"iota","full_name":"gchp/iota","owner":{"login":"gchp","id":1315394,"avatar_url":"https://avatars.githubusercontent.com/u/1315394?v=3","gravatar_id":"","url":"https://api.github.com/users/gchp","html_url":"https://github.com/gchp","followers_url":"https://api.github.com/users/gchp/followers","following_url":"https://api.github.com/users/gchp/following{/other_user}","gists_url":"https://api.github.com/users/gchp/gists{/gist_id}","starred_url":"https://api.github.com/users/gchp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchp/subscriptions","organizations_url":"https://api.github.com/users/gchp/orgs","repos_url":"https://api.github.com/users/gchp/repos","events_url":"https://api.github.com/users/gchp/events{/privacy}","received_events_url":"https://api.github.com/users/gchp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gchp/iota","description":"A terminal-based text editor written in Rust","fork":false,"url":"https://api.github.com/repos/gchp/iota","forks_url":"https://api.github.com/repos/gchp/iota/forks","keys_url":"https://api.github.com/repos/gchp/iota/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gchp/iota/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gchp/iota/teams","hooks_url":"https://api.github.com/repos/gchp/iota/hooks","issue_events_url":"https://api.github.com/repos/gchp/iota/issues/events{/number}","events_url":"https://api.github.com/repos/gchp/iota/events","assignees_url":"https://api.github.com/repos/gchp/iota/assignees{/user}","branches_url":"https://api.github.com/repos/gchp/iota/branches{/branch}","tags_url":"https://api.github.com/repos/gchp/iota/tags","blobs_url":"https://api.github.com/repos/gchp/iota/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gchp/iota/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gchp/iota/git/refs{/sha}","trees_url":"https://api.github.com/repos/gchp/iota/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gchp/iota/statuses/{sha}","languages_url":"https://api.github.com/repos/gchp/iota/languages","stargazers_url":"https://api.github.com/repos/gchp/iota/stargazers","contributors_url":"https://api.github.com/repos/gchp/iota/contributors","subscribers_url":"https://api.github.com/repos/gchp/iota/subscribers","subscription_url":"https://api.github.com/repos/gchp/iota/subscription","commits_url":"https://api.github.com/repos/gchp/iota/commits{/sha}","git_commits_url":"https://api.github.com/repos/gchp/iota/git/commits{/sha}","comments_url":"https://api.github.com/repos/gchp/iota/comments{/number}","issue_comment_url":"https://api.github.com/repos/gchp/iota/issues/comments/{number}","contents_url":"https://api.github.com/repos/gchp/iota/contents/{+path}","compare_url":"https://api.github.com/repos/gchp/iota/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gchp/iota/merges","archive_url":"https://api.github.com/repos/gchp/iota/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gchp/iota/downloads","issues_url":"https://api.github.com/repos/gchp/iota/issues{/number}","pulls_url":"https://api.github.com/repos/gchp/iota/pulls{/number}","milestones_url":"https://api.github.com/repos/gchp/iota/milestones{/number}","notifications_url":"https://api.github.com/repos/gchp/iota/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gchp/iota/labels{/name}","releases_url":"https://api.github.com/repos/gchp/iota/releases{/id}","created_at":"2014-10-08T10:55:25Z","updated_at":"2015-01-06T11:35:15Z","pushed_at":"2015-01-06T11:35:15Z","git_url":"git://github.com/gchp/iota.git","ssh_url":"git@github.com:gchp/iota.git","clone_url":"https://github.com/gchp/iota.git","svn_url":"https://github.com/gchp/iota","homepage":"","size":1839,"stargazers_count":516,"watchers_count":516,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":21,"forks":24,"open_issues":21,"watchers":516,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gchp/iota/pulls/76"},"html":{"href":"https://github.com/gchp/iota/pull/76"},"issue":{"href":"https://api.github.com/repos/gchp/iota/issues/76"},"comments":{"href":"https://api.github.com/repos/gchp/iota/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/gchp/iota/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/gchp/iota/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gchp/iota/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/gchp/iota/statuses/e2c7ce0ffb1601c1f838b03d4041e111bf2acbc8"}}}}