{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/qserv/pulls/comments/33875492","id":33875492,"diff_hunk":"@@ -40,6 +40,33 @@ namespace lsst {\n namespace qserv {\n namespace util {\n ","path":"core/modules/util/Error.h","position":3,"original_position":3,"commit_id":"908b7c9a3a3aa3f92fbc295a66a541b7d436ec33","original_commit_id":"908b7c9a3a3aa3f92fbc295a66a541b7d436ec33","user":{"login":"jbecla","id":626419,"avatar_url":"https://avatars.githubusercontent.com/u/626419?v=3","gravatar_id":"","url":"https://api.github.com/users/jbecla","html_url":"https://github.com/jbecla","followers_url":"https://api.github.com/users/jbecla/followers","following_url":"https://api.github.com/users/jbecla/following{/other_user}","gists_url":"https://api.github.com/users/jbecla/gists{/gist_id}","starred_url":"https://api.github.com/users/jbecla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbecla/subscriptions","organizations_url":"https://api.github.com/users/jbecla/orgs","repos_url":"https://api.github.com/users/jbecla/repos","events_url":"https://api.github.com/users/jbecla/events{/privacy}","received_events_url":"https://api.github.com/users/jbecla/received_events","type":"User","site_admin":false},"body":"#ifndef in this file is non-conventional: UTIL_ERROR_H_, should be LSST_QSERV_UTIL_ERROR_H. While you are at it, could you also fix:\r\n\r\nqana/CheckAggregation.h:#ifndef QANA_CHECKAGGREGATION_H_\r\nqmeta/QMeta.h:#ifndef QMETA_QMETA_H\r\nquery/typedefs.h:#ifndef QUERY_TYPES_H_\r\nutil/Error.h:#ifndef UTIL_ERROR_H_\r\n","created_at":"2015-07-03T17:36:19Z","updated_at":"2015-07-03T17:36:19Z","html_url":"https://github.com/lsst/qserv/pull/99#discussion_r33875492","pull_request_url":"https://api.github.com/repos/lsst/qserv/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/lsst/qserv/pulls/comments/33875492"},"html":{"href":"https://github.com/lsst/qserv/pull/99#discussion_r33875492"},"pull_request":{"href":"https://api.github.com/repos/lsst/qserv/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/qserv/pulls/99","id":38633696,"html_url":"https://github.com/lsst/qserv/pull/99","diff_url":"https://github.com/lsst/qserv/pull/99.diff","patch_url":"https://github.com/lsst/qserv/pull/99.patch","issue_url":"https://api.github.com/repos/lsst/qserv/issues/99","number":99,"state":"open","locked":false,"title":"U/fjammes/dm 2885","user":{"login":"jbecla","id":626419,"avatar_url":"https://avatars.githubusercontent.com/u/626419?v=3","gravatar_id":"","url":"https://api.github.com/users/jbecla","html_url":"https://github.com/jbecla","followers_url":"https://api.github.com/users/jbecla/followers","following_url":"https://api.github.com/users/jbecla/following{/other_user}","gists_url":"https://api.github.com/users/jbecla/gists{/gist_id}","starred_url":"https://api.github.com/users/jbecla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbecla/subscriptions","organizations_url":"https://api.github.com/users/jbecla/orgs","repos_url":"https://api.github.com/users/jbecla/repos","events_url":"https://api.github.com/users/jbecla/events{/privacy}","received_events_url":"https://api.github.com/users/jbecla/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-26T09:53:39Z","updated_at":"2015-07-03T17:36:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"376a75c6b0cd23760fcbad822bf6ad25570abbe6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lsst/qserv/pulls/99/commits","review_comments_url":"https://api.github.com/repos/lsst/qserv/pulls/99/comments","review_comment_url":"https://api.github.com/repos/lsst/qserv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/qserv/issues/99/comments","statuses_url":"https://api.github.com/repos/lsst/qserv/statuses/908b7c9a3a3aa3f92fbc295a66a541b7d436ec33","head":{"label":"lsst:u/fjammes/DM-2885","ref":"u/fjammes/DM-2885","sha":"908b7c9a3a3aa3f92fbc295a66a541b7d436ec33","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013460,"name":"qserv","full_name":"lsst/qserv","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/qserv","description":"LSST Query Services","fork":false,"url":"https://api.github.com/repos/lsst/qserv","forks_url":"https://api.github.com/repos/lsst/qserv/forks","keys_url":"https://api.github.com/repos/lsst/qserv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/qserv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/qserv/teams","hooks_url":"https://api.github.com/repos/lsst/qserv/hooks","issue_events_url":"https://api.github.com/repos/lsst/qserv/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/qserv/events","assignees_url":"https://api.github.com/repos/lsst/qserv/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/qserv/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/qserv/tags","blobs_url":"https://api.github.com/repos/lsst/qserv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/qserv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/qserv/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/qserv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/qserv/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/qserv/languages","stargazers_url":"https://api.github.com/repos/lsst/qserv/stargazers","contributors_url":"https://api.github.com/repos/lsst/qserv/contributors","subscribers_url":"https://api.github.com/repos/lsst/qserv/subscribers","subscription_url":"https://api.github.com/repos/lsst/qserv/subscription","commits_url":"https://api.github.com/repos/lsst/qserv/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/qserv/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/qserv/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/qserv/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/qserv/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/qserv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/qserv/merges","archive_url":"https://api.github.com/repos/lsst/qserv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/qserv/downloads","issues_url":"https://api.github.com/repos/lsst/qserv/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/qserv/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/qserv/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/qserv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/qserv/labels{/name}","releases_url":"https://api.github.com/repos/lsst/qserv/releases{/id}","created_at":"2014-08-16T07:50:36Z","updated_at":"2015-05-08T02:01:15Z","pushed_at":"2015-07-03T16:29:14Z","git_url":"git://github.com/lsst/qserv.git","ssh_url":"git@github.com:lsst/qserv.git","clone_url":"https://github.com/lsst/qserv.git","svn_url":"https://github.com/lsst/qserv","homepage":"http://dm.lsst.org/","size":20291,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":12,"forks":5,"open_issues":12,"watchers":4,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"db7952a985e3049171483284cbf234f7366006fb","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013460,"name":"qserv","full_name":"lsst/qserv","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/qserv","description":"LSST Query Services","fork":false,"url":"https://api.github.com/repos/lsst/qserv","forks_url":"https://api.github.com/repos/lsst/qserv/forks","keys_url":"https://api.github.com/repos/lsst/qserv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/qserv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/qserv/teams","hooks_url":"https://api.github.com/repos/lsst/qserv/hooks","issue_events_url":"https://api.github.com/repos/lsst/qserv/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/qserv/events","assignees_url":"https://api.github.com/repos/lsst/qserv/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/qserv/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/qserv/tags","blobs_url":"https://api.github.com/repos/lsst/qserv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/qserv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/qserv/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/qserv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/qserv/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/qserv/languages","stargazers_url":"https://api.github.com/repos/lsst/qserv/stargazers","contributors_url":"https://api.github.com/repos/lsst/qserv/contributors","subscribers_url":"https://api.github.com/repos/lsst/qserv/subscribers","subscription_url":"https://api.github.com/repos/lsst/qserv/subscription","commits_url":"https://api.github.com/repos/lsst/qserv/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/qserv/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/qserv/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/qserv/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/qserv/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/qserv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/qserv/merges","archive_url":"https://api.github.com/repos/lsst/qserv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/qserv/downloads","issues_url":"https://api.github.com/repos/lsst/qserv/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/qserv/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/qserv/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/qserv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/qserv/labels{/name}","releases_url":"https://api.github.com/repos/lsst/qserv/releases{/id}","created_at":"2014-08-16T07:50:36Z","updated_at":"2015-05-08T02:01:15Z","pushed_at":"2015-07-03T16:29:14Z","git_url":"git://github.com/lsst/qserv.git","ssh_url":"git@github.com:lsst/qserv.git","clone_url":"https://github.com/lsst/qserv.git","svn_url":"https://github.com/lsst/qserv","homepage":"http://dm.lsst.org/","size":20291,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":12,"forks":5,"open_issues":12,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/qserv/pulls/99"},"html":{"href":"https://github.com/lsst/qserv/pull/99"},"issue":{"href":"https://api.github.com/repos/lsst/qserv/issues/99"},"comments":{"href":"https://api.github.com/repos/lsst/qserv/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/qserv/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/qserv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/qserv/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/qserv/statuses/908b7c9a3a3aa3f92fbc295a66a541b7d436ec33"}}}}