{"push_id":715852301,"size":100,"distinct_size":100,"ref":"refs/heads/master","head":"5c755fe142b421d295e7dd64a9833c12abbfd28e","before":"1b3618b60a487fa219c5381a9c983a00c40e6477","commits":[{"sha":"f75b6fae1a1d0a79dcbb9cbaed1d06bf3fe57a3c","author":{"email":"380ce2a82d3d08e67ab163b51dc6d30288ad3f13@mellanox.com","name":"Sagi Grimberg"},"message":"target: Merge sbc_verify_dif_read|write\n\nInstead of providing DIF verify routines for read/write\nthat are almost identical and conditionally copy protection\ninformation, just let the caller do the right thing.\n\nHave a single sbc_dif_verify that handles an sgl (that\ndoes NOT copy any data) and a protection information copy\nroutine used by rd_mcp and fileio backend.\n\nIn the WRITE case, call sbc_dif_verify with cmd->t_prot_sg\nand then do the copy from it to local sgl (assuming the verify\nsucceeded of course). In the READ case, call sbc_dif_verify\nwith the local sgl and if it succeeds, copy it to t_prot_sg (or\nnot if we are stripping it).\n\n(Fix apply breakage from commit c836777 - nab)\n\nTested-by: Akinobu Mita <akinobu.mita@gmail.com>\nSigned-off-by: Sagi Grimberg <sagig@mellanox.com>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/f75b6fae1a1d0a79dcbb9cbaed1d06bf3fe57a3c"},{"sha":"8287fa5fb43c3fa05748560b8e13b91c4e88f586","author":{"email":"380ce2a82d3d08e67ab163b51dc6d30288ad3f13@mellanox.com","name":"Sagi Grimberg"},"message":"target/file: Remove fd_prot bounce buffer\n\nThe reason this bounce buffer exists is to allow code\nreuse between rd_mcp and fileio in DIF mode. But the fact is,\nthat this bounce is really not needed at all, we can simply call\nsbc_dif_verify on cmd->t_prot_sg and use it for file IO.\n\nThis also removes fd_do_prot_rw as fd_do_rw was generalised\nto receive file pointer, block size (8 bytes for DIF data) and\ntotal data length.\n\n(Fix apply breakage from commit c836777 - nab)\n\nTested-by: Akinobu Mita <akinobu.mita@gmail.com>\nSigned-off-by: Sagi Grimberg <sagig@mellanox.com>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/8287fa5fb43c3fa05748560b8e13b91c4e88f586"},{"sha":"414e4627277e38e3a557c53c9def7fe9f1ec9b2c","author":{"email":"380ce2a82d3d08e67ab163b51dc6d30288ad3f13@mellanox.com","name":"Sagi Grimberg"},"message":"target/sbc: Fix sbc_dif_verify inconsistent map/unmap\n\nFix map/unmap consistency and get rid of a redundant\nlocal variable psg.\n\nReported-by: Akinobu Mita <akinobu.mita@gmail.com>\nSigned-off-by: Sagi Grimberg <sagig@mellanox.com>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/414e4627277e38e3a557c53c9def7fe9f1ec9b2c"},{"sha":"c04a6091c951c88636a569cdd29feb65fb5003af","author":{"email":"1930e27f67e1e10d51770b88cb06d386f1aa46ae@fastmail.fm","name":"Christophe Vu-Brugier"},"message":"iscsi-target: remove support for obsolete markers\n\nSupport for markers is currently broken because of a bug in\niscsi_enforce_integrity_rules(): the \"IFMarkInt_Reject\" and\n\"OFMarkInt_Reject\" variables are always equal to 1 in\niscsi_enforce_integrity_rules().\n\nMoreover, fixed interval markers keys (IFMarker, OFMarker, IFMarkInt\nand OFMarkInt) are obsolete according to iSCSI RFC 7143:\n\n>From http://tools.ietf.org/html/rfc7143#section-13.25:\n\n   13.25.  Obsoleted Keys\n\n   This document obsoletes the following keys defined in [RFC3720]:\n   IFMarker, OFMarker, OFMarkInt, and IFMarkInt.  However, iSCSI\n   implementations compliant to this document may still receive these\n   obsoleted keys -- i.e., in a responder role -- in a text negotiation.\n\n   When an IFMarker or OFMarker key is received, a compliant iSCSI\n   implementation SHOULD respond with the constant \"Reject\" value.  The\n   implementation MAY alternatively respond with a \"No\" value.\n\n   However, the implementation MUST NOT respond with a \"NotUnderstood\"\n   value for either of these keys.\n\n   When an IFMarkInt or OFMarkInt key is received, a compliant iSCSI\n   implementation MUST respond with the constant \"Reject\" value.  The\n   implementation MUST NOT respond with a \"NotUnderstood\" value for\n   either of these keys.\n\nThis patch disables markers by turning the corresponding parameters to\nread-only. The default value of IFMarker and OFMarker remains \"No\" but\nthe user cannot change it to \"Yes\" anymore. The new value of IFMarkInt\nand OFMarkInt is \"Reject\".\n\n(Drop left-over iscsi_get_value_from_number_range + make configfs\n parameters attrs R/W nops - nab)\n\nSigned-off-by: Christophe Vu-Brugier <cvubrugier@fastmail.fm>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/c04a6091c951c88636a569cdd29feb65fb5003af"},{"sha":"814e5b45182f4aaf6c0b0deac7104bc2cba5109e","author":{"email":"923f7720577207a44b32e59bbfbea59d27f1ae8e@lst.de","name":"Christoph Hellwig"},"message":"target: fix DPO and FUA bit checks\n\nDrivers may override the WCE flag, in which case the DPOFUA flag in\nMODE SENSE might differ from the check used to reject invalid FUA\nbits in sbc_check_dpofua.  Also now that we reject invalid FUA\nbits early there is no need to duplicate the same buggy check\ndown in the fileio code.\n\nAs the DPOFUA flag controls th support for FUA bits on read and\nwrite commands as well as DPO key off all the checks off a single\nhelper, and deprecate the emulate_dpo and emulate_fua_read attributs.\n\nThis fixes various failures in the libiscsi testsuite.\n\nPersonally I'd prefer to also remove the emulate_fua_write attribute\nas there is no good reason to disable it, but I'll leave that for\na separate discussion.\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/814e5b45182f4aaf6c0b0deac7104bc2cba5109e"},{"sha":"2bc396a2529ae8a2287f17a49d893ce790e19110","author":{"email":"7f657306c3c5f1ef1cfa2e11204de3febce40ef6@arrikto.com","name":"Ilias Tsitsimpis"},"message":"driver/user: Don't warn for DMA_NONE data direction\n\nSome SCSI commands (for example the TEST UNIT READY command) do not\ncarry data and so data_direction is DMA_NONE. Patch TCMU to not print a\nwarning message about unknown data direction, when it is DMA_NONE.\n\nSigned-off-by: Ilias Tsitsimpis <iliastsi@arrikto.com>\nSigned-off-by: Vangelis Koukis <vkoukis@arrikto.com>\nReviewed-by: Andy Grover <agrover@redhat.com>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/2bc396a2529ae8a2287f17a49d893ce790e19110"},{"sha":"9736f4ad7c6dd79eea36c7fb537a27bbd802582a","author":{"email":"7f657306c3c5f1ef1cfa2e11204de3febce40ef6@arrikto.com","name":"Ilias Tsitsimpis"},"message":"target/loop: Enable VARLEN CDB support\n\nField shost->max_cmd_len is used to inform Linux / the SCSI midlayer of\nthe maximum CDB size an LLD is capable of handling. Set this field to\nSCSI_MAX_VARLEN_CDB_SIZE for target, to enable support for\nvariable-sized CDBs (0x7E).\n\nAlso remove the definition of TL_SCSI_MAX_CMD_LEN since it is now\nredundant.\n\nSigned-off-by: Ilias Tsitsimpis <iliastsi@arrikto.com>\nSigned-off-by: Vangelis Koukis <vkoukis@arrikto.com>\nReviewed-by: Andy Grover <agrover@redhat.com>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/9736f4ad7c6dd79eea36c7fb537a27bbd802582a"},{"sha":"b32bd0a8ee6a19f9b70aa4fcb9bfc802b105ce05","author":{"email":"7f657306c3c5f1ef1cfa2e11204de3febce40ef6@arrikto.com","name":"Ilias Tsitsimpis"},"message":"target/transport: Always initialize bidi fields in se_cmd\n\nFields t_bidi_data_sg and t_bidi_data_nents are set only in the presence\nof BIDI commands. This means that the underlying code (for example TCMU)\ncannot inspect them when the SCSI command is not a BIDI one.\n\nEnsure the code always initializes these fields with the given values,\neven when the SCSI command is not a BIDI one. Set t_bidi_data_sg to\nsgl_bidi (which should be NULL for non-BIDI commands) and\nt_bidi_data_nents to sgl_bidi_count (which should be 0 for non-BIDI\ncommands). This allows the underlying code to use these fields\nunconditionally.\n\nSigned-off-by: Ilias Tsitsimpis <iliastsi@arrikto.com>\nSigned-off-by: Vangelis Koukis <vkoukis@arrikto.com>\nReviewed-by: Andy Grover <agrover@redhat.com>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/b32bd0a8ee6a19f9b70aa4fcb9bfc802b105ce05"},{"sha":"f97ec7db1606875666366bfcba8476f8c917db96","author":{"email":"7f657306c3c5f1ef1cfa2e11204de3febce40ef6@arrikto.com","name":"Ilias Tsitsimpis"},"message":"target/user: Refactor data area allocation code\n\nIntroduce alloc_and_scatter_data_area()/gather_and_free_data_area()\nfunctions that allocate/deallocate space from the data area and copy\ndata to/from a given scatter-gather list. These functions are needed so\nthe next patch, introducing support for bidirectional commands in TCMU,\ncan use the same code path both for t_data_sg and for t_bidi_data_sg.\n\nSigned-off-by: Ilias Tsitsimpis <iliastsi@arrikto.com>\nSigned-off-by: Vangelis Koukis <vkoukis@arrikto.com>\nReviewed-by: Andy Grover <agrover@redhat.com>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/f97ec7db1606875666366bfcba8476f8c917db96"},{"sha":"e4648b014e03baee45d5f5146c1219b19e4e5f2f","author":{"email":"7f657306c3c5f1ef1cfa2e11204de3febce40ef6@arrikto.com","name":"Ilias Tsitsimpis"},"message":"target/user: Add support for bidirectional commands\n\nEnable TCMU to handle bidirectional SCSI commands. In such cases,\nentries in iov[] cover both the Data-In and the Data-Out buffers. The\nfirst iov_cnt entries correspond to the Data-Out buffer, while the\nremaining iov_bidi_cnt entries correspond to the Data-In buffer.\n\nSigned-off-by: Ilias Tsitsimpis <iliastsi@arrikto.com>\nSigned-off-by: Vangelis Koukis <vkoukis@arrikto.com>\nReviewed-by: Andy Grover <agrover@redhat.com>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/e4648b014e03baee45d5f5146c1219b19e4e5f2f"},{"sha":"afc16604c06414223478df3e42301ab630b9960a","author":{"email":"28563a2d387a4f8f033bf7abbf80937064dfbe0c@sandisk.com","name":"Bart Van Assche"},"message":"target: Remove first argument of target_{get,put}_sess_cmd()\n\nThe first argument of these two functions is always identical\nto se_cmd->se_sess. Hence remove the first argument.\n\nSigned-off-by: Bart Van Assche <bart.vanassche@sandisk.com>\nReviewed-by: Sagi Grimberg <sagig@mellanox.com>\nReviewed-by: Christoph Hellwig <hch@lst.de>\nCc: Andy Grover <agrover@redhat.com>\nCc: <qla2xxx-upstream@qlogic.com>\nCc: Felipe Balbi <balbi@ti.com>\nCc: Michael S. Tsirkin <mst@redhat.com>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/afc16604c06414223478df3e42301ab630b9960a"},{"sha":"df75b956274b03e09426c1169f913d884d768ee7","author":{"email":"923f7720577207a44b32e59bbfbea59d27f1ae8e@lst.de","name":"Christoph Hellwig"},"message":"tcm_loop: remove struct tcm_loop_nacl\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/df75b956274b03e09426c1169f913d884d768ee7"},{"sha":"a3b679e7e4369dfb5be735598888fcdef9d35196","author":{"email":"923f7720577207a44b32e59bbfbea59d27f1ae8e@lst.de","name":"Christoph Hellwig"},"message":"tcm_usb: remove struct usbg_nacl\n\nExcept for the embedded struct se_node_acl none of the fields were\never used.\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/a3b679e7e4369dfb5be735598888fcdef9d35196"},{"sha":"16233799e383fc76f20d8142ef55da2308d36c65","author":{"email":"923f7720577207a44b32e59bbfbea59d27f1ae8e@lst.de","name":"Christoph Hellwig"},"message":"sbp_target: remove struct sbp_nacl\n\nExcept for the embedded struct se_node_acl none of the fields were\never used.\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/16233799e383fc76f20d8142ef55da2308d36c65"},{"sha":"55570113a955091af5fafa94cd50914d994e09ae","author":{"email":"923f7720577207a44b32e59bbfbea59d27f1ae8e@lst.de","name":"Christoph Hellwig"},"message":"vhost/scsi: remove struct vhost_scsi_nacl\n\nExcept for the embedded struct se_node_acl none of the fields were\never used.\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/55570113a955091af5fafa94cd50914d994e09ae"},{"sha":"e1750d20e69477c0d7b26d6e0ba24c3c9ec47530","author":{"email":"923f7720577207a44b32e59bbfbea59d27f1ae8e@lst.de","name":"Christoph Hellwig"},"message":"target: make the tpg_get_default_depth method optional\n\nAll fabric drivers except for iSCSI always return 1, so implement\nthat as default behavior.\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/e1750d20e69477c0d7b26d6e0ba24c3c9ec47530"},{"sha":"c7d6a803926bae9bbf4510a18fc8dd8957cc0e01","author":{"email":"923f7720577207a44b32e59bbfbea59d27f1ae8e@lst.de","name":"Christoph Hellwig"},"message":"target: refactor init/drop_nodeacl methods\n\nBy always allocating and adding, respectively removing and freeing\nthe se_node_acl structure in core code we can remove tons of repeated\ncode in the init_nodeacl and drop_nodeacl routines.  Additionally\nthis now respects the get_default_queue_depth method in this code\npath as well.\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/c7d6a803926bae9bbf4510a18fc8dd8957cc0e01"},{"sha":"e413f4727037e826c55a639c713a221006b6d61d","author":{"email":"923f7720577207a44b32e59bbfbea59d27f1ae8e@lst.de","name":"Christoph Hellwig"},"message":"target: refactor node ACL allocation\n\nSplit out two common helpers to share code for allocating and initializing\nnode ACLs.\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/e413f4727037e826c55a639c713a221006b6d61d"},{"sha":"144bc4c2a42a0f42a32c106d53f5bf2724fbf098","author":{"email":"923f7720577207a44b32e59bbfbea59d27f1ae8e@lst.de","name":"Christoph Hellwig"},"message":"target: move node ACL allocation to core code\n\nSigned-off-by: Christoph Hellwig <hch@lst.de>\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/144bc4c2a42a0f42a32c106d53f5bf2724fbf098"},{"sha":"57636388af32c2c7db3919e8d53f4979b7c7c307","author":{"email":"3807cf899f217da549814bf6c330d3b6e6819ccf@gmail.com","name":"Akinobu Mita"},"message":"target: Fix inconsistent address passed to kunmap_atomic() in sbc_dif_copy_prot()\n\nIn sbc_dif_copy_prot(), the addresses passed to kunmap_atomic() are\ninconsistent with the addresses which are mapped by kmap_atomic().\nThat could be problematic if an SG element has its length larger than\nPAGE_SIZE as kunmap_atomic() will attempt to unmap different page.\n\nSigned-off-by: Akinobu Mita <akinobu.mita@gmail.com>\nCc: Nicholas Bellinger <nab@linux-iscsi.org>\nCc: Sagi Grimberg <sagig@mellanox.com>\nCc: \"Martin K. Petersen\" <martin.petersen@oracle.com>\nCc: Christoph Hellwig <hch@lst.de>\nCc: \"James E.J. Bottomley\" <James.Bottomley@HansenPartnership.com>\nCc: target-devel@vger.kernel.org\nCc: linux-scsi@vger.kernel.org\nSigned-off-by: Nicholas Bellinger <nab@linux-iscsi.org>","distinct":true,"url":"https://api.github.com/repos/openwrt-es/linux/commits/57636388af32c2c7db3919e8d53f4979b7c7c307"}]}