{"push_id":813470889,"size":8,"distinct_size":4,"ref":"refs/heads/separate-unit-tests","head":"2a072f2ed31b034f8a26c63c6a6ebfae516f8c80","before":"38e02538404150f8ed4863b05e8040766172f7c5","commits":[{"sha":"cd7f49436085421e0d3eaf9098b8ec5cecd44131","author":{"email":"b6b9c760cb451ae1d4607a4e6e226c82288cfa72@bloomberg.net","name":"Chandan Singh"},"message":"Meta: Add exclude option to precommit.sh\n\nAdd a '-e' option to precommit.sh to allow exclusion of certain tests\nfrom the script. The names of the tests to be excluded are provided as\narguments to this option and valid options are 'gen_docs', 'autofix',\n'static_tests', 'unit_tests' and 'smoke_tests'.\n\nTest plan:\n$ ./precommit.sh\n\n$ ./precommit.sh -h\nEnsure that correct and meaningful help text is displayed.\n\n$ ./precommit.sh -e smoke_tests\nEnsure that smoke_tests.sh is not ran when its passed as an argument to\n'-e'.","distinct":false,"url":"https://api.github.com/repos/cs-shadow/phabricator-tools/commits/cd7f49436085421e0d3eaf9098b8ec5cecd44131"},{"sha":"c21f6e53f5a8aa32b22ea08a08b42bdf09c6f260","author":{"email":"b6b9c760cb451ae1d4607a4e6e226c82288cfa72@bloomberg.net","name":"Chandan Singh"},"message":"Meta: Remove python-pip as apt dependency\n\nTravis CI automatically setups a virtual environment when the language\nis set to python so there's no need for us to try to install pip\nseparately as it is already installed on Travis CI.\n\nTest plan:\n$ ./precommit.sh\n\nEnsure that build passes successfully on Travis CI.","distinct":false,"url":"https://api.github.com/repos/cs-shadow/phabricator-tools/commits/c21f6e53f5a8aa32b22ea08a08b42bdf09c6f260"},{"sha":"7dd979b44ed4ba13a7b94f0d18ff45c667d5bf08","author":{"email":"b6b9c760cb451ae1d4607a4e6e226c82288cfa72@bloomberg.net","name":"Chandan Singh"},"message":"Meta: Run pre-commit tests on Travis-CI\n\nAt the moment, Travis only runs static tests but without much effort it\ncan run other code checks like gen_doc and fixlegal etc. as well. This\nwill take the burden of verifying such things off the reviewers.\n\nTest plan:\n$ ./precommit.sh\n\nEnsure that builds pass on Travis with this change and also that\ngen_doc.sh, autofix.sh and static_tests.sh pass successfully in the\nbuild.","distinct":false,"url":"https://api.github.com/repos/cs-shadow/phabricator-tools/commits/7dd979b44ed4ba13a7b94f0d18ff45c667d5bf08"},{"sha":"3e93e8db8e0ec250500e41dd74fe397039664d5e","author":{"email":"b6b9c760cb451ae1d4607a4e6e226c82288cfa72@bloomberg.net","name":"Chandan Singh"},"message":"phlsys_fs: Fix write_text_file_atomic\n\nThe file descriptor returned by tempfile.mkstemp() function was used\nincorrectly and would have led to an exception if called. This commit\nfixes that.\n\nTest plan:\n$ ./precommit.sh","distinct":false,"url":"https://api.github.com/repos/cs-shadow/phabricator-tools/commits/3e93e8db8e0ec250500e41dd74fe397039664d5e"},{"sha":"1fdfef2e8aa31ff0160a20566b145e53bdb7bdbb","author":{"email":"b6b9c760cb451ae1d4607a4e6e226c82288cfa72@bloomberg.net","name":"Chandan Singh"},"message":"Change integrations tests suffix to __it","distinct":true,"url":"https://api.github.com/repos/cs-shadow/phabricator-tools/commits/1fdfef2e8aa31ff0160a20566b145e53bdb7bdbb"},{"sha":"94974ede95a69798584269f83f26bb47b8a46b91","author":{"email":"b6b9c760cb451ae1d4607a4e6e226c82288cfa72@bloomberg.net","name":"Chandan Singh"},"message":"Run only unit tests","distinct":true,"url":"https://api.github.com/repos/cs-shadow/phabricator-tools/commits/94974ede95a69798584269f83f26bb47b8a46b91"},{"sha":"fb94c868afefb1c3e17c595eaf8cb3a3bbd6724f","author":{"email":"b6b9c760cb451ae1d4607a4e6e226c82288cfa72@bloomberg.net","name":"Chandan Singh"},"message":"phlsys_conduit: Rename make_phab_test_conduit\n\nRename the function make_phab_test_conduit() to\nmake_phab_example_conduit() because any function which has a 'test' in\nits name is considered as a test by Nose. So, Nose considered this\nfunction when it was actually just a helper function which would cause\nthe tests to fail in some cases. So, rename this function to avoid any\nconfusion.\n\nTest plan:\n$ ./precommit.sh\n\n$ git grep make_phab_test_conduit\nEnsure output of grep is empty to make sure that the old function name\nis not used in any place.","distinct":true,"url":"https://api.github.com/repos/cs-shadow/phabricator-tools/commits/fb94c868afefb1c3e17c595eaf8cb3a3bbd6724f"},{"sha":"2a072f2ed31b034f8a26c63c6a6ebfae516f8c80","author":{"email":"b6b9c760cb451ae1d4607a4e6e226c82288cfa72@bloomberg.net","name":"Chandan Singh"},"message":"Remove integration doc test","distinct":true,"url":"https://api.github.com/repos/cs-shadow/phabricator-tools/commits/2a072f2ed31b034f8a26c63c6a6ebfae516f8c80"}]}