{"action":"created","issue":{"url":"https://api.github.com/repos/libtrading/libtrading/issues/69","labels_url":"https://api.github.com/repos/libtrading/libtrading/issues/69/labels{/name}","comments_url":"https://api.github.com/repos/libtrading/libtrading/issues/69/comments","events_url":"https://api.github.com/repos/libtrading/libtrading/issues/69/events","html_url":"https://github.com/libtrading/libtrading/issues/69","id":72429552,"number":69,"title":"FIX: C string 0x0 character during unparse","user":{"login":"divaykin","id":331169,"avatar_url":"https://avatars.githubusercontent.com/u/331169?v=3","gravatar_id":"","url":"https://api.github.com/users/divaykin","html_url":"https://github.com/divaykin","followers_url":"https://api.github.com/users/divaykin/followers","following_url":"https://api.github.com/users/divaykin/following{/other_user}","gists_url":"https://api.github.com/users/divaykin/gists{/gist_id}","starred_url":"https://api.github.com/users/divaykin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divaykin/subscriptions","organizations_url":"https://api.github.com/users/divaykin/orgs","repos_url":"https://api.github.com/users/divaykin/repos","events_url":"https://api.github.com/users/divaykin/events{/privacy}","received_events_url":"https://api.github.com/users/divaykin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-01T13:10:49Z","updated_at":"2015-05-05T09:22:29Z","closed_at":null,"body":"@penberg should we remove this line?\r\nhttps://github.com/libtrading/libtrading/blob/master/lib/stringencoders/modp_numtoa.c#L300"},"comment":{"url":"https://api.github.com/repos/libtrading/libtrading/issues/comments/99006635","html_url":"https://github.com/libtrading/libtrading/issues/69#issuecomment-99006635","issue_url":"https://api.github.com/repos/libtrading/libtrading/issues/69","id":99006635,"user":{"login":"mstanichenko","id":2406080,"avatar_url":"https://avatars.githubusercontent.com/u/2406080?v=3","gravatar_id":"","url":"https://api.github.com/users/mstanichenko","html_url":"https://github.com/mstanichenko","followers_url":"https://api.github.com/users/mstanichenko/followers","following_url":"https://api.github.com/users/mstanichenko/following{/other_user}","gists_url":"https://api.github.com/users/mstanichenko/gists{/gist_id}","starred_url":"https://api.github.com/users/mstanichenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstanichenko/subscriptions","organizations_url":"https://api.github.com/users/mstanichenko/orgs","repos_url":"https://api.github.com/users/mstanichenko/repos","events_url":"https://api.github.com/users/mstanichenko/events{/privacy}","received_events_url":"https://api.github.com/users/mstanichenko/received_events","type":"User","site_admin":false},"created_at":"2015-05-05T09:22:29Z","updated_at":"2015-05-05T09:22:29Z","body":"Could you please elaborate what problem you are trying to solve? If you would like to introduce some micro-optimizations, then yes we probably don't have to spend any time putting zero byte in the end. Otherwise, I don't see any problem here as zero byte will be overwritten here https://github.com/libtrading/libtrading/blob/master/lib/proto/fix_message.c#L598\r\n\r\nMy previous comment was just a general note :)"}}