{"action":"created","comment":{"url":"https://api.github.com/repos/divio/django-cms/pulls/comments/39489945","id":39489945,"diff_hunk":"@@ -108,8 +108,27 @@\n                 });\n             },\n \n-            // public methods\n-            open: function (url, name, breadcrumb) {\n+            /**\n+             * opens the modal either in an iframe or renders markup\n+             *\n+             * @method open\n+             * @param opts\n+             * @param opts.breadcrumb {Array} collection of breadcrumb items","path":"cms/static/cms/js/modules/cms.modal.js","position":29,"original_position":29,"commit_id":"aa99c7c5756657a638c0a6058ba2b944ed8ed2b6","original_commit_id":"aa99c7c5756657a638c0a6058ba2b944ed8ed2b6","user":{"login":"vxsx","id":366813,"avatar_url":"https://avatars.githubusercontent.com/u/366813?v=3","gravatar_id":"","url":"https://api.github.com/users/vxsx","html_url":"https://github.com/vxsx","followers_url":"https://api.github.com/users/vxsx/followers","following_url":"https://api.github.com/users/vxsx/following{/other_user}","gists_url":"https://api.github.com/users/vxsx/gists{/gist_id}","starred_url":"https://api.github.com/users/vxsx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vxsx/subscriptions","organizations_url":"https://api.github.com/users/vxsx/orgs","repos_url":"https://api.github.com/users/vxsx/repos","events_url":"https://api.github.com/users/vxsx/events{/privacy}","received_events_url":"https://api.github.com/users/vxsx/received_events","type":"User","site_admin":false},"body":"and they are optional","created_at":"2015-09-15T09:22:07Z","updated_at":"2015-09-15T09:22:07Z","html_url":"https://github.com/divio/django-cms/pull/4454#discussion_r39489945","pull_request_url":"https://api.github.com/repos/divio/django-cms/pulls/4454","_links":{"self":{"href":"https://api.github.com/repos/divio/django-cms/pulls/comments/39489945"},"html":{"href":"https://github.com/divio/django-cms/pull/4454#discussion_r39489945"},"pull_request":{"href":"https://api.github.com/repos/divio/django-cms/pulls/4454"}}},"pull_request":{"url":"https://api.github.com/repos/divio/django-cms/pulls/4454","id":45025606,"html_url":"https://github.com/divio/django-cms/pull/4454","diff_url":"https://github.com/divio/django-cms/pull/4454.diff","patch_url":"https://github.com/divio/django-cms/pull/4454.patch","issue_url":"https://api.github.com/repos/divio/django-cms/issues/4454","number":4454,"state":"open","locked":false,"title":"Extend modal to inject html markup","user":{"login":"FinalAngel","id":270307,"avatar_url":"https://avatars.githubusercontent.com/u/270307?v=3","gravatar_id":"","url":"https://api.github.com/users/FinalAngel","html_url":"https://github.com/FinalAngel","followers_url":"https://api.github.com/users/FinalAngel/followers","following_url":"https://api.github.com/users/FinalAngel/following{/other_user}","gists_url":"https://api.github.com/users/FinalAngel/gists{/gist_id}","starred_url":"https://api.github.com/users/FinalAngel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FinalAngel/subscriptions","organizations_url":"https://api.github.com/users/FinalAngel/orgs","repos_url":"https://api.github.com/users/FinalAngel/repos","events_url":"https://api.github.com/users/FinalAngel/events{/privacy}","received_events_url":"https://api.github.com/users/FinalAngel/received_events","type":"User","site_admin":false},"body":"**Still in development**\r\n\r\nThis PR extends the modals functionality to inject iframes with html markup. Additionally we changed from passing params to a single object.\r\n\r\nLet's have a look on the old behaviour:\r\n\r\n```\r\nvar modal = new CMS.Modal();\r\nmodal.open('http://www.google.ch', 'Modal name', ['breadcrumb items']);\r\n```\r\n\r\nthe new format in this case would be:\r\n\r\n```\r\nvar modal = new CMS.Modal();\r\nmodal.open({\r\n    url: 'http://www.google.ch',\r\n    name: 'Modal name',\r\n    breadcrumb: ['breadcrumb items']\r\n});\r\n```\r\n\r\nadditionally there is now a `html` param to pass html markup:\r\n\r\n```\r\nvar modal = new CMS.Modal();\r\nmodal.open({\r\n    html: '<p>Hello World</p>',\r\n    name: 'Modal name'\r\n});\r\n```\r\n\r\nPlease not that url has precedence over html. If both are provided url wins. Also note that the html version doesn't load a breadcrumb as of this version.","created_at":"2015-09-15T09:16:47Z","updated_at":"2015-09-15T09:22:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4859eaced8681b6cd7edcac3a75ef6668c9fd58e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/divio/django-cms/pulls/4454/commits","review_comments_url":"https://api.github.com/repos/divio/django-cms/pulls/4454/comments","review_comment_url":"https://api.github.com/repos/divio/django-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/divio/django-cms/issues/4454/comments","statuses_url":"https://api.github.com/repos/divio/django-cms/statuses/aa99c7c5756657a638c0a6058ba2b944ed8ed2b6","head":{"label":"FinalAngel:feature/modalMarkup","ref":"feature/modalMarkup","sha":"aa99c7c5756657a638c0a6058ba2b944ed8ed2b6","user":{"login":"FinalAngel","id":270307,"avatar_url":"https://avatars.githubusercontent.com/u/270307?v=3","gravatar_id":"","url":"https://api.github.com/users/FinalAngel","html_url":"https://github.com/FinalAngel","followers_url":"https://api.github.com/users/FinalAngel/followers","following_url":"https://api.github.com/users/FinalAngel/following{/other_user}","gists_url":"https://api.github.com/users/FinalAngel/gists{/gist_id}","starred_url":"https://api.github.com/users/FinalAngel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FinalAngel/subscriptions","organizations_url":"https://api.github.com/users/FinalAngel/orgs","repos_url":"https://api.github.com/users/FinalAngel/repos","events_url":"https://api.github.com/users/FinalAngel/events{/privacy}","received_events_url":"https://api.github.com/users/FinalAngel/received_events","type":"User","site_admin":false},"repo":{"id":748738,"name":"django-cms","full_name":"FinalAngel/django-cms","owner":{"login":"FinalAngel","id":270307,"avatar_url":"https://avatars.githubusercontent.com/u/270307?v=3","gravatar_id":"","url":"https://api.github.com/users/FinalAngel","html_url":"https://github.com/FinalAngel","followers_url":"https://api.github.com/users/FinalAngel/followers","following_url":"https://api.github.com/users/FinalAngel/following{/other_user}","gists_url":"https://api.github.com/users/FinalAngel/gists{/gist_id}","starred_url":"https://api.github.com/users/FinalAngel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FinalAngel/subscriptions","organizations_url":"https://api.github.com/users/FinalAngel/orgs","repos_url":"https://api.github.com/users/FinalAngel/repos","events_url":"https://api.github.com/users/FinalAngel/events{/privacy}","received_events_url":"https://api.github.com/users/FinalAngel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FinalAngel/django-cms","description":"An Advanced Django Cms","fork":true,"url":"https://api.github.com/repos/FinalAngel/django-cms","forks_url":"https://api.github.com/repos/FinalAngel/django-cms/forks","keys_url":"https://api.github.com/repos/FinalAngel/django-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FinalAngel/django-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FinalAngel/django-cms/teams","hooks_url":"https://api.github.com/repos/FinalAngel/django-cms/hooks","issue_events_url":"https://api.github.com/repos/FinalAngel/django-cms/issues/events{/number}","events_url":"https://api.github.com/repos/FinalAngel/django-cms/events","assignees_url":"https://api.github.com/repos/FinalAngel/django-cms/assignees{/user}","branches_url":"https://api.github.com/repos/FinalAngel/django-cms/branches{/branch}","tags_url":"https://api.github.com/repos/FinalAngel/django-cms/tags","blobs_url":"https://api.github.com/repos/FinalAngel/django-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FinalAngel/django-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FinalAngel/django-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/FinalAngel/django-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FinalAngel/django-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/FinalAngel/django-cms/languages","stargazers_url":"https://api.github.com/repos/FinalAngel/django-cms/stargazers","contributors_url":"https://api.github.com/repos/FinalAngel/django-cms/contributors","subscribers_url":"https://api.github.com/repos/FinalAngel/django-cms/subscribers","subscription_url":"https://api.github.com/repos/FinalAngel/django-cms/subscription","commits_url":"https://api.github.com/repos/FinalAngel/django-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/FinalAngel/django-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/FinalAngel/django-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/FinalAngel/django-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/FinalAngel/django-cms/contents/{+path}","compare_url":"https://api.github.com/repos/FinalAngel/django-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FinalAngel/django-cms/merges","archive_url":"https://api.github.com/repos/FinalAngel/django-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FinalAngel/django-cms/downloads","issues_url":"https://api.github.com/repos/FinalAngel/django-cms/issues{/number}","pulls_url":"https://api.github.com/repos/FinalAngel/django-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/FinalAngel/django-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/FinalAngel/django-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FinalAngel/django-cms/labels{/name}","releases_url":"https://api.github.com/repos/FinalAngel/django-cms/releases{/id}","created_at":"2010-06-30T09:37:05Z","updated_at":"2014-08-06T23:53:12Z","pushed_at":"2015-09-15T09:11:17Z","git_url":"git://github.com/FinalAngel/django-cms.git","ssh_url":"git@github.com:FinalAngel/django-cms.git","clone_url":"https://github.com/FinalAngel/django-cms.git","svn_url":"https://github.com/FinalAngel/django-cms","homepage":"http://www.django-cms.org","size":50096,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"divio:preview","ref":"preview","sha":"d47d5e5451898a4df917e8db6d0392f601daee87","user":{"login":"divio","id":117904,"avatar_url":"https://avatars.githubusercontent.com/u/117904?v=3","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"repo":{"id":143580,"name":"django-cms","full_name":"divio/django-cms","owner":{"login":"divio","id":117904,"avatar_url":"https://avatars.githubusercontent.com/u/117904?v=3","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/divio/django-cms","description":"The easy-to-use and developer-friendly CMS","fork":false,"url":"https://api.github.com/repos/divio/django-cms","forks_url":"https://api.github.com/repos/divio/django-cms/forks","keys_url":"https://api.github.com/repos/divio/django-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divio/django-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divio/django-cms/teams","hooks_url":"https://api.github.com/repos/divio/django-cms/hooks","issue_events_url":"https://api.github.com/repos/divio/django-cms/issues/events{/number}","events_url":"https://api.github.com/repos/divio/django-cms/events","assignees_url":"https://api.github.com/repos/divio/django-cms/assignees{/user}","branches_url":"https://api.github.com/repos/divio/django-cms/branches{/branch}","tags_url":"https://api.github.com/repos/divio/django-cms/tags","blobs_url":"https://api.github.com/repos/divio/django-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divio/django-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divio/django-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/divio/django-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divio/django-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/divio/django-cms/languages","stargazers_url":"https://api.github.com/repos/divio/django-cms/stargazers","contributors_url":"https://api.github.com/repos/divio/django-cms/contributors","subscribers_url":"https://api.github.com/repos/divio/django-cms/subscribers","subscription_url":"https://api.github.com/repos/divio/django-cms/subscription","commits_url":"https://api.github.com/repos/divio/django-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/divio/django-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/divio/django-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/divio/django-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/divio/django-cms/contents/{+path}","compare_url":"https://api.github.com/repos/divio/django-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divio/django-cms/merges","archive_url":"https://api.github.com/repos/divio/django-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divio/django-cms/downloads","issues_url":"https://api.github.com/repos/divio/django-cms/issues{/number}","pulls_url":"https://api.github.com/repos/divio/django-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/divio/django-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/divio/django-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divio/django-cms/labels{/name}","releases_url":"https://api.github.com/repos/divio/django-cms/releases{/id}","created_at":"2009-03-05T10:14:18Z","updated_at":"2015-09-14T14:50:01Z","pushed_at":"2015-09-15T09:16:47Z","git_url":"git://github.com/divio/django-cms.git","ssh_url":"git@github.com:divio/django-cms.git","clone_url":"https://github.com/divio/django-cms.git","svn_url":"https://github.com/divio/django-cms","homepage":"http://www.django-cms.org","size":66952,"stargazers_count":3628,"watchers_count":3628,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1407,"mirror_url":null,"open_issues_count":291,"forks":1407,"open_issues":291,"watchers":3628,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/divio/django-cms/pulls/4454"},"html":{"href":"https://github.com/divio/django-cms/pull/4454"},"issue":{"href":"https://api.github.com/repos/divio/django-cms/issues/4454"},"comments":{"href":"https://api.github.com/repos/divio/django-cms/issues/4454/comments"},"review_comments":{"href":"https://api.github.com/repos/divio/django-cms/pulls/4454/comments"},"review_comment":{"href":"https://api.github.com/repos/divio/django-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/divio/django-cms/pulls/4454/commits"},"statuses":{"href":"https://api.github.com/repos/divio/django-cms/statuses/aa99c7c5756657a638c0a6058ba2b944ed8ed2b6"}}}}