{"action":"opened","number":515,"pull_request":{"url":"https://api.github.com/repos/FAForever/fa/pulls/515","id":31199857,"html_url":"https://github.com/FAForever/fa/pull/515","diff_url":"https://github.com/FAForever/fa/pull/515.diff","patch_url":"https://github.com/FAForever/fa/pull/515.patch","issue_url":"https://api.github.com/repos/FAForever/fa/issues/515","number":515,"state":"open","locked":false,"title":"Only TryCopyPose when death animation occurs","user":{"login":"Crotalus","id":254972,"avatar_url":"https://avatars.githubusercontent.com/u/254972?v=3","gravatar_id":"","url":"https://api.github.com/users/Crotalus","html_url":"https://github.com/Crotalus","followers_url":"https://api.github.com/users/Crotalus/followers","following_url":"https://api.github.com/users/Crotalus/following{/other_user}","gists_url":"https://api.github.com/users/Crotalus/gists{/gist_id}","starred_url":"https://api.github.com/users/Crotalus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crotalus/subscriptions","organizations_url":"https://api.github.com/users/Crotalus/orgs","repos_url":"https://api.github.com/users/Crotalus/repos","events_url":"https://api.github.com/users/Crotalus/events{/privacy}","received_events_url":"https://api.github.com/users/Crotalus/received_events","type":"User","site_admin":false},"body":"Seems like the first attempt to fix pose errors didn't work.\r\n\r\nMore testing of the pose errors reveals that it's due to some form of\r\ngarbage collection of wrecks. When there's been enough of unit deaths on\r\nthe field it starts to remove random wrecks.\r\n\r\nThis results in wrecks getting removed in the same tick as they are\r\ncreated. This causes the error with TryCopyPose() when it tries to set a\r\npose of a deleted wreck.\r\n\r\nIt's unnecessary to copy pose of units that doesn't animated at death so\r\nthis fix at least reduce the amount of spam in log\r\n\r\nI've not found out a way to raise the bar of the garbage collect. Maybe we\r\nshould implement our own GC of wrecks and delete the oldest ones instead,\r\nthis would prevent newly created wrecks to insta-disappear.","created_at":"2015-03-15T12:54:29Z","updated_at":"2015-03-15T12:54:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FAForever/fa/pulls/515/commits","review_comments_url":"https://api.github.com/repos/FAForever/fa/pulls/515/comments","review_comment_url":"https://api.github.com/repos/FAForever/fa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FAForever/fa/issues/515/comments","statuses_url":"https://api.github.com/repos/FAForever/fa/statuses/7b6a2a669a3d328dfa94d2a264c4d5e9de89ec14","head":{"label":"Crotalus:bugfix/pose-wrecks","ref":"bugfix/pose-wrecks","sha":"7b6a2a669a3d328dfa94d2a264c4d5e9de89ec14","user":{"login":"Crotalus","id":254972,"avatar_url":"https://avatars.githubusercontent.com/u/254972?v=3","gravatar_id":"","url":"https://api.github.com/users/Crotalus","html_url":"https://github.com/Crotalus","followers_url":"https://api.github.com/users/Crotalus/followers","following_url":"https://api.github.com/users/Crotalus/following{/other_user}","gists_url":"https://api.github.com/users/Crotalus/gists{/gist_id}","starred_url":"https://api.github.com/users/Crotalus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crotalus/subscriptions","organizations_url":"https://api.github.com/users/Crotalus/orgs","repos_url":"https://api.github.com/users/Crotalus/repos","events_url":"https://api.github.com/users/Crotalus/events{/privacy}","received_events_url":"https://api.github.com/users/Crotalus/received_events","type":"User","site_admin":false},"repo":{"id":24535673,"name":"fa","full_name":"Crotalus/fa","owner":{"login":"Crotalus","id":254972,"avatar_url":"https://avatars.githubusercontent.com/u/254972?v=3","gravatar_id":"","url":"https://api.github.com/users/Crotalus","html_url":"https://github.com/Crotalus","followers_url":"https://api.github.com/users/Crotalus/followers","following_url":"https://api.github.com/users/Crotalus/following{/other_user}","gists_url":"https://api.github.com/users/Crotalus/gists{/gist_id}","starred_url":"https://api.github.com/users/Crotalus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crotalus/subscriptions","organizations_url":"https://api.github.com/users/Crotalus/orgs","repos_url":"https://api.github.com/users/Crotalus/repos","events_url":"https://api.github.com/users/Crotalus/events{/privacy}","received_events_url":"https://api.github.com/users/Crotalus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Crotalus/fa","description":"Lua code for FAF","fork":true,"url":"https://api.github.com/repos/Crotalus/fa","forks_url":"https://api.github.com/repos/Crotalus/fa/forks","keys_url":"https://api.github.com/repos/Crotalus/fa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Crotalus/fa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Crotalus/fa/teams","hooks_url":"https://api.github.com/repos/Crotalus/fa/hooks","issue_events_url":"https://api.github.com/repos/Crotalus/fa/issues/events{/number}","events_url":"https://api.github.com/repos/Crotalus/fa/events","assignees_url":"https://api.github.com/repos/Crotalus/fa/assignees{/user}","branches_url":"https://api.github.com/repos/Crotalus/fa/branches{/branch}","tags_url":"https://api.github.com/repos/Crotalus/fa/tags","blobs_url":"https://api.github.com/repos/Crotalus/fa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Crotalus/fa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Crotalus/fa/git/refs{/sha}","trees_url":"https://api.github.com/repos/Crotalus/fa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Crotalus/fa/statuses/{sha}","languages_url":"https://api.github.com/repos/Crotalus/fa/languages","stargazers_url":"https://api.github.com/repos/Crotalus/fa/stargazers","contributors_url":"https://api.github.com/repos/Crotalus/fa/contributors","subscribers_url":"https://api.github.com/repos/Crotalus/fa/subscribers","subscription_url":"https://api.github.com/repos/Crotalus/fa/subscription","commits_url":"https://api.github.com/repos/Crotalus/fa/commits{/sha}","git_commits_url":"https://api.github.com/repos/Crotalus/fa/git/commits{/sha}","comments_url":"https://api.github.com/repos/Crotalus/fa/comments{/number}","issue_comment_url":"https://api.github.com/repos/Crotalus/fa/issues/comments{/number}","contents_url":"https://api.github.com/repos/Crotalus/fa/contents/{+path}","compare_url":"https://api.github.com/repos/Crotalus/fa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Crotalus/fa/merges","archive_url":"https://api.github.com/repos/Crotalus/fa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Crotalus/fa/downloads","issues_url":"https://api.github.com/repos/Crotalus/fa/issues{/number}","pulls_url":"https://api.github.com/repos/Crotalus/fa/pulls{/number}","milestones_url":"https://api.github.com/repos/Crotalus/fa/milestones{/number}","notifications_url":"https://api.github.com/repos/Crotalus/fa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Crotalus/fa/labels{/name}","releases_url":"https://api.github.com/repos/Crotalus/fa/releases{/id}","created_at":"2014-09-27T15:44:04Z","updated_at":"2015-02-07T05:06:14Z","pushed_at":"2015-03-15T12:53:57Z","git_url":"git://github.com/Crotalus/fa.git","ssh_url":"git@github.com:Crotalus/fa.git","clone_url":"https://github.com/Crotalus/fa.git","svn_url":"https://github.com/Crotalus/fa","homepage":"","size":104436,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"FAForever:release/3641","ref":"release/3641","sha":"ffc250ae9b4bfd2d1d22f75ce1ae421ee275f05c","user":{"login":"FAForever","id":8887184,"avatar_url":"https://avatars.githubusercontent.com/u/8887184?v=3","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"repo":{"id":24403473,"name":"fa","full_name":"FAForever/fa","owner":{"login":"FAForever","id":8887184,"avatar_url":"https://avatars.githubusercontent.com/u/8887184?v=3","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FAForever/fa","description":"Lua code for FAF","fork":false,"url":"https://api.github.com/repos/FAForever/fa","forks_url":"https://api.github.com/repos/FAForever/fa/forks","keys_url":"https://api.github.com/repos/FAForever/fa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FAForever/fa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FAForever/fa/teams","hooks_url":"https://api.github.com/repos/FAForever/fa/hooks","issue_events_url":"https://api.github.com/repos/FAForever/fa/issues/events{/number}","events_url":"https://api.github.com/repos/FAForever/fa/events","assignees_url":"https://api.github.com/repos/FAForever/fa/assignees{/user}","branches_url":"https://api.github.com/repos/FAForever/fa/branches{/branch}","tags_url":"https://api.github.com/repos/FAForever/fa/tags","blobs_url":"https://api.github.com/repos/FAForever/fa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FAForever/fa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FAForever/fa/git/refs{/sha}","trees_url":"https://api.github.com/repos/FAForever/fa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FAForever/fa/statuses/{sha}","languages_url":"https://api.github.com/repos/FAForever/fa/languages","stargazers_url":"https://api.github.com/repos/FAForever/fa/stargazers","contributors_url":"https://api.github.com/repos/FAForever/fa/contributors","subscribers_url":"https://api.github.com/repos/FAForever/fa/subscribers","subscription_url":"https://api.github.com/repos/FAForever/fa/subscription","commits_url":"https://api.github.com/repos/FAForever/fa/commits{/sha}","git_commits_url":"https://api.github.com/repos/FAForever/fa/git/commits{/sha}","comments_url":"https://api.github.com/repos/FAForever/fa/comments{/number}","issue_comment_url":"https://api.github.com/repos/FAForever/fa/issues/comments{/number}","contents_url":"https://api.github.com/repos/FAForever/fa/contents/{+path}","compare_url":"https://api.github.com/repos/FAForever/fa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FAForever/fa/merges","archive_url":"https://api.github.com/repos/FAForever/fa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FAForever/fa/downloads","issues_url":"https://api.github.com/repos/FAForever/fa/issues{/number}","pulls_url":"https://api.github.com/repos/FAForever/fa/pulls{/number}","milestones_url":"https://api.github.com/repos/FAForever/fa/milestones{/number}","notifications_url":"https://api.github.com/repos/FAForever/fa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FAForever/fa/labels{/name}","releases_url":"https://api.github.com/repos/FAForever/fa/releases{/id}","created_at":"2014-09-24T06:34:12Z","updated_at":"2015-03-14T17:39:15Z","pushed_at":"2015-03-14T17:51:49Z","git_url":"git://github.com/FAForever/fa.git","ssh_url":"git@github.com:FAForever/fa.git","clone_url":"https://github.com/FAForever/fa.git","svn_url":"https://github.com/FAForever/fa","homepage":"","size":113007,"stargazers_count":16,"watchers_count":16,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":105,"forks":17,"open_issues":105,"watchers":16,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/FAForever/fa/pulls/515"},"html":{"href":"https://github.com/FAForever/fa/pull/515"},"issue":{"href":"https://api.github.com/repos/FAForever/fa/issues/515"},"comments":{"href":"https://api.github.com/repos/FAForever/fa/issues/515/comments"},"review_comments":{"href":"https://api.github.com/repos/FAForever/fa/pulls/515/comments"},"review_comment":{"href":"https://api.github.com/repos/FAForever/fa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FAForever/fa/pulls/515/commits"},"statuses":{"href":"https://api.github.com/repos/FAForever/fa/statuses/7b6a2a669a3d328dfa94d2a264c4d5e9de89ec14"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}