{"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/30841559","id":30841559,"diff_hunk":"@@ -1576,9 +1579,9 @@ templates used by the :class:`ModelAdmin` views:\n \n     .. admonition:: Note\n \n-        Any ``choices`` attribute set on the formfield will limited to the form\n-        field only. If the corresponding field on the model has choices set,\n-        the choices provided to the form must be a valid subset of those\n+        Any ``choices`` attributes set on the formfield will be limited to the ","path":"docs/ref/contrib/admin/index.txt","position":117,"original_position":137,"commit_id":"279218c7ec41dc86d25ef435fb467f157fc48630","original_commit_id":"c5a013468e7ad8eb3186614f7fcfba252510a5ef","user":{"login":"timgraham","id":411869,"avatar_url":"https://avatars.githubusercontent.com/u/411869?v=3","gravatar_id":"","url":"https://api.github.com/users/timgraham","html_url":"https://github.com/timgraham","followers_url":"https://api.github.com/users/timgraham/followers","following_url":"https://api.github.com/users/timgraham/following{/other_user}","gists_url":"https://api.github.com/users/timgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/timgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timgraham/subscriptions","organizations_url":"https://api.github.com/users/timgraham/orgs","repos_url":"https://api.github.com/users/timgraham/repos","events_url":"https://api.github.com/users/timgraham/events{/privacy}","received_events_url":"https://api.github.com/users/timgraham/received_events","type":"User","site_admin":false},"body":"Agreed with \"will be\".  \"choices attribute\" refers to something like `field.choices`, not the number of choices that are selected.","created_at":"2015-05-21T20:05:50Z","updated_at":"2015-05-21T20:05:50Z","html_url":"https://github.com/django/django/pull/4690#discussion_r30841559","pull_request_url":"https://api.github.com/repos/django/django/pulls/4690","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/30841559"},"html":{"href":"https://github.com/django/django/pull/4690#discussion_r30841559"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/4690"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/4690","id":35943966,"html_url":"https://github.com/django/django/pull/4690","diff_url":"https://github.com/django/django/pull/4690.diff","patch_url":"https://github.com/django/django/pull/4690.patch","issue_url":"https://api.github.com/repos/django/django/issues/4690","number":4690,"state":"open","locked":false,"title":"index.txt basic grammar edits and SQL statements","user":{"login":"garwoodpr","id":8339337,"avatar_url":"https://avatars.githubusercontent.com/u/8339337?v=3","gravatar_id":"","url":"https://api.github.com/users/garwoodpr","html_url":"https://github.com/garwoodpr","followers_url":"https://api.github.com/users/garwoodpr/followers","following_url":"https://api.github.com/users/garwoodpr/following{/other_user}","gists_url":"https://api.github.com/users/garwoodpr/gists{/gist_id}","starred_url":"https://api.github.com/users/garwoodpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garwoodpr/subscriptions","organizations_url":"https://api.github.com/users/garwoodpr/orgs","repos_url":"https://api.github.com/users/garwoodpr/repos","events_url":"https://api.github.com/users/garwoodpr/events{/privacy}","received_events_url":"https://api.github.com/users/garwoodpr/received_events","type":"User","site_admin":false},"body":"For your review and consideration please find basic edits to this document, and two topics for discussion below. \r\n\r\nThe two topics which require clarification: \r\n1)  In the 'fieldsets' and 'get_fieldsets' discussions on lines: 284 and 1367; the text suggests 'a list of two-tuples', but technically this is a 'two-tuple tuple'. I left it as is, because a list of two-tuples actually sounds less confusing, but seems to be technically wrong. Please weigh in on this issue. \r\n\r\n2) SQL statements on lines 1100-1101; 1113-1114; and 1129-1130 \r\nOf the primary SQL flavors regularly referenced through the documentation (PostgreSQL, sqLite and MySQL), only PostgreSQL has the ILIKE statement. Unless clarification is added to the document at the point where ILIKE statements are referenced which explains the statement is exclusive to PostgreSQL when constructing case-insensitive searches, LIKE is a better representation of a SQL statement (even novices know the LIKE statement). Below please find the references to case-sensitivity searching in SQL by their respective sources.  \r\n\r\nPostgreSQL:\r\n\"The key word ILIKE can be used instead of LIKE to make the match case-insensitive according to the active locale. This is not in the SQL standard but is a PostgreSQL extension.\" (http://www.postgresql.org/docs/8.3/static/functions-matching.html)\r\n\r\nsqLite:\r\n\"The default configuration of SQLite only supports case-insensitive comparisons of ASCII characters.\" (https://www.sqlite.org/faq.html)\r\n\r\nMySQL\r\n\"  string comparisons are case insensitive by default. This means that if you search with col_name LIKE 'a%', you get all column values that start with A or a.\" (https://dev.mysql.com/doc/refman/5.0/en/case-sensitivity.html)\r\n\r\nI do not have write privileges to the repo, so if these changes are appropriate, please commit.  \r\nThank you.","created_at":"2015-05-21T15:10:36Z","updated_at":"2015-05-21T20:05:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d355ee430c48e1cb0d42cf2fc0e8983707ad6cf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/4690/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/4690/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/django/issues/4690/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/279218c7ec41dc86d25ef435fb467f157fc48630","head":{"label":"garwoodpr:patch-8","ref":"patch-8","sha":"279218c7ec41dc86d25ef435fb467f157fc48630","user":{"login":"garwoodpr","id":8339337,"avatar_url":"https://avatars.githubusercontent.com/u/8339337?v=3","gravatar_id":"","url":"https://api.github.com/users/garwoodpr","html_url":"https://github.com/garwoodpr","followers_url":"https://api.github.com/users/garwoodpr/followers","following_url":"https://api.github.com/users/garwoodpr/following{/other_user}","gists_url":"https://api.github.com/users/garwoodpr/gists{/gist_id}","starred_url":"https://api.github.com/users/garwoodpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garwoodpr/subscriptions","organizations_url":"https://api.github.com/users/garwoodpr/orgs","repos_url":"https://api.github.com/users/garwoodpr/repos","events_url":"https://api.github.com/users/garwoodpr/events{/privacy}","received_events_url":"https://api.github.com/users/garwoodpr/received_events","type":"User","site_admin":false},"repo":{"id":35194235,"name":"django","full_name":"garwoodpr/django","owner":{"login":"garwoodpr","id":8339337,"avatar_url":"https://avatars.githubusercontent.com/u/8339337?v=3","gravatar_id":"","url":"https://api.github.com/users/garwoodpr","html_url":"https://github.com/garwoodpr","followers_url":"https://api.github.com/users/garwoodpr/followers","following_url":"https://api.github.com/users/garwoodpr/following{/other_user}","gists_url":"https://api.github.com/users/garwoodpr/gists{/gist_id}","starred_url":"https://api.github.com/users/garwoodpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garwoodpr/subscriptions","organizations_url":"https://api.github.com/users/garwoodpr/orgs","repos_url":"https://api.github.com/users/garwoodpr/repos","events_url":"https://api.github.com/users/garwoodpr/events{/privacy}","received_events_url":"https://api.github.com/users/garwoodpr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garwoodpr/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/garwoodpr/django","forks_url":"https://api.github.com/repos/garwoodpr/django/forks","keys_url":"https://api.github.com/repos/garwoodpr/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garwoodpr/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garwoodpr/django/teams","hooks_url":"https://api.github.com/repos/garwoodpr/django/hooks","issue_events_url":"https://api.github.com/repos/garwoodpr/django/issues/events{/number}","events_url":"https://api.github.com/repos/garwoodpr/django/events","assignees_url":"https://api.github.com/repos/garwoodpr/django/assignees{/user}","branches_url":"https://api.github.com/repos/garwoodpr/django/branches{/branch}","tags_url":"https://api.github.com/repos/garwoodpr/django/tags","blobs_url":"https://api.github.com/repos/garwoodpr/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garwoodpr/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garwoodpr/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/garwoodpr/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garwoodpr/django/statuses/{sha}","languages_url":"https://api.github.com/repos/garwoodpr/django/languages","stargazers_url":"https://api.github.com/repos/garwoodpr/django/stargazers","contributors_url":"https://api.github.com/repos/garwoodpr/django/contributors","subscribers_url":"https://api.github.com/repos/garwoodpr/django/subscribers","subscription_url":"https://api.github.com/repos/garwoodpr/django/subscription","commits_url":"https://api.github.com/repos/garwoodpr/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/garwoodpr/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/garwoodpr/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/garwoodpr/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/garwoodpr/django/contents/{+path}","compare_url":"https://api.github.com/repos/garwoodpr/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garwoodpr/django/merges","archive_url":"https://api.github.com/repos/garwoodpr/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garwoodpr/django/downloads","issues_url":"https://api.github.com/repos/garwoodpr/django/issues{/number}","pulls_url":"https://api.github.com/repos/garwoodpr/django/pulls{/number}","milestones_url":"https://api.github.com/repos/garwoodpr/django/milestones{/number}","notifications_url":"https://api.github.com/repos/garwoodpr/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garwoodpr/django/labels{/name}","releases_url":"https://api.github.com/repos/garwoodpr/django/releases{/id}","created_at":"2015-05-07T02:25:35Z","updated_at":"2015-05-07T23:41:44Z","pushed_at":"2015-05-21T19:47:50Z","git_url":"git://github.com/garwoodpr/django.git","ssh_url":"git@github.com:garwoodpr/django.git","clone_url":"https://github.com/garwoodpr/django.git","svn_url":"https://github.com/garwoodpr/django","homepage":"https://www.djangoproject.com/","size":137055,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"655f52491505932ef04264de2bce21a03f3a7cd0","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","created_at":"2012-04-28T02:47:18Z","updated_at":"2015-05-21T20:00:16Z","pushed_at":"2015-05-21T19:47:57Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":298955,"stargazers_count":14315,"watchers_count":14315,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5687,"mirror_url":null,"open_issues_count":76,"forks":5687,"open_issues":76,"watchers":14315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/4690"},"html":{"href":"https://github.com/django/django/pull/4690"},"issue":{"href":"https://api.github.com/repos/django/django/issues/4690"},"comments":{"href":"https://api.github.com/repos/django/django/issues/4690/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/4690/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/4690/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/279218c7ec41dc86d25ef435fb467f157fc48630"}}}}