{"action":"created","comment":{"url":"https://api.github.com/repos/leongersen/noUiSlider/pulls/comments/41627030","id":41627030,"diff_hunk":"@@ -30,8 +31,8 @@\n \t\t// JavaScript has some issues in its floating point implementation.\n \t\tto = limit(parseFloat(to.toFixed(7)));\n \n-\t\t// Return false if handle can't move.\n-\t\tif ( to === scope_Locations[trigger] ) {\n+\t\t// Return false if handle can't move and ranges were not updated\n+\t\tif ( to === scope_Locations[trigger] && newScopeValue === scope_Values[trigger]) {","path":"src/js/scope.js","position":17,"original_position":17,"commit_id":"c65749b94b0a5f3ab942174f1627b180a9e31ae4","original_commit_id":"c65749b94b0a5f3ab942174f1627b180a9e31ae4","user":{"login":"vvo","id":123822,"avatar_url":"https://avatars.githubusercontent.com/u/123822?v=3","gravatar_id":"","url":"https://api.github.com/users/vvo","html_url":"https://github.com/vvo","followers_url":"https://api.github.com/users/vvo/followers","following_url":"https://api.github.com/users/vvo/following{/other_user}","gists_url":"https://api.github.com/users/vvo/gists{/gist_id}","starred_url":"https://api.github.com/users/vvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvo/subscriptions","organizations_url":"https://api.github.com/users/vvo/orgs","repos_url":"https://api.github.com/users/vvo/repos","events_url":"https://api.github.com/users/vvo/events{/privacy}","received_events_url":"https://api.github.com/users/vvo/received_events","type":"User","site_admin":false},"body":"I added a comment but it is not very good because it does not explain the underlying issue I was facing. Which I do not remember. I guess it handle the case were your update the option ranges and they are the same as before, thus you do not need to do anything more.","created_at":"2015-10-09T13:02:08Z","updated_at":"2015-10-09T13:02:08Z","html_url":"https://github.com/leongersen/noUiSlider/pull/515#discussion_r41627030","pull_request_url":"https://api.github.com/repos/leongersen/noUiSlider/pulls/515","_links":{"self":{"href":"https://api.github.com/repos/leongersen/noUiSlider/pulls/comments/41627030"},"html":{"href":"https://github.com/leongersen/noUiSlider/pull/515#discussion_r41627030"},"pull_request":{"href":"https://api.github.com/repos/leongersen/noUiSlider/pulls/515"}}},"pull_request":{"url":"https://api.github.com/repos/leongersen/noUiSlider/pulls/515","id":44778513,"html_url":"https://github.com/leongersen/noUiSlider/pull/515","diff_url":"https://github.com/leongersen/noUiSlider/pull/515.diff","patch_url":"https://github.com/leongersen/noUiSlider/pull/515.patch","issue_url":"https://api.github.com/repos/leongersen/noUiSlider/issues/515","number":515,"state":"open","locked":false,"title":"feat: slider.updateOptions","user":{"login":"vvo","id":123822,"avatar_url":"https://avatars.githubusercontent.com/u/123822?v=3","gravatar_id":"","url":"https://api.github.com/users/vvo","html_url":"https://github.com/vvo","followers_url":"https://api.github.com/users/vvo/followers","following_url":"https://api.github.com/users/vvo/following{/other_user}","gists_url":"https://api.github.com/users/vvo/gists{/gist_id}","starred_url":"https://api.github.com/users/vvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvo/subscriptions","organizations_url":"https://api.github.com/users/vvo/orgs","repos_url":"https://api.github.com/users/vvo/repos","events_url":"https://api.github.com/users/vvo/events{/privacy}","received_events_url":"https://api.github.com/users/vvo/received_events","type":"User","site_admin":false},"body":"So I did a quick hack to be able to dynamically update the slider options.\r\n\r\nIt works ok but I am sure it's no complete enough, let me know.\r\n\r\n","created_at":"2015-09-11T12:51:44Z","updated_at":"2015-10-09T13:02:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e2db2b55394b8704bf1d4461f44c9aabbf5e44a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/leongersen/noUiSlider/pulls/515/commits","review_comments_url":"https://api.github.com/repos/leongersen/noUiSlider/pulls/515/comments","review_comment_url":"https://api.github.com/repos/leongersen/noUiSlider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leongersen/noUiSlider/issues/515/comments","statuses_url":"https://api.github.com/repos/leongersen/noUiSlider/statuses/c65749b94b0a5f3ab942174f1627b180a9e31ae4","head":{"label":"algolia:feat/updateOptions","ref":"feat/updateOptions","sha":"c65749b94b0a5f3ab942174f1627b180a9e31ae4","user":{"login":"algolia","id":2034458,"avatar_url":"https://avatars.githubusercontent.com/u/2034458?v=3","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"repo":{"id":42193125,"name":"noUiSlider","full_name":"algolia/noUiSlider","owner":{"login":"algolia","id":2034458,"avatar_url":"https://avatars.githubusercontent.com/u/2034458?v=3","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/algolia/noUiSlider","description":"noUiSlider is a lightweight JavaScript range slider library. It offers a wide selection of options and settings, and is compatible with a ton of (touch) devices, including those running iOS, Android, Windows 8 and Windows Phone 8.","fork":true,"url":"https://api.github.com/repos/algolia/noUiSlider","forks_url":"https://api.github.com/repos/algolia/noUiSlider/forks","keys_url":"https://api.github.com/repos/algolia/noUiSlider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/algolia/noUiSlider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/algolia/noUiSlider/teams","hooks_url":"https://api.github.com/repos/algolia/noUiSlider/hooks","issue_events_url":"https://api.github.com/repos/algolia/noUiSlider/issues/events{/number}","events_url":"https://api.github.com/repos/algolia/noUiSlider/events","assignees_url":"https://api.github.com/repos/algolia/noUiSlider/assignees{/user}","branches_url":"https://api.github.com/repos/algolia/noUiSlider/branches{/branch}","tags_url":"https://api.github.com/repos/algolia/noUiSlider/tags","blobs_url":"https://api.github.com/repos/algolia/noUiSlider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/algolia/noUiSlider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/algolia/noUiSlider/git/refs{/sha}","trees_url":"https://api.github.com/repos/algolia/noUiSlider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/algolia/noUiSlider/statuses/{sha}","languages_url":"https://api.github.com/repos/algolia/noUiSlider/languages","stargazers_url":"https://api.github.com/repos/algolia/noUiSlider/stargazers","contributors_url":"https://api.github.com/repos/algolia/noUiSlider/contributors","subscribers_url":"https://api.github.com/repos/algolia/noUiSlider/subscribers","subscription_url":"https://api.github.com/repos/algolia/noUiSlider/subscription","commits_url":"https://api.github.com/repos/algolia/noUiSlider/commits{/sha}","git_commits_url":"https://api.github.com/repos/algolia/noUiSlider/git/commits{/sha}","comments_url":"https://api.github.com/repos/algolia/noUiSlider/comments{/number}","issue_comment_url":"https://api.github.com/repos/algolia/noUiSlider/issues/comments{/number}","contents_url":"https://api.github.com/repos/algolia/noUiSlider/contents/{+path}","compare_url":"https://api.github.com/repos/algolia/noUiSlider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/algolia/noUiSlider/merges","archive_url":"https://api.github.com/repos/algolia/noUiSlider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/algolia/noUiSlider/downloads","issues_url":"https://api.github.com/repos/algolia/noUiSlider/issues{/number}","pulls_url":"https://api.github.com/repos/algolia/noUiSlider/pulls{/number}","milestones_url":"https://api.github.com/repos/algolia/noUiSlider/milestones{/number}","notifications_url":"https://api.github.com/repos/algolia/noUiSlider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/algolia/noUiSlider/labels{/name}","releases_url":"https://api.github.com/repos/algolia/noUiSlider/releases{/id}","created_at":"2015-09-09T17:17:53Z","updated_at":"2015-10-05T16:15:03Z","pushed_at":"2015-10-09T12:49:28Z","git_url":"git://github.com/algolia/noUiSlider.git","ssh_url":"git@github.com:algolia/noUiSlider.git","clone_url":"https://github.com/algolia/noUiSlider.git","svn_url":"https://github.com/algolia/noUiSlider","homepage":"http://refreshless.com/nouislider/","size":1189,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"leongersen:master","ref":"master","sha":"a4920afadb0d7aaac7db6f84a4bb22cca6f0e228","user":{"login":"leongersen","id":1206361,"avatar_url":"https://avatars.githubusercontent.com/u/1206361?v=3","gravatar_id":"","url":"https://api.github.com/users/leongersen","html_url":"https://github.com/leongersen","followers_url":"https://api.github.com/users/leongersen/followers","following_url":"https://api.github.com/users/leongersen/following{/other_user}","gists_url":"https://api.github.com/users/leongersen/gists{/gist_id}","starred_url":"https://api.github.com/users/leongersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leongersen/subscriptions","organizations_url":"https://api.github.com/users/leongersen/orgs","repos_url":"https://api.github.com/users/leongersen/repos","events_url":"https://api.github.com/users/leongersen/events{/privacy}","received_events_url":"https://api.github.com/users/leongersen/received_events","type":"User","site_admin":false},"repo":{"id":2808651,"name":"noUiSlider","full_name":"leongersen/noUiSlider","owner":{"login":"leongersen","id":1206361,"avatar_url":"https://avatars.githubusercontent.com/u/1206361?v=3","gravatar_id":"","url":"https://api.github.com/users/leongersen","html_url":"https://github.com/leongersen","followers_url":"https://api.github.com/users/leongersen/followers","following_url":"https://api.github.com/users/leongersen/following{/other_user}","gists_url":"https://api.github.com/users/leongersen/gists{/gist_id}","starred_url":"https://api.github.com/users/leongersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leongersen/subscriptions","organizations_url":"https://api.github.com/users/leongersen/orgs","repos_url":"https://api.github.com/users/leongersen/repos","events_url":"https://api.github.com/users/leongersen/events{/privacy}","received_events_url":"https://api.github.com/users/leongersen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leongersen/noUiSlider","description":"noUiSlider is a lightweight JavaScript range slider library. It offers a wide selection of options and settings, and is compatible with a ton of (touch) devices, including those running iOS, Android, Windows 8 and Windows Phone 8.","fork":false,"url":"https://api.github.com/repos/leongersen/noUiSlider","forks_url":"https://api.github.com/repos/leongersen/noUiSlider/forks","keys_url":"https://api.github.com/repos/leongersen/noUiSlider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leongersen/noUiSlider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leongersen/noUiSlider/teams","hooks_url":"https://api.github.com/repos/leongersen/noUiSlider/hooks","issue_events_url":"https://api.github.com/repos/leongersen/noUiSlider/issues/events{/number}","events_url":"https://api.github.com/repos/leongersen/noUiSlider/events","assignees_url":"https://api.github.com/repos/leongersen/noUiSlider/assignees{/user}","branches_url":"https://api.github.com/repos/leongersen/noUiSlider/branches{/branch}","tags_url":"https://api.github.com/repos/leongersen/noUiSlider/tags","blobs_url":"https://api.github.com/repos/leongersen/noUiSlider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leongersen/noUiSlider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leongersen/noUiSlider/git/refs{/sha}","trees_url":"https://api.github.com/repos/leongersen/noUiSlider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leongersen/noUiSlider/statuses/{sha}","languages_url":"https://api.github.com/repos/leongersen/noUiSlider/languages","stargazers_url":"https://api.github.com/repos/leongersen/noUiSlider/stargazers","contributors_url":"https://api.github.com/repos/leongersen/noUiSlider/contributors","subscribers_url":"https://api.github.com/repos/leongersen/noUiSlider/subscribers","subscription_url":"https://api.github.com/repos/leongersen/noUiSlider/subscription","commits_url":"https://api.github.com/repos/leongersen/noUiSlider/commits{/sha}","git_commits_url":"https://api.github.com/repos/leongersen/noUiSlider/git/commits{/sha}","comments_url":"https://api.github.com/repos/leongersen/noUiSlider/comments{/number}","issue_comment_url":"https://api.github.com/repos/leongersen/noUiSlider/issues/comments{/number}","contents_url":"https://api.github.com/repos/leongersen/noUiSlider/contents/{+path}","compare_url":"https://api.github.com/repos/leongersen/noUiSlider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leongersen/noUiSlider/merges","archive_url":"https://api.github.com/repos/leongersen/noUiSlider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leongersen/noUiSlider/downloads","issues_url":"https://api.github.com/repos/leongersen/noUiSlider/issues{/number}","pulls_url":"https://api.github.com/repos/leongersen/noUiSlider/pulls{/number}","milestones_url":"https://api.github.com/repos/leongersen/noUiSlider/milestones{/number}","notifications_url":"https://api.github.com/repos/leongersen/noUiSlider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leongersen/noUiSlider/labels{/name}","releases_url":"https://api.github.com/repos/leongersen/noUiSlider/releases{/id}","created_at":"2011-11-19T12:38:41Z","updated_at":"2015-10-09T09:48:49Z","pushed_at":"2015-10-09T12:57:16Z","git_url":"git://github.com/leongersen/noUiSlider.git","ssh_url":"git@github.com:leongersen/noUiSlider.git","clone_url":"https://github.com/leongersen/noUiSlider.git","svn_url":"https://github.com/leongersen/noUiSlider","homepage":"http://refreshless.com/nouislider/","size":2518,"stargazers_count":1584,"watchers_count":1584,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":262,"mirror_url":null,"open_issues_count":53,"forks":262,"open_issues":53,"watchers":1584,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/leongersen/noUiSlider/pulls/515"},"html":{"href":"https://github.com/leongersen/noUiSlider/pull/515"},"issue":{"href":"https://api.github.com/repos/leongersen/noUiSlider/issues/515"},"comments":{"href":"https://api.github.com/repos/leongersen/noUiSlider/issues/515/comments"},"review_comments":{"href":"https://api.github.com/repos/leongersen/noUiSlider/pulls/515/comments"},"review_comment":{"href":"https://api.github.com/repos/leongersen/noUiSlider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leongersen/noUiSlider/pulls/515/commits"},"statuses":{"href":"https://api.github.com/repos/leongersen/noUiSlider/statuses/c65749b94b0a5f3ab942174f1627b180a9e31ae4"}}}}