{"action":"opened","issue":{"url":"https://api.github.com/repos/sjlawton/proj10/issues/1","labels_url":"https://api.github.com/repos/sjlawton/proj10/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/sjlawton/proj10/issues/1/comments","events_url":"https://api.github.com/repos/sjlawton/proj10/issues/1/events","html_url":"https://github.com/sjlawton/proj10/issues/1","id":64021840,"number":1,"title":"Review notes","user":{"login":"chrisvfritz","id":2327556,"avatar_url":"https://avatars.githubusercontent.com/u/2327556?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvfritz","html_url":"https://github.com/chrisvfritz","followers_url":"https://api.github.com/users/chrisvfritz/followers","following_url":"https://api.github.com/users/chrisvfritz/following{/other_user}","gists_url":"https://api.github.com/users/chrisvfritz/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvfritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvfritz/subscriptions","organizations_url":"https://api.github.com/users/chrisvfritz/orgs","repos_url":"https://api.github.com/users/chrisvfritz/repos","events_url":"https://api.github.com/users/chrisvfritz/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvfritz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-03-24T15:17:37Z","updated_at":"2015-03-24T15:17:37Z","closed_at":null,"body":"### Styles spread across files\r\n\r\nIn this case, I'm not sure there's any value in spreading these styles across different files in the `stylesheets` folder. I would delete either `static.css` or `custom.css`, then move all the styles into the one you didn't delete. Let me know if that makes sense.\r\n\r\n### Indentation\r\n\r\nI see some inconsistent indentation and some indentation that isn't two-space soft-tabs (I *think* just in the stylesheets). The standard indentation for Ruby (`.rb`) files is two-space soft-tabs. And in Rails projects, it's actually best practice to have *every* file use two-space soft-tabs.\r\n\r\nCan you [reconfigure your text editor](https://github.com/chrisvfritz/tc359_cheatsheets/blob/master/ruby/indentation.md) to use two-space soft-tabs instead? And then afterwards, update all your files to use that indentation. You may also find [this video](https://www.youtube.com/watch?v=_JFIeY46sIU) and [this video](https://www.youtube.com/watch?v=GMf8dlrEbB4) helpful for Sublime Text.\r\n\r\n---\r\n\r\nLet me know when you've updated these and I'll take another look. If you get stuck, also please don't hesitate to let me know and I'll be happy to point you in the right direction."}}