{"action":"created","issue":{"url":"https://api.github.com/repos/yesodweb/wai/issues/356","labels_url":"https://api.github.com/repos/yesodweb/wai/issues/356/labels{/name}","comments_url":"https://api.github.com/repos/yesodweb/wai/issues/356/comments","events_url":"https://api.github.com/repos/yesodweb/wai/issues/356/events","html_url":"https://github.com/yesodweb/wai/pull/356","id":65771886,"number":356,"title":"Add Cookie Handling to Network.Wai.Test","user":{"login":"taladar","id":21060,"avatar_url":"https://avatars.githubusercontent.com/u/21060?v=3","gravatar_id":"","url":"https://api.github.com/users/taladar","html_url":"https://github.com/taladar","followers_url":"https://api.github.com/users/taladar/followers","following_url":"https://api.github.com/users/taladar/following{/other_user}","gists_url":"https://api.github.com/users/taladar/gists{/gist_id}","starred_url":"https://api.github.com/users/taladar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taladar/subscriptions","organizations_url":"https://api.github.com/users/taladar/orgs","repos_url":"https://api.github.com/users/taladar/repos","events_url":"https://api.github.com/users/taladar/events{/privacy}","received_events_url":"https://api.github.com/users/taladar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-01T20:24:52Z","updated_at":"2015-04-01T20:32:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/yesodweb/wai/pulls/356","html_url":"https://github.com/yesodweb/wai/pull/356","diff_url":"https://github.com/yesodweb/wai/pull/356.diff","patch_url":"https://github.com/yesodweb/wai/pull/356.patch"},"body":"This would be a useful addition (already hinted at in TODOs in the code anyway) to test WAI applications with some kind of login or session mechanism.\r\n\r\nyesod-test already implements something similar and this implementation has the same limitations (no support for max-age) but not all WAI applications with login/sessions are Yesod applications.\r\n\r\nThis should also benefit hspec-wai if it is built against a version of wai-extra including this change (I did not test that but the source of hspec-wai seems to use Network.Wai.Test)\r\n\r\nI am open for ideas for additional tests to add or changes to bring it in line with any layout or style rules for your packages I missed."},"comment":{"url":"https://api.github.com/repos/yesodweb/wai/issues/comments/88623344","html_url":"https://github.com/yesodweb/wai/pull/356#issuecomment-88623344","issue_url":"https://api.github.com/repos/yesodweb/wai/issues/356","id":88623344,"user":{"login":"snoyberg","id":49415,"avatar_url":"https://avatars.githubusercontent.com/u/49415?v=3","gravatar_id":"","url":"https://api.github.com/users/snoyberg","html_url":"https://github.com/snoyberg","followers_url":"https://api.github.com/users/snoyberg/followers","following_url":"https://api.github.com/users/snoyberg/following{/other_user}","gists_url":"https://api.github.com/users/snoyberg/gists{/gist_id}","starred_url":"https://api.github.com/users/snoyberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snoyberg/subscriptions","organizations_url":"https://api.github.com/users/snoyberg/orgs","repos_url":"https://api.github.com/users/snoyberg/repos","events_url":"https://api.github.com/users/snoyberg/events{/privacy}","received_events_url":"https://api.github.com/users/snoyberg/received_events","type":"User","site_admin":false},"created_at":"2015-04-01T20:32:47Z","updated_at":"2015-04-01T20:32:47Z","body":"Just headed to bed now so I can't look into this, but in principle I'm in\nfavor.\n\nOn Wed, Apr 1, 2015, 11:24 PM Matthias Hörmann <notifications@github.com>\nwrote:\n\n> This would be a useful addition (already hinted at in TODOs in the code\n> anyway) to test WAI applications with some kind of login or session\n> mechanism.\n>\n> yesod-test already implements something similar and this implementation\n> has the same limitations (no support for max-age) but not all WAI\n> applications with login/sessions are Yesod applications.\n>\n> This should also benefit hspec-wai if it is built against a version of\n> wai-extra including this change (I did not test that but the source of\n> hspec-wai seems to use Network.Wai.Test)\n>\n> I am open for ideas for additional tests to add or changes to bring it in\n> line with any layout or style rules for your packages I missed.\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/yesodweb/wai/pull/356\n> Commit Summary\n>\n>    - untested cookie support in Network.Wai.Test\n>    - tests for new cookie handling\n>\n> File Changes\n>\n>    - *M* wai-extra/Network/Wai/Test.hs\n>    <https://github.com/yesodweb/wai/pull/356/files#diff-0> (64)\n>    - *M* wai-extra/test/Network/Wai/TestSpec.hs\n>    <https://github.com/yesodweb/wai/pull/356/files#diff-1> (117)\n>    - *M* wai-extra/wai-extra.cabal\n>    <https://github.com/yesodweb/wai/pull/356/files#diff-2> (4)\n>\n> Patch Links:\n>\n>    - https://github.com/yesodweb/wai/pull/356.patch\n>    - https://github.com/yesodweb/wai/pull/356.diff\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/yesodweb/wai/pull/356>.\n>\n"}}