{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/43985006","id":43985006,"diff_hunk":"@@ -47,17 +47,18 @@ def _graph_connected_component(graph, node_id):\n     nodes_to_explore = np.zeros(shape=(graph.shape[0]), dtype=np.bool)\n     nodes_to_explore[node_id] = True\n     n_node = graph.shape[0]\n-    nodes_to_add = np.zeros(shape=(graph.shape[0]), dtype=np.bool)\n     for i in range(n_node):","path":"sklearn/manifold/spectral_embedding_.py","position":5,"original_position":5,"commit_id":"bde037b22bad40bc5e8c541b35210927723669c0","original_commit_id":"bde037b22bad40bc5e8c541b35210927723669c0","user":{"login":"giorgiop","id":2871319,"avatar_url":"https://avatars.githubusercontent.com/u/2871319?v=3","gravatar_id":"","url":"https://api.github.com/users/giorgiop","html_url":"https://github.com/giorgiop","followers_url":"https://api.github.com/users/giorgiop/followers","following_url":"https://api.github.com/users/giorgiop/following{/other_user}","gists_url":"https://api.github.com/users/giorgiop/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiop/subscriptions","organizations_url":"https://api.github.com/users/giorgiop/orgs","repos_url":"https://api.github.com/users/giorgiop/repos","events_url":"https://api.github.com/users/giorgiop/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiop/received_events","type":"User","site_admin":false},"body":"To help readability we could write `for _ in range(n_node):` since the index is not used","created_at":"2015-11-05T07:57:59Z","updated_at":"2015-11-05T07:57:59Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/5713#discussion_r43985006","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5713","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/43985006"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/5713#discussion_r43985006"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5713"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5713","id":49692096,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/5713","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/5713.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/5713.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5713","number":5713,"state":"open","locked":false,"title":"Fix stopping criterion of _graph_connected_components","user":{"login":"AlexandreAbraham","id":1647301,"avatar_url":"https://avatars.githubusercontent.com/u/1647301?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexandreAbraham","html_url":"https://github.com/AlexandreAbraham","followers_url":"https://api.github.com/users/AlexandreAbraham/followers","following_url":"https://api.github.com/users/AlexandreAbraham/following{/other_user}","gists_url":"https://api.github.com/users/AlexandreAbraham/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexandreAbraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexandreAbraham/subscriptions","organizations_url":"https://api.github.com/users/AlexandreAbraham/orgs","repos_url":"https://api.github.com/users/AlexandreAbraham/repos","events_url":"https://api.github.com/users/AlexandreAbraham/events{/privacy}","received_events_url":"https://api.github.com/users/AlexandreAbraham/received_events","type":"User","site_admin":false},"body":"The function didn't stop in the case of a cyclic graph. I restored the previous stopping criterion and left the optimization that only bring a small overhead on my box (50ms on 10 tries).\r\n\r\nRelated to #5639","created_at":"2015-11-04T14:08:02Z","updated_at":"2015-11-05T07:57:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86244b5e78544cbbe05046367ad22787beae342f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5713/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5713/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5713/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/bde037b22bad40bc5e8c541b35210927723669c0","head":{"label":"AlexandreAbraham:fix_stopping_criterion_graph_connected","ref":"fix_stopping_criterion_graph_connected","sha":"bde037b22bad40bc5e8c541b35210927723669c0","user":{"login":"AlexandreAbraham","id":1647301,"avatar_url":"https://avatars.githubusercontent.com/u/1647301?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexandreAbraham","html_url":"https://github.com/AlexandreAbraham","followers_url":"https://api.github.com/users/AlexandreAbraham/followers","following_url":"https://api.github.com/users/AlexandreAbraham/following{/other_user}","gists_url":"https://api.github.com/users/AlexandreAbraham/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexandreAbraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexandreAbraham/subscriptions","organizations_url":"https://api.github.com/users/AlexandreAbraham/orgs","repos_url":"https://api.github.com/users/AlexandreAbraham/repos","events_url":"https://api.github.com/users/AlexandreAbraham/events{/privacy}","received_events_url":"https://api.github.com/users/AlexandreAbraham/received_events","type":"User","site_admin":false},"repo":{"id":4495814,"name":"scikit-learn","full_name":"AlexandreAbraham/scikit-learn","owner":{"login":"AlexandreAbraham","id":1647301,"avatar_url":"https://avatars.githubusercontent.com/u/1647301?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexandreAbraham","html_url":"https://github.com/AlexandreAbraham","followers_url":"https://api.github.com/users/AlexandreAbraham/followers","following_url":"https://api.github.com/users/AlexandreAbraham/following{/other_user}","gists_url":"https://api.github.com/users/AlexandreAbraham/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexandreAbraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexandreAbraham/subscriptions","organizations_url":"https://api.github.com/users/AlexandreAbraham/orgs","repos_url":"https://api.github.com/users/AlexandreAbraham/repos","events_url":"https://api.github.com/users/AlexandreAbraham/events{/privacy}","received_events_url":"https://api.github.com/users/AlexandreAbraham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlexandreAbraham/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn","forks_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/forks","keys_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/teams","hooks_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/events","assignees_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/tags","blobs_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/subscription","commits_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/merges","archive_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/downloads","issues_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/AlexandreAbraham/scikit-learn/releases{/id}","created_at":"2012-05-30T14:34:49Z","updated_at":"2015-10-27T16:56:26Z","pushed_at":"2015-11-04T13:49:10Z","git_url":"git://github.com/AlexandreAbraham/scikit-learn.git","ssh_url":"git@github.com:AlexandreAbraham/scikit-learn.git","clone_url":"https://github.com/AlexandreAbraham/scikit-learn.git","svn_url":"https://github.com/AlexandreAbraham/scikit-learn","homepage":"http://scikit-learn.org","size":68804,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"b4adafe6b22b5a5ffa390d3366c6913bf4df1966","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2015-11-05T07:11:30Z","pushed_at":"2015-11-05T06:23:17Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":143450,"stargazers_count":8119,"watchers_count":8119,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4838,"mirror_url":null,"open_issues_count":833,"forks":4838,"open_issues":833,"watchers":8119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5713"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/5713"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5713"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5713/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5713/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5713/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/bde037b22bad40bc5e8c541b35210927723669c0"}}}}