{"action":"created","issue":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/702","labels_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/702/labels{/name}","comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/702/comments","events_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/702/events","html_url":"https://github.com/Cockatrice/Cockatrice/pull/702","id":56928828,"number":702,"title":"Osx menubar improvements; fix #659","user":{"login":"ctrlaltca","id":1631111,"avatar_url":"https://avatars.githubusercontent.com/u/1631111?v=3","gravatar_id":"","url":"https://api.github.com/users/ctrlaltca","html_url":"https://github.com/ctrlaltca","followers_url":"https://api.github.com/users/ctrlaltca/followers","following_url":"https://api.github.com/users/ctrlaltca/following{/other_user}","gists_url":"https://api.github.com/users/ctrlaltca/gists{/gist_id}","starred_url":"https://api.github.com/users/ctrlaltca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctrlaltca/subscriptions","organizations_url":"https://api.github.com/users/ctrlaltca/orgs","repos_url":"https://api.github.com/users/ctrlaltca/repos","events_url":"https://api.github.com/users/ctrlaltca/events{/privacy}","received_events_url":"https://api.github.com/users/ctrlaltca/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-07T22:30:36Z","updated_at":"2015-02-07T22:56:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/702","html_url":"https://github.com/Cockatrice/Cockatrice/pull/702","diff_url":"https://github.com/Cockatrice/Cockatrice/pull/702.diff","patch_url":"https://github.com/Cockatrice/Cockatrice/pull/702.patch"},"body":"By now under osx we had two \"cockarice\" menus:\r\n 1. the first one is created automatically by osx, and contains standard items like \"about\", \"quit\", \"preferences\".\r\n 2. the second one is created by cockatrice and contains its actions like \"connect\", \"disconnect\".\r\nImho the current approach has some problems:\r\n * having two menus with the same name is quite confusing, especially for newbies following instructions;\r\n * some special menu entries (quit, about, settings) are currently moved automatically in the correct place by qt depending on specific strings contained in the menu name (info here: http://qt-project.org/doc/qt-4.8/qmenubar.html#qmenubar-on-mac-os-x). Unfortunately when they are translated, this doesn't work anymore.\r\n * the menu entries on the osx-created application menu are not translated.\r\n\r\nThis PR:\r\n * sets the correct menu role on the special menu entries, so they're placed in the correct place even when translated;\r\n * merges all the items in cockatrice's menu inside the osx-created application menu;\r\n * adds translations for all the other items in the application menu;\r\n\r\nHere's the result for an italian-localized cockatrice:\r\n![menu](https://cloud.githubusercontent.com/assets/1631111/6094223/4001a5f8-af21-11e4-8085-08cde2f0dd39.png)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/comments/73387449","html_url":"https://github.com/Cockatrice/Cockatrice/pull/702#issuecomment-73387449","issue_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/702","id":73387449,"user":{"login":"ZeldaZach","id":7460172,"avatar_url":"https://avatars.githubusercontent.com/u/7460172?v=3","gravatar_id":"","url":"https://api.github.com/users/ZeldaZach","html_url":"https://github.com/ZeldaZach","followers_url":"https://api.github.com/users/ZeldaZach/followers","following_url":"https://api.github.com/users/ZeldaZach/following{/other_user}","gists_url":"https://api.github.com/users/ZeldaZach/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeldaZach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeldaZach/subscriptions","organizations_url":"https://api.github.com/users/ZeldaZach/orgs","repos_url":"https://api.github.com/users/ZeldaZach/repos","events_url":"https://api.github.com/users/ZeldaZach/events{/privacy}","received_events_url":"https://api.github.com/users/ZeldaZach/received_events","type":"User","site_admin":false},"created_at":"2015-02-07T22:56:17Z","updated_at":"2015-02-07T22:56:17Z","body":"Works as expected and it's good to merge... I just don't like the SUPER DUPER long ass menu"}}