{"action":"created","comment":{"url":"https://api.github.com/repos/qa-tools/qa-tools/pulls/comments/25132596","id":25132596,"diff_hunk":"@@ -106,4 +106,27 @@ public function setUrlBuilder(IBuilder $url_builder)\n \t\treturn $this;\n \t}\n \n+\t/**\n+\t * Asserts that the page is of the given name.\n+\t *\n+\t * @param string $class_name Name of the page.\n+\t *\n+\t * @return self\n+\t *\n+\t * @throws PageException When class name does not match.\n+\t */\n+\tpublic function matches($class_name)","path":"library/QATools/QATools/PageObject/Page.php","position":13,"original_position":13,"commit_id":"2be94ee84d543f465020a7b0431d222b0cf802ca","original_commit_id":"2be94ee84d543f465020a7b0431d222b0cf802ca","user":{"login":"aik099","id":1277526,"avatar_url":"https://avatars.githubusercontent.com/u/1277526?v=3","gravatar_id":"","url":"https://api.github.com/users/aik099","html_url":"https://github.com/aik099","followers_url":"https://api.github.com/users/aik099/followers","following_url":"https://api.github.com/users/aik099/following{/other_user}","gists_url":"https://api.github.com/users/aik099/gists{/gist_id}","starred_url":"https://api.github.com/users/aik099/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aik099/subscriptions","organizations_url":"https://api.github.com/users/aik099/orgs","repos_url":"https://api.github.com/users/aik099/repos","events_url":"https://api.github.com/users/aik099/events{/privacy}","received_events_url":"https://api.github.com/users/aik099/received_events","type":"User","site_admin":false},"body":"The argument name seems to be wrong, because you give class as input and get class for comparison.\r\n\r\nIn fact it's wrong also for `PageFactory::getPage` method as well, because in the beginning it accepted page class names, but now it accepts page names which can also match page class name.","created_at":"2015-02-22T14:41:52Z","updated_at":"2015-02-22T14:41:52Z","html_url":"https://github.com/qa-tools/qa-tools/pull/123#discussion_r25132596","pull_request_url":"https://api.github.com/repos/qa-tools/qa-tools/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/qa-tools/qa-tools/pulls/comments/25132596"},"html":{"href":"https://github.com/qa-tools/qa-tools/pull/123#discussion_r25132596"},"pull_request":{"href":"https://api.github.com/repos/qa-tools/qa-tools/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/qa-tools/qa-tools/pulls/123","id":29771025,"html_url":"https://github.com/qa-tools/qa-tools/pull/123","diff_url":"https://github.com/qa-tools/qa-tools/pull/123.diff","patch_url":"https://github.com/qa-tools/qa-tools/pull/123.patch","issue_url":"https://api.github.com/repos/qa-tools/qa-tools/issues/123","number":123,"state":"open","locked":false,"title":"Added \"matches\" method to \"Page\" class","user":{"login":"evangelion1204","id":685814,"avatar_url":"https://avatars.githubusercontent.com/u/685814?v=3","gravatar_id":"","url":"https://api.github.com/users/evangelion1204","html_url":"https://github.com/evangelion1204","followers_url":"https://api.github.com/users/evangelion1204/followers","following_url":"https://api.github.com/users/evangelion1204/following{/other_user}","gists_url":"https://api.github.com/users/evangelion1204/gists{/gist_id}","starred_url":"https://api.github.com/users/evangelion1204/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evangelion1204/subscriptions","organizations_url":"https://api.github.com/users/evangelion1204/orgs","repos_url":"https://api.github.com/users/evangelion1204/repos","events_url":"https://api.github.com/users/evangelion1204/events{/privacy}","received_events_url":"https://api.github.com/users/evangelion1204/received_events","type":"User","site_admin":false},"body":"Could also renamed to `assertClassName`, cause its currently an assertion and does not return anything.\r\n\r\nCloses #122","created_at":"2015-02-22T14:31:34Z","updated_at":"2015-02-22T14:41:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3887485838718a4a7352e4258644fe34c5815fe2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/qa-tools/qa-tools/pulls/123/commits","review_comments_url":"https://api.github.com/repos/qa-tools/qa-tools/pulls/123/comments","review_comment_url":"https://api.github.com/repos/qa-tools/qa-tools/pulls/comments/{number}","comments_url":"https://api.github.com/repos/qa-tools/qa-tools/issues/123/comments","statuses_url":"https://api.github.com/repos/qa-tools/qa-tools/statuses/2be94ee84d543f465020a7b0431d222b0cf802ca","head":{"label":"evangelion1204:122-add-matches-to-page","ref":"122-add-matches-to-page","sha":"2be94ee84d543f465020a7b0431d222b0cf802ca","user":{"login":"evangelion1204","id":685814,"avatar_url":"https://avatars.githubusercontent.com/u/685814?v=3","gravatar_id":"","url":"https://api.github.com/users/evangelion1204","html_url":"https://github.com/evangelion1204","followers_url":"https://api.github.com/users/evangelion1204/followers","following_url":"https://api.github.com/users/evangelion1204/following{/other_user}","gists_url":"https://api.github.com/users/evangelion1204/gists{/gist_id}","starred_url":"https://api.github.com/users/evangelion1204/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evangelion1204/subscriptions","organizations_url":"https://api.github.com/users/evangelion1204/orgs","repos_url":"https://api.github.com/users/evangelion1204/repos","events_url":"https://api.github.com/users/evangelion1204/events{/privacy}","received_events_url":"https://api.github.com/users/evangelion1204/received_events","type":"User","site_admin":false},"repo":{"id":19190646,"name":"qa-tools","full_name":"evangelion1204/qa-tools","owner":{"login":"evangelion1204","id":685814,"avatar_url":"https://avatars.githubusercontent.com/u/685814?v=3","gravatar_id":"","url":"https://api.github.com/users/evangelion1204","html_url":"https://github.com/evangelion1204","followers_url":"https://api.github.com/users/evangelion1204/followers","following_url":"https://api.github.com/users/evangelion1204/following{/other_user}","gists_url":"https://api.github.com/users/evangelion1204/gists{/gist_id}","starred_url":"https://api.github.com/users/evangelion1204/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evangelion1204/subscriptions","organizations_url":"https://api.github.com/users/evangelion1204/orgs","repos_url":"https://api.github.com/users/evangelion1204/repos","events_url":"https://api.github.com/users/evangelion1204/events{/privacy}","received_events_url":"https://api.github.com/users/evangelion1204/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evangelion1204/qa-tools","description":"Library that provides easy-to-use way of interaction with web-page elements in functional tests using PageObject pattern.","fork":true,"url":"https://api.github.com/repos/evangelion1204/qa-tools","forks_url":"https://api.github.com/repos/evangelion1204/qa-tools/forks","keys_url":"https://api.github.com/repos/evangelion1204/qa-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evangelion1204/qa-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evangelion1204/qa-tools/teams","hooks_url":"https://api.github.com/repos/evangelion1204/qa-tools/hooks","issue_events_url":"https://api.github.com/repos/evangelion1204/qa-tools/issues/events{/number}","events_url":"https://api.github.com/repos/evangelion1204/qa-tools/events","assignees_url":"https://api.github.com/repos/evangelion1204/qa-tools/assignees{/user}","branches_url":"https://api.github.com/repos/evangelion1204/qa-tools/branches{/branch}","tags_url":"https://api.github.com/repos/evangelion1204/qa-tools/tags","blobs_url":"https://api.github.com/repos/evangelion1204/qa-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evangelion1204/qa-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evangelion1204/qa-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/evangelion1204/qa-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evangelion1204/qa-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/evangelion1204/qa-tools/languages","stargazers_url":"https://api.github.com/repos/evangelion1204/qa-tools/stargazers","contributors_url":"https://api.github.com/repos/evangelion1204/qa-tools/contributors","subscribers_url":"https://api.github.com/repos/evangelion1204/qa-tools/subscribers","subscription_url":"https://api.github.com/repos/evangelion1204/qa-tools/subscription","commits_url":"https://api.github.com/repos/evangelion1204/qa-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/evangelion1204/qa-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/evangelion1204/qa-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/evangelion1204/qa-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/evangelion1204/qa-tools/contents/{+path}","compare_url":"https://api.github.com/repos/evangelion1204/qa-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evangelion1204/qa-tools/merges","archive_url":"https://api.github.com/repos/evangelion1204/qa-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evangelion1204/qa-tools/downloads","issues_url":"https://api.github.com/repos/evangelion1204/qa-tools/issues{/number}","pulls_url":"https://api.github.com/repos/evangelion1204/qa-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/evangelion1204/qa-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/evangelion1204/qa-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evangelion1204/qa-tools/labels{/name}","releases_url":"https://api.github.com/repos/evangelion1204/qa-tools/releases{/id}","created_at":"2014-04-26T22:59:37Z","updated_at":"2014-06-25T20:34:00Z","pushed_at":"2015-02-22T14:30:13Z","git_url":"git://github.com/evangelion1204/qa-tools.git","ssh_url":"git@github.com:evangelion1204/qa-tools.git","clone_url":"https://github.com/evangelion1204/qa-tools.git","svn_url":"https://github.com/evangelion1204/qa-tools","homepage":"","size":1413,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qa-tools:develop","ref":"develop","sha":"6f676e09d5283adcde6a13cd1f183e5bef941cac","user":{"login":"qa-tools","id":7933716,"avatar_url":"https://avatars.githubusercontent.com/u/7933716?v=3","gravatar_id":"","url":"https://api.github.com/users/qa-tools","html_url":"https://github.com/qa-tools","followers_url":"https://api.github.com/users/qa-tools/followers","following_url":"https://api.github.com/users/qa-tools/following{/other_user}","gists_url":"https://api.github.com/users/qa-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/qa-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qa-tools/subscriptions","organizations_url":"https://api.github.com/users/qa-tools/orgs","repos_url":"https://api.github.com/users/qa-tools/repos","events_url":"https://api.github.com/users/qa-tools/events{/privacy}","received_events_url":"https://api.github.com/users/qa-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":14977523,"name":"qa-tools","full_name":"qa-tools/qa-tools","owner":{"login":"qa-tools","id":7933716,"avatar_url":"https://avatars.githubusercontent.com/u/7933716?v=3","gravatar_id":"","url":"https://api.github.com/users/qa-tools","html_url":"https://github.com/qa-tools","followers_url":"https://api.github.com/users/qa-tools/followers","following_url":"https://api.github.com/users/qa-tools/following{/other_user}","gists_url":"https://api.github.com/users/qa-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/qa-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qa-tools/subscriptions","organizations_url":"https://api.github.com/users/qa-tools/orgs","repos_url":"https://api.github.com/users/qa-tools/repos","events_url":"https://api.github.com/users/qa-tools/events{/privacy}","received_events_url":"https://api.github.com/users/qa-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qa-tools/qa-tools","description":"Library that provides easy-to-use way of interaction with web-page elements in functional tests using PageObject pattern.","fork":false,"url":"https://api.github.com/repos/qa-tools/qa-tools","forks_url":"https://api.github.com/repos/qa-tools/qa-tools/forks","keys_url":"https://api.github.com/repos/qa-tools/qa-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qa-tools/qa-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qa-tools/qa-tools/teams","hooks_url":"https://api.github.com/repos/qa-tools/qa-tools/hooks","issue_events_url":"https://api.github.com/repos/qa-tools/qa-tools/issues/events{/number}","events_url":"https://api.github.com/repos/qa-tools/qa-tools/events","assignees_url":"https://api.github.com/repos/qa-tools/qa-tools/assignees{/user}","branches_url":"https://api.github.com/repos/qa-tools/qa-tools/branches{/branch}","tags_url":"https://api.github.com/repos/qa-tools/qa-tools/tags","blobs_url":"https://api.github.com/repos/qa-tools/qa-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qa-tools/qa-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qa-tools/qa-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/qa-tools/qa-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qa-tools/qa-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/qa-tools/qa-tools/languages","stargazers_url":"https://api.github.com/repos/qa-tools/qa-tools/stargazers","contributors_url":"https://api.github.com/repos/qa-tools/qa-tools/contributors","subscribers_url":"https://api.github.com/repos/qa-tools/qa-tools/subscribers","subscription_url":"https://api.github.com/repos/qa-tools/qa-tools/subscription","commits_url":"https://api.github.com/repos/qa-tools/qa-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/qa-tools/qa-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/qa-tools/qa-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/qa-tools/qa-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/qa-tools/qa-tools/contents/{+path}","compare_url":"https://api.github.com/repos/qa-tools/qa-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qa-tools/qa-tools/merges","archive_url":"https://api.github.com/repos/qa-tools/qa-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qa-tools/qa-tools/downloads","issues_url":"https://api.github.com/repos/qa-tools/qa-tools/issues{/number}","pulls_url":"https://api.github.com/repos/qa-tools/qa-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/qa-tools/qa-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/qa-tools/qa-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qa-tools/qa-tools/labels{/name}","releases_url":"https://api.github.com/repos/qa-tools/qa-tools/releases{/id}","created_at":"2013-12-06T08:27:52Z","updated_at":"2015-02-08T17:57:01Z","pushed_at":"2015-02-08T17:57:00Z","git_url":"git://github.com/qa-tools/qa-tools.git","ssh_url":"git@github.com:qa-tools/qa-tools.git","clone_url":"https://github.com/qa-tools/qa-tools.git","svn_url":"https://github.com/qa-tools/qa-tools","homepage":"www.qa-tools.io","size":2632,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":30,"forks":6,"open_issues":30,"watchers":19,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/qa-tools/qa-tools/pulls/123"},"html":{"href":"https://github.com/qa-tools/qa-tools/pull/123"},"issue":{"href":"https://api.github.com/repos/qa-tools/qa-tools/issues/123"},"comments":{"href":"https://api.github.com/repos/qa-tools/qa-tools/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/qa-tools/qa-tools/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/qa-tools/qa-tools/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/qa-tools/qa-tools/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/qa-tools/qa-tools/statuses/2be94ee84d543f465020a7b0431d222b0cf802ca"}}}}