{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/JSON.jl/pulls/comments/40495685","id":40495685,"diff_hunk":"@@ -3,12 +3,13 @@ module Parser #JSON\n using Compat\n \n #Define ordered dictionary from DataStructures if present\n-_HAVE_DATASTRUCTURES = try\n-    using DataStructures\n-    import DataStructures.OrderedDict\n-    true\n-catch\n-    false\n+function __init__()\n+    global _HAVE_DATASTRUCTURES = try","path":"src/Parser.jl","position":11,"original_position":11,"commit_id":"0716a1ccc00e63461e03851387390fdcd43d0c35","original_commit_id":"0716a1ccc00e63461e03851387390fdcd43d0c35","user":{"login":"tkelman","id":5934628,"avatar_url":"https://avatars.githubusercontent.com/u/5934628?v=3","gravatar_id":"","url":"https://api.github.com/users/tkelman","html_url":"https://github.com/tkelman","followers_url":"https://api.github.com/users/tkelman/followers","following_url":"https://api.github.com/users/tkelman/following{/other_user}","gists_url":"https://api.github.com/users/tkelman/gists{/gist_id}","starred_url":"https://api.github.com/users/tkelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkelman/subscriptions","organizations_url":"https://api.github.com/users/tkelman/orgs","repos_url":"https://api.github.com/users/tkelman/repos","events_url":"https://api.github.com/users/tkelman/events{/privacy}","received_events_url":"https://api.github.com/users/tkelman/received_events","type":"User","site_admin":false},"body":"I'm going to merge this then, fix what's broken. Adjusting constness can be done separately if it makes a difference.","created_at":"2015-09-26T17:06:22Z","updated_at":"2015-09-26T17:06:22Z","html_url":"https://github.com/JuliaLang/JSON.jl/pull/126#discussion_r40495685","pull_request_url":"https://api.github.com/repos/JuliaLang/JSON.jl/pulls/126","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/JSON.jl/pulls/comments/40495685"},"html":{"href":"https://github.com/JuliaLang/JSON.jl/pull/126#discussion_r40495685"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/JSON.jl/pulls/126"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/JSON.jl/pulls/126","id":45986642,"html_url":"https://github.com/JuliaLang/JSON.jl/pull/126","diff_url":"https://github.com/JuliaLang/JSON.jl/pull/126.diff","patch_url":"https://github.com/JuliaLang/JSON.jl/pull/126.patch","issue_url":"https://api.github.com/repos/JuliaLang/JSON.jl/issues/126","number":126,"state":"open","locked":false,"title":"Fix loading of precompiled JSON when DataStructures is not present","user":{"login":"tkelman","id":5934628,"avatar_url":"https://avatars.githubusercontent.com/u/5934628?v=3","gravatar_id":"","url":"https://api.github.com/users/tkelman","html_url":"https://github.com/tkelman","followers_url":"https://api.github.com/users/tkelman/followers","following_url":"https://api.github.com/users/tkelman/following{/other_user}","gists_url":"https://api.github.com/users/tkelman/gists{/gist_id}","starred_url":"https://api.github.com/users/tkelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkelman/subscriptions","organizations_url":"https://api.github.com/users/tkelman/orgs","repos_url":"https://api.github.com/users/tkelman/repos","events_url":"https://api.github.com/users/tkelman/events{/privacy}","received_events_url":"https://api.github.com/users/tkelman/received_events","type":"User","site_admin":false},"body":"closes #123\r\n\r\nfirst commit adds a test to demonstrate failure case on travis, then second commit moves the conditional dependency on DataStructures into an `__init__` function.","created_at":"2015-09-25T08:11:39Z","updated_at":"2015-09-26T17:06:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3becafba08f1cbd0f987d7544a39dc49fcb07986","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/JSON.jl/pulls/126/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/JSON.jl/pulls/126/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/JSON.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/JSON.jl/issues/126/comments","statuses_url":"https://api.github.com/repos/JuliaLang/JSON.jl/statuses/0716a1ccc00e63461e03851387390fdcd43d0c35","head":{"label":"JuliaLang:tk/fixprecompile","ref":"tk/fixprecompile","sha":"0716a1ccc00e63461e03851387390fdcd43d0c35","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":7042601,"name":"JSON.jl","full_name":"JuliaLang/JSON.jl","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/JSON.jl","description":"JSON parsing and printing","fork":false,"url":"https://api.github.com/repos/JuliaLang/JSON.jl","forks_url":"https://api.github.com/repos/JuliaLang/JSON.jl/forks","keys_url":"https://api.github.com/repos/JuliaLang/JSON.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/JSON.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/JSON.jl/teams","hooks_url":"https://api.github.com/repos/JuliaLang/JSON.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/JSON.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/JSON.jl/events","assignees_url":"https://api.github.com/repos/JuliaLang/JSON.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/JSON.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/JSON.jl/tags","blobs_url":"https://api.github.com/repos/JuliaLang/JSON.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/JSON.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/JSON.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/JSON.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/JSON.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/JSON.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/JSON.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/JSON.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/JSON.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/JSON.jl/subscription","commits_url":"https://api.github.com/repos/JuliaLang/JSON.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/JSON.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/JSON.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/JSON.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/JSON.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/JSON.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/JSON.jl/merges","archive_url":"https://api.github.com/repos/JuliaLang/JSON.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/JSON.jl/downloads","issues_url":"https://api.github.com/repos/JuliaLang/JSON.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/JSON.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/JSON.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/JSON.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/JSON.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/JSON.jl/releases{/id}","created_at":"2012-12-06T20:39:39Z","updated_at":"2015-09-23T02:13:00Z","pushed_at":"2015-09-25T08:28:36Z","git_url":"git://github.com/JuliaLang/JSON.jl.git","ssh_url":"git@github.com:JuliaLang/JSON.jl.git","clone_url":"https://github.com/JuliaLang/JSON.jl.git","svn_url":"https://github.com/JuliaLang/JSON.jl","homepage":"","size":851,"stargazers_count":50,"watchers_count":50,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":14,"forks":33,"open_issues":14,"watchers":50,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"fb33673c338a59ba3f00b0653b262468d60a58d0","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":7042601,"name":"JSON.jl","full_name":"JuliaLang/JSON.jl","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/JSON.jl","description":"JSON parsing and printing","fork":false,"url":"https://api.github.com/repos/JuliaLang/JSON.jl","forks_url":"https://api.github.com/repos/JuliaLang/JSON.jl/forks","keys_url":"https://api.github.com/repos/JuliaLang/JSON.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/JSON.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/JSON.jl/teams","hooks_url":"https://api.github.com/repos/JuliaLang/JSON.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/JSON.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/JSON.jl/events","assignees_url":"https://api.github.com/repos/JuliaLang/JSON.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/JSON.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/JSON.jl/tags","blobs_url":"https://api.github.com/repos/JuliaLang/JSON.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/JSON.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/JSON.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/JSON.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/JSON.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/JSON.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/JSON.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/JSON.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/JSON.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/JSON.jl/subscription","commits_url":"https://api.github.com/repos/JuliaLang/JSON.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/JSON.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/JSON.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/JSON.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/JSON.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/JSON.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/JSON.jl/merges","archive_url":"https://api.github.com/repos/JuliaLang/JSON.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/JSON.jl/downloads","issues_url":"https://api.github.com/repos/JuliaLang/JSON.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/JSON.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/JSON.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/JSON.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/JSON.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/JSON.jl/releases{/id}","created_at":"2012-12-06T20:39:39Z","updated_at":"2015-09-23T02:13:00Z","pushed_at":"2015-09-25T08:28:36Z","git_url":"git://github.com/JuliaLang/JSON.jl.git","ssh_url":"git@github.com:JuliaLang/JSON.jl.git","clone_url":"https://github.com/JuliaLang/JSON.jl.git","svn_url":"https://github.com/JuliaLang/JSON.jl","homepage":"","size":851,"stargazers_count":50,"watchers_count":50,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":14,"forks":33,"open_issues":14,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/JSON.jl/pulls/126"},"html":{"href":"https://github.com/JuliaLang/JSON.jl/pull/126"},"issue":{"href":"https://api.github.com/repos/JuliaLang/JSON.jl/issues/126"},"comments":{"href":"https://api.github.com/repos/JuliaLang/JSON.jl/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/JSON.jl/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/JSON.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/JSON.jl/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/JSON.jl/statuses/0716a1ccc00e63461e03851387390fdcd43d0c35"}}}}