{"action":"opened","number":29965,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/29965","id":51417187,"html_url":"https://github.com/rust-lang/rust/pull/29965","diff_url":"https://github.com/rust-lang/rust/pull/29965.diff","patch_url":"https://github.com/rust-lang/rust/pull/29965.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/29965","number":29965,"state":"open","locked":false,"title":"Added Self where possible","user":{"login":"crossroads1112","id":3654575,"avatar_url":"https://avatars.githubusercontent.com/u/3654575?v=3","gravatar_id":"","url":"https://api.github.com/users/crossroads1112","html_url":"https://github.com/crossroads1112","followers_url":"https://api.github.com/users/crossroads1112/followers","following_url":"https://api.github.com/users/crossroads1112/following{/other_user}","gists_url":"https://api.github.com/users/crossroads1112/gists{/gist_id}","starred_url":"https://api.github.com/users/crossroads1112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossroads1112/subscriptions","organizations_url":"https://api.github.com/users/crossroads1112/orgs","repos_url":"https://api.github.com/users/crossroads1112/repos","events_url":"https://api.github.com/users/crossroads1112/events{/privacy}","received_events_url":"https://api.github.com/users/crossroads1112/received_events","type":"User","site_admin":false},"body":"In this commit, I added `Self` as the return value for implementations that returned their own type as it seems much more readable IMO. Additionally for the implementations of Iterator and IntoIter, I used Self::Item and Self::IntoIter","created_at":"2015-11-20T22:31:54Z","updated_at":"2015-11-20T22:31:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20eb06a78abb395ebf2f27cfed66255bcf3dfdbb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/29965/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/29965/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/29965/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/44500c83ac36d5e7f042ebe574342e413cadaa36","head":{"label":"crossroads1112:patch-1","ref":"patch-1","sha":"44500c83ac36d5e7f042ebe574342e413cadaa36","user":{"login":"crossroads1112","id":3654575,"avatar_url":"https://avatars.githubusercontent.com/u/3654575?v=3","gravatar_id":"","url":"https://api.github.com/users/crossroads1112","html_url":"https://github.com/crossroads1112","followers_url":"https://api.github.com/users/crossroads1112/followers","following_url":"https://api.github.com/users/crossroads1112/following{/other_user}","gists_url":"https://api.github.com/users/crossroads1112/gists{/gist_id}","starred_url":"https://api.github.com/users/crossroads1112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossroads1112/subscriptions","organizations_url":"https://api.github.com/users/crossroads1112/orgs","repos_url":"https://api.github.com/users/crossroads1112/repos","events_url":"https://api.github.com/users/crossroads1112/events{/privacy}","received_events_url":"https://api.github.com/users/crossroads1112/received_events","type":"User","site_admin":false},"repo":{"id":46589405,"name":"rust","full_name":"crossroads1112/rust","owner":{"login":"crossroads1112","id":3654575,"avatar_url":"https://avatars.githubusercontent.com/u/3654575?v=3","gravatar_id":"","url":"https://api.github.com/users/crossroads1112","html_url":"https://github.com/crossroads1112","followers_url":"https://api.github.com/users/crossroads1112/followers","following_url":"https://api.github.com/users/crossroads1112/following{/other_user}","gists_url":"https://api.github.com/users/crossroads1112/gists{/gist_id}","starred_url":"https://api.github.com/users/crossroads1112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crossroads1112/subscriptions","organizations_url":"https://api.github.com/users/crossroads1112/orgs","repos_url":"https://api.github.com/users/crossroads1112/repos","events_url":"https://api.github.com/users/crossroads1112/events{/privacy}","received_events_url":"https://api.github.com/users/crossroads1112/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crossroads1112/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/crossroads1112/rust","forks_url":"https://api.github.com/repos/crossroads1112/rust/forks","keys_url":"https://api.github.com/repos/crossroads1112/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crossroads1112/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crossroads1112/rust/teams","hooks_url":"https://api.github.com/repos/crossroads1112/rust/hooks","issue_events_url":"https://api.github.com/repos/crossroads1112/rust/issues/events{/number}","events_url":"https://api.github.com/repos/crossroads1112/rust/events","assignees_url":"https://api.github.com/repos/crossroads1112/rust/assignees{/user}","branches_url":"https://api.github.com/repos/crossroads1112/rust/branches{/branch}","tags_url":"https://api.github.com/repos/crossroads1112/rust/tags","blobs_url":"https://api.github.com/repos/crossroads1112/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crossroads1112/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crossroads1112/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/crossroads1112/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crossroads1112/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/crossroads1112/rust/languages","stargazers_url":"https://api.github.com/repos/crossroads1112/rust/stargazers","contributors_url":"https://api.github.com/repos/crossroads1112/rust/contributors","subscribers_url":"https://api.github.com/repos/crossroads1112/rust/subscribers","subscription_url":"https://api.github.com/repos/crossroads1112/rust/subscription","commits_url":"https://api.github.com/repos/crossroads1112/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/crossroads1112/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/crossroads1112/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/crossroads1112/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/crossroads1112/rust/contents/{+path}","compare_url":"https://api.github.com/repos/crossroads1112/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crossroads1112/rust/merges","archive_url":"https://api.github.com/repos/crossroads1112/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crossroads1112/rust/downloads","issues_url":"https://api.github.com/repos/crossroads1112/rust/issues{/number}","pulls_url":"https://api.github.com/repos/crossroads1112/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/crossroads1112/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/crossroads1112/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crossroads1112/rust/labels{/name}","releases_url":"https://api.github.com/repos/crossroads1112/rust/releases{/id}","created_at":"2015-11-20T22:06:09Z","updated_at":"2015-11-20T22:07:02Z","pushed_at":"2015-11-20T22:31:29Z","git_url":"git://github.com/crossroads1112/rust.git","ssh_url":"git@github.com:crossroads1112/rust.git","clone_url":"https://github.com/crossroads1112/rust.git","svn_url":"https://github.com/crossroads1112/rust","homepage":"http://www.rust-lang.org","size":329743,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"20cbba71d496b8b3760d76d694e12dd54c3f3eea","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-11-20T12:56:37Z","pushed_at":"2015-11-20T22:31:55Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":389911,"stargazers_count":14233,"watchers_count":14233,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2783,"mirror_url":null,"open_issues_count":2311,"forks":2783,"open_issues":2311,"watchers":14233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/29965"},"html":{"href":"https://github.com/rust-lang/rust/pull/29965"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/29965"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/29965/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/29965/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/29965/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/44500c83ac36d5e7f042ebe574342e413cadaa36"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":23,"deletions":23,"changed_files":1}}