{"action":"created","issue":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/341","labels_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/341/labels{/name}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/341/comments","events_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/341/events","html_url":"https://github.com/gemini-hlsw/ocs/pull/341","id":71935010,"number":341,"title":"OCSADV-304: vignetting updates","user":{"login":"swalker2m","id":4906023,"avatar_url":"https://avatars.githubusercontent.com/u/4906023?v=3","gravatar_id":"","url":"https://api.github.com/users/swalker2m","html_url":"https://github.com/swalker2m","followers_url":"https://api.github.com/users/swalker2m/followers","following_url":"https://api.github.com/users/swalker2m/following{/other_user}","gists_url":"https://api.github.com/users/swalker2m/gists{/gist_id}","starred_url":"https://api.github.com/users/swalker2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swalker2m/subscriptions","organizations_url":"https://api.github.com/users/swalker2m/orgs","repos_url":"https://api.github.com/users/swalker2m/repos","events_url":"https://api.github.com/users/swalker2m/events{/privacy}","received_events_url":"https://api.github.com/users/swalker2m/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-29T17:20:38Z","updated_at":"2015-04-29T18:00:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/341","html_url":"https://github.com/gemini-hlsw/ocs/pull/341","diff_url":"https://github.com/gemini-hlsw/ocs/pull/341.diff","patch_url":"https://github.com/gemini-hlsw/ocs/pull/341.patch"},"body":"This PR reworks the vignetting model, plotting, and calculation to fix issues with non-zero base coordinates and offsets.  In particular:\r\n\r\n* _At the Model Level_ - changes probe arm calculations to work with new model `Coordinates` and `Offsets` rather than `Point2D`.  All calculations are now done with positions relative to the base rather\r\nthan absolute coordinates.  Moves the GMOS detector gaps to the model itself.\r\n\r\n* _In the OT TPE_ - introduces a `SciAreaPlotFeature` and a `OiwfsPlotFeature` that work with the model and just convert the model elements to screen coordinates for plotting.  Now handles the correction for image north.  There is overlap with existing `SciAreaFeatureBase` and `OIWFS_FeatureBase` that should be addressed in the future by moving the plotting code in their subclasses to model elements just as we've done for GMOS.\r\n\r\n* _Vignetting Calculation_ - changed to approximate the area of the vignetted region and compare it with the overall science area.\r\n\r\nNote that the F2 model and plotting are not being used yet and that the integration with AGS itself has been commented out.  I wanted to put this out a bit early for review though since I'll need to merge it into the test release."},"comment":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/comments/97522105","html_url":"https://github.com/gemini-hlsw/ocs/pull/341#issuecomment-97522105","issue_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/341","id":97522105,"user":{"login":"cquiroz","id":3615303,"avatar_url":"https://avatars.githubusercontent.com/u/3615303?v=3","gravatar_id":"","url":"https://api.github.com/users/cquiroz","html_url":"https://github.com/cquiroz","followers_url":"https://api.github.com/users/cquiroz/followers","following_url":"https://api.github.com/users/cquiroz/following{/other_user}","gists_url":"https://api.github.com/users/cquiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/cquiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cquiroz/subscriptions","organizations_url":"https://api.github.com/users/cquiroz/orgs","repos_url":"https://api.github.com/users/cquiroz/repos","events_url":"https://api.github.com/users/cquiroz/events{/privacy}","received_events_url":"https://api.github.com/users/cquiroz/received_events","type":"User","site_admin":false},"created_at":"2015-04-29T18:00:41Z","updated_at":"2015-04-29T18:00:41Z","body":"You probably deserve a medal for this :+1: "}}