{"action":"created","comment":{"url":"https://api.github.com/repos/marmelab/ng-admin/pulls/comments/40568607","id":40568607,"diff_hunk":"@@ -1,4 +1,5 @@\n /*global define*/\n+import Entry from 'admin-config/lib/Entry';\n \n define(function () {","path":"src/javascripts/ng-admin/Crud/list/ListController.js","position":4,"original_position":4,"commit_id":"d74498224d3663069d17f7264543e8ea282a9210","original_commit_id":"d74498224d3663069d17f7264543e8ea282a9210","user":{"login":"jpetitcolas","id":688373,"avatar_url":"https://avatars.githubusercontent.com/u/688373?v=3","gravatar_id":"","url":"https://api.github.com/users/jpetitcolas","html_url":"https://github.com/jpetitcolas","followers_url":"https://api.github.com/users/jpetitcolas/followers","following_url":"https://api.github.com/users/jpetitcolas/following{/other_user}","gists_url":"https://api.github.com/users/jpetitcolas/gists{/gist_id}","starred_url":"https://api.github.com/users/jpetitcolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpetitcolas/subscriptions","organizations_url":"https://api.github.com/users/jpetitcolas/orgs","repos_url":"https://api.github.com/users/jpetitcolas/repos","events_url":"https://api.github.com/users/jpetitcolas/events{/privacy}","received_events_url":"https://api.github.com/users/jpetitcolas/received_events","type":"User","site_admin":false},"body":"Not specific to this PR, but can you remove the `define`, as it is just requirejs obsolete code? Just `export default` the controller function.","created_at":"2015-09-28T15:52:02Z","updated_at":"2015-09-28T15:52:02Z","html_url":"https://github.com/marmelab/ng-admin/pull/709#discussion_r40568607","pull_request_url":"https://api.github.com/repos/marmelab/ng-admin/pulls/709","_links":{"self":{"href":"https://api.github.com/repos/marmelab/ng-admin/pulls/comments/40568607"},"html":{"href":"https://github.com/marmelab/ng-admin/pull/709#discussion_r40568607"},"pull_request":{"href":"https://api.github.com/repos/marmelab/ng-admin/pulls/709"}}},"pull_request":{"url":"https://api.github.com/repos/marmelab/ng-admin/pulls/709","id":46028283,"html_url":"https://github.com/marmelab/ng-admin/pull/709","diff_url":"https://github.com/marmelab/ng-admin/pull/709.diff","patch_url":"https://github.com/marmelab/ng-admin/pull/709.patch","issue_url":"https://api.github.com/repos/marmelab/ng-admin/issues/709","number":709,"state":"open","locked":false,"title":"[RFR] infinitePagination now resolve reference fields","user":{"login":"djhi","id":1122076,"avatar_url":"https://avatars.githubusercontent.com/u/1122076?v=3","gravatar_id":"","url":"https://api.github.com/users/djhi","html_url":"https://github.com/djhi","followers_url":"https://api.github.com/users/djhi/followers","following_url":"https://api.github.com/users/djhi/following{/other_user}","gists_url":"https://api.github.com/users/djhi/gists{/gist_id}","starred_url":"https://api.github.com/users/djhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djhi/subscriptions","organizations_url":"https://api.github.com/users/djhi/orgs","repos_url":"https://api.github.com/users/djhi/repos","events_url":"https://api.github.com/users/djhi/events{/privacy}","received_events_url":"https://api.github.com/users/djhi/received_events","type":"User","site_admin":false},"body":"Fix for #624 ","created_at":"2015-09-25T16:00:28Z","updated_at":"2015-09-28T15:52:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3193474e611cf906cdadc4a6d74ddd556aedbaa4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/marmelab/ng-admin/pulls/709/commits","review_comments_url":"https://api.github.com/repos/marmelab/ng-admin/pulls/709/comments","review_comment_url":"https://api.github.com/repos/marmelab/ng-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marmelab/ng-admin/issues/709/comments","statuses_url":"https://api.github.com/repos/marmelab/ng-admin/statuses/d74498224d3663069d17f7264543e8ea282a9210","head":{"label":"marmelab:inifinite_loading_references","ref":"inifinite_loading_references","sha":"d74498224d3663069d17f7264543e8ea282a9210","user":{"login":"marmelab","id":3116319,"avatar_url":"https://avatars.githubusercontent.com/u/3116319?v=3","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"repo":{"id":20059361,"name":"ng-admin","full_name":"marmelab/ng-admin","owner":{"login":"marmelab","id":3116319,"avatar_url":"https://avatars.githubusercontent.com/u/3116319?v=3","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marmelab/ng-admin","description":"Add an AngularJS admin GUI to any RESTful API","fork":false,"url":"https://api.github.com/repos/marmelab/ng-admin","forks_url":"https://api.github.com/repos/marmelab/ng-admin/forks","keys_url":"https://api.github.com/repos/marmelab/ng-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marmelab/ng-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marmelab/ng-admin/teams","hooks_url":"https://api.github.com/repos/marmelab/ng-admin/hooks","issue_events_url":"https://api.github.com/repos/marmelab/ng-admin/issues/events{/number}","events_url":"https://api.github.com/repos/marmelab/ng-admin/events","assignees_url":"https://api.github.com/repos/marmelab/ng-admin/assignees{/user}","branches_url":"https://api.github.com/repos/marmelab/ng-admin/branches{/branch}","tags_url":"https://api.github.com/repos/marmelab/ng-admin/tags","blobs_url":"https://api.github.com/repos/marmelab/ng-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marmelab/ng-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marmelab/ng-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/marmelab/ng-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marmelab/ng-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/marmelab/ng-admin/languages","stargazers_url":"https://api.github.com/repos/marmelab/ng-admin/stargazers","contributors_url":"https://api.github.com/repos/marmelab/ng-admin/contributors","subscribers_url":"https://api.github.com/repos/marmelab/ng-admin/subscribers","subscription_url":"https://api.github.com/repos/marmelab/ng-admin/subscription","commits_url":"https://api.github.com/repos/marmelab/ng-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/marmelab/ng-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/marmelab/ng-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/marmelab/ng-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/marmelab/ng-admin/contents/{+path}","compare_url":"https://api.github.com/repos/marmelab/ng-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marmelab/ng-admin/merges","archive_url":"https://api.github.com/repos/marmelab/ng-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marmelab/ng-admin/downloads","issues_url":"https://api.github.com/repos/marmelab/ng-admin/issues{/number}","pulls_url":"https://api.github.com/repos/marmelab/ng-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/marmelab/ng-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/marmelab/ng-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marmelab/ng-admin/labels{/name}","releases_url":"https://api.github.com/repos/marmelab/ng-admin/releases{/id}","created_at":"2014-05-22T12:00:10Z","updated_at":"2015-09-28T13:47:17Z","pushed_at":"2015-09-25T17:12:43Z","git_url":"git://github.com/marmelab/ng-admin.git","ssh_url":"git@github.com:marmelab/ng-admin.git","clone_url":"https://github.com/marmelab/ng-admin.git","svn_url":"https://github.com/marmelab/ng-admin","homepage":"http://marmelab.com/ng-admin-demo/","size":49382,"stargazers_count":2040,"watchers_count":2040,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":223,"mirror_url":null,"open_issues_count":38,"forks":223,"open_issues":38,"watchers":2040,"default_branch":"master"}},"base":{"label":"marmelab:master","ref":"master","sha":"ae5afa2401b8d32f0601efd1c1e723bc4e7c065a","user":{"login":"marmelab","id":3116319,"avatar_url":"https://avatars.githubusercontent.com/u/3116319?v=3","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"repo":{"id":20059361,"name":"ng-admin","full_name":"marmelab/ng-admin","owner":{"login":"marmelab","id":3116319,"avatar_url":"https://avatars.githubusercontent.com/u/3116319?v=3","gravatar_id":"","url":"https://api.github.com/users/marmelab","html_url":"https://github.com/marmelab","followers_url":"https://api.github.com/users/marmelab/followers","following_url":"https://api.github.com/users/marmelab/following{/other_user}","gists_url":"https://api.github.com/users/marmelab/gists{/gist_id}","starred_url":"https://api.github.com/users/marmelab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmelab/subscriptions","organizations_url":"https://api.github.com/users/marmelab/orgs","repos_url":"https://api.github.com/users/marmelab/repos","events_url":"https://api.github.com/users/marmelab/events{/privacy}","received_events_url":"https://api.github.com/users/marmelab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marmelab/ng-admin","description":"Add an AngularJS admin GUI to any RESTful API","fork":false,"url":"https://api.github.com/repos/marmelab/ng-admin","forks_url":"https://api.github.com/repos/marmelab/ng-admin/forks","keys_url":"https://api.github.com/repos/marmelab/ng-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marmelab/ng-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marmelab/ng-admin/teams","hooks_url":"https://api.github.com/repos/marmelab/ng-admin/hooks","issue_events_url":"https://api.github.com/repos/marmelab/ng-admin/issues/events{/number}","events_url":"https://api.github.com/repos/marmelab/ng-admin/events","assignees_url":"https://api.github.com/repos/marmelab/ng-admin/assignees{/user}","branches_url":"https://api.github.com/repos/marmelab/ng-admin/branches{/branch}","tags_url":"https://api.github.com/repos/marmelab/ng-admin/tags","blobs_url":"https://api.github.com/repos/marmelab/ng-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marmelab/ng-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marmelab/ng-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/marmelab/ng-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marmelab/ng-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/marmelab/ng-admin/languages","stargazers_url":"https://api.github.com/repos/marmelab/ng-admin/stargazers","contributors_url":"https://api.github.com/repos/marmelab/ng-admin/contributors","subscribers_url":"https://api.github.com/repos/marmelab/ng-admin/subscribers","subscription_url":"https://api.github.com/repos/marmelab/ng-admin/subscription","commits_url":"https://api.github.com/repos/marmelab/ng-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/marmelab/ng-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/marmelab/ng-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/marmelab/ng-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/marmelab/ng-admin/contents/{+path}","compare_url":"https://api.github.com/repos/marmelab/ng-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marmelab/ng-admin/merges","archive_url":"https://api.github.com/repos/marmelab/ng-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marmelab/ng-admin/downloads","issues_url":"https://api.github.com/repos/marmelab/ng-admin/issues{/number}","pulls_url":"https://api.github.com/repos/marmelab/ng-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/marmelab/ng-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/marmelab/ng-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marmelab/ng-admin/labels{/name}","releases_url":"https://api.github.com/repos/marmelab/ng-admin/releases{/id}","created_at":"2014-05-22T12:00:10Z","updated_at":"2015-09-28T13:47:17Z","pushed_at":"2015-09-25T17:12:43Z","git_url":"git://github.com/marmelab/ng-admin.git","ssh_url":"git@github.com:marmelab/ng-admin.git","clone_url":"https://github.com/marmelab/ng-admin.git","svn_url":"https://github.com/marmelab/ng-admin","homepage":"http://marmelab.com/ng-admin-demo/","size":49382,"stargazers_count":2040,"watchers_count":2040,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":223,"mirror_url":null,"open_issues_count":38,"forks":223,"open_issues":38,"watchers":2040,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marmelab/ng-admin/pulls/709"},"html":{"href":"https://github.com/marmelab/ng-admin/pull/709"},"issue":{"href":"https://api.github.com/repos/marmelab/ng-admin/issues/709"},"comments":{"href":"https://api.github.com/repos/marmelab/ng-admin/issues/709/comments"},"review_comments":{"href":"https://api.github.com/repos/marmelab/ng-admin/pulls/709/comments"},"review_comment":{"href":"https://api.github.com/repos/marmelab/ng-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marmelab/ng-admin/pulls/709/commits"},"statuses":{"href":"https://api.github.com/repos/marmelab/ng-admin/statuses/d74498224d3663069d17f7264543e8ea282a9210"}}}}