{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/44097442","id":44097442,"diff_hunk":"@@ -39,12 +39,8 @@ func (s *DockerSuite) TestEventsTimestampFormats(c *check.C) {\n \t\tsince, until := f(start), f(end)\n \t\tout, _ := dockerCmd(c, \"events\", \"--since=\"+since, \"--until=\"+until)\n \t\tevents := strings.Split(strings.TrimSpace(out), \"\\n\")\n-\t\tif len(events) != 2 {\n-\t\t\tc.Fatalf(\"unexpected events, was expecting only 2 events tag/untag (since=%s, until=%s) out=%s\", since, until, out)\n-\t\t}\n-\t\tif !strings.Contains(out, \"untag\") {\n-\t\t\tc.Fatalf(\"expected 'untag' event not found (since=%s, until=%s) out=%s\", since, until, out)\n-\t\t}\n+\t\tc.Assert(events, checker.HasLen, 2, check.Commentf(\"unexpected events, was expecting only 2 events tag/untag (since=%s, until=%s) out=%s\", since, until, out))\n+\t\tc.Assert(out, checker.Contains, \"untag\", check.Commentf(\"expected 'untag' event not found (since=%s, until=%s) out=%s\", since, until, out))","path":"integration-cli/docker_cli_events_test.go","position":11,"original_position":11,"commit_id":"e4b82087f1a5a51b7ff025194044437ba68a9bfa","original_commit_id":"e4b82087f1a5a51b7ff025194044437ba68a9bfa","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"body":"There's no need for `out` in the commentf here.","created_at":"2015-11-06T02:24:13Z","updated_at":"2015-11-06T02:24:13Z","html_url":"https://github.com/docker/docker/pull/17200#discussion_r44097442","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/17200","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/44097442"},"html":{"href":"https://github.com/docker/docker/pull/17200#discussion_r44097442"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/17200"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/17200","id":48151738,"html_url":"https://github.com/docker/docker/pull/17200","diff_url":"https://github.com/docker/docker/pull/17200.diff","patch_url":"https://github.com/docker/docker/pull/17200.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/17200","number":17200,"state":"open","locked":false,"title":"Using checkers assert for integration-cli/docker_cli_events_test.go","user":{"login":"maaquib","id":880376,"avatar_url":"https://avatars.githubusercontent.com/u/880376?v=3","gravatar_id":"","url":"https://api.github.com/users/maaquib","html_url":"https://github.com/maaquib","followers_url":"https://api.github.com/users/maaquib/followers","following_url":"https://api.github.com/users/maaquib/following{/other_user}","gists_url":"https://api.github.com/users/maaquib/gists{/gist_id}","starred_url":"https://api.github.com/users/maaquib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maaquib/subscriptions","organizations_url":"https://api.github.com/users/maaquib/orgs","repos_url":"https://api.github.com/users/maaquib/repos","events_url":"https://api.github.com/users/maaquib/events{/privacy}","received_events_url":"https://api.github.com/users/maaquib/received_events","type":"User","site_admin":false},"body":"Part of #16756\r\n\r\nUsing checkers assert for integration-cli/docker_cli_events_test.go\r\n\r\nSigned-off-by: Mohammed Aaqib Ansari <maaquib@gmail.com>","created_at":"2015-10-20T03:01:24Z","updated_at":"2015-11-06T02:24:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20485112511a891ec7b476a7002602794b73dbf3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/17200/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/17200/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/17200/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/e4b82087f1a5a51b7ff025194044437ba68a9bfa","head":{"label":"maaquib:16756-integration-cli-events-test","ref":"16756-integration-cli-events-test","sha":"e4b82087f1a5a51b7ff025194044437ba68a9bfa","user":{"login":"maaquib","id":880376,"avatar_url":"https://avatars.githubusercontent.com/u/880376?v=3","gravatar_id":"","url":"https://api.github.com/users/maaquib","html_url":"https://github.com/maaquib","followers_url":"https://api.github.com/users/maaquib/followers","following_url":"https://api.github.com/users/maaquib/following{/other_user}","gists_url":"https://api.github.com/users/maaquib/gists{/gist_id}","starred_url":"https://api.github.com/users/maaquib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maaquib/subscriptions","organizations_url":"https://api.github.com/users/maaquib/orgs","repos_url":"https://api.github.com/users/maaquib/repos","events_url":"https://api.github.com/users/maaquib/events{/privacy}","received_events_url":"https://api.github.com/users/maaquib/received_events","type":"User","site_admin":false},"repo":{"id":38056069,"name":"docker","full_name":"maaquib/docker","owner":{"login":"maaquib","id":880376,"avatar_url":"https://avatars.githubusercontent.com/u/880376?v=3","gravatar_id":"","url":"https://api.github.com/users/maaquib","html_url":"https://github.com/maaquib","followers_url":"https://api.github.com/users/maaquib/followers","following_url":"https://api.github.com/users/maaquib/following{/other_user}","gists_url":"https://api.github.com/users/maaquib/gists{/gist_id}","starred_url":"https://api.github.com/users/maaquib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maaquib/subscriptions","organizations_url":"https://api.github.com/users/maaquib/orgs","repos_url":"https://api.github.com/users/maaquib/repos","events_url":"https://api.github.com/users/maaquib/events{/privacy}","received_events_url":"https://api.github.com/users/maaquib/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maaquib/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/maaquib/docker","forks_url":"https://api.github.com/repos/maaquib/docker/forks","keys_url":"https://api.github.com/repos/maaquib/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maaquib/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maaquib/docker/teams","hooks_url":"https://api.github.com/repos/maaquib/docker/hooks","issue_events_url":"https://api.github.com/repos/maaquib/docker/issues/events{/number}","events_url":"https://api.github.com/repos/maaquib/docker/events","assignees_url":"https://api.github.com/repos/maaquib/docker/assignees{/user}","branches_url":"https://api.github.com/repos/maaquib/docker/branches{/branch}","tags_url":"https://api.github.com/repos/maaquib/docker/tags","blobs_url":"https://api.github.com/repos/maaquib/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maaquib/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maaquib/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/maaquib/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maaquib/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/maaquib/docker/languages","stargazers_url":"https://api.github.com/repos/maaquib/docker/stargazers","contributors_url":"https://api.github.com/repos/maaquib/docker/contributors","subscribers_url":"https://api.github.com/repos/maaquib/docker/subscribers","subscription_url":"https://api.github.com/repos/maaquib/docker/subscription","commits_url":"https://api.github.com/repos/maaquib/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/maaquib/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/maaquib/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/maaquib/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/maaquib/docker/contents/{+path}","compare_url":"https://api.github.com/repos/maaquib/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maaquib/docker/merges","archive_url":"https://api.github.com/repos/maaquib/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maaquib/docker/downloads","issues_url":"https://api.github.com/repos/maaquib/docker/issues{/number}","pulls_url":"https://api.github.com/repos/maaquib/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/maaquib/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/maaquib/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maaquib/docker/labels{/name}","releases_url":"https://api.github.com/repos/maaquib/docker/releases{/id}","created_at":"2015-06-25T15:00:33Z","updated_at":"2015-06-25T15:00:41Z","pushed_at":"2015-10-28T17:52:46Z","git_url":"git://github.com/maaquib/docker.git","ssh_url":"git@github.com:maaquib/docker.git","clone_url":"https://github.com/maaquib/docker.git","svn_url":"https://github.com/maaquib/docker","homepage":"http://www.docker.com","size":71890,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"310725c9331f6f294ab759698e707052efb7bf09","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-11-06T02:19:04Z","pushed_at":"2015-11-06T02:10:31Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":279381,"stargazers_count":25957,"watchers_count":25957,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6939,"mirror_url":null,"open_issues_count":1201,"forks":6939,"open_issues":1201,"watchers":25957,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/17200"},"html":{"href":"https://github.com/docker/docker/pull/17200"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/17200"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/17200/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/17200/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/17200/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/e4b82087f1a5a51b7ff025194044437ba68a9bfa"}}}}