{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/41059566","id":41059566,"diff_hunk":"@@ -69,8 +72,23 @@ fn plain_charset() {\n }\n \n #[test]\n+fn plain_only_charset() {\n+    assert_parse(\n+        \"data:charset=utf-8,hello\",","path":"tests/unit/net/data_loader.rs","position":18,"original_position":18,"commit_id":"3db1e6e4f4ece6a9508ca7062ae10745e09d9e75","original_commit_id":"3db1e6e4f4ece6a9508ca7062ae10745e09d9e75","user":{"login":"eefriedman","id":12769964,"avatar_url":"https://avatars.githubusercontent.com/u/12769964?v=3","gravatar_id":"","url":"https://api.github.com/users/eefriedman","html_url":"https://github.com/eefriedman","followers_url":"https://api.github.com/users/eefriedman/followers","following_url":"https://api.github.com/users/eefriedman/following{/other_user}","gists_url":"https://api.github.com/users/eefriedman/gists{/gist_id}","starred_url":"https://api.github.com/users/eefriedman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eefriedman/subscriptions","organizations_url":"https://api.github.com/users/eefriedman/orgs","repos_url":"https://api.github.com/users/eefriedman/repos","events_url":"https://api.github.com/users/eefriedman/events{/privacy}","received_events_url":"https://api.github.com/users/eefriedman/received_events","type":"User","site_admin":false},"body":"The correct shorthand is `data:;charset=utf-8,hello`.  `data:charset=utf-8,<b>hello` gets interpreted as HTML by Firefox.","created_at":"2015-10-02T19:41:25Z","updated_at":"2015-10-02T19:41:25Z","html_url":"https://github.com/servo/servo/pull/7836#discussion_r41059566","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/7836","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/41059566"},"html":{"href":"https://github.com/servo/servo/pull/7836#discussion_r41059566"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/7836"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/7836","id":46671843,"html_url":"https://github.com/servo/servo/pull/7836","diff_url":"https://github.com/servo/servo/pull/7836.diff","patch_url":"https://github.com/servo/servo/pull/7836.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/7836","number":7836,"state":"open","locked":false,"title":"interpret empty data URI as plain text","user":{"login":"6112","id":678711,"avatar_url":"https://avatars.githubusercontent.com/u/678711?v=3","gravatar_id":"","url":"https://api.github.com/users/6112","html_url":"https://github.com/6112","followers_url":"https://api.github.com/users/6112/followers","following_url":"https://api.github.com/users/6112/following{/other_user}","gists_url":"https://api.github.com/users/6112/gists{/gist_id}","starred_url":"https://api.github.com/users/6112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/6112/subscriptions","organizations_url":"https://api.github.com/users/6112/orgs","repos_url":"https://api.github.com/users/6112/repos","events_url":"https://api.github.com/users/6112/events{/privacy}","received_events_url":"https://api.github.com/users/6112/received_events","type":"User","site_admin":false},"body":"Fixes #7803. As @eefriedman pointed out, RFC 2397 says:\r\n\r\n> If &lt;mediatype&gt; is omitted, it defaults to text/plain;charset=US-ASCII.  As a shorthand, \"text/plain\" can be omitted but the charset parameter supplied.\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/7836)\r\n<!-- Reviewable:end -->\r\n","created_at":"2015-10-02T19:20:11Z","updated_at":"2015-10-02T19:41:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58d6d79cd2733163b3de36461fe23f627dbd3c13","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/7836/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/7836/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/7836/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/3db1e6e4f4ece6a9508ca7062ae10745e09d9e75","head":{"label":"6112:master","ref":"master","sha":"3db1e6e4f4ece6a9508ca7062ae10745e09d9e75","user":{"login":"6112","id":678711,"avatar_url":"https://avatars.githubusercontent.com/u/678711?v=3","gravatar_id":"","url":"https://api.github.com/users/6112","html_url":"https://github.com/6112","followers_url":"https://api.github.com/users/6112/followers","following_url":"https://api.github.com/users/6112/following{/other_user}","gists_url":"https://api.github.com/users/6112/gists{/gist_id}","starred_url":"https://api.github.com/users/6112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/6112/subscriptions","organizations_url":"https://api.github.com/users/6112/orgs","repos_url":"https://api.github.com/users/6112/repos","events_url":"https://api.github.com/users/6112/events{/privacy}","received_events_url":"https://api.github.com/users/6112/received_events","type":"User","site_admin":false},"repo":{"id":43395099,"name":"servo","full_name":"6112/servo","owner":{"login":"6112","id":678711,"avatar_url":"https://avatars.githubusercontent.com/u/678711?v=3","gravatar_id":"","url":"https://api.github.com/users/6112","html_url":"https://github.com/6112","followers_url":"https://api.github.com/users/6112/followers","following_url":"https://api.github.com/users/6112/following{/other_user}","gists_url":"https://api.github.com/users/6112/gists{/gist_id}","starred_url":"https://api.github.com/users/6112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/6112/subscriptions","organizations_url":"https://api.github.com/users/6112/orgs","repos_url":"https://api.github.com/users/6112/repos","events_url":"https://api.github.com/users/6112/events{/privacy}","received_events_url":"https://api.github.com/users/6112/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/6112/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/6112/servo","forks_url":"https://api.github.com/repos/6112/servo/forks","keys_url":"https://api.github.com/repos/6112/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/6112/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/6112/servo/teams","hooks_url":"https://api.github.com/repos/6112/servo/hooks","issue_events_url":"https://api.github.com/repos/6112/servo/issues/events{/number}","events_url":"https://api.github.com/repos/6112/servo/events","assignees_url":"https://api.github.com/repos/6112/servo/assignees{/user}","branches_url":"https://api.github.com/repos/6112/servo/branches{/branch}","tags_url":"https://api.github.com/repos/6112/servo/tags","blobs_url":"https://api.github.com/repos/6112/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/6112/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/6112/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/6112/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/6112/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/6112/servo/languages","stargazers_url":"https://api.github.com/repos/6112/servo/stargazers","contributors_url":"https://api.github.com/repos/6112/servo/contributors","subscribers_url":"https://api.github.com/repos/6112/servo/subscribers","subscription_url":"https://api.github.com/repos/6112/servo/subscription","commits_url":"https://api.github.com/repos/6112/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/6112/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/6112/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/6112/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/6112/servo/contents/{+path}","compare_url":"https://api.github.com/repos/6112/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/6112/servo/merges","archive_url":"https://api.github.com/repos/6112/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/6112/servo/downloads","issues_url":"https://api.github.com/repos/6112/servo/issues{/number}","pulls_url":"https://api.github.com/repos/6112/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/6112/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/6112/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/6112/servo/labels{/name}","releases_url":"https://api.github.com/repos/6112/servo/releases{/id}","created_at":"2015-09-29T21:19:01Z","updated_at":"2015-09-29T20:04:49Z","pushed_at":"2015-10-02T19:03:17Z","git_url":"git://github.com/6112/servo.git","ssh_url":"git@github.com:6112/servo.git","clone_url":"https://github.com/6112/servo.git","svn_url":"https://github.com/6112/servo","homepage":"","size":133880,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"8865410ffc7998b1c74b5acda24507a07289fd1a","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","created_at":"2012-02-08T19:07:25Z","updated_at":"2015-10-02T18:45:40Z","pushed_at":"2015-10-02T19:26:07Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"","size":5891108,"stargazers_count":4952,"watchers_count":4952,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":780,"mirror_url":null,"open_issues_count":1111,"forks":780,"open_issues":1111,"watchers":4952,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/7836"},"html":{"href":"https://github.com/servo/servo/pull/7836"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/7836"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/7836/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/7836/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/7836/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/3db1e6e4f4ece6a9508ca7062ae10745e09d9e75"}}}}