{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/46412160","id":46412160,"diff_hunk":"@@ -43,4 +50,23 @@ public function getType( $wikiId, $pageId ) {\n \n \t\treturn $templateType;\n \t}\n+\n+\t/**\n+\t * Verify template type before user classification\n+\t *\n+\t * @param int $wikiId\n+\t * @param int $pageId\n+\t * @param string $templateType\n+\t * @param string $origin\n+\t * @throws BadRequestApiException\n+\t */\n+\tpublic function classifyTemplate( $wikiId, $pageId, $templateType, $origin ) {\n+\t\tif ( !in_array( $templateType, self::$templateTypes ) ) {\n+\t\t\tthrow new ApiException( self::CLASSIFY_TEMPLATE_EXCEPTION_MESSAGE, self::CLASSIFY_TEMPLATE_EXCEPTION_CODE );\n+\t\t}\n+\n+\t\tparent::classifyTemplate( $wikiId, $pageId, $templateType, self::USER_PROVIDER, $origin );\n+\n+\t\twfRunHooks( 'UserTemplateClassification::TemplateClassified', [ $wikiId, $pageId, $templateType ] );","path":"extensions/wikia/TemplateClassification/services/UserTemplateClassificationService.class.php","position":35,"original_position":35,"commit_id":"a0ce83ead113a411a942d58b60739a03d495a339","original_commit_id":"a0ce83ead113a411a942d58b60739a03d495a339","user":{"login":"SebastianMarzjan","id":2051084,"avatar_url":"https://avatars.githubusercontent.com/u/2051084?v=3","gravatar_id":"","url":"https://api.github.com/users/SebastianMarzjan","html_url":"https://github.com/SebastianMarzjan","followers_url":"https://api.github.com/users/SebastianMarzjan/followers","following_url":"https://api.github.com/users/SebastianMarzjan/following{/other_user}","gists_url":"https://api.github.com/users/SebastianMarzjan/gists{/gist_id}","starred_url":"https://api.github.com/users/SebastianMarzjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SebastianMarzjan/subscriptions","organizations_url":"https://api.github.com/users/SebastianMarzjan/orgs","repos_url":"https://api.github.com/users/SebastianMarzjan/repos","events_url":"https://api.github.com/users/SebastianMarzjan/events{/privacy}","received_events_url":"https://api.github.com/users/SebastianMarzjan/received_events","type":"User","site_admin":false},"body":"In this flow, \r\nhttps://github.com/Wikia/app/pull/9206/files#diff-51080aaef54b01dd7a86c59c827a2761R124\r\nand\r\nhttps://github.com/Wikia/app/pull/9206/files#diff-2e8dea429e8ffb59895bd46f92ed5942R139\r\nboth need to build the title object.\r\nWhat is the reason behind passing $pageId instead of a valid Title?\r\n","created_at":"2015-12-02T13:18:52Z","updated_at":"2015-12-02T13:18:52Z","html_url":"https://github.com/Wikia/app/pull/9206#discussion_r46412160","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/9206","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/46412160"},"html":{"href":"https://github.com/Wikia/app/pull/9206#discussion_r46412160"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/9206"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/9206","id":52388318,"html_url":"https://github.com/Wikia/app/pull/9206","diff_url":"https://github.com/Wikia/app/pull/9206.diff","patch_url":"https://github.com/Wikia/app/pull/9206.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/9206","number":9206,"state":"open","locked":false,"title":" CE-3073: Verify template type classified by user","user":{"login":"lukaszkonieczny","id":3470655,"avatar_url":"https://avatars.githubusercontent.com/u/3470655?v=3","gravatar_id":"","url":"https://api.github.com/users/lukaszkonieczny","html_url":"https://github.com/lukaszkonieczny","followers_url":"https://api.github.com/users/lukaszkonieczny/followers","following_url":"https://api.github.com/users/lukaszkonieczny/following{/other_user}","gists_url":"https://api.github.com/users/lukaszkonieczny/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszkonieczny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszkonieczny/subscriptions","organizations_url":"https://api.github.com/users/lukaszkonieczny/orgs","repos_url":"https://api.github.com/users/lukaszkonieczny/repos","events_url":"https://api.github.com/users/lukaszkonieczny/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszkonieczny/received_events","type":"User","site_admin":false},"body":"+ move hook to classifying method\r\n\r\n/cc @Wikia/community-engineering @kamilkoterba @SebastianMarzjan ","created_at":"2015-12-02T12:17:57Z","updated_at":"2015-12-02T13:18:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2074db14ed5cf9e99c52c56291b5fb8d2f75fbf6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/9206/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/9206/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/9206/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/a0ce83ead113a411a942d58b60739a03d495a339","head":{"label":"Wikia:CE-3073","ref":"CE-3073","sha":"a0ce83ead113a411a942d58b60739a03d495a339","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-11-25T22:05:09Z","pushed_at":"2015-12-02T13:04:35Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":661199,"stargazers_count":95,"watchers_count":95,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":75,"forks":70,"open_issues":75,"watchers":95,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"2f4ded702523cdb68373ff16ccc844f220081f61","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-11-25T22:05:09Z","pushed_at":"2015-12-02T13:04:35Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":661199,"stargazers_count":95,"watchers_count":95,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":75,"forks":70,"open_issues":75,"watchers":95,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/9206"},"html":{"href":"https://github.com/Wikia/app/pull/9206"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/9206"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/9206/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/9206/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/9206/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/a0ce83ead113a411a942d58b60739a03d495a339"}}}}