{"comment":{"url":"https://api.github.com/repos/kalessil/phpseclib/comments/12692331","html_url":"https://github.com/kalessil/phpseclib/commit/b3defbc78e788f19ae1c7fd06ecb029ce8955e30#commitcomment-12692331","id":12692331,"user":{"login":"terrafrost","id":214474,"avatar_url":"https://avatars.githubusercontent.com/u/214474?v=3","gravatar_id":"","url":"https://api.github.com/users/terrafrost","html_url":"https://github.com/terrafrost","followers_url":"https://api.github.com/users/terrafrost/followers","following_url":"https://api.github.com/users/terrafrost/following{/other_user}","gists_url":"https://api.github.com/users/terrafrost/gists{/gist_id}","starred_url":"https://api.github.com/users/terrafrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrafrost/subscriptions","organizations_url":"https://api.github.com/users/terrafrost/orgs","repos_url":"https://api.github.com/users/terrafrost/repos","events_url":"https://api.github.com/users/terrafrost/events{/privacy}","received_events_url":"https://api.github.com/users/terrafrost/received_events","type":"User","site_admin":false},"position":5,"line":2787,"path":"phpseclib/File/X509.php","commit_id":"b3defbc78e788f19ae1c7fd06ecb029ce8955e30","created_at":"2015-08-13T15:35:09Z","updated_at":"2015-08-13T15:35:09Z","body":"So I don't have a unit test for this specific return by reference but, as a general rule, the return by references are intended and removing the ampersand will actually break things.\r\n\r\n#772 demonstrates this.\r\n\r\nSo I think for all return by references...  either come up with a unit test showing the before and after behavior for each return by reference you're removing or don't remove them at  all."}}