{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/47384937","id":47384937,"diff_hunk":"@@ -192,15 +193,17 @@ export default {\n \t\tanalytics.pageView.record( basePath, ANALYTICS_PAGE_TITLE + ' > Notifications' );\n \n \t\tReact.render(\n-\t\t\tReact.createElement( NotificationsComponent,\n-\t\t\t\t{\n-\t\t\t\t\tuser: user,\n-\t\t\t\t\tuserSettings: userSettings,\n-\t\t\t\t\tblogs: sites,\n-\t\t\t\t\tdevices: devices,\n-\t\t\t\t\tpath: context.path\n-\t\t\t\t}\n-\t\t\t),\n+\t\t\tReact.createElement( Provider, { store: context.store }, () => {","path":"client/me/controller.js","position":21,"original_position":21,"commit_id":"e50178afe32c8190fce7e62f522cfc8b85f6eadc","original_commit_id":"e50178afe32c8190fce7e62f522cfc8b85f6eadc","user":{"login":"drewblaisdell","id":1130674,"avatar_url":"https://avatars.githubusercontent.com/u/1130674?v=3","gravatar_id":"","url":"https://api.github.com/users/drewblaisdell","html_url":"https://github.com/drewblaisdell","followers_url":"https://api.github.com/users/drewblaisdell/followers","following_url":"https://api.github.com/users/drewblaisdell/following{/other_user}","gists_url":"https://api.github.com/users/drewblaisdell/gists{/gist_id}","starred_url":"https://api.github.com/users/drewblaisdell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewblaisdell/subscriptions","organizations_url":"https://api.github.com/users/drewblaisdell/orgs","repos_url":"https://api.github.com/users/drewblaisdell/repos","events_url":"https://api.github.com/users/drewblaisdell/events{/privacy}","received_events_url":"https://api.github.com/users/drewblaisdell/received_events","type":"User","site_admin":false},"body":"If the root layout component is wrapped in `<Provider />`, why do we need to wrap `NotificationsComponent` in it here? Would upgrading to 0.14 obviate this?","created_at":"2015-12-11T18:08:45Z","updated_at":"2015-12-11T18:08:45Z","html_url":"https://github.com/Automattic/wp-calypso/pull/1496#discussion_r47384937","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1496","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/47384937"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/1496#discussion_r47384937"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1496"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1496","id":53395843,"html_url":"https://github.com/Automattic/wp-calypso/pull/1496","diff_url":"https://github.com/Automattic/wp-calypso/pull/1496.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/1496.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1496","number":1496,"state":"open","locked":false,"title":"Notices: Redux everything!","user":{"login":"artpi","id":3775068,"avatar_url":"https://avatars.githubusercontent.com/u/3775068?v=3","gravatar_id":"","url":"https://api.github.com/users/artpi","html_url":"https://github.com/artpi","followers_url":"https://api.github.com/users/artpi/followers","following_url":"https://api.github.com/users/artpi/following{/other_user}","gists_url":"https://api.github.com/users/artpi/gists{/gist_id}","starred_url":"https://api.github.com/users/artpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artpi/subscriptions","organizations_url":"https://api.github.com/users/artpi/orgs","repos_url":"https://api.github.com/users/artpi/repos","events_url":"https://api.github.com/users/artpi/events{/privacy}","received_events_url":"https://api.github.com/users/artpi/received_events","type":"User","site_admin":false},"body":"Part of ongoing effort to clean up notices:\r\n#888 #1094 #1105 #1313 #1364\r\n\r\nThis is how notices will look like in the future: #1415\r\n\r\n# What is going on here?\r\nWell, we want global notices to be in redux store.\r\n\r\nThis PR introduces second system for global notices, which relies on redux store.\r\nBecause sending notices needs the component to be connected and we have many of those, I want to have both notices systems operational at once so that we can gradually move from old to new one in a couple of PRs.\r\nThen, we will phase out the old one.\r\n\r\nThis PR provides:\r\n- Store for notices\r\n- Component for displaying them\r\n- Shows notices from `notification-settings` as an example.\r\n\r\n# But you're doing it wrong!\r\nI'm open fo suggestions :)\r\n\r\n# Plan for now\r\n- Polish and finish this. This will introduce second global notification system and 2 will be active at once. \r\n- in different PRs gradually switch from old notice system to new one implementing more comple use cases\r\n- Phase out old system\r\n\r\n# TODO\r\n[ ] tests\r\n","created_at":"2015-12-11T14:04:21Z","updated_at":"2015-12-11T18:08:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ca262ab554beca09d2eb2020738c0c35b980b93","assignee":{"login":"artpi","id":3775068,"avatar_url":"https://avatars.githubusercontent.com/u/3775068?v=3","gravatar_id":"","url":"https://api.github.com/users/artpi","html_url":"https://github.com/artpi","followers_url":"https://api.github.com/users/artpi/followers","following_url":"https://api.github.com/users/artpi/following{/other_user}","gists_url":"https://api.github.com/users/artpi/gists{/gist_id}","starred_url":"https://api.github.com/users/artpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artpi/subscriptions","organizations_url":"https://api.github.com/users/artpi/orgs","repos_url":"https://api.github.com/users/artpi/repos","events_url":"https://api.github.com/users/artpi/events{/privacy}","received_events_url":"https://api.github.com/users/artpi/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/20","html_url":"https://github.com/Automattic/wp-calypso/milestones/Core:%20Iteration%2017","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/20/labels","id":1420284,"number":20,"title":"Core: Iteration 17","description":"","creator":{"login":"hoverduck","id":7233112,"avatar_url":"https://avatars.githubusercontent.com/u/7233112?v=3","gravatar_id":"","url":"https://api.github.com/users/hoverduck","html_url":"https://github.com/hoverduck","followers_url":"https://api.github.com/users/hoverduck/followers","following_url":"https://api.github.com/users/hoverduck/following{/other_user}","gists_url":"https://api.github.com/users/hoverduck/gists{/gist_id}","starred_url":"https://api.github.com/users/hoverduck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoverduck/subscriptions","organizations_url":"https://api.github.com/users/hoverduck/orgs","repos_url":"https://api.github.com/users/hoverduck/repos","events_url":"https://api.github.com/users/hoverduck/events{/privacy}","received_events_url":"https://api.github.com/users/hoverduck/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":19,"state":"open","created_at":"2015-11-19T17:10:22Z","updated_at":"2015-12-11T14:54:19Z","due_on":"2015-12-31T06:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1496/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1496/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1496/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/e50178afe32c8190fce7e62f522cfc8b85f6eadc","head":{"label":"Automattic:add/redux-notices","ref":"add/redux-notices","sha":"e50178afe32c8190fce7e62f522cfc8b85f6eadc","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","created_at":"2015-11-10T20:00:16Z","updated_at":"2015-12-11T18:03:39Z","pushed_at":"2015-12-11T18:04:37Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":12514,"stargazers_count":6078,"watchers_count":6078,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":658,"mirror_url":null,"open_issues_count":842,"forks":658,"open_issues":842,"watchers":6078,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"bc9f4a3c99e522c0bf86f5082807494695b3959a","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","created_at":"2015-11-10T20:00:16Z","updated_at":"2015-12-11T18:03:39Z","pushed_at":"2015-12-11T18:04:37Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":12514,"stargazers_count":6078,"watchers_count":6078,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":658,"mirror_url":null,"open_issues_count":842,"forks":658,"open_issues":842,"watchers":6078,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1496"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/1496"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/1496"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/1496/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1496/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1496/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/e50178afe32c8190fce7e62f522cfc8b85f6eadc"}}}}