{"action":"created","issue":{"url":"https://api.github.com/repos/popcornmix/omxplayer/issues/326","labels_url":"https://api.github.com/repos/popcornmix/omxplayer/issues/326/labels{/name}","comments_url":"https://api.github.com/repos/popcornmix/omxplayer/issues/326/comments","events_url":"https://api.github.com/repos/popcornmix/omxplayer/issues/326/events","html_url":"https://github.com/popcornmix/omxplayer/pull/326","id":60771876,"number":326,"title":"Fix #313 by catching when unhide occurs and explicitly re-opening video player","user":{"login":"tdicola","id":1332183,"avatar_url":"https://avatars.githubusercontent.com/u/1332183?v=3","gravatar_id":"","url":"https://api.github.com/users/tdicola","html_url":"https://github.com/tdicola","followers_url":"https://api.github.com/users/tdicola/followers","following_url":"https://api.github.com/users/tdicola/following{/other_user}","gists_url":"https://api.github.com/users/tdicola/gists{/gist_id}","starred_url":"https://api.github.com/users/tdicola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdicola/subscriptions","organizations_url":"https://api.github.com/users/tdicola/orgs","repos_url":"https://api.github.com/users/tdicola/repos","events_url":"https://api.github.com/users/tdicola/events{/privacy}","received_events_url":"https://api.github.com/users/tdicola/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-12T05:06:28Z","updated_at":"2015-03-12T17:40:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/popcornmix/omxplayer/pulls/326","html_url":"https://github.com/popcornmix/omxplayer/pull/326","diff_url":"https://github.com/popcornmix/omxplayer/pull/326.diff","patch_url":"https://github.com/popcornmix/omxplayer/pull/326.patch"},"body":"This fixes a bug with the hide & unhide video actions, #313.  The issue is that hide will close the video player component and unhide will cause a seek which expects the video player to be re-opened.  However an optimization was made to seek so that it wouldn't close and re-open the video player (#322), and this ends up breaking unhide.\r\n\r\nAs a fix this change catches the case where unhide occurs and does an explicit re-open of the video player.  For all other seeks (like looping, user initiated seek, etc.) the quick reset occurs instead of a full close & open.\r\n\r\nI tested this by playing a video and using the dbuscontrol.sh to run hide, unhide, and setvideopos.  Before the fix hide would work but neither unhide or setvideopos would work as expected.  After the fix the same commands work as expected--hide will stop displaying the video, unhide will show the video again, and setvideopos will change what area of the screen displays the video."},"comment":{"url":"https://api.github.com/repos/popcornmix/omxplayer/issues/comments/78542321","html_url":"https://github.com/popcornmix/omxplayer/pull/326#issuecomment-78542321","issue_url":"https://api.github.com/repos/popcornmix/omxplayer/issues/326","id":78542321,"user":{"login":"popcornmix","id":1053730,"avatar_url":"https://avatars.githubusercontent.com/u/1053730?v=3","gravatar_id":"","url":"https://api.github.com/users/popcornmix","html_url":"https://github.com/popcornmix","followers_url":"https://api.github.com/users/popcornmix/followers","following_url":"https://api.github.com/users/popcornmix/following{/other_user}","gists_url":"https://api.github.com/users/popcornmix/gists{/gist_id}","starred_url":"https://api.github.com/users/popcornmix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popcornmix/subscriptions","organizations_url":"https://api.github.com/users/popcornmix/orgs","repos_url":"https://api.github.com/users/popcornmix/repos","events_url":"https://api.github.com/users/popcornmix/events{/privacy}","received_events_url":"https://api.github.com/users/popcornmix/received_events","type":"User","site_admin":false},"created_at":"2015-03-12T17:40:14Z","updated_at":"2015-03-12T17:40:14Z","body":"Can you squash the two commits and force push?"}}