{"push_id":696126489,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"2954df3d3a5b02dfeed1bc955555c9889810998f","before":"757f7a8d2f1b6d8de770345e0e6edb01fb7084c5","commits":[{"sha":"2954df3d3a5b02dfeed1bc955555c9889810998f","author":{"email":"75509ea3e75a7bf67afd5aa8148f466bc3862b07@users.noreply.github.com","name":"John Lacey"},"message":"Remove FileDeletionObject.\n\nThis is a prelude to removing IBaseObject.\n\nFileDeletionObject is a marker interface that simply delegates to the\nunderlying IBaseObject, but that will be more difficult when we\nreplace IBaseObject with IndependentObject, which has many more\nmethods. Instead, the objects in the three IObjectSets are wrapped in\na new non-delegating DocumentWrapper class that has an explicit type\nfor distinguishing added or updated documents from deleted documents\nreturned by the additional delete query. (DeletionEvents continue to\nbe identified using instanceof.)\n\nThe complicated changes are in the tests.\n\nThe tests started with the standard three sets of objects, but poured\nthem all into a map for the object store, illicitly wrapping the\ncustom deletions in FileDeletionObject (even before passing them to\nFileDocumentList, which would wrap them again). Then the three sets\nwere extracted from the map by checking for instances of DeletionEvent\nand FileDeletionObject.\n\nThis change flips this, so that we always start with three IObjectSets\ncontaining unwrapped IBaseObjects, as in production. Then we put those\ninto the object store map, before passing the sets to FileDocumentList.\n(The object store is used under the covers in FileDocument as before.)\n\nTest notes:\n\n* The sorting tests had only one non-empty object set, for documents.\n  I have made this obvious, as a natural part of this change.\n\n* newObjectStore takes a varargs array of IObjectSets and constructs\n  the map internally.\n\n* Merge the two testUnreleasedNextDocument methods.\n\n* Remove the unused String[] overload of generateObjectMap and both\n  overloads of generateCustomDeletion.\n\n* getCustomDeletions (formerly getCustomDeletion) is an alias of\n  getDocuments maintained for readability.\n\nOther changes:\n\n* Added two forgotten @Test annotations.\n\nCode review: https://codereview.appspot.com/248880043/","distinct":true,"url":"https://api.github.com/repos/googlegsa/filenet.v3/commits/2954df3d3a5b02dfeed1bc955555c9889810998f"}]}