{"action":"created","comment":{"url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/comments/45436513","id":45436513,"diff_hunk":"@@ -69,31 +75,52 @@ cdef void sub_update(FLOAT[:, ::1] XY,\n     ############################################################\n     # SUBPROBLEM 2: use the grid values to reduce the number of other\n     # objects to check for collisions.\n-    for j in range(i + 1, count):\n-        XY2 = &(XY[j, 0])\n-        V2 = &(V[j, 0])\n-        if overlapping(XY1, XY2, R):\n-            # SUBPROBLEM 4: Add locking\n-            if not moving_apart(XY1, V1, XY2, V2):\n-                collide(XY1, V1, XY2, V2)\n-\n-            # give a slight impulse to help separate them\n-            for dim in range(2):\n-                V2[dim] += eps * (XY2[dim] - XY1[dim])\n+    for ii in range(-4, 5):\n+        for jj in range(-4, 5):\n+            if ii==0 and jj==0: continue\n+            pos_i = <int>(XY1[0]/grid_spacing)+ii\n+            pos_j = <int>(XY1[1]/grid_spacing)+jj\n+            if pos_i<0 or pos_i>=gridsize: continue\n+            if pos_j<0 or pos_j>=gridsize: continue\n+\n+            j = Grid[pos_i, pos_j]\n+            if j!=-1 & i<j:\n+                # lock j","path":"HW2/P5/physics.pyx","position":53,"original_position":53,"commit_id":"bbbfcb06c774b88e3de72934976c4180f2aefae7","original_commit_id":"bbbfcb06c774b88e3de72934976c4180f2aefae7","user":{"login":"quezacot","id":9496382,"avatar_url":"https://avatars.githubusercontent.com/u/9496382?v=3","gravatar_id":"","url":"https://api.github.com/users/quezacot","html_url":"https://github.com/quezacot","followers_url":"https://api.github.com/users/quezacot/followers","following_url":"https://api.github.com/users/quezacot/following{/other_user}","gists_url":"https://api.github.com/users/quezacot/gists{/gist_id}","starred_url":"https://api.github.com/users/quezacot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quezacot/subscriptions","organizations_url":"https://api.github.com/users/quezacot/orgs","repos_url":"https://api.github.com/users/quezacot/repos","events_url":"https://api.github.com/users/quezacot/events{/privacy}","received_events_url":"https://api.github.com/users/quezacot/received_events","type":"User","site_admin":false},"body":"Good to catch that preventing the same two balls collide twice!","created_at":"2015-11-20T05:13:06Z","updated_at":"2015-11-20T05:13:06Z","html_url":"https://github.com/harvard-cs205/cs205-homework/pull/327#discussion_r45436513","pull_request_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/327","_links":{"self":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/comments/45436513"},"html":{"href":"https://github.com/harvard-cs205/cs205-homework/pull/327#discussion_r45436513"},"pull_request":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/327"}}},"pull_request":{"url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/327","id":49673258,"html_url":"https://github.com/harvard-cs205/cs205-homework/pull/327","diff_url":"https://github.com/harvard-cs205/cs205-homework/pull/327.diff","patch_url":"https://github.com/harvard-cs205/cs205-homework/pull/327.patch","issue_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/327","number":327,"state":"open","locked":false,"title":"HW2","user":{"login":"tobytoyuito","id":10595504,"avatar_url":"https://avatars.githubusercontent.com/u/10595504?v=3","gravatar_id":"","url":"https://api.github.com/users/tobytoyuito","html_url":"https://github.com/tobytoyuito","followers_url":"https://api.github.com/users/tobytoyuito/followers","following_url":"https://api.github.com/users/tobytoyuito/following{/other_user}","gists_url":"https://api.github.com/users/tobytoyuito/gists{/gist_id}","starred_url":"https://api.github.com/users/tobytoyuito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobytoyuito/subscriptions","organizations_url":"https://api.github.com/users/tobytoyuito/orgs","repos_url":"https://api.github.com/users/tobytoyuito/repos","events_url":"https://api.github.com/users/tobytoyuito/events{/privacy}","received_events_url":"https://api.github.com/users/tobytoyuito/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-04T10:48:57Z","updated_at":"2015-11-20T05:13:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"869d999392355c042cb98b7ba51b0edb65b64fdc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/327/commits","review_comments_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/327/comments","review_comment_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/327/comments","statuses_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/statuses/bbbfcb06c774b88e3de72934976c4180f2aefae7","head":{"label":"tobytoyuito:HW2","ref":"HW2","sha":"bbbfcb06c774b88e3de72934976c4180f2aefae7","user":{"login":"tobytoyuito","id":10595504,"avatar_url":"https://avatars.githubusercontent.com/u/10595504?v=3","gravatar_id":"","url":"https://api.github.com/users/tobytoyuito","html_url":"https://github.com/tobytoyuito","followers_url":"https://api.github.com/users/tobytoyuito/followers","following_url":"https://api.github.com/users/tobytoyuito/following{/other_user}","gists_url":"https://api.github.com/users/tobytoyuito/gists{/gist_id}","starred_url":"https://api.github.com/users/tobytoyuito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobytoyuito/subscriptions","organizations_url":"https://api.github.com/users/tobytoyuito/orgs","repos_url":"https://api.github.com/users/tobytoyuito/repos","events_url":"https://api.github.com/users/tobytoyuito/events{/privacy}","received_events_url":"https://api.github.com/users/tobytoyuito/received_events","type":"User","site_admin":false},"repo":{"id":41892030,"name":"cs205-homework","full_name":"tobytoyuito/cs205-homework","owner":{"login":"tobytoyuito","id":10595504,"avatar_url":"https://avatars.githubusercontent.com/u/10595504?v=3","gravatar_id":"","url":"https://api.github.com/users/tobytoyuito","html_url":"https://github.com/tobytoyuito","followers_url":"https://api.github.com/users/tobytoyuito/followers","following_url":"https://api.github.com/users/tobytoyuito/following{/other_user}","gists_url":"https://api.github.com/users/tobytoyuito/gists{/gist_id}","starred_url":"https://api.github.com/users/tobytoyuito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobytoyuito/subscriptions","organizations_url":"https://api.github.com/users/tobytoyuito/orgs","repos_url":"https://api.github.com/users/tobytoyuito/repos","events_url":"https://api.github.com/users/tobytoyuito/events{/privacy}","received_events_url":"https://api.github.com/users/tobytoyuito/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tobytoyuito/cs205-homework","description":"","fork":true,"url":"https://api.github.com/repos/tobytoyuito/cs205-homework","forks_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/forks","keys_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/teams","hooks_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/hooks","issue_events_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/issues/events{/number}","events_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/events","assignees_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/assignees{/user}","branches_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/branches{/branch}","tags_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/tags","blobs_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/git/refs{/sha}","trees_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/statuses/{sha}","languages_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/languages","stargazers_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/stargazers","contributors_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/contributors","subscribers_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/subscribers","subscription_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/subscription","commits_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/commits{/sha}","git_commits_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/git/commits{/sha}","comments_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/comments{/number}","issue_comment_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/issues/comments{/number}","contents_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/contents/{+path}","compare_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/merges","archive_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/downloads","issues_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/issues{/number}","pulls_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/pulls{/number}","milestones_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/milestones{/number}","notifications_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/labels{/name}","releases_url":"https://api.github.com/repos/tobytoyuito/cs205-homework/releases{/id}","created_at":"2015-09-04T01:23:24Z","updated_at":"2015-09-04T01:23:24Z","pushed_at":"2015-11-19T04:12:56Z","git_url":"git://github.com/tobytoyuito/cs205-homework.git","ssh_url":"git@github.com:tobytoyuito/cs205-homework.git","clone_url":"https://github.com/tobytoyuito/cs205-homework.git","svn_url":"https://github.com/tobytoyuito/cs205-homework","homepage":null,"size":513,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"harvard-cs205:master","ref":"master","sha":"ed6f0167fd1f6097ce9e454c2950c5db00a0c513","user":{"login":"harvard-cs205","id":13456002,"avatar_url":"https://avatars.githubusercontent.com/u/13456002?v=3","gravatar_id":"","url":"https://api.github.com/users/harvard-cs205","html_url":"https://github.com/harvard-cs205","followers_url":"https://api.github.com/users/harvard-cs205/followers","following_url":"https://api.github.com/users/harvard-cs205/following{/other_user}","gists_url":"https://api.github.com/users/harvard-cs205/gists{/gist_id}","starred_url":"https://api.github.com/users/harvard-cs205/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harvard-cs205/subscriptions","organizations_url":"https://api.github.com/users/harvard-cs205/orgs","repos_url":"https://api.github.com/users/harvard-cs205/repos","events_url":"https://api.github.com/users/harvard-cs205/events{/privacy}","received_events_url":"https://api.github.com/users/harvard-cs205/received_events","type":"Organization","site_admin":false},"repo":{"id":40614104,"name":"cs205-homework","full_name":"harvard-cs205/cs205-homework","owner":{"login":"harvard-cs205","id":13456002,"avatar_url":"https://avatars.githubusercontent.com/u/13456002?v=3","gravatar_id":"","url":"https://api.github.com/users/harvard-cs205","html_url":"https://github.com/harvard-cs205","followers_url":"https://api.github.com/users/harvard-cs205/followers","following_url":"https://api.github.com/users/harvard-cs205/following{/other_user}","gists_url":"https://api.github.com/users/harvard-cs205/gists{/gist_id}","starred_url":"https://api.github.com/users/harvard-cs205/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harvard-cs205/subscriptions","organizations_url":"https://api.github.com/users/harvard-cs205/orgs","repos_url":"https://api.github.com/users/harvard-cs205/repos","events_url":"https://api.github.com/users/harvard-cs205/events{/privacy}","received_events_url":"https://api.github.com/users/harvard-cs205/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/harvard-cs205/cs205-homework","description":"","fork":false,"url":"https://api.github.com/repos/harvard-cs205/cs205-homework","forks_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/forks","keys_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/teams","hooks_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/hooks","issue_events_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/events{/number}","events_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/events","assignees_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/assignees{/user}","branches_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/branches{/branch}","tags_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/tags","blobs_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/git/refs{/sha}","trees_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/statuses/{sha}","languages_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/languages","stargazers_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/stargazers","contributors_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/contributors","subscribers_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/subscribers","subscription_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/subscription","commits_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/commits{/sha}","git_commits_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/git/commits{/sha}","comments_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/comments{/number}","issue_comment_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/comments{/number}","contents_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/contents/{+path}","compare_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/merges","archive_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/downloads","issues_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues{/number}","pulls_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls{/number}","milestones_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/milestones{/number}","notifications_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/labels{/name}","releases_url":"https://api.github.com/repos/harvard-cs205/cs205-homework/releases{/id}","created_at":"2015-08-12T17:18:15Z","updated_at":"2015-10-21T19:21:28Z","pushed_at":"2015-11-20T05:12:37Z","git_url":"git://github.com/harvard-cs205/cs205-homework.git","ssh_url":"git@github.com:harvard-cs205/cs205-homework.git","clone_url":"https://github.com/harvard-cs205/cs205-homework.git","svn_url":"https://github.com/harvard-cs205/cs205-homework","homepage":null,"size":162893,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":394,"forks":99,"open_issues":394,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/327"},"html":{"href":"https://github.com/harvard-cs205/cs205-homework/pull/327"},"issue":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/327"},"comments":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/issues/327/comments"},"review_comments":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/327/comments"},"review_comment":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/pulls/327/commits"},"statuses":{"href":"https://api.github.com/repos/harvard-cs205/cs205-homework/statuses/bbbfcb06c774b88e3de72934976c4180f2aefae7"}}}}