{"action":"created","issue":{"url":"https://api.github.com/repos/Netflix/denominator/issues/270","labels_url":"https://api.github.com/repos/Netflix/denominator/issues/270/labels{/name}","comments_url":"https://api.github.com/repos/Netflix/denominator/issues/270/comments","events_url":"https://api.github.com/repos/Netflix/denominator/issues/270/events","html_url":"https://github.com/Netflix/denominator/pull/270","id":55154841,"number":270,"title":"Verisign mdns refactor","user":{"login":"sanjaympawar1","id":3072997,"avatar_url":"https://avatars.githubusercontent.com/u/3072997?v=3","gravatar_id":"","url":"https://api.github.com/users/sanjaympawar1","html_url":"https://github.com/sanjaympawar1","followers_url":"https://api.github.com/users/sanjaympawar1/followers","following_url":"https://api.github.com/users/sanjaympawar1/following{/other_user}","gists_url":"https://api.github.com/users/sanjaympawar1/gists{/gist_id}","starred_url":"https://api.github.com/users/sanjaympawar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanjaympawar1/subscriptions","organizations_url":"https://api.github.com/users/sanjaympawar1/orgs","repos_url":"https://api.github.com/users/sanjaympawar1/repos","events_url":"https://api.github.com/users/sanjaympawar1/events{/privacy}","received_events_url":"https://api.github.com/users/sanjaympawar1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-22T13:48:50Z","updated_at":"2015-01-23T03:07:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Netflix/denominator/pulls/270","html_url":"https://github.com/Netflix/denominator/pull/270","diff_url":"https://github.com/Netflix/denominator/pull/270.diff","patch_url":"https://github.com/Netflix/denominator/pull/270.patch"},"body":"Code review comments for earlier pull request are applied and code is updated."},"comment":{"url":"https://api.github.com/repos/Netflix/denominator/issues/comments/71141088","html_url":"https://github.com/Netflix/denominator/pull/270#issuecomment-71141088","issue_url":"https://api.github.com/repos/Netflix/denominator/issues/270","id":71141088,"user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"created_at":"2015-01-23T03:07:12Z","updated_at":"2015-01-23T03:07:12Z","body":"I appreciate that this is better than before, but prior comments weren't fully addressed before this was reposted. For example, having live tests, naming convention consistency, etc. Please be conscious that taking time to review takes me off other tasks. I don't have time to keep saying the same things.\r\n\r\nDenominator providers must not introduce new words like \"Helper\" etc. swallow exceptions or do other code malpractice. Code in this repository often outlives the author, we have to ensure the quality gates are met before merge, and that review time is least possible."}}