{"action":"created","issue":{"url":"https://api.github.com/repos/mlafeldt/sharness/issues/30","labels_url":"https://api.github.com/repos/mlafeldt/sharness/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/mlafeldt/sharness/issues/30/comments","events_url":"https://api.github.com/repos/mlafeldt/sharness/issues/30/events","html_url":"https://github.com/mlafeldt/sharness/pull/30","id":91506485,"number":30,"title":"save original TERM before sanitization","user":{"login":"grondo","id":741970,"avatar_url":"https://avatars.githubusercontent.com/u/741970?v=3","gravatar_id":"","url":"https://api.github.com/users/grondo","html_url":"https://github.com/grondo","followers_url":"https://api.github.com/users/grondo/followers","following_url":"https://api.github.com/users/grondo/following{/other_user}","gists_url":"https://api.github.com/users/grondo/gists{/gist_id}","starred_url":"https://api.github.com/users/grondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grondo/subscriptions","organizations_url":"https://api.github.com/users/grondo/orgs","repos_url":"https://api.github.com/users/grondo/repos","events_url":"https://api.github.com/users/grondo/events{/privacy}","received_events_url":"https://api.github.com/users/grondo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-06-27T19:50:52Z","updated_at":"2015-06-29T01:10:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mlafeldt/sharness/pulls/30","html_url":"https://github.com/mlafeldt/sharness/pull/30","diff_url":"https://github.com/mlafeldt/sharness/pull/30.diff","patch_url":"https://github.com/mlafeldt/sharness/pull/30.patch"},"body":"I'm not sure if this one will be acceptable, but we have a use case where our sharness test will reinvoke itself under our framework.\r\n\r\nBecuase `TERM` is now sanitized, we unnecessarily lose color output from the secondary sharness.\r\n\r\nThis change simply uses `SHARNESS_SAVED_TERM` to save the original `TERM` value, then resets `TERM` if `SHARNESS_SAVED_TERM` is found."},"comment":{"url":"https://api.github.com/repos/mlafeldt/sharness/issues/comments/116366006","html_url":"https://github.com/mlafeldt/sharness/pull/30#issuecomment-116366006","issue_url":"https://api.github.com/repos/mlafeldt/sharness/issues/30","id":116366006,"user":{"login":"richardhansen","id":1612291,"avatar_url":"https://avatars.githubusercontent.com/u/1612291?v=3","gravatar_id":"","url":"https://api.github.com/users/richardhansen","html_url":"https://github.com/richardhansen","followers_url":"https://api.github.com/users/richardhansen/followers","following_url":"https://api.github.com/users/richardhansen/following{/other_user}","gists_url":"https://api.github.com/users/richardhansen/gists{/gist_id}","starred_url":"https://api.github.com/users/richardhansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardhansen/subscriptions","organizations_url":"https://api.github.com/users/richardhansen/orgs","repos_url":"https://api.github.com/users/richardhansen/repos","events_url":"https://api.github.com/users/richardhansen/events{/privacy}","received_events_url":"https://api.github.com/users/richardhansen/received_events","type":"User","site_admin":false},"created_at":"2015-06-29T01:10:34Z","updated_at":"2015-06-29T01:10:34Z","body":"> I'd really like to write a test case but was struggling how to programmatically test for color output. let me ponder that one further, but if anyone has any ideas let me know.\r\n\r\nHow about `[ -n \"$color\" ]` in a subtest?  It doesn't test the actual color codes, but it does test to see if color is still enabled.\r\n\r\n> Rebased with change to SHARNESS_ORIG_TERM\r\n> \r\n> I also added a test to at least ensure SHARNESS_ORIG_TERM is propagated to sub-sharness.\r\n\r\nThank you!"}}