{"action":"created","issue":{"url":"https://api.github.com/repos/bbatsov/rubocop/issues/2352","labels_url":"https://api.github.com/repos/bbatsov/rubocop/issues/2352/labels{/name}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/2352/comments","events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/2352/events","html_url":"https://github.com/bbatsov/rubocop/pull/2352","id":113468651,"number":2352,"title":"[Fix #2262] Replace Rainbow reference with Colorizable#yellow","user":{"login":"minustehbare","id":493868,"avatar_url":"https://avatars.githubusercontent.com/u/493868?v=3","gravatar_id":"","url":"https://api.github.com/users/minustehbare","html_url":"https://github.com/minustehbare","followers_url":"https://api.github.com/users/minustehbare/followers","following_url":"https://api.github.com/users/minustehbare/following{/other_user}","gists_url":"https://api.github.com/users/minustehbare/gists{/gist_id}","starred_url":"https://api.github.com/users/minustehbare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minustehbare/subscriptions","organizations_url":"https://api.github.com/users/minustehbare/orgs","repos_url":"https://api.github.com/users/minustehbare/repos","events_url":"https://api.github.com/users/minustehbare/events{/privacy}","received_events_url":"https://api.github.com/users/minustehbare/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-26T22:57:24Z","updated_at":"2015-10-27T14:26:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/2352","html_url":"https://github.com/bbatsov/rubocop/pull/2352","diff_url":"https://github.com/bbatsov/rubocop/pull/2352.diff","patch_url":"https://github.com/bbatsov/rubocop/pull/2352.patch"},"body":"As described in #2262, using the `--format simple --out some_file.txt` options caused colors to be output into the text file even though they are not supported.  The cause of this problem was a reference to `Rainbow('\\1').yellow` which is enabled by default.\r\n\r\nUsing the methods mixed in through the `Colorizable` module, I replaced this call with `Colorizable#yellow` which respects the output's support (or lack thereof) for coloring."},"comment":{"url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments/151514934","html_url":"https://github.com/bbatsov/rubocop/pull/2352#issuecomment-151514934","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/2352","id":151514934,"user":{"login":"minustehbare","id":493868,"avatar_url":"https://avatars.githubusercontent.com/u/493868?v=3","gravatar_id":"","url":"https://api.github.com/users/minustehbare","html_url":"https://github.com/minustehbare","followers_url":"https://api.github.com/users/minustehbare/followers","following_url":"https://api.github.com/users/minustehbare/following{/other_user}","gists_url":"https://api.github.com/users/minustehbare/gists{/gist_id}","starred_url":"https://api.github.com/users/minustehbare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minustehbare/subscriptions","organizations_url":"https://api.github.com/users/minustehbare/orgs","repos_url":"https://api.github.com/users/minustehbare/repos","events_url":"https://api.github.com/users/minustehbare/events{/privacy}","received_events_url":"https://api.github.com/users/minustehbare/received_events","type":"User","site_admin":false},"created_at":"2015-10-27T14:26:37Z","updated_at":"2015-10-27T14:26:37Z","body":"Apologies for not including it in the original pull.  It doesn't appear that the `SimpleTextFormatter` spec has any tests related to coloring so I will need to spend some time figuring out how to best incorporate it.\r\n\r\nOnce I have the test(s) written, would you like the commit separate or squashed with the fix itself so it is atomized?"}}