{"action":"created","issue":{"url":"https://api.github.com/repos/boonebgorges/bp-groupblog/issues/35","labels_url":"https://api.github.com/repos/boonebgorges/bp-groupblog/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/boonebgorges/bp-groupblog/issues/35/comments","events_url":"https://api.github.com/repos/boonebgorges/bp-groupblog/issues/35/events","html_url":"https://github.com/boonebgorges/bp-groupblog/pull/35","id":59649711,"number":35,"title":"Add missing params to `groups_details_updated` action","user":{"login":"christianwach","id":726936,"avatar_url":"https://avatars.githubusercontent.com/u/726936?v=3","gravatar_id":"","url":"https://api.github.com/users/christianwach","html_url":"https://github.com/christianwach","followers_url":"https://api.github.com/users/christianwach/followers","following_url":"https://api.github.com/users/christianwach/following{/other_user}","gists_url":"https://api.github.com/users/christianwach/gists{/gist_id}","starred_url":"https://api.github.com/users/christianwach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianwach/subscriptions","organizations_url":"https://api.github.com/users/christianwach/orgs","repos_url":"https://api.github.com/users/christianwach/repos","events_url":"https://api.github.com/users/christianwach/events{/privacy}","received_events_url":"https://api.github.com/users/christianwach/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-03T14:36:05Z","updated_at":"2015-03-03T18:25:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/boonebgorges/bp-groupblog/pulls/35","html_url":"https://github.com/boonebgorges/bp-groupblog/pull/35","diff_url":"https://github.com/boonebgorges/bp-groupblog/pull/35.diff","patch_url":"https://github.com/boonebgorges/bp-groupblog/pull/35.patch"},"body":"The hook signature of the `groups_details_updated` action has changed in BuddyPress 2.2.0. Two new params added, see:\r\nhttps://buddypress.trac.wordpress.org/changeset/9204\r\n\r\nThis PR adds default values that prevent `bp_groups_group_details_updated_add_activity()` from throwing a \"missing parameters\" error. Also copies in the docblock for the hook for reference."},"comment":{"url":"https://api.github.com/repos/boonebgorges/bp-groupblog/issues/comments/77003760","html_url":"https://github.com/boonebgorges/bp-groupblog/pull/35#issuecomment-77003760","issue_url":"https://api.github.com/repos/boonebgorges/bp-groupblog/issues/35","id":77003760,"user":{"login":"boonebgorges","id":246627,"avatar_url":"https://avatars.githubusercontent.com/u/246627?v=3","gravatar_id":"","url":"https://api.github.com/users/boonebgorges","html_url":"https://github.com/boonebgorges","followers_url":"https://api.github.com/users/boonebgorges/followers","following_url":"https://api.github.com/users/boonebgorges/following{/other_user}","gists_url":"https://api.github.com/users/boonebgorges/gists{/gist_id}","starred_url":"https://api.github.com/users/boonebgorges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boonebgorges/subscriptions","organizations_url":"https://api.github.com/users/boonebgorges/orgs","repos_url":"https://api.github.com/users/boonebgorges/repos","events_url":"https://api.github.com/users/boonebgorges/events{/privacy}","received_events_url":"https://api.github.com/users/boonebgorges/received_events","type":"User","site_admin":false},"created_at":"2015-03-03T18:25:56Z","updated_at":"2015-03-03T18:25:56Z","body":"Good catch. It seems to me that we should not be using this hook here at all. It's a BP core hook. We should be using `'groupblog_details_updated'`. I think it's probably a typo that it's like this at all. What do you think?"}}