{"action":"opened","number":375,"pull_request":{"url":"https://api.github.com/repos/bengardner/uncrustify/pulls/375","id":35554343,"html_url":"https://github.com/bengardner/uncrustify/pull/375","diff_url":"https://github.com/bengardner/uncrustify/pull/375.diff","patch_url":"https://github.com/bengardner/uncrustify/pull/375.patch","issue_url":"https://api.github.com/repos/bengardner/uncrustify/issues/375","number":375,"state":"open","locked":false,"title":"Commit vs2015 upgrade of the solution file","user":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"body":"So this is the third time the Windows machines has decided to self destruct with this license expiration:\r\n\r\nhttp://54.183.26.131:8080/job/ros2_batch_ci_windows/240/console\r\n```\r\n         Microsoft Visual Studio 2015 RC Version 14.0.22823.1.\r\n         Copyright (C) Microsoft Corp. All rights reserved.\r\n         \r\n         The license for Visual Studio has expired.\r\n         \r\n         The evaluation period for this product has ended.\r\n```\r\n\r\nThis only happens when Jenkins is running the job. I cannot reproduce the problem when using `cmd.exe` from the desktop. I've tried:\r\n\r\n- Running the Jenkins slave as my user.\r\n- Force setting the `USERNAME` env variable to `osrf`.\r\n- Getting a new developer license (https://msdn.microsoft.com/en-us/library/windows/apps/hh974578.aspx)\r\n- Repairing the VS2015 installation.\r\n\r\nNone of these have worked. That last time I fixed this issue by reinstalling Windows...\r\n\r\nThe weird thing is that this failure only occurs when `uncrustify` runs `devenv` to upgrade the solution file, and not when invoking msbuild or compiling/linking. With this pull request I've committed that upgrade to the solution file and disabled the upgrade step in CMake. This at least allows the build to continue until it gets to the idl parser error https://github.com/ros2/rcl_interfaces/issues/2, see:\r\n\r\nhttp://54.183.26.131:8080/job/ros2_batch_ci_windows/241/console\r\n\r\nIf I can't come up with another solution then this will have to be the work around for now.","created_at":"2015-05-15T21:53:31Z","updated_at":"2015-05-15T21:53:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bengardner/uncrustify/pulls/375/commits","review_comments_url":"https://api.github.com/repos/bengardner/uncrustify/pulls/375/comments","review_comment_url":"https://api.github.com/repos/bengardner/uncrustify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bengardner/uncrustify/issues/375/comments","statuses_url":"https://api.github.com/repos/bengardner/uncrustify/statuses/7d1385abd963a585e45b772a9186a5acacee8dad","head":{"label":"ament:vs2015","ref":"vs2015","sha":"7d1385abd963a585e45b772a9186a5acacee8dad","user":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=3","gravatar_id":"","url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"repo":{"id":33959751,"name":"uncrustify","full_name":"ament/uncrustify","owner":{"login":"ament","id":7365061,"avatar_url":"https://avatars.githubusercontent.com/u/7365061?v=3","gravatar_id":"","url":"https://api.github.com/users/ament","html_url":"https://github.com/ament","followers_url":"https://api.github.com/users/ament/followers","following_url":"https://api.github.com/users/ament/following{/other_user}","gists_url":"https://api.github.com/users/ament/gists{/gist_id}","starred_url":"https://api.github.com/users/ament/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ament/subscriptions","organizations_url":"https://api.github.com/users/ament/orgs","repos_url":"https://api.github.com/users/ament/repos","events_url":"https://api.github.com/users/ament/events{/privacy}","received_events_url":"https://api.github.com/users/ament/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ament/uncrustify","description":"Code beautifier","fork":true,"url":"https://api.github.com/repos/ament/uncrustify","forks_url":"https://api.github.com/repos/ament/uncrustify/forks","keys_url":"https://api.github.com/repos/ament/uncrustify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ament/uncrustify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ament/uncrustify/teams","hooks_url":"https://api.github.com/repos/ament/uncrustify/hooks","issue_events_url":"https://api.github.com/repos/ament/uncrustify/issues/events{/number}","events_url":"https://api.github.com/repos/ament/uncrustify/events","assignees_url":"https://api.github.com/repos/ament/uncrustify/assignees{/user}","branches_url":"https://api.github.com/repos/ament/uncrustify/branches{/branch}","tags_url":"https://api.github.com/repos/ament/uncrustify/tags","blobs_url":"https://api.github.com/repos/ament/uncrustify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ament/uncrustify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ament/uncrustify/git/refs{/sha}","trees_url":"https://api.github.com/repos/ament/uncrustify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ament/uncrustify/statuses/{sha}","languages_url":"https://api.github.com/repos/ament/uncrustify/languages","stargazers_url":"https://api.github.com/repos/ament/uncrustify/stargazers","contributors_url":"https://api.github.com/repos/ament/uncrustify/contributors","subscribers_url":"https://api.github.com/repos/ament/uncrustify/subscribers","subscription_url":"https://api.github.com/repos/ament/uncrustify/subscription","commits_url":"https://api.github.com/repos/ament/uncrustify/commits{/sha}","git_commits_url":"https://api.github.com/repos/ament/uncrustify/git/commits{/sha}","comments_url":"https://api.github.com/repos/ament/uncrustify/comments{/number}","issue_comment_url":"https://api.github.com/repos/ament/uncrustify/issues/comments{/number}","contents_url":"https://api.github.com/repos/ament/uncrustify/contents/{+path}","compare_url":"https://api.github.com/repos/ament/uncrustify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ament/uncrustify/merges","archive_url":"https://api.github.com/repos/ament/uncrustify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ament/uncrustify/downloads","issues_url":"https://api.github.com/repos/ament/uncrustify/issues{/number}","pulls_url":"https://api.github.com/repos/ament/uncrustify/pulls{/number}","milestones_url":"https://api.github.com/repos/ament/uncrustify/milestones{/number}","notifications_url":"https://api.github.com/repos/ament/uncrustify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ament/uncrustify/labels{/name}","releases_url":"https://api.github.com/repos/ament/uncrustify/releases{/id}","created_at":"2015-04-14T22:12:21Z","updated_at":"2015-05-08T04:55:44Z","pushed_at":"2015-05-15T21:28:34Z","git_url":"git://github.com/ament/uncrustify.git","ssh_url":"git@github.com:ament/uncrustify.git","clone_url":"https://github.com/ament/uncrustify.git","svn_url":"https://github.com/ament/uncrustify","homepage":"http://uncrustify.sourceforge.net/","size":3951,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"bengardner:master","ref":"master","sha":"b6593c1bd9f2d5f2980c7e219df9109bef49e845","user":{"login":"bengardner","id":83918,"avatar_url":"https://avatars.githubusercontent.com/u/83918?v=3","gravatar_id":"","url":"https://api.github.com/users/bengardner","html_url":"https://github.com/bengardner","followers_url":"https://api.github.com/users/bengardner/followers","following_url":"https://api.github.com/users/bengardner/following{/other_user}","gists_url":"https://api.github.com/users/bengardner/gists{/gist_id}","starred_url":"https://api.github.com/users/bengardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengardner/subscriptions","organizations_url":"https://api.github.com/users/bengardner/orgs","repos_url":"https://api.github.com/users/bengardner/repos","events_url":"https://api.github.com/users/bengardner/events{/privacy}","received_events_url":"https://api.github.com/users/bengardner/received_events","type":"User","site_admin":false},"repo":{"id":340637,"name":"uncrustify","full_name":"bengardner/uncrustify","owner":{"login":"bengardner","id":83918,"avatar_url":"https://avatars.githubusercontent.com/u/83918?v=3","gravatar_id":"","url":"https://api.github.com/users/bengardner","html_url":"https://github.com/bengardner","followers_url":"https://api.github.com/users/bengardner/followers","following_url":"https://api.github.com/users/bengardner/following{/other_user}","gists_url":"https://api.github.com/users/bengardner/gists{/gist_id}","starred_url":"https://api.github.com/users/bengardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengardner/subscriptions","organizations_url":"https://api.github.com/users/bengardner/orgs","repos_url":"https://api.github.com/users/bengardner/repos","events_url":"https://api.github.com/users/bengardner/events{/privacy}","received_events_url":"https://api.github.com/users/bengardner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bengardner/uncrustify","description":"Code beautifier","fork":false,"url":"https://api.github.com/repos/bengardner/uncrustify","forks_url":"https://api.github.com/repos/bengardner/uncrustify/forks","keys_url":"https://api.github.com/repos/bengardner/uncrustify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bengardner/uncrustify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bengardner/uncrustify/teams","hooks_url":"https://api.github.com/repos/bengardner/uncrustify/hooks","issue_events_url":"https://api.github.com/repos/bengardner/uncrustify/issues/events{/number}","events_url":"https://api.github.com/repos/bengardner/uncrustify/events","assignees_url":"https://api.github.com/repos/bengardner/uncrustify/assignees{/user}","branches_url":"https://api.github.com/repos/bengardner/uncrustify/branches{/branch}","tags_url":"https://api.github.com/repos/bengardner/uncrustify/tags","blobs_url":"https://api.github.com/repos/bengardner/uncrustify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bengardner/uncrustify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bengardner/uncrustify/git/refs{/sha}","trees_url":"https://api.github.com/repos/bengardner/uncrustify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bengardner/uncrustify/statuses/{sha}","languages_url":"https://api.github.com/repos/bengardner/uncrustify/languages","stargazers_url":"https://api.github.com/repos/bengardner/uncrustify/stargazers","contributors_url":"https://api.github.com/repos/bengardner/uncrustify/contributors","subscribers_url":"https://api.github.com/repos/bengardner/uncrustify/subscribers","subscription_url":"https://api.github.com/repos/bengardner/uncrustify/subscription","commits_url":"https://api.github.com/repos/bengardner/uncrustify/commits{/sha}","git_commits_url":"https://api.github.com/repos/bengardner/uncrustify/git/commits{/sha}","comments_url":"https://api.github.com/repos/bengardner/uncrustify/comments{/number}","issue_comment_url":"https://api.github.com/repos/bengardner/uncrustify/issues/comments{/number}","contents_url":"https://api.github.com/repos/bengardner/uncrustify/contents/{+path}","compare_url":"https://api.github.com/repos/bengardner/uncrustify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bengardner/uncrustify/merges","archive_url":"https://api.github.com/repos/bengardner/uncrustify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bengardner/uncrustify/downloads","issues_url":"https://api.github.com/repos/bengardner/uncrustify/issues{/number}","pulls_url":"https://api.github.com/repos/bengardner/uncrustify/pulls{/number}","milestones_url":"https://api.github.com/repos/bengardner/uncrustify/milestones{/number}","notifications_url":"https://api.github.com/repos/bengardner/uncrustify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bengardner/uncrustify/labels{/name}","releases_url":"https://api.github.com/repos/bengardner/uncrustify/releases{/id}","created_at":"2009-10-17T18:39:53Z","updated_at":"2015-05-13T20:14:58Z","pushed_at":"2015-05-04T15:52:48Z","git_url":"git://github.com/bengardner/uncrustify.git","ssh_url":"git@github.com:bengardner/uncrustify.git","clone_url":"https://github.com/bengardner/uncrustify.git","svn_url":"https://github.com/bengardner/uncrustify","homepage":"http://uncrustify.sourceforge.net/","size":6173,"stargazers_count":909,"watchers_count":909,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":172,"mirror_url":null,"open_issues_count":149,"forks":172,"open_issues":149,"watchers":909,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bengardner/uncrustify/pulls/375"},"html":{"href":"https://github.com/bengardner/uncrustify/pull/375"},"issue":{"href":"https://api.github.com/repos/bengardner/uncrustify/issues/375"},"comments":{"href":"https://api.github.com/repos/bengardner/uncrustify/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/bengardner/uncrustify/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/bengardner/uncrustify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bengardner/uncrustify/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/bengardner/uncrustify/statuses/7d1385abd963a585e45b772a9186a5acacee8dad"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":9,"additions":111,"deletions":5,"changed_files":4}}