{"comment":{"url":"https://api.github.com/repos/killbill/killbill-cloud/comments/12052801","html_url":"https://github.com/killbill/killbill-cloud/commit/d4a7bb841ef82f5536a6c938f0bf2cf2a49ac4ba#commitcomment-12052801","id":12052801,"user":{"login":"sbrossie","id":246910,"avatar_url":"https://avatars.githubusercontent.com/u/246910?v=3","gravatar_id":"","url":"https://api.github.com/users/sbrossie","html_url":"https://github.com/sbrossie","followers_url":"https://api.github.com/users/sbrossie/followers","following_url":"https://api.github.com/users/sbrossie/following{/other_user}","gists_url":"https://api.github.com/users/sbrossie/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrossie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrossie/subscriptions","organizations_url":"https://api.github.com/users/sbrossie/orgs","repos_url":"https://api.github.com/users/sbrossie/repos","events_url":"https://api.github.com/users/sbrossie/events{/privacy}","received_events_url":"https://api.github.com/users/sbrossie/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"d4a7bb841ef82f5536a6c938f0bf2cf2a49ac4ba","created_at":"2015-07-08T03:07:49Z","updated_at":"2015-07-08T03:07:49Z","body":">> Having bigger value may not necessarily be an advantage.\r\n\r\n> Indeed. We don't want a too big number to limit the size of the `IN` query, but we want it large enough to limit the number of queries to the DB.\r\n\r\nThere are several things to consider:\r\n1. Yes, in principle increasing the value *may* limit the number of round trips we do to the database (we need to instrument it to understand if that limit is actually used or if we end up being way lower because there are not enough entries in the Q)\r\n2. The tradeoff however is that if we take too many per-thread, there is a risk of killing the level of parallelism because now all these entries are processed sequentially by that thread\r\n\r\nSo in the end, i don't know what the right value is, but this is what i mean by 'a bigger value may not necessarily be an advantage'. We need to i/ instrument and ii/ run tests with different values."}}