{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/7359","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/7359/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/7359/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/7359/events","html_url":"https://github.com/xbmc/xbmc/pull/7359","id":91599629,"number":7359,"title":"support saving skin settings as addon data instead of in guisettings.xml","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Cleanup","name":"Cleanup","color":"DDDDDD"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Improvement","name":"Improvement","color":"0b02e1"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/64","html_url":"https://github.com/xbmc/xbmc/milestones/Isengard%2016.0-alpha1","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/64/labels","id":1184180,"number":64,"title":"Isengard 16.0-alpha1","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":71,"state":"open","created_at":"2015-06-28T11:45:15Z","updated_at":"2015-07-08T22:08:49Z","due_on":"2015-07-30T22:00:00Z","closed_at":null},"comments":15,"created_at":"2015-06-28T13:27:17Z","updated_at":"2015-07-09T00:03:18Z","closed_at":"2015-07-08T16:47:44Z","pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/7359","html_url":"https://github.com/xbmc/xbmc/pull/7359","diff_url":"https://github.com/xbmc/xbmc/pull/7359.diff","patch_url":"https://github.com/xbmc/xbmc/pull/7359.patch"},"body":"These commits change the location where skin settings are stored. Instead of saving all skin settings from all skins in `guisettings.xml` (and making it rather huge) the settings are now stored in the skin's `addon_data` folder in `settings.xml` like any other addon with two differences:\r\n* skins don't require a `settings.xml` file with a definition for each setting\r\n* the format of the generated `settings.xml` slightly differs from the one used by all other addons (due to the previous point)\r\n\r\nThe migration of existing skin settings happens whenever a skin is loaded. We then look for skin settings matching the loaded skin in `guisettings.xml` and transfer them to the skin-specific `settings.xml` file. This is done because not all skins with skin settings in `guisettings.xml` might still be installed. This also means that `guisettings.xml` is only really cleaned up when loading the different skins."},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/119762975","html_url":"https://github.com/xbmc/xbmc/pull/7359#issuecomment-119762975","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/7359","id":119762975,"user":{"login":"popcornmix","id":1053730,"avatar_url":"https://avatars.githubusercontent.com/u/1053730?v=3","gravatar_id":"","url":"https://api.github.com/users/popcornmix","html_url":"https://github.com/popcornmix","followers_url":"https://api.github.com/users/popcornmix/followers","following_url":"https://api.github.com/users/popcornmix/following{/other_user}","gists_url":"https://api.github.com/users/popcornmix/gists{/gist_id}","starred_url":"https://api.github.com/users/popcornmix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popcornmix/subscriptions","organizations_url":"https://api.github.com/users/popcornmix/orgs","repos_url":"https://api.github.com/users/popcornmix/repos","events_url":"https://api.github.com/users/popcornmix/events{/privacy}","received_events_url":"https://api.github.com/users/popcornmix/received_events","type":"User","site_admin":false},"created_at":"2015-07-09T00:03:18Z","updated_at":"2015-07-09T00:03:18Z","body":"Same here."}}