{"action":"closed","number":169,"pull_request":{"url":"https://api.github.com/repos/jline/jline2/pulls/169","id":23721620,"html_url":"https://github.com/jline/jline2/pull/169","diff_url":"https://github.com/jline/jline2/pull/169.diff","patch_url":"https://github.com/jline/jline2/pull/169.patch","issue_url":"https://api.github.com/repos/jline/jline2/issues/169","number":169,"state":"closed","locked":false,"title":"callbacks and secondary keymap binding","user":{"login":"lcall","id":2119770,"avatar_url":"https://avatars.githubusercontent.com/u/2119770?v=3","gravatar_id":"","url":"https://api.github.com/users/lcall","html_url":"https://github.com/lcall","followers_url":"https://api.github.com/users/lcall/followers","following_url":"https://api.github.com/users/lcall/following{/other_user}","gists_url":"https://api.github.com/users/lcall/gists{/gist_id}","starred_url":"https://api.github.com/users/lcall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcall/subscriptions","organizations_url":"https://api.github.com/users/lcall/orgs","repos_url":"https://api.github.com/users/lcall/repos","events_url":"https://api.github.com/users/lcall/events{/privacy}","received_events_url":"https://api.github.com/users/lcall/received_events","type":"User","site_admin":false},"body":"If there's a better way that I just didn't understand, pls let me know.  My goal was to let the user just hit ESC and abandon an edit session in a way familiar to those who have no idea what emacs is, but to have those editing conveniences myself.  Seems to be working well so far.  I didn't end up using the 1st commit (callbacks) but might in the future and it seemed useful to keep.  \r\n\r\nThis approach, where my app does this to consume the changes:\r\n                     jlineReader.setKeyMap(jline.console.KeyMap.EMACS_META)\r\n                     jlineReader.getKeys.bind(jline.console.KeyMap.ESCAPE.toString, jline.console.Operation.QUIT)\r\n                     jlineReader.setKeyMap(KeyMap.VI_MOVE)\r\n                     jlineReader.getKeys.bind(jline.console.KeyMap.ESCAPE.toString, jline.console.Operation.QUIT)\r\n                     jlineReader.setKeyMap(startingKeyMap)\r\n\r\n...seems to have actually disabled vi mode, which is OK for me for now, also i don't have a better idea.\r\n\r\nAlso, i wasn't sure how best to make a test for the 2nd change (\"Allow a binding to be invoked ...\"; the one I'm using now), but I tested it via my own application.  I had some test ideas that didn't work.\r\n\r\nThanks for this very useful tool!","created_at":"2014-11-01T17:23:10Z","updated_at":"2015-07-13T13:31:10Z","closed_at":"2015-07-13T13:31:10Z","merged_at":null,"merge_commit_sha":"4512cda774a74e2c6b3f8e7806d0a4a428d773bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jline/jline2/pulls/169/commits","review_comments_url":"https://api.github.com/repos/jline/jline2/pulls/169/comments","review_comment_url":"https://api.github.com/repos/jline/jline2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jline/jline2/issues/169/comments","statuses_url":"https://api.github.com/repos/jline/jline2/statuses/6dcf9193bbecdf81d4b57c23ee92bc2d97d41e6c","head":{"label":"lcall:master","ref":"master","sha":"6dcf9193bbecdf81d4b57c23ee92bc2d97d41e6c","user":{"login":"lcall","id":2119770,"avatar_url":"https://avatars.githubusercontent.com/u/2119770?v=3","gravatar_id":"","url":"https://api.github.com/users/lcall","html_url":"https://github.com/lcall","followers_url":"https://api.github.com/users/lcall/followers","following_url":"https://api.github.com/users/lcall/following{/other_user}","gists_url":"https://api.github.com/users/lcall/gists{/gist_id}","starred_url":"https://api.github.com/users/lcall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcall/subscriptions","organizations_url":"https://api.github.com/users/lcall/orgs","repos_url":"https://api.github.com/users/lcall/repos","events_url":"https://api.github.com/users/lcall/events{/privacy}","received_events_url":"https://api.github.com/users/lcall/received_events","type":"User","site_admin":false},"repo":{"id":25750648,"name":"jline2","full_name":"lcall/jline2","owner":{"login":"lcall","id":2119770,"avatar_url":"https://avatars.githubusercontent.com/u/2119770?v=3","gravatar_id":"","url":"https://api.github.com/users/lcall","html_url":"https://github.com/lcall","followers_url":"https://api.github.com/users/lcall/followers","following_url":"https://api.github.com/users/lcall/following{/other_user}","gists_url":"https://api.github.com/users/lcall/gists{/gist_id}","starred_url":"https://api.github.com/users/lcall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcall/subscriptions","organizations_url":"https://api.github.com/users/lcall/orgs","repos_url":"https://api.github.com/users/lcall/repos","events_url":"https://api.github.com/users/lcall/events{/privacy}","received_events_url":"https://api.github.com/users/lcall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lcall/jline2","description":"The new Jline","fork":true,"url":"https://api.github.com/repos/lcall/jline2","forks_url":"https://api.github.com/repos/lcall/jline2/forks","keys_url":"https://api.github.com/repos/lcall/jline2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lcall/jline2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lcall/jline2/teams","hooks_url":"https://api.github.com/repos/lcall/jline2/hooks","issue_events_url":"https://api.github.com/repos/lcall/jline2/issues/events{/number}","events_url":"https://api.github.com/repos/lcall/jline2/events","assignees_url":"https://api.github.com/repos/lcall/jline2/assignees{/user}","branches_url":"https://api.github.com/repos/lcall/jline2/branches{/branch}","tags_url":"https://api.github.com/repos/lcall/jline2/tags","blobs_url":"https://api.github.com/repos/lcall/jline2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lcall/jline2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lcall/jline2/git/refs{/sha}","trees_url":"https://api.github.com/repos/lcall/jline2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lcall/jline2/statuses/{sha}","languages_url":"https://api.github.com/repos/lcall/jline2/languages","stargazers_url":"https://api.github.com/repos/lcall/jline2/stargazers","contributors_url":"https://api.github.com/repos/lcall/jline2/contributors","subscribers_url":"https://api.github.com/repos/lcall/jline2/subscribers","subscription_url":"https://api.github.com/repos/lcall/jline2/subscription","commits_url":"https://api.github.com/repos/lcall/jline2/commits{/sha}","git_commits_url":"https://api.github.com/repos/lcall/jline2/git/commits{/sha}","comments_url":"https://api.github.com/repos/lcall/jline2/comments{/number}","issue_comment_url":"https://api.github.com/repos/lcall/jline2/issues/comments{/number}","contents_url":"https://api.github.com/repos/lcall/jline2/contents/{+path}","compare_url":"https://api.github.com/repos/lcall/jline2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lcall/jline2/merges","archive_url":"https://api.github.com/repos/lcall/jline2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lcall/jline2/downloads","issues_url":"https://api.github.com/repos/lcall/jline2/issues{/number}","pulls_url":"https://api.github.com/repos/lcall/jline2/pulls{/number}","milestones_url":"https://api.github.com/repos/lcall/jline2/milestones{/number}","notifications_url":"https://api.github.com/repos/lcall/jline2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lcall/jline2/labels{/name}","releases_url":"https://api.github.com/repos/lcall/jline2/releases{/id}","created_at":"2014-10-25T23:34:11Z","updated_at":"2014-12-13T16:29:02Z","pushed_at":"2014-12-13T16:29:01Z","git_url":"git://github.com/lcall/jline2.git","ssh_url":"git@github.com:lcall/jline2.git","clone_url":"https://github.com/lcall/jline2.git","svn_url":"https://github.com/lcall/jline2","homepage":"http://jline.github.com/jline2/","size":3283,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jline:master","ref":"master","sha":"ef475293cb85932f45bc4d37b27149e831707f92","user":{"login":"jline","id":711075,"avatar_url":"https://avatars.githubusercontent.com/u/711075?v=3","gravatar_id":"","url":"https://api.github.com/users/jline","html_url":"https://github.com/jline","followers_url":"https://api.github.com/users/jline/followers","following_url":"https://api.github.com/users/jline/following{/other_user}","gists_url":"https://api.github.com/users/jline/gists{/gist_id}","starred_url":"https://api.github.com/users/jline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jline/subscriptions","organizations_url":"https://api.github.com/users/jline/orgs","repos_url":"https://api.github.com/users/jline/repos","events_url":"https://api.github.com/users/jline/events{/privacy}","received_events_url":"https://api.github.com/users/jline/received_events","type":"Organization","site_admin":false},"repo":{"id":1577604,"name":"jline2","full_name":"jline/jline2","owner":{"login":"jline","id":711075,"avatar_url":"https://avatars.githubusercontent.com/u/711075?v=3","gravatar_id":"","url":"https://api.github.com/users/jline","html_url":"https://github.com/jline","followers_url":"https://api.github.com/users/jline/followers","following_url":"https://api.github.com/users/jline/following{/other_user}","gists_url":"https://api.github.com/users/jline/gists{/gist_id}","starred_url":"https://api.github.com/users/jline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jline/subscriptions","organizations_url":"https://api.github.com/users/jline/orgs","repos_url":"https://api.github.com/users/jline/repos","events_url":"https://api.github.com/users/jline/events{/privacy}","received_events_url":"https://api.github.com/users/jline/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jline/jline2","description":"The new Jline","fork":false,"url":"https://api.github.com/repos/jline/jline2","forks_url":"https://api.github.com/repos/jline/jline2/forks","keys_url":"https://api.github.com/repos/jline/jline2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jline/jline2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jline/jline2/teams","hooks_url":"https://api.github.com/repos/jline/jline2/hooks","issue_events_url":"https://api.github.com/repos/jline/jline2/issues/events{/number}","events_url":"https://api.github.com/repos/jline/jline2/events","assignees_url":"https://api.github.com/repos/jline/jline2/assignees{/user}","branches_url":"https://api.github.com/repos/jline/jline2/branches{/branch}","tags_url":"https://api.github.com/repos/jline/jline2/tags","blobs_url":"https://api.github.com/repos/jline/jline2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jline/jline2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jline/jline2/git/refs{/sha}","trees_url":"https://api.github.com/repos/jline/jline2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jline/jline2/statuses/{sha}","languages_url":"https://api.github.com/repos/jline/jline2/languages","stargazers_url":"https://api.github.com/repos/jline/jline2/stargazers","contributors_url":"https://api.github.com/repos/jline/jline2/contributors","subscribers_url":"https://api.github.com/repos/jline/jline2/subscribers","subscription_url":"https://api.github.com/repos/jline/jline2/subscription","commits_url":"https://api.github.com/repos/jline/jline2/commits{/sha}","git_commits_url":"https://api.github.com/repos/jline/jline2/git/commits{/sha}","comments_url":"https://api.github.com/repos/jline/jline2/comments{/number}","issue_comment_url":"https://api.github.com/repos/jline/jline2/issues/comments{/number}","contents_url":"https://api.github.com/repos/jline/jline2/contents/{+path}","compare_url":"https://api.github.com/repos/jline/jline2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jline/jline2/merges","archive_url":"https://api.github.com/repos/jline/jline2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jline/jline2/downloads","issues_url":"https://api.github.com/repos/jline/jline2/issues{/number}","pulls_url":"https://api.github.com/repos/jline/jline2/pulls{/number}","milestones_url":"https://api.github.com/repos/jline/jline2/milestones{/number}","notifications_url":"https://api.github.com/repos/jline/jline2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jline/jline2/labels{/name}","releases_url":"https://api.github.com/repos/jline/jline2/releases{/id}","created_at":"2011-04-06T14:53:44Z","updated_at":"2015-07-12T12:37:30Z","pushed_at":"2015-07-13T13:30:48Z","git_url":"git://github.com/jline/jline2.git","ssh_url":"git@github.com:jline/jline2.git","clone_url":"https://github.com/jline/jline2.git","svn_url":"https://github.com/jline/jline2","homepage":"http://jline.github.com/jline2/","size":4433,"stargazers_count":401,"watchers_count":401,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":127,"mirror_url":null,"open_issues_count":59,"forks":127,"open_issues":59,"watchers":401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jline/jline2/pulls/169"},"html":{"href":"https://github.com/jline/jline2/pull/169"},"issue":{"href":"https://api.github.com/repos/jline/jline2/issues/169"},"comments":{"href":"https://api.github.com/repos/jline/jline2/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/jline/jline2/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/jline/jline2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jline/jline2/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/jline/jline2/statuses/6dcf9193bbecdf81d4b57c23ee92bc2d97d41e6c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":0,"commits":6,"additions":64,"deletions":21,"changed_files":4}}