{"action":"created","issue":{"url":"https://api.github.com/repos/praekelt/go-metrics-api/issues/19","labels_url":"https://api.github.com/repos/praekelt/go-metrics-api/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/praekelt/go-metrics-api/issues/19/comments","events_url":"https://api.github.com/repos/praekelt/go-metrics-api/issues/19/events","html_url":"https://github.com/praekelt/go-metrics-api/pull/19","id":110170053,"number":19,"title":"Tear down graphite backend's metric worker","user":{"login":"justinvdm","id":1731223,"avatar_url":"https://avatars.githubusercontent.com/u/1731223?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvdm","html_url":"https://github.com/justinvdm","followers_url":"https://api.github.com/users/justinvdm/followers","following_url":"https://api.github.com/users/justinvdm/following{/other_user}","gists_url":"https://api.github.com/users/justinvdm/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvdm/subscriptions","organizations_url":"https://api.github.com/users/justinvdm/orgs","repos_url":"https://api.github.com/users/justinvdm/repos","events_url":"https://api.github.com/users/justinvdm/events{/privacy}","received_events_url":"https://api.github.com/users/justinvdm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-07T07:55:40Z","updated_at":"2015-10-07T08:56:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/praekelt/go-metrics-api/pulls/19","html_url":"https://github.com/praekelt/go-metrics-api/pull/19","diff_url":"https://github.com/praekelt/go-metrics-api/pull/19.diff","patch_url":"https://github.com/praekelt/go-metrics-api/pull/19.patch"},"body":"At the moment, we start the metric worker when we initialise the graphite backend, but do not do any teardown later."},"comment":{"url":"https://api.github.com/repos/praekelt/go-metrics-api/issues/comments/146122434","html_url":"https://github.com/praekelt/go-metrics-api/pull/19#issuecomment-146122434","issue_url":"https://api.github.com/repos/praekelt/go-metrics-api/issues/19","id":146122434,"user":{"login":"justinvdm","id":1731223,"avatar_url":"https://avatars.githubusercontent.com/u/1731223?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvdm","html_url":"https://github.com/justinvdm","followers_url":"https://api.github.com/users/justinvdm/followers","following_url":"https://api.github.com/users/justinvdm/following{/other_user}","gists_url":"https://api.github.com/users/justinvdm/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvdm/subscriptions","organizations_url":"https://api.github.com/users/justinvdm/orgs","repos_url":"https://api.github.com/users/justinvdm/repos","events_url":"https://api.github.com/users/justinvdm/events{/privacy}","received_events_url":"https://api.github.com/users/justinvdm/received_events","type":"User","site_admin":false},"created_at":"2015-10-07T08:56:53Z","updated_at":"2015-10-07T08:56:53Z","body":"Ready for review.\r\n\r\n`MetricsApi.teardown` won't actually be called, we'll need to change `ApiApplication` to do tearing down in the api toolkit. Not sure how easy it will be to hook that up to cyclone's twistd service though. Wondering what happens when the process is stopped if we don't call tear down though, will twisted exit the process even thought the reactor is unclean?"}}