{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/4532","labels_url":"https://api.github.com/repos/ceph/ceph/issues/4532/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/4532/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/4532/events","html_url":"https://github.com/ceph/ceph/pull/4532","id":72661847,"number":4532,"title":"ceph-detect-init helper and associated tests","user":{"login":"dachary","id":433594,"avatar_url":"https://avatars.githubusercontent.com/u/433594?v=3","gravatar_id":"","url":"https://api.github.com/users/dachary","html_url":"https://github.com/dachary","followers_url":"https://api.github.com/users/dachary/followers","following_url":"https://api.github.com/users/dachary/following{/other_user}","gists_url":"https://api.github.com/users/dachary/gists{/gist_id}","starred_url":"https://api.github.com/users/dachary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachary/subscriptions","organizations_url":"https://api.github.com/users/dachary/orgs","repos_url":"https://api.github.com/users/dachary/repos","events_url":"https://api.github.com/users/dachary/events{/privacy}","received_events_url":"https://api.github.com/users/dachary/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ceph/ceph/labels/build/ops","name":"build/ops","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-05-02T15:37:19Z","updated_at":"2015-05-07T07:58:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/4532","html_url":"https://github.com/ceph/ceph/pull/4532","diff_url":"https://github.com/ceph/ceph/pull/4532.diff","patch_url":"https://github.com/ceph/ceph/pull/4532.patch"},"body":"this also lays out the foundations for integrating the existing python code into make check and allow running tox without network access"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/99760729","html_url":"https://github.com/ceph/ceph/pull/4532#issuecomment-99760729","issue_url":"https://api.github.com/repos/ceph/ceph/issues/4532","id":99760729,"user":{"login":"dachary","id":433594,"avatar_url":"https://avatars.githubusercontent.com/u/433594?v=3","gravatar_id":"","url":"https://api.github.com/users/dachary","html_url":"https://github.com/dachary","followers_url":"https://api.github.com/users/dachary/followers","following_url":"https://api.github.com/users/dachary/following{/other_user}","gists_url":"https://api.github.com/users/dachary/gists{/gist_id}","starred_url":"https://api.github.com/users/dachary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachary/subscriptions","organizations_url":"https://api.github.com/users/dachary/orgs","repos_url":"https://api.github.com/users/dachary/repos","events_url":"https://api.github.com/users/dachary/events{/privacy}","received_events_url":"https://api.github.com/users/dachary/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T07:58:21Z","updated_at":"2015-05-07T07:58:21Z","body":"@liewegas this is osynge ceph-detect-init with integration tests and unit tests. I turned out to be significant work for a simple change, reason why this kind of code was untested so far: the test infrastructure was missing. I believe these tests can be re-used or mimicked to significantly improve the tests of other python scripts included in the ceph source directory."}}