{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/42760335","id":42760335,"diff_hunk":"@@ -297,3 +297,16 @@ func DefaultOpenShiftUserAgent() string {\n \tversion = seg[0]\n \treturn fmt.Sprintf(\"%s/%s (%s/%s) openshift/%s\", path.Base(os.Args[0]), version, runtime.GOOS, runtime.GOARCH, commit)\n }\n+\n+type HybridClient struct {","path":"pkg/client/client.go","position":5,"original_position":5,"commit_id":"9ee049b6aea46786357968193b3c00f5be9b2b36","original_commit_id":"9ee049b6aea46786357968193b3c00f5be9b2b36","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"Nix this.  Its been rejected on principle mulitple times.","created_at":"2015-10-22T15:08:27Z","updated_at":"2015-10-22T15:08:27Z","html_url":"https://github.com/openshift/origin/pull/5310#discussion_r42760335","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/5310","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/42760335"},"html":{"href":"https://github.com/openshift/origin/pull/5310#discussion_r42760335"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/5310"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/5310","id":48404570,"html_url":"https://github.com/openshift/origin/pull/5310","diff_url":"https://github.com/openshift/origin/pull/5310.diff","patch_url":"https://github.com/openshift/origin/pull/5310.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/5310","number":5310,"state":"open","locked":false,"title":"[WIP] Enable HorizontalPodAutoscaler Support for DeploymentConfigs","user":{"login":"DirectXMan12","id":119737,"avatar_url":"https://avatars.githubusercontent.com/u/119737?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"body":"This PR adds support for HPAs scaling DeploymentConfigs.   A new \"HybridClient\" struct is introduced to support Namespacers that need to point at resources or subresources that could be in either the Origin API or the Kube API (like `Scale`).\r\n\r\nThis commit also imports the Scale kind into the Origin v1 API (but it's still \"backed\" in the unversioned API by the underlying Kube resource).\r\n\r\nFinally, this commit contains a patch to Kube that converts the HPA controller from using a single `Client` type to using separate `Namespacers` for its various needs.","created_at":"2015-10-22T00:16:33Z","updated_at":"2015-10-22T15:08:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/5310/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/5310/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/5310/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/9ee049b6aea46786357968193b3c00f5be9b2b36","head":{"label":"DirectXMan12:feature/hpa-deploymentconfig","ref":"feature/hpa-deploymentconfig","sha":"9ee049b6aea46786357968193b3c00f5be9b2b36","user":{"login":"DirectXMan12","id":119737,"avatar_url":"https://avatars.githubusercontent.com/u/119737?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"repo":{"id":44701804,"name":"origin","full_name":"DirectXMan12/origin","owner":{"login":"DirectXMan12","id":119737,"avatar_url":"https://avatars.githubusercontent.com/u/119737?v=3","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DirectXMan12/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/DirectXMan12/origin","forks_url":"https://api.github.com/repos/DirectXMan12/origin/forks","keys_url":"https://api.github.com/repos/DirectXMan12/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DirectXMan12/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DirectXMan12/origin/teams","hooks_url":"https://api.github.com/repos/DirectXMan12/origin/hooks","issue_events_url":"https://api.github.com/repos/DirectXMan12/origin/issues/events{/number}","events_url":"https://api.github.com/repos/DirectXMan12/origin/events","assignees_url":"https://api.github.com/repos/DirectXMan12/origin/assignees{/user}","branches_url":"https://api.github.com/repos/DirectXMan12/origin/branches{/branch}","tags_url":"https://api.github.com/repos/DirectXMan12/origin/tags","blobs_url":"https://api.github.com/repos/DirectXMan12/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DirectXMan12/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DirectXMan12/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/DirectXMan12/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DirectXMan12/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/DirectXMan12/origin/languages","stargazers_url":"https://api.github.com/repos/DirectXMan12/origin/stargazers","contributors_url":"https://api.github.com/repos/DirectXMan12/origin/contributors","subscribers_url":"https://api.github.com/repos/DirectXMan12/origin/subscribers","subscription_url":"https://api.github.com/repos/DirectXMan12/origin/subscription","commits_url":"https://api.github.com/repos/DirectXMan12/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/DirectXMan12/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/DirectXMan12/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/DirectXMan12/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/DirectXMan12/origin/contents/{+path}","compare_url":"https://api.github.com/repos/DirectXMan12/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DirectXMan12/origin/merges","archive_url":"https://api.github.com/repos/DirectXMan12/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DirectXMan12/origin/downloads","issues_url":"https://api.github.com/repos/DirectXMan12/origin/issues{/number}","pulls_url":"https://api.github.com/repos/DirectXMan12/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/DirectXMan12/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/DirectXMan12/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DirectXMan12/origin/labels{/name}","releases_url":"https://api.github.com/repos/DirectXMan12/origin/releases{/id}","created_at":"2015-10-21T20:18:34Z","updated_at":"2015-10-21T20:19:02Z","pushed_at":"2015-10-22T00:12:37Z","git_url":"git://github.com/DirectXMan12/origin.git","ssh_url":"git@github.com:DirectXMan12/origin.git","clone_url":"https://github.com/DirectXMan12/origin.git","svn_url":"https://github.com/DirectXMan12/origin","homepage":"http://www.openshift.org","size":159759,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"a7032bc01dbfd39f21c7dd8bc9fc0692799dca8f","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-10-22T01:58:51Z","pushed_at":"2015-10-22T15:05:50Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":276331,"stargazers_count":760,"watchers_count":760,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":467,"mirror_url":null,"open_issues_count":615,"forks":467,"open_issues":615,"watchers":760,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/5310"},"html":{"href":"https://github.com/openshift/origin/pull/5310"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/5310"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/5310/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/5310/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/5310/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/9ee049b6aea46786357968193b3c00f5be9b2b36"}}}}