{"action":"created","comment":{"url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/pulls/comments/22732253","id":22732253,"diff_hunk":"@@ -1,3 +1,244 @@\n # React Breakpoints Mixin\n \n BreakpointsMixin for your React Components.\n+\n+\n+## Example\n+\n+See the working [example page](http://ui.deseretdigital.com/react-breakpoints-mixin/).\n+\n+\n+## Install\n+\n+The package is available through npm and also bower.\n+\n+### npm\n+\n+```shell\n+npm install --save react-breakpoints-mixin\n+```\n+\n+\n+### bower\n+\n+```shell\n+bower install --save react-breakpoints-mixin\n+```\n+\n+\n+## Import\n+\n+The `BreakpointsMixin` module is packaged in the [UMD][GoogleUMD] format, which\n+means you can bring it in as a [CommonJS][GoogleCommonJS] module using `require`,\n+or as a [global variable][GoogleGlobalVariable] using a `<script>` tag.","path":"README.md","position":33,"original_position":33,"commit_id":"04ff8693fac69d2ff4b148abf5432be567c10996","original_commit_id":"04ff8693fac69d2ff4b148abf5432be567c10996","user":{"login":"janiv","id":677780,"avatar_url":"https://avatars.githubusercontent.com/u/677780?v=3","gravatar_id":"","url":"https://api.github.com/users/janiv","html_url":"https://github.com/janiv","followers_url":"https://api.github.com/users/janiv/followers","following_url":"https://api.github.com/users/janiv/following{/other_user}","gists_url":"https://api.github.com/users/janiv/gists{/gist_id}","starred_url":"https://api.github.com/users/janiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janiv/subscriptions","organizations_url":"https://api.github.com/users/janiv/orgs","repos_url":"https://api.github.com/users/janiv/repos","events_url":"https://api.github.com/users/janiv/events{/privacy}","received_events_url":"https://api.github.com/users/janiv/received_events","type":"User","site_admin":false},"body":"No mention of UMD also supporting AMD?","created_at":"2015-01-09T18:15:38Z","updated_at":"2015-01-09T18:15:38Z","html_url":"https://github.com/deseretdigital-ui/react-breakpoints-mixin/pull/1#discussion_r22732253","pull_request_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/pulls/comments/22732253"},"html":{"href":"https://github.com/deseretdigital-ui/react-breakpoints-mixin/pull/1#discussion_r22732253"},"pull_request":{"href":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/pulls/1","id":26998357,"html_url":"https://github.com/deseretdigital-ui/react-breakpoints-mixin/pull/1","diff_url":"https://github.com/deseretdigital-ui/react-breakpoints-mixin/pull/1.diff","patch_url":"https://github.com/deseretdigital-ui/react-breakpoints-mixin/pull/1.patch","issue_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/issues/1","number":1,"state":"open","locked":false,"title":"Initialize BreakpointsMixin","user":{"login":"jehoshua02","id":625814,"avatar_url":"https://avatars.githubusercontent.com/u/625814?v=3","gravatar_id":"","url":"https://api.github.com/users/jehoshua02","html_url":"https://github.com/jehoshua02","followers_url":"https://api.github.com/users/jehoshua02/followers","following_url":"https://api.github.com/users/jehoshua02/following{/other_user}","gists_url":"https://api.github.com/users/jehoshua02/gists{/gist_id}","starred_url":"https://api.github.com/users/jehoshua02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jehoshua02/subscriptions","organizations_url":"https://api.github.com/users/jehoshua02/orgs","repos_url":"https://api.github.com/users/jehoshua02/repos","events_url":"https://api.github.com/users/jehoshua02/events{/privacy}","received_events_url":"https://api.github.com/users/jehoshua02/received_events","type":"User","site_admin":false},"body":"Starting with ddm-react-skeleton, set up the project with an example page, with it's own build process, and the src directory with it's build process.\r\n\r\nThe mixin looks at breakpoints defined in the component and binds handlers to window resize. The handlers evaluate breakpoints and sets matched breakpoints into component state, which triggers a render. Then for render, the mixin provides a method to get the generated classNames for the component based on matched breakpoints in the state.\r\n\r\nThere's still a little more work I want to do:\r\n\r\n+ [x] Warn on overlapping breakpoints. We have decided this is something we want to avoid for our own sanity.\r\n+ [x] Meh. ~~Move \"non-public\" methods out of the mixin. We don't want to expose more than what is intended for normal use.~~\r\n+ [x] Check in all browsers.\r\n+ [x] README.md\r\n+ [x] Publish example build to ghpages.\r\n+ [ ] Breakpoints as a prop, or something to make overriding breakpoints easy?\r\n","created_at":"2015-01-08T00:05:16Z","updated_at":"2015-01-09T18:15:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ce0d67182af929db307adba1125eec326faeae9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/pulls/1/commits","review_comments_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/pulls/1/comments","review_comment_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/issues/1/comments","statuses_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/statuses/04ff8693fac69d2ff4b148abf5432be567c10996","head":{"label":"deseretdigital-ui:init","ref":"init","sha":"04ff8693fac69d2ff4b148abf5432be567c10996","user":{"login":"deseretdigital-ui","id":9342905,"avatar_url":"https://avatars.githubusercontent.com/u/9342905?v=3","gravatar_id":"","url":"https://api.github.com/users/deseretdigital-ui","html_url":"https://github.com/deseretdigital-ui","followers_url":"https://api.github.com/users/deseretdigital-ui/followers","following_url":"https://api.github.com/users/deseretdigital-ui/following{/other_user}","gists_url":"https://api.github.com/users/deseretdigital-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/deseretdigital-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deseretdigital-ui/subscriptions","organizations_url":"https://api.github.com/users/deseretdigital-ui/orgs","repos_url":"https://api.github.com/users/deseretdigital-ui/repos","events_url":"https://api.github.com/users/deseretdigital-ui/events{/privacy}","received_events_url":"https://api.github.com/users/deseretdigital-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":28939717,"name":"react-breakpoints-mixin","full_name":"deseretdigital-ui/react-breakpoints-mixin","owner":{"login":"deseretdigital-ui","id":9342905,"avatar_url":"https://avatars.githubusercontent.com/u/9342905?v=3","gravatar_id":"","url":"https://api.github.com/users/deseretdigital-ui","html_url":"https://github.com/deseretdigital-ui","followers_url":"https://api.github.com/users/deseretdigital-ui/followers","following_url":"https://api.github.com/users/deseretdigital-ui/following{/other_user}","gists_url":"https://api.github.com/users/deseretdigital-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/deseretdigital-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deseretdigital-ui/subscriptions","organizations_url":"https://api.github.com/users/deseretdigital-ui/orgs","repos_url":"https://api.github.com/users/deseretdigital-ui/repos","events_url":"https://api.github.com/users/deseretdigital-ui/events{/privacy}","received_events_url":"https://api.github.com/users/deseretdigital-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deseretdigital-ui/react-breakpoints-mixin","description":"BreakpointsMixin for your React Components.","fork":false,"url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin","forks_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/forks","keys_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/teams","hooks_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/hooks","issue_events_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/issues/events{/number}","events_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/events","assignees_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/assignees{/user}","branches_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/branches{/branch}","tags_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/tags","blobs_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/git/refs{/sha}","trees_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/statuses/{sha}","languages_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/languages","stargazers_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/stargazers","contributors_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/contributors","subscribers_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/subscribers","subscription_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/subscription","commits_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/commits{/sha}","git_commits_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/git/commits{/sha}","comments_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/comments{/number}","issue_comment_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/issues/comments/{number}","contents_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/contents/{+path}","compare_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/merges","archive_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/downloads","issues_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/issues{/number}","pulls_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/pulls{/number}","milestones_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/milestones{/number}","notifications_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/labels{/name}","releases_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/releases{/id}","created_at":"2015-01-07T23:47:56Z","updated_at":"2015-01-08T21:05:12Z","pushed_at":"2015-01-09T02:32:56Z","git_url":"git://github.com/deseretdigital-ui/react-breakpoints-mixin.git","ssh_url":"git@github.com:deseretdigital-ui/react-breakpoints-mixin.git","clone_url":"https://github.com/deseretdigital-ui/react-breakpoints-mixin.git","svn_url":"https://github.com/deseretdigital-ui/react-breakpoints-mixin","homepage":"http://ui.deseretdigital.com/react-breakpoints-mixin/","size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"deseretdigital-ui:master","ref":"master","sha":"18b788a08867e3976fa5749186b3afe3a8217061","user":{"login":"deseretdigital-ui","id":9342905,"avatar_url":"https://avatars.githubusercontent.com/u/9342905?v=3","gravatar_id":"","url":"https://api.github.com/users/deseretdigital-ui","html_url":"https://github.com/deseretdigital-ui","followers_url":"https://api.github.com/users/deseretdigital-ui/followers","following_url":"https://api.github.com/users/deseretdigital-ui/following{/other_user}","gists_url":"https://api.github.com/users/deseretdigital-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/deseretdigital-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deseretdigital-ui/subscriptions","organizations_url":"https://api.github.com/users/deseretdigital-ui/orgs","repos_url":"https://api.github.com/users/deseretdigital-ui/repos","events_url":"https://api.github.com/users/deseretdigital-ui/events{/privacy}","received_events_url":"https://api.github.com/users/deseretdigital-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":28939717,"name":"react-breakpoints-mixin","full_name":"deseretdigital-ui/react-breakpoints-mixin","owner":{"login":"deseretdigital-ui","id":9342905,"avatar_url":"https://avatars.githubusercontent.com/u/9342905?v=3","gravatar_id":"","url":"https://api.github.com/users/deseretdigital-ui","html_url":"https://github.com/deseretdigital-ui","followers_url":"https://api.github.com/users/deseretdigital-ui/followers","following_url":"https://api.github.com/users/deseretdigital-ui/following{/other_user}","gists_url":"https://api.github.com/users/deseretdigital-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/deseretdigital-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deseretdigital-ui/subscriptions","organizations_url":"https://api.github.com/users/deseretdigital-ui/orgs","repos_url":"https://api.github.com/users/deseretdigital-ui/repos","events_url":"https://api.github.com/users/deseretdigital-ui/events{/privacy}","received_events_url":"https://api.github.com/users/deseretdigital-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deseretdigital-ui/react-breakpoints-mixin","description":"BreakpointsMixin for your React Components.","fork":false,"url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin","forks_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/forks","keys_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/teams","hooks_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/hooks","issue_events_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/issues/events{/number}","events_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/events","assignees_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/assignees{/user}","branches_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/branches{/branch}","tags_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/tags","blobs_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/git/refs{/sha}","trees_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/statuses/{sha}","languages_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/languages","stargazers_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/stargazers","contributors_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/contributors","subscribers_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/subscribers","subscription_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/subscription","commits_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/commits{/sha}","git_commits_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/git/commits{/sha}","comments_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/comments{/number}","issue_comment_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/issues/comments/{number}","contents_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/contents/{+path}","compare_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/merges","archive_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/downloads","issues_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/issues{/number}","pulls_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/pulls{/number}","milestones_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/milestones{/number}","notifications_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/labels{/name}","releases_url":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/releases{/id}","created_at":"2015-01-07T23:47:56Z","updated_at":"2015-01-08T21:05:12Z","pushed_at":"2015-01-09T02:32:56Z","git_url":"git://github.com/deseretdigital-ui/react-breakpoints-mixin.git","ssh_url":"git@github.com:deseretdigital-ui/react-breakpoints-mixin.git","clone_url":"https://github.com/deseretdigital-ui/react-breakpoints-mixin.git","svn_url":"https://github.com/deseretdigital-ui/react-breakpoints-mixin","homepage":"http://ui.deseretdigital.com/react-breakpoints-mixin/","size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/pulls/1"},"html":{"href":"https://github.com/deseretdigital-ui/react-breakpoints-mixin/pull/1"},"issue":{"href":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/issues/1"},"comments":{"href":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/deseretdigital-ui/react-breakpoints-mixin/statuses/04ff8693fac69d2ff4b148abf5432be567c10996"}}}}