{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/37499856","id":37499856,"diff_hunk":"@@ -181,7 +182,7 @@\n     public static final String WRITE_ATTRIBUTE = \"write-attribute\";\n \n     public static boolean isWindows() {\n-        return WildFlySecurityManager.getPropertyPrivileged(\"os.name\", null).toLowerCase(Locale.ENGLISH).indexOf(\"windows\") >= 0;\n+        return WildFlySecurityManager.getPropertyPrivileged(\"os.name\", null).toLowerCase(Locale.ENGLISH).contains(\"windows\");","path":"cli/src/main/java/org/jboss/as/cli/Util.java","position":13,"original_position":13,"commit_id":"2dc022f8cd20b501a952453b062942f49d3e03e9","original_commit_id":"2dc022f8cd20b501a952453b062942f49d3e03e9","user":{"login":"ehsavoie","id":73053,"avatar_url":"https://avatars.githubusercontent.com/u/73053?v=3","gravatar_id":"","url":"https://api.github.com/users/ehsavoie","html_url":"https://github.com/ehsavoie","followers_url":"https://api.github.com/users/ehsavoie/followers","following_url":"https://api.github.com/users/ehsavoie/following{/other_user}","gists_url":"https://api.github.com/users/ehsavoie/gists{/gist_id}","starred_url":"https://api.github.com/users/ehsavoie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehsavoie/subscriptions","organizations_url":"https://api.github.com/users/ehsavoie/orgs","repos_url":"https://api.github.com/users/ehsavoie/repos","events_url":"https://api.github.com/users/ehsavoie/events{/privacy}","received_events_url":"https://api.github.com/users/ehsavoie/received_events","type":"User","site_admin":false},"body":"Because I rewrote some code around and might have click an 'old code' hint","created_at":"2015-08-20T06:53:47Z","updated_at":"2015-08-20T06:53:47Z","html_url":"https://github.com/wildfly/wildfly-core/pull/951#discussion_r37499856","pull_request_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/951","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/37499856"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/951#discussion_r37499856"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/951"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/951","id":42173114,"html_url":"https://github.com/wildfly/wildfly-core/pull/951","diff_url":"https://github.com/wildfly/wildfly-core/pull/951.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/951.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/951","number":951,"state":"open","locked":false,"title":" [WFCORE-74] : Use 'filesystem-path' arbitrary descriptor for attributes/params that represent a path.","user":{"login":"ehsavoie","id":73053,"avatar_url":"https://avatars.githubusercontent.com/u/73053?v=3","gravatar_id":"","url":"https://api.github.com/users/ehsavoie","html_url":"https://github.com/ehsavoie","followers_url":"https://api.github.com/users/ehsavoie/followers","following_url":"https://api.github.com/users/ehsavoie/following{/other_user}","gists_url":"https://api.github.com/users/ehsavoie/gists{/gist_id}","starred_url":"https://api.github.com/users/ehsavoie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehsavoie/subscriptions","organizations_url":"https://api.github.com/users/ehsavoie/orgs","repos_url":"https://api.github.com/users/ehsavoie/repos","events_url":"https://api.github.com/users/ehsavoie/events{/privacy}","received_events_url":"https://api.github.com/users/ehsavoie/received_events","type":"User","site_admin":false},"body":"Adding support for arbitrary descriptors metadata.\r\nAdding FILESYSTEM_PATH and WEB_URL arbitrary descriptors.\r\nAdding support in CLI for FILESYSTEM_PATH during completion.\r\nAdding CLI operation parameter validation before sending operation.\r\n\r\nJira: https://issues.jboss.org/browse/WFCORE-74","created_at":"2015-08-11T20:21:23Z","updated_at":"2015-08-20T06:53:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bd4eccca0fbded6d7d37d07fd215b71f38e071c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/951/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/951/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/951/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/2dc022f8cd20b501a952453b062942f49d3e03e9","head":{"label":"ehsavoie:WFCORE-74","ref":"WFCORE-74","sha":"2dc022f8cd20b501a952453b062942f49d3e03e9","user":{"login":"ehsavoie","id":73053,"avatar_url":"https://avatars.githubusercontent.com/u/73053?v=3","gravatar_id":"","url":"https://api.github.com/users/ehsavoie","html_url":"https://github.com/ehsavoie","followers_url":"https://api.github.com/users/ehsavoie/followers","following_url":"https://api.github.com/users/ehsavoie/following{/other_user}","gists_url":"https://api.github.com/users/ehsavoie/gists{/gist_id}","starred_url":"https://api.github.com/users/ehsavoie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehsavoie/subscriptions","organizations_url":"https://api.github.com/users/ehsavoie/orgs","repos_url":"https://api.github.com/users/ehsavoie/repos","events_url":"https://api.github.com/users/ehsavoie/events{/privacy}","received_events_url":"https://api.github.com/users/ehsavoie/received_events","type":"User","site_admin":false},"repo":{"id":21896147,"name":"wildfly-core","full_name":"ehsavoie/wildfly-core","owner":{"login":"ehsavoie","id":73053,"avatar_url":"https://avatars.githubusercontent.com/u/73053?v=3","gravatar_id":"","url":"https://api.github.com/users/ehsavoie","html_url":"https://github.com/ehsavoie","followers_url":"https://api.github.com/users/ehsavoie/followers","following_url":"https://api.github.com/users/ehsavoie/following{/other_user}","gists_url":"https://api.github.com/users/ehsavoie/gists{/gist_id}","starred_url":"https://api.github.com/users/ehsavoie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehsavoie/subscriptions","organizations_url":"https://api.github.com/users/ehsavoie/orgs","repos_url":"https://api.github.com/users/ehsavoie/repos","events_url":"https://api.github.com/users/ehsavoie/events{/privacy}","received_events_url":"https://api.github.com/users/ehsavoie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ehsavoie/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/ehsavoie/wildfly-core","forks_url":"https://api.github.com/repos/ehsavoie/wildfly-core/forks","keys_url":"https://api.github.com/repos/ehsavoie/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehsavoie/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehsavoie/wildfly-core/teams","hooks_url":"https://api.github.com/repos/ehsavoie/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/ehsavoie/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/ehsavoie/wildfly-core/events","assignees_url":"https://api.github.com/repos/ehsavoie/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/ehsavoie/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/ehsavoie/wildfly-core/tags","blobs_url":"https://api.github.com/repos/ehsavoie/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehsavoie/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehsavoie/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehsavoie/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehsavoie/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ehsavoie/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/ehsavoie/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/ehsavoie/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/ehsavoie/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/ehsavoie/wildfly-core/subscription","commits_url":"https://api.github.com/repos/ehsavoie/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehsavoie/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehsavoie/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehsavoie/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehsavoie/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/ehsavoie/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehsavoie/wildfly-core/merges","archive_url":"https://api.github.com/repos/ehsavoie/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehsavoie/wildfly-core/downloads","issues_url":"https://api.github.com/repos/ehsavoie/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/ehsavoie/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ehsavoie/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ehsavoie/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehsavoie/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/ehsavoie/wildfly-core/releases{/id}","created_at":"2014-07-16T10:20:50Z","updated_at":"2014-08-07T07:28:12Z","pushed_at":"2015-08-19T16:12:59Z","git_url":"git://github.com/ehsavoie/wildfly-core.git","ssh_url":"git@github.com:ehsavoie/wildfly-core.git","clone_url":"https://github.com/ehsavoie/wildfly-core.git","svn_url":"https://github.com/ehsavoie/wildfly-core","homepage":null,"size":42126,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"aab3cb31ae5dacee0ae87c2fb6da167108b06340","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"name":"wildfly-core","full_name":"wildfly/wildfly-core","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","created_at":"2014-07-01T16:33:34Z","updated_at":"2015-07-26T14:40:02Z","pushed_at":"2015-08-19T23:11:23Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":50586,"stargazers_count":30,"watchers_count":30,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":149,"mirror_url":null,"open_issues_count":17,"forks":149,"open_issues":17,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/951"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/951"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/951"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/951/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/951/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/951/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/2dc022f8cd20b501a952453b062942f49d3e03e9"}}}}