{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/22368","labels_url":"https://api.github.com/repos/saltstack/salt/issues/22368/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/22368/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/22368/events","html_url":"https://github.com/saltstack/salt/pull/22368","id":66442612,"number":22368,"title":"Make iptables module build_rules accept protocol as an alias for proto","user":{"login":"anlutro","id":163093,"avatar_url":"https://avatars.githubusercontent.com/u/163093?v=3","gravatar_id":"","url":"https://api.github.com/users/anlutro","html_url":"https://github.com/anlutro","followers_url":"https://api.github.com/users/anlutro/followers","following_url":"https://api.github.com/users/anlutro/following{/other_user}","gists_url":"https://api.github.com/users/anlutro/gists{/gist_id}","starred_url":"https://api.github.com/users/anlutro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anlutro/subscriptions","organizations_url":"https://api.github.com/users/anlutro/orgs","repos_url":"https://api.github.com/users/anlutro/repos","events_url":"https://api.github.com/users/anlutro/events{/privacy}","received_events_url":"https://api.github.com/users/anlutro/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-05T14:20:12Z","updated_at":"2015-04-05T15:58:05Z","closed_at":"2015-04-05T15:57:55Z","pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/22368","html_url":"https://github.com/saltstack/salt/pull/22368","diff_url":"https://github.com/saltstack/salt/pull/22368.diff","patch_url":"https://github.com/saltstack/salt/pull/22368.patch"},"body":"The salt documentation mentions that **kwargs passed to an iptables state such as iptables.append are passed to the iptables command as a long command line option ([here](https://github.com/saltstack/salt/blob/a60579bcf5a3bbb6c94191d1e4aebe7da1242959/salt/states/iptables.py#L309-L312), for example). This is not the case, as `--proto` is not an iptables option, whereas `--protocol` is.\r\n\r\nAs far as I can tell, the option is `--proto` for some other iptables commands, but not the main one. I think the most flexible solution here is to just make them both work, which is what this change does."},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/89796288","html_url":"https://github.com/saltstack/salt/pull/22368#issuecomment-89796288","issue_url":"https://api.github.com/repos/saltstack/salt/issues/22368","id":89796288,"user":{"login":"techhat","id":287147,"avatar_url":"https://avatars.githubusercontent.com/u/287147?v=3","gravatar_id":"","url":"https://api.github.com/users/techhat","html_url":"https://github.com/techhat","followers_url":"https://api.github.com/users/techhat/followers","following_url":"https://api.github.com/users/techhat/following{/other_user}","gists_url":"https://api.github.com/users/techhat/gists{/gist_id}","starred_url":"https://api.github.com/users/techhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techhat/subscriptions","organizations_url":"https://api.github.com/users/techhat/orgs","repos_url":"https://api.github.com/users/techhat/repos","events_url":"https://api.github.com/users/techhat/events{/privacy}","received_events_url":"https://api.github.com/users/techhat/received_events","type":"User","site_admin":false},"created_at":"2015-04-05T15:58:05Z","updated_at":"2015-04-05T15:58:05Z","body":"Thanks @anlutro!"}}