{"action":"created","comment":{"url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/comments/31905473","id":31905473,"diff_hunk":"@@ -0,0 +1,59 @@\n+<% if @firm.errors.any? %>\n+  <div class=\"t-validation-summary\">\n+    <%= f.validation_summary %>\n+  </div>\n+<% end %>\n+\n+<section class=\"form-section\">\n+  <div class=\"form-section__heading-with-button\">\n+    <% if f.object.trading_name? %>\n+      <h2 class=\"form-section__heading-with-button__heading\"><%= t('dashboard.firm_edit.trading_name_heading') %></h2>\n+    <% else %>\n+      <h2 class=\"form-section__heading-with-button__heading\"><%= t('dashboard.firm_edit.firm_heading') %></h2>\n+      <a class=\"form-section__heading-with-button__button button button--primary\"><%= t('dashboard.add_trading_name_button') %></a>","path":"app/views/dashboard/firms/_form.html.erb","position":13,"original_position":13,"commit_id":"edf01a33130f37c8da45d394ee7acc91b2f7fdfe","original_commit_id":"f269bb173f07bbfa51ddb5a3acdc880257f2b89a","user":{"login":"benbarnett","id":295469,"avatar_url":"https://avatars.githubusercontent.com/u/295469?v=3","gravatar_id":"","url":"https://api.github.com/users/benbarnett","html_url":"https://github.com/benbarnett","followers_url":"https://api.github.com/users/benbarnett/followers","following_url":"https://api.github.com/users/benbarnett/following{/other_user}","gists_url":"https://api.github.com/users/benbarnett/gists{/gist_id}","starred_url":"https://api.github.com/users/benbarnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbarnett/subscriptions","organizations_url":"https://api.github.com/users/benbarnett/orgs","repos_url":"https://api.github.com/users/benbarnett/repos","events_url":"https://api.github.com/users/benbarnett/events{/privacy}","received_events_url":"https://api.github.com/users/benbarnett/received_events","type":"User","site_admin":false},"body":"I know this was just moved around on this PR but might've missed it before. This classlist got a little crazy.\r\n\r\nIt might be an idea to use a layout in this context. This would essentially say that all `button`'s in this layout should look have this style. For example:\r\n\r\n```css\r\n.l-form-section .button {\r\n  float: right;\r\n}\r\n``` \r\n\r\nIts a cleaner way to override component's initial styles and removes the need to have a big long class list like this one. \r\n\r\nIt also avoids components styling the same element and therefore competing for specificity (which I'm guessing is why https://github.com/moneyadviceservice/rad/commit/edf01a33130f37c8da45d394ee7acc91b2f7fdfe might've been there?). With a layout class, you're nearly always one level more 'specific'.\r\n\r\nYou could just wrap each `form-section` in a `l-form-section` container, or all of them in one – whichever you feel works best.","created_at":"2015-06-08T11:31:12Z","updated_at":"2015-06-08T11:31:12Z","html_url":"https://github.com/moneyadviceservice/rad/pull/209#discussion_r31905473","pull_request_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/209","_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/comments/31905473"},"html":{"href":"https://github.com/moneyadviceservice/rad/pull/209#discussion_r31905473"},"pull_request":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/209"}}},"pull_request":{"url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/209","id":37139843,"html_url":"https://github.com/moneyadviceservice/rad/pull/209","diff_url":"https://github.com/moneyadviceservice/rad/pull/209.diff","patch_url":"https://github.com/moneyadviceservice/rad/pull/209.patch","issue_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/209","number":209,"state":"open","locked":false,"title":"Feature to add trading names","user":{"login":"neoeno","id":1007202,"avatar_url":"https://avatars.githubusercontent.com/u/1007202?v=3","gravatar_id":"","url":"https://api.github.com/users/neoeno","html_url":"https://github.com/neoeno","followers_url":"https://api.github.com/users/neoeno/followers","following_url":"https://api.github.com/users/neoeno/following{/other_user}","gists_url":"https://api.github.com/users/neoeno/gists{/gist_id}","starred_url":"https://api.github.com/users/neoeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neoeno/subscriptions","organizations_url":"https://api.github.com/users/neoeno/orgs","repos_url":"https://api.github.com/users/neoeno/repos","events_url":"https://api.github.com/users/neoeno/events{/privacy}","received_events_url":"https://api.github.com/users/neoeno/received_events","type":"User","site_admin":false},"body":"There's a list of available trading names that gets imported from the FCA data into Lookup::Subsidiaries. This populates a table, and each row has link that points to a TradingNamesController#new action with a param specifying the FCA record to base it on.\r\n\r\nFrom this point, it's just a regular TradingName, which is a kind of Firm — so we reuse most of the logic for editing firms by inheriting from an abstract controller.","created_at":"2015-06-08T10:28:30Z","updated_at":"2015-06-08T11:31:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02c84aa5928273ec4cd3f51a8dbd214c6ee04406","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/209/commits","review_comments_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/209/comments","review_comment_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/209/comments","statuses_url":"https://api.github.com/repos/moneyadviceservice/rad/statuses/edf01a33130f37c8da45d394ee7acc91b2f7fdfe","head":{"label":"moneyadviceservice:feature/add_trading_names","ref":"feature/add_trading_names","sha":"edf01a33130f37c8da45d394ee7acc91b2f7fdfe","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":26871523,"name":"rad","full_name":"moneyadviceservice/rad","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/rad","description":"Retirement Adviser Directory","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/rad","forks_url":"https://api.github.com/repos/moneyadviceservice/rad/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/rad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/rad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/rad/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/rad/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/rad/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/rad/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/rad/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/rad/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/rad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/rad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/rad/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/rad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/rad/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/rad/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/rad/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/rad/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/rad/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/rad/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/rad/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/rad/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/rad/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/comments{/number}","contents_url":"https://api.github.com/repos/moneyadviceservice/rad/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/rad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/rad/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/rad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/rad/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/rad/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/rad/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/rad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/rad/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/rad/releases{/id}","created_at":"2014-11-19T16:55:48Z","updated_at":"2015-06-03T11:23:50Z","pushed_at":"2015-06-08T11:28:20Z","git_url":"git://github.com/moneyadviceservice/rad.git","ssh_url":"git@github.com:moneyadviceservice/rad.git","clone_url":"https://github.com/moneyadviceservice/rad.git","svn_url":"https://github.com/moneyadviceservice/rad","homepage":"","size":7329,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"moneyadviceservice:master","ref":"master","sha":"04995a13360808023c944492af64b6002d8e68eb","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":26871523,"name":"rad","full_name":"moneyadviceservice/rad","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/rad","description":"Retirement Adviser Directory","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/rad","forks_url":"https://api.github.com/repos/moneyadviceservice/rad/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/rad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/rad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/rad/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/rad/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/rad/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/rad/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/rad/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/rad/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/rad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/rad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/rad/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/rad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/rad/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/rad/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/rad/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/rad/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/rad/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/rad/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/rad/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/rad/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/rad/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/rad/issues/comments{/number}","contents_url":"https://api.github.com/repos/moneyadviceservice/rad/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/rad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/rad/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/rad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/rad/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/rad/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/rad/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/rad/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/rad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/rad/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/rad/releases{/id}","created_at":"2014-11-19T16:55:48Z","updated_at":"2015-06-03T11:23:50Z","pushed_at":"2015-06-08T11:28:20Z","git_url":"git://github.com/moneyadviceservice/rad.git","ssh_url":"git@github.com:moneyadviceservice/rad.git","clone_url":"https://github.com/moneyadviceservice/rad.git","svn_url":"https://github.com/moneyadviceservice/rad","homepage":"","size":7329,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/209"},"html":{"href":"https://github.com/moneyadviceservice/rad/pull/209"},"issue":{"href":"https://api.github.com/repos/moneyadviceservice/rad/issues/209"},"comments":{"href":"https://api.github.com/repos/moneyadviceservice/rad/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moneyadviceservice/rad/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/moneyadviceservice/rad/statuses/edf01a33130f37c8da45d394ee7acc91b2f7fdfe"}}}}