{"action":"closed","issue":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/376","labels_url":"https://api.github.com/repos/catapult-project/catapult/issues/376/labels{/name}","comments_url":"https://api.github.com/repos/catapult-project/catapult/issues/376/comments","events_url":"https://api.github.com/repos/catapult-project/catapult/issues/376/events","html_url":"https://github.com/catapult-project/catapult/issues/376","id":98560291,"number":376,"title":"TimelineCounterSamples impedence mismatch with analysis & track code","user":{"login":"catapult-bot","id":13457154,"avatar_url":"https://avatars.githubusercontent.com/u/13457154?v=3","gravatar_id":"","url":"https://api.github.com/users/catapult-bot","html_url":"https://github.com/catapult-bot","followers_url":"https://api.github.com/users/catapult-bot/followers","following_url":"https://api.github.com/users/catapult-bot/following{/other_user}","gists_url":"https://api.github.com/users/catapult-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/catapult-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catapult-bot/subscriptions","organizations_url":"https://api.github.com/users/catapult-bot/orgs","repos_url":"https://api.github.com/users/catapult-bot/repos","events_url":"https://api.github.com/users/catapult-bot/events{/privacy}","received_events_url":"https://api.github.com/users/catapult-bot/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/catapult-project/catapult/labels/P2","name":"P2","color":"fbca04"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-08-01T20:38:11Z","updated_at":"2015-08-01T20:38:17Z","closed_at":"2015-08-01T20:38:17Z","body":"<a href=\"https://github.com/natduca\"><img src=\"https://avatars.githubusercontent.com/u/412396?v=3\" align=\"left\" width=\"96\" height=\"96\" hspace=\"10\"></img></a> **Issue by [natduca](https://github.com/natduca)**\n_Monday Sep 22, 2014 at 20:15 GMT_\n_Originally opened as https://github.com/google/trace-viewer/issues/376_\n\n----\n\n_From [nd...@chromium.org](https://code.google.com/u/102435256078839283966/) on August 05, 2013 11:08:47_\n\nIf we want to go toward a world were we track selected states entirely in a map from guid -> {...., selected state}, then we need to make sure that everything that is selectable has a guid.\r\n\r\nRight now, TimelineCounterSample is the thing with the GUID. But, the current analysis UI and counter track treats selection as picking all the samples at a given timestamp.\r\n\r\nI think the model is correct --- TimelineCounterSample is the selectable thing. The counter should probably just emit all the samples for the selected index. And, analysis should re-grouop samples by their timestamp before doing the analysis (or become robust to individual samples being selected).\n\n_Original issue: http://code.google.com/p/trace-viewer/issues/detail?id=371_\n"}}