{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/36310495","id":36310495,"diff_hunk":"@@ -44,6 +46,61 @@ message GossipRequest {\n message GossipResponse {\n   // Requested delta of server's infostore.\n   optional bytes delta = 1;\n+  // TODO(thschroeter): replace bytes with GossipInfoStore\n+  //optional GossipInfoStore delta = 1;\n   // Non-nil means client should retry with this address.\n   optional Addr alternate = 2;\n }\n+\n+message GossipInfoStore {\n+  // Map from key to info\n+  map<string, GossipInfo> infos = 1;","path":"proto/gossip.proto","position":21,"original_position":21,"commit_id":"d031e88dcdc0d4d16c8edc8aa8869109105c1277","original_commit_id":"d031e88dcdc0d4d16c8edc8aa8869109105c1277","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"so this is interesting. @thschroeter does this actually work? maps are a protobuf 3 feature, and this file (and all the others) are explicitly protobuf 2 syntax.\r\n\r\nI'm ok with introducing some protobuf 3, especially if it helps achieve specific goals (like getting us off of gob), but we should do it piecemeal and separately from existing protos. In this case, we'd want to put this proto in a new package.","created_at":"2015-08-05T14:52:13Z","updated_at":"2015-08-05T14:52:13Z","html_url":"https://github.com/cockroachdb/cockroach/pull/1966#discussion_r36310495","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1966","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/36310495"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/1966#discussion_r36310495"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1966"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1966","id":41677554,"html_url":"https://github.com/cockroachdb/cockroach/pull/1966","diff_url":"https://github.com/cockroachdb/cockroach/pull/1966.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/1966.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/1966","number":1966,"state":"open","locked":false,"title":"WIP towards gossiping proto only","user":{"login":"thschroeter","id":40804,"avatar_url":"https://avatars.githubusercontent.com/u/40804?v=3","gravatar_id":"","url":"https://api.github.com/users/thschroeter","html_url":"https://github.com/thschroeter","followers_url":"https://api.github.com/users/thschroeter/followers","following_url":"https://api.github.com/users/thschroeter/following{/other_user}","gists_url":"https://api.github.com/users/thschroeter/gists{/gist_id}","starred_url":"https://api.github.com/users/thschroeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thschroeter/subscriptions","organizations_url":"https://api.github.com/users/thschroeter/orgs","repos_url":"https://api.github.com/users/thschroeter/repos","events_url":"https://api.github.com/users/thschroeter/events{/privacy}","received_events_url":"https://api.github.com/users/thschroeter/received_events","type":"User","site_admin":false},"body":"#629, @tamird, please take a look.\r\n\r\nI will need some help with encoding and gossiping `PrefixConfigMap` as proto.\r\n\r\nSo far I've added `proto.GossipInfoStore` and some helpers to copy data to and from `gossip.*` to `proto.GossipInfoStore`. If you think this approach is valid, I continue today to define the proto structures for encoding of `PrefixConfigMap`, and then test gossiping using the new proto structures.\r\n\r\nMaye there is a simpler approach, that leads to fewer changes?\r\n\r\nI think, it's possible to continue refactoring and use the new proto structures in `gossip.infoStore` to avoid having to copy data. I still need some time to\r\n - continue refactoring\r\n - make sure gossip still works as expected.\r\n\r\n","created_at":"2015-08-05T13:20:46Z","updated_at":"2015-08-05T14:52:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18269f525321d922a76805b72841f712a6ce1a3c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1966/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1966/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/1966/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/d031e88dcdc0d4d16c8edc8aa8869109105c1277","head":{"label":"thschroeter:gossip-proto-not-gob","ref":"gossip-proto-not-gob","sha":"d031e88dcdc0d4d16c8edc8aa8869109105c1277","user":{"login":"thschroeter","id":40804,"avatar_url":"https://avatars.githubusercontent.com/u/40804?v=3","gravatar_id":"","url":"https://api.github.com/users/thschroeter","html_url":"https://github.com/thschroeter","followers_url":"https://api.github.com/users/thschroeter/followers","following_url":"https://api.github.com/users/thschroeter/following{/other_user}","gists_url":"https://api.github.com/users/thschroeter/gists{/gist_id}","starred_url":"https://api.github.com/users/thschroeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thschroeter/subscriptions","organizations_url":"https://api.github.com/users/thschroeter/orgs","repos_url":"https://api.github.com/users/thschroeter/repos","events_url":"https://api.github.com/users/thschroeter/events{/privacy}","received_events_url":"https://api.github.com/users/thschroeter/received_events","type":"User","site_admin":false},"repo":{"id":29617637,"name":"cockroach","full_name":"thschroeter/cockroach","owner":{"login":"thschroeter","id":40804,"avatar_url":"https://avatars.githubusercontent.com/u/40804?v=3","gravatar_id":"","url":"https://api.github.com/users/thschroeter","html_url":"https://github.com/thschroeter","followers_url":"https://api.github.com/users/thschroeter/followers","following_url":"https://api.github.com/users/thschroeter/following{/other_user}","gists_url":"https://api.github.com/users/thschroeter/gists{/gist_id}","starred_url":"https://api.github.com/users/thschroeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thschroeter/subscriptions","organizations_url":"https://api.github.com/users/thschroeter/orgs","repos_url":"https://api.github.com/users/thschroeter/repos","events_url":"https://api.github.com/users/thschroeter/events{/privacy}","received_events_url":"https://api.github.com/users/thschroeter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thschroeter/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":true,"url":"https://api.github.com/repos/thschroeter/cockroach","forks_url":"https://api.github.com/repos/thschroeter/cockroach/forks","keys_url":"https://api.github.com/repos/thschroeter/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thschroeter/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thschroeter/cockroach/teams","hooks_url":"https://api.github.com/repos/thschroeter/cockroach/hooks","issue_events_url":"https://api.github.com/repos/thschroeter/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/thschroeter/cockroach/events","assignees_url":"https://api.github.com/repos/thschroeter/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/thschroeter/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/thschroeter/cockroach/tags","blobs_url":"https://api.github.com/repos/thschroeter/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thschroeter/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thschroeter/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/thschroeter/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thschroeter/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/thschroeter/cockroach/languages","stargazers_url":"https://api.github.com/repos/thschroeter/cockroach/stargazers","contributors_url":"https://api.github.com/repos/thschroeter/cockroach/contributors","subscribers_url":"https://api.github.com/repos/thschroeter/cockroach/subscribers","subscription_url":"https://api.github.com/repos/thschroeter/cockroach/subscription","commits_url":"https://api.github.com/repos/thschroeter/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/thschroeter/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/thschroeter/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/thschroeter/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/thschroeter/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/thschroeter/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thschroeter/cockroach/merges","archive_url":"https://api.github.com/repos/thschroeter/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thschroeter/cockroach/downloads","issues_url":"https://api.github.com/repos/thschroeter/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/thschroeter/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/thschroeter/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/thschroeter/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thschroeter/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/thschroeter/cockroach/releases{/id}","created_at":"2015-01-21T21:38:27Z","updated_at":"2015-01-21T21:38:29Z","pushed_at":"2015-08-05T13:00:11Z","git_url":"git://github.com/thschroeter/cockroach.git","ssh_url":"git@github.com:thschroeter/cockroach.git","clone_url":"https://github.com/thschroeter/cockroach.git","svn_url":"https://github.com/thschroeter/cockroach","homepage":null,"size":9087,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"106246ba0e1242a2715f1a8770aa338b7ab0f193","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","created_at":"2014-02-06T00:18:47Z","updated_at":"2015-08-04T10:44:09Z","pushed_at":"2015-08-05T14:52:00Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":null,"size":46413,"stargazers_count":4960,"watchers_count":4960,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":390,"mirror_url":null,"open_issues_count":132,"forks":390,"open_issues":132,"watchers":4960,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1966"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/1966"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/1966"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/1966/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1966/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/1966/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/d031e88dcdc0d4d16c8edc8aa8869109105c1277"}}}}