{"action":"created","comment":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/31935087","id":31935087,"diff_hunk":"@@ -210,13 +217,15 @@ class configuration:\n   # A dictionary of the linker flags to use for each compiler type\n   linker_flags = dict()\n \n-  if (get_platform()[:6] == 'macosx'):\n+  if ('macosx' in get_platform()):\n     linker_flags['gcc'] = ['-fopenmp', '-dynamiclib', '-lpython2.7',\n                            '-Wl,-install_name,' + get_openmoc_object_name()]\n   else:\n     linker_flags['gcc'] = ['-fopenmp', '-shared',\n                            '-Wl,-soname,' + get_openmoc_object_name()]\n \n+  linker_flags['clang'] = ['-fopenmp', '-shared',\n+                         '-Wl,-soname,' + get_openmoc_object_name()]","path":"config.py","position":120,"original_position":120,"commit_id":"e249905d1c70b79e4f94e018bf01a6363246571e","original_commit_id":"e249905d1c70b79e4f94e018bf01a6363246571e","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"body":"The `-soname` and `-shared` linker flags for clang should be changed to '-install_name' and `-dynamiclib` for clang on mac OS X just as with gcc.","created_at":"2015-06-08T16:54:16Z","updated_at":"2015-06-08T16:54:16Z","html_url":"https://github.com/mit-crpg/OpenMOC/pull/149#discussion_r31935087","pull_request_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/149","_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/31935087"},"html":{"href":"https://github.com/mit-crpg/OpenMOC/pull/149#discussion_r31935087"},"pull_request":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/149"}}},"pull_request":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/149","id":35904782,"html_url":"https://github.com/mit-crpg/OpenMOC/pull/149","diff_url":"https://github.com/mit-crpg/OpenMOC/pull/149.diff","patch_url":"https://github.com/mit-crpg/OpenMOC/pull/149.patch","issue_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/149","number":149,"state":"open","locked":false,"title":"Simplified build system","user":{"login":"wbinventor","id":209492,"avatar_url":"https://avatars.githubusercontent.com/u/209492?v=3","gravatar_id":"","url":"https://api.github.com/users/wbinventor","html_url":"https://github.com/wbinventor","followers_url":"https://api.github.com/users/wbinventor/followers","following_url":"https://api.github.com/users/wbinventor/following{/other_user}","gists_url":"https://api.github.com/users/wbinventor/gists{/gist_id}","starred_url":"https://api.github.com/users/wbinventor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbinventor/subscriptions","organizations_url":"https://api.github.com/users/wbinventor/orgs","repos_url":"https://api.github.com/users/wbinventor/repos","events_url":"https://api.github.com/users/wbinventor/events{/privacy}","received_events_url":"https://api.github.com/users/wbinventor/received_events","type":"User","site_admin":false},"body":"This PR greatly simplifies the distutils-based build system. In particular, the ability to compile and install different OpenMOC installations (*.e.g.*, ``openmoc.intel.single``, ``openmoc.gnu.double``, etc.) is eliminated since it was mainly useful for my M.S. thesis and not much else. In addition several changes were made to the \"setup.py\" and \"config.py\" files to make them more intuitive for developers to navigate and extend. The overall effect of these changes is to largely gut the build system to make it simpler and more effective. This PR is independent of all other PR's currently in the queue and can be reviewed on its own, though it will nicely complement #148.","created_at":"2015-05-21T06:57:44Z","updated_at":"2015-06-08T16:54:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9a0eda1b8ed9dd1ff0389ff48e2ba0ba90a8a39","assignee":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/milestones/3","html_url":"https://github.com/mit-crpg/OpenMOC/milestones/v0.1.5","labels_url":"https://api.github.com/repos/mit-crpg/OpenMOC/milestones/3/labels","id":980734,"number":3,"title":"v0.1.5","description":"","creator":{"login":"wbinventor","id":209492,"avatar_url":"https://avatars.githubusercontent.com/u/209492?v=3","gravatar_id":"","url":"https://api.github.com/users/wbinventor","html_url":"https://github.com/wbinventor","followers_url":"https://api.github.com/users/wbinventor/followers","following_url":"https://api.github.com/users/wbinventor/following{/other_user}","gists_url":"https://api.github.com/users/wbinventor/gists{/gist_id}","starred_url":"https://api.github.com/users/wbinventor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbinventor/subscriptions","organizations_url":"https://api.github.com/users/wbinventor/orgs","repos_url":"https://api.github.com/users/wbinventor/repos","events_url":"https://api.github.com/users/wbinventor/events{/privacy}","received_events_url":"https://api.github.com/users/wbinventor/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":14,"state":"open","created_at":"2015-02-16T04:36:42Z","updated_at":"2015-06-05T13:19:27Z","due_on":"2015-05-31T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/149/commits","review_comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/149/comments","review_comment_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/149/comments","statuses_url":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/e249905d1c70b79e4f94e018bf01a6363246571e","head":{"label":"wbinventor:simpler-build","ref":"simpler-build","sha":"e249905d1c70b79e4f94e018bf01a6363246571e","user":{"login":"wbinventor","id":209492,"avatar_url":"https://avatars.githubusercontent.com/u/209492?v=3","gravatar_id":"","url":"https://api.github.com/users/wbinventor","html_url":"https://github.com/wbinventor","followers_url":"https://api.github.com/users/wbinventor/followers","following_url":"https://api.github.com/users/wbinventor/following{/other_user}","gists_url":"https://api.github.com/users/wbinventor/gists{/gist_id}","starred_url":"https://api.github.com/users/wbinventor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbinventor/subscriptions","organizations_url":"https://api.github.com/users/wbinventor/orgs","repos_url":"https://api.github.com/users/wbinventor/repos","events_url":"https://api.github.com/users/wbinventor/events{/privacy}","received_events_url":"https://api.github.com/users/wbinventor/received_events","type":"User","site_admin":false},"repo":{"id":17987110,"name":"OpenMOC","full_name":"wbinventor/OpenMOC","owner":{"login":"wbinventor","id":209492,"avatar_url":"https://avatars.githubusercontent.com/u/209492?v=3","gravatar_id":"","url":"https://api.github.com/users/wbinventor","html_url":"https://github.com/wbinventor","followers_url":"https://api.github.com/users/wbinventor/followers","following_url":"https://api.github.com/users/wbinventor/following{/other_user}","gists_url":"https://api.github.com/users/wbinventor/gists{/gist_id}","starred_url":"https://api.github.com/users/wbinventor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbinventor/subscriptions","organizations_url":"https://api.github.com/users/wbinventor/orgs","repos_url":"https://api.github.com/users/wbinventor/repos","events_url":"https://api.github.com/users/wbinventor/events{/privacy}","received_events_url":"https://api.github.com/users/wbinventor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wbinventor/OpenMOC","description":"A method of characteristics code for nuclear reactor physics calculations.","fork":true,"url":"https://api.github.com/repos/wbinventor/OpenMOC","forks_url":"https://api.github.com/repos/wbinventor/OpenMOC/forks","keys_url":"https://api.github.com/repos/wbinventor/OpenMOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wbinventor/OpenMOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wbinventor/OpenMOC/teams","hooks_url":"https://api.github.com/repos/wbinventor/OpenMOC/hooks","issue_events_url":"https://api.github.com/repos/wbinventor/OpenMOC/issues/events{/number}","events_url":"https://api.github.com/repos/wbinventor/OpenMOC/events","assignees_url":"https://api.github.com/repos/wbinventor/OpenMOC/assignees{/user}","branches_url":"https://api.github.com/repos/wbinventor/OpenMOC/branches{/branch}","tags_url":"https://api.github.com/repos/wbinventor/OpenMOC/tags","blobs_url":"https://api.github.com/repos/wbinventor/OpenMOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wbinventor/OpenMOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wbinventor/OpenMOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/wbinventor/OpenMOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wbinventor/OpenMOC/statuses/{sha}","languages_url":"https://api.github.com/repos/wbinventor/OpenMOC/languages","stargazers_url":"https://api.github.com/repos/wbinventor/OpenMOC/stargazers","contributors_url":"https://api.github.com/repos/wbinventor/OpenMOC/contributors","subscribers_url":"https://api.github.com/repos/wbinventor/OpenMOC/subscribers","subscription_url":"https://api.github.com/repos/wbinventor/OpenMOC/subscription","commits_url":"https://api.github.com/repos/wbinventor/OpenMOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/wbinventor/OpenMOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/wbinventor/OpenMOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/wbinventor/OpenMOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/wbinventor/OpenMOC/contents/{+path}","compare_url":"https://api.github.com/repos/wbinventor/OpenMOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wbinventor/OpenMOC/merges","archive_url":"https://api.github.com/repos/wbinventor/OpenMOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wbinventor/OpenMOC/downloads","issues_url":"https://api.github.com/repos/wbinventor/OpenMOC/issues{/number}","pulls_url":"https://api.github.com/repos/wbinventor/OpenMOC/pulls{/number}","milestones_url":"https://api.github.com/repos/wbinventor/OpenMOC/milestones{/number}","notifications_url":"https://api.github.com/repos/wbinventor/OpenMOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wbinventor/OpenMOC/labels{/name}","releases_url":"https://api.github.com/repos/wbinventor/OpenMOC/releases{/id}","created_at":"2014-03-21T16:55:16Z","updated_at":"2014-12-03T14:21:53Z","pushed_at":"2015-06-05T12:58:27Z","git_url":"git://github.com/wbinventor/OpenMOC.git","ssh_url":"git@github.com:wbinventor/OpenMOC.git","clone_url":"https://github.com/wbinventor/OpenMOC.git","svn_url":"https://github.com/wbinventor/OpenMOC","homepage":"https://mit-crpg.github.io/OpenMOC/","size":73764,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mit-crpg:develop","ref":"develop","sha":"af371acba194156f1611572618f6232edcaa398a","user":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"repo":{"id":8780988,"name":"OpenMOC","full_name":"mit-crpg/OpenMOC","owner":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mit-crpg/OpenMOC","description":"A method of characteristics code for nuclear reactor physics calculations.","fork":false,"url":"https://api.github.com/repos/mit-crpg/OpenMOC","forks_url":"https://api.github.com/repos/mit-crpg/OpenMOC/forks","keys_url":"https://api.github.com/repos/mit-crpg/OpenMOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit-crpg/OpenMOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit-crpg/OpenMOC/teams","hooks_url":"https://api.github.com/repos/mit-crpg/OpenMOC/hooks","issue_events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/events{/number}","events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/events","assignees_url":"https://api.github.com/repos/mit-crpg/OpenMOC/assignees{/user}","branches_url":"https://api.github.com/repos/mit-crpg/OpenMOC/branches{/branch}","tags_url":"https://api.github.com/repos/mit-crpg/OpenMOC/tags","blobs_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/{sha}","languages_url":"https://api.github.com/repos/mit-crpg/OpenMOC/languages","stargazers_url":"https://api.github.com/repos/mit-crpg/OpenMOC/stargazers","contributors_url":"https://api.github.com/repos/mit-crpg/OpenMOC/contributors","subscribers_url":"https://api.github.com/repos/mit-crpg/OpenMOC/subscribers","subscription_url":"https://api.github.com/repos/mit-crpg/OpenMOC/subscription","commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/mit-crpg/OpenMOC/contents/{+path}","compare_url":"https://api.github.com/repos/mit-crpg/OpenMOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit-crpg/OpenMOC/merges","archive_url":"https://api.github.com/repos/mit-crpg/OpenMOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit-crpg/OpenMOC/downloads","issues_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues{/number}","pulls_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls{/number}","milestones_url":"https://api.github.com/repos/mit-crpg/OpenMOC/milestones{/number}","notifications_url":"https://api.github.com/repos/mit-crpg/OpenMOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit-crpg/OpenMOC/labels{/name}","releases_url":"https://api.github.com/repos/mit-crpg/OpenMOC/releases{/id}","created_at":"2013-03-14T17:19:26Z","updated_at":"2015-06-03T01:42:03Z","pushed_at":"2015-06-05T19:26:44Z","git_url":"git://github.com/mit-crpg/OpenMOC.git","ssh_url":"git@github.com:mit-crpg/OpenMOC.git","clone_url":"https://github.com/mit-crpg/OpenMOC.git","svn_url":"https://github.com/mit-crpg/OpenMOC","homepage":"https://mit-crpg.github.io/OpenMOC/","size":111094,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":23,"forks":19,"open_issues":23,"watchers":13,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/149"},"html":{"href":"https://github.com/mit-crpg/OpenMOC/pull/149"},"issue":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/149"},"comments":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/e249905d1c70b79e4f94e018bf01a6363246571e"}}}}