{"action":"created","comment":{"url":"https://api.github.com/repos/gawkermedia/amqp-client/pulls/comments/28000433","id":28000433,"diff_hunk":"@@ -51,10 +60,9 @@ object ChannelOwner {\n           def handleFlow(active: Boolean): Unit = listener ! HandleFlow(active)\n         }))\n       }\n-      case request@Publish(exchange, routingKey, body, properties, mandatory, immediate) => {\n+      case request@Publish(_, _, _, _, _, _) => {","path":"src/main/scala/com/github.sstone/amqp/ChannelOwner.scala","position":36,"original_position":36,"commit_id":"b6f979f4e45055a9c9d8bfa1ee641738a7966f04","original_commit_id":"b6f979f4e45055a9c9d8bfa1ee641738a7966f04","user":{"login":"privateblue","id":888542,"avatar_url":"https://avatars.githubusercontent.com/u/888542?v=3","gravatar_id":"","url":"https://api.github.com/users/privateblue","html_url":"https://github.com/privateblue","followers_url":"https://api.github.com/users/privateblue/followers","following_url":"https://api.github.com/users/privateblue/following{/other_user}","gists_url":"https://api.github.com/users/privateblue/gists{/gist_id}","starred_url":"https://api.github.com/users/privateblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/privateblue/subscriptions","organizations_url":"https://api.github.com/users/privateblue/orgs","repos_url":"https://api.github.com/users/privateblue/repos","events_url":"https://api.github.com/users/privateblue/events{/privacy}","received_events_url":"https://api.github.com/users/privateblue/received_events","type":"User","site_admin":false},"body":"It's just a theoretical thing, that has no practical implications in this particular case. I would just prefer to have it as a reflex that we don't match on types, because matching on a type is like calling .isInstanceOf[] on something. If it becomes a reflex, then it won't happen in cases where it actually matters. \r\n\r\n(These are cases for example, when the function is parameterized, because in such cases isInstanceOf[] and typecasts break parametricity, which is a really useful property of such functions, that provides you with guarantees based on the type of the function. For example if you have an ```A => Boolan``` function, you can be sure that either it will always and only return true, or it will always and only return false, because if the only value that goes in is of type A, then you can only \"create\" a value of type Boolean, if you hardcode it. But if you return param.isInstanceOf[Int], then you lose this extra knowledge, that is encoded in the type of the function. This particular function is not parameterized, so parametricity is irrelevant here, and I might be wrong that getting into the habit of generally not matching on types is a good thing, because we are clever enough to distinguish, but to me it seems simpler to just avoid it. Anyway)","created_at":"2015-04-08T18:44:55Z","updated_at":"2015-04-08T18:44:55Z","html_url":"https://github.com/gawkermedia/amqp-client/pull/1#discussion_r28000433","pull_request_url":"https://api.github.com/repos/gawkermedia/amqp-client/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/gawkermedia/amqp-client/pulls/comments/28000433"},"html":{"href":"https://github.com/gawkermedia/amqp-client/pull/1#discussion_r28000433"},"pull_request":{"href":"https://api.github.com/repos/gawkermedia/amqp-client/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/gawkermedia/amqp-client/pulls/1","id":32422443,"html_url":"https://github.com/gawkermedia/amqp-client/pull/1","diff_url":"https://github.com/gawkermedia/amqp-client/pull/1.diff","patch_url":"https://github.com/gawkermedia/amqp-client/pull/1.patch","issue_url":"https://api.github.com/repos/gawkermedia/amqp-client/issues/1","number":1,"state":"open","locked":false,"title":"Return seq number and uuid for Publish and Confirmation","user":{"login":"leventem","id":10024983,"avatar_url":"https://avatars.githubusercontent.com/u/10024983?v=3","gravatar_id":"","url":"https://api.github.com/users/leventem","html_url":"https://github.com/leventem","followers_url":"https://api.github.com/users/leventem/followers","following_url":"https://api.github.com/users/leventem/following{/other_user}","gists_url":"https://api.github.com/users/leventem/gists{/gist_id}","starred_url":"https://api.github.com/users/leventem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leventem/subscriptions","organizations_url":"https://api.github.com/users/leventem/orgs","repos_url":"https://api.github.com/users/leventem/repos","events_url":"https://api.github.com/users/leventem/events{/privacy}","received_events_url":"https://api.github.com/users/leventem/received_events","type":"User","site_admin":false},"body":"### What does this PR do? How does it affect users?\r\nWhen receiving a Publish message, return the sequence number and the channel's uuid so that we can store it on the client side until the confirmation arrives.\r\n\r\n### How should this be tested (feature switches, URLs, special user permissions)?\r\nWhen switching the producer part to use \"ask\", we can check the content of the returned OK message.\r\n\r\n### Related Trello card, wiki page or blog posts\r\nhttps://trello.com/c/Il7iSgAt/323-configure-and-use-rabbitmq-in-linksupportservice\r\n\r\n@privateblue @stratiator please take a look","created_at":"2015-04-01T14:11:45Z","updated_at":"2015-04-08T18:44:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18e6de00b329b0f64d43ec0846be79481e477ef1","assignee":{"login":"stratiator","id":2676848,"avatar_url":"https://avatars.githubusercontent.com/u/2676848?v=3","gravatar_id":"","url":"https://api.github.com/users/stratiator","html_url":"https://github.com/stratiator","followers_url":"https://api.github.com/users/stratiator/followers","following_url":"https://api.github.com/users/stratiator/following{/other_user}","gists_url":"https://api.github.com/users/stratiator/gists{/gist_id}","starred_url":"https://api.github.com/users/stratiator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratiator/subscriptions","organizations_url":"https://api.github.com/users/stratiator/orgs","repos_url":"https://api.github.com/users/stratiator/repos","events_url":"https://api.github.com/users/stratiator/events{/privacy}","received_events_url":"https://api.github.com/users/stratiator/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/gawkermedia/amqp-client/pulls/1/commits","review_comments_url":"https://api.github.com/repos/gawkermedia/amqp-client/pulls/1/comments","review_comment_url":"https://api.github.com/repos/gawkermedia/amqp-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gawkermedia/amqp-client/issues/1/comments","statuses_url":"https://api.github.com/repos/gawkermedia/amqp-client/statuses/b6f979f4e45055a9c9d8bfa1ee641738a7966f04","head":{"label":"gawkermedia:return-seq-no","ref":"return-seq-no","sha":"b6f979f4e45055a9c9d8bfa1ee641738a7966f04","user":{"login":"gawkermedia","id":852924,"avatar_url":"https://avatars.githubusercontent.com/u/852924?v=3","gravatar_id":"","url":"https://api.github.com/users/gawkermedia","html_url":"https://github.com/gawkermedia","followers_url":"https://api.github.com/users/gawkermedia/followers","following_url":"https://api.github.com/users/gawkermedia/following{/other_user}","gists_url":"https://api.github.com/users/gawkermedia/gists{/gist_id}","starred_url":"https://api.github.com/users/gawkermedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gawkermedia/subscriptions","organizations_url":"https://api.github.com/users/gawkermedia/orgs","repos_url":"https://api.github.com/users/gawkermedia/repos","events_url":"https://api.github.com/users/gawkermedia/events{/privacy}","received_events_url":"https://api.github.com/users/gawkermedia/received_events","type":"Organization","site_admin":false},"repo":{"id":32338520,"name":"amqp-client","full_name":"gawkermedia/amqp-client","owner":{"login":"gawkermedia","id":852924,"avatar_url":"https://avatars.githubusercontent.com/u/852924?v=3","gravatar_id":"","url":"https://api.github.com/users/gawkermedia","html_url":"https://github.com/gawkermedia","followers_url":"https://api.github.com/users/gawkermedia/followers","following_url":"https://api.github.com/users/gawkermedia/following{/other_user}","gists_url":"https://api.github.com/users/gawkermedia/gists{/gist_id}","starred_url":"https://api.github.com/users/gawkermedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gawkermedia/subscriptions","organizations_url":"https://api.github.com/users/gawkermedia/orgs","repos_url":"https://api.github.com/users/gawkermedia/repos","events_url":"https://api.github.com/users/gawkermedia/events{/privacy}","received_events_url":"https://api.github.com/users/gawkermedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gawkermedia/amqp-client","description":"Simple fault-tolerant AMQP client written in Scala and based on Akka and the RabbitMQ java client","fork":true,"url":"https://api.github.com/repos/gawkermedia/amqp-client","forks_url":"https://api.github.com/repos/gawkermedia/amqp-client/forks","keys_url":"https://api.github.com/repos/gawkermedia/amqp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gawkermedia/amqp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gawkermedia/amqp-client/teams","hooks_url":"https://api.github.com/repos/gawkermedia/amqp-client/hooks","issue_events_url":"https://api.github.com/repos/gawkermedia/amqp-client/issues/events{/number}","events_url":"https://api.github.com/repos/gawkermedia/amqp-client/events","assignees_url":"https://api.github.com/repos/gawkermedia/amqp-client/assignees{/user}","branches_url":"https://api.github.com/repos/gawkermedia/amqp-client/branches{/branch}","tags_url":"https://api.github.com/repos/gawkermedia/amqp-client/tags","blobs_url":"https://api.github.com/repos/gawkermedia/amqp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gawkermedia/amqp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gawkermedia/amqp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/gawkermedia/amqp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gawkermedia/amqp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/gawkermedia/amqp-client/languages","stargazers_url":"https://api.github.com/repos/gawkermedia/amqp-client/stargazers","contributors_url":"https://api.github.com/repos/gawkermedia/amqp-client/contributors","subscribers_url":"https://api.github.com/repos/gawkermedia/amqp-client/subscribers","subscription_url":"https://api.github.com/repos/gawkermedia/amqp-client/subscription","commits_url":"https://api.github.com/repos/gawkermedia/amqp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/gawkermedia/amqp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/gawkermedia/amqp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/gawkermedia/amqp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/gawkermedia/amqp-client/contents/{+path}","compare_url":"https://api.github.com/repos/gawkermedia/amqp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gawkermedia/amqp-client/merges","archive_url":"https://api.github.com/repos/gawkermedia/amqp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gawkermedia/amqp-client/downloads","issues_url":"https://api.github.com/repos/gawkermedia/amqp-client/issues{/number}","pulls_url":"https://api.github.com/repos/gawkermedia/amqp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/gawkermedia/amqp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/gawkermedia/amqp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gawkermedia/amqp-client/labels{/name}","releases_url":"https://api.github.com/repos/gawkermedia/amqp-client/releases{/id}","created_at":"2015-03-16T16:35:48Z","updated_at":"2015-03-16T16:35:49Z","pushed_at":"2015-04-08T12:20:54Z","git_url":"git://github.com/gawkermedia/amqp-client.git","ssh_url":"git@github.com:gawkermedia/amqp-client.git","clone_url":"https://github.com/gawkermedia/amqp-client.git","svn_url":"https://github.com/gawkermedia/amqp-client","homepage":"","size":421,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"scala2.10_kinja"}},"base":{"label":"gawkermedia:scala2.10_kinja","ref":"scala2.10_kinja","sha":"d49f6e6f4cc64a467cd380e51b4a9691eef6489c","user":{"login":"gawkermedia","id":852924,"avatar_url":"https://avatars.githubusercontent.com/u/852924?v=3","gravatar_id":"","url":"https://api.github.com/users/gawkermedia","html_url":"https://github.com/gawkermedia","followers_url":"https://api.github.com/users/gawkermedia/followers","following_url":"https://api.github.com/users/gawkermedia/following{/other_user}","gists_url":"https://api.github.com/users/gawkermedia/gists{/gist_id}","starred_url":"https://api.github.com/users/gawkermedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gawkermedia/subscriptions","organizations_url":"https://api.github.com/users/gawkermedia/orgs","repos_url":"https://api.github.com/users/gawkermedia/repos","events_url":"https://api.github.com/users/gawkermedia/events{/privacy}","received_events_url":"https://api.github.com/users/gawkermedia/received_events","type":"Organization","site_admin":false},"repo":{"id":32338520,"name":"amqp-client","full_name":"gawkermedia/amqp-client","owner":{"login":"gawkermedia","id":852924,"avatar_url":"https://avatars.githubusercontent.com/u/852924?v=3","gravatar_id":"","url":"https://api.github.com/users/gawkermedia","html_url":"https://github.com/gawkermedia","followers_url":"https://api.github.com/users/gawkermedia/followers","following_url":"https://api.github.com/users/gawkermedia/following{/other_user}","gists_url":"https://api.github.com/users/gawkermedia/gists{/gist_id}","starred_url":"https://api.github.com/users/gawkermedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gawkermedia/subscriptions","organizations_url":"https://api.github.com/users/gawkermedia/orgs","repos_url":"https://api.github.com/users/gawkermedia/repos","events_url":"https://api.github.com/users/gawkermedia/events{/privacy}","received_events_url":"https://api.github.com/users/gawkermedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gawkermedia/amqp-client","description":"Simple fault-tolerant AMQP client written in Scala and based on Akka and the RabbitMQ java client","fork":true,"url":"https://api.github.com/repos/gawkermedia/amqp-client","forks_url":"https://api.github.com/repos/gawkermedia/amqp-client/forks","keys_url":"https://api.github.com/repos/gawkermedia/amqp-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gawkermedia/amqp-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gawkermedia/amqp-client/teams","hooks_url":"https://api.github.com/repos/gawkermedia/amqp-client/hooks","issue_events_url":"https://api.github.com/repos/gawkermedia/amqp-client/issues/events{/number}","events_url":"https://api.github.com/repos/gawkermedia/amqp-client/events","assignees_url":"https://api.github.com/repos/gawkermedia/amqp-client/assignees{/user}","branches_url":"https://api.github.com/repos/gawkermedia/amqp-client/branches{/branch}","tags_url":"https://api.github.com/repos/gawkermedia/amqp-client/tags","blobs_url":"https://api.github.com/repos/gawkermedia/amqp-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gawkermedia/amqp-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gawkermedia/amqp-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/gawkermedia/amqp-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gawkermedia/amqp-client/statuses/{sha}","languages_url":"https://api.github.com/repos/gawkermedia/amqp-client/languages","stargazers_url":"https://api.github.com/repos/gawkermedia/amqp-client/stargazers","contributors_url":"https://api.github.com/repos/gawkermedia/amqp-client/contributors","subscribers_url":"https://api.github.com/repos/gawkermedia/amqp-client/subscribers","subscription_url":"https://api.github.com/repos/gawkermedia/amqp-client/subscription","commits_url":"https://api.github.com/repos/gawkermedia/amqp-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/gawkermedia/amqp-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/gawkermedia/amqp-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/gawkermedia/amqp-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/gawkermedia/amqp-client/contents/{+path}","compare_url":"https://api.github.com/repos/gawkermedia/amqp-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gawkermedia/amqp-client/merges","archive_url":"https://api.github.com/repos/gawkermedia/amqp-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gawkermedia/amqp-client/downloads","issues_url":"https://api.github.com/repos/gawkermedia/amqp-client/issues{/number}","pulls_url":"https://api.github.com/repos/gawkermedia/amqp-client/pulls{/number}","milestones_url":"https://api.github.com/repos/gawkermedia/amqp-client/milestones{/number}","notifications_url":"https://api.github.com/repos/gawkermedia/amqp-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gawkermedia/amqp-client/labels{/name}","releases_url":"https://api.github.com/repos/gawkermedia/amqp-client/releases{/id}","created_at":"2015-03-16T16:35:48Z","updated_at":"2015-03-16T16:35:49Z","pushed_at":"2015-04-08T12:20:54Z","git_url":"git://github.com/gawkermedia/amqp-client.git","ssh_url":"git@github.com:gawkermedia/amqp-client.git","clone_url":"https://github.com/gawkermedia/amqp-client.git","svn_url":"https://github.com/gawkermedia/amqp-client","homepage":"","size":421,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"scala2.10_kinja"}},"_links":{"self":{"href":"https://api.github.com/repos/gawkermedia/amqp-client/pulls/1"},"html":{"href":"https://github.com/gawkermedia/amqp-client/pull/1"},"issue":{"href":"https://api.github.com/repos/gawkermedia/amqp-client/issues/1"},"comments":{"href":"https://api.github.com/repos/gawkermedia/amqp-client/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/gawkermedia/amqp-client/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/gawkermedia/amqp-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gawkermedia/amqp-client/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/gawkermedia/amqp-client/statuses/b6f979f4e45055a9c9d8bfa1ee641738a7966f04"}}}}