{"action":"opened","number":1252,"pull_request":{"url":"https://api.github.com/repos/drone/drone/pulls/1252","id":48532091,"html_url":"https://github.com/drone/drone/pull/1252","diff_url":"https://github.com/drone/drone/pull/1252.diff","patch_url":"https://github.com/drone/drone/pull/1252.patch","issue_url":"https://api.github.com/repos/drone/drone/issues/1252","number":1252,"state":"open","locked":false,"title":"RFC7239 : Standard header for SSL proxy forwarding","user":{"login":"dolanor","id":928722,"avatar_url":"https://avatars.githubusercontent.com/u/928722?v=3","gravatar_id":"","url":"https://api.github.com/users/dolanor","html_url":"https://github.com/dolanor","followers_url":"https://api.github.com/users/dolanor/followers","following_url":"https://api.github.com/users/dolanor/following{/other_user}","gists_url":"https://api.github.com/users/dolanor/gists{/gist_id}","starred_url":"https://api.github.com/users/dolanor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolanor/subscriptions","organizations_url":"https://api.github.com/users/dolanor/orgs","repos_url":"https://api.github.com/users/dolanor/repos","events_url":"https://api.github.com/users/dolanor/events{/privacy}","received_events_url":"https://api.github.com/users/dolanor/received_events","type":"User","site_admin":false},"body":"Done modifications to include RFC7239 in 0.4.0.\r\nCompared to my 0.3.0 branch, I added test and a more generic way of parsing the \"Forwarded\" header and getting the values.\r\nI also deleted the X-Real-IP code for getting the host, since the RFC7239 should handle it with the first `for=` options of the list. And it also has the `host=` options that could be used directly.\r\nBut for me, X-Host and X-Real-IP are different. One is for getting the original http request from the client before all the redirection. And X-Real-IP is the IP from the original client. Those are 2 totally opposite ends.\r\nBut all of that is based on what I learned on the web. And seriously, there are not so many documentation on all those non standard extensions except X-Forwarded-For and X-Forwarded-Proto. So maybe my assertions are wrong.","created_at":"2015-10-23T01:05:49Z","updated_at":"2015-10-23T01:05:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/drone/drone/pulls/1252/commits","review_comments_url":"https://api.github.com/repos/drone/drone/pulls/1252/comments","review_comment_url":"https://api.github.com/repos/drone/drone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drone/drone/issues/1252/comments","statuses_url":"https://api.github.com/repos/drone/drone/statuses/b57edcd8021ade6d22c40bddc1710cba70ea6a46","head":{"label":"dolanor:0.4.0-rfc7239","ref":"0.4.0-rfc7239","sha":"b57edcd8021ade6d22c40bddc1710cba70ea6a46","user":{"login":"dolanor","id":928722,"avatar_url":"https://avatars.githubusercontent.com/u/928722?v=3","gravatar_id":"","url":"https://api.github.com/users/dolanor","html_url":"https://github.com/dolanor","followers_url":"https://api.github.com/users/dolanor/followers","following_url":"https://api.github.com/users/dolanor/following{/other_user}","gists_url":"https://api.github.com/users/dolanor/gists{/gist_id}","starred_url":"https://api.github.com/users/dolanor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolanor/subscriptions","organizations_url":"https://api.github.com/users/dolanor/orgs","repos_url":"https://api.github.com/users/dolanor/repos","events_url":"https://api.github.com/users/dolanor/events{/privacy}","received_events_url":"https://api.github.com/users/dolanor/received_events","type":"User","site_admin":false},"repo":{"id":44598564,"name":"drone","full_name":"dolanor/drone","owner":{"login":"dolanor","id":928722,"avatar_url":"https://avatars.githubusercontent.com/u/928722?v=3","gravatar_id":"","url":"https://api.github.com/users/dolanor","html_url":"https://github.com/dolanor","followers_url":"https://api.github.com/users/dolanor/followers","following_url":"https://api.github.com/users/dolanor/following{/other_user}","gists_url":"https://api.github.com/users/dolanor/gists{/gist_id}","starred_url":"https://api.github.com/users/dolanor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolanor/subscriptions","organizations_url":"https://api.github.com/users/dolanor/orgs","repos_url":"https://api.github.com/users/dolanor/repos","events_url":"https://api.github.com/users/dolanor/events{/privacy}","received_events_url":"https://api.github.com/users/dolanor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dolanor/drone","description":"Drone is a Continuous Integration platform built on Docker, written in Go","fork":true,"url":"https://api.github.com/repos/dolanor/drone","forks_url":"https://api.github.com/repos/dolanor/drone/forks","keys_url":"https://api.github.com/repos/dolanor/drone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolanor/drone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolanor/drone/teams","hooks_url":"https://api.github.com/repos/dolanor/drone/hooks","issue_events_url":"https://api.github.com/repos/dolanor/drone/issues/events{/number}","events_url":"https://api.github.com/repos/dolanor/drone/events","assignees_url":"https://api.github.com/repos/dolanor/drone/assignees{/user}","branches_url":"https://api.github.com/repos/dolanor/drone/branches{/branch}","tags_url":"https://api.github.com/repos/dolanor/drone/tags","blobs_url":"https://api.github.com/repos/dolanor/drone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolanor/drone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolanor/drone/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolanor/drone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolanor/drone/statuses/{sha}","languages_url":"https://api.github.com/repos/dolanor/drone/languages","stargazers_url":"https://api.github.com/repos/dolanor/drone/stargazers","contributors_url":"https://api.github.com/repos/dolanor/drone/contributors","subscribers_url":"https://api.github.com/repos/dolanor/drone/subscribers","subscription_url":"https://api.github.com/repos/dolanor/drone/subscription","commits_url":"https://api.github.com/repos/dolanor/drone/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolanor/drone/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolanor/drone/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolanor/drone/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolanor/drone/contents/{+path}","compare_url":"https://api.github.com/repos/dolanor/drone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolanor/drone/merges","archive_url":"https://api.github.com/repos/dolanor/drone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolanor/drone/downloads","issues_url":"https://api.github.com/repos/dolanor/drone/issues{/number}","pulls_url":"https://api.github.com/repos/dolanor/drone/pulls{/number}","milestones_url":"https://api.github.com/repos/dolanor/drone/milestones{/number}","notifications_url":"https://api.github.com/repos/dolanor/drone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolanor/drone/labels{/name}","releases_url":"https://api.github.com/repos/dolanor/drone/releases{/id}","created_at":"2015-10-20T10:19:46Z","updated_at":"2015-10-20T10:19:49Z","pushed_at":"2015-10-23T00:40:37Z","git_url":"git://github.com/dolanor/drone.git","ssh_url":"git@github.com:dolanor/drone.git","clone_url":"https://github.com/dolanor/drone.git","svn_url":"https://github.com/dolanor/drone","homepage":"","size":18383,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"drone:0.4.0","ref":"0.4.0","sha":"6ed5ae4827607a97ffd528d83f44618362e5d4ef","user":{"login":"drone","id":2181346,"avatar_url":"https://avatars.githubusercontent.com/u/2181346?v=3","gravatar_id":"","url":"https://api.github.com/users/drone","html_url":"https://github.com/drone","followers_url":"https://api.github.com/users/drone/followers","following_url":"https://api.github.com/users/drone/following{/other_user}","gists_url":"https://api.github.com/users/drone/gists{/gist_id}","starred_url":"https://api.github.com/users/drone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drone/subscriptions","organizations_url":"https://api.github.com/users/drone/orgs","repos_url":"https://api.github.com/users/drone/repos","events_url":"https://api.github.com/users/drone/events{/privacy}","received_events_url":"https://api.github.com/users/drone/received_events","type":"Organization","site_admin":false},"repo":{"id":16607898,"name":"drone","full_name":"drone/drone","owner":{"login":"drone","id":2181346,"avatar_url":"https://avatars.githubusercontent.com/u/2181346?v=3","gravatar_id":"","url":"https://api.github.com/users/drone","html_url":"https://github.com/drone","followers_url":"https://api.github.com/users/drone/followers","following_url":"https://api.github.com/users/drone/following{/other_user}","gists_url":"https://api.github.com/users/drone/gists{/gist_id}","starred_url":"https://api.github.com/users/drone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drone/subscriptions","organizations_url":"https://api.github.com/users/drone/orgs","repos_url":"https://api.github.com/users/drone/repos","events_url":"https://api.github.com/users/drone/events{/privacy}","received_events_url":"https://api.github.com/users/drone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/drone/drone","description":"Drone is a Continuous Integration platform built on Docker, written in Go","fork":false,"url":"https://api.github.com/repos/drone/drone","forks_url":"https://api.github.com/repos/drone/drone/forks","keys_url":"https://api.github.com/repos/drone/drone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drone/drone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drone/drone/teams","hooks_url":"https://api.github.com/repos/drone/drone/hooks","issue_events_url":"https://api.github.com/repos/drone/drone/issues/events{/number}","events_url":"https://api.github.com/repos/drone/drone/events","assignees_url":"https://api.github.com/repos/drone/drone/assignees{/user}","branches_url":"https://api.github.com/repos/drone/drone/branches{/branch}","tags_url":"https://api.github.com/repos/drone/drone/tags","blobs_url":"https://api.github.com/repos/drone/drone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drone/drone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drone/drone/git/refs{/sha}","trees_url":"https://api.github.com/repos/drone/drone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drone/drone/statuses/{sha}","languages_url":"https://api.github.com/repos/drone/drone/languages","stargazers_url":"https://api.github.com/repos/drone/drone/stargazers","contributors_url":"https://api.github.com/repos/drone/drone/contributors","subscribers_url":"https://api.github.com/repos/drone/drone/subscribers","subscription_url":"https://api.github.com/repos/drone/drone/subscription","commits_url":"https://api.github.com/repos/drone/drone/commits{/sha}","git_commits_url":"https://api.github.com/repos/drone/drone/git/commits{/sha}","comments_url":"https://api.github.com/repos/drone/drone/comments{/number}","issue_comment_url":"https://api.github.com/repos/drone/drone/issues/comments{/number}","contents_url":"https://api.github.com/repos/drone/drone/contents/{+path}","compare_url":"https://api.github.com/repos/drone/drone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drone/drone/merges","archive_url":"https://api.github.com/repos/drone/drone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drone/drone/downloads","issues_url":"https://api.github.com/repos/drone/drone/issues{/number}","pulls_url":"https://api.github.com/repos/drone/drone/pulls{/number}","milestones_url":"https://api.github.com/repos/drone/drone/milestones{/number}","notifications_url":"https://api.github.com/repos/drone/drone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drone/drone/labels{/name}","releases_url":"https://api.github.com/repos/drone/drone/releases{/id}","created_at":"2014-02-07T07:54:44Z","updated_at":"2015-10-22T21:38:50Z","pushed_at":"2015-10-23T00:59:42Z","git_url":"git://github.com/drone/drone.git","ssh_url":"git@github.com:drone/drone.git","clone_url":"https://github.com/drone/drone.git","svn_url":"https://github.com/drone/drone","homepage":"","size":30598,"stargazers_count":5515,"watchers_count":5515,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":621,"mirror_url":null,"open_issues_count":150,"forks":621,"open_issues":150,"watchers":5515,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/drone/drone/pulls/1252"},"html":{"href":"https://github.com/drone/drone/pull/1252"},"issue":{"href":"https://api.github.com/repos/drone/drone/issues/1252"},"comments":{"href":"https://api.github.com/repos/drone/drone/issues/1252/comments"},"review_comments":{"href":"https://api.github.com/repos/drone/drone/pulls/1252/comments"},"review_comment":{"href":"https://api.github.com/repos/drone/drone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drone/drone/pulls/1252/commits"},"statuses":{"href":"https://api.github.com/repos/drone/drone/statuses/b57edcd8021ade6d22c40bddc1710cba70ea6a46"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":74,"deletions":17,"changed_files":2}}