{"action":"created","issue":{"url":"https://api.github.com/repos/orgsync/active_interaction/issues/310","labels_url":"https://api.github.com/repos/orgsync/active_interaction/issues/310/labels{/name}","comments_url":"https://api.github.com/repos/orgsync/active_interaction/issues/310/comments","events_url":"https://api.github.com/repos/orgsync/active_interaction/issues/310/events","html_url":"https://github.com/orgsync/active_interaction/pull/310","id":111646727,"number":310,"title":"Warn when redefining a filter","user":{"login":"tfausak","id":408753,"avatar_url":"https://avatars.githubusercontent.com/u/408753?v=3","gravatar_id":"","url":"https://api.github.com/users/tfausak","html_url":"https://github.com/tfausak","followers_url":"https://api.github.com/users/tfausak/followers","following_url":"https://api.github.com/users/tfausak/following{/other_user}","gists_url":"https://api.github.com/users/tfausak/gists{/gist_id}","starred_url":"https://api.github.com/users/tfausak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfausak/subscriptions","organizations_url":"https://api.github.com/users/tfausak/orgs","repos_url":"https://api.github.com/users/tfausak/repos","events_url":"https://api.github.com/users/tfausak/events{/privacy}","received_events_url":"https://api.github.com/users/tfausak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/orgsync/active_interaction/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"tfausak","id":408753,"avatar_url":"https://avatars.githubusercontent.com/u/408753?v=3","gravatar_id":"","url":"https://api.github.com/users/tfausak","html_url":"https://github.com/tfausak","followers_url":"https://api.github.com/users/tfausak/followers","following_url":"https://api.github.com/users/tfausak/following{/other_user}","gists_url":"https://api.github.com/users/tfausak/gists{/gist_id}","starred_url":"https://api.github.com/users/tfausak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfausak/subscriptions","organizations_url":"https://api.github.com/users/tfausak/orgs","repos_url":"https://api.github.com/users/tfausak/repos","events_url":"https://api.github.com/users/tfausak/events{/privacy}","received_events_url":"https://api.github.com/users/tfausak/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-10-15T15:47:12Z","updated_at":"2015-10-15T18:27:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/orgsync/active_interaction/pulls/310","html_url":"https://github.com/orgsync/active_interaction/pull/310","diff_url":"https://github.com/orgsync/active_interaction/pull/310.diff","patch_url":"https://github.com/orgsync/active_interaction/pull/310.patch"},"body":"This pull request makes it so that you get a warning when you redefine a filter. Issue #308 brought the need for this to my attention. \r\n\r\nHere is an example of the warning:\r\n\r\n``` rb\r\nclass Example < ActiveInteraction::Base\r\n  boolean :x, :x\r\nend\r\n# WARNING: Redefining Example#x filter!\r\n```"},"comment":{"url":"https://api.github.com/repos/orgsync/active_interaction/issues/comments/148480861","html_url":"https://github.com/orgsync/active_interaction/pull/310#issuecomment-148480861","issue_url":"https://api.github.com/repos/orgsync/active_interaction/issues/310","id":148480861,"user":{"login":"AaronLasseigne","id":297205,"avatar_url":"https://avatars.githubusercontent.com/u/297205?v=3","gravatar_id":"","url":"https://api.github.com/users/AaronLasseigne","html_url":"https://github.com/AaronLasseigne","followers_url":"https://api.github.com/users/AaronLasseigne/followers","following_url":"https://api.github.com/users/AaronLasseigne/following{/other_user}","gists_url":"https://api.github.com/users/AaronLasseigne/gists{/gist_id}","starred_url":"https://api.github.com/users/AaronLasseigne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AaronLasseigne/subscriptions","organizations_url":"https://api.github.com/users/AaronLasseigne/orgs","repos_url":"https://api.github.com/users/AaronLasseigne/repos","events_url":"https://api.github.com/users/AaronLasseigne/events{/privacy}","received_events_url":"https://api.github.com/users/AaronLasseigne/received_events","type":"User","site_admin":false},"created_at":"2015-10-15T18:27:34Z","updated_at":"2015-10-15T18:27:34Z","body":"Is there any case where you might intentionally redefine a filter? I can't really think of one. Maybe on some kind of conditional filter import? Should we just raise an error instead?\r\n\r\nAlso, I don't think it needs to be so excited (i.e. we can drop the \"!\")."}}