{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/client/issues/1592","labels_url":"https://api.github.com/repos/owncloud/client/issues/1592/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/client/issues/1592/comments","events_url":"https://api.github.com/repos/owncloud/client/issues/1592/events","html_url":"https://github.com/owncloud/client/issues/1592","id":29820013,"number":1592,"title":"Code signing Mac client fails","user":{"login":"scolebrook","id":6951720,"avatar_url":"https://avatars.githubusercontent.com/u/6951720?v=3","gravatar_id":"","url":"https://api.github.com/users/scolebrook","html_url":"https://github.com/scolebrook","followers_url":"https://api.github.com/users/scolebrook/followers","following_url":"https://api.github.com/users/scolebrook/following{/other_user}","gists_url":"https://api.github.com/users/scolebrook/gists{/gist_id}","starred_url":"https://api.github.com/users/scolebrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scolebrook/subscriptions","organizations_url":"https://api.github.com/users/scolebrook/orgs","repos_url":"https://api.github.com/users/scolebrook/repos","events_url":"https://api.github.com/users/scolebrook/events{/privacy}","received_events_url":"https://api.github.com/users/scolebrook/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/client/labels/Discussion","name":"Discussion","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2014-03-20T13:54:38Z","updated_at":"2015-04-15T06:01:00Z","closed_at":"2014-10-12T11:10:18Z","body":"Expected behaviour\r\nRunning the code signing script should at admin/osx/sign_dmg.sh should convertthe dmg created during the build process to a writable one, mount it, sign owncloud.app with the supplied identity, unmount and convert back to read only image.\r\n\r\nActual behaviour\r\nThe codesign command fails. Disk images all get made successfully but the app never gets signed.\r\n\r\nSteps to reproduce\r\n1. Build client for Mac.\r\n2. cd to build directory.\r\n3. ../mirall-1.5.3/admin/osx/sign_dmg.sh ownCloud-1.5.3.0.dmg <name of code signing identity in Keychain>\r\n\r\nClient configuration\r\nClient version: 1.5.3\r\n\r\nOperating system: OS X 10.9.2\r\n\r\nOutput:\r\n<path to owncloud.app>: bundle format unrecognized, invalid, or unsuitable\r\nIn subcomponent: <path to QtCore.framework>\r\n\r\n\r\nThe Qt* frameworks do not have Info.plist files copied during the build process so codesign doesn't recognize them as bundles in Mavericks. It appears that this is a change in the Mavericks version of codesign. Mavericks requires all frameworks in an app bundle to be signed, not just the app itself. Attempting the sign the frameworks individually results in the same error message.\r\n\r\nManually copying the Info.plist from /usr/local/cellar/qt/4.8.5/Frameworks/QtCore.framework/Contents to <path to finished owncloud.app>/Contents/Frameworks/QtCore.framework/Contents for example allows codesign to successfully sign the framework.\r\n\r\nThe fix would be altering the build scripts to copy Contents/Info.plist for each framework."},"comment":{"url":"https://api.github.com/repos/owncloud/client/issues/comments/93207301","html_url":"https://github.com/owncloud/client/issues/1592#issuecomment-93207301","issue_url":"https://api.github.com/repos/owncloud/client/issues/1592","id":93207301,"user":{"login":"abraithwaite","id":3791413,"avatar_url":"https://avatars.githubusercontent.com/u/3791413?v=3","gravatar_id":"","url":"https://api.github.com/users/abraithwaite","html_url":"https://github.com/abraithwaite","followers_url":"https://api.github.com/users/abraithwaite/followers","following_url":"https://api.github.com/users/abraithwaite/following{/other_user}","gists_url":"https://api.github.com/users/abraithwaite/gists{/gist_id}","starred_url":"https://api.github.com/users/abraithwaite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abraithwaite/subscriptions","organizations_url":"https://api.github.com/users/abraithwaite/orgs","repos_url":"https://api.github.com/users/abraithwaite/repos","events_url":"https://api.github.com/users/abraithwaite/events{/privacy}","received_events_url":"https://api.github.com/users/abraithwaite/received_events","type":"User","site_admin":false},"created_at":"2015-04-15T06:01:00Z","updated_at":"2015-04-15T06:01:00Z","body":"I was just going through my apps and noticed that owncloud was the only one which wasn't being codesigned.\r\n\r\nWhat's the status of signing the owncloud app for OSX?  According to the blog linked above, it should have been fixed in recent qt releases (if that's still the issue)."}}