{"action":"opened","number":164,"pull_request":{"url":"https://api.github.com/repos/zlsa/atc/pulls/164","id":44313087,"html_url":"https://github.com/zlsa/atc/pull/164","diff_url":"https://github.com/zlsa/atc/pull/164.diff","patch_url":"https://github.com/zlsa/atc/pull/164.patch","issue_url":"https://api.github.com/repos/zlsa/atc/issues/164","number":164,"state":"open","locked":false,"title":"Separate control radius from radar range and add departure destinations","user":{"login":"tedrek","id":386829,"avatar_url":"https://avatars.githubusercontent.com/u/386829?v=3","gravatar_id":"","url":"https://api.github.com/users/tedrek","html_url":"https://github.com/tedrek","followers_url":"https://api.github.com/users/tedrek/followers","following_url":"https://api.github.com/users/tedrek/following{/other_user}","gists_url":"https://api.github.com/users/tedrek/gists{/gist_id}","starred_url":"https://api.github.com/users/tedrek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedrek/subscriptions","organizations_url":"https://api.github.com/users/tedrek/orgs","repos_url":"https://api.github.com/users/tedrek/repos","events_url":"https://api.github.com/users/tedrek/events{/privacy}","received_events_url":"https://api.github.com/users/tedrek/received_events","type":"User","site_admin":false},"body":"This is a pull request for feedback.  There are further changes required before merge.\r\n\r\nTwo major changes:\r\n* Aircraft outside of airport.ctr_radius are not controllable - #134\r\n* Aircraft have departure destinations - #29\r\n\r\nI've tested this on KDBG only, all other airports will require some tuning before being playable.\r\n\r\nThe first change uses the center radius as the control zone, aircraft outside of the terminal area do not respond to commands and are displayed in a subdued manner.  Scoring for arrivals/departures occurs at the area boundary instead of the radar range.  To support this aircraft fly directly away from the airport upon leaving the area boundary.\r\nOne 'feature' which needs feedback here is the ability to order an aircraft to climb above the area ceiling to depart.  To use this clear an aircraft to 11,000 feet.\r\n\r\nThe second major change is adding aircraft departures, by default everything will depart due north.  The airport.json can specify different headings for departures.  A blue arc 10 degrees wide is shown at the area boundary to show where the aircraft must fly to score a valid departure.\r\nDeparture directions are included in this PR as a method for separating departures from arrivals outside of the terminal area.\r\n\r\nA logical further development will be to eventually extend departure specification to be like arrivals.  This would allow some airlines do depart in certain directions more than others for example.\r\n\r\nBefore merge, all airports need to be updated with departure directions and arrivals to be certain they won't conflict with either departures or other arrivals prior to reaching the terminal area.","created_at":"2015-09-07T00:38:04Z","updated_at":"2015-09-07T00:38:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63d66afce575422d85f403223e5f6825db11aaa1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zlsa/atc/pulls/164/commits","review_comments_url":"https://api.github.com/repos/zlsa/atc/pulls/164/comments","review_comment_url":"https://api.github.com/repos/zlsa/atc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zlsa/atc/issues/164/comments","statuses_url":"https://api.github.com/repos/zlsa/atc/statuses/237e7762ff9f815679490e5bd30e4fcc9e04ea10","head":{"label":"tedrek:t-departure-destinations","ref":"t-departure-destinations","sha":"237e7762ff9f815679490e5bd30e4fcc9e04ea10","user":{"login":"tedrek","id":386829,"avatar_url":"https://avatars.githubusercontent.com/u/386829?v=3","gravatar_id":"","url":"https://api.github.com/users/tedrek","html_url":"https://github.com/tedrek","followers_url":"https://api.github.com/users/tedrek/followers","following_url":"https://api.github.com/users/tedrek/following{/other_user}","gists_url":"https://api.github.com/users/tedrek/gists{/gist_id}","starred_url":"https://api.github.com/users/tedrek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedrek/subscriptions","organizations_url":"https://api.github.com/users/tedrek/orgs","repos_url":"https://api.github.com/users/tedrek/repos","events_url":"https://api.github.com/users/tedrek/events{/privacy}","received_events_url":"https://api.github.com/users/tedrek/received_events","type":"User","site_admin":false},"repo":{"id":30897934,"name":"atc","full_name":"tedrek/atc","owner":{"login":"tedrek","id":386829,"avatar_url":"https://avatars.githubusercontent.com/u/386829?v=3","gravatar_id":"","url":"https://api.github.com/users/tedrek","html_url":"https://github.com/tedrek","followers_url":"https://api.github.com/users/tedrek/followers","following_url":"https://api.github.com/users/tedrek/following{/other_user}","gists_url":"https://api.github.com/users/tedrek/gists{/gist_id}","starred_url":"https://api.github.com/users/tedrek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedrek/subscriptions","organizations_url":"https://api.github.com/users/tedrek/orgs","repos_url":"https://api.github.com/users/tedrek/repos","events_url":"https://api.github.com/users/tedrek/events{/privacy}","received_events_url":"https://api.github.com/users/tedrek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tedrek/atc","description":"","fork":true,"url":"https://api.github.com/repos/tedrek/atc","forks_url":"https://api.github.com/repos/tedrek/atc/forks","keys_url":"https://api.github.com/repos/tedrek/atc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tedrek/atc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tedrek/atc/teams","hooks_url":"https://api.github.com/repos/tedrek/atc/hooks","issue_events_url":"https://api.github.com/repos/tedrek/atc/issues/events{/number}","events_url":"https://api.github.com/repos/tedrek/atc/events","assignees_url":"https://api.github.com/repos/tedrek/atc/assignees{/user}","branches_url":"https://api.github.com/repos/tedrek/atc/branches{/branch}","tags_url":"https://api.github.com/repos/tedrek/atc/tags","blobs_url":"https://api.github.com/repos/tedrek/atc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tedrek/atc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tedrek/atc/git/refs{/sha}","trees_url":"https://api.github.com/repos/tedrek/atc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tedrek/atc/statuses/{sha}","languages_url":"https://api.github.com/repos/tedrek/atc/languages","stargazers_url":"https://api.github.com/repos/tedrek/atc/stargazers","contributors_url":"https://api.github.com/repos/tedrek/atc/contributors","subscribers_url":"https://api.github.com/repos/tedrek/atc/subscribers","subscription_url":"https://api.github.com/repos/tedrek/atc/subscription","commits_url":"https://api.github.com/repos/tedrek/atc/commits{/sha}","git_commits_url":"https://api.github.com/repos/tedrek/atc/git/commits{/sha}","comments_url":"https://api.github.com/repos/tedrek/atc/comments{/number}","issue_comment_url":"https://api.github.com/repos/tedrek/atc/issues/comments{/number}","contents_url":"https://api.github.com/repos/tedrek/atc/contents/{+path}","compare_url":"https://api.github.com/repos/tedrek/atc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tedrek/atc/merges","archive_url":"https://api.github.com/repos/tedrek/atc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tedrek/atc/downloads","issues_url":"https://api.github.com/repos/tedrek/atc/issues{/number}","pulls_url":"https://api.github.com/repos/tedrek/atc/pulls{/number}","milestones_url":"https://api.github.com/repos/tedrek/atc/milestones{/number}","notifications_url":"https://api.github.com/repos/tedrek/atc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tedrek/atc/labels{/name}","releases_url":"https://api.github.com/repos/tedrek/atc/releases{/id}","created_at":"2015-02-17T01:43:26Z","updated_at":"2015-02-17T01:43:26Z","pushed_at":"2015-09-07T00:18:28Z","git_url":"git://github.com/tedrek/atc.git","ssh_url":"git@github.com:tedrek/atc.git","clone_url":"https://github.com/tedrek/atc.git","svn_url":"https://github.com/tedrek/atc","homepage":"http://zlsa.github.io/atc","size":684,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zlsa:gh-pages","ref":"gh-pages","sha":"c1bf7cb3d106d8e468c626c6fa073f6f67cb258c","user":{"login":"zlsa","id":6366062,"avatar_url":"https://avatars.githubusercontent.com/u/6366062?v=3","gravatar_id":"","url":"https://api.github.com/users/zlsa","html_url":"https://github.com/zlsa","followers_url":"https://api.github.com/users/zlsa/followers","following_url":"https://api.github.com/users/zlsa/following{/other_user}","gists_url":"https://api.github.com/users/zlsa/gists{/gist_id}","starred_url":"https://api.github.com/users/zlsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zlsa/subscriptions","organizations_url":"https://api.github.com/users/zlsa/orgs","repos_url":"https://api.github.com/users/zlsa/repos","events_url":"https://api.github.com/users/zlsa/events{/privacy}","received_events_url":"https://api.github.com/users/zlsa/received_events","type":"User","site_admin":false},"repo":{"id":23041972,"name":"atc","full_name":"zlsa/atc","owner":{"login":"zlsa","id":6366062,"avatar_url":"https://avatars.githubusercontent.com/u/6366062?v=3","gravatar_id":"","url":"https://api.github.com/users/zlsa","html_url":"https://github.com/zlsa","followers_url":"https://api.github.com/users/zlsa/followers","following_url":"https://api.github.com/users/zlsa/following{/other_user}","gists_url":"https://api.github.com/users/zlsa/gists{/gist_id}","starred_url":"https://api.github.com/users/zlsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zlsa/subscriptions","organizations_url":"https://api.github.com/users/zlsa/orgs","repos_url":"https://api.github.com/users/zlsa/repos","events_url":"https://api.github.com/users/zlsa/events{/privacy}","received_events_url":"https://api.github.com/users/zlsa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zlsa/atc","description":"","fork":false,"url":"https://api.github.com/repos/zlsa/atc","forks_url":"https://api.github.com/repos/zlsa/atc/forks","keys_url":"https://api.github.com/repos/zlsa/atc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zlsa/atc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zlsa/atc/teams","hooks_url":"https://api.github.com/repos/zlsa/atc/hooks","issue_events_url":"https://api.github.com/repos/zlsa/atc/issues/events{/number}","events_url":"https://api.github.com/repos/zlsa/atc/events","assignees_url":"https://api.github.com/repos/zlsa/atc/assignees{/user}","branches_url":"https://api.github.com/repos/zlsa/atc/branches{/branch}","tags_url":"https://api.github.com/repos/zlsa/atc/tags","blobs_url":"https://api.github.com/repos/zlsa/atc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zlsa/atc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zlsa/atc/git/refs{/sha}","trees_url":"https://api.github.com/repos/zlsa/atc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zlsa/atc/statuses/{sha}","languages_url":"https://api.github.com/repos/zlsa/atc/languages","stargazers_url":"https://api.github.com/repos/zlsa/atc/stargazers","contributors_url":"https://api.github.com/repos/zlsa/atc/contributors","subscribers_url":"https://api.github.com/repos/zlsa/atc/subscribers","subscription_url":"https://api.github.com/repos/zlsa/atc/subscription","commits_url":"https://api.github.com/repos/zlsa/atc/commits{/sha}","git_commits_url":"https://api.github.com/repos/zlsa/atc/git/commits{/sha}","comments_url":"https://api.github.com/repos/zlsa/atc/comments{/number}","issue_comment_url":"https://api.github.com/repos/zlsa/atc/issues/comments{/number}","contents_url":"https://api.github.com/repos/zlsa/atc/contents/{+path}","compare_url":"https://api.github.com/repos/zlsa/atc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zlsa/atc/merges","archive_url":"https://api.github.com/repos/zlsa/atc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zlsa/atc/downloads","issues_url":"https://api.github.com/repos/zlsa/atc/issues{/number}","pulls_url":"https://api.github.com/repos/zlsa/atc/pulls{/number}","milestones_url":"https://api.github.com/repos/zlsa/atc/milestones{/number}","notifications_url":"https://api.github.com/repos/zlsa/atc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zlsa/atc/labels{/name}","releases_url":"https://api.github.com/repos/zlsa/atc/releases{/id}","created_at":"2014-08-17T14:13:31Z","updated_at":"2015-08-31T23:04:46Z","pushed_at":"2015-09-07T00:38:05Z","git_url":"git://github.com/zlsa/atc.git","ssh_url":"git@github.com:zlsa/atc.git","clone_url":"https://github.com/zlsa/atc.git","svn_url":"https://github.com/zlsa/atc","homepage":"http://zlsa.github.io/atc","size":1689,"stargazers_count":280,"watchers_count":280,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":59,"mirror_url":null,"open_issues_count":31,"forks":59,"open_issues":31,"watchers":280,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/zlsa/atc/pulls/164"},"html":{"href":"https://github.com/zlsa/atc/pull/164"},"issue":{"href":"https://api.github.com/repos/zlsa/atc/issues/164"},"comments":{"href":"https://api.github.com/repos/zlsa/atc/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/zlsa/atc/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/zlsa/atc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zlsa/atc/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/zlsa/atc/statuses/237e7762ff9f815679490e5bd30e4fcc9e04ea10"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":230,"deletions":64,"changed_files":7}}