{"action":"created","issue":{"url":"https://api.github.com/repos/mulesoft/api-console/issues/170","labels_url":"https://api.github.com/repos/mulesoft/api-console/issues/170/labels{/name}","comments_url":"https://api.github.com/repos/mulesoft/api-console/issues/170/comments","events_url":"https://api.github.com/repos/mulesoft/api-console/issues/170/events","html_url":"https://github.com/mulesoft/api-console/pull/170","id":103130939,"number":170,"title":"Fixed multiple minification issues - reserved keywords being used as properties and angularJS directives/controller dependencies being malformed after minification/munging/obfuscation","user":{"login":"ravikiranj","id":389491,"avatar_url":"https://avatars.githubusercontent.com/u/389491?v=3","gravatar_id":"","url":"https://api.github.com/users/ravikiranj","html_url":"https://github.com/ravikiranj","followers_url":"https://api.github.com/users/ravikiranj/followers","following_url":"https://api.github.com/users/ravikiranj/following{/other_user}","gists_url":"https://api.github.com/users/ravikiranj/gists{/gist_id}","starred_url":"https://api.github.com/users/ravikiranj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravikiranj/subscriptions","organizations_url":"https://api.github.com/users/ravikiranj/orgs","repos_url":"https://api.github.com/users/ravikiranj/repos","events_url":"https://api.github.com/users/ravikiranj/events{/privacy}","received_events_url":"https://api.github.com/users/ravikiranj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-25T22:29:59Z","updated_at":"2015-08-26T04:12:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mulesoft/api-console/pulls/170","html_url":"https://github.com/mulesoft/api-console/pull/170","diff_url":"https://github.com/mulesoft/api-console/pull/170.diff","patch_url":"https://github.com/mulesoft/api-console/pull/170.patch"},"body":"This pull request fixes 2 minification/obfuscation issues.\r\n* Fixes reserved keywords being used as properties by referring to them via strings\r\n* Fixes minification issues w.r.t RAML directives and controllers by providing an array of dependencies and function instead of just the function\r\n\r\nRAML Initializer - http://rkjanardhana.com/api-console-dist/\r\nRAML Console (preloaded) - http://rkjanardhana.com/api-console-dist/ramlconsoleapp.html\r\n\r\nSee Network tab and notice http://rkjanardhana.com/api-console-dist/scripts/api-console-minified-munged.js"},"comment":{"url":"https://api.github.com/repos/mulesoft/api-console/issues/comments/134823268","html_url":"https://github.com/mulesoft/api-console/pull/170#issuecomment-134823268","issue_url":"https://api.github.com/repos/mulesoft/api-console/issues/170","id":134823268,"user":{"login":"ravikiranj","id":389491,"avatar_url":"https://avatars.githubusercontent.com/u/389491?v=3","gravatar_id":"","url":"https://api.github.com/users/ravikiranj","html_url":"https://github.com/ravikiranj","followers_url":"https://api.github.com/users/ravikiranj/followers","following_url":"https://api.github.com/users/ravikiranj/following{/other_user}","gists_url":"https://api.github.com/users/ravikiranj/gists{/gist_id}","starred_url":"https://api.github.com/users/ravikiranj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravikiranj/subscriptions","organizations_url":"https://api.github.com/users/ravikiranj/orgs","repos_url":"https://api.github.com/users/ravikiranj/repos","events_url":"https://api.github.com/users/ravikiranj/events{/privacy}","received_events_url":"https://api.github.com/users/ravikiranj/received_events","type":"User","site_admin":false},"created_at":"2015-08-26T04:12:00Z","updated_at":"2015-08-26T04:12:00Z","body":"I ES3-fied `api-console-vendor.js` locally but since it included from external libs that was concatenated. Unfortunately, I cannot change our JS compressor for the project I'm working on, hence I'll have to deal with local fixes until https://github.com/yui/yuicompressor/issues/47 gets fixed :(\r\n\r\nThanks a bunch for all the help you've offered, the API docs console looks great :) !\r\n\r\nP.S: I also hit another issue with YUICompressor with this project, see http://davidwalsh.name/yui-compressor-media-query-error. I had to manually extract the media queries to a new file and patch that in using https://www.npmjs.com/package/media-query-extractor . YUICompressor has not been kind to me the last few days :( ! It might be worth calling these issues out somewhere (maybe README.md?) since other folks who try to minify api-console js/css using YUICompressor will encounter these."}}