{"action":"created","comment":{"url":"https://api.github.com/repos/chef/chef-server/pulls/comments/30812335","id":30812335,"diff_hunk":"@@ -31,7 +31,7 @@\n \n {erl_opts, [debug_info,\n             {parse_transform, lager_transform},\n-            warnings_as_errors}].\n+            warnings_as_errors]}.","path":"src/bookshelf/rebar.config","position":30,"original_position":30,"commit_id":"dd3314fd8952dd0e9f91bbf555b0c90c0839faa5","original_commit_id":"dd3314fd8952dd0e9f91bbf555b0c90c0839faa5","user":{"login":"stevendanna","id":852371,"avatar_url":"https://avatars.githubusercontent.com/u/852371?v=3","gravatar_id":"","url":"https://api.github.com/users/stevendanna","html_url":"https://github.com/stevendanna","followers_url":"https://api.github.com/users/stevendanna/followers","following_url":"https://api.github.com/users/stevendanna/following{/other_user}","gists_url":"https://api.github.com/users/stevendanna/gists{/gist_id}","starred_url":"https://api.github.com/users/stevendanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevendanna/subscriptions","organizations_url":"https://api.github.com/users/stevendanna/orgs","repos_url":"https://api.github.com/users/stevendanna/repos","events_url":"https://api.github.com/users/stevendanna/events{/privacy}","received_events_url":"https://api.github.com/users/stevendanna/received_events","type":"User","site_admin":false},"body":"My guess was that it wasn't but we didn't notice because rebar.config.lock gets used instead for nearly all builds.","created_at":"2015-05-21T15:16:02Z","updated_at":"2015-05-21T15:16:02Z","html_url":"https://github.com/chef/chef-server/pull/285#discussion_r30812335","pull_request_url":"https://api.github.com/repos/chef/chef-server/pulls/285","_links":{"self":{"href":"https://api.github.com/repos/chef/chef-server/pulls/comments/30812335"},"html":{"href":"https://github.com/chef/chef-server/pull/285#discussion_r30812335"},"pull_request":{"href":"https://api.github.com/repos/chef/chef-server/pulls/285"}}},"pull_request":{"url":"https://api.github.com/repos/chef/chef-server/pulls/285","id":35934504,"html_url":"https://github.com/chef/chef-server/pull/285","diff_url":"https://github.com/chef/chef-server/pull/285.diff","patch_url":"https://github.com/chef/chef-server/pull/285.patch","issue_url":"https://api.github.com/repos/chef/chef-server/issues/285","number":285,"state":"open","locked":false,"title":"Erlang 17.5 Compatibility","user":{"login":"joedevivo","id":55951,"avatar_url":"https://avatars.githubusercontent.com/u/55951?v=3","gravatar_id":"","url":"https://api.github.com/users/joedevivo","html_url":"https://github.com/joedevivo","followers_url":"https://api.github.com/users/joedevivo/followers","following_url":"https://api.github.com/users/joedevivo/following{/other_user}","gists_url":"https://api.github.com/users/joedevivo/gists{/gist_id}","starred_url":"https://api.github.com/users/joedevivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joedevivo/subscriptions","organizations_url":"https://api.github.com/users/joedevivo/orgs","repos_url":"https://api.github.com/users/joedevivo/repos","events_url":"https://api.github.com/users/joedevivo/events{/privacy}","received_events_url":"https://api.github.com/users/joedevivo/received_events","type":"User","site_admin":false},"body":"This PR allows all projects to build in erlang 17.5 except for `chef-mover`.\r\n\r\n`chef-mover` needs some attention to get that done, which it should be receiving shortly.\r\n\r\nSince that's the case, these changes were all made to be compatible with R16B03-1 as well, and omnibus continues to build it that way.","created_at":"2015-05-21T13:42:20Z","updated_at":"2015-05-21T15:16:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7126c341f254116051bb0a6b72b05eab9bc181a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef/chef-server/pulls/285/commits","review_comments_url":"https://api.github.com/repos/chef/chef-server/pulls/285/comments","review_comment_url":"https://api.github.com/repos/chef/chef-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef-server/issues/285/comments","statuses_url":"https://api.github.com/repos/chef/chef-server/statuses/dd3314fd8952dd0e9f91bbf555b0c90c0839faa5","head":{"label":"chef:jd/17","ref":"jd/17","sha":"dd3314fd8952dd0e9f91bbf555b0c90c0839faa5","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":24732433,"name":"chef-server","full_name":"chef/chef-server","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-server","description":"The Chef Server ","fork":false,"url":"https://api.github.com/repos/chef/chef-server","forks_url":"https://api.github.com/repos/chef/chef-server/forks","keys_url":"https://api.github.com/repos/chef/chef-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-server/teams","hooks_url":"https://api.github.com/repos/chef/chef-server/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-server/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-server/events","assignees_url":"https://api.github.com/repos/chef/chef-server/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-server/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-server/tags","blobs_url":"https://api.github.com/repos/chef/chef-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-server/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-server/languages","stargazers_url":"https://api.github.com/repos/chef/chef-server/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-server/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-server/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-server/subscription","commits_url":"https://api.github.com/repos/chef/chef-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-server/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-server/merges","archive_url":"https://api.github.com/repos/chef/chef-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-server/downloads","issues_url":"https://api.github.com/repos/chef/chef-server/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-server/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-server/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-server/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-server/releases{/id}","created_at":"2014-10-02T19:04:18Z","updated_at":"2015-05-19T14:10:15Z","pushed_at":"2015-05-21T14:42:42Z","git_url":"git://github.com/chef/chef-server.git","ssh_url":"git@github.com:chef/chef-server.git","clone_url":"https://github.com/chef/chef-server.git","svn_url":"https://github.com/chef/chef-server","homepage":"https://www.chef.io/chef/","size":13704,"stargazers_count":22,"watchers_count":22,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":165,"forks":9,"open_issues":165,"watchers":22,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"c78dbd86589f9bc994dfc0674313a6a3579aaf31","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":24732433,"name":"chef-server","full_name":"chef/chef-server","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-server","description":"The Chef Server ","fork":false,"url":"https://api.github.com/repos/chef/chef-server","forks_url":"https://api.github.com/repos/chef/chef-server/forks","keys_url":"https://api.github.com/repos/chef/chef-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-server/teams","hooks_url":"https://api.github.com/repos/chef/chef-server/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-server/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-server/events","assignees_url":"https://api.github.com/repos/chef/chef-server/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-server/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-server/tags","blobs_url":"https://api.github.com/repos/chef/chef-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-server/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-server/languages","stargazers_url":"https://api.github.com/repos/chef/chef-server/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-server/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-server/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-server/subscription","commits_url":"https://api.github.com/repos/chef/chef-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-server/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-server/merges","archive_url":"https://api.github.com/repos/chef/chef-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-server/downloads","issues_url":"https://api.github.com/repos/chef/chef-server/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-server/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-server/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-server/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-server/releases{/id}","created_at":"2014-10-02T19:04:18Z","updated_at":"2015-05-19T14:10:15Z","pushed_at":"2015-05-21T14:42:42Z","git_url":"git://github.com/chef/chef-server.git","ssh_url":"git@github.com:chef/chef-server.git","clone_url":"https://github.com/chef/chef-server.git","svn_url":"https://github.com/chef/chef-server","homepage":"https://www.chef.io/chef/","size":13704,"stargazers_count":22,"watchers_count":22,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":165,"forks":9,"open_issues":165,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef-server/pulls/285"},"html":{"href":"https://github.com/chef/chef-server/pull/285"},"issue":{"href":"https://api.github.com/repos/chef/chef-server/issues/285"},"comments":{"href":"https://api.github.com/repos/chef/chef-server/issues/285/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef-server/pulls/285/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef-server/pulls/285/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef-server/statuses/dd3314fd8952dd0e9f91bbf555b0c90c0839faa5"}}}}