{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/25894313","id":25894313,"diff_hunk":"@@ -87,8 +88,23 @@ func mutateEtcdOrDie(mutator func() error) {\n }\n \n func newEtcdClient() (client *etcd.Client) {\n-\t// TODO: take a flag for etcd server(s).\n-\tclient = etcd.NewClient([]string{\"http://127.0.0.1:4001\"})\n+\tmaxConnectRetries := 12\n+\tfor maxConnectRetries > 0 {\n+\t\tif _, _, err := tools.GetEtcdVersion(*etcd_server); err != nil {","path":"cluster/addons/dns/kube2sky/kube2sky.go","position":19,"original_position":19,"commit_id":"b3584ee3850bffdd0c05204d52892edb6010d4bc","original_commit_id":"b3584ee3850bffdd0c05204d52892edb6010d4bc","user":{"login":"fabioy","id":6294975,"avatar_url":"https://avatars.githubusercontent.com/u/6294975?v=3","gravatar_id":"","url":"https://api.github.com/users/fabioy","html_url":"https://github.com/fabioy","followers_url":"https://api.github.com/users/fabioy/followers","following_url":"https://api.github.com/users/fabioy/following{/other_user}","gists_url":"https://api.github.com/users/fabioy/gists{/gist_id}","starred_url":"https://api.github.com/users/fabioy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabioy/subscriptions","organizations_url":"https://api.github.com/users/fabioy/orgs","repos_url":"https://api.github.com/users/fabioy/repos","events_url":"https://api.github.com/users/fabioy/events{/privacy}","received_events_url":"https://api.github.com/users/fabioy/received_events","type":"User","site_admin":false},"body":"It's the tools package under \"pkg/tools\". It contained a number of nice etcd tools, which I modified and reused.","created_at":"2015-03-05T19:37:52Z","updated_at":"2015-03-05T19:37:52Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5097#discussion_r25894313","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5097","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/25894313"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5097#discussion_r25894313"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5097"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5097","id":30578142,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5097","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5097.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5097.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5097","number":5097,"state":"open","locked":false,"title":"Add etcd server check at startup to kube2sky (with retry loop).","user":{"login":"fabioy","id":6294975,"avatar_url":"https://avatars.githubusercontent.com/u/6294975?v=3","gravatar_id":"","url":"https://api.github.com/users/fabioy","html_url":"https://github.com/fabioy","followers_url":"https://api.github.com/users/fabioy/followers","following_url":"https://api.github.com/users/fabioy/following{/other_user}","gists_url":"https://api.github.com/users/fabioy/gists{/gist_id}","starred_url":"https://api.github.com/users/fabioy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabioy/subscriptions","organizations_url":"https://api.github.com/users/fabioy/orgs","repos_url":"https://api.github.com/users/fabioy/repos","events_url":"https://api.github.com/users/fabioy/events{/privacy}","received_events_url":"https://api.github.com/users/fabioy/received_events","type":"User","site_admin":false},"body":"Addresses an issue with etcd not having started when kube2sky comes up.","created_at":"2015-03-05T17:36:40Z","updated_at":"2015-03-05T19:37:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea515d23086cff7e6c94402d8a7e6d5980a8e7db","assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5097/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5097/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5097/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/b3584ee3850bffdd0c05204d52892edb6010d4bc","head":{"label":"fabioy:k2sky-fix","ref":"k2sky-fix","sha":"b3584ee3850bffdd0c05204d52892edb6010d4bc","user":{"login":"fabioy","id":6294975,"avatar_url":"https://avatars.githubusercontent.com/u/6294975?v=3","gravatar_id":"","url":"https://api.github.com/users/fabioy","html_url":"https://github.com/fabioy","followers_url":"https://api.github.com/users/fabioy/followers","following_url":"https://api.github.com/users/fabioy/following{/other_user}","gists_url":"https://api.github.com/users/fabioy/gists{/gist_id}","starred_url":"https://api.github.com/users/fabioy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabioy/subscriptions","organizations_url":"https://api.github.com/users/fabioy/orgs","repos_url":"https://api.github.com/users/fabioy/repos","events_url":"https://api.github.com/users/fabioy/events{/privacy}","received_events_url":"https://api.github.com/users/fabioy/received_events","type":"User","site_admin":false},"repo":{"id":30671784,"name":"kubernetes","full_name":"fabioy/kubernetes","owner":{"login":"fabioy","id":6294975,"avatar_url":"https://avatars.githubusercontent.com/u/6294975?v=3","gravatar_id":"","url":"https://api.github.com/users/fabioy","html_url":"https://github.com/fabioy","followers_url":"https://api.github.com/users/fabioy/followers","following_url":"https://api.github.com/users/fabioy/following{/other_user}","gists_url":"https://api.github.com/users/fabioy/gists{/gist_id}","starred_url":"https://api.github.com/users/fabioy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabioy/subscriptions","organizations_url":"https://api.github.com/users/fabioy/orgs","repos_url":"https://api.github.com/users/fabioy/repos","events_url":"https://api.github.com/users/fabioy/events{/privacy}","received_events_url":"https://api.github.com/users/fabioy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabioy/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/fabioy/kubernetes","forks_url":"https://api.github.com/repos/fabioy/kubernetes/forks","keys_url":"https://api.github.com/repos/fabioy/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabioy/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabioy/kubernetes/teams","hooks_url":"https://api.github.com/repos/fabioy/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/fabioy/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/fabioy/kubernetes/events","assignees_url":"https://api.github.com/repos/fabioy/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/fabioy/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/fabioy/kubernetes/tags","blobs_url":"https://api.github.com/repos/fabioy/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabioy/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabioy/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabioy/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabioy/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/fabioy/kubernetes/languages","stargazers_url":"https://api.github.com/repos/fabioy/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/fabioy/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/fabioy/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/fabioy/kubernetes/subscription","commits_url":"https://api.github.com/repos/fabioy/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabioy/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabioy/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabioy/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabioy/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/fabioy/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabioy/kubernetes/merges","archive_url":"https://api.github.com/repos/fabioy/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabioy/kubernetes/downloads","issues_url":"https://api.github.com/repos/fabioy/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/fabioy/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/fabioy/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/fabioy/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabioy/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/fabioy/kubernetes/releases{/id}","created_at":"2015-02-11T21:55:17Z","updated_at":"2015-03-05T00:07:23Z","pushed_at":"2015-03-05T18:34:14Z","git_url":"git://github.com/fabioy/kubernetes.git","ssh_url":"git@github.com:fabioy/kubernetes.git","clone_url":"https://github.com/fabioy/kubernetes.git","svn_url":"https://github.com/fabioy/kubernetes","homepage":"http://kubernetes.io","size":32594,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"9fcb48cab6da5dc2f00adfb93d79fa1307e6138e","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-03-05T19:17:49Z","pushed_at":"2015-03-05T19:15:12Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":92668,"stargazers_count":6454,"watchers_count":6454,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1150,"mirror_url":null,"open_issues_count":785,"forks":1150,"open_issues":785,"watchers":6454,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5097"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5097"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5097"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5097/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5097/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5097/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/b3584ee3850bffdd0c05204d52892edb6010d4bc"}}}}