{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/44258188","id":44258188,"diff_hunk":"@@ -79,8 +79,26 @@ func (lw *layerWriter) Finish(dgst digest.Digest) (distribution.Layer, error) {\n \n \t}\n \n-\tif err := lw.moveLayer(canonical); err != nil {\n-\t\t// TODO(stevvooe): Cleanup?\n+\t// On NFS filesystem file attributes are cached on client. File may\n+\t// not exist (os.Stat failes with NotExist) few seconds after the write\n+\t// has been completed.\n+\tfor retries := 0; ; retries++ {\n+\t\terr := lw.moveLayer(canonical)","path":"Godeps/_workspace/src/github.com/docker/distribution/registry/storage/layerwriter.go","position":10,"original_position":10,"commit_id":"61950d1cde54a5a042b2599a9be626d18e6d6ba1","original_commit_id":"c8be144bfcac9405f47ebaddcebeae0b37198b75","user":{"login":"miminar","id":1478803,"avatar_url":"https://avatars.githubusercontent.com/u/1478803?v=3","gravatar_id":"","url":"https://api.github.com/users/miminar","html_url":"https://github.com/miminar","followers_url":"https://api.github.com/users/miminar/followers","following_url":"https://api.github.com/users/miminar/following{/other_user}","gists_url":"https://api.github.com/users/miminar/gists{/gist_id}","starred_url":"https://api.github.com/users/miminar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miminar/subscriptions","organizations_url":"https://api.github.com/users/miminar/orgs","repos_url":"https://api.github.com/users/miminar/repos","events_url":"https://api.github.com/users/miminar/events{/privacy}","received_events_url":"https://api.github.com/users/miminar/received_events","type":"User","site_admin":false},"body":"I'd say no. There are too many layers below - various storage drivers, various filesystems. I think it would be safer to just retry an existence check of a source file. And issue `moveLayer` just once and fail on error.","created_at":"2015-11-09T10:11:07Z","updated_at":"2015-11-09T10:11:07Z","html_url":"https://github.com/openshift/origin/pull/5761#discussion_r44258188","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/5761","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/44258188"},"html":{"href":"https://github.com/openshift/origin/pull/5761#discussion_r44258188"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/5761"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/5761","id":49980207,"html_url":"https://github.com/openshift/origin/pull/5761","diff_url":"https://github.com/openshift/origin/pull/5761.diff","patch_url":"https://github.com/openshift/origin/pull/5761.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/5761","number":5761,"state":"open","locked":false,"title":"Fixed push to scaled registry with nfs","user":{"login":"ashcrow","id":22706,"avatar_url":"https://avatars.githubusercontent.com/u/22706?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false},"body":"Original PR: #5749\r\n\r\n```\r\nOn NFS it takes some time for filesystem changes to propagate to other\r\ninstances. Several operations need to be retried until successful.\r\n\r\nResolves rhbz#1277356\r\n```\r\n\r\nThis breaks out the backport to it's own commit and adds logging if the new retries pass their limits.","created_at":"2015-11-06T17:18:32Z","updated_at":"2015-11-09T10:11:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fae6fdbf1329f094589782a57a7038adf277c8b","assignee":null,"milestone":{"url":"https://api.github.com/repos/openshift/origin/milestones/5","html_url":"https://github.com/openshift/origin/milestones/1.1.0","labels_url":"https://api.github.com/repos/openshift/origin/milestones/5/labels","id":1119756,"number":5,"title":"1.1.0","description":"Corresponds to the 3.1.0 OSE release","creator":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":267,"state":"open","created_at":"2015-05-20T04:04:56Z","updated_at":"2015-11-08T20:48:34Z","due_on":"2015-11-14T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/openshift/origin/pulls/5761/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/5761/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/5761/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/61950d1cde54a5a042b2599a9be626d18e6d6ba1","head":{"label":"ashcrow:fixed-push-to-scaled-registry-with-nfs","ref":"fixed-push-to-scaled-registry-with-nfs","sha":"61950d1cde54a5a042b2599a9be626d18e6d6ba1","user":{"login":"ashcrow","id":22706,"avatar_url":"https://avatars.githubusercontent.com/u/22706?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false},"repo":{"id":45694223,"name":"origin","full_name":"ashcrow/origin","owner":{"login":"ashcrow","id":22706,"avatar_url":"https://avatars.githubusercontent.com/u/22706?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashcrow/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/ashcrow/origin","forks_url":"https://api.github.com/repos/ashcrow/origin/forks","keys_url":"https://api.github.com/repos/ashcrow/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashcrow/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashcrow/origin/teams","hooks_url":"https://api.github.com/repos/ashcrow/origin/hooks","issue_events_url":"https://api.github.com/repos/ashcrow/origin/issues/events{/number}","events_url":"https://api.github.com/repos/ashcrow/origin/events","assignees_url":"https://api.github.com/repos/ashcrow/origin/assignees{/user}","branches_url":"https://api.github.com/repos/ashcrow/origin/branches{/branch}","tags_url":"https://api.github.com/repos/ashcrow/origin/tags","blobs_url":"https://api.github.com/repos/ashcrow/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashcrow/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashcrow/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashcrow/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashcrow/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/ashcrow/origin/languages","stargazers_url":"https://api.github.com/repos/ashcrow/origin/stargazers","contributors_url":"https://api.github.com/repos/ashcrow/origin/contributors","subscribers_url":"https://api.github.com/repos/ashcrow/origin/subscribers","subscription_url":"https://api.github.com/repos/ashcrow/origin/subscription","commits_url":"https://api.github.com/repos/ashcrow/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashcrow/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashcrow/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashcrow/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashcrow/origin/contents/{+path}","compare_url":"https://api.github.com/repos/ashcrow/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashcrow/origin/merges","archive_url":"https://api.github.com/repos/ashcrow/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashcrow/origin/downloads","issues_url":"https://api.github.com/repos/ashcrow/origin/issues{/number}","pulls_url":"https://api.github.com/repos/ashcrow/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/ashcrow/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/ashcrow/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashcrow/origin/labels{/name}","releases_url":"https://api.github.com/repos/ashcrow/origin/releases{/id}","created_at":"2015-11-06T16:45:22Z","updated_at":"2015-11-06T16:45:54Z","pushed_at":"2015-11-06T20:57:50Z","git_url":"git://github.com/ashcrow/origin.git","ssh_url":"git@github.com:ashcrow/origin.git","clone_url":"https://github.com/ashcrow/origin.git","svn_url":"https://github.com/ashcrow/origin","homepage":"http://www.openshift.org","size":178411,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"6cb071c44928053b15bdba6513839d23932b34ff","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-11-08T11:33:56Z","pushed_at":"2015-11-08T00:38:30Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":299494,"stargazers_count":797,"watchers_count":797,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":491,"mirror_url":null,"open_issues_count":649,"forks":491,"open_issues":649,"watchers":797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/5761"},"html":{"href":"https://github.com/openshift/origin/pull/5761"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/5761"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/5761/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/5761/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/5761/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/61950d1cde54a5a042b2599a9be626d18e6d6ba1"}}}}