{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/35148645","id":35148645,"diff_hunk":"@@ -385,3 +385,48 @@ do need a fair way to deal with people who are making our community suck.\n \tappeals, we know that mistakes happen, and we'll work with you to come up with a\n \tfair solution if there has been a misunderstanding.\n \n+## Coding Style\n+\n+Unless explicitly stated, we follow all coding guidelines from the Go\n+community. While some of these standards may seem arbitrary, they somehow seem\n+to result in a solid, consistent codebase.\n+\n+It is possible that the code base does not currently comply with these\n+guidelines. We are not looking for a massive PR that fixes this, since that\n+goes against the spirit of the guidelines. All new contributions should make a\n+best effort to clean up and make the code base better than they left it.\n+Obviously, apply your best judgement. Remember, the goal here to make the code\n+base easier for people to navigate and understand. Always keep that in mind\n+when nudging others to comply.\n+\n+The rules:\n+\n+1. All code should be formatted with `gofmt -s`.\n+2. All code should pass the default levels of\n+   [`golint`](https://github.com/golang/lint).\n+3. All code should follow the guidelines covered at\n+   https://github.com/golang/go/wiki/CodeReviewComments.\n+4. Comment the code. Tell us the why, the history and the context.\n+5. Document _all_ declarations and methods, even private ones. Declare\n+   expectations, caveats and anything else that may be important. If a type\n+   gets exported, having the comments already there will ensure it's ready.\n+6. Variable name length should be proportional to it's context and no longer.\n+   noALongVariableNameLikeThisIsNotMoreClearWhenASimpleCommentWouldDo. In\n+   practice, short methods will have short variable names and globals will\n+   have longer names.\n+7. No underscores in package names. If you need a compound name, step back,\n+   and re-examine why you need a compound name. If you still think you need a\n+   compound name, lose the underscore.\n+8. No utils or helpers packages. If a function is not general enough to\n+   warrant it's own package, it has not been written generally enough to be a\n+   part of a util package. Just leave it unexported and well-documented.\n+9. All tests should run with `go test` and outside tooling should not be","path":"CONTRIBUTING.md","position":39,"original_position":39,"commit_id":"b1dc3003ea88b110db23a1b989d7dcab87d522aa","original_commit_id":"b1dc3003ea88b110db23a1b989d7dcab87d522aa","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"body":"Oh, I think it's useful information, but it might distract from the \"core\" information here (I think)","created_at":"2015-07-21T20:15:51Z","updated_at":"2015-07-21T20:15:51Z","html_url":"https://github.com/docker/docker/pull/14821#discussion_r35148645","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/14821","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/35148645"},"html":{"href":"https://github.com/docker/docker/pull/14821#discussion_r35148645"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/14821"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/14821","id":40491616,"html_url":"https://github.com/docker/docker/pull/14821","diff_url":"https://github.com/docker/docker/pull/14821.diff","patch_url":"https://github.com/docker/docker/pull/14821.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/14821","number":14821,"state":"open","locked":false,"title":"Adding Go coding style guidelines","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"body":"In the spirt of #14756, I've assembled some lightweight coding style guidelines. Let's keep controversy to a minimum.\r\n\r\ncc @icecrime @thaJeztah \r\n\r\nSigned-off-by: Stephen J Day <stephen.day@docker.com>","created_at":"2015-07-21T18:55:16Z","updated_at":"2015-07-21T20:15:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b387a766b60ff01578085874edf6d2e945046416","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/14821/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/14821/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/14821/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/b1dc3003ea88b110db23a1b989d7dcab87d522aa","head":{"label":"stevvooe:coding-style-guidelines","ref":"coding-style-guidelines","sha":"b1dc3003ea88b110db23a1b989d7dcab87d522aa","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"repo":{"id":27934158,"name":"docker","full_name":"stevvooe/docker","owner":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevvooe/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/stevvooe/docker","forks_url":"https://api.github.com/repos/stevvooe/docker/forks","keys_url":"https://api.github.com/repos/stevvooe/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevvooe/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevvooe/docker/teams","hooks_url":"https://api.github.com/repos/stevvooe/docker/hooks","issue_events_url":"https://api.github.com/repos/stevvooe/docker/issues/events{/number}","events_url":"https://api.github.com/repos/stevvooe/docker/events","assignees_url":"https://api.github.com/repos/stevvooe/docker/assignees{/user}","branches_url":"https://api.github.com/repos/stevvooe/docker/branches{/branch}","tags_url":"https://api.github.com/repos/stevvooe/docker/tags","blobs_url":"https://api.github.com/repos/stevvooe/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevvooe/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevvooe/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevvooe/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevvooe/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/stevvooe/docker/languages","stargazers_url":"https://api.github.com/repos/stevvooe/docker/stargazers","contributors_url":"https://api.github.com/repos/stevvooe/docker/contributors","subscribers_url":"https://api.github.com/repos/stevvooe/docker/subscribers","subscription_url":"https://api.github.com/repos/stevvooe/docker/subscription","commits_url":"https://api.github.com/repos/stevvooe/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevvooe/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevvooe/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevvooe/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevvooe/docker/contents/{+path}","compare_url":"https://api.github.com/repos/stevvooe/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevvooe/docker/merges","archive_url":"https://api.github.com/repos/stevvooe/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevvooe/docker/downloads","issues_url":"https://api.github.com/repos/stevvooe/docker/issues{/number}","pulls_url":"https://api.github.com/repos/stevvooe/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/stevvooe/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/stevvooe/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevvooe/docker/labels{/name}","releases_url":"https://api.github.com/repos/stevvooe/docker/releases{/id}","created_at":"2014-12-12T19:09:15Z","updated_at":"2015-05-19T17:04:15Z","pushed_at":"2015-07-21T18:54:00Z","git_url":"git://github.com/stevvooe/docker.git","ssh_url":"git@github.com:stevvooe/docker.git","clone_url":"https://github.com/stevvooe/docker.git","svn_url":"https://github.com/stevvooe/docker","homepage":"http://www.docker.com","size":48066,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"3ee15acaadc3f25c90ea2c4de2e5ab1a12d8e042","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-07-21T20:06:48Z","pushed_at":"2015-07-21T20:10:13Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":229204,"stargazers_count":23423,"watchers_count":23423,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5837,"mirror_url":null,"open_issues_count":1080,"forks":5837,"open_issues":1080,"watchers":23423,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/14821"},"html":{"href":"https://github.com/docker/docker/pull/14821"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/14821"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/14821/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/14821/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/14821/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/b1dc3003ea88b110db23a1b989d7dcab87d522aa"}}}}