{"push_id":851329681,"size":40,"distinct_size":17,"ref":"refs/heads/master","head":"a4a0efc534921b681d9f4f134471e8eee395c77e","before":"052611b0d1d65804cf4ee3602f71ccbb516530c5","commits":[{"sha":"3308e5ea2a729b15a8154c4c30b9ebb15ed002db","author":{"email":"9cb5491eb5770dd8e0bf77a8a0335abf5f0488c5@gmail.com","name":"Trevor Norris"},"message":"buffer: fix value check for writeUInt{B,L}E\n\nFixes: https://github.com/nodejs/node/issues/3497\nPR-URL: https://github.com/nodejs/node/pull/3500\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/3308e5ea2a729b15a8154c4c30b9ebb15ed002db"},{"sha":"437930c0cca8b53f5ba6f6d070e2006177585bb7","author":{"email":"b84950071fc99921a72f4fa56f6cad2496b3223c@gmail.com","name":"Sakthipriyan Vairamani"},"message":"http{s}: don't connect to localhost on invalid URL\n\nIf the URL passed to `http{s}.request` or `http{s}.get` is not properly\nparsable by `url.parse`, we fall back to use `localhost` and port 80.\nThis creates confusing error messages like in this question\nhttp://stackoverflow.com/q/32675907/1903116.\n\nThis patch throws an error message, if `url.parse` fails to parse the\nURL properly.\n\nPrevious Discussion: https://github.com/nodejs/node/pull/2966\nPR-URL: https://github.com/nodejs/node/pull/2967\n\nReviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>\nReviewed-By: Evan Lucas <evanlucas@me.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/437930c0cca8b53f5ba6f6d070e2006177585bb7"},{"sha":"29da8cf8d7ab8f66b9091ab22664067d4468461e","author":{"email":"dc852f7f42c586356f6be32b8780273088b3bded@gmail.com","name":"Michaël Zasso"},"message":"util: make inherits work with classes\n\nThe current implementation overwrites the prototype of the target\nconstructor. It is not allowed with ES2015 classes because the prototype\nproperty is read only. Use Object.setPrototypeOf instead.\n\nFixes: https://github.com/nodejs/node/issues/3452\nPR-URL: https://github.com/nodejs/node/pull/3455\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/29da8cf8d7ab8f66b9091ab22664067d4468461e"},{"sha":"53e64bb29e3b70cf23b345d02fac081de716ef3f","author":{"email":"59bd0a3ff43b32849b319e645d4798d8a5d1e889@bnoordhuis.nl","name":"Ben Noordhuis"},"message":"src: fix race condition in debug signal on exit\n\nBefore this commit, sending a SIGUSR1 at program exit could trigger a\nhard to reproduce race condition where `v8::Debug::DebugBreak(isolate)`\ngot called when the isolate was in the process of being torn down.\n\nA similar race condition is in theory possible when sending signals\nto two threads simultaneously but I haven't been able to reproduce\nthat myself (and I tried, oh how I tried.)\n\nThis commit fixes the race condition by turning `node_isolate` into\na `std::atomic` and using it as an ad hoc synchronization primitive\nin places where that is necessary.\n\nA bare minimum std::atomic polyfill is added for OS X because Apple\nwouldn't be Apple if things just worked out of the box.\n\nPR-URL: https://github.com/nodejs/node/pull/3528\nReviewed-By: Fedor Indutny <fedor@indutny.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/53e64bb29e3b70cf23b345d02fac081de716ef3f"},{"sha":"c339fa36f5493c2bd2e108463910122ef82843c4","author":{"email":"c129494552fc0581006cc992619c10f4bdb73bee@wizcorp.jp","name":"ronkorving"},"message":"fs: reduced duplicate code in fs.write()\n\nPR-URL: https://github.com/nodejs/node/pull/2947\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>\nReviewed-By: Trevor Norris <trev.norris@gmail.com>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/c339fa36f5493c2bd2e108463910122ef82843c4"},{"sha":"da21dba1a001eb85dbf720e142a1b94778e9a9f7","author":{"email":"28a7b6144c43947e3f532c033ff42c8a2ae08045@gmail.com","name":"Rich Trott"},"message":"lib: fix cluster handle leak\n\nIt is possible to cause a resource leak in SharedHandle. This commit\nfixes the leak.\n\nFixes: https://github.com/nodejs/node/issues/2510\nPR-URL: https://github.com/nodejs/node/pull/3510\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/da21dba1a001eb85dbf720e142a1b94778e9a9f7"},{"sha":"b0e7b362c2ffe91d785446f420629e52eb793508","author":{"email":"b84950071fc99921a72f4fa56f6cad2496b3223c@gmail.com","name":"Sakthipriyan Vairamani"},"message":"tools: enable prefer-const eslint rule\n\nDescription from: http://eslint.org/docs/rules/prefer-const.html\n\nIf a variable is never modified, using the `const` declaration is\nbetter. `const` declaration tells readers, \"this variable is never\nmodified,\" reducing cognitive load and improving maintainability.\n\nRefer: https://github.com/nodejs/node/issues/3118\nPR-URL: https://github.com/nodejs/node/pull/3152\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>\nReviewed-By: Roman Reiss <me@silverwind.io>\nReviewed-By: Michaël Zasso <mic.besace@gmail.com>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/b0e7b362c2ffe91d785446f420629e52eb793508"},{"sha":"aaf9b488e28cb904be2ceec032b3fb2dbe532d6d","author":{"email":"b84950071fc99921a72f4fa56f6cad2496b3223c@gmail.com","name":"Sakthipriyan Vairamani"},"message":"lib,test: update let to const where applicable\n\nAs per the `prefer-const` eslint rule, few instances of `let` have been\nidentified to be better with `const`. This patch updates all those\ninstances.\n\nRefer: https://github.com/nodejs/node/issues/3118\nPR-URL: https://github.com/nodejs/node/pull/3152\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>\nReviewed-By: Roman Reiss <me@silverwind.io>\nReviewed-By: Michaël Zasso <mic.besace@gmail.com>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/aaf9b488e28cb904be2ceec032b3fb2dbe532d6d"},{"sha":"32237041b84faa1ddd2caa43c47b8f75135a37f7","author":{"email":"e39d94bae70283f13d24c278e04952d6dad9384b@indutny.com","name":"Fedor Indutny"},"message":"deps: backport 8d6a228 from the v8's upstream\n\nOriginal commit message:\n\n    [heap] fix crash during the scavenge of ArrayBuffer\n    Scavenger should not attempt to visit ArrayBuffer's storage, it is a\n    user-supplied pointer that may have any alignment. Visiting it, may\n    result in a crash.\n\n    BUG=\n    R=jochen\n\n    Review URL: https://codereview.chromium.org/1406133003\n\n    Cr-Commit-Position: refs/heads/master@{#31611}\n\nPR-URL: https://github.com/nodejs/node/pull/3549\nReviewed-By: Trevor Norris <trev.norris@gmail.com>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/32237041b84faa1ddd2caa43c47b8f75135a37f7"},{"sha":"6cf19103b63f4c33eb2c33590bc533ffa5a3e7e1","author":{"email":"b84950071fc99921a72f4fa56f6cad2496b3223c@gmail.com","name":"Sakthipriyan Vairamani"},"message":"repl: handle comments properly\n\nAs it is, the comments are not handled properly in REPL. So, if the\ncomments have `'` or `\"`, then they are treated as incomplete string\nliterals and the error is thrown in REPL.\n\nThis patch refactors the existing logic and groups everything in a\nclass.\n\nFixes: https://github.com/nodejs/node/issues/3421\nPR-URL: https://github.com/nodejs/node/pull/3515\nReviewed-By: Brian White <mscdex@mscdex.net>\nReviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/6cf19103b63f4c33eb2c33590bc533ffa5a3e7e1"},{"sha":"5d5a4c4c18566a07f13a51b8b0adad15c3495d6b","author":{"email":"b84950071fc99921a72f4fa56f6cad2496b3223c@gmail.com","name":"Sakthipriyan Vairamani"},"message":"doc: createServer's key option can be an array\n\nThe `tls` module's `createServer` and `createSecureContext` accept\n`key` option and it can be an array of keys as well. This patch\nexplains the format of the entries in that array.\n\nCorresponding code:\nhttps://github.com/nodejs/node/blob/v4.1.1/lib/_tls_common.js#L73-L90\n\nPR-URL: https://github.com/nodejs/node/pull/3123\nReviewed-By: Roman Reiss <me@silverwind.io>\nReviewed-By: Fedor Indutny <fedor.indutny@gmail.com>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/5d5a4c4c18566a07f13a51b8b0adad15c3495d6b"},{"sha":"c9e682d587e3095667423cd7ada1afea7561ff3e","author":{"email":"eb0877843acc39f8ef6f7269937dee931c372d23@budeanu.com","name":"Stefan Budeanu"},"message":"test: use port number from env in tls socket test\n\nTests normally use common.PORT to allow the user to select which port\nnumber to listen on. Hardcoding the port number will cause parallel\ninstances of the test to fail.\n\nPR-URL: https://github.com/nodejs/node/pull/3557\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>\nReviewed-By: Fedor Indutny <fedor@indutny.com>\nReviewed-By: Johan Bergström <bugs@bergstroem.nu>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/c9e682d587e3095667423cd7ada1afea7561ff3e"},{"sha":"81f6b543d94d43fee9dc313e47a22199dd1ed5ba","author":{"email":"0aae46e22085b8114be801f98c6281c5fc13b487@google.com","name":"Ali Ijaz Sheikh"},"message":"deps: backport 010897c from V8 upstream\n\nThis is a reland of https://github.com/nodejs/node/pull/3165. The patch abates\nthe truncation of script filenames in the perf-event output produced by V8.\n\nV8 commits:\nOriginal: https://github.com/v8/v8/commit/03ef3cd004c2fd31ae7e48772f106df67b8c2feb\nReland: https://github.com/v8/v8/commit/010897c16adb46d3fe403eab525502a63e174b0c\n\nOriginal commit message:\n  improve perf_basic_prof filename reporting\n\n  The buffer used for appending filenames to the string printed to the\n  perf_basic_prof log was unnecessarily too small. Bump it up to be at least\n  kUtf8BufferSize.\n\n  Truncation of filenames makes it really hard to work with profiles gathered on\n  Node.js. Because of the way Node.js works, you can have node module dependencies\n  in deeply nested directories. The last thing you want when investigating a\n  performance problem is to have script names be truncated.\n\n  This patch is a stop-gap. Ideally, I want no truncation of the filename at all\n  and use a dynamically growing buffer. That would be a larger change, and I\n  wanted to have a quick fix available that can be back-ported to Node.js LTS\n  release.\n\n  R=yangguo@chromium.org,yurys@chromium.org\n  BUG=\n\n  Review URL: https://codereview.chromium.org/1388543002\n\nPR-URL: https://github.com/nodejs/node/pull/3520\nReviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/81f6b543d94d43fee9dc313e47a22199dd1ed5ba"},{"sha":"d394e9e6bb75dc6a15befb89f7cd0b30df51596f","author":{"email":"b0c9a348ea900a493402ad782bca66f04feea3f9@us.ibm.com","name":"Myles Borins"},"message":"doc: add LTS info to COLLABORATOR_GUIDE.md\n\nThere is currently no information in the Collaborators guide regarding\nLTS. This commit adds some basic copy explaining what LTS is, what is\nconsidered for LTS, and a simple way collaborators can help.\n\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Steven R. Loomis <srloomis@us.ibm.com>\nPR-URL: https://github.com/nodejs/node/pull/3442","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/d394e9e6bb75dc6a15befb89f7cd0b30df51596f"},{"sha":"26e47efbca9e3c2a334430aa3c17f1c2a499b75e","author":{"email":"28a7b6144c43947e3f532c033ff42c8a2ae08045@gmail.com","name":"Rich Trott"},"message":"test: split independent tests into separate files\n\nMove ENOENT related tests out of general fs.watch() test file and into\nits own file. This may help diagnose\nhttps://github.com/nodejs/node/issues/3541.\n\nPR-URL: https://github.com/nodejs/node/pull/3548\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Michaël Zasso <mic.besace@gmail.com>\nReviewed-By: Johan Bergström <bugs@bergstroem.nu>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/26e47efbca9e3c2a334430aa3c17f1c2a499b75e"},{"sha":"4139f2a820cf1045d247114fee02cb3136cc4d8c","author":{"email":"0bce4854cb6f5628ba2932be400290810cc7e243@ca.ibm.com","name":"Junliang Yan"},"message":"test: fix missing unistd.h on windows\n\nPR-URL: https://github.com/nodejs/node/pull/3532\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/4139f2a820cf1045d247114fee02cb3136cc4d8c"},{"sha":"9f967058e8eb3a49edc453eab22ce4c91d4f1ba7","author":{"email":"0bce4854cb6f5628ba2932be400290810cc7e243@ca.ibm.com","name":"Junliang Yan"},"message":"test: fix heap-profiler link error LNK1194 on win\n\nFix the following error message in windows using VS 2013:\n\n    LINK : fatal error LNK1194: cannot delay-load 'node.exe'\n    due to import of data symbol '\"__declspec(dllimport)\n    const v8::OutputStream::`vftable'\"\n    (__imp_??_7OutputStream@v8@@6B@)'; link without\n    /DELAYLOAD:node.exe\n\nPR-URL: https://github.com/nodejs/node/pull/3572\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/9f967058e8eb3a49edc453eab22ce4c91d4f1ba7"},{"sha":"cdcf00a0b9016982d1d20cce00003e397c302723","author":{"email":"28a7b6144c43947e3f532c033ff42c8a2ae08045@gmail.com","name":"Rich Trott"},"message":"lib,doc: return boolean from child.send()\n\nThe documentation indicates that child.send() returns a boolean but it\nhas returned undefinined at since v0.12.0. It now returns a boolean per\nthe (slightly updated) documentation.\n\nPR-URL: https://github.com/nodejs/node/pull/3516\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/cdcf00a0b9016982d1d20cce00003e397c302723"},{"sha":"6b0c906e6badbba64611feb766d57b233b64e5f9","author":{"email":"b0c9a348ea900a493402ad782bca66f04feea3f9@us.ibm.com","name":"Myles Borins"},"message":"tls: remove util and calls to util.format\n\nCurrently util.format is being used for string templating in tls.\nBy replacing all of the instances of util.format with backtick\nstring we can remove the need to require util in tls all together.\n\nPR-URL: https://github.com/nodejs/node/pull/3456\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Fedor Indutny <fedor@indutny.com>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/6b0c906e6badbba64611feb766d57b233b64e5f9"},{"sha":"57bce60da33b26d8e782c92fcd56f7af6ada8c4d","author":{"email":"59bd0a3ff43b32849b319e645d4798d8a5d1e889@bnoordhuis.nl","name":"Ben Noordhuis"},"message":"child_process: don't fork bomb ourselves from -e\n\nRemove the `-e` argument from process.execArgv in child_process.fork()\nto keep `node -e 'require(\"child_process\").fork(\"empty.js\")'` from\nspawning itself recursively.\n\nFixes: https://github.com/nodejs/node/issues/3574\nPR-URL: https://github.com/nodejs/node/pull/3575\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Rich Trott <rtrott@gmail.com>","distinct":false,"url":"https://api.github.com/repos/TheAlphaNerd/node/commits/57bce60da33b26d8e782c92fcd56f7af6ada8c4d"}]}