{"action":"opened","number":137,"pull_request":{"url":"https://api.github.com/repos/twitter/cassovary/pulls/137","id":28195712,"html_url":"https://github.com/twitter/cassovary/pull/137","diff_url":"https://github.com/twitter/cassovary/pull/137.diff","patch_url":"https://github.com/twitter/cassovary/pull/137.patch","issue_url":"https://api.github.com/repos/twitter/cassovary/issues/137","number":137,"state":"open","locked":false,"title":"Remove the unnecessary \"() =>\" in `def iteratorSeq` ","user":{"login":"AnishShah","id":3175743,"avatar_url":"https://avatars.githubusercontent.com/u/3175743?v=3","gravatar_id":"","url":"https://api.github.com/users/AnishShah","html_url":"https://github.com/AnishShah","followers_url":"https://api.github.com/users/AnishShah/followers","following_url":"https://api.github.com/users/AnishShah/following{/other_user}","gists_url":"https://api.github.com/users/AnishShah/gists{/gist_id}","starred_url":"https://api.github.com/users/AnishShah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnishShah/subscriptions","organizations_url":"https://api.github.com/users/AnishShah/orgs","repos_url":"https://api.github.com/users/AnishShah/repos","events_url":"https://api.github.com/users/AnishShah/events{/privacy}","received_events_url":"https://api.github.com/users/AnishShah/received_events","type":"User","site_admin":false},"body":"I made an abstract class as @szymonm said.\r\n\r\n```\r\nabstract class NodeStream extends Iterable[NodeIdEdgesMaxId] with Closeable {..}\r\n```\r\nThen, I used it in AdjacencyListGraphReader.scala & ListOfEdgesGraphReader.scala.\r\n\r\nI implemened the `close()` method to close the file.\r\n\r\nIs this correct? I haven't removed \"() => \" in `def iteratorSeq`.  I will do it after reviews on this.","created_at":"2015-01-28T14:08:53Z","updated_at":"2015-01-28T14:08:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/cassovary/pulls/137/commits","review_comments_url":"https://api.github.com/repos/twitter/cassovary/pulls/137/comments","review_comment_url":"https://api.github.com/repos/twitter/cassovary/pulls/comments/{number}","comments_url":"https://api.github.com/repos/twitter/cassovary/issues/137/comments","statuses_url":"https://api.github.com/repos/twitter/cassovary/statuses/ec227dba702b9f139dc5565dd5ca905c67f86887","head":{"label":"AnishShah:issue136","ref":"issue136","sha":"ec227dba702b9f139dc5565dd5ca905c67f86887","user":{"login":"AnishShah","id":3175743,"avatar_url":"https://avatars.githubusercontent.com/u/3175743?v=3","gravatar_id":"","url":"https://api.github.com/users/AnishShah","html_url":"https://github.com/AnishShah","followers_url":"https://api.github.com/users/AnishShah/followers","following_url":"https://api.github.com/users/AnishShah/following{/other_user}","gists_url":"https://api.github.com/users/AnishShah/gists{/gist_id}","starred_url":"https://api.github.com/users/AnishShah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnishShah/subscriptions","organizations_url":"https://api.github.com/users/AnishShah/orgs","repos_url":"https://api.github.com/users/AnishShah/repos","events_url":"https://api.github.com/users/AnishShah/events{/privacy}","received_events_url":"https://api.github.com/users/AnishShah/received_events","type":"User","site_admin":false},"repo":{"id":28858810,"name":"cassovary","full_name":"AnishShah/cassovary","owner":{"login":"AnishShah","id":3175743,"avatar_url":"https://avatars.githubusercontent.com/u/3175743?v=3","gravatar_id":"","url":"https://api.github.com/users/AnishShah","html_url":"https://github.com/AnishShah","followers_url":"https://api.github.com/users/AnishShah/followers","following_url":"https://api.github.com/users/AnishShah/following{/other_user}","gists_url":"https://api.github.com/users/AnishShah/gists{/gist_id}","starred_url":"https://api.github.com/users/AnishShah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnishShah/subscriptions","organizations_url":"https://api.github.com/users/AnishShah/orgs","repos_url":"https://api.github.com/users/AnishShah/repos","events_url":"https://api.github.com/users/AnishShah/events{/privacy}","received_events_url":"https://api.github.com/users/AnishShah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AnishShah/cassovary","description":"Cassovary is a simple big graph processing library for the JVM","fork":true,"url":"https://api.github.com/repos/AnishShah/cassovary","forks_url":"https://api.github.com/repos/AnishShah/cassovary/forks","keys_url":"https://api.github.com/repos/AnishShah/cassovary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnishShah/cassovary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnishShah/cassovary/teams","hooks_url":"https://api.github.com/repos/AnishShah/cassovary/hooks","issue_events_url":"https://api.github.com/repos/AnishShah/cassovary/issues/events{/number}","events_url":"https://api.github.com/repos/AnishShah/cassovary/events","assignees_url":"https://api.github.com/repos/AnishShah/cassovary/assignees{/user}","branches_url":"https://api.github.com/repos/AnishShah/cassovary/branches{/branch}","tags_url":"https://api.github.com/repos/AnishShah/cassovary/tags","blobs_url":"https://api.github.com/repos/AnishShah/cassovary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnishShah/cassovary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnishShah/cassovary/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnishShah/cassovary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnishShah/cassovary/statuses/{sha}","languages_url":"https://api.github.com/repos/AnishShah/cassovary/languages","stargazers_url":"https://api.github.com/repos/AnishShah/cassovary/stargazers","contributors_url":"https://api.github.com/repos/AnishShah/cassovary/contributors","subscribers_url":"https://api.github.com/repos/AnishShah/cassovary/subscribers","subscription_url":"https://api.github.com/repos/AnishShah/cassovary/subscription","commits_url":"https://api.github.com/repos/AnishShah/cassovary/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnishShah/cassovary/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnishShah/cassovary/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnishShah/cassovary/issues/comments/{number}","contents_url":"https://api.github.com/repos/AnishShah/cassovary/contents/{+path}","compare_url":"https://api.github.com/repos/AnishShah/cassovary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnishShah/cassovary/merges","archive_url":"https://api.github.com/repos/AnishShah/cassovary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnishShah/cassovary/downloads","issues_url":"https://api.github.com/repos/AnishShah/cassovary/issues{/number}","pulls_url":"https://api.github.com/repos/AnishShah/cassovary/pulls{/number}","milestones_url":"https://api.github.com/repos/AnishShah/cassovary/milestones{/number}","notifications_url":"https://api.github.com/repos/AnishShah/cassovary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnishShah/cassovary/labels{/name}","releases_url":"https://api.github.com/repos/AnishShah/cassovary/releases{/id}","created_at":"2015-01-06T10:43:30Z","updated_at":"2015-01-28T07:20:50Z","pushed_at":"2015-01-28T12:58:37Z","git_url":"git://github.com/AnishShah/cassovary.git","ssh_url":"git@github.com:AnishShah/cassovary.git","clone_url":"https://github.com/AnishShah/cassovary.git","svn_url":"https://github.com/AnishShah/cassovary","homepage":"http://twitter.com/cassovary","size":2757,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"004f2ac8fbbd014c8627fd1a7ff77b1338af40cc","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":3509388,"name":"cassovary","full_name":"twitter/cassovary","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/cassovary","description":"Cassovary is a simple big graph processing library for the JVM","fork":false,"url":"https://api.github.com/repos/twitter/cassovary","forks_url":"https://api.github.com/repos/twitter/cassovary/forks","keys_url":"https://api.github.com/repos/twitter/cassovary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/cassovary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/cassovary/teams","hooks_url":"https://api.github.com/repos/twitter/cassovary/hooks","issue_events_url":"https://api.github.com/repos/twitter/cassovary/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/cassovary/events","assignees_url":"https://api.github.com/repos/twitter/cassovary/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/cassovary/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/cassovary/tags","blobs_url":"https://api.github.com/repos/twitter/cassovary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/cassovary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/cassovary/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/cassovary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/cassovary/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/cassovary/languages","stargazers_url":"https://api.github.com/repos/twitter/cassovary/stargazers","contributors_url":"https://api.github.com/repos/twitter/cassovary/contributors","subscribers_url":"https://api.github.com/repos/twitter/cassovary/subscribers","subscription_url":"https://api.github.com/repos/twitter/cassovary/subscription","commits_url":"https://api.github.com/repos/twitter/cassovary/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/cassovary/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/cassovary/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/cassovary/issues/comments/{number}","contents_url":"https://api.github.com/repos/twitter/cassovary/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/cassovary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/cassovary/merges","archive_url":"https://api.github.com/repos/twitter/cassovary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/cassovary/downloads","issues_url":"https://api.github.com/repos/twitter/cassovary/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/cassovary/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/cassovary/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/cassovary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/cassovary/labels{/name}","releases_url":"https://api.github.com/repos/twitter/cassovary/releases{/id}","created_at":"2012-02-21T23:22:30Z","updated_at":"2015-01-28T07:26:55Z","pushed_at":"2015-01-26T18:57:08Z","git_url":"git://github.com/twitter/cassovary.git","ssh_url":"git@github.com:twitter/cassovary.git","clone_url":"https://github.com/twitter/cassovary.git","svn_url":"https://github.com/twitter/cassovary","homepage":"http://twitter.com/cassovary","size":4163,"stargazers_count":679,"watchers_count":679,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":14,"forks":85,"open_issues":14,"watchers":679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/cassovary/pulls/137"},"html":{"href":"https://github.com/twitter/cassovary/pull/137"},"issue":{"href":"https://api.github.com/repos/twitter/cassovary/issues/137"},"comments":{"href":"https://api.github.com/repos/twitter/cassovary/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/cassovary/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/cassovary/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/twitter/cassovary/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/cassovary/statuses/ec227dba702b9f139dc5565dd5ca905c67f86887"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":66,"deletions":31,"changed_files":3}}