{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/26755599","id":26755599,"diff_hunk":"@@ -35,7 +34,7 @@ echo $$ > $RUN_THOR_PID_NAME\n export SENTINEL=\"thor.sentinel\"\n while [ 1 ]; do\n     # update slaves file in case state of environment has been altered since last run\n-    daliadmin $DALISERVER dfsgroup ${groupName} slaves\n+    daliadmin server=$DALISERVER dfsgroup ${groupName} slaves","path":"initfiles/componentfiles/thor/run_thor","position":15,"original_position":15,"commit_id":"c9c6446bb8a94360f131ae67f217bd591122f7e5","original_commit_id":"c9c6446bb8a94360f131ae67f217bd591122f7e5","user":{"login":"Michael-Gardner","id":7481082,"avatar_url":"https://avatars.githubusercontent.com/u/7481082?v=3","gravatar_id":"","url":"https://api.github.com/users/Michael-Gardner","html_url":"https://github.com/Michael-Gardner","followers_url":"https://api.github.com/users/Michael-Gardner/followers","following_url":"https://api.github.com/users/Michael-Gardner/following{/other_user}","gists_url":"https://api.github.com/users/Michael-Gardner/gists{/gist_id}","starred_url":"https://api.github.com/users/Michael-Gardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michael-Gardner/subscriptions","organizations_url":"https://api.github.com/users/Michael-Gardner/orgs","repos_url":"https://api.github.com/users/Michael-Gardner/repos","events_url":"https://api.github.com/users/Michael-Gardner/events{/privacy}","received_events_url":"https://api.github.com/users/Michael-Gardner/received_events","type":"User","site_admin":false},"body":"This change was made because I've been researching using dns instead of environments defined by ip's.  If we're using ip's then it works without using server=.  If we instead use a domain name, daliadmin will parse the domain name as though it was a command instead of an address.  server= just makes it more robust so in the future we can use either.  It's sort of a side issue that I've been noticing when playing around, so I took the chance to make the change here.","created_at":"2015-03-19T13:53:40Z","updated_at":"2015-03-19T13:53:40Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7130#discussion_r26755599","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7130","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/26755599"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7130#discussion_r26755599"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7130"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7130","id":31437041,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7130","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7130.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7130.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7130","number":7130,"state":"open","locked":false,"title":"HPCC-13230 Added dfsgroup check against environment.xml","user":{"login":"Michael-Gardner","id":7481082,"avatar_url":"https://avatars.githubusercontent.com/u/7481082?v=3","gravatar_id":"","url":"https://api.github.com/users/Michael-Gardner","html_url":"https://github.com/Michael-Gardner","followers_url":"https://api.github.com/users/Michael-Gardner/followers","following_url":"https://api.github.com/users/Michael-Gardner/following{/other_user}","gists_url":"https://api.github.com/users/Michael-Gardner/gists{/gist_id}","starred_url":"https://api.github.com/users/Michael-Gardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michael-Gardner/subscriptions","organizations_url":"https://api.github.com/users/Michael-Gardner/orgs","repos_url":"https://api.github.com/users/Michael-Gardner/repos","events_url":"https://api.github.com/users/Michael-Gardner/events{/privacy}","received_events_url":"https://api.github.com/users/Michael-Gardner/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Michael Gardner <Michael.Gardner@lexisnexis.com>","created_at":"2015-03-18T15:01:37Z","updated_at":"2015-03-19T13:53:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bda8f05ed4e07cd17eb617d46b5c1cd37456891","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7130/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7130/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7130/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/c9c6446bb8a94360f131ae67f217bd591122f7e5","head":{"label":"Michael-Gardner:HPCC-13230","ref":"HPCC-13230","sha":"c9c6446bb8a94360f131ae67f217bd591122f7e5","user":{"login":"Michael-Gardner","id":7481082,"avatar_url":"https://avatars.githubusercontent.com/u/7481082?v=3","gravatar_id":"","url":"https://api.github.com/users/Michael-Gardner","html_url":"https://github.com/Michael-Gardner","followers_url":"https://api.github.com/users/Michael-Gardner/followers","following_url":"https://api.github.com/users/Michael-Gardner/following{/other_user}","gists_url":"https://api.github.com/users/Michael-Gardner/gists{/gist_id}","starred_url":"https://api.github.com/users/Michael-Gardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michael-Gardner/subscriptions","organizations_url":"https://api.github.com/users/Michael-Gardner/orgs","repos_url":"https://api.github.com/users/Michael-Gardner/repos","events_url":"https://api.github.com/users/Michael-Gardner/events{/privacy}","received_events_url":"https://api.github.com/users/Michael-Gardner/received_events","type":"User","site_admin":false},"repo":{"id":24113512,"name":"HPCC-Platform","full_name":"Michael-Gardner/HPCC-Platform","owner":{"login":"Michael-Gardner","id":7481082,"avatar_url":"https://avatars.githubusercontent.com/u/7481082?v=3","gravatar_id":"","url":"https://api.github.com/users/Michael-Gardner","html_url":"https://github.com/Michael-Gardner","followers_url":"https://api.github.com/users/Michael-Gardner/followers","following_url":"https://api.github.com/users/Michael-Gardner/following{/other_user}","gists_url":"https://api.github.com/users/Michael-Gardner/gists{/gist_id}","starred_url":"https://api.github.com/users/Michael-Gardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michael-Gardner/subscriptions","organizations_url":"https://api.github.com/users/Michael-Gardner/orgs","repos_url":"https://api.github.com/users/Michael-Gardner/repos","events_url":"https://api.github.com/users/Michael-Gardner/events{/privacy}","received_events_url":"https://api.github.com/users/Michael-Gardner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Michael-Gardner/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":true,"url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform","forks_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/releases{/id}","created_at":"2014-09-16T19:06:46Z","updated_at":"2015-03-10T17:33:41Z","pushed_at":"2015-03-18T20:41:34Z","git_url":"git://github.com/Michael-Gardner/HPCC-Platform.git","ssh_url":"git@github.com:Michael-Gardner/HPCC-Platform.git","clone_url":"https://github.com/Michael-Gardner/HPCC-Platform.git","svn_url":"https://github.com/Michael-Gardner/HPCC-Platform","homepage":"track.hpccsystems.com","size":141179,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"candidate-5.2.0"}},"base":{"label":"hpcc-systems:candidate-5.4.0","ref":"candidate-5.4.0","sha":"731796749ef5e0127d2534f85ef31ec39396d7f3","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","created_at":"2011-07-11T14:29:51Z","updated_at":"2015-03-16T17:01:45Z","pushed_at":"2015-03-18T13:36:28Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"track.hpccsystems.com","size":273526,"stargazers_count":244,"watchers_count":244,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":100,"mirror_url":null,"open_issues_count":424,"forks":100,"open_issues":424,"watchers":244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7130"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7130"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7130"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7130/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7130/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7130/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/c9c6446bb8a94360f131ae67f217bd591122f7e5"}}}}