{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/31371578","id":31371578,"diff_hunk":"@@ -17,23 +17,22 @@\n \n package org.apache.spark.shuffle.hash\n \n-import scala.collection.mutable.ArrayBuffer\n-import scala.collection.mutable.HashMap\n-import scala.util.{Failure, Success, Try}\n+import java.io.InputStream\n \n import org.apache.spark._\n-import org.apache.spark.serializer.Serializer\n import org.apache.spark.shuffle.FetchFailedException\n import org.apache.spark.storage.{BlockId, BlockManagerId, ShuffleBlockFetcherIterator, ShuffleBlockId}\n import org.apache.spark.util.CompletionIterator\n \n+import scala.collection.mutable.{ArrayBuffer, HashMap}","path":"core/src/main/scala/org/apache/spark/shuffle/hash/BlockStoreShuffleFetcher.scala","position":15,"original_position":15,"commit_id":"418b10315d9c0c5b4710fad01a94be1960a846dd","original_commit_id":"b12f912c41acb8612130c6f9abcd3ef2bc59e36c","user":{"login":"massie","id":19554,"avatar_url":"https://avatars.githubusercontent.com/u/19554?v=3","gravatar_id":"","url":"https://api.github.com/users/massie","html_url":"https://github.com/massie","followers_url":"https://api.github.com/users/massie/followers","following_url":"https://api.github.com/users/massie/following{/other_user}","gists_url":"https://api.github.com/users/massie/gists{/gist_id}","starred_url":"https://api.github.com/users/massie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massie/subscriptions","organizations_url":"https://api.github.com/users/massie/orgs","repos_url":"https://api.github.com/users/massie/repos","events_url":"https://api.github.com/users/massie/events{/privacy}","received_events_url":"https://api.github.com/users/massie/received_events","type":"User","site_admin":false},"body":"Will do.","created_at":"2015-05-29T22:50:53Z","updated_at":"2015-05-29T22:50:53Z","html_url":"https://github.com/apache/spark/pull/6423#discussion_r31371578","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/6423","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/31371578"},"html":{"href":"https://github.com/apache/spark/pull/6423#discussion_r31371578"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/6423"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/6423","id":36258709,"html_url":"https://github.com/apache/spark/pull/6423","diff_url":"https://github.com/apache/spark/pull/6423.diff","patch_url":"https://github.com/apache/spark/pull/6423.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/6423","number":6423,"state":"open","locked":false,"title":"[SPARK-7884] Allow Spark shuffle APIs to be more customizable","user":{"login":"massie","id":19554,"avatar_url":"https://avatars.githubusercontent.com/u/19554?v=3","gravatar_id":"","url":"https://api.github.com/users/massie","html_url":"https://github.com/massie","followers_url":"https://api.github.com/users/massie/followers","following_url":"https://api.github.com/users/massie/following{/other_user}","gists_url":"https://api.github.com/users/massie/gists{/gist_id}","starred_url":"https://api.github.com/users/massie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massie/subscriptions","organizations_url":"https://api.github.com/users/massie/orgs","repos_url":"https://api.github.com/users/massie/repos","events_url":"https://api.github.com/users/massie/events{/privacy}","received_events_url":"https://api.github.com/users/massie/received_events","type":"User","site_admin":false},"body":"This commit updates the shuffle read path to enable ShuffleReader\r\nimplementations more control over the deserialization process.\r\n\r\nThe BlockStoreShuffleFetcher.fetch() method has been renamed to\r\nBlockStoreShuffleFetcher.fetchBlockStreams(). Previously, this method\r\nreturned a record iterator; now, it returns an iterator of\r\n(BlockId, InputStream). Deserialization of records is now handled\r\nin the ShuffleReader.read() method.\r\n\r\nThis change creates a cleaner separation of concerns and allows\r\nimplementations of ShuffleReader more flexibility in how records\r\nare retrieved.\r\n","created_at":"2015-05-27T00:21:22Z","updated_at":"2015-05-29T22:50:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03d6a8f9b78ae00b346302598675368bf9582839","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/6423/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/6423/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/6423/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/418b10315d9c0c5b4710fad01a94be1960a846dd","head":{"label":"massie:shuffle-api-cleanup","ref":"shuffle-api-cleanup","sha":"418b10315d9c0c5b4710fad01a94be1960a846dd","user":{"login":"massie","id":19554,"avatar_url":"https://avatars.githubusercontent.com/u/19554?v=3","gravatar_id":"","url":"https://api.github.com/users/massie","html_url":"https://github.com/massie","followers_url":"https://api.github.com/users/massie/followers","following_url":"https://api.github.com/users/massie/following{/other_user}","gists_url":"https://api.github.com/users/massie/gists{/gist_id}","starred_url":"https://api.github.com/users/massie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massie/subscriptions","organizations_url":"https://api.github.com/users/massie/orgs","repos_url":"https://api.github.com/users/massie/repos","events_url":"https://api.github.com/users/massie/events{/privacy}","received_events_url":"https://api.github.com/users/massie/received_events","type":"User","site_admin":false},"repo":{"id":25941269,"name":"spark","full_name":"massie/spark","owner":{"login":"massie","id":19554,"avatar_url":"https://avatars.githubusercontent.com/u/19554?v=3","gravatar_id":"","url":"https://api.github.com/users/massie","html_url":"https://github.com/massie","followers_url":"https://api.github.com/users/massie/followers","following_url":"https://api.github.com/users/massie/following{/other_user}","gists_url":"https://api.github.com/users/massie/gists{/gist_id}","starred_url":"https://api.github.com/users/massie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massie/subscriptions","organizations_url":"https://api.github.com/users/massie/orgs","repos_url":"https://api.github.com/users/massie/repos","events_url":"https://api.github.com/users/massie/events{/privacy}","received_events_url":"https://api.github.com/users/massie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/massie/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/massie/spark","forks_url":"https://api.github.com/repos/massie/spark/forks","keys_url":"https://api.github.com/repos/massie/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/massie/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/massie/spark/teams","hooks_url":"https://api.github.com/repos/massie/spark/hooks","issue_events_url":"https://api.github.com/repos/massie/spark/issues/events{/number}","events_url":"https://api.github.com/repos/massie/spark/events","assignees_url":"https://api.github.com/repos/massie/spark/assignees{/user}","branches_url":"https://api.github.com/repos/massie/spark/branches{/branch}","tags_url":"https://api.github.com/repos/massie/spark/tags","blobs_url":"https://api.github.com/repos/massie/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/massie/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/massie/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/massie/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/massie/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/massie/spark/languages","stargazers_url":"https://api.github.com/repos/massie/spark/stargazers","contributors_url":"https://api.github.com/repos/massie/spark/contributors","subscribers_url":"https://api.github.com/repos/massie/spark/subscribers","subscription_url":"https://api.github.com/repos/massie/spark/subscription","commits_url":"https://api.github.com/repos/massie/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/massie/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/massie/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/massie/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/massie/spark/contents/{+path}","compare_url":"https://api.github.com/repos/massie/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/massie/spark/merges","archive_url":"https://api.github.com/repos/massie/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/massie/spark/downloads","issues_url":"https://api.github.com/repos/massie/spark/issues{/number}","pulls_url":"https://api.github.com/repos/massie/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/massie/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/massie/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/massie/spark/labels{/name}","releases_url":"https://api.github.com/repos/massie/spark/releases{/id}","created_at":"2014-10-29T21:03:16Z","updated_at":"2015-05-27T19:48:00Z","pushed_at":"2015-05-29T22:40:36Z","git_url":"git://github.com/massie/spark.git","ssh_url":"git@github.com:massie/spark.git","clone_url":"https://github.com/massie/spark.git","svn_url":"https://github.com/massie/spark","homepage":null,"size":104372,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"dbf8ff38de0f95f467b874a5b527dcf59439efe8","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-05-29T22:15:38Z","pushed_at":"2015-05-29T22:40:38Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1803111,"stargazers_count":4141,"watchers_count":4141,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3646,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":326,"forks":3646,"open_issues":326,"watchers":4141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/6423"},"html":{"href":"https://github.com/apache/spark/pull/6423"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/6423"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/6423/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/6423/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/6423/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/418b10315d9c0c5b4710fad01a94be1960a846dd"}}}}