{"action":"closed","number":1720,"pull_request":{"url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/1720","id":44158591,"html_url":"https://github.com/pentaho/pentaho-kettle/pull/1720","diff_url":"https://github.com/pentaho/pentaho-kettle/pull/1720.diff","patch_url":"https://github.com/pentaho/pentaho-kettle/pull/1720.patch","issue_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/1720","number":1720,"state":"closed","locked":false,"title":"[BACKLOG-4802] Continue processing SharedObjects if DB type not found","user":{"login":"mattyb149","id":2124747,"avatar_url":"https://avatars.githubusercontent.com/u/2124747?v=3","gravatar_id":"","url":"https://api.github.com/users/mattyb149","html_url":"https://github.com/mattyb149","followers_url":"https://api.github.com/users/mattyb149/followers","following_url":"https://api.github.com/users/mattyb149/following{/other_user}","gists_url":"https://api.github.com/users/mattyb149/gists{/gist_id}","starred_url":"https://api.github.com/users/mattyb149/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattyb149/subscriptions","organizations_url":"https://api.github.com/users/mattyb149/orgs","repos_url":"https://api.github.com/users/mattyb149/repos","events_url":"https://api.github.com/users/mattyb149/events{/privacy}","received_events_url":"https://api.github.com/users/mattyb149/received_events","type":"User","site_admin":false},"body":"This fix will just log when a database type is not found, then continue to process the Shared Objects file. This will prevent errors when loading up a trans/job when there's an invalid entry in the Shared Objects file.  Also I adding formatting fixes and a toString() implementation.\r\n\r\nThere is no unit test attached. The constructor (and even the little part of code I was working in) depends on parsing XML, and it would take a LOT of mocking to test this change. The reproduction path for validation testing is straightforward, it doesn't allow for automation but this whole class needs a refactor before full unit testing can be done.","created_at":"2015-09-03T21:15:50Z","updated_at":"2015-09-03T21:19:02Z","closed_at":"2015-09-03T21:19:02Z","merged_at":"2015-09-03T21:19:02Z","merge_commit_sha":"ca1292c28b232ad6172ab9c908b739e6da44a5c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/1720/commits","review_comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/1720/comments","review_comment_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/1720/comments","statuses_url":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/5ff9b096ce2bde933e5a070728cac8045f7bb625","head":{"label":"mattyb149:BACKLOG-4802","ref":"BACKLOG-4802","sha":"5ff9b096ce2bde933e5a070728cac8045f7bb625","user":{"login":"mattyb149","id":2124747,"avatar_url":"https://avatars.githubusercontent.com/u/2124747?v=3","gravatar_id":"","url":"https://api.github.com/users/mattyb149","html_url":"https://github.com/mattyb149","followers_url":"https://api.github.com/users/mattyb149/followers","following_url":"https://api.github.com/users/mattyb149/following{/other_user}","gists_url":"https://api.github.com/users/mattyb149/gists{/gist_id}","starred_url":"https://api.github.com/users/mattyb149/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattyb149/subscriptions","organizations_url":"https://api.github.com/users/mattyb149/orgs","repos_url":"https://api.github.com/users/mattyb149/repos","events_url":"https://api.github.com/users/mattyb149/events{/privacy}","received_events_url":"https://api.github.com/users/mattyb149/received_events","type":"User","site_admin":false},"repo":{"id":13423338,"name":"pentaho-kettle","full_name":"mattyb149/pentaho-kettle","owner":{"login":"mattyb149","id":2124747,"avatar_url":"https://avatars.githubusercontent.com/u/2124747?v=3","gravatar_id":"","url":"https://api.github.com/users/mattyb149","html_url":"https://github.com/mattyb149","followers_url":"https://api.github.com/users/mattyb149/followers","following_url":"https://api.github.com/users/mattyb149/following{/other_user}","gists_url":"https://api.github.com/users/mattyb149/gists{/gist_id}","starred_url":"https://api.github.com/users/mattyb149/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattyb149/subscriptions","organizations_url":"https://api.github.com/users/mattyb149/orgs","repos_url":"https://api.github.com/users/mattyb149/repos","events_url":"https://api.github.com/users/mattyb149/events{/privacy}","received_events_url":"https://api.github.com/users/mattyb149/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattyb149/pentaho-kettle","description":"Pentaho Data Integration ( ETL ) a.k.a Kettle","fork":true,"url":"https://api.github.com/repos/mattyb149/pentaho-kettle","forks_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/forks","keys_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/teams","hooks_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/hooks","issue_events_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/issues/events{/number}","events_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/events","assignees_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/assignees{/user}","branches_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/branches{/branch}","tags_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/tags","blobs_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/statuses/{sha}","languages_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/languages","stargazers_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/stargazers","contributors_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/contributors","subscribers_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/subscribers","subscription_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/subscription","commits_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/contents/{+path}","compare_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/merges","archive_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/downloads","issues_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/issues{/number}","pulls_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/pulls{/number}","milestones_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/milestones{/number}","notifications_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/labels{/name}","releases_url":"https://api.github.com/repos/mattyb149/pentaho-kettle/releases{/id}","created_at":"2013-10-08T19:27:38Z","updated_at":"2014-09-04T00:29:49Z","pushed_at":"2015-09-03T20:35:23Z","git_url":"git://github.com/mattyb149/pentaho-kettle.git","ssh_url":"git@github.com:mattyb149/pentaho-kettle.git","clone_url":"https://github.com/mattyb149/pentaho-kettle.git","svn_url":"https://github.com/mattyb149/pentaho-kettle","homepage":null,"size":449076,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pentaho:master","ref":"master","sha":"bcba55aad1aa0eaffd554ad4a016ebc4f52dc212","user":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars.githubusercontent.com/u/1022787?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"repo":{"id":13421878,"name":"pentaho-kettle","full_name":"pentaho/pentaho-kettle","owner":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars.githubusercontent.com/u/1022787?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pentaho/pentaho-kettle","description":"Pentaho Data Integration ( ETL ) a.k.a Kettle","fork":false,"url":"https://api.github.com/repos/pentaho/pentaho-kettle","forks_url":"https://api.github.com/repos/pentaho/pentaho-kettle/forks","keys_url":"https://api.github.com/repos/pentaho/pentaho-kettle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pentaho/pentaho-kettle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pentaho/pentaho-kettle/teams","hooks_url":"https://api.github.com/repos/pentaho/pentaho-kettle/hooks","issue_events_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/events{/number}","events_url":"https://api.github.com/repos/pentaho/pentaho-kettle/events","assignees_url":"https://api.github.com/repos/pentaho/pentaho-kettle/assignees{/user}","branches_url":"https://api.github.com/repos/pentaho/pentaho-kettle/branches{/branch}","tags_url":"https://api.github.com/repos/pentaho/pentaho-kettle/tags","blobs_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/refs{/sha}","trees_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/{sha}","languages_url":"https://api.github.com/repos/pentaho/pentaho-kettle/languages","stargazers_url":"https://api.github.com/repos/pentaho/pentaho-kettle/stargazers","contributors_url":"https://api.github.com/repos/pentaho/pentaho-kettle/contributors","subscribers_url":"https://api.github.com/repos/pentaho/pentaho-kettle/subscribers","subscription_url":"https://api.github.com/repos/pentaho/pentaho-kettle/subscription","commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/commits{/sha}","git_commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/commits{/sha}","comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/comments{/number}","issue_comment_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/comments{/number}","contents_url":"https://api.github.com/repos/pentaho/pentaho-kettle/contents/{+path}","compare_url":"https://api.github.com/repos/pentaho/pentaho-kettle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pentaho/pentaho-kettle/merges","archive_url":"https://api.github.com/repos/pentaho/pentaho-kettle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pentaho/pentaho-kettle/downloads","issues_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues{/number}","pulls_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls{/number}","milestones_url":"https://api.github.com/repos/pentaho/pentaho-kettle/milestones{/number}","notifications_url":"https://api.github.com/repos/pentaho/pentaho-kettle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pentaho/pentaho-kettle/labels{/name}","releases_url":"https://api.github.com/repos/pentaho/pentaho-kettle/releases{/id}","created_at":"2013-10-08T18:27:11Z","updated_at":"2015-09-03T16:38:19Z","pushed_at":"2015-09-03T21:19:04Z","git_url":"git://github.com/pentaho/pentaho-kettle.git","ssh_url":"git@github.com:pentaho/pentaho-kettle.git","clone_url":"https://github.com/pentaho/pentaho-kettle.git","svn_url":"https://github.com/pentaho/pentaho-kettle","homepage":null,"size":611214,"stargazers_count":296,"watchers_count":296,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":419,"mirror_url":null,"open_issues_count":47,"forks":419,"open_issues":47,"watchers":296,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/1720"},"html":{"href":"https://github.com/pentaho/pentaho-kettle/pull/1720"},"issue":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/1720"},"comments":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/1720/comments"},"review_comments":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/1720/comments"},"review_comment":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/1720/commits"},"statuses":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/5ff9b096ce2bde933e5a070728cac8045f7bb625"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bmorrise","id":5509637,"avatar_url":"https://avatars.githubusercontent.com/u/5509637?v=3","gravatar_id":"","url":"https://api.github.com/users/bmorrise","html_url":"https://github.com/bmorrise","followers_url":"https://api.github.com/users/bmorrise/followers","following_url":"https://api.github.com/users/bmorrise/following{/other_user}","gists_url":"https://api.github.com/users/bmorrise/gists{/gist_id}","starred_url":"https://api.github.com/users/bmorrise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmorrise/subscriptions","organizations_url":"https://api.github.com/users/bmorrise/orgs","repos_url":"https://api.github.com/users/bmorrise/repos","events_url":"https://api.github.com/users/bmorrise/events{/privacy}","received_events_url":"https://api.github.com/users/bmorrise/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":51,"deletions":34,"changed_files":1}}