{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/23008489","id":23008489,"diff_hunk":"@@ -397,7 +404,16 @@ static inline void GeneratePixelShader(T& out, DSTALPHA_MODE dstAlphaMode, API_T\n \n \t\t// On GLSL, input variables must not be assigned to.\n \t\t// This is why we declare these variables locally instead.\n-\t\tout.Write(\"\\tfloat4 col0, col1;\\n\");\n+\t\tif (ApiType == API_OPENGL)\n+\t\t{\n+\t\t\tout.Write(\"\\tfloat4 col0, col1;\\n\");\n+\t\t}\n+\t\t// On D3D, input variables must be completely initialized before being used.\n+\t\telse\n+\t\t{\n+\t\t\tout.Write(\"\\tfloat4 col0 = 0.0;\\n\");\n+\t\t\tout.Write(\"\\tfloat4 col1 = 0.0;\\n\");","path":"Source/Core/VideoCommon/PixelShaderGen.cpp","position":54,"original_position":54,"commit_id":"ff7507be866b48846746357a79e4932bb3e481fe","original_commit_id":"ff7507be866b48846746357a79e4932bb3e481fe","user":{"login":"Tinob","id":6096778,"avatar_url":"https://avatars.githubusercontent.com/u/6096778?v=3","gravatar_id":"","url":"https://api.github.com/users/Tinob","html_url":"https://github.com/Tinob","followers_url":"https://api.github.com/users/Tinob/followers","following_url":"https://api.github.com/users/Tinob/following{/other_user}","gists_url":"https://api.github.com/users/Tinob/gists{/gist_id}","starred_url":"https://api.github.com/users/Tinob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tinob/subscriptions","organizations_url":"https://api.github.com/users/Tinob/orgs","repos_url":"https://api.github.com/users/Tinob/repos","events_url":"https://api.github.com/users/Tinob/events{/privacy}","received_events_url":"https://api.github.com/users/Tinob/received_events","type":"User","site_admin":false},"body":"recomend to use float4(0.0,0.0,0.0,0.0) in both backends it will avoid problems with some implementations","created_at":"2015-01-15T13:21:01Z","updated_at":"2015-01-15T13:21:01Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/1881#discussion_r23008489","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1881","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/23008489"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1881#discussion_r23008489"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1881"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1881","id":27262222,"html_url":"https://github.com/dolphin-emu/dolphin/pull/1881","diff_url":"https://github.com/dolphin-emu/dolphin/pull/1881.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/1881.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1881","number":1881,"state":"open","locked":false,"title":"zfreeze depth fixes to PR #1812","user":{"login":"NanoByte011","id":8997598,"avatar_url":"https://avatars.githubusercontent.com/u/8997598?v=3","gravatar_id":"","url":"https://api.github.com/users/NanoByte011","html_url":"https://github.com/NanoByte011","followers_url":"https://api.github.com/users/NanoByte011/followers","following_url":"https://api.github.com/users/NanoByte011/following{/other_user}","gists_url":"https://api.github.com/users/NanoByte011/gists{/gist_id}","starred_url":"https://api.github.com/users/NanoByte011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanoByte011/subscriptions","organizations_url":"https://api.github.com/users/NanoByte011/orgs","repos_url":"https://api.github.com/users/NanoByte011/repos","events_url":"https://api.github.com/users/NanoByte011/events{/privacy}","received_events_url":"https://api.github.com/users/NanoByte011/received_events","type":"User","site_admin":false},"body":"Let's open up our final thoughts and discussions on zfreeze joys and woes here.\r\n\r\nPR #1812 should be merged before this.","created_at":"2015-01-13T10:49:18Z","updated_at":"2015-01-15T13:21:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e5c156d9a4fb72b5e3353af89f8a600226aae84","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1881/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1881/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1881/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/ff7507be866b48846746357a79e4932bb3e481fe","head":{"label":"NanoByte011:real_zfreeze","ref":"real_zfreeze","sha":"ff7507be866b48846746357a79e4932bb3e481fe","user":{"login":"NanoByte011","id":8997598,"avatar_url":"https://avatars.githubusercontent.com/u/8997598?v=3","gravatar_id":"","url":"https://api.github.com/users/NanoByte011","html_url":"https://github.com/NanoByte011","followers_url":"https://api.github.com/users/NanoByte011/followers","following_url":"https://api.github.com/users/NanoByte011/following{/other_user}","gists_url":"https://api.github.com/users/NanoByte011/gists{/gist_id}","starred_url":"https://api.github.com/users/NanoByte011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanoByte011/subscriptions","organizations_url":"https://api.github.com/users/NanoByte011/orgs","repos_url":"https://api.github.com/users/NanoByte011/repos","events_url":"https://api.github.com/users/NanoByte011/events{/privacy}","received_events_url":"https://api.github.com/users/NanoByte011/received_events","type":"User","site_admin":false},"repo":{"id":28471788,"name":"dolphin","full_name":"NanoByte011/dolphin","owner":{"login":"NanoByte011","id":8997598,"avatar_url":"https://avatars.githubusercontent.com/u/8997598?v=3","gravatar_id":"","url":"https://api.github.com/users/NanoByte011","html_url":"https://github.com/NanoByte011","followers_url":"https://api.github.com/users/NanoByte011/followers","following_url":"https://api.github.com/users/NanoByte011/following{/other_user}","gists_url":"https://api.github.com/users/NanoByte011/gists{/gist_id}","starred_url":"https://api.github.com/users/NanoByte011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanoByte011/subscriptions","organizations_url":"https://api.github.com/users/NanoByte011/orgs","repos_url":"https://api.github.com/users/NanoByte011/repos","events_url":"https://api.github.com/users/NanoByte011/events{/privacy}","received_events_url":"https://api.github.com/users/NanoByte011/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NanoByte011/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/NanoByte011/dolphin","forks_url":"https://api.github.com/repos/NanoByte011/dolphin/forks","keys_url":"https://api.github.com/repos/NanoByte011/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NanoByte011/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NanoByte011/dolphin/teams","hooks_url":"https://api.github.com/repos/NanoByte011/dolphin/hooks","issue_events_url":"https://api.github.com/repos/NanoByte011/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/NanoByte011/dolphin/events","assignees_url":"https://api.github.com/repos/NanoByte011/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/NanoByte011/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/NanoByte011/dolphin/tags","blobs_url":"https://api.github.com/repos/NanoByte011/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NanoByte011/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NanoByte011/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/NanoByte011/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NanoByte011/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/NanoByte011/dolphin/languages","stargazers_url":"https://api.github.com/repos/NanoByte011/dolphin/stargazers","contributors_url":"https://api.github.com/repos/NanoByte011/dolphin/contributors","subscribers_url":"https://api.github.com/repos/NanoByte011/dolphin/subscribers","subscription_url":"https://api.github.com/repos/NanoByte011/dolphin/subscription","commits_url":"https://api.github.com/repos/NanoByte011/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/NanoByte011/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/NanoByte011/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/NanoByte011/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/NanoByte011/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/NanoByte011/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NanoByte011/dolphin/merges","archive_url":"https://api.github.com/repos/NanoByte011/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NanoByte011/dolphin/downloads","issues_url":"https://api.github.com/repos/NanoByte011/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/NanoByte011/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/NanoByte011/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/NanoByte011/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NanoByte011/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/NanoByte011/dolphin/releases{/id}","created_at":"2014-12-25T05:21:27Z","updated_at":"2015-01-07T09:00:11Z","pushed_at":"2015-01-15T05:56:34Z","git_url":"git://github.com/NanoByte011/dolphin.git","ssh_url":"git@github.com:NanoByte011/dolphin.git","clone_url":"https://github.com/NanoByte011/dolphin.git","svn_url":"https://github.com/NanoByte011/dolphin","homepage":null,"size":197142,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"0932282caf926347c60f49af60c17612fc9624b5","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/{number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-01-15T13:11:04Z","pushed_at":"2015-01-15T03:08:41Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":null,"size":252241,"stargazers_count":939,"watchers_count":939,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":300,"mirror_url":null,"open_issues_count":61,"forks":300,"open_issues":61,"watchers":939,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1881"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/1881"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1881"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/1881/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1881/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/1881/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/ff7507be866b48846746357a79e4932bb3e481fe"}}}}