{"action":"closed","number":244,"pull_request":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/244","id":29035725,"html_url":"https://github.com/gemini-hlsw/ocs/pull/244","diff_url":"https://github.com/gemini-hlsw/ocs/pull/244.diff","patch_url":"https://github.com/gemini-hlsw/ocs/pull/244.patch","issue_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/244","number":244,"state":"closed","locked":false,"title":"OCSADV-154  push proper motion into HmsDegTarget","user":{"login":"tpolecat","id":1200131,"avatar_url":"https://avatars.githubusercontent.com/u/1200131?v=3","gravatar_id":"","url":"https://api.github.com/users/tpolecat","html_url":"https://github.com/tpolecat","followers_url":"https://api.github.com/users/tpolecat/followers","following_url":"https://api.github.com/users/tpolecat/following{/other_user}","gists_url":"https://api.github.com/users/tpolecat/gists{/gist_id}","starred_url":"https://api.github.com/users/tpolecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpolecat/subscriptions","organizations_url":"https://api.github.com/users/tpolecat/orgs","repos_url":"https://api.github.com/users/tpolecat/repos","events_url":"https://api.github.com/users/tpolecat/events{/privacy}","received_events_url":"https://api.github.com/users/tpolecat/received_events","type":"User","site_admin":false},"body":"This PR pushes proper motion parameters from `ITarget` down into `HmsDegTarget`, which is the only subtype where they make sense. Consequences are as follows:\r\n\r\n- Had to rewrite part of `GeneralRule.WFS_RULE` so I added a test for it.\r\n- Discovered a bug in `clone()` for all target types that caused the RA and Dec to be shared with the previous instance. This was probably introduced by me in an earlier refactoring. Fixed and added tests for cloning.\r\n- Several OT editors had to be updated to deal with the possibility that their target might not have proper motion. Mostly trivial changes here.\r\n\r\n","created_at":"2015-02-10T19:17:19Z","updated_at":"2015-02-11T19:38:30Z","closed_at":"2015-02-11T19:38:30Z","merged_at":"2015-02-11T19:38:30Z","merge_commit_sha":"17b05129e988745fded0f6a8de3e3259903b5c61","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/244/commits","review_comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/244/comments","review_comment_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/244/comments","statuses_url":"https://api.github.com/repos/gemini-hlsw/ocs/statuses/0e891d6ead023836c8c63df39c6e01809466ad74","head":{"label":"tpolecat:pm-down","ref":"pm-down","sha":"0e891d6ead023836c8c63df39c6e01809466ad74","user":{"login":"tpolecat","id":1200131,"avatar_url":"https://avatars.githubusercontent.com/u/1200131?v=3","gravatar_id":"","url":"https://api.github.com/users/tpolecat","html_url":"https://github.com/tpolecat","followers_url":"https://api.github.com/users/tpolecat/followers","following_url":"https://api.github.com/users/tpolecat/following{/other_user}","gists_url":"https://api.github.com/users/tpolecat/gists{/gist_id}","starred_url":"https://api.github.com/users/tpolecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpolecat/subscriptions","organizations_url":"https://api.github.com/users/tpolecat/orgs","repos_url":"https://api.github.com/users/tpolecat/repos","events_url":"https://api.github.com/users/tpolecat/events{/privacy}","received_events_url":"https://api.github.com/users/tpolecat/received_events","type":"User","site_admin":false},"repo":{"id":23966560,"name":"ocs","full_name":"tpolecat/ocs","owner":{"login":"tpolecat","id":1200131,"avatar_url":"https://avatars.githubusercontent.com/u/1200131?v=3","gravatar_id":"","url":"https://api.github.com/users/tpolecat","html_url":"https://github.com/tpolecat","followers_url":"https://api.github.com/users/tpolecat/followers","following_url":"https://api.github.com/users/tpolecat/following{/other_user}","gists_url":"https://api.github.com/users/tpolecat/gists{/gist_id}","starred_url":"https://api.github.com/users/tpolecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpolecat/subscriptions","organizations_url":"https://api.github.com/users/tpolecat/orgs","repos_url":"https://api.github.com/users/tpolecat/repos","events_url":"https://api.github.com/users/tpolecat/events{/privacy}","received_events_url":"https://api.github.com/users/tpolecat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tpolecat/ocs","description":"","fork":true,"url":"https://api.github.com/repos/tpolecat/ocs","forks_url":"https://api.github.com/repos/tpolecat/ocs/forks","keys_url":"https://api.github.com/repos/tpolecat/ocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpolecat/ocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpolecat/ocs/teams","hooks_url":"https://api.github.com/repos/tpolecat/ocs/hooks","issue_events_url":"https://api.github.com/repos/tpolecat/ocs/issues/events{/number}","events_url":"https://api.github.com/repos/tpolecat/ocs/events","assignees_url":"https://api.github.com/repos/tpolecat/ocs/assignees{/user}","branches_url":"https://api.github.com/repos/tpolecat/ocs/branches{/branch}","tags_url":"https://api.github.com/repos/tpolecat/ocs/tags","blobs_url":"https://api.github.com/repos/tpolecat/ocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpolecat/ocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpolecat/ocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpolecat/ocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpolecat/ocs/statuses/{sha}","languages_url":"https://api.github.com/repos/tpolecat/ocs/languages","stargazers_url":"https://api.github.com/repos/tpolecat/ocs/stargazers","contributors_url":"https://api.github.com/repos/tpolecat/ocs/contributors","subscribers_url":"https://api.github.com/repos/tpolecat/ocs/subscribers","subscription_url":"https://api.github.com/repos/tpolecat/ocs/subscription","commits_url":"https://api.github.com/repos/tpolecat/ocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpolecat/ocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpolecat/ocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpolecat/ocs/issues/comments/{number}","contents_url":"https://api.github.com/repos/tpolecat/ocs/contents/{+path}","compare_url":"https://api.github.com/repos/tpolecat/ocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpolecat/ocs/merges","archive_url":"https://api.github.com/repos/tpolecat/ocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpolecat/ocs/downloads","issues_url":"https://api.github.com/repos/tpolecat/ocs/issues{/number}","pulls_url":"https://api.github.com/repos/tpolecat/ocs/pulls{/number}","milestones_url":"https://api.github.com/repos/tpolecat/ocs/milestones{/number}","notifications_url":"https://api.github.com/repos/tpolecat/ocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpolecat/ocs/labels{/name}","releases_url":"https://api.github.com/repos/tpolecat/ocs/releases{/id}","created_at":"2014-09-12T15:45:38Z","updated_at":"2015-01-28T18:21:35Z","pushed_at":"2015-02-10T18:34:36Z","git_url":"git://github.com/tpolecat/ocs.git","ssh_url":"git@github.com:tpolecat/ocs.git","clone_url":"https://github.com/tpolecat/ocs.git","svn_url":"https://github.com/tpolecat/ocs","homepage":null,"size":256399,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"gemini-hlsw:develop","ref":"develop","sha":"d40216e55b42c683b836f2ca74b409a8e2e2bdd4","user":{"login":"gemini-hlsw","id":8593735,"avatar_url":"https://avatars.githubusercontent.com/u/8593735?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-hlsw","html_url":"https://github.com/gemini-hlsw","followers_url":"https://api.github.com/users/gemini-hlsw/followers","following_url":"https://api.github.com/users/gemini-hlsw/following{/other_user}","gists_url":"https://api.github.com/users/gemini-hlsw/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-hlsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-hlsw/subscriptions","organizations_url":"https://api.github.com/users/gemini-hlsw/orgs","repos_url":"https://api.github.com/users/gemini-hlsw/repos","events_url":"https://api.github.com/users/gemini-hlsw/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-hlsw/received_events","type":"Organization","site_admin":false},"repo":{"id":23963494,"name":"ocs","full_name":"gemini-hlsw/ocs","owner":{"login":"gemini-hlsw","id":8593735,"avatar_url":"https://avatars.githubusercontent.com/u/8593735?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-hlsw","html_url":"https://github.com/gemini-hlsw","followers_url":"https://api.github.com/users/gemini-hlsw/followers","following_url":"https://api.github.com/users/gemini-hlsw/following{/other_user}","gists_url":"https://api.github.com/users/gemini-hlsw/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-hlsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-hlsw/subscriptions","organizations_url":"https://api.github.com/users/gemini-hlsw/orgs","repos_url":"https://api.github.com/users/gemini-hlsw/repos","events_url":"https://api.github.com/users/gemini-hlsw/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-hlsw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-hlsw/ocs","description":"Observatory Control Software","fork":false,"url":"https://api.github.com/repos/gemini-hlsw/ocs","forks_url":"https://api.github.com/repos/gemini-hlsw/ocs/forks","keys_url":"https://api.github.com/repos/gemini-hlsw/ocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-hlsw/ocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-hlsw/ocs/teams","hooks_url":"https://api.github.com/repos/gemini-hlsw/ocs/hooks","issue_events_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-hlsw/ocs/events","assignees_url":"https://api.github.com/repos/gemini-hlsw/ocs/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-hlsw/ocs/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-hlsw/ocs/tags","blobs_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-hlsw/ocs/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-hlsw/ocs/languages","stargazers_url":"https://api.github.com/repos/gemini-hlsw/ocs/stargazers","contributors_url":"https://api.github.com/repos/gemini-hlsw/ocs/contributors","subscribers_url":"https://api.github.com/repos/gemini-hlsw/ocs/subscribers","subscription_url":"https://api.github.com/repos/gemini-hlsw/ocs/subscription","commits_url":"https://api.github.com/repos/gemini-hlsw/ocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/comments/{number}","contents_url":"https://api.github.com/repos/gemini-hlsw/ocs/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-hlsw/ocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-hlsw/ocs/merges","archive_url":"https://api.github.com/repos/gemini-hlsw/ocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-hlsw/ocs/downloads","issues_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-hlsw/ocs/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-hlsw/ocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-hlsw/ocs/labels{/name}","releases_url":"https://api.github.com/repos/gemini-hlsw/ocs/releases{/id}","created_at":"2014-09-12T14:20:23Z","updated_at":"2015-02-11T18:25:56Z","pushed_at":"2015-02-11T19:38:30Z","git_url":"git://github.com/gemini-hlsw/ocs.git","ssh_url":"git@github.com:gemini-hlsw/ocs.git","clone_url":"https://github.com/gemini-hlsw/ocs.git","svn_url":"https://github.com/gemini-hlsw/ocs","homepage":"","size":262638,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":4,"forks":8,"open_issues":4,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/244"},"html":{"href":"https://github.com/gemini-hlsw/ocs/pull/244"},"issue":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/issues/244"},"comments":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/statuses/0e891d6ead023836c8c63df39c6e01809466ad74"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tpolecat","id":1200131,"avatar_url":"https://avatars.githubusercontent.com/u/1200131?v=3","gravatar_id":"","url":"https://api.github.com/users/tpolecat","html_url":"https://github.com/tpolecat","followers_url":"https://api.github.com/users/tpolecat/followers","following_url":"https://api.github.com/users/tpolecat/following{/other_user}","gists_url":"https://api.github.com/users/tpolecat/gists{/gist_id}","starred_url":"https://api.github.com/users/tpolecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpolecat/subscriptions","organizations_url":"https://api.github.com/users/tpolecat/orgs","repos_url":"https://api.github.com/users/tpolecat/repos","events_url":"https://api.github.com/users/tpolecat/events{/privacy}","received_events_url":"https://api.github.com/users/tpolecat/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"commits":5,"additions":395,"deletions":160,"changed_files":10}}