{"action":"closed","number":11201,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11201","id":29069393,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11201","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11201.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11201.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11201","number":11201,"state":"closed","locked":false,"title":"(perf-tweak-3) Cache friendly traversal","user":{"login":"bkentel","id":780369,"avatar_url":"https://avatars.githubusercontent.com/u/780369?v=3","gravatar_id":"","url":"https://api.github.com/users/bkentel","html_url":"https://github.com/bkentel","followers_url":"https://api.github.com/users/bkentel/followers","following_url":"https://api.github.com/users/bkentel/following{/other_user}","gists_url":"https://api.github.com/users/bkentel/gists{/gist_id}","starred_url":"https://api.github.com/users/bkentel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkentel/subscriptions","organizations_url":"https://api.github.com/users/bkentel/orgs","repos_url":"https://api.github.com/users/bkentel/repos","events_url":"https://api.github.com/users/bkentel/events{/privacy}","received_events_url":"https://api.github.com/users/bkentel/received_events","type":"User","site_admin":false},"body":"This changes the array traversal for lightmaps and transparency to access `submaps` in order, and access arrays within `submaps` in order to much improve cache friendliness. Also, some very light cleanup.\r\n\r\n+ New / Fix: use `add_light_source(...)` to illuminate a small area around vehicle mounted cone lights (re: the longstanding issue that @KA101 brought up).\r\n+ Moved `map::build_transparency_cache(...)` from `map.cpp` to `lightmap.cpp`.\r\n+ Flipped a few `#define`s  to `constexpr`.\r\n+ Slightly tweak `dir_x[]` and `dir_y[]` order.\r\n+ Use `std::hypot`\r\n+ Flip nested ifs to an early bail-out in two places.\r\n+ Remove `static` from `lit [][]` and use the compiler generated zero-initialization instead of `memset`.\r\n\r\nSee #11180 \r\n\r\n@narc0tiq Does this also fix your clang related failures?\r\n","created_at":"2015-02-11T05:38:01Z","updated_at":"2015-02-11T07:11:51Z","closed_at":"2015-02-11T07:11:51Z","merged_at":"2015-02-11T07:11:51Z","merge_commit_sha":"e3f132155f01651cad614befea6bed79d14b4f61","assignee":{"login":"KA101","id":4195632,"avatar_url":"https://avatars.githubusercontent.com/u/4195632?v=3","gravatar_id":"","url":"https://api.github.com/users/KA101","html_url":"https://github.com/KA101","followers_url":"https://api.github.com/users/KA101/followers","following_url":"https://api.github.com/users/KA101/following{/other_user}","gists_url":"https://api.github.com/users/KA101/gists{/gist_id}","starred_url":"https://api.github.com/users/KA101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KA101/subscriptions","organizations_url":"https://api.github.com/users/KA101/orgs","repos_url":"https://api.github.com/users/KA101/repos","events_url":"https://api.github.com/users/KA101/events{/privacy}","received_events_url":"https://api.github.com/users/KA101/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11201/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11201/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11201/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/e8e87410cfbe22ca90739c1a3ea88248892ccc66","head":{"label":"bkentel:hotpath-perf-tweak3","ref":"hotpath-perf-tweak3","sha":"e8e87410cfbe22ca90739c1a3ea88248892ccc66","user":{"login":"bkentel","id":780369,"avatar_url":"https://avatars.githubusercontent.com/u/780369?v=3","gravatar_id":"","url":"https://api.github.com/users/bkentel","html_url":"https://github.com/bkentel","followers_url":"https://api.github.com/users/bkentel/followers","following_url":"https://api.github.com/users/bkentel/following{/other_user}","gists_url":"https://api.github.com/users/bkentel/gists{/gist_id}","starred_url":"https://api.github.com/users/bkentel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkentel/subscriptions","organizations_url":"https://api.github.com/users/bkentel/orgs","repos_url":"https://api.github.com/users/bkentel/repos","events_url":"https://api.github.com/users/bkentel/events{/privacy}","received_events_url":"https://api.github.com/users/bkentel/received_events","type":"User","site_admin":false},"repo":{"id":28679284,"name":"Cataclysm-DDA","full_name":"bkentel/Cataclysm-DDA","owner":{"login":"bkentel","id":780369,"avatar_url":"https://avatars.githubusercontent.com/u/780369?v=3","gravatar_id":"","url":"https://api.github.com/users/bkentel","html_url":"https://github.com/bkentel","followers_url":"https://api.github.com/users/bkentel/followers","following_url":"https://api.github.com/users/bkentel/following{/other_user}","gists_url":"https://api.github.com/users/bkentel/gists{/gist_id}","starred_url":"https://api.github.com/users/bkentel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkentel/subscriptions","organizations_url":"https://api.github.com/users/bkentel/orgs","repos_url":"https://api.github.com/users/bkentel/repos","events_url":"https://api.github.com/users/bkentel/events{/privacy}","received_events_url":"https://api.github.com/users/bkentel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bkentel/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/bkentel/Cataclysm-DDA","forks_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/issues/comments/{number}","contents_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/releases{/id}","created_at":"2015-01-01T02:36:43Z","updated_at":"2015-02-10T15:56:00Z","pushed_at":"2015-02-11T05:25:28Z","git_url":"git://github.com/bkentel/Cataclysm-DDA.git","ssh_url":"git@github.com:bkentel/Cataclysm-DDA.git","clone_url":"https://github.com/bkentel/Cataclysm-DDA.git","svn_url":"https://github.com/bkentel/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":350465,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"7ca5594f4a39e832b2a9999a25bf1c322c25a3f0","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/{number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2015-02-11T07:11:39Z","pushed_at":"2015-02-11T07:11:39Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":422781,"stargazers_count":597,"watchers_count":597,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":647,"mirror_url":null,"open_issues_count":813,"forks":647,"open_issues":813,"watchers":597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11201"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11201"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11201"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11201/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11201/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11201/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/e8e87410cfbe22ca90739c1a3ea88248892ccc66"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"KA101","id":4195632,"avatar_url":"https://avatars.githubusercontent.com/u/4195632?v=3","gravatar_id":"","url":"https://api.github.com/users/KA101","html_url":"https://github.com/KA101","followers_url":"https://api.github.com/users/KA101/followers","following_url":"https://api.github.com/users/KA101/following{/other_user}","gists_url":"https://api.github.com/users/KA101/gists{/gist_id}","starred_url":"https://api.github.com/users/KA101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KA101/subscriptions","organizations_url":"https://api.github.com/users/KA101/orgs","repos_url":"https://api.github.com/users/KA101/repos","events_url":"https://api.github.com/users/KA101/events{/privacy}","received_events_url":"https://api.github.com/users/KA101/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":234,"deletions":198,"changed_files":2}}