{"action":"created","comment":{"url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/pulls/comments/41356521","id":41356521,"diff_hunk":"@@ -0,0 +1,36 @@\n+﻿using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Text;\n+using System.Threading.Tasks;\n+\n+namespace BookingRoom.Helpers\n+{\n+    public static class SettingsHelper\n+    {\n+        public static string GetLoggerName()","path":"CalendarApp/BookingRoom/Helpers/SettingsHelper.cs","position":11,"original_position":11,"commit_id":"2ed823810c5778b5957901bcf84ff336c4428b2f","original_commit_id":"2ed823810c5778b5957901bcf84ff336c4428b2f","user":{"login":"oloandriy","id":10503958,"avatar_url":"https://avatars.githubusercontent.com/u/10503958?v=3","gravatar_id":"","url":"https://api.github.com/users/oloandriy","html_url":"https://github.com/oloandriy","followers_url":"https://api.github.com/users/oloandriy/followers","following_url":"https://api.github.com/users/oloandriy/following{/other_user}","gists_url":"https://api.github.com/users/oloandriy/gists{/gist_id}","starred_url":"https://api.github.com/users/oloandriy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oloandriy/subscriptions","organizations_url":"https://api.github.com/users/oloandriy/orgs","repos_url":"https://api.github.com/users/oloandriy/repos","events_url":"https://api.github.com/users/oloandriy/events{/privacy}","received_events_url":"https://api.github.com/users/oloandriy/received_events","type":"User","site_admin":false},"body":"I don't see any benefit having dedicated method or pair of methods per each app setting. \r\nMain goal of having this helper class is to avoid potential mistakes in appsetting names. My suggestion is to create pair of methods : one for getting app setting second for setting. They should accept value from enumeration that will be used to identified appsetting that needs to be received/updated","created_at":"2015-10-07T06:48:59Z","updated_at":"2015-10-07T06:48:59Z","html_url":"https://github.com/OrestHurskiy/CalenderApp/pull/7#discussion_r41356521","pull_request_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/OrestHurskiy/CalenderApp/pulls/comments/41356521"},"html":{"href":"https://github.com/OrestHurskiy/CalenderApp/pull/7#discussion_r41356521"},"pull_request":{"href":"https://api.github.com/repos/OrestHurskiy/CalenderApp/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/pulls/7","id":46905764,"html_url":"https://github.com/OrestHurskiy/CalenderApp/pull/7","diff_url":"https://github.com/OrestHurskiy/CalenderApp/pull/7.diff","patch_url":"https://github.com/OrestHurskiy/CalenderApp/pull/7.patch","issue_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/issues/7","number":7,"state":"open","locked":false,"title":"Add Simple Calendar Event Actions","user":{"login":"KarpaDmytro","id":14778235,"avatar_url":"https://avatars.githubusercontent.com/u/14778235?v=3","gravatar_id":"","url":"https://api.github.com/users/KarpaDmytro","html_url":"https://github.com/KarpaDmytro","followers_url":"https://api.github.com/users/KarpaDmytro/followers","following_url":"https://api.github.com/users/KarpaDmytro/following{/other_user}","gists_url":"https://api.github.com/users/KarpaDmytro/gists{/gist_id}","starred_url":"https://api.github.com/users/KarpaDmytro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarpaDmytro/subscriptions","organizations_url":"https://api.github.com/users/KarpaDmytro/orgs","repos_url":"https://api.github.com/users/KarpaDmytro/repos","events_url":"https://api.github.com/users/KarpaDmytro/events{/privacy}","received_events_url":"https://api.github.com/users/KarpaDmytro/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-06T13:56:50Z","updated_at":"2015-10-07T06:48:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"314a906a4faa26c5ada6f467db2bbfdb8b57fe7c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/pulls/7/commits","review_comments_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/pulls/7/comments","review_comment_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/issues/7/comments","statuses_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/statuses/2ed823810c5778b5957901bcf84ff336c4428b2f","head":{"label":"OrestHurskiy:Add-Simple-Event","ref":"Add-Simple-Event","sha":"2ed823810c5778b5957901bcf84ff336c4428b2f","user":{"login":"OrestHurskiy","id":11854706,"avatar_url":"https://avatars.githubusercontent.com/u/11854706?v=3","gravatar_id":"","url":"https://api.github.com/users/OrestHurskiy","html_url":"https://github.com/OrestHurskiy","followers_url":"https://api.github.com/users/OrestHurskiy/followers","following_url":"https://api.github.com/users/OrestHurskiy/following{/other_user}","gists_url":"https://api.github.com/users/OrestHurskiy/gists{/gist_id}","starred_url":"https://api.github.com/users/OrestHurskiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrestHurskiy/subscriptions","organizations_url":"https://api.github.com/users/OrestHurskiy/orgs","repos_url":"https://api.github.com/users/OrestHurskiy/repos","events_url":"https://api.github.com/users/OrestHurskiy/events{/privacy}","received_events_url":"https://api.github.com/users/OrestHurskiy/received_events","type":"User","site_admin":false},"repo":{"id":42934225,"name":"CalenderApp","full_name":"OrestHurskiy/CalenderApp","owner":{"login":"OrestHurskiy","id":11854706,"avatar_url":"https://avatars.githubusercontent.com/u/11854706?v=3","gravatar_id":"","url":"https://api.github.com/users/OrestHurskiy","html_url":"https://github.com/OrestHurskiy","followers_url":"https://api.github.com/users/OrestHurskiy/followers","following_url":"https://api.github.com/users/OrestHurskiy/following{/other_user}","gists_url":"https://api.github.com/users/OrestHurskiy/gists{/gist_id}","starred_url":"https://api.github.com/users/OrestHurskiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrestHurskiy/subscriptions","organizations_url":"https://api.github.com/users/OrestHurskiy/orgs","repos_url":"https://api.github.com/users/OrestHurskiy/repos","events_url":"https://api.github.com/users/OrestHurskiy/events{/privacy}","received_events_url":"https://api.github.com/users/OrestHurskiy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OrestHurskiy/CalenderApp","description":"Booking meeting rooms","fork":false,"url":"https://api.github.com/repos/OrestHurskiy/CalenderApp","forks_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/forks","keys_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/teams","hooks_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/hooks","issue_events_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/issues/events{/number}","events_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/events","assignees_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/assignees{/user}","branches_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/branches{/branch}","tags_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/tags","blobs_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/statuses/{sha}","languages_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/languages","stargazers_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/stargazers","contributors_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/contributors","subscribers_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/subscribers","subscription_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/subscription","commits_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/contents/{+path}","compare_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/merges","archive_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/downloads","issues_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/issues{/number}","pulls_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/pulls{/number}","milestones_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/milestones{/number}","notifications_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/labels{/name}","releases_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/releases{/id}","created_at":"2015-09-22T13:06:53Z","updated_at":"2015-09-25T07:43:48Z","pushed_at":"2015-10-06T21:43:09Z","git_url":"git://github.com/OrestHurskiy/CalenderApp.git","ssh_url":"git@github.com:OrestHurskiy/CalenderApp.git","clone_url":"https://github.com/OrestHurskiy/CalenderApp.git","svn_url":"https://github.com/OrestHurskiy/CalenderApp","homepage":null,"size":12772,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"OrestHurskiy:dev","ref":"dev","sha":"e86a7994e538116f00ee938a7b11dc082d66fb61","user":{"login":"OrestHurskiy","id":11854706,"avatar_url":"https://avatars.githubusercontent.com/u/11854706?v=3","gravatar_id":"","url":"https://api.github.com/users/OrestHurskiy","html_url":"https://github.com/OrestHurskiy","followers_url":"https://api.github.com/users/OrestHurskiy/followers","following_url":"https://api.github.com/users/OrestHurskiy/following{/other_user}","gists_url":"https://api.github.com/users/OrestHurskiy/gists{/gist_id}","starred_url":"https://api.github.com/users/OrestHurskiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrestHurskiy/subscriptions","organizations_url":"https://api.github.com/users/OrestHurskiy/orgs","repos_url":"https://api.github.com/users/OrestHurskiy/repos","events_url":"https://api.github.com/users/OrestHurskiy/events{/privacy}","received_events_url":"https://api.github.com/users/OrestHurskiy/received_events","type":"User","site_admin":false},"repo":{"id":42934225,"name":"CalenderApp","full_name":"OrestHurskiy/CalenderApp","owner":{"login":"OrestHurskiy","id":11854706,"avatar_url":"https://avatars.githubusercontent.com/u/11854706?v=3","gravatar_id":"","url":"https://api.github.com/users/OrestHurskiy","html_url":"https://github.com/OrestHurskiy","followers_url":"https://api.github.com/users/OrestHurskiy/followers","following_url":"https://api.github.com/users/OrestHurskiy/following{/other_user}","gists_url":"https://api.github.com/users/OrestHurskiy/gists{/gist_id}","starred_url":"https://api.github.com/users/OrestHurskiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrestHurskiy/subscriptions","organizations_url":"https://api.github.com/users/OrestHurskiy/orgs","repos_url":"https://api.github.com/users/OrestHurskiy/repos","events_url":"https://api.github.com/users/OrestHurskiy/events{/privacy}","received_events_url":"https://api.github.com/users/OrestHurskiy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OrestHurskiy/CalenderApp","description":"Booking meeting rooms","fork":false,"url":"https://api.github.com/repos/OrestHurskiy/CalenderApp","forks_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/forks","keys_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/teams","hooks_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/hooks","issue_events_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/issues/events{/number}","events_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/events","assignees_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/assignees{/user}","branches_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/branches{/branch}","tags_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/tags","blobs_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/statuses/{sha}","languages_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/languages","stargazers_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/stargazers","contributors_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/contributors","subscribers_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/subscribers","subscription_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/subscription","commits_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/contents/{+path}","compare_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/merges","archive_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/downloads","issues_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/issues{/number}","pulls_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/pulls{/number}","milestones_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/milestones{/number}","notifications_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/labels{/name}","releases_url":"https://api.github.com/repos/OrestHurskiy/CalenderApp/releases{/id}","created_at":"2015-09-22T13:06:53Z","updated_at":"2015-09-25T07:43:48Z","pushed_at":"2015-10-06T21:43:09Z","git_url":"git://github.com/OrestHurskiy/CalenderApp.git","ssh_url":"git@github.com:OrestHurskiy/CalenderApp.git","clone_url":"https://github.com/OrestHurskiy/CalenderApp.git","svn_url":"https://github.com/OrestHurskiy/CalenderApp","homepage":null,"size":12772,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OrestHurskiy/CalenderApp/pulls/7"},"html":{"href":"https://github.com/OrestHurskiy/CalenderApp/pull/7"},"issue":{"href":"https://api.github.com/repos/OrestHurskiy/CalenderApp/issues/7"},"comments":{"href":"https://api.github.com/repos/OrestHurskiy/CalenderApp/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/OrestHurskiy/CalenderApp/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/OrestHurskiy/CalenderApp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OrestHurskiy/CalenderApp/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/OrestHurskiy/CalenderApp/statuses/2ed823810c5778b5957901bcf84ff336c4428b2f"}}}}