{"action":"created","issue":{"url":"https://api.github.com/repos/salvadore-jefferson/beat_box/issues/7","labels_url":"https://api.github.com/repos/salvadore-jefferson/beat_box/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/salvadore-jefferson/beat_box/issues/7/comments","events_url":"https://api.github.com/repos/salvadore-jefferson/beat_box/issues/7/events","html_url":"https://github.com/salvadore-jefferson/beat_box/pull/7","id":95914452,"number":7,"title":"#6 Add preconditions and JSR-305 annotations to Instrument class","user":{"login":"salvadore-jefferson","id":13281866,"avatar_url":"https://avatars.githubusercontent.com/u/13281866?v=3","gravatar_id":"","url":"https://api.github.com/users/salvadore-jefferson","html_url":"https://github.com/salvadore-jefferson","followers_url":"https://api.github.com/users/salvadore-jefferson/followers","following_url":"https://api.github.com/users/salvadore-jefferson/following{/other_user}","gists_url":"https://api.github.com/users/salvadore-jefferson/gists{/gist_id}","starred_url":"https://api.github.com/users/salvadore-jefferson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salvadore-jefferson/subscriptions","organizations_url":"https://api.github.com/users/salvadore-jefferson/orgs","repos_url":"https://api.github.com/users/salvadore-jefferson/repos","events_url":"https://api.github.com/users/salvadore-jefferson/events{/privacy}","received_events_url":"https://api.github.com/users/salvadore-jefferson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-19T13:05:37Z","updated_at":"2015-07-19T18:31:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/salvadore-jefferson/beat_box/pulls/7","html_url":"https://github.com/salvadore-jefferson/beat_box/pull/7","diff_url":"https://github.com/salvadore-jefferson/beat_box/pull/7.diff","patch_url":"https://github.com/salvadore-jefferson/beat_box/pull/7.patch"},"body":" \r\nNew import statements to Instrument.java:\r\n *import static com.google.common.base.Preconditions.checkNotNull;\r\n *import javax.annotation.Nonnull;\r\n *import javax.annotation.Nullable;\r\n\r\nRefactoring:\r\n *Changed instrumentNumber to instrumentKey\r\n *Changed String name to final String instrumentName\r\n *Changed int number to final int instrumentKey\r\n *Changed getNumber() to get Key()\r\n\r\n*Added javadoc comments to the Instrument constructor\r\n*Added JSR-305 annotations to the Instrument constructor\r\n*Added preconditions to the Instrument constructor\r\n\r\n*Added Google Guava dependency to the POM\r\n\r\n*Ran a test with “null” as the Instrument name. The application failed\r\nto compile and printed out my custom error message for that\r\nprecondition.\r\n\r\nNote: This seems to be working, but I am not 100% convinced that it is\r\nexactly the right way I should be doing this."},"comment":{"url":"https://api.github.com/repos/salvadore-jefferson/beat_box/issues/comments/122691678","html_url":"https://github.com/salvadore-jefferson/beat_box/pull/7#issuecomment-122691678","issue_url":"https://api.github.com/repos/salvadore-jefferson/beat_box/issues/7","id":122691678,"user":{"login":"salvadore-jefferson","id":13281866,"avatar_url":"https://avatars.githubusercontent.com/u/13281866?v=3","gravatar_id":"","url":"https://api.github.com/users/salvadore-jefferson","html_url":"https://github.com/salvadore-jefferson","followers_url":"https://api.github.com/users/salvadore-jefferson/followers","following_url":"https://api.github.com/users/salvadore-jefferson/following{/other_user}","gists_url":"https://api.github.com/users/salvadore-jefferson/gists{/gist_id}","starred_url":"https://api.github.com/users/salvadore-jefferson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salvadore-jefferson/subscriptions","organizations_url":"https://api.github.com/users/salvadore-jefferson/orgs","repos_url":"https://api.github.com/users/salvadore-jefferson/repos","events_url":"https://api.github.com/users/salvadore-jefferson/events{/privacy}","received_events_url":"https://api.github.com/users/salvadore-jefferson/received_events","type":"User","site_admin":false},"created_at":"2015-07-19T18:31:23Z","updated_at":"2015-07-19T18:31:23Z","body":"Yes it compiles. I downloaded the Google Guava jar file form here\r\nhttps://code.google.com/p/guava-libraries/\r\nAnd added it to the build path. Everything seems to be working, but like I said, I am not sure if I have it all configured in the best possible way."}}