{"action":"created","issue":{"url":"https://api.github.com/repos/gregorio-project/gregorio/issues/211","labels_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/211/labels{/name}","comments_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/211/comments","events_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/211/events","html_url":"https://github.com/gregorio-project/gregorio/pull/211","id":65609608,"number":211,"title":"Refactor - Phase III (?)","user":{"login":"henryso","id":421318,"avatar_url":"https://avatars.githubusercontent.com/u/421318?v=3","gravatar_id":"","url":"https://api.github.com/users/henryso","html_url":"https://github.com/henryso","followers_url":"https://api.github.com/users/henryso/followers","following_url":"https://api.github.com/users/henryso/following{/other_user}","gists_url":"https://api.github.com/users/henryso/gists{/gist_id}","starred_url":"https://api.github.com/users/henryso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryso/subscriptions","organizations_url":"https://api.github.com/users/henryso/orgs","repos_url":"https://api.github.com/users/henryso/repos","events_url":"https://api.github.com/users/henryso/events{/privacy}","received_events_url":"https://api.github.com/users/henryso/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-01T05:38:02Z","updated_at":"2015-04-01T07:36:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/211","html_url":"https://github.com/gregorio-project/gregorio/pull/211","diff_url":"https://github.com/gregorio-project/gregorio/pull/211.diff","patch_url":"https://github.com/gregorio-project/gregorio/pull/211.patch"},"body":"Please review these changes.  I have converted the remaining enum-like defines to enums and put unions into the structures to reduce multi-purpose fields.  This was a fairly messy refactor, so I'm expecting bugs, but it does seem to work against my battery of tests.  gabc->gabc has not been tested extensively (do we still need that functionality?).\r\n\r\nPlease don't merge this until we've had time to discuss."},"comment":{"url":"https://api.github.com/repos/gregorio-project/gregorio/issues/comments/88379900","html_url":"https://github.com/gregorio-project/gregorio/pull/211#issuecomment-88379900","issue_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/211","id":88379900,"user":{"login":"eroux","id":60868,"avatar_url":"https://avatars.githubusercontent.com/u/60868?v=3","gravatar_id":"","url":"https://api.github.com/users/eroux","html_url":"https://github.com/eroux","followers_url":"https://api.github.com/users/eroux/followers","following_url":"https://api.github.com/users/eroux/following{/other_user}","gists_url":"https://api.github.com/users/eroux/gists{/gist_id}","starred_url":"https://api.github.com/users/eroux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eroux/subscriptions","organizations_url":"https://api.github.com/users/eroux/orgs","repos_url":"https://api.github.com/users/eroux/repos","events_url":"https://api.github.com/users/eroux/events{/privacy}","received_events_url":"https://api.github.com/users/eroux/received_events","type":"User","site_admin":false},"created_at":"2015-04-01T07:36:06Z","updated_at":"2015-04-01T07:36:06Z","body":"Wow, that's a lot of great work! I was actually thinking about something more hackish but more simple, just using a basic union between \"something not a note\" and a note, just as something temporary for gabc to use before it can build the structure (that wouldn't have changed). But this is really a step further! I like it, I just need to review and test it more carefully, but I think it goes in a cleaner direction, which seems good! I'll let you know when I'll have more time to review (tonight Paris time certainly)"}}