{"action":"closed","issue":{"url":"https://api.github.com/repos/sigmavirus24/github3.py/issues/487","labels_url":"https://api.github.com/repos/sigmavirus24/github3.py/issues/487/labels{/name}","comments_url":"https://api.github.com/repos/sigmavirus24/github3.py/issues/487/comments","events_url":"https://api.github.com/repos/sigmavirus24/github3.py/issues/487/events","html_url":"https://github.com/sigmavirus24/github3.py/issues/487","id":117860494,"number":487,"title":"Migrate in line JSON data in tests/unit","user":{"login":"itsmemattchung","id":7358102,"avatar_url":"https://avatars.githubusercontent.com/u/7358102?v=3","gravatar_id":"","url":"https://api.github.com/users/itsmemattchung","html_url":"https://github.com/itsmemattchung","followers_url":"https://api.github.com/users/itsmemattchung/followers","following_url":"https://api.github.com/users/itsmemattchung/following{/other_user}","gists_url":"https://api.github.com/users/itsmemattchung/gists{/gist_id}","starred_url":"https://api.github.com/users/itsmemattchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itsmemattchung/subscriptions","organizations_url":"https://api.github.com/users/itsmemattchung/orgs","repos_url":"https://api.github.com/users/itsmemattchung/repos","events_url":"https://api.github.com/users/itsmemattchung/events{/privacy}","received_events_url":"https://api.github.com/users/itsmemattchung/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-19T17:11:21Z","updated_at":"2015-12-07T22:36:27Z","closed_at":"2015-12-07T22:36:27Z","body":"Here's the initial thread:\r\nhttps://github.com/sigmavirus24/github3.py/pull/482#issuecomment-158074071\r\n\r\nSome of the unit tests have in line example data instead of a separate JSON file: https://github.com/sigmavirus24/github3.py/blob/develop/tests/unit/test_orgs.py#L13-L30 \r\n\r\nThis should be updated to something like:\r\nhttps://github.com/sigmavirus24/github3.py/blob/develop/tests/unit/test_notifications.py#L5-L8\r\n\r\n## Before\r\n```Javascript\r\n    example_data = {\r\n        'login': 'hapy',\r\n        'id': 1,\r\n        'url': 'https://api.github.com/orgs/hapy',\r\n        'avatar_url': 'https://github.com/images/error/octocat_happy.gif',\r\n        'name': 'github',\r\n        'company': 'GitHub',\r\n        'blog': 'https://github.com/blog',\r\n        'location': 'San Francisco',\r\n        'email': 'octocat@github.com',\r\n        'public_repos': 2,\r\n        'public_gists': 1,\r\n        'followers': 20,\r\n        'following': 0,\r\n        'html_url': 'https://github.com/hapy',\r\n        'created_at': '2008-01-14T04:33:35Z',\r\n        'type': 'Organization'\r\n    }\r\n```\r\n\r\n## Should be\r\n```python\r\nget_example_data = create_example_data_helper('organization_example')\r\n```"}}