{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/793","labels_url":"https://api.github.com/repos/facebook/react-native/issues/793/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/793/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/793/events","html_url":"https://github.com/facebook/react-native/issues/793","id":67551446,"number":793,"title":"Native Module Docs need to be updated for RCT_EXPORT_MODULE","user":{"login":"colinramsay","id":72954,"avatar_url":"https://avatars.githubusercontent.com/u/72954?v=3","gravatar_id":"","url":"https://api.github.com/users/colinramsay","html_url":"https://github.com/colinramsay","followers_url":"https://api.github.com/users/colinramsay/followers","following_url":"https://api.github.com/users/colinramsay/following{/other_user}","gists_url":"https://api.github.com/users/colinramsay/gists{/gist_id}","starred_url":"https://api.github.com/users/colinramsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinramsay/subscriptions","organizations_url":"https://api.github.com/users/colinramsay/orgs","repos_url":"https://api.github.com/users/colinramsay/repos","events_url":"https://api.github.com/users/colinramsay/events{/privacy}","received_events_url":"https://api.github.com/users/colinramsay/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-04-10T09:27:17Z","updated_at":"2015-04-11T08:07:37Z","closed_at":null,"body":"Previously we'd use RCT_EXPORT but it seems that there's been a change (9th Apr) that means we need to use RCT_EXPORT_MODULE on the class and RCT_EXPORT_METHOD for each method to be exported. The docs don't yet reflect this. It also raises two points:\r\n\r\n- What's the policy for informing the community of breaking changes synced from FB?\r\n- Should changes be synced without associated documentation?"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/91793758","html_url":"https://github.com/facebook/react-native/issues/793#issuecomment-91793758","issue_url":"https://api.github.com/repos/facebook/react-native/issues/793","id":91793758,"user":{"login":"nicklockwood","id":546885,"avatar_url":"https://avatars.githubusercontent.com/u/546885?v=3","gravatar_id":"","url":"https://api.github.com/users/nicklockwood","html_url":"https://github.com/nicklockwood","followers_url":"https://api.github.com/users/nicklockwood/followers","following_url":"https://api.github.com/users/nicklockwood/following{/other_user}","gists_url":"https://api.github.com/users/nicklockwood/gists{/gist_id}","starred_url":"https://api.github.com/users/nicklockwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicklockwood/subscriptions","organizations_url":"https://api.github.com/users/nicklockwood/orgs","repos_url":"https://api.github.com/users/nicklockwood/repos","events_url":"https://api.github.com/users/nicklockwood/events{/privacy}","received_events_url":"https://api.github.com/users/nicklockwood/received_events","type":"User","site_admin":false},"created_at":"2015-04-11T08:07:37Z","updated_at":"2015-04-11T08:07:37Z","body":"@lwansbrough I understand that this is frustrating, and we'll try to do better, particularly with the docs updates.\r\n\r\nRelease notes are problematic due to the way that fixes are landed internally and then pushed to github in batches. Again, we're actively working to improve that process.\r\n\r\nI would like to reassure you that there is some method to the madness though. We're aware that breaking changes are painful, and we'll do our best to a) avoid making them, and b) when we do make them, ensure that we break things in an *obvious* way, rather than having things silently fail.\r\n\r\nFor example, in the change to module registration, we left the class scanning feature enabled in debug mode, purely so we could detect modules that have not yet been converted, and provide a useful error message.\r\n\r\nSimilarly, for the RCT_EXPORT -> RCT_EXPORT_METHOD change, we've left in full support for the old system so that you can make the upgrades at your convenience instead of immediately breaking the apps.\r\n\r\nI'm pretty happy with the technical approach we've taken here, but we'll try to improve on the communication and documentation side too."}}