{"action":"created","comment":{"url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/pulls/comments/48449758","id":48449758,"diff_hunk":"@@ -47,25 +62,15 @@ public function create(DocumentGroupDefinitionInterface $definition)\n             throw new InvalidArgumentException('Definition must be an instance of ' . DocumentGroupDefinition::class);\n         }\n \n-        // TODO: move this to a custom factory so that we can inject the factory in this class and then have the\n-        // middleware as dependency of that factory.\n+        $strategies = $this->stategies;\n+        $strategies[] = new File(","path":"src/phpDocumentor/ApiReference/Factory.php","position":49,"original_position":49,"commit_id":"13ac21d418024aa30db294a8de8b50ab85f21a39","original_commit_id":"13ac21d418024aa30db294a8de8b50ab85f21a39","user":{"login":"mvriel","id":193704,"avatar_url":"https://avatars.githubusercontent.com/u/193704?v=3","gravatar_id":"","url":"https://api.github.com/users/mvriel","html_url":"https://github.com/mvriel","followers_url":"https://api.github.com/users/mvriel/followers","following_url":"https://api.github.com/users/mvriel/following{/other_user}","gists_url":"https://api.github.com/users/mvriel/gists{/gist_id}","starred_url":"https://api.github.com/users/mvriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvriel/subscriptions","organizations_url":"https://api.github.com/users/mvriel/orgs","repos_url":"https://api.github.com/users/mvriel/repos","events_url":"https://api.github.com/users/mvriel/events{/privacy}","received_events_url":"https://api.github.com/users/mvriel/received_events","type":"User","site_admin":false},"body":"Using such a factory will also remove the need for injecting the middleware into this class; and that will improve the SRP part of this class","created_at":"2015-12-26T20:50:30Z","updated_at":"2015-12-26T20:50:30Z","html_url":"https://github.com/phpDocumentor/phpDocumentor2/pull/1673#discussion_r48449758","pull_request_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/pulls/1673","_links":{"self":{"href":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/pulls/comments/48449758"},"html":{"href":"https://github.com/phpDocumentor/phpDocumentor2/pull/1673#discussion_r48449758"},"pull_request":{"href":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/pulls/1673"}}},"pull_request":{"url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/pulls/1673","id":49484734,"html_url":"https://github.com/phpDocumentor/phpDocumentor2/pull/1673","diff_url":"https://github.com/phpDocumentor/phpDocumentor2/pull/1673.diff","patch_url":"https://github.com/phpDocumentor/phpDocumentor2/pull/1673.patch","issue_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/issues/1673","number":1673,"state":"open","locked":false,"title":"Feature/api factory cache","user":{"login":"jaapio","id":1060433,"avatar_url":"https://avatars.githubusercontent.com/u/1060433?v=3","gravatar_id":"","url":"https://api.github.com/users/jaapio","html_url":"https://github.com/jaapio","followers_url":"https://api.github.com/users/jaapio/followers","following_url":"https://api.github.com/users/jaapio/following{/other_user}","gists_url":"https://api.github.com/users/jaapio/gists{/gist_id}","starred_url":"https://api.github.com/users/jaapio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaapio/subscriptions","organizations_url":"https://api.github.com/users/jaapio/orgs","repos_url":"https://api.github.com/users/jaapio/repos","events_url":"https://api.github.com/users/jaapio/events{/privacy}","received_events_url":"https://api.github.com/users/jaapio/received_events","type":"User","site_admin":false},"body":"This pr adds cache middleware to the project factory. Which allows partial processing","created_at":"2015-11-02T20:59:58Z","updated_at":"2015-12-26T20:50:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"803f2b23947a162675949168724dec84ff3961f7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/pulls/1673/commits","review_comments_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/pulls/1673/comments","review_comment_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/issues/1673/comments","statuses_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/statuses/13ac21d418024aa30db294a8de8b50ab85f21a39","head":{"label":"jaapio:feature/apiFactoryCache","ref":"feature/apiFactoryCache","sha":"13ac21d418024aa30db294a8de8b50ab85f21a39","user":{"login":"jaapio","id":1060433,"avatar_url":"https://avatars.githubusercontent.com/u/1060433?v=3","gravatar_id":"","url":"https://api.github.com/users/jaapio","html_url":"https://github.com/jaapio","followers_url":"https://api.github.com/users/jaapio/followers","following_url":"https://api.github.com/users/jaapio/following{/other_user}","gists_url":"https://api.github.com/users/jaapio/gists{/gist_id}","starred_url":"https://api.github.com/users/jaapio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaapio/subscriptions","organizations_url":"https://api.github.com/users/jaapio/orgs","repos_url":"https://api.github.com/users/jaapio/repos","events_url":"https://api.github.com/users/jaapio/events{/privacy}","received_events_url":"https://api.github.com/users/jaapio/received_events","type":"User","site_admin":false},"repo":{"id":22478402,"name":"phpDocumentor2","full_name":"jaapio/phpDocumentor2","owner":{"login":"jaapio","id":1060433,"avatar_url":"https://avatars.githubusercontent.com/u/1060433?v=3","gravatar_id":"","url":"https://api.github.com/users/jaapio","html_url":"https://github.com/jaapio","followers_url":"https://api.github.com/users/jaapio/followers","following_url":"https://api.github.com/users/jaapio/following{/other_user}","gists_url":"https://api.github.com/users/jaapio/gists{/gist_id}","starred_url":"https://api.github.com/users/jaapio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaapio/subscriptions","organizations_url":"https://api.github.com/users/jaapio/orgs","repos_url":"https://api.github.com/users/jaapio/repos","events_url":"https://api.github.com/users/jaapio/events{/privacy}","received_events_url":"https://api.github.com/users/jaapio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaapio/phpDocumentor2","description":"Documentation Generator for PHP ","fork":true,"url":"https://api.github.com/repos/jaapio/phpDocumentor2","forks_url":"https://api.github.com/repos/jaapio/phpDocumentor2/forks","keys_url":"https://api.github.com/repos/jaapio/phpDocumentor2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaapio/phpDocumentor2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaapio/phpDocumentor2/teams","hooks_url":"https://api.github.com/repos/jaapio/phpDocumentor2/hooks","issue_events_url":"https://api.github.com/repos/jaapio/phpDocumentor2/issues/events{/number}","events_url":"https://api.github.com/repos/jaapio/phpDocumentor2/events","assignees_url":"https://api.github.com/repos/jaapio/phpDocumentor2/assignees{/user}","branches_url":"https://api.github.com/repos/jaapio/phpDocumentor2/branches{/branch}","tags_url":"https://api.github.com/repos/jaapio/phpDocumentor2/tags","blobs_url":"https://api.github.com/repos/jaapio/phpDocumentor2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaapio/phpDocumentor2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaapio/phpDocumentor2/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaapio/phpDocumentor2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaapio/phpDocumentor2/statuses/{sha}","languages_url":"https://api.github.com/repos/jaapio/phpDocumentor2/languages","stargazers_url":"https://api.github.com/repos/jaapio/phpDocumentor2/stargazers","contributors_url":"https://api.github.com/repos/jaapio/phpDocumentor2/contributors","subscribers_url":"https://api.github.com/repos/jaapio/phpDocumentor2/subscribers","subscription_url":"https://api.github.com/repos/jaapio/phpDocumentor2/subscription","commits_url":"https://api.github.com/repos/jaapio/phpDocumentor2/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaapio/phpDocumentor2/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaapio/phpDocumentor2/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaapio/phpDocumentor2/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaapio/phpDocumentor2/contents/{+path}","compare_url":"https://api.github.com/repos/jaapio/phpDocumentor2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaapio/phpDocumentor2/merges","archive_url":"https://api.github.com/repos/jaapio/phpDocumentor2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaapio/phpDocumentor2/downloads","issues_url":"https://api.github.com/repos/jaapio/phpDocumentor2/issues{/number}","pulls_url":"https://api.github.com/repos/jaapio/phpDocumentor2/pulls{/number}","milestones_url":"https://api.github.com/repos/jaapio/phpDocumentor2/milestones{/number}","notifications_url":"https://api.github.com/repos/jaapio/phpDocumentor2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaapio/phpDocumentor2/labels{/name}","releases_url":"https://api.github.com/repos/jaapio/phpDocumentor2/releases{/id}","created_at":"2014-07-31T17:30:57Z","updated_at":"2015-05-08T19:31:18Z","pushed_at":"2015-12-26T13:33:48Z","git_url":"git://github.com/jaapio/phpDocumentor2.git","ssh_url":"git@github.com:jaapio/phpDocumentor2.git","clone_url":"https://github.com/jaapio/phpDocumentor2.git","svn_url":"https://github.com/jaapio/phpDocumentor2","homepage":"http://www.phpdoc.org","size":27408,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"phpDocumentor:develop","ref":"develop","sha":"da4567a658766df13184670fd0ccf59df51c220a","user":{"login":"phpDocumentor","id":1239567,"avatar_url":"https://avatars.githubusercontent.com/u/1239567?v=3","gravatar_id":"","url":"https://api.github.com/users/phpDocumentor","html_url":"https://github.com/phpDocumentor","followers_url":"https://api.github.com/users/phpDocumentor/followers","following_url":"https://api.github.com/users/phpDocumentor/following{/other_user}","gists_url":"https://api.github.com/users/phpDocumentor/gists{/gist_id}","starred_url":"https://api.github.com/users/phpDocumentor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpDocumentor/subscriptions","organizations_url":"https://api.github.com/users/phpDocumentor/orgs","repos_url":"https://api.github.com/users/phpDocumentor/repos","events_url":"https://api.github.com/users/phpDocumentor/events{/privacy}","received_events_url":"https://api.github.com/users/phpDocumentor/received_events","type":"Organization","site_admin":false},"repo":{"id":761653,"name":"phpDocumentor2","full_name":"phpDocumentor/phpDocumentor2","owner":{"login":"phpDocumentor","id":1239567,"avatar_url":"https://avatars.githubusercontent.com/u/1239567?v=3","gravatar_id":"","url":"https://api.github.com/users/phpDocumentor","html_url":"https://github.com/phpDocumentor","followers_url":"https://api.github.com/users/phpDocumentor/followers","following_url":"https://api.github.com/users/phpDocumentor/following{/other_user}","gists_url":"https://api.github.com/users/phpDocumentor/gists{/gist_id}","starred_url":"https://api.github.com/users/phpDocumentor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpDocumentor/subscriptions","organizations_url":"https://api.github.com/users/phpDocumentor/orgs","repos_url":"https://api.github.com/users/phpDocumentor/repos","events_url":"https://api.github.com/users/phpDocumentor/events{/privacy}","received_events_url":"https://api.github.com/users/phpDocumentor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpDocumentor/phpDocumentor2","description":"Documentation Generator for PHP ","fork":false,"url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2","forks_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/forks","keys_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/teams","hooks_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/hooks","issue_events_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/issues/events{/number}","events_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/events","assignees_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/assignees{/user}","branches_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/branches{/branch}","tags_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/tags","blobs_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/statuses/{sha}","languages_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/languages","stargazers_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/stargazers","contributors_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/contributors","subscribers_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/subscribers","subscription_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/subscription","commits_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/contents/{+path}","compare_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/merges","archive_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/downloads","issues_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/issues{/number}","pulls_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/pulls{/number}","milestones_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/milestones{/number}","notifications_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/labels{/name}","releases_url":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/releases{/id}","created_at":"2010-07-07T12:07:55Z","updated_at":"2015-12-26T18:44:46Z","pushed_at":"2015-12-26T13:33:48Z","git_url":"git://github.com/phpDocumentor/phpDocumentor2.git","ssh_url":"git@github.com:phpDocumentor/phpDocumentor2.git","clone_url":"https://github.com/phpDocumentor/phpDocumentor2.git","svn_url":"https://github.com/phpDocumentor/phpDocumentor2","homepage":"http://www.phpdoc.org","size":31114,"stargazers_count":1595,"watchers_count":1595,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":436,"mirror_url":null,"open_issues_count":254,"forks":436,"open_issues":254,"watchers":1595,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/pulls/1673"},"html":{"href":"https://github.com/phpDocumentor/phpDocumentor2/pull/1673"},"issue":{"href":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/issues/1673"},"comments":{"href":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/issues/1673/comments"},"review_comments":{"href":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/pulls/1673/comments"},"review_comment":{"href":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/pulls/1673/commits"},"statuses":{"href":"https://api.github.com/repos/phpDocumentor/phpDocumentor2/statuses/13ac21d418024aa30db294a8de8b50ab85f21a39"}}}}