{"action":"created","comment":{"url":"https://api.github.com/repos/sorentwo/readthis/pulls/comments/25926120","id":25926120,"diff_hunk":"@@ -192,6 +197,11 @@\n       expect(cache.read('b')).to be_nil\n       expect(cache.read('b', namespace: 'alph')).not_to be_nil\n     end\n+\n+    it 'return empty results without keys' do\n+      results = cache.fetch_multi(namespace: 'alph') { |key| key }","path":"spec/readthis/cache_spec.rb","position":18,"original_position":18,"commit_id":"820f8e47907e3cb79e2b855dfa859914adb2e0f5","original_commit_id":"820f8e47907e3cb79e2b855dfa859914adb2e0f5","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2015-03-06T05:09:02Z","updated_at":"2015-03-06T05:09:02Z","html_url":"https://github.com/sorentwo/readthis/pull/3#discussion_r25926120","pull_request_url":"https://api.github.com/repos/sorentwo/readthis/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/sorentwo/readthis/pulls/comments/25926120"},"html":{"href":"https://github.com/sorentwo/readthis/pull/3#discussion_r25926120"},"pull_request":{"href":"https://api.github.com/repos/sorentwo/readthis/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/sorentwo/readthis/pulls/3","id":30621372,"html_url":"https://github.com/sorentwo/readthis/pull/3","diff_url":"https://github.com/sorentwo/readthis/pull/3.diff","patch_url":"https://github.com/sorentwo/readthis/pull/3.patch","issue_url":"https://api.github.com/repos/sorentwo/readthis/issues/3","number":3,"state":"open","locked":false,"title":"Handle read_multi and fetch_multi with no keys","user":{"login":"rykov","id":35549,"avatar_url":"https://avatars.githubusercontent.com/u/35549?v=3","gravatar_id":"","url":"https://api.github.com/users/rykov","html_url":"https://github.com/rykov","followers_url":"https://api.github.com/users/rykov/followers","following_url":"https://api.github.com/users/rykov/following{/other_user}","gists_url":"https://api.github.com/users/rykov/gists{/gist_id}","starred_url":"https://api.github.com/users/rykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rykov/subscriptions","organizations_url":"https://api.github.com/users/rykov/orgs","repos_url":"https://api.github.com/users/rykov/repos","events_url":"https://api.github.com/users/rykov/events{/privacy}","received_events_url":"https://api.github.com/users/rykov/received_events","type":"User","site_admin":false},"body":"In instances when `read_multi` or `fetch_mutli` are called no keys, Redis throws this error:\r\n\r\n    ERR wrong number of arguments for 'mget' command\r\n\r\nThis PR is to handle this case gracefully following the behavior of `ActiveSupport::Cache::FileStore`.  Both added tests include a `namespace` option to make sure the empty check happens after `extract_options!`","created_at":"2015-03-06T05:08:55Z","updated_at":"2015-03-06T05:09:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7379b7b5d7245b5017985d02bcaf10e7d276153e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sorentwo/readthis/pulls/3/commits","review_comments_url":"https://api.github.com/repos/sorentwo/readthis/pulls/3/comments","review_comment_url":"https://api.github.com/repos/sorentwo/readthis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sorentwo/readthis/issues/3/comments","statuses_url":"https://api.github.com/repos/sorentwo/readthis/statuses/820f8e47907e3cb79e2b855dfa859914adb2e0f5","head":{"label":"rykov:empty-keys-1","ref":"empty-keys-1","sha":"820f8e47907e3cb79e2b855dfa859914adb2e0f5","user":{"login":"rykov","id":35549,"avatar_url":"https://avatars.githubusercontent.com/u/35549?v=3","gravatar_id":"","url":"https://api.github.com/users/rykov","html_url":"https://github.com/rykov","followers_url":"https://api.github.com/users/rykov/followers","following_url":"https://api.github.com/users/rykov/following{/other_user}","gists_url":"https://api.github.com/users/rykov/gists{/gist_id}","starred_url":"https://api.github.com/users/rykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rykov/subscriptions","organizations_url":"https://api.github.com/users/rykov/orgs","repos_url":"https://api.github.com/users/rykov/repos","events_url":"https://api.github.com/users/rykov/events{/privacy}","received_events_url":"https://api.github.com/users/rykov/received_events","type":"User","site_admin":false},"repo":{"id":31753227,"name":"readthis","full_name":"rykov/readthis","owner":{"login":"rykov","id":35549,"avatar_url":"https://avatars.githubusercontent.com/u/35549?v=3","gravatar_id":"","url":"https://api.github.com/users/rykov","html_url":"https://github.com/rykov","followers_url":"https://api.github.com/users/rykov/followers","following_url":"https://api.github.com/users/rykov/following{/other_user}","gists_url":"https://api.github.com/users/rykov/gists{/gist_id}","starred_url":"https://api.github.com/users/rykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rykov/subscriptions","organizations_url":"https://api.github.com/users/rykov/orgs","repos_url":"https://api.github.com/users/rykov/repos","events_url":"https://api.github.com/users/rykov/events{/privacy}","received_events_url":"https://api.github.com/users/rykov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rykov/readthis","description":"Pooled active support compliant caching with redis","fork":true,"url":"https://api.github.com/repos/rykov/readthis","forks_url":"https://api.github.com/repos/rykov/readthis/forks","keys_url":"https://api.github.com/repos/rykov/readthis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rykov/readthis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rykov/readthis/teams","hooks_url":"https://api.github.com/repos/rykov/readthis/hooks","issue_events_url":"https://api.github.com/repos/rykov/readthis/issues/events{/number}","events_url":"https://api.github.com/repos/rykov/readthis/events","assignees_url":"https://api.github.com/repos/rykov/readthis/assignees{/user}","branches_url":"https://api.github.com/repos/rykov/readthis/branches{/branch}","tags_url":"https://api.github.com/repos/rykov/readthis/tags","blobs_url":"https://api.github.com/repos/rykov/readthis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rykov/readthis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rykov/readthis/git/refs{/sha}","trees_url":"https://api.github.com/repos/rykov/readthis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rykov/readthis/statuses/{sha}","languages_url":"https://api.github.com/repos/rykov/readthis/languages","stargazers_url":"https://api.github.com/repos/rykov/readthis/stargazers","contributors_url":"https://api.github.com/repos/rykov/readthis/contributors","subscribers_url":"https://api.github.com/repos/rykov/readthis/subscribers","subscription_url":"https://api.github.com/repos/rykov/readthis/subscription","commits_url":"https://api.github.com/repos/rykov/readthis/commits{/sha}","git_commits_url":"https://api.github.com/repos/rykov/readthis/git/commits{/sha}","comments_url":"https://api.github.com/repos/rykov/readthis/comments{/number}","issue_comment_url":"https://api.github.com/repos/rykov/readthis/issues/comments{/number}","contents_url":"https://api.github.com/repos/rykov/readthis/contents/{+path}","compare_url":"https://api.github.com/repos/rykov/readthis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rykov/readthis/merges","archive_url":"https://api.github.com/repos/rykov/readthis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rykov/readthis/downloads","issues_url":"https://api.github.com/repos/rykov/readthis/issues{/number}","pulls_url":"https://api.github.com/repos/rykov/readthis/pulls{/number}","milestones_url":"https://api.github.com/repos/rykov/readthis/milestones{/number}","notifications_url":"https://api.github.com/repos/rykov/readthis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rykov/readthis/labels{/name}","releases_url":"https://api.github.com/repos/rykov/readthis/releases{/id}","created_at":"2015-03-06T04:53:42Z","updated_at":"2015-03-06T04:53:42Z","pushed_at":"2015-03-06T05:02:41Z","git_url":"git://github.com/rykov/readthis.git","ssh_url":"git@github.com:rykov/readthis.git","clone_url":"https://github.com/rykov/readthis.git","svn_url":"https://github.com/rykov/readthis","homepage":null,"size":143,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sorentwo:master","ref":"master","sha":"7c79870a76d9d448dc907ef015cfbf9a5ff2c25b","user":{"login":"sorentwo","id":270831,"avatar_url":"https://avatars.githubusercontent.com/u/270831?v=3","gravatar_id":"","url":"https://api.github.com/users/sorentwo","html_url":"https://github.com/sorentwo","followers_url":"https://api.github.com/users/sorentwo/followers","following_url":"https://api.github.com/users/sorentwo/following{/other_user}","gists_url":"https://api.github.com/users/sorentwo/gists{/gist_id}","starred_url":"https://api.github.com/users/sorentwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorentwo/subscriptions","organizations_url":"https://api.github.com/users/sorentwo/orgs","repos_url":"https://api.github.com/users/sorentwo/repos","events_url":"https://api.github.com/users/sorentwo/events{/privacy}","received_events_url":"https://api.github.com/users/sorentwo/received_events","type":"User","site_admin":false},"repo":{"id":27021112,"name":"readthis","full_name":"sorentwo/readthis","owner":{"login":"sorentwo","id":270831,"avatar_url":"https://avatars.githubusercontent.com/u/270831?v=3","gravatar_id":"","url":"https://api.github.com/users/sorentwo","html_url":"https://github.com/sorentwo","followers_url":"https://api.github.com/users/sorentwo/followers","following_url":"https://api.github.com/users/sorentwo/following{/other_user}","gists_url":"https://api.github.com/users/sorentwo/gists{/gist_id}","starred_url":"https://api.github.com/users/sorentwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorentwo/subscriptions","organizations_url":"https://api.github.com/users/sorentwo/orgs","repos_url":"https://api.github.com/users/sorentwo/repos","events_url":"https://api.github.com/users/sorentwo/events{/privacy}","received_events_url":"https://api.github.com/users/sorentwo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sorentwo/readthis","description":"Pooled active support compliant caching with redis","fork":false,"url":"https://api.github.com/repos/sorentwo/readthis","forks_url":"https://api.github.com/repos/sorentwo/readthis/forks","keys_url":"https://api.github.com/repos/sorentwo/readthis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sorentwo/readthis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sorentwo/readthis/teams","hooks_url":"https://api.github.com/repos/sorentwo/readthis/hooks","issue_events_url":"https://api.github.com/repos/sorentwo/readthis/issues/events{/number}","events_url":"https://api.github.com/repos/sorentwo/readthis/events","assignees_url":"https://api.github.com/repos/sorentwo/readthis/assignees{/user}","branches_url":"https://api.github.com/repos/sorentwo/readthis/branches{/branch}","tags_url":"https://api.github.com/repos/sorentwo/readthis/tags","blobs_url":"https://api.github.com/repos/sorentwo/readthis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sorentwo/readthis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sorentwo/readthis/git/refs{/sha}","trees_url":"https://api.github.com/repos/sorentwo/readthis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sorentwo/readthis/statuses/{sha}","languages_url":"https://api.github.com/repos/sorentwo/readthis/languages","stargazers_url":"https://api.github.com/repos/sorentwo/readthis/stargazers","contributors_url":"https://api.github.com/repos/sorentwo/readthis/contributors","subscribers_url":"https://api.github.com/repos/sorentwo/readthis/subscribers","subscription_url":"https://api.github.com/repos/sorentwo/readthis/subscription","commits_url":"https://api.github.com/repos/sorentwo/readthis/commits{/sha}","git_commits_url":"https://api.github.com/repos/sorentwo/readthis/git/commits{/sha}","comments_url":"https://api.github.com/repos/sorentwo/readthis/comments{/number}","issue_comment_url":"https://api.github.com/repos/sorentwo/readthis/issues/comments{/number}","contents_url":"https://api.github.com/repos/sorentwo/readthis/contents/{+path}","compare_url":"https://api.github.com/repos/sorentwo/readthis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sorentwo/readthis/merges","archive_url":"https://api.github.com/repos/sorentwo/readthis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sorentwo/readthis/downloads","issues_url":"https://api.github.com/repos/sorentwo/readthis/issues{/number}","pulls_url":"https://api.github.com/repos/sorentwo/readthis/pulls{/number}","milestones_url":"https://api.github.com/repos/sorentwo/readthis/milestones{/number}","notifications_url":"https://api.github.com/repos/sorentwo/readthis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sorentwo/readthis/labels{/name}","releases_url":"https://api.github.com/repos/sorentwo/readthis/releases{/id}","created_at":"2014-11-23T03:45:07Z","updated_at":"2015-02-17T14:12:22Z","pushed_at":"2015-01-16T15:35:56Z","git_url":"git://github.com/sorentwo/readthis.git","ssh_url":"git@github.com:sorentwo/readthis.git","clone_url":"https://github.com/sorentwo/readthis.git","svn_url":"https://github.com/sorentwo/readthis","homepage":null,"size":432,"stargazers_count":48,"watchers_count":48,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sorentwo/readthis/pulls/3"},"html":{"href":"https://github.com/sorentwo/readthis/pull/3"},"issue":{"href":"https://api.github.com/repos/sorentwo/readthis/issues/3"},"comments":{"href":"https://api.github.com/repos/sorentwo/readthis/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/sorentwo/readthis/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/sorentwo/readthis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sorentwo/readthis/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/sorentwo/readthis/statuses/820f8e47907e3cb79e2b855dfa859914adb2e0f5"}}}}