{"action":"created","issue":{"url":"https://api.github.com/repos/dmt4/sfa-mer/issues/9","labels_url":"https://api.github.com/repos/dmt4/sfa-mer/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/dmt4/sfa-mer/issues/9/comments","events_url":"https://api.github.com/repos/dmt4/sfa-mer/issues/9/events","html_url":"https://github.com/dmt4/sfa-mer/pull/9","id":66199962,"number":9,"title":"generalized build script","user":{"login":"oleid","id":3369899,"avatar_url":"https://avatars.githubusercontent.com/u/3369899?v=3","gravatar_id":"","url":"https://api.github.com/users/oleid","html_url":"https://github.com/oleid","followers_url":"https://api.github.com/users/oleid/followers","following_url":"https://api.github.com/users/oleid/following{/other_user}","gists_url":"https://api.github.com/users/oleid/gists{/gist_id}","starred_url":"https://api.github.com/users/oleid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleid/subscriptions","organizations_url":"https://api.github.com/users/oleid/orgs","repos_url":"https://api.github.com/users/oleid/repos","events_url":"https://api.github.com/users/oleid/events{/privacy}","received_events_url":"https://api.github.com/users/oleid/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-03T18:03:33Z","updated_at":"2015-04-04T11:54:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dmt4/sfa-mer/pulls/9","html_url":"https://github.com/dmt4/sfa-mer/pull/9","diff_url":"https://github.com/dmt4/sfa-mer/pull/9.diff","patch_url":"https://github.com/dmt4/sfa-mer/pull/9.patch"},"body":"Hey there,\r\n\r\nI took your build script and made it (IMHO) more readable by using bash functions for writing coloured messages, added the possibility in task_ubu.sh and ahal.sh to inject device-specific code (e.g. a spec file or a local repository config) and added a lot of failsafe checky by letting the script die, if commands that shouldn't fail do so.\r\n\r\nI didn't test the DHD_REPO and MW_REPO code branches, though.\r\n\r\nHopefully, you find the changes useful! :)\r\n\r\n\r\n\r\nBest,\r\n\r\nOlaf"},"comment":{"url":"https://api.github.com/repos/dmt4/sfa-mer/issues/comments/89555607","html_url":"https://github.com/dmt4/sfa-mer/pull/9#issuecomment-89555607","issue_url":"https://api.github.com/repos/dmt4/sfa-mer/issues/9","id":89555607,"user":{"login":"dmt4","id":8308230,"avatar_url":"https://avatars.githubusercontent.com/u/8308230?v=3","gravatar_id":"","url":"https://api.github.com/users/dmt4","html_url":"https://github.com/dmt4","followers_url":"https://api.github.com/users/dmt4/followers","following_url":"https://api.github.com/users/dmt4/following{/other_user}","gists_url":"https://api.github.com/users/dmt4/gists{/gist_id}","starred_url":"https://api.github.com/users/dmt4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmt4/subscriptions","organizations_url":"https://api.github.com/users/dmt4/orgs","repos_url":"https://api.github.com/users/dmt4/repos","events_url":"https://api.github.com/users/dmt4/events{/privacy}","received_events_url":"https://api.github.com/users/dmt4/received_events","type":"User","site_admin":false},"created_at":"2015-04-04T11:54:29Z","updated_at":"2015-04-04T11:54:29Z","body":"Hi Olaf,\n\nGlad you found the pile of scripts useful and even more so for contributing \nfixes, niceties and extras! I'd have merged them already if I could test a \nbuild, unfortunately I cannot connect to my proper computer due to a massive \npower cut in central London. If you can't imagine it, google \"BBC Holborn \nfire\". My be in a few days it will be possible if there is someone at the uni  \nto turn it on as I'm away for the easter break. I might get back to with a \ncouple of technical questions if I don't understand something.\n\nBest,\n\nDimitar\n\nOn Friday 03 Apr 2015 11:03:34 oleid wrote:\n> Hey there,\n> \n> I took your build script and made it (IMHO) more readable by using bash\n> functions for writing coloured messages, added the possibility in\n> task_ubu.sh and ahal.sh to inject device-specific code (e.g. a spec file or\n> a local repository config) and added a lot of failsafe checky by letting\n> the script die, if commands that shouldn't fail do so.\n> \n> I didn't test the DHD_REPO and MW_REPO code branches, though.\n> \n> Hopefully, you find the changes useful! :)\n> \n> \n> \n> Best,\n> \n> Olaf\n> You can view, comment on, or merge this pull request online at:\n> \n>   https://github.com/dmt4/sfa-mer/pull/9\n> \n> -- Commit Summary --\n> \n>   * add description of hack\n>   * utility functions for scripts\n>   * simplify and generalize scripts\n>   * extra script for package handling\n>   * a working work-around for the dumpkey issue\n>   * introduce hal-build credits\n>   * [hammerhead] hal-build setup script\n>   * [yuga] repository config\n>   * [yuga] hal-build setup script\n>   * make sure there is at least the /var/lib/environment directory\n> \n> -- File Changes --\n> \n>     M ahal.sh (346)\n>     M build-img.sh (90)\n>     A device/lge/hammerhead-hal-build-setup.sh (15)\n>     A device/sony/yuga-hal-build-credits.inc (5)\n>     A device/sony/yuga-hal-build-setup.sh (10)\n>     A device/sony/yuga.xml (23)\n>     M exec-mer.sh (7)\n>     M fullbuild.sh (17)\n>     M hal-mw-and-img.sh (6)\n>     A pkgbuild.sh (57)\n>     M sb-setup.sh (59)\n>     M setup-mer.sh (16)\n>     M task-mer.sh (37)\n>     M task-ubu.sh (114)\n>     A utility-functions.inc (38)\n> \n> -- Patch Links --\n> \n> https://github.com/dmt4/sfa-mer/pull/9.patch\n> https://github.com/dmt4/sfa-mer/pull/9.diff\n> \n> ---\n> Reply to this email directly or view it on GitHub:\n> https://github.com/dmt4/sfa-mer/pull/9\n\n"}}