{"action":"created","comment":{"url":"https://api.github.com/repos/joblib/joblib/pulls/comments/29045730","id":29045730,"diff_hunk":"@@ -202,3 +202,23 @@ def test_format_signature_numpy():\n     \"\"\" Test the format signature formatting with numpy.\n     \"\"\"\n \n+\n+def test_special_source_encoding():\n+    from .test_func_inspect_special_encoding import big5_f\n+    func_code, source_file, first_line = get_func_code(big5_f)\n+    nose.tools.assert_equal(first_line, 5)\n+    nose.tools.assert_equal(\"def big5_f():\" in func_code, True)\n+    nose.tools.assert_equal(\"test_func_inspect_special_encoding\" in source_file, True)","path":"joblib/test/test_func_inspect.py","position":10,"original_position":10,"commit_id":"c3d0e6e6d4ba87d99c84aee1d2beb60333218923","original_commit_id":"c3d0e6e6d4ba87d99c84aee1d2beb60333218923","user":{"login":"lesteve","id":1680079,"avatar_url":"https://avatars.githubusercontent.com/u/1680079?v=3","gravatar_id":"","url":"https://api.github.com/users/lesteve","html_url":"https://github.com/lesteve","followers_url":"https://api.github.com/users/lesteve/followers","following_url":"https://api.github.com/users/lesteve/following{/other_user}","gists_url":"https://api.github.com/users/lesteve/gists{/gist_id}","starred_url":"https://api.github.com/users/lesteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesteve/subscriptions","organizations_url":"https://api.github.com/users/lesteve/orgs","repos_url":"https://api.github.com/users/lesteve/repos","events_url":"https://api.github.com/users/lesteve/events{/privacy}","received_events_url":"https://api.github.com/users/lesteve/received_events","type":"User","site_admin":false},"body":"you can use assert_true in this line and the line above","created_at":"2015-04-24T12:57:26Z","updated_at":"2015-04-24T12:57:26Z","html_url":"https://github.com/joblib/joblib/pull/203#discussion_r29045730","pull_request_url":"https://api.github.com/repos/joblib/joblib/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/joblib/joblib/pulls/comments/29045730"},"html":{"href":"https://github.com/joblib/joblib/pull/203#discussion_r29045730"},"pull_request":{"href":"https://api.github.com/repos/joblib/joblib/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/joblib/joblib/pulls/203","id":33755336,"html_url":"https://github.com/joblib/joblib/pull/203","diff_url":"https://github.com/joblib/joblib/pull/203.diff","patch_url":"https://github.com/joblib/joblib/pull/203.patch","issue_url":"https://api.github.com/repos/joblib/joblib/issues/203","number":203,"state":"open","locked":false,"title":"Add source encoding parameter in Memory module","user":{"login":"ryanzz","id":7149896,"avatar_url":"https://avatars.githubusercontent.com/u/7149896?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanzz","html_url":"https://github.com/ryanzz","followers_url":"https://api.github.com/users/ryanzz/followers","following_url":"https://api.github.com/users/ryanzz/following{/other_user}","gists_url":"https://api.github.com/users/ryanzz/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanzz/subscriptions","organizations_url":"https://api.github.com/users/ryanzz/orgs","repos_url":"https://api.github.com/users/ryanzz/repos","events_url":"https://api.github.com/users/ryanzz/events{/privacy}","received_events_url":"https://api.github.com/users/ryanzz/received_events","type":"User","site_admin":false},"body":"When caching a function's return value,  current implementation assume that the source file encoding of that function is the system's default encoding. If not, something bad happens.\r\nThis pull request added a source code encoding parameter to fix this problem. I think it would be useful.","created_at":"2015-04-21T12:18:54Z","updated_at":"2015-04-24T12:57:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81f459a4267b68595297033b9de1631e3a34b34a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joblib/joblib/pulls/203/commits","review_comments_url":"https://api.github.com/repos/joblib/joblib/pulls/203/comments","review_comment_url":"https://api.github.com/repos/joblib/joblib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joblib/joblib/issues/203/comments","statuses_url":"https://api.github.com/repos/joblib/joblib/statuses/c3d0e6e6d4ba87d99c84aee1d2beb60333218923","head":{"label":"ryanzz:master","ref":"master","sha":"c3d0e6e6d4ba87d99c84aee1d2beb60333218923","user":{"login":"ryanzz","id":7149896,"avatar_url":"https://avatars.githubusercontent.com/u/7149896?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanzz","html_url":"https://github.com/ryanzz","followers_url":"https://api.github.com/users/ryanzz/followers","following_url":"https://api.github.com/users/ryanzz/following{/other_user}","gists_url":"https://api.github.com/users/ryanzz/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanzz/subscriptions","organizations_url":"https://api.github.com/users/ryanzz/orgs","repos_url":"https://api.github.com/users/ryanzz/repos","events_url":"https://api.github.com/users/ryanzz/events{/privacy}","received_events_url":"https://api.github.com/users/ryanzz/received_events","type":"User","site_admin":false},"repo":{"id":34323561,"name":"joblib","full_name":"ryanzz/joblib","owner":{"login":"ryanzz","id":7149896,"avatar_url":"https://avatars.githubusercontent.com/u/7149896?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanzz","html_url":"https://github.com/ryanzz","followers_url":"https://api.github.com/users/ryanzz/followers","following_url":"https://api.github.com/users/ryanzz/following{/other_user}","gists_url":"https://api.github.com/users/ryanzz/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanzz/subscriptions","organizations_url":"https://api.github.com/users/ryanzz/orgs","repos_url":"https://api.github.com/users/ryanzz/repos","events_url":"https://api.github.com/users/ryanzz/events{/privacy}","received_events_url":"https://api.github.com/users/ryanzz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryanzz/joblib","description":"Python function as pipeline jobs.","fork":true,"url":"https://api.github.com/repos/ryanzz/joblib","forks_url":"https://api.github.com/repos/ryanzz/joblib/forks","keys_url":"https://api.github.com/repos/ryanzz/joblib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanzz/joblib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanzz/joblib/teams","hooks_url":"https://api.github.com/repos/ryanzz/joblib/hooks","issue_events_url":"https://api.github.com/repos/ryanzz/joblib/issues/events{/number}","events_url":"https://api.github.com/repos/ryanzz/joblib/events","assignees_url":"https://api.github.com/repos/ryanzz/joblib/assignees{/user}","branches_url":"https://api.github.com/repos/ryanzz/joblib/branches{/branch}","tags_url":"https://api.github.com/repos/ryanzz/joblib/tags","blobs_url":"https://api.github.com/repos/ryanzz/joblib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanzz/joblib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanzz/joblib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanzz/joblib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanzz/joblib/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanzz/joblib/languages","stargazers_url":"https://api.github.com/repos/ryanzz/joblib/stargazers","contributors_url":"https://api.github.com/repos/ryanzz/joblib/contributors","subscribers_url":"https://api.github.com/repos/ryanzz/joblib/subscribers","subscription_url":"https://api.github.com/repos/ryanzz/joblib/subscription","commits_url":"https://api.github.com/repos/ryanzz/joblib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanzz/joblib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanzz/joblib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanzz/joblib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryanzz/joblib/contents/{+path}","compare_url":"https://api.github.com/repos/ryanzz/joblib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanzz/joblib/merges","archive_url":"https://api.github.com/repos/ryanzz/joblib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanzz/joblib/downloads","issues_url":"https://api.github.com/repos/ryanzz/joblib/issues{/number}","pulls_url":"https://api.github.com/repos/ryanzz/joblib/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanzz/joblib/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanzz/joblib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanzz/joblib/labels{/name}","releases_url":"https://api.github.com/repos/ryanzz/joblib/releases{/id}","created_at":"2015-04-21T11:43:28Z","updated_at":"2015-04-24T10:59:07Z","pushed_at":"2015-04-24T10:59:07Z","git_url":"git://github.com/ryanzz/joblib.git","ssh_url":"git@github.com:ryanzz/joblib.git","clone_url":"https://github.com/ryanzz/joblib.git","svn_url":"https://github.com/ryanzz/joblib","homepage":"http://packages.python.org/joblib/","size":3766,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joblib:master","ref":"master","sha":"001fab4ab42e604a5471a6bef9722ea3d77e4309","user":{"login":"joblib","id":332661,"avatar_url":"https://avatars.githubusercontent.com/u/332661?v=3","gravatar_id":"","url":"https://api.github.com/users/joblib","html_url":"https://github.com/joblib","followers_url":"https://api.github.com/users/joblib/followers","following_url":"https://api.github.com/users/joblib/following{/other_user}","gists_url":"https://api.github.com/users/joblib/gists{/gist_id}","starred_url":"https://api.github.com/users/joblib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joblib/subscriptions","organizations_url":"https://api.github.com/users/joblib/orgs","repos_url":"https://api.github.com/users/joblib/repos","events_url":"https://api.github.com/users/joblib/events{/privacy}","received_events_url":"https://api.github.com/users/joblib/received_events","type":"Organization","site_admin":false},"repo":{"id":654608,"name":"joblib","full_name":"joblib/joblib","owner":{"login":"joblib","id":332661,"avatar_url":"https://avatars.githubusercontent.com/u/332661?v=3","gravatar_id":"","url":"https://api.github.com/users/joblib","html_url":"https://github.com/joblib","followers_url":"https://api.github.com/users/joblib/followers","following_url":"https://api.github.com/users/joblib/following{/other_user}","gists_url":"https://api.github.com/users/joblib/gists{/gist_id}","starred_url":"https://api.github.com/users/joblib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joblib/subscriptions","organizations_url":"https://api.github.com/users/joblib/orgs","repos_url":"https://api.github.com/users/joblib/repos","events_url":"https://api.github.com/users/joblib/events{/privacy}","received_events_url":"https://api.github.com/users/joblib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joblib/joblib","description":"Python function as pipeline jobs.","fork":false,"url":"https://api.github.com/repos/joblib/joblib","forks_url":"https://api.github.com/repos/joblib/joblib/forks","keys_url":"https://api.github.com/repos/joblib/joblib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joblib/joblib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joblib/joblib/teams","hooks_url":"https://api.github.com/repos/joblib/joblib/hooks","issue_events_url":"https://api.github.com/repos/joblib/joblib/issues/events{/number}","events_url":"https://api.github.com/repos/joblib/joblib/events","assignees_url":"https://api.github.com/repos/joblib/joblib/assignees{/user}","branches_url":"https://api.github.com/repos/joblib/joblib/branches{/branch}","tags_url":"https://api.github.com/repos/joblib/joblib/tags","blobs_url":"https://api.github.com/repos/joblib/joblib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joblib/joblib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joblib/joblib/git/refs{/sha}","trees_url":"https://api.github.com/repos/joblib/joblib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joblib/joblib/statuses/{sha}","languages_url":"https://api.github.com/repos/joblib/joblib/languages","stargazers_url":"https://api.github.com/repos/joblib/joblib/stargazers","contributors_url":"https://api.github.com/repos/joblib/joblib/contributors","subscribers_url":"https://api.github.com/repos/joblib/joblib/subscribers","subscription_url":"https://api.github.com/repos/joblib/joblib/subscription","commits_url":"https://api.github.com/repos/joblib/joblib/commits{/sha}","git_commits_url":"https://api.github.com/repos/joblib/joblib/git/commits{/sha}","comments_url":"https://api.github.com/repos/joblib/joblib/comments{/number}","issue_comment_url":"https://api.github.com/repos/joblib/joblib/issues/comments{/number}","contents_url":"https://api.github.com/repos/joblib/joblib/contents/{+path}","compare_url":"https://api.github.com/repos/joblib/joblib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joblib/joblib/merges","archive_url":"https://api.github.com/repos/joblib/joblib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joblib/joblib/downloads","issues_url":"https://api.github.com/repos/joblib/joblib/issues{/number}","pulls_url":"https://api.github.com/repos/joblib/joblib/pulls{/number}","milestones_url":"https://api.github.com/repos/joblib/joblib/milestones{/number}","notifications_url":"https://api.github.com/repos/joblib/joblib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joblib/joblib/labels{/name}","releases_url":"https://api.github.com/repos/joblib/joblib/releases{/id}","created_at":"2010-05-07T06:48:26Z","updated_at":"2015-04-23T13:33:30Z","pushed_at":"2015-04-24T10:59:08Z","git_url":"git://github.com/joblib/joblib.git","ssh_url":"git@github.com:joblib/joblib.git","clone_url":"https://github.com/joblib/joblib.git","svn_url":"https://github.com/joblib/joblib","homepage":"http://packages.python.org/joblib/","size":3766,"stargazers_count":349,"watchers_count":349,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":67,"forks":76,"open_issues":67,"watchers":349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joblib/joblib/pulls/203"},"html":{"href":"https://github.com/joblib/joblib/pull/203"},"issue":{"href":"https://api.github.com/repos/joblib/joblib/issues/203"},"comments":{"href":"https://api.github.com/repos/joblib/joblib/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/joblib/joblib/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/joblib/joblib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joblib/joblib/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/joblib/joblib/statuses/c3d0e6e6d4ba87d99c84aee1d2beb60333218923"}}}}