{"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid/pulls/comments/48199867","id":48199867,"diff_hunk":"@@ -81,12 +97,28 @@ public boolean eval(Row row)\n   {\n     byte[] dimBytes = StringUtils.toUtf8(this.dimension);\n     byte[] valBytes = StringUtils.toUtf8(this.value);\n-    return ByteBuffer.allocate(2 + dimBytes.length + valBytes.length)\n-                     .put(CACHE_KEY)\n-                     .put(dimBytes)\n-                     .put(STRING_SEPARATOR)\n-                     .put(valBytes)\n-                     .array();\n+    byte[] extractionFnBytes = null;\n+\n+    if (this.getExtractionFn() != null) {","path":"processing/src/main/java/io/druid/query/groupby/having/DimensionSelectorHavingSpec.java","position":null,"original_position":73,"commit_id":"eab2a16ae9fbb616e7b6b6d15721cc6c13059582","original_commit_id":"4f8cf80c157786770e0deeeb1ea122362f57910f","user":{"login":"mangeshpardeshiyahoo","id":12863032,"avatar_url":"https://avatars.githubusercontent.com/u/12863032?v=3","gravatar_id":"","url":"https://api.github.com/users/mangeshpardeshiyahoo","html_url":"https://github.com/mangeshpardeshiyahoo","followers_url":"https://api.github.com/users/mangeshpardeshiyahoo/followers","following_url":"https://api.github.com/users/mangeshpardeshiyahoo/following{/other_user}","gists_url":"https://api.github.com/users/mangeshpardeshiyahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mangeshpardeshiyahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mangeshpardeshiyahoo/subscriptions","organizations_url":"https://api.github.com/users/mangeshpardeshiyahoo/orgs","repos_url":"https://api.github.com/users/mangeshpardeshiyahoo/repos","events_url":"https://api.github.com/users/mangeshpardeshiyahoo/events{/privacy}","received_events_url":"https://api.github.com/users/mangeshpardeshiyahoo/received_events","type":"User","site_admin":false},"body":"done","created_at":"2015-12-21T22:25:08Z","updated_at":"2015-12-21T22:25:08Z","html_url":"https://github.com/druid-io/druid/pull/2125#discussion_r48199867","pull_request_url":"https://api.github.com/repos/druid-io/druid/pulls/2125","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/48199867"},"html":{"href":"https://github.com/druid-io/druid/pull/2125#discussion_r48199867"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2125"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/2125","id":54146882,"html_url":"https://github.com/druid-io/druid/pull/2125","diff_url":"https://github.com/druid-io/druid/pull/2125.diff","patch_url":"https://github.com/druid-io/druid/pull/2125.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/2125","number":2125,"state":"open","locked":false,"title":"Add extraction function support for Dimension Selector","user":{"login":"mangeshpardeshiyahoo","id":12863032,"avatar_url":"https://avatars.githubusercontent.com/u/12863032?v=3","gravatar_id":"","url":"https://api.github.com/users/mangeshpardeshiyahoo","html_url":"https://github.com/mangeshpardeshiyahoo","followers_url":"https://api.github.com/users/mangeshpardeshiyahoo/followers","following_url":"https://api.github.com/users/mangeshpardeshiyahoo/following{/other_user}","gists_url":"https://api.github.com/users/mangeshpardeshiyahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mangeshpardeshiyahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mangeshpardeshiyahoo/subscriptions","organizations_url":"https://api.github.com/users/mangeshpardeshiyahoo/orgs","repos_url":"https://api.github.com/users/mangeshpardeshiyahoo/repos","events_url":"https://api.github.com/users/mangeshpardeshiyahoo/events{/privacy}","received_events_url":"https://api.github.com/users/mangeshpardeshiyahoo/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-18T20:33:14Z","updated_at":"2015-12-21T22:25:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5943da9b87ba8a0e61a53421b211a6d36073c083","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/2125/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/2125/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/2125/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/eab2a16ae9fbb616e7b6b6d15721cc6c13059582","head":{"label":"mangeshpardeshiyahoo:master","ref":"master","sha":"eab2a16ae9fbb616e7b6b6d15721cc6c13059582","user":{"login":"mangeshpardeshiyahoo","id":12863032,"avatar_url":"https://avatars.githubusercontent.com/u/12863032?v=3","gravatar_id":"","url":"https://api.github.com/users/mangeshpardeshiyahoo","html_url":"https://github.com/mangeshpardeshiyahoo","followers_url":"https://api.github.com/users/mangeshpardeshiyahoo/followers","following_url":"https://api.github.com/users/mangeshpardeshiyahoo/following{/other_user}","gists_url":"https://api.github.com/users/mangeshpardeshiyahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mangeshpardeshiyahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mangeshpardeshiyahoo/subscriptions","organizations_url":"https://api.github.com/users/mangeshpardeshiyahoo/orgs","repos_url":"https://api.github.com/users/mangeshpardeshiyahoo/repos","events_url":"https://api.github.com/users/mangeshpardeshiyahoo/events{/privacy}","received_events_url":"https://api.github.com/users/mangeshpardeshiyahoo/received_events","type":"User","site_admin":false},"repo":{"id":46795318,"name":"druid","full_name":"mangeshpardeshiyahoo/druid","owner":{"login":"mangeshpardeshiyahoo","id":12863032,"avatar_url":"https://avatars.githubusercontent.com/u/12863032?v=3","gravatar_id":"","url":"https://api.github.com/users/mangeshpardeshiyahoo","html_url":"https://github.com/mangeshpardeshiyahoo","followers_url":"https://api.github.com/users/mangeshpardeshiyahoo/followers","following_url":"https://api.github.com/users/mangeshpardeshiyahoo/following{/other_user}","gists_url":"https://api.github.com/users/mangeshpardeshiyahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mangeshpardeshiyahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mangeshpardeshiyahoo/subscriptions","organizations_url":"https://api.github.com/users/mangeshpardeshiyahoo/orgs","repos_url":"https://api.github.com/users/mangeshpardeshiyahoo/repos","events_url":"https://api.github.com/users/mangeshpardeshiyahoo/events{/privacy}","received_events_url":"https://api.github.com/users/mangeshpardeshiyahoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mangeshpardeshiyahoo/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":true,"url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid","forks_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/forks","keys_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/teams","hooks_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/hooks","issue_events_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/issues/events{/number}","events_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/events","assignees_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/assignees{/user}","branches_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/branches{/branch}","tags_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/tags","blobs_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/languages","stargazers_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/stargazers","contributors_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/contributors","subscribers_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/subscribers","subscription_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/subscription","commits_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/contents/{+path}","compare_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/merges","archive_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/downloads","issues_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/issues{/number}","pulls_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/labels{/name}","releases_url":"https://api.github.com/repos/mangeshpardeshiyahoo/druid/releases{/id}","created_at":"2015-11-24T14:03:57Z","updated_at":"2015-11-24T14:04:08Z","pushed_at":"2015-12-21T22:23:14Z","git_url":"git://github.com/mangeshpardeshiyahoo/druid.git","ssh_url":"git@github.com:mangeshpardeshiyahoo/druid.git","clone_url":"https://github.com/mangeshpardeshiyahoo/druid.git","svn_url":"https://github.com/mangeshpardeshiyahoo/druid","homepage":"http://druid.io","size":98891,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"71f554bf805f34fc1c12431a080cb4cb652b69e2","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","created_at":"2012-10-23T19:08:07Z","updated_at":"2015-12-21T12:39:40Z","pushed_at":"2015-12-21T22:23:14Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"git@github.com:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":118044,"stargazers_count":2289,"watchers_count":2289,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":538,"mirror_url":null,"open_issues_count":275,"forks":538,"open_issues":275,"watchers":2289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2125"},"html":{"href":"https://github.com/druid-io/druid/pull/2125"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/2125"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/2125/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2125/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/2125/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/eab2a16ae9fbb616e7b6b6d15721cc6c13059582"}}}}