{"action":"created","comment":{"url":"https://api.github.com/repos/onefinestay/nameko/pulls/comments/23097852","id":23097852,"diff_hunk":"@@ -383,7 +403,7 @@ def _run_worker(self, worker_ctx, handle_result):\n                 del exc_info\n \n                 self.dependencies.all.worker_teardown(worker_ctx)\n-                self.dependencies.injections.all.release(worker_ctx)\n+                # release?","path":"nameko/containers.py","position":294,"original_position":294,"commit_id":"5ce4d8f2d5603d11decc7b51a82ce09274871d15","original_commit_id":"5ce4d8f2d5603d11decc7b51a82ce09274871d15","user":{"login":"davidszotten","id":412005,"avatar_url":"https://avatars.githubusercontent.com/u/412005?v=3","gravatar_id":"","url":"https://api.github.com/users/davidszotten","html_url":"https://github.com/davidszotten","followers_url":"https://api.github.com/users/davidszotten/followers","following_url":"https://api.github.com/users/davidszotten/following{/other_user}","gists_url":"https://api.github.com/users/davidszotten/gists{/gist_id}","starred_url":"https://api.github.com/users/davidszotten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidszotten/subscriptions","organizations_url":"https://api.github.com/users/davidszotten/orgs","repos_url":"https://api.github.com/users/davidszotten/repos","events_url":"https://api.github.com/users/davidszotten/events{/privacy}","received_events_url":"https://api.github.com/users/davidszotten/received_events","type":"User","site_admin":false},"body":"did we have an intended use-case? i.e. some extension that wanted to use a dependency in another extensions teardown? think we ended up just using teardown tidy up from `acquire_injection`","created_at":"2015-01-16T18:12:57Z","updated_at":"2015-01-16T18:12:57Z","html_url":"https://github.com/onefinestay/nameko/pull/187#discussion_r23097852","pull_request_url":"https://api.github.com/repos/onefinestay/nameko/pulls/187","_links":{"self":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/comments/23097852"},"html":{"href":"https://github.com/onefinestay/nameko/pull/187#discussion_r23097852"},"pull_request":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/onefinestay/nameko/pulls/187","id":27107036,"html_url":"https://github.com/onefinestay/nameko/pull/187","diff_url":"https://github.com/onefinestay/nameko/pull/187.diff","patch_url":"https://github.com/onefinestay/nameko/pull/187.patch","issue_url":"https://api.github.com/repos/onefinestay/nameko/issues/187","number":187,"state":"open","locked":false,"title":"Dependency redux","user":{"login":"mattbennett","id":107611,"avatar_url":"https://avatars.githubusercontent.com/u/107611?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbennett","html_url":"https://github.com/mattbennett","followers_url":"https://api.github.com/users/mattbennett/followers","following_url":"https://api.github.com/users/mattbennett/following{/other_user}","gists_url":"https://api.github.com/users/mattbennett/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbennett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbennett/subscriptions","organizations_url":"https://api.github.com/users/mattbennett/orgs","repos_url":"https://api.github.com/users/mattbennett/repos","events_url":"https://api.github.com/users/mattbennett/events{/privacy}","received_events_url":"https://api.github.com/users/mattbennett/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-09T15:34:12Z","updated_at":"2015-01-16T18:12:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e4b3b46c3057e4bac6a9a41a21669022d1e1324","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/onefinestay/nameko/pulls/187/commits","review_comments_url":"https://api.github.com/repos/onefinestay/nameko/pulls/187/comments","review_comment_url":"https://api.github.com/repos/onefinestay/nameko/pulls/comments/{number}","comments_url":"https://api.github.com/repos/onefinestay/nameko/issues/187/comments","statuses_url":"https://api.github.com/repos/onefinestay/nameko/statuses/5ce4d8f2d5603d11decc7b51a82ce09274871d15","head":{"label":"onefinestay:dependency-redux","ref":"dependency-redux","sha":"5ce4d8f2d5603d11decc7b51a82ce09274871d15","user":{"login":"onefinestay","id":634153,"avatar_url":"https://avatars.githubusercontent.com/u/634153?v=3","gravatar_id":"","url":"https://api.github.com/users/onefinestay","html_url":"https://github.com/onefinestay","followers_url":"https://api.github.com/users/onefinestay/followers","following_url":"https://api.github.com/users/onefinestay/following{/other_user}","gists_url":"https://api.github.com/users/onefinestay/gists{/gist_id}","starred_url":"https://api.github.com/users/onefinestay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onefinestay/subscriptions","organizations_url":"https://api.github.com/users/onefinestay/orgs","repos_url":"https://api.github.com/users/onefinestay/repos","events_url":"https://api.github.com/users/onefinestay/events{/privacy}","received_events_url":"https://api.github.com/users/onefinestay/received_events","type":"Organization","site_admin":false},"repo":{"id":8431589,"name":"nameko","full_name":"onefinestay/nameko","owner":{"login":"onefinestay","id":634153,"avatar_url":"https://avatars.githubusercontent.com/u/634153?v=3","gravatar_id":"","url":"https://api.github.com/users/onefinestay","html_url":"https://github.com/onefinestay","followers_url":"https://api.github.com/users/onefinestay/followers","following_url":"https://api.github.com/users/onefinestay/following{/other_user}","gists_url":"https://api.github.com/users/onefinestay/gists{/gist_id}","starred_url":"https://api.github.com/users/onefinestay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onefinestay/subscriptions","organizations_url":"https://api.github.com/users/onefinestay/orgs","repos_url":"https://api.github.com/users/onefinestay/repos","events_url":"https://api.github.com/users/onefinestay/events{/privacy}","received_events_url":"https://api.github.com/users/onefinestay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onefinestay/nameko","description":"","fork":false,"url":"https://api.github.com/repos/onefinestay/nameko","forks_url":"https://api.github.com/repos/onefinestay/nameko/forks","keys_url":"https://api.github.com/repos/onefinestay/nameko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onefinestay/nameko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onefinestay/nameko/teams","hooks_url":"https://api.github.com/repos/onefinestay/nameko/hooks","issue_events_url":"https://api.github.com/repos/onefinestay/nameko/issues/events{/number}","events_url":"https://api.github.com/repos/onefinestay/nameko/events","assignees_url":"https://api.github.com/repos/onefinestay/nameko/assignees{/user}","branches_url":"https://api.github.com/repos/onefinestay/nameko/branches{/branch}","tags_url":"https://api.github.com/repos/onefinestay/nameko/tags","blobs_url":"https://api.github.com/repos/onefinestay/nameko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onefinestay/nameko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onefinestay/nameko/git/refs{/sha}","trees_url":"https://api.github.com/repos/onefinestay/nameko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onefinestay/nameko/statuses/{sha}","languages_url":"https://api.github.com/repos/onefinestay/nameko/languages","stargazers_url":"https://api.github.com/repos/onefinestay/nameko/stargazers","contributors_url":"https://api.github.com/repos/onefinestay/nameko/contributors","subscribers_url":"https://api.github.com/repos/onefinestay/nameko/subscribers","subscription_url":"https://api.github.com/repos/onefinestay/nameko/subscription","commits_url":"https://api.github.com/repos/onefinestay/nameko/commits{/sha}","git_commits_url":"https://api.github.com/repos/onefinestay/nameko/git/commits{/sha}","comments_url":"https://api.github.com/repos/onefinestay/nameko/comments{/number}","issue_comment_url":"https://api.github.com/repos/onefinestay/nameko/issues/comments/{number}","contents_url":"https://api.github.com/repos/onefinestay/nameko/contents/{+path}","compare_url":"https://api.github.com/repos/onefinestay/nameko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onefinestay/nameko/merges","archive_url":"https://api.github.com/repos/onefinestay/nameko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onefinestay/nameko/downloads","issues_url":"https://api.github.com/repos/onefinestay/nameko/issues{/number}","pulls_url":"https://api.github.com/repos/onefinestay/nameko/pulls{/number}","milestones_url":"https://api.github.com/repos/onefinestay/nameko/milestones{/number}","notifications_url":"https://api.github.com/repos/onefinestay/nameko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onefinestay/nameko/labels{/name}","releases_url":"https://api.github.com/repos/onefinestay/nameko/releases{/id}","created_at":"2013-02-26T11:59:08Z","updated_at":"2015-01-06T15:53:09Z","pushed_at":"2015-01-16T17:32:13Z","git_url":"git://github.com/onefinestay/nameko.git","ssh_url":"git@github.com:onefinestay/nameko.git","clone_url":"https://github.com/onefinestay/nameko.git","svn_url":"https://github.com/onefinestay/nameko","homepage":null,"size":4357,"stargazers_count":37,"watchers_count":37,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":8,"forks":7,"open_issues":8,"watchers":37,"default_branch":"master"}},"base":{"label":"onefinestay:master","ref":"master","sha":"8a96cae5222812e316eac315e4852bafa3f04f27","user":{"login":"onefinestay","id":634153,"avatar_url":"https://avatars.githubusercontent.com/u/634153?v=3","gravatar_id":"","url":"https://api.github.com/users/onefinestay","html_url":"https://github.com/onefinestay","followers_url":"https://api.github.com/users/onefinestay/followers","following_url":"https://api.github.com/users/onefinestay/following{/other_user}","gists_url":"https://api.github.com/users/onefinestay/gists{/gist_id}","starred_url":"https://api.github.com/users/onefinestay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onefinestay/subscriptions","organizations_url":"https://api.github.com/users/onefinestay/orgs","repos_url":"https://api.github.com/users/onefinestay/repos","events_url":"https://api.github.com/users/onefinestay/events{/privacy}","received_events_url":"https://api.github.com/users/onefinestay/received_events","type":"Organization","site_admin":false},"repo":{"id":8431589,"name":"nameko","full_name":"onefinestay/nameko","owner":{"login":"onefinestay","id":634153,"avatar_url":"https://avatars.githubusercontent.com/u/634153?v=3","gravatar_id":"","url":"https://api.github.com/users/onefinestay","html_url":"https://github.com/onefinestay","followers_url":"https://api.github.com/users/onefinestay/followers","following_url":"https://api.github.com/users/onefinestay/following{/other_user}","gists_url":"https://api.github.com/users/onefinestay/gists{/gist_id}","starred_url":"https://api.github.com/users/onefinestay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onefinestay/subscriptions","organizations_url":"https://api.github.com/users/onefinestay/orgs","repos_url":"https://api.github.com/users/onefinestay/repos","events_url":"https://api.github.com/users/onefinestay/events{/privacy}","received_events_url":"https://api.github.com/users/onefinestay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onefinestay/nameko","description":"","fork":false,"url":"https://api.github.com/repos/onefinestay/nameko","forks_url":"https://api.github.com/repos/onefinestay/nameko/forks","keys_url":"https://api.github.com/repos/onefinestay/nameko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onefinestay/nameko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onefinestay/nameko/teams","hooks_url":"https://api.github.com/repos/onefinestay/nameko/hooks","issue_events_url":"https://api.github.com/repos/onefinestay/nameko/issues/events{/number}","events_url":"https://api.github.com/repos/onefinestay/nameko/events","assignees_url":"https://api.github.com/repos/onefinestay/nameko/assignees{/user}","branches_url":"https://api.github.com/repos/onefinestay/nameko/branches{/branch}","tags_url":"https://api.github.com/repos/onefinestay/nameko/tags","blobs_url":"https://api.github.com/repos/onefinestay/nameko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onefinestay/nameko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onefinestay/nameko/git/refs{/sha}","trees_url":"https://api.github.com/repos/onefinestay/nameko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onefinestay/nameko/statuses/{sha}","languages_url":"https://api.github.com/repos/onefinestay/nameko/languages","stargazers_url":"https://api.github.com/repos/onefinestay/nameko/stargazers","contributors_url":"https://api.github.com/repos/onefinestay/nameko/contributors","subscribers_url":"https://api.github.com/repos/onefinestay/nameko/subscribers","subscription_url":"https://api.github.com/repos/onefinestay/nameko/subscription","commits_url":"https://api.github.com/repos/onefinestay/nameko/commits{/sha}","git_commits_url":"https://api.github.com/repos/onefinestay/nameko/git/commits{/sha}","comments_url":"https://api.github.com/repos/onefinestay/nameko/comments{/number}","issue_comment_url":"https://api.github.com/repos/onefinestay/nameko/issues/comments/{number}","contents_url":"https://api.github.com/repos/onefinestay/nameko/contents/{+path}","compare_url":"https://api.github.com/repos/onefinestay/nameko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onefinestay/nameko/merges","archive_url":"https://api.github.com/repos/onefinestay/nameko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onefinestay/nameko/downloads","issues_url":"https://api.github.com/repos/onefinestay/nameko/issues{/number}","pulls_url":"https://api.github.com/repos/onefinestay/nameko/pulls{/number}","milestones_url":"https://api.github.com/repos/onefinestay/nameko/milestones{/number}","notifications_url":"https://api.github.com/repos/onefinestay/nameko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onefinestay/nameko/labels{/name}","releases_url":"https://api.github.com/repos/onefinestay/nameko/releases{/id}","created_at":"2013-02-26T11:59:08Z","updated_at":"2015-01-06T15:53:09Z","pushed_at":"2015-01-16T17:32:13Z","git_url":"git://github.com/onefinestay/nameko.git","ssh_url":"git@github.com:onefinestay/nameko.git","clone_url":"https://github.com/onefinestay/nameko.git","svn_url":"https://github.com/onefinestay/nameko","homepage":null,"size":4357,"stargazers_count":37,"watchers_count":37,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":8,"forks":7,"open_issues":8,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/187"},"html":{"href":"https://github.com/onefinestay/nameko/pull/187"},"issue":{"href":"https://api.github.com/repos/onefinestay/nameko/issues/187"},"comments":{"href":"https://api.github.com/repos/onefinestay/nameko/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/onefinestay/nameko/statuses/5ce4d8f2d5603d11decc7b51a82ce09274871d15"}}}}