{"action":"created","issue":{"url":"https://api.github.com/repos/github/git-lfs/issues/403","labels_url":"https://api.github.com/repos/github/git-lfs/issues/403/labels{/name}","comments_url":"https://api.github.com/repos/github/git-lfs/issues/403/comments","events_url":"https://api.github.com/repos/github/git-lfs/issues/403/events","html_url":"https://github.com/github/git-lfs/pull/403","id":88974807,"number":403,"title":"Consistently construct Endpoint from urls the same way","user":{"login":"sinbad","id":142735,"avatar_url":"https://avatars.githubusercontent.com/u/142735?v=3","gravatar_id":"","url":"https://api.github.com/users/sinbad","html_url":"https://github.com/sinbad","followers_url":"https://api.github.com/users/sinbad/followers","following_url":"https://api.github.com/users/sinbad/following{/other_user}","gists_url":"https://api.github.com/users/sinbad/gists{/gist_id}","starred_url":"https://api.github.com/users/sinbad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinbad/subscriptions","organizations_url":"https://api.github.com/users/sinbad/orgs","repos_url":"https://api.github.com/users/sinbad/repos","events_url":"https://api.github.com/users/sinbad/events{/privacy}","received_events_url":"https://api.github.com/users/sinbad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-06-17T10:05:47Z","updated_at":"2015-06-17T19:40:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/github/git-lfs/pulls/403","html_url":"https://github.com/github/git-lfs/pull/403","diff_url":"https://github.com/github/git-lfs/pull/403.diff","patch_url":"https://github.com/github/git-lfs/pull/403.patch"},"body":"There are 2 ways to construct LFS urls - from explicit URLs and from the\r\nclone URL (which gets info/lfs appended). Previously there were multiple\r\npaths where the Endpoint could be constructed in a short-circuit manner\r\nwhich prevents future expansion in common functions. This standardises\r\nthe Endpoint construction so it always happens via NewEndpoint, and\r\nNewEndpointFromCloneURL performs the extra step of appending info/lfs.\r\n\r\nThis has a current effect of supporting SSH urls in all config settings,\r\nand not just the remote clone URL as before. But mostly this is to enable\r\nfuture expansion (improved SSH support)"},"comment":{"url":"https://api.github.com/repos/github/git-lfs/issues/comments/112923835","html_url":"https://github.com/github/git-lfs/pull/403#issuecomment-112923835","issue_url":"https://api.github.com/repos/github/git-lfs/issues/403","id":112923835,"user":{"login":"technoweenie","id":21,"avatar_url":"https://avatars.githubusercontent.com/u/21?v=3","gravatar_id":"","url":"https://api.github.com/users/technoweenie","html_url":"https://github.com/technoweenie","followers_url":"https://api.github.com/users/technoweenie/followers","following_url":"https://api.github.com/users/technoweenie/following{/other_user}","gists_url":"https://api.github.com/users/technoweenie/gists{/gist_id}","starred_url":"https://api.github.com/users/technoweenie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technoweenie/subscriptions","organizations_url":"https://api.github.com/users/technoweenie/orgs","repos_url":"https://api.github.com/users/technoweenie/repos","events_url":"https://api.github.com/users/technoweenie/events{/privacy}","received_events_url":"https://api.github.com/users/technoweenie/received_events","type":"User","site_admin":true},"created_at":"2015-06-17T19:40:33Z","updated_at":"2015-06-17T19:40:33Z","body":"I reorganized the code a bit in #407 based on the assumption that this PR will be merged as is. Now that `Endpoint` is more than just a struct declaration, I moved it all to a separate go file.\r\n\r\n2a6af23ce065e6fd25b7c54ec383362f7cd30993 is the actual commit."}}