{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/27052067","id":27052067,"diff_hunk":"@@ -1,5 +1,14 @@\n /*global require*/\n-require(['ext.wikia.adEngine.messageListener'], function (messageListener) {\n+require([\n+\t'ext.wikia.adEngine.messageListener',\n+\t'ext.wikia.adEngine.customAdsLoader'","path":"extensions/wikia/AdEngine/js/mercury.run.js","position":5,"original_position":5,"commit_id":"b768fe60554f45620ab861a393135b7038d260fb","original_commit_id":"b768fe60554f45620ab861a393135b7038d260fb","user":{"login":"rogatty","id":7030884,"avatar_url":"https://avatars.githubusercontent.com/u/7030884?v=3","gravatar_id":"","url":"https://api.github.com/users/rogatty","html_url":"https://github.com/rogatty","followers_url":"https://api.github.com/users/rogatty/followers","following_url":"https://api.github.com/users/rogatty/following{/other_user}","gists_url":"https://api.github.com/users/rogatty/gists{/gist_id}","starred_url":"https://api.github.com/users/rogatty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogatty/subscriptions","organizations_url":"https://api.github.com/users/rogatty/orgs","repos_url":"https://api.github.com/users/rogatty/repos","events_url":"https://api.github.com/users/rogatty/events{/privacy}","received_events_url":"https://api.github.com/users/rogatty/received_events","type":"User","site_admin":false},"body":"Shouldn't it be kept in an alphabetic order?","created_at":"2015-03-24T17:29:26Z","updated_at":"2015-03-24T17:29:26Z","html_url":"https://github.com/Wikia/app/pull/6758#discussion_r27052067","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/6758","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/27052067"},"html":{"href":"https://github.com/Wikia/app/pull/6758#discussion_r27052067"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/6758"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/6758","id":31751425,"html_url":"https://github.com/Wikia/app/pull/6758","diff_url":"https://github.com/Wikia/app/pull/6758.diff","patch_url":"https://github.com/Wikia/app/pull/6758.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/6758","number":6758,"state":"open","locked":false,"title":"ADEN-1834: Interstitial ads on mercury","user":{"login":"nandy-andy","id":1662451,"avatar_url":"https://avatars.githubusercontent.com/u/1662451?v=3","gravatar_id":"","url":"https://api.github.com/users/nandy-andy","html_url":"https://github.com/nandy-andy","followers_url":"https://api.github.com/users/nandy-andy/followers","following_url":"https://api.github.com/users/nandy-andy/following{/other_user}","gists_url":"https://api.github.com/users/nandy-andy/gists{/gist_id}","starred_url":"https://api.github.com/users/nandy-andy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nandy-andy/subscriptions","organizations_url":"https://api.github.com/users/nandy-andy/orgs","repos_url":"https://api.github.com/users/nandy-andy/repos","events_url":"https://api.github.com/users/nandy-andy/events{/privacy}","received_events_url":"https://api.github.com/users/nandy-andy/received_events","type":"User","site_admin":false},"body":"We implemented interstitial ads on Oasis and we're using there `UiFactory` and its regular modals. We also wanted to have the interstitial product on Mercury and changes below allows us to have it. The changes includes:\r\n* extracted exposed functionality `loadCustomAd()` to a separate module: `ext.wikia.adEngine.customAdsLoader`,\r\n* exposed `loadCustomAd()` on Mercury as well (in the run file),\r\n* new method `createAdIframe()` reused for Oasis&Mercury in `show()` funciton of `modal.js`.\r\n\r\nThis pull request is connected to https://github.com/Wikia/mercury/pull/630.","created_at":"2015-03-23T16:54:54Z","updated_at":"2015-03-24T17:29:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ada4da947eaf91ee74478dd9230e6f2e4098aa97","assignee":{"login":"gabrys","id":74567,"avatar_url":"https://avatars.githubusercontent.com/u/74567?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrys","html_url":"https://github.com/gabrys","followers_url":"https://api.github.com/users/gabrys/followers","following_url":"https://api.github.com/users/gabrys/following{/other_user}","gists_url":"https://api.github.com/users/gabrys/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrys/subscriptions","organizations_url":"https://api.github.com/users/gabrys/orgs","repos_url":"https://api.github.com/users/gabrys/repos","events_url":"https://api.github.com/users/gabrys/events{/privacy}","received_events_url":"https://api.github.com/users/gabrys/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/6758/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/6758/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/6758/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/b768fe60554f45620ab861a393135b7038d260fb","head":{"label":"Wikia:aden-1834-interstitial-ads-on-mercury","ref":"aden-1834-interstitial-ads-on-mercury","sha":"b768fe60554f45620ab861a393135b7038d260fb","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-03-24T16:09:05Z","pushed_at":"2015-03-24T16:11:15Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1382936,"stargazers_count":74,"watchers_count":74,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":59,"forks":54,"open_issues":59,"watchers":74,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"5c8802d0cb94cbaf2101995e0544ac6f3d99dec2","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-03-24T16:09:05Z","pushed_at":"2015-03-24T16:11:15Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1382936,"stargazers_count":74,"watchers_count":74,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":59,"forks":54,"open_issues":59,"watchers":74,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/6758"},"html":{"href":"https://github.com/Wikia/app/pull/6758"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/6758"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/6758/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/6758/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/6758/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/b768fe60554f45620ab861a393135b7038d260fb"}}}}