{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/24558505","id":24558505,"diff_hunk":"@@ -29,11 +29,24 @@\n #define KERNEL_MISC_H\n \n #include <types_ext.h>\n+#include <utee_types.h>\n+#include <arm32.h>\n \n size_t get_core_pos(void);\n \n uint32_t read_usr_sp(void);\n uint32_t read_usr_lr(void);\n \n+static inline int get_generic_timer_info(struct generic_timer_info *timer_info)","path":"core/arch/arm32/include/kernel/misc.h","position":12,"original_position":12,"commit_id":"943bdd61b69a0d5605b2d8d6e492e399578ddd96","original_commit_id":"943bdd61b69a0d5605b2d8d6e492e399578ddd96","user":{"login":"kong1191","id":8639254,"avatar_url":"https://avatars.githubusercontent.com/u/8639254?v=3","gravatar_id":"","url":"https://api.github.com/users/kong1191","html_url":"https://github.com/kong1191","followers_url":"https://api.github.com/users/kong1191/followers","following_url":"https://api.github.com/users/kong1191/following{/other_user}","gists_url":"https://api.github.com/users/kong1191/gists{/gist_id}","starred_url":"https://api.github.com/users/kong1191/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kong1191/subscriptions","organizations_url":"https://api.github.com/users/kong1191/orgs","repos_url":"https://api.github.com/users/kong1191/repos","events_url":"https://api.github.com/users/kong1191/events{/privacy}","received_events_url":"https://api.github.com/users/kong1191/received_events","type":"User","site_admin":false},"body":"The design is bad, this should be separated into architecture independent part and architecture dependent part.","created_at":"2015-02-12T04:50:43Z","updated_at":"2015-02-12T04:50:43Z","html_url":"https://github.com/OP-TEE/optee_os/pull/184#discussion_r24558505","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/184","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/24558505"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/184#discussion_r24558505"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/184"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/184","id":28081711,"html_url":"https://github.com/OP-TEE/optee_os/pull/184","diff_url":"https://github.com/OP-TEE/optee_os/pull/184.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/184.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/184","number":184,"state":"open","locked":false,"title":"OP-TEE Benchmark","user":{"login":"kong1191","id":8639254,"avatar_url":"https://avatars.githubusercontent.com/u/8639254?v=3","gravatar_id":"","url":"https://api.github.com/users/kong1191","html_url":"https://github.com/kong1191","followers_url":"https://api.github.com/users/kong1191/followers","following_url":"https://api.github.com/users/kong1191/following{/other_user}","gists_url":"https://api.github.com/users/kong1191/gists{/gist_id}","starred_url":"https://api.github.com/users/kong1191/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kong1191/subscriptions","organizations_url":"https://api.github.com/users/kong1191/orgs","repos_url":"https://api.github.com/users/kong1191/repos","events_url":"https://api.github.com/users/kong1191/events{/privacy}","received_events_url":"https://api.github.com/users/kong1191/received_events","type":"User","site_admin":false},"body":"  - Add new secure system call for system call performance measurement\r\n  - Print CNTVCT value for smc call performance measurement\r\n  - Fix compile warning message issue that will happen when compiling libutee and change log level to 0\r\n\r\nSigned-off-by: James Kung <kong1191@gmail.com>\r\nTested-by: James Kung <kong1191@gmail.com> (QEMU, FVP)","created_at":"2015-01-27T03:43:26Z","updated_at":"2015-02-12T04:50:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee81b61f6f200e954f3a78b933fd3775a586f749","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/184/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/184/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/184/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/943bdd61b69a0d5605b2d8d6e492e399578ddd96","head":{"label":"kong1191:master","ref":"master","sha":"943bdd61b69a0d5605b2d8d6e492e399578ddd96","user":{"login":"kong1191","id":8639254,"avatar_url":"https://avatars.githubusercontent.com/u/8639254?v=3","gravatar_id":"","url":"https://api.github.com/users/kong1191","html_url":"https://github.com/kong1191","followers_url":"https://api.github.com/users/kong1191/followers","following_url":"https://api.github.com/users/kong1191/following{/other_user}","gists_url":"https://api.github.com/users/kong1191/gists{/gist_id}","starred_url":"https://api.github.com/users/kong1191/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kong1191/subscriptions","organizations_url":"https://api.github.com/users/kong1191/orgs","repos_url":"https://api.github.com/users/kong1191/repos","events_url":"https://api.github.com/users/kong1191/events{/privacy}","received_events_url":"https://api.github.com/users/kong1191/received_events","type":"User","site_admin":false},"repo":{"id":28868412,"name":"optee_os","full_name":"kong1191/optee_os","owner":{"login":"kong1191","id":8639254,"avatar_url":"https://avatars.githubusercontent.com/u/8639254?v=3","gravatar_id":"","url":"https://api.github.com/users/kong1191","html_url":"https://github.com/kong1191","followers_url":"https://api.github.com/users/kong1191/followers","following_url":"https://api.github.com/users/kong1191/following{/other_user}","gists_url":"https://api.github.com/users/kong1191/gists{/gist_id}","starred_url":"https://api.github.com/users/kong1191/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kong1191/subscriptions","organizations_url":"https://api.github.com/users/kong1191/orgs","repos_url":"https://api.github.com/users/kong1191/repos","events_url":"https://api.github.com/users/kong1191/events{/privacy}","received_events_url":"https://api.github.com/users/kong1191/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kong1191/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/kong1191/optee_os","forks_url":"https://api.github.com/repos/kong1191/optee_os/forks","keys_url":"https://api.github.com/repos/kong1191/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kong1191/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kong1191/optee_os/teams","hooks_url":"https://api.github.com/repos/kong1191/optee_os/hooks","issue_events_url":"https://api.github.com/repos/kong1191/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/kong1191/optee_os/events","assignees_url":"https://api.github.com/repos/kong1191/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/kong1191/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/kong1191/optee_os/tags","blobs_url":"https://api.github.com/repos/kong1191/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kong1191/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kong1191/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/kong1191/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kong1191/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/kong1191/optee_os/languages","stargazers_url":"https://api.github.com/repos/kong1191/optee_os/stargazers","contributors_url":"https://api.github.com/repos/kong1191/optee_os/contributors","subscribers_url":"https://api.github.com/repos/kong1191/optee_os/subscribers","subscription_url":"https://api.github.com/repos/kong1191/optee_os/subscription","commits_url":"https://api.github.com/repos/kong1191/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/kong1191/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/kong1191/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/kong1191/optee_os/issues/comments/{number}","contents_url":"https://api.github.com/repos/kong1191/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/kong1191/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kong1191/optee_os/merges","archive_url":"https://api.github.com/repos/kong1191/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kong1191/optee_os/downloads","issues_url":"https://api.github.com/repos/kong1191/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/kong1191/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/kong1191/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/kong1191/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kong1191/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/kong1191/optee_os/releases{/id}","created_at":"2015-01-06T15:05:20Z","updated_at":"2015-01-29T13:35:17Z","pushed_at":"2015-01-29T13:35:17Z","git_url":"git://github.com/kong1191/optee_os.git","ssh_url":"git@github.com:kong1191/optee_os.git","clone_url":"https://github.com/kong1191/optee_os.git","svn_url":"https://github.com/kong1191/optee_os","homepage":null,"size":4856,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"759cc499f6cb56595da2e6596fb58293168cdc31","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments/{number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","created_at":"2014-05-26T17:18:57Z","updated_at":"2015-02-12T02:24:23Z","pushed_at":"2015-02-12T02:24:22Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":7145,"stargazers_count":30,"watchers_count":30,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":10,"forks":32,"open_issues":10,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/184"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/184"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/184"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/184/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/184/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/184/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/943bdd61b69a0d5605b2d8d6e492e399578ddd96"}}}}