{"action":"created","comment":{"url":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments/43990020","id":43990020,"diff_hunk":"@@ -86,11 +87,11 @@ class Bootstrap\n      */\n     public function __construct($context)\n     {\n-        $this->defineConstants();\n-        $this->ensureRequiredEnvironment();\n-\n         $this->context = new ApplicationContext($context);\n         $this->earlyInstances[__CLASS__] = $this;\n+\n+        $this->defineConstants();\n+        $this->ensureRequiredEnvironment();","path":"TYPO3.Flow/Classes/TYPO3/Flow/Core/Bootstrap.php","position":19,"original_position":19,"commit_id":"49f09863fe5b440bea0a3cdce2c9ebfb41d78740","original_commit_id":"49f09863fe5b440bea0a3cdce2c9ebfb41d78740","user":{"login":"kitsunet","id":324408,"avatar_url":"https://avatars.githubusercontent.com/u/324408?v=3","gravatar_id":"","url":"https://api.github.com/users/kitsunet","html_url":"https://github.com/kitsunet","followers_url":"https://api.github.com/users/kitsunet/followers","following_url":"https://api.github.com/users/kitsunet/following{/other_user}","gists_url":"https://api.github.com/users/kitsunet/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsunet/subscriptions","organizations_url":"https://api.github.com/users/kitsunet/orgs","repos_url":"https://api.github.com/users/kitsunet/repos","events_url":"https://api.github.com/users/kitsunet/events{/privacy}","received_events_url":"https://api.github.com/users/kitsunet/received_events","type":"User","site_admin":false},"body":"You need to have the context ready to define the constants now.","created_at":"2015-11-05T09:12:23Z","updated_at":"2015-11-05T09:12:23Z","html_url":"https://github.com/neos/flow-development-collection/pull/97#discussion_r43990020","pull_request_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments/43990020"},"html":{"href":"https://github.com/neos/flow-development-collection/pull/97#discussion_r43990020"},"pull_request":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/neos/flow-development-collection/pulls/97","id":48216706,"html_url":"https://github.com/neos/flow-development-collection/pull/97","diff_url":"https://github.com/neos/flow-development-collection/pull/97.diff","patch_url":"https://github.com/neos/flow-development-collection/pull/97.patch","issue_url":"https://api.github.com/repos/neos/flow-development-collection/issues/97","number":97,"state":"open","locked":false,"title":"[!!!][BUGFIX] Store site lock in Flow temporary base path","user":{"login":"bwaidelich","id":307571,"avatar_url":"https://avatars.githubusercontent.com/u/307571?v=3","gravatar_id":"","url":"https://api.github.com/users/bwaidelich","html_url":"https://github.com/bwaidelich","followers_url":"https://api.github.com/users/bwaidelich/followers","following_url":"https://api.github.com/users/bwaidelich/following{/other_user}","gists_url":"https://api.github.com/users/bwaidelich/gists{/gist_id}","starred_url":"https://api.github.com/users/bwaidelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwaidelich/subscriptions","organizations_url":"https://api.github.com/users/bwaidelich/orgs","repos_url":"https://api.github.com/users/bwaidelich/repos","events_url":"https://api.github.com/users/bwaidelich/events{/privacy}","received_events_url":"https://api.github.com/users/bwaidelich/received_events","type":"User","site_admin":false},"body":"Storing the site lock files in the system temporary directory\r\ncould lead to endless locks on some file systems.\r\nThis changes the site locks to be stored in the Flow temporary base\r\npath again.\r\n\r\nThis is a breaking change because it removes the setting\r\n``TYPO3.Flow.utility.environment.temporaryDirectoryBase`` in favor of\r\na new environment variable ``FLOW_PATH_TEMPORARY_BASE`` that allows for\r\nchanging the path if needed.\r\n\r\nBackground:\r\n\r\nFLOW-348 introduced a new locking mechanism that stored lock files\r\nin the systems default temporary folder determined via\r\n``sys_get_temp_dir()``. On some systems files created there by the\r\nPHP process could not be removed afterwards.\r\n\r\nRelated: FLOW-348\r\nResolves: FLOW-381","created_at":"2015-10-20T15:28:36Z","updated_at":"2015-11-05T09:12:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25c9d794a14a620e70f958ad05a91c9380cbd2dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/97/commits","review_comments_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/97/comments","review_comment_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neos/flow-development-collection/issues/97/comments","statuses_url":"https://api.github.com/repos/neos/flow-development-collection/statuses/49f09863fe5b440bea0a3cdce2c9ebfb41d78740","head":{"label":"bwaidelich:NEOS-1333","ref":"NEOS-1333","sha":"49f09863fe5b440bea0a3cdce2c9ebfb41d78740","user":{"login":"bwaidelich","id":307571,"avatar_url":"https://avatars.githubusercontent.com/u/307571?v=3","gravatar_id":"","url":"https://api.github.com/users/bwaidelich","html_url":"https://github.com/bwaidelich","followers_url":"https://api.github.com/users/bwaidelich/followers","following_url":"https://api.github.com/users/bwaidelich/following{/other_user}","gists_url":"https://api.github.com/users/bwaidelich/gists{/gist_id}","starred_url":"https://api.github.com/users/bwaidelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwaidelich/subscriptions","organizations_url":"https://api.github.com/users/bwaidelich/orgs","repos_url":"https://api.github.com/users/bwaidelich/repos","events_url":"https://api.github.com/users/bwaidelich/events{/privacy}","received_events_url":"https://api.github.com/users/bwaidelich/received_events","type":"User","site_admin":false},"repo":{"id":41787828,"name":"flow-development-collection","full_name":"bwaidelich/flow-development-collection","owner":{"login":"bwaidelich","id":307571,"avatar_url":"https://avatars.githubusercontent.com/u/307571?v=3","gravatar_id":"","url":"https://api.github.com/users/bwaidelich","html_url":"https://github.com/bwaidelich","followers_url":"https://api.github.com/users/bwaidelich/followers","following_url":"https://api.github.com/users/bwaidelich/following{/other_user}","gists_url":"https://api.github.com/users/bwaidelich/gists{/gist_id}","starred_url":"https://api.github.com/users/bwaidelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwaidelich/subscriptions","organizations_url":"https://api.github.com/users/bwaidelich/orgs","repos_url":"https://api.github.com/users/bwaidelich/repos","events_url":"https://api.github.com/users/bwaidelich/events{/privacy}","received_events_url":"https://api.github.com/users/bwaidelich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bwaidelich/flow-development-collection","description":"The unified repository containing the Flow core packages, used for Flow development.","fork":true,"url":"https://api.github.com/repos/bwaidelich/flow-development-collection","forks_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/forks","keys_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/teams","hooks_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/hooks","issue_events_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/events","assignees_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/tags","blobs_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/languages","stargazers_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/stargazers","contributors_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/contributors","subscribers_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/subscribers","subscription_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/subscription","commits_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/merges","archive_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/downloads","issues_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/releases{/id}","created_at":"2015-09-02T07:54:57Z","updated_at":"2015-09-02T07:55:04Z","pushed_at":"2015-11-02T16:22:34Z","git_url":"git://github.com/bwaidelich/flow-development-collection.git","ssh_url":"git@github.com:bwaidelich/flow-development-collection.git","clone_url":"https://github.com/bwaidelich/flow-development-collection.git","svn_url":"https://github.com/bwaidelich/flow-development-collection","homepage":null,"size":33216,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neos:2.3","ref":"2.3","sha":"9511addd86301a5d4992d408e48174744b6fbaae","user":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"repo":{"id":40963991,"name":"flow-development-collection","full_name":"neos/flow-development-collection","owner":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neos/flow-development-collection","description":"The unified repository containing the Flow core packages, used for Flow development.","fork":false,"url":"https://api.github.com/repos/neos/flow-development-collection","forks_url":"https://api.github.com/repos/neos/flow-development-collection/forks","keys_url":"https://api.github.com/repos/neos/flow-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neos/flow-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neos/flow-development-collection/teams","hooks_url":"https://api.github.com/repos/neos/flow-development-collection/hooks","issue_events_url":"https://api.github.com/repos/neos/flow-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/neos/flow-development-collection/events","assignees_url":"https://api.github.com/repos/neos/flow-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/neos/flow-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/neos/flow-development-collection/tags","blobs_url":"https://api.github.com/repos/neos/flow-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neos/flow-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neos/flow-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/neos/flow-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neos/flow-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/neos/flow-development-collection/languages","stargazers_url":"https://api.github.com/repos/neos/flow-development-collection/stargazers","contributors_url":"https://api.github.com/repos/neos/flow-development-collection/contributors","subscribers_url":"https://api.github.com/repos/neos/flow-development-collection/subscribers","subscription_url":"https://api.github.com/repos/neos/flow-development-collection/subscription","commits_url":"https://api.github.com/repos/neos/flow-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/neos/flow-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/neos/flow-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/neos/flow-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/neos/flow-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/neos/flow-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neos/flow-development-collection/merges","archive_url":"https://api.github.com/repos/neos/flow-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neos/flow-development-collection/downloads","issues_url":"https://api.github.com/repos/neos/flow-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/neos/flow-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/neos/flow-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/neos/flow-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neos/flow-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/neos/flow-development-collection/releases{/id}","created_at":"2015-08-18T09:48:13Z","updated_at":"2015-10-29T12:44:34Z","pushed_at":"2015-11-05T07:08:09Z","git_url":"git://github.com/neos/flow-development-collection.git","ssh_url":"git@github.com:neos/flow-development-collection.git","clone_url":"https://github.com/neos/flow-development-collection.git","svn_url":"https://github.com/neos/flow-development-collection","homepage":null,"size":34774,"stargazers_count":21,"watchers_count":21,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":31,"forks":32,"open_issues":31,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/97"},"html":{"href":"https://github.com/neos/flow-development-collection/pull/97"},"issue":{"href":"https://api.github.com/repos/neos/flow-development-collection/issues/97"},"comments":{"href":"https://api.github.com/repos/neos/flow-development-collection/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/neos/flow-development-collection/statuses/49f09863fe5b440bea0a3cdce2c9ebfb41d78740"}}}}