{"action":"created","issue":{"url":"https://api.github.com/repos/gds-operations/vcloud-launcher/issues/89","labels_url":"https://api.github.com/repos/gds-operations/vcloud-launcher/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/gds-operations/vcloud-launcher/issues/89/comments","events_url":"https://api.github.com/repos/gds-operations/vcloud-launcher/issues/89/events","html_url":"https://github.com/gds-operations/vcloud-launcher/pull/89","id":55134664,"number":89,"title":"Refactor: use Trollop for arg processing. Remove Cli class.","user":{"login":"bazbremner","id":173771,"avatar_url":"https://avatars.githubusercontent.com/u/173771?v=3","gravatar_id":"","url":"https://api.github.com/users/bazbremner","html_url":"https://github.com/bazbremner","followers_url":"https://api.github.com/users/bazbremner/followers","following_url":"https://api.github.com/users/bazbremner/following{/other_user}","gists_url":"https://api.github.com/users/bazbremner/gists{/gist_id}","starred_url":"https://api.github.com/users/bazbremner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazbremner/subscriptions","organizations_url":"https://api.github.com/users/bazbremner/orgs","repos_url":"https://api.github.com/users/bazbremner/repos","events_url":"https://api.github.com/users/bazbremner/events{/privacy}","received_events_url":"https://api.github.com/users/bazbremner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-22T10:03:44Z","updated_at":"2015-01-22T10:50:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gds-operations/vcloud-launcher/pulls/89","html_url":"https://github.com/gds-operations/vcloud-launcher/pull/89","diff_url":"https://github.com/gds-operations/vcloud-launcher/pull/89.diff","patch_url":"https://github.com/gds-operations/vcloud-launcher/pull/89.patch"},"body":"The Cli class is a lot of code and specs around optparser. Trollop is\r\nfar more compact and we can achieve what Cli was doing in significantly\r\nless code.\r\n\r\nTrollop symbolises keys in the opts hash it generates, unlike our\r\nCli/optparser class, so some small changes to follow that.\r\n\r\nDiscussed with @mattbostock in meatspace, this is just a spike to demonstrate what one of the vcloud tools looks like minus a dedicated Cli class. I'd expect to update the other tools to follow suit and possibly look at any command line flag inconsistencies that come of it."},"comment":{"url":"https://api.github.com/repos/gds-operations/vcloud-launcher/issues/comments/71002825","html_url":"https://github.com/gds-operations/vcloud-launcher/pull/89#issuecomment-71002825","issue_url":"https://api.github.com/repos/gds-operations/vcloud-launcher/issues/89","id":71002825,"user":{"login":"annashipman","id":719118,"avatar_url":"https://avatars.githubusercontent.com/u/719118?v=3","gravatar_id":"","url":"https://api.github.com/users/annashipman","html_url":"https://github.com/annashipman","followers_url":"https://api.github.com/users/annashipman/followers","following_url":"https://api.github.com/users/annashipman/following{/other_user}","gists_url":"https://api.github.com/users/annashipman/gists{/gist_id}","starred_url":"https://api.github.com/users/annashipman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annashipman/subscriptions","organizations_url":"https://api.github.com/users/annashipman/orgs","repos_url":"https://api.github.com/users/annashipman/repos","events_url":"https://api.github.com/users/annashipman/events{/privacy}","received_events_url":"https://api.github.com/users/annashipman/received_events","type":"User","site_admin":false},"created_at":"2015-01-22T10:50:00Z","updated_at":"2015-01-22T10:50:00Z","body":"I was going to comment further but then I saw @dcarley's summary with which I entirely agree so I shall back out again :smile:"}}