{"action":"created","comment":{"url":"https://api.github.com/repos/StackStorm/st2/pulls/comments/33677109","id":33677109,"diff_hunk":"@@ -205,6 +209,12 @@ $(VIRTUALENV_DIR)/bin/activate:\n \techo '  functions -e old_deactivate' >> $(VIRTUALENV_DIR)/bin/activate.fish\n \techo 'end' >> $(VIRTUALENV_DIR)/bin/activate.fish\n \ttouch $(VIRTUALENV_DIR)/bin/activate.fish\n+\t\n+\t# Make sure we use latest version of pip\n+\t$(VIRTUALENV_DIR)/bin/pip install --upgrade pip\n+\n+\t# Install stdeb st2client build dependency","path":"Makefile","position":32,"original_position":32,"commit_id":"76be02b1f2bc3e02730d1f85afc45ad802a3f975","original_commit_id":"76be02b1f2bc3e02730d1f85afc45ad802a3f975","user":{"login":"dennybaa","id":891419,"avatar_url":"https://avatars.githubusercontent.com/u/891419?v=3","gravatar_id":"","url":"https://api.github.com/users/dennybaa","html_url":"https://github.com/dennybaa","followers_url":"https://api.github.com/users/dennybaa/followers","following_url":"https://api.github.com/users/dennybaa/following{/other_user}","gists_url":"https://api.github.com/users/dennybaa/gists{/gist_id}","starred_url":"https://api.github.com/users/dennybaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennybaa/subscriptions","organizations_url":"https://api.github.com/users/dennybaa/orgs","repos_url":"https://api.github.com/users/dennybaa/repos","events_url":"https://api.github.com/users/dennybaa/events{/privacy}","received_events_url":"https://api.github.com/users/dennybaa/received_events","type":"User","site_admin":false},"body":"@Kami  what's stdeb?","created_at":"2015-07-01T13:25:15Z","updated_at":"2015-07-01T13:25:15Z","html_url":"https://github.com/StackStorm/st2/pull/1677#discussion_r33677109","pull_request_url":"https://api.github.com/repos/StackStorm/st2/pulls/1677","_links":{"self":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/comments/33677109"},"html":{"href":"https://github.com/StackStorm/st2/pull/1677#discussion_r33677109"},"pull_request":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/1677"}}},"pull_request":{"url":"https://api.github.com/repos/StackStorm/st2/pulls/1677","id":38971770,"html_url":"https://github.com/StackStorm/st2/pull/1677","diff_url":"https://github.com/StackStorm/st2/pull/1677.diff","patch_url":"https://github.com/StackStorm/st2/pull/1677.patch","issue_url":"https://api.github.com/repos/StackStorm/st2/issues/1677","number":1677,"state":"open","locked":false,"title":"[WIP] Setuptools packaging improvements - make each st2 component packagable and installable via package","user":{"login":"Kami","id":125088,"avatar_url":"https://avatars.githubusercontent.com/u/125088?v=3","gravatar_id":"","url":"https://api.github.com/users/Kami","html_url":"https://github.com/Kami","followers_url":"https://api.github.com/users/Kami/followers","following_url":"https://api.github.com/users/Kami/following{/other_user}","gists_url":"https://api.github.com/users/Kami/gists{/gist_id}","starred_url":"https://api.github.com/users/Kami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kami/subscriptions","organizations_url":"https://api.github.com/users/Kami/orgs","repos_url":"https://api.github.com/users/Kami/repos","events_url":"https://api.github.com/users/Kami/events{/privacy}","received_events_url":"https://api.github.com/users/Kami/received_events","type":"User","site_admin":false},"body":"This pull requests builds on top of of #1647 and #1668.\r\n\r\nI spent a lot of time finishing, polishing and testing all the changes from #1668 locally. Everything worked and looked fine so I decided to merge it into master. Sadly this turned out to be a mistake - there were many, many issues with packaging and other workflows used by our CI.\r\n\r\nAfter 3-4 hours of digging in and fixing issues, I still haven't managed to fix all of them so I decided to revert changes in the master and unbreak it. I believe that's better than trying to rush to whole thing. Next step will be to address all the issues and run all the packaging and related workflows on this branch and only merge it into master when everything passes.\r\n\r\nI will work with / ask @DoriftoShoes for help with running everything on a particular branch (not sure if we are there yet, might require some changes).\r\n\r\nThe biggest offenders currently are:\r\n\r\n- [x] Making sure we use pip >= 6.0.0 everywhere. I believe I managed to fix this by using virtualenv everywhere, but there might still be issues somewhere.\r\n- [x] Getting rid of the \"recursive-include\" abuse in the `MANIFEST.in` and replacing it with collecting all the code packages inside the `setup.py `files.\r\n\r\nThis branch includes the following changes and improvements:\r\n\r\n1. Add new ``dist_utils.py`` module which is copied over to each component during build step and used inside setup.py instead of copy and pasting code over in setup.py.\r\n2. Update all the setup.py files to include ``license`` and ``url`` attribute.\r\n3. Add ``long_description`` attribute to each setup.py file. This attribute is generated by combining together ``README.rest`` and ``CHANGELOG.rst`` file.\r\n4. Port README from Markdown to rst (needed because of 3).\r\n5. Add new ``sdist`` Makefilet target which generates ``.tar.gz`` and ``wheel`` archive for each component.\r\n6. Update setup.py files to use ``__version`` attribute from each package __init__.py file. For now we simply copy over __init__.py from st2common. This way we don't break out existing release / build workflow, but eventually we should move to per-package version.\r\n7. Removed unused dependencies: `flask`, `flask_json`. This was actually done by @dennybaa, but I verified the changes and I'm pointing it out there to make it easier to track.\r\n8. Sort the requirements before writing them in the ``requirements.txt`` file. This way we make sure generated requirements files are always sorted the same.\r\n\r\nTO FIX:\r\n\r\n- [ ] mistral_itests workflow fails (times out) on CI. I dug into it, but I couldn't reproduce the problem. It works fine locally and it also works fine if I manually run commands on the CI server.\r\n- [ ] st2_deploy_tests workflow fails on CI. I believe I've fixed the RHEL issue, but I don't know what's wrong with the Ubuntu one.\r\n","created_at":"2015-07-01T11:16:53Z","updated_at":"2015-07-01T13:25:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6449ee70ce967ef911873d40b7ee7fb7cac533ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/StackStorm/st2/pulls/1677/commits","review_comments_url":"https://api.github.com/repos/StackStorm/st2/pulls/1677/comments","review_comment_url":"https://api.github.com/repos/StackStorm/st2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StackStorm/st2/issues/1677/comments","statuses_url":"https://api.github.com/repos/StackStorm/st2/statuses/76be02b1f2bc3e02730d1f85afc45ad802a3f975","head":{"label":"StackStorm:setuptools_packaging_improvements","ref":"setuptools_packaging_improvements","sha":"76be02b1f2bc3e02730d1f85afc45ad802a3f975","user":{"login":"StackStorm","id":4969009,"avatar_url":"https://avatars.githubusercontent.com/u/4969009?v=3","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"repo":{"id":19051806,"name":"st2","full_name":"StackStorm/st2","owner":{"login":"StackStorm","id":4969009,"avatar_url":"https://avatars.githubusercontent.com/u/4969009?v=3","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StackStorm/st2","description":"StackStorm event driven automation code.  With workflow, rules engine, many to many integration and more.  Aka IFTTT for Ops (uber orchestration).  Ping us on IRC #stackstorm. ","fork":false,"url":"https://api.github.com/repos/StackStorm/st2","forks_url":"https://api.github.com/repos/StackStorm/st2/forks","keys_url":"https://api.github.com/repos/StackStorm/st2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StackStorm/st2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StackStorm/st2/teams","hooks_url":"https://api.github.com/repos/StackStorm/st2/hooks","issue_events_url":"https://api.github.com/repos/StackStorm/st2/issues/events{/number}","events_url":"https://api.github.com/repos/StackStorm/st2/events","assignees_url":"https://api.github.com/repos/StackStorm/st2/assignees{/user}","branches_url":"https://api.github.com/repos/StackStorm/st2/branches{/branch}","tags_url":"https://api.github.com/repos/StackStorm/st2/tags","blobs_url":"https://api.github.com/repos/StackStorm/st2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StackStorm/st2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StackStorm/st2/git/refs{/sha}","trees_url":"https://api.github.com/repos/StackStorm/st2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StackStorm/st2/statuses/{sha}","languages_url":"https://api.github.com/repos/StackStorm/st2/languages","stargazers_url":"https://api.github.com/repos/StackStorm/st2/stargazers","contributors_url":"https://api.github.com/repos/StackStorm/st2/contributors","subscribers_url":"https://api.github.com/repos/StackStorm/st2/subscribers","subscription_url":"https://api.github.com/repos/StackStorm/st2/subscription","commits_url":"https://api.github.com/repos/StackStorm/st2/commits{/sha}","git_commits_url":"https://api.github.com/repos/StackStorm/st2/git/commits{/sha}","comments_url":"https://api.github.com/repos/StackStorm/st2/comments{/number}","issue_comment_url":"https://api.github.com/repos/StackStorm/st2/issues/comments{/number}","contents_url":"https://api.github.com/repos/StackStorm/st2/contents/{+path}","compare_url":"https://api.github.com/repos/StackStorm/st2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StackStorm/st2/merges","archive_url":"https://api.github.com/repos/StackStorm/st2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StackStorm/st2/downloads","issues_url":"https://api.github.com/repos/StackStorm/st2/issues{/number}","pulls_url":"https://api.github.com/repos/StackStorm/st2/pulls{/number}","milestones_url":"https://api.github.com/repos/StackStorm/st2/milestones{/number}","notifications_url":"https://api.github.com/repos/StackStorm/st2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StackStorm/st2/labels{/name}","releases_url":"https://api.github.com/repos/StackStorm/st2/releases{/id}","created_at":"2014-04-23T00:51:34Z","updated_at":"2015-06-30T17:10:14Z","pushed_at":"2015-07-01T13:22:16Z","git_url":"git://github.com/StackStorm/st2.git","ssh_url":"git@github.com:StackStorm/st2.git","clone_url":"https://github.com/StackStorm/st2.git","svn_url":"https://github.com/StackStorm/st2","homepage":"http://www.stackstorm.com/","size":25195,"stargazers_count":229,"watchers_count":229,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":30,"forks":46,"open_issues":30,"watchers":229,"default_branch":"master"}},"base":{"label":"StackStorm:master","ref":"master","sha":"7213b755c94e50db131b716a538aa23fd26f76f1","user":{"login":"StackStorm","id":4969009,"avatar_url":"https://avatars.githubusercontent.com/u/4969009?v=3","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"repo":{"id":19051806,"name":"st2","full_name":"StackStorm/st2","owner":{"login":"StackStorm","id":4969009,"avatar_url":"https://avatars.githubusercontent.com/u/4969009?v=3","gravatar_id":"","url":"https://api.github.com/users/StackStorm","html_url":"https://github.com/StackStorm","followers_url":"https://api.github.com/users/StackStorm/followers","following_url":"https://api.github.com/users/StackStorm/following{/other_user}","gists_url":"https://api.github.com/users/StackStorm/gists{/gist_id}","starred_url":"https://api.github.com/users/StackStorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StackStorm/subscriptions","organizations_url":"https://api.github.com/users/StackStorm/orgs","repos_url":"https://api.github.com/users/StackStorm/repos","events_url":"https://api.github.com/users/StackStorm/events{/privacy}","received_events_url":"https://api.github.com/users/StackStorm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StackStorm/st2","description":"StackStorm event driven automation code.  With workflow, rules engine, many to many integration and more.  Aka IFTTT for Ops (uber orchestration).  Ping us on IRC #stackstorm. ","fork":false,"url":"https://api.github.com/repos/StackStorm/st2","forks_url":"https://api.github.com/repos/StackStorm/st2/forks","keys_url":"https://api.github.com/repos/StackStorm/st2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StackStorm/st2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StackStorm/st2/teams","hooks_url":"https://api.github.com/repos/StackStorm/st2/hooks","issue_events_url":"https://api.github.com/repos/StackStorm/st2/issues/events{/number}","events_url":"https://api.github.com/repos/StackStorm/st2/events","assignees_url":"https://api.github.com/repos/StackStorm/st2/assignees{/user}","branches_url":"https://api.github.com/repos/StackStorm/st2/branches{/branch}","tags_url":"https://api.github.com/repos/StackStorm/st2/tags","blobs_url":"https://api.github.com/repos/StackStorm/st2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StackStorm/st2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StackStorm/st2/git/refs{/sha}","trees_url":"https://api.github.com/repos/StackStorm/st2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StackStorm/st2/statuses/{sha}","languages_url":"https://api.github.com/repos/StackStorm/st2/languages","stargazers_url":"https://api.github.com/repos/StackStorm/st2/stargazers","contributors_url":"https://api.github.com/repos/StackStorm/st2/contributors","subscribers_url":"https://api.github.com/repos/StackStorm/st2/subscribers","subscription_url":"https://api.github.com/repos/StackStorm/st2/subscription","commits_url":"https://api.github.com/repos/StackStorm/st2/commits{/sha}","git_commits_url":"https://api.github.com/repos/StackStorm/st2/git/commits{/sha}","comments_url":"https://api.github.com/repos/StackStorm/st2/comments{/number}","issue_comment_url":"https://api.github.com/repos/StackStorm/st2/issues/comments{/number}","contents_url":"https://api.github.com/repos/StackStorm/st2/contents/{+path}","compare_url":"https://api.github.com/repos/StackStorm/st2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StackStorm/st2/merges","archive_url":"https://api.github.com/repos/StackStorm/st2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StackStorm/st2/downloads","issues_url":"https://api.github.com/repos/StackStorm/st2/issues{/number}","pulls_url":"https://api.github.com/repos/StackStorm/st2/pulls{/number}","milestones_url":"https://api.github.com/repos/StackStorm/st2/milestones{/number}","notifications_url":"https://api.github.com/repos/StackStorm/st2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StackStorm/st2/labels{/name}","releases_url":"https://api.github.com/repos/StackStorm/st2/releases{/id}","created_at":"2014-04-23T00:51:34Z","updated_at":"2015-06-30T17:10:14Z","pushed_at":"2015-07-01T13:22:16Z","git_url":"git://github.com/StackStorm/st2.git","ssh_url":"git@github.com:StackStorm/st2.git","clone_url":"https://github.com/StackStorm/st2.git","svn_url":"https://github.com/StackStorm/st2","homepage":"http://www.stackstorm.com/","size":25195,"stargazers_count":229,"watchers_count":229,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":30,"forks":46,"open_issues":30,"watchers":229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/1677"},"html":{"href":"https://github.com/StackStorm/st2/pull/1677"},"issue":{"href":"https://api.github.com/repos/StackStorm/st2/issues/1677"},"comments":{"href":"https://api.github.com/repos/StackStorm/st2/issues/1677/comments"},"review_comments":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/1677/comments"},"review_comment":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StackStorm/st2/pulls/1677/commits"},"statuses":{"href":"https://api.github.com/repos/StackStorm/st2/statuses/76be02b1f2bc3e02730d1f85afc45ad802a3f975"}}}}