{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/40850076","id":40850076,"diff_hunk":"@@ -570,7 +575,11 @@\n                                                          (tasks-fn out-stream-id values))\n                                              rooted? (and message-id has-ackers?)\n                                              root-id (if rooted? (MessageId/generateId rand))\n-                                             out-ids (fast-list-for [t out-tasks] (if rooted? (MessageId/generateId rand)))]\n+                                             out-ids (fast-list-for [t out-tasks] (if rooted? (MessageId/generateId rand)))\n+                                             sampler? (sampler)]\n+                                         (when sampler?\n+                                           (.notify rate-tracker (count out-tasks))","path":"storm-core/src/clj/backtype/storm/daemon/executor.clj","position":154,"original_position":154,"commit_id":"066e234bcf141525c0a1ed4a04f6d3cf160f6c28","original_commit_id":"066e234bcf141525c0a1ed4a04f6d3cf160f6c28","user":{"login":"revans2","id":3441321,"avatar_url":"https://avatars.githubusercontent.com/u/3441321?v=3","gravatar_id":"","url":"https://api.github.com/users/revans2","html_url":"https://github.com/revans2","followers_url":"https://api.github.com/users/revans2/followers","following_url":"https://api.github.com/users/revans2/following{/other_user}","gists_url":"https://api.github.com/users/revans2/gists{/gist_id}","starred_url":"https://api.github.com/users/revans2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revans2/subscriptions","organizations_url":"https://api.github.com/users/revans2/orgs","repos_url":"https://api.github.com/users/revans2/repos","events_url":"https://api.github.com/users/revans2/events{/privacy}","received_events_url":"https://api.github.com/users/revans2/received_events","type":"User","site_admin":false},"body":"Wait I just thought about this again.  How in the world can we get an accurate rate if we are only counting a subset of the tuples?  Wouldn't we also have to increase the rate proportionally to the sampling rate?","created_at":"2015-09-30T20:53:16Z","updated_at":"2015-09-30T20:53:16Z","html_url":"https://github.com/apache/storm/pull/753#discussion_r40850076","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/753","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/40850076"},"html":{"href":"https://github.com/apache/storm/pull/753#discussion_r40850076"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/753"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/753","id":45660450,"html_url":"https://github.com/apache/storm/pull/753","diff_url":"https://github.com/apache/storm/pull/753.diff","patch_url":"https://github.com/apache/storm/pull/753.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/753","number":753,"state":"open","locked":false,"title":"[STORM-1057] Add throughput metrics to spouts/bolts and display them on web ui","user":{"login":"wangli1426","id":5260276,"avatar_url":"https://avatars.githubusercontent.com/u/5260276?v=3","gravatar_id":"","url":"https://api.github.com/users/wangli1426","html_url":"https://github.com/wangli1426","followers_url":"https://api.github.com/users/wangli1426/followers","following_url":"https://api.github.com/users/wangli1426/following{/other_user}","gists_url":"https://api.github.com/users/wangli1426/gists{/gist_id}","starred_url":"https://api.github.com/users/wangli1426/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangli1426/subscriptions","organizations_url":"https://api.github.com/users/wangli1426/orgs","repos_url":"https://api.github.com/users/wangli1426/repos","events_url":"https://api.github.com/users/wangli1426/events{/privacy}","received_events_url":"https://api.github.com/users/wangli1426/received_events","type":"User","site_admin":false},"body":"The throughputs for the spouts and bolts could help the user to identify the performance bottleneck and detect the load balancing issue. In this RP, I take measurements on the throughput of the executors and display them on web UI.\r\n\r\n### Summary of Changes\r\n1. Take throughput measurements on the spouts and bolts;\r\n2. Add throughput to ExecutorStats;\r\n3. Display the throughputs on web UI.\r\n\r\n\r\n**Note: If you cannot see the throughputs on your web UI, please clean your browser cache and try again.**\r\n### Screenshots\r\n\r\n![screen shot 2015-09-21 at 13 16 01](https://cloud.githubusercontent.com/assets/5260276/9987644/3e3b5720-607c-11e5-928c-ec49892b67f6.png)\r\n![screen shot 2015-09-21 at 13 17 24](https://cloud.githubusercontent.com/assets/5260276/9987684/953e7048-607c-11e5-9188-b0f8ba1c7943.png)\r\n![screen shot 2015-09-21 at 13 17 57](https://cloud.githubusercontent.com/assets/5260276/9987686/96ab9dc0-607c-11e5-954d-2369069b22d6.png)\r\n![screen shot 2015-09-21 at 13 18 49](https://cloud.githubusercontent.com/assets/5260276/9987687/999e7e26-607c-11e5-99e4-0ac8d31b8768.png)","created_at":"2015-09-22T13:06:29Z","updated_at":"2015-09-30T20:53:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a8b2837f057d14f0c65ba312b5d5ac0c0206ac3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/753/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/753/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/753/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/066e234bcf141525c0a1ed4a04f6d3cf160f6c28","head":{"label":"wangli1426:throughput-metrics","ref":"throughput-metrics","sha":"066e234bcf141525c0a1ed4a04f6d3cf160f6c28","user":{"login":"wangli1426","id":5260276,"avatar_url":"https://avatars.githubusercontent.com/u/5260276?v=3","gravatar_id":"","url":"https://api.github.com/users/wangli1426","html_url":"https://github.com/wangli1426","followers_url":"https://api.github.com/users/wangli1426/followers","following_url":"https://api.github.com/users/wangli1426/following{/other_user}","gists_url":"https://api.github.com/users/wangli1426/gists{/gist_id}","starred_url":"https://api.github.com/users/wangli1426/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangli1426/subscriptions","organizations_url":"https://api.github.com/users/wangli1426/orgs","repos_url":"https://api.github.com/users/wangli1426/repos","events_url":"https://api.github.com/users/wangli1426/events{/privacy}","received_events_url":"https://api.github.com/users/wangli1426/received_events","type":"User","site_admin":false},"repo":{"id":40603295,"name":"storm","full_name":"wangli1426/storm","owner":{"login":"wangli1426","id":5260276,"avatar_url":"https://avatars.githubusercontent.com/u/5260276?v=3","gravatar_id":"","url":"https://api.github.com/users/wangli1426","html_url":"https://github.com/wangli1426","followers_url":"https://api.github.com/users/wangli1426/followers","following_url":"https://api.github.com/users/wangli1426/following{/other_user}","gists_url":"https://api.github.com/users/wangli1426/gists{/gist_id}","starred_url":"https://api.github.com/users/wangli1426/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangli1426/subscriptions","organizations_url":"https://api.github.com/users/wangli1426/orgs","repos_url":"https://api.github.com/users/wangli1426/repos","events_url":"https://api.github.com/users/wangli1426/events{/privacy}","received_events_url":"https://api.github.com/users/wangli1426/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wangli1426/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/wangli1426/storm","forks_url":"https://api.github.com/repos/wangli1426/storm/forks","keys_url":"https://api.github.com/repos/wangli1426/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wangli1426/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wangli1426/storm/teams","hooks_url":"https://api.github.com/repos/wangli1426/storm/hooks","issue_events_url":"https://api.github.com/repos/wangli1426/storm/issues/events{/number}","events_url":"https://api.github.com/repos/wangli1426/storm/events","assignees_url":"https://api.github.com/repos/wangli1426/storm/assignees{/user}","branches_url":"https://api.github.com/repos/wangli1426/storm/branches{/branch}","tags_url":"https://api.github.com/repos/wangli1426/storm/tags","blobs_url":"https://api.github.com/repos/wangli1426/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wangli1426/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wangli1426/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/wangli1426/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wangli1426/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/wangli1426/storm/languages","stargazers_url":"https://api.github.com/repos/wangli1426/storm/stargazers","contributors_url":"https://api.github.com/repos/wangli1426/storm/contributors","subscribers_url":"https://api.github.com/repos/wangli1426/storm/subscribers","subscription_url":"https://api.github.com/repos/wangli1426/storm/subscription","commits_url":"https://api.github.com/repos/wangli1426/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/wangli1426/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/wangli1426/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/wangli1426/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/wangli1426/storm/contents/{+path}","compare_url":"https://api.github.com/repos/wangli1426/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wangli1426/storm/merges","archive_url":"https://api.github.com/repos/wangli1426/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wangli1426/storm/downloads","issues_url":"https://api.github.com/repos/wangli1426/storm/issues{/number}","pulls_url":"https://api.github.com/repos/wangli1426/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/wangli1426/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/wangli1426/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wangli1426/storm/labels{/name}","releases_url":"https://api.github.com/repos/wangli1426/storm/releases{/id}","created_at":"2015-08-12T13:50:17Z","updated_at":"2015-08-14T11:15:48Z","pushed_at":"2015-09-22T14:17:35Z","git_url":"git://github.com/wangli1426/storm.git","ssh_url":"git@github.com:wangli1426/storm.git","clone_url":"https://github.com/wangli1426/storm.git","svn_url":"https://github.com/wangli1426/storm","homepage":null,"size":19892,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"397d2d8a7bcca79aa3f9c7b33482ced897e074f9","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","created_at":"2013-11-05T08:00:14Z","updated_at":"2015-09-30T20:40:51Z","pushed_at":"2015-09-30T20:12:55Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":850913,"stargazers_count":2405,"watchers_count":2405,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1728,"mirror_url":"git://git.apache.org/incubator-storm.git","open_issues_count":90,"forks":1728,"open_issues":90,"watchers":2405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/753"},"html":{"href":"https://github.com/apache/storm/pull/753"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/753"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/753/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/753/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/753/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/066e234bcf141525c0a1ed4a04f6d3cf160f6c28"}}}}