{"action":"created","comment":{"url":"https://api.github.com/repos/novoda/image-loader/pulls/comments/23727422","id":23727422,"diff_hunk":"@@ -4,10 +4,4 @@\n \n     String getFileName(String sourceUrl, T metadata);\n \n-    T extractMetadata(String fileName);\n-\n-    boolean hasMetadata(String file);\n-\n-    String getCacheDirectory();","path":"core/src/main/java/com/novoda/pxfetcher/FileNameFactory.java","position":15,"original_position":8,"commit_id":"3438d4e10f9d7813d5cdf936a004d81fb972de6a","original_commit_id":"81e1fba725da068b3bd562d9cb6865cc44aa242e","user":{"login":"blundell","id":655860,"avatar_url":"https://avatars.githubusercontent.com/u/655860?v=3","gravatar_id":"","url":"https://api.github.com/users/blundell","html_url":"https://github.com/blundell","followers_url":"https://api.github.com/users/blundell/followers","following_url":"https://api.github.com/users/blundell/following{/other_user}","gists_url":"https://api.github.com/users/blundell/gists{/gist_id}","starred_url":"https://api.github.com/users/blundell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blundell/subscriptions","organizations_url":"https://api.github.com/users/blundell/orgs","repos_url":"https://api.github.com/users/blundell/repos","events_url":"https://api.github.com/users/blundell/events{/privacy}","received_events_url":"https://api.github.com/users/blundell/received_events","type":"User","site_admin":false},"body":"This is probably a good place to organise a quick hangout between the people that know (not me!) @ataulm @Dorvaryn @friedger ?","created_at":"2015-01-28T21:56:38Z","updated_at":"2015-01-28T21:56:38Z","html_url":"https://github.com/novoda/image-loader/pull/206#discussion_r23727422","pull_request_url":"https://api.github.com/repos/novoda/image-loader/pulls/206","_links":{"self":{"href":"https://api.github.com/repos/novoda/image-loader/pulls/comments/23727422"},"html":{"href":"https://github.com/novoda/image-loader/pull/206#discussion_r23727422"},"pull_request":{"href":"https://api.github.com/repos/novoda/image-loader/pulls/206"}}},"pull_request":{"url":"https://api.github.com/repos/novoda/image-loader/pulls/206","id":28119218,"html_url":"https://github.com/novoda/image-loader/pull/206","diff_url":"https://github.com/novoda/image-loader/pull/206.diff","patch_url":"https://github.com/novoda/image-loader/pull/206.patch","issue_url":"https://api.github.com/repos/novoda/image-loader/issues/206","number":206,"state":"open","locked":false,"title":"189/Simplify filenamefactory","user":{"login":"friedger","id":1449049,"avatar_url":"https://avatars.githubusercontent.com/u/1449049?v=3","gravatar_id":"","url":"https://api.github.com/users/friedger","html_url":"https://github.com/friedger","followers_url":"https://api.github.com/users/friedger/followers","following_url":"https://api.github.com/users/friedger/following{/other_user}","gists_url":"https://api.github.com/users/friedger/gists{/gist_id}","starred_url":"https://api.github.com/users/friedger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedger/subscriptions","organizations_url":"https://api.github.com/users/friedger/orgs","repos_url":"https://api.github.com/users/friedger/repos","events_url":"https://api.github.com/users/friedger/events{/privacy}","received_events_url":"https://api.github.com/users/friedger/received_events","type":"User","site_admin":false},"body":"Depends on PR #205 \r\n\r\nJust remove unused methods so that the purpose of the factory is clear","created_at":"2015-01-27T15:51:42Z","updated_at":"2015-01-28T21:56:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6955cd13eee032213bddbc130f25a122e6193f95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/novoda/image-loader/pulls/206/commits","review_comments_url":"https://api.github.com/repos/novoda/image-loader/pulls/206/comments","review_comment_url":"https://api.github.com/repos/novoda/image-loader/pulls/comments/{number}","comments_url":"https://api.github.com/repos/novoda/image-loader/issues/206/comments","statuses_url":"https://api.github.com/repos/novoda/image-loader/statuses/3438d4e10f9d7813d5cdf936a004d81fb972de6a","head":{"label":"novoda:189/simplify_filenamefactory","ref":"189/simplify_filenamefactory","sha":"3438d4e10f9d7813d5cdf936a004d81fb972de6a","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":2161802,"name":"image-loader","full_name":"novoda/image-loader","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/image-loader","description":"Library for async image loading and caching on Android","fork":false,"url":"https://api.github.com/repos/novoda/image-loader","forks_url":"https://api.github.com/repos/novoda/image-loader/forks","keys_url":"https://api.github.com/repos/novoda/image-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/image-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/image-loader/teams","hooks_url":"https://api.github.com/repos/novoda/image-loader/hooks","issue_events_url":"https://api.github.com/repos/novoda/image-loader/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/image-loader/events","assignees_url":"https://api.github.com/repos/novoda/image-loader/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/image-loader/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/image-loader/tags","blobs_url":"https://api.github.com/repos/novoda/image-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/image-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/image-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/image-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/image-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/image-loader/languages","stargazers_url":"https://api.github.com/repos/novoda/image-loader/stargazers","contributors_url":"https://api.github.com/repos/novoda/image-loader/contributors","subscribers_url":"https://api.github.com/repos/novoda/image-loader/subscribers","subscription_url":"https://api.github.com/repos/novoda/image-loader/subscription","commits_url":"https://api.github.com/repos/novoda/image-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/image-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/image-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/image-loader/issues/comments/{number}","contents_url":"https://api.github.com/repos/novoda/image-loader/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/image-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/image-loader/merges","archive_url":"https://api.github.com/repos/novoda/image-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/image-loader/downloads","issues_url":"https://api.github.com/repos/novoda/image-loader/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/image-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/image-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/image-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/image-loader/labels{/name}","releases_url":"https://api.github.com/repos/novoda/image-loader/releases{/id}","created_at":"2011-08-05T18:05:02Z","updated_at":"2015-01-28T13:49:44Z","pushed_at":"2015-01-28T21:00:28Z","git_url":"git://github.com/novoda/image-loader.git","ssh_url":"git@github.com:novoda/image-loader.git","clone_url":"https://github.com/novoda/image-loader.git","svn_url":"https://github.com/novoda/image-loader","homepage":"","size":6307,"stargazers_count":890,"watchers_count":890,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":317,"mirror_url":null,"open_issues_count":36,"forks":317,"open_issues":36,"watchers":890,"default_branch":"develop"}},"base":{"label":"novoda:develop","ref":"develop","sha":"db4b040a209d319c05625ede835c5db850268706","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":2161802,"name":"image-loader","full_name":"novoda/image-loader","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/image-loader","description":"Library for async image loading and caching on Android","fork":false,"url":"https://api.github.com/repos/novoda/image-loader","forks_url":"https://api.github.com/repos/novoda/image-loader/forks","keys_url":"https://api.github.com/repos/novoda/image-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/image-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/image-loader/teams","hooks_url":"https://api.github.com/repos/novoda/image-loader/hooks","issue_events_url":"https://api.github.com/repos/novoda/image-loader/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/image-loader/events","assignees_url":"https://api.github.com/repos/novoda/image-loader/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/image-loader/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/image-loader/tags","blobs_url":"https://api.github.com/repos/novoda/image-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/image-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/image-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/image-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/image-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/image-loader/languages","stargazers_url":"https://api.github.com/repos/novoda/image-loader/stargazers","contributors_url":"https://api.github.com/repos/novoda/image-loader/contributors","subscribers_url":"https://api.github.com/repos/novoda/image-loader/subscribers","subscription_url":"https://api.github.com/repos/novoda/image-loader/subscription","commits_url":"https://api.github.com/repos/novoda/image-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/image-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/image-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/image-loader/issues/comments/{number}","contents_url":"https://api.github.com/repos/novoda/image-loader/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/image-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/image-loader/merges","archive_url":"https://api.github.com/repos/novoda/image-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/image-loader/downloads","issues_url":"https://api.github.com/repos/novoda/image-loader/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/image-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/image-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/image-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/image-loader/labels{/name}","releases_url":"https://api.github.com/repos/novoda/image-loader/releases{/id}","created_at":"2011-08-05T18:05:02Z","updated_at":"2015-01-28T13:49:44Z","pushed_at":"2015-01-28T21:00:28Z","git_url":"git://github.com/novoda/image-loader.git","ssh_url":"git@github.com:novoda/image-loader.git","clone_url":"https://github.com/novoda/image-loader.git","svn_url":"https://github.com/novoda/image-loader","homepage":"","size":6307,"stargazers_count":890,"watchers_count":890,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":317,"mirror_url":null,"open_issues_count":36,"forks":317,"open_issues":36,"watchers":890,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/novoda/image-loader/pulls/206"},"html":{"href":"https://github.com/novoda/image-loader/pull/206"},"issue":{"href":"https://api.github.com/repos/novoda/image-loader/issues/206"},"comments":{"href":"https://api.github.com/repos/novoda/image-loader/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/novoda/image-loader/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/novoda/image-loader/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/novoda/image-loader/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/novoda/image-loader/statuses/3438d4e10f9d7813d5cdf936a004d81fb972de6a"}}}}