{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/37795757","id":37795757,"diff_hunk":"@@ -780,10 +799,16 @@ static void ProcessTriangleInternal(const Shader::OutputVertex& v0,\n             }\n \n             u8 old_stencil = 0;\n+\n+            auto UpdateStencil = [stencil_test, x, y, &old_stencil](Pica::Regs::StencilAction action) {","path":"src/video_core/rasterizer.cpp","position":44,"original_position":44,"commit_id":"583d777b1a844259e6a389c420281388fce68dc4","original_commit_id":"583d777b1a844259e6a389c420281388fce68dc4","user":{"login":"Subv","id":357072,"avatar_url":"https://avatars.githubusercontent.com/u/357072?v=3","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"body":"I disagree, SetStencil does a bunch of other stuff related to the format and swizzling, id prefer if this code remains separate ","created_at":"2015-08-24T19:51:05Z","updated_at":"2015-08-24T19:51:05Z","html_url":"https://github.com/citra-emu/citra/pull/1049#discussion_r37795757","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/1049","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/37795757"},"html":{"href":"https://github.com/citra-emu/citra/pull/1049#discussion_r37795757"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1049"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/1049","id":42773578,"html_url":"https://github.com/citra-emu/citra/pull/1049","diff_url":"https://github.com/citra-emu/citra/pull/1049.diff","patch_url":"https://github.com/citra-emu/citra/pull/1049.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/1049","number":1049,"state":"open","locked":false,"title":"Rasterizer: Corrected the stencil implementation.","user":{"login":"Subv","id":357072,"avatar_url":"https://avatars.githubusercontent.com/u/357072?v=3","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"body":"And implemented stencil in the hw renderer.\r\nImplemented more stencil functions.\r\n\r\nThis was verified using hw tests, some of which can be found [here](https://gist.github.com/Subv/692aaf09d4593018bbcc).\r\n\r\nI'll update the information on 3dbrew later.\r\n\r\nFixes #1039 and _maybe_ some of the problems with #1041\r\n\r\nhwtests: https://github.com/Subv/3ds-homebrew/tree/master/gpu_stencil_tests\r\n\r\nThere's currently a bug related to changing the stencil buffer with the OpenGL renderer, it seems to only happen on Intel and is apparently a driver bug, a report has been filed [here](https://communities.intel.com/message/324464)","created_at":"2015-08-19T03:28:36Z","updated_at":"2015-08-24T19:51:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81eb363ce3c157057843f9f8ca048f5817bd0780","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/1049/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/1049/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/1049/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/583d777b1a844259e6a389c420281388fce68dc4","head":{"label":"Subv:stencil","ref":"stencil","sha":"583d777b1a844259e6a389c420281388fce68dc4","user":{"login":"Subv","id":357072,"avatar_url":"https://avatars.githubusercontent.com/u/357072?v=3","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"repo":{"id":22818827,"name":"citra","full_name":"Subv/citra","owner":{"login":"Subv","id":357072,"avatar_url":"https://avatars.githubusercontent.com/u/357072?v=3","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Subv/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/Subv/citra","forks_url":"https://api.github.com/repos/Subv/citra/forks","keys_url":"https://api.github.com/repos/Subv/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Subv/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Subv/citra/teams","hooks_url":"https://api.github.com/repos/Subv/citra/hooks","issue_events_url":"https://api.github.com/repos/Subv/citra/issues/events{/number}","events_url":"https://api.github.com/repos/Subv/citra/events","assignees_url":"https://api.github.com/repos/Subv/citra/assignees{/user}","branches_url":"https://api.github.com/repos/Subv/citra/branches{/branch}","tags_url":"https://api.github.com/repos/Subv/citra/tags","blobs_url":"https://api.github.com/repos/Subv/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Subv/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Subv/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/Subv/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Subv/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/Subv/citra/languages","stargazers_url":"https://api.github.com/repos/Subv/citra/stargazers","contributors_url":"https://api.github.com/repos/Subv/citra/contributors","subscribers_url":"https://api.github.com/repos/Subv/citra/subscribers","subscription_url":"https://api.github.com/repos/Subv/citra/subscription","commits_url":"https://api.github.com/repos/Subv/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/Subv/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/Subv/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/Subv/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/Subv/citra/contents/{+path}","compare_url":"https://api.github.com/repos/Subv/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Subv/citra/merges","archive_url":"https://api.github.com/repos/Subv/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Subv/citra/downloads","issues_url":"https://api.github.com/repos/Subv/citra/issues{/number}","pulls_url":"https://api.github.com/repos/Subv/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/Subv/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/Subv/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Subv/citra/labels{/name}","releases_url":"https://api.github.com/repos/Subv/citra/releases{/id}","created_at":"2014-08-10T21:13:43Z","updated_at":"2015-05-07T23:57:36Z","pushed_at":"2015-08-24T16:29:13Z","git_url":"git://github.com/Subv/citra.git","ssh_url":"git@github.com:Subv/citra.git","clone_url":"https://github.com/Subv/citra.git","svn_url":"https://github.com/Subv/citra","homepage":null,"size":10757,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"d6a5a00c24daa90911d39734baa5283ca3c67f0b","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","created_at":"2014-05-16T18:33:15Z","updated_at":"2015-08-24T18:52:27Z","pushed_at":"2015-08-24T17:02:44Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":23194,"stargazers_count":1058,"watchers_count":1058,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":264,"mirror_url":null,"open_issues_count":86,"forks":264,"open_issues":86,"watchers":1058,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1049"},"html":{"href":"https://github.com/citra-emu/citra/pull/1049"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/1049"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/1049/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1049/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/1049/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/583d777b1a844259e6a389c420281388fce68dc4"}}}}