{"action":"created","issue":{"url":"https://api.github.com/repos/ripple/ripple-lib/issues/333","labels_url":"https://api.github.com/repos/ripple/ripple-lib/issues/333/labels{/name}","comments_url":"https://api.github.com/repos/ripple/ripple-lib/issues/333/comments","events_url":"https://api.github.com/repos/ripple/ripple-lib/issues/333/events","html_url":"https://github.com/ripple/ripple-lib/pull/333","id":72309997,"number":333,"title":"Use Deterministic Signatures (RFC 6979)","user":{"login":"harryprotist","id":3362563,"avatar_url":"https://avatars.githubusercontent.com/u/3362563?v=3","gravatar_id":"","url":"https://api.github.com/users/harryprotist","html_url":"https://github.com/harryprotist","followers_url":"https://api.github.com/users/harryprotist/followers","following_url":"https://api.github.com/users/harryprotist/following{/other_user}","gists_url":"https://api.github.com/users/harryprotist/gists{/gist_id}","starred_url":"https://api.github.com/users/harryprotist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harryprotist/subscriptions","organizations_url":"https://api.github.com/users/harryprotist/orgs","repos_url":"https://api.github.com/users/harryprotist/repos","events_url":"https://api.github.com/users/harryprotist/events{/privacy}","received_events_url":"https://api.github.com/users/harryprotist/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2015-04-30T23:32:02Z","updated_at":"2015-05-18T23:01:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ripple/ripple-lib/pulls/333","html_url":"https://github.com/ripple/ripple-lib/pull/333","diff_url":"https://github.com/ripple/ripple-lib/pull/333.diff","patch_url":"https://github.com/ripple/ripple-lib/pull/333.patch"},"body":"Adds `signDeterministic` function to `sjcl.ecc.ecdsa.secretKey`, which uses a deterministically generated ephemeral key instead of the usual random one. \r\n\r\nUses HMAC for generating the ephemeral key, as described in [RFC 6979](http://tools.ietf.org/html/rfc6979). It uses the implementation of HMAC from sjcl, and whatever hash is passed to the function (default sjcl.hash.sha256).\r\n\r\nAdds signDeterministic and tests for signDeterministic, modifies recoverablepublic key and tests for it, removes validecc.js and uses the sjcl sign and verify functions instead."},"comment":{"url":"https://api.github.com/repos/ripple/ripple-lib/issues/comments/103242968","html_url":"https://github.com/ripple/ripple-lib/pull/333#issuecomment-103242968","issue_url":"https://api.github.com/repos/ripple/ripple-lib/issues/333","id":103242968,"user":{"login":"harryprotist","id":3362563,"avatar_url":"https://avatars.githubusercontent.com/u/3362563?v=3","gravatar_id":"","url":"https://api.github.com/users/harryprotist","html_url":"https://github.com/harryprotist","followers_url":"https://api.github.com/users/harryprotist/followers","following_url":"https://api.github.com/users/harryprotist/following{/other_user}","gists_url":"https://api.github.com/users/harryprotist/gists{/gist_id}","starred_url":"https://api.github.com/users/harryprotist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harryprotist/subscriptions","organizations_url":"https://api.github.com/users/harryprotist/orgs","repos_url":"https://api.github.com/users/harryprotist/repos","events_url":"https://api.github.com/users/harryprotist/events{/privacy}","received_events_url":"https://api.github.com/users/harryprotist/received_events","type":"User","site_admin":false},"created_at":"2015-05-18T23:01:38Z","updated_at":"2015-05-18T23:01:38Z","body":"i started getting that too after I merged with your change from develop that removes linter errors. Was that present in that commit, or did I just mess up the merge?"}}