{"push_id":681951846,"size":12,"distinct_size":12,"ref":"refs/heads/master","head":"71cc675572654c4e22e10150a909c3ab048233cf","before":"94df2050dd6085c7afcd8bcee8ff0cd111444b47","commits":[{"sha":"df2809f04e6df31e2b36bac08704d8f27e04a0ad","author":{"email":"7ea35d812706d9213868749011af1ed4fa2f6aa0@google.com","name":"Austin Clements"},"message":"runtime: document that runtime.GC() blocks until GC is complete\n\nruntime.GC() is intentionally very weakly specified. However, it is so\nweakly specified that it's difficult to know that it's being used\ncorrectly for its one intended use case: to ensure garbage collection\nhas run in a test that is garbage-sensitive. In particular, it is\nunclear whether it is synchronous or asynchronous. In the old STW\ncollector this was essentially self-evident; short of queuing up a\ngarbage collection to run later, it had to be synchronous. However,\nwith the concurrent collector, there's evidence that people are\ninferring that it may be asynchronous (e.g., issue #10986), as this is\nboth unclear in the documentation and possible in the implementation.\n\nIn fact, runtime.GC() runs a fully synchronous STW collection. We\nprobably don't want to commit to this exact behavior. But we can\ncommit to the essential property that tests rely on: that runtime.GC()\ndoes not return until the GC has finished.\n\nChange-Id: Ifc3045a505e1898ecdbe32c1f7e80e2e9ffacb5b\nReviewed-on: https://go-review.googlesource.com/10488\nReviewed-by: Keith Randall <khr@golang.org>\nReviewed-by: Rick Hudson <rlh@golang.org>","distinct":true,"url":"https://api.github.com/repos/bsmr-go/go/commits/df2809f04e6df31e2b36bac08704d8f27e04a0ad"},{"sha":"bc8e129366ebc4244026884319c68c31c3127853","author":{"email":"4dc7c9ec434ed06502767136789763ec11d2c4b7@golang.org","name":"Rob Pike"},"message":"encoding/gob: fix infinite recursion caused by ignoring recursive type\n\nThis was a simple oversight: the algorithm to handle recursive types\nneeded to be applied to the ignore-item case as well.\n\nFixes #10415.\n\nChange-Id: I39ef31cad680ab8334e141f60d2f8707896785d1\nReviewed-on: https://go-review.googlesource.com/8942\nReviewed-by: Dmitry Vyukov <dvyukov@google.com>","distinct":true,"url":"https://api.github.com/repos/bsmr-go/go/commits/bc8e129366ebc4244026884319c68c31c3127853"},{"sha":"8801bdf2b3cb8f3d59664f56fba7eeb7a2cf0bdb","author":{"email":"b565fbd08cb369eb6666bcfc4fc10d41b38d2885@gmail.com","name":"Aamir Khan"},"message":"text/template: template must be initialized at the time of creation\n\nt.init() should be called at the time of template creation\ni.e, template.New() and t.New() instead of later in the process.\n\n- Removed calls of t.init() from t.Parse(), t.Execute(), t.Funcs()\n- Also got rid of t.common != nil checks as it should never be nil\n\nFixes #10879\n\nChange-Id: I1b7ac812f02c841ae80037babce7e2b0a2df13e8\nReviewed-on: https://go-review.googlesource.com/10240\nReviewed-by: Rob Pike <r@golang.org>","distinct":true,"url":"https://api.github.com/repos/bsmr-go/go/commits/8801bdf2b3cb8f3d59664f56fba7eeb7a2cf0bdb"},{"sha":"e15f89c526ec464a78b5e76279090cba785c1326","author":{"email":"af2599c5a5fd48633e3f1d058bfadfe70711a6a3@gmail.com","name":"Konstantin Shaposhnikov"},"message":"cmd/doc: try better when looking for package dir\n\nWhen go doc is invoked with a single package name argument (e.g. go doc pkgname)\nit needs to find the directory of the requested package sources in GOPATH.\n\nGOPATH might contain directories with the same name as the requested package\nthat do no contain any *.go files. This change makes \"go doc\" ignore such\ndirectories when looking for possible package directories.\n\nThis fixes #10882\n\nChange-Id: Ib3d4ea69a25801c34cbe7b044de9870ba12f9aa8\nReviewed-on: https://go-review.googlesource.com/10190\nReviewed-by: Rob Pike <r@golang.org>","distinct":true,"url":"https://api.github.com/repos/bsmr-go/go/commits/e15f89c526ec464a78b5e76279090cba785c1326"},{"sha":"ae38ef4cdf2e8cf843b9d3872e66586327d744ae","author":{"email":"4dc7c9ec434ed06502767136789763ec11d2c4b7@golang.org","name":"Rob Pike"},"message":"regexp: suggest go doc, not godoc\n\nIn 1.6, go doc is more likely to be available.\n\nChange-Id: I970ad1d3317b35273f5c8d830f75713d3570c473\nReviewed-on: https://go-review.googlesource.com/10518\nReviewed-by: Andrew Gerrand <adg@golang.org>","distinct":true,"url":"https://api.github.com/repos/bsmr-go/go/commits/ae38ef4cdf2e8cf843b9d3872e66586327d744ae"},{"sha":"f6853369c315d69a77163756e916e784bfe2e281","author":{"email":"39a219e50b35b2484efaaa187fda16b27b6c5abe@gmail.com","name":"Didier Spezia"},"message":"html/template: prevent panic when escaping actions involving chain nodes\n\nThe current escape code panics when an action involves chain nodes.\nSuch nodes can be seen in the following situation:\n\n{{ . | AAA.B }} - AAA being a registered function\n\nThe above expression is actually valid, because AAA could return a\nmap containing a B key. The tests in text/template explicitly\ndemonstrate this case.\n\nFix allIdents to cover also chain nodes.\n\nWhile I was investigating this issue, I realized that the tests\nintroduced in similar CL 9621 were incorrect. Parse errors were\ncaught as expected, but for the wrong reason. Fixed them as well.\nNo changes in text/template code itself.\n\nFixes #10801\n\nChange-Id: Ic9fe43b63669298ca52c3f499e2725dd2bb818a8\nReviewed-on: https://go-review.googlesource.com/10340\nReviewed-by: Rob Pike <r@golang.org>","distinct":true,"url":"https://api.github.com/repos/bsmr-go/go/commits/f6853369c315d69a77163756e916e784bfe2e281"},{"sha":"5c60a4fb0a7f49105e2daa10efe45faf2bf3a36b","author":{"email":"39a219e50b35b2484efaaa187fda16b27b6c5abe@gmail.com","name":"Didier Spezia"},"message":"text/template: fix variadic function call corner case\n\nExecuting a template involving variadic functions featuring\na []interface{} slice (such as printf) could result in a\npanic in reflect.Value.Call, due to incorrect type checking.\n\nThe following expressions failed (with a panic):\n{{true|printf}}\n{{1|printf}}\n{{1.1|printf}}\n{{'x'|printf}}\n{{1+2i|printf}}\n\nImplemented proper type checks for the fixed parameters of the\nvariadic functions.\n\nFixes #10946\n\nChange-Id: Ia75333f651f73b3d2e024cb0c47cc30d90cb6852\nReviewed-on: https://go-review.googlesource.com/10403\nReviewed-by: Rob Pike <r@golang.org>","distinct":true,"url":"https://api.github.com/repos/bsmr-go/go/commits/5c60a4fb0a7f49105e2daa10efe45faf2bf3a36b"},{"sha":"f04e7bb1cf73a493999c236471456847a8eafc41","author":{"email":"e277c7a50d2dbeb0023053996d86a8fb90b98f5a@gmail.com","name":"Alexandre Cesaro"},"message":"mime: fix names of examples\n\nThe names of examples were wrong so they were not shown in\nthe documentation.\n\nChange-Id: Ib1b985b44d2e056c38c008a591cb441e422c4717\nReviewed-on: https://go-review.googlesource.com/10404\nRun-TryBot: Brad Fitzpatrick <bradfitz@golang.org>\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>\nTryBot-Result: Gobot Gobot <gobot@golang.org>","distinct":true,"url":"https://api.github.com/repos/bsmr-go/go/commits/f04e7bb1cf73a493999c236471456847a8eafc41"},{"sha":"26301b6cfda5888a625c546e57024ac28336ac18","author":{"email":"bfcdf3e6ca6cef45543bfbb57509c92aec9a39fb@cheney.net","name":"Dave Cheney"},"message":"cmd/cover: fix missing error check in test\n\nFix missing error check in test.\n\nSpotted by Gordon Klass, https://groups.google.com/forum/#!topic/golang-nuts/MdDLbvOjb4o\n\nChange-Id: I22f1a438cbb60a2fe1740fc2d43fbf8aa008b6de\nReviewed-on: https://go-review.googlesource.com/10605\nReviewed-by: Brad Fitzpatrick <bradfitz@golang.org>","distinct":true,"url":"https://api.github.com/repos/bsmr-go/go/commits/26301b6cfda5888a625c546e57024ac28336ac18"},{"sha":"1831e1ec3725c987c42aef81264433a219756226","author":{"email":"bfcdf3e6ca6cef45543bfbb57509c92aec9a39fb@cheney.net","name":"Dave Cheney"},"message":"cmd/pprof/internal/profile: fix missing error check\n\nFix missing error check.\n\nSpotted by Gordon Klass, https://groups.google.com/forum/#!topic/golang-nuts/MdDLbvOjb4o\n\nChange-Id: I453a0cf032e0077d2622d5b85030310d159b9c4b\nReviewed-on: https://go-review.googlesource.com/10606\nReviewed-by: Nigel Tao <nigeltao@golang.org>","distinct":true,"url":"https://api.github.com/repos/bsmr-go/go/commits/1831e1ec3725c987c42aef81264433a219756226"},{"sha":"f6d43b746a683b63f93999f07a27db79be1ca146","author":{"email":"bfcdf3e6ca6cef45543bfbb57509c92aec9a39fb@cheney.net","name":"Dave Cheney"},"message":"net: fix undetected set and not used error\n\nFixes an error where the compiler did not spot that the shadowed err\nvalue was set again after being read. That second assignment was lost\nas the value was redeclared in an inner scope.\n\nSpotted by Gordon Klass, https://groups.google.com/forum/#!topic/golang-nuts/MdDLbvOjb4o\n\nChange-Id: I28f2da6f98c52afcbb45e17d2b4f36c586598f98\nReviewed-on: https://go-review.googlesource.com/10600\nReviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>","distinct":true,"url":"https://api.github.com/repos/bsmr-go/go/commits/f6d43b746a683b63f93999f07a27db79be1ca146"},{"sha":"71cc675572654c4e22e10150a909c3ab048233cf","author":{"email":"a6752097faebf1f02d80107d77a9be009089afe3@golang.org","name":"Robert Griesemer"},"message":"math/big: implement fmt.Formatter-compatible (*Float).Format\n\nChange-Id: I22fdba8ecaecf4e9201b845e65d982cac09f254a\nReviewed-on: https://go-review.googlesource.com/10499\nReviewed-by: Alan Donovan <adonovan@google.com>","distinct":true,"url":"https://api.github.com/repos/bsmr-go/go/commits/71cc675572654c4e22e10150a909c3ab048233cf"}]}