{"action":"created","issue":{"url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/issues/132","labels_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/issues/132/labels{/name}","comments_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/issues/132/comments","events_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/issues/132/events","html_url":"https://github.com/MiniProfiler/rack-mini-profiler/pull/132","id":63848147,"number":132,"title":"UI Submodule","user":{"login":"thomas-mcdonald","id":197928,"avatar_url":"https://avatars.githubusercontent.com/u/197928?v=3","gravatar_id":"","url":"https://api.github.com/users/thomas-mcdonald","html_url":"https://github.com/thomas-mcdonald","followers_url":"https://api.github.com/users/thomas-mcdonald/followers","following_url":"https://api.github.com/users/thomas-mcdonald/following{/other_user}","gists_url":"https://api.github.com/users/thomas-mcdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/thomas-mcdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomas-mcdonald/subscriptions","organizations_url":"https://api.github.com/users/thomas-mcdonald/orgs","repos_url":"https://api.github.com/users/thomas-mcdonald/repos","events_url":"https://api.github.com/users/thomas-mcdonald/events{/privacy}","received_events_url":"https://api.github.com/users/thomas-mcdonald/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-23T22:24:45Z","updated_at":"2015-03-24T01:05:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/pulls/132","html_url":"https://github.com/MiniProfiler/rack-mini-profiler/pull/132","diff_url":"https://github.com/MiniProfiler/rack-mini-profiler/pull/132.diff","patch_url":"https://github.com/MiniProfiler/rack-mini-profiler/pull/132.patch"},"body":"Just throwing an *early* PR up for my work on switching the mini profiler to use the UI repository\r\n\r\nStuff to do:\r\n- [x] fix tests\r\n- [ ] refactor struct classes?\r\n- [x] finish converting all request data into UI format - fairly sure some of this can be trimmed off (looks like time without child duration is now computed clientside, for example)\r\n- [ ] switch to using `include.partial.html` over `profile_handler.js`\r\n"},"comment":{"url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/issues/comments/85271933","html_url":"https://github.com/MiniProfiler/rack-mini-profiler/pull/132#issuecomment-85271933","issue_url":"https://api.github.com/repos/MiniProfiler/rack-mini-profiler/issues/132","id":85271933,"user":{"login":"SamSaffron","id":5213,"avatar_url":"https://avatars.githubusercontent.com/u/5213?v=3","gravatar_id":"","url":"https://api.github.com/users/SamSaffron","html_url":"https://github.com/SamSaffron","followers_url":"https://api.github.com/users/SamSaffron/followers","following_url":"https://api.github.com/users/SamSaffron/following{/other_user}","gists_url":"https://api.github.com/users/SamSaffron/gists{/gist_id}","starred_url":"https://api.github.com/users/SamSaffron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamSaffron/subscriptions","organizations_url":"https://api.github.com/users/SamSaffron/orgs","repos_url":"https://api.github.com/users/SamSaffron/repos","events_url":"https://api.github.com/users/SamSaffron/events{/privacy}","received_events_url":"https://api.github.com/users/SamSaffron/received_events","type":"User","site_admin":false},"created_at":"2015-03-24T01:05:05Z","updated_at":"2015-03-24T01:05:05Z","body":"Can you make sure no new functionality that we added since the fork is\nlost?\n\nFor example recently I added the ability to highlight slow queries in the\nquery list (which needs to be ported back into the UI project) I can work\nwith you on merging all the fixes / changes into UI first before we take on\nthe dependency.\n\nOn Tue, Mar 24, 2015 at 11:55 AM, Thomas McDonald <notifications@github.com>\nwrote:\n\n> @SamSaffron <https://github.com/SamSaffron> pretty roughly 'done'. Would\n> probably hang off refactoring structs too much until this is merged. things\n> I'm not sure about/uncomfortable with:\n>\n>    - :has_user_viewed key in the Page struct, looks like it should maybe\n>    be a property since it shouldn't be returned to the client? Similarly with\n>    the :user key\n>    - I pulled the type attribute off of custom structs, since it seems to\n>    have no value except for setting the column name in CustomTimings\n>    - Strange capitalised keys everywhere [image: :frowning:]\n>\n> Aside from that, the last thing that needs doing it switching the html\n> file/options that are inserted for the <script> tag, but I've done far\n> too much procrastinating for one evening.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/MiniProfiler/rack-mini-profiler/pull/132#issuecomment-85268917>\n> .\n>\n"}}