{"action":"closed","number":2594,"pull_request":{"url":"https://api.github.com/repos/concrete5/concrete5/pulls/2594","id":37650895,"html_url":"https://github.com/concrete5/concrete5/pull/2594","diff_url":"https://github.com/concrete5/concrete5/pull/2594.diff","patch_url":"https://github.com/concrete5/concrete5/pull/2594.patch","issue_url":"https://api.github.com/repos/concrete5/concrete5/issues/2594","number":2594,"state":"closed","locked":false,"title":"Stack block type javascript","user":{"login":"ChrisHougard","id":1550925,"avatar_url":"https://avatars.githubusercontent.com/u/1550925?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisHougard","html_url":"https://github.com/ChrisHougard","followers_url":"https://api.github.com/users/ChrisHougard/followers","following_url":"https://api.github.com/users/ChrisHougard/following{/other_user}","gists_url":"https://api.github.com/users/ChrisHougard/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisHougard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisHougard/subscriptions","organizations_url":"https://api.github.com/users/ChrisHougard/orgs","repos_url":"https://api.github.com/users/ChrisHougard/repos","events_url":"https://api.github.com/users/ChrisHougard/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisHougard/received_events","type":"User","site_admin":false},"body":"This code makes the stacks block type javascript behave the same way as the javascript for a normal block type. On a custom editing page this code causes problems because:\r\n+ CCM_ID is the ID of the current page, which is ok when editing a normal page but not when editing a collection from another page. A normal block type uses data-cid to store the destination collection ID, which for stacks was changed to the stack collection ID. Instead, I added a new attribute to store the stack collection ID and kept the same behavior for the collection ID.\r\n+ ConcretePanelManager.exitPanelMode() is not needed here when editing a normal page because the panel will already have been closed. When used on a dashboard page it actually closes the side navigation page. In addition, a normal block type will close open dialogs, which stacks previously do not do.","created_at":"2015-06-14T23:43:26Z","updated_at":"2015-06-16T22:55:17Z","closed_at":"2015-06-16T22:55:17Z","merged_at":"2015-06-16T22:55:17Z","merge_commit_sha":"be63304369970fdcdc419cdec2ee8b7635d5f1c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/concrete5/concrete5/pulls/2594/commits","review_comments_url":"https://api.github.com/repos/concrete5/concrete5/pulls/2594/comments","review_comment_url":"https://api.github.com/repos/concrete5/concrete5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/concrete5/concrete5/issues/2594/comments","statuses_url":"https://api.github.com/repos/concrete5/concrete5/statuses/5301ccce7a5c35b6937597d94885703db300994a","head":{"label":"ExchangeCore:stack-blocks","ref":"stack-blocks","sha":"5301ccce7a5c35b6937597d94885703db300994a","user":{"login":"ExchangeCore","id":7229913,"avatar_url":"https://avatars.githubusercontent.com/u/7229913?v=3","gravatar_id":"","url":"https://api.github.com/users/ExchangeCore","html_url":"https://github.com/ExchangeCore","followers_url":"https://api.github.com/users/ExchangeCore/followers","following_url":"https://api.github.com/users/ExchangeCore/following{/other_user}","gists_url":"https://api.github.com/users/ExchangeCore/gists{/gist_id}","starred_url":"https://api.github.com/users/ExchangeCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExchangeCore/subscriptions","organizations_url":"https://api.github.com/users/ExchangeCore/orgs","repos_url":"https://api.github.com/users/ExchangeCore/repos","events_url":"https://api.github.com/users/ExchangeCore/events{/privacy}","received_events_url":"https://api.github.com/users/ExchangeCore/received_events","type":"Organization","site_admin":false},"repo":{"id":19051532,"name":"concrete5-5.7.0","full_name":"ExchangeCore/concrete5-5.7.0","owner":{"login":"ExchangeCore","id":7229913,"avatar_url":"https://avatars.githubusercontent.com/u/7229913?v=3","gravatar_id":"","url":"https://api.github.com/users/ExchangeCore","html_url":"https://github.com/ExchangeCore","followers_url":"https://api.github.com/users/ExchangeCore/followers","following_url":"https://api.github.com/users/ExchangeCore/following{/other_user}","gists_url":"https://api.github.com/users/ExchangeCore/gists{/gist_id}","starred_url":"https://api.github.com/users/ExchangeCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExchangeCore/subscriptions","organizations_url":"https://api.github.com/users/ExchangeCore/orgs","repos_url":"https://api.github.com/users/ExchangeCore/repos","events_url":"https://api.github.com/users/ExchangeCore/events{/privacy}","received_events_url":"https://api.github.com/users/ExchangeCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ExchangeCore/concrete5-5.7.0","description":"ExchangeCore development fork of Concrete5","fork":true,"url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0","forks_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/forks","keys_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/teams","hooks_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/hooks","issue_events_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/issues/events{/number}","events_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/events","assignees_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/assignees{/user}","branches_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/branches{/branch}","tags_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/tags","blobs_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/git/refs{/sha}","trees_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/statuses/{sha}","languages_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/languages","stargazers_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/stargazers","contributors_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/contributors","subscribers_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/subscribers","subscription_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/subscription","commits_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/commits{/sha}","git_commits_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/git/commits{/sha}","comments_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/comments{/number}","issue_comment_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/issues/comments{/number}","contents_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/contents/{+path}","compare_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/merges","archive_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/downloads","issues_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/issues{/number}","pulls_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/pulls{/number}","milestones_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/milestones{/number}","notifications_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/labels{/name}","releases_url":"https://api.github.com/repos/ExchangeCore/concrete5-5.7.0/releases{/id}","created_at":"2014-04-23T00:38:01Z","updated_at":"2015-05-02T02:02:00Z","pushed_at":"2015-06-16T02:27:32Z","git_url":"git://github.com/ExchangeCore/concrete5-5.7.0.git","ssh_url":"git@github.com:ExchangeCore/concrete5-5.7.0.git","clone_url":"https://github.com/ExchangeCore/concrete5-5.7.0.git","svn_url":"https://github.com/ExchangeCore/concrete5-5.7.0","homepage":"","size":116375,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"concrete5:develop","ref":"develop","sha":"c4ee9809675050a2d7aab36dc90b1fbdd1ab4b7e","user":{"login":"concrete5","id":657929,"avatar_url":"https://avatars.githubusercontent.com/u/657929?v=3","gravatar_id":"","url":"https://api.github.com/users/concrete5","html_url":"https://github.com/concrete5","followers_url":"https://api.github.com/users/concrete5/followers","following_url":"https://api.github.com/users/concrete5/following{/other_user}","gists_url":"https://api.github.com/users/concrete5/gists{/gist_id}","starred_url":"https://api.github.com/users/concrete5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concrete5/subscriptions","organizations_url":"https://api.github.com/users/concrete5/orgs","repos_url":"https://api.github.com/users/concrete5/repos","events_url":"https://api.github.com/users/concrete5/events{/privacy}","received_events_url":"https://api.github.com/users/concrete5/received_events","type":"Organization","site_admin":false},"repo":{"id":19040482,"name":"concrete5","full_name":"concrete5/concrete5","owner":{"login":"concrete5","id":657929,"avatar_url":"https://avatars.githubusercontent.com/u/657929?v=3","gravatar_id":"","url":"https://api.github.com/users/concrete5","html_url":"https://github.com/concrete5","followers_url":"https://api.github.com/users/concrete5/followers","following_url":"https://api.github.com/users/concrete5/following{/other_user}","gists_url":"https://api.github.com/users/concrete5/gists{/gist_id}","starred_url":"https://api.github.com/users/concrete5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concrete5/subscriptions","organizations_url":"https://api.github.com/users/concrete5/orgs","repos_url":"https://api.github.com/users/concrete5/repos","events_url":"https://api.github.com/users/concrete5/events{/privacy}","received_events_url":"https://api.github.com/users/concrete5/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concrete5/concrete5","description":"Official repository for concrete5 5.7 development","fork":false,"url":"https://api.github.com/repos/concrete5/concrete5","forks_url":"https://api.github.com/repos/concrete5/concrete5/forks","keys_url":"https://api.github.com/repos/concrete5/concrete5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concrete5/concrete5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concrete5/concrete5/teams","hooks_url":"https://api.github.com/repos/concrete5/concrete5/hooks","issue_events_url":"https://api.github.com/repos/concrete5/concrete5/issues/events{/number}","events_url":"https://api.github.com/repos/concrete5/concrete5/events","assignees_url":"https://api.github.com/repos/concrete5/concrete5/assignees{/user}","branches_url":"https://api.github.com/repos/concrete5/concrete5/branches{/branch}","tags_url":"https://api.github.com/repos/concrete5/concrete5/tags","blobs_url":"https://api.github.com/repos/concrete5/concrete5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concrete5/concrete5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concrete5/concrete5/git/refs{/sha}","trees_url":"https://api.github.com/repos/concrete5/concrete5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concrete5/concrete5/statuses/{sha}","languages_url":"https://api.github.com/repos/concrete5/concrete5/languages","stargazers_url":"https://api.github.com/repos/concrete5/concrete5/stargazers","contributors_url":"https://api.github.com/repos/concrete5/concrete5/contributors","subscribers_url":"https://api.github.com/repos/concrete5/concrete5/subscribers","subscription_url":"https://api.github.com/repos/concrete5/concrete5/subscription","commits_url":"https://api.github.com/repos/concrete5/concrete5/commits{/sha}","git_commits_url":"https://api.github.com/repos/concrete5/concrete5/git/commits{/sha}","comments_url":"https://api.github.com/repos/concrete5/concrete5/comments{/number}","issue_comment_url":"https://api.github.com/repos/concrete5/concrete5/issues/comments{/number}","contents_url":"https://api.github.com/repos/concrete5/concrete5/contents/{+path}","compare_url":"https://api.github.com/repos/concrete5/concrete5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concrete5/concrete5/merges","archive_url":"https://api.github.com/repos/concrete5/concrete5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concrete5/concrete5/downloads","issues_url":"https://api.github.com/repos/concrete5/concrete5/issues{/number}","pulls_url":"https://api.github.com/repos/concrete5/concrete5/pulls{/number}","milestones_url":"https://api.github.com/repos/concrete5/concrete5/milestones{/number}","notifications_url":"https://api.github.com/repos/concrete5/concrete5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concrete5/concrete5/labels{/name}","releases_url":"https://api.github.com/repos/concrete5/concrete5/releases{/id}","created_at":"2014-04-22T18:12:28Z","updated_at":"2015-06-11T15:02:09Z","pushed_at":"2015-06-16T22:55:17Z","git_url":"git://github.com/concrete5/concrete5.git","ssh_url":"git@github.com:concrete5/concrete5.git","clone_url":"https://github.com/concrete5/concrete5.git","svn_url":"https://github.com/concrete5/concrete5","homepage":"","size":159907,"stargazers_count":153,"watchers_count":153,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":169,"mirror_url":null,"open_issues_count":277,"forks":169,"open_issues":277,"watchers":153,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/2594"},"html":{"href":"https://github.com/concrete5/concrete5/pull/2594"},"issue":{"href":"https://api.github.com/repos/concrete5/concrete5/issues/2594"},"comments":{"href":"https://api.github.com/repos/concrete5/concrete5/issues/2594/comments"},"review_comments":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/2594/comments"},"review_comment":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/2594/commits"},"statuses":{"href":"https://api.github.com/repos/concrete5/concrete5/statuses/5301ccce7a5c35b6937597d94885703db300994a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"aembler","id":527809,"avatar_url":"https://avatars.githubusercontent.com/u/527809?v=3","gravatar_id":"","url":"https://api.github.com/users/aembler","html_url":"https://github.com/aembler","followers_url":"https://api.github.com/users/aembler/followers","following_url":"https://api.github.com/users/aembler/following{/other_user}","gists_url":"https://api.github.com/users/aembler/gists{/gist_id}","starred_url":"https://api.github.com/users/aembler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aembler/subscriptions","organizations_url":"https://api.github.com/users/aembler/orgs","repos_url":"https://api.github.com/users/aembler/repos","events_url":"https://api.github.com/users/aembler/events{/privacy}","received_events_url":"https://api.github.com/users/aembler/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":6,"deletions":5,"changed_files":2}}