{"action":"created","issue":{"url":"https://api.github.com/repos/jquery/jquery/issues/2667","labels_url":"https://api.github.com/repos/jquery/jquery/issues/2667/labels{/name}","comments_url":"https://api.github.com/repos/jquery/jquery/issues/2667/comments","events_url":"https://api.github.com/repos/jquery/jquery/issues/2667/events","html_url":"https://github.com/jquery/jquery/issues/2667","id":112211404,"number":2667,"title":"Update event.which to avoid deprecated properties","user":{"login":"khigakisugar","id":10406395,"avatar_url":"https://avatars.githubusercontent.com/u/10406395?v=3","gravatar_id":"","url":"https://api.github.com/users/khigakisugar","html_url":"https://github.com/khigakisugar","followers_url":"https://api.github.com/users/khigakisugar/followers","following_url":"https://api.github.com/users/khigakisugar/following{/other_user}","gists_url":"https://api.github.com/users/khigakisugar/gists{/gist_id}","starred_url":"https://api.github.com/users/khigakisugar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khigakisugar/subscriptions","organizations_url":"https://api.github.com/users/khigakisugar/orgs","repos_url":"https://api.github.com/users/khigakisugar/repos","events_url":"https://api.github.com/users/khigakisugar/events{/privacy}","received_events_url":"https://api.github.com/users/khigakisugar/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-19T19:08:19Z","updated_at":"2015-10-20T17:55:30Z","closed_at":"2015-10-20T01:17:22Z","body":"Version: Master\r\n\r\nDescription: The `event.keyCode` and `event.charCode are deprecated and used by jQuery's `event.which` https://github.com/jquery/jquery/blob/e99a3ac7066226d00ff5828de596d4a4b3818c0c/src/event.js#L544\r\n\r\nFor information about the deprecation, please refer to MDN:\r\nhttps://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode\r\nhttps://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/charCode\r\n\r\nJS Fiddle (limited usefulness in this case):\r\nhttp://jsfiddle.net/mqaxhuj3/"},"comment":{"url":"https://api.github.com/repos/jquery/jquery/issues/comments/149647372","html_url":"https://github.com/jquery/jquery/issues/2667#issuecomment-149647372","issue_url":"https://api.github.com/repos/jquery/jquery/issues/2667","id":149647372,"user":{"login":"rhoggSugarcrm","id":10406503,"avatar_url":"https://avatars.githubusercontent.com/u/10406503?v=3","gravatar_id":"","url":"https://api.github.com/users/rhoggSugarcrm","html_url":"https://github.com/rhoggSugarcrm","followers_url":"https://api.github.com/users/rhoggSugarcrm/followers","following_url":"https://api.github.com/users/rhoggSugarcrm/following{/other_user}","gists_url":"https://api.github.com/users/rhoggSugarcrm/gists{/gist_id}","starred_url":"https://api.github.com/users/rhoggSugarcrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhoggSugarcrm/subscriptions","organizations_url":"https://api.github.com/users/rhoggSugarcrm/orgs","repos_url":"https://api.github.com/users/rhoggSugarcrm/repos","events_url":"https://api.github.com/users/rhoggSugarcrm/events{/privacy}","received_events_url":"https://api.github.com/users/rhoggSugarcrm/received_events","type":"User","site_admin":false},"created_at":"2015-10-20T17:55:30Z","updated_at":"2015-10-20T17:55:30Z","body":"No, this isn't due to console messages from Firefox - this was just the result of @khigakisugar and I realizing that `KeyboardEvent.keyCode` is deprecated and looking for a better solution.\r\n\r\nWhile the DOM method `KeyboardEvent.which` is marked as deprecated, `event.which` is not listed as deprecated at https://api.jquery.com/event.which/.\r\n\r\nIMHO, what would be most helpful, both to us and any other potential future users of `event.which`, would be a deprecation notice on the JQuery web page and some text there recommending something to use instead. `KeyboardEvent.key` isn't really a viable option for us (at least without manually falling back to something else) until Chrome and Safari support for it is finished."}}