{"action":"created","comment":{"url":"https://api.github.com/repos/yegor256/takes/pulls/comments/47722231","id":47722231,"diff_hunk":"@@ -0,0 +1,65 @@\n+/**\n+ * The MIT License (MIT)\n+ *\n+ * Copyright (c) 2015 Yegor Bugayenko\n+ *\n+ * Permission is hereby granted, free of charge, to any person obtaining a copy\n+ * of this software and associated documentation files (the \"Software\"), to deal\n+ * in the Software without restriction, including without limitation the rights\n+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+ * copies of the Software, and to permit persons to whom the Software is\n+ * furnished to do so, subject to the following conditions:\n+ *\n+ * The above copyright notice and this permission notice shall be included\n+ * in all copies or substantial portions of the Software.\n+ *\n+ * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+ * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE\n+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE\n+ * SOFTWARE.\n+ */\n+package org.takes.misc;\n+\n+import java.io.ByteArrayInputStream;\n+import java.io.IOException;\n+import java.util.concurrent.atomic.AtomicBoolean;\n+\n+/**\n+ * Converts supplied string to an input stream encoded as bytes in default\n+ * encoding.\n+ *\n+ * @author I. Sokolov (happy.neko@gmail.com)\n+ * @version $Id$\n+ */\n+public final class MockInputStream extends ByteArrayInputStream {","path":"src/test/java/org/takes/misc/MockInputStream.java","position":37,"original_position":37,"commit_id":"dc4fdbbf7c71ef3017654dc351506a5985994f0c","original_commit_id":"dc4fdbbf7c71ef3017654dc351506a5985994f0c","user":{"login":"carlosmiranda","id":1917892,"avatar_url":"https://avatars.githubusercontent.com/u/1917892?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosmiranda","html_url":"https://github.com/carlosmiranda","followers_url":"https://api.github.com/users/carlosmiranda/followers","following_url":"https://api.github.com/users/carlosmiranda/following{/other_user}","gists_url":"https://api.github.com/users/carlosmiranda/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosmiranda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosmiranda/subscriptions","organizations_url":"https://api.github.com/users/carlosmiranda/orgs","repos_url":"https://api.github.com/users/carlosmiranda/repos","events_url":"https://api.github.com/users/carlosmiranda/events{/privacy}","received_events_url":"https://api.github.com/users/carlosmiranda/received_events","type":"User","site_admin":false},"body":"@Happy-Neko Why do we need this class? It is very problematic. It's named as if it were a mock but is actually doing String encoding. Then it extends `ByteArrayInputStream`, but only initializes the internal array to a string value. No need for a separate class for that.","created_at":"2015-12-16T00:41:12Z","updated_at":"2015-12-16T00:41:12Z","html_url":"https://github.com/yegor256/takes/pull/465#discussion_r47722231","pull_request_url":"https://api.github.com/repos/yegor256/takes/pulls/465","_links":{"self":{"href":"https://api.github.com/repos/yegor256/takes/pulls/comments/47722231"},"html":{"href":"https://github.com/yegor256/takes/pull/465#discussion_r47722231"},"pull_request":{"href":"https://api.github.com/repos/yegor256/takes/pulls/465"}}},"pull_request":{"url":"https://api.github.com/repos/yegor256/takes/pulls/465","id":53639978,"html_url":"https://github.com/yegor256/takes/pull/465","diff_url":"https://github.com/yegor256/takes/pull/465.diff","patch_url":"https://github.com/yegor256/takes/pull/465.patch","issue_url":"https://api.github.com/repos/yegor256/takes/issues/465","number":465,"state":"open","locked":false,"title":"#442: RsVelocity.render() should close template's InputStream","user":{"login":"Happy-Neko","id":11806,"avatar_url":"https://avatars.githubusercontent.com/u/11806?v=3","gravatar_id":"","url":"https://api.github.com/users/Happy-Neko","html_url":"https://github.com/Happy-Neko","followers_url":"https://api.github.com/users/Happy-Neko/followers","following_url":"https://api.github.com/users/Happy-Neko/following{/other_user}","gists_url":"https://api.github.com/users/Happy-Neko/gists{/gist_id}","starred_url":"https://api.github.com/users/Happy-Neko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Happy-Neko/subscriptions","organizations_url":"https://api.github.com/users/Happy-Neko/orgs","repos_url":"https://api.github.com/users/Happy-Neko/repos","events_url":"https://api.github.com/users/Happy-Neko/events{/privacy}","received_events_url":"https://api.github.com/users/Happy-Neko/received_events","type":"User","site_admin":false},"body":"Could not reproduce issue #442 with unit tests. It appears that Velocity engine closes template's stream internally.\r\n\r\n@david Please assign someone to do code review.","created_at":"2015-12-14T23:45:23Z","updated_at":"2015-12-16T00:41:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"425586293d6816a0d6a15aa343411331d9984b8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yegor256/takes/pulls/465/commits","review_comments_url":"https://api.github.com/repos/yegor256/takes/pulls/465/comments","review_comment_url":"https://api.github.com/repos/yegor256/takes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yegor256/takes/issues/465/comments","statuses_url":"https://api.github.com/repos/yegor256/takes/statuses/dc4fdbbf7c71ef3017654dc351506a5985994f0c","head":{"label":"Happy-Neko:issue-442","ref":"issue-442","sha":"dc4fdbbf7c71ef3017654dc351506a5985994f0c","user":{"login":"Happy-Neko","id":11806,"avatar_url":"https://avatars.githubusercontent.com/u/11806?v=3","gravatar_id":"","url":"https://api.github.com/users/Happy-Neko","html_url":"https://github.com/Happy-Neko","followers_url":"https://api.github.com/users/Happy-Neko/followers","following_url":"https://api.github.com/users/Happy-Neko/following{/other_user}","gists_url":"https://api.github.com/users/Happy-Neko/gists{/gist_id}","starred_url":"https://api.github.com/users/Happy-Neko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Happy-Neko/subscriptions","organizations_url":"https://api.github.com/users/Happy-Neko/orgs","repos_url":"https://api.github.com/users/Happy-Neko/repos","events_url":"https://api.github.com/users/Happy-Neko/events{/privacy}","received_events_url":"https://api.github.com/users/Happy-Neko/received_events","type":"User","site_admin":false},"repo":{"id":47987971,"name":"takes","full_name":"Happy-Neko/takes","owner":{"login":"Happy-Neko","id":11806,"avatar_url":"https://avatars.githubusercontent.com/u/11806?v=3","gravatar_id":"","url":"https://api.github.com/users/Happy-Neko","html_url":"https://github.com/Happy-Neko","followers_url":"https://api.github.com/users/Happy-Neko/followers","following_url":"https://api.github.com/users/Happy-Neko/following{/other_user}","gists_url":"https://api.github.com/users/Happy-Neko/gists{/gist_id}","starred_url":"https://api.github.com/users/Happy-Neko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Happy-Neko/subscriptions","organizations_url":"https://api.github.com/users/Happy-Neko/orgs","repos_url":"https://api.github.com/users/Happy-Neko/repos","events_url":"https://api.github.com/users/Happy-Neko/events{/privacy}","received_events_url":"https://api.github.com/users/Happy-Neko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Happy-Neko/takes","description":"True Object-Oriented and Immutable Java Web Framework","fork":true,"url":"https://api.github.com/repos/Happy-Neko/takes","forks_url":"https://api.github.com/repos/Happy-Neko/takes/forks","keys_url":"https://api.github.com/repos/Happy-Neko/takes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Happy-Neko/takes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Happy-Neko/takes/teams","hooks_url":"https://api.github.com/repos/Happy-Neko/takes/hooks","issue_events_url":"https://api.github.com/repos/Happy-Neko/takes/issues/events{/number}","events_url":"https://api.github.com/repos/Happy-Neko/takes/events","assignees_url":"https://api.github.com/repos/Happy-Neko/takes/assignees{/user}","branches_url":"https://api.github.com/repos/Happy-Neko/takes/branches{/branch}","tags_url":"https://api.github.com/repos/Happy-Neko/takes/tags","blobs_url":"https://api.github.com/repos/Happy-Neko/takes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Happy-Neko/takes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Happy-Neko/takes/git/refs{/sha}","trees_url":"https://api.github.com/repos/Happy-Neko/takes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Happy-Neko/takes/statuses/{sha}","languages_url":"https://api.github.com/repos/Happy-Neko/takes/languages","stargazers_url":"https://api.github.com/repos/Happy-Neko/takes/stargazers","contributors_url":"https://api.github.com/repos/Happy-Neko/takes/contributors","subscribers_url":"https://api.github.com/repos/Happy-Neko/takes/subscribers","subscription_url":"https://api.github.com/repos/Happy-Neko/takes/subscription","commits_url":"https://api.github.com/repos/Happy-Neko/takes/commits{/sha}","git_commits_url":"https://api.github.com/repos/Happy-Neko/takes/git/commits{/sha}","comments_url":"https://api.github.com/repos/Happy-Neko/takes/comments{/number}","issue_comment_url":"https://api.github.com/repos/Happy-Neko/takes/issues/comments{/number}","contents_url":"https://api.github.com/repos/Happy-Neko/takes/contents/{+path}","compare_url":"https://api.github.com/repos/Happy-Neko/takes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Happy-Neko/takes/merges","archive_url":"https://api.github.com/repos/Happy-Neko/takes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Happy-Neko/takes/downloads","issues_url":"https://api.github.com/repos/Happy-Neko/takes/issues{/number}","pulls_url":"https://api.github.com/repos/Happy-Neko/takes/pulls{/number}","milestones_url":"https://api.github.com/repos/Happy-Neko/takes/milestones{/number}","notifications_url":"https://api.github.com/repos/Happy-Neko/takes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Happy-Neko/takes/labels{/name}","releases_url":"https://api.github.com/repos/Happy-Neko/takes/releases{/id}","created_at":"2015-12-14T16:45:23Z","updated_at":"2015-12-14T16:45:25Z","pushed_at":"2015-12-15T16:16:08Z","git_url":"git://github.com/Happy-Neko/takes.git","ssh_url":"git@github.com:Happy-Neko/takes.git","clone_url":"https://github.com/Happy-Neko/takes.git","svn_url":"https://github.com/Happy-Neko/takes","homepage":"http://www.takes.org","size":28284,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yegor256:master","ref":"master","sha":"d6d4c56cfca8c20bf2ab6a14f79d90bb29ad5d4d","user":{"login":"yegor256","id":526301,"avatar_url":"https://avatars.githubusercontent.com/u/526301?v=3","gravatar_id":"","url":"https://api.github.com/users/yegor256","html_url":"https://github.com/yegor256","followers_url":"https://api.github.com/users/yegor256/followers","following_url":"https://api.github.com/users/yegor256/following{/other_user}","gists_url":"https://api.github.com/users/yegor256/gists{/gist_id}","starred_url":"https://api.github.com/users/yegor256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yegor256/subscriptions","organizations_url":"https://api.github.com/users/yegor256/orgs","repos_url":"https://api.github.com/users/yegor256/repos","events_url":"https://api.github.com/users/yegor256/events{/privacy}","received_events_url":"https://api.github.com/users/yegor256/received_events","type":"User","site_admin":false},"repo":{"id":28924109,"name":"takes","full_name":"yegor256/takes","owner":{"login":"yegor256","id":526301,"avatar_url":"https://avatars.githubusercontent.com/u/526301?v=3","gravatar_id":"","url":"https://api.github.com/users/yegor256","html_url":"https://github.com/yegor256","followers_url":"https://api.github.com/users/yegor256/followers","following_url":"https://api.github.com/users/yegor256/following{/other_user}","gists_url":"https://api.github.com/users/yegor256/gists{/gist_id}","starred_url":"https://api.github.com/users/yegor256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yegor256/subscriptions","organizations_url":"https://api.github.com/users/yegor256/orgs","repos_url":"https://api.github.com/users/yegor256/repos","events_url":"https://api.github.com/users/yegor256/events{/privacy}","received_events_url":"https://api.github.com/users/yegor256/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yegor256/takes","description":"True Object-Oriented and Immutable Java Web Framework","fork":false,"url":"https://api.github.com/repos/yegor256/takes","forks_url":"https://api.github.com/repos/yegor256/takes/forks","keys_url":"https://api.github.com/repos/yegor256/takes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yegor256/takes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yegor256/takes/teams","hooks_url":"https://api.github.com/repos/yegor256/takes/hooks","issue_events_url":"https://api.github.com/repos/yegor256/takes/issues/events{/number}","events_url":"https://api.github.com/repos/yegor256/takes/events","assignees_url":"https://api.github.com/repos/yegor256/takes/assignees{/user}","branches_url":"https://api.github.com/repos/yegor256/takes/branches{/branch}","tags_url":"https://api.github.com/repos/yegor256/takes/tags","blobs_url":"https://api.github.com/repos/yegor256/takes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yegor256/takes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yegor256/takes/git/refs{/sha}","trees_url":"https://api.github.com/repos/yegor256/takes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yegor256/takes/statuses/{sha}","languages_url":"https://api.github.com/repos/yegor256/takes/languages","stargazers_url":"https://api.github.com/repos/yegor256/takes/stargazers","contributors_url":"https://api.github.com/repos/yegor256/takes/contributors","subscribers_url":"https://api.github.com/repos/yegor256/takes/subscribers","subscription_url":"https://api.github.com/repos/yegor256/takes/subscription","commits_url":"https://api.github.com/repos/yegor256/takes/commits{/sha}","git_commits_url":"https://api.github.com/repos/yegor256/takes/git/commits{/sha}","comments_url":"https://api.github.com/repos/yegor256/takes/comments{/number}","issue_comment_url":"https://api.github.com/repos/yegor256/takes/issues/comments{/number}","contents_url":"https://api.github.com/repos/yegor256/takes/contents/{+path}","compare_url":"https://api.github.com/repos/yegor256/takes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yegor256/takes/merges","archive_url":"https://api.github.com/repos/yegor256/takes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yegor256/takes/downloads","issues_url":"https://api.github.com/repos/yegor256/takes/issues{/number}","pulls_url":"https://api.github.com/repos/yegor256/takes/pulls{/number}","milestones_url":"https://api.github.com/repos/yegor256/takes/milestones{/number}","notifications_url":"https://api.github.com/repos/yegor256/takes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yegor256/takes/labels{/name}","releases_url":"https://api.github.com/repos/yegor256/takes/releases{/id}","created_at":"2015-01-07T16:57:47Z","updated_at":"2015-12-11T11:24:28Z","pushed_at":"2015-12-15T22:37:32Z","git_url":"git://github.com/yegor256/takes.git","ssh_url":"git@github.com:yegor256/takes.git","clone_url":"https://github.com/yegor256/takes.git","svn_url":"https://github.com/yegor256/takes","homepage":"http://www.takes.org","size":29248,"stargazers_count":121,"watchers_count":121,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":61,"mirror_url":null,"open_issues_count":41,"forks":61,"open_issues":41,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yegor256/takes/pulls/465"},"html":{"href":"https://github.com/yegor256/takes/pull/465"},"issue":{"href":"https://api.github.com/repos/yegor256/takes/issues/465"},"comments":{"href":"https://api.github.com/repos/yegor256/takes/issues/465/comments"},"review_comments":{"href":"https://api.github.com/repos/yegor256/takes/pulls/465/comments"},"review_comment":{"href":"https://api.github.com/repos/yegor256/takes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yegor256/takes/pulls/465/commits"},"statuses":{"href":"https://api.github.com/repos/yegor256/takes/statuses/dc4fdbbf7c71ef3017654dc351506a5985994f0c"}}}}