{"action":"created","comment":{"url":"https://api.github.com/repos/progrium/dokku/pulls/comments/31888335","id":31888335,"diff_hunk":"@@ -14,6 +14,14 @@ if ! command -v apt-get &>/dev/null; then\n   exit 1\n fi\n \n+for CMD in curl sudo\n+do\n+  if ! command -v ${CMD} &>/dev/null; then\n+    echo \"Error: ${CMD} not found.\" >&2\n+    exit 1\n+  fi\n+done\n+\n apt-get update\n which curl > /dev/null || apt-get install -qq -y curl","path":"bootstrap.sh","position":13,"original_position":13,"commit_id":"0aef9577e6ae84773e83ca45c906fa07d21a07ef","original_commit_id":"0aef9577e6ae84773e83ca45c906fa07d21a07ef","user":{"login":"3onyc","id":5650650,"avatar_url":"https://avatars.githubusercontent.com/u/5650650?v=3","gravatar_id":"","url":"https://api.github.com/users/3onyc","html_url":"https://github.com/3onyc","followers_url":"https://api.github.com/users/3onyc/followers","following_url":"https://api.github.com/users/3onyc/following{/other_user}","gists_url":"https://api.github.com/users/3onyc/gists{/gist_id}","starred_url":"https://api.github.com/users/3onyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3onyc/subscriptions","organizations_url":"https://api.github.com/users/3onyc/orgs","repos_url":"https://api.github.com/users/3onyc/repos","events_url":"https://api.github.com/users/3onyc/events{/privacy}","received_events_url":"https://api.github.com/users/3onyc/received_events","type":"User","site_admin":false},"body":"There's already a check for curl so this one isn't needed.\r\n\r\n@josegonzalez Best to assume as little as possible, getting an early error message when sudo is missing is better than some command failing.","created_at":"2015-06-08T05:58:15Z","updated_at":"2015-06-08T05:58:15Z","html_url":"https://github.com/progrium/dokku/pull/1219#discussion_r31888335","pull_request_url":"https://api.github.com/repos/progrium/dokku/pulls/1219","_links":{"self":{"href":"https://api.github.com/repos/progrium/dokku/pulls/comments/31888335"},"html":{"href":"https://github.com/progrium/dokku/pull/1219#discussion_r31888335"},"pull_request":{"href":"https://api.github.com/repos/progrium/dokku/pulls/1219"}}},"pull_request":{"url":"https://api.github.com/repos/progrium/dokku/pulls/1219","id":37078086,"html_url":"https://github.com/progrium/dokku/pull/1219","diff_url":"https://github.com/progrium/dokku/pull/1219.diff","patch_url":"https://github.com/progrium/dokku/pull/1219.patch","issue_url":"https://api.github.com/repos/progrium/dokku/issues/1219","number":1219,"state":"open","locked":false,"title":"adding checks for curl and sudo.","user":{"login":"cellularmitosis","id":223396,"avatar_url":"https://avatars.githubusercontent.com/u/223396?v=3","gravatar_id":"","url":"https://api.github.com/users/cellularmitosis","html_url":"https://github.com/cellularmitosis","followers_url":"https://api.github.com/users/cellularmitosis/followers","following_url":"https://api.github.com/users/cellularmitosis/following{/other_user}","gists_url":"https://api.github.com/users/cellularmitosis/gists{/gist_id}","starred_url":"https://api.github.com/users/cellularmitosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cellularmitosis/subscriptions","organizations_url":"https://api.github.com/users/cellularmitosis/orgs","repos_url":"https://api.github.com/users/cellularmitosis/repos","events_url":"https://api.github.com/users/cellularmitosis/events{/privacy}","received_events_url":"https://api.github.com/users/cellularmitosis/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI just tried installing dokku using Debian Jessie i386.\r\n\r\nbootstrap.sh failed because curl and sudo aren't part of the default installation.\r\n\r\nI've added a check for them.  Can you pull this in?\r\n\r\nThanks,\r\nJason","created_at":"2015-06-05T23:13:22Z","updated_at":"2015-06-08T05:58:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71a4ab7b249d51ce50ae6d04da56fe00deef4534","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/progrium/dokku/pulls/1219/commits","review_comments_url":"https://api.github.com/repos/progrium/dokku/pulls/1219/comments","review_comment_url":"https://api.github.com/repos/progrium/dokku/pulls/comments{/number}","comments_url":"https://api.github.com/repos/progrium/dokku/issues/1219/comments","statuses_url":"https://api.github.com/repos/progrium/dokku/statuses/0aef9577e6ae84773e83ca45c906fa07d21a07ef","head":{"label":"cellularmitosis:master","ref":"master","sha":"0aef9577e6ae84773e83ca45c906fa07d21a07ef","user":{"login":"cellularmitosis","id":223396,"avatar_url":"https://avatars.githubusercontent.com/u/223396?v=3","gravatar_id":"","url":"https://api.github.com/users/cellularmitosis","html_url":"https://github.com/cellularmitosis","followers_url":"https://api.github.com/users/cellularmitosis/followers","following_url":"https://api.github.com/users/cellularmitosis/following{/other_user}","gists_url":"https://api.github.com/users/cellularmitosis/gists{/gist_id}","starred_url":"https://api.github.com/users/cellularmitosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cellularmitosis/subscriptions","organizations_url":"https://api.github.com/users/cellularmitosis/orgs","repos_url":"https://api.github.com/users/cellularmitosis/repos","events_url":"https://api.github.com/users/cellularmitosis/events{/privacy}","received_events_url":"https://api.github.com/users/cellularmitosis/received_events","type":"User","site_admin":false},"repo":{"id":36959745,"name":"dokku","full_name":"cellularmitosis/dokku","owner":{"login":"cellularmitosis","id":223396,"avatar_url":"https://avatars.githubusercontent.com/u/223396?v=3","gravatar_id":"","url":"https://api.github.com/users/cellularmitosis","html_url":"https://github.com/cellularmitosis","followers_url":"https://api.github.com/users/cellularmitosis/followers","following_url":"https://api.github.com/users/cellularmitosis/following{/other_user}","gists_url":"https://api.github.com/users/cellularmitosis/gists{/gist_id}","starred_url":"https://api.github.com/users/cellularmitosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cellularmitosis/subscriptions","organizations_url":"https://api.github.com/users/cellularmitosis/orgs","repos_url":"https://api.github.com/users/cellularmitosis/repos","events_url":"https://api.github.com/users/cellularmitosis/events{/privacy}","received_events_url":"https://api.github.com/users/cellularmitosis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cellularmitosis/dokku","description":"Docker powered mini-Heroku in around 100 lines of Bash","fork":true,"url":"https://api.github.com/repos/cellularmitosis/dokku","forks_url":"https://api.github.com/repos/cellularmitosis/dokku/forks","keys_url":"https://api.github.com/repos/cellularmitosis/dokku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cellularmitosis/dokku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cellularmitosis/dokku/teams","hooks_url":"https://api.github.com/repos/cellularmitosis/dokku/hooks","issue_events_url":"https://api.github.com/repos/cellularmitosis/dokku/issues/events{/number}","events_url":"https://api.github.com/repos/cellularmitosis/dokku/events","assignees_url":"https://api.github.com/repos/cellularmitosis/dokku/assignees{/user}","branches_url":"https://api.github.com/repos/cellularmitosis/dokku/branches{/branch}","tags_url":"https://api.github.com/repos/cellularmitosis/dokku/tags","blobs_url":"https://api.github.com/repos/cellularmitosis/dokku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cellularmitosis/dokku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cellularmitosis/dokku/git/refs{/sha}","trees_url":"https://api.github.com/repos/cellularmitosis/dokku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cellularmitosis/dokku/statuses/{sha}","languages_url":"https://api.github.com/repos/cellularmitosis/dokku/languages","stargazers_url":"https://api.github.com/repos/cellularmitosis/dokku/stargazers","contributors_url":"https://api.github.com/repos/cellularmitosis/dokku/contributors","subscribers_url":"https://api.github.com/repos/cellularmitosis/dokku/subscribers","subscription_url":"https://api.github.com/repos/cellularmitosis/dokku/subscription","commits_url":"https://api.github.com/repos/cellularmitosis/dokku/commits{/sha}","git_commits_url":"https://api.github.com/repos/cellularmitosis/dokku/git/commits{/sha}","comments_url":"https://api.github.com/repos/cellularmitosis/dokku/comments{/number}","issue_comment_url":"https://api.github.com/repos/cellularmitosis/dokku/issues/comments{/number}","contents_url":"https://api.github.com/repos/cellularmitosis/dokku/contents/{+path}","compare_url":"https://api.github.com/repos/cellularmitosis/dokku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cellularmitosis/dokku/merges","archive_url":"https://api.github.com/repos/cellularmitosis/dokku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cellularmitosis/dokku/downloads","issues_url":"https://api.github.com/repos/cellularmitosis/dokku/issues{/number}","pulls_url":"https://api.github.com/repos/cellularmitosis/dokku/pulls{/number}","milestones_url":"https://api.github.com/repos/cellularmitosis/dokku/milestones{/number}","notifications_url":"https://api.github.com/repos/cellularmitosis/dokku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cellularmitosis/dokku/labels{/name}","releases_url":"https://api.github.com/repos/cellularmitosis/dokku/releases{/id}","created_at":"2015-06-05T23:09:47Z","updated_at":"2015-06-05T23:09:48Z","pushed_at":"2015-06-05T23:26:50Z","git_url":"git://github.com/cellularmitosis/dokku.git","ssh_url":"git@github.com:cellularmitosis/dokku.git","clone_url":"https://github.com/cellularmitosis/dokku.git","svn_url":"https://github.com/cellularmitosis/dokku","homepage":"","size":1248,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"progrium:master","ref":"master","sha":"dda2ac03ee3bcac4b5a44f55df9dbcf72659be17","user":{"login":"progrium","id":647,"avatar_url":"https://avatars.githubusercontent.com/u/647?v=3","gravatar_id":"","url":"https://api.github.com/users/progrium","html_url":"https://github.com/progrium","followers_url":"https://api.github.com/users/progrium/followers","following_url":"https://api.github.com/users/progrium/following{/other_user}","gists_url":"https://api.github.com/users/progrium/gists{/gist_id}","starred_url":"https://api.github.com/users/progrium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/progrium/subscriptions","organizations_url":"https://api.github.com/users/progrium/orgs","repos_url":"https://api.github.com/users/progrium/repos","events_url":"https://api.github.com/users/progrium/events{/privacy}","received_events_url":"https://api.github.com/users/progrium/received_events","type":"User","site_admin":false},"repo":{"id":10567197,"name":"dokku","full_name":"progrium/dokku","owner":{"login":"progrium","id":647,"avatar_url":"https://avatars.githubusercontent.com/u/647?v=3","gravatar_id":"","url":"https://api.github.com/users/progrium","html_url":"https://github.com/progrium","followers_url":"https://api.github.com/users/progrium/followers","following_url":"https://api.github.com/users/progrium/following{/other_user}","gists_url":"https://api.github.com/users/progrium/gists{/gist_id}","starred_url":"https://api.github.com/users/progrium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/progrium/subscriptions","organizations_url":"https://api.github.com/users/progrium/orgs","repos_url":"https://api.github.com/users/progrium/repos","events_url":"https://api.github.com/users/progrium/events{/privacy}","received_events_url":"https://api.github.com/users/progrium/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/progrium/dokku","description":"Docker powered mini-Heroku in around 100 lines of Bash","fork":false,"url":"https://api.github.com/repos/progrium/dokku","forks_url":"https://api.github.com/repos/progrium/dokku/forks","keys_url":"https://api.github.com/repos/progrium/dokku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/progrium/dokku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/progrium/dokku/teams","hooks_url":"https://api.github.com/repos/progrium/dokku/hooks","issue_events_url":"https://api.github.com/repos/progrium/dokku/issues/events{/number}","events_url":"https://api.github.com/repos/progrium/dokku/events","assignees_url":"https://api.github.com/repos/progrium/dokku/assignees{/user}","branches_url":"https://api.github.com/repos/progrium/dokku/branches{/branch}","tags_url":"https://api.github.com/repos/progrium/dokku/tags","blobs_url":"https://api.github.com/repos/progrium/dokku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/progrium/dokku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/progrium/dokku/git/refs{/sha}","trees_url":"https://api.github.com/repos/progrium/dokku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/progrium/dokku/statuses/{sha}","languages_url":"https://api.github.com/repos/progrium/dokku/languages","stargazers_url":"https://api.github.com/repos/progrium/dokku/stargazers","contributors_url":"https://api.github.com/repos/progrium/dokku/contributors","subscribers_url":"https://api.github.com/repos/progrium/dokku/subscribers","subscription_url":"https://api.github.com/repos/progrium/dokku/subscription","commits_url":"https://api.github.com/repos/progrium/dokku/commits{/sha}","git_commits_url":"https://api.github.com/repos/progrium/dokku/git/commits{/sha}","comments_url":"https://api.github.com/repos/progrium/dokku/comments{/number}","issue_comment_url":"https://api.github.com/repos/progrium/dokku/issues/comments{/number}","contents_url":"https://api.github.com/repos/progrium/dokku/contents/{+path}","compare_url":"https://api.github.com/repos/progrium/dokku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/progrium/dokku/merges","archive_url":"https://api.github.com/repos/progrium/dokku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/progrium/dokku/downloads","issues_url":"https://api.github.com/repos/progrium/dokku/issues{/number}","pulls_url":"https://api.github.com/repos/progrium/dokku/pulls{/number}","milestones_url":"https://api.github.com/repos/progrium/dokku/milestones{/number}","notifications_url":"https://api.github.com/repos/progrium/dokku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/progrium/dokku/labels{/name}","releases_url":"https://api.github.com/repos/progrium/dokku/releases{/id}","created_at":"2013-06-08T10:26:57Z","updated_at":"2015-06-08T02:01:22Z","pushed_at":"2015-06-06T18:37:56Z","git_url":"git://github.com/progrium/dokku.git","ssh_url":"git@github.com:progrium/dokku.git","clone_url":"https://github.com/progrium/dokku.git","svn_url":"https://github.com/progrium/dokku","homepage":"","size":6063,"stargazers_count":9285,"watchers_count":9285,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":770,"mirror_url":null,"open_issues_count":46,"forks":770,"open_issues":46,"watchers":9285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/progrium/dokku/pulls/1219"},"html":{"href":"https://github.com/progrium/dokku/pull/1219"},"issue":{"href":"https://api.github.com/repos/progrium/dokku/issues/1219"},"comments":{"href":"https://api.github.com/repos/progrium/dokku/issues/1219/comments"},"review_comments":{"href":"https://api.github.com/repos/progrium/dokku/pulls/1219/comments"},"review_comment":{"href":"https://api.github.com/repos/progrium/dokku/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/progrium/dokku/pulls/1219/commits"},"statuses":{"href":"https://api.github.com/repos/progrium/dokku/statuses/0aef9577e6ae84773e83ca45c906fa07d21a07ef"}}}}