{"action":"opened","number":45,"pull_request":{"url":"https://api.github.com/repos/galkahana/HummusJS/pulls/45","id":44846227,"html_url":"https://github.com/galkahana/HummusJS/pull/45","diff_url":"https://github.com/galkahana/HummusJS/pull/45.diff","patch_url":"https://github.com/galkahana/HummusJS/pull/45.patch","issue_url":"https://api.github.com/repos/galkahana/HummusJS/issues/45","number":45,"state":"open","locked":false,"title":"Feature/nodejs 4.0 compile","user":{"login":"taxilian","id":224334,"avatar_url":"https://avatars.githubusercontent.com/u/224334?v=3","gravatar_id":"","url":"https://api.github.com/users/taxilian","html_url":"https://github.com/taxilian","followers_url":"https://api.github.com/users/taxilian/followers","following_url":"https://api.github.com/users/taxilian/following{/other_user}","gists_url":"https://api.github.com/users/taxilian/gists{/gist_id}","starred_url":"https://api.github.com/users/taxilian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taxilian/subscriptions","organizations_url":"https://api.github.com/users/taxilian/orgs","repos_url":"https://api.github.com/users/taxilian/repos","events_url":"https://api.github.com/users/taxilian/events{/privacy}","received_events_url":"https://api.github.com/users/taxilian/received_events","type":"User","site_admin":false},"body":"Seems some things have changed in node.js 4.0; this fixes #44 by explicitly doing the conversion to std::string in two cases where previously it was being done implicitly. I think there is a new implicit conversion in V8 from char* or similar to v8::Handle<v8::Object>\r\n\r\nEither way, this should be a very safe change and it fixes the issue.","created_at":"2015-09-12T03:48:28Z","updated_at":"2015-09-12T03:48:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/galkahana/HummusJS/pulls/45/commits","review_comments_url":"https://api.github.com/repos/galkahana/HummusJS/pulls/45/comments","review_comment_url":"https://api.github.com/repos/galkahana/HummusJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/galkahana/HummusJS/issues/45/comments","statuses_url":"https://api.github.com/repos/galkahana/HummusJS/statuses/b47f85c31cbd3b5fbae21c129025f0bfd945496a","head":{"label":"taxilian:feature/nodejs_4.0_compile","ref":"feature/nodejs_4.0_compile","sha":"b47f85c31cbd3b5fbae21c129025f0bfd945496a","user":{"login":"taxilian","id":224334,"avatar_url":"https://avatars.githubusercontent.com/u/224334?v=3","gravatar_id":"","url":"https://api.github.com/users/taxilian","html_url":"https://github.com/taxilian","followers_url":"https://api.github.com/users/taxilian/followers","following_url":"https://api.github.com/users/taxilian/following{/other_user}","gists_url":"https://api.github.com/users/taxilian/gists{/gist_id}","starred_url":"https://api.github.com/users/taxilian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taxilian/subscriptions","organizations_url":"https://api.github.com/users/taxilian/orgs","repos_url":"https://api.github.com/users/taxilian/repos","events_url":"https://api.github.com/users/taxilian/events{/privacy}","received_events_url":"https://api.github.com/users/taxilian/received_events","type":"User","site_admin":false},"repo":{"id":42343528,"name":"HummusJS","full_name":"taxilian/HummusJS","owner":{"login":"taxilian","id":224334,"avatar_url":"https://avatars.githubusercontent.com/u/224334?v=3","gravatar_id":"","url":"https://api.github.com/users/taxilian","html_url":"https://github.com/taxilian","followers_url":"https://api.github.com/users/taxilian/followers","following_url":"https://api.github.com/users/taxilian/following{/other_user}","gists_url":"https://api.github.com/users/taxilian/gists{/gist_id}","starred_url":"https://api.github.com/users/taxilian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taxilian/subscriptions","organizations_url":"https://api.github.com/users/taxilian/orgs","repos_url":"https://api.github.com/users/taxilian/repos","events_url":"https://api.github.com/users/taxilian/events{/privacy}","received_events_url":"https://api.github.com/users/taxilian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taxilian/HummusJS","description":"HummusJS is a node.js driver for my PDF library PDFHummus, hosted here on github as github.com/galkahana/pdf-writer","fork":true,"url":"https://api.github.com/repos/taxilian/HummusJS","forks_url":"https://api.github.com/repos/taxilian/HummusJS/forks","keys_url":"https://api.github.com/repos/taxilian/HummusJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taxilian/HummusJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taxilian/HummusJS/teams","hooks_url":"https://api.github.com/repos/taxilian/HummusJS/hooks","issue_events_url":"https://api.github.com/repos/taxilian/HummusJS/issues/events{/number}","events_url":"https://api.github.com/repos/taxilian/HummusJS/events","assignees_url":"https://api.github.com/repos/taxilian/HummusJS/assignees{/user}","branches_url":"https://api.github.com/repos/taxilian/HummusJS/branches{/branch}","tags_url":"https://api.github.com/repos/taxilian/HummusJS/tags","blobs_url":"https://api.github.com/repos/taxilian/HummusJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taxilian/HummusJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taxilian/HummusJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/taxilian/HummusJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taxilian/HummusJS/statuses/{sha}","languages_url":"https://api.github.com/repos/taxilian/HummusJS/languages","stargazers_url":"https://api.github.com/repos/taxilian/HummusJS/stargazers","contributors_url":"https://api.github.com/repos/taxilian/HummusJS/contributors","subscribers_url":"https://api.github.com/repos/taxilian/HummusJS/subscribers","subscription_url":"https://api.github.com/repos/taxilian/HummusJS/subscription","commits_url":"https://api.github.com/repos/taxilian/HummusJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/taxilian/HummusJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/taxilian/HummusJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/taxilian/HummusJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/taxilian/HummusJS/contents/{+path}","compare_url":"https://api.github.com/repos/taxilian/HummusJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taxilian/HummusJS/merges","archive_url":"https://api.github.com/repos/taxilian/HummusJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taxilian/HummusJS/downloads","issues_url":"https://api.github.com/repos/taxilian/HummusJS/issues{/number}","pulls_url":"https://api.github.com/repos/taxilian/HummusJS/pulls{/number}","milestones_url":"https://api.github.com/repos/taxilian/HummusJS/milestones{/number}","notifications_url":"https://api.github.com/repos/taxilian/HummusJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taxilian/HummusJS/labels{/name}","releases_url":"https://api.github.com/repos/taxilian/HummusJS/releases{/id}","created_at":"2015-09-12T03:44:44Z","updated_at":"2015-09-12T03:44:48Z","pushed_at":"2015-09-12T03:46:26Z","git_url":"git://github.com/taxilian/HummusJS.git","ssh_url":"git@github.com:taxilian/HummusJS.git","clone_url":"https://github.com/taxilian/HummusJS.git","svn_url":"https://github.com/taxilian/HummusJS","homepage":"pdfhummus.com","size":23607,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"galkahana:master","ref":"master","sha":"83df457de005c85e0f524d8158335087b386497e","user":{"login":"galkahana","id":271847,"avatar_url":"https://avatars.githubusercontent.com/u/271847?v=3","gravatar_id":"","url":"https://api.github.com/users/galkahana","html_url":"https://github.com/galkahana","followers_url":"https://api.github.com/users/galkahana/followers","following_url":"https://api.github.com/users/galkahana/following{/other_user}","gists_url":"https://api.github.com/users/galkahana/gists{/gist_id}","starred_url":"https://api.github.com/users/galkahana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galkahana/subscriptions","organizations_url":"https://api.github.com/users/galkahana/orgs","repos_url":"https://api.github.com/users/galkahana/repos","events_url":"https://api.github.com/users/galkahana/events{/privacy}","received_events_url":"https://api.github.com/users/galkahana/received_events","type":"User","site_admin":false},"repo":{"id":8962136,"name":"HummusJS","full_name":"galkahana/HummusJS","owner":{"login":"galkahana","id":271847,"avatar_url":"https://avatars.githubusercontent.com/u/271847?v=3","gravatar_id":"","url":"https://api.github.com/users/galkahana","html_url":"https://github.com/galkahana","followers_url":"https://api.github.com/users/galkahana/followers","following_url":"https://api.github.com/users/galkahana/following{/other_user}","gists_url":"https://api.github.com/users/galkahana/gists{/gist_id}","starred_url":"https://api.github.com/users/galkahana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galkahana/subscriptions","organizations_url":"https://api.github.com/users/galkahana/orgs","repos_url":"https://api.github.com/users/galkahana/repos","events_url":"https://api.github.com/users/galkahana/events{/privacy}","received_events_url":"https://api.github.com/users/galkahana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/galkahana/HummusJS","description":"HummusJS is a node.js driver for my PDF library PDFHummus, hosted here on github as github.com/galkahana/pdf-writer","fork":false,"url":"https://api.github.com/repos/galkahana/HummusJS","forks_url":"https://api.github.com/repos/galkahana/HummusJS/forks","keys_url":"https://api.github.com/repos/galkahana/HummusJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galkahana/HummusJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galkahana/HummusJS/teams","hooks_url":"https://api.github.com/repos/galkahana/HummusJS/hooks","issue_events_url":"https://api.github.com/repos/galkahana/HummusJS/issues/events{/number}","events_url":"https://api.github.com/repos/galkahana/HummusJS/events","assignees_url":"https://api.github.com/repos/galkahana/HummusJS/assignees{/user}","branches_url":"https://api.github.com/repos/galkahana/HummusJS/branches{/branch}","tags_url":"https://api.github.com/repos/galkahana/HummusJS/tags","blobs_url":"https://api.github.com/repos/galkahana/HummusJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galkahana/HummusJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galkahana/HummusJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/galkahana/HummusJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galkahana/HummusJS/statuses/{sha}","languages_url":"https://api.github.com/repos/galkahana/HummusJS/languages","stargazers_url":"https://api.github.com/repos/galkahana/HummusJS/stargazers","contributors_url":"https://api.github.com/repos/galkahana/HummusJS/contributors","subscribers_url":"https://api.github.com/repos/galkahana/HummusJS/subscribers","subscription_url":"https://api.github.com/repos/galkahana/HummusJS/subscription","commits_url":"https://api.github.com/repos/galkahana/HummusJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/galkahana/HummusJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/galkahana/HummusJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/galkahana/HummusJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/galkahana/HummusJS/contents/{+path}","compare_url":"https://api.github.com/repos/galkahana/HummusJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galkahana/HummusJS/merges","archive_url":"https://api.github.com/repos/galkahana/HummusJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galkahana/HummusJS/downloads","issues_url":"https://api.github.com/repos/galkahana/HummusJS/issues{/number}","pulls_url":"https://api.github.com/repos/galkahana/HummusJS/pulls{/number}","milestones_url":"https://api.github.com/repos/galkahana/HummusJS/milestones{/number}","notifications_url":"https://api.github.com/repos/galkahana/HummusJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galkahana/HummusJS/labels{/name}","releases_url":"https://api.github.com/repos/galkahana/HummusJS/releases{/id}","created_at":"2013-03-22T22:23:36Z","updated_at":"2015-09-09T14:51:13Z","pushed_at":"2015-09-12T03:48:28Z","git_url":"git://github.com/galkahana/HummusJS.git","ssh_url":"git@github.com:galkahana/HummusJS.git","clone_url":"https://github.com/galkahana/HummusJS.git","svn_url":"https://github.com/galkahana/HummusJS","homepage":"pdfhummus.com","size":23607,"stargazers_count":68,"watchers_count":68,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":10,"forks":12,"open_issues":10,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/galkahana/HummusJS/pulls/45"},"html":{"href":"https://github.com/galkahana/HummusJS/pull/45"},"issue":{"href":"https://api.github.com/repos/galkahana/HummusJS/issues/45"},"comments":{"href":"https://api.github.com/repos/galkahana/HummusJS/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/galkahana/HummusJS/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/galkahana/HummusJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/galkahana/HummusJS/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/galkahana/HummusJS/statuses/b47f85c31cbd3b5fbae21c129025f0bfd945496a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":2,"deletions":2,"changed_files":1}}