{"action":"created","issue":{"url":"https://api.github.com/repos/cujojs/when/issues/476","labels_url":"https://api.github.com/repos/cujojs/when/issues/476/labels{/name}","comments_url":"https://api.github.com/repos/cujojs/when/issues/476/comments","events_url":"https://api.github.com/repos/cujojs/when/issues/476/events","html_url":"https://github.com/cujojs/when/pull/476","id":120273084,"number":476,"title":"include browserified and browserified+uglified version in dist","user":{"login":"dominykas","id":505619,"avatar_url":"https://avatars.githubusercontent.com/u/505619?v=3","gravatar_id":"","url":"https://api.github.com/users/dominykas","html_url":"https://github.com/dominykas","followers_url":"https://api.github.com/users/dominykas/followers","following_url":"https://api.github.com/users/dominykas/following{/other_user}","gists_url":"https://api.github.com/users/dominykas/gists{/gist_id}","starred_url":"https://api.github.com/users/dominykas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominykas/subscriptions","organizations_url":"https://api.github.com/users/dominykas/orgs","repos_url":"https://api.github.com/users/dominykas/repos","events_url":"https://api.github.com/users/dominykas/events{/privacy}","received_events_url":"https://api.github.com/users/dominykas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-12-03T21:23:52Z","updated_at":"2015-12-16T14:27:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cujojs/when/pulls/476","html_url":"https://github.com/cujojs/when/pull/476","diff_url":"https://github.com/cujojs/when/pull/476.diff","patch_url":"https://github.com/cujojs/when/pull/476.patch"},"body":"Fix for https://github.com/cujojs/when/issues/473, also add source maps, next to browserified JS files. The source maps include `sourceRoot` pointing to the raw files on Github for the current git `HEAD` - uglify for some reason then lists `sources` twice - relative to the project root and then repeats them at `sourceRoot` - not sure if that's a bug in uglify or not, but I tested in the browser and since `sourcesContent` are included in the actual source map, things just work.\r\n\r\nA couple of questions:\r\n\r\n1. Why is browserification done during `prepublish` AND during `preversion`? I wouldn't normally care, but `npm version` creates a new commit, so it would probably be best to run the build step `postversion`, as it includes a link to the commit in the source map (event if the content at both commits is roughly the same, for source map purposes). Or maybe `prepublish` is enough and `preversion` should be removed?\r\n2. Should I move `es6-shim` to `dist`? That might be considered a breaking change (file no longer where it used to be)\r\n3. I can also add a source map for the `es6-shim`, but it seems the output is checked into git? Is it supposed to be that way? Should source map also be checked in?\r\n4. Installation docs need a rewrite - I can write up the \"install with npm, then include the file from `dist` and use a global\" bit, but I don't use bower, so I'm useless there...\r\n5. `npm install` reordered the `devDependencies` - should I put it back the way it was?"},"comment":{"url":"https://api.github.com/repos/cujojs/when/issues/comments/165124987","html_url":"https://github.com/cujojs/when/pull/476#issuecomment-165124987","issue_url":"https://api.github.com/repos/cujojs/when/issues/476","id":165124987,"user":{"login":"briancavalier","id":90518,"avatar_url":"https://avatars.githubusercontent.com/u/90518?v=3","gravatar_id":"","url":"https://api.github.com/users/briancavalier","html_url":"https://github.com/briancavalier","followers_url":"https://api.github.com/users/briancavalier/followers","following_url":"https://api.github.com/users/briancavalier/following{/other_user}","gists_url":"https://api.github.com/users/briancavalier/gists{/gist_id}","starred_url":"https://api.github.com/users/briancavalier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briancavalier/subscriptions","organizations_url":"https://api.github.com/users/briancavalier/orgs","repos_url":"https://api.github.com/users/briancavalier/repos","events_url":"https://api.github.com/users/briancavalier/events{/privacy}","received_events_url":"https://api.github.com/users/briancavalier/received_events","type":"User","site_admin":false},"created_at":"2015-12-16T14:27:49Z","updated_at":"2015-12-16T14:27:49Z","body":"This looks great, @dominykas.  I pulled the branch and tried it out, and both `npm run browserify` and `npm pack` afterward seemed to work perfectly.  I appreciate the attention to detail in the docs, too.\r\n\r\nIs there anything else you want/need to do here, or is this ready to be merged?"}}