{"action":"created","comment":{"url":"https://api.github.com/repos/flynn/flynn/pulls/comments/28635814","id":28635814,"diff_hunk":"@@ -173,6 +173,36 @@ func (s *S) TestDeleteApp(c *C) {\n \t}\n }\n \n+func (s *S) TestDeleteAppUUIDName(c *C) {\n+\tfor _, useName := range []bool{false, true} {\n+\t\tapp := s.createTestApp(c, &ct.App{Name: random.UUID()})\n+\n+\t\tvar appID string\n+\t\tif useName {\n+\t\t\tappID = app.Name\n+\t\t} else {\n+\t\t\tappID = app.ID\n+\t\t}\n+\t\tc.Assert(s.c.DeleteApp(appID), IsNil)\n+\n+\t\t_, err := s.c.GetApp(appID)\n+\t\tc.Assert(err, Equals, controller.ErrNotFound)\n+\t}\n+}\n+\n+func (s *S) TestDeleteNonExistingApp(c *C) {","path":"controller/controller_test.go","position":21,"original_position":21,"commit_id":"d82589915c85baf4d567892a1f43dd9dd0483dcc","original_commit_id":"d82589915c85baf4d567892a1f43dd9dd0483dcc","user":{"login":"lmars","id":488515,"avatar_url":"https://avatars.githubusercontent.com/u/488515?v=3","gravatar_id":"","url":"https://api.github.com/users/lmars","html_url":"https://github.com/lmars","followers_url":"https://api.github.com/users/lmars/followers","following_url":"https://api.github.com/users/lmars/following{/other_user}","gists_url":"https://api.github.com/users/lmars/gists{/gist_id}","starred_url":"https://api.github.com/users/lmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmars/subscriptions","organizations_url":"https://api.github.com/users/lmars/orgs","repos_url":"https://api.github.com/users/lmars/repos","events_url":"https://api.github.com/users/lmars/events{/privacy}","received_events_url":"https://api.github.com/users/lmars/received_events","type":"User","site_admin":false},"body":"I think `TestDeleteNonExistentApp` is a better name","created_at":"2015-04-17T22:45:46Z","updated_at":"2015-04-17T22:45:46Z","html_url":"https://github.com/flynn/flynn/pull/1468#discussion_r28635814","pull_request_url":"https://api.github.com/repos/flynn/flynn/pulls/1468","_links":{"self":{"href":"https://api.github.com/repos/flynn/flynn/pulls/comments/28635814"},"html":{"href":"https://github.com/flynn/flynn/pull/1468#discussion_r28635814"},"pull_request":{"href":"https://api.github.com/repos/flynn/flynn/pulls/1468"}}},"pull_request":{"url":"https://api.github.com/repos/flynn/flynn/pulls/1468","id":33573948,"html_url":"https://github.com/flynn/flynn/pull/1468","diff_url":"https://github.com/flynn/flynn/pull/1468.diff","patch_url":"https://github.com/flynn/flynn/pull/1468.patch","issue_url":"https://api.github.com/repos/flynn/flynn/issues/1468","number":1468,"state":"open","locked":false,"title":"controller: Fixed removal of apps with uuids as names","user":{"login":"arekkas","id":3372410,"avatar_url":"https://avatars.githubusercontent.com/u/3372410?v=3","gravatar_id":"","url":"https://api.github.com/users/arekkas","html_url":"https://github.com/arekkas","followers_url":"https://api.github.com/users/arekkas/followers","following_url":"https://api.github.com/users/arekkas/following{/other_user}","gists_url":"https://api.github.com/users/arekkas/gists{/gist_id}","starred_url":"https://api.github.com/users/arekkas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arekkas/subscriptions","organizations_url":"https://api.github.com/users/arekkas/orgs","repos_url":"https://api.github.com/users/arekkas/repos","events_url":"https://api.github.com/users/arekkas/events{/privacy}","received_events_url":"https://api.github.com/users/arekkas/received_events","type":"User","site_admin":false},"body":"Follow up to #1467\r\n\r\nUnit tests now require the uuid package. Not sure if I need to update godeps for that.\r\n\r\nping @lmars ","created_at":"2015-04-17T19:19:43Z","updated_at":"2015-04-17T22:45:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2a6e1a0dd18ef4cddc5844f56bf4d0184615eb8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flynn/flynn/pulls/1468/commits","review_comments_url":"https://api.github.com/repos/flynn/flynn/pulls/1468/comments","review_comment_url":"https://api.github.com/repos/flynn/flynn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flynn/flynn/issues/1468/comments","statuses_url":"https://api.github.com/repos/flynn/flynn/statuses/d82589915c85baf4d567892a1f43dd9dd0483dcc","head":{"label":"arekkas:controller-delete-fix","ref":"controller-delete-fix","sha":"d82589915c85baf4d567892a1f43dd9dd0483dcc","user":{"login":"arekkas","id":3372410,"avatar_url":"https://avatars.githubusercontent.com/u/3372410?v=3","gravatar_id":"","url":"https://api.github.com/users/arekkas","html_url":"https://github.com/arekkas","followers_url":"https://api.github.com/users/arekkas/followers","following_url":"https://api.github.com/users/arekkas/following{/other_user}","gists_url":"https://api.github.com/users/arekkas/gists{/gist_id}","starred_url":"https://api.github.com/users/arekkas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arekkas/subscriptions","organizations_url":"https://api.github.com/users/arekkas/orgs","repos_url":"https://api.github.com/users/arekkas/repos","events_url":"https://api.github.com/users/arekkas/events{/privacy}","received_events_url":"https://api.github.com/users/arekkas/received_events","type":"User","site_admin":false},"repo":{"id":31168135,"name":"flynn","full_name":"arekkas/flynn","owner":{"login":"arekkas","id":3372410,"avatar_url":"https://avatars.githubusercontent.com/u/3372410?v=3","gravatar_id":"","url":"https://api.github.com/users/arekkas","html_url":"https://github.com/arekkas","followers_url":"https://api.github.com/users/arekkas/followers","following_url":"https://api.github.com/users/arekkas/following{/other_user}","gists_url":"https://api.github.com/users/arekkas/gists{/gist_id}","starred_url":"https://api.github.com/users/arekkas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arekkas/subscriptions","organizations_url":"https://api.github.com/users/arekkas/orgs","repos_url":"https://api.github.com/users/arekkas/repos","events_url":"https://api.github.com/users/arekkas/events{/privacy}","received_events_url":"https://api.github.com/users/arekkas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arekkas/flynn","description":"A next generation open source platform as a service (PaaS)","fork":true,"url":"https://api.github.com/repos/arekkas/flynn","forks_url":"https://api.github.com/repos/arekkas/flynn/forks","keys_url":"https://api.github.com/repos/arekkas/flynn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arekkas/flynn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arekkas/flynn/teams","hooks_url":"https://api.github.com/repos/arekkas/flynn/hooks","issue_events_url":"https://api.github.com/repos/arekkas/flynn/issues/events{/number}","events_url":"https://api.github.com/repos/arekkas/flynn/events","assignees_url":"https://api.github.com/repos/arekkas/flynn/assignees{/user}","branches_url":"https://api.github.com/repos/arekkas/flynn/branches{/branch}","tags_url":"https://api.github.com/repos/arekkas/flynn/tags","blobs_url":"https://api.github.com/repos/arekkas/flynn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arekkas/flynn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arekkas/flynn/git/refs{/sha}","trees_url":"https://api.github.com/repos/arekkas/flynn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arekkas/flynn/statuses/{sha}","languages_url":"https://api.github.com/repos/arekkas/flynn/languages","stargazers_url":"https://api.github.com/repos/arekkas/flynn/stargazers","contributors_url":"https://api.github.com/repos/arekkas/flynn/contributors","subscribers_url":"https://api.github.com/repos/arekkas/flynn/subscribers","subscription_url":"https://api.github.com/repos/arekkas/flynn/subscription","commits_url":"https://api.github.com/repos/arekkas/flynn/commits{/sha}","git_commits_url":"https://api.github.com/repos/arekkas/flynn/git/commits{/sha}","comments_url":"https://api.github.com/repos/arekkas/flynn/comments{/number}","issue_comment_url":"https://api.github.com/repos/arekkas/flynn/issues/comments{/number}","contents_url":"https://api.github.com/repos/arekkas/flynn/contents/{+path}","compare_url":"https://api.github.com/repos/arekkas/flynn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arekkas/flynn/merges","archive_url":"https://api.github.com/repos/arekkas/flynn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arekkas/flynn/downloads","issues_url":"https://api.github.com/repos/arekkas/flynn/issues{/number}","pulls_url":"https://api.github.com/repos/arekkas/flynn/pulls{/number}","milestones_url":"https://api.github.com/repos/arekkas/flynn/milestones{/number}","notifications_url":"https://api.github.com/repos/arekkas/flynn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arekkas/flynn/labels{/name}","releases_url":"https://api.github.com/repos/arekkas/flynn/releases{/id}","created_at":"2015-02-22T15:50:58Z","updated_at":"2015-04-16T15:15:08Z","pushed_at":"2015-04-17T21:40:32Z","git_url":"git://github.com/arekkas/flynn.git","ssh_url":"git@github.com:arekkas/flynn.git","clone_url":"https://github.com/arekkas/flynn.git","svn_url":"https://github.com/arekkas/flynn","homepage":"https://flynn.io","size":13159,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flynn:master","ref":"master","sha":"726bbf03143f6f98cb82f62af800c54766ce28f8","user":{"login":"flynn","id":4973613,"avatar_url":"https://avatars.githubusercontent.com/u/4973613?v=3","gravatar_id":"","url":"https://api.github.com/users/flynn","html_url":"https://github.com/flynn","followers_url":"https://api.github.com/users/flynn/followers","following_url":"https://api.github.com/users/flynn/following{/other_user}","gists_url":"https://api.github.com/users/flynn/gists{/gist_id}","starred_url":"https://api.github.com/users/flynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flynn/subscriptions","organizations_url":"https://api.github.com/users/flynn/orgs","repos_url":"https://api.github.com/users/flynn/repos","events_url":"https://api.github.com/users/flynn/events{/privacy}","received_events_url":"https://api.github.com/users/flynn/received_events","type":"Organization","site_admin":false},"repo":{"id":11290232,"name":"flynn","full_name":"flynn/flynn","owner":{"login":"flynn","id":4973613,"avatar_url":"https://avatars.githubusercontent.com/u/4973613?v=3","gravatar_id":"","url":"https://api.github.com/users/flynn","html_url":"https://github.com/flynn","followers_url":"https://api.github.com/users/flynn/followers","following_url":"https://api.github.com/users/flynn/following{/other_user}","gists_url":"https://api.github.com/users/flynn/gists{/gist_id}","starred_url":"https://api.github.com/users/flynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flynn/subscriptions","organizations_url":"https://api.github.com/users/flynn/orgs","repos_url":"https://api.github.com/users/flynn/repos","events_url":"https://api.github.com/users/flynn/events{/privacy}","received_events_url":"https://api.github.com/users/flynn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flynn/flynn","description":"A next generation open source platform as a service (PaaS)","fork":false,"url":"https://api.github.com/repos/flynn/flynn","forks_url":"https://api.github.com/repos/flynn/flynn/forks","keys_url":"https://api.github.com/repos/flynn/flynn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flynn/flynn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flynn/flynn/teams","hooks_url":"https://api.github.com/repos/flynn/flynn/hooks","issue_events_url":"https://api.github.com/repos/flynn/flynn/issues/events{/number}","events_url":"https://api.github.com/repos/flynn/flynn/events","assignees_url":"https://api.github.com/repos/flynn/flynn/assignees{/user}","branches_url":"https://api.github.com/repos/flynn/flynn/branches{/branch}","tags_url":"https://api.github.com/repos/flynn/flynn/tags","blobs_url":"https://api.github.com/repos/flynn/flynn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flynn/flynn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flynn/flynn/git/refs{/sha}","trees_url":"https://api.github.com/repos/flynn/flynn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flynn/flynn/statuses/{sha}","languages_url":"https://api.github.com/repos/flynn/flynn/languages","stargazers_url":"https://api.github.com/repos/flynn/flynn/stargazers","contributors_url":"https://api.github.com/repos/flynn/flynn/contributors","subscribers_url":"https://api.github.com/repos/flynn/flynn/subscribers","subscription_url":"https://api.github.com/repos/flynn/flynn/subscription","commits_url":"https://api.github.com/repos/flynn/flynn/commits{/sha}","git_commits_url":"https://api.github.com/repos/flynn/flynn/git/commits{/sha}","comments_url":"https://api.github.com/repos/flynn/flynn/comments{/number}","issue_comment_url":"https://api.github.com/repos/flynn/flynn/issues/comments{/number}","contents_url":"https://api.github.com/repos/flynn/flynn/contents/{+path}","compare_url":"https://api.github.com/repos/flynn/flynn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flynn/flynn/merges","archive_url":"https://api.github.com/repos/flynn/flynn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flynn/flynn/downloads","issues_url":"https://api.github.com/repos/flynn/flynn/issues{/number}","pulls_url":"https://api.github.com/repos/flynn/flynn/pulls{/number}","milestones_url":"https://api.github.com/repos/flynn/flynn/milestones{/number}","notifications_url":"https://api.github.com/repos/flynn/flynn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flynn/flynn/labels{/name}","releases_url":"https://api.github.com/repos/flynn/flynn/releases{/id}","created_at":"2013-07-09T18:22:06Z","updated_at":"2015-04-17T19:48:37Z","pushed_at":"2015-04-17T22:22:41Z","git_url":"git://github.com/flynn/flynn.git","ssh_url":"git@github.com:flynn/flynn.git","clone_url":"https://github.com/flynn/flynn.git","svn_url":"https://github.com/flynn/flynn","homepage":"https://flynn.io","size":50382,"stargazers_count":3465,"watchers_count":3465,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":243,"mirror_url":null,"open_issues_count":185,"forks":243,"open_issues":185,"watchers":3465,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flynn/flynn/pulls/1468"},"html":{"href":"https://github.com/flynn/flynn/pull/1468"},"issue":{"href":"https://api.github.com/repos/flynn/flynn/issues/1468"},"comments":{"href":"https://api.github.com/repos/flynn/flynn/issues/1468/comments"},"review_comments":{"href":"https://api.github.com/repos/flynn/flynn/pulls/1468/comments"},"review_comment":{"href":"https://api.github.com/repos/flynn/flynn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flynn/flynn/pulls/1468/commits"},"statuses":{"href":"https://api.github.com/repos/flynn/flynn/statuses/d82589915c85baf4d567892a1f43dd9dd0483dcc"}}}}