{"action":"created","issue":{"url":"https://api.github.com/repos/jakemmarsh/angularjs-gulp-browserify-boilerplate/issues/107","labels_url":"https://api.github.com/repos/jakemmarsh/angularjs-gulp-browserify-boilerplate/issues/107/labels{/name}","comments_url":"https://api.github.com/repos/jakemmarsh/angularjs-gulp-browserify-boilerplate/issues/107/comments","events_url":"https://api.github.com/repos/jakemmarsh/angularjs-gulp-browserify-boilerplate/issues/107/events","html_url":"https://github.com/jakemmarsh/angularjs-gulp-browserify-boilerplate/pull/107","id":115721342,"number":107,"title":"Fix not being able to serve fonts and other assets using query string cache busters.","user":{"login":"StrikeForceZero","id":983413,"avatar_url":"https://avatars.githubusercontent.com/u/983413?v=3","gravatar_id":"","url":"https://api.github.com/users/StrikeForceZero","html_url":"https://github.com/StrikeForceZero","followers_url":"https://api.github.com/users/StrikeForceZero/followers","following_url":"https://api.github.com/users/StrikeForceZero/following{/other_user}","gists_url":"https://api.github.com/users/StrikeForceZero/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeForceZero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeForceZero/subscriptions","organizations_url":"https://api.github.com/users/StrikeForceZero/orgs","repos_url":"https://api.github.com/users/StrikeForceZero/repos","events_url":"https://api.github.com/users/StrikeForceZero/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeForceZero/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-11-08T10:03:42Z","updated_at":"2015-11-09T01:30:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jakemmarsh/angularjs-gulp-browserify-boilerplate/pulls/107","html_url":"https://github.com/jakemmarsh/angularjs-gulp-browserify-boilerplate/pull/107","diff_url":"https://github.com/jakemmarsh/angularjs-gulp-browserify-boilerplate/pull/107.diff","patch_url":"https://github.com/jakemmarsh/angularjs-gulp-browserify-boilerplate/pull/107.patch"},"body":"I was losing my sanity thinking I broke something after merging all the es6 changes lol.\r\n\r\none of the regressions was browserSync checking to see if an assets extensions was whitelisted in a predefined array. Unfortunately some fonts use somefont.tff?v1.2.4 as their name to prevent caching.\r\nWith the logic of splitting every occurrence of a period you'd get an array [somefont, ttf?v1, 2, 4] which would fail even if you explicitly added ttf to that array. \r\n\r\nI was going to add a regex to search for the extension but then I thought what's the point of this? why not just allow anything that has an extension? as everything routed through angular uses a directory structure. And anything with a '.' is probably an asset.\r\n\r\nIf someone wants to use /myapp.dev/ then I guess a regex would be needed. Thoughts?"},"comment":{"url":"https://api.github.com/repos/jakemmarsh/angularjs-gulp-browserify-boilerplate/issues/comments/154898677","html_url":"https://github.com/jakemmarsh/angularjs-gulp-browserify-boilerplate/pull/107#issuecomment-154898677","issue_url":"https://api.github.com/repos/jakemmarsh/angularjs-gulp-browserify-boilerplate/issues/107","id":154898677,"user":{"login":"StrikeForceZero","id":983413,"avatar_url":"https://avatars.githubusercontent.com/u/983413?v=3","gravatar_id":"","url":"https://api.github.com/users/StrikeForceZero","html_url":"https://github.com/StrikeForceZero","followers_url":"https://api.github.com/users/StrikeForceZero/followers","following_url":"https://api.github.com/users/StrikeForceZero/following{/other_user}","gists_url":"https://api.github.com/users/StrikeForceZero/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeForceZero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeForceZero/subscriptions","organizations_url":"https://api.github.com/users/StrikeForceZero/orgs","repos_url":"https://api.github.com/users/StrikeForceZero/repos","events_url":"https://api.github.com/users/StrikeForceZero/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeForceZero/received_events","type":"User","site_admin":false},"created_at":"2015-11-09T01:30:44Z","updated_at":"2015-11-09T01:30:44Z","body":"Last minute thought on the regex.. we should make sure it doesn't catch things that **start** with a whitelisted extension\r\n\r\n[test case](https://regex101.com/r/dV8cW2/4)"}}