{"action":"created","issue":{"url":"https://api.github.com/repos/SuperTux88/diaspora_federation/issues/13","labels_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/issues/13/comments","events_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/issues/13/events","html_url":"https://github.com/SuperTux88/diaspora_federation/pull/13","id":116401991,"number":13,"title":"[WIP] Add signature computation for entities support","user":{"login":"cmrd-senya","id":10187586,"avatar_url":"https://avatars.githubusercontent.com/u/10187586?v=3","gravatar_id":"","url":"https://api.github.com/users/cmrd-senya","html_url":"https://github.com/cmrd-senya","followers_url":"https://api.github.com/users/cmrd-senya/followers","following_url":"https://api.github.com/users/cmrd-senya/following{/other_user}","gists_url":"https://api.github.com/users/cmrd-senya/gists{/gist_id}","starred_url":"https://api.github.com/users/cmrd-senya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmrd-senya/subscriptions","organizations_url":"https://api.github.com/users/cmrd-senya/orgs","repos_url":"https://api.github.com/users/cmrd-senya/repos","events_url":"https://api.github.com/users/cmrd-senya/events{/privacy}","received_events_url":"https://api.github.com/users/cmrd-senya/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-11-11T19:15:03Z","updated_at":"2015-11-21T17:35:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SuperTux88/diaspora_federation/pulls/13","html_url":"https://github.com/SuperTux88/diaspora_federation/pull/13","diff_url":"https://github.com/SuperTux88/diaspora_federation/pull/13.diff","patch_url":"https://github.com/SuperTux88/diaspora_federation/pull/13.patch"},"body":"This is a preliminary patch that implements signatures support for entities, the functionality that in Diaspora source represented by https://github.com/diaspora/diaspora/blob/develop/lib/diaspora/encryptable.rb and friends.\r\n\r\nIt notably differs from the way it is done in Diaspora. The thing is that in [4269](https://github.com/diaspora/diaspora/pull/4269) and [4935](https://github.com/diaspora/diaspora/pull/4935) developers faced problem, that adding any new field to an entity would break backward compatibility with older diaspora implementations. That's why I moved signable_string to the XmlPayload class. There it will iterate every field in received Salmon during signature generation, no matter if an entity class aware of it or not.\r\n\r\nThis, though, forced me to move signatures update routine call to the MagicEnvelope class, because it encapsulates all the work with XmlPayload.\r\n\r\nI put it here in order to receive some feedback on the approach I picked."},"comment":{"url":"https://api.github.com/repos/SuperTux88/diaspora_federation/issues/comments/158663861","html_url":"https://github.com/SuperTux88/diaspora_federation/pull/13#issuecomment-158663861","issue_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/issues/13","id":158663861,"user":{"login":"cmrd-senya","id":10187586,"avatar_url":"https://avatars.githubusercontent.com/u/10187586?v=3","gravatar_id":"","url":"https://api.github.com/users/cmrd-senya","html_url":"https://github.com/cmrd-senya","followers_url":"https://api.github.com/users/cmrd-senya/followers","following_url":"https://api.github.com/users/cmrd-senya/following{/other_user}","gists_url":"https://api.github.com/users/cmrd-senya/gists{/gist_id}","starred_url":"https://api.github.com/users/cmrd-senya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmrd-senya/subscriptions","organizations_url":"https://api.github.com/users/cmrd-senya/orgs","repos_url":"https://api.github.com/users/cmrd-senya/repos","events_url":"https://api.github.com/users/cmrd-senya/events{/privacy}","received_events_url":"https://api.github.com/users/cmrd-senya/received_events","type":"User","site_admin":false},"created_at":"2015-11-21T17:35:03Z","updated_at":"2015-11-21T17:35:03Z","body":"It looks to me like I have accepted all the remarks.\r\nTell me, if it is ok to make squash or I shall correct something else."}}