{"action":"closed","number":9323,"pull_request":{"url":"https://api.github.com/repos/grails/grails-core/pulls/9323","id":47076036,"html_url":"https://github.com/grails/grails-core/pull/9323","diff_url":"https://github.com/grails/grails-core/pull/9323.diff","patch_url":"https://github.com/grails/grails-core/pull/9323.patch","issue_url":"https://api.github.com/repos/grails/grails-core/issues/9323","number":9323,"state":"closed","locked":false,"title":"Issue #9090 - Grails docs not building the source tags","user":{"login":"jwagenleitner","id":97695,"avatar_url":"https://avatars.githubusercontent.com/u/97695?v=3","gravatar_id":"","url":"https://api.github.com/users/jwagenleitner","html_url":"https://github.com/jwagenleitner","followers_url":"https://api.github.com/users/jwagenleitner/followers","following_url":"https://api.github.com/users/jwagenleitner/following{/other_user}","gists_url":"https://api.github.com/users/jwagenleitner/gists{/gist_id}","starred_url":"https://api.github.com/users/jwagenleitner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwagenleitner/subscriptions","organizations_url":"https://api.github.com/users/jwagenleitner/orgs","repos_url":"https://api.github.com/users/jwagenleitner/repos","events_url":"https://api.github.com/users/jwagenleitner/events{/privacy}","received_events_url":"https://api.github.com/users/jwagenleitner/received_events","type":"User","site_admin":false},"body":"Regex was not picking up the new tag closure signature (def -> Closure).  Also it had issues identifying the end of the method, relying on either a javadoc comment or a `def method...`.  In looking at various taglibs there was a variety of things after the closure that would have been difficult to write a regex for so went with counting braces.\r\n\r\nAlso will submit a PR for the grails-docs repo.","created_at":"2015-10-07T20:14:29Z","updated_at":"2015-10-07T20:52:49Z","closed_at":"2015-10-07T20:52:49Z","merged_at":"2015-10-07T20:52:49Z","merge_commit_sha":"9e3728963a27bdae682ef1ba096987d9444a0130","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/grails/grails-core/pulls/9323/commits","review_comments_url":"https://api.github.com/repos/grails/grails-core/pulls/9323/comments","review_comment_url":"https://api.github.com/repos/grails/grails-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grails/grails-core/issues/9323/comments","statuses_url":"https://api.github.com/repos/grails/grails-core/statuses/aaa44450aa4cc01e42ea5727c4c2ca2524aa0c44","head":{"label":"jwagenleitner:issue-9090","ref":"issue-9090","sha":"aaa44450aa4cc01e42ea5727c4c2ca2524aa0c44","user":{"login":"jwagenleitner","id":97695,"avatar_url":"https://avatars.githubusercontent.com/u/97695?v=3","gravatar_id":"","url":"https://api.github.com/users/jwagenleitner","html_url":"https://github.com/jwagenleitner","followers_url":"https://api.github.com/users/jwagenleitner/followers","following_url":"https://api.github.com/users/jwagenleitner/following{/other_user}","gists_url":"https://api.github.com/users/jwagenleitner/gists{/gist_id}","starred_url":"https://api.github.com/users/jwagenleitner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwagenleitner/subscriptions","organizations_url":"https://api.github.com/users/jwagenleitner/orgs","repos_url":"https://api.github.com/users/jwagenleitner/repos","events_url":"https://api.github.com/users/jwagenleitner/events{/privacy}","received_events_url":"https://api.github.com/users/jwagenleitner/received_events","type":"User","site_admin":false},"repo":{"id":42155651,"name":"grails-core","full_name":"jwagenleitner/grails-core","owner":{"login":"jwagenleitner","id":97695,"avatar_url":"https://avatars.githubusercontent.com/u/97695?v=3","gravatar_id":"","url":"https://api.github.com/users/jwagenleitner","html_url":"https://github.com/jwagenleitner","followers_url":"https://api.github.com/users/jwagenleitner/followers","following_url":"https://api.github.com/users/jwagenleitner/following{/other_user}","gists_url":"https://api.github.com/users/jwagenleitner/gists{/gist_id}","starred_url":"https://api.github.com/users/jwagenleitner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwagenleitner/subscriptions","organizations_url":"https://api.github.com/users/jwagenleitner/orgs","repos_url":"https://api.github.com/users/jwagenleitner/repos","events_url":"https://api.github.com/users/jwagenleitner/events{/privacy}","received_events_url":"https://api.github.com/users/jwagenleitner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwagenleitner/grails-core","description":"The Grails Web Application Framework","fork":true,"url":"https://api.github.com/repos/jwagenleitner/grails-core","forks_url":"https://api.github.com/repos/jwagenleitner/grails-core/forks","keys_url":"https://api.github.com/repos/jwagenleitner/grails-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwagenleitner/grails-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwagenleitner/grails-core/teams","hooks_url":"https://api.github.com/repos/jwagenleitner/grails-core/hooks","issue_events_url":"https://api.github.com/repos/jwagenleitner/grails-core/issues/events{/number}","events_url":"https://api.github.com/repos/jwagenleitner/grails-core/events","assignees_url":"https://api.github.com/repos/jwagenleitner/grails-core/assignees{/user}","branches_url":"https://api.github.com/repos/jwagenleitner/grails-core/branches{/branch}","tags_url":"https://api.github.com/repos/jwagenleitner/grails-core/tags","blobs_url":"https://api.github.com/repos/jwagenleitner/grails-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwagenleitner/grails-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwagenleitner/grails-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwagenleitner/grails-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwagenleitner/grails-core/statuses/{sha}","languages_url":"https://api.github.com/repos/jwagenleitner/grails-core/languages","stargazers_url":"https://api.github.com/repos/jwagenleitner/grails-core/stargazers","contributors_url":"https://api.github.com/repos/jwagenleitner/grails-core/contributors","subscribers_url":"https://api.github.com/repos/jwagenleitner/grails-core/subscribers","subscription_url":"https://api.github.com/repos/jwagenleitner/grails-core/subscription","commits_url":"https://api.github.com/repos/jwagenleitner/grails-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwagenleitner/grails-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwagenleitner/grails-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwagenleitner/grails-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwagenleitner/grails-core/contents/{+path}","compare_url":"https://api.github.com/repos/jwagenleitner/grails-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwagenleitner/grails-core/merges","archive_url":"https://api.github.com/repos/jwagenleitner/grails-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwagenleitner/grails-core/downloads","issues_url":"https://api.github.com/repos/jwagenleitner/grails-core/issues{/number}","pulls_url":"https://api.github.com/repos/jwagenleitner/grails-core/pulls{/number}","milestones_url":"https://api.github.com/repos/jwagenleitner/grails-core/milestones{/number}","notifications_url":"https://api.github.com/repos/jwagenleitner/grails-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwagenleitner/grails-core/labels{/name}","releases_url":"https://api.github.com/repos/jwagenleitner/grails-core/releases{/id}","created_at":"2015-09-09T04:19:43Z","updated_at":"2015-09-09T04:19:49Z","pushed_at":"2015-10-07T19:46:53Z","git_url":"git://github.com/jwagenleitner/grails-core.git","ssh_url":"git@github.com:jwagenleitner/grails-core.git","clone_url":"https://github.com/jwagenleitner/grails-core.git","svn_url":"https://github.com/jwagenleitner/grails-core","homepage":"http://grails.org","size":329033,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grails:master","ref":"master","sha":"a0fc26034a37dbe106e0c7c38c470dda827abe07","user":{"login":"grails","id":64546,"avatar_url":"https://avatars.githubusercontent.com/u/64546?v=3","gravatar_id":"","url":"https://api.github.com/users/grails","html_url":"https://github.com/grails","followers_url":"https://api.github.com/users/grails/followers","following_url":"https://api.github.com/users/grails/following{/other_user}","gists_url":"https://api.github.com/users/grails/gists{/gist_id}","starred_url":"https://api.github.com/users/grails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grails/subscriptions","organizations_url":"https://api.github.com/users/grails/orgs","repos_url":"https://api.github.com/users/grails/repos","events_url":"https://api.github.com/users/grails/events{/privacy}","received_events_url":"https://api.github.com/users/grails/received_events","type":"Organization","site_admin":false},"repo":{"id":512295,"name":"grails-core","full_name":"grails/grails-core","owner":{"login":"grails","id":64546,"avatar_url":"https://avatars.githubusercontent.com/u/64546?v=3","gravatar_id":"","url":"https://api.github.com/users/grails","html_url":"https://github.com/grails","followers_url":"https://api.github.com/users/grails/followers","following_url":"https://api.github.com/users/grails/following{/other_user}","gists_url":"https://api.github.com/users/grails/gists{/gist_id}","starred_url":"https://api.github.com/users/grails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grails/subscriptions","organizations_url":"https://api.github.com/users/grails/orgs","repos_url":"https://api.github.com/users/grails/repos","events_url":"https://api.github.com/users/grails/events{/privacy}","received_events_url":"https://api.github.com/users/grails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grails/grails-core","description":"The Grails Web Application Framework","fork":false,"url":"https://api.github.com/repos/grails/grails-core","forks_url":"https://api.github.com/repos/grails/grails-core/forks","keys_url":"https://api.github.com/repos/grails/grails-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grails/grails-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grails/grails-core/teams","hooks_url":"https://api.github.com/repos/grails/grails-core/hooks","issue_events_url":"https://api.github.com/repos/grails/grails-core/issues/events{/number}","events_url":"https://api.github.com/repos/grails/grails-core/events","assignees_url":"https://api.github.com/repos/grails/grails-core/assignees{/user}","branches_url":"https://api.github.com/repos/grails/grails-core/branches{/branch}","tags_url":"https://api.github.com/repos/grails/grails-core/tags","blobs_url":"https://api.github.com/repos/grails/grails-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grails/grails-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grails/grails-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/grails/grails-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grails/grails-core/statuses/{sha}","languages_url":"https://api.github.com/repos/grails/grails-core/languages","stargazers_url":"https://api.github.com/repos/grails/grails-core/stargazers","contributors_url":"https://api.github.com/repos/grails/grails-core/contributors","subscribers_url":"https://api.github.com/repos/grails/grails-core/subscribers","subscription_url":"https://api.github.com/repos/grails/grails-core/subscription","commits_url":"https://api.github.com/repos/grails/grails-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/grails/grails-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/grails/grails-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/grails/grails-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/grails/grails-core/contents/{+path}","compare_url":"https://api.github.com/repos/grails/grails-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grails/grails-core/merges","archive_url":"https://api.github.com/repos/grails/grails-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grails/grails-core/downloads","issues_url":"https://api.github.com/repos/grails/grails-core/issues{/number}","pulls_url":"https://api.github.com/repos/grails/grails-core/pulls{/number}","milestones_url":"https://api.github.com/repos/grails/grails-core/milestones{/number}","notifications_url":"https://api.github.com/repos/grails/grails-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grails/grails-core/labels{/name}","releases_url":"https://api.github.com/repos/grails/grails-core/releases{/id}","created_at":"2010-02-10T23:57:57Z","updated_at":"2015-10-07T08:16:16Z","pushed_at":"2015-10-07T20:52:49Z","git_url":"git://github.com/grails/grails-core.git","ssh_url":"git@github.com:grails/grails-core.git","clone_url":"https://github.com/grails/grails-core.git","svn_url":"https://github.com/grails/grails-core","homepage":"http://grails.org","size":423052,"stargazers_count":1481,"watchers_count":1481,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":713,"mirror_url":null,"open_issues_count":110,"forks":713,"open_issues":110,"watchers":1481,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grails/grails-core/pulls/9323"},"html":{"href":"https://github.com/grails/grails-core/pull/9323"},"issue":{"href":"https://api.github.com/repos/grails/grails-core/issues/9323"},"comments":{"href":"https://api.github.com/repos/grails/grails-core/issues/9323/comments"},"review_comments":{"href":"https://api.github.com/repos/grails/grails-core/pulls/9323/comments"},"review_comment":{"href":"https://api.github.com/repos/grails/grails-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grails/grails-core/pulls/9323/commits"},"statuses":{"href":"https://api.github.com/repos/grails/grails-core/statuses/aaa44450aa4cc01e42ea5727c4c2ca2524aa0c44"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"graemerocher","id":66626,"avatar_url":"https://avatars.githubusercontent.com/u/66626?v=3","gravatar_id":"","url":"https://api.github.com/users/graemerocher","html_url":"https://github.com/graemerocher","followers_url":"https://api.github.com/users/graemerocher/followers","following_url":"https://api.github.com/users/graemerocher/following{/other_user}","gists_url":"https://api.github.com/users/graemerocher/gists{/gist_id}","starred_url":"https://api.github.com/users/graemerocher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graemerocher/subscriptions","organizations_url":"https://api.github.com/users/graemerocher/orgs","repos_url":"https://api.github.com/users/graemerocher/repos","events_url":"https://api.github.com/users/graemerocher/events{/privacy}","received_events_url":"https://api.github.com/users/graemerocher/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":252,"deletions":6,"changed_files":2}}