{"action":"created","issue":{"url":"https://api.github.com/repos/twitter/twitter-cldr-js/issues/62","labels_url":"https://api.github.com/repos/twitter/twitter-cldr-js/issues/62/labels{/name}","comments_url":"https://api.github.com/repos/twitter/twitter-cldr-js/issues/62/comments","events_url":"https://api.github.com/repos/twitter/twitter-cldr-js/issues/62/events","html_url":"https://github.com/twitter/twitter-cldr-js/pull/62","id":83367637,"number":62,"title":"Data/logic separation","user":{"login":"radzinzki","id":3008045,"avatar_url":"https://avatars.githubusercontent.com/u/3008045?v=3","gravatar_id":"","url":"https://api.github.com/users/radzinzki","html_url":"https://github.com/radzinzki","followers_url":"https://api.github.com/users/radzinzki/followers","following_url":"https://api.github.com/users/radzinzki/following{/other_user}","gists_url":"https://api.github.com/users/radzinzki/gists{/gist_id}","starred_url":"https://api.github.com/users/radzinzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radzinzki/subscriptions","organizations_url":"https://api.github.com/users/radzinzki/orgs","repos_url":"https://api.github.com/users/radzinzki/repos","events_url":"https://api.github.com/users/radzinzki/events{/privacy}","received_events_url":"https://api.github.com/users/radzinzki/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-01T07:47:14Z","updated_at":"2015-06-20T10:59:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/twitter/twitter-cldr-js/pulls/62","html_url":"https://github.com/twitter/twitter-cldr-js/pull/62","diff_url":"https://github.com/twitter/twitter-cldr-js/pull/62.diff","patch_url":"https://github.com/twitter/twitter-cldr-js/pull/62.patch"},"body":"__Separates the implementation from the locale specific data.__\r\n- The base implementation goes to a file called `twitter_cldr.js` and all the locale specific data are compiled in files named after the locale, for example, `en.js`, `ru.js`, etc.\r\n- The implementation files have placeholder empty dictionaries/objects (`{}`) which get overwritten by the set_data method on the `TwitterCldr` object.\r\n\r\n__Sample usage (Node):__\r\n\r\n```\r\nvar TwitterCldr = require('../../../lib/assets/javascripts/twitter_cldr/twitter_cldr.js');\r\nvar data = require('../../../lib/assets/javascripts/twitter_cldr/en.js');\r\nTwitterCldr.set_data(data);\r\n```\r\n\r\n__TODO__\r\n - [ ] Update Docs\r\n - [ ] Discuss code organization of the project (Currently the respective name spaces are called `data` and `implementation` respectively.\r\n - [ ] Discuss release because this PR makes breaking changes."},"comment":{"url":"https://api.github.com/repos/twitter/twitter-cldr-js/issues/comments/113746233","html_url":"https://github.com/twitter/twitter-cldr-js/pull/62#issuecomment-113746233","issue_url":"https://api.github.com/repos/twitter/twitter-cldr-js/issues/62","id":113746233,"user":{"login":"radzinzki","id":3008045,"avatar_url":"https://avatars.githubusercontent.com/u/3008045?v=3","gravatar_id":"","url":"https://api.github.com/users/radzinzki","html_url":"https://github.com/radzinzki","followers_url":"https://api.github.com/users/radzinzki/followers","following_url":"https://api.github.com/users/radzinzki/following{/other_user}","gists_url":"https://api.github.com/users/radzinzki/gists{/gist_id}","starred_url":"https://api.github.com/users/radzinzki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radzinzki/subscriptions","organizations_url":"https://api.github.com/users/radzinzki/orgs","repos_url":"https://api.github.com/users/radzinzki/repos","events_url":"https://api.github.com/users/radzinzki/events{/privacy}","received_events_url":"https://api.github.com/users/radzinzki/received_events","type":"User","site_admin":false},"created_at":"2015-06-20T10:59:09Z","updated_at":"2015-06-20T10:59:09Z","body":"@KL-7 Thanks for the review and comments. You're right. Most of the changes are just renderers being moved around and the CoffeeScript files being split to accommodate these changes.\r\nI'll move the `is_rtl` to being a method. That makes way more sense!\r\n\r\n\r\nRegarding the locale property, I'll push a branch to demonstrate the issue and let you know. If we move `is_rtl` to being a method, then you're right, having `Settings` with just `locale` doesn't feel right. Let me see what I can do about that.\r\n"}}