{"action":"created","issue":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5036","labels_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5036/labels{/name}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5036/comments","events_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5036/events","html_url":"https://github.com/ember-cli/ember-cli/pull/5036","id":115084065,"number":5036,"title":"Remove native bundled dependencies","user":{"login":"patocallaghan","id":685034,"avatar_url":"https://avatars.githubusercontent.com/u/685034?v=3","gravatar_id":"","url":"https://api.github.com/users/patocallaghan","html_url":"https://github.com/patocallaghan","followers_url":"https://api.github.com/users/patocallaghan/followers","following_url":"https://api.github.com/users/patocallaghan/following{/other_user}","gists_url":"https://api.github.com/users/patocallaghan/gists{/gist_id}","starred_url":"https://api.github.com/users/patocallaghan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patocallaghan/subscriptions","organizations_url":"https://api.github.com/users/patocallaghan/orgs","repos_url":"https://api.github.com/users/patocallaghan/repos","events_url":"https://api.github.com/users/patocallaghan/events{/privacy}","received_events_url":"https://api.github.com/users/patocallaghan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":28,"created_at":"2015-11-04T15:53:05Z","updated_at":"2015-11-10T20:22:30Z","closed_at":"2015-11-07T18:36:27Z","pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli/pulls/5036","html_url":"https://github.com/ember-cli/ember-cli/pull/5036","diff_url":"https://github.com/ember-cli/ember-cli/pull/5036.diff","patch_url":"https://github.com/ember-cli/ember-cli/pull/5036.patch"},"body":"Re: https://github.com/ember-cli/ember-cli/issues/5028#issuecomment-153405634\r\n\r\n@stefanpenner this is more a placeholder for discussion rather than a finished PR. Would appreciate you chiming in with your thoughts whether this is even on the right track or not.\r\n\r\n## ws.js\r\nIt seems the issue of failing native dependencies has been fixed in npm 3.3.12\r\n\r\n* Optional dependencies causing an install to fail was fixed in https://github.com/npm/npm/commit/2289234e11b30c878585aebee68d4a3a5bd63cce See https://github.com/npm/npm/issues/9643 for the related issue\r\n* running `--no-optional` should not try to install bundled dependencies in deps of deps\r\n\r\nThis means we don't need the patch for `ws.js` as `bufferutil` and `utf8-validation` will not be installed.\r\n\r\n## patch-engine-io-client.js\r\nit appears the reference to the `tgz` [has been removed](https://github.com/socketio/engine.io-client/pull/401/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L38) but it hasn't shipped in a release yet . Not entirely sure what we can do here though besides pushing for a release or making our own fork.\r\n\r\n### BUT\r\n\r\nthere's a bug with the 3.3.12 version of NPM which prevents `./bin/prepare-release` from finishing. If you try to `npm uninstall` or `npm unlink` a `npm link`'d global module, the build fails. This means `prepare-release` fails at the second last step when uninstalling the global `ember-cli`.  See here for more on the issue https://github.com/npm/npm/issues/9980.\r\n\r\nWe could possibly do a `which ember`, work out where the global ember is installed, and manually `rm -rf` it?\r\n"},"comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/comments/155554586","html_url":"https://github.com/ember-cli/ember-cli/pull/5036#issuecomment-155554586","issue_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/5036","id":155554586,"user":{"login":"tim-evans","id":177701,"avatar_url":"https://avatars.githubusercontent.com/u/177701?v=3","gravatar_id":"","url":"https://api.github.com/users/tim-evans","html_url":"https://github.com/tim-evans","followers_url":"https://api.github.com/users/tim-evans/followers","following_url":"https://api.github.com/users/tim-evans/following{/other_user}","gists_url":"https://api.github.com/users/tim-evans/gists{/gist_id}","starred_url":"https://api.github.com/users/tim-evans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tim-evans/subscriptions","organizations_url":"https://api.github.com/users/tim-evans/orgs","repos_url":"https://api.github.com/users/tim-evans/repos","events_url":"https://api.github.com/users/tim-evans/events{/privacy}","received_events_url":"https://api.github.com/users/tim-evans/received_events","type":"User","site_admin":false},"created_at":"2015-11-10T20:22:30Z","updated_at":"2015-11-10T20:22:30Z","body":"ember-cli is now failing to install due to `engine.io-client-pure` not being an available package. It seem that https://github.com/socketio/socket.io-client/blob/master/package.json#L15 now references `automattic/engine.io-client#ea5b5f` rather than `socketio/engine.io-client#ea5b5f`.\r\n\r\nAny ideas on how to resolve this?"}}