{"action":"created","issue":{"url":"https://api.github.com/repos/FreeOpcUa/freeopcua/issues/133","labels_url":"https://api.github.com/repos/FreeOpcUa/freeopcua/issues/133/labels{/name}","comments_url":"https://api.github.com/repos/FreeOpcUa/freeopcua/issues/133/comments","events_url":"https://api.github.com/repos/FreeOpcUa/freeopcua/issues/133/events","html_url":"https://github.com/FreeOpcUa/freeopcua/pull/133","id":73508491,"number":133,"title":"Changes to build on Windows, handling of errors","user":{"login":"RavilN","id":6540681,"avatar_url":"https://avatars.githubusercontent.com/u/6540681?v=3","gravatar_id":"","url":"https://api.github.com/users/RavilN","html_url":"https://github.com/RavilN","followers_url":"https://api.github.com/users/RavilN/followers","following_url":"https://api.github.com/users/RavilN/following{/other_user}","gists_url":"https://api.github.com/users/RavilN/gists{/gist_id}","starred_url":"https://api.github.com/users/RavilN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RavilN/subscriptions","organizations_url":"https://api.github.com/users/RavilN/orgs","repos_url":"https://api.github.com/users/RavilN/repos","events_url":"https://api.github.com/users/RavilN/events{/privacy}","received_events_url":"https://api.github.com/users/RavilN/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":27,"created_at":"2015-05-06T04:13:09Z","updated_at":"2015-05-21T08:02:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/FreeOpcUa/freeopcua/pulls/133","html_url":"https://github.com/FreeOpcUa/freeopcua/pull/133","diff_url":"https://github.com/FreeOpcUa/freeopcua/pull/133.diff","patch_url":"https://github.com/FreeOpcUa/freeopcua/pull/133.patch"},"body":"Changes in CMakeLists.txt to build on Windows (tested with Visual Studio\r\n2013);\r\nHandling of errors returned from UA Server;\r\nExample Client connects to Demo Server form Unified Automation."},"comment":{"url":"https://api.github.com/repos/FreeOpcUa/freeopcua/issues/comments/104171836","html_url":"https://github.com/FreeOpcUa/freeopcua/pull/133#issuecomment-104171836","issue_url":"https://api.github.com/repos/FreeOpcUa/freeopcua/issues/133","id":104171836,"user":{"login":"oroulet","id":2564046,"avatar_url":"https://avatars.githubusercontent.com/u/2564046?v=3","gravatar_id":"","url":"https://api.github.com/users/oroulet","html_url":"https://github.com/oroulet","followers_url":"https://api.github.com/users/oroulet/followers","following_url":"https://api.github.com/users/oroulet/following{/other_user}","gists_url":"https://api.github.com/users/oroulet/gists{/gist_id}","starred_url":"https://api.github.com/users/oroulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oroulet/subscriptions","organizations_url":"https://api.github.com/users/oroulet/orgs","repos_url":"https://api.github.com/users/oroulet/repos","events_url":"https://api.github.com/users/oroulet/events{/privacy}","received_events_url":"https://api.github.com/users/oroulet/received_events","type":"User","site_admin":false},"created_at":"2015-05-21T08:02:12Z","updated_at":"2015-05-21T08:02:12Z","body":"travis test now passes because I restarted it. it seems there is a\nthreading error left somewhere and one test hang....\n\nOn Thu, 21 May 2015 at 09:59 Olivier Roulet-Dubonnet <\nolivier.roulet@gmail.com> wrote:\n\n> I completely agree it does not need to be in WIN32 section either, this\n> code is generic. I propose to merge #133 and then you send a pull request\n> to simplify the cmake stuff.\n>\n> On Thu, 21 May 2015 at 09:39 tomkcook <notifications@github.com> wrote:\n>\n>> It seems Travis now passes this, though I can't quite spot what's changed\n>> since it failed.\n>>\n>> I'd suggest, though, that the CMake recipe for finding boost should be\n>> simplified somewhat - just have this in the if(WIN32) section:\n>>\n>> find_package(Boost COMPONENTS system program_options filesystem thread REQUIRED)\n>> include_directories( ${Boost_INCLUDE_DIR} )\n>> link_directories( ${Boost_LIBRARY_DIR} )\n>>\n>> then let the person building it set BOOST_ROOT (and BOOST_LIBRARYDIR if\n>> necessary) and let CMake sort the rest out. This is how CMake is supposed\n>> to work, I think, rather than messing with Boost_INCLUDE_DIR and\n>> Boost_LIBRARY_DIR directly.\n>>\n>> —\n>> Reply to this email directly or view it on GitHub\n>> <https://github.com/FreeOpcUa/freeopcua/pull/133#issuecomment-104167377>.\n>>\n>\n"}}