{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/32931730","id":32931730,"diff_hunk":"@@ -0,0 +1,52 @@\n+//------------------------------------------------------------------------------\n+/*\n+    This file is part of rippled: https://github.com/ripple/rippled\n+    Copyright (c) 2012, 2013 Ripple Labs Inc.\n+\n+    Permission to use, copy, modify, and/or distribute this software for any\n+    purpose  with  or without fee is hereby granted, provided that the above\n+    copyright notice and this permission notice appear in all copies.\n+\n+    THE  SOFTWARE IS PROVIDED \"AS IS\" AND THE AUTHOR DISCLAIMS ALL WARRANTIES\n+    WITH  REGARD  TO  THIS  SOFTWARE  INCLUDING  ALL  IMPLIED  WARRANTIES  OF\n+    MERCHANTABILITY  AND  FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR\n+    ANY  SPECIAL ,  DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES\n+    WHATSOEVER  RESULTING  FROM  LOSS  OF USE, DATA OR PROFITS, WHETHER IN AN\n+    ACTION  OF  CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF\n+    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.\n+*/\n+//==============================================================================\n+\n+#ifndef RIPPLE_TEST_JTX_QUALITY_H_INCLUDED\n+#define RIPPLE_TEST_JTX_QUALITY_H_INCLUDED\n+\n+#include <ripple/test/jtx/Env.h>\n+#include <ripple/test/jtx/tags.h>\n+\n+namespace ripple {\n+namespace test {\n+namespace jtx {\n+\n+/** Set the quality on a JTx. */\n+class quality","path":"src/ripple/test/jtx/quality.h","position":31,"original_position":31,"commit_id":"e8e4a6028b7c35d7ea4a386d658e330f46d88348","original_commit_id":"e8e4a6028b7c35d7ea4a386d658e330f46d88348","user":{"login":"vinniefalco","id":1503976,"avatar_url":"https://avatars.githubusercontent.com/u/1503976?v=3","gravatar_id":"","url":"https://api.github.com/users/vinniefalco","html_url":"https://github.com/vinniefalco","followers_url":"https://api.github.com/users/vinniefalco/followers","following_url":"https://api.github.com/users/vinniefalco/following{/other_user}","gists_url":"https://api.github.com/users/vinniefalco/gists{/gist_id}","starred_url":"https://api.github.com/users/vinniefalco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinniefalco/subscriptions","organizations_url":"https://api.github.com/users/vinniefalco/orgs","repos_url":"https://api.github.com/users/vinniefalco/repos","events_url":"https://api.github.com/users/vinniefalco/events{/privacy}","received_events_url":"https://api.github.com/users/vinniefalco/received_events","type":"User","site_admin":false},"body":"This quality class is not useful enough to put in src/ripple/test/jtx. In fact the same could be achieved with one or two calls to the JSON funclet:\r\n```\r\n..., json(sfQualityIn.fieldName, 1000000), json(sfQualityOut.fieldName, 40000)\r\n```\r\nConsidering that almost no other tests would need it, I think it belongs in Path_test.cpp\r\n","created_at":"2015-06-22T13:09:36Z","updated_at":"2015-06-22T13:09:36Z","html_url":"https://github.com/ripple/rippled/pull/1139#discussion_r32931730","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/1139","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/32931730"},"html":{"href":"https://github.com/ripple/rippled/pull/1139#discussion_r32931730"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1139"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/1139","id":38148226,"html_url":"https://github.com/ripple/rippled/pull/1139","diff_url":"https://github.com/ripple/rippled/pull/1139.diff","patch_url":"https://github.com/ripple/rippled/pull/1139.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/1139","number":1139,"state":"open","locked":false,"title":"Path finding unit tests (RIPD-731)","user":{"login":"miguelportilla","id":1524671,"avatar_url":"https://avatars.githubusercontent.com/u/1524671?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelportilla","html_url":"https://github.com/miguelportilla","followers_url":"https://api.github.com/users/miguelportilla/followers","following_url":"https://api.github.com/users/miguelportilla/following{/other_user}","gists_url":"https://api.github.com/users/miguelportilla/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelportilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelportilla/subscriptions","organizations_url":"https://api.github.com/users/miguelportilla/orgs","repos_url":"https://api.github.com/users/miguelportilla/repos","events_url":"https://api.github.com/users/miguelportilla/events{/privacy}","received_events_url":"https://api.github.com/users/miguelportilla/received_events","type":"User","site_admin":false},"body":"C++ unit test port of the integration tests found in path-test.js. Uses new jtx framework.\r\n\r\nReviewers: @seelabs @ximinez ","created_at":"2015-06-19T21:10:20Z","updated_at":"2015-06-22T13:09:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b44a76e9d8dc42c0fcd49a61de504391d2149833","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/1139/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/1139/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/1139/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/e8e4a6028b7c35d7ea4a386d658e330f46d88348","head":{"label":"miguelportilla:pf_tests","ref":"pf_tests","sha":"e8e4a6028b7c35d7ea4a386d658e330f46d88348","user":{"login":"miguelportilla","id":1524671,"avatar_url":"https://avatars.githubusercontent.com/u/1524671?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelportilla","html_url":"https://github.com/miguelportilla","followers_url":"https://api.github.com/users/miguelportilla/followers","following_url":"https://api.github.com/users/miguelportilla/following{/other_user}","gists_url":"https://api.github.com/users/miguelportilla/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelportilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelportilla/subscriptions","organizations_url":"https://api.github.com/users/miguelportilla/orgs","repos_url":"https://api.github.com/users/miguelportilla/repos","events_url":"https://api.github.com/users/miguelportilla/events{/privacy}","received_events_url":"https://api.github.com/users/miguelportilla/received_events","type":"User","site_admin":false},"repo":{"id":18802139,"name":"rippled","full_name":"miguelportilla/rippled","owner":{"login":"miguelportilla","id":1524671,"avatar_url":"https://avatars.githubusercontent.com/u/1524671?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelportilla","html_url":"https://github.com/miguelportilla","followers_url":"https://api.github.com/users/miguelportilla/followers","following_url":"https://api.github.com/users/miguelportilla/following{/other_user}","gists_url":"https://api.github.com/users/miguelportilla/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelportilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelportilla/subscriptions","organizations_url":"https://api.github.com/users/miguelportilla/orgs","repos_url":"https://api.github.com/users/miguelportilla/repos","events_url":"https://api.github.com/users/miguelportilla/events{/privacy}","received_events_url":"https://api.github.com/users/miguelportilla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miguelportilla/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/miguelportilla/rippled","forks_url":"https://api.github.com/repos/miguelportilla/rippled/forks","keys_url":"https://api.github.com/repos/miguelportilla/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miguelportilla/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miguelportilla/rippled/teams","hooks_url":"https://api.github.com/repos/miguelportilla/rippled/hooks","issue_events_url":"https://api.github.com/repos/miguelportilla/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/miguelportilla/rippled/events","assignees_url":"https://api.github.com/repos/miguelportilla/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/miguelportilla/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/miguelportilla/rippled/tags","blobs_url":"https://api.github.com/repos/miguelportilla/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miguelportilla/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miguelportilla/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/miguelportilla/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miguelportilla/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/miguelportilla/rippled/languages","stargazers_url":"https://api.github.com/repos/miguelportilla/rippled/stargazers","contributors_url":"https://api.github.com/repos/miguelportilla/rippled/contributors","subscribers_url":"https://api.github.com/repos/miguelportilla/rippled/subscribers","subscription_url":"https://api.github.com/repos/miguelportilla/rippled/subscription","commits_url":"https://api.github.com/repos/miguelportilla/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/miguelportilla/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/miguelportilla/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/miguelportilla/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/miguelportilla/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/miguelportilla/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miguelportilla/rippled/merges","archive_url":"https://api.github.com/repos/miguelportilla/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miguelportilla/rippled/downloads","issues_url":"https://api.github.com/repos/miguelportilla/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/miguelportilla/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/miguelportilla/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/miguelportilla/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miguelportilla/rippled/labels{/name}","releases_url":"https://api.github.com/repos/miguelportilla/rippled/releases{/id}","created_at":"2014-04-15T14:02:06Z","updated_at":"2015-02-05T17:31:02Z","pushed_at":"2015-06-19T20:49:56Z","git_url":"git://github.com/miguelportilla/rippled.git","ssh_url":"git@github.com:miguelportilla/rippled.git","clone_url":"https://github.com/miguelportilla/rippled.git","svn_url":"https://github.com/miguelportilla/rippled","homepage":"https://ripple.com","size":57083,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"7d329570f4f1599cf6586273b6bf8025d44ab9a9","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Ripple peer-to-peer network daemon","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","created_at":"2011-11-07T04:40:15Z","updated_at":"2015-06-21T02:51:40Z","pushed_at":"2015-06-21T03:13:50Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":117228,"stargazers_count":963,"watchers_count":963,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":270,"mirror_url":null,"open_issues_count":131,"forks":270,"open_issues":131,"watchers":963,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1139"},"html":{"href":"https://github.com/ripple/rippled/pull/1139"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/1139"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/1139/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1139/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/1139/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/e8e4a6028b7c35d7ea4a386d658e330f46d88348"}}}}