{"action":"created","comment":{"url":"https://api.github.com/repos/angular-ui/ui-router/pulls/comments/41332505","id":41332505,"diff_hunk":"@@ -917,10 +921,15 @@ function $UrlMatcherFactory() {\n     }\n \n     function getType(config, urlType, location) {\n-      if (config.type && urlType) throw new Error(\"Param '\"+id+\"' has two type configurations.\");\n+      if (config.type && urlType && config.type !== urlType) throw new Error(\"Param '\"+id+\"' has two type configurations.\");","path":"src/urlMatcherFactory.js","position":18,"original_position":18,"commit_id":"9803883c8cedff0d42ec8329b1dd7484bbc5df55","original_commit_id":"9803883c8cedff0d42ec8329b1dd7484bbc5df55","user":{"login":"christopherthielen","id":2053478,"avatar_url":"https://avatars.githubusercontent.com/u/2053478?v=3","gravatar_id":"","url":"https://api.github.com/users/christopherthielen","html_url":"https://github.com/christopherthielen","followers_url":"https://api.github.com/users/christopherthielen/followers","following_url":"https://api.github.com/users/christopherthielen/following{/other_user}","gists_url":"https://api.github.com/users/christopherthielen/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherthielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherthielen/subscriptions","organizations_url":"https://api.github.com/users/christopherthielen/orgs","repos_url":"https://api.github.com/users/christopherthielen/repos","events_url":"https://api.github.com/users/christopherthielen/events{/privacy}","received_events_url":"https://api.github.com/users/christopherthielen/received_events","type":"User","site_admin":false},"body":"whops, missed that.  I will fix and force push","created_at":"2015-10-06T22:43:46Z","updated_at":"2015-10-06T22:43:46Z","html_url":"https://github.com/angular-ui/ui-router/pull/2296#discussion_r41332505","pull_request_url":"https://api.github.com/repos/angular-ui/ui-router/pulls/2296","_links":{"self":{"href":"https://api.github.com/repos/angular-ui/ui-router/pulls/comments/41332505"},"html":{"href":"https://github.com/angular-ui/ui-router/pull/2296#discussion_r41332505"},"pull_request":{"href":"https://api.github.com/repos/angular-ui/ui-router/pulls/2296"}}},"pull_request":{"url":"https://api.github.com/repos/angular-ui/ui-router/pulls/2296","id":46967709,"html_url":"https://github.com/angular-ui/ui-router/pull/2296","diff_url":"https://github.com/angular-ui/ui-router/pull/2296.diff","patch_url":"https://github.com/angular-ui/ui-router/pull/2296.patch","issue_url":"https://api.github.com/repos/angular-ui/ui-router/issues/2296","number":2296,"state":"open","locked":false,"title":"fix(urlMatcherFactory): fix configuring a parameter type by name in a…","user":{"login":"christopherthielen","id":2053478,"avatar_url":"https://avatars.githubusercontent.com/u/2053478?v=3","gravatar_id":"","url":"https://api.github.com/users/christopherthielen","html_url":"https://github.com/christopherthielen","followers_url":"https://api.github.com/users/christopherthielen/followers","following_url":"https://api.github.com/users/christopherthielen/following{/other_user}","gists_url":"https://api.github.com/users/christopherthielen/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherthielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherthielen/subscriptions","organizations_url":"https://api.github.com/users/christopherthielen/orgs","repos_url":"https://api.github.com/users/christopherthielen/repos","events_url":"https://api.github.com/users/christopherthielen/events{/privacy}","received_events_url":"https://api.github.com/users/christopherthielen/received_events","type":"User","site_admin":false},"body":"… params block\r\n\r\ncloses #2294","created_at":"2015-10-06T22:42:09Z","updated_at":"2015-10-06T22:43:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e79c0d5ef09f6045178ca248db062ec654520516","assignee":null,"milestone":{"url":"https://api.github.com/repos/angular-ui/ui-router/milestones/12","html_url":"https://github.com/angular-ui/ui-router/milestones/0.2.16","labels_url":"https://api.github.com/repos/angular-ui/ui-router/milestones/12/labels","id":1116814,"number":12,"title":"0.2.16","description":"Schedule a release to catch up any bugs fixes in the 0.2.x series","creator":{"login":"christopherthielen","id":2053478,"avatar_url":"https://avatars.githubusercontent.com/u/2053478?v=3","gravatar_id":"","url":"https://api.github.com/users/christopherthielen","html_url":"https://github.com/christopherthielen","followers_url":"https://api.github.com/users/christopherthielen/followers","following_url":"https://api.github.com/users/christopherthielen/following{/other_user}","gists_url":"https://api.github.com/users/christopherthielen/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherthielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherthielen/subscriptions","organizations_url":"https://api.github.com/users/christopherthielen/orgs","repos_url":"https://api.github.com/users/christopherthielen/repos","events_url":"https://api.github.com/users/christopherthielen/events{/privacy}","received_events_url":"https://api.github.com/users/christopherthielen/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":18,"state":"open","created_at":"2015-05-19T01:17:06Z","updated_at":"2015-10-06T22:42:09Z","due_on":"2015-07-01T05:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/angular-ui/ui-router/pulls/2296/commits","review_comments_url":"https://api.github.com/repos/angular-ui/ui-router/pulls/2296/comments","review_comment_url":"https://api.github.com/repos/angular-ui/ui-router/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/ui-router/issues/2296/comments","statuses_url":"https://api.github.com/repos/angular-ui/ui-router/statuses/9803883c8cedff0d42ec8329b1dd7484bbc5df55","head":{"label":"angular-ui:issue2294","ref":"issue2294","sha":"9803883c8cedff0d42ec8329b1dd7484bbc5df55","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":7693799,"name":"ui-router","full_name":"angular-ui/ui-router","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/ui-router","description":"The de-facto solution to flexible routing with nested views in AngularJS","fork":false,"url":"https://api.github.com/repos/angular-ui/ui-router","forks_url":"https://api.github.com/repos/angular-ui/ui-router/forks","keys_url":"https://api.github.com/repos/angular-ui/ui-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/ui-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/ui-router/teams","hooks_url":"https://api.github.com/repos/angular-ui/ui-router/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/ui-router/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/ui-router/events","assignees_url":"https://api.github.com/repos/angular-ui/ui-router/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/ui-router/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/ui-router/tags","blobs_url":"https://api.github.com/repos/angular-ui/ui-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/ui-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/ui-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/ui-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/ui-router/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/ui-router/languages","stargazers_url":"https://api.github.com/repos/angular-ui/ui-router/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/ui-router/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/ui-router/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/ui-router/subscription","commits_url":"https://api.github.com/repos/angular-ui/ui-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/ui-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/ui-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/ui-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/ui-router/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/ui-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/ui-router/merges","archive_url":"https://api.github.com/repos/angular-ui/ui-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/ui-router/downloads","issues_url":"https://api.github.com/repos/angular-ui/ui-router/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/ui-router/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/ui-router/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/ui-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/ui-router/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/ui-router/releases{/id}","created_at":"2013-01-18T20:26:29Z","updated_at":"2015-10-06T17:35:51Z","pushed_at":"2015-10-06T22:42:10Z","git_url":"git://github.com/angular-ui/ui-router.git","ssh_url":"git@github.com:angular-ui/ui-router.git","clone_url":"https://github.com/angular-ui/ui-router.git","svn_url":"https://github.com/angular-ui/ui-router","homepage":"http://angular-ui.github.io/ui-router/site","size":13916,"stargazers_count":8540,"watchers_count":8540,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2063,"mirror_url":null,"open_issues_count":217,"forks":2063,"open_issues":217,"watchers":8540,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"1c763c88adb319ecfb37fee09b0465a83602c8e5","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":7693799,"name":"ui-router","full_name":"angular-ui/ui-router","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/ui-router","description":"The de-facto solution to flexible routing with nested views in AngularJS","fork":false,"url":"https://api.github.com/repos/angular-ui/ui-router","forks_url":"https://api.github.com/repos/angular-ui/ui-router/forks","keys_url":"https://api.github.com/repos/angular-ui/ui-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/ui-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/ui-router/teams","hooks_url":"https://api.github.com/repos/angular-ui/ui-router/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/ui-router/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/ui-router/events","assignees_url":"https://api.github.com/repos/angular-ui/ui-router/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/ui-router/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/ui-router/tags","blobs_url":"https://api.github.com/repos/angular-ui/ui-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/ui-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/ui-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/ui-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/ui-router/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/ui-router/languages","stargazers_url":"https://api.github.com/repos/angular-ui/ui-router/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/ui-router/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/ui-router/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/ui-router/subscription","commits_url":"https://api.github.com/repos/angular-ui/ui-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/ui-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/ui-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/ui-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/ui-router/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/ui-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/ui-router/merges","archive_url":"https://api.github.com/repos/angular-ui/ui-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/ui-router/downloads","issues_url":"https://api.github.com/repos/angular-ui/ui-router/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/ui-router/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/ui-router/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/ui-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/ui-router/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/ui-router/releases{/id}","created_at":"2013-01-18T20:26:29Z","updated_at":"2015-10-06T17:35:51Z","pushed_at":"2015-10-06T22:42:10Z","git_url":"git://github.com/angular-ui/ui-router.git","ssh_url":"git@github.com:angular-ui/ui-router.git","clone_url":"https://github.com/angular-ui/ui-router.git","svn_url":"https://github.com/angular-ui/ui-router","homepage":"http://angular-ui.github.io/ui-router/site","size":13916,"stargazers_count":8540,"watchers_count":8540,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2063,"mirror_url":null,"open_issues_count":217,"forks":2063,"open_issues":217,"watchers":8540,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/ui-router/pulls/2296"},"html":{"href":"https://github.com/angular-ui/ui-router/pull/2296"},"issue":{"href":"https://api.github.com/repos/angular-ui/ui-router/issues/2296"},"comments":{"href":"https://api.github.com/repos/angular-ui/ui-router/issues/2296/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/ui-router/pulls/2296/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/ui-router/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/ui-router/pulls/2296/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/ui-router/statuses/9803883c8cedff0d42ec8329b1dd7484bbc5df55"}}}}