{"action":"created","comment":{"url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/comments/32329443","id":32329443,"diff_hunk":"@@ -135,6 +135,25 @@ class Book < ActiveFedora::Base\n     end\n   end\n   \n+  describe \"#apply_schema\" do\n+    before do\n+      class ExampleSchema < ActiveTriples::Schema\n+        property :title, predicate: RDF::DC.title\n+      end\n+      class ExampleBase < ActiveFedora::Base\n+        apply_schema ExampleSchema\n+      end\n+    end\n+    after do\n+      Object.send(:remove_const, :ExampleSchema)\n+      Object.send(:remove_const, :ExampleBase)\n+    end\n+    let(:obj) { ExampleBase.new }\n+    it \"should configure properties and solrize them\" do\n+      obj.title = [\"Test\"]\n+      expect(obj.to_solr[ActiveFedora::SolrQueryBuilder.solr_name(\"title\", :symbol)]).to eq [\"Test\"]","path":"spec/integration/base_spec.rb","position":20,"original_position":20,"commit_id":"20827f2abfe9d38fdd0edc3a8a1db4d1e7c4d3a2","original_commit_id":"20827f2abfe9d38fdd0edc3a8a1db4d1e7c4d3a2","user":{"login":"jcoyne","id":92044,"avatar_url":"https://avatars.githubusercontent.com/u/92044?v=3","gravatar_id":"","url":"https://api.github.com/users/jcoyne","html_url":"https://github.com/jcoyne","followers_url":"https://api.github.com/users/jcoyne/followers","following_url":"https://api.github.com/users/jcoyne/following{/other_user}","gists_url":"https://api.github.com/users/jcoyne/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoyne/subscriptions","organizations_url":"https://api.github.com/users/jcoyne/orgs","repos_url":"https://api.github.com/users/jcoyne/repos","events_url":"https://api.github.com/users/jcoyne/events{/privacy}","received_events_url":"https://api.github.com/users/jcoyne/received_events","type":"User","site_admin":false},"body":"It looks like it's indexing every property even if no indexing hint has been supplied?  I'm not sure that's desired. ","created_at":"2015-06-12T16:07:30Z","updated_at":"2015-06-12T16:07:30Z","html_url":"https://github.com/projecthydra/active_fedora/pull/807#discussion_r32329443","pull_request_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/807","_links":{"self":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/comments/32329443"},"html":{"href":"https://github.com/projecthydra/active_fedora/pull/807#discussion_r32329443"},"pull_request":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/807"}}},"pull_request":{"url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/807","id":36986698,"html_url":"https://github.com/projecthydra/active_fedora/pull/807","diff_url":"https://github.com/projecthydra/active_fedora/pull/807.diff","patch_url":"https://github.com/projecthydra/active_fedora/pull/807.patch","issue_url":"https://api.github.com/repos/projecthydra/active_fedora/issues/807","number":807,"state":"open","locked":false,"title":"Add apply_schema support to AF.","user":{"login":"terrellt","id":2806645,"avatar_url":"https://avatars.githubusercontent.com/u/2806645?v=3","gravatar_id":"","url":"https://api.github.com/users/terrellt","html_url":"https://github.com/terrellt","followers_url":"https://api.github.com/users/terrellt/followers","following_url":"https://api.github.com/users/terrellt/following{/other_user}","gists_url":"https://api.github.com/users/terrellt/gists{/gist_id}","starred_url":"https://api.github.com/users/terrellt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrellt/subscriptions","organizations_url":"https://api.github.com/users/terrellt/orgs","repos_url":"https://api.github.com/users/terrellt/repos","events_url":"https://api.github.com/users/terrellt/events{/privacy}","received_events_url":"https://api.github.com/users/terrellt/received_events","type":"User","site_admin":false},"body":"Pending merge and release of ActiveTriples with Schema support.\r\n\r\nThis is related to https://github.com/ActiveTriples/ActiveTriples/pull/132 and I'm only doing it before that code is merged because I feel like there's discussion to have around this, especially in regard to the SolrApplicationStrategy.\r\n\r\nI'm proposing that if you apply a schema you probably want it indexed, and by default the system should do that for you.","created_at":"2015-06-04T22:55:41Z","updated_at":"2015-06-12T16:07:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba566601c5d29f678536c7f25c77740b22ca936e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/807/commits","review_comments_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/807/comments","review_comment_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projecthydra/active_fedora/issues/807/comments","statuses_url":"https://api.github.com/repos/projecthydra/active_fedora/statuses/20827f2abfe9d38fdd0edc3a8a1db4d1e7c4d3a2","head":{"label":"terrellt:ATSchemas","ref":"ATSchemas","sha":"20827f2abfe9d38fdd0edc3a8a1db4d1e7c4d3a2","user":{"login":"terrellt","id":2806645,"avatar_url":"https://avatars.githubusercontent.com/u/2806645?v=3","gravatar_id":"","url":"https://api.github.com/users/terrellt","html_url":"https://github.com/terrellt","followers_url":"https://api.github.com/users/terrellt/followers","following_url":"https://api.github.com/users/terrellt/following{/other_user}","gists_url":"https://api.github.com/users/terrellt/gists{/gist_id}","starred_url":"https://api.github.com/users/terrellt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrellt/subscriptions","organizations_url":"https://api.github.com/users/terrellt/orgs","repos_url":"https://api.github.com/users/terrellt/repos","events_url":"https://api.github.com/users/terrellt/events{/privacy}","received_events_url":"https://api.github.com/users/terrellt/received_events","type":"User","site_admin":false},"repo":{"id":33686321,"name":"active_fedora","full_name":"terrellt/active_fedora","owner":{"login":"terrellt","id":2806645,"avatar_url":"https://avatars.githubusercontent.com/u/2806645?v=3","gravatar_id":"","url":"https://api.github.com/users/terrellt","html_url":"https://github.com/terrellt","followers_url":"https://api.github.com/users/terrellt/followers","following_url":"https://api.github.com/users/terrellt/following{/other_user}","gists_url":"https://api.github.com/users/terrellt/gists{/gist_id}","starred_url":"https://api.github.com/users/terrellt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrellt/subscriptions","organizations_url":"https://api.github.com/users/terrellt/orgs","repos_url":"https://api.github.com/users/terrellt/repos","events_url":"https://api.github.com/users/terrellt/events{/privacy}","received_events_url":"https://api.github.com/users/terrellt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/terrellt/active_fedora","description":"A Rails interface to the Fedora repository, akin to Active Model","fork":true,"url":"https://api.github.com/repos/terrellt/active_fedora","forks_url":"https://api.github.com/repos/terrellt/active_fedora/forks","keys_url":"https://api.github.com/repos/terrellt/active_fedora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terrellt/active_fedora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terrellt/active_fedora/teams","hooks_url":"https://api.github.com/repos/terrellt/active_fedora/hooks","issue_events_url":"https://api.github.com/repos/terrellt/active_fedora/issues/events{/number}","events_url":"https://api.github.com/repos/terrellt/active_fedora/events","assignees_url":"https://api.github.com/repos/terrellt/active_fedora/assignees{/user}","branches_url":"https://api.github.com/repos/terrellt/active_fedora/branches{/branch}","tags_url":"https://api.github.com/repos/terrellt/active_fedora/tags","blobs_url":"https://api.github.com/repos/terrellt/active_fedora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terrellt/active_fedora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terrellt/active_fedora/git/refs{/sha}","trees_url":"https://api.github.com/repos/terrellt/active_fedora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terrellt/active_fedora/statuses/{sha}","languages_url":"https://api.github.com/repos/terrellt/active_fedora/languages","stargazers_url":"https://api.github.com/repos/terrellt/active_fedora/stargazers","contributors_url":"https://api.github.com/repos/terrellt/active_fedora/contributors","subscribers_url":"https://api.github.com/repos/terrellt/active_fedora/subscribers","subscription_url":"https://api.github.com/repos/terrellt/active_fedora/subscription","commits_url":"https://api.github.com/repos/terrellt/active_fedora/commits{/sha}","git_commits_url":"https://api.github.com/repos/terrellt/active_fedora/git/commits{/sha}","comments_url":"https://api.github.com/repos/terrellt/active_fedora/comments{/number}","issue_comment_url":"https://api.github.com/repos/terrellt/active_fedora/issues/comments{/number}","contents_url":"https://api.github.com/repos/terrellt/active_fedora/contents/{+path}","compare_url":"https://api.github.com/repos/terrellt/active_fedora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terrellt/active_fedora/merges","archive_url":"https://api.github.com/repos/terrellt/active_fedora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terrellt/active_fedora/downloads","issues_url":"https://api.github.com/repos/terrellt/active_fedora/issues{/number}","pulls_url":"https://api.github.com/repos/terrellt/active_fedora/pulls{/number}","milestones_url":"https://api.github.com/repos/terrellt/active_fedora/milestones{/number}","notifications_url":"https://api.github.com/repos/terrellt/active_fedora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terrellt/active_fedora/labels{/name}","releases_url":"https://api.github.com/repos/terrellt/active_fedora/releases{/id}","created_at":"2015-04-09T18:47:33Z","updated_at":"2015-04-09T18:47:34Z","pushed_at":"2015-06-11T22:50:42Z","git_url":"git://github.com/terrellt/active_fedora.git","ssh_url":"git@github.com:terrellt/active_fedora.git","clone_url":"https://github.com/terrellt/active_fedora.git","svn_url":"https://github.com/terrellt/active_fedora","homepage":"","size":147664,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projecthydra:master","ref":"master","sha":"2143476474c057acaff588d17f17c031dcbf5314","user":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"repo":{"id":3867127,"name":"active_fedora","full_name":"projecthydra/active_fedora","owner":{"login":"projecthydra","id":109426,"avatar_url":"https://avatars.githubusercontent.com/u/109426?v=3","gravatar_id":"","url":"https://api.github.com/users/projecthydra","html_url":"https://github.com/projecthydra","followers_url":"https://api.github.com/users/projecthydra/followers","following_url":"https://api.github.com/users/projecthydra/following{/other_user}","gists_url":"https://api.github.com/users/projecthydra/gists{/gist_id}","starred_url":"https://api.github.com/users/projecthydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecthydra/subscriptions","organizations_url":"https://api.github.com/users/projecthydra/orgs","repos_url":"https://api.github.com/users/projecthydra/repos","events_url":"https://api.github.com/users/projecthydra/events{/privacy}","received_events_url":"https://api.github.com/users/projecthydra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecthydra/active_fedora","description":"A Rails interface to the Fedora repository, akin to Active Model","fork":false,"url":"https://api.github.com/repos/projecthydra/active_fedora","forks_url":"https://api.github.com/repos/projecthydra/active_fedora/forks","keys_url":"https://api.github.com/repos/projecthydra/active_fedora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecthydra/active_fedora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecthydra/active_fedora/teams","hooks_url":"https://api.github.com/repos/projecthydra/active_fedora/hooks","issue_events_url":"https://api.github.com/repos/projecthydra/active_fedora/issues/events{/number}","events_url":"https://api.github.com/repos/projecthydra/active_fedora/events","assignees_url":"https://api.github.com/repos/projecthydra/active_fedora/assignees{/user}","branches_url":"https://api.github.com/repos/projecthydra/active_fedora/branches{/branch}","tags_url":"https://api.github.com/repos/projecthydra/active_fedora/tags","blobs_url":"https://api.github.com/repos/projecthydra/active_fedora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecthydra/active_fedora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecthydra/active_fedora/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecthydra/active_fedora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecthydra/active_fedora/statuses/{sha}","languages_url":"https://api.github.com/repos/projecthydra/active_fedora/languages","stargazers_url":"https://api.github.com/repos/projecthydra/active_fedora/stargazers","contributors_url":"https://api.github.com/repos/projecthydra/active_fedora/contributors","subscribers_url":"https://api.github.com/repos/projecthydra/active_fedora/subscribers","subscription_url":"https://api.github.com/repos/projecthydra/active_fedora/subscription","commits_url":"https://api.github.com/repos/projecthydra/active_fedora/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecthydra/active_fedora/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecthydra/active_fedora/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecthydra/active_fedora/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecthydra/active_fedora/contents/{+path}","compare_url":"https://api.github.com/repos/projecthydra/active_fedora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecthydra/active_fedora/merges","archive_url":"https://api.github.com/repos/projecthydra/active_fedora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecthydra/active_fedora/downloads","issues_url":"https://api.github.com/repos/projecthydra/active_fedora/issues{/number}","pulls_url":"https://api.github.com/repos/projecthydra/active_fedora/pulls{/number}","milestones_url":"https://api.github.com/repos/projecthydra/active_fedora/milestones{/number}","notifications_url":"https://api.github.com/repos/projecthydra/active_fedora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecthydra/active_fedora/labels{/name}","releases_url":"https://api.github.com/repos/projecthydra/active_fedora/releases{/id}","created_at":"2012-03-29T15:01:13Z","updated_at":"2015-05-11T18:16:40Z","pushed_at":"2015-06-11T22:50:42Z","git_url":"git://github.com/projecthydra/active_fedora.git","ssh_url":"git@github.com:projecthydra/active_fedora.git","clone_url":"https://github.com/projecthydra/active_fedora.git","svn_url":"https://github.com/projecthydra/active_fedora","homepage":"","size":14157,"stargazers_count":31,"watchers_count":31,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":59,"forks":47,"open_issues":59,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/807"},"html":{"href":"https://github.com/projecthydra/active_fedora/pull/807"},"issue":{"href":"https://api.github.com/repos/projecthydra/active_fedora/issues/807"},"comments":{"href":"https://api.github.com/repos/projecthydra/active_fedora/issues/807/comments"},"review_comments":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/807/comments"},"review_comment":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projecthydra/active_fedora/pulls/807/commits"},"statuses":{"href":"https://api.github.com/repos/projecthydra/active_fedora/statuses/20827f2abfe9d38fdd0edc3a8a1db4d1e7c4d3a2"}}}}