{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/andes/pulls/comments/41225866","id":41225866,"diff_hunk":"@@ -2040,6 +2040,10 @@ protected C createConsumerImpl(final Destination destination, final int prefetch\n                                                  final int prefetchLow, final boolean noLocal, final boolean exclusive, String selector, final FieldTable rawSelector,\n                                                  final boolean noConsume, final boolean autoClose) throws JMSException\n     {\n+        if (this._consumers.values().size() > 0 ) {\n+            throw new JMSException(\"Only one consumer can be created per session\");","path":"modules/andes-core/client/src/main/java/org/wso2/andes/client/AMQSession.java","position":5,"original_position":5,"commit_id":"c44d7786b499adb21d9a6733f419fd77a41eab6a","original_commit_id":"c44d7786b499adb21d9a6733f419fd77a41eab6a","user":{"login":"akalankapagoda","id":1322058,"avatar_url":"https://avatars.githubusercontent.com/u/1322058?v=3","gravatar_id":"","url":"https://api.github.com/users/akalankapagoda","html_url":"https://github.com/akalankapagoda","followers_url":"https://api.github.com/users/akalankapagoda/followers","following_url":"https://api.github.com/users/akalankapagoda/following{/other_user}","gists_url":"https://api.github.com/users/akalankapagoda/gists{/gist_id}","starred_url":"https://api.github.com/users/akalankapagoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akalankapagoda/subscriptions","organizations_url":"https://api.github.com/users/akalankapagoda/orgs","repos_url":"https://api.github.com/users/akalankapagoda/repos","events_url":"https://api.github.com/users/akalankapagoda/events{/privacy}","received_events_url":"https://api.github.com/users/akalankapagoda/received_events","type":"User","site_admin":false},"body":"We cannot support having multiple consumers in a single session with the current architecture. Will try to update the server code.","created_at":"2015-10-06T04:51:53Z","updated_at":"2015-10-06T04:51:53Z","html_url":"https://github.com/wso2/andes/pull/398#discussion_r41225866","pull_request_url":"https://api.github.com/repos/wso2/andes/pulls/398","_links":{"self":{"href":"https://api.github.com/repos/wso2/andes/pulls/comments/41225866"},"html":{"href":"https://github.com/wso2/andes/pull/398#discussion_r41225866"},"pull_request":{"href":"https://api.github.com/repos/wso2/andes/pulls/398"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/andes/pulls/398","id":46859756,"html_url":"https://github.com/wso2/andes/pull/398","diff_url":"https://github.com/wso2/andes/pull/398.diff","patch_url":"https://github.com/wso2/andes/pull/398.patch","issue_url":"https://api.github.com/repos/wso2/andes/issues/398","number":398,"state":"open","locked":false,"title":"[MB-1419] Use limited max unacked messages only for topic and restrict client session to have only one consumer","user":{"login":"akalankapagoda","id":1322058,"avatar_url":"https://avatars.githubusercontent.com/u/1322058?v=3","gravatar_id":"","url":"https://api.github.com/users/akalankapagoda","html_url":"https://github.com/akalankapagoda","followers_url":"https://api.github.com/users/akalankapagoda/followers","following_url":"https://api.github.com/users/akalankapagoda/following{/other_user}","gists_url":"https://api.github.com/users/akalankapagoda/gists{/gist_id}","starred_url":"https://api.github.com/users/akalankapagoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akalankapagoda/subscriptions","organizations_url":"https://api.github.com/users/akalankapagoda/orgs","repos_url":"https://api.github.com/users/akalankapagoda/repos","events_url":"https://api.github.com/users/akalankapagoda/events{/privacy}","received_events_url":"https://api.github.com/users/akalankapagoda/received_events","type":"User","site_admin":false},"body":"Fixing - https://wso2.org/jira/browse/MB-1419\r\n\r\nUse the LimitedSizeQueueEntryHolder only for topic messages and restrict andes client to allow only one consumer per session.\r\nThis is because although QPID is designed so that there can be many consumers per session, Andes is designed so that session and consumer is a one-to-one mapping.\r\n","created_at":"2015-10-06T03:41:55Z","updated_at":"2015-10-06T04:51:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be22829ed152f6db3407cb2142631378bd3101be","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wso2/andes/pulls/398/commits","review_comments_url":"https://api.github.com/repos/wso2/andes/pulls/398/comments","review_comment_url":"https://api.github.com/repos/wso2/andes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/andes/issues/398/comments","statuses_url":"https://api.github.com/repos/wso2/andes/statuses/c44d7786b499adb21d9a6733f419fd77a41eab6a","head":{"label":"akalankapagoda:maxUnacked","ref":"maxUnacked","sha":"c44d7786b499adb21d9a6733f419fd77a41eab6a","user":{"login":"akalankapagoda","id":1322058,"avatar_url":"https://avatars.githubusercontent.com/u/1322058?v=3","gravatar_id":"","url":"https://api.github.com/users/akalankapagoda","html_url":"https://github.com/akalankapagoda","followers_url":"https://api.github.com/users/akalankapagoda/followers","following_url":"https://api.github.com/users/akalankapagoda/following{/other_user}","gists_url":"https://api.github.com/users/akalankapagoda/gists{/gist_id}","starred_url":"https://api.github.com/users/akalankapagoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akalankapagoda/subscriptions","organizations_url":"https://api.github.com/users/akalankapagoda/orgs","repos_url":"https://api.github.com/users/akalankapagoda/repos","events_url":"https://api.github.com/users/akalankapagoda/events{/privacy}","received_events_url":"https://api.github.com/users/akalankapagoda/received_events","type":"User","site_admin":false},"repo":{"id":22331598,"name":"andes","full_name":"akalankapagoda/andes","owner":{"login":"akalankapagoda","id":1322058,"avatar_url":"https://avatars.githubusercontent.com/u/1322058?v=3","gravatar_id":"","url":"https://api.github.com/users/akalankapagoda","html_url":"https://github.com/akalankapagoda","followers_url":"https://api.github.com/users/akalankapagoda/followers","following_url":"https://api.github.com/users/akalankapagoda/following{/other_user}","gists_url":"https://api.github.com/users/akalankapagoda/gists{/gist_id}","starred_url":"https://api.github.com/users/akalankapagoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akalankapagoda/subscriptions","organizations_url":"https://api.github.com/users/akalankapagoda/orgs","repos_url":"https://api.github.com/users/akalankapagoda/repos","events_url":"https://api.github.com/users/akalankapagoda/events{/privacy}","received_events_url":"https://api.github.com/users/akalankapagoda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akalankapagoda/andes","description":"","fork":true,"url":"https://api.github.com/repos/akalankapagoda/andes","forks_url":"https://api.github.com/repos/akalankapagoda/andes/forks","keys_url":"https://api.github.com/repos/akalankapagoda/andes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akalankapagoda/andes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akalankapagoda/andes/teams","hooks_url":"https://api.github.com/repos/akalankapagoda/andes/hooks","issue_events_url":"https://api.github.com/repos/akalankapagoda/andes/issues/events{/number}","events_url":"https://api.github.com/repos/akalankapagoda/andes/events","assignees_url":"https://api.github.com/repos/akalankapagoda/andes/assignees{/user}","branches_url":"https://api.github.com/repos/akalankapagoda/andes/branches{/branch}","tags_url":"https://api.github.com/repos/akalankapagoda/andes/tags","blobs_url":"https://api.github.com/repos/akalankapagoda/andes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akalankapagoda/andes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akalankapagoda/andes/git/refs{/sha}","trees_url":"https://api.github.com/repos/akalankapagoda/andes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akalankapagoda/andes/statuses/{sha}","languages_url":"https://api.github.com/repos/akalankapagoda/andes/languages","stargazers_url":"https://api.github.com/repos/akalankapagoda/andes/stargazers","contributors_url":"https://api.github.com/repos/akalankapagoda/andes/contributors","subscribers_url":"https://api.github.com/repos/akalankapagoda/andes/subscribers","subscription_url":"https://api.github.com/repos/akalankapagoda/andes/subscription","commits_url":"https://api.github.com/repos/akalankapagoda/andes/commits{/sha}","git_commits_url":"https://api.github.com/repos/akalankapagoda/andes/git/commits{/sha}","comments_url":"https://api.github.com/repos/akalankapagoda/andes/comments{/number}","issue_comment_url":"https://api.github.com/repos/akalankapagoda/andes/issues/comments{/number}","contents_url":"https://api.github.com/repos/akalankapagoda/andes/contents/{+path}","compare_url":"https://api.github.com/repos/akalankapagoda/andes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akalankapagoda/andes/merges","archive_url":"https://api.github.com/repos/akalankapagoda/andes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akalankapagoda/andes/downloads","issues_url":"https://api.github.com/repos/akalankapagoda/andes/issues{/number}","pulls_url":"https://api.github.com/repos/akalankapagoda/andes/pulls{/number}","milestones_url":"https://api.github.com/repos/akalankapagoda/andes/milestones{/number}","notifications_url":"https://api.github.com/repos/akalankapagoda/andes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akalankapagoda/andes/labels{/name}","releases_url":"https://api.github.com/repos/akalankapagoda/andes/releases{/id}","created_at":"2014-07-28T05:11:24Z","updated_at":"2015-09-10T08:37:53Z","pushed_at":"2015-10-06T03:37:09Z","git_url":"git://github.com/akalankapagoda/andes.git","ssh_url":"git@github.com:akalankapagoda/andes.git","clone_url":"https://github.com/akalankapagoda/andes.git","svn_url":"https://github.com/akalankapagoda/andes","homepage":null,"size":66359,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"15d59a35249e10685a5c3fe97d477f13e22162c1","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":20559270,"name":"andes","full_name":"wso2/andes","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/andes","description":"","fork":false,"url":"https://api.github.com/repos/wso2/andes","forks_url":"https://api.github.com/repos/wso2/andes/forks","keys_url":"https://api.github.com/repos/wso2/andes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/andes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/andes/teams","hooks_url":"https://api.github.com/repos/wso2/andes/hooks","issue_events_url":"https://api.github.com/repos/wso2/andes/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/andes/events","assignees_url":"https://api.github.com/repos/wso2/andes/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/andes/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/andes/tags","blobs_url":"https://api.github.com/repos/wso2/andes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/andes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/andes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/andes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/andes/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/andes/languages","stargazers_url":"https://api.github.com/repos/wso2/andes/stargazers","contributors_url":"https://api.github.com/repos/wso2/andes/contributors","subscribers_url":"https://api.github.com/repos/wso2/andes/subscribers","subscription_url":"https://api.github.com/repos/wso2/andes/subscription","commits_url":"https://api.github.com/repos/wso2/andes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/andes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/andes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/andes/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/andes/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/andes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/andes/merges","archive_url":"https://api.github.com/repos/wso2/andes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/andes/downloads","issues_url":"https://api.github.com/repos/wso2/andes/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/andes/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/andes/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/andes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/andes/labels{/name}","releases_url":"https://api.github.com/repos/wso2/andes/releases{/id}","created_at":"2014-06-06T10:04:24Z","updated_at":"2015-05-05T14:31:31Z","pushed_at":"2015-10-06T03:41:55Z","git_url":"git://github.com/wso2/andes.git","ssh_url":"git@github.com:wso2/andes.git","clone_url":"https://github.com/wso2/andes.git","svn_url":"https://github.com/wso2/andes","homepage":null,"size":69815,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":8,"forks":38,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/andes/pulls/398"},"html":{"href":"https://github.com/wso2/andes/pull/398"},"issue":{"href":"https://api.github.com/repos/wso2/andes/issues/398"},"comments":{"href":"https://api.github.com/repos/wso2/andes/issues/398/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/andes/pulls/398/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/andes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/andes/pulls/398/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/andes/statuses/c44d7786b499adb21d9a6733f419fd77a41eab6a"}}}}