{"action":"created","issue":{"url":"https://api.github.com/repos/freeorion/freeorion/issues/53","labels_url":"https://api.github.com/repos/freeorion/freeorion/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/freeorion/freeorion/issues/53/comments","events_url":"https://api.github.com/repos/freeorion/freeorion/issues/53/events","html_url":"https://github.com/freeorion/freeorion/pull/53","id":72726935,"number":53,"title":"Basic diplomacy","user":{"login":"Dilvish-fo","id":10995939,"avatar_url":"https://avatars.githubusercontent.com/u/10995939?v=3","gravatar_id":"","url":"https://api.github.com/users/Dilvish-fo","html_url":"https://github.com/Dilvish-fo","followers_url":"https://api.github.com/users/Dilvish-fo/followers","following_url":"https://api.github.com/users/Dilvish-fo/following{/other_user}","gists_url":"https://api.github.com/users/Dilvish-fo/gists{/gist_id}","starred_url":"https://api.github.com/users/Dilvish-fo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dilvish-fo/subscriptions","organizations_url":"https://api.github.com/users/Dilvish-fo/orgs","repos_url":"https://api.github.com/users/Dilvish-fo/repos","events_url":"https://api.github.com/users/Dilvish-fo/events{/privacy}","received_events_url":"https://api.github.com/users/Dilvish-fo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/freeorion/freeorion/labels/feature","name":"feature","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-05-03T01:14:53Z","updated_at":"2015-05-07T07:51:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/53","html_url":"https://github.com/freeorion/freeorion/pull/53","diff_url":"https://github.com/freeorion/freeorion/pull/53.diff","patch_url":"https://github.com/freeorion/freeorion/pull/53.patch"},"body":"This moves AI diplomacy into a dedicated module and slightly advances the actual diplomatic dealings.  The AI will now keep a log of peace requests and war declarations.  It now has an 'attitude' regarding the respective other empires, largely shaped by its aggression level but also affected by the diplomatic history between the empires.   Its response to a peace request will be controlled by this attitude.  The AI will also now have a more varied set of responses to peace requests, drawn from the stringtables.\r\n\r\nThere is obviously much more that can and will be done going forward.  I've tested this moderately & it seems to work fine, but I thought I'd post it for review & feedback before committing.  (Plus, it involves a change in the executables and so I thought I'd wait until closer to Vezzra's weekly build to commit.)"},"comment":{"url":"https://api.github.com/repos/freeorion/freeorion/issues/comments/99758871","html_url":"https://github.com/freeorion/freeorion/pull/53#issuecomment-99758871","issue_url":"https://api.github.com/repos/freeorion/freeorion/issues/53","id":99758871,"user":{"login":"Morlic-fo","id":11706951,"avatar_url":"https://avatars.githubusercontent.com/u/11706951?v=3","gravatar_id":"","url":"https://api.github.com/users/Morlic-fo","html_url":"https://github.com/Morlic-fo","followers_url":"https://api.github.com/users/Morlic-fo/followers","following_url":"https://api.github.com/users/Morlic-fo/following{/other_user}","gists_url":"https://api.github.com/users/Morlic-fo/gists{/gist_id}","starred_url":"https://api.github.com/users/Morlic-fo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morlic-fo/subscriptions","organizations_url":"https://api.github.com/users/Morlic-fo/orgs","repos_url":"https://api.github.com/users/Morlic-fo/repos","events_url":"https://api.github.com/users/Morlic-fo/events{/privacy}","received_events_url":"https://api.github.com/users/Morlic-fo/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T07:51:15Z","updated_at":"2015-05-07T07:51:15Z","body":"I agree with the approach of using subclasses for different personality types (here: aggression levels).\r\n\r\nDiplomacy definitely should be an area where personality of the AI matters a lot so I expect the subclasses to be used relatively often to tweak some factors or behaviour. Having all what personality changes in a subclass definitely makes things easier to grasp compared to checking some dozen if-statements scattered around multiple hundred lines of codes."}}