{"action":"created","comment":{"url":"https://api.github.com/repos/atom/vim-mode/pulls/comments/26828015","id":26828015,"diff_hunk":"@@ -149,10 +149,16 @@ class MoveLeft extends Motion\n class MoveRight extends Motion\n   operatesInclusively: false\n \n-  moveCursor: (cursor, count=1) ->\n+  # MoveRight can be combined with Delete, which will indicate it by the presence of options.deleting\n+  moveCursor: (cursor, count=1, options={}) ->\n     _.times count, =>\n-      cursor.moveRight() unless cursor.isAtEndOfLine()\n-      cursor.moveRight() if settings.wrapLeftRightMotion() and cursor.isAtEndOfLine()\n+      goingToNextLine = atom.config.get('vim-mode.wrapLeftRightMotion')\n+\n+      if not cursor.isAtEndOfLine() # the line is not empty\n+        cursor.moveRight()\n+        goingToNextLine = false if options.deleting # when deleting, wrapLeftRightMotion only works on an empty line","path":"lib/motions/general-motions.coffee","position":14,"original_position":14,"commit_id":"10f22a199080169ee4bb33112c6999474c52b8c0","original_commit_id":"10f22a199080169ee4bb33112c6999474c52b8c0","user":{"login":"jacekkopecky","id":807315,"avatar_url":"https://avatars.githubusercontent.com/u/807315?v=3","gravatar_id":"","url":"https://api.github.com/users/jacekkopecky","html_url":"https://github.com/jacekkopecky","followers_url":"https://api.github.com/users/jacekkopecky/followers","following_url":"https://api.github.com/users/jacekkopecky/following{/other_user}","gists_url":"https://api.github.com/users/jacekkopecky/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekkopecky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekkopecky/subscriptions","organizations_url":"https://api.github.com/users/jacekkopecky/orgs","repos_url":"https://api.github.com/users/jacekkopecky/repos","events_url":"https://api.github.com/users/jacekkopecky/events{/privacy}","received_events_url":"https://api.github.com/users/jacekkopecky/received_events","type":"User","site_admin":false},"body":"Oh right, I'll check that - it would be cleaner indeed. I just need to ask for patience please, my dayjob is extra busy right now so I can't give vim-mode as much time as I'd like... Thank you.","created_at":"2015-03-20T09:47:45Z","updated_at":"2015-03-20T09:47:45Z","html_url":"https://github.com/atom/vim-mode/pull/555#discussion_r26828015","pull_request_url":"https://api.github.com/repos/atom/vim-mode/pulls/555","_links":{"self":{"href":"https://api.github.com/repos/atom/vim-mode/pulls/comments/26828015"},"html":{"href":"https://github.com/atom/vim-mode/pull/555#discussion_r26828015"},"pull_request":{"href":"https://api.github.com/repos/atom/vim-mode/pulls/555"}}},"pull_request":{"url":"https://api.github.com/repos/atom/vim-mode/pulls/555","id":30728076,"html_url":"https://github.com/atom/vim-mode/pull/555","diff_url":"https://github.com/atom/vim-mode/pull/555.diff","patch_url":"https://github.com/atom/vim-mode/pull/555.patch","issue_url":"https://api.github.com/repos/atom/vim-mode/issues/555","number":555,"state":"open","locked":false,"title":"fix wrapping behavior of x","user":{"login":"jacekkopecky","id":807315,"avatar_url":"https://avatars.githubusercontent.com/u/807315?v=3","gravatar_id":"","url":"https://api.github.com/users/jacekkopecky","html_url":"https://github.com/jacekkopecky","followers_url":"https://api.github.com/users/jacekkopecky/followers","following_url":"https://api.github.com/users/jacekkopecky/following{/other_user}","gists_url":"https://api.github.com/users/jacekkopecky/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekkopecky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekkopecky/subscriptions","organizations_url":"https://api.github.com/users/jacekkopecky/orgs","repos_url":"https://api.github.com/users/jacekkopecky/repos","events_url":"https://api.github.com/users/jacekkopecky/events{/privacy}","received_events_url":"https://api.github.com/users/jacekkopecky/received_events","type":"User","site_admin":false},"body":"`x` should only wrap to next line with `vim-mode.wrapLeftRightMotion = true`, and only with a count or on an empty line.\r\nThe PR also adds a bit to the tests for X.","created_at":"2015-03-08T22:30:45Z","updated_at":"2015-03-20T09:47:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4bf687bd743cefa81fd52f2018bc3807d205d84","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/vim-mode/pulls/555/commits","review_comments_url":"https://api.github.com/repos/atom/vim-mode/pulls/555/comments","review_comment_url":"https://api.github.com/repos/atom/vim-mode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/vim-mode/issues/555/comments","statuses_url":"https://api.github.com/repos/atom/vim-mode/statuses/10f22a199080169ee4bb33112c6999474c52b8c0","head":{"label":"jacekkopecky:fix-wrapping-of-x","ref":"fix-wrapping-of-x","sha":"10f22a199080169ee4bb33112c6999474c52b8c0","user":{"login":"jacekkopecky","id":807315,"avatar_url":"https://avatars.githubusercontent.com/u/807315?v=3","gravatar_id":"","url":"https://api.github.com/users/jacekkopecky","html_url":"https://github.com/jacekkopecky","followers_url":"https://api.github.com/users/jacekkopecky/followers","following_url":"https://api.github.com/users/jacekkopecky/following{/other_user}","gists_url":"https://api.github.com/users/jacekkopecky/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekkopecky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekkopecky/subscriptions","organizations_url":"https://api.github.com/users/jacekkopecky/orgs","repos_url":"https://api.github.com/users/jacekkopecky/repos","events_url":"https://api.github.com/users/jacekkopecky/events{/privacy}","received_events_url":"https://api.github.com/users/jacekkopecky/received_events","type":"User","site_admin":false},"repo":{"id":30833935,"name":"vim-mode","full_name":"jacekkopecky/vim-mode","owner":{"login":"jacekkopecky","id":807315,"avatar_url":"https://avatars.githubusercontent.com/u/807315?v=3","gravatar_id":"","url":"https://api.github.com/users/jacekkopecky","html_url":"https://github.com/jacekkopecky","followers_url":"https://api.github.com/users/jacekkopecky/followers","following_url":"https://api.github.com/users/jacekkopecky/following{/other_user}","gists_url":"https://api.github.com/users/jacekkopecky/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekkopecky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekkopecky/subscriptions","organizations_url":"https://api.github.com/users/jacekkopecky/orgs","repos_url":"https://api.github.com/users/jacekkopecky/repos","events_url":"https://api.github.com/users/jacekkopecky/events{/privacy}","received_events_url":"https://api.github.com/users/jacekkopecky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jacekkopecky/vim-mode","description":"Next generation vim support for atom","fork":true,"url":"https://api.github.com/repos/jacekkopecky/vim-mode","forks_url":"https://api.github.com/repos/jacekkopecky/vim-mode/forks","keys_url":"https://api.github.com/repos/jacekkopecky/vim-mode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacekkopecky/vim-mode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacekkopecky/vim-mode/teams","hooks_url":"https://api.github.com/repos/jacekkopecky/vim-mode/hooks","issue_events_url":"https://api.github.com/repos/jacekkopecky/vim-mode/issues/events{/number}","events_url":"https://api.github.com/repos/jacekkopecky/vim-mode/events","assignees_url":"https://api.github.com/repos/jacekkopecky/vim-mode/assignees{/user}","branches_url":"https://api.github.com/repos/jacekkopecky/vim-mode/branches{/branch}","tags_url":"https://api.github.com/repos/jacekkopecky/vim-mode/tags","blobs_url":"https://api.github.com/repos/jacekkopecky/vim-mode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacekkopecky/vim-mode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacekkopecky/vim-mode/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacekkopecky/vim-mode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacekkopecky/vim-mode/statuses/{sha}","languages_url":"https://api.github.com/repos/jacekkopecky/vim-mode/languages","stargazers_url":"https://api.github.com/repos/jacekkopecky/vim-mode/stargazers","contributors_url":"https://api.github.com/repos/jacekkopecky/vim-mode/contributors","subscribers_url":"https://api.github.com/repos/jacekkopecky/vim-mode/subscribers","subscription_url":"https://api.github.com/repos/jacekkopecky/vim-mode/subscription","commits_url":"https://api.github.com/repos/jacekkopecky/vim-mode/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacekkopecky/vim-mode/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacekkopecky/vim-mode/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacekkopecky/vim-mode/issues/comments{/number}","contents_url":"https://api.github.com/repos/jacekkopecky/vim-mode/contents/{+path}","compare_url":"https://api.github.com/repos/jacekkopecky/vim-mode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacekkopecky/vim-mode/merges","archive_url":"https://api.github.com/repos/jacekkopecky/vim-mode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacekkopecky/vim-mode/downloads","issues_url":"https://api.github.com/repos/jacekkopecky/vim-mode/issues{/number}","pulls_url":"https://api.github.com/repos/jacekkopecky/vim-mode/pulls{/number}","milestones_url":"https://api.github.com/repos/jacekkopecky/vim-mode/milestones{/number}","notifications_url":"https://api.github.com/repos/jacekkopecky/vim-mode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacekkopecky/vim-mode/labels{/name}","releases_url":"https://api.github.com/repos/jacekkopecky/vim-mode/releases{/id}","created_at":"2015-02-15T16:53:14Z","updated_at":"2015-03-13T15:38:11Z","pushed_at":"2015-03-15T16:24:00Z","git_url":"git://github.com/jacekkopecky/vim-mode.git","ssh_url":"git@github.com:jacekkopecky/vim-mode.git","clone_url":"https://github.com/jacekkopecky/vim-mode.git","svn_url":"https://github.com/jacekkopecky/vim-mode","homepage":null,"size":1424,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"991a16c1066aac99b060d7af7762cc9613377c3f","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":11827104,"name":"vim-mode","full_name":"atom/vim-mode","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/vim-mode","description":"Next generation vim support for atom","fork":false,"url":"https://api.github.com/repos/atom/vim-mode","forks_url":"https://api.github.com/repos/atom/vim-mode/forks","keys_url":"https://api.github.com/repos/atom/vim-mode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/vim-mode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/vim-mode/teams","hooks_url":"https://api.github.com/repos/atom/vim-mode/hooks","issue_events_url":"https://api.github.com/repos/atom/vim-mode/issues/events{/number}","events_url":"https://api.github.com/repos/atom/vim-mode/events","assignees_url":"https://api.github.com/repos/atom/vim-mode/assignees{/user}","branches_url":"https://api.github.com/repos/atom/vim-mode/branches{/branch}","tags_url":"https://api.github.com/repos/atom/vim-mode/tags","blobs_url":"https://api.github.com/repos/atom/vim-mode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/vim-mode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/vim-mode/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/vim-mode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/vim-mode/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/vim-mode/languages","stargazers_url":"https://api.github.com/repos/atom/vim-mode/stargazers","contributors_url":"https://api.github.com/repos/atom/vim-mode/contributors","subscribers_url":"https://api.github.com/repos/atom/vim-mode/subscribers","subscription_url":"https://api.github.com/repos/atom/vim-mode/subscription","commits_url":"https://api.github.com/repos/atom/vim-mode/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/vim-mode/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/vim-mode/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/vim-mode/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/vim-mode/contents/{+path}","compare_url":"https://api.github.com/repos/atom/vim-mode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/vim-mode/merges","archive_url":"https://api.github.com/repos/atom/vim-mode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/vim-mode/downloads","issues_url":"https://api.github.com/repos/atom/vim-mode/issues{/number}","pulls_url":"https://api.github.com/repos/atom/vim-mode/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/vim-mode/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/vim-mode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/vim-mode/labels{/name}","releases_url":"https://api.github.com/repos/atom/vim-mode/releases{/id}","created_at":"2013-08-01T20:37:14Z","updated_at":"2015-03-20T02:40:05Z","pushed_at":"2015-03-19T16:25:59Z","git_url":"git://github.com/atom/vim-mode.git","ssh_url":"git@github.com:atom/vim-mode.git","clone_url":"https://github.com/atom/vim-mode.git","svn_url":"https://github.com/atom/vim-mode","homepage":null,"size":4455,"stargazers_count":855,"watchers_count":855,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"open_issues_count":131,"forks":187,"open_issues":131,"watchers":855,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/vim-mode/pulls/555"},"html":{"href":"https://github.com/atom/vim-mode/pull/555"},"issue":{"href":"https://api.github.com/repos/atom/vim-mode/issues/555"},"comments":{"href":"https://api.github.com/repos/atom/vim-mode/issues/555/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/vim-mode/pulls/555/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/vim-mode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/vim-mode/pulls/555/commits"},"statuses":{"href":"https://api.github.com/repos/atom/vim-mode/statuses/10f22a199080169ee4bb33112c6999474c52b8c0"}}}}