{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/48336446","id":48336446,"diff_hunk":"@@ -12013,7 +12013,7 @@ bool game::ramp_move( const tripoint &dest_loc )\n \n     // We're moving from a ramp onto an obstacle\n     if( !m.has_flag( TFLAG_RAMP, u.pos() ) ||\n-        m.move_cost_ter_furn( dest_loc ) > 0 ) {\n+        m.impassable( dest_loc ) ) {","path":"src/game.cpp","position":null,"original_position":95,"commit_id":"b44f7c8117bddbf5b479c57c174e76a1e180c5a3","original_commit_id":"bfa2b7896735bdbf89a853bcee9f877be42adb8d","user":{"login":"BevapDin","id":5095435,"avatar_url":"https://avatars.githubusercontent.com/u/5095435?v=3","gravatar_id":"","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"body":"> The logic here is inverted. Could be caused by my comment, which also has inverted logic(that is, the  if  checks the opposite of what comment describes).\r\n\r\nI fixed the logic and remove the comment.","created_at":"2015-12-23T10:51:07Z","updated_at":"2015-12-23T10:51:07Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14541#discussion_r48336446","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14541","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/48336446"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14541#discussion_r48336446"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14541"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14541","id":54227448,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14541","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14541.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14541.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14541","number":14541,"state":"open","locked":false,"title":"Replace the comparison of `map::move_cost` and magic value 0 with function","user":{"login":"BevapDin","id":5095435,"avatar_url":"https://avatars.githubusercontent.com/u/5095435?v=3","gravatar_id":"","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"body":"A move cost of 0 means the tile is impassable, but this is not obvious to the reader and actually an implementation detail. This PR adds two functions `map::passable` and `map::impassable`, each with two versions (2D and 3D). They are used instead of the comparison.\r\n\r\nThis should make the code more readable. The previously used checks were somehow inconsistent, some used `> 0` and `<= 0`, some used `== 0` and `!= 0`.\r\n","created_at":"2015-12-21T07:25:03Z","updated_at":"2015-12-23T10:51:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"940d32ccc532ebe60e3ce26d682d5b9dd7424042","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14541/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14541/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14541/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/b44f7c8117bddbf5b479c57c174e76a1e180c5a3","head":{"label":"BevapDin:iju","ref":"iju","sha":"b44f7c8117bddbf5b479c57c174e76a1e180c5a3","user":{"login":"BevapDin","id":5095435,"avatar_url":"https://avatars.githubusercontent.com/u/5095435?v=3","gravatar_id":"","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"repo":{"id":11775770,"name":"Cataclysm-DDA","full_name":"BevapDin/Cataclysm-DDA","owner":{"login":"BevapDin","id":5095435,"avatar_url":"https://avatars.githubusercontent.com/u/5095435?v=3","gravatar_id":"","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BevapDin/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA","forks_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/BevapDin/Cataclysm-DDA/releases{/id}","created_at":"2013-07-30T21:12:59Z","updated_at":"2015-04-22T16:20:34Z","pushed_at":"2015-12-23T08:18:52Z","git_url":"git://github.com/BevapDin/Cataclysm-DDA.git","ssh_url":"git@github.com:BevapDin/Cataclysm-DDA.git","clone_url":"https://github.com/BevapDin/Cataclysm-DDA.git","svn_url":"https://github.com/BevapDin/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":630667,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"8401eeb89c661d0a33842bcca4a27753b35dc0b6","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2015-12-22T12:08:21Z","pushed_at":"2015-12-23T09:39:38Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":872617,"stargazers_count":832,"watchers_count":832,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":830,"mirror_url":null,"open_issues_count":1210,"forks":830,"open_issues":1210,"watchers":832,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14541"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14541"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14541"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14541/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14541/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14541/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/b44f7c8117bddbf5b479c57c174e76a1e180c5a3"}}}}