{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/7938","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/7938/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/7938/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/7938/events","html_url":"https://github.com/xbmc/xbmc/pull/7938","id":104107400,"number":7938,"title":"[MusicLibrary] Include \"Various artists\" album artist in the artists list","user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":32,"created_at":"2015-08-31T18:31:00Z","updated_at":"2015-09-10T18:31:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/7938","html_url":"https://github.com/xbmc/xbmc/pull/7938","diff_url":"https://github.com/xbmc/xbmc/pull/7938.diff","patch_url":"https://github.com/xbmc/xbmc/pull/7938.patch"},"body":"(Resubmitted #7928 after messing up the Git and commiting additional WIP by mistake).\r\nBefore Gotham the \"Various artists\" entry would appear in the artists list (when \"include artists who appear only on compilations\" is disabled). On the forum users have requested this is reinstated. See http://forum.kodi.tv/showthread.php?tid=223454 and http://forum.kodi.tv/showthread.php?tid=200797\r\n\r\nIt also seems inconsistent to exclude it as an album artist in this one view, since it does appear when listing the artists for a specific genre.\r\n\r\nIn testing I discovered that this change reveals some previously hidden (lost?) artists. That possibly elevates it to being a bug fix!!  MusicBrainz/Picard sometimes sets the compliation flag but also provides album artists, unless these artists appear on some other album then they are currently excluded from the artists list. That is not good behaviour.\r\n\r\nWhen albumArtistsOnly is false then it is valid to exclude the fake (album) artist \"Various artists\" from the artists list because you are listing the song artists individually.\r\n\r\nLooked back in the Git I have not be able to find a good reason to exclude it - in fact it simplifies the query. Anyone see a problem? A nice simple change, a good place to start my first PR.\r\n\r\n@evilhamster, @Razzeee nothing new here. @Montellese any comments?\r\n"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/139336779","html_url":"https://github.com/xbmc/xbmc/pull/7938#issuecomment-139336779","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/7938","id":139336779,"user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"created_at":"2015-09-10T18:31:18Z","updated_at":"2015-09-10T18:31:18Z","body":"@Razzeee \r\n[quote]exactly, but this setting also hides artists that are featured on a cd. Where the albumartist is != to the songartist.[/quote]\r\nThat's not quite right, or I may have misunderstood you.\r\nIncluding the compilation flag in the query prevents \"Various Artists\" item from appearing in the list of album artists, something users would like to see, so this PR changes that query. \r\n\r\nHowever Musicbrainz uses the \"compilation\" release group secondary type to include both various artist compilations and single artist anthologies, and through Picard you end up with (anthology) abums with a named album artist and compilation flag set. Without this PR these artists will be inadvertently hidden from the list of album artists unless you have other albums by them.\r\n\r\nHope that makes the impact clearer for people."}}