{"action":"opened","number":10,"pull_request":{"url":"https://api.github.com/repos/php-cache/doctrine-adapter/pulls/10","id":54750803,"html_url":"https://github.com/php-cache/doctrine-adapter/pull/10","diff_url":"https://github.com/php-cache/doctrine-adapter/pull/10.diff","patch_url":"https://github.com/php-cache/doctrine-adapter/pull/10.patch","issue_url":"https://api.github.com/repos/php-cache/doctrine-adapter/issues/10","number":10,"state":"open","locked":false,"title":"Make sure we return false when committing.","user":{"login":"Nyholm","id":1275206,"avatar_url":"https://avatars.githubusercontent.com/u/1275206?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyholm","html_url":"https://github.com/Nyholm","followers_url":"https://api.github.com/users/Nyholm/followers","following_url":"https://api.github.com/users/Nyholm/following{/other_user}","gists_url":"https://api.github.com/users/Nyholm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyholm/subscriptions","organizations_url":"https://api.github.com/users/Nyholm/orgs","repos_url":"https://api.github.com/users/Nyholm/repos","events_url":"https://api.github.com/users/Nyholm/events{/privacy}","received_events_url":"https://api.github.com/users/Nyholm/received_events","type":"User","site_admin":false},"body":"This adds a tests to make sure we do not implement commit like this: \r\n\r\n```php\r\n\r\npublic function commit()\r\n    {\r\n        $saved = true;\r\n        foreach ($this->deferred as $item) {\r\n            $saved = !$this->save($item));\r\n        }\r\n        $this->deferred = [];\r\n\r\n        return $saved;\r\n    }\r\n\r\n```","created_at":"2015-12-29T19:19:43Z","updated_at":"2015-12-29T19:19:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e96208b3b4834ff6c42ca5259a0ff0618707f6a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/php-cache/doctrine-adapter/pulls/10/commits","review_comments_url":"https://api.github.com/repos/php-cache/doctrine-adapter/pulls/10/comments","review_comment_url":"https://api.github.com/repos/php-cache/doctrine-adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php-cache/doctrine-adapter/issues/10/comments","statuses_url":"https://api.github.com/repos/php-cache/doctrine-adapter/statuses/87cc6025ed742297ee63c3daf6884637d0180ad6","head":{"label":"Nyholm:patch-1","ref":"patch-1","sha":"87cc6025ed742297ee63c3daf6884637d0180ad6","user":{"login":"Nyholm","id":1275206,"avatar_url":"https://avatars.githubusercontent.com/u/1275206?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyholm","html_url":"https://github.com/Nyholm","followers_url":"https://api.github.com/users/Nyholm/followers","following_url":"https://api.github.com/users/Nyholm/following{/other_user}","gists_url":"https://api.github.com/users/Nyholm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyholm/subscriptions","organizations_url":"https://api.github.com/users/Nyholm/orgs","repos_url":"https://api.github.com/users/Nyholm/repos","events_url":"https://api.github.com/users/Nyholm/events{/privacy}","received_events_url":"https://api.github.com/users/Nyholm/received_events","type":"User","site_admin":false},"repo":{"id":47518885,"name":"doctrine-adapter","full_name":"Nyholm/doctrine-adapter","owner":{"login":"Nyholm","id":1275206,"avatar_url":"https://avatars.githubusercontent.com/u/1275206?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyholm","html_url":"https://github.com/Nyholm","followers_url":"https://api.github.com/users/Nyholm/followers","following_url":"https://api.github.com/users/Nyholm/following{/other_user}","gists_url":"https://api.github.com/users/Nyholm/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyholm/subscriptions","organizations_url":"https://api.github.com/users/Nyholm/orgs","repos_url":"https://api.github.com/users/Nyholm/repos","events_url":"https://api.github.com/users/Nyholm/events{/privacy}","received_events_url":"https://api.github.com/users/Nyholm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nyholm/doctrine-adapter","description":"PSR-6 Cache Implementation using Doctrine\\Common\\Cache","fork":true,"url":"https://api.github.com/repos/Nyholm/doctrine-adapter","forks_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/forks","keys_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/teams","hooks_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/hooks","issue_events_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/events","assignees_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/tags","blobs_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/languages","stargazers_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/stargazers","contributors_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/contributors","subscribers_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/subscribers","subscription_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/subscription","commits_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/merges","archive_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/downloads","issues_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/labels{/name}","releases_url":"https://api.github.com/repos/Nyholm/doctrine-adapter/releases{/id}","created_at":"2015-12-06T23:49:01Z","updated_at":"2015-12-06T23:49:03Z","pushed_at":"2015-12-29T19:18:45Z","git_url":"git://github.com/Nyholm/doctrine-adapter.git","ssh_url":"git@github.com:Nyholm/doctrine-adapter.git","clone_url":"https://github.com/Nyholm/doctrine-adapter.git","svn_url":"https://github.com/Nyholm/doctrine-adapter","homepage":"","size":38,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php-cache:master","ref":"master","sha":"a3d5f53c30da4f05566c2cf6d1eb132ebc8946b7","user":{"login":"php-cache","id":16170857,"avatar_url":"https://avatars.githubusercontent.com/u/16170857?v=3","gravatar_id":"","url":"https://api.github.com/users/php-cache","html_url":"https://github.com/php-cache","followers_url":"https://api.github.com/users/php-cache/followers","following_url":"https://api.github.com/users/php-cache/following{/other_user}","gists_url":"https://api.github.com/users/php-cache/gists{/gist_id}","starred_url":"https://api.github.com/users/php-cache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-cache/subscriptions","organizations_url":"https://api.github.com/users/php-cache/orgs","repos_url":"https://api.github.com/users/php-cache/repos","events_url":"https://api.github.com/users/php-cache/events{/privacy}","received_events_url":"https://api.github.com/users/php-cache/received_events","type":"Organization","site_admin":false},"repo":{"id":47476127,"name":"doctrine-adapter","full_name":"php-cache/doctrine-adapter","owner":{"login":"php-cache","id":16170857,"avatar_url":"https://avatars.githubusercontent.com/u/16170857?v=3","gravatar_id":"","url":"https://api.github.com/users/php-cache","html_url":"https://github.com/php-cache","followers_url":"https://api.github.com/users/php-cache/followers","following_url":"https://api.github.com/users/php-cache/following{/other_user}","gists_url":"https://api.github.com/users/php-cache/gists{/gist_id}","starred_url":"https://api.github.com/users/php-cache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-cache/subscriptions","organizations_url":"https://api.github.com/users/php-cache/orgs","repos_url":"https://api.github.com/users/php-cache/repos","events_url":"https://api.github.com/users/php-cache/events{/privacy}","received_events_url":"https://api.github.com/users/php-cache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php-cache/doctrine-adapter","description":"PSR-6 Cache Implementation using Doctrine\\Common\\Cache","fork":false,"url":"https://api.github.com/repos/php-cache/doctrine-adapter","forks_url":"https://api.github.com/repos/php-cache/doctrine-adapter/forks","keys_url":"https://api.github.com/repos/php-cache/doctrine-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-cache/doctrine-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-cache/doctrine-adapter/teams","hooks_url":"https://api.github.com/repos/php-cache/doctrine-adapter/hooks","issue_events_url":"https://api.github.com/repos/php-cache/doctrine-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/php-cache/doctrine-adapter/events","assignees_url":"https://api.github.com/repos/php-cache/doctrine-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/php-cache/doctrine-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/php-cache/doctrine-adapter/tags","blobs_url":"https://api.github.com/repos/php-cache/doctrine-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-cache/doctrine-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-cache/doctrine-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-cache/doctrine-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-cache/doctrine-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/php-cache/doctrine-adapter/languages","stargazers_url":"https://api.github.com/repos/php-cache/doctrine-adapter/stargazers","contributors_url":"https://api.github.com/repos/php-cache/doctrine-adapter/contributors","subscribers_url":"https://api.github.com/repos/php-cache/doctrine-adapter/subscribers","subscription_url":"https://api.github.com/repos/php-cache/doctrine-adapter/subscription","commits_url":"https://api.github.com/repos/php-cache/doctrine-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-cache/doctrine-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-cache/doctrine-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-cache/doctrine-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-cache/doctrine-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/php-cache/doctrine-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-cache/doctrine-adapter/merges","archive_url":"https://api.github.com/repos/php-cache/doctrine-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-cache/doctrine-adapter/downloads","issues_url":"https://api.github.com/repos/php-cache/doctrine-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/php-cache/doctrine-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/php-cache/doctrine-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/php-cache/doctrine-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-cache/doctrine-adapter/labels{/name}","releases_url":"https://api.github.com/repos/php-cache/doctrine-adapter/releases{/id}","created_at":"2015-12-05T23:06:12Z","updated_at":"2015-12-06T08:56:38Z","pushed_at":"2015-12-29T19:19:44Z","git_url":"git://github.com/php-cache/doctrine-adapter.git","ssh_url":"git@github.com:php-cache/doctrine-adapter.git","clone_url":"https://github.com/php-cache/doctrine-adapter.git","svn_url":"https://github.com/php-cache/doctrine-adapter","homepage":"","size":38,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php-cache/doctrine-adapter/pulls/10"},"html":{"href":"https://github.com/php-cache/doctrine-adapter/pull/10"},"issue":{"href":"https://api.github.com/repos/php-cache/doctrine-adapter/issues/10"},"comments":{"href":"https://api.github.com/repos/php-cache/doctrine-adapter/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/php-cache/doctrine-adapter/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/php-cache/doctrine-adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php-cache/doctrine-adapter/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/php-cache/doctrine-adapter/statuses/87cc6025ed742297ee63c3daf6884637d0180ad6"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":30,"deletions":1,"changed_files":1}}