{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/docker-plugin/issues/163","labels_url":"https://api.github.com/repos/jenkinsci/docker-plugin/issues/163/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/docker-plugin/issues/163/comments","events_url":"https://api.github.com/repos/jenkinsci/docker-plugin/issues/163/events","html_url":"https://github.com/jenkinsci/docker-plugin/issues/163","id":58720478,"number":163,"title":"Fix Shading / Tests","user":{"login":"magnayn","id":53653,"avatar_url":"https://avatars.githubusercontent.com/u/53653?v=3","gravatar_id":"","url":"https://api.github.com/users/magnayn","html_url":"https://github.com/magnayn","followers_url":"https://api.github.com/users/magnayn/followers","following_url":"https://api.github.com/users/magnayn/following{/other_user}","gists_url":"https://api.github.com/users/magnayn/gists{/gist_id}","starred_url":"https://api.github.com/users/magnayn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnayn/subscriptions","organizations_url":"https://api.github.com/users/magnayn/orgs","repos_url":"https://api.github.com/users/magnayn/repos","events_url":"https://api.github.com/users/magnayn/events{/privacy}","received_events_url":"https://api.github.com/users/magnayn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jenkinsci/docker-plugin/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/jenkinsci/docker-plugin/milestones/1","html_url":"https://github.com/jenkinsci/docker-plugin/milestones/0.9","labels_url":"https://api.github.com/repos/jenkinsci/docker-plugin/milestones/1/labels","id":943580,"number":1,"title":"0.9","description":null,"creator":{"login":"magnayn","id":53653,"avatar_url":"https://avatars.githubusercontent.com/u/53653?v=3","gravatar_id":"","url":"https://api.github.com/users/magnayn","html_url":"https://github.com/magnayn","followers_url":"https://api.github.com/users/magnayn/followers","following_url":"https://api.github.com/users/magnayn/following{/other_user}","gists_url":"https://api.github.com/users/magnayn/gists{/gist_id}","starred_url":"https://api.github.com/users/magnayn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnayn/subscriptions","organizations_url":"https://api.github.com/users/magnayn/orgs","repos_url":"https://api.github.com/users/magnayn/repos","events_url":"https://api.github.com/users/magnayn/events{/privacy}","received_events_url":"https://api.github.com/users/magnayn/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":0,"state":"open","created_at":"2015-01-20T14:15:21Z","updated_at":"2015-02-24T12:51:04Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2015-02-24T10:37:12Z","updated_at":"2015-02-25T16:57:37Z","closed_at":null,"body":"As partially expected, #157 didn't quite fix the guava/shading issue.\r\n\r\nI have created a work branch (shade-dependencies) to attempt to fix this. I think it might be working for Jenkins, but it fails if you run the tests, which I don't understand. I have not tried with any kind of security.\r\n\r\nBroadly, the issue is this:\r\n\r\nWe use docker-java. docker-java has a number of dependencies. Some of these dependencies (notably guava and http commons) clash with Jenkins' own, and because the plugin infrastructure follows a 'jenkins first, then plugin', this causes all manner of class-not-found fails. \r\n\r\nWe are not the first people to come across this. I have cheerfully ripped the pattern from jclouds-plugin, which generates a shaded jar and then uses that.\r\n\r\nI have not tested thoroughly. Particularly it is currently failing when the tests are run, with (for example)\r\n\r\n```bash\r\ncom/nirima/jenkins/plugins/docker/DockerSlave/configure-entries.jelly(org.jvnet.hudson.test.JellyTestSuiteBuilder$JellyCheck)  Time elapsed: 0.002 sec  <<< FAILURE!\r\njava.lang.AssertionError: <?jelly escape-by-default='true'?> is missing\r\n\tat org.jvnet.hudson.test.JellyTestSuiteBuilder$JellyCheck.runTest(JellyTestSuiteBuilder.java:98)\r\n```\r\n\r\n@jglick had useful stuff to say on the mailing list and may have some insight into what's going on above; @thomassuckow was also working on this.\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jenkinsci/docker-plugin/issues/comments/76001310","html_url":"https://github.com/jenkinsci/docker-plugin/issues/163#issuecomment-76001310","issue_url":"https://api.github.com/repos/jenkinsci/docker-plugin/issues/163","id":76001310,"user":{"login":"thomassuckow","id":3100037,"avatar_url":"https://avatars.githubusercontent.com/u/3100037?v=3","gravatar_id":"","url":"https://api.github.com/users/thomassuckow","html_url":"https://github.com/thomassuckow","followers_url":"https://api.github.com/users/thomassuckow/followers","following_url":"https://api.github.com/users/thomassuckow/following{/other_user}","gists_url":"https://api.github.com/users/thomassuckow/gists{/gist_id}","starred_url":"https://api.github.com/users/thomassuckow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomassuckow/subscriptions","organizations_url":"https://api.github.com/users/thomassuckow/orgs","repos_url":"https://api.github.com/users/thomassuckow/repos","events_url":"https://api.github.com/users/thomassuckow/events{/privacy}","received_events_url":"https://api.github.com/users/thomassuckow/received_events","type":"User","site_admin":false},"created_at":"2015-02-25T16:57:37Z","updated_at":"2015-02-25T16:57:37Z","body":"Strange. When I get a chance I'll have to look into it further. It does appear to be in Central, but maven isn't downloading it.\r\n\r\nUntil then, I will blame the corporate firewall... because I can, even though it is probably something else."}}