{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/vault-boss/pulls/comments/27997274","id":27997274,"diff_hunk":"@@ -398,6 +398,26 @@ private String getMessage(String key) {\n         return msg;\n     }\n \n+    @Override\n+    public ErrorDesc getResumableUploadURL(String objectId, String userName, ResolveResponse resp) {\n+        ErrorDesc error = null;\n+        if ( userName == null  ){\n+            return badReqErr(getMessage(\"remoteUser\"));\n+        }\n+        BossDAO dao = getDao();\n+        ObjectRow rec = dao.findObjectById(objectId);\n+        if ( rec == null ) {\n+            return  notFoundErr(objectId);\n+        }\n+        if ( !dao.canWrite(objectId,userName) ) {\n+            return  writePermsErr(objectId,userName);\n+        }\n+        ObjectStore objStore = getObjectStore(StoragePlatform.CLOUDSTORE.getValue());","path":"boss-ws/src/main/java/org/genomebridge/boss/http/service/DatabaseBossAPI.java","position":29,"original_position":29,"commit_id":"3b0a233b30b11a962d7cbeaccf01bc9d6b5ed552","original_commit_id":"3b0a233b30b11a962d7cbeaccf01bc9d6b5ed552","user":{"login":"tedsharpe","id":9284156,"avatar_url":"https://avatars.githubusercontent.com/u/9284156?v=3","gravatar_id":"","url":"https://api.github.com/users/tedsharpe","html_url":"https://github.com/tedsharpe","followers_url":"https://api.github.com/users/tedsharpe/followers","following_url":"https://api.github.com/users/tedsharpe/following{/other_user}","gists_url":"https://api.github.com/users/tedsharpe/gists{/gist_id}","starred_url":"https://api.github.com/users/tedsharpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedsharpe/subscriptions","organizations_url":"https://api.github.com/users/tedsharpe/orgs","repos_url":"https://api.github.com/users/tedsharpe/repos","events_url":"https://api.github.com/users/tedsharpe/events{/privacy}","received_events_url":"https://api.github.com/users/tedsharpe/received_events","type":"User","site_admin":false},"body":"We need to use the object store indicated by the ObjectRow -- we can't hard-code CLOUDSTORE here.  But one more thing:  we need to check to make sure that the rec.storagePlatform is not OPAQUEURI because the getObjectStore method returns null for that type.  The needed code is on lines 268-9 in this file.\r\nAnd let's move this method up with the other @Override public methods.","created_at":"2015-04-08T18:15:58Z","updated_at":"2015-04-08T18:15:58Z","html_url":"https://github.com/broadinstitute/vault-boss/pull/2#discussion_r27997274","pull_request_url":"https://api.github.com/repos/broadinstitute/vault-boss/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/vault-boss/pulls/comments/27997274"},"html":{"href":"https://github.com/broadinstitute/vault-boss/pull/2#discussion_r27997274"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/vault-boss/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/vault-boss/pulls/2","id":32680758,"html_url":"https://github.com/broadinstitute/vault-boss/pull/2","diff_url":"https://github.com/broadinstitute/vault-boss/pull/2.diff","patch_url":"https://github.com/broadinstitute/vault-boss/pull/2.patch","issue_url":"https://api.github.com/repos/broadinstitute/vault-boss/issues/2","number":2,"state":"open","locked":false,"title":"add resumable uploads","user":{"login":"vvicario","id":11353754,"avatar_url":"https://avatars.githubusercontent.com/u/11353754?v=3","gravatar_id":"","url":"https://api.github.com/users/vvicario","html_url":"https://github.com/vvicario","followers_url":"https://api.github.com/users/vvicario/followers","following_url":"https://api.github.com/users/vvicario/following{/other_user}","gists_url":"https://api.github.com/users/vvicario/gists{/gist_id}","starred_url":"https://api.github.com/users/vvicario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvicario/subscriptions","organizations_url":"https://api.github.com/users/vvicario/orgs","repos_url":"https://api.github.com/users/vvicario/repos","events_url":"https://api.github.com/users/vvicario/events{/privacy}","received_events_url":"https://api.github.com/users/vvicario/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-06T14:11:57Z","updated_at":"2015-04-08T18:15:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce4b97e55b3643d3c6b51be2ab5fd42edc097ffe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/vault-boss/pulls/2/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/vault-boss/pulls/2/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/vault-boss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/vault-boss/issues/2/comments","statuses_url":"https://api.github.com/repos/broadinstitute/vault-boss/statuses/3b0a233b30b11a962d7cbeaccf01bc9d6b5ed552","head":{"label":"broadinstitute:vv_resumable_upload","ref":"vv_resumable_upload","sha":"3b0a233b30b11a962d7cbeaccf01bc9d6b5ed552","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":33316998,"name":"vault-boss","full_name":"broadinstitute/vault-boss","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/vault-boss","description":"Public repo for BOSS","fork":false,"url":"https://api.github.com/repos/broadinstitute/vault-boss","forks_url":"https://api.github.com/repos/broadinstitute/vault-boss/forks","keys_url":"https://api.github.com/repos/broadinstitute/vault-boss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/vault-boss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/vault-boss/teams","hooks_url":"https://api.github.com/repos/broadinstitute/vault-boss/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/vault-boss/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/vault-boss/events","assignees_url":"https://api.github.com/repos/broadinstitute/vault-boss/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/vault-boss/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/vault-boss/tags","blobs_url":"https://api.github.com/repos/broadinstitute/vault-boss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/vault-boss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/vault-boss/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/vault-boss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/vault-boss/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/vault-boss/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/vault-boss/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/vault-boss/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/vault-boss/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/vault-boss/subscription","commits_url":"https://api.github.com/repos/broadinstitute/vault-boss/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/vault-boss/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/vault-boss/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/vault-boss/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/vault-boss/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/vault-boss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/vault-boss/merges","archive_url":"https://api.github.com/repos/broadinstitute/vault-boss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/vault-boss/downloads","issues_url":"https://api.github.com/repos/broadinstitute/vault-boss/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/vault-boss/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/vault-boss/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/vault-boss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/vault-boss/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/vault-boss/releases{/id}","created_at":"2015-04-02T15:38:37Z","updated_at":"2015-04-02T20:23:33Z","pushed_at":"2015-04-06T14:11:57Z","git_url":"git://github.com/broadinstitute/vault-boss.git","ssh_url":"git@github.com:broadinstitute/vault-boss.git","clone_url":"https://github.com/broadinstitute/vault-boss.git","svn_url":"https://github.com/broadinstitute/vault-boss","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"6c24ec15dc72ecbf29361b35d1f173f04c2ce082","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":33316998,"name":"vault-boss","full_name":"broadinstitute/vault-boss","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/vault-boss","description":"Public repo for BOSS","fork":false,"url":"https://api.github.com/repos/broadinstitute/vault-boss","forks_url":"https://api.github.com/repos/broadinstitute/vault-boss/forks","keys_url":"https://api.github.com/repos/broadinstitute/vault-boss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/vault-boss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/vault-boss/teams","hooks_url":"https://api.github.com/repos/broadinstitute/vault-boss/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/vault-boss/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/vault-boss/events","assignees_url":"https://api.github.com/repos/broadinstitute/vault-boss/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/vault-boss/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/vault-boss/tags","blobs_url":"https://api.github.com/repos/broadinstitute/vault-boss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/vault-boss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/vault-boss/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/vault-boss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/vault-boss/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/vault-boss/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/vault-boss/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/vault-boss/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/vault-boss/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/vault-boss/subscription","commits_url":"https://api.github.com/repos/broadinstitute/vault-boss/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/vault-boss/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/vault-boss/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/vault-boss/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/vault-boss/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/vault-boss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/vault-boss/merges","archive_url":"https://api.github.com/repos/broadinstitute/vault-boss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/vault-boss/downloads","issues_url":"https://api.github.com/repos/broadinstitute/vault-boss/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/vault-boss/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/vault-boss/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/vault-boss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/vault-boss/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/vault-boss/releases{/id}","created_at":"2015-04-02T15:38:37Z","updated_at":"2015-04-02T20:23:33Z","pushed_at":"2015-04-06T14:11:57Z","git_url":"git://github.com/broadinstitute/vault-boss.git","ssh_url":"git@github.com:broadinstitute/vault-boss.git","clone_url":"https://github.com/broadinstitute/vault-boss.git","svn_url":"https://github.com/broadinstitute/vault-boss","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/vault-boss/pulls/2"},"html":{"href":"https://github.com/broadinstitute/vault-boss/pull/2"},"issue":{"href":"https://api.github.com/repos/broadinstitute/vault-boss/issues/2"},"comments":{"href":"https://api.github.com/repos/broadinstitute/vault-boss/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/vault-boss/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/vault-boss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/vault-boss/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/vault-boss/statuses/3b0a233b30b11a962d7cbeaccf01bc9d6b5ed552"}}}}