{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/47447179","id":47447179,"diff_hunk":"@@ -2,30 +2,33 @@\n \n ##    Error messages for Unicode / UTF support\n \n-const UTF_ERR_SHORT             = \"invalid UTF-8 sequence starting at index <<1>> (0x<<2>>) missing one or more continuation bytes)\"\n-const UTF_ERR_CONT              = \"invalid UTF-8 sequence starting at index <<1>> (0x<<2>> is not a continuation byte)\"\n-const UTF_ERR_LONG              = \"invalid UTF-8 sequence, overlong encoding starting at index <<1>> (0x<<2>>)\"\n-const UTF_ERR_NOT_LEAD          = \"not a leading Unicode surrogate code unit at index <<1>> (0x<<2>>)\"\n-const UTF_ERR_NOT_TRAIL         = \"not a trailing Unicode surrogate code unit at index <<1>> (0x<<2>>)\"\n-const UTF_ERR_NOT_SURROGATE     = \"not a valid Unicode surrogate code unit at index <<1>> (0x<<2>>\"\n-const UTF_ERR_MISSING_SURROGATE = \"missing trailing Unicode surrogate code unit after index <<1>> (0x<<2>>)\"\n-const UTF_ERR_INVALID           = \"invalid Unicode character starting at index <<1>> (0x<<2>> > 0x10ffff)\"\n-const UTF_ERR_SURROGATE         = \"surrogate encoding not allowed in UTF-8 or UTF-32, at index <<1>> (0x<<2>>)\"\n-const UTF_ERR_NULL_16_TERMINATE = \"UTF16String data must be NULL-terminated\"\n-const UTF_ERR_NULL_32_TERMINATE = \"UTF32String data must be NULL-terminated\"\n-const UTF_ERR_ODD_BYTES_16      = \"UTF16String can't have odd number of bytes <<1>>\"\n-const UTF_ERR_ODD_BYTES_32      = \"UTF32String must have multiple of 4 bytes <<1>>\"\n-const UTF_ERR_INVALID_CHAR      = \"invalid Unicode character (0x<<2>> > 0x10ffff)\"\n-const UTF_ERR_INVALID_8         = \"invalid UTF-8 data\"\n-const UTF_ERR_INVALID_16        = \"invalid UTF-16 data\"\n-const UTF_ERR_INVALID_INDEX     = \"invalid character index\"\n-const UTF_ERR_MAP_CHAR          = \"map(f,s::AbstractString) requires f to return Char; try map(f,collect(s)) or a comprehension instead\"\n+const ERR_SHORT             = \"invalid UTF-8 sequence starting at index <<1>> (0x<<2>>) missing one or more continuation bytes)\"\n+const ERR_CONT              = \"invalid UTF-8 sequence starting at index <<1>> (0x<<2>> is not a continuation byte)\"\n+const ERR_LONG              = \"invalid UTF-8 sequence, overlong encoding starting at index <<1>> (0x<<2>>)\"\n+const ERR_NOT_LEAD          = \"not a leading Unicode surrogate code unit at index <<1>> (0x<<2>>)\"\n+const ERR_NOT_TRAIL         = \"not a trailing Unicode surrogate code unit at index <<1>> (0x<<2>>)\"\n+const ERR_NOT_SURROGATE     = \"not a valid Unicode surrogate code unit at index <<1>> (0x<<2>>\"\n+const ERR_MISSING_SURROGATE = \"missing trailing Unicode surrogate code unit after index <<1>> (0x<<2>>)\"\n+const ERR_INVALID           = \"invalid Unicode character starting at index <<1>> (0x<<2>> > 0x10ffff)\"\n+const ERR_SURROGATE         = \"surrogate encoding not allowed in UTF-8 or UTF-32, at index <<1>> (0x<<2>>)\"\n+const ERR_NULL_16_TERMINATE = \"UTF16String data must be NULL-terminated\"\n+const ERR_NULL_32_TERMINATE = \"UTF32String data must be NULL-terminated\"\n+const ERR_ODD_BYTES_16      = \"UTF16String can't have odd number of bytes <<1>>\"\n+const ERR_ODD_BYTES_32      = \"UTF32String must have multiple of 4 bytes <<1>>\"\n+const ERR_INVALID_CHAR      = \"invalid Unicode character (0x<<2>> > 0x10ffff)\"\n+const ERR_INVALID_8         = \"invalid UTF-8 data\"\n+const ERR_INVALID_16        = \"invalid UTF-16 data\"\n+const ERR_INVALID_INDEX     = \"invalid character index\"\n+const ERR_MAP_CHAR          = \"map(f,s::AbstractString) requires f to return Char; try map(f,collect(s)) or a comprehension instead\"\n+\n+export UnicodeError\n \n type UnicodeError <: Exception\n-    errmsg::AbstractString      ##< A UTF_ERR_ message\n+    errmsg::AbstractString      ##< An Unicode.ERR_ message","path":"base/unicode/UnicodeError.jl","position":45,"original_position":45,"commit_id":"e6488e36ee0dac57e7f192163644ac881982cbc4","original_commit_id":"e6488e36ee0dac57e7f192163644ac881982cbc4","user":{"login":"nalimilan","id":1120448,"avatar_url":"https://avatars.githubusercontent.com/u/1120448?v=3","gravatar_id":"","url":"https://api.github.com/users/nalimilan","html_url":"https://github.com/nalimilan","followers_url":"https://api.github.com/users/nalimilan/followers","following_url":"https://api.github.com/users/nalimilan/following{/other_user}","gists_url":"https://api.github.com/users/nalimilan/gists{/gist_id}","starred_url":"https://api.github.com/users/nalimilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalimilan/subscriptions","organizations_url":"https://api.github.com/users/nalimilan/orgs","repos_url":"https://api.github.com/users/nalimilan/repos","events_url":"https://api.github.com/users/nalimilan/events{/privacy}","received_events_url":"https://api.github.com/users/nalimilan/received_events","type":"User","site_admin":false},"body":"\"A Unicode\" if I'm not mistaken.","created_at":"2015-12-13T16:56:48Z","updated_at":"2015-12-13T16:56:48Z","html_url":"https://github.com/JuliaLang/julia/pull/14387#discussion_r47447179","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/14387","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/47447179"},"html":{"href":"https://github.com/JuliaLang/julia/pull/14387#discussion_r47447179"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/14387"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/14387","id":53493458,"html_url":"https://github.com/JuliaLang/julia/pull/14387","diff_url":"https://github.com/JuliaLang/julia/pull/14387.diff","patch_url":"https://github.com/JuliaLang/julia/pull/14387.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/14387","number":14387,"state":"open","locked":false,"title":"WIP: Unicode character properties","user":{"login":"ScottPJones","id":11798751,"avatar_url":"https://avatars.githubusercontent.com/u/11798751?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottPJones","html_url":"https://github.com/ScottPJones","followers_url":"https://api.github.com/users/ScottPJones/followers","following_url":"https://api.github.com/users/ScottPJones/following{/other_user}","gists_url":"https://api.github.com/users/ScottPJones/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottPJones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottPJones/subscriptions","organizations_url":"https://api.github.com/users/ScottPJones/orgs","repos_url":"https://api.github.com/users/ScottPJones/repos","events_url":"https://api.github.com/users/ScottPJones/events{/privacy}","received_events_url":"https://api.github.com/users/ScottPJones/received_events","type":"User","site_admin":false},"body":"This is still a WIP, based on the comments in #14347, to be subjected to some bikeshedding and performance testing, before deprecating some (not all) of the old very abbreviated character classification functions, such as `isalnum`, `isnumber`, `iscntrl`, etc.\r\nSuggestions on how to improve it are quite welcome, of course!\r\n","created_at":"2015-12-13T05:43:14Z","updated_at":"2015-12-13T16:56:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c03794798a474fea2facc1b9c54dfc59bb033ee7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/14387/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/14387/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/14387/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/e6488e36ee0dac57e7f192163644ac881982cbc4","head":{"label":"ScottPJones:spj/charcategory","ref":"spj/charcategory","sha":"e6488e36ee0dac57e7f192163644ac881982cbc4","user":{"login":"ScottPJones","id":11798751,"avatar_url":"https://avatars.githubusercontent.com/u/11798751?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottPJones","html_url":"https://github.com/ScottPJones","followers_url":"https://api.github.com/users/ScottPJones/followers","following_url":"https://api.github.com/users/ScottPJones/following{/other_user}","gists_url":"https://api.github.com/users/ScottPJones/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottPJones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottPJones/subscriptions","organizations_url":"https://api.github.com/users/ScottPJones/orgs","repos_url":"https://api.github.com/users/ScottPJones/repos","events_url":"https://api.github.com/users/ScottPJones/events{/privacy}","received_events_url":"https://api.github.com/users/ScottPJones/received_events","type":"User","site_admin":false},"repo":{"id":34334720,"name":"julia","full_name":"ScottPJones/julia","owner":{"login":"ScottPJones","id":11798751,"avatar_url":"https://avatars.githubusercontent.com/u/11798751?v=3","gravatar_id":"","url":"https://api.github.com/users/ScottPJones","html_url":"https://github.com/ScottPJones","followers_url":"https://api.github.com/users/ScottPJones/followers","following_url":"https://api.github.com/users/ScottPJones/following{/other_user}","gists_url":"https://api.github.com/users/ScottPJones/gists{/gist_id}","starred_url":"https://api.github.com/users/ScottPJones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScottPJones/subscriptions","organizations_url":"https://api.github.com/users/ScottPJones/orgs","repos_url":"https://api.github.com/users/ScottPJones/repos","events_url":"https://api.github.com/users/ScottPJones/events{/privacy}","received_events_url":"https://api.github.com/users/ScottPJones/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ScottPJones/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/ScottPJones/julia","forks_url":"https://api.github.com/repos/ScottPJones/julia/forks","keys_url":"https://api.github.com/repos/ScottPJones/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScottPJones/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScottPJones/julia/teams","hooks_url":"https://api.github.com/repos/ScottPJones/julia/hooks","issue_events_url":"https://api.github.com/repos/ScottPJones/julia/issues/events{/number}","events_url":"https://api.github.com/repos/ScottPJones/julia/events","assignees_url":"https://api.github.com/repos/ScottPJones/julia/assignees{/user}","branches_url":"https://api.github.com/repos/ScottPJones/julia/branches{/branch}","tags_url":"https://api.github.com/repos/ScottPJones/julia/tags","blobs_url":"https://api.github.com/repos/ScottPJones/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScottPJones/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScottPJones/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScottPJones/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScottPJones/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/ScottPJones/julia/languages","stargazers_url":"https://api.github.com/repos/ScottPJones/julia/stargazers","contributors_url":"https://api.github.com/repos/ScottPJones/julia/contributors","subscribers_url":"https://api.github.com/repos/ScottPJones/julia/subscribers","subscription_url":"https://api.github.com/repos/ScottPJones/julia/subscription","commits_url":"https://api.github.com/repos/ScottPJones/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScottPJones/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScottPJones/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScottPJones/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScottPJones/julia/contents/{+path}","compare_url":"https://api.github.com/repos/ScottPJones/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScottPJones/julia/merges","archive_url":"https://api.github.com/repos/ScottPJones/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScottPJones/julia/downloads","issues_url":"https://api.github.com/repos/ScottPJones/julia/issues{/number}","pulls_url":"https://api.github.com/repos/ScottPJones/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/ScottPJones/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/ScottPJones/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScottPJones/julia/labels{/name}","releases_url":"https://api.github.com/repos/ScottPJones/julia/releases{/id}","created_at":"2015-04-21T15:12:29Z","updated_at":"2015-05-08T00:23:59Z","pushed_at":"2015-12-13T13:07:09Z","git_url":"git://github.com/ScottPJones/julia.git","ssh_url":"git@github.com:ScottPJones/julia.git","clone_url":"https://github.com/ScottPJones/julia.git","svn_url":"https://github.com/ScottPJones/julia","homepage":"http://julialang.org/","size":91027,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"99cf12cb7c13cce11ca2f33df5c20f38736916e4","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2015-12-13T16:34:09Z","pushed_at":"2015-12-13T16:52:52Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":116965,"stargazers_count":6456,"watchers_count":6456,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1441,"mirror_url":null,"open_issues_count":1557,"forks":1441,"open_issues":1557,"watchers":6456,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/14387"},"html":{"href":"https://github.com/JuliaLang/julia/pull/14387"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/14387"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/14387/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/14387/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/14387/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/e6488e36ee0dac57e7f192163644ac881982cbc4"}}}}