{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/34649162","id":34649162,"diff_hunk":"@@ -1,15 +1,5 @@\n-#if (defined _WIN32 || defined WINDOWS || defined MINGW) && ! defined CROSS_LINUX && !defined _MSC_VER\n-\n-#ifndef VERSION\n-#define VERSION \"0.C\" // FIXME: automatically generate VERSION based on git","path":"src/version.cpp","position":4,"original_position":4,"commit_id":"94aa3351017ee2f088f11e1603baea1cf689d201","original_commit_id":"94aa3351017ee2f088f11e1603baea1cf689d201","user":{"login":"karlnp","id":3675735,"avatar_url":"https://avatars.githubusercontent.com/u/3675735?v=3","gravatar_id":"","url":"https://api.github.com/users/karlnp","html_url":"https://github.com/karlnp","followers_url":"https://api.github.com/users/karlnp/followers","following_url":"https://api.github.com/users/karlnp/following{/other_user}","gists_url":"https://api.github.com/users/karlnp/gists{/gist_id}","starred_url":"https://api.github.com/users/karlnp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlnp/subscriptions","organizations_url":"https://api.github.com/users/karlnp/orgs","repos_url":"https://api.github.com/users/karlnp/repos","events_url":"https://api.github.com/users/karlnp/events{/privacy}","received_events_url":"https://api.github.com/users/karlnp/received_events","type":"User","site_admin":false},"body":"Why don't we add a version.h with a static version and we can bump that or override it as necessary?","created_at":"2015-07-15T06:27:58Z","updated_at":"2015-07-15T06:27:58Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12939#discussion_r34649162","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12939","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/34649162"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12939#discussion_r34649162"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12939"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12939","id":39987553,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12939","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12939.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12939.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12939","number":12939,"state":"open","locked":false,"title":"Enables git versioning for Windows/CMake builds","user":{"login":"karlnp","id":3675735,"avatar_url":"https://avatars.githubusercontent.com/u/3675735?v=3","gravatar_id":"","url":"https://api.github.com/users/karlnp","html_url":"https://github.com/karlnp","followers_url":"https://api.github.com/users/karlnp/followers","following_url":"https://api.github.com/users/karlnp/following{/other_user}","gists_url":"https://api.github.com/users/karlnp/gists{/gist_id}","starred_url":"https://api.github.com/users/karlnp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlnp/subscriptions","organizations_url":"https://api.github.com/users/karlnp/orgs","repos_url":"https://api.github.com/users/karlnp/repos","events_url":"https://api.github.com/users/karlnp/events{/privacy}","received_events_url":"https://api.github.com/users/karlnp/received_events","type":"User","site_admin":false},"body":"Adding git revision module to CmakeMods & updating CMakeList to use it.\r\n\r\nsrc/version.h will be generated each build, but it was previously 0.9something and replaced with 0.C as hardcoded in version.cpp, so I don't think anyone will mind.","created_at":"2015-07-15T04:39:07Z","updated_at":"2015-07-15T06:27:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1db65f3791036a809f2f8417c7941e8a4b02779","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12939/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12939/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12939/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/94aa3351017ee2f088f11e1603baea1cf689d201","head":{"label":"karlnp:cmake_versioning","ref":"cmake_versioning","sha":"94aa3351017ee2f088f11e1603baea1cf689d201","user":{"login":"karlnp","id":3675735,"avatar_url":"https://avatars.githubusercontent.com/u/3675735?v=3","gravatar_id":"","url":"https://api.github.com/users/karlnp","html_url":"https://github.com/karlnp","followers_url":"https://api.github.com/users/karlnp/followers","following_url":"https://api.github.com/users/karlnp/following{/other_user}","gists_url":"https://api.github.com/users/karlnp/gists{/gist_id}","starred_url":"https://api.github.com/users/karlnp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlnp/subscriptions","organizations_url":"https://api.github.com/users/karlnp/orgs","repos_url":"https://api.github.com/users/karlnp/repos","events_url":"https://api.github.com/users/karlnp/events{/privacy}","received_events_url":"https://api.github.com/users/karlnp/received_events","type":"User","site_admin":false},"repo":{"id":38774641,"name":"Cataclysm-DDA","full_name":"karlnp/Cataclysm-DDA","owner":{"login":"karlnp","id":3675735,"avatar_url":"https://avatars.githubusercontent.com/u/3675735?v=3","gravatar_id":"","url":"https://api.github.com/users/karlnp","html_url":"https://github.com/karlnp","followers_url":"https://api.github.com/users/karlnp/followers","following_url":"https://api.github.com/users/karlnp/following{/other_user}","gists_url":"https://api.github.com/users/karlnp/gists{/gist_id}","starred_url":"https://api.github.com/users/karlnp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlnp/subscriptions","organizations_url":"https://api.github.com/users/karlnp/orgs","repos_url":"https://api.github.com/users/karlnp/repos","events_url":"https://api.github.com/users/karlnp/events{/privacy}","received_events_url":"https://api.github.com/users/karlnp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karlnp/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/karlnp/Cataclysm-DDA","forks_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/karlnp/Cataclysm-DDA/releases{/id}","created_at":"2015-07-08T19:16:03Z","updated_at":"2015-07-08T19:16:09Z","pushed_at":"2015-07-15T04:37:09Z","git_url":"git://github.com/karlnp/Cataclysm-DDA.git","ssh_url":"git@github.com:karlnp/Cataclysm-DDA.git","clone_url":"https://github.com/karlnp/Cataclysm-DDA.git","svn_url":"https://github.com/karlnp/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":483864,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"16da6017b4a4d714a57ebcb2927c42909f8cd05d","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2015-07-11T09:12:31Z","pushed_at":"2015-07-15T05:20:50Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":567289,"stargazers_count":695,"watchers_count":695,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":734,"mirror_url":null,"open_issues_count":1016,"forks":734,"open_issues":1016,"watchers":695,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12939"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12939"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12939"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12939/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12939/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12939/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/94aa3351017ee2f088f11e1603baea1cf689d201"}}}}