{"action":"created","comment":{"url":"https://api.github.com/repos/OSGP/Platform/pulls/comments/47640111","id":47640111,"diff_hunk":"@@ -33,6 +36,9 @@\n     @Autowired\n     private NotificationService notificationService;\n \n+    @Autowired\n+    private MeterResponseDataService meterResponseDataService;","path":"osgp-adapter-ws-smartmetering/src/main/java/com/alliander/osgp/adapter/ws/smartmetering/infra/jms/messageprocessor/AddMeterResponseMessageProcessor.java","position":18,"original_position":18,"commit_id":"711fa1d62df355bd89aa5dca8ee0dcb7fad8eb00","original_commit_id":"664400cf6daf46faebd7abb762e5d85ef8864dd2","user":{"login":"rudidevries","id":5311277,"avatar_url":"https://avatars.githubusercontent.com/u/5311277?v=3","gravatar_id":"","url":"https://api.github.com/users/rudidevries","html_url":"https://github.com/rudidevries","followers_url":"https://api.github.com/users/rudidevries/followers","following_url":"https://api.github.com/users/rudidevries/following{/other_user}","gists_url":"https://api.github.com/users/rudidevries/gists{/gist_id}","starred_url":"https://api.github.com/users/rudidevries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudidevries/subscriptions","organizations_url":"https://api.github.com/users/rudidevries/orgs","repos_url":"https://api.github.com/users/rudidevries/repos","events_url":"https://api.github.com/users/rudidevries/events{/privacy}","received_events_url":"https://api.github.com/users/rudidevries/received_events","type":"User","site_admin":false},"body":"When to refactor all and when to refactor just the part of the related story is still a bit of a fuzzy decision to make. I have refactored the other response processers to the service now.","created_at":"2015-12-15T14:15:58Z","updated_at":"2015-12-15T14:15:58Z","html_url":"https://github.com/OSGP/Platform/pull/269#discussion_r47640111","pull_request_url":"https://api.github.com/repos/OSGP/Platform/pulls/269","_links":{"self":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/comments/47640111"},"html":{"href":"https://github.com/OSGP/Platform/pull/269#discussion_r47640111"},"pull_request":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/269"}}},"pull_request":{"url":"https://api.github.com/repos/OSGP/Platform/pulls/269","id":53537432,"html_url":"https://github.com/OSGP/Platform/pull/269","diff_url":"https://github.com/OSGP/Platform/pull/269.diff","patch_url":"https://github.com/OSGP/Platform/pull/269.patch","issue_url":"https://api.github.com/repos/OSGP/Platform/issues/269","number":269,"state":"open","locked":false,"title":"Feat retrieve results","user":{"login":"rudidevries","id":5311277,"avatar_url":"https://avatars.githubusercontent.com/u/5311277?v=3","gravatar_id":"","url":"https://api.github.com/users/rudidevries","html_url":"https://github.com/rudidevries","followers_url":"https://api.github.com/users/rudidevries/followers","following_url":"https://api.github.com/users/rudidevries/following{/other_user}","gists_url":"https://api.github.com/users/rudidevries/gists{/gist_id}","starred_url":"https://api.github.com/users/rudidevries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudidevries/subscriptions","organizations_url":"https://api.github.com/users/rudidevries/orgs","repos_url":"https://api.github.com/users/rudidevries/repos","events_url":"https://api.github.com/users/rudidevries/events{/privacy}","received_events_url":"https://api.github.com/users/rudidevries/received_events","type":"User","site_admin":false},"body":"Connects to OSGP/Platform#213\r\nConnects to OSGP/Platform#215\r\nConnects to OSGP/Platform#216","created_at":"2015-12-14T08:47:17Z","updated_at":"2015-12-15T14:15:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8361d712edab8eca8786b2a8f3928a00b9d376e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OSGP/Platform/pulls/269/commits","review_comments_url":"https://api.github.com/repos/OSGP/Platform/pulls/269/comments","review_comment_url":"https://api.github.com/repos/OSGP/Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OSGP/Platform/issues/269/comments","statuses_url":"https://api.github.com/repos/OSGP/Platform/statuses/711fa1d62df355bd89aa5dca8ee0dcb7fad8eb00","head":{"label":"OSGP:feat-retrieve-results","ref":"feat-retrieve-results","sha":"711fa1d62df355bd89aa5dca8ee0dcb7fad8eb00","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":32739388,"name":"Platform","full_name":"OSGP/Platform","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Platform","description":"The main components of OSGP.","fork":false,"url":"https://api.github.com/repos/OSGP/Platform","forks_url":"https://api.github.com/repos/OSGP/Platform/forks","keys_url":"https://api.github.com/repos/OSGP/Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Platform/teams","hooks_url":"https://api.github.com/repos/OSGP/Platform/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Platform/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Platform/events","assignees_url":"https://api.github.com/repos/OSGP/Platform/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Platform/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Platform/tags","blobs_url":"https://api.github.com/repos/OSGP/Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Platform/languages","stargazers_url":"https://api.github.com/repos/OSGP/Platform/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Platform/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Platform/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Platform/subscription","commits_url":"https://api.github.com/repos/OSGP/Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Platform/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Platform/merges","archive_url":"https://api.github.com/repos/OSGP/Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Platform/downloads","issues_url":"https://api.github.com/repos/OSGP/Platform/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Platform/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Platform/releases{/id}","created_at":"2015-03-23T15:05:40Z","updated_at":"2015-12-09T15:31:36Z","pushed_at":"2015-12-15T14:13:39Z","git_url":"git://github.com/OSGP/Platform.git","ssh_url":"git@github.com:OSGP/Platform.git","clone_url":"https://github.com/OSGP/Platform.git","svn_url":"https://github.com/OSGP/Platform","homepage":null,"size":24448,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":79,"forks":2,"open_issues":79,"watchers":7,"default_branch":"development"}},"base":{"label":"OSGP:development","ref":"development","sha":"a8777c240425b3817d6413c11a3c5519bdf7e5d5","user":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"repo":{"id":32739388,"name":"Platform","full_name":"OSGP/Platform","owner":{"login":"OSGP","id":11352045,"avatar_url":"https://avatars.githubusercontent.com/u/11352045?v=3","gravatar_id":"","url":"https://api.github.com/users/OSGP","html_url":"https://github.com/OSGP","followers_url":"https://api.github.com/users/OSGP/followers","following_url":"https://api.github.com/users/OSGP/following{/other_user}","gists_url":"https://api.github.com/users/OSGP/gists{/gist_id}","starred_url":"https://api.github.com/users/OSGP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OSGP/subscriptions","organizations_url":"https://api.github.com/users/OSGP/orgs","repos_url":"https://api.github.com/users/OSGP/repos","events_url":"https://api.github.com/users/OSGP/events{/privacy}","received_events_url":"https://api.github.com/users/OSGP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OSGP/Platform","description":"The main components of OSGP.","fork":false,"url":"https://api.github.com/repos/OSGP/Platform","forks_url":"https://api.github.com/repos/OSGP/Platform/forks","keys_url":"https://api.github.com/repos/OSGP/Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OSGP/Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OSGP/Platform/teams","hooks_url":"https://api.github.com/repos/OSGP/Platform/hooks","issue_events_url":"https://api.github.com/repos/OSGP/Platform/issues/events{/number}","events_url":"https://api.github.com/repos/OSGP/Platform/events","assignees_url":"https://api.github.com/repos/OSGP/Platform/assignees{/user}","branches_url":"https://api.github.com/repos/OSGP/Platform/branches{/branch}","tags_url":"https://api.github.com/repos/OSGP/Platform/tags","blobs_url":"https://api.github.com/repos/OSGP/Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OSGP/Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OSGP/Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/OSGP/Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OSGP/Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/OSGP/Platform/languages","stargazers_url":"https://api.github.com/repos/OSGP/Platform/stargazers","contributors_url":"https://api.github.com/repos/OSGP/Platform/contributors","subscribers_url":"https://api.github.com/repos/OSGP/Platform/subscribers","subscription_url":"https://api.github.com/repos/OSGP/Platform/subscription","commits_url":"https://api.github.com/repos/OSGP/Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/OSGP/Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/OSGP/Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/OSGP/Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/OSGP/Platform/contents/{+path}","compare_url":"https://api.github.com/repos/OSGP/Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OSGP/Platform/merges","archive_url":"https://api.github.com/repos/OSGP/Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OSGP/Platform/downloads","issues_url":"https://api.github.com/repos/OSGP/Platform/issues{/number}","pulls_url":"https://api.github.com/repos/OSGP/Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/OSGP/Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/OSGP/Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OSGP/Platform/labels{/name}","releases_url":"https://api.github.com/repos/OSGP/Platform/releases{/id}","created_at":"2015-03-23T15:05:40Z","updated_at":"2015-12-09T15:31:36Z","pushed_at":"2015-12-15T14:13:39Z","git_url":"git://github.com/OSGP/Platform.git","ssh_url":"git@github.com:OSGP/Platform.git","clone_url":"https://github.com/OSGP/Platform.git","svn_url":"https://github.com/OSGP/Platform","homepage":null,"size":24448,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":79,"forks":2,"open_issues":79,"watchers":7,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/269"},"html":{"href":"https://github.com/OSGP/Platform/pull/269"},"issue":{"href":"https://api.github.com/repos/OSGP/Platform/issues/269"},"comments":{"href":"https://api.github.com/repos/OSGP/Platform/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OSGP/Platform/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/OSGP/Platform/statuses/711fa1d62df355bd89aa5dca8ee0dcb7fad8eb00"}}}}