{"action":"created","issue":{"url":"https://api.github.com/repos/igniterealtime/Smack/issues/35","labels_url":"https://api.github.com/repos/igniterealtime/Smack/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/igniterealtime/Smack/issues/35/comments","events_url":"https://api.github.com/repos/igniterealtime/Smack/issues/35/events","html_url":"https://github.com/igniterealtime/Smack/pull/35","id":60810323,"number":35,"title":"Fix a logic error when create a new Chat in ChatManager","user":{"login":"zhuzhang","id":4180937,"avatar_url":"https://avatars.githubusercontent.com/u/4180937?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuzhang","html_url":"https://github.com/zhuzhang","followers_url":"https://api.github.com/users/zhuzhang/followers","following_url":"https://api.github.com/users/zhuzhang/following{/other_user}","gists_url":"https://api.github.com/users/zhuzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuzhang/subscriptions","organizations_url":"https://api.github.com/users/zhuzhang/orgs","repos_url":"https://api.github.com/users/zhuzhang/repos","events_url":"https://api.github.com/users/zhuzhang/events{/privacy}","received_events_url":"https://api.github.com/users/zhuzhang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-12T12:18:36Z","updated_at":"2015-03-12T13:05:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/igniterealtime/Smack/pulls/35","html_url":"https://github.com/igniterealtime/Smack/pull/35","diff_url":"https://github.com/igniterealtime/Smack/pull/35.diff","patch_url":"https://github.com/igniterealtime/Smack/pull/35.patch"},"body":"When us smack library for android app, I found a logic error when create Chat in file ChatManager.java.\r\nAs doc says: \"Smack will attempt match the incoming messages to the best fit existing chat, first try thread-id, if no match found,  then based on the JID. It will attempt to find a chat with the same full JID, failing that, it will try the base JID. If no existing chat to the user can found, then a new one is created.\r\nBut the code seems can't handle this scenario: \"A message with a thread id is received, no thread id matched, but jid matched\". The original code will create a new chat, but in fact, it should use a chat with jid matched in the local map."},"comment":{"url":"https://api.github.com/repos/igniterealtime/Smack/issues/comments/78475387","html_url":"https://github.com/igniterealtime/Smack/pull/35#issuecomment-78475387","issue_url":"https://api.github.com/repos/igniterealtime/Smack/issues/35","id":78475387,"user":{"login":"Flowdalic","id":432385,"avatar_url":"https://avatars.githubusercontent.com/u/432385?v=3","gravatar_id":"","url":"https://api.github.com/users/Flowdalic","html_url":"https://github.com/Flowdalic","followers_url":"https://api.github.com/users/Flowdalic/followers","following_url":"https://api.github.com/users/Flowdalic/following{/other_user}","gists_url":"https://api.github.com/users/Flowdalic/gists{/gist_id}","starred_url":"https://api.github.com/users/Flowdalic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flowdalic/subscriptions","organizations_url":"https://api.github.com/users/Flowdalic/orgs","repos_url":"https://api.github.com/users/Flowdalic/repos","events_url":"https://api.github.com/users/Flowdalic/events{/privacy}","received_events_url":"https://api.github.com/users/Flowdalic/received_events","type":"User","site_admin":false},"created_at":"2015-03-12T13:05:59Z","updated_at":"2015-03-12T13:05:59Z","body":"Where in Smacks documentation/javadoc is the documentation you are referring to?"}}