{"action":"created","comment":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/36460444","id":36460444,"diff_hunk":"@@ -43,31 +43,79 @@\n  * OTHER DEALINGS IN THE SOFTWARE.\n  */\n \n-#include \"receivenode.h\"\n-\n #include <sstream>\n \n+#include \"boost/foreach.hpp\"\n+\n+#include \"receivenode.h\"\n+\n namespace voltdb {\n \n-ReceivePlanNode::~ReceivePlanNode() { }\n+namespace {\n+    void schemaDebugInfo(std::ostringstream& buffer, const std::vector<SchemaColumn*>& schema,\n+        const std::string& schema_name, const std::string& spacer) {\n+        buffer << spacer << schema_name << \" Table Columns[\" << schema.size() << \"]:\\n\";\n+        for (int ctr = 0, cnt = (int)schema.size(); ctr < cnt; ctr++) {\n+            SchemaColumn* col = schema[ctr];\n+            buffer << spacer << \"  [\" << ctr << \"] \";\n+            buffer << \"name=\" << col->getColumnName() << \" : \";\n+            buffer << \"size=\" << col->getExpression()->getValueSize() << \" : \";\n+            buffer << \"type=\" << col->getExpression()->getValueType() << \"\\n\";\n+        }\n+    }\n+}\n+\n+\n+ReceivePlanNode::ReceivePlanNode() :\n+    m_mergeReceive(false), m_outputSchemaPreAgg()\n+{ }\n+\n+ReceivePlanNode::~ReceivePlanNode()\n+{\n+    if (m_mergeReceive) {","path":"src/ee/plannodes/receivenode.cpp","position":36,"original_position":36,"commit_id":"97af0488e11aedd248608cf4e9174fdc1a9a5daf","original_commit_id":"97af0488e11aedd248608cf4e9174fdc1a9a5daf","user":{"login":"paulmartel","id":1512099,"avatar_url":"https://avatars.githubusercontent.com/u/1512099?v=3","gravatar_id":"","url":"https://api.github.com/users/paulmartel","html_url":"https://github.com/paulmartel","followers_url":"https://api.github.com/users/paulmartel/followers","following_url":"https://api.github.com/users/paulmartel/following{/other_user}","gists_url":"https://api.github.com/users/paulmartel/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmartel/subscriptions","organizations_url":"https://api.github.com/users/paulmartel/orgs","repos_url":"https://api.github.com/users/paulmartel/repos","events_url":"https://api.github.com/users/paulmartel/events{/privacy}","received_events_url":"https://api.github.com/users/paulmartel/received_events","type":"User","site_admin":false},"body":"This flag test is not actually required.","created_at":"2015-08-06T20:19:59Z","updated_at":"2015-08-06T20:19:59Z","html_url":"https://github.com/VoltDB/voltdb/pull/2665#discussion_r36460444","pull_request_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2665","_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments/36460444"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/2665#discussion_r36460444"},"pull_request":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2665"}}},"pull_request":{"url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2665","id":41739927,"html_url":"https://github.com/VoltDB/voltdb/pull/2665","diff_url":"https://github.com/VoltDB/voltdb/pull/2665.diff","patch_url":"https://github.com/VoltDB/voltdb/pull/2665.patch","issue_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2665","number":2665,"state":"open","locked":false,"title":"Eng 8455 orderby merge sort","user":{"login":"alexeevm","id":1646199,"avatar_url":"https://avatars.githubusercontent.com/u/1646199?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeevm","html_url":"https://github.com/alexeevm","followers_url":"https://api.github.com/users/alexeevm/followers","following_url":"https://api.github.com/users/alexeevm/following{/other_user}","gists_url":"https://api.github.com/users/alexeevm/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeevm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeevm/subscriptions","organizations_url":"https://api.github.com/users/alexeevm/orgs","repos_url":"https://api.github.com/users/alexeevm/repos","events_url":"https://api.github.com/users/alexeevm/events{/privacy}","received_events_url":"https://api.github.com/users/alexeevm/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-06T00:04:03Z","updated_at":"2015-08-06T20:19:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46eb96c661882833d10131c578d4e1c1f43a70a7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2665/commits","review_comments_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/2665/comments","review_comment_url":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/issues/2665/comments","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/97af0488e11aedd248608cf4e9174fdc1a9a5daf","head":{"label":"alexeevm:ENG-8455-orderby-merge-sort","ref":"ENG-8455-orderby-merge-sort","sha":"97af0488e11aedd248608cf4e9174fdc1a9a5daf","user":{"login":"alexeevm","id":1646199,"avatar_url":"https://avatars.githubusercontent.com/u/1646199?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeevm","html_url":"https://github.com/alexeevm","followers_url":"https://api.github.com/users/alexeevm/followers","following_url":"https://api.github.com/users/alexeevm/following{/other_user}","gists_url":"https://api.github.com/users/alexeevm/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeevm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeevm/subscriptions","organizations_url":"https://api.github.com/users/alexeevm/orgs","repos_url":"https://api.github.com/users/alexeevm/repos","events_url":"https://api.github.com/users/alexeevm/events{/privacy}","received_events_url":"https://api.github.com/users/alexeevm/received_events","type":"User","site_admin":false},"repo":{"id":4035225,"name":"voltdb","full_name":"alexeevm/voltdb","owner":{"login":"alexeevm","id":1646199,"avatar_url":"https://avatars.githubusercontent.com/u/1646199?v=3","gravatar_id":"","url":"https://api.github.com/users/alexeevm","html_url":"https://github.com/alexeevm","followers_url":"https://api.github.com/users/alexeevm/followers","following_url":"https://api.github.com/users/alexeevm/following{/other_user}","gists_url":"https://api.github.com/users/alexeevm/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeevm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeevm/subscriptions","organizations_url":"https://api.github.com/users/alexeevm/orgs","repos_url":"https://api.github.com/users/alexeevm/repos","events_url":"https://api.github.com/users/alexeevm/events{/privacy}","received_events_url":"https://api.github.com/users/alexeevm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexeevm/voltdb","description":"VoltDB","fork":true,"url":"https://api.github.com/repos/alexeevm/voltdb","forks_url":"https://api.github.com/repos/alexeevm/voltdb/forks","keys_url":"https://api.github.com/repos/alexeevm/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexeevm/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexeevm/voltdb/teams","hooks_url":"https://api.github.com/repos/alexeevm/voltdb/hooks","issue_events_url":"https://api.github.com/repos/alexeevm/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/alexeevm/voltdb/events","assignees_url":"https://api.github.com/repos/alexeevm/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/alexeevm/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/alexeevm/voltdb/tags","blobs_url":"https://api.github.com/repos/alexeevm/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexeevm/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexeevm/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexeevm/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexeevm/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/alexeevm/voltdb/languages","stargazers_url":"https://api.github.com/repos/alexeevm/voltdb/stargazers","contributors_url":"https://api.github.com/repos/alexeevm/voltdb/contributors","subscribers_url":"https://api.github.com/repos/alexeevm/voltdb/subscribers","subscription_url":"https://api.github.com/repos/alexeevm/voltdb/subscription","commits_url":"https://api.github.com/repos/alexeevm/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexeevm/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexeevm/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexeevm/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexeevm/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/alexeevm/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexeevm/voltdb/merges","archive_url":"https://api.github.com/repos/alexeevm/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexeevm/voltdb/downloads","issues_url":"https://api.github.com/repos/alexeevm/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/alexeevm/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/alexeevm/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/alexeevm/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexeevm/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/alexeevm/voltdb/releases{/id}","created_at":"2012-04-15T21:29:40Z","updated_at":"2015-04-30T01:37:44Z","pushed_at":"2015-08-06T02:36:08Z","git_url":"git://github.com/alexeevm/voltdb.git","ssh_url":"git@github.com:alexeevm/voltdb.git","clone_url":"https://github.com/alexeevm/voltdb.git","svn_url":"https://github.com/alexeevm/voltdb","homepage":"http://community.voltdb.com/","size":220324,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"VoltDB:master","ref":"master","sha":"aa7c835769717f5414d2b763fe4a8f824e53f81a","user":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"repo":{"id":2445970,"name":"voltdb","full_name":"VoltDB/voltdb","owner":{"login":"VoltDB","id":703910,"avatar_url":"https://avatars.githubusercontent.com/u/703910?v=3","gravatar_id":"","url":"https://api.github.com/users/VoltDB","html_url":"https://github.com/VoltDB","followers_url":"https://api.github.com/users/VoltDB/followers","following_url":"https://api.github.com/users/VoltDB/following{/other_user}","gists_url":"https://api.github.com/users/VoltDB/gists{/gist_id}","starred_url":"https://api.github.com/users/VoltDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoltDB/subscriptions","organizations_url":"https://api.github.com/users/VoltDB/orgs","repos_url":"https://api.github.com/users/VoltDB/repos","events_url":"https://api.github.com/users/VoltDB/events{/privacy}","received_events_url":"https://api.github.com/users/VoltDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VoltDB/voltdb","description":"VoltDB","fork":false,"url":"https://api.github.com/repos/VoltDB/voltdb","forks_url":"https://api.github.com/repos/VoltDB/voltdb/forks","keys_url":"https://api.github.com/repos/VoltDB/voltdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoltDB/voltdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoltDB/voltdb/teams","hooks_url":"https://api.github.com/repos/VoltDB/voltdb/hooks","issue_events_url":"https://api.github.com/repos/VoltDB/voltdb/issues/events{/number}","events_url":"https://api.github.com/repos/VoltDB/voltdb/events","assignees_url":"https://api.github.com/repos/VoltDB/voltdb/assignees{/user}","branches_url":"https://api.github.com/repos/VoltDB/voltdb/branches{/branch}","tags_url":"https://api.github.com/repos/VoltDB/voltdb/tags","blobs_url":"https://api.github.com/repos/VoltDB/voltdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoltDB/voltdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoltDB/voltdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoltDB/voltdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoltDB/voltdb/statuses/{sha}","languages_url":"https://api.github.com/repos/VoltDB/voltdb/languages","stargazers_url":"https://api.github.com/repos/VoltDB/voltdb/stargazers","contributors_url":"https://api.github.com/repos/VoltDB/voltdb/contributors","subscribers_url":"https://api.github.com/repos/VoltDB/voltdb/subscribers","subscription_url":"https://api.github.com/repos/VoltDB/voltdb/subscription","commits_url":"https://api.github.com/repos/VoltDB/voltdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoltDB/voltdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoltDB/voltdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoltDB/voltdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoltDB/voltdb/contents/{+path}","compare_url":"https://api.github.com/repos/VoltDB/voltdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoltDB/voltdb/merges","archive_url":"https://api.github.com/repos/VoltDB/voltdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoltDB/voltdb/downloads","issues_url":"https://api.github.com/repos/VoltDB/voltdb/issues{/number}","pulls_url":"https://api.github.com/repos/VoltDB/voltdb/pulls{/number}","milestones_url":"https://api.github.com/repos/VoltDB/voltdb/milestones{/number}","notifications_url":"https://api.github.com/repos/VoltDB/voltdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoltDB/voltdb/labels{/name}","releases_url":"https://api.github.com/repos/VoltDB/voltdb/releases{/id}","created_at":"2011-09-23T18:46:12Z","updated_at":"2015-08-06T03:04:21Z","pushed_at":"2015-08-06T20:19:12Z","git_url":"git://github.com/VoltDB/voltdb.git","ssh_url":"git@github.com:VoltDB/voltdb.git","clone_url":"https://github.com/VoltDB/voltdb.git","svn_url":"https://github.com/VoltDB/voltdb","homepage":"http://community.voltdb.com/","size":736574,"stargazers_count":608,"watchers_count":608,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":180,"mirror_url":null,"open_issues_count":31,"forks":180,"open_issues":31,"watchers":608,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2665"},"html":{"href":"https://github.com/VoltDB/voltdb/pull/2665"},"issue":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/2665"},"comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/issues/2665/comments"},"review_comments":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2665/comments"},"review_comment":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VoltDB/voltdb/pulls/2665/commits"},"statuses":{"href":"https://api.github.com/repos/VoltDB/voltdb/statuses/97af0488e11aedd248608cf4e9174fdc1a9a5daf"}}}}