{"action":"closed","issue":{"url":"https://api.github.com/repos/noflo/noflo-ui/issues/497","labels_url":"https://api.github.com/repos/noflo/noflo-ui/issues/497/labels{/name}","comments_url":"https://api.github.com/repos/noflo/noflo-ui/issues/497/comments","events_url":"https://api.github.com/repos/noflo/noflo-ui/issues/497/events","html_url":"https://github.com/noflo/noflo-ui/issues/497","id":104150277,"number":497,"title":"graph loading: don't add initial packets for ports with incoming connections","user":{"login":"chadrik","id":63251,"avatar_url":"https://avatars.githubusercontent.com/u/63251?v=3","gravatar_id":"","url":"https://api.github.com/users/chadrik","html_url":"https://github.com/chadrik","followers_url":"https://api.github.com/users/chadrik/followers","following_url":"https://api.github.com/users/chadrik/following{/other_user}","gists_url":"https://api.github.com/users/chadrik/gists{/gist_id}","starred_url":"https://api.github.com/users/chadrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadrik/subscriptions","organizations_url":"https://api.github.com/users/chadrik/orgs","repos_url":"https://api.github.com/users/chadrik/repos","events_url":"https://api.github.com/users/chadrik/events{/privacy}","received_events_url":"https://api.github.com/users/chadrik/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-31T22:59:15Z","updated_at":"2015-09-01T08:24:45Z","closed_at":"2015-09-01T08:24:45Z","body":"When loading an existing graph, noflo-ui issues a series of commands to the connected runtime that look like this:\r\n\r\n```\r\naddnode foo\r\naddnode bar\r\naddedge foo.out bar.in\r\naddinitial foo.in  \"x\"\r\naddinitial bar.in  \"y\"\r\n```\r\n\r\nThe problem is that `bar.in` already has an incoming connection, as created by the `addedge` command.  There might be some difference of opinion on this, but I think it should be an error to try to set an initial packet on a port with a connection without first disconnecting it.  I suppose that noflo runtimes are silently ignoring this situation, but as we work towards a more solid FBP protocol, I think it will be increasingly important that command sequences are explicit and purposeful.  In other words, I don't think it should be the runtime's responsibility to swallow nonsensical commands to make it easier on the UI (unless I'm missing something and there is a valid reason to have both an input and an initial packet).  \r\n\r\nWhat do you all think about tweaking noflo-ui to skip `addinitial` commands for ports with incoming connections?\r\n\r\n"}}