{"action":"closed","number":108,"pull_request":{"url":"https://api.github.com/repos/facebook/esprima/pulls/108","id":32389125,"html_url":"https://github.com/facebook/esprima/pull/108","diff_url":"https://github.com/facebook/esprima/pull/108.diff","patch_url":"https://github.com/facebook/esprima/pull/108.patch","issue_url":"https://api.github.com/repos/facebook/esprima/issues/108","number":108,"state":"closed","locked":false,"title":"fix loc.end for JSXEmptyExpression","user":{"login":"jenseng","id":109489,"avatar_url":"https://avatars.githubusercontent.com/u/109489?v=3","gravatar_id":"","url":"https://api.github.com/users/jenseng","html_url":"https://github.com/jenseng","followers_url":"https://api.github.com/users/jenseng/followers","following_url":"https://api.github.com/users/jenseng/following{/other_user}","gists_url":"https://api.github.com/users/jenseng/gists{/gist_id}","starred_url":"https://api.github.com/users/jenseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenseng/subscriptions","organizations_url":"https://api.github.com/users/jenseng/orgs","repos_url":"https://api.github.com/users/jenseng/repos","events_url":"https://api.github.com/users/jenseng/events{/privacy}","received_events_url":"https://api.github.com/users/jenseng/received_events","type":"User","site_admin":false},"body":"ensure that it correctly handles line terminators, whether part of the\r\nempty expression, or block comment inside it.\r\n\r\nthis is particularly important for recast or other tools that care about\r\ncomments inside jsx expressions. recast in particular will error out if\r\nthere is a loc mismatch between the comment and its corresponding node.\r\nsee https://github.com/benjamn/recast/issues/175 for more context.\r\n\r\nthe AST for the newly added tests differs only in its JSXEmptyExpression\r\nloc.end data when run against the old code:\r\n\r\n```\r\n1058c1058\r\n<                             end: { line: 1, column: 6 }\r\n---\r\n>                             end: { line: 2, column: 1 }\r\n1194c1194\r\n<                             end: { line: 1, column: 38 }\r\n---\r\n>                             end: { line: 5, column: 11 }\r\n```","created_at":"2015-04-01T04:48:03Z","updated_at":"2015-04-02T21:33:33Z","closed_at":"2015-04-02T21:33:33Z","merged_at":"2015-04-02T21:33:33Z","merge_commit_sha":"a04abb7f198ee4a9ee65aec6dc081a6d7c8f3d68","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/esprima/pulls/108/commits","review_comments_url":"https://api.github.com/repos/facebook/esprima/pulls/108/comments","review_comment_url":"https://api.github.com/repos/facebook/esprima/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/esprima/issues/108/comments","statuses_url":"https://api.github.com/repos/facebook/esprima/statuses/1e7e6731393d47014ba8d495790fdf59574abec4","head":{"label":"jenseng:newlines-in-empty-expressions","ref":"newlines-in-empty-expressions","sha":"1e7e6731393d47014ba8d495790fdf59574abec4","user":{"login":"jenseng","id":109489,"avatar_url":"https://avatars.githubusercontent.com/u/109489?v=3","gravatar_id":"","url":"https://api.github.com/users/jenseng","html_url":"https://github.com/jenseng","followers_url":"https://api.github.com/users/jenseng/followers","following_url":"https://api.github.com/users/jenseng/following{/other_user}","gists_url":"https://api.github.com/users/jenseng/gists{/gist_id}","starred_url":"https://api.github.com/users/jenseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenseng/subscriptions","organizations_url":"https://api.github.com/users/jenseng/orgs","repos_url":"https://api.github.com/users/jenseng/repos","events_url":"https://api.github.com/users/jenseng/events{/privacy}","received_events_url":"https://api.github.com/users/jenseng/received_events","type":"User","site_admin":false},"repo":{"id":33227152,"name":"esprima","full_name":"jenseng/esprima","owner":{"login":"jenseng","id":109489,"avatar_url":"https://avatars.githubusercontent.com/u/109489?v=3","gravatar_id":"","url":"https://api.github.com/users/jenseng","html_url":"https://github.com/jenseng","followers_url":"https://api.github.com/users/jenseng/followers","following_url":"https://api.github.com/users/jenseng/following{/other_user}","gists_url":"https://api.github.com/users/jenseng/gists{/gist_id}","starred_url":"https://api.github.com/users/jenseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenseng/subscriptions","organizations_url":"https://api.github.com/users/jenseng/orgs","repos_url":"https://api.github.com/users/jenseng/repos","events_url":"https://api.github.com/users/jenseng/events{/privacy}","received_events_url":"https://api.github.com/users/jenseng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jenseng/esprima","description":"ECMAScript parsing infrastructure for multipurpose analysis","fork":true,"url":"https://api.github.com/repos/jenseng/esprima","forks_url":"https://api.github.com/repos/jenseng/esprima/forks","keys_url":"https://api.github.com/repos/jenseng/esprima/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenseng/esprima/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenseng/esprima/teams","hooks_url":"https://api.github.com/repos/jenseng/esprima/hooks","issue_events_url":"https://api.github.com/repos/jenseng/esprima/issues/events{/number}","events_url":"https://api.github.com/repos/jenseng/esprima/events","assignees_url":"https://api.github.com/repos/jenseng/esprima/assignees{/user}","branches_url":"https://api.github.com/repos/jenseng/esprima/branches{/branch}","tags_url":"https://api.github.com/repos/jenseng/esprima/tags","blobs_url":"https://api.github.com/repos/jenseng/esprima/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenseng/esprima/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenseng/esprima/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenseng/esprima/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenseng/esprima/statuses/{sha}","languages_url":"https://api.github.com/repos/jenseng/esprima/languages","stargazers_url":"https://api.github.com/repos/jenseng/esprima/stargazers","contributors_url":"https://api.github.com/repos/jenseng/esprima/contributors","subscribers_url":"https://api.github.com/repos/jenseng/esprima/subscribers","subscription_url":"https://api.github.com/repos/jenseng/esprima/subscription","commits_url":"https://api.github.com/repos/jenseng/esprima/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenseng/esprima/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenseng/esprima/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenseng/esprima/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenseng/esprima/contents/{+path}","compare_url":"https://api.github.com/repos/jenseng/esprima/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenseng/esprima/merges","archive_url":"https://api.github.com/repos/jenseng/esprima/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenseng/esprima/downloads","issues_url":"https://api.github.com/repos/jenseng/esprima/issues{/number}","pulls_url":"https://api.github.com/repos/jenseng/esprima/pulls{/number}","milestones_url":"https://api.github.com/repos/jenseng/esprima/milestones{/number}","notifications_url":"https://api.github.com/repos/jenseng/esprima/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenseng/esprima/labels{/name}","releases_url":"https://api.github.com/repos/jenseng/esprima/releases{/id}","created_at":"2015-04-01T04:45:41Z","updated_at":"2015-04-01T04:45:42Z","pushed_at":"2015-04-01T04:57:44Z","git_url":"git://github.com/jenseng/esprima.git","ssh_url":"git@github.com:jenseng/esprima.git","clone_url":"https://github.com/jenseng/esprima.git","svn_url":"https://github.com/jenseng/esprima","homepage":"http://esprima.org","size":38992,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"fb-harmony"}},"base":{"label":"facebook:fb-harmony","ref":"fb-harmony","sha":"7fff45ac9410a1da1f7c5fbc58de21f1d71c1617","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":7764559,"name":"esprima","full_name":"facebook/esprima","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/esprima","description":"ECMAScript parsing infrastructure for multipurpose analysis","fork":true,"url":"https://api.github.com/repos/facebook/esprima","forks_url":"https://api.github.com/repos/facebook/esprima/forks","keys_url":"https://api.github.com/repos/facebook/esprima/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/esprima/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/esprima/teams","hooks_url":"https://api.github.com/repos/facebook/esprima/hooks","issue_events_url":"https://api.github.com/repos/facebook/esprima/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/esprima/events","assignees_url":"https://api.github.com/repos/facebook/esprima/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/esprima/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/esprima/tags","blobs_url":"https://api.github.com/repos/facebook/esprima/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/esprima/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/esprima/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/esprima/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/esprima/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/esprima/languages","stargazers_url":"https://api.github.com/repos/facebook/esprima/stargazers","contributors_url":"https://api.github.com/repos/facebook/esprima/contributors","subscribers_url":"https://api.github.com/repos/facebook/esprima/subscribers","subscription_url":"https://api.github.com/repos/facebook/esprima/subscription","commits_url":"https://api.github.com/repos/facebook/esprima/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/esprima/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/esprima/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/esprima/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/esprima/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/esprima/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/esprima/merges","archive_url":"https://api.github.com/repos/facebook/esprima/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/esprima/downloads","issues_url":"https://api.github.com/repos/facebook/esprima/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/esprima/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/esprima/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/esprima/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/esprima/labels{/name}","releases_url":"https://api.github.com/repos/facebook/esprima/releases{/id}","created_at":"2013-01-23T00:27:38Z","updated_at":"2015-04-01T19:56:20Z","pushed_at":"2015-04-02T21:33:34Z","git_url":"git://github.com/facebook/esprima.git","ssh_url":"git@github.com:facebook/esprima.git","clone_url":"https://github.com/facebook/esprima.git","svn_url":"https://github.com/facebook/esprima","homepage":"http://esprima.org","size":38992,"stargazers_count":76,"watchers_count":76,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":42,"mirror_url":null,"open_issues_count":10,"forks":42,"open_issues":10,"watchers":76,"default_branch":"fb-harmony"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/esprima/pulls/108"},"html":{"href":"https://github.com/facebook/esprima/pull/108"},"issue":{"href":"https://api.github.com/repos/facebook/esprima/issues/108"},"comments":{"href":"https://api.github.com/repos/facebook/esprima/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/esprima/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/esprima/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/esprima/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/esprima/statuses/1e7e6731393d47014ba8d495790fdf59574abec4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"zpao","id":8445,"avatar_url":"https://avatars.githubusercontent.com/u/8445?v=3","gravatar_id":"","url":"https://api.github.com/users/zpao","html_url":"https://github.com/zpao","followers_url":"https://api.github.com/users/zpao/followers","following_url":"https://api.github.com/users/zpao/following{/other_user}","gists_url":"https://api.github.com/users/zpao/gists{/gist_id}","starred_url":"https://api.github.com/users/zpao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpao/subscriptions","organizations_url":"https://api.github.com/users/zpao/orgs","repos_url":"https://api.github.com/users/zpao/repos","events_url":"https://api.github.com/users/zpao/events{/privacy}","received_events_url":"https://api.github.com/users/zpao/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":152,"deletions":4,"changed_files":3}}