{"action":"created","issue":{"url":"https://api.github.com/repos/ckirkendall/enfocus/issues/104","labels_url":"https://api.github.com/repos/ckirkendall/enfocus/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/ckirkendall/enfocus/issues/104/comments","events_url":"https://api.github.com/repos/ckirkendall/enfocus/issues/104/events","html_url":"https://github.com/ckirkendall/enfocus/issues/104","id":111247303,"number":104,"title":"replace-vars broken in clojurescript 1.7.145","user":{"login":"nickweeds","id":2964197,"avatar_url":"https://avatars.githubusercontent.com/u/2964197?v=3","gravatar_id":"","url":"https://api.github.com/users/nickweeds","html_url":"https://github.com/nickweeds","followers_url":"https://api.github.com/users/nickweeds/followers","following_url":"https://api.github.com/users/nickweeds/following{/other_user}","gists_url":"https://api.github.com/users/nickweeds/gists{/gist_id}","starred_url":"https://api.github.com/users/nickweeds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickweeds/subscriptions","organizations_url":"https://api.github.com/users/nickweeds/orgs","repos_url":"https://api.github.com/users/nickweeds/repos","events_url":"https://api.github.com/users/nickweeds/events{/privacy}","received_events_url":"https://api.github.com/users/nickweeds/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-10-13T19:04:43Z","updated_at":"2015-12-13T12:41:12Z","closed_at":null,"body":"On updating my project to use enfocus with clojurecript 1.7.145 I found that all variables were replaced with the text \"null\".\r\n\r\nI believe that this is because clojurescript 1.7.145 has a non-back-compatible change to the string/replace function.  This change is described by clojurescript issue CLJS-1304.\r\n\r\nSee http://dev.clojure.org/jira/browse/CLJS-1304 for the issue description.\r\n\r\nSee https://github.com/clojure/clojurescript/blob/master/changes.md for the clojurescript change history (including CLJS-1304).\r\n\r\nSee https://github.com/clojure/clojurescript/commit/3e146905999f9b9ffb249e139e266f845c4af34c for the string/replace change.\r\n\r\nThe replace-vars function uses string/replace with a replacement function.  The problem can probably be fixed by changing the \"%2\" in the replacement function to \"(%1 1)\".\r\n\r\nUsers will need to be warned which enfocus versions work with which clojurescript versions."},"comment":{"url":"https://api.github.com/repos/ckirkendall/enfocus/issues/comments/164254754","html_url":"https://github.com/ckirkendall/enfocus/issues/104#issuecomment-164254754","issue_url":"https://api.github.com/repos/ckirkendall/enfocus/issues/104","id":164254754,"user":{"login":"nickweeds","id":2964197,"avatar_url":"https://avatars.githubusercontent.com/u/2964197?v=3","gravatar_id":"","url":"https://api.github.com/users/nickweeds","html_url":"https://github.com/nickweeds","followers_url":"https://api.github.com/users/nickweeds/followers","following_url":"https://api.github.com/users/nickweeds/following{/other_user}","gists_url":"https://api.github.com/users/nickweeds/gists{/gist_id}","starred_url":"https://api.github.com/users/nickweeds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickweeds/subscriptions","organizations_url":"https://api.github.com/users/nickweeds/orgs","repos_url":"https://api.github.com/users/nickweeds/repos","events_url":"https://api.github.com/users/nickweeds/events{/privacy}","received_events_url":"https://api.github.com/users/nickweeds/received_events","type":"User","site_admin":false},"created_at":"2015-12-13T12:41:12Z","updated_at":"2015-12-13T12:41:12Z","body":"I think this issue can be closed now.\r\n\r\nWould you push a fix release to clojars so that developers can easily use Enfocus replace-vars with ClojuresScript 1.7.145 and above ?"}}