{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/16013","labels_url":"https://api.github.com/repos/owncloud/core/issues/16013/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/16013/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/16013/events","html_url":"https://github.com/owncloud/core/issues/16013","id":72679959,"number":16013,"title":"Reconsider adding ob_end_clean() in remote.php for files app","user":{"login":"LukasReschke","id":878997,"avatar_url":"https://avatars.githubusercontent.com/u/878997?v=3","gravatar_id":"","url":"https://api.github.com/users/LukasReschke","html_url":"https://github.com/LukasReschke","followers_url":"https://api.github.com/users/LukasReschke/followers","following_url":"https://api.github.com/users/LukasReschke/following{/other_user}","gists_url":"https://api.github.com/users/LukasReschke/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasReschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasReschke/subscriptions","organizations_url":"https://api.github.com/users/LukasReschke/orgs","repos_url":"https://api.github.com/users/LukasReschke/repos","events_url":"https://api.github.com/users/LukasReschke/events{/privacy}","received_events_url":"https://api.github.com/users/LukasReschke/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/8.1%20Bugfixing%20Shortlist","name":"8.1 Bugfixing Shortlist","color":"009800"},{"url":"https://api.github.com/repos/owncloud/core/labels/discussion","name":"discussion","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/31","html_url":"https://github.com/owncloud/core/milestones/8.1-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/31/labels","id":912160,"number":31,"title":"8.1-current","description":"","creator":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"open_issues":174,"closed_issues":967,"state":"open","created_at":"2014-12-22T12:04:01Z","updated_at":"2015-05-04T12:18:23Z","due_on":"2015-04-02T22:00:00Z","closed_at":null},"comments":8,"created_at":"2015-05-02T18:28:29Z","updated_at":"2015-05-04T12:18:28Z","closed_at":null,"body":"@karlitschek has requested why we have an hard dependency on `output_buffering` set to `off` with ownCloud 8.1 – thus I investigated it a little bit.\r\n\r\nThis check has been introduced since [our documentation](https://doc.owncloud.org/server/7.0/admin_manual/configuration/big_file_upload_configuration.html#configuring-php), the [SabreDAV documentation](http://sabre.io/dav/large-files/) as well as @evert in https://github.com/fruux/sabre-dav/pull/331#issuecomment-16945953 claim that `output_buffering` should be disabled, without this PHP will return memory-related errors and we might effectively risk data loss or integrity loss issues. \r\n\r\nThis indeed makes sense to me but we should reconsider if there is another way to address this issue, I stumbled upon [`ob_end_flush`](http://php.net/manual/en/function.ob-end-flush.php) and [`ob_end_clean`](http://php.net/manual/en/function.ob-end-clean.php) which we could just add to our [remote.php file of the files app](https://github.com/owncloud/core/blob/6528a17ea3c1f3ef81c463f6c84edaddad29e967/apps/files/appinfo/remote.php).\r\n\r\nA little digging in our source showed me that @icewind1991 introduced this already once for stable45 in https://github.com/owncloud/core/pull/576 and it was indeed there until ownCloud 7 where @DeepDiver1975 removed it with https://github.com/owncloud/core/commit/79fc4f312604feb20f96378d052703ec4768ecad, the commit message states:\r\n\r\n> Within OC:init() the minimum set of apps is loaded - which is filesystem, authentication and logging\r\n\r\nThis looks rather unrelated. @DeepDiver1975 do you remind why you removed it? I suspect you assumed that it was removed by mistake since the code was undocumented?\r\n\r\ncc @evert I'd greatly appreciate if you can lend us your expertise once more on this. Just a short \"yes that should work\" or a \"kittens will die – don't try it\" would be a great guidance since you are obviously *the* SabreDAV expert :smile: \r\ncc @DeepDiver1975 @karlitschek "},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/98690447","html_url":"https://github.com/owncloud/core/issues/16013#issuecomment-98690447","issue_url":"https://api.github.com/repos/owncloud/core/issues/16013","id":98690447,"user":{"login":"LukasReschke","id":878997,"avatar_url":"https://avatars.githubusercontent.com/u/878997?v=3","gravatar_id":"","url":"https://api.github.com/users/LukasReschke","html_url":"https://github.com/LukasReschke","followers_url":"https://api.github.com/users/LukasReschke/followers","following_url":"https://api.github.com/users/LukasReschke/following{/other_user}","gists_url":"https://api.github.com/users/LukasReschke/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasReschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasReschke/subscriptions","organizations_url":"https://api.github.com/users/LukasReschke/orgs","repos_url":"https://api.github.com/users/LukasReschke/repos","events_url":"https://api.github.com/users/LukasReschke/events{/privacy}","received_events_url":"https://api.github.com/users/LukasReschke/received_events","type":"User","site_admin":false},"created_at":"2015-05-04T12:18:28Z","updated_at":"2015-05-04T12:18:28Z","body":"Let's re-add this then and remove the check for now and hope it doesn't bite us at other places were we handle files stuff => https://github.com/owncloud/core/pull/16042"}}