{"action":"created","comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/27850548","id":27850548,"diff_hunk":"@@ -354,6 +354,18 @@ if __name__ == '__main__':\n     args.append('-Dnotifications=1')\n     args.append('-Drelease_unwind_tables=0')\n \n+  parameter = '-Dverify_xwalk_apk='","path":"gyp_xwalk","position":4,"original_position":4,"commit_id":"9ff62f7bb80658f24c6b41fe1d85bd9965099704","original_commit_id":"9f9ebdd284cb0e25beef3068447fcf2c4bfe2aa1","user":{"login":"lincsoon","id":1285835,"avatar_url":"https://avatars.githubusercontent.com/u/1285835?v=3","gravatar_id":"","url":"https://api.github.com/users/lincsoon","html_url":"https://github.com/lincsoon","followers_url":"https://api.github.com/users/lincsoon/followers","following_url":"https://api.github.com/users/lincsoon/following{/other_user}","gists_url":"https://api.github.com/users/lincsoon/gists{/gist_id}","starred_url":"https://api.github.com/users/lincsoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lincsoon/subscriptions","organizations_url":"https://api.github.com/users/lincsoon/orgs","repos_url":"https://api.github.com/users/lincsoon/repos","events_url":"https://api.github.com/users/lincsoon/events{/privacy}","received_events_url":"https://api.github.com/users/lincsoon/received_events","type":"User","site_admin":false},"body":"I agree that this should not be related to Debug vs Release. As you said that \"set this in build/common.gypi instead like a regular variable\", do you mean the users have to modify the parameter in common.gypi if they want to enable APK verification?","created_at":"2015-04-07T04:13:46Z","updated_at":"2015-04-07T04:13:46Z","html_url":"https://github.com/crosswalk-project/crosswalk/pull/2944#discussion_r27850548","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2944","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/27850548"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/2944#discussion_r27850548"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2944"}}},"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2944","id":32216579,"html_url":"https://github.com/crosswalk-project/crosswalk/pull/2944","diff_url":"https://github.com/crosswalk-project/crosswalk/pull/2944.diff","patch_url":"https://github.com/crosswalk-project/crosswalk/pull/2944.patch","issue_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2944","number":2944,"state":"open","locked":false,"title":"[Android] Security check for shared mode","user":{"login":"lincsoon","id":1285835,"avatar_url":"https://avatars.githubusercontent.com/u/1285835?v=3","gravatar_id":"","url":"https://api.github.com/users/lincsoon","html_url":"https://github.com/lincsoon","followers_url":"https://api.github.com/users/lincsoon/followers","following_url":"https://api.github.com/users/lincsoon/following{/other_user}","gists_url":"https://api.github.com/users/lincsoon/gists{/gist_id}","starred_url":"https://api.github.com/users/lincsoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lincsoon/subscriptions","organizations_url":"https://api.github.com/users/lincsoon/orgs","repos_url":"https://api.github.com/users/lincsoon/repos","events_url":"https://api.github.com/users/lincsoon/events{/privacy}","received_events_url":"https://api.github.com/users/lincsoon/received_events","type":"User","site_admin":false},"body":"Before the app loading Crosswalk library on device, it is necessary\r\nto make sure the library APK is not tampered and is exactly the one\r\nwe published.\r\n\r\nThe officially released library APK is signed with the signing key\r\nfrom codesign.intel.com. The foundation of this approach is that the\r\npackage manager is trustworthy and the fingerprinting algorithm is\r\nnot broken.\r\n\r\nThe verification process are:\r\n1. Get signatures of Crosswalk library via package manager\r\n2. Generate SHA1 fingerprint by the signature\r\n3. Check against the fingerprint from codesign.intel.com\r\n\r\nBUG=XWALK-3804","created_at":"2015-03-30T11:07:13Z","updated_at":"2015-04-07T04:13:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78c043fecd136a1f85a22f707648ff4facbcc1ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2944/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2944/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2944/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/9ff62f7bb80658f24c6b41fe1d85bd9965099704","head":{"label":"lincsoon:feature-3804-security_check","ref":"feature-3804-security_check","sha":"9ff62f7bb80658f24c6b41fe1d85bd9965099704","user":{"login":"lincsoon","id":1285835,"avatar_url":"https://avatars.githubusercontent.com/u/1285835?v=3","gravatar_id":"","url":"https://api.github.com/users/lincsoon","html_url":"https://github.com/lincsoon","followers_url":"https://api.github.com/users/lincsoon/followers","following_url":"https://api.github.com/users/lincsoon/following{/other_user}","gists_url":"https://api.github.com/users/lincsoon/gists{/gist_id}","starred_url":"https://api.github.com/users/lincsoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lincsoon/subscriptions","organizations_url":"https://api.github.com/users/lincsoon/orgs","repos_url":"https://api.github.com/users/lincsoon/repos","events_url":"https://api.github.com/users/lincsoon/events{/privacy}","received_events_url":"https://api.github.com/users/lincsoon/received_events","type":"User","site_admin":false},"repo":{"id":22664891,"name":"crosswalk","full_name":"lincsoon/crosswalk","owner":{"login":"lincsoon","id":1285835,"avatar_url":"https://avatars.githubusercontent.com/u/1285835?v=3","gravatar_id":"","url":"https://api.github.com/users/lincsoon","html_url":"https://github.com/lincsoon","followers_url":"https://api.github.com/users/lincsoon/followers","following_url":"https://api.github.com/users/lincsoon/following{/other_user}","gists_url":"https://api.github.com/users/lincsoon/gists{/gist_id}","starred_url":"https://api.github.com/users/lincsoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lincsoon/subscriptions","organizations_url":"https://api.github.com/users/lincsoon/orgs","repos_url":"https://api.github.com/users/lincsoon/repos","events_url":"https://api.github.com/users/lincsoon/events{/privacy}","received_events_url":"https://api.github.com/users/lincsoon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lincsoon/crosswalk","description":"","fork":true,"url":"https://api.github.com/repos/lincsoon/crosswalk","forks_url":"https://api.github.com/repos/lincsoon/crosswalk/forks","keys_url":"https://api.github.com/repos/lincsoon/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lincsoon/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lincsoon/crosswalk/teams","hooks_url":"https://api.github.com/repos/lincsoon/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/lincsoon/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/lincsoon/crosswalk/events","assignees_url":"https://api.github.com/repos/lincsoon/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/lincsoon/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/lincsoon/crosswalk/tags","blobs_url":"https://api.github.com/repos/lincsoon/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lincsoon/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lincsoon/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/lincsoon/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lincsoon/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/lincsoon/crosswalk/languages","stargazers_url":"https://api.github.com/repos/lincsoon/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/lincsoon/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/lincsoon/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/lincsoon/crosswalk/subscription","commits_url":"https://api.github.com/repos/lincsoon/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/lincsoon/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/lincsoon/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/lincsoon/crosswalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/lincsoon/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/lincsoon/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lincsoon/crosswalk/merges","archive_url":"https://api.github.com/repos/lincsoon/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lincsoon/crosswalk/downloads","issues_url":"https://api.github.com/repos/lincsoon/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/lincsoon/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/lincsoon/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/lincsoon/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lincsoon/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/lincsoon/crosswalk/releases{/id}","created_at":"2014-08-06T01:04:55Z","updated_at":"2015-04-03T06:11:49Z","pushed_at":"2015-04-07T04:08:44Z","git_url":"git://github.com/lincsoon/crosswalk.git","ssh_url":"git@github.com:lincsoon/crosswalk.git","clone_url":"https://github.com/lincsoon/crosswalk.git","svn_url":"https://github.com/lincsoon/crosswalk","homepage":"https://crosswalk-project.org/","size":12852,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crosswalk-project:master","ref":"master","sha":"3eec718bf90c937a693dc185038f2c75f8e4cdf8","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":9207280,"name":"crosswalk","full_name":"crosswalk-project/crosswalk","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/crosswalk","description":"","fork":false,"url":"https://api.github.com/repos/crosswalk-project/crosswalk","forks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/forks","keys_url":"https://api.github.com/repos/crosswalk-project/crosswalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/crosswalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/crosswalk/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/crosswalk/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/crosswalk/events","assignees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/crosswalk/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/crosswalk/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/crosswalk/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/crosswalk-project/crosswalk/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/crosswalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/crosswalk/merges","archive_url":"https://api.github.com/repos/crosswalk-project/crosswalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/crosswalk/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/crosswalk/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/crosswalk/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/crosswalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/crosswalk/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/crosswalk/releases{/id}","created_at":"2013-04-03T23:30:12Z","updated_at":"2015-04-03T20:44:55Z","pushed_at":"2015-04-07T04:08:45Z","git_url":"git://github.com/crosswalk-project/crosswalk.git","ssh_url":"git@github.com:crosswalk-project/crosswalk.git","clone_url":"https://github.com/crosswalk-project/crosswalk.git","svn_url":"https://github.com/crosswalk-project/crosswalk","homepage":"https://crosswalk-project.org/","size":136445,"stargazers_count":721,"watchers_count":721,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":226,"mirror_url":null,"open_issues_count":117,"forks":226,"open_issues":117,"watchers":721,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2944"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/2944"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2944"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/issues/2944/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2944/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/2944/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/statuses/9ff62f7bb80658f24c6b41fe1d85bd9965099704"}}}}