{"action":"created","issue":{"url":"https://api.github.com/repos/request/request/issues/1346","labels_url":"https://api.github.com/repos/request/request/issues/1346/labels{/name}","comments_url":"https://api.github.com/repos/request/request/issues/1346/comments","events_url":"https://api.github.com/repos/request/request/issues/1346/events","html_url":"https://github.com/request/request/pull/1346","id":53830705,"number":1346,"title":"getProxyFromURI Extraction Refactor","user":{"login":"seanstrom","id":2845768,"avatar_url":"https://avatars.githubusercontent.com/u/2845768?v=3","gravatar_id":"","url":"https://api.github.com/users/seanstrom","html_url":"https://github.com/seanstrom","followers_url":"https://api.github.com/users/seanstrom/followers","following_url":"https://api.github.com/users/seanstrom/following{/other_user}","gists_url":"https://api.github.com/users/seanstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/seanstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanstrom/subscriptions","organizations_url":"https://api.github.com/users/seanstrom/orgs","repos_url":"https://api.github.com/users/seanstrom/repos","events_url":"https://api.github.com/users/seanstrom/events{/privacy}","received_events_url":"https://api.github.com/users/seanstrom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-09T03:40:34Z","updated_at":"2015-01-09T16:55:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/request/request/pulls/1346","html_url":"https://github.com/request/request/pull/1346","diff_url":"https://github.com/request/request/pull/1346.diff","patch_url":"https://github.com/request/request/pull/1346.patch"},"body":"The getProxyFromURI function seems like a good candidate to remove from the\r\nrequest.js file. That file is bloated and this fits well as a module.\r\n\r\nThis is still in need of a few more changes, but I figured people can start reviewing.\r\n\r\n@simov @FredKSchott @nylen review?"},"comment":{"url":"https://api.github.com/repos/request/request/issues/comments/69362784","html_url":"https://github.com/request/request/pull/1346#issuecomment-69362784","issue_url":"https://api.github.com/repos/request/request/issues/1346","id":69362784,"user":{"login":"nylen","id":227022,"avatar_url":"https://avatars.githubusercontent.com/u/227022?v=3","gravatar_id":"","url":"https://api.github.com/users/nylen","html_url":"https://github.com/nylen","followers_url":"https://api.github.com/users/nylen/followers","following_url":"https://api.github.com/users/nylen/following{/other_user}","gists_url":"https://api.github.com/users/nylen/gists{/gist_id}","starred_url":"https://api.github.com/users/nylen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylen/subscriptions","organizations_url":"https://api.github.com/users/nylen/orgs","repos_url":"https://api.github.com/users/nylen/repos","events_url":"https://api.github.com/users/nylen/events{/privacy}","received_events_url":"https://api.github.com/users/nylen/received_events","type":"User","site_admin":false},"created_at":"2015-01-09T16:55:41Z","updated_at":"2015-01-09T16:55:41Z","body":"I like the concept, but I agree with Fred, just use `if` statements instead of `shortCircuit`.\r\n\r\nI'm also not sold on the amount of functional decomposition going on for relatively simple operations that are only done once - can you explain why you took this approach, and maybe we can find a better balance between the current code and the proposed changes.\r\n\r\nI'd probably like to see some more tests of the proxy behavior before we undertake this.  I'll add that to a PR I'm working on which should be ready early next week."}}