{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/comments/23316494","id":23316494,"diff_hunk":"@@ -212,6 +212,27 @@\n                   />\n                     <ServiceControl Id=\"ServiceControlOptionsDisabled\" Stop=\"both\" Remove=\"uninstall\" Name=\"$(var.PuppetServiceName)\" Wait=\"yes\" />\n                   </Component>\n+                  <Component Id='MCOService' Guid=\"7601FCEA-90B3-CC69-6A69-4087FBC7292D\" Win64=\"$(var.Win64)\">\n+                    <File Id=\"RubyWExe\" KeyPath=\"yes\" Source=\"stagedir\\sys\\ruby\\bin\\rubyw.exe\" />\n+                    <!-- This service is installed with start set to demand because\n+                    it won't be correctly configured to start right away. The\n+                    puppet run that configures mcollective will allow it to start\n+                    and set it to automatic -->\n+                    <ServiceInstall Id=\"MCOServiceInstaller\"\n+                      Account=\"[PUPPET_AGENT_ACCOUNT_DOMAIN]\\[PUPPET_AGENT_ACCOUNT_USER]\"\n+                      Password=\"[PUPPET_AGENT_ACCOUNT_PASSWORD]\"\n+                      Description=\"Puppet Labs server orchestration framework\"\n+                      DisplayName=\"Marionette Collective Server\"\n+                      Interactive=\"no\"\n+                      Name=\"mcollective\"\n+                      Start=\"demand\"\n+                      Type=\"ownProcess\"\n+                      ErrorControl=\"normal\"\n+                      Vital=\"yes\" \n+                      Arguments=\"-I&quot;[INSTALLDIR]puppet\\lib;[INSTALLDIR]facter\\lib;[INSTALLDIR]hiera\\lib;[INSTALLDIR]mcollective\\lib;[INSTALLDIR]mcollective_plugins&quot; -rubygems &quot;[INSTALLDIR]mcollective\\bin\\mcollectived&quot; --daemonize\"","path":"wix/puppet.wxs","position":21,"original_position":21,"commit_id":"ee781c1522a1be4b1cf1d2d49256ba90530c34fb","original_commit_id":"ee781c1522a1be4b1cf1d2d49256ba90530c34fb","user":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars.githubusercontent.com/u/394081?v=3","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"body":"For reference, the original `daemon.bat` this replaces looks like:\r\n\r\n```batch\r\n@echo off\r\nSETLOCAL\r\n\r\ncall \"%~dp0..\\bin\\environment.bat\" %0 %*\r\n\r\nrubyw -rubygems \"%MCOLLECTIVE_DIR%\\bin\\mcollectived\" %*\r\n```\r\n\r\nAnd the original `environment.bat` looks like:\r\n\r\n```batch\r\nSET BASEDIR=%~dp0..\r\nSET BASEDIR=%BASEDIR:\\bin\\..=%\r\n\r\nSET SERVER_CONFIG=%BASEDIR%\\etc\\server.cfg\r\nSET CLIENT_CONFIG=%BASEDIR%\\etc\\client.cfg\r\n\r\nSET MCOLLECTIVED=%BASEDIR%\\bin\\mcollectived\r\nSET MC_STARTTYPE=manual\r\nREM SET MC_STARTTYPE=auto\r\n\r\nSET PATH=%BASEDIR%\\bin;%PATH%\r\n\r\nSET RUBYLIB=%BASEDIR%\\lib;%RUBYLIB%\r\nSET RUBYLIB=%RUBYLIB:\\=/%\r\n\r\nSET RUBY=\"ruby\"\r\n```","created_at":"2015-01-21T17:22:50Z","updated_at":"2015-01-21T17:22:50Z","html_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/87#discussion_r23316494","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/comments/23316494"},"html":{"href":"https://github.com/puppetlabs/puppet_for_the_win/pull/87#discussion_r23316494"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/87","id":27713171,"html_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/87","diff_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/87.diff","patch_url":"https://github.com/puppetlabs/puppet_for_the_win/pull/87.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/87","number":87,"state":"open","locked":false,"title":"[DO NOT MERGE] (MCO-548) Discontinue use of MCO daemon.bat","user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=3","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"body":"Currently when mcollective runs as a service on Windows, it executes a\r\nbatch script in a cmd.exe process. This adds a layer of unnecessary\r\ncomplexity when we could call our vendored rubyw directly with the\r\nnecessary arguments for the service to run.\r\n\r\nThis switches over to using rubyw.exe directly and updates filters.xslt\r\nto exclude rubyw.","created_at":"2015-01-20T21:19:29Z","updated_at":"2015-01-21T17:22:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7292eb2c66e18f90eb03293ad610310809427c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/87/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/87/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/87/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/statuses/ee781c1522a1be4b1cf1d2d49256ba90530c34fb","head":{"label":"ferventcoder:ticket/master/MCO-548-no-daemon.bat","ref":"ticket/master/MCO-548-no-daemon.bat","sha":"ee781c1522a1be4b1cf1d2d49256ba90530c34fb","user":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=3","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"repo":{"id":11299979,"name":"puppet_for_the_win","full_name":"ferventcoder/puppet_for_the_win","owner":{"login":"ferventcoder","id":63502,"avatar_url":"https://avatars.githubusercontent.com/u/63502?v=3","gravatar_id":"","url":"https://api.github.com/users/ferventcoder","html_url":"https://github.com/ferventcoder","followers_url":"https://api.github.com/users/ferventcoder/followers","following_url":"https://api.github.com/users/ferventcoder/following{/other_user}","gists_url":"https://api.github.com/users/ferventcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/ferventcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferventcoder/subscriptions","organizations_url":"https://api.github.com/users/ferventcoder/orgs","repos_url":"https://api.github.com/users/ferventcoder/repos","events_url":"https://api.github.com/users/ferventcoder/events{/privacy}","received_events_url":"https://api.github.com/users/ferventcoder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferventcoder/puppet_for_the_win","description":"Rake tasks to automatically build Puppet Windows MSI Packages","fork":true,"url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win","forks_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/forks","keys_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/teams","hooks_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/hooks","issue_events_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/issues/events{/number}","events_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/events","assignees_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/assignees{/user}","branches_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/branches{/branch}","tags_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/tags","blobs_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/statuses/{sha}","languages_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/languages","stargazers_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/stargazers","contributors_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/contributors","subscribers_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/subscribers","subscription_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/subscription","commits_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/issues/comments/{number}","contents_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/contents/{+path}","compare_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/merges","archive_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/downloads","issues_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/issues{/number}","pulls_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/pulls{/number}","milestones_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/milestones{/number}","notifications_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/labels{/name}","releases_url":"https://api.github.com/repos/ferventcoder/puppet_for_the_win/releases{/id}","created_at":"2013-07-10T02:31:58Z","updated_at":"2015-01-15T23:56:36Z","pushed_at":"2015-01-20T21:19:11Z","git_url":"git://github.com/ferventcoder/puppet_for_the_win.git","ssh_url":"git@github.com:ferventcoder/puppet_for_the_win.git","clone_url":"https://github.com/ferventcoder/puppet_for_the_win.git","svn_url":"https://github.com/ferventcoder/puppet_for_the_win","homepage":"http://puppetlabs.com","size":921,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"898b097a97f6cd72d59290253867ec8002fd7d38","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":3166814,"name":"puppet_for_the_win","full_name":"puppetlabs/puppet_for_the_win","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet_for_the_win","description":"Rake tasks to automatically build Puppet Windows MSI Packages","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win","forks_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/releases{/id}","created_at":"2012-01-12T23:13:50Z","updated_at":"2015-01-20T19:04:26Z","pushed_at":"2015-01-20T19:04:26Z","git_url":"git://github.com/puppetlabs/puppet_for_the_win.git","ssh_url":"git@github.com:puppetlabs/puppet_for_the_win.git","clone_url":"https://github.com/puppetlabs/puppet_for_the_win.git","svn_url":"https://github.com/puppetlabs/puppet_for_the_win","homepage":"http://puppetlabs.com","size":1492,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":4,"forks":15,"open_issues":4,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/87"},"html":{"href":"https://github.com/puppetlabs/puppet_for_the_win/pull/87"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/87"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet_for_the_win/statuses/ee781c1522a1be4b1cf1d2d49256ba90530c34fb"}}}}