{"action":"created","comment":{"url":"https://api.github.com/repos/PolicyStat/combokeys/pulls/comments/27315933","id":27315933,"diff_hunk":"@@ -184,15 +184,26 @@ describe('combokeys.bind', function () {\n       var combokeys = new Combokeys(element)\n       combokeys.bind('command+s', spy)\n \n+      if (Event.prototype.preventDefault) {\n+        var preventDefaultSpy = sinon.spy(Event.prototype, 'preventDefault')\n+      }\n+      if (Event.prototype.stopPropagation) {\n+        var stopPropagationSpy = sinon.spy(Event.prototype, 'stopPropagation')\n+      }\n       KeyEvent.simulate('S'.charCodeAt(0), 83, ['meta'], element)\n \n       assert.strictEqual(spy.callCount, 1, 'callback should fire')\n       assert.instanceOf(spy.args[0][0], Event, 'first argument should be Event')\n       var event = spy.args[0][0]\n       if (event.preventDefault) {\n-        assert.isTrue(event.defaultPrevented)\n+        assert.isTrue(preventDefaultSpy.calledOnce, 'default action was cancelled')","path":"test/test.combokeys.js","position":17,"original_position":17,"commit_id":"24a57d4821a1793b9a29787cf22aec131b2d3f61","original_commit_id":"24a57d4821a1793b9a29787cf22aec131b2d3f61","user":{"login":"mightyiam","id":635591,"avatar_url":"https://avatars.githubusercontent.com/u/635591?v=3","gravatar_id":"","url":"https://api.github.com/users/mightyiam","html_url":"https://github.com/mightyiam","followers_url":"https://api.github.com/users/mightyiam/followers","following_url":"https://api.github.com/users/mightyiam/following{/other_user}","gists_url":"https://api.github.com/users/mightyiam/gists{/gist_id}","starred_url":"https://api.github.com/users/mightyiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mightyiam/subscriptions","organizations_url":"https://api.github.com/users/mightyiam/orgs","repos_url":"https://api.github.com/users/mightyiam/repos","events_url":"https://api.github.com/users/mightyiam/events{/privacy}","received_events_url":"https://api.github.com/users/mightyiam/received_events","type":"User","site_admin":false},"body":"So we use a spy, for modern IE.","created_at":"2015-03-27T17:49:17Z","updated_at":"2015-03-27T17:49:17Z","html_url":"https://github.com/PolicyStat/combokeys/pull/39#discussion_r27315933","pull_request_url":"https://api.github.com/repos/PolicyStat/combokeys/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/PolicyStat/combokeys/pulls/comments/27315933"},"html":{"href":"https://github.com/PolicyStat/combokeys/pull/39#discussion_r27315933"},"pull_request":{"href":"https://api.github.com/repos/PolicyStat/combokeys/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/PolicyStat/combokeys/pulls/39","id":32128908,"html_url":"https://github.com/PolicyStat/combokeys/pull/39","diff_url":"https://github.com/PolicyStat/combokeys/pull/39.diff","patch_url":"https://github.com/PolicyStat/combokeys/pull/39.patch","issue_url":"https://api.github.com/repos/PolicyStat/combokeys/issues/39","number":39,"state":"open","locked":false,"title":"Fix 'return false' tests","user":{"login":"mightyiam","id":635591,"avatar_url":"https://avatars.githubusercontent.com/u/635591?v=3","gravatar_id":"","url":"https://api.github.com/users/mightyiam","html_url":"https://github.com/mightyiam","followers_url":"https://api.github.com/users/mightyiam/followers","following_url":"https://api.github.com/users/mightyiam/following{/other_user}","gists_url":"https://api.github.com/users/mightyiam/gists{/gist_id}","starred_url":"https://api.github.com/users/mightyiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mightyiam/subscriptions","organizations_url":"https://api.github.com/users/mightyiam/orgs","repos_url":"https://api.github.com/users/mightyiam/repos","events_url":"https://api.github.com/users/mightyiam/events{/privacy}","received_events_url":"https://api.github.com/users/mightyiam/received_events","type":"User","site_admin":false},"body":null,"created_at":"2015-03-27T17:40:14Z","updated_at":"2015-03-27T17:49:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47460f9b892bb7a5e711a64378e810a33ef71e44","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PolicyStat/combokeys/pulls/39/commits","review_comments_url":"https://api.github.com/repos/PolicyStat/combokeys/pulls/39/comments","review_comment_url":"https://api.github.com/repos/PolicyStat/combokeys/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolicyStat/combokeys/issues/39/comments","statuses_url":"https://api.github.com/repos/PolicyStat/combokeys/statuses/24a57d4821a1793b9a29787cf22aec131b2d3f61","head":{"label":"PolicyStat:fix-unit-test-prevent-default-and-stop-propagation","ref":"fix-unit-test-prevent-default-and-stop-propagation","sha":"24a57d4821a1793b9a29787cf22aec131b2d3f61","user":{"login":"PolicyStat","id":149499,"avatar_url":"https://avatars.githubusercontent.com/u/149499?v=3","gravatar_id":"","url":"https://api.github.com/users/PolicyStat","html_url":"https://github.com/PolicyStat","followers_url":"https://api.github.com/users/PolicyStat/followers","following_url":"https://api.github.com/users/PolicyStat/following{/other_user}","gists_url":"https://api.github.com/users/PolicyStat/gists{/gist_id}","starred_url":"https://api.github.com/users/PolicyStat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolicyStat/subscriptions","organizations_url":"https://api.github.com/users/PolicyStat/orgs","repos_url":"https://api.github.com/users/PolicyStat/repos","events_url":"https://api.github.com/users/PolicyStat/events{/privacy}","received_events_url":"https://api.github.com/users/PolicyStat/received_events","type":"Organization","site_admin":false},"repo":{"id":26683992,"name":"combokeys","full_name":"PolicyStat/combokeys","owner":{"login":"PolicyStat","id":149499,"avatar_url":"https://avatars.githubusercontent.com/u/149499?v=3","gravatar_id":"","url":"https://api.github.com/users/PolicyStat","html_url":"https://github.com/PolicyStat","followers_url":"https://api.github.com/users/PolicyStat/followers","following_url":"https://api.github.com/users/PolicyStat/following{/other_user}","gists_url":"https://api.github.com/users/PolicyStat/gists{/gist_id}","starred_url":"https://api.github.com/users/PolicyStat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolicyStat/subscriptions","organizations_url":"https://api.github.com/users/PolicyStat/orgs","repos_url":"https://api.github.com/users/PolicyStat/repos","events_url":"https://api.github.com/users/PolicyStat/events{/privacy}","received_events_url":"https://api.github.com/users/PolicyStat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolicyStat/combokeys","description":"Web browser keyboard shortcuts. CommonJS, NPM.","fork":false,"url":"https://api.github.com/repos/PolicyStat/combokeys","forks_url":"https://api.github.com/repos/PolicyStat/combokeys/forks","keys_url":"https://api.github.com/repos/PolicyStat/combokeys/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolicyStat/combokeys/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolicyStat/combokeys/teams","hooks_url":"https://api.github.com/repos/PolicyStat/combokeys/hooks","issue_events_url":"https://api.github.com/repos/PolicyStat/combokeys/issues/events{/number}","events_url":"https://api.github.com/repos/PolicyStat/combokeys/events","assignees_url":"https://api.github.com/repos/PolicyStat/combokeys/assignees{/user}","branches_url":"https://api.github.com/repos/PolicyStat/combokeys/branches{/branch}","tags_url":"https://api.github.com/repos/PolicyStat/combokeys/tags","blobs_url":"https://api.github.com/repos/PolicyStat/combokeys/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolicyStat/combokeys/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolicyStat/combokeys/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolicyStat/combokeys/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolicyStat/combokeys/statuses/{sha}","languages_url":"https://api.github.com/repos/PolicyStat/combokeys/languages","stargazers_url":"https://api.github.com/repos/PolicyStat/combokeys/stargazers","contributors_url":"https://api.github.com/repos/PolicyStat/combokeys/contributors","subscribers_url":"https://api.github.com/repos/PolicyStat/combokeys/subscribers","subscription_url":"https://api.github.com/repos/PolicyStat/combokeys/subscription","commits_url":"https://api.github.com/repos/PolicyStat/combokeys/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolicyStat/combokeys/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolicyStat/combokeys/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolicyStat/combokeys/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolicyStat/combokeys/contents/{+path}","compare_url":"https://api.github.com/repos/PolicyStat/combokeys/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolicyStat/combokeys/merges","archive_url":"https://api.github.com/repos/PolicyStat/combokeys/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolicyStat/combokeys/downloads","issues_url":"https://api.github.com/repos/PolicyStat/combokeys/issues{/number}","pulls_url":"https://api.github.com/repos/PolicyStat/combokeys/pulls{/number}","milestones_url":"https://api.github.com/repos/PolicyStat/combokeys/milestones{/number}","notifications_url":"https://api.github.com/repos/PolicyStat/combokeys/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolicyStat/combokeys/labels{/name}","releases_url":"https://api.github.com/repos/PolicyStat/combokeys/releases{/id}","created_at":"2014-11-15T15:31:27Z","updated_at":"2015-03-27T14:38:30Z","pushed_at":"2015-03-27T17:40:16Z","git_url":"git://github.com/PolicyStat/combokeys.git","ssh_url":"git@github.com:PolicyStat/combokeys.git","clone_url":"https://github.com/PolicyStat/combokeys.git","svn_url":"https://github.com/PolicyStat/combokeys","homepage":"","size":868,"stargazers_count":519,"watchers_count":519,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":10,"forks":14,"open_issues":10,"watchers":519,"default_branch":"master"}},"base":{"label":"PolicyStat:master","ref":"master","sha":"cec8d17bac85f130d198c1b78061b3ebaa2f02cc","user":{"login":"PolicyStat","id":149499,"avatar_url":"https://avatars.githubusercontent.com/u/149499?v=3","gravatar_id":"","url":"https://api.github.com/users/PolicyStat","html_url":"https://github.com/PolicyStat","followers_url":"https://api.github.com/users/PolicyStat/followers","following_url":"https://api.github.com/users/PolicyStat/following{/other_user}","gists_url":"https://api.github.com/users/PolicyStat/gists{/gist_id}","starred_url":"https://api.github.com/users/PolicyStat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolicyStat/subscriptions","organizations_url":"https://api.github.com/users/PolicyStat/orgs","repos_url":"https://api.github.com/users/PolicyStat/repos","events_url":"https://api.github.com/users/PolicyStat/events{/privacy}","received_events_url":"https://api.github.com/users/PolicyStat/received_events","type":"Organization","site_admin":false},"repo":{"id":26683992,"name":"combokeys","full_name":"PolicyStat/combokeys","owner":{"login":"PolicyStat","id":149499,"avatar_url":"https://avatars.githubusercontent.com/u/149499?v=3","gravatar_id":"","url":"https://api.github.com/users/PolicyStat","html_url":"https://github.com/PolicyStat","followers_url":"https://api.github.com/users/PolicyStat/followers","following_url":"https://api.github.com/users/PolicyStat/following{/other_user}","gists_url":"https://api.github.com/users/PolicyStat/gists{/gist_id}","starred_url":"https://api.github.com/users/PolicyStat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolicyStat/subscriptions","organizations_url":"https://api.github.com/users/PolicyStat/orgs","repos_url":"https://api.github.com/users/PolicyStat/repos","events_url":"https://api.github.com/users/PolicyStat/events{/privacy}","received_events_url":"https://api.github.com/users/PolicyStat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolicyStat/combokeys","description":"Web browser keyboard shortcuts. CommonJS, NPM.","fork":false,"url":"https://api.github.com/repos/PolicyStat/combokeys","forks_url":"https://api.github.com/repos/PolicyStat/combokeys/forks","keys_url":"https://api.github.com/repos/PolicyStat/combokeys/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolicyStat/combokeys/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolicyStat/combokeys/teams","hooks_url":"https://api.github.com/repos/PolicyStat/combokeys/hooks","issue_events_url":"https://api.github.com/repos/PolicyStat/combokeys/issues/events{/number}","events_url":"https://api.github.com/repos/PolicyStat/combokeys/events","assignees_url":"https://api.github.com/repos/PolicyStat/combokeys/assignees{/user}","branches_url":"https://api.github.com/repos/PolicyStat/combokeys/branches{/branch}","tags_url":"https://api.github.com/repos/PolicyStat/combokeys/tags","blobs_url":"https://api.github.com/repos/PolicyStat/combokeys/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolicyStat/combokeys/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolicyStat/combokeys/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolicyStat/combokeys/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolicyStat/combokeys/statuses/{sha}","languages_url":"https://api.github.com/repos/PolicyStat/combokeys/languages","stargazers_url":"https://api.github.com/repos/PolicyStat/combokeys/stargazers","contributors_url":"https://api.github.com/repos/PolicyStat/combokeys/contributors","subscribers_url":"https://api.github.com/repos/PolicyStat/combokeys/subscribers","subscription_url":"https://api.github.com/repos/PolicyStat/combokeys/subscription","commits_url":"https://api.github.com/repos/PolicyStat/combokeys/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolicyStat/combokeys/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolicyStat/combokeys/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolicyStat/combokeys/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolicyStat/combokeys/contents/{+path}","compare_url":"https://api.github.com/repos/PolicyStat/combokeys/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolicyStat/combokeys/merges","archive_url":"https://api.github.com/repos/PolicyStat/combokeys/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolicyStat/combokeys/downloads","issues_url":"https://api.github.com/repos/PolicyStat/combokeys/issues{/number}","pulls_url":"https://api.github.com/repos/PolicyStat/combokeys/pulls{/number}","milestones_url":"https://api.github.com/repos/PolicyStat/combokeys/milestones{/number}","notifications_url":"https://api.github.com/repos/PolicyStat/combokeys/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolicyStat/combokeys/labels{/name}","releases_url":"https://api.github.com/repos/PolicyStat/combokeys/releases{/id}","created_at":"2014-11-15T15:31:27Z","updated_at":"2015-03-27T14:38:30Z","pushed_at":"2015-03-27T17:40:16Z","git_url":"git://github.com/PolicyStat/combokeys.git","ssh_url":"git@github.com:PolicyStat/combokeys.git","clone_url":"https://github.com/PolicyStat/combokeys.git","svn_url":"https://github.com/PolicyStat/combokeys","homepage":"","size":868,"stargazers_count":519,"watchers_count":519,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":10,"forks":14,"open_issues":10,"watchers":519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolicyStat/combokeys/pulls/39"},"html":{"href":"https://github.com/PolicyStat/combokeys/pull/39"},"issue":{"href":"https://api.github.com/repos/PolicyStat/combokeys/issues/39"},"comments":{"href":"https://api.github.com/repos/PolicyStat/combokeys/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/PolicyStat/combokeys/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/PolicyStat/combokeys/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolicyStat/combokeys/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/PolicyStat/combokeys/statuses/24a57d4821a1793b9a29787cf22aec131b2d3f61"}}}}