{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/37850835","id":37850835,"diff_hunk":"@@ -69,6 +69,25 @@ ve.dm.MWTransclusionNode.static.getHashObject = function ( dataElement ) {\n \t};\n };\n \n+/**\n+ * return the type to be assigned to given data element. If this is a portable infobox, the proper\n+ * node type was already defined and named.\n+ *\n+ * @param domElements array of clicked elements\n+ * @param converter Converter object\n+ * @returns {string} type of Node\n+ */\n+ve.dm.MWTransclusionNode.static.getDataElementType = function ( domElements, converter ) {\n+\tvar isInline = this.isHybridInline( domElements, converter);\n+\n+\tif ( isInline ) {\n+\t\treturn ve.dm.MWTransclusionInlineNode.static.name;\n+\t}\n+\treturn this.name === ve.dm.WikiaInfoboxTransclusionBlockNode.static.name ?","path":"extensions/VisualEditor/modules/ve-mw/dm/nodes/ve.dm.MWTransclusionNode.js","position":18,"original_position":18,"commit_id":"603021397fdb47d6e63c0162ebaf11968bf81a79","original_commit_id":"0756279dabbaf72d8bca90924f011cc4cd8468e4","user":{"login":"dianafa","id":3716441,"avatar_url":"https://avatars.githubusercontent.com/u/3716441?v=3","gravatar_id":"","url":"https://api.github.com/users/dianafa","html_url":"https://github.com/dianafa","followers_url":"https://api.github.com/users/dianafa/followers","following_url":"https://api.github.com/users/dianafa/following{/other_user}","gists_url":"https://api.github.com/users/dianafa/gists{/gist_id}","starred_url":"https://api.github.com/users/dianafa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dianafa/subscriptions","organizations_url":"https://api.github.com/users/dianafa/orgs","repos_url":"https://api.github.com/users/dianafa/repos","events_url":"https://api.github.com/users/dianafa/events{/privacy}","received_events_url":"https://api.github.com/users/dianafa/received_events","type":"User","site_admin":false},"body":"`toDataElement` is called on `ve.dm.MWTransclusionNode` because `ve.dm.Converter.prototype.createDataElements` gets in params the `modelClass` equal to `VeDmMWTransclusionNode()`. It's because `modelName = this.modelRegistry.matchElement( childNode, aboutGroup.length > 1 );` in `ve.dm.Converter.prototype.getDataFromDomSubtree` is equal to `mwTransclusion` for all templates. I think that's why the 'isInline' check was performed here before.","created_at":"2015-08-25T10:10:52Z","updated_at":"2015-08-25T10:10:52Z","html_url":"https://github.com/Wikia/app/pull/8069#discussion_r37850835","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/8069","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/37850835"},"html":{"href":"https://github.com/Wikia/app/pull/8069#discussion_r37850835"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/8069"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/8069","id":42119809,"html_url":"https://github.com/Wikia/app/pull/8069","diff_url":"https://github.com/Wikia/app/pull/8069.diff","patch_url":"https://github.com/Wikia/app/pull/8069.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/8069","number":8069,"state":"open","locked":false,"title":"VE infobox edit","user":{"login":"dianafa","id":3716441,"avatar_url":"https://avatars.githubusercontent.com/u/3716441?v=3","gravatar_id":"","url":"https://api.github.com/users/dianafa","html_url":"https://github.com/dianafa","followers_url":"https://api.github.com/users/dianafa/followers","following_url":"https://api.github.com/users/dianafa/following{/other_user}","gists_url":"https://api.github.com/users/dianafa/gists{/gist_id}","starred_url":"https://api.github.com/users/dianafa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dianafa/subscriptions","organizations_url":"https://api.github.com/users/dianafa/orgs","repos_url":"https://api.github.com/users/dianafa/repos","events_url":"https://api.github.com/users/dianafa/events{/privacy}","received_events_url":"https://api.github.com/users/dianafa/received_events","type":"User","site_admin":false},"body":"DO NOT MERGE!!!!!\r\n\r\nhttps://wikia-inc.atlassian.net/browse/DAT-3107","created_at":"2015-08-11T11:46:33Z","updated_at":"2015-08-25T10:10:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54df27e70fda2414fa4dfbffb488dcf544c0c339","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/8069/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/8069/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/8069/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/603021397fdb47d6e63c0162ebaf11968bf81a79","head":{"label":"Wikia:DAT-ve-infobox-edit","ref":"DAT-ve-infobox-edit","sha":"603021397fdb47d6e63c0162ebaf11968bf81a79","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-08-21T19:21:58Z","pushed_at":"2015-08-25T10:09:06Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1480321,"stargazers_count":83,"watchers_count":83,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":69,"forks":66,"open_issues":69,"watchers":83,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"1a7ffa2dc8baa434f2d6c5b02a9816b5a8527e1d","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-08-21T19:21:58Z","pushed_at":"2015-08-25T10:09:06Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1480321,"stargazers_count":83,"watchers_count":83,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":69,"forks":66,"open_issues":69,"watchers":83,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/8069"},"html":{"href":"https://github.com/Wikia/app/pull/8069"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/8069"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/8069/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/8069/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/8069/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/603021397fdb47d6e63c0162ebaf11968bf81a79"}}}}