{"action":"created","comment":{"url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/pulls/comments/33150529","id":33150529,"diff_hunk":"@@ -103,55 +281,110 @@ apiNewMulticastGroup state ourAddress = do\n -- subsequent calls to resolveMulticastGroup will fail. This mimicks the fact\n -- that some multicast messages may still be in transit when the group is\n -- deleted.\n-createMulticastGroup :: MVar TransportState -> EndPointAddress -> MulticastAddress -> MVar (Set EndPointAddress) -> MulticastGroup\n-createMulticastGroup state ourAddress groupAddress group =\n-  MulticastGroup { multicastAddress     = groupAddress\n-                 , deleteMulticastGroup = modifyMVar_ state $ return . (multigroups ^: Map.delete groupAddress)\n-                 , maxMsgSize           = Nothing\n-                 , multicastSend        = \\payload -> do\n-                                            cs <- (^. channels) <$> readMVar state\n-                                            es <- readMVar group\n-                                            forM_ (Set.elems es) $ \\ep -> do\n-                                              let ch = cs ^. at ep \"Invalid endpoint\"\n-                                              writeChan ch (ReceivedMulticast groupAddress payload)\n-                 , multicastSubscribe   = modifyMVar_ group $ return . Set.insert ourAddress\n-                 , multicastUnsubscribe = modifyMVar_ group $ return . Set.delete ourAddress\n-                 , multicastClose       = return ()\n-                 }\n+createMulticastGroup :: TVar TransportState -> EndPointAddress -> MulticastAddress -> TVar (Set EndPointAddress) -> MulticastGroup","path":"src/Network/Transport/Chan.hs","position":363,"original_position":363,"commit_id":"2242aa1868784ece938460a53d06db18bfe9ec18","original_commit_id":"2242aa1868784ece938460a53d06db18bfe9ec18","user":{"login":"qnikst","id":170227,"avatar_url":"https://avatars.githubusercontent.com/u/170227?v=3","gravatar_id":"","url":"https://api.github.com/users/qnikst","html_url":"https://github.com/qnikst","followers_url":"https://api.github.com/users/qnikst/followers","following_url":"https://api.github.com/users/qnikst/following{/other_user}","gists_url":"https://api.github.com/users/qnikst/gists{/gist_id}","starred_url":"https://api.github.com/users/qnikst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qnikst/subscriptions","organizations_url":"https://api.github.com/users/qnikst/orgs","repos_url":"https://api.github.com/users/qnikst/repos","events_url":"https://api.github.com/users/qnikst/events{/privacy}","received_events_url":"https://api.github.com/users/qnikst/received_events","type":"User","site_admin":false},"body":"OK.","created_at":"2015-06-24T14:08:34Z","updated_at":"2015-06-24T14:08:34Z","html_url":"https://github.com/haskell-distributed/network-transport-inmemory/pull/8#discussion_r33150529","pull_request_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/pulls/comments/33150529"},"html":{"href":"https://github.com/haskell-distributed/network-transport-inmemory/pull/8#discussion_r33150529"},"pull_request":{"href":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/pulls/8","id":38343030,"html_url":"https://github.com/haskell-distributed/network-transport-inmemory/pull/8","diff_url":"https://github.com/haskell-distributed/network-transport-inmemory/pull/8.diff","patch_url":"https://github.com/haskell-distributed/network-transport-inmemory/pull/8.patch","issue_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/issues/8","number":8,"state":"open","locked":false,"title":"Implement transport that preserves semantics using STM primitives.","user":{"login":"qnikst","id":170227,"avatar_url":"https://avatars.githubusercontent.com/u/170227?v=3","gravatar_id":"","url":"https://api.github.com/users/qnikst","html_url":"https://github.com/qnikst","followers_url":"https://api.github.com/users/qnikst/followers","following_url":"https://api.github.com/users/qnikst/following{/other_user}","gists_url":"https://api.github.com/users/qnikst/gists{/gist_id}","starred_url":"https://api.github.com/users/qnikst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qnikst/subscriptions","organizations_url":"https://api.github.com/users/qnikst/orgs","repos_url":"https://api.github.com/users/qnikst/repos","events_url":"https://api.github.com/users/qnikst/events{/privacy}","received_events_url":"https://api.github.com/users/qnikst/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-23T14:33:14Z","updated_at":"2015-06-24T14:08:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5148d62105ec86d023c6530b366105d65cab3c2","assignee":{"login":"facundominguez","id":1200667,"avatar_url":"https://avatars.githubusercontent.com/u/1200667?v=3","gravatar_id":"","url":"https://api.github.com/users/facundominguez","html_url":"https://github.com/facundominguez","followers_url":"https://api.github.com/users/facundominguez/followers","following_url":"https://api.github.com/users/facundominguez/following{/other_user}","gists_url":"https://api.github.com/users/facundominguez/gists{/gist_id}","starred_url":"https://api.github.com/users/facundominguez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facundominguez/subscriptions","organizations_url":"https://api.github.com/users/facundominguez/orgs","repos_url":"https://api.github.com/users/facundominguez/repos","events_url":"https://api.github.com/users/facundominguez/events{/privacy}","received_events_url":"https://api.github.com/users/facundominguez/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/pulls/8/commits","review_comments_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/pulls/8/comments","review_comment_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/issues/8/comments","statuses_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/statuses/2242aa1868784ece938460a53d06db18bfe9ec18","head":{"label":"haskell-distributed:dev/move-to-stm","ref":"dev/move-to-stm","sha":"2242aa1868784ece938460a53d06db18bfe9ec18","user":{"login":"haskell-distributed","id":1215670,"avatar_url":"https://avatars.githubusercontent.com/u/1215670?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell-distributed","html_url":"https://github.com/haskell-distributed","followers_url":"https://api.github.com/users/haskell-distributed/followers","following_url":"https://api.github.com/users/haskell-distributed/following{/other_user}","gists_url":"https://api.github.com/users/haskell-distributed/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell-distributed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell-distributed/subscriptions","organizations_url":"https://api.github.com/users/haskell-distributed/orgs","repos_url":"https://api.github.com/users/haskell-distributed/repos","events_url":"https://api.github.com/users/haskell-distributed/events{/privacy}","received_events_url":"https://api.github.com/users/haskell-distributed/received_events","type":"Organization","site_admin":false},"repo":{"id":7963404,"name":"network-transport-inmemory","full_name":"haskell-distributed/network-transport-inmemory","owner":{"login":"haskell-distributed","id":1215670,"avatar_url":"https://avatars.githubusercontent.com/u/1215670?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell-distributed","html_url":"https://github.com/haskell-distributed","followers_url":"https://api.github.com/users/haskell-distributed/followers","following_url":"https://api.github.com/users/haskell-distributed/following{/other_user}","gists_url":"https://api.github.com/users/haskell-distributed/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell-distributed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell-distributed/subscriptions","organizations_url":"https://api.github.com/users/haskell-distributed/orgs","repos_url":"https://api.github.com/users/haskell-distributed/repos","events_url":"https://api.github.com/users/haskell-distributed/events{/privacy}","received_events_url":"https://api.github.com/users/haskell-distributed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell-distributed/network-transport-inmemory","description":"In-memory realisation of Network.Transport","fork":false,"url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory","forks_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/forks","keys_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/teams","hooks_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/hooks","issue_events_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/issues/events{/number}","events_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/events","assignees_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/assignees{/user}","branches_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/branches{/branch}","tags_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/tags","blobs_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/languages","stargazers_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/stargazers","contributors_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/contributors","subscribers_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/subscribers","subscription_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/subscription","commits_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/contents/{+path}","compare_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/merges","archive_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/downloads","issues_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/issues{/number}","pulls_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/labels{/name}","releases_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/releases{/id}","created_at":"2013-02-01T18:17:20Z","updated_at":"2015-06-13T11:35:51Z","pushed_at":"2015-06-24T11:24:22Z","git_url":"git://github.com/haskell-distributed/network-transport-inmemory.git","ssh_url":"git@github.com:haskell-distributed/network-transport-inmemory.git","clone_url":"https://github.com/haskell-distributed/network-transport-inmemory.git","svn_url":"https://github.com/haskell-distributed/network-transport-inmemory","homepage":"http://haskell-distributed.github.com","size":250,"stargazers_count":2,"watchers_count":2,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":2,"default_branch":"master"}},"base":{"label":"haskell-distributed:master","ref":"master","sha":"4d5b6edf2c08a5ef248503b3524addc16d91fb13","user":{"login":"haskell-distributed","id":1215670,"avatar_url":"https://avatars.githubusercontent.com/u/1215670?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell-distributed","html_url":"https://github.com/haskell-distributed","followers_url":"https://api.github.com/users/haskell-distributed/followers","following_url":"https://api.github.com/users/haskell-distributed/following{/other_user}","gists_url":"https://api.github.com/users/haskell-distributed/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell-distributed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell-distributed/subscriptions","organizations_url":"https://api.github.com/users/haskell-distributed/orgs","repos_url":"https://api.github.com/users/haskell-distributed/repos","events_url":"https://api.github.com/users/haskell-distributed/events{/privacy}","received_events_url":"https://api.github.com/users/haskell-distributed/received_events","type":"Organization","site_admin":false},"repo":{"id":7963404,"name":"network-transport-inmemory","full_name":"haskell-distributed/network-transport-inmemory","owner":{"login":"haskell-distributed","id":1215670,"avatar_url":"https://avatars.githubusercontent.com/u/1215670?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell-distributed","html_url":"https://github.com/haskell-distributed","followers_url":"https://api.github.com/users/haskell-distributed/followers","following_url":"https://api.github.com/users/haskell-distributed/following{/other_user}","gists_url":"https://api.github.com/users/haskell-distributed/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell-distributed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell-distributed/subscriptions","organizations_url":"https://api.github.com/users/haskell-distributed/orgs","repos_url":"https://api.github.com/users/haskell-distributed/repos","events_url":"https://api.github.com/users/haskell-distributed/events{/privacy}","received_events_url":"https://api.github.com/users/haskell-distributed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell-distributed/network-transport-inmemory","description":"In-memory realisation of Network.Transport","fork":false,"url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory","forks_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/forks","keys_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/teams","hooks_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/hooks","issue_events_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/issues/events{/number}","events_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/events","assignees_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/assignees{/user}","branches_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/branches{/branch}","tags_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/tags","blobs_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/languages","stargazers_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/stargazers","contributors_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/contributors","subscribers_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/subscribers","subscription_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/subscription","commits_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/contents/{+path}","compare_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/merges","archive_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/downloads","issues_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/issues{/number}","pulls_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/labels{/name}","releases_url":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/releases{/id}","created_at":"2013-02-01T18:17:20Z","updated_at":"2015-06-13T11:35:51Z","pushed_at":"2015-06-24T11:24:22Z","git_url":"git://github.com/haskell-distributed/network-transport-inmemory.git","ssh_url":"git@github.com:haskell-distributed/network-transport-inmemory.git","clone_url":"https://github.com/haskell-distributed/network-transport-inmemory.git","svn_url":"https://github.com/haskell-distributed/network-transport-inmemory","homepage":"http://haskell-distributed.github.com","size":250,"stargazers_count":2,"watchers_count":2,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/pulls/8"},"html":{"href":"https://github.com/haskell-distributed/network-transport-inmemory/pull/8"},"issue":{"href":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/issues/8"},"comments":{"href":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/haskell-distributed/network-transport-inmemory/statuses/2242aa1868784ece938460a53d06db18bfe9ec18"}}}}