{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/44710921","id":44710921,"diff_hunk":"@@ -114,12 +115,32 @@ private static String readString(String propertyName, Object value) {\n      * Returns and removes the specified property of type map from the specified configuration map.\n      *\n      * If the property value isn't of type map an {@link IllegalArgumentException} is thrown.\n+     * If the property is missing an {@link IllegalArgumentException} is thrown\n+     */\n+    public static <T> Map<String, T> readMap(Map<String, Object> configuration, String propertyName) {\n+        Object value = configuration.remove(propertyName);\n+        if (value == null) {\n+            throw new IllegalArgumentException(\"required property [\" + propertyName + \"] is missing\");\n+        }\n+\n+        return readMap(propertyName, value);\n+    }\n+\n+    /**\n+     * Returns and removes the specified property of type map from the specified configuration map.\n+     *\n+     * If the property value isn't of type map an {@link IllegalArgumentException} is thrown.\n      */\n     public static <T> Map<String, T> readOptionalMap(Map<String, Object> configuration, String propertyName) {\n         Object value = configuration.remove(propertyName);\n         if (value == null) {\n             return null;\n         }\n+\n+        return readMap(propertyName, value);\n+    }\n+\n+    public static <T> Map<String, T> readMap(String propertyName, Object value) {","path":"plugins/ingest/src/main/java/org/elasticsearch/ingest/processor/ConfigurationUtils.java","position":73,"original_position":73,"commit_id":"39d353e572b570b2d247c8af22dbabe7b63ca527","original_commit_id":"39d353e572b570b2d247c8af22dbabe7b63ca527","user":{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false},"body":"yes, missed that","created_at":"2015-11-12T20:37:08Z","updated_at":"2015-11-12T20:37:08Z","html_url":"https://github.com/elastic/elasticsearch/pull/14572#discussion_r44710921","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/14572","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/44710921"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/14572#discussion_r44710921"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/14572"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/14572","id":49901194,"html_url":"https://github.com/elastic/elasticsearch/pull/14572","diff_url":"https://github.com/elastic/elasticsearch/pull/14572.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/14572.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/14572","number":14572,"state":"open","locked":false,"title":"[Ingest] Simulate Endpoint","user":{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false},"body":"Still needs work, but good to get some eyes on this","created_at":"2015-11-06T00:25:38Z","updated_at":"2015-11-12T20:37:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea3abe1571a93488dfd8447136ac3cd1801c150d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/14572/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/14572/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/14572/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/39d353e572b570b2d247c8af22dbabe7b63ca527","head":{"label":"talevy:simulate_ingest","ref":"simulate_ingest","sha":"39d353e572b570b2d247c8af22dbabe7b63ca527","user":{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false},"repo":{"id":25600001,"name":"elasticsearch","full_name":"talevy/elasticsearch","owner":{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/talevy/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/talevy/elasticsearch","forks_url":"https://api.github.com/repos/talevy/elasticsearch/forks","keys_url":"https://api.github.com/repos/talevy/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talevy/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talevy/elasticsearch/teams","hooks_url":"https://api.github.com/repos/talevy/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/talevy/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/talevy/elasticsearch/events","assignees_url":"https://api.github.com/repos/talevy/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/talevy/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/talevy/elasticsearch/tags","blobs_url":"https://api.github.com/repos/talevy/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talevy/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talevy/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/talevy/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talevy/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/talevy/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/talevy/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/talevy/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/talevy/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/talevy/elasticsearch/subscription","commits_url":"https://api.github.com/repos/talevy/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/talevy/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/talevy/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/talevy/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/talevy/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/talevy/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talevy/elasticsearch/merges","archive_url":"https://api.github.com/repos/talevy/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talevy/elasticsearch/downloads","issues_url":"https://api.github.com/repos/talevy/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/talevy/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/talevy/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/talevy/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talevy/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/talevy/elasticsearch/releases{/id}","created_at":"2014-10-22T19:25:53Z","updated_at":"2015-04-14T21:19:32Z","pushed_at":"2015-11-12T20:04:33Z","git_url":"git://github.com/talevy/elasticsearch.git","ssh_url":"git@github.com:talevy/elasticsearch.git","clone_url":"https://github.com/talevy/elasticsearch.git","svn_url":"https://github.com/talevy/elasticsearch","homepage":"http://elasticsearch.org","size":160127,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:feature/ingest","ref":"feature/ingest","sha":"5bd4493ea21eead46d34ac64bbeb5860602bbe94","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","created_at":"2010-02-08T13:20:56Z","updated_at":"2015-11-12T16:35:43Z","pushed_at":"2015-11-12T20:36:27Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":482776,"stargazers_count":13509,"watchers_count":13509,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4450,"mirror_url":null,"open_issues_count":1326,"forks":4450,"open_issues":1326,"watchers":13509,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/14572"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/14572"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/14572"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/14572/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/14572/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/14572/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/39d353e572b570b2d247c8af22dbabe7b63ca527"}}}}