{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/8436","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/8436/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/8436/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/8436/events","html_url":"https://github.com/xbmc/xbmc/pull/8436","id":118672755,"number":8436,"title":"Fix artist names when list cached, and with prioritised APE tags","user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Fix","name":"Fix","color":"0b02e1"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Jarvis","name":"Jarvis","color":"fbca04"},{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Music","name":"Music","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-24T18:21:59Z","updated_at":"2015-11-25T09:13:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/8436","html_url":"https://github.com/xbmc/xbmc/pull/8436","diff_url":"https://github.com/xbmc/xbmc/pull/8436.diff","patch_url":"https://github.com/xbmc/xbmc/pull/8436.patch"},"body":"Fixing a couple of niggles following the processing of ARTISTS tag #7281 and the subsequent changes to artist variable in Song and Album #8158.\r\n\r\nArtist name was being lost when the album list was cached, so when caching of the album list  happened going back up from a list of songs to a list of albums the artist names wasn't showing. In CMusicInfotag both artistDesc and albumArtistDesc needed archiving.\r\n\r\nThere was also inconsistent tag processing behaviour with music files with both ID3v2 and APE tags, when `prioritiseapetags` set. This is discussed here http://forum.kodi.tv/showthread.php?tid=248791 \r\nIn this case the tags are parsed twice, and artist desc set from ID3v2 tags needs to be overwritten by that in APE tags.\r\n\r\n@Razzeee have a look.  @evilhamster if you are around? Needs to go into Jarvis."},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/159544001","html_url":"https://github.com/xbmc/xbmc/pull/8436#issuecomment-159544001","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/8436","id":159544001,"user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T09:13:25Z","updated_at":"2015-11-25T09:13:25Z","body":"Thanks for the testing Scott. @Razzeee is happy, so can we merge this fix into Jarvis @MartijnKaijser ?"}}