{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/comments/28849409","id":28849409,"diff_hunk":"@@ -0,0 +1,9 @@\n+def upgrade ta, td, a, d\n+  a['admin_pass'] = ta['admin_pass']\n+  return a, d\n+end\n+\n+def downgrade ta, td, a, d\n+  a.delete('admin_pass')","path":"chef/data_bags/crowbar/migrate/provisioner/023_add_hyperv-adminpassword.rb","position":7,"original_position":7,"commit_id":"9cdfc8c45a571d72e58650d44a39a53fea137010","original_commit_id":"9cdfc8c45a571d72e58650d44a39a53fea137010","user":{"login":"mjura","id":4455471,"avatar_url":"https://avatars.githubusercontent.com/u/4455471?v=3","gravatar_id":"","url":"https://api.github.com/users/mjura","html_url":"https://github.com/mjura","followers_url":"https://api.github.com/users/mjura/followers","following_url":"https://api.github.com/users/mjura/following{/other_user}","gists_url":"https://api.github.com/users/mjura/gists{/gist_id}","starred_url":"https://api.github.com/users/mjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjura/subscriptions","organizations_url":"https://api.github.com/users/mjura/orgs","repos_url":"https://api.github.com/users/mjura/repos","events_url":"https://api.github.com/users/mjura/events{/privacy}","received_events_url":"https://api.github.com/users/mjura/received_events","type":"User","site_admin":false},"body":"@tboerger: yeap, you are right","created_at":"2015-04-22T07:16:51Z","updated_at":"2015-04-22T07:16:51Z","html_url":"https://github.com/crowbar/barclamp-provisioner/pull/406#discussion_r28849409","pull_request_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/406","_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/comments/28849409"},"html":{"href":"https://github.com/crowbar/barclamp-provisioner/pull/406#discussion_r28849409"},"pull_request":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/406"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/406","id":32120726,"html_url":"https://github.com/crowbar/barclamp-provisioner/pull/406","diff_url":"https://github.com/crowbar/barclamp-provisioner/pull/406.diff","patch_url":"https://github.com/crowbar/barclamp-provisioner/pull/406.patch","issue_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/issues/406","number":406,"state":"open","locked":false,"title":"[WIP] Make Windows/Hyper-V Admin-Password configurable","user":{"login":"thutterer","id":5372947,"avatar_url":"https://avatars.githubusercontent.com/u/5372947?v=3","gravatar_id":"","url":"https://api.github.com/users/thutterer","html_url":"https://github.com/thutterer","followers_url":"https://api.github.com/users/thutterer/followers","following_url":"https://api.github.com/users/thutterer/following{/other_user}","gists_url":"https://api.github.com/users/thutterer/gists{/gist_id}","starred_url":"https://api.github.com/users/thutterer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thutterer/subscriptions","organizations_url":"https://api.github.com/users/thutterer/orgs","repos_url":"https://api.github.com/users/thutterer/repos","events_url":"https://api.github.com/users/thutterer/events{/privacy}","received_events_url":"https://api.github.com/users/thutterer/received_events","type":"User","site_admin":false},"body":"This change still needs some testing. **Do not merge yet!**\r\nI open the PR for review and discussion:\r\n- Should there be a helper text next to the password field that describes what characters are (not) allowed?\r\n- Should the password be validated before it gets accepted?\r\n- Is the number in the migration filename correct?\r\n\r\n","created_at":"2015-03-27T16:07:01Z","updated_at":"2015-04-22T07:16:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa7896cf56aad620a3a3b030f8a02d17714224e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/406/commits","review_comments_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/406/comments","review_comment_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/issues/406/comments","statuses_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/statuses/9cdfc8c45a571d72e58650d44a39a53fea137010","head":{"label":"thutterer:hyperV_admin_pass","ref":"hyperV_admin_pass","sha":"9cdfc8c45a571d72e58650d44a39a53fea137010","user":{"login":"thutterer","id":5372947,"avatar_url":"https://avatars.githubusercontent.com/u/5372947?v=3","gravatar_id":"","url":"https://api.github.com/users/thutterer","html_url":"https://github.com/thutterer","followers_url":"https://api.github.com/users/thutterer/followers","following_url":"https://api.github.com/users/thutterer/following{/other_user}","gists_url":"https://api.github.com/users/thutterer/gists{/gist_id}","starred_url":"https://api.github.com/users/thutterer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thutterer/subscriptions","organizations_url":"https://api.github.com/users/thutterer/orgs","repos_url":"https://api.github.com/users/thutterer/repos","events_url":"https://api.github.com/users/thutterer/events{/privacy}","received_events_url":"https://api.github.com/users/thutterer/received_events","type":"User","site_admin":false},"repo":{"id":32934015,"name":"barclamp-provisioner","full_name":"thutterer/barclamp-provisioner","owner":{"login":"thutterer","id":5372947,"avatar_url":"https://avatars.githubusercontent.com/u/5372947?v=3","gravatar_id":"","url":"https://api.github.com/users/thutterer","html_url":"https://github.com/thutterer","followers_url":"https://api.github.com/users/thutterer/followers","following_url":"https://api.github.com/users/thutterer/following{/other_user}","gists_url":"https://api.github.com/users/thutterer/gists{/gist_id}","starred_url":"https://api.github.com/users/thutterer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thutterer/subscriptions","organizations_url":"https://api.github.com/users/thutterer/orgs","repos_url":"https://api.github.com/users/thutterer/repos","events_url":"https://api.github.com/users/thutterer/events{/privacy}","received_events_url":"https://api.github.com/users/thutterer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thutterer/barclamp-provisioner","description":"Crowbar Provisioner: Install Operating Systems","fork":true,"url":"https://api.github.com/repos/thutterer/barclamp-provisioner","forks_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/forks","keys_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/teams","hooks_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/hooks","issue_events_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/issues/events{/number}","events_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/events","assignees_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/assignees{/user}","branches_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/branches{/branch}","tags_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/tags","blobs_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/git/refs{/sha}","trees_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/statuses/{sha}","languages_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/languages","stargazers_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/stargazers","contributors_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/contributors","subscribers_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/subscribers","subscription_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/subscription","commits_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/commits{/sha}","git_commits_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/git/commits{/sha}","comments_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/comments{/number}","issue_comment_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/issues/comments{/number}","contents_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/contents/{+path}","compare_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/merges","archive_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/downloads","issues_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/issues{/number}","pulls_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/pulls{/number}","milestones_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/milestones{/number}","notifications_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/labels{/name}","releases_url":"https://api.github.com/repos/thutterer/barclamp-provisioner/releases{/id}","created_at":"2015-03-26T15:01:13Z","updated_at":"2015-03-26T15:01:14Z","pushed_at":"2015-04-20T14:33:36Z","git_url":"git://github.com/thutterer/barclamp-provisioner.git","ssh_url":"git@github.com:thutterer/barclamp-provisioner.git","clone_url":"https://github.com/thutterer/barclamp-provisioner.git","svn_url":"https://github.com/thutterer/barclamp-provisioner","homepage":"https://github.com/crowbar/crowbar","size":64347,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"94417885fdcce309bd43694541a13ea63324010c","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":2351609,"name":"barclamp-provisioner","full_name":"crowbar/barclamp-provisioner","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/barclamp-provisioner","description":"Crowbar Provisioner: Install Operating Systems","fork":false,"url":"https://api.github.com/repos/crowbar/barclamp-provisioner","forks_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/forks","keys_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/teams","hooks_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/hooks","issue_events_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/events","assignees_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/tags","blobs_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/languages","stargazers_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/stargazers","contributors_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/contributors","subscribers_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/subscribers","subscription_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/subscription","commits_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/merges","archive_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/downloads","issues_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/barclamp-provisioner/releases{/id}","created_at":"2011-09-08T21:20:51Z","updated_at":"2015-03-26T09:46:20Z","pushed_at":"2015-04-20T14:33:37Z","git_url":"git://github.com/crowbar/barclamp-provisioner.git","ssh_url":"git@github.com:crowbar/barclamp-provisioner.git","clone_url":"https://github.com/crowbar/barclamp-provisioner.git","svn_url":"https://github.com/crowbar/barclamp-provisioner","homepage":"https://github.com/crowbar/crowbar","size":66763,"stargazers_count":61,"watchers_count":61,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":186,"mirror_url":null,"open_issues_count":10,"forks":186,"open_issues":10,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/406"},"html":{"href":"https://github.com/crowbar/barclamp-provisioner/pull/406"},"issue":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/issues/406"},"comments":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/issues/406/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/406/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/pulls/406/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/barclamp-provisioner/statuses/9cdfc8c45a571d72e58650d44a39a53fea137010"}}}}