{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/24791888","id":24791888,"diff_hunk":"@@ -472,6 +472,21 @@ int ModApiMainMenu::l_get_favorites(lua_State *L)\n \n \tfor (unsigned int i = 0; i < servers.size(); i++)\n \t{\n+\n+\t\tif (listtype == \"online\") {\n+\t\t\t//for the online list, we only want servers we support.\n+\t\t\tif (!servers[i][\"proto_min\"].asString().size() ||\n+\t\t\t\t!servers[i][\"proto_max\"].asString().size()) {\n+\t\t\t\tcontinue;\n+\t\t\t} else {\n+\t\t\t\tint proto_min = servers[i][\"proto_min\"].asInt();\n+\t\t\t\tint proto_max = servers[i][\"proto_max\"].asInt();\n+\t\t\t\tif (proto_max < CLIENT_PROTOCOL_VERSION_MIN\n+\t\t\t\t\t|| proto_min > CLIENT_PROTOCOL_VERSION_MAX)","path":"src/script/lua_api/l_mainmenu.cpp","position":null,"original_position":14,"commit_id":"9e1348ae44be6630f8ef5e59122a7e2dd57f3f38","original_commit_id":"df8fff6fc9c55fcc76429abf75629f01d16cc77f","user":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"body":"fixed.","created_at":"2015-02-17T04:37:04Z","updated_at":"2015-02-17T04:37:04Z","html_url":"https://github.com/minetest/minetest/pull/2334#discussion_r24791888","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/2334","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/24791888"},"html":{"href":"https://github.com/minetest/minetest/pull/2334#discussion_r24791888"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2334"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/2334","id":29414186,"html_url":"https://github.com/minetest/minetest/pull/2334","diff_url":"https://github.com/minetest/minetest/pull/2334.diff","patch_url":"https://github.com/minetest/minetest/pull/2334.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/2334","number":2334,"state":"open","locked":false,"title":"Add protocol version logic to master server","user":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"body":"#2327 breaks protocol. Currently, the server list has no feature to distinguish between supported servers with a compatible version, and those witout. This PR enables server to send protocol version, and makes client filter for protocol version. This commit should go to the freeze branch to, as @ShadowNinja suggested, not make two masterserver lists, one for clients which distinguish after protocol version, and one for clients which don't, but only have one production master server instance.","created_at":"2015-02-17T02:34:56Z","updated_at":"2015-02-17T04:37:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a332887437c4ea030105a287c26642bb0021cba0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/2334/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/2334/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments/{number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/2334/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/9e1348ae44be6630f8ef5e59122a7e2dd57f3f38","head":{"label":"est31:master","ref":"master","sha":"9e1348ae44be6630f8ef5e59122a7e2dd57f3f38","user":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"repo":{"id":28881630,"name":"minetest","full_name":"est31/minetest","owner":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/est31/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also [minetest_game](https://github.com/minetest/minetest_game)]","fork":true,"url":"https://api.github.com/repos/est31/minetest","forks_url":"https://api.github.com/repos/est31/minetest/forks","keys_url":"https://api.github.com/repos/est31/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/est31/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/est31/minetest/teams","hooks_url":"https://api.github.com/repos/est31/minetest/hooks","issue_events_url":"https://api.github.com/repos/est31/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/est31/minetest/events","assignees_url":"https://api.github.com/repos/est31/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/est31/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/est31/minetest/tags","blobs_url":"https://api.github.com/repos/est31/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/est31/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/est31/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/est31/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/est31/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/est31/minetest/languages","stargazers_url":"https://api.github.com/repos/est31/minetest/stargazers","contributors_url":"https://api.github.com/repos/est31/minetest/contributors","subscribers_url":"https://api.github.com/repos/est31/minetest/subscribers","subscription_url":"https://api.github.com/repos/est31/minetest/subscription","commits_url":"https://api.github.com/repos/est31/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/est31/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/est31/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/est31/minetest/issues/comments/{number}","contents_url":"https://api.github.com/repos/est31/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/est31/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/est31/minetest/merges","archive_url":"https://api.github.com/repos/est31/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/est31/minetest/downloads","issues_url":"https://api.github.com/repos/est31/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/est31/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/est31/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/est31/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/est31/minetest/labels{/name}","releases_url":"https://api.github.com/repos/est31/minetest/releases{/id}","created_at":"2015-01-06T20:18:47Z","updated_at":"2015-02-17T04:36:57Z","pushed_at":"2015-02-17T04:36:56Z","git_url":"git://github.com/est31/minetest.git","ssh_url":"git@github.com:est31/minetest.git","clone_url":"https://github.com/est31/minetest.git","svn_url":"https://github.com/est31/minetest","homepage":"http://minetest.net/","size":32238,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"98d80e2012ab4856b8b443ef498297e3d3eadbaa","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments/{number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","created_at":"2011-08-07T13:48:36Z","updated_at":"2015-02-17T04:05:34Z","pushed_at":"2015-02-16T15:56:42Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":80973,"stargazers_count":1366,"watchers_count":1366,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":463,"mirror_url":null,"open_issues_count":482,"forks":463,"open_issues":482,"watchers":1366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2334"},"html":{"href":"https://github.com/minetest/minetest/pull/2334"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/2334"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/2334/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2334/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2334/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/9e1348ae44be6630f8ef5e59122a7e2dd57f3f38"}}}}