{"action":"opened","number":299,"pull_request":{"url":"https://api.github.com/repos/mgibbs189/custom-field-suite/pulls/299","id":52413095,"html_url":"https://github.com/mgibbs189/custom-field-suite/pull/299","diff_url":"https://github.com/mgibbs189/custom-field-suite/pull/299.diff","patch_url":"https://github.com/mgibbs189/custom-field-suite/pull/299.patch","issue_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/issues/299","number":299,"state":"open","locked":false,"title":"Confirm field ID when checking dynamic loop label source","user":{"login":"jchristopher","id":10412,"avatar_url":"https://avatars.githubusercontent.com/u/10412?v=3","gravatar_id":"","url":"https://api.github.com/users/jchristopher","html_url":"https://github.com/jchristopher","followers_url":"https://api.github.com/users/jchristopher/followers","following_url":"https://api.github.com/users/jchristopher/following{/other_user}","gists_url":"https://api.github.com/users/jchristopher/gists{/gist_id}","starred_url":"https://api.github.com/users/jchristopher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchristopher/subscriptions","organizations_url":"https://api.github.com/users/jchristopher/orgs","repos_url":"https://api.github.com/users/jchristopher/repos","events_url":"https://api.github.com/users/jchristopher/events{/privacy}","received_events_url":"https://api.github.com/users/jchristopher/received_events","type":"User","site_admin":false},"body":"Noticed after updating to 2.5.2 there was a Warning having to do with the change in dynamic labels:\r\n\r\n![screen shot 2015-12-02 at 10 25 14 am](https://cloud.githubusercontent.com/assets/10412/11534872/1ef6665c-98df-11e5-80fd-81a66a861c64.png)\r\n\r\nLooks like `$field` https://github.com/mgibbs189/custom-field-suite/blob/master/includes/fields/loop.php#L354 is left over from https://github.com/mgibbs189/custom-field-suite/blob/master/includes/fields/loop.php#L341-L343 which in my case is a `select` but it's the last field in my Loop.\r\n\r\nMy Loop is as such:\r\n\r\n- Loop with dynamic field referencing first Text field name\r\n    - Text (this is the field defining the Loop row label)\r\n    - Text\r\n    - Select\r\n\r\nSo `$field` still references the `select` when in fact it should be the first Text field. Checking for the field ID resolves the issue.","created_at":"2015-12-02T15:49:44Z","updated_at":"2015-12-02T15:49:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/pulls/299/commits","review_comments_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/pulls/299/comments","review_comment_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/issues/299/comments","statuses_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/statuses/ac227c92ab10522b8a3d4d7f0e09753839bc8e9d","head":{"label":"jchristopher:dynamic-field-label-select-fix","ref":"dynamic-field-label-select-fix","sha":"ac227c92ab10522b8a3d4d7f0e09753839bc8e9d","user":{"login":"jchristopher","id":10412,"avatar_url":"https://avatars.githubusercontent.com/u/10412?v=3","gravatar_id":"","url":"https://api.github.com/users/jchristopher","html_url":"https://github.com/jchristopher","followers_url":"https://api.github.com/users/jchristopher/followers","following_url":"https://api.github.com/users/jchristopher/following{/other_user}","gists_url":"https://api.github.com/users/jchristopher/gists{/gist_id}","starred_url":"https://api.github.com/users/jchristopher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchristopher/subscriptions","organizations_url":"https://api.github.com/users/jchristopher/orgs","repos_url":"https://api.github.com/users/jchristopher/repos","events_url":"https://api.github.com/users/jchristopher/events{/privacy}","received_events_url":"https://api.github.com/users/jchristopher/received_events","type":"User","site_admin":false},"repo":{"id":47271070,"name":"custom-field-suite","full_name":"jchristopher/custom-field-suite","owner":{"login":"jchristopher","id":10412,"avatar_url":"https://avatars.githubusercontent.com/u/10412?v=3","gravatar_id":"","url":"https://api.github.com/users/jchristopher","html_url":"https://github.com/jchristopher","followers_url":"https://api.github.com/users/jchristopher/followers","following_url":"https://api.github.com/users/jchristopher/following{/other_user}","gists_url":"https://api.github.com/users/jchristopher/gists{/gist_id}","starred_url":"https://api.github.com/users/jchristopher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchristopher/subscriptions","organizations_url":"https://api.github.com/users/jchristopher/orgs","repos_url":"https://api.github.com/users/jchristopher/repos","events_url":"https://api.github.com/users/jchristopher/events{/privacy}","received_events_url":"https://api.github.com/users/jchristopher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jchristopher/custom-field-suite","description":"Custom fields UI for WordPress","fork":true,"url":"https://api.github.com/repos/jchristopher/custom-field-suite","forks_url":"https://api.github.com/repos/jchristopher/custom-field-suite/forks","keys_url":"https://api.github.com/repos/jchristopher/custom-field-suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jchristopher/custom-field-suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jchristopher/custom-field-suite/teams","hooks_url":"https://api.github.com/repos/jchristopher/custom-field-suite/hooks","issue_events_url":"https://api.github.com/repos/jchristopher/custom-field-suite/issues/events{/number}","events_url":"https://api.github.com/repos/jchristopher/custom-field-suite/events","assignees_url":"https://api.github.com/repos/jchristopher/custom-field-suite/assignees{/user}","branches_url":"https://api.github.com/repos/jchristopher/custom-field-suite/branches{/branch}","tags_url":"https://api.github.com/repos/jchristopher/custom-field-suite/tags","blobs_url":"https://api.github.com/repos/jchristopher/custom-field-suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jchristopher/custom-field-suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jchristopher/custom-field-suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/jchristopher/custom-field-suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jchristopher/custom-field-suite/statuses/{sha}","languages_url":"https://api.github.com/repos/jchristopher/custom-field-suite/languages","stargazers_url":"https://api.github.com/repos/jchristopher/custom-field-suite/stargazers","contributors_url":"https://api.github.com/repos/jchristopher/custom-field-suite/contributors","subscribers_url":"https://api.github.com/repos/jchristopher/custom-field-suite/subscribers","subscription_url":"https://api.github.com/repos/jchristopher/custom-field-suite/subscription","commits_url":"https://api.github.com/repos/jchristopher/custom-field-suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/jchristopher/custom-field-suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/jchristopher/custom-field-suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/jchristopher/custom-field-suite/issues/comments{/number}","contents_url":"https://api.github.com/repos/jchristopher/custom-field-suite/contents/{+path}","compare_url":"https://api.github.com/repos/jchristopher/custom-field-suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jchristopher/custom-field-suite/merges","archive_url":"https://api.github.com/repos/jchristopher/custom-field-suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jchristopher/custom-field-suite/downloads","issues_url":"https://api.github.com/repos/jchristopher/custom-field-suite/issues{/number}","pulls_url":"https://api.github.com/repos/jchristopher/custom-field-suite/pulls{/number}","milestones_url":"https://api.github.com/repos/jchristopher/custom-field-suite/milestones{/number}","notifications_url":"https://api.github.com/repos/jchristopher/custom-field-suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jchristopher/custom-field-suite/labels{/name}","releases_url":"https://api.github.com/repos/jchristopher/custom-field-suite/releases{/id}","created_at":"2015-12-02T15:45:52Z","updated_at":"2015-12-02T15:45:53Z","pushed_at":"2015-12-02T15:48:52Z","git_url":"git://github.com/jchristopher/custom-field-suite.git","ssh_url":"git@github.com:jchristopher/custom-field-suite.git","clone_url":"https://github.com/jchristopher/custom-field-suite.git","svn_url":"https://github.com/jchristopher/custom-field-suite","homepage":"http://customfieldsuite.com","size":1707,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mgibbs189:master","ref":"master","sha":"f297d4c2c648cfc499c170da1dbaef9affb3d541","user":{"login":"mgibbs189","id":115410,"avatar_url":"https://avatars.githubusercontent.com/u/115410?v=3","gravatar_id":"","url":"https://api.github.com/users/mgibbs189","html_url":"https://github.com/mgibbs189","followers_url":"https://api.github.com/users/mgibbs189/followers","following_url":"https://api.github.com/users/mgibbs189/following{/other_user}","gists_url":"https://api.github.com/users/mgibbs189/gists{/gist_id}","starred_url":"https://api.github.com/users/mgibbs189/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgibbs189/subscriptions","organizations_url":"https://api.github.com/users/mgibbs189/orgs","repos_url":"https://api.github.com/users/mgibbs189/repos","events_url":"https://api.github.com/users/mgibbs189/events{/privacy}","received_events_url":"https://api.github.com/users/mgibbs189/received_events","type":"User","site_admin":false},"repo":{"id":4675169,"name":"custom-field-suite","full_name":"mgibbs189/custom-field-suite","owner":{"login":"mgibbs189","id":115410,"avatar_url":"https://avatars.githubusercontent.com/u/115410?v=3","gravatar_id":"","url":"https://api.github.com/users/mgibbs189","html_url":"https://github.com/mgibbs189","followers_url":"https://api.github.com/users/mgibbs189/followers","following_url":"https://api.github.com/users/mgibbs189/following{/other_user}","gists_url":"https://api.github.com/users/mgibbs189/gists{/gist_id}","starred_url":"https://api.github.com/users/mgibbs189/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgibbs189/subscriptions","organizations_url":"https://api.github.com/users/mgibbs189/orgs","repos_url":"https://api.github.com/users/mgibbs189/repos","events_url":"https://api.github.com/users/mgibbs189/events{/privacy}","received_events_url":"https://api.github.com/users/mgibbs189/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgibbs189/custom-field-suite","description":"Custom fields UI for WordPress","fork":false,"url":"https://api.github.com/repos/mgibbs189/custom-field-suite","forks_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/forks","keys_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/teams","hooks_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/hooks","issue_events_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/issues/events{/number}","events_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/events","assignees_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/assignees{/user}","branches_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/branches{/branch}","tags_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/tags","blobs_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/statuses/{sha}","languages_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/languages","stargazers_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/stargazers","contributors_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/contributors","subscribers_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/subscribers","subscription_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/subscription","commits_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/contents/{+path}","compare_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/merges","archive_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/downloads","issues_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/issues{/number}","pulls_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/pulls{/number}","milestones_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/milestones{/number}","notifications_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/labels{/name}","releases_url":"https://api.github.com/repos/mgibbs189/custom-field-suite/releases{/id}","created_at":"2012-06-15T12:57:09Z","updated_at":"2015-11-26T11:35:14Z","pushed_at":"2015-11-17T15:24:14Z","git_url":"git://github.com/mgibbs189/custom-field-suite.git","ssh_url":"git@github.com:mgibbs189/custom-field-suite.git","clone_url":"https://github.com/mgibbs189/custom-field-suite.git","svn_url":"https://github.com/mgibbs189/custom-field-suite","homepage":"http://customfieldsuite.com","size":1966,"stargazers_count":166,"watchers_count":166,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":47,"mirror_url":null,"open_issues_count":13,"forks":47,"open_issues":13,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mgibbs189/custom-field-suite/pulls/299"},"html":{"href":"https://github.com/mgibbs189/custom-field-suite/pull/299"},"issue":{"href":"https://api.github.com/repos/mgibbs189/custom-field-suite/issues/299"},"comments":{"href":"https://api.github.com/repos/mgibbs189/custom-field-suite/issues/299/comments"},"review_comments":{"href":"https://api.github.com/repos/mgibbs189/custom-field-suite/pulls/299/comments"},"review_comment":{"href":"https://api.github.com/repos/mgibbs189/custom-field-suite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mgibbs189/custom-field-suite/pulls/299/commits"},"statuses":{"href":"https://api.github.com/repos/mgibbs189/custom-field-suite/statuses/ac227c92ab10522b8a3d4d7f0e09753839bc8e9d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}