{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/27635908","id":27635908,"diff_hunk":"@@ -2603,13 +2601,6 @@ impl<'a> Parser<'a> {\n     pub fn parse_more_binops(&mut self, lhs: P<Expr>, min_prec: usize) -> P<Expr> {\n         if self.expr_is_complete(&*lhs) { return lhs; }\n \n-        // Prevent dynamic borrow errors later on by limiting the\n-        // scope of the borrows.\n-        if self.token == token::BinOp(token::Or) &&\n-            self.restrictions.contains(RESTRICTION_NO_BAR_OP) {\n-            return lhs;\n-        }","path":"src/libsyntax/parse/parser.rs","position":34,"original_position":34,"commit_id":"d9a0ca01f3938efbb34587e3f52214d8c0bc1624","original_commit_id":"d9a0ca01f3938efbb34587e3f52214d8c0bc1624","user":{"login":"petrochenkov","id":5751617,"avatar_url":"https://avatars.githubusercontent.com/u/5751617?v=3","gravatar_id":"","url":"https://api.github.com/users/petrochenkov","html_url":"https://github.com/petrochenkov","followers_url":"https://api.github.com/users/petrochenkov/followers","following_url":"https://api.github.com/users/petrochenkov/following{/other_user}","gists_url":"https://api.github.com/users/petrochenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/petrochenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrochenkov/subscriptions","organizations_url":"https://api.github.com/users/petrochenkov/orgs","repos_url":"https://api.github.com/users/petrochenkov/repos","events_url":"https://api.github.com/users/petrochenkov/events{/privacy}","received_events_url":"https://api.github.com/users/petrochenkov/received_events","type":"User","site_admin":false},"body":"Flag RESTRICTION_NO_BAR_OP is checked here but it isn't set anywhere, so I removed the check and the flag itself. RESTRICTION_NO_BAR_OP was used before in `parse_pat`, see my line comments there.","created_at":"2015-04-02T06:59:44Z","updated_at":"2015-04-02T06:59:44Z","html_url":"https://github.com/rust-lang/rust/pull/23930#discussion_r27635908","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/23930","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/27635908"},"html":{"href":"https://github.com/rust-lang/rust/pull/23930#discussion_r27635908"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/23930"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/23930","id":32385132,"html_url":"https://github.com/rust-lang/rust/pull/23930","diff_url":"https://github.com/rust-lang/rust/pull/23930.diff","patch_url":"https://github.com/rust-lang/rust/pull/23930.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/23930","number":23930,"state":"open","locked":false,"title":"syntax: Rewrite parsing of patterns","user":{"login":"petrochenkov","id":5751617,"avatar_url":"https://avatars.githubusercontent.com/u/5751617?v=3","gravatar_id":"","url":"https://api.github.com/users/petrochenkov","html_url":"https://github.com/petrochenkov","followers_url":"https://api.github.com/users/petrochenkov/followers","following_url":"https://api.github.com/users/petrochenkov/following{/other_user}","gists_url":"https://api.github.com/users/petrochenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/petrochenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrochenkov/subscriptions","organizations_url":"https://api.github.com/users/petrochenkov/orgs","repos_url":"https://api.github.com/users/petrochenkov/repos","events_url":"https://api.github.com/users/petrochenkov/events{/privacy}","received_events_url":"https://api.github.com/users/petrochenkov/received_events","type":"User","site_admin":false},"body":"Fixes #22757\r\nFixes #22972\r\nFixes #23044\r\nFixes #23151\r\nFixes #23597\r\nFixes #23656\r\nFixes #23929\r\nIt also fixes some other corner cases in range patterns, like incorrect spans or not accepting global paths after `...`.\r\n\r\nIt passes `make check` but needs some additional tests (then it will fix #22546 as well), I'll write them today or tomorrow.","created_at":"2015-04-01T02:49:23Z","updated_at":"2015-04-02T06:59:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"564562147c95f8c453245a69acbfbad5bf86b99d","assignee":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/23930/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/23930/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/23930/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/d9a0ca01f3938efbb34587e3f52214d8c0bc1624","head":{"label":"petrochenkov:issue23656","ref":"issue23656","sha":"d9a0ca01f3938efbb34587e3f52214d8c0bc1624","user":{"login":"petrochenkov","id":5751617,"avatar_url":"https://avatars.githubusercontent.com/u/5751617?v=3","gravatar_id":"","url":"https://api.github.com/users/petrochenkov","html_url":"https://github.com/petrochenkov","followers_url":"https://api.github.com/users/petrochenkov/followers","following_url":"https://api.github.com/users/petrochenkov/following{/other_user}","gists_url":"https://api.github.com/users/petrochenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/petrochenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrochenkov/subscriptions","organizations_url":"https://api.github.com/users/petrochenkov/orgs","repos_url":"https://api.github.com/users/petrochenkov/repos","events_url":"https://api.github.com/users/petrochenkov/events{/privacy}","received_events_url":"https://api.github.com/users/petrochenkov/received_events","type":"User","site_admin":false},"repo":{"id":26977039,"name":"rust","full_name":"petrochenkov/rust","owner":{"login":"petrochenkov","id":5751617,"avatar_url":"https://avatars.githubusercontent.com/u/5751617?v=3","gravatar_id":"","url":"https://api.github.com/users/petrochenkov","html_url":"https://github.com/petrochenkov","followers_url":"https://api.github.com/users/petrochenkov/followers","following_url":"https://api.github.com/users/petrochenkov/following{/other_user}","gists_url":"https://api.github.com/users/petrochenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/petrochenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrochenkov/subscriptions","organizations_url":"https://api.github.com/users/petrochenkov/orgs","repos_url":"https://api.github.com/users/petrochenkov/repos","events_url":"https://api.github.com/users/petrochenkov/events{/privacy}","received_events_url":"https://api.github.com/users/petrochenkov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petrochenkov/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/petrochenkov/rust","forks_url":"https://api.github.com/repos/petrochenkov/rust/forks","keys_url":"https://api.github.com/repos/petrochenkov/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petrochenkov/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petrochenkov/rust/teams","hooks_url":"https://api.github.com/repos/petrochenkov/rust/hooks","issue_events_url":"https://api.github.com/repos/petrochenkov/rust/issues/events{/number}","events_url":"https://api.github.com/repos/petrochenkov/rust/events","assignees_url":"https://api.github.com/repos/petrochenkov/rust/assignees{/user}","branches_url":"https://api.github.com/repos/petrochenkov/rust/branches{/branch}","tags_url":"https://api.github.com/repos/petrochenkov/rust/tags","blobs_url":"https://api.github.com/repos/petrochenkov/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petrochenkov/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petrochenkov/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/petrochenkov/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petrochenkov/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/petrochenkov/rust/languages","stargazers_url":"https://api.github.com/repos/petrochenkov/rust/stargazers","contributors_url":"https://api.github.com/repos/petrochenkov/rust/contributors","subscribers_url":"https://api.github.com/repos/petrochenkov/rust/subscribers","subscription_url":"https://api.github.com/repos/petrochenkov/rust/subscription","commits_url":"https://api.github.com/repos/petrochenkov/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/petrochenkov/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/petrochenkov/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/petrochenkov/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/petrochenkov/rust/contents/{+path}","compare_url":"https://api.github.com/repos/petrochenkov/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petrochenkov/rust/merges","archive_url":"https://api.github.com/repos/petrochenkov/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petrochenkov/rust/downloads","issues_url":"https://api.github.com/repos/petrochenkov/rust/issues{/number}","pulls_url":"https://api.github.com/repos/petrochenkov/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/petrochenkov/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/petrochenkov/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petrochenkov/rust/labels{/name}","releases_url":"https://api.github.com/repos/petrochenkov/rust/releases{/id}","created_at":"2014-11-21T20:39:20Z","updated_at":"2015-02-21T10:32:16Z","pushed_at":"2015-04-01T02:43:28Z","git_url":"git://github.com/petrochenkov/rust.git","ssh_url":"git@github.com:petrochenkov/rust.git","clone_url":"https://github.com/petrochenkov/rust.git","svn_url":"https://github.com/petrochenkov/rust","homepage":"http://www.rust-lang.org","size":261059,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"d754722a04b99fdcae0fd97fa2a4395521145ef2","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-04-02T05:08:00Z","pushed_at":"2015-04-02T06:29:37Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":533970,"stargazers_count":9931,"watchers_count":9931,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1929,"mirror_url":null,"open_issues_count":2029,"forks":1929,"open_issues":2029,"watchers":9931,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/23930"},"html":{"href":"https://github.com/rust-lang/rust/pull/23930"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/23930"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/23930/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/23930/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/23930/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/d9a0ca01f3938efbb34587e3f52214d8c0bc1624"}}}}