{"action":"opened","issue":{"url":"https://api.github.com/repos/dealii/dealii/issues/909","labels_url":"https://api.github.com/repos/dealii/dealii/issues/909/labels{/name}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/909/comments","events_url":"https://api.github.com/repos/dealii/dealii/issues/909/events","html_url":"https://github.com/dealii/dealii/issues/909","id":73911197,"number":909,"title":"MultipleParameterLoop::UserClass::declare_parameters(…) unused","user":{"login":"fsonner","id":12097488,"avatar_url":"https://avatars.githubusercontent.com/u/12097488?v=3","gravatar_id":"","url":"https://api.github.com/users/fsonner","html_url":"https://github.com/fsonner","followers_url":"https://api.github.com/users/fsonner/followers","following_url":"https://api.github.com/users/fsonner/following{/other_user}","gists_url":"https://api.github.com/users/fsonner/gists{/gist_id}","starred_url":"https://api.github.com/users/fsonner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsonner/subscriptions","organizations_url":"https://api.github.com/users/fsonner/orgs","repos_url":"https://api.github.com/users/fsonner/repos","events_url":"https://api.github.com/users/fsonner/events{/privacy}","received_events_url":"https://api.github.com/users/fsonner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-05-07T09:17:24Z","updated_at":"2015-05-07T09:17:24Z","closed_at":null,"body":"The class `MultipleParameterLoop::UserClass` declares the pure virtual function `declare_parameters(…)` but this function is never used in the library. Therefore I propose the removal of this function, even if it is considered best practice. \r\n\r\nIn the examples the function could then be made static, which prevents any confusion about whether or not the parameter declaration can use the problem object (currently answered through the comment `note: must be static member!`)."}}