{"action":"created","issue":{"url":"https://api.github.com/repos/iojs/io.js/issues/723","labels_url":"https://api.github.com/repos/iojs/io.js/issues/723/labels{/name}","comments_url":"https://api.github.com/repos/iojs/io.js/issues/723/comments","events_url":"https://api.github.com/repos/iojs/io.js/issues/723/events","html_url":"https://github.com/iojs/io.js/pull/723","id":56673198,"number":723,"title":"upgrade gyp and refactor openssl.gyp","user":{"login":"shigeki","id":782880,"avatar_url":"https://avatars.githubusercontent.com/u/782880?v=3","gravatar_id":"","url":"https://api.github.com/users/shigeki","html_url":"https://github.com/shigeki","followers_url":"https://api.github.com/users/shigeki/followers","following_url":"https://api.github.com/users/shigeki/following{/other_user}","gists_url":"https://api.github.com/users/shigeki/gists{/gist_id}","starred_url":"https://api.github.com/users/shigeki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shigeki/subscriptions","organizations_url":"https://api.github.com/users/shigeki/orgs","repos_url":"https://api.github.com/users/shigeki/repos","events_url":"https://api.github.com/users/shigeki/events{/privacy}","received_events_url":"https://api.github.com/users/shigeki/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2015-02-05T13:59:09Z","updated_at":"2015-03-02T04:55:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/iojs/io.js/pulls/723","html_url":"https://github.com/iojs/io.js/pull/723","diff_url":"https://github.com/iojs/io.js/pull/723.diff","patch_url":"https://github.com/iojs/io.js/pull/723.patch"},"body":"I would like to use openssl-1.0.2 on iojs but openssl.gyp is so large and complicated that I think it need some refactoring before updating to openssl-1.0.2.\r\n\r\nThis PR has the following commits as\r\n- upgrade gyp to use else if conditions as supported in https://codereview.chromium.org/601353002\r\n- move all openssl sources into openssl.gypi\r\n- refactor openssl.gyp so as to switch target_arch and OS with \"else if\" condition and move most of defines to gypi.\r\n\r\nTesting is hard to confirm this in all platforms. I made two tests as below.\r\n-  Comparing all diffs of out/deps/openssl/openssl.target.mk with configure --dest-CPU=[win mac solaris freebsd openbsd linux android] --dest-os=[arm ia32 x32 x64] between before and after this PR and there is no difference in makefiles. In windows, there are small diffs in openssl.vcxprj , but it comes from updating gyp.\r\n- Build and make test on linux-x86_64, linux-x86, MacOS-x86_64, Win-x86_64.  All tests were passed.\r\n\r\nWIP branch for openssl102 is in https://github.com/shigeki/io.js/tree/WIP_upgrade_openssl102 . It's working on only x86_64 of Linux and MacOSX.\r\n\r\nCC: @bnoordhuis @indutny \r\n"},"comment":{"url":"https://api.github.com/repos/iojs/io.js/issues/comments/76658583","html_url":"https://github.com/iojs/io.js/pull/723#issuecomment-76658583","issue_url":"https://api.github.com/repos/iojs/io.js/issues/723","id":76658583,"user":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=3","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"created_at":"2015-03-02T04:55:04Z","updated_at":"2015-03-02T04:55:04Z","body":"@shigeki not so simple because it's behind a jump-host on the Linaro cluster. I might be able to set up a tunnel for you to work with but I'd better check out the Linaro terms before I go doing that! Leave it with me, in the mean time feel free to make branches on your io.js fork and point me to them to try out."}}