{"action":"created","comment":{"url":"https://api.github.com/repos/lutece-platform/lutece-core/pulls/comments/35315321","id":35315321,"diff_hunk":"@@ -50,7 +53,10 @@\n     <bean id=\"siteMessageHandler\" class=\"fr.paris.lutece.portal.service.message.SiteMessageHandler\"/>\n \n     <!--                      Search Engine                                   -->\n-    <bean id=\"searchEngine\" class=\"fr.paris.lutece.portal.service.search.LuceneSearchEngine\" />\n+    <bean id=\"searchEngine\" class=\"fr.paris.lutece.portal.service.search.LuceneSearchEngine\">\n+        <aop:scoped-proxy proxy-target-class=\"false\" />","path":"webapp/WEB-INF/conf/core_context.xml","position":23,"original_position":23,"commit_id":"a9afdbe7b246d0bd24f36b332c9cefccc45a6bd0","original_commit_id":"a9afdbe7b246d0bd24f36b332c9cefccc45a6bd0","user":{"login":"rzara","id":9724888,"avatar_url":"https://avatars.githubusercontent.com/u/9724888?v=3","gravatar_id":"","url":"https://api.github.com/users/rzara","html_url":"https://github.com/rzara","followers_url":"https://api.github.com/users/rzara/followers","following_url":"https://api.github.com/users/rzara/following{/other_user}","gists_url":"https://api.github.com/users/rzara/gists{/gist_id}","starred_url":"https://api.github.com/users/rzara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzara/subscriptions","organizations_url":"https://api.github.com/users/rzara/orgs","repos_url":"https://api.github.com/users/rzara/repos","events_url":"https://api.github.com/users/rzara/events{/privacy}","received_events_url":"https://api.github.com/users/rzara/received_events","type":"User","site_admin":false},"body":"Without it, the bean is injected directly, but we need a serializable proxy because XPage applications are stored in session. \n\nIf you don't need session serialization, you can omit it. \n\n\n> Le 23 juil. 2015 à 12:41, Jon Harper <notifications@github.com> a écrit :\n> \n> In webapp/WEB-INF/conf/core_context.xml:\n> \n> > @@ -50,7 +53,10 @@\n> >      <bean id=\"siteMessageHandler\" class=\"fr.paris.lutece.portal.service.message.SiteMessageHandler\"/>\n> >  \n> >      <!--                      Search Engine                                   -->\n> > -    <bean id=\"searchEngine\" class=\"fr.paris.lutece.portal.service.search.LuceneSearchEngine\" />\n> > +    <bean id=\"searchEngine\" class=\"fr.paris.lutece.portal.service.search.LuceneSearchEngine\">\n> > +        <aop:scoped-proxy proxy-target-class=\"false\" />\n> According to http://docs.spring.io/spring/docs/current/spring-framework-reference/html/beans.html#beans-factory-scopes-other-injection\n> \n> You do not need to use the aop:scoped-proxy/ in conjunction with beans that are scoped as singletons or prototypes. It is an error to try to create a scoped proxy for a singleton bean (and the resulting BeanCreationException will certainly set you straight in this regard).\n> \n> It's the same for the version we use (3.1.x). Did you add it to fix a problem ?\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n","created_at":"2015-07-23T12:22:57Z","updated_at":"2015-07-23T12:22:57Z","html_url":"https://github.com/lutece-platform/lutece-core/pull/27#discussion_r35315321","pull_request_url":"https://api.github.com/repos/lutece-platform/lutece-core/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/lutece-platform/lutece-core/pulls/comments/35315321"},"html":{"href":"https://github.com/lutece-platform/lutece-core/pull/27#discussion_r35315321"},"pull_request":{"href":"https://api.github.com/repos/lutece-platform/lutece-core/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/lutece-platform/lutece-core/pulls/27","id":31913185,"html_url":"https://github.com/lutece-platform/lutece-core/pull/27","diff_url":"https://github.com/lutece-platform/lutece-core/pull/27.diff","patch_url":"https://github.com/lutece-platform/lutece-core/pull/27.patch","issue_url":"https://api.github.com/repos/lutece-platform/lutece-core/issues/27","number":27,"state":"open","locked":false,"title":"Lutece 1889 : Allow XPageApplications to be managed by Spring","user":{"login":"rzara","id":9724888,"avatar_url":"https://avatars.githubusercontent.com/u/9724888?v=3","gravatar_id":"","url":"https://api.github.com/users/rzara","html_url":"https://github.com/rzara","followers_url":"https://api.github.com/users/rzara/followers","following_url":"https://api.github.com/users/rzara/following{/other_user}","gists_url":"https://api.github.com/users/rzara/gists{/gist_id}","starred_url":"https://api.github.com/users/rzara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzara/subscriptions","organizations_url":"https://api.github.com/users/rzara/orgs","repos_url":"https://api.github.com/users/rzara/repos","events_url":"https://api.github.com/users/rzara/events{/privacy}","received_events_url":"https://api.github.com/users/rzara/received_events","type":"User","site_admin":false},"body":"This will allow to use spring facilities to configure page objects (dependency injection, etc.)\r\nConvert SearchApp over.","created_at":"2015-03-25T11:25:19Z","updated_at":"2015-07-23T12:22:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"070f5a3361434682aca90f2a0464a7ab532cbc11","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lutece-platform/lutece-core/pulls/27/commits","review_comments_url":"https://api.github.com/repos/lutece-platform/lutece-core/pulls/27/comments","review_comment_url":"https://api.github.com/repos/lutece-platform/lutece-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lutece-platform/lutece-core/issues/27/comments","statuses_url":"https://api.github.com/repos/lutece-platform/lutece-core/statuses/a9afdbe7b246d0bd24f36b332c9cefccc45a6bd0","head":{"label":"rzara:LUTECE-1889","ref":"LUTECE-1889","sha":"a9afdbe7b246d0bd24f36b332c9cefccc45a6bd0","user":{"login":"rzara","id":9724888,"avatar_url":"https://avatars.githubusercontent.com/u/9724888?v=3","gravatar_id":"","url":"https://api.github.com/users/rzara","html_url":"https://github.com/rzara","followers_url":"https://api.github.com/users/rzara/followers","following_url":"https://api.github.com/users/rzara/following{/other_user}","gists_url":"https://api.github.com/users/rzara/gists{/gist_id}","starred_url":"https://api.github.com/users/rzara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzara/subscriptions","organizations_url":"https://api.github.com/users/rzara/orgs","repos_url":"https://api.github.com/users/rzara/repos","events_url":"https://api.github.com/users/rzara/events{/privacy}","received_events_url":"https://api.github.com/users/rzara/received_events","type":"User","site_admin":false},"repo":{"id":27344520,"name":"lutece-core","full_name":"rzara/lutece-core","owner":{"login":"rzara","id":9724888,"avatar_url":"https://avatars.githubusercontent.com/u/9724888?v=3","gravatar_id":"","url":"https://api.github.com/users/rzara","html_url":"https://github.com/rzara","followers_url":"https://api.github.com/users/rzara/followers","following_url":"https://api.github.com/users/rzara/following{/other_user}","gists_url":"https://api.github.com/users/rzara/gists{/gist_id}","starred_url":"https://api.github.com/users/rzara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzara/subscriptions","organizations_url":"https://api.github.com/users/rzara/orgs","repos_url":"https://api.github.com/users/rzara/repos","events_url":"https://api.github.com/users/rzara/events{/privacy}","received_events_url":"https://api.github.com/users/rzara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rzara/lutece-core","description":"Lutece Core","fork":true,"url":"https://api.github.com/repos/rzara/lutece-core","forks_url":"https://api.github.com/repos/rzara/lutece-core/forks","keys_url":"https://api.github.com/repos/rzara/lutece-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rzara/lutece-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rzara/lutece-core/teams","hooks_url":"https://api.github.com/repos/rzara/lutece-core/hooks","issue_events_url":"https://api.github.com/repos/rzara/lutece-core/issues/events{/number}","events_url":"https://api.github.com/repos/rzara/lutece-core/events","assignees_url":"https://api.github.com/repos/rzara/lutece-core/assignees{/user}","branches_url":"https://api.github.com/repos/rzara/lutece-core/branches{/branch}","tags_url":"https://api.github.com/repos/rzara/lutece-core/tags","blobs_url":"https://api.github.com/repos/rzara/lutece-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rzara/lutece-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rzara/lutece-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/rzara/lutece-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rzara/lutece-core/statuses/{sha}","languages_url":"https://api.github.com/repos/rzara/lutece-core/languages","stargazers_url":"https://api.github.com/repos/rzara/lutece-core/stargazers","contributors_url":"https://api.github.com/repos/rzara/lutece-core/contributors","subscribers_url":"https://api.github.com/repos/rzara/lutece-core/subscribers","subscription_url":"https://api.github.com/repos/rzara/lutece-core/subscription","commits_url":"https://api.github.com/repos/rzara/lutece-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/rzara/lutece-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/rzara/lutece-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/rzara/lutece-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/rzara/lutece-core/contents/{+path}","compare_url":"https://api.github.com/repos/rzara/lutece-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rzara/lutece-core/merges","archive_url":"https://api.github.com/repos/rzara/lutece-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rzara/lutece-core/downloads","issues_url":"https://api.github.com/repos/rzara/lutece-core/issues{/number}","pulls_url":"https://api.github.com/repos/rzara/lutece-core/pulls{/number}","milestones_url":"https://api.github.com/repos/rzara/lutece-core/milestones{/number}","notifications_url":"https://api.github.com/repos/rzara/lutece-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rzara/lutece-core/labels{/name}","releases_url":"https://api.github.com/repos/rzara/lutece-core/releases{/id}","created_at":"2014-11-30T17:51:09Z","updated_at":"2015-03-21T10:38:28Z","pushed_at":"2015-05-12T17:23:30Z","git_url":"git://github.com/rzara/lutece-core.git","ssh_url":"git@github.com:rzara/lutece-core.git","clone_url":"https://github.com/rzara/lutece-core.git","svn_url":"https://github.com/rzara/lutece-core","homepage":null,"size":19143,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lutece-platform:develop","ref":"develop","sha":"1b6591b1495e4c8f2528d1ee3dad31b09ee23bcf","user":{"login":"lutece-platform","id":8707688,"avatar_url":"https://avatars.githubusercontent.com/u/8707688?v=3","gravatar_id":"","url":"https://api.github.com/users/lutece-platform","html_url":"https://github.com/lutece-platform","followers_url":"https://api.github.com/users/lutece-platform/followers","following_url":"https://api.github.com/users/lutece-platform/following{/other_user}","gists_url":"https://api.github.com/users/lutece-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/lutece-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutece-platform/subscriptions","organizations_url":"https://api.github.com/users/lutece-platform/orgs","repos_url":"https://api.github.com/users/lutece-platform/repos","events_url":"https://api.github.com/users/lutece-platform/events{/privacy}","received_events_url":"https://api.github.com/users/lutece-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":27342068,"name":"lutece-core","full_name":"lutece-platform/lutece-core","owner":{"login":"lutece-platform","id":8707688,"avatar_url":"https://avatars.githubusercontent.com/u/8707688?v=3","gravatar_id":"","url":"https://api.github.com/users/lutece-platform","html_url":"https://github.com/lutece-platform","followers_url":"https://api.github.com/users/lutece-platform/followers","following_url":"https://api.github.com/users/lutece-platform/following{/other_user}","gists_url":"https://api.github.com/users/lutece-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/lutece-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutece-platform/subscriptions","organizations_url":"https://api.github.com/users/lutece-platform/orgs","repos_url":"https://api.github.com/users/lutece-platform/repos","events_url":"https://api.github.com/users/lutece-platform/events{/privacy}","received_events_url":"https://api.github.com/users/lutece-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lutece-platform/lutece-core","description":"Lutece Core","fork":false,"url":"https://api.github.com/repos/lutece-platform/lutece-core","forks_url":"https://api.github.com/repos/lutece-platform/lutece-core/forks","keys_url":"https://api.github.com/repos/lutece-platform/lutece-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lutece-platform/lutece-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lutece-platform/lutece-core/teams","hooks_url":"https://api.github.com/repos/lutece-platform/lutece-core/hooks","issue_events_url":"https://api.github.com/repos/lutece-platform/lutece-core/issues/events{/number}","events_url":"https://api.github.com/repos/lutece-platform/lutece-core/events","assignees_url":"https://api.github.com/repos/lutece-platform/lutece-core/assignees{/user}","branches_url":"https://api.github.com/repos/lutece-platform/lutece-core/branches{/branch}","tags_url":"https://api.github.com/repos/lutece-platform/lutece-core/tags","blobs_url":"https://api.github.com/repos/lutece-platform/lutece-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lutece-platform/lutece-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lutece-platform/lutece-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/lutece-platform/lutece-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lutece-platform/lutece-core/statuses/{sha}","languages_url":"https://api.github.com/repos/lutece-platform/lutece-core/languages","stargazers_url":"https://api.github.com/repos/lutece-platform/lutece-core/stargazers","contributors_url":"https://api.github.com/repos/lutece-platform/lutece-core/contributors","subscribers_url":"https://api.github.com/repos/lutece-platform/lutece-core/subscribers","subscription_url":"https://api.github.com/repos/lutece-platform/lutece-core/subscription","commits_url":"https://api.github.com/repos/lutece-platform/lutece-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/lutece-platform/lutece-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/lutece-platform/lutece-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/lutece-platform/lutece-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/lutece-platform/lutece-core/contents/{+path}","compare_url":"https://api.github.com/repos/lutece-platform/lutece-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lutece-platform/lutece-core/merges","archive_url":"https://api.github.com/repos/lutece-platform/lutece-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lutece-platform/lutece-core/downloads","issues_url":"https://api.github.com/repos/lutece-platform/lutece-core/issues{/number}","pulls_url":"https://api.github.com/repos/lutece-platform/lutece-core/pulls{/number}","milestones_url":"https://api.github.com/repos/lutece-platform/lutece-core/milestones{/number}","notifications_url":"https://api.github.com/repos/lutece-platform/lutece-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lutece-platform/lutece-core/labels{/name}","releases_url":"https://api.github.com/repos/lutece-platform/lutece-core/releases{/id}","created_at":"2014-11-30T16:26:59Z","updated_at":"2015-06-08T07:22:45Z","pushed_at":"2015-07-22T18:33:58Z","git_url":"git://github.com/lutece-platform/lutece-core.git","ssh_url":"git@github.com:lutece-platform/lutece-core.git","clone_url":"https://github.com/lutece-platform/lutece-core.git","svn_url":"https://github.com/lutece-platform/lutece-core","homepage":null,"size":19517,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lutece-platform/lutece-core/pulls/27"},"html":{"href":"https://github.com/lutece-platform/lutece-core/pull/27"},"issue":{"href":"https://api.github.com/repos/lutece-platform/lutece-core/issues/27"},"comments":{"href":"https://api.github.com/repos/lutece-platform/lutece-core/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/lutece-platform/lutece-core/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/lutece-platform/lutece-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lutece-platform/lutece-core/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/lutece-platform/lutece-core/statuses/a9afdbe7b246d0bd24f36b332c9cefccc45a6bd0"}}}}