{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph-deploy/pulls/comments/40732730","id":40732730,"diff_hunk":"@@ -312,35 +315,15 @@ def uninstall(args):\n             use_rhceph=True)\n         LOG.info('Distro info: %s %s %s', distro.name, distro.release, distro.codename)\n         rlogger = logging.getLogger(hostname)\n-        rlogger.info('uninstalling Ceph on %s' % hostname)\n-        distro.uninstall(distro)\n+        rlogger.info('%s Ceph on %s' % (remove_action, hostname))\n+        distro.uninstall(distro, purge)","path":"ceph_deploy/install.py","position":26,"original_position":26,"commit_id":"f6ce787f02e3ed0878c9a9c9ad2f0ad5ecc1612a","original_commit_id":"f6ce787f02e3ed0878c9a9c9ad2f0ad5ecc1612a","user":{"login":"trhoden","id":1627176,"avatar_url":"https://avatars.githubusercontent.com/u/1627176?v=3","gravatar_id":"","url":"https://api.github.com/users/trhoden","html_url":"https://github.com/trhoden","followers_url":"https://api.github.com/users/trhoden/followers","following_url":"https://api.github.com/users/trhoden/following{/other_user}","gists_url":"https://api.github.com/users/trhoden/gists{/gist_id}","starred_url":"https://api.github.com/users/trhoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trhoden/subscriptions","organizations_url":"https://api.github.com/users/trhoden/orgs","repos_url":"https://api.github.com/users/trhoden/repos","events_url":"https://api.github.com/users/trhoden/events{/privacy}","received_events_url":"https://api.github.com/users/trhoden/received_events","type":"User","site_admin":false},"body":"Would you be open to changing this line to: `distro.uninstall(distro, purge=purge)`?  `purge` is a kwarg here, and I would prefer to see that called out explicitly rather than it looking like a positional argument.","created_at":"2015-09-29T21:31:26Z","updated_at":"2015-09-29T21:31:26Z","html_url":"https://github.com/ceph/ceph-deploy/pull/359#discussion_r40732730","pull_request_url":"https://api.github.com/repos/ceph/ceph-deploy/pulls/359","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-deploy/pulls/comments/40732730"},"html":{"href":"https://github.com/ceph/ceph-deploy/pull/359#discussion_r40732730"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph-deploy/pulls/359"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph-deploy/pulls/359","id":45887580,"html_url":"https://github.com/ceph/ceph-deploy/pull/359","diff_url":"https://github.com/ceph/ceph-deploy/pull/359.diff","patch_url":"https://github.com/ceph/ceph-deploy/pull/359.patch","issue_url":"https://api.github.com/repos/ceph/ceph-deploy/issues/359","number":359,"state":"open","locked":false,"title":"install: functions \"uninstall\" and \"purge\" merged to function \"remove\"","user":{"login":"osynge","id":669365,"avatar_url":"https://avatars.githubusercontent.com/u/669365?v=3","gravatar_id":"","url":"https://api.github.com/users/osynge","html_url":"https://github.com/osynge","followers_url":"https://api.github.com/users/osynge/followers","following_url":"https://api.github.com/users/osynge/following{/other_user}","gists_url":"https://api.github.com/users/osynge/gists{/gist_id}","starred_url":"https://api.github.com/users/osynge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osynge/subscriptions","organizations_url":"https://api.github.com/users/osynge/orgs","repos_url":"https://api.github.com/users/osynge/repos","events_url":"https://api.github.com/users/osynge/events{/privacy}","received_events_url":"https://api.github.com/users/osynge/received_events","type":"User","site_admin":false},"body":"Before this patch functions \"uninstall\" and \"purge\" are almost identical.\r\nSince the only difference is the logging messages, and when the\r\ndistro.uninstall() function is called a boolean parameter set both these\r\nfunctions are merged into a single command \"remove\" with the parameter\r\npurge.\r\n\r\nSigned-off-by: Owen Synge <osynge@suse.com>","created_at":"2015-09-24T11:47:39Z","updated_at":"2015-09-29T21:31:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65631c6c573e013dc631e48a4a2936ce61577563","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph-deploy/pulls/359/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph-deploy/pulls/359/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph-deploy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph-deploy/issues/359/comments","statuses_url":"https://api.github.com/repos/ceph/ceph-deploy/statuses/f6ce787f02e3ed0878c9a9c9ad2f0ad5ecc1612a","head":{"label":"SUSE:wip_dry_uninstall_purge","ref":"wip_dry_uninstall_purge","sha":"f6ce787f02e3ed0878c9a9c9ad2f0ad5ecc1612a","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":38686248,"name":"ceph-deploy","full_name":"SUSE/ceph-deploy","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/ceph-deploy","description":"Deploy Ceph with minimal infrastructure, using just SSH access","fork":true,"url":"https://api.github.com/repos/SUSE/ceph-deploy","forks_url":"https://api.github.com/repos/SUSE/ceph-deploy/forks","keys_url":"https://api.github.com/repos/SUSE/ceph-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/ceph-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/ceph-deploy/teams","hooks_url":"https://api.github.com/repos/SUSE/ceph-deploy/hooks","issue_events_url":"https://api.github.com/repos/SUSE/ceph-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/ceph-deploy/events","assignees_url":"https://api.github.com/repos/SUSE/ceph-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/ceph-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/ceph-deploy/tags","blobs_url":"https://api.github.com/repos/SUSE/ceph-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/ceph-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/ceph-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/ceph-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/ceph-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/ceph-deploy/languages","stargazers_url":"https://api.github.com/repos/SUSE/ceph-deploy/stargazers","contributors_url":"https://api.github.com/repos/SUSE/ceph-deploy/contributors","subscribers_url":"https://api.github.com/repos/SUSE/ceph-deploy/subscribers","subscription_url":"https://api.github.com/repos/SUSE/ceph-deploy/subscription","commits_url":"https://api.github.com/repos/SUSE/ceph-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/ceph-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/ceph-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/ceph-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/ceph-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/ceph-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/ceph-deploy/merges","archive_url":"https://api.github.com/repos/SUSE/ceph-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/ceph-deploy/downloads","issues_url":"https://api.github.com/repos/SUSE/ceph-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/ceph-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/ceph-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/ceph-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/ceph-deploy/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/ceph-deploy/releases{/id}","created_at":"2015-07-07T12:30:28Z","updated_at":"2015-07-07T12:30:28Z","pushed_at":"2015-09-29T15:48:30Z","git_url":"git://github.com/SUSE/ceph-deploy.git","ssh_url":"git@github.com:SUSE/ceph-deploy.git","clone_url":"https://github.com/SUSE/ceph-deploy.git","svn_url":"https://github.com/SUSE/ceph-deploy","homepage":null,"size":2481,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"8cd1e4e03fddef953c67501573030cfedf5aa70d","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":5786856,"name":"ceph-deploy","full_name":"ceph/ceph-deploy","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-deploy","description":"Deploy Ceph with minimal infrastructure, using just SSH access","fork":false,"url":"https://api.github.com/repos/ceph/ceph-deploy","forks_url":"https://api.github.com/repos/ceph/ceph-deploy/forks","keys_url":"https://api.github.com/repos/ceph/ceph-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-deploy/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-deploy/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-deploy/events","assignees_url":"https://api.github.com/repos/ceph/ceph-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-deploy/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-deploy/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-deploy/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-deploy/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-deploy/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-deploy/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-deploy/merges","archive_url":"https://api.github.com/repos/ceph/ceph-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-deploy/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-deploy/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-deploy/releases{/id}","created_at":"2012-09-12T22:30:24Z","updated_at":"2015-09-13T03:36:49Z","pushed_at":"2015-09-29T15:48:31Z","git_url":"git://github.com/ceph/ceph-deploy.git","ssh_url":"git@github.com:ceph/ceph-deploy.git","clone_url":"https://github.com/ceph/ceph-deploy.git","svn_url":"https://github.com/ceph/ceph-deploy","homepage":null,"size":5432,"stargazers_count":114,"watchers_count":114,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":117,"mirror_url":null,"open_issues_count":18,"forks":117,"open_issues":18,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-deploy/pulls/359"},"html":{"href":"https://github.com/ceph/ceph-deploy/pull/359"},"issue":{"href":"https://api.github.com/repos/ceph/ceph-deploy/issues/359"},"comments":{"href":"https://api.github.com/repos/ceph/ceph-deploy/issues/359/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph-deploy/pulls/359/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph-deploy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph-deploy/pulls/359/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph-deploy/statuses/f6ce787f02e3ed0878c9a9c9ad2f0ad5ecc1612a"}}}}