{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/26006062","id":26006062,"diff_hunk":"@@ -79,14 +79,7 @@ def console\n     @compute_resource = find_compute_resource(:console_compute_resources_vms)\n     @vm = find_vm\n     @console = @compute_resource.console @vm.identity\n-    @encrypt = case Setting[:websockets_encrypt]\n-               when 'on'\n-                 true\n-               when 'off'\n-                 false\n-               else","path":"app/controllers/compute_resources_vms_controller.rb","position":9,"original_position":9,"commit_id":"d7d8a4a0e24c9e090e27c24b72801d5dd01f5f58","original_commit_id":"d7d8a4a0e24c9e090e27c24b72801d5dd01f5f58","user":{"login":"eLobato","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=3","gravatar_id":"","url":"https://api.github.com/users/eLobato","html_url":"https://github.com/eLobato","followers_url":"https://api.github.com/users/eLobato/followers","following_url":"https://api.github.com/users/eLobato/following{/other_user}","gists_url":"https://api.github.com/users/eLobato/gists{/gist_id}","starred_url":"https://api.github.com/users/eLobato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eLobato/subscriptions","organizations_url":"https://api.github.com/users/eLobato/orgs","repos_url":"https://api.github.com/users/eLobato/repos","events_url":"https://api.github.com/users/eLobato/events{/privacy}","received_events_url":"https://api.github.com/users/eLobato/received_events","type":"User","site_admin":false},"body":"This is what the `auto` setting was supposed to do, however it seems like it would not honor `websockets_encrypt = off` as you pointed out. ","created_at":"2015-03-08T15:34:41Z","updated_at":"2015-03-08T15:34:41Z","html_url":"https://github.com/theforeman/foreman/pull/2219#discussion_r26006062","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/2219","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/26006062"},"html":{"href":"https://github.com/theforeman/foreman/pull/2219#discussion_r26006062"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2219"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/2219","id":30282976,"html_url":"https://github.com/theforeman/foreman/pull/2219","diff_url":"https://github.com/theforeman/foreman/pull/2219.diff","patch_url":"https://github.com/theforeman/foreman/pull/2219.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/2219","number":2219,"state":"open","locked":false,"title":"Fixed #9603 - fixed websockets_* set of settings","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"body":"Basically `websockets_encrypt` setting did not work at all. Initially I thought\nthe only change is not to use certificates when websockets_encrypt is set to\nfalse, but it looks the whole setting handling is incorrect. There are \"on\" and\n\"off\" switch/case statements which are (no longer?) correct. The setting is\nread-only, defined in the settings.yaml and type of boolean.\n\nThis fixes it completely.","created_at":"2015-03-02T13:30:09Z","updated_at":"2015-03-08T15:34:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d59b7f1af9d0a653c68f89dfe661883ed8b816ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/2219/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/2219/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/2219/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/d7d8a4a0e24c9e090e27c24b72801d5dd01f5f58","head":{"label":"lzap:websockets-proxy-9603","ref":"websockets-proxy-9603","sha":"d7d8a4a0e24c9e090e27c24b72801d5dd01f5f58","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"repo":{"id":1410439,"name":"foreman","full_name":"lzap/foreman","owner":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lzap/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/lzap/foreman","forks_url":"https://api.github.com/repos/lzap/foreman/forks","keys_url":"https://api.github.com/repos/lzap/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lzap/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lzap/foreman/teams","hooks_url":"https://api.github.com/repos/lzap/foreman/hooks","issue_events_url":"https://api.github.com/repos/lzap/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/lzap/foreman/events","assignees_url":"https://api.github.com/repos/lzap/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/lzap/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/lzap/foreman/tags","blobs_url":"https://api.github.com/repos/lzap/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lzap/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lzap/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/lzap/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lzap/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/lzap/foreman/languages","stargazers_url":"https://api.github.com/repos/lzap/foreman/stargazers","contributors_url":"https://api.github.com/repos/lzap/foreman/contributors","subscribers_url":"https://api.github.com/repos/lzap/foreman/subscribers","subscription_url":"https://api.github.com/repos/lzap/foreman/subscription","commits_url":"https://api.github.com/repos/lzap/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/lzap/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/lzap/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/lzap/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/lzap/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/lzap/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lzap/foreman/merges","archive_url":"https://api.github.com/repos/lzap/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lzap/foreman/downloads","issues_url":"https://api.github.com/repos/lzap/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/lzap/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/lzap/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/lzap/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lzap/foreman/labels{/name}","releases_url":"https://api.github.com/repos/lzap/foreman/releases{/id}","created_at":"2011-02-25T10:13:00Z","updated_at":"2014-06-19T15:16:06Z","pushed_at":"2015-03-05T14:47:29Z","git_url":"git://github.com/lzap/foreman.git","ssh_url":"git@github.com:lzap/foreman.git","clone_url":"https://github.com/lzap/foreman.git","svn_url":"https://github.com/lzap/foreman","homepage":"http://theforeman.org","size":23819,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"6d05514ad02676067389f44c4ba1d3daf357884b","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","created_at":"2009-07-23T15:07:00Z","updated_at":"2015-03-08T13:20:49Z","pushed_at":"2015-03-08T13:20:49Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":70873,"stargazers_count":684,"watchers_count":684,"language":"Gettext Catalog","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":368,"mirror_url":null,"open_issues_count":89,"forks":368,"open_issues":89,"watchers":684,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2219"},"html":{"href":"https://github.com/theforeman/foreman/pull/2219"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2219"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2219/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2219/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2219/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/d7d8a4a0e24c9e090e27c24b72801d5dd01f5f58"}}}}