{"action":"created","issue":{"url":"https://api.github.com/repos/bcsgsvn/finance/issues/39","labels_url":"https://api.github.com/repos/bcsgsvn/finance/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/bcsgsvn/finance/issues/39/comments","events_url":"https://api.github.com/repos/bcsgsvn/finance/issues/39/events","html_url":"https://github.com/bcsgsvn/finance/pull/39","id":103144577,"number":39,"title":"Fixing Issue #38","user":{"login":"weshatheleopard","id":3384534,"avatar_url":"https://avatars.githubusercontent.com/u/3384534?v=3","gravatar_id":"","url":"https://api.github.com/users/weshatheleopard","html_url":"https://github.com/weshatheleopard","followers_url":"https://api.github.com/users/weshatheleopard/followers","following_url":"https://api.github.com/users/weshatheleopard/following{/other_user}","gists_url":"https://api.github.com/users/weshatheleopard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshatheleopard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshatheleopard/subscriptions","organizations_url":"https://api.github.com/users/weshatheleopard/orgs","repos_url":"https://api.github.com/users/weshatheleopard/repos","events_url":"https://api.github.com/users/weshatheleopard/events{/privacy}","received_events_url":"https://api.github.com/users/weshatheleopard/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-26T00:33:35Z","updated_at":"2015-12-01T16:10:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bcsgsvn/finance/pulls/39","html_url":"https://github.com/bcsgsvn/finance/pull/39","diff_url":"https://github.com/bcsgsvn/finance/pull/39.diff","patch_url":"https://github.com/bcsgsvn/finance/pull/39.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/bcsgsvn/finance/issues/comments/161015605","html_url":"https://github.com/bcsgsvn/finance/pull/39#issuecomment-161015605","issue_url":"https://api.github.com/repos/bcsgsvn/finance/issues/39","id":161015605,"user":{"login":"marksweston","id":392071,"avatar_url":"https://avatars.githubusercontent.com/u/392071?v=3","gravatar_id":"","url":"https://api.github.com/users/marksweston","html_url":"https://github.com/marksweston","followers_url":"https://api.github.com/users/marksweston/followers","following_url":"https://api.github.com/users/marksweston/following{/other_user}","gists_url":"https://api.github.com/users/marksweston/gists{/gist_id}","starred_url":"https://api.github.com/users/marksweston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marksweston/subscriptions","organizations_url":"https://api.github.com/users/marksweston/orgs","repos_url":"https://api.github.com/users/marksweston/repos","events_url":"https://api.github.com/users/marksweston/events{/privacy}","received_events_url":"https://api.github.com/users/marksweston/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T16:10:37Z","updated_at":"2015-12-01T16:10:37Z","body":"Firstly, sorry for being later than promised with this review.\r\n\r\nYour diagnosis of the problem and your fix make sense to me, within my limited understanding of the algorithm.  \r\n\r\nHowever, one of your new tests is failing for me, repeatedly.\r\n\r\n>finance @ Marks-Mac-mini (eligoenergy-master)$ ruby test/test_cashflows.rb\r\n>Run options: --seed 38870\r\n>\r\n>Running:\r\n>\r\n>...F..\r\n>\r\n>Finished in 0.601733s, 9.9712 runs/s, 111.3451 assertions/s.\r\n>\r\n>  1) Failure:\r\n>Cashflows::an array of Transactions#test_0003_should properly calculate IRR when Complex numbers >arise from calculations [test/test_cashflows.rb:36]:\r\n>Expected: DecNum('0.085677')\r\n>  Actual: DecNum('0.085675')\r\n>\r\n>6 runs, 67 assertions, 1 failures, 0 errors, 0 skips\r\n\r\nCould you take a look at this please?\r\n"}}