{"action":"opened","number":871,"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/871","id":28032107,"html_url":"https://github.com/ethereum/cpp-ethereum/pull/871","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/871.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/871.patch","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/871","number":871,"state":"open","locked":false,"title":"new tests for libdevcore/CommonJS (failing)","user":{"login":"debris","id":2613714,"avatar_url":"https://avatars.githubusercontent.com/u/2613714?v=3","gravatar_id":"","url":"https://api.github.com/users/debris","html_url":"https://github.com/debris","followers_url":"https://api.github.com/users/debris/followers","following_url":"https://api.github.com/users/debris/following{/other_user}","gists_url":"https://api.github.com/users/debris/gists{/gist_id}","starred_url":"https://api.github.com/users/debris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debris/subscriptions","organizations_url":"https://api.github.com/users/debris/orgs","repos_url":"https://api.github.com/users/debris/repos","events_url":"https://api.github.com/users/debris/events{/privacy}","received_events_url":"https://api.github.com/users/debris/received_events","type":"User","site_admin":false},"body":"new tests for libdevcore/CommonJS\r\njsToPublic && jsToSecret tests are failing. That's caused by recent changes in CommonJS.h\r\n\r\n```cpp\r\nreturn FixedHash<N>(_s.substr(2));\r\n```\r\n\r\nwas altered to\r\n\r\n```cpp\r\nreturn FixedHash<N>(_s.substr(2 + std::max<unsigned>(40, _s.size() - 2) - 40));\r\n```\r\n\r\n[link](https://github.com/ethereum/cpp-ethereum/blob/develop/libdevcore/CommonJS.h#L68)\r\n\r\nThis introduces issues for multiple *ethereum.js* methods using public keys.","created_at":"2015-01-26T15:00:46Z","updated_at":"2015-01-26T15:00:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/871/commits","review_comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/871/comments","review_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/871/comments","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/04f45fb1a58253b93b14bc1b67004f4763a1833b","head":{"label":"debris:commonjs_tests","ref":"commonjs_tests","sha":"04f45fb1a58253b93b14bc1b67004f4763a1833b","user":{"login":"debris","id":2613714,"avatar_url":"https://avatars.githubusercontent.com/u/2613714?v=3","gravatar_id":"","url":"https://api.github.com/users/debris","html_url":"https://github.com/debris","followers_url":"https://api.github.com/users/debris/followers","following_url":"https://api.github.com/users/debris/following{/other_user}","gists_url":"https://api.github.com/users/debris/gists{/gist_id}","starred_url":"https://api.github.com/users/debris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debris/subscriptions","organizations_url":"https://api.github.com/users/debris/orgs","repos_url":"https://api.github.com/users/debris/repos","events_url":"https://api.github.com/users/debris/events{/privacy}","received_events_url":"https://api.github.com/users/debris/received_events","type":"User","site_admin":false},"repo":{"id":25056321,"name":"cpp-ethereum","full_name":"debris/cpp-ethereum","owner":{"login":"debris","id":2613714,"avatar_url":"https://avatars.githubusercontent.com/u/2613714?v=3","gravatar_id":"","url":"https://api.github.com/users/debris","html_url":"https://github.com/debris","followers_url":"https://api.github.com/users/debris/followers","following_url":"https://api.github.com/users/debris/following{/other_user}","gists_url":"https://api.github.com/users/debris/gists{/gist_id}","starred_url":"https://api.github.com/users/debris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debris/subscriptions","organizations_url":"https://api.github.com/users/debris/orgs","repos_url":"https://api.github.com/users/debris/repos","events_url":"https://api.github.com/users/debris/events{/privacy}","received_events_url":"https://api.github.com/users/debris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/debris/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":true,"url":"https://api.github.com/repos/debris/cpp-ethereum","forks_url":"https://api.github.com/repos/debris/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/debris/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/debris/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/debris/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/debris/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/debris/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/debris/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/debris/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/debris/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/debris/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/debris/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/debris/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/debris/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/debris/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/debris/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/debris/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/debris/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/debris/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/debris/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/debris/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/debris/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/debris/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/debris/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/debris/cpp-ethereum/issues/comments/{number}","contents_url":"https://api.github.com/repos/debris/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/debris/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/debris/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/debris/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/debris/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/debris/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/debris/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/debris/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/debris/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/debris/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/debris/cpp-ethereum/releases{/id}","created_at":"2014-10-10T23:01:05Z","updated_at":"2015-01-19T09:15:52Z","pushed_at":"2015-01-26T14:53:12Z","git_url":"git://github.com/debris/cpp-ethereum.git","ssh_url":"git@github.com:debris/cpp-ethereum.git","clone_url":"https://github.com/debris/cpp-ethereum.git","svn_url":"https://github.com/debris/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":11429,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"d0180e78d052cb627a9223d7a22b3c82973743cb","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments/{number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","created_at":"2013-12-26T21:26:06Z","updated_at":"2015-01-26T14:48:54Z","pushed_at":"2015-01-26T14:48:54Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":32195,"stargazers_count":392,"watchers_count":392,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":113,"forks":136,"open_issues":113,"watchers":392,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/871"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/871"},"issue":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/871"},"comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/871/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/871/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/871/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/04f45fb1a58253b93b14bc1b67004f4763a1833b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":57,"deletions":0,"changed_files":1}}