{"action":"created","issue":{"url":"https://api.github.com/repos/isetbio/isetbio/issues/26","labels_url":"https://api.github.com/repos/isetbio/isetbio/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/isetbio/isetbio/issues/26/comments","events_url":"https://api.github.com/repos/isetbio/isetbio/issues/26/events","html_url":"https://github.com/isetbio/isetbio/issues/26","id":79503524,"number":26,"title":"Cone adapt mysteries","user":{"login":"DavidBrainard","id":1158757,"avatar_url":"https://avatars.githubusercontent.com/u/1158757?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidBrainard","html_url":"https://github.com/DavidBrainard","followers_url":"https://api.github.com/users/DavidBrainard/followers","following_url":"https://api.github.com/users/DavidBrainard/following{/other_user}","gists_url":"https://api.github.com/users/DavidBrainard/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidBrainard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidBrainard/subscriptions","organizations_url":"https://api.github.com/users/DavidBrainard/orgs","repos_url":"https://api.github.com/users/DavidBrainard/repos","events_url":"https://api.github.com/users/DavidBrainard/events{/privacy}","received_events_url":"https://api.github.com/users/DavidBrainard/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-22T15:47:07Z","updated_at":"2015-05-22T16:01:53Z","closed_at":null,"body":"There was code in sensor get that allows one to get adapted data.  This was incorrectly pointed to in the help text and once we called it correctly (by using sensorGet('adapted data') it crashed.  That's because the code itself called sensorGet('adapted volts') which doesn't exist.  We changed that line to be sensorGet('adaptation offset') because the left hand side had a variable name called offset.  But we aren't sure this is right.  We will push this change up to gitHub once Xiaomao's permissions get sorted out (we should be able to deal with that).\r\n\r\nThen we realized that we are very confused, because the cone adaptation tutorial itself runs.  It calls a function named coneAdapt.  We haven't yet traced through this all, because we figure you guys can tell us what is known to be stale and where we should be looking.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/isetbio/isetbio/issues/comments/104698503","html_url":"https://github.com/isetbio/isetbio/issues/26#issuecomment-104698503","issue_url":"https://api.github.com/repos/isetbio/isetbio/issues/26","id":104698503,"user":{"login":"chichilnisky","id":4309421,"avatar_url":"https://avatars.githubusercontent.com/u/4309421?v=3","gravatar_id":"","url":"https://api.github.com/users/chichilnisky","html_url":"https://github.com/chichilnisky","followers_url":"https://api.github.com/users/chichilnisky/followers","following_url":"https://api.github.com/users/chichilnisky/following{/other_user}","gists_url":"https://api.github.com/users/chichilnisky/gists{/gist_id}","starred_url":"https://api.github.com/users/chichilnisky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chichilnisky/subscriptions","organizations_url":"https://api.github.com/users/chichilnisky/orgs","repos_url":"https://api.github.com/users/chichilnisky/repos","events_url":"https://api.github.com/users/chichilnisky/events{/privacy}","received_events_url":"https://api.github.com/users/chichilnisky/received_events","type":"User","site_admin":false},"created_at":"2015-05-22T16:01:53Z","updated_at":"2015-05-22T16:01:53Z","body":"While you’re on this — “coneAdapt” as a name for this function seems like a misnomer to me.  It’s a model for cone dynamics as a function of the incoming light stream.  It incorporates adaptation but it’s not a model of adaptation per se, certainly not in the sense that the field means it.  I would suggest a new name, e.g. coneModel or coneDynamics\n\nej\n\n> On May 22, 2015, at 8:47 AM, David Brainard <notifications@github.com> wrote:\n> \n> There was code in sensor get that allows one to get adapted data. This was incorrectly pointed to in the help text and once we called it correctly (by using sensorGet('adapted data') it crashed. That's because the code itself called sensorGet('adapted volts') which doesn't exist. We changed that line to be sensorGet('adaptation offset') because the left hand side had a variable name called offset. But we aren't sure this is right. We will push this change up to gitHub once Xiaomao's permissions get sorted out (we should be able to deal with that).\n> \n> Then we realized that we are very confused, because the cone adaptation tutorial itself runs. It calls a function named coneAdapt. We haven't yet traced through this all, because we figure you guys can tell us what is known to be stale and where we should be looking.\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n\n\n"}}