{"action":"created","comment":{"url":"https://api.github.com/repos/lxc/lxd/pulls/comments/34965495","id":34965495,"diff_hunk":"@@ -71,8 +30,14 @@ func containerDelete(d *Daemon, r *http.Request) Response {\n \t\treturn SmartError(err)\n \t}\n \n+\t// TODO: i have added this not sure its a good idea (pcdummy)","path":"lxd/container_delete.go","position":72,"original_position":72,"commit_id":"a7ec530cc0c26bb6a0750690f8de8102f1eac900","original_commit_id":"a7ec530cc0c26bb6a0750690f8de8102f1eac900","user":{"login":"stgraber","id":2230599,"avatar_url":"https://avatars.githubusercontent.com/u/2230599?v=3","gravatar_id":"","url":"https://api.github.com/users/stgraber","html_url":"https://github.com/stgraber","followers_url":"https://api.github.com/users/stgraber/followers","following_url":"https://api.github.com/users/stgraber/following{/other_user}","gists_url":"https://api.github.com/users/stgraber/gists{/gist_id}","starred_url":"https://api.github.com/users/stgraber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stgraber/subscriptions","organizations_url":"https://api.github.com/users/stgraber/orgs","repos_url":"https://api.github.com/users/stgraber/repos","events_url":"https://api.github.com/users/stgraber/events{/privacy}","received_events_url":"https://api.github.com/users/stgraber/received_events","type":"User","site_admin":false},"body":"Doesn't seem like we really have a choice since removeContainer now takes a container struct instead of just the name. so not sure what's the alternative.","created_at":"2015-07-20T01:47:21Z","updated_at":"2015-07-20T01:47:21Z","html_url":"https://github.com/lxc/lxd/pull/858#discussion_r34965495","pull_request_url":"https://api.github.com/repos/lxc/lxd/pulls/858","_links":{"self":{"href":"https://api.github.com/repos/lxc/lxd/pulls/comments/34965495"},"html":{"href":"https://github.com/lxc/lxd/pull/858#discussion_r34965495"},"pull_request":{"href":"https://api.github.com/repos/lxc/lxd/pulls/858"}}},"pull_request":{"url":"https://api.github.com/repos/lxc/lxd/pulls/858","id":40263705,"html_url":"https://github.com/lxc/lxd/pull/858","diff_url":"https://github.com/lxc/lxd/pull/858.diff","patch_url":"https://github.com/lxc/lxd/pull/858.patch","issue_url":"https://api.github.com/repos/lxc/lxd/issues/858","number":858,"state":"open","locked":false,"title":"Split up storage stuff into drivers.","user":{"login":"pcdummy","id":358074,"avatar_url":"https://avatars.githubusercontent.com/u/358074?v=3","gravatar_id":"","url":"https://api.github.com/users/pcdummy","html_url":"https://github.com/pcdummy","followers_url":"https://api.github.com/users/pcdummy/followers","following_url":"https://api.github.com/users/pcdummy/following{/other_user}","gists_url":"https://api.github.com/users/pcdummy/gists{/gist_id}","starred_url":"https://api.github.com/users/pcdummy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcdummy/subscriptions","organizations_url":"https://api.github.com/users/pcdummy/orgs","repos_url":"https://api.github.com/users/pcdummy/repos","events_url":"https://api.github.com/users/pcdummy/events{/privacy}","received_events_url":"https://api.github.com/users/pcdummy/received_events","type":"User","site_admin":false},"body":"This is the split up of all storage things into one object per driver we have discussed in IRC.\r\n\r\nCurrently this supports 3 storage \"drivers\":\r\n\r\n- btrfs\r\n- lvm\r\n- dir (plain directories)\r\n\r\nThe driver will be autoselected, when you have `core.lvm_vg_name` set it will use LVM, if you have a btrfs filesystem that else plain dirs.","created_at":"2015-07-17T19:29:08Z","updated_at":"2015-07-20T01:47:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"774443d9834a650d869a8b17209d1a7ecceaf039","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lxc/lxd/pulls/858/commits","review_comments_url":"https://api.github.com/repos/lxc/lxd/pulls/858/comments","review_comment_url":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lxc/lxd/issues/858/comments","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/a7ec530cc0c26bb6a0750690f8de8102f1eac900","head":{"label":"pcdummy:storage","ref":"storage","sha":"a7ec530cc0c26bb6a0750690f8de8102f1eac900","user":{"login":"pcdummy","id":358074,"avatar_url":"https://avatars.githubusercontent.com/u/358074?v=3","gravatar_id":"","url":"https://api.github.com/users/pcdummy","html_url":"https://github.com/pcdummy","followers_url":"https://api.github.com/users/pcdummy/followers","following_url":"https://api.github.com/users/pcdummy/following{/other_user}","gists_url":"https://api.github.com/users/pcdummy/gists{/gist_id}","starred_url":"https://api.github.com/users/pcdummy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcdummy/subscriptions","organizations_url":"https://api.github.com/users/pcdummy/orgs","repos_url":"https://api.github.com/users/pcdummy/repos","events_url":"https://api.github.com/users/pcdummy/events{/privacy}","received_events_url":"https://api.github.com/users/pcdummy/received_events","type":"User","site_admin":false},"repo":{"id":38551824,"name":"lxd","full_name":"pcdummy/lxd","owner":{"login":"pcdummy","id":358074,"avatar_url":"https://avatars.githubusercontent.com/u/358074?v=3","gravatar_id":"","url":"https://api.github.com/users/pcdummy","html_url":"https://github.com/pcdummy","followers_url":"https://api.github.com/users/pcdummy/followers","following_url":"https://api.github.com/users/pcdummy/following{/other_user}","gists_url":"https://api.github.com/users/pcdummy/gists{/gist_id}","starred_url":"https://api.github.com/users/pcdummy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcdummy/subscriptions","organizations_url":"https://api.github.com/users/pcdummy/orgs","repos_url":"https://api.github.com/users/pcdummy/repos","events_url":"https://api.github.com/users/pcdummy/events{/privacy}","received_events_url":"https://api.github.com/users/pcdummy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pcdummy/lxd","description":"Daemon based on liblxc offering a REST API to manage containers","fork":true,"url":"https://api.github.com/repos/pcdummy/lxd","forks_url":"https://api.github.com/repos/pcdummy/lxd/forks","keys_url":"https://api.github.com/repos/pcdummy/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcdummy/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcdummy/lxd/teams","hooks_url":"https://api.github.com/repos/pcdummy/lxd/hooks","issue_events_url":"https://api.github.com/repos/pcdummy/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/pcdummy/lxd/events","assignees_url":"https://api.github.com/repos/pcdummy/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/pcdummy/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/pcdummy/lxd/tags","blobs_url":"https://api.github.com/repos/pcdummy/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcdummy/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcdummy/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcdummy/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcdummy/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/pcdummy/lxd/languages","stargazers_url":"https://api.github.com/repos/pcdummy/lxd/stargazers","contributors_url":"https://api.github.com/repos/pcdummy/lxd/contributors","subscribers_url":"https://api.github.com/repos/pcdummy/lxd/subscribers","subscription_url":"https://api.github.com/repos/pcdummy/lxd/subscription","commits_url":"https://api.github.com/repos/pcdummy/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcdummy/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcdummy/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcdummy/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/pcdummy/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/pcdummy/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcdummy/lxd/merges","archive_url":"https://api.github.com/repos/pcdummy/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcdummy/lxd/downloads","issues_url":"https://api.github.com/repos/pcdummy/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/pcdummy/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/pcdummy/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/pcdummy/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcdummy/lxd/labels{/name}","releases_url":"https://api.github.com/repos/pcdummy/lxd/releases{/id}","created_at":"2015-07-05T00:31:33Z","updated_at":"2015-07-05T00:31:34Z","pushed_at":"2015-07-19T22:29:41Z","git_url":"git://github.com/pcdummy/lxd.git","ssh_url":"git@github.com:pcdummy/lxd.git","clone_url":"https://github.com/pcdummy/lxd.git","svn_url":"https://github.com/pcdummy/lxd","homepage":"https://linuxcontainers.org","size":2667,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lxc:master","ref":"master","sha":"cac56f07479bdde20e03a1e21895a84b51e2ca42","user":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"repo":{"id":26192117,"name":"lxd","full_name":"lxc/lxd","owner":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxc/lxd","description":"Daemon based on liblxc offering a REST API to manage containers","fork":false,"url":"https://api.github.com/repos/lxc/lxd","forks_url":"https://api.github.com/repos/lxc/lxd/forks","keys_url":"https://api.github.com/repos/lxc/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxc/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxc/lxd/teams","hooks_url":"https://api.github.com/repos/lxc/lxd/hooks","issue_events_url":"https://api.github.com/repos/lxc/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/lxc/lxd/events","assignees_url":"https://api.github.com/repos/lxc/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/lxc/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/lxc/lxd/tags","blobs_url":"https://api.github.com/repos/lxc/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxc/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxc/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxc/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/lxc/lxd/languages","stargazers_url":"https://api.github.com/repos/lxc/lxd/stargazers","contributors_url":"https://api.github.com/repos/lxc/lxd/contributors","subscribers_url":"https://api.github.com/repos/lxc/lxd/subscribers","subscription_url":"https://api.github.com/repos/lxc/lxd/subscription","commits_url":"https://api.github.com/repos/lxc/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxc/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxc/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxc/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxc/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/lxc/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxc/lxd/merges","archive_url":"https://api.github.com/repos/lxc/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxc/lxd/downloads","issues_url":"https://api.github.com/repos/lxc/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/lxc/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/lxc/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/lxc/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxc/lxd/labels{/name}","releases_url":"https://api.github.com/repos/lxc/lxd/releases{/id}","created_at":"2014-11-04T22:40:52Z","updated_at":"2015-07-19T18:12:46Z","pushed_at":"2015-07-19T22:20:38Z","git_url":"git://github.com/lxc/lxd.git","ssh_url":"git@github.com:lxc/lxd.git","clone_url":"https://github.com/lxc/lxd.git","svn_url":"https://github.com/lxc/lxd","homepage":"https://linuxcontainers.org","size":5798,"stargazers_count":522,"watchers_count":522,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":74,"mirror_url":null,"open_issues_count":67,"forks":74,"open_issues":67,"watchers":522,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxc/lxd/pulls/858"},"html":{"href":"https://github.com/lxc/lxd/pull/858"},"issue":{"href":"https://api.github.com/repos/lxc/lxd/issues/858"},"comments":{"href":"https://api.github.com/repos/lxc/lxd/issues/858/comments"},"review_comments":{"href":"https://api.github.com/repos/lxc/lxd/pulls/858/comments"},"review_comment":{"href":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lxc/lxd/pulls/858/commits"},"statuses":{"href":"https://api.github.com/repos/lxc/lxd/statuses/a7ec530cc0c26bb6a0750690f8de8102f1eac900"}}}}