{"action":"closed","number":338,"pull_request":{"url":"https://api.github.com/repos/shaarli/Shaarli/pulls/338","id":44159156,"html_url":"https://github.com/shaarli/Shaarli/pull/338","diff_url":"https://github.com/shaarli/Shaarli/pull/338.diff","patch_url":"https://github.com/shaarli/Shaarli/pull/338.patch","issue_url":"https://api.github.com/repos/shaarli/Shaarli/issues/338","number":338,"state":"closed","locked":false,"title":"Session ID: extend the regex to match possible hash representations","user":{"login":"virtualtam","id":1615162,"avatar_url":"https://avatars.githubusercontent.com/u/1615162?v=3","gravatar_id":"","url":"https://api.github.com/users/virtualtam","html_url":"https://github.com/virtualtam","followers_url":"https://api.github.com/users/virtualtam/followers","following_url":"https://api.github.com/users/virtualtam/following{/other_user}","gists_url":"https://api.github.com/users/virtualtam/gists{/gist_id}","starred_url":"https://api.github.com/users/virtualtam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtualtam/subscriptions","organizations_url":"https://api.github.com/users/virtualtam/orgs","repos_url":"https://api.github.com/users/virtualtam/repos","events_url":"https://api.github.com/users/virtualtam/events{/privacy}","received_events_url":"https://api.github.com/users/virtualtam/received_events","type":"User","site_admin":false},"body":"[EDITED]\r\n\r\nImproves #306\r\nRelates to #335 & #336\r\nDuplicated by #339\r\n\r\nIssues:\r\n - PHP regenerates the session ID if it is not compliant\r\n - the regex checking the session ID does not cover all cases\r\n   - different algorithms: md5, sha1, sha256, etc.\r\n   - bit representations: `4, 5, 6`\r\n\r\nFix:\r\n - `index.php`:\r\n   - remove `uniqid()` usage\r\n   - call `session_regenerate_id()` if an invalid cookie is detected\r\n - regex: support all possible characters - `[a-zA-Z,-]{2,128}`\r\n - tests: add coverage for all algorithms & bit representations\r\n\r\nSee:\r\n - http://php.net/manual/en/session.configuration.php#ini.session.hash-function\r\n - https://secure.php.net/manual/en/session.configuration.php#ini.session.hash-bits-per-character\r\n - http://php.net/manual/en/function.session-id.php\r\n - http://php.net/manual/en/function.session-regenerate-id.php\r\n - http://php.net/manual/en/function.hash-algos.php","created_at":"2015-09-03T21:21:18Z","updated_at":"2015-09-06T14:16:53Z","closed_at":"2015-09-06T14:16:53Z","merged_at":"2015-09-06T14:16:53Z","merge_commit_sha":"b3acc182736eec14317122f577f7972548c607a0","assignee":{"login":"virtualtam","id":1615162,"avatar_url":"https://avatars.githubusercontent.com/u/1615162?v=3","gravatar_id":"","url":"https://api.github.com/users/virtualtam","html_url":"https://github.com/virtualtam","followers_url":"https://api.github.com/users/virtualtam/followers","following_url":"https://api.github.com/users/virtualtam/following{/other_user}","gists_url":"https://api.github.com/users/virtualtam/gists{/gist_id}","starred_url":"https://api.github.com/users/virtualtam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtualtam/subscriptions","organizations_url":"https://api.github.com/users/virtualtam/orgs","repos_url":"https://api.github.com/users/virtualtam/repos","events_url":"https://api.github.com/users/virtualtam/events{/privacy}","received_events_url":"https://api.github.com/users/virtualtam/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/shaarli/Shaarli/milestones/12","html_url":"https://github.com/shaarli/Shaarli/milestones/0.5.4","labels_url":"https://api.github.com/repos/shaarli/Shaarli/milestones/12/labels","id":1286658,"number":12,"title":"0.5.4","description":"","creator":{"login":"ArthurHoaro","id":1962678,"avatar_url":"https://avatars.githubusercontent.com/u/1962678?v=3","gravatar_id":"","url":"https://api.github.com/users/ArthurHoaro","html_url":"https://github.com/ArthurHoaro","followers_url":"https://api.github.com/users/ArthurHoaro/followers","following_url":"https://api.github.com/users/ArthurHoaro/following{/other_user}","gists_url":"https://api.github.com/users/ArthurHoaro/gists{/gist_id}","starred_url":"https://api.github.com/users/ArthurHoaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArthurHoaro/subscriptions","organizations_url":"https://api.github.com/users/ArthurHoaro/orgs","repos_url":"https://api.github.com/users/ArthurHoaro/repos","events_url":"https://api.github.com/users/ArthurHoaro/events{/privacy}","received_events_url":"https://api.github.com/users/ArthurHoaro/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":4,"state":"open","created_at":"2015-09-02T15:56:12Z","updated_at":"2015-09-06T14:16:53Z","due_on":"2015-09-11T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/shaarli/Shaarli/pulls/338/commits","review_comments_url":"https://api.github.com/repos/shaarli/Shaarli/pulls/338/comments","review_comment_url":"https://api.github.com/repos/shaarli/Shaarli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shaarli/Shaarli/issues/338/comments","statuses_url":"https://api.github.com/repos/shaarli/Shaarli/statuses/68bc21353a6138a898724c8bb87684bb2b6b2c1c","head":{"label":"virtualtam:fix/unique-uniqid","ref":"fix/unique-uniqid","sha":"68bc21353a6138a898724c8bb87684bb2b6b2c1c","user":{"login":"virtualtam","id":1615162,"avatar_url":"https://avatars.githubusercontent.com/u/1615162?v=3","gravatar_id":"","url":"https://api.github.com/users/virtualtam","html_url":"https://github.com/virtualtam","followers_url":"https://api.github.com/users/virtualtam/followers","following_url":"https://api.github.com/users/virtualtam/following{/other_user}","gists_url":"https://api.github.com/users/virtualtam/gists{/gist_id}","starred_url":"https://api.github.com/users/virtualtam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtualtam/subscriptions","organizations_url":"https://api.github.com/users/virtualtam/orgs","repos_url":"https://api.github.com/users/virtualtam/repos","events_url":"https://api.github.com/users/virtualtam/events{/privacy}","received_events_url":"https://api.github.com/users/virtualtam/received_events","type":"User","site_admin":false},"repo":{"id":25399689,"name":"Shaarli","full_name":"virtualtam/Shaarli","owner":{"login":"virtualtam","id":1615162,"avatar_url":"https://avatars.githubusercontent.com/u/1615162?v=3","gravatar_id":"","url":"https://api.github.com/users/virtualtam","html_url":"https://github.com/virtualtam","followers_url":"https://api.github.com/users/virtualtam/followers","following_url":"https://api.github.com/users/virtualtam/following{/other_user}","gists_url":"https://api.github.com/users/virtualtam/gists{/gist_id}","starred_url":"https://api.github.com/users/virtualtam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtualtam/subscriptions","organizations_url":"https://api.github.com/users/virtualtam/orgs","repos_url":"https://api.github.com/users/virtualtam/repos","events_url":"https://api.github.com/users/virtualtam/events{/privacy}","received_events_url":"https://api.github.com/users/virtualtam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/virtualtam/Shaarli","description":"The personal, minimalist, super-fast, no-database delicious clone - community repo","fork":true,"url":"https://api.github.com/repos/virtualtam/Shaarli","forks_url":"https://api.github.com/repos/virtualtam/Shaarli/forks","keys_url":"https://api.github.com/repos/virtualtam/Shaarli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/virtualtam/Shaarli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/virtualtam/Shaarli/teams","hooks_url":"https://api.github.com/repos/virtualtam/Shaarli/hooks","issue_events_url":"https://api.github.com/repos/virtualtam/Shaarli/issues/events{/number}","events_url":"https://api.github.com/repos/virtualtam/Shaarli/events","assignees_url":"https://api.github.com/repos/virtualtam/Shaarli/assignees{/user}","branches_url":"https://api.github.com/repos/virtualtam/Shaarli/branches{/branch}","tags_url":"https://api.github.com/repos/virtualtam/Shaarli/tags","blobs_url":"https://api.github.com/repos/virtualtam/Shaarli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/virtualtam/Shaarli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/virtualtam/Shaarli/git/refs{/sha}","trees_url":"https://api.github.com/repos/virtualtam/Shaarli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/virtualtam/Shaarli/statuses/{sha}","languages_url":"https://api.github.com/repos/virtualtam/Shaarli/languages","stargazers_url":"https://api.github.com/repos/virtualtam/Shaarli/stargazers","contributors_url":"https://api.github.com/repos/virtualtam/Shaarli/contributors","subscribers_url":"https://api.github.com/repos/virtualtam/Shaarli/subscribers","subscription_url":"https://api.github.com/repos/virtualtam/Shaarli/subscription","commits_url":"https://api.github.com/repos/virtualtam/Shaarli/commits{/sha}","git_commits_url":"https://api.github.com/repos/virtualtam/Shaarli/git/commits{/sha}","comments_url":"https://api.github.com/repos/virtualtam/Shaarli/comments{/number}","issue_comment_url":"https://api.github.com/repos/virtualtam/Shaarli/issues/comments{/number}","contents_url":"https://api.github.com/repos/virtualtam/Shaarli/contents/{+path}","compare_url":"https://api.github.com/repos/virtualtam/Shaarli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/virtualtam/Shaarli/merges","archive_url":"https://api.github.com/repos/virtualtam/Shaarli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/virtualtam/Shaarli/downloads","issues_url":"https://api.github.com/repos/virtualtam/Shaarli/issues{/number}","pulls_url":"https://api.github.com/repos/virtualtam/Shaarli/pulls{/number}","milestones_url":"https://api.github.com/repos/virtualtam/Shaarli/milestones{/number}","notifications_url":"https://api.github.com/repos/virtualtam/Shaarli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/virtualtam/Shaarli/labels{/name}","releases_url":"https://api.github.com/repos/virtualtam/Shaarli/releases{/id}","created_at":"2014-10-18T14:31:48Z","updated_at":"2015-05-01T09:30:05Z","pushed_at":"2015-09-06T14:14:57Z","git_url":"git://github.com/virtualtam/Shaarli.git","ssh_url":"git@github.com:virtualtam/Shaarli.git","clone_url":"https://github.com/virtualtam/Shaarli.git","svn_url":"https://github.com/virtualtam/Shaarli","homepage":"http://sebsauvage.net/wiki/doku.php?id=php:shaarli","size":2159,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shaarli:master","ref":"master","sha":"a02257b8aed58ef2f8536c877ce2fb222f84ac40","user":{"login":"shaarli","id":8275533,"avatar_url":"https://avatars.githubusercontent.com/u/8275533?v=3","gravatar_id":"","url":"https://api.github.com/users/shaarli","html_url":"https://github.com/shaarli","followers_url":"https://api.github.com/users/shaarli/followers","following_url":"https://api.github.com/users/shaarli/following{/other_user}","gists_url":"https://api.github.com/users/shaarli/gists{/gist_id}","starred_url":"https://api.github.com/users/shaarli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaarli/subscriptions","organizations_url":"https://api.github.com/users/shaarli/orgs","repos_url":"https://api.github.com/users/shaarli/repos","events_url":"https://api.github.com/users/shaarli/events{/privacy}","received_events_url":"https://api.github.com/users/shaarli/received_events","type":"Organization","site_admin":false},"repo":{"id":22287975,"name":"Shaarli","full_name":"shaarli/Shaarli","owner":{"login":"shaarli","id":8275533,"avatar_url":"https://avatars.githubusercontent.com/u/8275533?v=3","gravatar_id":"","url":"https://api.github.com/users/shaarli","html_url":"https://github.com/shaarli","followers_url":"https://api.github.com/users/shaarli/followers","following_url":"https://api.github.com/users/shaarli/following{/other_user}","gists_url":"https://api.github.com/users/shaarli/gists{/gist_id}","starred_url":"https://api.github.com/users/shaarli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaarli/subscriptions","organizations_url":"https://api.github.com/users/shaarli/orgs","repos_url":"https://api.github.com/users/shaarli/repos","events_url":"https://api.github.com/users/shaarli/events{/privacy}","received_events_url":"https://api.github.com/users/shaarli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shaarli/Shaarli","description":"The personal, minimalist, super-fast, no-database delicious clone - community repo","fork":true,"url":"https://api.github.com/repos/shaarli/Shaarli","forks_url":"https://api.github.com/repos/shaarli/Shaarli/forks","keys_url":"https://api.github.com/repos/shaarli/Shaarli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shaarli/Shaarli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shaarli/Shaarli/teams","hooks_url":"https://api.github.com/repos/shaarli/Shaarli/hooks","issue_events_url":"https://api.github.com/repos/shaarli/Shaarli/issues/events{/number}","events_url":"https://api.github.com/repos/shaarli/Shaarli/events","assignees_url":"https://api.github.com/repos/shaarli/Shaarli/assignees{/user}","branches_url":"https://api.github.com/repos/shaarli/Shaarli/branches{/branch}","tags_url":"https://api.github.com/repos/shaarli/Shaarli/tags","blobs_url":"https://api.github.com/repos/shaarli/Shaarli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shaarli/Shaarli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shaarli/Shaarli/git/refs{/sha}","trees_url":"https://api.github.com/repos/shaarli/Shaarli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shaarli/Shaarli/statuses/{sha}","languages_url":"https://api.github.com/repos/shaarli/Shaarli/languages","stargazers_url":"https://api.github.com/repos/shaarli/Shaarli/stargazers","contributors_url":"https://api.github.com/repos/shaarli/Shaarli/contributors","subscribers_url":"https://api.github.com/repos/shaarli/Shaarli/subscribers","subscription_url":"https://api.github.com/repos/shaarli/Shaarli/subscription","commits_url":"https://api.github.com/repos/shaarli/Shaarli/commits{/sha}","git_commits_url":"https://api.github.com/repos/shaarli/Shaarli/git/commits{/sha}","comments_url":"https://api.github.com/repos/shaarli/Shaarli/comments{/number}","issue_comment_url":"https://api.github.com/repos/shaarli/Shaarli/issues/comments{/number}","contents_url":"https://api.github.com/repos/shaarli/Shaarli/contents/{+path}","compare_url":"https://api.github.com/repos/shaarli/Shaarli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shaarli/Shaarli/merges","archive_url":"https://api.github.com/repos/shaarli/Shaarli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shaarli/Shaarli/downloads","issues_url":"https://api.github.com/repos/shaarli/Shaarli/issues{/number}","pulls_url":"https://api.github.com/repos/shaarli/Shaarli/pulls{/number}","milestones_url":"https://api.github.com/repos/shaarli/Shaarli/milestones{/number}","notifications_url":"https://api.github.com/repos/shaarli/Shaarli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shaarli/Shaarli/labels{/name}","releases_url":"https://api.github.com/repos/shaarli/Shaarli/releases{/id}","created_at":"2014-07-26T14:10:30Z","updated_at":"2015-09-04T16:17:25Z","pushed_at":"2015-09-06T14:16:53Z","git_url":"git://github.com/shaarli/Shaarli.git","ssh_url":"git@github.com:shaarli/Shaarli.git","clone_url":"https://github.com/shaarli/Shaarli.git","svn_url":"https://github.com/shaarli/Shaarli","homepage":"https://github.com/shaarli/Shaarli","size":3983,"stargazers_count":124,"watchers_count":124,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":85,"forks":28,"open_issues":85,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shaarli/Shaarli/pulls/338"},"html":{"href":"https://github.com/shaarli/Shaarli/pull/338"},"issue":{"href":"https://api.github.com/repos/shaarli/Shaarli/issues/338"},"comments":{"href":"https://api.github.com/repos/shaarli/Shaarli/issues/338/comments"},"review_comments":{"href":"https://api.github.com/repos/shaarli/Shaarli/pulls/338/comments"},"review_comment":{"href":"https://api.github.com/repos/shaarli/Shaarli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shaarli/Shaarli/pulls/338/commits"},"statuses":{"href":"https://api.github.com/repos/shaarli/Shaarli/statuses/68bc21353a6138a898724c8bb87684bb2b6b2c1c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"virtualtam","id":1615162,"avatar_url":"https://avatars.githubusercontent.com/u/1615162?v=3","gravatar_id":"","url":"https://api.github.com/users/virtualtam","html_url":"https://github.com/virtualtam","followers_url":"https://api.github.com/users/virtualtam/followers","following_url":"https://api.github.com/users/virtualtam/following{/other_user}","gists_url":"https://api.github.com/users/virtualtam/gists{/gist_id}","starred_url":"https://api.github.com/users/virtualtam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtualtam/subscriptions","organizations_url":"https://api.github.com/users/virtualtam/orgs","repos_url":"https://api.github.com/users/virtualtam/repos","events_url":"https://api.github.com/users/virtualtam/events{/privacy}","received_events_url":"https://api.github.com/users/virtualtam/received_events","type":"User","site_admin":false},"comments":17,"review_comments":0,"commits":1,"additions":119,"deletions":9,"changed_files":4}}