{"action":"created","issue":{"url":"https://api.github.com/repos/linkedin/camus/issues/158","labels_url":"https://api.github.com/repos/linkedin/camus/issues/158/labels{/name}","comments_url":"https://api.github.com/repos/linkedin/camus/issues/158/comments","events_url":"https://api.github.com/repos/linkedin/camus/issues/158/events","html_url":"https://github.com/linkedin/camus/pull/158","id":53390445,"number":158,"title":"Sweeper should not depend on the order of directory entries","user":{"login":"erikvanoosten","id":630600,"avatar_url":"https://avatars.githubusercontent.com/u/630600?v=3","gravatar_id":"","url":"https://api.github.com/users/erikvanoosten","html_url":"https://github.com/erikvanoosten","followers_url":"https://api.github.com/users/erikvanoosten/followers","following_url":"https://api.github.com/users/erikvanoosten/following{/other_user}","gists_url":"https://api.github.com/users/erikvanoosten/gists{/gist_id}","starred_url":"https://api.github.com/users/erikvanoosten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikvanoosten/subscriptions","organizations_url":"https://api.github.com/users/erikvanoosten/orgs","repos_url":"https://api.github.com/users/erikvanoosten/repos","events_url":"https://api.github.com/users/erikvanoosten/events{/privacy}","received_events_url":"https://api.github.com/users/erikvanoosten/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-05T12:14:41Z","updated_at":"2015-01-05T22:40:09Z","closed_at":"2015-01-05T22:40:03Z","pull_request":{"url":"https://api.github.com/repos/linkedin/camus/pulls/158","html_url":"https://github.com/linkedin/camus/pull/158","diff_url":"https://github.com/linkedin/camus/pull/158.diff","patch_url":"https://github.com/linkedin/camus/pull/158.patch"},"body":"Currently, when sweeper analyses the source directory tree, it assumes that the first entry inside the topic directory is 1) a directory, 2) the source sub-directory.\r\n\r\nBoth are not necessarily true.\r\nAssumption 2) fails when destination sub-directory (e.g. 'daily') lexically comes before the source sub-directory (e.g. 'recent'). (This can only happen when source and destination trees are the same.)\r\nAssumption 1) fails under the edge case where additional files are kept in the topic directory (or in any sub-directory). I am storing some topic meta data in the topic directory so this assumption failed for me as well.\r\n\r\nThis change will make sweeper analyze the entire topic directory and not just the first entry."},"comment":{"url":"https://api.github.com/repos/linkedin/camus/issues/comments/68795314","html_url":"https://github.com/linkedin/camus/pull/158#issuecomment-68795314","issue_url":"https://api.github.com/repos/linkedin/camus/issues/158","id":68795314,"user":{"login":"HenryCaiHaiying","id":7378943,"avatar_url":"https://avatars.githubusercontent.com/u/7378943?v=3","gravatar_id":"","url":"https://api.github.com/users/HenryCaiHaiying","html_url":"https://github.com/HenryCaiHaiying","followers_url":"https://api.github.com/users/HenryCaiHaiying/followers","following_url":"https://api.github.com/users/HenryCaiHaiying/following{/other_user}","gists_url":"https://api.github.com/users/HenryCaiHaiying/gists{/gist_id}","starred_url":"https://api.github.com/users/HenryCaiHaiying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenryCaiHaiying/subscriptions","organizations_url":"https://api.github.com/users/HenryCaiHaiying/orgs","repos_url":"https://api.github.com/users/HenryCaiHaiying/repos","events_url":"https://api.github.com/users/HenryCaiHaiying/events{/privacy}","received_events_url":"https://api.github.com/users/HenryCaiHaiying/received_events","type":"User","site_admin":false},"created_at":"2015-01-05T22:40:09Z","updated_at":"2015-01-05T22:40:09Z","body":"Looks fine, thanks."}}