{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/31318894","id":31318894,"diff_hunk":"@@ -0,0 +1,132 @@\n+// Copyright (c) Microsoft. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+\n+using System.Collections.Generic;\n+using System.Globalization;\n+using System.Net.Http.Headers;\n+using System.Threading;\n+using System.Threading.Tasks;\n+\n+namespace System.Net.Http\n+{\n+    public class HttpClientHandler : HttpMessageHandler\n+    {\n+        #region Properties\n+\n+        public virtual bool SupportsAutomaticDecompression\n+        {\n+            get { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+        }\n+\n+        public virtual bool SupportsProxy\n+        {\n+            get { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+        }\n+\n+        public virtual bool SupportsRedirectConfiguration\n+        {\n+            get { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+        }\n+\n+        public bool UseCookies\n+        {\n+            get { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+            set { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+        }\n+\n+        public CookieContainer CookieContainer\n+        {\n+            get { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+            set { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+        }\n+\n+        public ClientCertificateOption ClientCertificateOptions\n+        {\n+            get { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+            set { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+        }\n+\n+        public DecompressionMethods AutomaticDecompression\n+        {\n+            get { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+            set { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+        }\n+\n+        public bool UseProxy\n+        {\n+            get { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+            set { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+        }\n+\n+        public IWebProxy Proxy\n+        {\n+            get { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+            set { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+        }\n+\n+        public bool PreAuthenticate\n+        {\n+            get { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+            set { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+        }\n+\n+        public bool UseDefaultCredentials\n+        {\n+            get { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+            set { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+        }\n+\n+        public ICredentials Credentials\n+        {\n+            get { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+            set { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+        }\n+\n+        public bool AllowAutoRedirect\n+        {\n+            get { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+            set { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+        }\n+\n+        public int MaxAutomaticRedirections\n+        {\n+            get { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+            set { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+        }\n+\n+        public long MaxRequestContentBufferSize\n+        {\n+            get { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+            set { throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\"); }\n+        }\n+\n+        #endregion Properties\n+\n+        #region De/Constructors\n+\n+        public HttpClientHandler()\n+        {\n+            throw NotImplemented.ByDesignWithMessage(\"HTTP stack not implemented\");\n+        }\n+\n+        protected override void Dispose(bool disposing)\n+        {\n+            base.Dispose(disposing);\n+        }\n+\n+        #endregion De/Constructors\n+\n+        #region Request Execution\n+\n+#pragma warning disable 1998 // async method with no await","path":"src/System.Net.Http/tests/UnitTests/Fakes/HttpClientHandler.cs","position":121,"original_position":121,"commit_id":"708a0984df1e10fcbb0d80a650af46839150e2f2","original_commit_id":"708a0984df1e10fcbb0d80a650af46839150e2f2","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"Instead of suppressing the warning, you could just remove the 'async' keyword from the method.","created_at":"2015-05-29T12:13:08Z","updated_at":"2015-05-29T12:13:08Z","html_url":"https://github.com/dotnet/corefx/pull/1864#discussion_r31318894","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/1864","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/31318894"},"html":{"href":"https://github.com/dotnet/corefx/pull/1864#discussion_r31318894"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1864"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/1864","id":36447416,"html_url":"https://github.com/dotnet/corefx/pull/1864","diff_url":"https://github.com/dotnet/corefx/pull/1864.diff","patch_url":"https://github.com/dotnet/corefx/pull/1864.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/1864","number":1864,"state":"open","locked":false,"title":"Open source System.Net.Http unit tests","user":{"login":"davidsh","id":7684835,"avatar_url":"https://avatars.githubusercontent.com/u/7684835?v=3","gravatar_id":"","url":"https://api.github.com/users/davidsh","html_url":"https://github.com/davidsh","followers_url":"https://api.github.com/users/davidsh/followers","following_url":"https://api.github.com/users/davidsh/following{/other_user}","gists_url":"https://api.github.com/users/davidsh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsh/subscriptions","organizations_url":"https://api.github.com/users/davidsh/orgs","repos_url":"https://api.github.com/users/davidsh/repos","events_url":"https://api.github.com/users/davidsh/events{/privacy}","received_events_url":"https://api.github.com/users/davidsh/received_events","type":"User","site_admin":false},"body":"This is a port of the existing System.Net.Http unit tests. There are over 790 tests.  The majority of these test the header parsers as well as some of the HttpClient base methods.\r\n\r\nSimilar to our other unit tests, the sources of System.Net.Http are built into the test assembly itself. This enables us to test internal members as well as public members.\r\n\r\nThe tests have been ported from MSTest-style to Xunit and additional formatting tools run so that the sources conform to the CoreFX coding style guidelines.","created_at":"2015-05-28T20:29:58Z","updated_at":"2015-05-29T12:13:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"142aded27d2e384ca3b2295a5e27325b5b3343d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/1864/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/1864/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/1864/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/708a0984df1e10fcbb0d80a650af46839150e2f2","head":{"label":"davidsh:http_unit_tests","ref":"http_unit_tests","sha":"708a0984df1e10fcbb0d80a650af46839150e2f2","user":{"login":"davidsh","id":7684835,"avatar_url":"https://avatars.githubusercontent.com/u/7684835?v=3","gravatar_id":"","url":"https://api.github.com/users/davidsh","html_url":"https://github.com/davidsh","followers_url":"https://api.github.com/users/davidsh/followers","following_url":"https://api.github.com/users/davidsh/following{/other_user}","gists_url":"https://api.github.com/users/davidsh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsh/subscriptions","organizations_url":"https://api.github.com/users/davidsh/orgs","repos_url":"https://api.github.com/users/davidsh/repos","events_url":"https://api.github.com/users/davidsh/events{/privacy}","received_events_url":"https://api.github.com/users/davidsh/received_events","type":"User","site_admin":false},"repo":{"id":31976766,"name":"corefx","full_name":"davidsh/corefx","owner":{"login":"davidsh","id":7684835,"avatar_url":"https://avatars.githubusercontent.com/u/7684835?v=3","gravatar_id":"","url":"https://api.github.com/users/davidsh","html_url":"https://github.com/davidsh","followers_url":"https://api.github.com/users/davidsh/followers","following_url":"https://api.github.com/users/davidsh/following{/other_user}","gists_url":"https://api.github.com/users/davidsh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsh/subscriptions","organizations_url":"https://api.github.com/users/davidsh/orgs","repos_url":"https://api.github.com/users/davidsh/repos","events_url":"https://api.github.com/users/davidsh/events{/privacy}","received_events_url":"https://api.github.com/users/davidsh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidsh/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/davidsh/corefx","forks_url":"https://api.github.com/repos/davidsh/corefx/forks","keys_url":"https://api.github.com/repos/davidsh/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidsh/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidsh/corefx/teams","hooks_url":"https://api.github.com/repos/davidsh/corefx/hooks","issue_events_url":"https://api.github.com/repos/davidsh/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/davidsh/corefx/events","assignees_url":"https://api.github.com/repos/davidsh/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/davidsh/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/davidsh/corefx/tags","blobs_url":"https://api.github.com/repos/davidsh/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidsh/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidsh/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidsh/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidsh/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/davidsh/corefx/languages","stargazers_url":"https://api.github.com/repos/davidsh/corefx/stargazers","contributors_url":"https://api.github.com/repos/davidsh/corefx/contributors","subscribers_url":"https://api.github.com/repos/davidsh/corefx/subscribers","subscription_url":"https://api.github.com/repos/davidsh/corefx/subscription","commits_url":"https://api.github.com/repos/davidsh/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidsh/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidsh/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidsh/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidsh/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/davidsh/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidsh/corefx/merges","archive_url":"https://api.github.com/repos/davidsh/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidsh/corefx/downloads","issues_url":"https://api.github.com/repos/davidsh/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/davidsh/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/davidsh/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/davidsh/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidsh/corefx/labels{/name}","releases_url":"https://api.github.com/repos/davidsh/corefx/releases{/id}","created_at":"2015-03-10T19:16:38Z","updated_at":"2015-05-06T21:44:49Z","pushed_at":"2015-05-28T22:55:48Z","git_url":"git://github.com/davidsh/corefx.git","ssh_url":"git@github.com:davidsh/corefx.git","clone_url":"https://github.com/davidsh/corefx.git","svn_url":"https://github.com/davidsh/corefx","homepage":"","size":19304,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c799bf3ab5aade661e28b08027362abd8616186d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-05-28T19:28:00Z","pushed_at":"2015-05-29T12:09:13Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"","size":47060,"stargazers_count":7846,"watchers_count":7846,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1582,"mirror_url":null,"open_issues_count":404,"forks":1582,"open_issues":404,"watchers":7846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1864"},"html":{"href":"https://github.com/dotnet/corefx/pull/1864"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/1864"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/1864/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1864/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/1864/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/708a0984df1e10fcbb0d80a650af46839150e2f2"}}}}