{"action":"created","issue":{"url":"https://api.github.com/repos/openlayers/ol3/issues/4129","labels_url":"https://api.github.com/repos/openlayers/ol3/issues/4129/labels{/name}","comments_url":"https://api.github.com/repos/openlayers/ol3/issues/4129/comments","events_url":"https://api.github.com/repos/openlayers/ol3/issues/4129/events","html_url":"https://github.com/openlayers/ol3/pull/4129","id":107136886,"number":4129,"title":"(WIP) Remove use of goog.isDef","user":{"login":"tschaub","id":41094,"avatar_url":"https://avatars.githubusercontent.com/u/41094?v=3","gravatar_id":"","url":"https://api.github.com/users/tschaub","html_url":"https://github.com/tschaub","followers_url":"https://api.github.com/users/tschaub/followers","following_url":"https://api.github.com/users/tschaub/following{/other_user}","gists_url":"https://api.github.com/users/tschaub/gists{/gist_id}","starred_url":"https://api.github.com/users/tschaub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschaub/subscriptions","organizations_url":"https://api.github.com/users/tschaub/orgs","repos_url":"https://api.github.com/users/tschaub/repos","events_url":"https://api.github.com/users/tschaub/events{/privacy}","received_events_url":"https://api.github.com/users/tschaub/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-09-18T05:33:21Z","updated_at":"2015-09-24T06:11:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openlayers/ol3/pulls/4129","html_url":"https://github.com/openlayers/ol3/pull/4129","diff_url":"https://github.com/openlayers/ol3/pull/4129.diff","patch_url":"https://github.com/openlayers/ol3/pull/4129.patch"},"body":"As part of a larger effort to remove our dependency on the Closure Library (see #4128), this branch removes our use of `goog.isDef()`.\r\n\r\nI pushed this branch to the main OpenLayers repo so more people can contribute.  I'll happily cherry pick commits from other forks as well.\r\n"},"comment":{"url":"https://api.github.com/repos/openlayers/ol3/issues/comments/142820296","html_url":"https://github.com/openlayers/ol3/pull/4129#issuecomment-142820296","issue_url":"https://api.github.com/repos/openlayers/ol3/issues/4129","id":142820296,"user":{"login":"elemoine","id":76594,"avatar_url":"https://avatars.githubusercontent.com/u/76594?v=3","gravatar_id":"","url":"https://api.github.com/users/elemoine","html_url":"https://github.com/elemoine","followers_url":"https://api.github.com/users/elemoine/followers","following_url":"https://api.github.com/users/elemoine/following{/other_user}","gists_url":"https://api.github.com/users/elemoine/gists{/gist_id}","starred_url":"https://api.github.com/users/elemoine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elemoine/subscriptions","organizations_url":"https://api.github.com/users/elemoine/orgs","repos_url":"https://api.github.com/users/elemoine/repos","events_url":"https://api.github.com/users/elemoine/events{/privacy}","received_events_url":"https://api.github.com/users/elemoine/received_events","type":"User","site_admin":false},"created_at":"2015-09-24T06:11:40Z","updated_at":"2015-09-24T06:11:40Z","body":"> I used !== undefined in assertions, because they get removed at compile time, right?\r\n\r\nDo you mean that the assertion is **not** removed at compile time if you use `ol.isDef` rather than `=== undefined`?? I hope it's not the case.\r\n\r\n\r\n\r\n> I didn't want to add a goog.require('ol') if only an asserion needs ol.isDef.\r\n\r\nI don't think it's a problem. But I do think using `ol.isDef` here and `=== undefined` there is inconsistent and confusing."}}