{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/pulls/1","id":30391179,"html_url":"https://github.com/Hugo-ter-Doest/chart-parsers/pull/1","diff_url":"https://github.com/Hugo-ter-Doest/chart-parsers/pull/1.diff","patch_url":"https://github.com/Hugo-ter-Doest/chart-parsers/pull/1.patch","issue_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/issues/1","number":1,"state":"closed","locked":false,"title":"Remove dependency on `fs` package","user":{"login":"KenanY","id":733364,"avatar_url":"https://avatars.githubusercontent.com/u/733364?v=3","gravatar_id":"","url":"https://api.github.com/users/KenanY","html_url":"https://github.com/KenanY","followers_url":"https://api.github.com/users/KenanY/followers","following_url":"https://api.github.com/users/KenanY/following{/other_user}","gists_url":"https://api.github.com/users/KenanY/gists{/gist_id}","starred_url":"https://api.github.com/users/KenanY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KenanY/subscriptions","organizations_url":"https://api.github.com/users/KenanY/orgs","repos_url":"https://api.github.com/users/KenanY/repos","events_url":"https://api.github.com/users/KenanY/events{/privacy}","received_events_url":"https://api.github.com/users/KenanY/received_events","type":"User","site_admin":false},"body":"Hello!\r\n\r\nYou might not be aware of this, but the `fs` module that you `require()` here is actually [a core Node.js module](http://nodejs.org/api/fs.html). This means that it comes with every installation of Node.js.\r\n\r\nIn your `package.json`, you have [this `fs` module](https://www.npmjs.com/package/fs) as a dependency. Yet, technically you are never using this module. Due to how `require()` is implemented, core modules take precedence over `npm` packages. As such, when you do:\r\n\r\n``` js\r\nvar fs = require('fs');\r\n```\r\n\r\nYou are getting the core `fs` module I mentioned earlier, not the `fs` module from `npm` that you seem to have a dependency on. Furthermore, this `fs` module on `npm` is literally nothing more than a `console.log`:\r\n\r\n``` sh\r\n$ npm install fs\r\n$ cat node_modules/fs/index.js\r\nconsole.log(\"I'm `fs` modules\");\r\n```\r\n\r\nSo, this patch removes the dependency on this useless module.\r\n\r\nThanks for your time :)","created_at":"2015-03-03T16:54:41Z","updated_at":"2015-03-03T19:55:34Z","closed_at":"2015-03-03T19:55:34Z","merged_at":"2015-03-03T19:55:34Z","merge_commit_sha":"6c0a1ff9e6d59ebf2fa25fe8747869a3d84756af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/issues/1/comments","statuses_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/statuses/43e19fbc49a92b3b313d2c95c81b3b7e687ef43a","head":{"label":"KenanY:fs","ref":"fs","sha":"43e19fbc49a92b3b313d2c95c81b3b7e687ef43a","user":{"login":"KenanY","id":733364,"avatar_url":"https://avatars.githubusercontent.com/u/733364?v=3","gravatar_id":"","url":"https://api.github.com/users/KenanY","html_url":"https://github.com/KenanY","followers_url":"https://api.github.com/users/KenanY/followers","following_url":"https://api.github.com/users/KenanY/following{/other_user}","gists_url":"https://api.github.com/users/KenanY/gists{/gist_id}","starred_url":"https://api.github.com/users/KenanY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KenanY/subscriptions","organizations_url":"https://api.github.com/users/KenanY/orgs","repos_url":"https://api.github.com/users/KenanY/repos","events_url":"https://api.github.com/users/KenanY/events{/privacy}","received_events_url":"https://api.github.com/users/KenanY/received_events","type":"User","site_admin":false},"repo":{"id":31609802,"name":"chart-parsers","full_name":"KenanY/chart-parsers","owner":{"login":"KenanY","id":733364,"avatar_url":"https://avatars.githubusercontent.com/u/733364?v=3","gravatar_id":"","url":"https://api.github.com/users/KenanY","html_url":"https://github.com/KenanY","followers_url":"https://api.github.com/users/KenanY/followers","following_url":"https://api.github.com/users/KenanY/following{/other_user}","gists_url":"https://api.github.com/users/KenanY/gists{/gist_id}","starred_url":"https://api.github.com/users/KenanY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KenanY/subscriptions","organizations_url":"https://api.github.com/users/KenanY/orgs","repos_url":"https://api.github.com/users/KenanY/repos","events_url":"https://api.github.com/users/KenanY/events{/privacy}","received_events_url":"https://api.github.com/users/KenanY/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KenanY/chart-parsers","description":"CYK, Earley, Left-Corner and Head-Corner chart parsers","fork":true,"url":"https://api.github.com/repos/KenanY/chart-parsers","forks_url":"https://api.github.com/repos/KenanY/chart-parsers/forks","keys_url":"https://api.github.com/repos/KenanY/chart-parsers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KenanY/chart-parsers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KenanY/chart-parsers/teams","hooks_url":"https://api.github.com/repos/KenanY/chart-parsers/hooks","issue_events_url":"https://api.github.com/repos/KenanY/chart-parsers/issues/events{/number}","events_url":"https://api.github.com/repos/KenanY/chart-parsers/events","assignees_url":"https://api.github.com/repos/KenanY/chart-parsers/assignees{/user}","branches_url":"https://api.github.com/repos/KenanY/chart-parsers/branches{/branch}","tags_url":"https://api.github.com/repos/KenanY/chart-parsers/tags","blobs_url":"https://api.github.com/repos/KenanY/chart-parsers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KenanY/chart-parsers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KenanY/chart-parsers/git/refs{/sha}","trees_url":"https://api.github.com/repos/KenanY/chart-parsers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KenanY/chart-parsers/statuses/{sha}","languages_url":"https://api.github.com/repos/KenanY/chart-parsers/languages","stargazers_url":"https://api.github.com/repos/KenanY/chart-parsers/stargazers","contributors_url":"https://api.github.com/repos/KenanY/chart-parsers/contributors","subscribers_url":"https://api.github.com/repos/KenanY/chart-parsers/subscribers","subscription_url":"https://api.github.com/repos/KenanY/chart-parsers/subscription","commits_url":"https://api.github.com/repos/KenanY/chart-parsers/commits{/sha}","git_commits_url":"https://api.github.com/repos/KenanY/chart-parsers/git/commits{/sha}","comments_url":"https://api.github.com/repos/KenanY/chart-parsers/comments{/number}","issue_comment_url":"https://api.github.com/repos/KenanY/chart-parsers/issues/comments{/number}","contents_url":"https://api.github.com/repos/KenanY/chart-parsers/contents/{+path}","compare_url":"https://api.github.com/repos/KenanY/chart-parsers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KenanY/chart-parsers/merges","archive_url":"https://api.github.com/repos/KenanY/chart-parsers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KenanY/chart-parsers/downloads","issues_url":"https://api.github.com/repos/KenanY/chart-parsers/issues{/number}","pulls_url":"https://api.github.com/repos/KenanY/chart-parsers/pulls{/number}","milestones_url":"https://api.github.com/repos/KenanY/chart-parsers/milestones{/number}","notifications_url":"https://api.github.com/repos/KenanY/chart-parsers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KenanY/chart-parsers/labels{/name}","releases_url":"https://api.github.com/repos/KenanY/chart-parsers/releases{/id}","created_at":"2015-03-03T16:54:14Z","updated_at":"2015-03-03T16:54:15Z","pushed_at":"2015-03-03T16:54:33Z","git_url":"git://github.com/KenanY/chart-parsers.git","ssh_url":"git@github.com:KenanY/chart-parsers.git","clone_url":"https://github.com/KenanY/chart-parsers.git","svn_url":"https://github.com/KenanY/chart-parsers","homepage":"","size":1603,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Hugo-ter-Doest:master","ref":"master","sha":"2d8ce60c47a9de6ec10283e6b01ea4d4b1ae858e","user":{"login":"Hugo-ter-Doest","id":7829083,"avatar_url":"https://avatars.githubusercontent.com/u/7829083?v=3","gravatar_id":"","url":"https://api.github.com/users/Hugo-ter-Doest","html_url":"https://github.com/Hugo-ter-Doest","followers_url":"https://api.github.com/users/Hugo-ter-Doest/followers","following_url":"https://api.github.com/users/Hugo-ter-Doest/following{/other_user}","gists_url":"https://api.github.com/users/Hugo-ter-Doest/gists{/gist_id}","starred_url":"https://api.github.com/users/Hugo-ter-Doest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hugo-ter-Doest/subscriptions","organizations_url":"https://api.github.com/users/Hugo-ter-Doest/orgs","repos_url":"https://api.github.com/users/Hugo-ter-Doest/repos","events_url":"https://api.github.com/users/Hugo-ter-Doest/events{/privacy}","received_events_url":"https://api.github.com/users/Hugo-ter-Doest/received_events","type":"User","site_admin":false},"repo":{"id":23283195,"name":"chart-parsers","full_name":"Hugo-ter-Doest/chart-parsers","owner":{"login":"Hugo-ter-Doest","id":7829083,"avatar_url":"https://avatars.githubusercontent.com/u/7829083?v=3","gravatar_id":"","url":"https://api.github.com/users/Hugo-ter-Doest","html_url":"https://github.com/Hugo-ter-Doest","followers_url":"https://api.github.com/users/Hugo-ter-Doest/followers","following_url":"https://api.github.com/users/Hugo-ter-Doest/following{/other_user}","gists_url":"https://api.github.com/users/Hugo-ter-Doest/gists{/gist_id}","starred_url":"https://api.github.com/users/Hugo-ter-Doest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hugo-ter-Doest/subscriptions","organizations_url":"https://api.github.com/users/Hugo-ter-Doest/orgs","repos_url":"https://api.github.com/users/Hugo-ter-Doest/repos","events_url":"https://api.github.com/users/Hugo-ter-Doest/events{/privacy}","received_events_url":"https://api.github.com/users/Hugo-ter-Doest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hugo-ter-Doest/chart-parsers","description":"CYK, Earley, Left-Corner and Head-Corner chart parsers","fork":false,"url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers","forks_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/forks","keys_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/teams","hooks_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/hooks","issue_events_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/issues/events{/number}","events_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/events","assignees_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/assignees{/user}","branches_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/branches{/branch}","tags_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/tags","blobs_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/statuses/{sha}","languages_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/languages","stargazers_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/stargazers","contributors_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/contributors","subscribers_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/subscribers","subscription_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/subscription","commits_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/contents/{+path}","compare_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/merges","archive_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/downloads","issues_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/issues{/number}","pulls_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/pulls{/number}","milestones_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/milestones{/number}","notifications_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/labels{/name}","releases_url":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/releases{/id}","created_at":"2014-08-24T14:35:45Z","updated_at":"2015-03-03T19:55:34Z","pushed_at":"2015-03-03T19:55:34Z","git_url":"git://github.com/Hugo-ter-Doest/chart-parsers.git","ssh_url":"git@github.com:Hugo-ter-Doest/chart-parsers.git","clone_url":"https://github.com/Hugo-ter-Doest/chart-parsers.git","svn_url":"https://github.com/Hugo-ter-Doest/chart-parsers","homepage":"","size":2208,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/pulls/1"},"html":{"href":"https://github.com/Hugo-ter-Doest/chart-parsers/pull/1"},"issue":{"href":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/issues/1"},"comments":{"href":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Hugo-ter-Doest/chart-parsers/statuses/43e19fbc49a92b3b313d2c95c81b3b7e687ef43a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Hugo-ter-Doest","id":7829083,"avatar_url":"https://avatars.githubusercontent.com/u/7829083?v=3","gravatar_id":"","url":"https://api.github.com/users/Hugo-ter-Doest","html_url":"https://github.com/Hugo-ter-Doest","followers_url":"https://api.github.com/users/Hugo-ter-Doest/followers","following_url":"https://api.github.com/users/Hugo-ter-Doest/following{/other_user}","gists_url":"https://api.github.com/users/Hugo-ter-Doest/gists{/gist_id}","starred_url":"https://api.github.com/users/Hugo-ter-Doest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hugo-ter-Doest/subscriptions","organizations_url":"https://api.github.com/users/Hugo-ter-Doest/orgs","repos_url":"https://api.github.com/users/Hugo-ter-Doest/repos","events_url":"https://api.github.com/users/Hugo-ter-Doest/events{/privacy}","received_events_url":"https://api.github.com/users/Hugo-ter-Doest/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":2}}