{"action":"created","issue":{"url":"https://api.github.com/repos/racehub/om-bootstrap/issues/50","labels_url":"https://api.github.com/repos/racehub/om-bootstrap/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/racehub/om-bootstrap/issues/50/comments","events_url":"https://api.github.com/repos/racehub/om-bootstrap/issues/50/events","html_url":"https://github.com/racehub/om-bootstrap/pull/50","id":55901066,"number":50,"title":"[WIP] Support for modals","user":{"login":"dignati","id":1379753,"avatar_url":"https://avatars.githubusercontent.com/u/1379753?v=3","gravatar_id":"","url":"https://api.github.com/users/dignati","html_url":"https://github.com/dignati","followers_url":"https://api.github.com/users/dignati/followers","following_url":"https://api.github.com/users/dignati/following{/other_user}","gists_url":"https://api.github.com/users/dignati/gists{/gist_id}","starred_url":"https://api.github.com/users/dignati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dignati/subscriptions","organizations_url":"https://api.github.com/users/dignati/orgs","repos_url":"https://api.github.com/users/dignati/repos","events_url":"https://api.github.com/users/dignati/events{/privacy}","received_events_url":"https://api.github.com/users/dignati/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-29T13:51:59Z","updated_at":"2015-01-29T15:59:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/racehub/om-bootstrap/pulls/50","html_url":"https://github.com/racehub/om-bootstrap/pull/50","diff_url":"https://github.com/racehub/om-bootstrap/pull/50.diff","patch_url":"https://github.com/racehub/om-bootstrap/pull/50.patch"},"body":"This adds support for modals. I opened the pull request to discuss how the modal should be activated/faded in. Some sort of channel or function to call?"},"comment":{"url":"https://api.github.com/repos/racehub/om-bootstrap/issues/comments/72049326","html_url":"https://github.com/racehub/om-bootstrap/pull/50#issuecomment-72049326","issue_url":"https://api.github.com/repos/racehub/om-bootstrap/issues/50","id":72049326,"user":{"login":"dpetrovics","id":288236,"avatar_url":"https://avatars.githubusercontent.com/u/288236?v=3","gravatar_id":"","url":"https://api.github.com/users/dpetrovics","html_url":"https://github.com/dpetrovics","followers_url":"https://api.github.com/users/dpetrovics/followers","following_url":"https://api.github.com/users/dpetrovics/following{/other_user}","gists_url":"https://api.github.com/users/dpetrovics/gists{/gist_id}","starred_url":"https://api.github.com/users/dpetrovics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpetrovics/subscriptions","organizations_url":"https://api.github.com/users/dpetrovics/orgs","repos_url":"https://api.github.com/users/dpetrovics/repos","events_url":"https://api.github.com/users/dpetrovics/events{/privacy}","received_events_url":"https://api.github.com/users/dpetrovics/received_events","type":"User","site_admin":false},"created_at":"2015-01-29T15:59:04Z","updated_at":"2015-01-29T15:59:04Z","body":"Definitely-- we're not tied to mimicking their approach. If you think you\r\ncan cleanly implement it by just handling the logic within the modal\r\ncomponent that's fine by me. Thanks for this!\r\nOn Jan 29, 2015 8:41 AM, \"Ole Krüger\" <notifications@github.com> wrote:\r\n\r\n> Oh I'm happy to contribute to this great project!\r\n>\r\n> As I said in #7 <https://github.com/racehub/om-bootstrap/issues/7>,\r\n> implementing the FadeMixin feels very hacky (timeouts, string replacement\r\n> to add and remove classes etc.). Would it be an option to handle the fade\r\n> logic inside the modal component and provide the user a function to open\r\n> the modal? I understand that this is not how react-bootstrap did it but\r\n> maybe this approach could actually be better.\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/racehub/om-bootstrap/pull/50#issuecomment-72045897>.\r\n>"}}