{"action":"created","comment":{"url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/pulls/comments/26220690","id":26220690,"diff_hunk":"@@ -111,7 +119,14 @@ function processKey(key, cb) {\n     }\n     fs.appendFileSync(program.file, JSON.stringify(out,null,'\\t'));\n     first=false;\n-    return cb();\n+    \n+    if (deleteKeys) {","path":"bin/riak-bucket-exporter.js","position":null,"original_position":31,"commit_id":"01cb3ca3a7c08ca3a5c3bf12f0341525787ca161","original_commit_id":"b2c1c9da08ff7d6d8d0ef822b92c31ef6b7a53d7","user":{"login":"cthayer","id":626418,"avatar_url":"https://avatars.githubusercontent.com/u/626418?v=3","gravatar_id":"","url":"https://api.github.com/users/cthayer","html_url":"https://github.com/cthayer","followers_url":"https://api.github.com/users/cthayer/followers","following_url":"https://api.github.com/users/cthayer/following{/other_user}","gists_url":"https://api.github.com/users/cthayer/gists{/gist_id}","starred_url":"https://api.github.com/users/cthayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cthayer/subscriptions","organizations_url":"https://api.github.com/users/cthayer/orgs","repos_url":"https://api.github.com/users/cthayer/repos","events_url":"https://api.github.com/users/cthayer/events{/privacy}","received_events_url":"https://api.github.com/users/cthayer/received_events","type":"User","site_admin":false},"body":"I've made all your suggested changes.  I think it's cleaner that way.\r\n\r\nWasn't sure how you would increment the version number though.  I was tempted to increment it to 0.2.0 (minor increment since there's a new feature), but wanted to get your feedback before doing that.","created_at":"2015-03-11T15:14:08Z","updated_at":"2015-03-11T15:14:08Z","html_url":"https://github.com/maurermax/riak-bucket-exporter/pull/1#discussion_r26220690","pull_request_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/maurermax/riak-bucket-exporter/pulls/comments/26220690"},"html":{"href":"https://github.com/maurermax/riak-bucket-exporter/pull/1#discussion_r26220690"},"pull_request":{"href":"https://api.github.com/repos/maurermax/riak-bucket-exporter/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/pulls/1","id":29704348,"html_url":"https://github.com/maurermax/riak-bucket-exporter/pull/1","diff_url":"https://github.com/maurermax/riak-bucket-exporter/pull/1.diff","patch_url":"https://github.com/maurermax/riak-bucket-exporter/pull/1.patch","issue_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/issues/1","number":1,"state":"open","locked":false,"title":"option to delete exported keys","user":{"login":"cthayer","id":626418,"avatar_url":"https://avatars.githubusercontent.com/u/626418?v=3","gravatar_id":"","url":"https://api.github.com/users/cthayer","html_url":"https://github.com/cthayer","followers_url":"https://api.github.com/users/cthayer/followers","following_url":"https://api.github.com/users/cthayer/following{/other_user}","gists_url":"https://api.github.com/users/cthayer/gists{/gist_id}","starred_url":"https://api.github.com/users/cthayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cthayer/subscriptions","organizations_url":"https://api.github.com/users/cthayer/orgs","repos_url":"https://api.github.com/users/cthayer/repos","events_url":"https://api.github.com/users/cthayer/events{/privacy}","received_events_url":"https://api.github.com/users/cthayer/received_events","type":"User","site_admin":false},"body":"Allow an option to be specified during export (`--delete`) that deletes the exported keys from riak as they are exported (after being appended to the output file)","created_at":"2015-02-20T15:31:30Z","updated_at":"2015-03-11T15:14:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c53822d2a0722df1bb25d6a328c721c28a43a1e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/pulls/1/commits","review_comments_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/pulls/1/comments","review_comment_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/issues/1/comments","statuses_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/statuses/01cb3ca3a7c08ca3a5c3bf12f0341525787ca161","head":{"label":"cthayer:patch-1","ref":"patch-1","sha":"01cb3ca3a7c08ca3a5c3bf12f0341525787ca161","user":{"login":"cthayer","id":626418,"avatar_url":"https://avatars.githubusercontent.com/u/626418?v=3","gravatar_id":"","url":"https://api.github.com/users/cthayer","html_url":"https://github.com/cthayer","followers_url":"https://api.github.com/users/cthayer/followers","following_url":"https://api.github.com/users/cthayer/following{/other_user}","gists_url":"https://api.github.com/users/cthayer/gists{/gist_id}","starred_url":"https://api.github.com/users/cthayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cthayer/subscriptions","organizations_url":"https://api.github.com/users/cthayer/orgs","repos_url":"https://api.github.com/users/cthayer/repos","events_url":"https://api.github.com/users/cthayer/events{/privacy}","received_events_url":"https://api.github.com/users/cthayer/received_events","type":"User","site_admin":false},"repo":{"id":31070196,"name":"riak-bucket-exporter","full_name":"cthayer/riak-bucket-exporter","owner":{"login":"cthayer","id":626418,"avatar_url":"https://avatars.githubusercontent.com/u/626418?v=3","gravatar_id":"","url":"https://api.github.com/users/cthayer","html_url":"https://github.com/cthayer","followers_url":"https://api.github.com/users/cthayer/followers","following_url":"https://api.github.com/users/cthayer/following{/other_user}","gists_url":"https://api.github.com/users/cthayer/gists{/gist_id}","starred_url":"https://api.github.com/users/cthayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cthayer/subscriptions","organizations_url":"https://api.github.com/users/cthayer/orgs","repos_url":"https://api.github.com/users/cthayer/repos","events_url":"https://api.github.com/users/cthayer/events{/privacy}","received_events_url":"https://api.github.com/users/cthayer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cthayer/riak-bucket-exporter","description":"Small node utility to export a whole bucket with all keys from riak into a file","fork":true,"url":"https://api.github.com/repos/cthayer/riak-bucket-exporter","forks_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/forks","keys_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/teams","hooks_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/hooks","issue_events_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/issues/events{/number}","events_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/events","assignees_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/assignees{/user}","branches_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/branches{/branch}","tags_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/tags","blobs_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/languages","stargazers_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/stargazers","contributors_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/contributors","subscribers_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/subscribers","subscription_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/subscription","commits_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/contents/{+path}","compare_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/merges","archive_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/downloads","issues_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/issues{/number}","pulls_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/labels{/name}","releases_url":"https://api.github.com/repos/cthayer/riak-bucket-exporter/releases{/id}","created_at":"2015-02-20T15:15:42Z","updated_at":"2015-02-20T15:15:43Z","pushed_at":"2015-03-11T15:11:37Z","git_url":"git://github.com/cthayer/riak-bucket-exporter.git","ssh_url":"git@github.com:cthayer/riak-bucket-exporter.git","clone_url":"https://github.com/cthayer/riak-bucket-exporter.git","svn_url":"https://github.com/cthayer/riak-bucket-exporter","homepage":null,"size":119,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maurermax:master","ref":"master","sha":"19d482a32ca89df54e72b8ca80a778c51cd47eea","user":{"login":"maurermax","id":8026463,"avatar_url":"https://avatars.githubusercontent.com/u/8026463?v=3","gravatar_id":"","url":"https://api.github.com/users/maurermax","html_url":"https://github.com/maurermax","followers_url":"https://api.github.com/users/maurermax/followers","following_url":"https://api.github.com/users/maurermax/following{/other_user}","gists_url":"https://api.github.com/users/maurermax/gists{/gist_id}","starred_url":"https://api.github.com/users/maurermax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maurermax/subscriptions","organizations_url":"https://api.github.com/users/maurermax/orgs","repos_url":"https://api.github.com/users/maurermax/repos","events_url":"https://api.github.com/users/maurermax/events{/privacy}","received_events_url":"https://api.github.com/users/maurermax/received_events","type":"User","site_admin":false},"repo":{"id":23180567,"name":"riak-bucket-exporter","full_name":"maurermax/riak-bucket-exporter","owner":{"login":"maurermax","id":8026463,"avatar_url":"https://avatars.githubusercontent.com/u/8026463?v=3","gravatar_id":"","url":"https://api.github.com/users/maurermax","html_url":"https://github.com/maurermax","followers_url":"https://api.github.com/users/maurermax/followers","following_url":"https://api.github.com/users/maurermax/following{/other_user}","gists_url":"https://api.github.com/users/maurermax/gists{/gist_id}","starred_url":"https://api.github.com/users/maurermax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maurermax/subscriptions","organizations_url":"https://api.github.com/users/maurermax/orgs","repos_url":"https://api.github.com/users/maurermax/repos","events_url":"https://api.github.com/users/maurermax/events{/privacy}","received_events_url":"https://api.github.com/users/maurermax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maurermax/riak-bucket-exporter","description":"Small node utility to export a whole bucket with all keys from riak into a file","fork":false,"url":"https://api.github.com/repos/maurermax/riak-bucket-exporter","forks_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/forks","keys_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/teams","hooks_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/hooks","issue_events_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/issues/events{/number}","events_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/events","assignees_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/assignees{/user}","branches_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/branches{/branch}","tags_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/tags","blobs_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/languages","stargazers_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/stargazers","contributors_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/contributors","subscribers_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/subscribers","subscription_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/subscription","commits_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/contents/{+path}","compare_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/merges","archive_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/downloads","issues_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/issues{/number}","pulls_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/labels{/name}","releases_url":"https://api.github.com/repos/maurermax/riak-bucket-exporter/releases{/id}","created_at":"2014-08-21T08:55:21Z","updated_at":"2015-03-02T13:51:10Z","pushed_at":"2015-03-02T13:51:10Z","git_url":"git://github.com/maurermax/riak-bucket-exporter.git","ssh_url":"git@github.com:maurermax/riak-bucket-exporter.git","clone_url":"https://github.com/maurermax/riak-bucket-exporter.git","svn_url":"https://github.com/maurermax/riak-bucket-exporter","homepage":null,"size":194,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maurermax/riak-bucket-exporter/pulls/1"},"html":{"href":"https://github.com/maurermax/riak-bucket-exporter/pull/1"},"issue":{"href":"https://api.github.com/repos/maurermax/riak-bucket-exporter/issues/1"},"comments":{"href":"https://api.github.com/repos/maurermax/riak-bucket-exporter/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/maurermax/riak-bucket-exporter/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/maurermax/riak-bucket-exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maurermax/riak-bucket-exporter/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/maurermax/riak-bucket-exporter/statuses/01cb3ca3a7c08ca3a5c3bf12f0341525787ca161"}}}}