{"action":"created","issue":{"url":"https://api.github.com/repos/janinko/ghprb/issues/322","labels_url":"https://api.github.com/repos/janinko/ghprb/issues/322/labels{/name}","comments_url":"https://api.github.com/repos/janinko/ghprb/issues/322/comments","events_url":"https://api.github.com/repos/janinko/ghprb/issues/322/events","html_url":"https://github.com/janinko/ghprb/issues/322","id":104677603,"number":322,"title":"ghprbPullLongDescription causes Windows builds to break","user":{"login":"marcocast","id":706746,"avatar_url":"https://avatars.githubusercontent.com/u/706746?v=3","gravatar_id":"","url":"https://api.github.com/users/marcocast","html_url":"https://github.com/marcocast","followers_url":"https://api.github.com/users/marcocast/followers","following_url":"https://api.github.com/users/marcocast/following{/other_user}","gists_url":"https://api.github.com/users/marcocast/gists{/gist_id}","starred_url":"https://api.github.com/users/marcocast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcocast/subscriptions","organizations_url":"https://api.github.com/users/marcocast/orgs","repos_url":"https://api.github.com/users/marcocast/repos","events_url":"https://api.github.com/users/marcocast/events{/privacy}","received_events_url":"https://api.github.com/users/marcocast/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-03T12:14:32Z","updated_at":"2015-09-11T14:18:15Z","closed_at":null,"body":"Hi,\r\n\r\nWe have a Jenkins job configured with the ghprb plugin to run builds against a matrix of slaves (Linux,Mac, Windows).\r\n\r\nLinux and Mac environments work well, but in windows we noticed a problem related with the ghprbPullLongDescription system property passed  at execution time. \r\nThe problem is that there are multiple git comments joined together, but separated by a break line that is badly handled by Windows OS. \r\n\r\nIt would be good to be able to optionally remove some of the properties defined in the GhprbTrigger.startJob \r\n\r\nThanks\r\n\r\nMarco"},"comment":{"url":"https://api.github.com/repos/janinko/ghprb/issues/comments/139558797","html_url":"https://github.com/janinko/ghprb/issues/322#issuecomment-139558797","issue_url":"https://api.github.com/repos/janinko/ghprb/issues/322","id":139558797,"user":{"login":"vorburger","id":298598,"avatar_url":"https://avatars.githubusercontent.com/u/298598?v=3","gravatar_id":"","url":"https://api.github.com/users/vorburger","html_url":"https://github.com/vorburger","followers_url":"https://api.github.com/users/vorburger/followers","following_url":"https://api.github.com/users/vorburger/following{/other_user}","gists_url":"https://api.github.com/users/vorburger/gists{/gist_id}","starred_url":"https://api.github.com/users/vorburger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vorburger/subscriptions","organizations_url":"https://api.github.com/users/vorburger/orgs","repos_url":"https://api.github.com/users/vorburger/repos","events_url":"https://api.github.com/users/vorburger/events{/privacy}","received_events_url":"https://api.github.com/users/vorburger/received_events","type":"User","site_admin":false},"created_at":"2015-09-11T14:18:15Z","updated_at":"2015-09-11T14:18:15Z","body":"Same problem here.. more details: The -DghprbPullLongDescription intro. https://github.com/jenkinsci/ghprb-plugin/pull/105 can cause errors such as:\r\n\r\n    [master-build] $ cmd.exe /C '\"C:\\EDS\\ant\\ant-1.9.0.dist\\bin\\ant.bat -file build.xml -DghprbCommentBody=null -DghprbTriggerAuthorEmail=\"\" -DghprbTargetBranch=master -DghprbSourceBranch=DS-9174_headlessELangTAP_final \"-DghprbActualCommitAuthor=Michael Vorburger\" -Dsha1=origin/pr/1067/merge \"-DghprbPullLongDescription=BLA BLA\r\n    BLA BLA _very_ long...\r\n    ... multi line description\" -DghprbPullLink=https://github.com/TemenosDS/DS/pull/1067 -DghprbActualCommit=bfdd7a70b5d69879d74162eea1a58512e1ece08b -DghprbTriggerAuthorLoginMention=\"\" -DGIT_BRANCH=DS-9174_headlessELangTAP_final -DghprbPullAuthorEmail=michael.vorburger+github-profile@gmail.com -DghprbPullAuthorLogin=vorburger -DghprbActualCommitAuthorEmail=mvorburger@temenos.com -DghprbTriggerAuthor=\"\" -DghprbTriggerAuthorLogin=\"\" -DghprbPullId=1067 \"-DghprbPullTitle=DS-9174 DS Generator failing with 'The method ==(boolean) is undefined'\" -DghprbPullAuthorLoginMention=@vorburger \"-DghprbPullDescription=GitHub pull request #1067 of commit bfdd7a70b5d69879d74162eea1a58512e1ece08b, no merge conflicts.\" -Dds.skip.40-Plugins-Build=false -Dskip.62-Big-Tests--TAP-Models-Generation=true -Dds.remote.build=true -Dds.skip.63-Medium-Tests--T24-Models-Generation-and-Packaging=false -Dds.skip.10-Prepare-Dependencies=false -Dds.skip.50-Small-Tests--Unit-Tests=false -Dds.skip.15-b2-Templates=false -Dskip.65-Big-Tests--BM-Maven-Generation=true -Dds.skip.73-Big-tests--Component-Framework-Integration-Test=false -Dds.p2cache.location.relative=../../ds.p2.repo.cache -Dds.skip.72-Big-Tests--Hothouse-Fully-Loaded-Test=true -Dds.skip.30-Documentation=false -Dds.skip.71-Big-Tests--Hothouse-Test=true -Dsun.net.client.defaultConnectTimeout=10000 -Dds.skip.68-Big-Tests--T24-External-Tests=false -Dds.skip.60-Products-Only-Build=false -Dds.skip.09-T24-Maven=false -Dds.skip.99-Final-Cleanup=true -Dsun.net.client.defaultReadTimeout=10000 -Dds.skip.69-Big-Tests--TAP-External-Tests=false -Dds.skip.61-Runtime-Build=false build-all-online && exit %%ERRORLEVEL%%\"'\r\n    The syntax of the command is incorrect.\r\n    Build step 'Invoke Ant' marked build as failure\r\n\r\nHow about simply trimming the content of -DghprbPullLongDescription if exceeding some max length? Only on Windows slaves if that information, or just everywhere, is that a problem? Or does Jenkins have some better built-in lower level support to deal with max. length of exec problems on Windows? (Like creating an intermediate script approach?)\r\n\r\nWould a pull request from us proposing this be welcome and be merged?"}}