{"action":"created","issue":{"url":"https://api.github.com/repos/ruby/ruby/issues/803","labels_url":"https://api.github.com/repos/ruby/ruby/issues/803/labels{/name}","comments_url":"https://api.github.com/repos/ruby/ruby/issues/803/comments","events_url":"https://api.github.com/repos/ruby/ruby/issues/803/events","html_url":"https://github.com/ruby/ruby/pull/803","id":53240089,"number":803,"title":"Tidying up string scrub tests","user":{"login":"brocktimus","id":2103728,"avatar_url":"https://avatars.githubusercontent.com/u/2103728?v=3","gravatar_id":"","url":"https://api.github.com/users/brocktimus","html_url":"https://github.com/brocktimus","followers_url":"https://api.github.com/users/brocktimus/followers","following_url":"https://api.github.com/users/brocktimus/following{/other_user}","gists_url":"https://api.github.com/users/brocktimus/gists{/gist_id}","starred_url":"https://api.github.com/users/brocktimus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brocktimus/subscriptions","organizations_url":"https://api.github.com/users/brocktimus/orgs","repos_url":"https://api.github.com/users/brocktimus/repos","events_url":"https://api.github.com/users/brocktimus/events{/privacy}","received_events_url":"https://api.github.com/users/brocktimus/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-02T06:48:53Z","updated_at":"2015-01-02T19:04:53Z","closed_at":"2015-01-02T06:51:09Z","pull_request":{"url":"https://api.github.com/repos/ruby/ruby/pulls/803","html_url":"https://github.com/ruby/ruby/pull/803","diff_url":"https://github.com/ruby/ruby/pull/803.diff","patch_url":"https://github.com/ruby/ruby/pull/803.patch"},"body":"There was finger pointing earlier someone pointed at String#scrub tests for being incomprehensible. So I'm following @headius lead and opening a PR. Starting here and see where my time lets me go.\r\n\r\nThis is a pure refactoring, no functional code change in the slightest. Just moving code around to give each test case a more descriptive name.\r\n\r\nI don't know exactly what all these tests cases are doing but I've tried to take a best guess to get started to see if there is interest. Starting on github because its easier for me, when I'm done with String#scrub tests I'll move to redmine or flatten as required.\r\n\r\nOnly 10 assertions left in the original #test_scrub, I don't fully understand what they're doing so any advice would be great. Similarly if my names are incorrect just let me know what they should be! If this is too much talking on a PR I'll take discussions elsewhere.\r\n\r\n/cc @headius, @zzak."},"comment":{"url":"https://api.github.com/repos/ruby/ruby/issues/comments/68552315","html_url":"https://github.com/ruby/ruby/pull/803#issuecomment-68552315","issue_url":"https://api.github.com/repos/ruby/ruby/issues/803","id":68552315,"user":{"login":"zzak","id":277819,"avatar_url":"https://avatars.githubusercontent.com/u/277819?v=3","gravatar_id":"","url":"https://api.github.com/users/zzak","html_url":"https://github.com/zzak","followers_url":"https://api.github.com/users/zzak/followers","following_url":"https://api.github.com/users/zzak/following{/other_user}","gists_url":"https://api.github.com/users/zzak/gists{/gist_id}","starred_url":"https://api.github.com/users/zzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zzak/subscriptions","organizations_url":"https://api.github.com/users/zzak/orgs","repos_url":"https://api.github.com/users/zzak/repos","events_url":"https://api.github.com/users/zzak/events{/privacy}","received_events_url":"https://api.github.com/users/zzak/received_events","type":"User","site_admin":false},"created_at":"2015-01-02T19:04:53Z","updated_at":"2015-01-02T19:04:53Z","body":":+1: Thank you for pitching in"}}