{"action":"created","issue":{"url":"https://api.github.com/repos/iStefo/ember-select-2/issues/92","labels_url":"https://api.github.com/repos/iStefo/ember-select-2/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/iStefo/ember-select-2/issues/92/comments","events_url":"https://api.github.com/repos/iStefo/ember-select-2/issues/92/events","html_url":"https://github.com/iStefo/ember-select-2/pull/92","id":73778418,"number":92,"title":"[WIP] Tagging with ember data support","user":{"login":"steffenbrem","id":1569156,"avatar_url":"https://avatars.githubusercontent.com/u/1569156?v=3","gravatar_id":"","url":"https://api.github.com/users/steffenbrem","html_url":"https://github.com/steffenbrem","followers_url":"https://api.github.com/users/steffenbrem/followers","following_url":"https://api.github.com/users/steffenbrem/following{/other_user}","gists_url":"https://api.github.com/users/steffenbrem/gists{/gist_id}","starred_url":"https://api.github.com/users/steffenbrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffenbrem/subscriptions","organizations_url":"https://api.github.com/users/steffenbrem/orgs","repos_url":"https://api.github.com/users/steffenbrem/repos","events_url":"https://api.github.com/users/steffenbrem/events{/privacy}","received_events_url":"https://api.github.com/users/steffenbrem/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-07T00:15:54Z","updated_at":"2015-05-07T16:05:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/iStefo/ember-select-2/pulls/92","html_url":"https://github.com/iStefo/ember-select-2/pull/92","diff_url":"https://github.com/iStefo/ember-select-2/pull/92.diff","patch_url":"https://github.com/iStefo/ember-select-2/pull/92.patch"},"body":"This fixes issue #7 \r\n\r\nI am currently working on supporting tags in this component, while also supporting ember data. You can pass in an ember data record array (`DS.RecordArray`) instance, and it will create new tags based on the\r\n`type` of the recordarray, almost magic.\r\n\r\nThis PR is still a WIP and is still made with only ember data in mind, any feedback is welcome!\r\n\r\n@iStefo Could you review this, note this is still a WIP, but would like to know your ideas on this.\r\n\r\nCurrently, the following settings work as you would expect:\r\n\r\n| Option           | Type | Info\r\n| ----------------- | ------  | ------------------------------------------- |\r\n| tags               | bool | This is required to enable tagging |\r\n| content          | Array | This can also be an ember data record array |\r\n| value             | Array | This can also be an ember data record array, new records are appended automatically. When a **new** tag is deleted, the record is unloaded from the store. |\r\n| optionLabelPath | string | This will be mapped to the field name of the ember data model too, this would be something like `title` or `name`. |\r\n| optionIdPath | string | Set this the same as the label to have unique tags |\r\n\r\nExample usage (you could leave out `content` here if you don't want to preload some tags):\r\n```hbs\r\n{{select-2\r\n    tags=true\r\n    content=model.tags\r\n    value=model.post.tags\r\n    placeholder=\"Begin typing tags for this post\"\r\n    optionLabelPath=\"name\"\r\n    optionIdPath=\"name\"\r\n}}\r\n```\r\n\r\n## TODO\r\n- [ ] Test this functionality for both ember data objects and for simple objects\r\n- [ ] Complete examples/documentation"},"comment":{"url":"https://api.github.com/repos/iStefo/ember-select-2/issues/comments/99923202","html_url":"https://github.com/iStefo/ember-select-2/pull/92#issuecomment-99923202","issue_url":"https://api.github.com/repos/iStefo/ember-select-2/issues/92","id":99923202,"user":{"login":"iStefo","id":768764,"avatar_url":"https://avatars.githubusercontent.com/u/768764?v=3","gravatar_id":"","url":"https://api.github.com/users/iStefo","html_url":"https://github.com/iStefo","followers_url":"https://api.github.com/users/iStefo/followers","following_url":"https://api.github.com/users/iStefo/following{/other_user}","gists_url":"https://api.github.com/users/iStefo/gists{/gist_id}","starred_url":"https://api.github.com/users/iStefo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iStefo/subscriptions","organizations_url":"https://api.github.com/users/iStefo/orgs","repos_url":"https://api.github.com/users/iStefo/repos","events_url":"https://api.github.com/users/iStefo/events{/privacy}","received_events_url":"https://api.github.com/users/iStefo/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T16:05:52Z","updated_at":"2015-05-07T16:05:52Z","body":"Actually, I'm not sure about naming this option `create`, because the behaviour is what most people would understand as tagging (and also select2 iteself calls it tagging). What do you think about `createTags=true`? It's a little verbose but also states the suggested use case for the option."}}