{"action":"created","issue":{"url":"https://api.github.com/repos/prometheus/consul_exporter/issues/8","labels_url":"https://api.github.com/repos/prometheus/consul_exporter/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/consul_exporter/issues/8/comments","events_url":"https://api.github.com/repos/prometheus/consul_exporter/issues/8/events","html_url":"https://github.com/prometheus/consul_exporter/pull/8","id":88744113,"number":8,"title":"Add support for exposing key-value pairs (implements #7)","user":{"login":"raboof","id":131856,"avatar_url":"https://avatars.githubusercontent.com/u/131856?v=3","gravatar_id":"","url":"https://api.github.com/users/raboof","html_url":"https://github.com/raboof","followers_url":"https://api.github.com/users/raboof/followers","following_url":"https://api.github.com/users/raboof/following{/other_user}","gists_url":"https://api.github.com/users/raboof/gists{/gist_id}","starred_url":"https://api.github.com/users/raboof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raboof/subscriptions","organizations_url":"https://api.github.com/users/raboof/orgs","repos_url":"https://api.github.com/users/raboof/repos","events_url":"https://api.github.com/users/raboof/events{/privacy}","received_events_url":"https://api.github.com/users/raboof/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-06-16T14:30:55Z","updated_at":"2015-06-17T15:28:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/prometheus/consul_exporter/pulls/8","html_url":"https://github.com/prometheus/consul_exporter/pull/8","diff_url":"https://github.com/prometheus/consul_exporter/pull/8.diff","patch_url":"https://github.com/prometheus/consul_exporter/pull/8.patch"},"body":"This appears to work well here. \r\n\r\nI'm not too proficient in go yet so I'd appreciate feedback. \r\n\r\nIn particular, I suspect `kv.List` might be blocking so it might be worthwhile to do this as a goroutine that puts the pairs on a channel - on the other hand, if I understand correctly `setMetrics` doesn't do this either, so perhaps it's inconsequential."},"comment":{"url":"https://api.github.com/repos/prometheus/consul_exporter/issues/comments/112846543","html_url":"https://github.com/prometheus/consul_exporter/pull/8#issuecomment-112846543","issue_url":"https://api.github.com/repos/prometheus/consul_exporter/issues/8","id":112846543,"user":{"login":"ewr","id":204350,"avatar_url":"https://avatars.githubusercontent.com/u/204350?v=3","gravatar_id":"","url":"https://api.github.com/users/ewr","html_url":"https://github.com/ewr","followers_url":"https://api.github.com/users/ewr/followers","following_url":"https://api.github.com/users/ewr/following{/other_user}","gists_url":"https://api.github.com/users/ewr/gists{/gist_id}","starred_url":"https://api.github.com/users/ewr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewr/subscriptions","organizations_url":"https://api.github.com/users/ewr/orgs","repos_url":"https://api.github.com/users/ewr/repos","events_url":"https://api.github.com/users/ewr/events{/privacy}","received_events_url":"https://api.github.com/users/ewr/received_events","type":"User","site_admin":false},"created_at":"2015-06-17T15:28:39Z","updated_at":"2015-06-17T15:28:39Z","body":"It appears that `--kv.prefix='/'` will get all keys, so empty string should be a safe default."}}