{"action":"created","issue":{"url":"https://api.github.com/repos/oaeproject/Hilary/issues/1149","labels_url":"https://api.github.com/repos/oaeproject/Hilary/issues/1149/labels{/name}","comments_url":"https://api.github.com/repos/oaeproject/Hilary/issues/1149/comments","events_url":"https://api.github.com/repos/oaeproject/Hilary/issues/1149/events","html_url":"https://github.com/oaeproject/Hilary/pull/1149","id":62811134,"number":1149,"title":"Group delete functionality","user":{"login":"mrvisser","id":102265,"avatar_url":"https://avatars.githubusercontent.com/u/102265?v=3","gravatar_id":"","url":"https://api.github.com/users/mrvisser","html_url":"https://github.com/mrvisser","followers_url":"https://api.github.com/users/mrvisser/followers","following_url":"https://api.github.com/users/mrvisser/following{/other_user}","gists_url":"https://api.github.com/users/mrvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/mrvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrvisser/subscriptions","organizations_url":"https://api.github.com/users/mrvisser/orgs","repos_url":"https://api.github.com/users/mrvisser/repos","events_url":"https://api.github.com/users/mrvisser/events{/privacy}","received_events_url":"https://api.github.com/users/mrvisser/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/oaeproject/Hilary/labels/To%20Review","name":"To Review","color":"75c3ff"}],"state":"open","locked":false,"assignee":{"login":"simong","id":92180,"avatar_url":"https://avatars.githubusercontent.com/u/92180?v=3","gravatar_id":"","url":"https://api.github.com/users/simong","html_url":"https://github.com/simong","followers_url":"https://api.github.com/users/simong/followers","following_url":"https://api.github.com/users/simong/following{/other_user}","gists_url":"https://api.github.com/users/simong/gists{/gist_id}","starred_url":"https://api.github.com/users/simong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simong/subscriptions","organizations_url":"https://api.github.com/users/simong/orgs","repos_url":"https://api.github.com/users/simong/repos","events_url":"https://api.github.com/users/simong/events{/privacy}","received_events_url":"https://api.github.com/users/simong/received_events","type":"User","site_admin":false},"milestone":null,"comments":9,"created_at":"2015-03-18T21:47:16Z","updated_at":"2015-03-20T22:11:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/oaeproject/Hilary/pulls/1149","html_url":"https://github.com/oaeproject/Hilary/pull/1149","diff_url":"https://github.com/oaeproject/Hilary/pull/1149.diff","patch_url":"https://github.com/oaeproject/Hilary/pull/1149.patch"},"body":"This PR adds back-end functionality for deleting groups. Here is a list of things that are covered:\r\n\r\nDirect functionality:\r\n\r\n* When a group is deleted, memberships libraries no longer contain it, as well as groups that have access by virtue of access through deleted groups\r\n* When a group is deleted, it no longer shows up in search\r\n* When a group is restored, memberships libraries are fully restored\r\n* When a group is restored, it returns into search\r\n* When a group still shows up in members lists when it is deleted, there is a `deleted` property that is the millis-since-the-epoch that it was deleted\r\n* Deleting and restoring is idempotent, so any bugs/failures while deletes and restores are processing should be simple to \"reply\" by invoking another delete/restore for the same group\r\n* It is possible to search deleted items similar to general search: `/api/search/deleted`\r\n    * Tenant admins can search only deleted items from their own tenant\r\n    * Global admins can search deleted items from any tenant by use of `scope`, similar to `general` search\r\n\r\nIndirect functionality:\r\n\r\n* Ground-work was implemented for AuthzAPI to support managing \"deleted ids\". Further work could be done to implement a bloomfilter for deleted items so deleted checks could be done completely locally at the cost of several hashes instead of IO / Cassandra hit\r\n* The AuthzMembershipsCache is now cached as an encoded graph instead of a list. It is possible to query full memberships and full members (indirect) by virtue of accessing a MembershipsGraph or a MembersGraph from the AuthzAPI\r\n\r\nWhat's *not* implemented:\r\n\r\n* User delete is not implemented\r\n* Note that permissions are not erased by deleting a group. Content managers are responsible for removing groups that are deleted from being a member if they want to remove access\r\n\r\nThat's all I can think of right now. Please wait until I self-review before doing a detailed review (I'll notify), but feel free to have a high-level look.\r\n"},"comment":{"url":"https://api.github.com/repos/oaeproject/Hilary/issues/comments/84167267","html_url":"https://github.com/oaeproject/Hilary/pull/1149#issuecomment-84167267","issue_url":"https://api.github.com/repos/oaeproject/Hilary/issues/1149","id":84167267,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2015-03-20T22:11:46Z","updated_at":"2015-03-20T22:11:46Z","body":"\n[![Coverage Status](https://coveralls.io/builds/2162033/badge)](https://coveralls.io/builds/2162033)\n\nChanges Unknown when pulling **a1fda94a60b0ce57a729c1fe989f9a7b74fd93e6 on mrvisser:delete-groups** into ** on oaeproject:master**.\n"}}