{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/7546","labels_url":"https://api.github.com/repos/servo/servo/issues/7546/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/7546/comments","events_url":"https://api.github.com/repos/servo/servo/issues/7546/events","html_url":"https://github.com/servo/servo/pull/7546","id":104955659,"number":7546,"title":"Lint to check alphabetical order of uses, mods & crates","user":{"login":"Wafflespeanut","id":6691262,"avatar_url":"https://avatars.githubusercontent.com/u/6691262?v=3","gravatar_id":"","url":"https://api.github.com/users/Wafflespeanut","html_url":"https://github.com/Wafflespeanut","followers_url":"https://api.github.com/users/Wafflespeanut/followers","following_url":"https://api.github.com/users/Wafflespeanut/following{/other_user}","gists_url":"https://api.github.com/users/Wafflespeanut/gists{/gist_id}","starred_url":"https://api.github.com/users/Wafflespeanut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wafflespeanut/subscriptions","organizations_url":"https://api.github.com/users/Wafflespeanut/orgs","repos_url":"https://api.github.com/users/Wafflespeanut/repos","events_url":"https://api.github.com/users/Wafflespeanut/events{/privacy}","received_events_url":"https://api.github.com/users/Wafflespeanut/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"milestone":null,"comments":13,"created_at":"2015-09-04T19:29:31Z","updated_at":"2015-09-15T18:38:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/7546","html_url":"https://github.com/servo/servo/pull/7546","diff_url":"https://github.com/servo/servo/pull/7546.diff","patch_url":"https://github.com/servo/servo/pull/7546.patch"},"body":"fixes #7451\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/7546)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/140493778","html_url":"https://github.com/servo/servo/pull/7546#issuecomment-140493778","issue_url":"https://api.github.com/repos/servo/servo/issues/7546","id":140493778,"user":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"created_at":"2015-09-15T18:38:36Z","updated_at":"2015-09-15T18:38:36Z","body":"\n\n\n\nReviewed 1 of 1 files at r2, 1 of 1 files at r3.\nReview status: all files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.\n\n---\n\n<sup>**[components/plugins/lints/sorter.rs, line 34 \\[r2\\]](https://reviewable.io:443/reviews/servo/servo/7546#-JzD0pyYN5VHfgXJ3PaF)** ([raw file](https://github.com/servo/servo/blob/f4f19e8af8442fc916760320991888e91cdf97e0/components/plugins/lints/sorter.rs#L34)):</sup>\nAlso ignore mods with attributes\n\n---\n\n<sup>**[components/plugins/lints/sorter.rs, line 55 \\[r2\\]](https://reviewable.io:443/reviews/servo/servo/7546#-JzD1d2hj6km-CmMd-Oc)** ([raw file](https://github.com/servo/servo/blob/f4f19e8af8442fc916760320991888e91cdf97e0/components/plugins/lints/sorter.rs#L55)):</sup>\nYou need to sort it so that `self` comes at the beginning of the list\n\n---\n\n<sup>**[components/plugins/lints/sorter.rs, line 87 \\[r3\\]](https://reviewable.io:443/reviews/servo/servo/7546#-JzHHnvLfxwQ3Ii7TZDF)** ([raw file](https://github.com/servo/servo/blob/dda080496a4bc88e7410af5bbfee39cf2cdaa8a6/components/plugins/lints/sorter.rs#L87)):</sup>\n&Vec should be &[..]\n\n\nAlso, `T: Deref<Target=String>` should be enough, reallyx\n\n---\n\n<sup>**[components/plugins/lints/sorter.rs, line 93 \\[r2\\]](https://reviewable.io:443/reviews/servo/servo/7546#-JzD2VaXx45B0yE8H26B)** ([raw file](https://github.com/servo/servo/blob/f4f19e8af8442fc916760320991888e91cdf97e0/components/plugins/lints/sorter.rs#L93)):</sup>\nError message should be better.\n\nSomething like\n\n{} should be in alphabetical order\\n\\texpected: {}\\n\\tfound: {}\n\nwhere the first {} is either \"use statements\", \"module declarations\", or \"crate declarations\"\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/servo/servo/7546)\n<!-- Sent from Reviewable.io -->\n"}}