{"action":"created","issue":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/230","labels_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/230/labels{/name}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/230/comments","events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/230/events","html_url":"https://github.com/aws/amazon-ecs-agent/pull/230","id":112696985,"number":230,"title":"Engine: Refactor auth code","user":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-21T23:07:46Z","updated_at":"2015-10-22T21:09:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/230","html_url":"https://github.com/aws/amazon-ecs-agent/pull/230","diff_url":"https://github.com/aws/amazon-ecs-agent/pull/230.diff","patch_url":"https://github.com/aws/amazon-ecs-agent/pull/230.patch"},"body":"This is intended to resolve two problems:\r\n1. Remove the dependency of 'glog' which is instantiated and wastes memory because it is not used\r\n2. Resolve the issue disucssed in #215\r\n\r\nThis change accomplishes both of those goals by essentially doing a refactor with an identical external configuration and similar internal API.\r\n\r\nThis also introduces more detailed tests that hopefully cover #215\r\n\r\nThis implementation has 100% code coverage currently from the unit tests.\r\nI've manually tested that it works as I expect for all combinations of one Dockerhub private account and one other private registry account.\r\n\r\nr? @samuelkarp "},"comment":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/comments/150357101","html_url":"https://github.com/aws/amazon-ecs-agent/pull/230#issuecomment-150357101","issue_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/230","id":150357101,"user":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"created_at":"2015-10-22T21:09:32Z","updated_at":"2015-10-22T21:09:32Z","body":"@samuelkarp per offline discussion, I did some minor refactoring to make the code a bit cleaner at the expense of an extra map in memory.\r\nI had some test-failures that were unrelated to this; the auth-related tests all passed."}}