{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/DoSomething/laravel-user-api/pulls/18","id":28149754,"html_url":"https://github.com/DoSomething/laravel-user-api/pull/18","diff_url":"https://github.com/DoSomething/laravel-user-api/pull/18.diff","patch_url":"https://github.com/DoSomething/laravel-user-api/pull/18.patch","issue_url":"https://api.github.com/repos/DoSomething/laravel-user-api/issues/18","number":18,"state":"closed","locked":false,"title":"Don't use user email and phone in username generation.","user":{"login":"sergii-tkachenko","id":672669,"avatar_url":"https://avatars.githubusercontent.com/u/672669?v=3","gravatar_id":"","url":"https://api.github.com/users/sergii-tkachenko","html_url":"https://github.com/sergii-tkachenko","followers_url":"https://api.github.com/users/sergii-tkachenko/followers","following_url":"https://api.github.com/users/sergii-tkachenko/following{/other_user}","gists_url":"https://api.github.com/users/sergii-tkachenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergii-tkachenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergii-tkachenko/subscriptions","organizations_url":"https://api.github.com/users/sergii-tkachenko/orgs","repos_url":"https://api.github.com/users/sergii-tkachenko/repos","events_url":"https://api.github.com/users/sergii-tkachenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergii-tkachenko/received_events","type":"User","site_admin":false},"body":"#### What's this PR do?\r\n- Removes user email address and phone number from `makeUsername()` helper in order to protect sensetive user data from being exposed to the public through profile URL\r\n\r\n#### Testing\r\nChanges consistent with DS Canada:\r\n![image](https://cloud.githubusercontent.com/assets/672669/5928318/4b30e2d6-a648-11e4-8611-d7b2809c65cc.png)\r\n\r\nCC @mshmsh5000 @mfurdyk \r\n","created_at":"2015-01-27T22:17:31Z","updated_at":"2015-01-29T15:42:20Z","closed_at":"2015-01-29T15:42:20Z","merged_at":"2015-01-29T15:42:20Z","merge_commit_sha":"c489b37a1bf86be44cfd39950886b1e8ab61fc0d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/laravel-user-api/pulls/18/commits","review_comments_url":"https://api.github.com/repos/DoSomething/laravel-user-api/pulls/18/comments","review_comment_url":"https://api.github.com/repos/DoSomething/laravel-user-api/pulls/comments/{number}","comments_url":"https://api.github.com/repos/DoSomething/laravel-user-api/issues/18/comments","statuses_url":"https://api.github.com/repos/DoSomething/laravel-user-api/statuses/350165a544db586300771ed2e69068dc4dee984c","head":{"label":"sergii-tkachenko:remove-email-phone-from-username","ref":"remove-email-phone-from-username","sha":"350165a544db586300771ed2e69068dc4dee984c","user":{"login":"sergii-tkachenko","id":672669,"avatar_url":"https://avatars.githubusercontent.com/u/672669?v=3","gravatar_id":"","url":"https://api.github.com/users/sergii-tkachenko","html_url":"https://github.com/sergii-tkachenko","followers_url":"https://api.github.com/users/sergii-tkachenko/followers","following_url":"https://api.github.com/users/sergii-tkachenko/following{/other_user}","gists_url":"https://api.github.com/users/sergii-tkachenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergii-tkachenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergii-tkachenko/subscriptions","organizations_url":"https://api.github.com/users/sergii-tkachenko/orgs","repos_url":"https://api.github.com/users/sergii-tkachenko/repos","events_url":"https://api.github.com/users/sergii-tkachenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergii-tkachenko/received_events","type":"User","site_admin":false},"repo":{"id":23478674,"name":"laravel-user-api","full_name":"sergii-tkachenko/laravel-user-api","owner":{"login":"sergii-tkachenko","id":672669,"avatar_url":"https://avatars.githubusercontent.com/u/672669?v=3","gravatar_id":"","url":"https://api.github.com/users/sergii-tkachenko","html_url":"https://github.com/sergii-tkachenko","followers_url":"https://api.github.com/users/sergii-tkachenko/followers","following_url":"https://api.github.com/users/sergii-tkachenko/following{/other_user}","gists_url":"https://api.github.com/users/sergii-tkachenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sergii-tkachenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergii-tkachenko/subscriptions","organizations_url":"https://api.github.com/users/sergii-tkachenko/orgs","repos_url":"https://api.github.com/users/sergii-tkachenko/repos","events_url":"https://api.github.com/users/sergii-tkachenko/events{/privacy}","received_events_url":"https://api.github.com/users/sergii-tkachenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sergii-tkachenko/laravel-user-api","description":"A generic, RESTful API built in Laravel and based on the Parse user API.","fork":true,"url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api","forks_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/forks","keys_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/teams","hooks_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/hooks","issue_events_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/issues/events{/number}","events_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/events","assignees_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/assignees{/user}","branches_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/branches{/branch}","tags_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/tags","blobs_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/statuses/{sha}","languages_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/languages","stargazers_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/stargazers","contributors_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/contributors","subscribers_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/subscribers","subscription_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/subscription","commits_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/issues/comments/{number}","contents_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/contents/{+path}","compare_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/merges","archive_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/downloads","issues_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/issues{/number}","pulls_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/pulls{/number}","milestones_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/milestones{/number}","notifications_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/labels{/name}","releases_url":"https://api.github.com/repos/sergii-tkachenko/laravel-user-api/releases{/id}","created_at":"2014-08-29T21:44:18Z","updated_at":"2015-01-27T19:44:01Z","pushed_at":"2015-01-27T22:11:59Z","git_url":"git://github.com/sergii-tkachenko/laravel-user-api.git","ssh_url":"git@github.com:sergii-tkachenko/laravel-user-api.git","clone_url":"https://github.com/sergii-tkachenko/laravel-user-api.git","svn_url":"https://github.com/sergii-tkachenko/laravel-user-api","homepage":null,"size":251,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DoSomething:master","ref":"master","sha":"3206b1edb2839e777f518e285fdde08eb716b569","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":23473514,"name":"laravel-user-api","full_name":"DoSomething/laravel-user-api","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/laravel-user-api","description":"A generic, RESTful API built in Laravel and based on the Parse user API.","fork":false,"url":"https://api.github.com/repos/DoSomething/laravel-user-api","forks_url":"https://api.github.com/repos/DoSomething/laravel-user-api/forks","keys_url":"https://api.github.com/repos/DoSomething/laravel-user-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/laravel-user-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/laravel-user-api/teams","hooks_url":"https://api.github.com/repos/DoSomething/laravel-user-api/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/laravel-user-api/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/laravel-user-api/events","assignees_url":"https://api.github.com/repos/DoSomething/laravel-user-api/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/laravel-user-api/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/laravel-user-api/tags","blobs_url":"https://api.github.com/repos/DoSomething/laravel-user-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/laravel-user-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/laravel-user-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/laravel-user-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/laravel-user-api/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/laravel-user-api/languages","stargazers_url":"https://api.github.com/repos/DoSomething/laravel-user-api/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/laravel-user-api/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/laravel-user-api/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/laravel-user-api/subscription","commits_url":"https://api.github.com/repos/DoSomething/laravel-user-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/laravel-user-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/laravel-user-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/laravel-user-api/issues/comments/{number}","contents_url":"https://api.github.com/repos/DoSomething/laravel-user-api/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/laravel-user-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/laravel-user-api/merges","archive_url":"https://api.github.com/repos/DoSomething/laravel-user-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/laravel-user-api/downloads","issues_url":"https://api.github.com/repos/DoSomething/laravel-user-api/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/laravel-user-api/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/laravel-user-api/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/laravel-user-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/laravel-user-api/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/laravel-user-api/releases{/id}","created_at":"2014-08-29T18:25:32Z","updated_at":"2015-01-29T15:42:21Z","pushed_at":"2015-01-29T15:42:21Z","git_url":"git://github.com/DoSomething/laravel-user-api.git","ssh_url":"git@github.com:DoSomething/laravel-user-api.git","clone_url":"https://github.com/DoSomething/laravel-user-api.git","svn_url":"https://github.com/DoSomething/laravel-user-api","homepage":null,"size":290,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/laravel-user-api/pulls/18"},"html":{"href":"https://github.com/DoSomething/laravel-user-api/pull/18"},"issue":{"href":"https://api.github.com/repos/DoSomething/laravel-user-api/issues/18"},"comments":{"href":"https://api.github.com/repos/DoSomething/laravel-user-api/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/laravel-user-api/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/laravel-user-api/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/laravel-user-api/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/laravel-user-api/statuses/350165a544db586300771ed2e69068dc4dee984c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mfurdyk","id":244123,"avatar_url":"https://avatars.githubusercontent.com/u/244123?v=3","gravatar_id":"","url":"https://api.github.com/users/mfurdyk","html_url":"https://github.com/mfurdyk","followers_url":"https://api.github.com/users/mfurdyk/followers","following_url":"https://api.github.com/users/mfurdyk/following{/other_user}","gists_url":"https://api.github.com/users/mfurdyk/gists{/gist_id}","starred_url":"https://api.github.com/users/mfurdyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfurdyk/subscriptions","organizations_url":"https://api.github.com/users/mfurdyk/orgs","repos_url":"https://api.github.com/users/mfurdyk/repos","events_url":"https://api.github.com/users/mfurdyk/events{/privacy}","received_events_url":"https://api.github.com/users/mfurdyk/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":14,"changed_files":2}}