{"action":"created","comment":{"url":"https://api.github.com/repos/hylang/hy/pulls/comments/33409564","id":33409564,"diff_hunk":"@@ -1718,11 +1716,13 @@ def compile_maths_expression(self, expression):\n \n     @builds(\"+\")\n     @builds(\"*\")\n+    @builds(\"/\")\n+    @builds(\"//\")\n     def compile_maths_expression_mul(self, expression):\n         if len(expression) > 2:\n             return self.compile_maths_expression(expression)\n         else:\n-            id_op = {\"+\": HyInteger(0), \"*\": HyInteger(1)}\n+            id_op = {\"+\": HyInteger(0), \"*\": HyInteger(1), \"/\": HyInteger(1)}","path":"hy/compiler.py","position":20,"original_position":20,"commit_id":"8396021f8c9d03d3f001c44a165c4606e3344374","original_commit_id":"8396021f8c9d03d3f001c44a165c4606e3344374","user":{"login":"zackmdavis","id":1076988,"avatar_url":"https://avatars.githubusercontent.com/u/1076988?v=3","gravatar_id":"","url":"https://api.github.com/users/zackmdavis","html_url":"https://github.com/zackmdavis","followers_url":"https://api.github.com/users/zackmdavis/followers","following_url":"https://api.github.com/users/zackmdavis/following{/other_user}","gists_url":"https://api.github.com/users/zackmdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/zackmdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zackmdavis/subscriptions","organizations_url":"https://api.github.com/users/zackmdavis/orgs","repos_url":"https://api.github.com/users/zackmdavis/repos","events_url":"https://api.github.com/users/zackmdavis/events{/privacy}","received_events_url":"https://api.github.com/users/zackmdavis/received_events","type":"User","site_admin":false},"body":"Floor division needs its identity, too&mdash;\r\n```\r\n=> (// 2)\r\nTraceback (most recent call last):\r\n  File \"/home/zmd/Code/hy/hy/hy/compiler.py\", line 2315, in hy_compile\r\n    result = compiler.compile(tree)\r\n  File \"/home/zmd/Code/hy/hy/hy/compiler.py\", line 428, in compile\r\n    ret = self.compile_atom(_type, tree)\r\n  File \"/home/zmd/Code/hy/hy/hy/compiler.py\", line 420, in compile_atom\r\n    ret = _compile_table[atom_type](self, atom)\r\n  File \"/home/zmd/Code/hy/hy/hy/compiler.py\", line 596, in compile_raw_list\r\n    ret = self._compile_branch(entries)\r\n  File \"/home/zmd/Code/hy/hy/hy/compiler.py\", line 483, in _compile_branch\r\n    return _branch(self.compile(expr) for expr in exprs)\r\n  File \"/home/zmd/Code/hy/hy/hy/compiler.py\", line 313, in _branch\r\n    results = list(results)\r\n  File \"/home/zmd/Code/hy/hy/hy/compiler.py\", line 483, in <genexpr>\r\n    return _branch(self.compile(expr) for expr in exprs)\r\n  File \"/home/zmd/Code/hy/hy/hy/compiler.py\", line 440, in compile\r\n    raise_empty(HyCompileError, e, sys.exc_info()[2])\r\n  File \"<string>\", line 1, in raise_empty\r\nhy.errors.HyCompileError: Internal Compiler Bug 😱\r\n⤷ KeyError: '//'\r\nCompilation traceback:\r\nFile \"/home/zmd/Code/hy/hy/hy/compiler.py\", line 428, in compile\r\n    ret = self.compile_atom(_type, tree)\r\n  File \"/home/zmd/Code/hy/hy/hy/compiler.py\", line 420, in compile_atom\r\n    ret = _compile_table[atom_type](self, atom)\r\n  File \"/home/zmd/Code/hy/hy/hy/compiler.py\", line 1817, in compile_expression\r\n    ret = self.compile_atom(fn, expression)\r\n  File \"/home/zmd/Code/hy/hy/hy/compiler.py\", line 420, in compile_atom\r\n    ret = _compile_table[atom_type](self, atom)\r\n  File \"/home/zmd/Code/hy/hy/hy/compiler.py\", line 1733, in compile_maths_expression_mul\r\n    ]).replace(expression)\r\n```","created_at":"2015-06-27T04:35:16Z","updated_at":"2015-06-27T04:35:16Z","html_url":"https://github.com/hylang/hy/pull/828#discussion_r33409564","pull_request_url":"https://api.github.com/repos/hylang/hy/pulls/828","_links":{"self":{"href":"https://api.github.com/repos/hylang/hy/pulls/comments/33409564"},"html":{"href":"https://github.com/hylang/hy/pull/828#discussion_r33409564"},"pull_request":{"href":"https://api.github.com/repos/hylang/hy/pulls/828"}}},"pull_request":{"url":"https://api.github.com/repos/hylang/hy/pulls/828","id":38689828,"html_url":"https://github.com/hylang/hy/pull/828","diff_url":"https://github.com/hylang/hy/pull/828.diff","patch_url":"https://github.com/hylang/hy/pull/828.patch","issue_url":"https://api.github.com/repos/hylang/hy/issues/828","number":828,"state":"open","locked":false,"title":"Add one-argument division and rationals","user":{"login":"kirbyfan64","id":1690697,"avatar_url":"https://avatars.githubusercontent.com/u/1690697?v=3","gravatar_id":"","url":"https://api.github.com/users/kirbyfan64","html_url":"https://github.com/kirbyfan64","followers_url":"https://api.github.com/users/kirbyfan64/followers","following_url":"https://api.github.com/users/kirbyfan64/following{/other_user}","gists_url":"https://api.github.com/users/kirbyfan64/gists{/gist_id}","starred_url":"https://api.github.com/users/kirbyfan64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirbyfan64/subscriptions","organizations_url":"https://api.github.com/users/kirbyfan64/orgs","repos_url":"https://api.github.com/users/kirbyfan64/repos","events_url":"https://api.github.com/users/kirbyfan64/events{/privacy}","received_events_url":"https://api.github.com/users/kirbyfan64/received_events","type":"User","site_admin":false},"body":"Ref. #825 and #826.\r\n","created_at":"2015-06-26T21:11:21Z","updated_at":"2015-06-27T04:35:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2eb98da4bae10eeb0fad22ea024434aef3efa93f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hylang/hy/pulls/828/commits","review_comments_url":"https://api.github.com/repos/hylang/hy/pulls/828/comments","review_comment_url":"https://api.github.com/repos/hylang/hy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hylang/hy/issues/828/comments","statuses_url":"https://api.github.com/repos/hylang/hy/statuses/8396021f8c9d03d3f001c44a165c4606e3344374","head":{"label":"kirbyfan64:div","ref":"div","sha":"8396021f8c9d03d3f001c44a165c4606e3344374","user":{"login":"kirbyfan64","id":1690697,"avatar_url":"https://avatars.githubusercontent.com/u/1690697?v=3","gravatar_id":"","url":"https://api.github.com/users/kirbyfan64","html_url":"https://github.com/kirbyfan64","followers_url":"https://api.github.com/users/kirbyfan64/followers","following_url":"https://api.github.com/users/kirbyfan64/following{/other_user}","gists_url":"https://api.github.com/users/kirbyfan64/gists{/gist_id}","starred_url":"https://api.github.com/users/kirbyfan64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirbyfan64/subscriptions","organizations_url":"https://api.github.com/users/kirbyfan64/orgs","repos_url":"https://api.github.com/users/kirbyfan64/repos","events_url":"https://api.github.com/users/kirbyfan64/events{/privacy}","received_events_url":"https://api.github.com/users/kirbyfan64/received_events","type":"User","site_admin":false},"repo":{"id":26061590,"name":"hy","full_name":"kirbyfan64/hy","owner":{"login":"kirbyfan64","id":1690697,"avatar_url":"https://avatars.githubusercontent.com/u/1690697?v=3","gravatar_id":"","url":"https://api.github.com/users/kirbyfan64","html_url":"https://github.com/kirbyfan64","followers_url":"https://api.github.com/users/kirbyfan64/followers","following_url":"https://api.github.com/users/kirbyfan64/following{/other_user}","gists_url":"https://api.github.com/users/kirbyfan64/gists{/gist_id}","starred_url":"https://api.github.com/users/kirbyfan64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirbyfan64/subscriptions","organizations_url":"https://api.github.com/users/kirbyfan64/orgs","repos_url":"https://api.github.com/users/kirbyfan64/repos","events_url":"https://api.github.com/users/kirbyfan64/events{/privacy}","received_events_url":"https://api.github.com/users/kirbyfan64/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kirbyfan64/hy","description":"ὑμήνπτερόν","fork":true,"url":"https://api.github.com/repos/kirbyfan64/hy","forks_url":"https://api.github.com/repos/kirbyfan64/hy/forks","keys_url":"https://api.github.com/repos/kirbyfan64/hy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kirbyfan64/hy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kirbyfan64/hy/teams","hooks_url":"https://api.github.com/repos/kirbyfan64/hy/hooks","issue_events_url":"https://api.github.com/repos/kirbyfan64/hy/issues/events{/number}","events_url":"https://api.github.com/repos/kirbyfan64/hy/events","assignees_url":"https://api.github.com/repos/kirbyfan64/hy/assignees{/user}","branches_url":"https://api.github.com/repos/kirbyfan64/hy/branches{/branch}","tags_url":"https://api.github.com/repos/kirbyfan64/hy/tags","blobs_url":"https://api.github.com/repos/kirbyfan64/hy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kirbyfan64/hy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kirbyfan64/hy/git/refs{/sha}","trees_url":"https://api.github.com/repos/kirbyfan64/hy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kirbyfan64/hy/statuses/{sha}","languages_url":"https://api.github.com/repos/kirbyfan64/hy/languages","stargazers_url":"https://api.github.com/repos/kirbyfan64/hy/stargazers","contributors_url":"https://api.github.com/repos/kirbyfan64/hy/contributors","subscribers_url":"https://api.github.com/repos/kirbyfan64/hy/subscribers","subscription_url":"https://api.github.com/repos/kirbyfan64/hy/subscription","commits_url":"https://api.github.com/repos/kirbyfan64/hy/commits{/sha}","git_commits_url":"https://api.github.com/repos/kirbyfan64/hy/git/commits{/sha}","comments_url":"https://api.github.com/repos/kirbyfan64/hy/comments{/number}","issue_comment_url":"https://api.github.com/repos/kirbyfan64/hy/issues/comments{/number}","contents_url":"https://api.github.com/repos/kirbyfan64/hy/contents/{+path}","compare_url":"https://api.github.com/repos/kirbyfan64/hy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kirbyfan64/hy/merges","archive_url":"https://api.github.com/repos/kirbyfan64/hy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kirbyfan64/hy/downloads","issues_url":"https://api.github.com/repos/kirbyfan64/hy/issues{/number}","pulls_url":"https://api.github.com/repos/kirbyfan64/hy/pulls{/number}","milestones_url":"https://api.github.com/repos/kirbyfan64/hy/milestones{/number}","notifications_url":"https://api.github.com/repos/kirbyfan64/hy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kirbyfan64/hy/labels{/name}","releases_url":"https://api.github.com/repos/kirbyfan64/hy/releases{/id}","created_at":"2014-11-01T19:58:20Z","updated_at":"2014-11-01T20:00:45Z","pushed_at":"2015-06-26T22:53:35Z","git_url":"git://github.com/kirbyfan64/hy.git","ssh_url":"git@github.com:kirbyfan64/hy.git","clone_url":"https://github.com/kirbyfan64/hy.git","svn_url":"https://github.com/kirbyfan64/hy","homepage":"http://hylang.org/","size":3129,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hylang:master","ref":"master","sha":"920c8017337bb4999aba2589f7c10a3920793242","user":{"login":"hylang","id":4141508,"avatar_url":"https://avatars.githubusercontent.com/u/4141508?v=3","gravatar_id":"","url":"https://api.github.com/users/hylang","html_url":"https://github.com/hylang","followers_url":"https://api.github.com/users/hylang/followers","following_url":"https://api.github.com/users/hylang/following{/other_user}","gists_url":"https://api.github.com/users/hylang/gists{/gist_id}","starred_url":"https://api.github.com/users/hylang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hylang/subscriptions","organizations_url":"https://api.github.com/users/hylang/orgs","repos_url":"https://api.github.com/users/hylang/repos","events_url":"https://api.github.com/users/hylang/events{/privacy}","received_events_url":"https://api.github.com/users/hylang/received_events","type":"Organization","site_admin":false},"repo":{"id":7184072,"name":"hy","full_name":"hylang/hy","owner":{"login":"hylang","id":4141508,"avatar_url":"https://avatars.githubusercontent.com/u/4141508?v=3","gravatar_id":"","url":"https://api.github.com/users/hylang","html_url":"https://github.com/hylang","followers_url":"https://api.github.com/users/hylang/followers","following_url":"https://api.github.com/users/hylang/following{/other_user}","gists_url":"https://api.github.com/users/hylang/gists{/gist_id}","starred_url":"https://api.github.com/users/hylang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hylang/subscriptions","organizations_url":"https://api.github.com/users/hylang/orgs","repos_url":"https://api.github.com/users/hylang/repos","events_url":"https://api.github.com/users/hylang/events{/privacy}","received_events_url":"https://api.github.com/users/hylang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hylang/hy","description":"ὑμήνπτερόν","fork":false,"url":"https://api.github.com/repos/hylang/hy","forks_url":"https://api.github.com/repos/hylang/hy/forks","keys_url":"https://api.github.com/repos/hylang/hy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hylang/hy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hylang/hy/teams","hooks_url":"https://api.github.com/repos/hylang/hy/hooks","issue_events_url":"https://api.github.com/repos/hylang/hy/issues/events{/number}","events_url":"https://api.github.com/repos/hylang/hy/events","assignees_url":"https://api.github.com/repos/hylang/hy/assignees{/user}","branches_url":"https://api.github.com/repos/hylang/hy/branches{/branch}","tags_url":"https://api.github.com/repos/hylang/hy/tags","blobs_url":"https://api.github.com/repos/hylang/hy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hylang/hy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hylang/hy/git/refs{/sha}","trees_url":"https://api.github.com/repos/hylang/hy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hylang/hy/statuses/{sha}","languages_url":"https://api.github.com/repos/hylang/hy/languages","stargazers_url":"https://api.github.com/repos/hylang/hy/stargazers","contributors_url":"https://api.github.com/repos/hylang/hy/contributors","subscribers_url":"https://api.github.com/repos/hylang/hy/subscribers","subscription_url":"https://api.github.com/repos/hylang/hy/subscription","commits_url":"https://api.github.com/repos/hylang/hy/commits{/sha}","git_commits_url":"https://api.github.com/repos/hylang/hy/git/commits{/sha}","comments_url":"https://api.github.com/repos/hylang/hy/comments{/number}","issue_comment_url":"https://api.github.com/repos/hylang/hy/issues/comments{/number}","contents_url":"https://api.github.com/repos/hylang/hy/contents/{+path}","compare_url":"https://api.github.com/repos/hylang/hy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hylang/hy/merges","archive_url":"https://api.github.com/repos/hylang/hy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hylang/hy/downloads","issues_url":"https://api.github.com/repos/hylang/hy/issues{/number}","pulls_url":"https://api.github.com/repos/hylang/hy/pulls{/number}","milestones_url":"https://api.github.com/repos/hylang/hy/milestones{/number}","notifications_url":"https://api.github.com/repos/hylang/hy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hylang/hy/labels{/name}","releases_url":"https://api.github.com/repos/hylang/hy/releases{/id}","created_at":"2012-12-15T21:20:51Z","updated_at":"2015-06-27T01:32:20Z","pushed_at":"2015-06-26T22:53:35Z","git_url":"git://github.com/hylang/hy.git","ssh_url":"git@github.com:hylang/hy.git","clone_url":"https://github.com/hylang/hy.git","svn_url":"https://github.com/hylang/hy","homepage":"http://hylang.org/","size":8031,"stargazers_count":1083,"watchers_count":1083,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"open_issues_count":159,"forks":143,"open_issues":159,"watchers":1083,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hylang/hy/pulls/828"},"html":{"href":"https://github.com/hylang/hy/pull/828"},"issue":{"href":"https://api.github.com/repos/hylang/hy/issues/828"},"comments":{"href":"https://api.github.com/repos/hylang/hy/issues/828/comments"},"review_comments":{"href":"https://api.github.com/repos/hylang/hy/pulls/828/comments"},"review_comment":{"href":"https://api.github.com/repos/hylang/hy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hylang/hy/pulls/828/commits"},"statuses":{"href":"https://api.github.com/repos/hylang/hy/statuses/8396021f8c9d03d3f001c44a165c4606e3344374"}}}}