{"action":"created","comment":{"url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/comments/35345030","id":35345030,"diff_hunk":"@@ -91,22 +91,25 @@ describe 'LongForm HomeEquity', ->\n         assert.equal unified.request(req(xml())).mortgage.property.purchase_year, 1998\n \n     describe 'Loan', ->\n-      it 'should describe loan term', ->\n+      it 'should parse loan term', ->\n         assert.equal unified.request(req(xml())).mortgage.loan.term, null\n \n-      it 'should describe loan amount', ->\n+      it 'should parse loan amount', ->\n         assert.equal unified.request(req(xml())).mortgage.loan.amount, 3250000\n \n-      it 'should describe loan down payment', ->\n+      it 'should parse loan amount when range', ->\n+        assert.equal unified.request(req(xml(LoanAmount:'8000-9000'))).mortgage.loan.amount, '8000-9000'\n+\n+      it 'should parse loan down payment', ->\n         assert.equal unified.request(req(xml())).mortgage.loan.down_payment, 50000\n \n-      it 'should describe loan cash out', ->\n+      it 'should parse loan cash out', ->\n         assert.equal unified.request(req(xml())).mortgage.loan.cash_out, null\n \n-      it 'should describe loan purpose', ->\n+      it 'should parse loan purpose', ->\n         assert.equal unified.request(req(xml())).mortgage.loan.purpose, 'equity'\n \n-      xit 'should describe loan ltv', ->\n+      xit 'should parse loan ltv', ->","path":"spec/unified_long_homeequity.coffee","position":28,"original_position":28,"commit_id":"edaf679860d5de2a53230c8958346003251bee2a","original_commit_id":"edaf679860d5de2a53230c8958346003251bee2a","user":{"login":"cgrayson","id":5596,"avatar_url":"https://avatars.githubusercontent.com/u/5596?v=3","gravatar_id":"","url":"https://api.github.com/users/cgrayson","html_url":"https://github.com/cgrayson","followers_url":"https://api.github.com/users/cgrayson/followers","following_url":"https://api.github.com/users/cgrayson/following{/other_user}","gists_url":"https://api.github.com/users/cgrayson/gists{/gist_id}","starred_url":"https://api.github.com/users/cgrayson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgrayson/subscriptions","organizations_url":"https://api.github.com/users/cgrayson/orgs","repos_url":"https://api.github.com/users/cgrayson/repos","events_url":"https://api.github.com/users/cgrayson/events{/privacy}","received_events_url":"https://api.github.com/users/cgrayson/received_events","type":"User","site_admin":false},"body":"Appreciate the consistency :smiley:, but maybe take this opportunity to either delete or unpause `xit`ed tests.","created_at":"2015-07-23T17:03:40Z","updated_at":"2015-07-23T17:03:40Z","html_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree/pull/27#discussion_r35345030","pull_request_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/comments/35345030"},"html":{"href":"https://github.com/activeprospect/leadconduit-integration-lendingtree/pull/27#discussion_r35345030"},"pull_request":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/27","id":40618453,"html_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree/pull/27","diff_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree/pull/27.diff","patch_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree/pull/27.patch","issue_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues/27","number":27,"state":"open","locked":false,"title":"remove parseInt, update test, add range test, update type","user":{"login":"ros3bud","id":3402403,"avatar_url":"https://avatars.githubusercontent.com/u/3402403?v=3","gravatar_id":"","url":"https://api.github.com/users/ros3bud","html_url":"https://github.com/ros3bud","followers_url":"https://api.github.com/users/ros3bud/followers","following_url":"https://api.github.com/users/ros3bud/following{/other_user}","gists_url":"https://api.github.com/users/ros3bud/gists{/gist_id}","starred_url":"https://api.github.com/users/ros3bud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros3bud/subscriptions","organizations_url":"https://api.github.com/users/ros3bud/orgs","repos_url":"https://api.github.com/users/ros3bud/repos","events_url":"https://api.github.com/users/ros3bud/events{/privacy}","received_events_url":"https://api.github.com/users/ros3bud/received_events","type":"User","site_admin":false},"body":"- added tests for mortgage.loan.amount to accept range\r\n- updated mortgage.loan.amount type to range for each form\r\n- removed methods parse.integer, parse.float \r\n- removed occurrences of parseInt and parseFloat \r\n- made text edits for consistency throughout tests\r\n\r\n","created_at":"2015-07-22T22:19:32Z","updated_at":"2015-07-23T17:03:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2c969c6b50b7d19f9a2a90b5a2ac9ba604e92fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/27/commits","review_comments_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/27/comments","review_comment_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues/27/comments","statuses_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/statuses/edaf679860d5de2a53230c8958346003251bee2a","head":{"label":"activeprospect:update-loan-amount-lw","ref":"update-loan-amount-lw","sha":"edaf679860d5de2a53230c8958346003251bee2a","user":{"login":"activeprospect","id":245554,"avatar_url":"https://avatars.githubusercontent.com/u/245554?v=3","gravatar_id":"","url":"https://api.github.com/users/activeprospect","html_url":"https://github.com/activeprospect","followers_url":"https://api.github.com/users/activeprospect/followers","following_url":"https://api.github.com/users/activeprospect/following{/other_user}","gists_url":"https://api.github.com/users/activeprospect/gists{/gist_id}","starred_url":"https://api.github.com/users/activeprospect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeprospect/subscriptions","organizations_url":"https://api.github.com/users/activeprospect/orgs","repos_url":"https://api.github.com/users/activeprospect/repos","events_url":"https://api.github.com/users/activeprospect/events{/privacy}","received_events_url":"https://api.github.com/users/activeprospect/received_events","type":"Organization","site_admin":false},"repo":{"id":17524991,"name":"leadconduit-integration-lendingtree","full_name":"activeprospect/leadconduit-integration-lendingtree","owner":{"login":"activeprospect","id":245554,"avatar_url":"https://avatars.githubusercontent.com/u/245554?v=3","gravatar_id":"","url":"https://api.github.com/users/activeprospect","html_url":"https://github.com/activeprospect","followers_url":"https://api.github.com/users/activeprospect/followers","following_url":"https://api.github.com/users/activeprospect/following{/other_user}","gists_url":"https://api.github.com/users/activeprospect/gists{/gist_id}","starred_url":"https://api.github.com/users/activeprospect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeprospect/subscriptions","organizations_url":"https://api.github.com/users/activeprospect/orgs","repos_url":"https://api.github.com/users/activeprospect/repos","events_url":"https://api.github.com/users/activeprospect/events{/privacy}","received_events_url":"https://api.github.com/users/activeprospect/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree","description":"LeadConduit Integration with LendingTree","fork":false,"url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree","forks_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/forks","keys_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/teams","hooks_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/hooks","issue_events_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues/events{/number}","events_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/events","assignees_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/assignees{/user}","branches_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/branches{/branch}","tags_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/tags","blobs_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/refs{/sha}","trees_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/statuses/{sha}","languages_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/languages","stargazers_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/stargazers","contributors_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/contributors","subscribers_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/subscribers","subscription_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/subscription","commits_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/commits{/sha}","git_commits_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/commits{/sha}","comments_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/comments{/number}","issue_comment_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues/comments{/number}","contents_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/contents/{+path}","compare_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/merges","archive_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/downloads","issues_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues{/number}","pulls_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls{/number}","milestones_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/milestones{/number}","notifications_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/labels{/name}","releases_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/releases{/id}","created_at":"2014-03-07T19:35:30Z","updated_at":"2015-04-27T21:33:29Z","pushed_at":"2015-07-23T15:57:59Z","git_url":"git://github.com/activeprospect/leadconduit-integration-lendingtree.git","ssh_url":"git@github.com:activeprospect/leadconduit-integration-lendingtree.git","clone_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree.git","svn_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree","homepage":null,"size":636,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"activeprospect:master","ref":"master","sha":"184d85349d5115c4b31a547fd460122a7840312d","user":{"login":"activeprospect","id":245554,"avatar_url":"https://avatars.githubusercontent.com/u/245554?v=3","gravatar_id":"","url":"https://api.github.com/users/activeprospect","html_url":"https://github.com/activeprospect","followers_url":"https://api.github.com/users/activeprospect/followers","following_url":"https://api.github.com/users/activeprospect/following{/other_user}","gists_url":"https://api.github.com/users/activeprospect/gists{/gist_id}","starred_url":"https://api.github.com/users/activeprospect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeprospect/subscriptions","organizations_url":"https://api.github.com/users/activeprospect/orgs","repos_url":"https://api.github.com/users/activeprospect/repos","events_url":"https://api.github.com/users/activeprospect/events{/privacy}","received_events_url":"https://api.github.com/users/activeprospect/received_events","type":"Organization","site_admin":false},"repo":{"id":17524991,"name":"leadconduit-integration-lendingtree","full_name":"activeprospect/leadconduit-integration-lendingtree","owner":{"login":"activeprospect","id":245554,"avatar_url":"https://avatars.githubusercontent.com/u/245554?v=3","gravatar_id":"","url":"https://api.github.com/users/activeprospect","html_url":"https://github.com/activeprospect","followers_url":"https://api.github.com/users/activeprospect/followers","following_url":"https://api.github.com/users/activeprospect/following{/other_user}","gists_url":"https://api.github.com/users/activeprospect/gists{/gist_id}","starred_url":"https://api.github.com/users/activeprospect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeprospect/subscriptions","organizations_url":"https://api.github.com/users/activeprospect/orgs","repos_url":"https://api.github.com/users/activeprospect/repos","events_url":"https://api.github.com/users/activeprospect/events{/privacy}","received_events_url":"https://api.github.com/users/activeprospect/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree","description":"LeadConduit Integration with LendingTree","fork":false,"url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree","forks_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/forks","keys_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/teams","hooks_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/hooks","issue_events_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues/events{/number}","events_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/events","assignees_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/assignees{/user}","branches_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/branches{/branch}","tags_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/tags","blobs_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/refs{/sha}","trees_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/statuses/{sha}","languages_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/languages","stargazers_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/stargazers","contributors_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/contributors","subscribers_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/subscribers","subscription_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/subscription","commits_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/commits{/sha}","git_commits_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/git/commits{/sha}","comments_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/comments{/number}","issue_comment_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues/comments{/number}","contents_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/contents/{+path}","compare_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/merges","archive_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/downloads","issues_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues{/number}","pulls_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls{/number}","milestones_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/milestones{/number}","notifications_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/labels{/name}","releases_url":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/releases{/id}","created_at":"2014-03-07T19:35:30Z","updated_at":"2015-04-27T21:33:29Z","pushed_at":"2015-07-23T15:57:59Z","git_url":"git://github.com/activeprospect/leadconduit-integration-lendingtree.git","ssh_url":"git@github.com:activeprospect/leadconduit-integration-lendingtree.git","clone_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree.git","svn_url":"https://github.com/activeprospect/leadconduit-integration-lendingtree","homepage":null,"size":636,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/27"},"html":{"href":"https://github.com/activeprospect/leadconduit-integration-lendingtree/pull/27"},"issue":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues/27"},"comments":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/activeprospect/leadconduit-integration-lendingtree/statuses/edaf679860d5de2a53230c8958346003251bee2a"}}}}