{"action":"created","comment":{"url":"https://api.github.com/repos/piwik/piwik/pulls/comments/31881952","id":31881952,"diff_hunk":"@@ -0,0 +1,7 @@\n+{\n+  \"MobileAppType\": {\n+    \"MobileApp\": \"Mobile App\",\n+    \"MobileApps\": \"Mobile Apps\",\n+    \"MobileAppDescription\": \"A native mobile app for eg iOS, Android, ..\"","path":"plugins/MobileAppType/lang/en.json","position":5,"original_position":5,"commit_id":"b5aec8c824c644f824d047e052360ac891f49bc4","original_commit_id":"9c48b9a5798e6427b3ed4a08ef3a5e86b0b714fb","user":{"login":"mattab","id":466765,"avatar_url":"https://avatars.githubusercontent.com/u/466765?v=3","gravatar_id":"","url":"https://api.github.com/users/mattab","html_url":"https://github.com/mattab","followers_url":"https://api.github.com/users/mattab/followers","following_url":"https://api.github.com/users/mattab/following{/other_user}","gists_url":"https://api.github.com/users/mattab/gists{/gist_id}","starred_url":"https://api.github.com/users/mattab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattab/subscriptions","organizations_url":"https://api.github.com/users/mattab/orgs","repos_url":"https://api.github.com/users/mattab/repos","events_url":"https://api.github.com/users/mattab/events{/privacy}","received_events_url":"https://api.github.com/users/mattab/received_events","type":"User","site_admin":false},"body":"Suggested description: `A native mobile app for iOS, Android or Titanium. Measure user interactions with one of our SDKs.` ?","created_at":"2015-06-07T23:14:25Z","updated_at":"2015-06-07T23:14:25Z","html_url":"https://github.com/piwik/piwik/pull/8045#discussion_r31881952","pull_request_url":"https://api.github.com/repos/piwik/piwik/pulls/8045","_links":{"self":{"href":"https://api.github.com/repos/piwik/piwik/pulls/comments/31881952"},"html":{"href":"https://github.com/piwik/piwik/pull/8045#discussion_r31881952"},"pull_request":{"href":"https://api.github.com/repos/piwik/piwik/pulls/8045"}}},"pull_request":{"url":"https://api.github.com/repos/piwik/piwik/pulls/8045","id":37001977,"html_url":"https://github.com/piwik/piwik/pull/8045","diff_url":"https://github.com/piwik/piwik/pull/8045.diff","patch_url":"https://github.com/piwik/piwik/pull/8045.patch","issue_url":"https://api.github.com/repos/piwik/piwik/issues/8045","number":8045,"state":"open","locked":false,"title":"A first version of having the possibility to create mobile apps","user":{"login":"tsteur","id":273120,"avatar_url":"https://avatars.githubusercontent.com/u/273120?v=3","gravatar_id":"","url":"https://api.github.com/users/tsteur","html_url":"https://github.com/tsteur","followers_url":"https://api.github.com/users/tsteur/followers","following_url":"https://api.github.com/users/tsteur/following{/other_user}","gists_url":"https://api.github.com/users/tsteur/gists{/gist_id}","starred_url":"https://api.github.com/users/tsteur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsteur/subscriptions","organizations_url":"https://api.github.com/users/tsteur/orgs","repos_url":"https://api.github.com/users/tsteur/repos","events_url":"https://api.github.com/users/tsteur/events{/privacy}","received_events_url":"https://api.github.com/users/tsteur/received_events","type":"User","site_admin":false},"body":"**please wait with merge but review needed**\r\n\r\nrefs #7893 \r\nfixes #7803 \r\n\r\nNew wording \r\n* Type: Can be a \"Website\", \"Mobile App\", later a car,  a server, ...\r\n* Properties: So far we only had \"Websites\". We will use the term \"Properties\" as soon as multiple types are enabled and / or if multiple types are actually used. It depends where it is used. In the future we will no longer work based on `Sites` but on `Properties`. Not for now though...\r\n\r\nThis is only a first version since we will need this feature for a Piwik Pro plugin soon. To make it really nice we need to refactor the Settings API (which let's you currently create PluginSettings only, so everything is related to plugins, not properties). Also we need to change many other things and this is not doable in a short time frame. Therefore I made it more or less \"work\". It will be a bit nicer for Piwik 3.0.0 when we can also change APIs and spend more time on it. None of the new `PropertySettings` API etc will be actually public API as we will remove/change it very soon again.\r\n\r\nThere are new plugins `WebsiteType` and `MobileAppType`. Let me now re naming. I can name it only `Website` and `MobileApp` but we might want to use this for other things in the future. I do not really mind. `MobileAppType` is disabled by default so far most users nothing really changes. I do not think we will announce this MobileAppType thing big is it does not yet have a real value. This will be added over time.\r\n\r\nOnce multiple types are enabled we use \"Add new property\" (in Sites Management only so far) and we will let a user choose what type to create. The PropertySettings API let's you define custom settings for properties. Eg the type MobileAppType defines a custom setting \"App ID\". On top plugins can add custom settings for all properties or only settings for a certain type.\r\n\r\n@mattab you might want to have a look re the descriptions in the Types. I will leave a note in the code.\r\n\r\n![create_property](https://cloud.githubusercontent.com/assets/273120/7999963/2db9856c-0ba8-11e5-85e5-5418332be0f4.png)\r\n![edit_mobileapp](https://cloud.githubusercontent.com/assets/273120/7999964/2dba355c-0ba8-11e5-8da5-64923a92f41b.png)\r\n","created_at":"2015-06-05T05:26:30Z","updated_at":"2015-06-07T23:14:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"706eabe4a43e903283827bc7c4b777d9019ee2e0","assignee":null,"milestone":{"url":"https://api.github.com/repos/piwik/piwik/milestones/79","html_url":"https://github.com/piwik/piwik/milestones/2.14.0","labels_url":"https://api.github.com/repos/piwik/piwik/milestones/79/labels","id":1005076,"number":79,"title":"2.14.0","description":"","creator":{"login":"mattab","id":466765,"avatar_url":"https://avatars.githubusercontent.com/u/466765?v=3","gravatar_id":"","url":"https://api.github.com/users/mattab","html_url":"https://github.com/mattab","followers_url":"https://api.github.com/users/mattab/followers","following_url":"https://api.github.com/users/mattab/following{/other_user}","gists_url":"https://api.github.com/users/mattab/gists{/gist_id}","starred_url":"https://api.github.com/users/mattab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattab/subscriptions","organizations_url":"https://api.github.com/users/mattab/orgs","repos_url":"https://api.github.com/users/mattab/repos","events_url":"https://api.github.com/users/mattab/events{/privacy}","received_events_url":"https://api.github.com/users/mattab/received_events","type":"User","site_admin":false},"open_issues":37,"closed_issues":109,"state":"open","created_at":"2015-03-04T03:03:44Z","updated_at":"2015-06-07T22:56:58Z","due_on":"2015-06-09T12:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/piwik/piwik/pulls/8045/commits","review_comments_url":"https://api.github.com/repos/piwik/piwik/pulls/8045/comments","review_comment_url":"https://api.github.com/repos/piwik/piwik/pulls/comments{/number}","comments_url":"https://api.github.com/repos/piwik/piwik/issues/8045/comments","statuses_url":"https://api.github.com/repos/piwik/piwik/statuses/b5aec8c824c644f824d047e052360ac891f49bc4","head":{"label":"piwik:7893","ref":"7893","sha":"b5aec8c824c644f824d047e052360ac891f49bc4","user":{"login":"piwik","id":698038,"avatar_url":"https://avatars.githubusercontent.com/u/698038?v=3","gravatar_id":"","url":"https://api.github.com/users/piwik","html_url":"https://github.com/piwik","followers_url":"https://api.github.com/users/piwik/followers","following_url":"https://api.github.com/users/piwik/following{/other_user}","gists_url":"https://api.github.com/users/piwik/gists{/gist_id}","starred_url":"https://api.github.com/users/piwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwik/subscriptions","organizations_url":"https://api.github.com/users/piwik/orgs","repos_url":"https://api.github.com/users/piwik/repos","events_url":"https://api.github.com/users/piwik/events{/privacy}","received_events_url":"https://api.github.com/users/piwik/received_events","type":"Organization","site_admin":false},"repo":{"id":1548202,"name":"piwik","full_name":"piwik/piwik","owner":{"login":"piwik","id":698038,"avatar_url":"https://avatars.githubusercontent.com/u/698038?v=3","gravatar_id":"","url":"https://api.github.com/users/piwik","html_url":"https://github.com/piwik","followers_url":"https://api.github.com/users/piwik/followers","following_url":"https://api.github.com/users/piwik/following{/other_user}","gists_url":"https://api.github.com/users/piwik/gists{/gist_id}","starred_url":"https://api.github.com/users/piwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwik/subscriptions","organizations_url":"https://api.github.com/users/piwik/orgs","repos_url":"https://api.github.com/users/piwik/repos","events_url":"https://api.github.com/users/piwik/events{/privacy}","received_events_url":"https://api.github.com/users/piwik/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/piwik/piwik","description":"Liberating Web Analytics. Star us on Github? +1. Piwik is the leading open alternative to Google Analytics that gives you full control over your data. Piwik lets you easily collect data from websites, apps & IoT and visualise this data and extract insights. Privacy is built-in. We love Pull Requests! ","fork":false,"url":"https://api.github.com/repos/piwik/piwik","forks_url":"https://api.github.com/repos/piwik/piwik/forks","keys_url":"https://api.github.com/repos/piwik/piwik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piwik/piwik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piwik/piwik/teams","hooks_url":"https://api.github.com/repos/piwik/piwik/hooks","issue_events_url":"https://api.github.com/repos/piwik/piwik/issues/events{/number}","events_url":"https://api.github.com/repos/piwik/piwik/events","assignees_url":"https://api.github.com/repos/piwik/piwik/assignees{/user}","branches_url":"https://api.github.com/repos/piwik/piwik/branches{/branch}","tags_url":"https://api.github.com/repos/piwik/piwik/tags","blobs_url":"https://api.github.com/repos/piwik/piwik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piwik/piwik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piwik/piwik/git/refs{/sha}","trees_url":"https://api.github.com/repos/piwik/piwik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piwik/piwik/statuses/{sha}","languages_url":"https://api.github.com/repos/piwik/piwik/languages","stargazers_url":"https://api.github.com/repos/piwik/piwik/stargazers","contributors_url":"https://api.github.com/repos/piwik/piwik/contributors","subscribers_url":"https://api.github.com/repos/piwik/piwik/subscribers","subscription_url":"https://api.github.com/repos/piwik/piwik/subscription","commits_url":"https://api.github.com/repos/piwik/piwik/commits{/sha}","git_commits_url":"https://api.github.com/repos/piwik/piwik/git/commits{/sha}","comments_url":"https://api.github.com/repos/piwik/piwik/comments{/number}","issue_comment_url":"https://api.github.com/repos/piwik/piwik/issues/comments{/number}","contents_url":"https://api.github.com/repos/piwik/piwik/contents/{+path}","compare_url":"https://api.github.com/repos/piwik/piwik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piwik/piwik/merges","archive_url":"https://api.github.com/repos/piwik/piwik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piwik/piwik/downloads","issues_url":"https://api.github.com/repos/piwik/piwik/issues{/number}","pulls_url":"https://api.github.com/repos/piwik/piwik/pulls{/number}","milestones_url":"https://api.github.com/repos/piwik/piwik/milestones{/number}","notifications_url":"https://api.github.com/repos/piwik/piwik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piwik/piwik/labels{/name}","releases_url":"https://api.github.com/repos/piwik/piwik/releases{/id}","created_at":"2011-03-30T21:18:17Z","updated_at":"2015-06-07T12:48:12Z","pushed_at":"2015-06-07T21:55:09Z","git_url":"git://github.com/piwik/piwik.git","ssh_url":"git@github.com:piwik/piwik.git","clone_url":"https://github.com/piwik/piwik.git","svn_url":"https://github.com/piwik/piwik","homepage":"http://piwik.org/","size":332896,"stargazers_count":3962,"watchers_count":3962,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":721,"mirror_url":null,"open_issues_count":1044,"forks":721,"open_issues":1044,"watchers":3962,"default_branch":"master"}},"base":{"label":"piwik:master","ref":"master","sha":"d17d6b37afb10809b80a15290a868b58fd5da706","user":{"login":"piwik","id":698038,"avatar_url":"https://avatars.githubusercontent.com/u/698038?v=3","gravatar_id":"","url":"https://api.github.com/users/piwik","html_url":"https://github.com/piwik","followers_url":"https://api.github.com/users/piwik/followers","following_url":"https://api.github.com/users/piwik/following{/other_user}","gists_url":"https://api.github.com/users/piwik/gists{/gist_id}","starred_url":"https://api.github.com/users/piwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwik/subscriptions","organizations_url":"https://api.github.com/users/piwik/orgs","repos_url":"https://api.github.com/users/piwik/repos","events_url":"https://api.github.com/users/piwik/events{/privacy}","received_events_url":"https://api.github.com/users/piwik/received_events","type":"Organization","site_admin":false},"repo":{"id":1548202,"name":"piwik","full_name":"piwik/piwik","owner":{"login":"piwik","id":698038,"avatar_url":"https://avatars.githubusercontent.com/u/698038?v=3","gravatar_id":"","url":"https://api.github.com/users/piwik","html_url":"https://github.com/piwik","followers_url":"https://api.github.com/users/piwik/followers","following_url":"https://api.github.com/users/piwik/following{/other_user}","gists_url":"https://api.github.com/users/piwik/gists{/gist_id}","starred_url":"https://api.github.com/users/piwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwik/subscriptions","organizations_url":"https://api.github.com/users/piwik/orgs","repos_url":"https://api.github.com/users/piwik/repos","events_url":"https://api.github.com/users/piwik/events{/privacy}","received_events_url":"https://api.github.com/users/piwik/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/piwik/piwik","description":"Liberating Web Analytics. Star us on Github? +1. Piwik is the leading open alternative to Google Analytics that gives you full control over your data. Piwik lets you easily collect data from websites, apps & IoT and visualise this data and extract insights. Privacy is built-in. We love Pull Requests! ","fork":false,"url":"https://api.github.com/repos/piwik/piwik","forks_url":"https://api.github.com/repos/piwik/piwik/forks","keys_url":"https://api.github.com/repos/piwik/piwik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piwik/piwik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piwik/piwik/teams","hooks_url":"https://api.github.com/repos/piwik/piwik/hooks","issue_events_url":"https://api.github.com/repos/piwik/piwik/issues/events{/number}","events_url":"https://api.github.com/repos/piwik/piwik/events","assignees_url":"https://api.github.com/repos/piwik/piwik/assignees{/user}","branches_url":"https://api.github.com/repos/piwik/piwik/branches{/branch}","tags_url":"https://api.github.com/repos/piwik/piwik/tags","blobs_url":"https://api.github.com/repos/piwik/piwik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piwik/piwik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piwik/piwik/git/refs{/sha}","trees_url":"https://api.github.com/repos/piwik/piwik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piwik/piwik/statuses/{sha}","languages_url":"https://api.github.com/repos/piwik/piwik/languages","stargazers_url":"https://api.github.com/repos/piwik/piwik/stargazers","contributors_url":"https://api.github.com/repos/piwik/piwik/contributors","subscribers_url":"https://api.github.com/repos/piwik/piwik/subscribers","subscription_url":"https://api.github.com/repos/piwik/piwik/subscription","commits_url":"https://api.github.com/repos/piwik/piwik/commits{/sha}","git_commits_url":"https://api.github.com/repos/piwik/piwik/git/commits{/sha}","comments_url":"https://api.github.com/repos/piwik/piwik/comments{/number}","issue_comment_url":"https://api.github.com/repos/piwik/piwik/issues/comments{/number}","contents_url":"https://api.github.com/repos/piwik/piwik/contents/{+path}","compare_url":"https://api.github.com/repos/piwik/piwik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piwik/piwik/merges","archive_url":"https://api.github.com/repos/piwik/piwik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piwik/piwik/downloads","issues_url":"https://api.github.com/repos/piwik/piwik/issues{/number}","pulls_url":"https://api.github.com/repos/piwik/piwik/pulls{/number}","milestones_url":"https://api.github.com/repos/piwik/piwik/milestones{/number}","notifications_url":"https://api.github.com/repos/piwik/piwik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piwik/piwik/labels{/name}","releases_url":"https://api.github.com/repos/piwik/piwik/releases{/id}","created_at":"2011-03-30T21:18:17Z","updated_at":"2015-06-07T12:48:12Z","pushed_at":"2015-06-07T21:55:09Z","git_url":"git://github.com/piwik/piwik.git","ssh_url":"git@github.com:piwik/piwik.git","clone_url":"https://github.com/piwik/piwik.git","svn_url":"https://github.com/piwik/piwik","homepage":"http://piwik.org/","size":332896,"stargazers_count":3962,"watchers_count":3962,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":721,"mirror_url":null,"open_issues_count":1044,"forks":721,"open_issues":1044,"watchers":3962,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/piwik/piwik/pulls/8045"},"html":{"href":"https://github.com/piwik/piwik/pull/8045"},"issue":{"href":"https://api.github.com/repos/piwik/piwik/issues/8045"},"comments":{"href":"https://api.github.com/repos/piwik/piwik/issues/8045/comments"},"review_comments":{"href":"https://api.github.com/repos/piwik/piwik/pulls/8045/comments"},"review_comment":{"href":"https://api.github.com/repos/piwik/piwik/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/piwik/piwik/pulls/8045/commits"},"statuses":{"href":"https://api.github.com/repos/piwik/piwik/statuses/b5aec8c824c644f824d047e052360ac891f49bc4"}}}}