{"action":"created","comment":{"url":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/comments/23631249","id":23631249,"diff_hunk":"@@ -46,6 +47,28 @@ public function __construct( $requestedLanguageCode, $text, $actualLanguageCode,\n \t\t\tthrow new InvalidArgumentException( '$sourceLanguageCode must be a non-empty string or null' );\n \t\t}\n \n+\t\tif ( $sourceLanguageCode === null && $actualLanguageCode === $requestedLanguageCode ) {","path":"src/Term/TermFallback.php","position":16,"original_position":16,"commit_id":"85c2f5a5e095a80ae5261ee590e9fc46034ed2db","original_commit_id":"85c2f5a5e095a80ae5261ee590e9fc46034ed2db","user":{"login":"thiemowmde","id":6576639,"avatar_url":"https://avatars.githubusercontent.com/u/6576639?v=3","gravatar_id":"","url":"https://api.github.com/users/thiemowmde","html_url":"https://github.com/thiemowmde","followers_url":"https://api.github.com/users/thiemowmde/followers","following_url":"https://api.github.com/users/thiemowmde/following{/other_user}","gists_url":"https://api.github.com/users/thiemowmde/gists{/gist_id}","starred_url":"https://api.github.com/users/thiemowmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiemowmde/subscriptions","organizations_url":"https://api.github.com/users/thiemowmde/orgs","repos_url":"https://api.github.com/users/thiemowmde/repos","events_url":"https://api.github.com/users/thiemowmde/events{/privacy}","received_events_url":"https://api.github.com/users/thiemowmde/received_events","type":"User","site_admin":false},"body":"One of the later two `if`s is redundant and can be removed. What about these checks and messages:\r\n1. \"$actual must be different from $requested, if no transliteration took place; use Term without fallback instead\"\r\n2. \"$source must either be null, if no transliteration took place, or different from $requested\"","created_at":"2015-01-27T18:44:23Z","updated_at":"2015-01-27T18:44:23Z","html_url":"https://github.com/wmde/WikibaseDataModel/pull/350#discussion_r23631249","pull_request_url":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/350","_links":{"self":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/comments/23631249"},"html":{"href":"https://github.com/wmde/WikibaseDataModel/pull/350#discussion_r23631249"},"pull_request":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/350"}}},"pull_request":{"url":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/350","id":28035963,"html_url":"https://github.com/wmde/WikibaseDataModel/pull/350","diff_url":"https://github.com/wmde/WikibaseDataModel/pull/350.diff","patch_url":"https://github.com/wmde/WikibaseDataModel/pull/350.patch","issue_url":"https://api.github.com/repos/wmde/WikibaseDataModel/issues/350","number":350,"state":"open","locked":false,"title":"[WIP] Throw exception on creation of nonsensical Fallbacks","user":{"login":"JanZerebecki","id":7452727,"avatar_url":"https://avatars.githubusercontent.com/u/7452727?v=3","gravatar_id":"","url":"https://api.github.com/users/JanZerebecki","html_url":"https://github.com/JanZerebecki","followers_url":"https://api.github.com/users/JanZerebecki/followers","following_url":"https://api.github.com/users/JanZerebecki/following{/other_user}","gists_url":"https://api.github.com/users/JanZerebecki/gists{/gist_id}","starred_url":"https://api.github.com/users/JanZerebecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanZerebecki/subscriptions","organizations_url":"https://api.github.com/users/JanZerebecki/orgs","repos_url":"https://api.github.com/users/JanZerebecki/repos","events_url":"https://api.github.com/users/JanZerebecki/events{/privacy}","received_events_url":"https://api.github.com/users/JanZerebecki/received_events","type":"User","site_admin":false},"body":"Such Fallbacks should be normal Terms instead.","created_at":"2015-01-26T15:49:10Z","updated_at":"2015-01-27T18:44:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92ea28d6add9803b88c354e1c835487970b4a223","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/350/commits","review_comments_url":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/350/comments","review_comment_url":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wmde/WikibaseDataModel/issues/350/comments","statuses_url":"https://api.github.com/repos/wmde/WikibaseDataModel/statuses/85c2f5a5e095a80ae5261ee590e9fc46034ed2db","head":{"label":"wmde:exception-on-nonsense-fallback","ref":"exception-on-nonsense-fallback","sha":"85c2f5a5e095a80ae5261ee590e9fc46034ed2db","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":15110788,"name":"WikibaseDataModel","full_name":"wmde/WikibaseDataModel","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/WikibaseDataModel","description":"PHP implementation of the Wikibase Data Model","fork":false,"url":"https://api.github.com/repos/wmde/WikibaseDataModel","forks_url":"https://api.github.com/repos/wmde/WikibaseDataModel/forks","keys_url":"https://api.github.com/repos/wmde/WikibaseDataModel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/WikibaseDataModel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/WikibaseDataModel/teams","hooks_url":"https://api.github.com/repos/wmde/WikibaseDataModel/hooks","issue_events_url":"https://api.github.com/repos/wmde/WikibaseDataModel/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/WikibaseDataModel/events","assignees_url":"https://api.github.com/repos/wmde/WikibaseDataModel/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/WikibaseDataModel/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/WikibaseDataModel/tags","blobs_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/WikibaseDataModel/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/WikibaseDataModel/languages","stargazers_url":"https://api.github.com/repos/wmde/WikibaseDataModel/stargazers","contributors_url":"https://api.github.com/repos/wmde/WikibaseDataModel/contributors","subscribers_url":"https://api.github.com/repos/wmde/WikibaseDataModel/subscribers","subscription_url":"https://api.github.com/repos/wmde/WikibaseDataModel/subscription","commits_url":"https://api.github.com/repos/wmde/WikibaseDataModel/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/WikibaseDataModel/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/WikibaseDataModel/issues/comments/{number}","contents_url":"https://api.github.com/repos/wmde/WikibaseDataModel/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/WikibaseDataModel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/WikibaseDataModel/merges","archive_url":"https://api.github.com/repos/wmde/WikibaseDataModel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/WikibaseDataModel/downloads","issues_url":"https://api.github.com/repos/wmde/WikibaseDataModel/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/WikibaseDataModel/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/WikibaseDataModel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/WikibaseDataModel/labels{/name}","releases_url":"https://api.github.com/repos/wmde/WikibaseDataModel/releases{/id}","created_at":"2013-12-11T15:20:51Z","updated_at":"2015-01-27T18:30:58Z","pushed_at":"2015-01-27T18:31:02Z","git_url":"git://github.com/wmde/WikibaseDataModel.git","ssh_url":"git@github.com:wmde/WikibaseDataModel.git","clone_url":"https://github.com/wmde/WikibaseDataModel.git","svn_url":"https://github.com/wmde/WikibaseDataModel","homepage":"http://wikiba.se/","size":4868,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":23,"forks":8,"open_issues":23,"watchers":7,"default_branch":"master"}},"base":{"label":"wmde:master","ref":"master","sha":"f68441c4d7a26cd4a8f48efffaa9831e74cea6b6","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":15110788,"name":"WikibaseDataModel","full_name":"wmde/WikibaseDataModel","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/WikibaseDataModel","description":"PHP implementation of the Wikibase Data Model","fork":false,"url":"https://api.github.com/repos/wmde/WikibaseDataModel","forks_url":"https://api.github.com/repos/wmde/WikibaseDataModel/forks","keys_url":"https://api.github.com/repos/wmde/WikibaseDataModel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/WikibaseDataModel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/WikibaseDataModel/teams","hooks_url":"https://api.github.com/repos/wmde/WikibaseDataModel/hooks","issue_events_url":"https://api.github.com/repos/wmde/WikibaseDataModel/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/WikibaseDataModel/events","assignees_url":"https://api.github.com/repos/wmde/WikibaseDataModel/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/WikibaseDataModel/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/WikibaseDataModel/tags","blobs_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/WikibaseDataModel/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/WikibaseDataModel/languages","stargazers_url":"https://api.github.com/repos/wmde/WikibaseDataModel/stargazers","contributors_url":"https://api.github.com/repos/wmde/WikibaseDataModel/contributors","subscribers_url":"https://api.github.com/repos/wmde/WikibaseDataModel/subscribers","subscription_url":"https://api.github.com/repos/wmde/WikibaseDataModel/subscription","commits_url":"https://api.github.com/repos/wmde/WikibaseDataModel/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/WikibaseDataModel/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/WikibaseDataModel/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/WikibaseDataModel/issues/comments/{number}","contents_url":"https://api.github.com/repos/wmde/WikibaseDataModel/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/WikibaseDataModel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/WikibaseDataModel/merges","archive_url":"https://api.github.com/repos/wmde/WikibaseDataModel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/WikibaseDataModel/downloads","issues_url":"https://api.github.com/repos/wmde/WikibaseDataModel/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/WikibaseDataModel/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/WikibaseDataModel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/WikibaseDataModel/labels{/name}","releases_url":"https://api.github.com/repos/wmde/WikibaseDataModel/releases{/id}","created_at":"2013-12-11T15:20:51Z","updated_at":"2015-01-27T18:30:58Z","pushed_at":"2015-01-27T18:31:02Z","git_url":"git://github.com/wmde/WikibaseDataModel.git","ssh_url":"git@github.com:wmde/WikibaseDataModel.git","clone_url":"https://github.com/wmde/WikibaseDataModel.git","svn_url":"https://github.com/wmde/WikibaseDataModel","homepage":"http://wikiba.se/","size":4868,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":23,"forks":8,"open_issues":23,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/350"},"html":{"href":"https://github.com/wmde/WikibaseDataModel/pull/350"},"issue":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/issues/350"},"comments":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/issues/350/comments"},"review_comments":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/350/comments"},"review_comment":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/pulls/350/commits"},"statuses":{"href":"https://api.github.com/repos/wmde/WikibaseDataModel/statuses/85c2f5a5e095a80ae5261ee590e9fc46034ed2db"}}}}