{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/27256701","id":27256701,"diff_hunk":"@@ -68,12 +70,12 @@ public LabelPropagation(int maxIterations) {\n \tpublic static final class UpdateVertexLabel<K extends Comparable<K> & Serializable>\n \t\t\textends VertexUpdateFunction<K, Long, Long> {\n \n-\t\tpublic void updateVertex(K vertexKey, Long vertexValue,\n+\t\tpublic void updateVertex(Vertex<K, Tuple3<Long,Long,Long>> vertex,\n \t\t\t\tMessageIterator<Long> inMessages) {\n \t\t\tMap<Long, Long> labelsWithFrequencies = new HashMap<Long, Long>();\n \n \t\t\tlong maxFrequency = 1;\n-\t\t\tlong mostFrequentLabel = vertexValue;\n+\t\t\tlong mostFrequentLabel = vertex.getValue().f0;","path":"flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/library/LabelPropagation.java","position":22,"original_position":22,"commit_id":"d6ce302fbbf8994b87f8730d0a33430711c71ab8","original_commit_id":"d6ce302fbbf8994b87f8730d0a33430711c71ab8","user":{"login":"vasia","id":498957,"avatar_url":"https://avatars.githubusercontent.com/u/498957?v=3","gravatar_id":"","url":"https://api.github.com/users/vasia","html_url":"https://github.com/vasia","followers_url":"https://api.github.com/users/vasia/followers","following_url":"https://api.github.com/users/vasia/following{/other_user}","gists_url":"https://api.github.com/users/vasia/gists{/gist_id}","starred_url":"https://api.github.com/users/vasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasia/subscriptions","organizations_url":"https://api.github.com/users/vasia/orgs","repos_url":"https://api.github.com/users/vasia/repos","events_url":"https://api.github.com/users/vasia/events{/privacy}","received_events_url":"https://api.github.com/users/vasia/received_events","type":"User","site_admin":false},"body":"`vertex.getValue()` should return the vertex value, not a Tuple3 from the user has to extract the vertex value :S","created_at":"2015-03-26T21:13:58Z","updated_at":"2015-03-26T21:13:58Z","html_url":"https://github.com/apache/flink/pull/537#discussion_r27256701","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/537","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/27256701"},"html":{"href":"https://github.com/apache/flink/pull/537#discussion_r27256701"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/537"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/537","id":31996849,"html_url":"https://github.com/apache/flink/pull/537","diff_url":"https://github.com/apache/flink/pull/537.diff","patch_url":"https://github.com/apache/flink/pull/537.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/537","number":537,"state":"open","locked":false,"title":"[FLINK-1523][gelly] Vertex centric iteration extensions","user":{"login":"andralungu","id":2550549,"avatar_url":"https://avatars.githubusercontent.com/u/2550549?v=3","gravatar_id":"","url":"https://api.github.com/users/andralungu","html_url":"https://github.com/andralungu","followers_url":"https://api.github.com/users/andralungu/followers","following_url":"https://api.github.com/users/andralungu/following{/other_user}","gists_url":"https://api.github.com/users/andralungu/gists{/gist_id}","starred_url":"https://api.github.com/users/andralungu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andralungu/subscriptions","organizations_url":"https://api.github.com/users/andralungu/orgs","repos_url":"https://api.github.com/users/andralungu/repos","events_url":"https://api.github.com/users/andralungu/events{/privacy}","received_events_url":"https://api.github.com/users/andralungu/received_events","type":"User","site_admin":false},"body":"Thank you @StephanEwen for the hint!(keeping the degrees within the vertex value)\r\n@vasia, I am sure I left some trailing irrelevant comments/unused functions there. \r\n\r\nThis is the first draft for the Spargel extensions; it changes the usual runVertexCentricIteration(), which means that feedback is welcome. \r\n\r\nThanks!","created_at":"2015-03-26T08:20:43Z","updated_at":"2015-03-26T21:13:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"983b32794ec4d49a752871b7c796d8c6164558ec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/537/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/537/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/537/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/d6ce302fbbf8994b87f8730d0a33430711c71ab8","head":{"label":"andralungu:spargelExt","ref":"spargelExt","sha":"d6ce302fbbf8994b87f8730d0a33430711c71ab8","user":{"login":"andralungu","id":2550549,"avatar_url":"https://avatars.githubusercontent.com/u/2550549?v=3","gravatar_id":"","url":"https://api.github.com/users/andralungu","html_url":"https://github.com/andralungu","followers_url":"https://api.github.com/users/andralungu/followers","following_url":"https://api.github.com/users/andralungu/following{/other_user}","gists_url":"https://api.github.com/users/andralungu/gists{/gist_id}","starred_url":"https://api.github.com/users/andralungu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andralungu/subscriptions","organizations_url":"https://api.github.com/users/andralungu/orgs","repos_url":"https://api.github.com/users/andralungu/repos","events_url":"https://api.github.com/users/andralungu/events{/privacy}","received_events_url":"https://api.github.com/users/andralungu/received_events","type":"User","site_admin":false},"repo":{"id":30769949,"name":"flink","full_name":"andralungu/flink","owner":{"login":"andralungu","id":2550549,"avatar_url":"https://avatars.githubusercontent.com/u/2550549?v=3","gravatar_id":"","url":"https://api.github.com/users/andralungu","html_url":"https://github.com/andralungu","followers_url":"https://api.github.com/users/andralungu/followers","following_url":"https://api.github.com/users/andralungu/following{/other_user}","gists_url":"https://api.github.com/users/andralungu/gists{/gist_id}","starred_url":"https://api.github.com/users/andralungu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andralungu/subscriptions","organizations_url":"https://api.github.com/users/andralungu/orgs","repos_url":"https://api.github.com/users/andralungu/repos","events_url":"https://api.github.com/users/andralungu/events{/privacy}","received_events_url":"https://api.github.com/users/andralungu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andralungu/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/andralungu/flink","forks_url":"https://api.github.com/repos/andralungu/flink/forks","keys_url":"https://api.github.com/repos/andralungu/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andralungu/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andralungu/flink/teams","hooks_url":"https://api.github.com/repos/andralungu/flink/hooks","issue_events_url":"https://api.github.com/repos/andralungu/flink/issues/events{/number}","events_url":"https://api.github.com/repos/andralungu/flink/events","assignees_url":"https://api.github.com/repos/andralungu/flink/assignees{/user}","branches_url":"https://api.github.com/repos/andralungu/flink/branches{/branch}","tags_url":"https://api.github.com/repos/andralungu/flink/tags","blobs_url":"https://api.github.com/repos/andralungu/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andralungu/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andralungu/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/andralungu/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andralungu/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/andralungu/flink/languages","stargazers_url":"https://api.github.com/repos/andralungu/flink/stargazers","contributors_url":"https://api.github.com/repos/andralungu/flink/contributors","subscribers_url":"https://api.github.com/repos/andralungu/flink/subscribers","subscription_url":"https://api.github.com/repos/andralungu/flink/subscription","commits_url":"https://api.github.com/repos/andralungu/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/andralungu/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/andralungu/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/andralungu/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/andralungu/flink/contents/{+path}","compare_url":"https://api.github.com/repos/andralungu/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andralungu/flink/merges","archive_url":"https://api.github.com/repos/andralungu/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andralungu/flink/downloads","issues_url":"https://api.github.com/repos/andralungu/flink/issues{/number}","pulls_url":"https://api.github.com/repos/andralungu/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/andralungu/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/andralungu/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andralungu/flink/labels{/name}","releases_url":"https://api.github.com/repos/andralungu/flink/releases{/id}","created_at":"2015-02-13T18:32:47Z","updated_at":"2015-03-19T08:06:54Z","pushed_at":"2015-03-26T08:14:39Z","git_url":"git://github.com/andralungu/flink.git","ssh_url":"git@github.com:andralungu/flink.git","clone_url":"https://github.com/andralungu/flink.git","svn_url":"https://github.com/andralungu/flink","homepage":null,"size":44243,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1b42b6206845f574dc4f4ef5e47ab08be75e1cc2","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","created_at":"2014-06-07T07:00:10Z","updated_at":"2015-03-26T19:31:21Z","pushed_at":"2015-03-26T19:31:20Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":2830687,"stargazers_count":341,"watchers_count":341,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":195,"mirror_url":"git://git.apache.org/incubator-flink.git","open_issues_count":46,"forks":195,"open_issues":46,"watchers":341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/537"},"html":{"href":"https://github.com/apache/flink/pull/537"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/537"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/537/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/537/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/537/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/d6ce302fbbf8994b87f8730d0a33430711c71ab8"}}}}