{"action":"opened","issue":{"url":"https://api.github.com/repos/HerculesWS/Hercules/issues/737","labels_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/737/labels{/name}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/737/comments","events_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/737/events","html_url":"https://github.com/HerculesWS/Hercules/issues/737","id":108125441,"number":737,"title":"Error messages for server connections denied by network.conf are misleading","user":{"login":"MishimaHaruna","id":4590397,"avatar_url":"https://avatars.githubusercontent.com/u/4590397?v=3","gravatar_id":"","url":"https://api.github.com/users/MishimaHaruna","html_url":"https://github.com/MishimaHaruna","followers_url":"https://api.github.com/users/MishimaHaruna/followers","following_url":"https://api.github.com/users/MishimaHaruna/following{/other_user}","gists_url":"https://api.github.com/users/MishimaHaruna/gists{/gist_id}","starred_url":"https://api.github.com/users/MishimaHaruna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishimaHaruna/subscriptions","organizations_url":"https://api.github.com/users/MishimaHaruna/orgs","repos_url":"https://api.github.com/users/MishimaHaruna/repos","events_url":"https://api.github.com/users/MishimaHaruna/events{/privacy}","received_events_url":"https://api.github.com/users/MishimaHaruna/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/HerculesWS/Hercules/labels/component:core","name":"component:core","color":"803050"},{"url":"https://api.github.com/repos/HerculesWS/Hercules/labels/status:confirmed","name":"status:confirmed","color":"badbc2"},{"url":"https://api.github.com/repos/HerculesWS/Hercules/labels/type:enhancement","name":"type:enhancement","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"MishimaHaruna","id":4590397,"avatar_url":"https://avatars.githubusercontent.com/u/4590397?v=3","gravatar_id":"","url":"https://api.github.com/users/MishimaHaruna","html_url":"https://github.com/MishimaHaruna","followers_url":"https://api.github.com/users/MishimaHaruna/followers","following_url":"https://api.github.com/users/MishimaHaruna/following{/other_user}","gists_url":"https://api.github.com/users/MishimaHaruna/gists{/gist_id}","starred_url":"https://api.github.com/users/MishimaHaruna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishimaHaruna/subscriptions","organizations_url":"https://api.github.com/users/MishimaHaruna/orgs","repos_url":"https://api.github.com/users/MishimaHaruna/repos","events_url":"https://api.github.com/users/MishimaHaruna/events{/privacy}","received_events_url":"https://api.github.com/users/MishimaHaruna/received_events","type":"User","site_admin":false},"milestone":null,"comments":0,"created_at":"2015-09-24T13:03:35Z","updated_at":"2015-09-24T13:03:35Z","closed_at":null,"body":"When the `allowed` networks aren't correctly configured, the error messages are misleading and should be edited to reflect the actual error.\r\n\r\nThis is what currently happens:\r\n\r\n```\r\n[Status]: The login-server is ready (Server is listening on the port 6900).\r\n\r\n[Info]: Connection request of the char-server 'Hercules' @ 192.168.1.72:6121 (account: 's1', pass: 'p1', ip: '192.168.1.72')\r\n[Notice]: Authentication accepted (account: s1, id: 1, ip: 192.168.1.72)\r\n[Notice]: Connection of the char-server 'Hercules' REFUSED.\r\n[Info]: Closed connection from '192.168.1.72'.\r\n```\r\n\r\n```\r\n[Status]: The char-server is ready (Server is listening on the port 6121).\r\n\r\n[Info]: Attempt to connect to login-server...\r\n[Status]: Connecting to 192.168.1.72:6900\r\n[Error]: Can not connect to login-server.\r\n[Error]: The server communication passwords (default s1/p1) are probably invalid.\r\n[Error]: Also, please make sure your login db has the correct communication username/passwords and the gender of the account is S.\r\n[Error]: The communication passwords are set in /conf/map-server.conf and /conf/char-server.conf\r\n[Warning]: Connection to Login Server lost.\r\n```\r\n\r\nThe login server says that authentication was accepted, then says the connection was refused, without showing any message about the reason. Ideally, we'd want the *authentication accepted* message to be never shown in this case, and instead a message about the unauthorized IP should be printed.\r\n\r\nThe char server suggests that the problem might be an incorrect username/password pair, while this is not true. We could provide a proper error code to the character server, so that it can show the correct suggestion in this case.\r\n\r\nThis soft-depends on #736, in order to have a clean implementation."}}