{"action":"created","comment":{"url":"https://api.github.com/repos/QuantConnect/Lean/pulls/comments/27656282","id":27656282,"diff_hunk":"@@ -57,6 +57,11 @@ public abstract class Brokerage : IBrokerage\n         public abstract bool IsConnected { get; }\n \n         /// <summary>\n+        /// Broker Server/API Credentials \n+        /// </summary>\n+        public abstract BrokerageAuthentication Credentials { get; }","path":"Brokerages/Brokerage.cs","position":6,"original_position":6,"commit_id":"c416c2160fec235e4367d10cadcf072affd6e469","original_commit_id":"c416c2160fec235e4367d10cadcf072affd6e469","user":{"login":"mchandschuh","id":531416,"avatar_url":"https://avatars.githubusercontent.com/u/531416?v=3","gravatar_id":"","url":"https://api.github.com/users/mchandschuh","html_url":"https://github.com/mchandschuh","followers_url":"https://api.github.com/users/mchandschuh/followers","following_url":"https://api.github.com/users/mchandschuh/following{/other_user}","gists_url":"https://api.github.com/users/mchandschuh/gists{/gist_id}","starred_url":"https://api.github.com/users/mchandschuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchandschuh/subscriptions","organizations_url":"https://api.github.com/users/mchandschuh/orgs","repos_url":"https://api.github.com/users/mchandschuh/repos","events_url":"https://api.github.com/users/mchandschuh/events{/privacy}","received_events_url":"https://api.github.com/users/mchandschuh/received_events","type":"User","site_admin":false},"body":"This will also need to be added to the IBrokerage interface.","created_at":"2015-04-02T13:30:56Z","updated_at":"2015-04-02T13:30:56Z","html_url":"https://github.com/QuantConnect/Lean/pull/60#discussion_r27656282","pull_request_url":"https://api.github.com/repos/QuantConnect/Lean/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/QuantConnect/Lean/pulls/comments/27656282"},"html":{"href":"https://github.com/QuantConnect/Lean/pull/60#discussion_r27656282"},"pull_request":{"href":"https://api.github.com/repos/QuantConnect/Lean/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/QuantConnect/Lean/pulls/60","id":32500267,"html_url":"https://github.com/QuantConnect/Lean/pull/60","diff_url":"https://github.com/QuantConnect/Lean/pull/60.diff","patch_url":"https://github.com/QuantConnect/Lean/pull/60.patch","issue_url":"https://api.github.com/repos/QuantConnect/Lean/issues/60","number":60,"state":"open","locked":false,"title":"BrokerageAuthentication Classes","user":{"login":"QANTau","id":1386766,"avatar_url":"https://avatars.githubusercontent.com/u/1386766?v=3","gravatar_id":"","url":"https://api.github.com/users/QANTau","html_url":"https://github.com/QANTau","followers_url":"https://api.github.com/users/QANTau/followers","following_url":"https://api.github.com/users/QANTau/following{/other_user}","gists_url":"https://api.github.com/users/QANTau/gists{/gist_id}","starred_url":"https://api.github.com/users/QANTau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QANTau/subscriptions","organizations_url":"https://api.github.com/users/QANTau/orgs","repos_url":"https://api.github.com/users/QANTau/repos","events_url":"https://api.github.com/users/QANTau/events{/privacy}","received_events_url":"https://api.github.com/users/QANTau/received_events","type":"User","site_admin":false},"body":"As discussed last week, attempt #2 at building brokerage authentication code.\r\n\r\nNote the initial seting of a values in OandaBrokerageAuthentication method; I'm assuming that we could display these on a drop-box in the web UI (instead of having the user enter the URL).\r\n\r\nI'm aware that I haven't set intial values for the Oanda API anywhere yet.","created_at":"2015-04-02T10:37:40Z","updated_at":"2015-04-02T13:30:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b40a0d93b7eedde12cd5cd436a81d4bb0883426","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/QuantConnect/Lean/pulls/60/commits","review_comments_url":"https://api.github.com/repos/QuantConnect/Lean/pulls/60/comments","review_comment_url":"https://api.github.com/repos/QuantConnect/Lean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QuantConnect/Lean/issues/60/comments","statuses_url":"https://api.github.com/repos/QuantConnect/Lean/statuses/c416c2160fec235e4367d10cadcf072affd6e469","head":{"label":"QANTau:master","ref":"master","sha":"c416c2160fec235e4367d10cadcf072affd6e469","user":{"login":"QANTau","id":1386766,"avatar_url":"https://avatars.githubusercontent.com/u/1386766?v=3","gravatar_id":"","url":"https://api.github.com/users/QANTau","html_url":"https://github.com/QANTau","followers_url":"https://api.github.com/users/QANTau/followers","following_url":"https://api.github.com/users/QANTau/following{/other_user}","gists_url":"https://api.github.com/users/QANTau/gists{/gist_id}","starred_url":"https://api.github.com/users/QANTau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QANTau/subscriptions","organizations_url":"https://api.github.com/users/QANTau/orgs","repos_url":"https://api.github.com/users/QANTau/repos","events_url":"https://api.github.com/users/QANTau/events{/privacy}","received_events_url":"https://api.github.com/users/QANTau/received_events","type":"User","site_admin":false},"repo":{"id":32388235,"name":"Lean","full_name":"QANTau/Lean","owner":{"login":"QANTau","id":1386766,"avatar_url":"https://avatars.githubusercontent.com/u/1386766?v=3","gravatar_id":"","url":"https://api.github.com/users/QANTau","html_url":"https://github.com/QANTau","followers_url":"https://api.github.com/users/QANTau/followers","following_url":"https://api.github.com/users/QANTau/following{/other_user}","gists_url":"https://api.github.com/users/QANTau/gists{/gist_id}","starred_url":"https://api.github.com/users/QANTau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QANTau/subscriptions","organizations_url":"https://api.github.com/users/QANTau/orgs","repos_url":"https://api.github.com/users/QANTau/repos","events_url":"https://api.github.com/users/QANTau/events{/privacy}","received_events_url":"https://api.github.com/users/QANTau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/QANTau/Lean","description":"Lean Algorithmic Trading Engine by QuantConnect","fork":true,"url":"https://api.github.com/repos/QANTau/Lean","forks_url":"https://api.github.com/repos/QANTau/Lean/forks","keys_url":"https://api.github.com/repos/QANTau/Lean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QANTau/Lean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QANTau/Lean/teams","hooks_url":"https://api.github.com/repos/QANTau/Lean/hooks","issue_events_url":"https://api.github.com/repos/QANTau/Lean/issues/events{/number}","events_url":"https://api.github.com/repos/QANTau/Lean/events","assignees_url":"https://api.github.com/repos/QANTau/Lean/assignees{/user}","branches_url":"https://api.github.com/repos/QANTau/Lean/branches{/branch}","tags_url":"https://api.github.com/repos/QANTau/Lean/tags","blobs_url":"https://api.github.com/repos/QANTau/Lean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QANTau/Lean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QANTau/Lean/git/refs{/sha}","trees_url":"https://api.github.com/repos/QANTau/Lean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QANTau/Lean/statuses/{sha}","languages_url":"https://api.github.com/repos/QANTau/Lean/languages","stargazers_url":"https://api.github.com/repos/QANTau/Lean/stargazers","contributors_url":"https://api.github.com/repos/QANTau/Lean/contributors","subscribers_url":"https://api.github.com/repos/QANTau/Lean/subscribers","subscription_url":"https://api.github.com/repos/QANTau/Lean/subscription","commits_url":"https://api.github.com/repos/QANTau/Lean/commits{/sha}","git_commits_url":"https://api.github.com/repos/QANTau/Lean/git/commits{/sha}","comments_url":"https://api.github.com/repos/QANTau/Lean/comments{/number}","issue_comment_url":"https://api.github.com/repos/QANTau/Lean/issues/comments{/number}","contents_url":"https://api.github.com/repos/QANTau/Lean/contents/{+path}","compare_url":"https://api.github.com/repos/QANTau/Lean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QANTau/Lean/merges","archive_url":"https://api.github.com/repos/QANTau/Lean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QANTau/Lean/downloads","issues_url":"https://api.github.com/repos/QANTau/Lean/issues{/number}","pulls_url":"https://api.github.com/repos/QANTau/Lean/pulls{/number}","milestones_url":"https://api.github.com/repos/QANTau/Lean/milestones{/number}","notifications_url":"https://api.github.com/repos/QANTau/Lean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QANTau/Lean/labels{/name}","releases_url":"https://api.github.com/repos/QANTau/Lean/releases{/id}","created_at":"2015-03-17T10:58:52Z","updated_at":"2015-04-02T10:32:40Z","pushed_at":"2015-04-02T10:32:40Z","git_url":"git://github.com/QANTau/Lean.git","ssh_url":"git@github.com:QANTau/Lean.git","clone_url":"https://github.com/QANTau/Lean.git","svn_url":"https://github.com/QANTau/Lean","homepage":"https://lean.quantconnect.com","size":24384,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"QuantConnect:master","ref":"master","sha":"639a2fda83267c9f5f3891da5e9bf451711399e0","user":{"login":"QuantConnect","id":3912814,"avatar_url":"https://avatars.githubusercontent.com/u/3912814?v=3","gravatar_id":"","url":"https://api.github.com/users/QuantConnect","html_url":"https://github.com/QuantConnect","followers_url":"https://api.github.com/users/QuantConnect/followers","following_url":"https://api.github.com/users/QuantConnect/following{/other_user}","gists_url":"https://api.github.com/users/QuantConnect/gists{/gist_id}","starred_url":"https://api.github.com/users/QuantConnect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuantConnect/subscriptions","organizations_url":"https://api.github.com/users/QuantConnect/orgs","repos_url":"https://api.github.com/users/QuantConnect/repos","events_url":"https://api.github.com/users/QuantConnect/events{/privacy}","received_events_url":"https://api.github.com/users/QuantConnect/received_events","type":"Organization","site_admin":false},"repo":{"id":27251463,"name":"Lean","full_name":"QuantConnect/Lean","owner":{"login":"QuantConnect","id":3912814,"avatar_url":"https://avatars.githubusercontent.com/u/3912814?v=3","gravatar_id":"","url":"https://api.github.com/users/QuantConnect","html_url":"https://github.com/QuantConnect","followers_url":"https://api.github.com/users/QuantConnect/followers","following_url":"https://api.github.com/users/QuantConnect/following{/other_user}","gists_url":"https://api.github.com/users/QuantConnect/gists{/gist_id}","starred_url":"https://api.github.com/users/QuantConnect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuantConnect/subscriptions","organizations_url":"https://api.github.com/users/QuantConnect/orgs","repos_url":"https://api.github.com/users/QuantConnect/repos","events_url":"https://api.github.com/users/QuantConnect/events{/privacy}","received_events_url":"https://api.github.com/users/QuantConnect/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/QuantConnect/Lean","description":"Lean Algorithmic Trading Engine by QuantConnect","fork":false,"url":"https://api.github.com/repos/QuantConnect/Lean","forks_url":"https://api.github.com/repos/QuantConnect/Lean/forks","keys_url":"https://api.github.com/repos/QuantConnect/Lean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QuantConnect/Lean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QuantConnect/Lean/teams","hooks_url":"https://api.github.com/repos/QuantConnect/Lean/hooks","issue_events_url":"https://api.github.com/repos/QuantConnect/Lean/issues/events{/number}","events_url":"https://api.github.com/repos/QuantConnect/Lean/events","assignees_url":"https://api.github.com/repos/QuantConnect/Lean/assignees{/user}","branches_url":"https://api.github.com/repos/QuantConnect/Lean/branches{/branch}","tags_url":"https://api.github.com/repos/QuantConnect/Lean/tags","blobs_url":"https://api.github.com/repos/QuantConnect/Lean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QuantConnect/Lean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QuantConnect/Lean/git/refs{/sha}","trees_url":"https://api.github.com/repos/QuantConnect/Lean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QuantConnect/Lean/statuses/{sha}","languages_url":"https://api.github.com/repos/QuantConnect/Lean/languages","stargazers_url":"https://api.github.com/repos/QuantConnect/Lean/stargazers","contributors_url":"https://api.github.com/repos/QuantConnect/Lean/contributors","subscribers_url":"https://api.github.com/repos/QuantConnect/Lean/subscribers","subscription_url":"https://api.github.com/repos/QuantConnect/Lean/subscription","commits_url":"https://api.github.com/repos/QuantConnect/Lean/commits{/sha}","git_commits_url":"https://api.github.com/repos/QuantConnect/Lean/git/commits{/sha}","comments_url":"https://api.github.com/repos/QuantConnect/Lean/comments{/number}","issue_comment_url":"https://api.github.com/repos/QuantConnect/Lean/issues/comments{/number}","contents_url":"https://api.github.com/repos/QuantConnect/Lean/contents/{+path}","compare_url":"https://api.github.com/repos/QuantConnect/Lean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QuantConnect/Lean/merges","archive_url":"https://api.github.com/repos/QuantConnect/Lean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QuantConnect/Lean/downloads","issues_url":"https://api.github.com/repos/QuantConnect/Lean/issues{/number}","pulls_url":"https://api.github.com/repos/QuantConnect/Lean/pulls{/number}","milestones_url":"https://api.github.com/repos/QuantConnect/Lean/milestones{/number}","notifications_url":"https://api.github.com/repos/QuantConnect/Lean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QuantConnect/Lean/labels{/name}","releases_url":"https://api.github.com/repos/QuantConnect/Lean/releases{/id}","created_at":"2014-11-28T04:20:19Z","updated_at":"2015-04-01T23:57:33Z","pushed_at":"2015-04-02T10:37:40Z","git_url":"git://github.com/QuantConnect/Lean.git","ssh_url":"git@github.com:QuantConnect/Lean.git","clone_url":"https://github.com/QuantConnect/Lean.git","svn_url":"https://github.com/QuantConnect/Lean","homepage":"https://lean.quantconnect.com","size":39698,"stargazers_count":127,"watchers_count":127,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":22,"forks":86,"open_issues":22,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QuantConnect/Lean/pulls/60"},"html":{"href":"https://github.com/QuantConnect/Lean/pull/60"},"issue":{"href":"https://api.github.com/repos/QuantConnect/Lean/issues/60"},"comments":{"href":"https://api.github.com/repos/QuantConnect/Lean/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/QuantConnect/Lean/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/QuantConnect/Lean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QuantConnect/Lean/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/QuantConnect/Lean/statuses/c416c2160fec235e4367d10cadcf072affd6e469"}}}}