{"action":"created","comment":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments/40576747","id":40576747,"diff_hunk":"@@ -40,7 +36,11 @@ function __fish_apm_using_command\n                         return 1\n                     end\n                 case '*'\n-                    return 1\n+                    if test $command_seen_once -eq 0\n+                        continue","path":"share/completions/apm.fish","position":32,"original_position":32,"commit_id":"374c7a43a66d18034f1765c321deafbdd1aab5fa","original_commit_id":"374c7a43a66d18034f1765c321deafbdd1aab5fa","user":{"login":"dan-c-underwood","id":3052345,"avatar_url":"https://avatars.githubusercontent.com/u/3052345?v=3","gravatar_id":"","url":"https://api.github.com/users/dan-c-underwood","html_url":"https://github.com/dan-c-underwood","followers_url":"https://api.github.com/users/dan-c-underwood/followers","following_url":"https://api.github.com/users/dan-c-underwood/following{/other_user}","gists_url":"https://api.github.com/users/dan-c-underwood/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-c-underwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-c-underwood/subscriptions","organizations_url":"https://api.github.com/users/dan-c-underwood/orgs","repos_url":"https://api.github.com/users/dan-c-underwood/repos","events_url":"https://api.github.com/users/dan-c-underwood/events{/privacy}","received_events_url":"https://api.github.com/users/dan-c-underwood/received_events","type":"User","site_admin":false},"body":"> That would mean there can't be a package called \"stars\", \"install\", \"docs\", \"home\" or \"open\".\r\n\r\n> And the \"benefit\" you mention is that fish won't complete - it's not hooked up to syntax highlighting (that would require using completes \"-A\" option) and doesn't allow the user to undo the error. It's not really a good experience if I'm mashing the TAB key and all I get is that limp blink once. Or even worse, if it decides to complete files again.\r\n\r\nValid points, I'm new to working with `fish` and even newer to actually doing any contributions with it so I just want to make sure that any code I write/thoughts are getting critiqued so I'd rather be told something is wrong or inefficient early on than spend hours ending up with some amalgamated solution which works but isn't nearly as clean.\r\n\r\n> Anyway, this is your completion - I don't use apm, so I don't have a stake in this (apart from wanting fish to be great) or expert knowledge of the tool. If you insist, we can keep it that way.\r\n\r\nI wouldn't want anything that doesn't provide a good enough user experience getting merged in anyway since even though they're now my completions the user will just see it as an issue with `fish`! As above, you're a maintainer of the project so your point of view is justifiably one that's important to be noted!","created_at":"2015-09-28T17:01:52Z","updated_at":"2015-09-28T17:01:52Z","html_url":"https://github.com/fish-shell/fish-shell/pull/2435#discussion_r40576747","pull_request_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/2435","_links":{"self":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments/40576747"},"html":{"href":"https://github.com/fish-shell/fish-shell/pull/2435#discussion_r40576747"},"pull_request":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/2435"}}},"pull_request":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/2435","id":46106269,"html_url":"https://github.com/fish-shell/fish-shell/pull/2435","diff_url":"https://github.com/fish-shell/fish-shell/pull/2435.diff","patch_url":"https://github.com/fish-shell/fish-shell/pull/2435.patch","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2435","number":2435,"state":"open","locked":false,"title":"Fix of multiple synonyms for apm command completion","user":{"login":"dan-c-underwood","id":3052345,"avatar_url":"https://avatars.githubusercontent.com/u/3052345?v=3","gravatar_id":"","url":"https://api.github.com/users/dan-c-underwood","html_url":"https://github.com/dan-c-underwood","followers_url":"https://api.github.com/users/dan-c-underwood/followers","following_url":"https://api.github.com/users/dan-c-underwood/following{/other_user}","gists_url":"https://api.github.com/users/dan-c-underwood/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-c-underwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-c-underwood/subscriptions","organizations_url":"https://api.github.com/users/dan-c-underwood/orgs","repos_url":"https://api.github.com/users/dan-c-underwood/repos","events_url":"https://api.github.com/users/dan-c-underwood/events{/privacy}","received_events_url":"https://api.github.com/users/dan-c-underwood/received_events","type":"User","site_admin":false},"body":"Didn't spot this when finalising #2390! Apologies!\r\n\r\n`__fish_apm_using_command` was incorrectly taking lists of commands, new function added to support a command having synonyms.","created_at":"2015-09-27T18:50:11Z","updated_at":"2015-09-28T17:01:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e48abe027a19d7ca1e94eaa3b117006b76a0f48","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/2435/commits","review_comments_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/2435/comments","review_comment_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2435/comments","statuses_url":"https://api.github.com/repos/fish-shell/fish-shell/statuses/374c7a43a66d18034f1765c321deafbdd1aab5fa","head":{"label":"dan-c-underwood:patch-2","ref":"patch-2","sha":"374c7a43a66d18034f1765c321deafbdd1aab5fa","user":{"login":"dan-c-underwood","id":3052345,"avatar_url":"https://avatars.githubusercontent.com/u/3052345?v=3","gravatar_id":"","url":"https://api.github.com/users/dan-c-underwood","html_url":"https://github.com/dan-c-underwood","followers_url":"https://api.github.com/users/dan-c-underwood/followers","following_url":"https://api.github.com/users/dan-c-underwood/following{/other_user}","gists_url":"https://api.github.com/users/dan-c-underwood/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-c-underwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-c-underwood/subscriptions","organizations_url":"https://api.github.com/users/dan-c-underwood/orgs","repos_url":"https://api.github.com/users/dan-c-underwood/repos","events_url":"https://api.github.com/users/dan-c-underwood/events{/privacy}","received_events_url":"https://api.github.com/users/dan-c-underwood/received_events","type":"User","site_admin":false},"repo":{"id":41823208,"name":"fish-shell","full_name":"dan-c-underwood/fish-shell","owner":{"login":"dan-c-underwood","id":3052345,"avatar_url":"https://avatars.githubusercontent.com/u/3052345?v=3","gravatar_id":"","url":"https://api.github.com/users/dan-c-underwood","html_url":"https://github.com/dan-c-underwood","followers_url":"https://api.github.com/users/dan-c-underwood/followers","following_url":"https://api.github.com/users/dan-c-underwood/following{/other_user}","gists_url":"https://api.github.com/users/dan-c-underwood/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-c-underwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-c-underwood/subscriptions","organizations_url":"https://api.github.com/users/dan-c-underwood/orgs","repos_url":"https://api.github.com/users/dan-c-underwood/repos","events_url":"https://api.github.com/users/dan-c-underwood/events{/privacy}","received_events_url":"https://api.github.com/users/dan-c-underwood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dan-c-underwood/fish-shell","description":"The user-friendly command line shell.","fork":true,"url":"https://api.github.com/repos/dan-c-underwood/fish-shell","forks_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/forks","keys_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/teams","hooks_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/hooks","issue_events_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/issues/events{/number}","events_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/events","assignees_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/assignees{/user}","branches_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/branches{/branch}","tags_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/tags","blobs_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/languages","stargazers_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/stargazers","contributors_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/contributors","subscribers_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/subscribers","subscription_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/subscription","commits_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/contents/{+path}","compare_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/merges","archive_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/downloads","issues_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/issues{/number}","pulls_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/labels{/name}","releases_url":"https://api.github.com/repos/dan-c-underwood/fish-shell/releases{/id}","created_at":"2015-09-02T19:29:33Z","updated_at":"2015-09-02T19:29:36Z","pushed_at":"2015-09-27T19:16:06Z","git_url":"git://github.com/dan-c-underwood/fish-shell.git","ssh_url":"git@github.com:dan-c-underwood/fish-shell.git","clone_url":"https://github.com/dan-c-underwood/fish-shell.git","svn_url":"https://github.com/dan-c-underwood/fish-shell","homepage":"http://fishshell.com","size":25330,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fish-shell:master","ref":"master","sha":"aa37b40d934a613a9cd3772ddf10cf7d24d5a0a9","user":{"login":"fish-shell","id":1828073,"avatar_url":"https://avatars.githubusercontent.com/u/1828073?v=3","gravatar_id":"","url":"https://api.github.com/users/fish-shell","html_url":"https://github.com/fish-shell","followers_url":"https://api.github.com/users/fish-shell/followers","following_url":"https://api.github.com/users/fish-shell/following{/other_user}","gists_url":"https://api.github.com/users/fish-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/fish-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fish-shell/subscriptions","organizations_url":"https://api.github.com/users/fish-shell/orgs","repos_url":"https://api.github.com/users/fish-shell/repos","events_url":"https://api.github.com/users/fish-shell/events{/privacy}","received_events_url":"https://api.github.com/users/fish-shell/received_events","type":"Organization","site_admin":false},"repo":{"id":4279682,"name":"fish-shell","full_name":"fish-shell/fish-shell","owner":{"login":"fish-shell","id":1828073,"avatar_url":"https://avatars.githubusercontent.com/u/1828073?v=3","gravatar_id":"","url":"https://api.github.com/users/fish-shell","html_url":"https://github.com/fish-shell","followers_url":"https://api.github.com/users/fish-shell/followers","following_url":"https://api.github.com/users/fish-shell/following{/other_user}","gists_url":"https://api.github.com/users/fish-shell/gists{/gist_id}","starred_url":"https://api.github.com/users/fish-shell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fish-shell/subscriptions","organizations_url":"https://api.github.com/users/fish-shell/orgs","repos_url":"https://api.github.com/users/fish-shell/repos","events_url":"https://api.github.com/users/fish-shell/events{/privacy}","received_events_url":"https://api.github.com/users/fish-shell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fish-shell/fish-shell","description":"The user-friendly command line shell.","fork":false,"url":"https://api.github.com/repos/fish-shell/fish-shell","forks_url":"https://api.github.com/repos/fish-shell/fish-shell/forks","keys_url":"https://api.github.com/repos/fish-shell/fish-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fish-shell/fish-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fish-shell/fish-shell/teams","hooks_url":"https://api.github.com/repos/fish-shell/fish-shell/hooks","issue_events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/events{/number}","events_url":"https://api.github.com/repos/fish-shell/fish-shell/events","assignees_url":"https://api.github.com/repos/fish-shell/fish-shell/assignees{/user}","branches_url":"https://api.github.com/repos/fish-shell/fish-shell/branches{/branch}","tags_url":"https://api.github.com/repos/fish-shell/fish-shell/tags","blobs_url":"https://api.github.com/repos/fish-shell/fish-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fish-shell/fish-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fish-shell/fish-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/fish-shell/fish-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fish-shell/fish-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/fish-shell/fish-shell/languages","stargazers_url":"https://api.github.com/repos/fish-shell/fish-shell/stargazers","contributors_url":"https://api.github.com/repos/fish-shell/fish-shell/contributors","subscribers_url":"https://api.github.com/repos/fish-shell/fish-shell/subscribers","subscription_url":"https://api.github.com/repos/fish-shell/fish-shell/subscription","commits_url":"https://api.github.com/repos/fish-shell/fish-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/fish-shell/fish-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/fish-shell/fish-shell/contents/{+path}","compare_url":"https://api.github.com/repos/fish-shell/fish-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fish-shell/fish-shell/merges","archive_url":"https://api.github.com/repos/fish-shell/fish-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fish-shell/fish-shell/downloads","issues_url":"https://api.github.com/repos/fish-shell/fish-shell/issues{/number}","pulls_url":"https://api.github.com/repos/fish-shell/fish-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/fish-shell/fish-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/fish-shell/fish-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/labels{/name}","releases_url":"https://api.github.com/repos/fish-shell/fish-shell/releases{/id}","created_at":"2012-05-10T03:00:55Z","updated_at":"2015-09-28T15:55:05Z","pushed_at":"2015-09-28T16:06:57Z","git_url":"git://github.com/fish-shell/fish-shell.git","ssh_url":"git@github.com:fish-shell/fish-shell.git","clone_url":"https://github.com/fish-shell/fish-shell.git","svn_url":"https://github.com/fish-shell/fish-shell","homepage":"http://fishshell.com","size":39990,"stargazers_count":4706,"watchers_count":4706,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":454,"mirror_url":null,"open_issues_count":618,"forks":454,"open_issues":618,"watchers":4706,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/2435"},"html":{"href":"https://github.com/fish-shell/fish-shell/pull/2435"},"issue":{"href":"https://api.github.com/repos/fish-shell/fish-shell/issues/2435"},"comments":{"href":"https://api.github.com/repos/fish-shell/fish-shell/issues/2435/comments"},"review_comments":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/2435/comments"},"review_comment":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fish-shell/fish-shell/pulls/2435/commits"},"statuses":{"href":"https://api.github.com/repos/fish-shell/fish-shell/statuses/374c7a43a66d18034f1765c321deafbdd1aab5fa"}}}}