{"action":"created","issue":{"url":"https://api.github.com/repos/yuanqing/gulp-tape/issues/11","labels_url":"https://api.github.com/repos/yuanqing/gulp-tape/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/yuanqing/gulp-tape/issues/11/comments","events_url":"https://api.github.com/repos/yuanqing/gulp-tape/issues/11/events","html_url":"https://github.com/yuanqing/gulp-tape/pull/11","id":119260335,"number":11,"title":"End the stream created when done","user":{"login":"zoubin","id":2097644,"avatar_url":"https://avatars.githubusercontent.com/u/2097644?v=3","gravatar_id":"","url":"https://api.github.com/users/zoubin","html_url":"https://github.com/zoubin","followers_url":"https://api.github.com/users/zoubin/followers","following_url":"https://api.github.com/users/zoubin/following{/other_user}","gists_url":"https://api.github.com/users/zoubin/gists{/gist_id}","starred_url":"https://api.github.com/users/zoubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoubin/subscriptions","organizations_url":"https://api.github.com/users/zoubin/orgs","repos_url":"https://api.github.com/users/zoubin/repos","events_url":"https://api.github.com/users/zoubin/events{/privacy}","received_events_url":"https://api.github.com/users/zoubin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-11-28T00:43:47Z","updated_at":"2015-11-30T14:32:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/yuanqing/gulp-tape/pulls/11","html_url":"https://github.com/yuanqing/gulp-tape/pull/11","diff_url":"https://github.com/yuanqing/gulp-tape/pull/11.diff","patch_url":"https://github.com/yuanqing/gulp-tape/pull/11.patch"},"body":"Fix #10 and #8 \r\n\r\nThe reason why the test task never ends in watch mode, is that `tape.getHarness()._tests.length` increases each time the test task finishes. So from the second time, it never ends.\r\n\r\nI end the tape output when tests are done, so that the reporter output will come before the gulp task messages and they won't mess.\r\nHowever, the reporter will never receive messages created when `results.close` called. So I push them manually. \r\n\r\nI'm not quite sure whether we should end the tape output and push the extra messages.\r\nWhat do you say? @yuanqing "},"comment":{"url":"https://api.github.com/repos/yuanqing/gulp-tape/issues/comments/160646173","html_url":"https://github.com/yuanqing/gulp-tape/pull/11#issuecomment-160646173","issue_url":"https://api.github.com/repos/yuanqing/gulp-tape/issues/11","id":160646173,"user":{"login":"yuanqing","id":3170842,"avatar_url":"https://avatars.githubusercontent.com/u/3170842?v=3","gravatar_id":"","url":"https://api.github.com/users/yuanqing","html_url":"https://github.com/yuanqing","followers_url":"https://api.github.com/users/yuanqing/followers","following_url":"https://api.github.com/users/yuanqing/following{/other_user}","gists_url":"https://api.github.com/users/yuanqing/gists{/gist_id}","starred_url":"https://api.github.com/users/yuanqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuanqing/subscriptions","organizations_url":"https://api.github.com/users/yuanqing/orgs","repos_url":"https://api.github.com/users/yuanqing/repos","events_url":"https://api.github.com/users/yuanqing/events{/privacy}","received_events_url":"https://api.github.com/users/yuanqing/received_events","type":"User","site_admin":false},"created_at":"2015-11-30T14:32:59Z","updated_at":"2015-11-30T14:32:59Z","body":"@zoubin Am OK with merging this and cutting a `0.0.7` until we can find a better solution "}}