{"action":"created","comment":{"url":"https://api.github.com/repos/taskcluster/taskcluster-loader/pulls/comments/41457119","id":41457119,"diff_hunk":"@@ -8,8 +8,7 @@\n   },\n   \"scripts\": {\n     \"test\": \"./test/runtests.sh\",\n-    \"compile\": \"rm -rf lib/ && ./node_modules/.bin/babel -sd lib/ src/\",\n-    \"pretest\": \"npm run compile\",","path":"package.json","position":5,"original_position":5,"commit_id":"c1f51d11fa623d4214c9c5ce194e33fc7f773c9c","original_commit_id":"c1f51d11fa623d4214c9c5ce194e33fc7f773c9c","user":{"login":"jonasfj","id":149732,"avatar_url":"https://avatars.githubusercontent.com/u/149732?v=3","gravatar_id":"","url":"https://api.github.com/users/jonasfj","html_url":"https://github.com/jonasfj","followers_url":"https://api.github.com/users/jonasfj/followers","following_url":"https://api.github.com/users/jonasfj/following{/other_user}","gists_url":"https://api.github.com/users/jonasfj/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasfj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasfj/subscriptions","organizations_url":"https://api.github.com/users/jonasfj/orgs","repos_url":"https://api.github.com/users/jonasfj/repos","events_url":"https://api.github.com/users/jonasfj/events{/privacy}","received_events_url":"https://api.github.com/users/jonasfj/received_events","type":"User","site_admin":false},"body":"So, the only reason to use this is to make sure the target works.\r\n\r\nWe have to use mocha.opts with `--compilers js:babel/register` or the test file itself would have to be compiled...\r\n\r\nNote, `--compilers js:babel/register` is not the same as `babel-node` it doesn't start a subprocess, just overloads the `require` function (I think)... I haven't had issues with it so far, I also (hope) it caches a little bit... But our compile step certainly doesn't cache anything, so...\r\n\r\nI think there's value to not dealing with compile for the tests, as we need to use this for loading the test file anyways.","created_at":"2015-10-07T22:38:26Z","updated_at":"2015-10-07T22:38:26Z","html_url":"https://github.com/taskcluster/taskcluster-loader/pull/2#discussion_r41457119","pull_request_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-loader/pulls/comments/41457119"},"html":{"href":"https://github.com/taskcluster/taskcluster-loader/pull/2#discussion_r41457119"},"pull_request":{"href":"https://api.github.com/repos/taskcluster/taskcluster-loader/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/taskcluster/taskcluster-loader/pulls/2","id":47091365,"html_url":"https://github.com/taskcluster/taskcluster-loader/pull/2","diff_url":"https://github.com/taskcluster/taskcluster-loader/pull/2.diff","patch_url":"https://github.com/taskcluster/taskcluster-loader/pull/2.patch","issue_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/issues/2","number":2,"state":"open","locked":false,"title":"slightly different approach...","user":{"login":"jonasfj","id":149732,"avatar_url":"https://avatars.githubusercontent.com/u/149732?v=3","gravatar_id":"","url":"https://api.github.com/users/jonasfj","html_url":"https://github.com/jonasfj","followers_url":"https://api.github.com/users/jonasfj/followers","following_url":"https://api.github.com/users/jonasfj/following{/other_user}","gists_url":"https://api.github.com/users/jonasfj/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasfj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasfj/subscriptions","organizations_url":"https://api.github.com/users/jonasfj/orgs","repos_url":"https://api.github.com/users/jonasfj/repos","events_url":"https://api.github.com/users/jonasfj/events{/privacy}","received_events_url":"https://api.github.com/users/jonasfj/received_events","type":"User","site_admin":false},"body":"@jhford, you're right about babelrc not being read right...\r\n\r\nBut:\r\n> \"compile\": \"rm -rf lib/ && babel -sd lib/ src/\",\r\n\r\nworks fine... Try using `which babel` in there... maybe you just didn't have babel installed in the folder for some reason...\r\n\r\n\r\n--------------\r\nI was very tempted to do more crazy stuff in this PR... But decided that we're probably better off aiming at the bare minimum that we can both agree on...\r\n\r\nI'm still open to doing the position arguments for `setup`, but I'm also okay leaving as something we can do in a wrapper... Not a wrapper for `base.loader` but in some auxiliary function that helps you wrap create a component loader...\r\n\r\n\r\nRegarding the virtual components... I think this proposal is very robust because  we have a lot of upfront checks... IMO, if we have special component loaders that are only used in tests, we can still include them in the default `components.js` file because `server.js` won't load them...\r\n\r\nOr we can support the kind of additional component loaders you proposed later if we have solid use-cases for it. I hope we won't. So I've tried to keep this minimalistic.\r\n\r\n\r\n\r\n----\r\nIf you like the idea of giving `setup` positional arguments instead of a `deps` dictionary, let me know, and I'll it... it's unfortunately something we can easily add support for in the future...\r\n\r\nhmm.. Actually in the future we can just say that a component loader must implement either `setup` or `setup2` if we want to change the calling convention... Granted we would probably give the new a better name than `setup2` :)","created_at":"2015-10-07T22:34:38Z","updated_at":"2015-10-07T22:38:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba0351776f3859fa8287901fa4cf4846fbded587","assignee":{"login":"jhford","id":607353,"avatar_url":"https://avatars.githubusercontent.com/u/607353?v=3","gravatar_id":"","url":"https://api.github.com/users/jhford","html_url":"https://github.com/jhford","followers_url":"https://api.github.com/users/jhford/followers","following_url":"https://api.github.com/users/jhford/following{/other_user}","gists_url":"https://api.github.com/users/jhford/gists{/gist_id}","starred_url":"https://api.github.com/users/jhford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhford/subscriptions","organizations_url":"https://api.github.com/users/jhford/orgs","repos_url":"https://api.github.com/users/jhford/repos","events_url":"https://api.github.com/users/jhford/events{/privacy}","received_events_url":"https://api.github.com/users/jhford/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/pulls/2/commits","review_comments_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/pulls/2/comments","review_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/issues/2/comments","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/statuses/c1f51d11fa623d4214c9c5ce194e33fc7f773c9c","head":{"label":"taskcluster:avoid-await","ref":"avoid-await","sha":"c1f51d11fa623d4214c9c5ce194e33fc7f773c9c","user":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":43303403,"name":"taskcluster-loader","full_name":"taskcluster/taskcluster-loader","owner":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/taskcluster-loader","description":"A Component Loader for Taskcluster","fork":false,"url":"https://api.github.com/repos/taskcluster/taskcluster-loader","forks_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/forks","keys_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/teams","hooks_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/events","assignees_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/tags","blobs_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/languages","stargazers_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/subscription","commits_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/merges","archive_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/downloads","issues_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/releases{/id}","created_at":"2015-09-28T13:43:55Z","updated_at":"2015-10-02T19:47:28Z","pushed_at":"2015-10-07T22:34:39Z","git_url":"git://github.com/taskcluster/taskcluster-loader.git","ssh_url":"git@github.com:taskcluster/taskcluster-loader.git","clone_url":"https://github.com/taskcluster/taskcluster-loader.git","svn_url":"https://github.com/taskcluster/taskcluster-loader","homepage":null,"size":156,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"taskcluster:first-version","ref":"first-version","sha":"fc2f2e3db7f4ef3d626b39331460650039c65065","user":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":43303403,"name":"taskcluster-loader","full_name":"taskcluster/taskcluster-loader","owner":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars.githubusercontent.com/u/6257436?v=3","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/taskcluster-loader","description":"A Component Loader for Taskcluster","fork":false,"url":"https://api.github.com/repos/taskcluster/taskcluster-loader","forks_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/forks","keys_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/teams","hooks_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/events","assignees_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/tags","blobs_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/languages","stargazers_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/subscription","commits_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/merges","archive_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/downloads","issues_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/taskcluster-loader/releases{/id}","created_at":"2015-09-28T13:43:55Z","updated_at":"2015-10-02T19:47:28Z","pushed_at":"2015-10-07T22:34:39Z","git_url":"git://github.com/taskcluster/taskcluster-loader.git","ssh_url":"git@github.com:taskcluster/taskcluster-loader.git","clone_url":"https://github.com/taskcluster/taskcluster-loader.git","svn_url":"https://github.com/taskcluster/taskcluster-loader","homepage":null,"size":156,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-loader/pulls/2"},"html":{"href":"https://github.com/taskcluster/taskcluster-loader/pull/2"},"issue":{"href":"https://api.github.com/repos/taskcluster/taskcluster-loader/issues/2"},"comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-loader/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-loader/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/taskcluster/taskcluster-loader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/taskcluster/taskcluster-loader/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/taskcluster/taskcluster-loader/statuses/c1f51d11fa623d4214c9c5ce194e33fc7f773c9c"}}}}