{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-crowbar/pulls/comments/43479588","id":43479588,"diff_hunk":"@@ -118,6 +93,13 @@ def json2hash(file_name)\n       ret\n     end\n \n+    # read given yaml file and return the content as a map\n+    def yaml2hash(file_name)\n+      ret = YAML.load(File.read(file_name))","path":"src/modules/Crowbar.rb","position":61,"original_position":61,"commit_id":"ec846b0fe65bf7ea31133ec2494e44dfaa0ba9da","original_commit_id":"ec846b0fe65bf7ea31133ec2494e44dfaa0ba9da","user":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"body":"Hm, this fills nils for url's. Wondering if\r\n1. we should have empty string values in /opt/dell/crowbar_framework/config/repos-cloud.yml\r\n2. we should convert nils to empty strings in yaml2hash\r\n3. we should treat nils in the UI the same way we treat empty string (this might be easiest, but I'm not sure if correct)","created_at":"2015-10-30T08:09:24Z","updated_at":"2015-10-30T08:09:24Z","html_url":"https://github.com/yast/yast-crowbar/pull/35#discussion_r43479588","pull_request_url":"https://api.github.com/repos/yast/yast-crowbar/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-crowbar/pulls/comments/43479588"},"html":{"href":"https://github.com/yast/yast-crowbar/pull/35#discussion_r43479588"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-crowbar/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-crowbar/pulls/35","id":48804243,"html_url":"https://github.com/yast/yast-crowbar/pull/35","diff_url":"https://github.com/yast/yast-crowbar/pull/35.diff","patch_url":"https://github.com/yast/yast-crowbar/pull/35.patch","issue_url":"https://api.github.com/repos/yast/yast-crowbar/issues/35","number":35,"state":"open","locked":false,"title":"Load and write yaml files for repositories","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"This makes the crowbar module be able to deal with yaml files, as this is what is now used since https://github.com/crowbar/crowbar-core/pull/18 and https://github.com/crowbar/crowbar-core/pull/102","created_at":"2015-10-26T22:08:12Z","updated_at":"2015-10-30T08:09:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fd46d1388c9d6de3f12613377d6844de2d5651f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-crowbar/pulls/35/commits","review_comments_url":"https://api.github.com/repos/yast/yast-crowbar/pulls/35/comments","review_comment_url":"https://api.github.com/repos/yast/yast-crowbar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-crowbar/issues/35/comments","statuses_url":"https://api.github.com/repos/yast/yast-crowbar/statuses/ec846b0fe65bf7ea31133ec2494e44dfaa0ba9da","head":{"label":"vuntz:yaml-repos","ref":"yaml-repos","sha":"ec846b0fe65bf7ea31133ec2494e44dfaa0ba9da","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"repo":{"id":11471640,"name":"yast-crowbar","full_name":"vuntz/yast-crowbar","owner":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vuntz/yast-crowbar","description":"","fork":true,"url":"https://api.github.com/repos/vuntz/yast-crowbar","forks_url":"https://api.github.com/repos/vuntz/yast-crowbar/forks","keys_url":"https://api.github.com/repos/vuntz/yast-crowbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuntz/yast-crowbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuntz/yast-crowbar/teams","hooks_url":"https://api.github.com/repos/vuntz/yast-crowbar/hooks","issue_events_url":"https://api.github.com/repos/vuntz/yast-crowbar/issues/events{/number}","events_url":"https://api.github.com/repos/vuntz/yast-crowbar/events","assignees_url":"https://api.github.com/repos/vuntz/yast-crowbar/assignees{/user}","branches_url":"https://api.github.com/repos/vuntz/yast-crowbar/branches{/branch}","tags_url":"https://api.github.com/repos/vuntz/yast-crowbar/tags","blobs_url":"https://api.github.com/repos/vuntz/yast-crowbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuntz/yast-crowbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuntz/yast-crowbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuntz/yast-crowbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuntz/yast-crowbar/statuses/{sha}","languages_url":"https://api.github.com/repos/vuntz/yast-crowbar/languages","stargazers_url":"https://api.github.com/repos/vuntz/yast-crowbar/stargazers","contributors_url":"https://api.github.com/repos/vuntz/yast-crowbar/contributors","subscribers_url":"https://api.github.com/repos/vuntz/yast-crowbar/subscribers","subscription_url":"https://api.github.com/repos/vuntz/yast-crowbar/subscription","commits_url":"https://api.github.com/repos/vuntz/yast-crowbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuntz/yast-crowbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuntz/yast-crowbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuntz/yast-crowbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuntz/yast-crowbar/contents/{+path}","compare_url":"https://api.github.com/repos/vuntz/yast-crowbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuntz/yast-crowbar/merges","archive_url":"https://api.github.com/repos/vuntz/yast-crowbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuntz/yast-crowbar/downloads","issues_url":"https://api.github.com/repos/vuntz/yast-crowbar/issues{/number}","pulls_url":"https://api.github.com/repos/vuntz/yast-crowbar/pulls{/number}","milestones_url":"https://api.github.com/repos/vuntz/yast-crowbar/milestones{/number}","notifications_url":"https://api.github.com/repos/vuntz/yast-crowbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuntz/yast-crowbar/labels{/name}","releases_url":"https://api.github.com/repos/vuntz/yast-crowbar/releases{/id}","created_at":"2013-07-17T08:56:01Z","updated_at":"2014-09-09T12:46:08Z","pushed_at":"2015-10-27T23:52:22Z","git_url":"git://github.com/vuntz/yast-crowbar.git","ssh_url":"git@github.com:vuntz/yast-crowbar.git","clone_url":"https://github.com/vuntz/yast-crowbar.git","svn_url":"https://github.com/vuntz/yast-crowbar","homepage":null,"size":348,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"497058b27731e11a226289d8d4aa24f9f31505e6","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4635428,"name":"yast-crowbar","full_name":"yast/yast-crowbar","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-crowbar","description":"","fork":false,"url":"https://api.github.com/repos/yast/yast-crowbar","forks_url":"https://api.github.com/repos/yast/yast-crowbar/forks","keys_url":"https://api.github.com/repos/yast/yast-crowbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-crowbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-crowbar/teams","hooks_url":"https://api.github.com/repos/yast/yast-crowbar/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-crowbar/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-crowbar/events","assignees_url":"https://api.github.com/repos/yast/yast-crowbar/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-crowbar/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-crowbar/tags","blobs_url":"https://api.github.com/repos/yast/yast-crowbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-crowbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-crowbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-crowbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-crowbar/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-crowbar/languages","stargazers_url":"https://api.github.com/repos/yast/yast-crowbar/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-crowbar/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-crowbar/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-crowbar/subscription","commits_url":"https://api.github.com/repos/yast/yast-crowbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-crowbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-crowbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-crowbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-crowbar/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-crowbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-crowbar/merges","archive_url":"https://api.github.com/repos/yast/yast-crowbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-crowbar/downloads","issues_url":"https://api.github.com/repos/yast/yast-crowbar/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-crowbar/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-crowbar/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-crowbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-crowbar/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-crowbar/releases{/id}","created_at":"2012-06-12T09:20:44Z","updated_at":"2015-04-17T07:42:46Z","pushed_at":"2015-10-27T23:28:02Z","git_url":"git://github.com/yast/yast-crowbar.git","ssh_url":"git@github.com:yast/yast-crowbar.git","clone_url":"https://github.com/yast/yast-crowbar.git","svn_url":"https://github.com/yast/yast-crowbar","homepage":null,"size":722,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-crowbar/pulls/35"},"html":{"href":"https://github.com/yast/yast-crowbar/pull/35"},"issue":{"href":"https://api.github.com/repos/yast/yast-crowbar/issues/35"},"comments":{"href":"https://api.github.com/repos/yast/yast-crowbar/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-crowbar/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-crowbar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-crowbar/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-crowbar/statuses/ec846b0fe65bf7ea31133ec2494e44dfaa0ba9da"}}}}