{"action":"created","issue":{"url":"https://api.github.com/repos/01org/parameter-framework/issues/294","labels_url":"https://api.github.com/repos/01org/parameter-framework/issues/294/labels{/name}","comments_url":"https://api.github.com/repos/01org/parameter-framework/issues/294/comments","events_url":"https://api.github.com/repos/01org/parameter-framework/issues/294/events","html_url":"https://github.com/01org/parameter-framework/pull/294","id":112760457,"number":294,"title":"[review] Virtual subsystem back synchronization","user":{"login":"tcahuzax","id":11178583,"avatar_url":"https://avatars.githubusercontent.com/u/11178583?v=3","gravatar_id":"","url":"https://api.github.com/users/tcahuzax","html_url":"https://github.com/tcahuzax","followers_url":"https://api.github.com/users/tcahuzax/followers","following_url":"https://api.github.com/users/tcahuzax/following{/other_user}","gists_url":"https://api.github.com/users/tcahuzax/gists{/gist_id}","starred_url":"https://api.github.com/users/tcahuzax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcahuzax/subscriptions","organizations_url":"https://api.github.com/users/tcahuzax/orgs","repos_url":"https://api.github.com/users/tcahuzax/repos","events_url":"https://api.github.com/users/tcahuzax/events{/privacy}","received_events_url":"https://api.github.com/users/tcahuzax/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-22T09:02:35Z","updated_at":"2015-10-22T12:55:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/01org/parameter-framework/pulls/294","html_url":"https://github.com/01org/parameter-framework/pull/294","diff_url":"https://github.com/01org/parameter-framework/pull/294.diff","patch_url":"https://github.com/01org/parameter-framework/pull/294.patch"},"body":"The problem:\r\nInital values of virtual susbsystem parameters in the blackboard may be\r\nincorrect with respect to their type defintion. This may lead to situations\r\nwhere it's impossible to import settings which were previously exported.\r\n\r\nThe reason:\r\nBackward synchronization process occuring at start time ensures a proper\r\ninitialization of the blackboard by collecting all the syncers and\r\ntriggering a back synchronization on them. Only, the syncer set collection\r\nwas not properly implemented in Virtual Subsystem, meaning that its syncer\r\nwas not collected.\r\n\r\nThis patch ensures that the virtual subsystem syncer (called virtual\r\nsyncer) gets properly collected when filling the syncer set at\r\nConfigurableElement ancestor class level, by implementing the\r\nfillSyncerSetFromDescendant() virtual method at its level.\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/01org/parameter-framework/pull/294%23issuecomment-150155250%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/294%23discussion_r42728351%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/294%23discussion_r42731063%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/294%23issuecomment-150169262%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/294%23issuecomment-150155250%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%20%22%2C%20%22created_at%22%3A%20%222015-10-22T09%3A03%3A28Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/11178583%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/tcahuzax%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%20%22%2C%20%22created_at%22%3A%20%222015-10-22T10%3A13%3A08Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/11178583%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/tcahuzax%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%20ea00c754d6ef72b4b853b135257dcff67d57256c%20parameter/VirtualSubsystem.h%2010%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/294%23discussion_r42728351%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22override%20final%20%3F%22%2C%20%22created_at%22%3A%20%222015-10-22T09%3A38%3A15Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6862950%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/krocard%22%7D%7D%2C%20%7B%22body%22%3A%20%22done%22%2C%20%22created_at%22%3A%20%222015-10-22T10%3A12%3A31Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/11178583%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/tcahuzax%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20parameter/VirtualSubsystem.h%3AL50-63%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-Pull ea00c754d6ef72b4b853b135257dcff67d57256c parameter/VirtualSubsystem.h 10'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/294#discussion_r42728351'>File: parameter/VirtualSubsystem.h:L50-63</a></b>\n- <a href='https://github.com/krocard'><img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'></a> override final ?\n- <a href='https://github.com/tcahuzax'><img border=0 src='https://avatars.githubusercontent.com/u/11178583?v=3' height=16 width=16'></a> done\n\n\n<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/294?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/294?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/01org/parameter-framework/pull/294'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>"},"comment":{"url":"https://api.github.com/repos/01org/parameter-framework/issues/comments/150211113","html_url":"https://github.com/01org/parameter-framework/pull/294#issuecomment-150211113","issue_url":"https://api.github.com/repos/01org/parameter-framework/issues/294","id":150211113,"user":{"login":"krocard","id":6862950,"avatar_url":"https://avatars.githubusercontent.com/u/6862950?v=3","gravatar_id":"","url":"https://api.github.com/users/krocard","html_url":"https://github.com/krocard","followers_url":"https://api.github.com/users/krocard/followers","following_url":"https://api.github.com/users/krocard/following{/other_user}","gists_url":"https://api.github.com/users/krocard/gists{/gist_id}","starred_url":"https://api.github.com/users/krocard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krocard/subscriptions","organizations_url":"https://api.github.com/users/krocard/orgs","repos_url":"https://api.github.com/users/krocard/repos","events_url":"https://api.github.com/users/krocard/events{/privacy}","received_events_url":"https://api.github.com/users/krocard/received_events","type":"User","site_admin":false},"created_at":"2015-10-22T12:55:10Z","updated_at":"2015-10-22T12:55:10Z","body":":shipit: "}}