{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/pulls/comments/47037354","id":47037354,"diff_hunk":"@@ -397,20 +396,10 @@\n     },\n \n     _onCaptureClick: function(event) {\n-      // attempt to close asynchronously and prevent the close of a tap event is immediately heard\n-      // on target. This is because in shadow dom due to event retargetting event.target is not\n-      // useful.\n-      if (!this.noCancelOnOutsideClick && (this._manager.currentOverlay() == this)) {\n-        this._cancelJob = this.async(function() {\n-          this.cancel();\n-        }, 10);\n-      }\n-    },\n-\n-    _onClick: function(event) {\n-      if (this._cancelJob) {\n-        this.cancelAsync(this._cancelJob);\n-        this._cancelJob = null;\n+      if (Polymer.dom(event).path.indexOf(this) === -1 &&","path":"iron-overlay-behavior.html","position":null,"original_position":26,"commit_id":"05b714d8872371b40b342d20228e41ace6c9ccea","original_commit_id":"c4ba68d0120fc4571bb49d298ec47a36c7fedf49","user":{"login":"bicknellr","id":406614,"avatar_url":"https://avatars.githubusercontent.com/u/406614?v=3","gravatar_id":"","url":"https://api.github.com/users/bicknellr","html_url":"https://github.com/bicknellr","followers_url":"https://api.github.com/users/bicknellr/followers","following_url":"https://api.github.com/users/bicknellr/following{/other_user}","gists_url":"https://api.github.com/users/bicknellr/gists{/gist_id}","starred_url":"https://api.github.com/users/bicknellr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bicknellr/subscriptions","organizations_url":"https://api.github.com/users/bicknellr/orgs","repos_url":"https://api.github.com/users/bicknellr/repos","events_url":"https://api.github.com/users/bicknellr/events{/privacy}","received_events_url":"https://api.github.com/users/bicknellr/received_events","type":"User","site_admin":false},"body":"Makes sense; updated.","created_at":"2015-12-09T00:37:20Z","updated_at":"2015-12-09T00:37:20Z","html_url":"https://github.com/PolymerElements/iron-overlay-behavior/pull/64#discussion_r47037354","pull_request_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/pulls/comments/47037354"},"html":{"href":"https://github.com/PolymerElements/iron-overlay-behavior/pull/64#discussion_r47037354"},"pull_request":{"href":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/pulls/64","id":53028357,"html_url":"https://github.com/PolymerElements/iron-overlay-behavior/pull/64","diff_url":"https://github.com/PolymerElements/iron-overlay-behavior/pull/64.diff","patch_url":"https://github.com/PolymerElements/iron-overlay-behavior/pull/64.patch","issue_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/issues/64","number":64,"state":"open","locked":false,"title":"IronOverlayBehavior no longer needs click events to bubble to determine when to close.","user":{"login":"bicknellr","id":406614,"avatar_url":"https://avatars.githubusercontent.com/u/406614?v=3","gravatar_id":"","url":"https://api.github.com/users/bicknellr","html_url":"https://github.com/bicknellr","followers_url":"https://api.github.com/users/bicknellr/followers","following_url":"https://api.github.com/users/bicknellr/following{/other_user}","gists_url":"https://api.github.com/users/bicknellr/gists{/gist_id}","starred_url":"https://api.github.com/users/bicknellr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bicknellr/subscriptions","organizations_url":"https://api.github.com/users/bicknellr/orgs","repos_url":"https://api.github.com/users/bicknellr/repos","events_url":"https://api.github.com/users/bicknellr/events{/privacy}","received_events_url":"https://api.github.com/users/bicknellr/received_events","type":"User","site_admin":false},"body":"Fixes PolymerElements/iron-menu-behavior#40.","created_at":"2015-12-08T19:44:32Z","updated_at":"2015-12-09T00:37:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9dfb8730ab37768cbeba9bbc232d42d037ad4188","assignee":{"login":"cdata","id":240083,"avatar_url":"https://avatars.githubusercontent.com/u/240083?v=3","gravatar_id":"","url":"https://api.github.com/users/cdata","html_url":"https://github.com/cdata","followers_url":"https://api.github.com/users/cdata/followers","following_url":"https://api.github.com/users/cdata/following{/other_user}","gists_url":"https://api.github.com/users/cdata/gists{/gist_id}","starred_url":"https://api.github.com/users/cdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdata/subscriptions","organizations_url":"https://api.github.com/users/cdata/orgs","repos_url":"https://api.github.com/users/cdata/repos","events_url":"https://api.github.com/users/cdata/events{/privacy}","received_events_url":"https://api.github.com/users/cdata/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/pulls/64/commits","review_comments_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/pulls/64/comments","review_comment_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/issues/64/comments","statuses_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/statuses/05b714d8872371b40b342d20228e41ace6c9ccea","head":{"label":"PolymerElements:bicknellr/iron-menu-behavior-40","ref":"bicknellr/iron-menu-behavior-40","sha":"05b714d8872371b40b342d20228e41ace6c9ccea","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":34762920,"name":"iron-overlay-behavior","full_name":"PolymerElements/iron-overlay-behavior","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/iron-overlay-behavior","description":"Makes an element an overlay with an optional backdrop","fork":false,"url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior","forks_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/forks","keys_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/teams","hooks_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/events","assignees_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/tags","blobs_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/subscription","commits_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/merges","archive_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/downloads","issues_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/releases{/id}","created_at":"2015-04-29T00:18:57Z","updated_at":"2015-11-16T09:44:46Z","pushed_at":"2015-12-09T00:37:01Z","git_url":"git://github.com/PolymerElements/iron-overlay-behavior.git","ssh_url":"git@github.com:PolymerElements/iron-overlay-behavior.git","clone_url":"https://github.com/PolymerElements/iron-overlay-behavior.git","svn_url":"https://github.com/PolymerElements/iron-overlay-behavior","homepage":null,"size":105,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":14,"forks":9,"open_issues":14,"watchers":2,"default_branch":"master"}},"base":{"label":"PolymerElements:master","ref":"master","sha":"3f3bcd93108acbd7f781bb1eb2c2f43bba3c04df","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":34762920,"name":"iron-overlay-behavior","full_name":"PolymerElements/iron-overlay-behavior","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/iron-overlay-behavior","description":"Makes an element an overlay with an optional backdrop","fork":false,"url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior","forks_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/forks","keys_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/teams","hooks_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/events","assignees_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/tags","blobs_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/subscription","commits_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/merges","archive_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/downloads","issues_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/releases{/id}","created_at":"2015-04-29T00:18:57Z","updated_at":"2015-11-16T09:44:46Z","pushed_at":"2015-12-09T00:37:01Z","git_url":"git://github.com/PolymerElements/iron-overlay-behavior.git","ssh_url":"git@github.com:PolymerElements/iron-overlay-behavior.git","clone_url":"https://github.com/PolymerElements/iron-overlay-behavior.git","svn_url":"https://github.com/PolymerElements/iron-overlay-behavior","homepage":null,"size":105,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":14,"forks":9,"open_issues":14,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/pulls/64"},"html":{"href":"https://github.com/PolymerElements/iron-overlay-behavior/pull/64"},"issue":{"href":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/issues/64"},"comments":{"href":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerElements/iron-overlay-behavior/statuses/05b714d8872371b40b342d20228e41ace6c9ccea"}}}}