{"action":"created","issue":{"url":"https://api.github.com/repos/mtat76/exscalabar/issues/16","labels_url":"https://api.github.com/repos/mtat76/exscalabar/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/mtat76/exscalabar/issues/16/comments","events_url":"https://api.github.com/repos/mtat76/exscalabar/issues/16/events","html_url":"https://github.com/mtat76/exscalabar/pull/16","id":91703886,"number":16,"title":"Plotting with canvas.js","user":{"login":"danbek","id":1841132,"avatar_url":"https://avatars.githubusercontent.com/u/1841132?v=3","gravatar_id":"","url":"https://api.github.com/users/danbek","html_url":"https://github.com/danbek","followers_url":"https://api.github.com/users/danbek/followers","following_url":"https://api.github.com/users/danbek/following{/other_user}","gists_url":"https://api.github.com/users/danbek/gists{/gist_id}","starred_url":"https://api.github.com/users/danbek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbek/subscriptions","organizations_url":"https://api.github.com/users/danbek/orgs","repos_url":"https://api.github.com/users/danbek/repos","events_url":"https://api.github.com/users/danbek/events{/privacy}","received_events_url":"https://api.github.com/users/danbek/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-29T05:54:53Z","updated_at":"2015-07-10T21:21:10Z","closed_at":"2015-07-09T18:09:35Z","pull_request":{"url":"https://api.github.com/repos/mtat76/exscalabar/pulls/16","html_url":"https://github.com/mtat76/exscalabar/pull/16","diff_url":"https://github.com/mtat76/exscalabar/pull/16.diff","patch_url":"https://github.com/mtat76/exscalabar/pull/16.patch"},"body":"Matt,\r\n\r\nCreate a new branch (I used try-canvas.js), accept this request into it, and check out canvas.js\r\n\r\nIn terms of performance, it's not as good as flot, but still better than nvd3 on chrome. I see no evidence of memory leaks after letting it run for a good long while (over 1 hour).\r\n\r\nTurning on/off data series via clicking in the legend works very nicely, and it seems to play nicer with bootstrap than flot does. The documentation is excellent, very easy to use. Should be no problem to add your right-click menus.\r\n\r\nUnless you really want the lower CPU usage from flot, I think this is the way to go.\r\n"},"comment":{"url":"https://api.github.com/repos/mtat76/exscalabar/issues/comments/120532265","html_url":"https://github.com/mtat76/exscalabar/pull/16#issuecomment-120532265","issue_url":"https://api.github.com/repos/mtat76/exscalabar/issues/16","id":120532265,"user":{"login":"danbek","id":1841132,"avatar_url":"https://avatars.githubusercontent.com/u/1841132?v=3","gravatar_id":"","url":"https://api.github.com/users/danbek","html_url":"https://github.com/danbek","followers_url":"https://api.github.com/users/danbek/followers","following_url":"https://api.github.com/users/danbek/following{/other_user}","gists_url":"https://api.github.com/users/danbek/gists{/gist_id}","starred_url":"https://api.github.com/users/danbek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbek/subscriptions","organizations_url":"https://api.github.com/users/danbek/orgs","repos_url":"https://api.github.com/users/danbek/repos","events_url":"https://api.github.com/users/danbek/events{/privacy}","received_events_url":"https://api.github.com/users/danbek/received_events","type":"User","site_admin":false},"created_at":"2015-07-10T21:21:10Z","updated_at":"2015-07-10T21:21:10Z","body":"Wow, I didn't even consider that canvas.js might not be free to use! That's\na big pain. I'm very sorry about that.\n\nI think that if you can live with the performance issues, nvd3 is probably\nthe way to go. If you can't handle the nvd3 performance, flot was plenty\nfast. It won't be as nice as nvd3 or canvas (and we need to do some work to\nget turning the data sets on and off to work), but that seems to the be the\ntradeoff that we face.\n\nDan\n\nOn Fri, Jul 10, 2015 at 11:14 AM, Matt Richardson <notifications@github.com>\nwrote:\n\n> OK...so there are a couple of issues. First, CanvasJS is a commercial\n> product, so I would likely have to buy a license, especially if I want to\n> get rid of the watermark. Second, it looks like it uses jQuery pretty\n> heavily. This is causing some problems with the context menu as $ is being\n> redefined in context menu as angular.element. I will have to see if there\n> are any other issues, but we may have to reconsider this approach.\n>\n> NVD3 looks more and more promising unfortunately...\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/mtat76/exscalabar/pull/16#issuecomment-120463257>.\n>\n\n\n\n-- \nDan Becker\n"}}