{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/smarthome/issues/483","labels_url":"https://api.github.com/repos/eclipse/smarthome/issues/483/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/smarthome/issues/483/comments","events_url":"https://api.github.com/repos/eclipse/smarthome/issues/483/events","html_url":"https://github.com/eclipse/smarthome/pull/483","id":110205628,"number":483,"title":"Preview of the LIFX binding rewritten for the V2 LIFX Firmware.  It i…","user":{"login":"kgoderis","id":5459062,"avatar_url":"https://avatars.githubusercontent.com/u/5459062?v=3","gravatar_id":"","url":"https://api.github.com/users/kgoderis","html_url":"https://github.com/kgoderis","followers_url":"https://api.github.com/users/kgoderis/followers","following_url":"https://api.github.com/users/kgoderis/following{/other_user}","gists_url":"https://api.github.com/users/kgoderis/gists{/gist_id}","starred_url":"https://api.github.com/users/kgoderis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgoderis/subscriptions","organizations_url":"https://api.github.com/users/kgoderis/orgs","repos_url":"https://api.github.com/users/kgoderis/repos","events_url":"https://api.github.com/users/kgoderis/events{/privacy}","received_events_url":"https://api.github.com/users/kgoderis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-10-07T11:34:25Z","updated_at":"2015-10-15T14:26:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/483","html_url":"https://github.com/eclipse/smarthome/pull/483","diff_url":"https://github.com/eclipse/smarthome/pull/483.diff","patch_url":"https://github.com/eclipse/smarthome/pull/483.patch"},"body":"…s based on https://github.com/timothyb89/lifx-java with that understanding that only some of the basic data structures were re-used; all the rest is rewritten from scratch. It offers the same functionality as the first iteration of the LIFX binding, but addtionnal features exposed by the LIFX bulbs could be added in the future. The protocol implementation however, is complete and in line with the LIFX LAN Protocol Specification\r\n\r\nNote: All files that are are modified, e.g. code, name, etc, carry the OH/ESH license statement. All files that were left untouched carry a reference to the original license\r\n\r\nPurpose is to review and discuss\r\n\r\nSigned-off-by: Karel Goderis <karel.goderis@me.com>"},"comment":{"url":"https://api.github.com/repos/eclipse/smarthome/issues/comments/148401818","html_url":"https://github.com/eclipse/smarthome/pull/483#issuecomment-148401818","issue_url":"https://api.github.com/repos/eclipse/smarthome/issues/483","id":148401818,"user":{"login":"kgoderis","id":5459062,"avatar_url":"https://avatars.githubusercontent.com/u/5459062?v=3","gravatar_id":"","url":"https://api.github.com/users/kgoderis","html_url":"https://github.com/kgoderis","followers_url":"https://api.github.com/users/kgoderis/followers","following_url":"https://api.github.com/users/kgoderis/following{/other_user}","gists_url":"https://api.github.com/users/kgoderis/gists{/gist_id}","starred_url":"https://api.github.com/users/kgoderis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgoderis/subscriptions","organizations_url":"https://api.github.com/users/kgoderis/orgs","repos_url":"https://api.github.com/users/kgoderis/repos","events_url":"https://api.github.com/users/kgoderis/events{/privacy}","received_events_url":"https://api.github.com/users/kgoderis/received_events","type":"User","site_admin":false},"created_at":"2015-10-15T14:26:55Z","updated_at":"2015-10-15T14:26:55Z","body":"Ok - I understand what you aim for, but Discovery works quite different than what it was before, and I intentionally stripped out any intermediate interfaces/APIs to simplify things. Going back to what it looked like before is imho not evident, and will not simplify things. As it is right now, it can also be a template for those people that need TCP or UDP communication in their bindings (there quite a few, and the \"TCP-swiss-knife\" binding will most probably not be ported). I agree that some stuff could be tucked away in private methods() to simplify it a bit, and/or move code so that the \"tutorial\" part is at the top of the .java, but marrying this with the previous stuf.... mmmm.. not sure about that. "}}