{"action":"created","issue":{"url":"https://api.github.com/repos/Valiec/DeeperCaves/issues/26","labels_url":"https://api.github.com/repos/Valiec/DeeperCaves/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/Valiec/DeeperCaves/issues/26/comments","events_url":"https://api.github.com/repos/Valiec/DeeperCaves/issues/26/events","html_url":"https://github.com/Valiec/DeeperCaves/issues/26","id":111892731,"number":26,"title":"Refactor code","user":{"login":"jjtParadox","id":1388166,"avatar_url":"https://avatars.githubusercontent.com/u/1388166?v=3","gravatar_id":"","url":"https://api.github.com/users/jjtParadox","html_url":"https://github.com/jjtParadox","followers_url":"https://api.github.com/users/jjtParadox/followers","following_url":"https://api.github.com/users/jjtParadox/following{/other_user}","gists_url":"https://api.github.com/users/jjtParadox/gists{/gist_id}","starred_url":"https://api.github.com/users/jjtParadox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjtParadox/subscriptions","organizations_url":"https://api.github.com/users/jjtParadox/orgs","repos_url":"https://api.github.com/users/jjtParadox/repos","events_url":"https://api.github.com/users/jjtParadox/events{/privacy}","received_events_url":"https://api.github.com/users/jjtParadox/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Valiec/DeeperCaves/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/Valiec/DeeperCaves/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"Valiec","id":8001115,"avatar_url":"https://avatars.githubusercontent.com/u/8001115?v=3","gravatar_id":"","url":"https://api.github.com/users/Valiec","html_url":"https://github.com/Valiec","followers_url":"https://api.github.com/users/Valiec/followers","following_url":"https://api.github.com/users/Valiec/following{/other_user}","gists_url":"https://api.github.com/users/Valiec/gists{/gist_id}","starred_url":"https://api.github.com/users/Valiec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valiec/subscriptions","organizations_url":"https://api.github.com/users/Valiec/orgs","repos_url":"https://api.github.com/users/Valiec/repos","events_url":"https://api.github.com/users/Valiec/events{/privacy}","received_events_url":"https://api.github.com/users/Valiec/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-10-16T19:07:31Z","updated_at":"2015-10-25T15:22:29Z","closed_at":null,"body":"I've noticed this mod has some code in the `net.minecraft` package ([`MaterialMoltenIron`] (https://github.com/Valiec/DeeperCaves/blob/master/src/main/java/net/minecraft/block/material/MaterialMoltenIron.java) and [`RenderDeepSpider`] (https://github.com/Valiec/DeeperCaves/blob/master/src/main/java/net/minecraft/client/renderer/entity/RenderDeepSpider.java)). Minecraft mods should never have code in the `net.minecraft` package unless they know exactly what they are doing. The two files mentioned above can easily be moved into `com.kpabr.DeeperCaves` without issue (Right-click > Refactor/Rename in most IDEs).\r\n\r\nAlso, there is a large opportunity for cleaning up the mod by putting classes in proper packages (`BiomeGen` classes in `com.kpabr.DeeperCaves.world.gen`, `Block` classes in `com.kpabr.DeeperCaves.block`, `ChunkProvider` classes in `com.kpabr.DeeperCaves.world.chunk`, etc.).\r\n\r\nPackage organization is all personal preference, but it helps greatly in making code more manageable and readable."},"comment":{"url":"https://api.github.com/repos/Valiec/DeeperCaves/issues/comments/150934510","html_url":"https://github.com/Valiec/DeeperCaves/issues/26#issuecomment-150934510","issue_url":"https://api.github.com/repos/Valiec/DeeperCaves/issues/26","id":150934510,"user":{"login":"Valiec","id":8001115,"avatar_url":"https://avatars.githubusercontent.com/u/8001115?v=3","gravatar_id":"","url":"https://api.github.com/users/Valiec","html_url":"https://github.com/Valiec","followers_url":"https://api.github.com/users/Valiec/followers","following_url":"https://api.github.com/users/Valiec/following{/other_user}","gists_url":"https://api.github.com/users/Valiec/gists{/gist_id}","starred_url":"https://api.github.com/users/Valiec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valiec/subscriptions","organizations_url":"https://api.github.com/users/Valiec/orgs","repos_url":"https://api.github.com/users/Valiec/repos","events_url":"https://api.github.com/users/Valiec/events{/privacy}","received_events_url":"https://api.github.com/users/Valiec/received_events","type":"User","site_admin":false},"created_at":"2015-10-25T15:22:29Z","updated_at":"2015-10-25T15:22:29Z","body":"I've moved the two net.minecraft* src files. I am leaving the issue open since I am still going to clean up the package hierarchy a bit more."}}