{"action":"created","comment":{"url":"https://api.github.com/repos/papertrail/remote_syslog2/pulls/comments/33826466","id":33826466,"diff_hunk":"@@ -53,6 +54,11 @@ func tailOne(file string, excludePatterns []*regexp.Regexp, logger *syslog.Logge\n // Tails files speficied in the globs and re-evaluates the globs\n // at the specified interval\n func tailFiles(globs []string, excludedFiles []*regexp.Regexp, excludePatterns []*regexp.Regexp, interval RefreshInterval, logger *syslog.Logger, severity syslog.Priority, facility syslog.Priority, poll bool) {\n+\tif len(globs) == 0 {","path":"remote_syslog.go","position":21,"original_position":21,"commit_id":"7c67e297d42270fda2e3aa8bcd290e510288a8a8","original_commit_id":"86f18aa7cf816222501da23416e19440cdffd32c","user":{"login":"leonsodhi","id":2627536,"avatar_url":"https://avatars.githubusercontent.com/u/2627536?v=3","gravatar_id":"","url":"https://api.github.com/users/leonsodhi","html_url":"https://github.com/leonsodhi","followers_url":"https://api.github.com/users/leonsodhi/followers","following_url":"https://api.github.com/users/leonsodhi/following{/other_user}","gists_url":"https://api.github.com/users/leonsodhi/gists{/gist_id}","starred_url":"https://api.github.com/users/leonsodhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonsodhi/subscriptions","organizations_url":"https://api.github.com/users/leonsodhi/orgs","repos_url":"https://api.github.com/users/leonsodhi/repos","events_url":"https://api.github.com/users/leonsodhi/events{/privacy}","received_events_url":"https://api.github.com/users/leonsodhi/received_events","type":"User","site_admin":false},"body":"Agreed that we want to error and exit if no files have been specified. My suggestion was to run the check earlier so it can be printed when daemonized. \r\n\r\nI agree with @wagerlabs that it's likely worth merging everything early on.","created_at":"2015-07-02T21:50:27Z","updated_at":"2015-07-02T21:50:27Z","html_url":"https://github.com/papertrail/remote_syslog2/pull/73#discussion_r33826466","pull_request_url":"https://api.github.com/repos/papertrail/remote_syslog2/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/papertrail/remote_syslog2/pulls/comments/33826466"},"html":{"href":"https://github.com/papertrail/remote_syslog2/pull/73#discussion_r33826466"},"pull_request":{"href":"https://api.github.com/repos/papertrail/remote_syslog2/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/papertrail/remote_syslog2/pulls/73","id":38036728,"html_url":"https://github.com/papertrail/remote_syslog2/pull/73","diff_url":"https://github.com/papertrail/remote_syslog2/pull/73.diff","patch_url":"https://github.com/papertrail/remote_syslog2/pull/73.patch","issue_url":"https://api.github.com/repos/papertrail/remote_syslog2/issues/73","number":73,"state":"open","locked":false,"title":"Validation warnings","user":{"login":"featalion","id":413108,"avatar_url":"https://avatars.githubusercontent.com/u/413108?v=3","gravatar_id":"","url":"https://api.github.com/users/featalion","html_url":"https://github.com/featalion","followers_url":"https://api.github.com/users/featalion/followers","following_url":"https://api.github.com/users/featalion/following{/other_user}","gists_url":"https://api.github.com/users/featalion/gists{/gist_id}","starred_url":"https://api.github.com/users/featalion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/featalion/subscriptions","organizations_url":"https://api.github.com/users/featalion/orgs","repos_url":"https://api.github.com/users/featalion/repos","events_url":"https://api.github.com/users/featalion/events{/privacy}","received_events_url":"https://api.github.com/users/featalion/received_events","type":"User","site_admin":false},"body":"Print configuration file validation warnings if:\r\n* no files to watch supplied\r\n* port is not defined, when host is\r\n\r\nExit with error code if no files to watch specified at all (in config and via command line).\r\n\r\nRelated to #43 ","created_at":"2015-06-18T18:22:11Z","updated_at":"2015-07-02T21:50:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"770ab643d2f80576d03d558df36339dc7f0e6e5b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/papertrail/remote_syslog2/pulls/73/commits","review_comments_url":"https://api.github.com/repos/papertrail/remote_syslog2/pulls/73/comments","review_comment_url":"https://api.github.com/repos/papertrail/remote_syslog2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/papertrail/remote_syslog2/issues/73/comments","statuses_url":"https://api.github.com/repos/papertrail/remote_syslog2/statuses/7c67e297d42270fda2e3aa8bcd290e510288a8a8","head":{"label":"featalion:fix-issue-43","ref":"fix-issue-43","sha":"7c67e297d42270fda2e3aa8bcd290e510288a8a8","user":{"login":"featalion","id":413108,"avatar_url":"https://avatars.githubusercontent.com/u/413108?v=3","gravatar_id":"","url":"https://api.github.com/users/featalion","html_url":"https://github.com/featalion","followers_url":"https://api.github.com/users/featalion/followers","following_url":"https://api.github.com/users/featalion/following{/other_user}","gists_url":"https://api.github.com/users/featalion/gists{/gist_id}","starred_url":"https://api.github.com/users/featalion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/featalion/subscriptions","organizations_url":"https://api.github.com/users/featalion/orgs","repos_url":"https://api.github.com/users/featalion/repos","events_url":"https://api.github.com/users/featalion/events{/privacy}","received_events_url":"https://api.github.com/users/featalion/received_events","type":"User","site_admin":false},"repo":{"id":37589092,"name":"remote_syslog2","full_name":"featalion/remote_syslog2","owner":{"login":"featalion","id":413108,"avatar_url":"https://avatars.githubusercontent.com/u/413108?v=3","gravatar_id":"","url":"https://api.github.com/users/featalion","html_url":"https://github.com/featalion","followers_url":"https://api.github.com/users/featalion/followers","following_url":"https://api.github.com/users/featalion/following{/other_user}","gists_url":"https://api.github.com/users/featalion/gists{/gist_id}","starred_url":"https://api.github.com/users/featalion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/featalion/subscriptions","organizations_url":"https://api.github.com/users/featalion/orgs","repos_url":"https://api.github.com/users/featalion/repos","events_url":"https://api.github.com/users/featalion/events{/privacy}","received_events_url":"https://api.github.com/users/featalion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/featalion/remote_syslog2","description":"To install, see \"Releases\" tab. Self-contained daemon for reading local files and emitting remote syslog (without using local syslogd).","fork":true,"url":"https://api.github.com/repos/featalion/remote_syslog2","forks_url":"https://api.github.com/repos/featalion/remote_syslog2/forks","keys_url":"https://api.github.com/repos/featalion/remote_syslog2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/featalion/remote_syslog2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/featalion/remote_syslog2/teams","hooks_url":"https://api.github.com/repos/featalion/remote_syslog2/hooks","issue_events_url":"https://api.github.com/repos/featalion/remote_syslog2/issues/events{/number}","events_url":"https://api.github.com/repos/featalion/remote_syslog2/events","assignees_url":"https://api.github.com/repos/featalion/remote_syslog2/assignees{/user}","branches_url":"https://api.github.com/repos/featalion/remote_syslog2/branches{/branch}","tags_url":"https://api.github.com/repos/featalion/remote_syslog2/tags","blobs_url":"https://api.github.com/repos/featalion/remote_syslog2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/featalion/remote_syslog2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/featalion/remote_syslog2/git/refs{/sha}","trees_url":"https://api.github.com/repos/featalion/remote_syslog2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/featalion/remote_syslog2/statuses/{sha}","languages_url":"https://api.github.com/repos/featalion/remote_syslog2/languages","stargazers_url":"https://api.github.com/repos/featalion/remote_syslog2/stargazers","contributors_url":"https://api.github.com/repos/featalion/remote_syslog2/contributors","subscribers_url":"https://api.github.com/repos/featalion/remote_syslog2/subscribers","subscription_url":"https://api.github.com/repos/featalion/remote_syslog2/subscription","commits_url":"https://api.github.com/repos/featalion/remote_syslog2/commits{/sha}","git_commits_url":"https://api.github.com/repos/featalion/remote_syslog2/git/commits{/sha}","comments_url":"https://api.github.com/repos/featalion/remote_syslog2/comments{/number}","issue_comment_url":"https://api.github.com/repos/featalion/remote_syslog2/issues/comments{/number}","contents_url":"https://api.github.com/repos/featalion/remote_syslog2/contents/{+path}","compare_url":"https://api.github.com/repos/featalion/remote_syslog2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/featalion/remote_syslog2/merges","archive_url":"https://api.github.com/repos/featalion/remote_syslog2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/featalion/remote_syslog2/downloads","issues_url":"https://api.github.com/repos/featalion/remote_syslog2/issues{/number}","pulls_url":"https://api.github.com/repos/featalion/remote_syslog2/pulls{/number}","milestones_url":"https://api.github.com/repos/featalion/remote_syslog2/milestones{/number}","notifications_url":"https://api.github.com/repos/featalion/remote_syslog2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/featalion/remote_syslog2/labels{/name}","releases_url":"https://api.github.com/repos/featalion/remote_syslog2/releases{/id}","created_at":"2015-06-17T10:41:43Z","updated_at":"2015-06-17T10:41:43Z","pushed_at":"2015-07-02T11:05:03Z","git_url":"git://github.com/featalion/remote_syslog2.git","ssh_url":"git@github.com:featalion/remote_syslog2.git","clone_url":"https://github.com/featalion/remote_syslog2.git","svn_url":"https://github.com/featalion/remote_syslog2","homepage":"http://help.papertrailapp.com/","size":715,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"papertrail:master","ref":"master","sha":"eb9b7b7f37b12756ad40242456de22c742fd5f9b","user":{"login":"papertrail","id":481428,"avatar_url":"https://avatars.githubusercontent.com/u/481428?v=3","gravatar_id":"","url":"https://api.github.com/users/papertrail","html_url":"https://github.com/papertrail","followers_url":"https://api.github.com/users/papertrail/followers","following_url":"https://api.github.com/users/papertrail/following{/other_user}","gists_url":"https://api.github.com/users/papertrail/gists{/gist_id}","starred_url":"https://api.github.com/users/papertrail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papertrail/subscriptions","organizations_url":"https://api.github.com/users/papertrail/orgs","repos_url":"https://api.github.com/users/papertrail/repos","events_url":"https://api.github.com/users/papertrail/events{/privacy}","received_events_url":"https://api.github.com/users/papertrail/received_events","type":"Organization","site_admin":false},"repo":{"id":19044299,"name":"remote_syslog2","full_name":"papertrail/remote_syslog2","owner":{"login":"papertrail","id":481428,"avatar_url":"https://avatars.githubusercontent.com/u/481428?v=3","gravatar_id":"","url":"https://api.github.com/users/papertrail","html_url":"https://github.com/papertrail","followers_url":"https://api.github.com/users/papertrail/followers","following_url":"https://api.github.com/users/papertrail/following{/other_user}","gists_url":"https://api.github.com/users/papertrail/gists{/gist_id}","starred_url":"https://api.github.com/users/papertrail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papertrail/subscriptions","organizations_url":"https://api.github.com/users/papertrail/orgs","repos_url":"https://api.github.com/users/papertrail/repos","events_url":"https://api.github.com/users/papertrail/events{/privacy}","received_events_url":"https://api.github.com/users/papertrail/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/papertrail/remote_syslog2","description":"To install, see \"Releases\" tab. Self-contained daemon for reading local files and emitting remote syslog (without using local syslogd).","fork":false,"url":"https://api.github.com/repos/papertrail/remote_syslog2","forks_url":"https://api.github.com/repos/papertrail/remote_syslog2/forks","keys_url":"https://api.github.com/repos/papertrail/remote_syslog2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/papertrail/remote_syslog2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/papertrail/remote_syslog2/teams","hooks_url":"https://api.github.com/repos/papertrail/remote_syslog2/hooks","issue_events_url":"https://api.github.com/repos/papertrail/remote_syslog2/issues/events{/number}","events_url":"https://api.github.com/repos/papertrail/remote_syslog2/events","assignees_url":"https://api.github.com/repos/papertrail/remote_syslog2/assignees{/user}","branches_url":"https://api.github.com/repos/papertrail/remote_syslog2/branches{/branch}","tags_url":"https://api.github.com/repos/papertrail/remote_syslog2/tags","blobs_url":"https://api.github.com/repos/papertrail/remote_syslog2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/papertrail/remote_syslog2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/papertrail/remote_syslog2/git/refs{/sha}","trees_url":"https://api.github.com/repos/papertrail/remote_syslog2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/papertrail/remote_syslog2/statuses/{sha}","languages_url":"https://api.github.com/repos/papertrail/remote_syslog2/languages","stargazers_url":"https://api.github.com/repos/papertrail/remote_syslog2/stargazers","contributors_url":"https://api.github.com/repos/papertrail/remote_syslog2/contributors","subscribers_url":"https://api.github.com/repos/papertrail/remote_syslog2/subscribers","subscription_url":"https://api.github.com/repos/papertrail/remote_syslog2/subscription","commits_url":"https://api.github.com/repos/papertrail/remote_syslog2/commits{/sha}","git_commits_url":"https://api.github.com/repos/papertrail/remote_syslog2/git/commits{/sha}","comments_url":"https://api.github.com/repos/papertrail/remote_syslog2/comments{/number}","issue_comment_url":"https://api.github.com/repos/papertrail/remote_syslog2/issues/comments{/number}","contents_url":"https://api.github.com/repos/papertrail/remote_syslog2/contents/{+path}","compare_url":"https://api.github.com/repos/papertrail/remote_syslog2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/papertrail/remote_syslog2/merges","archive_url":"https://api.github.com/repos/papertrail/remote_syslog2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/papertrail/remote_syslog2/downloads","issues_url":"https://api.github.com/repos/papertrail/remote_syslog2/issues{/number}","pulls_url":"https://api.github.com/repos/papertrail/remote_syslog2/pulls{/number}","milestones_url":"https://api.github.com/repos/papertrail/remote_syslog2/milestones{/number}","notifications_url":"https://api.github.com/repos/papertrail/remote_syslog2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/papertrail/remote_syslog2/labels{/name}","releases_url":"https://api.github.com/repos/papertrail/remote_syslog2/releases{/id}","created_at":"2014-04-22T20:04:03Z","updated_at":"2015-06-29T11:56:30Z","pushed_at":"2015-07-02T11:05:05Z","git_url":"git://github.com/papertrail/remote_syslog2.git","ssh_url":"git@github.com:papertrail/remote_syslog2.git","clone_url":"https://github.com/papertrail/remote_syslog2.git","svn_url":"https://github.com/papertrail/remote_syslog2","homepage":"http://help.papertrailapp.com/","size":1461,"stargazers_count":126,"watchers_count":126,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":33,"forks":23,"open_issues":33,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/papertrail/remote_syslog2/pulls/73"},"html":{"href":"https://github.com/papertrail/remote_syslog2/pull/73"},"issue":{"href":"https://api.github.com/repos/papertrail/remote_syslog2/issues/73"},"comments":{"href":"https://api.github.com/repos/papertrail/remote_syslog2/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/papertrail/remote_syslog2/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/papertrail/remote_syslog2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/papertrail/remote_syslog2/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/papertrail/remote_syslog2/statuses/7c67e297d42270fda2e3aa8bcd290e510288a8a8"}}}}