{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/31388328","id":31388328,"diff_hunk":"@@ -1,4 +1,4 @@\n-{ stdenv, curl }: # Note that `curl' may be `null', in case of the native stdenv.\n+{ stdenv, curl, ca_cert_file ? null, insecure ? false }: # Note that `curl' may be `null', in case of the native stdenv.","path":"pkgs/build-support/fetchurl/default.nix","position":2,"original_position":2,"commit_id":"bcdd612e234a5924de4ccfb218e61e2149023a7c","original_commit_id":"bcdd612e234a5924de4ccfb218e61e2149023a7c","user":{"login":"wkennington","id":1773309,"avatar_url":"https://avatars.githubusercontent.com/u/1773309?v=3","gravatar_id":"","url":"https://api.github.com/users/wkennington","html_url":"https://github.com/wkennington","followers_url":"https://api.github.com/users/wkennington/followers","following_url":"https://api.github.com/users/wkennington/following{/other_user}","gists_url":"https://api.github.com/users/wkennington/gists{/gist_id}","starred_url":"https://api.github.com/users/wkennington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkennington/subscriptions","organizations_url":"https://api.github.com/users/wkennington/orgs","repos_url":"https://api.github.com/users/wkennington/repos","events_url":"https://api.github.com/users/wkennington/events{/privacy}","received_events_url":"https://api.github.com/users/wkennington/received_events","type":"User","site_admin":false},"body":"I want to make sure all implementations explicitly understand that a lack\nof ca implies insecure but I wouldn't be against changing this.\n\nOn Sun, May 31, 2015, 01:53 Vladimír Čunát <notifications@github.com> wrote:\n\n> In pkgs/build-support/fetchurl/default.nix\n> <https://github.com/NixOS/nixpkgs/pull/8082#discussion_r31388309>:\n>\n> > @@ -1,4 +1,4 @@\n> > -{ stdenv, curl }: # Note that `curl' may be `null', in case of the native stdenv.\n> > +{ stdenv, curl, ca_cert_file ? null, insecure ? false }: # Note that `curl' may be `null', in case of the native stdenv.\n>\n> What about dropping the insecure parameter and consider let insecure =\n> ca_cert_file != null;? Is there any sense in a different setting?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/NixOS/nixpkgs/pull/8082/files#r31388309>.\n>\n","created_at":"2015-05-31T08:54:37Z","updated_at":"2015-05-31T08:54:37Z","html_url":"https://github.com/NixOS/nixpkgs/pull/8082#discussion_r31388328","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/8082","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/31388328"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/8082#discussion_r31388328"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/8082"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/8082","id":36575752,"html_url":"https://github.com/NixOS/nixpkgs/pull/8082","diff_url":"https://github.com/NixOS/nixpkgs/pull/8082.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/8082.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/8082","number":8082,"state":"open","locked":false,"title":"linux/stdenv: Fixups to accomodate boostrap-tools changes and ssl in fetchurl","user":{"login":"wkennington","id":1773309,"avatar_url":"https://avatars.githubusercontent.com/u/1773309?v=3","gravatar_id":"","url":"https://api.github.com/users/wkennington","html_url":"https://github.com/wkennington","followers_url":"https://api.github.com/users/wkennington/followers","following_url":"https://api.github.com/users/wkennington/following{/other_user}","gists_url":"https://api.github.com/users/wkennington/gists{/gist_id}","starred_url":"https://api.github.com/users/wkennington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkennington/subscriptions","organizations_url":"https://api.github.com/users/wkennington/orgs","repos_url":"https://api.github.com/users/wkennington/repos","events_url":"https://api.github.com/users/wkennington/events{/privacy}","received_events_url":"https://api.github.com/users/wkennington/received_events","type":"User","site_admin":false},"body":"This is the second patchset for #8081. This adds support for the new boostrap-tools changes and also adds ssl verification support into fetchurl.","created_at":"2015-05-31T02:38:56Z","updated_at":"2015-05-31T08:54:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"512aaa1490def78ee4ed36205729d1aea732c606","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/8082/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/8082/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/8082/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/bcdd612e234a5924de4ccfb218e61e2149023a7c","head":{"label":"wkennington:master.bootstrap2","ref":"master.bootstrap2","sha":"bcdd612e234a5924de4ccfb218e61e2149023a7c","user":{"login":"wkennington","id":1773309,"avatar_url":"https://avatars.githubusercontent.com/u/1773309?v=3","gravatar_id":"","url":"https://api.github.com/users/wkennington","html_url":"https://github.com/wkennington","followers_url":"https://api.github.com/users/wkennington/followers","following_url":"https://api.github.com/users/wkennington/following{/other_user}","gists_url":"https://api.github.com/users/wkennington/gists{/gist_id}","starred_url":"https://api.github.com/users/wkennington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkennington/subscriptions","organizations_url":"https://api.github.com/users/wkennington/orgs","repos_url":"https://api.github.com/users/wkennington/repos","events_url":"https://api.github.com/users/wkennington/events{/privacy}","received_events_url":"https://api.github.com/users/wkennington/received_events","type":"User","site_admin":false},"repo":{"id":13711406,"name":"nixpkgs","full_name":"wkennington/nixpkgs","owner":{"login":"wkennington","id":1773309,"avatar_url":"https://avatars.githubusercontent.com/u/1773309?v=3","gravatar_id":"","url":"https://api.github.com/users/wkennington","html_url":"https://github.com/wkennington","followers_url":"https://api.github.com/users/wkennington/followers","following_url":"https://api.github.com/users/wkennington/following{/other_user}","gists_url":"https://api.github.com/users/wkennington/gists{/gist_id}","starred_url":"https://api.github.com/users/wkennington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkennington/subscriptions","organizations_url":"https://api.github.com/users/wkennington/orgs","repos_url":"https://api.github.com/users/wkennington/repos","events_url":"https://api.github.com/users/wkennington/events{/privacy}","received_events_url":"https://api.github.com/users/wkennington/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wkennington/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/wkennington/nixpkgs","forks_url":"https://api.github.com/repos/wkennington/nixpkgs/forks","keys_url":"https://api.github.com/repos/wkennington/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wkennington/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wkennington/nixpkgs/teams","hooks_url":"https://api.github.com/repos/wkennington/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/wkennington/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/wkennington/nixpkgs/events","assignees_url":"https://api.github.com/repos/wkennington/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/wkennington/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/wkennington/nixpkgs/tags","blobs_url":"https://api.github.com/repos/wkennington/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wkennington/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wkennington/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/wkennington/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wkennington/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/wkennington/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/wkennington/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/wkennington/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/wkennington/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/wkennington/nixpkgs/subscription","commits_url":"https://api.github.com/repos/wkennington/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/wkennington/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/wkennington/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/wkennington/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/wkennington/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/wkennington/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wkennington/nixpkgs/merges","archive_url":"https://api.github.com/repos/wkennington/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wkennington/nixpkgs/downloads","issues_url":"https://api.github.com/repos/wkennington/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/wkennington/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/wkennington/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/wkennington/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wkennington/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/wkennington/nixpkgs/releases{/id}","created_at":"2013-10-20T00:47:51Z","updated_at":"2015-01-02T08:26:25Z","pushed_at":"2015-05-31T03:46:33Z","git_url":"git://github.com/wkennington/nixpkgs.git","ssh_url":"git@github.com:wkennington/nixpkgs.git","clone_url":"https://github.com/wkennington/nixpkgs.git","svn_url":"https://github.com/wkennington/nixpkgs","homepage":null,"size":209124,"stargazers_count":3,"watchers_count":3,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":3,"default_branch":"cache"}},"base":{"label":"NixOS:master","ref":"master","sha":"4c898aad5115b8e2967003b9b78cb9f4ff8f3843","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","created_at":"2012-06-04T02:49:46Z","updated_at":"2015-05-31T02:01:34Z","pushed_at":"2015-05-31T08:47:05Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":392482,"stargazers_count":659,"watchers_count":659,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":818,"mirror_url":null,"open_issues_count":745,"forks":818,"open_issues":745,"watchers":659,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/8082"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/8082"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/8082"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/8082/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/8082/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/8082/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/bcdd612e234a5924de4ccfb218e61e2149023a7c"}}}}