{"action":"created","comment":{"url":"https://api.github.com/repos/Araq/Nim/pulls/comments/31292113","id":31292113,"diff_hunk":"@@ -121,16 +121,32 @@ proc hash*(x: string): THash =\n     h = h !& ord(x[i])\n   result = !$h\n \n+# The following need a better home than \"hashes\":\n+const magicIdentSeparatorRuneByteWidth* = 3","path":"lib/pure/hashes.nim","position":14,"original_position":14,"commit_id":"f97ce535d70b02ca1633cdb3a3773fc21aa191e8","original_commit_id":"f97ce535d70b02ca1633cdb3a3773fc21aa191e8","user":{"login":"Araq","id":287816,"avatar_url":"https://avatars.githubusercontent.com/u/287816?v=3","gravatar_id":"","url":"https://api.github.com/users/Araq","html_url":"https://github.com/Araq","followers_url":"https://api.github.com/users/Araq/followers","following_url":"https://api.github.com/users/Araq/following{/other_user}","gists_url":"https://api.github.com/users/Araq/gists{/gist_id}","starred_url":"https://api.github.com/users/Araq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Araq/subscriptions","organizations_url":"https://api.github.com/users/Araq/orgs","repos_url":"https://api.github.com/users/Araq/repos","events_url":"https://api.github.com/users/Araq/events{/privacy}","received_events_url":"https://api.github.com/users/Araq/received_events","type":"User","site_admin":false},"body":"this should be done in idents.nim","created_at":"2015-05-29T00:57:25Z","updated_at":"2015-05-29T00:57:25Z","html_url":"https://github.com/Araq/Nim/pull/2833#discussion_r31292113","pull_request_url":"https://api.github.com/repos/Araq/Nim/pulls/2833","_links":{"self":{"href":"https://api.github.com/repos/Araq/Nim/pulls/comments/31292113"},"html":{"href":"https://github.com/Araq/Nim/pull/2833#discussion_r31292113"},"pull_request":{"href":"https://api.github.com/repos/Araq/Nim/pulls/2833"}}},"pull_request":{"url":"https://api.github.com/repos/Araq/Nim/pulls/2833","id":36429963,"html_url":"https://github.com/Araq/Nim/pull/2833","diff_url":"https://github.com/Araq/Nim/pull/2833.diff","patch_url":"https://github.com/Araq/Nim/pull/2833.patch","issue_url":"https://api.github.com/repos/Araq/Nim/issues/2833","number":2833,"state":"open","locked":false,"title":"Fix #2811 - Support for EN DASH (U+2013) as a transparent alternative to snake and hump style.","user":{"login":"ozra","id":563674,"avatar_url":"https://avatars.githubusercontent.com/u/563674?v=3","gravatar_id":"","url":"https://api.github.com/users/ozra","html_url":"https://github.com/ozra","followers_url":"https://api.github.com/users/ozra/followers","following_url":"https://api.github.com/users/ozra/following{/other_user}","gists_url":"https://api.github.com/users/ozra/gists{/gist_id}","starred_url":"https://api.github.com/users/ozra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ozra/subscriptions","organizations_url":"https://api.github.com/users/ozra/orgs","repos_url":"https://api.github.com/users/ozra/repos","events_url":"https://api.github.com/users/ozra/events{/privacy}","received_events_url":"https://api.github.com/users/ozra/received_events","type":"User","site_admin":false},"body":"#### The rune / glyph ####\r\n- The glyph is clearly distinguishable from minus, for those who don't use the style - if they for some reason would read such code.\r\n- It has wide font support\r\n\r\n#### The code ####\r\n- I've compared the utf-8 encoded byte sequence directly, instead of converting to a code point and comparing, since this is less intrusive and more inline with the hotness of the code path.\r\n- The code style here might be a bit verbose for your tastes\r\n- The `isMagicIdentSeparatorRune()...` need a better place to live - figured I better get feedback\r\n- Should I add a unit-test, or is it overkill?\r\n\r\nThis is my first dive in to the compiler - so keep eyes open so I haven't done anything retarded ;-)","created_at":"2015-05-28T17:18:08Z","updated_at":"2015-05-29T00:57:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75bc0301eca2f4cfe3a0f5433feb1bd1d58bc503","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Araq/Nim/pulls/2833/commits","review_comments_url":"https://api.github.com/repos/Araq/Nim/pulls/2833/comments","review_comment_url":"https://api.github.com/repos/Araq/Nim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Araq/Nim/issues/2833/comments","statuses_url":"https://api.github.com/repos/Araq/Nim/statuses/f97ce535d70b02ca1633cdb3a3773fc21aa191e8","head":{"label":"ozra:devel","ref":"devel","sha":"f97ce535d70b02ca1633cdb3a3773fc21aa191e8","user":{"login":"ozra","id":563674,"avatar_url":"https://avatars.githubusercontent.com/u/563674?v=3","gravatar_id":"","url":"https://api.github.com/users/ozra","html_url":"https://github.com/ozra","followers_url":"https://api.github.com/users/ozra/followers","following_url":"https://api.github.com/users/ozra/following{/other_user}","gists_url":"https://api.github.com/users/ozra/gists{/gist_id}","starred_url":"https://api.github.com/users/ozra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ozra/subscriptions","organizations_url":"https://api.github.com/users/ozra/orgs","repos_url":"https://api.github.com/users/ozra/repos","events_url":"https://api.github.com/users/ozra/events{/privacy}","received_events_url":"https://api.github.com/users/ozra/received_events","type":"User","site_admin":false},"repo":{"id":35645960,"name":"Nim","full_name":"ozra/Nim","owner":{"login":"ozra","id":563674,"avatar_url":"https://avatars.githubusercontent.com/u/563674?v=3","gravatar_id":"","url":"https://api.github.com/users/ozra","html_url":"https://github.com/ozra","followers_url":"https://api.github.com/users/ozra/followers","following_url":"https://api.github.com/users/ozra/following{/other_user}","gists_url":"https://api.github.com/users/ozra/gists{/gist_id}","starred_url":"https://api.github.com/users/ozra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ozra/subscriptions","organizations_url":"https://api.github.com/users/ozra/orgs","repos_url":"https://api.github.com/users/ozra/repos","events_url":"https://api.github.com/users/ozra/events{/privacy}","received_events_url":"https://api.github.com/users/ozra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ozra/Nim","description":"Nim (formerly known as \"Nimrod\") is a compiled, garbage-collected systems programming language which has an excellent productivity/performance ratio. Nim's design focuses on efficiency, expressiveness, elegance (in the order of priority).","fork":true,"url":"https://api.github.com/repos/ozra/Nim","forks_url":"https://api.github.com/repos/ozra/Nim/forks","keys_url":"https://api.github.com/repos/ozra/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ozra/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ozra/Nim/teams","hooks_url":"https://api.github.com/repos/ozra/Nim/hooks","issue_events_url":"https://api.github.com/repos/ozra/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/ozra/Nim/events","assignees_url":"https://api.github.com/repos/ozra/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/ozra/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/ozra/Nim/tags","blobs_url":"https://api.github.com/repos/ozra/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ozra/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ozra/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/ozra/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ozra/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/ozra/Nim/languages","stargazers_url":"https://api.github.com/repos/ozra/Nim/stargazers","contributors_url":"https://api.github.com/repos/ozra/Nim/contributors","subscribers_url":"https://api.github.com/repos/ozra/Nim/subscribers","subscription_url":"https://api.github.com/repos/ozra/Nim/subscription","commits_url":"https://api.github.com/repos/ozra/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/ozra/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/ozra/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/ozra/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/ozra/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/ozra/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ozra/Nim/merges","archive_url":"https://api.github.com/repos/ozra/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ozra/Nim/downloads","issues_url":"https://api.github.com/repos/ozra/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/ozra/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/ozra/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/ozra/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ozra/Nim/labels{/name}","releases_url":"https://api.github.com/repos/ozra/Nim/releases{/id}","created_at":"2015-05-15T01:15:31Z","updated_at":"2015-05-15T01:15:35Z","pushed_at":"2015-05-28T17:07:05Z","git_url":"git://github.com/ozra/Nim.git","ssh_url":"git@github.com:ozra/Nim.git","clone_url":"https://github.com/ozra/Nim.git","svn_url":"https://github.com/ozra/Nim","homepage":"http://nim-lang.org/","size":37834,"stargazers_count":0,"watchers_count":0,"language":"Nimrod","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"Araq:devel","ref":"devel","sha":"6820b2fea919c033405e7e204343fddd947c2ef3","user":{"login":"Araq","id":287816,"avatar_url":"https://avatars.githubusercontent.com/u/287816?v=3","gravatar_id":"","url":"https://api.github.com/users/Araq","html_url":"https://github.com/Araq","followers_url":"https://api.github.com/users/Araq/followers","following_url":"https://api.github.com/users/Araq/following{/other_user}","gists_url":"https://api.github.com/users/Araq/gists{/gist_id}","starred_url":"https://api.github.com/users/Araq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Araq/subscriptions","organizations_url":"https://api.github.com/users/Araq/orgs","repos_url":"https://api.github.com/users/Araq/repos","events_url":"https://api.github.com/users/Araq/events{/privacy}","received_events_url":"https://api.github.com/users/Araq/received_events","type":"User","site_admin":false},"repo":{"id":842037,"name":"Nim","full_name":"Araq/Nim","owner":{"login":"Araq","id":287816,"avatar_url":"https://avatars.githubusercontent.com/u/287816?v=3","gravatar_id":"","url":"https://api.github.com/users/Araq","html_url":"https://github.com/Araq","followers_url":"https://api.github.com/users/Araq/followers","following_url":"https://api.github.com/users/Araq/following{/other_user}","gists_url":"https://api.github.com/users/Araq/gists{/gist_id}","starred_url":"https://api.github.com/users/Araq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Araq/subscriptions","organizations_url":"https://api.github.com/users/Araq/orgs","repos_url":"https://api.github.com/users/Araq/repos","events_url":"https://api.github.com/users/Araq/events{/privacy}","received_events_url":"https://api.github.com/users/Araq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Araq/Nim","description":"Nim (formerly known as \"Nimrod\") is a compiled, garbage-collected systems programming language which has an excellent productivity/performance ratio. Nim's design focuses on efficiency, expressiveness, elegance (in the order of priority).","fork":false,"url":"https://api.github.com/repos/Araq/Nim","forks_url":"https://api.github.com/repos/Araq/Nim/forks","keys_url":"https://api.github.com/repos/Araq/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Araq/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Araq/Nim/teams","hooks_url":"https://api.github.com/repos/Araq/Nim/hooks","issue_events_url":"https://api.github.com/repos/Araq/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/Araq/Nim/events","assignees_url":"https://api.github.com/repos/Araq/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/Araq/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/Araq/Nim/tags","blobs_url":"https://api.github.com/repos/Araq/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Araq/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Araq/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/Araq/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Araq/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/Araq/Nim/languages","stargazers_url":"https://api.github.com/repos/Araq/Nim/stargazers","contributors_url":"https://api.github.com/repos/Araq/Nim/contributors","subscribers_url":"https://api.github.com/repos/Araq/Nim/subscribers","subscription_url":"https://api.github.com/repos/Araq/Nim/subscription","commits_url":"https://api.github.com/repos/Araq/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/Araq/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/Araq/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/Araq/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/Araq/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/Araq/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Araq/Nim/merges","archive_url":"https://api.github.com/repos/Araq/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Araq/Nim/downloads","issues_url":"https://api.github.com/repos/Araq/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/Araq/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/Araq/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/Araq/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Araq/Nim/labels{/name}","releases_url":"https://api.github.com/repos/Araq/Nim/releases{/id}","created_at":"2010-08-16T20:38:58Z","updated_at":"2015-05-28T15:21:02Z","pushed_at":"2015-05-28T23:52:36Z","git_url":"git://github.com/Araq/Nim.git","ssh_url":"git@github.com:Araq/Nim.git","clone_url":"https://github.com/Araq/Nim.git","svn_url":"https://github.com/Araq/Nim","homepage":"http://nim-lang.org/","size":353392,"stargazers_count":1949,"watchers_count":1949,"language":"Nimrod","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":261,"mirror_url":null,"open_issues_count":545,"forks":261,"open_issues":545,"watchers":1949,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/Araq/Nim/pulls/2833"},"html":{"href":"https://github.com/Araq/Nim/pull/2833"},"issue":{"href":"https://api.github.com/repos/Araq/Nim/issues/2833"},"comments":{"href":"https://api.github.com/repos/Araq/Nim/issues/2833/comments"},"review_comments":{"href":"https://api.github.com/repos/Araq/Nim/pulls/2833/comments"},"review_comment":{"href":"https://api.github.com/repos/Araq/Nim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Araq/Nim/pulls/2833/commits"},"statuses":{"href":"https://api.github.com/repos/Araq/Nim/statuses/f97ce535d70b02ca1633cdb3a3773fc21aa191e8"}}}}