{"action":"created","comment":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments/28990232","id":28990232,"diff_hunk":"@@ -4,134 +4,118 @@\n \n from website.addons.github import views\n \n-settings_routes = {\n+","path":"website/addons/github/routes.py","position":5,"original_position":5,"commit_id":"02d873950e332a06056f7f154122669544e8b4a8","original_commit_id":"f997c96a3f2c3ff544c3177637633d4a19d1b664","user":{"login":"harrismendell","id":7120180,"avatar_url":"https://avatars.githubusercontent.com/u/7120180?v=3","gravatar_id":"","url":"https://api.github.com/users/harrismendell","html_url":"https://github.com/harrismendell","followers_url":"https://api.github.com/users/harrismendell/followers","following_url":"https://api.github.com/users/harrismendell/following{/other_user}","gists_url":"https://api.github.com/users/harrismendell/gists{/gist_id}","starred_url":"https://api.github.com/users/harrismendell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrismendell/subscriptions","organizations_url":"https://api.github.com/users/harrismendell/orgs","repos_url":"https://api.github.com/users/harrismendell/repos","events_url":"https://api.github.com/users/harrismendell/events{/privacy}","received_events_url":"https://api.github.com/users/harrismendell/received_events","type":"User","site_admin":false},"body":"For sure. I made a note of that during the dev meeting on Tuesday but it slipped my mind.","created_at":"2015-04-23T18:34:20Z","updated_at":"2015-04-23T18:34:20Z","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/2490#discussion_r28990232","pull_request_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/2490","_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments/28990232"},"html":{"href":"https://github.com/CenterForOpenScience/osf.io/pull/2490#discussion_r28990232"},"pull_request":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/2490"}}},"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/2490","id":33296087,"html_url":"https://github.com/CenterForOpenScience/osf.io/pull/2490","diff_url":"https://github.com/CenterForOpenScience/osf.io/pull/2490.diff","patch_url":"https://github.com/CenterForOpenScience/osf.io/pull/2490.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/2490","number":2490,"state":"open","locked":false,"title":"[Ready for Review] Feature: GitHub OAuth and UI Update","user":{"login":"harrismendell","id":7120180,"avatar_url":"https://avatars.githubusercontent.com/u/7120180?v=3","gravatar_id":"","url":"https://api.github.com/users/harrismendell","html_url":"https://github.com/harrismendell","followers_url":"https://api.github.com/users/harrismendell/followers","following_url":"https://api.github.com/users/harrismendell/following{/other_user}","gists_url":"https://api.github.com/users/harrismendell/gists{/gist_id}","starred_url":"https://api.github.com/users/harrismendell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrismendell/subscriptions","organizations_url":"https://api.github.com/users/harrismendell/orgs","repos_url":"https://api.github.com/users/harrismendell/repos","events_url":"https://api.github.com/users/harrismendell/events{/privacy}","received_events_url":"https://api.github.com/users/harrismendell/received_events","type":"User","site_admin":false},"body":"### Purpose\r\n\r\nGitHub's NodeSettings UI and OAuth flow are currently based on outdated code. This PR aims to change this.\r\n\r\n### Changes\r\n\r\n* Refactor GitHub's OAuth to use the new External Provider system employed by Mendeley/Zotero/Google Drive.\r\n* Serialize GitHub's settings.\r\n* Change the front end to use async/knockout instead of mako/j-query logic. \r\n* Refactor parts of the backend to support new front end changes.\r\n* Fix old broken tests and write new ones where necessary.\r\n\r\n### Side Effects\r\n\r\n* The new External Provider/Account OAuth system revokes access on our end, but does not delete OAuth keys from the 3rd party application, the current OAuth system on staging -does- delete the key on the 3rd party side (at least for GitHub).\r\n* Any dependencies on GitHub's node settings or OAuth flow could be affected. \r\n","created_at":"2015-04-14T20:24:50Z","updated_at":"2015-04-23T18:34:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"663c13f45d8aa4a8d27495e772b768114899f3e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/2490/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/2490/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/2490/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/02d873950e332a06056f7f154122669544e8b4a8","head":{"label":"harrismendell:feature/github_refactor_oauth","ref":"feature/github_refactor_oauth","sha":"02d873950e332a06056f7f154122669544e8b4a8","user":{"login":"harrismendell","id":7120180,"avatar_url":"https://avatars.githubusercontent.com/u/7120180?v=3","gravatar_id":"","url":"https://api.github.com/users/harrismendell","html_url":"https://github.com/harrismendell","followers_url":"https://api.github.com/users/harrismendell/followers","following_url":"https://api.github.com/users/harrismendell/following{/other_user}","gists_url":"https://api.github.com/users/harrismendell/gists{/gist_id}","starred_url":"https://api.github.com/users/harrismendell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrismendell/subscriptions","organizations_url":"https://api.github.com/users/harrismendell/orgs","repos_url":"https://api.github.com/users/harrismendell/repos","events_url":"https://api.github.com/users/harrismendell/events{/privacy}","received_events_url":"https://api.github.com/users/harrismendell/received_events","type":"User","site_admin":false},"repo":{"id":30252903,"name":"osf.io","full_name":"harrismendell/osf.io","owner":{"login":"harrismendell","id":7120180,"avatar_url":"https://avatars.githubusercontent.com/u/7120180?v=3","gravatar_id":"","url":"https://api.github.com/users/harrismendell","html_url":"https://github.com/harrismendell","followers_url":"https://api.github.com/users/harrismendell/followers","following_url":"https://api.github.com/users/harrismendell/following{/other_user}","gists_url":"https://api.github.com/users/harrismendell/gists{/gist_id}","starred_url":"https://api.github.com/users/harrismendell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrismendell/subscriptions","organizations_url":"https://api.github.com/users/harrismendell/orgs","repos_url":"https://api.github.com/users/harrismendell/repos","events_url":"https://api.github.com/users/harrismendell/events{/privacy}","received_events_url":"https://api.github.com/users/harrismendell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harrismendell/osf.io","description":"Facilitating Open Science","fork":true,"url":"https://api.github.com/repos/harrismendell/osf.io","forks_url":"https://api.github.com/repos/harrismendell/osf.io/forks","keys_url":"https://api.github.com/repos/harrismendell/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harrismendell/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harrismendell/osf.io/teams","hooks_url":"https://api.github.com/repos/harrismendell/osf.io/hooks","issue_events_url":"https://api.github.com/repos/harrismendell/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/harrismendell/osf.io/events","assignees_url":"https://api.github.com/repos/harrismendell/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/harrismendell/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/harrismendell/osf.io/tags","blobs_url":"https://api.github.com/repos/harrismendell/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harrismendell/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harrismendell/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/harrismendell/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harrismendell/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/harrismendell/osf.io/languages","stargazers_url":"https://api.github.com/repos/harrismendell/osf.io/stargazers","contributors_url":"https://api.github.com/repos/harrismendell/osf.io/contributors","subscribers_url":"https://api.github.com/repos/harrismendell/osf.io/subscribers","subscription_url":"https://api.github.com/repos/harrismendell/osf.io/subscription","commits_url":"https://api.github.com/repos/harrismendell/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/harrismendell/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/harrismendell/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/harrismendell/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/harrismendell/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/harrismendell/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harrismendell/osf.io/merges","archive_url":"https://api.github.com/repos/harrismendell/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harrismendell/osf.io/downloads","issues_url":"https://api.github.com/repos/harrismendell/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/harrismendell/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/harrismendell/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/harrismendell/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harrismendell/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/harrismendell/osf.io/releases{/id}","created_at":"2015-02-03T16:40:28Z","updated_at":"2015-03-24T21:51:19Z","pushed_at":"2015-04-23T18:18:32Z","git_url":"git://github.com/harrismendell/osf.io.git","ssh_url":"git@github.com:harrismendell/osf.io.git","clone_url":"https://github.com/harrismendell/osf.io.git","svn_url":"https://github.com/harrismendell/osf.io","homepage":"http://osf.io","size":84000,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:develop","ref":"develop","sha":"8bcdddc83635a9bc6f482ee100308349c86bd291","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":10199599,"name":"osf.io","full_name":"CenterForOpenScience/osf.io","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/osf.io","description":"Facilitating Open Science","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/osf.io","forks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/releases{/id}","created_at":"2013-05-21T15:53:37Z","updated_at":"2015-04-23T16:11:04Z","pushed_at":"2015-04-23T18:32:48Z","git_url":"git://github.com/CenterForOpenScience/osf.io.git","ssh_url":"git@github.com:CenterForOpenScience/osf.io.git","clone_url":"https://github.com/CenterForOpenScience/osf.io.git","svn_url":"https://github.com/CenterForOpenScience/osf.io","homepage":"http://osf.io","size":194582,"stargazers_count":96,"watchers_count":96,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":389,"forks":71,"open_issues":389,"watchers":96,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/2490"},"html":{"href":"https://github.com/CenterForOpenScience/osf.io/pull/2490"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/2490"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/2490/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/2490/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/2490/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/02d873950e332a06056f7f154122669544e8b4a8"}}}}