{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/38822073","id":38822073,"diff_hunk":"@@ -204,7 +204,7 @@ public StormTopology buildTopology() {\n         for(String id: _bolts.keySet()) {\n             Component c = _bolts.get(id);\n             \n-            Map<String, CoordSpec> specs = new HashMap();\n+            Map<String, CoordSpec> specs = new HashMap<>();","path":"storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java","position":32,"original_position":32,"commit_id":"f55f7a7e57f382b91a700daeeb292580fcf9da7d","original_commit_id":"f55f7a7e57f382b91a700daeeb292580fcf9da7d","user":{"login":"ddebree","id":396348,"avatar_url":"https://avatars.githubusercontent.com/u/396348?v=3","gravatar_id":"","url":"https://api.github.com/users/ddebree","html_url":"https://github.com/ddebree","followers_url":"https://api.github.com/users/ddebree/followers","following_url":"https://api.github.com/users/ddebree/following{/other_user}","gists_url":"https://api.github.com/users/ddebree/gists{/gist_id}","starred_url":"https://api.github.com/users/ddebree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddebree/subscriptions","organizations_url":"https://api.github.com/users/ddebree/orgs","repos_url":"https://api.github.com/users/ddebree/repos","events_url":"https://api.github.com/users/ddebree/events{/privacy}","received_events_url":"https://api.github.com/users/ddebree/received_events","type":"User","site_admin":false},"body":"Another minor generics fix.","created_at":"2015-09-06T14:39:25Z","updated_at":"2015-09-06T14:39:25Z","html_url":"https://github.com/apache/storm/pull/723#discussion_r38822073","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/723","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/38822073"},"html":{"href":"https://github.com/apache/storm/pull/723#discussion_r38822073"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/723"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/723","id":44303704,"html_url":"https://github.com/apache/storm/pull/723","diff_url":"https://github.com/apache/storm/pull/723.diff","patch_url":"https://github.com/apache/storm/pull/723.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/723","number":723,"state":"open","locked":false,"title":"[STORM-1032] Add generics to component configuration methods","user":{"login":"ddebree","id":396348,"avatar_url":"https://avatars.githubusercontent.com/u/396348?v=3","gravatar_id":"","url":"https://api.github.com/users/ddebree","html_url":"https://github.com/ddebree","followers_url":"https://api.github.com/users/ddebree/followers","following_url":"https://api.github.com/users/ddebree/following{/other_user}","gists_url":"https://api.github.com/users/ddebree/gists{/gist_id}","starred_url":"https://api.github.com/users/ddebree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddebree/subscriptions","organizations_url":"https://api.github.com/users/ddebree/orgs","repos_url":"https://api.github.com/users/ddebree/repos","events_url":"https://api.github.com/users/ddebree/events{/privacy}","received_events_url":"https://api.github.com/users/ddebree/received_events","type":"User","site_admin":false},"body":"The getComponentConfiguration methods currently return a simple Map object. In fact they should be returning a Map<String, Object>. \r\nBy changing this, it will make it slightly clear what is being returned by the method and potentially pick up some issues at compile time. ","created_at":"2015-09-06T14:37:47Z","updated_at":"2015-09-06T14:39:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf57fccd981e6a62cb10b03062d63ccfe106c5a9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/723/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/723/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/723/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/f55f7a7e57f382b91a700daeeb292580fcf9da7d","head":{"label":"ddebree:configuration_map_generics","ref":"configuration_map_generics","sha":"f55f7a7e57f382b91a700daeeb292580fcf9da7d","user":{"login":"ddebree","id":396348,"avatar_url":"https://avatars.githubusercontent.com/u/396348?v=3","gravatar_id":"","url":"https://api.github.com/users/ddebree","html_url":"https://github.com/ddebree","followers_url":"https://api.github.com/users/ddebree/followers","following_url":"https://api.github.com/users/ddebree/following{/other_user}","gists_url":"https://api.github.com/users/ddebree/gists{/gist_id}","starred_url":"https://api.github.com/users/ddebree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddebree/subscriptions","organizations_url":"https://api.github.com/users/ddebree/orgs","repos_url":"https://api.github.com/users/ddebree/repos","events_url":"https://api.github.com/users/ddebree/events{/privacy}","received_events_url":"https://api.github.com/users/ddebree/received_events","type":"User","site_admin":false},"repo":{"id":40651514,"name":"storm","full_name":"ddebree/storm","owner":{"login":"ddebree","id":396348,"avatar_url":"https://avatars.githubusercontent.com/u/396348?v=3","gravatar_id":"","url":"https://api.github.com/users/ddebree","html_url":"https://github.com/ddebree","followers_url":"https://api.github.com/users/ddebree/followers","following_url":"https://api.github.com/users/ddebree/following{/other_user}","gists_url":"https://api.github.com/users/ddebree/gists{/gist_id}","starred_url":"https://api.github.com/users/ddebree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddebree/subscriptions","organizations_url":"https://api.github.com/users/ddebree/orgs","repos_url":"https://api.github.com/users/ddebree/repos","events_url":"https://api.github.com/users/ddebree/events{/privacy}","received_events_url":"https://api.github.com/users/ddebree/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ddebree/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/ddebree/storm","forks_url":"https://api.github.com/repos/ddebree/storm/forks","keys_url":"https://api.github.com/repos/ddebree/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddebree/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddebree/storm/teams","hooks_url":"https://api.github.com/repos/ddebree/storm/hooks","issue_events_url":"https://api.github.com/repos/ddebree/storm/issues/events{/number}","events_url":"https://api.github.com/repos/ddebree/storm/events","assignees_url":"https://api.github.com/repos/ddebree/storm/assignees{/user}","branches_url":"https://api.github.com/repos/ddebree/storm/branches{/branch}","tags_url":"https://api.github.com/repos/ddebree/storm/tags","blobs_url":"https://api.github.com/repos/ddebree/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddebree/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddebree/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddebree/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddebree/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/ddebree/storm/languages","stargazers_url":"https://api.github.com/repos/ddebree/storm/stargazers","contributors_url":"https://api.github.com/repos/ddebree/storm/contributors","subscribers_url":"https://api.github.com/repos/ddebree/storm/subscribers","subscription_url":"https://api.github.com/repos/ddebree/storm/subscription","commits_url":"https://api.github.com/repos/ddebree/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddebree/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddebree/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddebree/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddebree/storm/contents/{+path}","compare_url":"https://api.github.com/repos/ddebree/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddebree/storm/merges","archive_url":"https://api.github.com/repos/ddebree/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddebree/storm/downloads","issues_url":"https://api.github.com/repos/ddebree/storm/issues{/number}","pulls_url":"https://api.github.com/repos/ddebree/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/ddebree/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/ddebree/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddebree/storm/labels{/name}","releases_url":"https://api.github.com/repos/ddebree/storm/releases{/id}","created_at":"2015-08-13T09:51:44Z","updated_at":"2015-08-13T09:51:47Z","pushed_at":"2015-09-06T14:27:52Z","git_url":"git://github.com/ddebree/storm.git","ssh_url":"git@github.com:ddebree/storm.git","clone_url":"https://github.com/ddebree/storm.git","svn_url":"https://github.com/ddebree/storm","homepage":null,"size":21663,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"895ba4251570ae4c8857ccd00b91af80cf51e957","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","created_at":"2013-11-05T08:00:14Z","updated_at":"2015-09-05T19:39:23Z","pushed_at":"2015-09-06T14:37:47Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":824959,"stargazers_count":2303,"watchers_count":2303,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1628,"mirror_url":"git://git.apache.org/incubator-storm.git","open_issues_count":84,"forks":1628,"open_issues":84,"watchers":2303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/723"},"html":{"href":"https://github.com/apache/storm/pull/723"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/723"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/723/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/723/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/723/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/f55f7a7e57f382b91a700daeeb292580fcf9da7d"}}}}