{"action":"created","comment":{"url":"https://api.github.com/repos/cylc/cylc/pulls/comments/44917313","id":44917313,"diff_hunk":"@@ -617,70 +617,69 @@ def _update_model( self, model, columns, path, row_id, data,\n         iter_ = model.append(parent_iter, data)\n         return iter_\n \n-    def _get_row_id( self, model, rpath ):\n-        # Record a row's first two values.\n-        riter = model.get_iter( rpath )\n-        point_string = model.get_value( riter, 0 )\n-        name = model.get_value( riter, 1 )\n+    def _get_row_id(self, model, rpath):\n+        \"\"\"Record a row's first two values.\"\"\"\n+        riter = model.get_iter(rpath)\n+        point_string = model.get_value(riter, 0)\n+        name = model.get_value(riter, 1)\n         return (point_string, name)\n \n-    def _add_expanded_row( self, view, rpath, expand_me ):\n-        # Add user-expanded rows to a list of rows to be expanded.\n+    def _add_expanded_row(self, view, rpath, expand_me):\n+        \"\"\"Add user-expanded rows to a list of rows to be expanded.\"\"\"\n         model = view.get_model()\n-        row_iter = model.get_iter( rpath )\n-        row_id = self._get_row_id( model, rpath )\n-        if (not self.autoexpand or\n-            row_id not in self._last_autoexpand_me):\n-            expand_me.append( row_id )\n+        row_iter = model.get_iter(rpath)\n+        row_id = self._get_row_id(model, rpath)\n+        if not self.autoexpand or row_id not in self._last_autoexpand_me:\n+            expand_me.append(row_id)\n         return False\n \n-    def _get_user_expanded_row_ids( self ):\n+    def _get_user_expanded_row_ids(self):\n         \"\"\"Return a list of user-expanded row point_strings and names.\"\"\"\n         names = []\n         model = self.ttreeview.get_model()\n         if model is None or model.get_iter_first() is None:\n             return names\n-        self.ttreeview.map_expanded_rows( self._add_expanded_row, names )\n+        self.ttreeview.map_expanded_rows(self._add_expanded_row, names)\n         return names\n \n-    def _expand_row( self, model, rpath, riter, expand_me ):\n+    def _expand_row(self, model, rpath, riter, expand_me):\n         \"\"\"Expand a row if it matches expand_me point_strings and names.\"\"\"\n-        point_string_name_tuple = self._get_row_id( model, rpath )\n+        point_string_name_tuple = self._get_row_id(model, rpath)\n         if point_string_name_tuple in expand_me:\n-            self.ttreeview.expand_to_path( rpath )\n+            self.ttreeview.expand_to_path(rpath)\n         return False\n \n-    def _update_path_info( self, row_iter, descendant_state, descendant_name ):\n+    def _update_path_info(self, row_iter, descendant_state, descendant_name):\n         # Cache states and names from the subtree below this row.\n-        path = self.ttreestore.get_path( row_iter )\n-        self.ttree_paths.setdefault( path, {})\n-        self.ttree_paths[path].setdefault( 'states', [] )\n-        self.ttree_paths[path]['states'].append( descendant_state )\n-        self.ttree_paths[path].setdefault( 'names', [] )\n-        self.ttree_paths[path]['names'].append( descendant_name )\n-\n-    def _get_autoexpand_rows( self ):\n+        path = self.ttreestore.get_path(row_iter)\n+        self.ttree_paths.setdefault(path, {})\n+        self.ttree_paths[path].setdefault('states', [])\n+        self.ttree_paths[path]['states'].append(descendant_state)\n+        self.ttree_paths[path].setdefault('names', [])\n+        self.ttree_paths[path]['names'].append(descendant_name)\n+\n+    def _get_autoexpand_rows(self):\n         # Return a list of rows that meet the auto-expansion criteria.","path":"lib/cylc/gui/updater_tree.py","position":380,"original_position":380,"commit_id":"eaa41d4e22c82c9cb9483589bb88a8785de16a51","original_commit_id":"eaa41d4e22c82c9cb9483589bb88a8785de16a51","user":{"login":"arjclark","id":2562650,"avatar_url":"https://avatars.githubusercontent.com/u/2562650?v=3","gravatar_id":"","url":"https://api.github.com/users/arjclark","html_url":"https://github.com/arjclark","followers_url":"https://api.github.com/users/arjclark/followers","following_url":"https://api.github.com/users/arjclark/following{/other_user}","gists_url":"https://api.github.com/users/arjclark/gists{/gist_id}","starred_url":"https://api.github.com/users/arjclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjclark/subscriptions","organizations_url":"https://api.github.com/users/arjclark/orgs","repos_url":"https://api.github.com/users/arjclark/repos","events_url":"https://api.github.com/users/arjclark/events{/privacy}","received_events_url":"https://api.github.com/users/arjclark/received_events","type":"User","site_admin":false},"body":"As above","created_at":"2015-11-16T12:24:00Z","updated_at":"2015-11-16T12:24:00Z","html_url":"https://github.com/cylc/cylc/pull/1667#discussion_r44917313","pull_request_url":"https://api.github.com/repos/cylc/cylc/pulls/1667","_links":{"self":{"href":"https://api.github.com/repos/cylc/cylc/pulls/comments/44917313"},"html":{"href":"https://github.com/cylc/cylc/pull/1667#discussion_r44917313"},"pull_request":{"href":"https://api.github.com/repos/cylc/cylc/pulls/1667"}}},"pull_request":{"url":"https://api.github.com/repos/cylc/cylc/pulls/1667","id":50131024,"html_url":"https://github.com/cylc/cylc/pull/1667","diff_url":"https://github.com/cylc/cylc/pull/1667.diff","patch_url":"https://github.com/cylc/cylc/pull/1667.patch","issue_url":"https://api.github.com/repos/cylc/cylc/issues/1667","number":1667,"state":"open","locked":false,"title":"PEP8 compliance","user":{"login":"matthewrmshin","id":908613,"avatar_url":"https://avatars.githubusercontent.com/u/908613?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewrmshin","html_url":"https://github.com/matthewrmshin","followers_url":"https://api.github.com/users/matthewrmshin/followers","following_url":"https://api.github.com/users/matthewrmshin/following{/other_user}","gists_url":"https://api.github.com/users/matthewrmshin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrmshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrmshin/subscriptions","organizations_url":"https://api.github.com/users/matthewrmshin/orgs","repos_url":"https://api.github.com/users/matthewrmshin/repos","events_url":"https://api.github.com/users/matthewrmshin/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrmshin/received_events","type":"User","site_admin":false},"body":"Modify Python source files in `bin/` and `lib/cylc/` for PEP8 compliance.\r\nAdd PEP8 test.\r\n\r\nSee metomi/rose#1739.","created_at":"2015-11-09T14:52:35Z","updated_at":"2015-11-16T12:24:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ebe48c349e2713c3a360305bd5a64b846eb0178","assignee":{"login":"arjclark","id":2562650,"avatar_url":"https://avatars.githubusercontent.com/u/2562650?v=3","gravatar_id":"","url":"https://api.github.com/users/arjclark","html_url":"https://github.com/arjclark","followers_url":"https://api.github.com/users/arjclark/followers","following_url":"https://api.github.com/users/arjclark/following{/other_user}","gists_url":"https://api.github.com/users/arjclark/gists{/gist_id}","starred_url":"https://api.github.com/users/arjclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjclark/subscriptions","organizations_url":"https://api.github.com/users/arjclark/orgs","repos_url":"https://api.github.com/users/arjclark/repos","events_url":"https://api.github.com/users/arjclark/events{/privacy}","received_events_url":"https://api.github.com/users/arjclark/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/cylc/cylc/milestones/44","html_url":"https://github.com/cylc/cylc/milestones/next%20release","labels_url":"https://api.github.com/repos/cylc/cylc/milestones/44/labels","id":1396763,"number":44,"title":"next release","description":"","creator":{"login":"hjoliver","id":2362137,"avatar_url":"https://avatars.githubusercontent.com/u/2362137?v=3","gravatar_id":"","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":7,"state":"open","created_at":"2015-11-06T00:37:11Z","updated_at":"2015-11-16T10:51:09Z","due_on":"2015-11-26T11:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cylc/cylc/pulls/1667/commits","review_comments_url":"https://api.github.com/repos/cylc/cylc/pulls/1667/comments","review_comment_url":"https://api.github.com/repos/cylc/cylc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cylc/cylc/issues/1667/comments","statuses_url":"https://api.github.com/repos/cylc/cylc/statuses/eaa41d4e22c82c9cb9483589bb88a8785de16a51","head":{"label":"matthewrmshin:pep8","ref":"pep8","sha":"eaa41d4e22c82c9cb9483589bb88a8785de16a51","user":{"login":"matthewrmshin","id":908613,"avatar_url":"https://avatars.githubusercontent.com/u/908613?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewrmshin","html_url":"https://github.com/matthewrmshin","followers_url":"https://api.github.com/users/matthewrmshin/followers","following_url":"https://api.github.com/users/matthewrmshin/following{/other_user}","gists_url":"https://api.github.com/users/matthewrmshin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrmshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrmshin/subscriptions","organizations_url":"https://api.github.com/users/matthewrmshin/orgs","repos_url":"https://api.github.com/users/matthewrmshin/repos","events_url":"https://api.github.com/users/matthewrmshin/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrmshin/received_events","type":"User","site_admin":false},"repo":{"id":4710539,"name":"cylc","full_name":"matthewrmshin/cylc","owner":{"login":"matthewrmshin","id":908613,"avatar_url":"https://avatars.githubusercontent.com/u/908613?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewrmshin","html_url":"https://github.com/matthewrmshin","followers_url":"https://api.github.com/users/matthewrmshin/followers","following_url":"https://api.github.com/users/matthewrmshin/following{/other_user}","gists_url":"https://api.github.com/users/matthewrmshin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrmshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrmshin/subscriptions","organizations_url":"https://api.github.com/users/matthewrmshin/orgs","repos_url":"https://api.github.com/users/matthewrmshin/repos","events_url":"https://api.github.com/users/matthewrmshin/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrmshin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewrmshin/cylc","description":"Cylc: an engine for running meteorological suites","fork":true,"url":"https://api.github.com/repos/matthewrmshin/cylc","forks_url":"https://api.github.com/repos/matthewrmshin/cylc/forks","keys_url":"https://api.github.com/repos/matthewrmshin/cylc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewrmshin/cylc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewrmshin/cylc/teams","hooks_url":"https://api.github.com/repos/matthewrmshin/cylc/hooks","issue_events_url":"https://api.github.com/repos/matthewrmshin/cylc/issues/events{/number}","events_url":"https://api.github.com/repos/matthewrmshin/cylc/events","assignees_url":"https://api.github.com/repos/matthewrmshin/cylc/assignees{/user}","branches_url":"https://api.github.com/repos/matthewrmshin/cylc/branches{/branch}","tags_url":"https://api.github.com/repos/matthewrmshin/cylc/tags","blobs_url":"https://api.github.com/repos/matthewrmshin/cylc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewrmshin/cylc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewrmshin/cylc/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewrmshin/cylc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewrmshin/cylc/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewrmshin/cylc/languages","stargazers_url":"https://api.github.com/repos/matthewrmshin/cylc/stargazers","contributors_url":"https://api.github.com/repos/matthewrmshin/cylc/contributors","subscribers_url":"https://api.github.com/repos/matthewrmshin/cylc/subscribers","subscription_url":"https://api.github.com/repos/matthewrmshin/cylc/subscription","commits_url":"https://api.github.com/repos/matthewrmshin/cylc/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewrmshin/cylc/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewrmshin/cylc/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewrmshin/cylc/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewrmshin/cylc/contents/{+path}","compare_url":"https://api.github.com/repos/matthewrmshin/cylc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewrmshin/cylc/merges","archive_url":"https://api.github.com/repos/matthewrmshin/cylc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewrmshin/cylc/downloads","issues_url":"https://api.github.com/repos/matthewrmshin/cylc/issues{/number}","pulls_url":"https://api.github.com/repos/matthewrmshin/cylc/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewrmshin/cylc/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewrmshin/cylc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewrmshin/cylc/labels{/name}","releases_url":"https://api.github.com/repos/matthewrmshin/cylc/releases{/id}","created_at":"2012-06-19T07:07:09Z","updated_at":"2015-05-08T11:59:22Z","pushed_at":"2015-11-16T10:53:26Z","git_url":"git://github.com/matthewrmshin/cylc.git","ssh_url":"git@github.com:matthewrmshin/cylc.git","clone_url":"https://github.com/matthewrmshin/cylc.git","svn_url":"https://github.com/matthewrmshin/cylc","homepage":"http://cylc.github.io/cylc/","size":74836,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"cylc:master","ref":"master","sha":"4859d4b5c144278d60fa158febb5732d35b449cc","user":{"login":"cylc","id":824878,"avatar_url":"https://avatars.githubusercontent.com/u/824878?v=3","gravatar_id":"","url":"https://api.github.com/users/cylc","html_url":"https://github.com/cylc","followers_url":"https://api.github.com/users/cylc/followers","following_url":"https://api.github.com/users/cylc/following{/other_user}","gists_url":"https://api.github.com/users/cylc/gists{/gist_id}","starred_url":"https://api.github.com/users/cylc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cylc/subscriptions","organizations_url":"https://api.github.com/users/cylc/orgs","repos_url":"https://api.github.com/users/cylc/repos","events_url":"https://api.github.com/users/cylc/events{/privacy}","received_events_url":"https://api.github.com/users/cylc/received_events","type":"Organization","site_admin":false},"repo":{"id":1836229,"name":"cylc","full_name":"cylc/cylc","owner":{"login":"cylc","id":824878,"avatar_url":"https://avatars.githubusercontent.com/u/824878?v=3","gravatar_id":"","url":"https://api.github.com/users/cylc","html_url":"https://github.com/cylc","followers_url":"https://api.github.com/users/cylc/followers","following_url":"https://api.github.com/users/cylc/following{/other_user}","gists_url":"https://api.github.com/users/cylc/gists{/gist_id}","starred_url":"https://api.github.com/users/cylc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cylc/subscriptions","organizations_url":"https://api.github.com/users/cylc/orgs","repos_url":"https://api.github.com/users/cylc/repos","events_url":"https://api.github.com/users/cylc/events{/privacy}","received_events_url":"https://api.github.com/users/cylc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cylc/cylc","description":"This is the official repository of the cylc suite engine. It will normally contain just the master branch, with completed features merged in from feature branches in developer forks.","fork":false,"url":"https://api.github.com/repos/cylc/cylc","forks_url":"https://api.github.com/repos/cylc/cylc/forks","keys_url":"https://api.github.com/repos/cylc/cylc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cylc/cylc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cylc/cylc/teams","hooks_url":"https://api.github.com/repos/cylc/cylc/hooks","issue_events_url":"https://api.github.com/repos/cylc/cylc/issues/events{/number}","events_url":"https://api.github.com/repos/cylc/cylc/events","assignees_url":"https://api.github.com/repos/cylc/cylc/assignees{/user}","branches_url":"https://api.github.com/repos/cylc/cylc/branches{/branch}","tags_url":"https://api.github.com/repos/cylc/cylc/tags","blobs_url":"https://api.github.com/repos/cylc/cylc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cylc/cylc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cylc/cylc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cylc/cylc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cylc/cylc/statuses/{sha}","languages_url":"https://api.github.com/repos/cylc/cylc/languages","stargazers_url":"https://api.github.com/repos/cylc/cylc/stargazers","contributors_url":"https://api.github.com/repos/cylc/cylc/contributors","subscribers_url":"https://api.github.com/repos/cylc/cylc/subscribers","subscription_url":"https://api.github.com/repos/cylc/cylc/subscription","commits_url":"https://api.github.com/repos/cylc/cylc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cylc/cylc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cylc/cylc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cylc/cylc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cylc/cylc/contents/{+path}","compare_url":"https://api.github.com/repos/cylc/cylc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cylc/cylc/merges","archive_url":"https://api.github.com/repos/cylc/cylc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cylc/cylc/downloads","issues_url":"https://api.github.com/repos/cylc/cylc/issues{/number}","pulls_url":"https://api.github.com/repos/cylc/cylc/pulls{/number}","milestones_url":"https://api.github.com/repos/cylc/cylc/milestones{/number}","notifications_url":"https://api.github.com/repos/cylc/cylc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cylc/cylc/labels{/name}","releases_url":"https://api.github.com/repos/cylc/cylc/releases{/id}","created_at":"2011-06-02T08:31:49Z","updated_at":"2015-11-04T09:25:44Z","pushed_at":"2015-11-16T10:51:10Z","git_url":"git://github.com/cylc/cylc.git","ssh_url":"git@github.com:cylc/cylc.git","clone_url":"https://github.com/cylc/cylc.git","svn_url":"https://github.com/cylc/cylc","homepage":"http://cylc.github.com/cylc","size":100162,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":171,"forks":18,"open_issues":171,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cylc/cylc/pulls/1667"},"html":{"href":"https://github.com/cylc/cylc/pull/1667"},"issue":{"href":"https://api.github.com/repos/cylc/cylc/issues/1667"},"comments":{"href":"https://api.github.com/repos/cylc/cylc/issues/1667/comments"},"review_comments":{"href":"https://api.github.com/repos/cylc/cylc/pulls/1667/comments"},"review_comment":{"href":"https://api.github.com/repos/cylc/cylc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cylc/cylc/pulls/1667/commits"},"statuses":{"href":"https://api.github.com/repos/cylc/cylc/statuses/eaa41d4e22c82c9cb9483589bb88a8785de16a51"}}}}