{"action":"created","issue":{"url":"https://api.github.com/repos/websudos/phantom/issues/276","labels_url":"https://api.github.com/repos/websudos/phantom/issues/276/labels{/name}","comments_url":"https://api.github.com/repos/websudos/phantom/issues/276/comments","events_url":"https://api.github.com/repos/websudos/phantom/issues/276/events","html_url":"https://github.com/websudos/phantom/issues/276","id":90303481,"number":276,"title":"Bugs with ByteBuffer/Blob handling in 1.8.x","user":{"login":"velvia","id":1062875,"avatar_url":"https://avatars.githubusercontent.com/u/1062875?v=3","gravatar_id":"","url":"https://api.github.com/users/velvia","html_url":"https://github.com/velvia","followers_url":"https://api.github.com/users/velvia/followers","following_url":"https://api.github.com/users/velvia/following{/other_user}","gists_url":"https://api.github.com/users/velvia/gists{/gist_id}","starred_url":"https://api.github.com/users/velvia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/velvia/subscriptions","organizations_url":"https://api.github.com/users/velvia/orgs","repos_url":"https://api.github.com/users/velvia/repos","events_url":"https://api.github.com/users/velvia/events{/privacy}","received_events_url":"https://api.github.com/users/velvia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-06-23T06:40:31Z","updated_at":"2015-08-25T12:52:00Z","closed_at":null,"body":"Phantom does not properly handle the following ByteBuffer conditions on write for Blob types in 1.8.x:\r\n\r\n* When the ByteBuffer position is nonzero, or\r\n* When the ByteBuffer position is zero, but the `arrayOffset` is nonzero.\r\n* When the ByteBuffer is direct allocated\r\n\r\nThis can be plainly seen in the code, in Primitives.scala, where the entire backing array of the byte buffer is used for serialization -- which only works for the simple case.\r\n\r\nI would be happy to submit a pull request, but I noticed the 1.9.x codebase is substantially different, so not sure what the authors recommend.   A fix would still make Blob writes workable for folks not ready to move to 1.9.x, so I still think it has value."},"comment":{"url":"https://api.github.com/repos/websudos/phantom/issues/comments/134575311","html_url":"https://github.com/websudos/phantom/issues/276#issuecomment-134575311","issue_url":"https://api.github.com/repos/websudos/phantom/issues/276","id":134575311,"user":{"login":"alexflav23","id":1645142,"avatar_url":"https://avatars.githubusercontent.com/u/1645142?v=3","gravatar_id":"","url":"https://api.github.com/users/alexflav23","html_url":"https://github.com/alexflav23","followers_url":"https://api.github.com/users/alexflav23/followers","following_url":"https://api.github.com/users/alexflav23/following{/other_user}","gists_url":"https://api.github.com/users/alexflav23/gists{/gist_id}","starred_url":"https://api.github.com/users/alexflav23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexflav23/subscriptions","organizations_url":"https://api.github.com/users/alexflav23/orgs","repos_url":"https://api.github.com/users/alexflav23/repos","events_url":"https://api.github.com/users/alexflav23/events{/privacy}","received_events_url":"https://api.github.com/users/alexflav23/received_events","type":"User","site_admin":false},"created_at":"2015-08-25T12:52:00Z","updated_at":"2015-08-25T12:52:00Z","body":"Hi @velvia,\r\n\r\nI wanted to ask if you think this would still be a requirement. Phantom has evolved quite a lot since the 1.8.x releases and many more months of improvements have been released since. Perhaps our efforts are much better spent improving the speed of upgrading and the documentation for upgrading to the latest version.\r\n\r\nI was considering scheduling the upgrade today for the upcoming sprint but before I do so it would be useful to know if it's still needed.\r\n\r\nRegards."}}