{"action":"opened","number":3510,"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3510","id":38139679,"html_url":"https://github.com/zfsonlinux/zfs/pull/3510","diff_url":"https://github.com/zfsonlinux/zfs/pull/3510.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/3510.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3510","number":3510,"state":"open","locked":false,"title":"Additional SYSV init script fixes (3).","user":{"login":"FransUrbo","id":572706,"avatar_url":"https://avatars.githubusercontent.com/u/572706?v=3","gravatar_id":"","url":"https://api.github.com/users/FransUrbo","html_url":"https://github.com/FransUrbo","followers_url":"https://api.github.com/users/FransUrbo/followers","following_url":"https://api.github.com/users/FransUrbo/following{/other_user}","gists_url":"https://api.github.com/users/FransUrbo/gists{/gist_id}","starred_url":"https://api.github.com/users/FransUrbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FransUrbo/subscriptions","organizations_url":"https://api.github.com/users/FransUrbo/orgs","repos_url":"https://api.github.com/users/FransUrbo/repos","events_url":"https://api.github.com/users/FransUrbo/events{/privacy}","received_events_url":"https://api.github.com/users/FransUrbo/received_events","type":"User","site_admin":false},"body":"Because #3509 came just after this commit was accepted and is related to the original problem the commit was supposed to fix, we need to solve the problem in another way.\r\n\r\n* Revert \"Additional SYSV init script fixes\" (commit 036391c980c1e6504352b770eb385806a951b1cb).\r\n* In read_mtab(), fix problems (!?) in the mounts file. It will record 'rpool 1' as 'rpool\\0401' instead of 'rpool\\00401' which seems to be the correct (at least as far as 'printf' is concerned). Use this using the external 'echo' command (and not the one built in to the shell) because the internal one would interpret the backslash code (incorrectly), giving us a ^A instead.\r\n* In reregister_mounts(), the mount command options differ depending on if we're remounting is a legacy or native Z filesystem.\r\n    \r\nSigned-off-by: Turbo Fredriksson turbo@bayour.com\r\nCloses #3488\r\nCloses #3509","created_at":"2015-06-19T19:25:44Z","updated_at":"2015-06-19T19:25:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3510/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3510/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3510/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/b7bdebde449d3f34878ccd7af40a57236f1497de","head":{"label":"FransUrbo:fixes.initscripts3","ref":"fixes.initscripts3","sha":"b7bdebde449d3f34878ccd7af40a57236f1497de","user":{"login":"FransUrbo","id":572706,"avatar_url":"https://avatars.githubusercontent.com/u/572706?v=3","gravatar_id":"","url":"https://api.github.com/users/FransUrbo","html_url":"https://github.com/FransUrbo","followers_url":"https://api.github.com/users/FransUrbo/followers","following_url":"https://api.github.com/users/FransUrbo/following{/other_user}","gists_url":"https://api.github.com/users/FransUrbo/gists{/gist_id}","starred_url":"https://api.github.com/users/FransUrbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FransUrbo/subscriptions","organizations_url":"https://api.github.com/users/FransUrbo/orgs","repos_url":"https://api.github.com/users/FransUrbo/repos","events_url":"https://api.github.com/users/FransUrbo/events{/privacy}","received_events_url":"https://api.github.com/users/FransUrbo/received_events","type":"User","site_admin":false},"repo":{"id":3354870,"name":"zfs","full_name":"FransUrbo/zfs","owner":{"login":"FransUrbo","id":572706,"avatar_url":"https://avatars.githubusercontent.com/u/572706?v=3","gravatar_id":"","url":"https://api.github.com/users/FransUrbo","html_url":"https://github.com/FransUrbo","followers_url":"https://api.github.com/users/FransUrbo/followers","following_url":"https://api.github.com/users/FransUrbo/following{/other_user}","gists_url":"https://api.github.com/users/FransUrbo/gists{/gist_id}","starred_url":"https://api.github.com/users/FransUrbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FransUrbo/subscriptions","organizations_url":"https://api.github.com/users/FransUrbo/orgs","repos_url":"https://api.github.com/users/FransUrbo/repos","events_url":"https://api.github.com/users/FransUrbo/events{/privacy}","received_events_url":"https://api.github.com/users/FransUrbo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FransUrbo/zfs","description":"Native ZFS for Linux","fork":true,"url":"https://api.github.com/repos/FransUrbo/zfs","forks_url":"https://api.github.com/repos/FransUrbo/zfs/forks","keys_url":"https://api.github.com/repos/FransUrbo/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FransUrbo/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FransUrbo/zfs/teams","hooks_url":"https://api.github.com/repos/FransUrbo/zfs/hooks","issue_events_url":"https://api.github.com/repos/FransUrbo/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/FransUrbo/zfs/events","assignees_url":"https://api.github.com/repos/FransUrbo/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/FransUrbo/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/FransUrbo/zfs/tags","blobs_url":"https://api.github.com/repos/FransUrbo/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FransUrbo/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FransUrbo/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/FransUrbo/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FransUrbo/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/FransUrbo/zfs/languages","stargazers_url":"https://api.github.com/repos/FransUrbo/zfs/stargazers","contributors_url":"https://api.github.com/repos/FransUrbo/zfs/contributors","subscribers_url":"https://api.github.com/repos/FransUrbo/zfs/subscribers","subscription_url":"https://api.github.com/repos/FransUrbo/zfs/subscription","commits_url":"https://api.github.com/repos/FransUrbo/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/FransUrbo/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/FransUrbo/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/FransUrbo/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/FransUrbo/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/FransUrbo/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FransUrbo/zfs/merges","archive_url":"https://api.github.com/repos/FransUrbo/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FransUrbo/zfs/downloads","issues_url":"https://api.github.com/repos/FransUrbo/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/FransUrbo/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/FransUrbo/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/FransUrbo/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FransUrbo/zfs/labels{/name}","releases_url":"https://api.github.com/repos/FransUrbo/zfs/releases{/id}","created_at":"2012-02-04T19:47:17Z","updated_at":"2015-05-03T13:46:34Z","pushed_at":"2015-06-19T19:15:09Z","git_url":"git://github.com/FransUrbo/zfs.git","ssh_url":"git@github.com:FransUrbo/zfs.git","clone_url":"https://github.com/FransUrbo/zfs.git","svn_url":"https://github.com/FransUrbo/zfs","homepage":"http://zfsonlinux.org/","size":26512,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":5,"default_branch":"FAVORITES"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"57ae840077e6c061bc57fb4860491f50b604d360","user":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"Native ZFS for Linux","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","created_at":"2009-12-14T20:20:34Z","updated_at":"2015-06-19T09:14:42Z","pushed_at":"2015-06-19T00:11:08Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":55616,"stargazers_count":1422,"watchers_count":1422,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":356,"mirror_url":null,"open_issues_count":763,"forks":356,"open_issues":763,"watchers":1422,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3510"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/3510"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/3510"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/3510/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3510/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3510/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/b7bdebde449d3f34878ccd7af40a57236f1497de"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":54,"deletions":16,"changed_files":1}}