{"action":"created","issue":{"url":"https://api.github.com/repos/servo/rust-mozjs/issues/194","labels_url":"https://api.github.com/repos/servo/rust-mozjs/issues/194/labels{/name}","comments_url":"https://api.github.com/repos/servo/rust-mozjs/issues/194/comments","events_url":"https://api.github.com/repos/servo/rust-mozjs/issues/194/events","html_url":"https://github.com/servo/rust-mozjs/issues/194","id":105827287,"number":194,"title":"Make Handle fields private","user":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-10T14:54:42Z","updated_at":"2015-09-10T20:11:52Z","closed_at":null,"body":"It's too easy for inexperienced JSAPI users to turn to manual Handle creation. We should hide the fields and add an unsafe `from_rooted_location` static method instead, so it's clearer what invariants must be upheld."},"comment":{"url":"https://api.github.com/repos/servo/rust-mozjs/issues/comments/139366476","html_url":"https://github.com/servo/rust-mozjs/issues/194#issuecomment-139366476","issue_url":"https://api.github.com/repos/servo/rust-mozjs/issues/194","id":139366476,"user":{"login":"michaelwu","id":719931,"avatar_url":"https://avatars.githubusercontent.com/u/719931?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelwu","html_url":"https://github.com/michaelwu","followers_url":"https://api.github.com/users/michaelwu/followers","following_url":"https://api.github.com/users/michaelwu/following{/other_user}","gists_url":"https://api.github.com/users/michaelwu/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwu/subscriptions","organizations_url":"https://api.github.com/users/michaelwu/orgs","repos_url":"https://api.github.com/users/michaelwu/repos","events_url":"https://api.github.com/users/michaelwu/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwu/received_events","type":"User","site_admin":false},"created_at":"2015-09-10T20:11:52Z","updated_at":"2015-09-10T20:11:52Z","body":"Was discussing this on IRC. I think we're close to the point where we can directly determine what fields should be public/private using the original headers. I made all the fields public originally to make things easier to use, but it's probably not necessary now. ptr in `Handle<T>` is private, so doing this would also fix this issue."}}