{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/comments/46060900","id":46060900,"diff_hunk":"@@ -87,42 +96,57 @@ private static string ApplyFixToSarif(string unfixedSarif)\n             return string.Join(Environment.NewLine, inputLines);\n         }\n \n-        /// <summary>\n-        /// Used to correct invalid SARIF generated by VS 2015 RTM Roslyn. \n-        /// Correctly escapes backslashes and quotes.\n-        /// \n-        /// Returns true if the output is valid SARIF (even if there was no change).\n-        /// </summary>\n-        public static bool FixRoslynV1Sarif(string unfixedSarif, out string output)\n+        #endregion\n+\n+        #region IRoslynV1SarifFixer\n+\n+        public string LoadAndFixFile(string sarifPath, ILogger logger)\n         {\n-            if (IsValidJson(unfixedSarif))\n+            if (!File.Exists(sarifPath))","path":"SonarRunner.Shim/RoslynV1SarifFixer.cs","position":64,"original_position":64,"commit_id":"99488f5eb65f083896680c2edc6cde973372e694","original_commit_id":"99488f5eb65f083896680c2edc6cde973372e694","user":{"login":"SonarLint","id":14070069,"avatar_url":"https://avatars.githubusercontent.com/u/14070069?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarLint","html_url":"https://github.com/SonarLint","followers_url":"https://api.github.com/users/SonarLint/followers","following_url":"https://api.github.com/users/SonarLint/following{/other_user}","gists_url":"https://api.github.com/users/SonarLint/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarLint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarLint/subscriptions","organizations_url":"https://api.github.com/users/SonarLint/orgs","repos_url":"https://api.github.com/users/SonarLint/repos","events_url":"https://api.github.com/users/SonarLint/events{/privacy}","received_events_url":"https://api.github.com/users/SonarLint/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) In member 'RoslynV1SarifFixer.LoadAndFixFile(string, ILogger)', change parameter name 'sarifPath' to 'sarifFilePath' in order to match the identifier as it has been declared in 'IRoslynV1SarifFixer.LoadAndFixFile(string, ILogger)'. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://nemo.sonarqube.org/coding_rules#rule_key=fxcop%3AParameterNamesShouldMatchBaseDeclaration)\n","created_at":"2015-11-27T16:46:19Z","updated_at":"2015-11-27T16:46:19Z","html_url":"https://github.com/SonarSource/sonar-msbuild-runner/pull/160#discussion_r46060900","pull_request_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/160","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/comments/46060900"},"html":{"href":"https://github.com/SonarSource/sonar-msbuild-runner/pull/160#discussion_r46060900"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/160","id":51932196,"html_url":"https://github.com/SonarSource/sonar-msbuild-runner/pull/160","diff_url":"https://github.com/SonarSource/sonar-msbuild-runner/pull/160.diff","patch_url":"https://github.com/SonarSource/sonar-msbuild-runner/pull/160.patch","issue_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/issues/160","number":160,"state":"open","locked":false,"title":"[SONARMSBRU-177] Implementation of functionality from e50f070","user":{"login":"HSAR","id":985911,"avatar_url":"https://avatars.githubusercontent.com/u/985911?v=3","gravatar_id":"","url":"https://api.github.com/users/HSAR","html_url":"https://github.com/HSAR","followers_url":"https://api.github.com/users/HSAR/followers","following_url":"https://api.github.com/users/HSAR/following{/other_user}","gists_url":"https://api.github.com/users/HSAR/gists{/gist_id}","starred_url":"https://api.github.com/users/HSAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HSAR/subscriptions","organizations_url":"https://api.github.com/users/HSAR/orgs","repos_url":"https://api.github.com/users/HSAR/repos","events_url":"https://api.github.com/users/HSAR/events{/privacy}","received_events_url":"https://api.github.com/users/HSAR/received_events","type":"User","site_admin":false},"body":"At long, long last.","created_at":"2015-11-26T16:46:00Z","updated_at":"2015-11-27T16:46:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"012685d59c1590c0f5fdb744f75b83aa0199892c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/160/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/160/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/issues/160/comments","statuses_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/statuses/99488f5eb65f083896680c2edc6cde973372e694","head":{"label":"HSAR:master","ref":"master","sha":"99488f5eb65f083896680c2edc6cde973372e694","user":{"login":"HSAR","id":985911,"avatar_url":"https://avatars.githubusercontent.com/u/985911?v=3","gravatar_id":"","url":"https://api.github.com/users/HSAR","html_url":"https://github.com/HSAR","followers_url":"https://api.github.com/users/HSAR/followers","following_url":"https://api.github.com/users/HSAR/following{/other_user}","gists_url":"https://api.github.com/users/HSAR/gists{/gist_id}","starred_url":"https://api.github.com/users/HSAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HSAR/subscriptions","organizations_url":"https://api.github.com/users/HSAR/orgs","repos_url":"https://api.github.com/users/HSAR/repos","events_url":"https://api.github.com/users/HSAR/events{/privacy}","received_events_url":"https://api.github.com/users/HSAR/received_events","type":"User","site_admin":false},"repo":{"id":46124465,"name":"sonar-msbuild-runner","full_name":"HSAR/sonar-msbuild-runner","owner":{"login":"HSAR","id":985911,"avatar_url":"https://avatars.githubusercontent.com/u/985911?v=3","gravatar_id":"","url":"https://api.github.com/users/HSAR","html_url":"https://github.com/HSAR","followers_url":"https://api.github.com/users/HSAR/followers","following_url":"https://api.github.com/users/HSAR/following{/other_user}","gists_url":"https://api.github.com/users/HSAR/gists{/gist_id}","starred_url":"https://api.github.com/users/HSAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HSAR/subscriptions","organizations_url":"https://api.github.com/users/HSAR/orgs","repos_url":"https://api.github.com/users/HSAR/repos","events_url":"https://api.github.com/users/HSAR/events{/privacy}","received_events_url":"https://api.github.com/users/HSAR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HSAR/sonar-msbuild-runner","description":"","fork":true,"url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner","forks_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/forks","keys_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/teams","hooks_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/hooks","issue_events_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/issues/events{/number}","events_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/events","assignees_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/assignees{/user}","branches_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/branches{/branch}","tags_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/tags","blobs_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/statuses/{sha}","languages_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/languages","stargazers_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/stargazers","contributors_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/contributors","subscribers_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/subscribers","subscription_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/subscription","commits_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/issues/comments{/number}","contents_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/contents/{+path}","compare_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/merges","archive_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/downloads","issues_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/issues{/number}","pulls_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/pulls{/number}","milestones_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/milestones{/number}","notifications_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/labels{/name}","releases_url":"https://api.github.com/repos/HSAR/sonar-msbuild-runner/releases{/id}","created_at":"2015-11-13T13:48:17Z","updated_at":"2015-11-13T13:48:19Z","pushed_at":"2015-11-27T16:43:31Z","git_url":"git://github.com/HSAR/sonar-msbuild-runner.git","ssh_url":"git@github.com:HSAR/sonar-msbuild-runner.git","clone_url":"https://github.com/HSAR/sonar-msbuild-runner.git","svn_url":"https://github.com/HSAR/sonar-msbuild-runner","homepage":null,"size":2924,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"aacbb82bbd60048f1b5bcbc8776858174d12783f","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":34444711,"name":"sonar-msbuild-runner","full_name":"SonarSource/sonar-msbuild-runner","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars.githubusercontent.com/u/545988?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonar-msbuild-runner","description":"","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner","forks_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/releases{/id}","created_at":"2015-04-23T08:45:40Z","updated_at":"2015-11-26T11:29:59Z","pushed_at":"2015-11-27T16:43:31Z","git_url":"git://github.com/SonarSource/sonar-msbuild-runner.git","ssh_url":"git@github.com:SonarSource/sonar-msbuild-runner.git","clone_url":"https://github.com/SonarSource/sonar-msbuild-runner.git","svn_url":"https://github.com/SonarSource/sonar-msbuild-runner","homepage":null,"size":3051,"stargazers_count":24,"watchers_count":24,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":6,"forks":22,"open_issues":6,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/160"},"html":{"href":"https://github.com/SonarSource/sonar-msbuild-runner/pull/160"},"issue":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/issues/160"},"comments":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sonar-msbuild-runner/statuses/99488f5eb65f083896680c2edc6cde973372e694"}}}}