{"action":"created","comment":{"url":"https://api.github.com/repos/for-GET/katt/pulls/comments/45601062","id":45601062,"diff_hunk":"@@ -241,7 +245,30 @@ http_request( #katt_request{ method = Method\n   Hdrs1 = proplists:delete(\"x-katt-sleep\", Hdrs0),\n   Hdrs = proplists:delete(\"x-katt-timeout\", Hdrs1),\n   timer:sleep(Sleep),\n-  lhttpc:request(Url, Method, Hdrs, Body, Timeout, []).\n+  %% need to module-prefixed call for meck's case\n+  %% http_request_now(Url, Method, Hdrs, Body, Timeout, []).\n+  katt_callbacks:http_request_now(Url, Method, Hdrs, Body, Timeout, []).\n+\n+http_request_now(Url, Method, Hdrs, Body, Timeout, []) ->","path":"src/katt_callbacks.erl","position":20,"original_position":20,"commit_id":"e60a62e3a49f8b5f4740ee3eca6c7ed54858e970","original_commit_id":"e60a62e3a49f8b5f4740ee3eca6c7ed54858e970","user":{"login":"sstrigler","id":23786,"avatar_url":"https://avatars.githubusercontent.com/u/23786?v=3","gravatar_id":"","url":"https://api.github.com/users/sstrigler","html_url":"https://github.com/sstrigler","followers_url":"https://api.github.com/users/sstrigler/followers","following_url":"https://api.github.com/users/sstrigler/following{/other_user}","gists_url":"https://api.github.com/users/sstrigler/gists{/gist_id}","starred_url":"https://api.github.com/users/sstrigler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstrigler/subscriptions","organizations_url":"https://api.github.com/users/sstrigler/orgs","repos_url":"https://api.github.com/users/sstrigler/repos","events_url":"https://api.github.com/users/sstrigler/events{/privacy}","received_events_url":"https://api.github.com/users/sstrigler/received_events","type":"User","site_admin":false},"body":"Re: util - I don't see a reason why a wrapper around an http client shouldn't be in some *_util, except for when it would go to its own module. Apart from that, why \"external\"?\r\n\r\nRe: fusco - we switched to it for almost any of our internal and opensource projects, it's probably not the worst. I think it can be regarded as the official successor of lhttpc. That said, nothing against using hackney either.\r\n\r\nI could offer to clean that up if you could be more clear what has to be done besides replacing lhttpc. What's wrong with the tests?","created_at":"2015-11-23T13:10:46Z","updated_at":"2015-11-23T13:10:46Z","html_url":"https://github.com/for-GET/katt/pull/21#discussion_r45601062","pull_request_url":"https://api.github.com/repos/for-GET/katt/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/for-GET/katt/pulls/comments/45601062"},"html":{"href":"https://github.com/for-GET/katt/pull/21#discussion_r45601062"},"pull_request":{"href":"https://api.github.com/repos/for-GET/katt/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/for-GET/katt/pulls/21","id":51400936,"html_url":"https://github.com/for-GET/katt/pull/21","diff_url":"https://github.com/for-GET/katt/pull/21.diff","patch_url":"https://github.com/for-GET/katt/pull/21.patch","issue_url":"https://api.github.com/repos/for-GET/katt/issues/21","number":21,"state":"open","locked":false,"title":"lhttpc -> hackney. fixes #17","user":{"login":"andreineculau","id":708161,"avatar_url":"https://avatars.githubusercontent.com/u/708161?v=3","gravatar_id":"","url":"https://api.github.com/users/andreineculau","html_url":"https://github.com/andreineculau","followers_url":"https://api.github.com/users/andreineculau/followers","following_url":"https://api.github.com/users/andreineculau/following{/other_user}","gists_url":"https://api.github.com/users/andreineculau/gists{/gist_id}","starred_url":"https://api.github.com/users/andreineculau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreineculau/subscriptions","organizations_url":"https://api.github.com/users/andreineculau/orgs","repos_url":"https://api.github.com/users/andreineculau/repos","events_url":"https://api.github.com/users/andreineculau/events{/privacy}","received_events_url":"https://api.github.com/users/andreineculau/received_events","type":"User","site_admin":false},"body":"Hackney WARNING: **Supported versions of Erlang are R16B03-1, 17.3.4 and above. It is reported to work with R14B04 and R15B03-1.**","created_at":"2015-11-20T19:58:57Z","updated_at":"2015-11-23T13:10:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbe77135dd7eadeff37bfcb2ef946902470ca412","assignee":null,"milestone":{"url":"https://api.github.com/repos/for-GET/katt/milestones/2","html_url":"https://github.com/for-GET/katt/milestones/1.4.0","labels_url":"https://api.github.com/repos/for-GET/katt/milestones/2/labels","id":986723,"number":2,"title":"1.4.0","description":"","creator":{"login":"andreineculau","id":708161,"avatar_url":"https://avatars.githubusercontent.com/u/708161?v=3","gravatar_id":"","url":"https://api.github.com/users/andreineculau","html_url":"https://github.com/andreineculau","followers_url":"https://api.github.com/users/andreineculau/followers","following_url":"https://api.github.com/users/andreineculau/following{/other_user}","gists_url":"https://api.github.com/users/andreineculau/gists{/gist_id}","starred_url":"https://api.github.com/users/andreineculau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreineculau/subscriptions","organizations_url":"https://api.github.com/users/andreineculau/orgs","repos_url":"https://api.github.com/users/andreineculau/repos","events_url":"https://api.github.com/users/andreineculau/events{/privacy}","received_events_url":"https://api.github.com/users/andreineculau/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":6,"state":"open","created_at":"2015-02-19T14:09:01Z","updated_at":"2015-11-20T20:00:51Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/for-GET/katt/pulls/21/commits","review_comments_url":"https://api.github.com/repos/for-GET/katt/pulls/21/comments","review_comment_url":"https://api.github.com/repos/for-GET/katt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/for-GET/katt/issues/21/comments","statuses_url":"https://api.github.com/repos/for-GET/katt/statuses/e60a62e3a49f8b5f4740ee3eca6c7ed54858e970","head":{"label":"for-GET:no-lhttpc-17","ref":"no-lhttpc-17","sha":"e60a62e3a49f8b5f4740ee3eca6c7ed54858e970","user":{"login":"for-GET","id":5500015,"avatar_url":"https://avatars.githubusercontent.com/u/5500015?v=3","gravatar_id":"","url":"https://api.github.com/users/for-GET","html_url":"https://github.com/for-GET","followers_url":"https://api.github.com/users/for-GET/followers","following_url":"https://api.github.com/users/for-GET/following{/other_user}","gists_url":"https://api.github.com/users/for-GET/gists{/gist_id}","starred_url":"https://api.github.com/users/for-GET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/for-GET/subscriptions","organizations_url":"https://api.github.com/users/for-GET/orgs","repos_url":"https://api.github.com/users/for-GET/repos","events_url":"https://api.github.com/users/for-GET/events{/privacy}","received_events_url":"https://api.github.com/users/for-GET/received_events","type":"Organization","site_admin":false},"repo":{"id":12784425,"name":"katt","full_name":"for-GET/katt","owner":{"login":"for-GET","id":5500015,"avatar_url":"https://avatars.githubusercontent.com/u/5500015?v=3","gravatar_id":"","url":"https://api.github.com/users/for-GET","html_url":"https://github.com/for-GET","followers_url":"https://api.github.com/users/for-GET/followers","following_url":"https://api.github.com/users/for-GET/following{/other_user}","gists_url":"https://api.github.com/users/for-GET/gists{/gist_id}","starred_url":"https://api.github.com/users/for-GET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/for-GET/subscriptions","organizations_url":"https://api.github.com/users/for-GET/orgs","repos_url":"https://api.github.com/users/for-GET/repos","events_url":"https://api.github.com/users/for-GET/events{/privacy}","received_events_url":"https://api.github.com/users/for-GET/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/for-GET/katt","description":"KATT (Klarna API Testing Tool) is an HTTP-based API testing tool for Erlang.","fork":true,"url":"https://api.github.com/repos/for-GET/katt","forks_url":"https://api.github.com/repos/for-GET/katt/forks","keys_url":"https://api.github.com/repos/for-GET/katt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/for-GET/katt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/for-GET/katt/teams","hooks_url":"https://api.github.com/repos/for-GET/katt/hooks","issue_events_url":"https://api.github.com/repos/for-GET/katt/issues/events{/number}","events_url":"https://api.github.com/repos/for-GET/katt/events","assignees_url":"https://api.github.com/repos/for-GET/katt/assignees{/user}","branches_url":"https://api.github.com/repos/for-GET/katt/branches{/branch}","tags_url":"https://api.github.com/repos/for-GET/katt/tags","blobs_url":"https://api.github.com/repos/for-GET/katt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/for-GET/katt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/for-GET/katt/git/refs{/sha}","trees_url":"https://api.github.com/repos/for-GET/katt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/for-GET/katt/statuses/{sha}","languages_url":"https://api.github.com/repos/for-GET/katt/languages","stargazers_url":"https://api.github.com/repos/for-GET/katt/stargazers","contributors_url":"https://api.github.com/repos/for-GET/katt/contributors","subscribers_url":"https://api.github.com/repos/for-GET/katt/subscribers","subscription_url":"https://api.github.com/repos/for-GET/katt/subscription","commits_url":"https://api.github.com/repos/for-GET/katt/commits{/sha}","git_commits_url":"https://api.github.com/repos/for-GET/katt/git/commits{/sha}","comments_url":"https://api.github.com/repos/for-GET/katt/comments{/number}","issue_comment_url":"https://api.github.com/repos/for-GET/katt/issues/comments{/number}","contents_url":"https://api.github.com/repos/for-GET/katt/contents/{+path}","compare_url":"https://api.github.com/repos/for-GET/katt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/for-GET/katt/merges","archive_url":"https://api.github.com/repos/for-GET/katt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/for-GET/katt/downloads","issues_url":"https://api.github.com/repos/for-GET/katt/issues{/number}","pulls_url":"https://api.github.com/repos/for-GET/katt/pulls{/number}","milestones_url":"https://api.github.com/repos/for-GET/katt/milestones{/number}","notifications_url":"https://api.github.com/repos/for-GET/katt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/for-GET/katt/labels{/name}","releases_url":"https://api.github.com/repos/for-GET/katt/releases{/id}","created_at":"2013-09-12T13:32:13Z","updated_at":"2015-10-13T04:40:42Z","pushed_at":"2015-11-20T22:32:00Z","git_url":"git://github.com/for-GET/katt.git","ssh_url":"git@github.com:for-GET/katt.git","clone_url":"https://github.com/for-GET/katt.git","svn_url":"https://github.com/for-GET/katt","homepage":"https://github.com/for-GET/katt/tree/develop","size":2042,"stargazers_count":17,"watchers_count":17,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":17,"default_branch":"develop"}},"base":{"label":"for-GET:develop","ref":"develop","sha":"1cb2b0ba4267cffaeb9f2e6574456cb845c3ded9","user":{"login":"for-GET","id":5500015,"avatar_url":"https://avatars.githubusercontent.com/u/5500015?v=3","gravatar_id":"","url":"https://api.github.com/users/for-GET","html_url":"https://github.com/for-GET","followers_url":"https://api.github.com/users/for-GET/followers","following_url":"https://api.github.com/users/for-GET/following{/other_user}","gists_url":"https://api.github.com/users/for-GET/gists{/gist_id}","starred_url":"https://api.github.com/users/for-GET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/for-GET/subscriptions","organizations_url":"https://api.github.com/users/for-GET/orgs","repos_url":"https://api.github.com/users/for-GET/repos","events_url":"https://api.github.com/users/for-GET/events{/privacy}","received_events_url":"https://api.github.com/users/for-GET/received_events","type":"Organization","site_admin":false},"repo":{"id":12784425,"name":"katt","full_name":"for-GET/katt","owner":{"login":"for-GET","id":5500015,"avatar_url":"https://avatars.githubusercontent.com/u/5500015?v=3","gravatar_id":"","url":"https://api.github.com/users/for-GET","html_url":"https://github.com/for-GET","followers_url":"https://api.github.com/users/for-GET/followers","following_url":"https://api.github.com/users/for-GET/following{/other_user}","gists_url":"https://api.github.com/users/for-GET/gists{/gist_id}","starred_url":"https://api.github.com/users/for-GET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/for-GET/subscriptions","organizations_url":"https://api.github.com/users/for-GET/orgs","repos_url":"https://api.github.com/users/for-GET/repos","events_url":"https://api.github.com/users/for-GET/events{/privacy}","received_events_url":"https://api.github.com/users/for-GET/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/for-GET/katt","description":"KATT (Klarna API Testing Tool) is an HTTP-based API testing tool for Erlang.","fork":true,"url":"https://api.github.com/repos/for-GET/katt","forks_url":"https://api.github.com/repos/for-GET/katt/forks","keys_url":"https://api.github.com/repos/for-GET/katt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/for-GET/katt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/for-GET/katt/teams","hooks_url":"https://api.github.com/repos/for-GET/katt/hooks","issue_events_url":"https://api.github.com/repos/for-GET/katt/issues/events{/number}","events_url":"https://api.github.com/repos/for-GET/katt/events","assignees_url":"https://api.github.com/repos/for-GET/katt/assignees{/user}","branches_url":"https://api.github.com/repos/for-GET/katt/branches{/branch}","tags_url":"https://api.github.com/repos/for-GET/katt/tags","blobs_url":"https://api.github.com/repos/for-GET/katt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/for-GET/katt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/for-GET/katt/git/refs{/sha}","trees_url":"https://api.github.com/repos/for-GET/katt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/for-GET/katt/statuses/{sha}","languages_url":"https://api.github.com/repos/for-GET/katt/languages","stargazers_url":"https://api.github.com/repos/for-GET/katt/stargazers","contributors_url":"https://api.github.com/repos/for-GET/katt/contributors","subscribers_url":"https://api.github.com/repos/for-GET/katt/subscribers","subscription_url":"https://api.github.com/repos/for-GET/katt/subscription","commits_url":"https://api.github.com/repos/for-GET/katt/commits{/sha}","git_commits_url":"https://api.github.com/repos/for-GET/katt/git/commits{/sha}","comments_url":"https://api.github.com/repos/for-GET/katt/comments{/number}","issue_comment_url":"https://api.github.com/repos/for-GET/katt/issues/comments{/number}","contents_url":"https://api.github.com/repos/for-GET/katt/contents/{+path}","compare_url":"https://api.github.com/repos/for-GET/katt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/for-GET/katt/merges","archive_url":"https://api.github.com/repos/for-GET/katt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/for-GET/katt/downloads","issues_url":"https://api.github.com/repos/for-GET/katt/issues{/number}","pulls_url":"https://api.github.com/repos/for-GET/katt/pulls{/number}","milestones_url":"https://api.github.com/repos/for-GET/katt/milestones{/number}","notifications_url":"https://api.github.com/repos/for-GET/katt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/for-GET/katt/labels{/name}","releases_url":"https://api.github.com/repos/for-GET/katt/releases{/id}","created_at":"2013-09-12T13:32:13Z","updated_at":"2015-10-13T04:40:42Z","pushed_at":"2015-11-20T22:32:00Z","git_url":"git://github.com/for-GET/katt.git","ssh_url":"git@github.com:for-GET/katt.git","clone_url":"https://github.com/for-GET/katt.git","svn_url":"https://github.com/for-GET/katt","homepage":"https://github.com/for-GET/katt/tree/develop","size":2042,"stargazers_count":17,"watchers_count":17,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":17,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/for-GET/katt/pulls/21"},"html":{"href":"https://github.com/for-GET/katt/pull/21"},"issue":{"href":"https://api.github.com/repos/for-GET/katt/issues/21"},"comments":{"href":"https://api.github.com/repos/for-GET/katt/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/for-GET/katt/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/for-GET/katt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/for-GET/katt/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/for-GET/katt/statuses/e60a62e3a49f8b5f4740ee3eca6c7ed54858e970"}}}}