{"action":"created","issue":{"url":"https://api.github.com/repos/openpnp/openpnp/issues/157","labels_url":"https://api.github.com/repos/openpnp/openpnp/issues/157/labels{/name}","comments_url":"https://api.github.com/repos/openpnp/openpnp/issues/157/comments","events_url":"https://api.github.com/repos/openpnp/openpnp/issues/157/events","html_url":"https://github.com/openpnp/openpnp/pull/157","id":109715621,"number":157,"title":"Develop","user":{"login":"DouglasPearless","id":3744251,"avatar_url":"https://avatars.githubusercontent.com/u/3744251?v=3","gravatar_id":"","url":"https://api.github.com/users/DouglasPearless","html_url":"https://github.com/DouglasPearless","followers_url":"https://api.github.com/users/DouglasPearless/followers","following_url":"https://api.github.com/users/DouglasPearless/following{/other_user}","gists_url":"https://api.github.com/users/DouglasPearless/gists{/gist_id}","starred_url":"https://api.github.com/users/DouglasPearless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DouglasPearless/subscriptions","organizations_url":"https://api.github.com/users/DouglasPearless/orgs","repos_url":"https://api.github.com/users/DouglasPearless/repos","events_url":"https://api.github.com/users/DouglasPearless/events{/privacy}","received_events_url":"https://api.github.com/users/DouglasPearless/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":23,"created_at":"2015-10-05T00:40:55Z","updated_at":"2015-10-06T03:07:39Z","closed_at":"2015-10-06T02:16:59Z","pull_request":{"url":"https://api.github.com/repos/openpnp/openpnp/pulls/157","html_url":"https://github.com/openpnp/openpnp/pull/157","diff_url":"https://github.com/openpnp/openpnp/pull/157.diff","patch_url":"https://github.com/openpnp/openpnp/pull/157.patch"},"body":"Eagle Board importer, works for all footprints except polygons which are on the todo list, merged into the BoardPad change, includes SolderPaste generation."},"comment":{"url":"https://api.github.com/repos/openpnp/openpnp/issues/comments/145730061","html_url":"https://github.com/openpnp/openpnp/pull/157#issuecomment-145730061","issue_url":"https://api.github.com/repos/openpnp/openpnp/issues/157","id":145730061,"user":{"login":"DouglasPearless","id":3744251,"avatar_url":"https://avatars.githubusercontent.com/u/3744251?v=3","gravatar_id":"","url":"https://api.github.com/users/DouglasPearless","html_url":"https://github.com/DouglasPearless","followers_url":"https://api.github.com/users/DouglasPearless/followers","following_url":"https://api.github.com/users/DouglasPearless/following{/other_user}","gists_url":"https://api.github.com/users/DouglasPearless/gists{/gist_id}","starred_url":"https://api.github.com/users/DouglasPearless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DouglasPearless/subscriptions","organizations_url":"https://api.github.com/users/DouglasPearless/orgs","repos_url":"https://api.github.com/users/DouglasPearless/repos","events_url":"https://api.github.com/users/DouglasPearless/events{/privacy}","received_events_url":"https://api.github.com/users/DouglasPearless/received_events","type":"User","site_admin":false},"created_at":"2015-10-06T03:07:39Z","updated_at":"2015-10-06T03:07:39Z","body":"Hi,\n\nI was going to remove that in the interim until we all agree on having a proper library construct so all good.\n\nI assume that if / when we add that to Part it will break every ones Part.xml file, so that leads me to ask how should OpenPnP handle versioning of such files, in the past projects I have put a version number in the XML file so programs can automatically upgrade XML files (usually only forwards and not for backwards compatibility) and / or handle different XML file versions as required.\n\nThis could be a useful discussion to be had on the forum as with a (hopefully) rapidly evolving system, it should really address this principle from the start.\n\nCheers\nDouglas\n> On 6/10/2015, at 3:50 pm, Jason von Nieda <notifications@github.com> wrote:\n> \n> Hi @DouglasPearless <https://github.com/DouglasPearless>, just letting you know I removed libraryId from Part. It was being set but never read, and it was not being stored in the parts.xml (no @Attribute <https://github.com/Attribute>) so it was not actually being used for anything. I realize that this is something you may want to use in the future, and I am okay with it being added back when the functionality is needed, but for now I don't want it there if it's not being used.\n> \n> —\n> Reply to this email directly or view it on GitHub <https://github.com/openpnp/openpnp/pull/157#issuecomment-145728518>.\n> \n\n"}}