{"action":"created","comment":{"url":"https://api.github.com/repos/neos/neos-development-collection/pulls/comments/39279154","id":39279154,"diff_hunk":"@@ -41,9 +41,11 @@ prototype(TYPO3.Neos.NodeTypes:Menu) {\n # Image TS Object\n prototype(TYPO3.Neos.NodeTypes:Image) {\n \tmaximumWidth = 2560","path":"TYPO3.Neos.NodeTypes/Resources/Private/TypoScript/Root.ts2","position":3,"original_position":3,"commit_id":"4b0c0267a8d307cdfa0aa50261d000377193e8f3","original_commit_id":"4b0c0267a8d307cdfa0aa50261d000377193e8f3","user":{"login":"dfeyer","id":221173,"avatar_url":"https://avatars.githubusercontent.com/u/221173?v=3","gravatar_id":"","url":"https://api.github.com/users/dfeyer","html_url":"https://github.com/dfeyer","followers_url":"https://api.github.com/users/dfeyer/followers","following_url":"https://api.github.com/users/dfeyer/following{/other_user}","gists_url":"https://api.github.com/users/dfeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dfeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfeyer/subscriptions","organizations_url":"https://api.github.com/users/dfeyer/orgs","repos_url":"https://api.github.com/users/dfeyer/repos","events_url":"https://api.github.com/users/dfeyer/events{/privacy}","received_events_url":"https://api.github.com/users/dfeyer/received_events","type":"User","site_admin":false},"body":"I think this magic number should be set to NULL in this case the image w/h will be used automatically ","created_at":"2015-09-11T14:54:58Z","updated_at":"2015-09-11T14:54:58Z","html_url":"https://github.com/neos/neos-development-collection/pull/60#discussion_r39279154","pull_request_url":"https://api.github.com/repos/neos/neos-development-collection/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/comments/39279154"},"html":{"href":"https://github.com/neos/neos-development-collection/pull/60#discussion_r39279154"},"pull_request":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/neos/neos-development-collection/pulls/60","id":44791052,"html_url":"https://github.com/neos/neos-development-collection/pull/60","diff_url":"https://github.com/neos/neos-development-collection/pull/60.diff","patch_url":"https://github.com/neos/neos-development-collection/pull/60.patch","issue_url":"https://api.github.com/repos/neos/neos-development-collection/issues/60","number":60,"state":"open","locked":false,"title":"[WIP][!!!][TASK] Add support to force thumbnail ratio","user":{"login":"dfeyer","id":221173,"avatar_url":"https://avatars.githubusercontent.com/u/221173?v=3","gravatar_id":"","url":"https://api.github.com/users/dfeyer","html_url":"https://github.com/dfeyer","followers_url":"https://api.github.com/users/dfeyer/followers","following_url":"https://api.github.com/users/dfeyer/following{/other_user}","gists_url":"https://api.github.com/users/dfeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dfeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfeyer/subscriptions","organizations_url":"https://api.github.com/users/dfeyer/orgs","repos_url":"https://api.github.com/users/dfeyer/repos","events_url":"https://api.github.com/users/dfeyer/events{/privacy}","received_events_url":"https://api.github.com/users/dfeyer/received_events","type":"User","site_admin":false},"body":"This change allow to set fixed width and height in Image ViewHelpers, TS Objects and change the internal API to generate thumbnail.\r\n\r\nThis change is currently breaking, will try to mitigate this before merging.\r\n\r\n","created_at":"2015-09-11T14:50:13Z","updated_at":"2015-09-11T14:54:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"016a0f455c842208715412a75385e80342a27e49","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neos/neos-development-collection/pulls/60/commits","review_comments_url":"https://api.github.com/repos/neos/neos-development-collection/pulls/60/comments","review_comment_url":"https://api.github.com/repos/neos/neos-development-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neos/neos-development-collection/issues/60/comments","statuses_url":"https://api.github.com/repos/neos/neos-development-collection/statuses/4b0c0267a8d307cdfa0aa50261d000377193e8f3","head":{"label":"dfeyer:fix-thumbnail-width-height-support","ref":"fix-thumbnail-width-height-support","sha":"4b0c0267a8d307cdfa0aa50261d000377193e8f3","user":{"login":"dfeyer","id":221173,"avatar_url":"https://avatars.githubusercontent.com/u/221173?v=3","gravatar_id":"","url":"https://api.github.com/users/dfeyer","html_url":"https://github.com/dfeyer","followers_url":"https://api.github.com/users/dfeyer/followers","following_url":"https://api.github.com/users/dfeyer/following{/other_user}","gists_url":"https://api.github.com/users/dfeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dfeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfeyer/subscriptions","organizations_url":"https://api.github.com/users/dfeyer/orgs","repos_url":"https://api.github.com/users/dfeyer/repos","events_url":"https://api.github.com/users/dfeyer/events{/privacy}","received_events_url":"https://api.github.com/users/dfeyer/received_events","type":"User","site_admin":false},"repo":{"id":41052872,"name":"neos-development-collection","full_name":"dfeyer/neos-development-collection","owner":{"login":"dfeyer","id":221173,"avatar_url":"https://avatars.githubusercontent.com/u/221173?v=3","gravatar_id":"","url":"https://api.github.com/users/dfeyer","html_url":"https://github.com/dfeyer","followers_url":"https://api.github.com/users/dfeyer/followers","following_url":"https://api.github.com/users/dfeyer/following{/other_user}","gists_url":"https://api.github.com/users/dfeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dfeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfeyer/subscriptions","organizations_url":"https://api.github.com/users/dfeyer/orgs","repos_url":"https://api.github.com/users/dfeyer/repos","events_url":"https://api.github.com/users/dfeyer/events{/privacy}","received_events_url":"https://api.github.com/users/dfeyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dfeyer/neos-development-collection","description":"The unified repository containing the Neos core packages, used for Neos development.","fork":true,"url":"https://api.github.com/repos/dfeyer/neos-development-collection","forks_url":"https://api.github.com/repos/dfeyer/neos-development-collection/forks","keys_url":"https://api.github.com/repos/dfeyer/neos-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dfeyer/neos-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dfeyer/neos-development-collection/teams","hooks_url":"https://api.github.com/repos/dfeyer/neos-development-collection/hooks","issue_events_url":"https://api.github.com/repos/dfeyer/neos-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/dfeyer/neos-development-collection/events","assignees_url":"https://api.github.com/repos/dfeyer/neos-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/dfeyer/neos-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/dfeyer/neos-development-collection/tags","blobs_url":"https://api.github.com/repos/dfeyer/neos-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dfeyer/neos-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dfeyer/neos-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/dfeyer/neos-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dfeyer/neos-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/dfeyer/neos-development-collection/languages","stargazers_url":"https://api.github.com/repos/dfeyer/neos-development-collection/stargazers","contributors_url":"https://api.github.com/repos/dfeyer/neos-development-collection/contributors","subscribers_url":"https://api.github.com/repos/dfeyer/neos-development-collection/subscribers","subscription_url":"https://api.github.com/repos/dfeyer/neos-development-collection/subscription","commits_url":"https://api.github.com/repos/dfeyer/neos-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/dfeyer/neos-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/dfeyer/neos-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/dfeyer/neos-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/dfeyer/neos-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/dfeyer/neos-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dfeyer/neos-development-collection/merges","archive_url":"https://api.github.com/repos/dfeyer/neos-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dfeyer/neos-development-collection/downloads","issues_url":"https://api.github.com/repos/dfeyer/neos-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/dfeyer/neos-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/dfeyer/neos-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/dfeyer/neos-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dfeyer/neos-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/dfeyer/neos-development-collection/releases{/id}","created_at":"2015-08-19T18:37:11Z","updated_at":"2015-08-19T18:37:17Z","pushed_at":"2015-09-11T14:48:04Z","git_url":"git://github.com/dfeyer/neos-development-collection.git","ssh_url":"git@github.com:dfeyer/neos-development-collection.git","clone_url":"https://github.com/dfeyer/neos-development-collection.git","svn_url":"https://github.com/dfeyer/neos-development-collection","homepage":null,"size":43945,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neos:2.0","ref":"2.0","sha":"9123040ed62948719e12cf211d69796c7b5a84b4","user":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"repo":{"id":40964014,"name":"neos-development-collection","full_name":"neos/neos-development-collection","owner":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neos/neos-development-collection","description":"The unified repository containing the Neos core packages, used for Neos development.","fork":false,"url":"https://api.github.com/repos/neos/neos-development-collection","forks_url":"https://api.github.com/repos/neos/neos-development-collection/forks","keys_url":"https://api.github.com/repos/neos/neos-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neos/neos-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neos/neos-development-collection/teams","hooks_url":"https://api.github.com/repos/neos/neos-development-collection/hooks","issue_events_url":"https://api.github.com/repos/neos/neos-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/neos/neos-development-collection/events","assignees_url":"https://api.github.com/repos/neos/neos-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/neos/neos-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/neos/neos-development-collection/tags","blobs_url":"https://api.github.com/repos/neos/neos-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neos/neos-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neos/neos-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/neos/neos-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neos/neos-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/neos/neos-development-collection/languages","stargazers_url":"https://api.github.com/repos/neos/neos-development-collection/stargazers","contributors_url":"https://api.github.com/repos/neos/neos-development-collection/contributors","subscribers_url":"https://api.github.com/repos/neos/neos-development-collection/subscribers","subscription_url":"https://api.github.com/repos/neos/neos-development-collection/subscription","commits_url":"https://api.github.com/repos/neos/neos-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/neos/neos-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/neos/neos-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/neos/neos-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/neos/neos-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/neos/neos-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neos/neos-development-collection/merges","archive_url":"https://api.github.com/repos/neos/neos-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neos/neos-development-collection/downloads","issues_url":"https://api.github.com/repos/neos/neos-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/neos/neos-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/neos/neos-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/neos/neos-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neos/neos-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/neos/neos-development-collection/releases{/id}","created_at":"2015-08-18T09:48:35Z","updated_at":"2015-09-07T04:03:42Z","pushed_at":"2015-09-11T14:50:13Z","git_url":"git://github.com/neos/neos-development-collection.git","ssh_url":"git@github.com:neos/neos-development-collection.git","clone_url":"https://github.com/neos/neos-development-collection.git","svn_url":"https://github.com/neos/neos-development-collection","homepage":null,"size":44688,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":38,"forks":25,"open_issues":38,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/60"},"html":{"href":"https://github.com/neos/neos-development-collection/pull/60"},"issue":{"href":"https://api.github.com/repos/neos/neos-development-collection/issues/60"},"comments":{"href":"https://api.github.com/repos/neos/neos-development-collection/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/neos/neos-development-collection/statuses/4b0c0267a8d307cdfa0aa50261d000377193e8f3"}}}}