{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/ding2tal/ddbasic/pulls/9","id":6743766,"html_url":"https://github.com/ding2tal/ddbasic/pull/9","diff_url":"https://github.com/ding2tal/ddbasic/pull/9.diff","patch_url":"https://github.com/ding2tal/ddbasic/pull/9.patch","issue_url":"https://api.github.com/repos/ding2tal/ddbasic/issues/9","number":9,"state":"closed","locked":false,"title":"Code review","user":{"login":"kasperg","id":73966,"avatar_url":"https://avatars.githubusercontent.com/u/73966?v=3","gravatar_id":"","url":"https://api.github.com/users/kasperg","html_url":"https://github.com/kasperg","followers_url":"https://api.github.com/users/kasperg/followers","following_url":"https://api.github.com/users/kasperg/following{/other_user}","gists_url":"https://api.github.com/users/kasperg/gists{/gist_id}","starred_url":"https://api.github.com/users/kasperg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasperg/subscriptions","organizations_url":"https://api.github.com/users/kasperg/orgs","repos_url":"https://api.github.com/users/kasperg/repos","events_url":"https://api.github.com/users/kasperg/events{/privacy}","received_events_url":"https://api.github.com/users/kasperg/received_events","type":"User","site_admin":false},"body":"Lots of changes, comments and questions here.\r\n\r\nMy general impression is that there is a lot of code here. Theming is not my core competency but I can't help but wonder if it could be done in another way.\r\n\r\n* Some templates seem to have very few changes compared to the default. Could these changes be handled in a better way?\r\n* There is a lot of cleanup code in the theme. Could this be added by using a module or a base theme instead?\r\n* If we go with many template files it would be nice to know why they are needed. Some seem very well documented. Others not so much.","created_at":"2013-07-05T09:03:34Z","updated_at":"2015-02-10T12:28:01Z","closed_at":"2015-02-10T12:28:01Z","merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ding2tal/ddbasic/pulls/9/commits","review_comments_url":"https://api.github.com/repos/ding2tal/ddbasic/pulls/9/comments","review_comment_url":"https://api.github.com/repos/ding2tal/ddbasic/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ding2tal/ddbasic/issues/9/comments","statuses_url":"https://api.github.com/repos/ding2tal/ddbasic/statuses/84c6657187a1f56a7967fa50f85c733aec76d937","head":{"label":"kasperg:development","ref":"development","sha":"84c6657187a1f56a7967fa50f85c733aec76d937","user":{"login":"kasperg","id":73966,"avatar_url":"https://avatars.githubusercontent.com/u/73966?v=3","gravatar_id":"","url":"https://api.github.com/users/kasperg","html_url":"https://github.com/kasperg","followers_url":"https://api.github.com/users/kasperg/followers","following_url":"https://api.github.com/users/kasperg/following{/other_user}","gists_url":"https://api.github.com/users/kasperg/gists{/gist_id}","starred_url":"https://api.github.com/users/kasperg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasperg/subscriptions","organizations_url":"https://api.github.com/users/kasperg/orgs","repos_url":"https://api.github.com/users/kasperg/repos","events_url":"https://api.github.com/users/kasperg/events{/privacy}","received_events_url":"https://api.github.com/users/kasperg/received_events","type":"User","site_admin":false},"repo":{"id":10844748,"name":"ddbasic","full_name":"kasperg/ddbasic","owner":{"login":"kasperg","id":73966,"avatar_url":"https://avatars.githubusercontent.com/u/73966?v=3","gravatar_id":"","url":"https://api.github.com/users/kasperg","html_url":"https://github.com/kasperg","followers_url":"https://api.github.com/users/kasperg/followers","following_url":"https://api.github.com/users/kasperg/following{/other_user}","gists_url":"https://api.github.com/users/kasperg/gists{/gist_id}","starred_url":"https://api.github.com/users/kasperg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasperg/subscriptions","organizations_url":"https://api.github.com/users/kasperg/orgs","repos_url":"https://api.github.com/users/kasperg/repos","events_url":"https://api.github.com/users/kasperg/events{/privacy}","received_events_url":"https://api.github.com/users/kasperg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kasperg/ddbasic","description":"Ding2tal base theme.","fork":true,"url":"https://api.github.com/repos/kasperg/ddbasic","forks_url":"https://api.github.com/repos/kasperg/ddbasic/forks","keys_url":"https://api.github.com/repos/kasperg/ddbasic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kasperg/ddbasic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kasperg/ddbasic/teams","hooks_url":"https://api.github.com/repos/kasperg/ddbasic/hooks","issue_events_url":"https://api.github.com/repos/kasperg/ddbasic/issues/events{/number}","events_url":"https://api.github.com/repos/kasperg/ddbasic/events","assignees_url":"https://api.github.com/repos/kasperg/ddbasic/assignees{/user}","branches_url":"https://api.github.com/repos/kasperg/ddbasic/branches{/branch}","tags_url":"https://api.github.com/repos/kasperg/ddbasic/tags","blobs_url":"https://api.github.com/repos/kasperg/ddbasic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kasperg/ddbasic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kasperg/ddbasic/git/refs{/sha}","trees_url":"https://api.github.com/repos/kasperg/ddbasic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kasperg/ddbasic/statuses/{sha}","languages_url":"https://api.github.com/repos/kasperg/ddbasic/languages","stargazers_url":"https://api.github.com/repos/kasperg/ddbasic/stargazers","contributors_url":"https://api.github.com/repos/kasperg/ddbasic/contributors","subscribers_url":"https://api.github.com/repos/kasperg/ddbasic/subscribers","subscription_url":"https://api.github.com/repos/kasperg/ddbasic/subscription","commits_url":"https://api.github.com/repos/kasperg/ddbasic/commits{/sha}","git_commits_url":"https://api.github.com/repos/kasperg/ddbasic/git/commits{/sha}","comments_url":"https://api.github.com/repos/kasperg/ddbasic/comments{/number}","issue_comment_url":"https://api.github.com/repos/kasperg/ddbasic/issues/comments/{number}","contents_url":"https://api.github.com/repos/kasperg/ddbasic/contents/{+path}","compare_url":"https://api.github.com/repos/kasperg/ddbasic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kasperg/ddbasic/merges","archive_url":"https://api.github.com/repos/kasperg/ddbasic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kasperg/ddbasic/downloads","issues_url":"https://api.github.com/repos/kasperg/ddbasic/issues{/number}","pulls_url":"https://api.github.com/repos/kasperg/ddbasic/pulls{/number}","milestones_url":"https://api.github.com/repos/kasperg/ddbasic/milestones{/number}","notifications_url":"https://api.github.com/repos/kasperg/ddbasic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kasperg/ddbasic/labels{/name}","releases_url":"https://api.github.com/repos/kasperg/ddbasic/releases{/id}","created_at":"2013-06-21T14:54:01Z","updated_at":"2013-07-05T09:03:34Z","pushed_at":"2013-07-05T08:53:31Z","git_url":"git://github.com/kasperg/ddbasic.git","ssh_url":"git@github.com:kasperg/ddbasic.git","clone_url":"https://github.com/kasperg/ddbasic.git","svn_url":"https://github.com/kasperg/ddbasic","homepage":null,"size":38740,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"ding2tal:development","ref":"development","sha":"791e5087277d245634c73036cd74af0f6cffda95","user":{"login":"ding2tal","id":1969151,"avatar_url":"https://avatars.githubusercontent.com/u/1969151?v=3","gravatar_id":"","url":"https://api.github.com/users/ding2tal","html_url":"https://github.com/ding2tal","followers_url":"https://api.github.com/users/ding2tal/followers","following_url":"https://api.github.com/users/ding2tal/following{/other_user}","gists_url":"https://api.github.com/users/ding2tal/gists{/gist_id}","starred_url":"https://api.github.com/users/ding2tal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ding2tal/subscriptions","organizations_url":"https://api.github.com/users/ding2tal/orgs","repos_url":"https://api.github.com/users/ding2tal/repos","events_url":"https://api.github.com/users/ding2tal/events{/privacy}","received_events_url":"https://api.github.com/users/ding2tal/received_events","type":"Organization","site_admin":false},"repo":{"id":5838038,"name":"ddbasic","full_name":"ding2tal/ddbasic","owner":{"login":"ding2tal","id":1969151,"avatar_url":"https://avatars.githubusercontent.com/u/1969151?v=3","gravatar_id":"","url":"https://api.github.com/users/ding2tal","html_url":"https://github.com/ding2tal","followers_url":"https://api.github.com/users/ding2tal/followers","following_url":"https://api.github.com/users/ding2tal/following{/other_user}","gists_url":"https://api.github.com/users/ding2tal/gists{/gist_id}","starred_url":"https://api.github.com/users/ding2tal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ding2tal/subscriptions","organizations_url":"https://api.github.com/users/ding2tal/orgs","repos_url":"https://api.github.com/users/ding2tal/repos","events_url":"https://api.github.com/users/ding2tal/events{/privacy}","received_events_url":"https://api.github.com/users/ding2tal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ding2tal/ddbasic","description":"Ding2tal base theme.","fork":false,"url":"https://api.github.com/repos/ding2tal/ddbasic","forks_url":"https://api.github.com/repos/ding2tal/ddbasic/forks","keys_url":"https://api.github.com/repos/ding2tal/ddbasic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ding2tal/ddbasic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ding2tal/ddbasic/teams","hooks_url":"https://api.github.com/repos/ding2tal/ddbasic/hooks","issue_events_url":"https://api.github.com/repos/ding2tal/ddbasic/issues/events{/number}","events_url":"https://api.github.com/repos/ding2tal/ddbasic/events","assignees_url":"https://api.github.com/repos/ding2tal/ddbasic/assignees{/user}","branches_url":"https://api.github.com/repos/ding2tal/ddbasic/branches{/branch}","tags_url":"https://api.github.com/repos/ding2tal/ddbasic/tags","blobs_url":"https://api.github.com/repos/ding2tal/ddbasic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ding2tal/ddbasic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ding2tal/ddbasic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ding2tal/ddbasic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ding2tal/ddbasic/statuses/{sha}","languages_url":"https://api.github.com/repos/ding2tal/ddbasic/languages","stargazers_url":"https://api.github.com/repos/ding2tal/ddbasic/stargazers","contributors_url":"https://api.github.com/repos/ding2tal/ddbasic/contributors","subscribers_url":"https://api.github.com/repos/ding2tal/ddbasic/subscribers","subscription_url":"https://api.github.com/repos/ding2tal/ddbasic/subscription","commits_url":"https://api.github.com/repos/ding2tal/ddbasic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ding2tal/ddbasic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ding2tal/ddbasic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ding2tal/ddbasic/issues/comments/{number}","contents_url":"https://api.github.com/repos/ding2tal/ddbasic/contents/{+path}","compare_url":"https://api.github.com/repos/ding2tal/ddbasic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ding2tal/ddbasic/merges","archive_url":"https://api.github.com/repos/ding2tal/ddbasic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ding2tal/ddbasic/downloads","issues_url":"https://api.github.com/repos/ding2tal/ddbasic/issues{/number}","pulls_url":"https://api.github.com/repos/ding2tal/ddbasic/pulls{/number}","milestones_url":"https://api.github.com/repos/ding2tal/ddbasic/milestones{/number}","notifications_url":"https://api.github.com/repos/ding2tal/ddbasic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ding2tal/ddbasic/labels{/name}","releases_url":"https://api.github.com/repos/ding2tal/ddbasic/releases{/id}","created_at":"2012-09-17T08:09:48Z","updated_at":"2015-01-20T09:40:24Z","pushed_at":"2015-01-20T09:41:42Z","git_url":"git://github.com/ding2tal/ddbasic.git","ssh_url":"git@github.com:ding2tal/ddbasic.git","clone_url":"https://github.com/ding2tal/ddbasic.git","svn_url":"https://github.com/ding2tal/ddbasic","homepage":null,"size":42911,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":3,"forks":13,"open_issues":3,"watchers":0,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ding2tal/ddbasic/pulls/9"},"html":{"href":"https://github.com/ding2tal/ddbasic/pull/9"},"issue":{"href":"https://api.github.com/repos/ding2tal/ddbasic/issues/9"},"comments":{"href":"https://api.github.com/repos/ding2tal/ddbasic/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/ding2tal/ddbasic/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/ding2tal/ddbasic/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ding2tal/ddbasic/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/ding2tal/ddbasic/statuses/84c6657187a1f56a7967fa50f85c733aec76d937"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":89,"deletions":146,"changed_files":29}}