{"action":"created","comment":{"url":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments/36333061","id":36333061,"diff_hunk":"@@ -62,47 +60,68 @@ XDG_CONFIG_HOME=\"./\"\n export LUA_PATH\n export XDG_CONFIG_HOME\n \n-awesome_log=/tmp/_awesome_test.log\n-echo \"awesome_log: $awesome_log\"\n-\n cd - >/dev/null\n \n-\n-kill_childs() {\n+# Cleanup on errors / aborting.\n+cleanup() {\n     for p in $awesome_pid $xserver_pid; do\n         kill -TERM $p 2>/dev/null || true\n     done\n+    rm -rf $tmp_files || true\n }\n-# Cleanup on errors / aborting.\n-set_trap() {\n-    trap \"kill_childs\" 0 2 3 15\n+trap \"cleanup\" 0 2 3 15\n+\n+tmp_files=$(mktemp -d)\n+awesome_log=$tmp_files/_awesome_test.log\n+echo \"awesome_log: $awesome_log\"\n+\n+wait_until_success() {\n+    if [ \"$CI\" = true ]; then\n+        set +x\n+    fi\n+    max_wait=60\n+    while true; do\n+        set +e\n+        eval reply=\"\\$($2)\"\n+        ret=$?\n+        set -e\n+        if [ $ret = 0 ]; then\n+            break\n+        fi\n+        max_wait=$(expr $max_wait - 1)\n+        if [ \"$max_wait\" -lt 0 ]; then","path":"tests/run.sh","position":59,"original_position":59,"commit_id":"1caec11944b3473593432df405919b5f6fe344f0","original_commit_id":"1caec11944b3473593432df405919b5f6fe344f0","user":{"login":"blueyed","id":9766,"avatar_url":"https://avatars.githubusercontent.com/u/9766?v=3","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"body":"..or use `-le 1` here?!","created_at":"2015-08-05T18:01:10Z","updated_at":"2015-08-05T18:01:10Z","html_url":"https://github.com/awesomeWM/awesome/pull/393#discussion_r36333061","pull_request_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/393","_links":{"self":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments/36333061"},"html":{"href":"https://github.com/awesomeWM/awesome/pull/393#discussion_r36333061"},"pull_request":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/393"}}},"pull_request":{"url":"https://api.github.com/repos/awesomeWM/awesome/pulls/393","id":41694443,"html_url":"https://github.com/awesomeWM/awesome/pull/393","diff_url":"https://github.com/awesomeWM/awesome/pull/393.diff","patch_url":"https://github.com/awesomeWM/awesome/pull/393.patch","issue_url":"https://api.github.com/repos/awesomeWM/awesome/issues/393","number":393,"state":"open","locked":false,"title":"Ci script improvements","user":{"login":"psychon","id":89482,"avatar_url":"https://avatars.githubusercontent.com/u/89482?v=3","gravatar_id":"","url":"https://api.github.com/users/psychon","html_url":"https://github.com/psychon","followers_url":"https://api.github.com/users/psychon/followers","following_url":"https://api.github.com/users/psychon/following{/other_user}","gists_url":"https://api.github.com/users/psychon/gists{/gist_id}","starred_url":"https://api.github.com/users/psychon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychon/subscriptions","organizations_url":"https://api.github.com/users/psychon/orgs","repos_url":"https://api.github.com/users/psychon/repos","events_url":"https://api.github.com/users/psychon/events{/privacy}","received_events_url":"https://api.github.com/users/psychon/received_events","type":"User","site_admin":false},"body":"Some stuff, the main thing being that I can run `tests/run.sh` now, too, even though I don't have an up-to-date version of awesome installed.","created_at":"2015-08-05T15:50:51Z","updated_at":"2015-08-05T18:01:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa3db5d6389458e38b3b9ec225d8133d93c026b2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/393/commits","review_comments_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/393/comments","review_comment_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/issues/393/comments","statuses_url":"https://api.github.com/repos/awesomeWM/awesome/statuses/1caec11944b3473593432df405919b5f6fe344f0","head":{"label":"psychon:ci-script-improvements","ref":"ci-script-improvements","sha":"1caec11944b3473593432df405919b5f6fe344f0","user":{"login":"psychon","id":89482,"avatar_url":"https://avatars.githubusercontent.com/u/89482?v=3","gravatar_id":"","url":"https://api.github.com/users/psychon","html_url":"https://github.com/psychon","followers_url":"https://api.github.com/users/psychon/followers","following_url":"https://api.github.com/users/psychon/following{/other_user}","gists_url":"https://api.github.com/users/psychon/gists{/gist_id}","starred_url":"https://api.github.com/users/psychon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychon/subscriptions","organizations_url":"https://api.github.com/users/psychon/orgs","repos_url":"https://api.github.com/users/psychon/repos","events_url":"https://api.github.com/users/psychon/events{/privacy}","received_events_url":"https://api.github.com/users/psychon/received_events","type":"User","site_admin":false},"repo":{"id":28717216,"name":"awesome","full_name":"psychon/awesome","owner":{"login":"psychon","id":89482,"avatar_url":"https://avatars.githubusercontent.com/u/89482?v=3","gravatar_id":"","url":"https://api.github.com/users/psychon","html_url":"https://github.com/psychon","followers_url":"https://api.github.com/users/psychon/followers","following_url":"https://api.github.com/users/psychon/following{/other_user}","gists_url":"https://api.github.com/users/psychon/gists{/gist_id}","starred_url":"https://api.github.com/users/psychon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychon/subscriptions","organizations_url":"https://api.github.com/users/psychon/orgs","repos_url":"https://api.github.com/users/psychon/repos","events_url":"https://api.github.com/users/psychon/events{/privacy}","received_events_url":"https://api.github.com/users/psychon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/psychon/awesome","description":"awesome window manager","fork":true,"url":"https://api.github.com/repos/psychon/awesome","forks_url":"https://api.github.com/repos/psychon/awesome/forks","keys_url":"https://api.github.com/repos/psychon/awesome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psychon/awesome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psychon/awesome/teams","hooks_url":"https://api.github.com/repos/psychon/awesome/hooks","issue_events_url":"https://api.github.com/repos/psychon/awesome/issues/events{/number}","events_url":"https://api.github.com/repos/psychon/awesome/events","assignees_url":"https://api.github.com/repos/psychon/awesome/assignees{/user}","branches_url":"https://api.github.com/repos/psychon/awesome/branches{/branch}","tags_url":"https://api.github.com/repos/psychon/awesome/tags","blobs_url":"https://api.github.com/repos/psychon/awesome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psychon/awesome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psychon/awesome/git/refs{/sha}","trees_url":"https://api.github.com/repos/psychon/awesome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psychon/awesome/statuses/{sha}","languages_url":"https://api.github.com/repos/psychon/awesome/languages","stargazers_url":"https://api.github.com/repos/psychon/awesome/stargazers","contributors_url":"https://api.github.com/repos/psychon/awesome/contributors","subscribers_url":"https://api.github.com/repos/psychon/awesome/subscribers","subscription_url":"https://api.github.com/repos/psychon/awesome/subscription","commits_url":"https://api.github.com/repos/psychon/awesome/commits{/sha}","git_commits_url":"https://api.github.com/repos/psychon/awesome/git/commits{/sha}","comments_url":"https://api.github.com/repos/psychon/awesome/comments{/number}","issue_comment_url":"https://api.github.com/repos/psychon/awesome/issues/comments{/number}","contents_url":"https://api.github.com/repos/psychon/awesome/contents/{+path}","compare_url":"https://api.github.com/repos/psychon/awesome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psychon/awesome/merges","archive_url":"https://api.github.com/repos/psychon/awesome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psychon/awesome/downloads","issues_url":"https://api.github.com/repos/psychon/awesome/issues{/number}","pulls_url":"https://api.github.com/repos/psychon/awesome/pulls{/number}","milestones_url":"https://api.github.com/repos/psychon/awesome/milestones{/number}","notifications_url":"https://api.github.com/repos/psychon/awesome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psychon/awesome/labels{/name}","releases_url":"https://api.github.com/repos/psychon/awesome/releases{/id}","created_at":"2015-01-02T15:31:52Z","updated_at":"2015-01-02T15:31:53Z","pushed_at":"2015-08-05T15:58:44Z","git_url":"git://github.com/psychon/awesome.git","ssh_url":"git@github.com:psychon/awesome.git","clone_url":"https://github.com/psychon/awesome.git","svn_url":"https://github.com/psychon/awesome","homepage":"https://awesome.naquadah.org/","size":8647,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awesomeWM:master","ref":"master","sha":"baeb8fd2b59aa9bc769d5b4288f27b182e23765d","user":{"login":"awesomeWM","id":6843364,"avatar_url":"https://avatars.githubusercontent.com/u/6843364?v=3","gravatar_id":"","url":"https://api.github.com/users/awesomeWM","html_url":"https://github.com/awesomeWM","followers_url":"https://api.github.com/users/awesomeWM/followers","following_url":"https://api.github.com/users/awesomeWM/following{/other_user}","gists_url":"https://api.github.com/users/awesomeWM/gists{/gist_id}","starred_url":"https://api.github.com/users/awesomeWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesomeWM/subscriptions","organizations_url":"https://api.github.com/users/awesomeWM/orgs","repos_url":"https://api.github.com/users/awesomeWM/repos","events_url":"https://api.github.com/users/awesomeWM/events{/privacy}","received_events_url":"https://api.github.com/users/awesomeWM/received_events","type":"Organization","site_admin":false},"repo":{"id":17378009,"name":"awesome","full_name":"awesomeWM/awesome","owner":{"login":"awesomeWM","id":6843364,"avatar_url":"https://avatars.githubusercontent.com/u/6843364?v=3","gravatar_id":"","url":"https://api.github.com/users/awesomeWM","html_url":"https://github.com/awesomeWM","followers_url":"https://api.github.com/users/awesomeWM/followers","following_url":"https://api.github.com/users/awesomeWM/following{/other_user}","gists_url":"https://api.github.com/users/awesomeWM/gists{/gist_id}","starred_url":"https://api.github.com/users/awesomeWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesomeWM/subscriptions","organizations_url":"https://api.github.com/users/awesomeWM/orgs","repos_url":"https://api.github.com/users/awesomeWM/repos","events_url":"https://api.github.com/users/awesomeWM/events{/privacy}","received_events_url":"https://api.github.com/users/awesomeWM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awesomeWM/awesome","description":"awesome window manager","fork":false,"url":"https://api.github.com/repos/awesomeWM/awesome","forks_url":"https://api.github.com/repos/awesomeWM/awesome/forks","keys_url":"https://api.github.com/repos/awesomeWM/awesome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awesomeWM/awesome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awesomeWM/awesome/teams","hooks_url":"https://api.github.com/repos/awesomeWM/awesome/hooks","issue_events_url":"https://api.github.com/repos/awesomeWM/awesome/issues/events{/number}","events_url":"https://api.github.com/repos/awesomeWM/awesome/events","assignees_url":"https://api.github.com/repos/awesomeWM/awesome/assignees{/user}","branches_url":"https://api.github.com/repos/awesomeWM/awesome/branches{/branch}","tags_url":"https://api.github.com/repos/awesomeWM/awesome/tags","blobs_url":"https://api.github.com/repos/awesomeWM/awesome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awesomeWM/awesome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awesomeWM/awesome/git/refs{/sha}","trees_url":"https://api.github.com/repos/awesomeWM/awesome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awesomeWM/awesome/statuses/{sha}","languages_url":"https://api.github.com/repos/awesomeWM/awesome/languages","stargazers_url":"https://api.github.com/repos/awesomeWM/awesome/stargazers","contributors_url":"https://api.github.com/repos/awesomeWM/awesome/contributors","subscribers_url":"https://api.github.com/repos/awesomeWM/awesome/subscribers","subscription_url":"https://api.github.com/repos/awesomeWM/awesome/subscription","commits_url":"https://api.github.com/repos/awesomeWM/awesome/commits{/sha}","git_commits_url":"https://api.github.com/repos/awesomeWM/awesome/git/commits{/sha}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/comments{/number}","issue_comment_url":"https://api.github.com/repos/awesomeWM/awesome/issues/comments{/number}","contents_url":"https://api.github.com/repos/awesomeWM/awesome/contents/{+path}","compare_url":"https://api.github.com/repos/awesomeWM/awesome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awesomeWM/awesome/merges","archive_url":"https://api.github.com/repos/awesomeWM/awesome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awesomeWM/awesome/downloads","issues_url":"https://api.github.com/repos/awesomeWM/awesome/issues{/number}","pulls_url":"https://api.github.com/repos/awesomeWM/awesome/pulls{/number}","milestones_url":"https://api.github.com/repos/awesomeWM/awesome/milestones{/number}","notifications_url":"https://api.github.com/repos/awesomeWM/awesome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awesomeWM/awesome/labels{/name}","releases_url":"https://api.github.com/repos/awesomeWM/awesome/releases{/id}","created_at":"2014-03-03T19:56:16Z","updated_at":"2015-08-05T12:38:39Z","pushed_at":"2015-08-05T17:58:10Z","git_url":"git://github.com/awesomeWM/awesome.git","ssh_url":"git@github.com:awesomeWM/awesome.git","clone_url":"https://github.com/awesomeWM/awesome.git","svn_url":"https://github.com/awesomeWM/awesome","homepage":"https://awesome.naquadah.org/","size":16729,"stargazers_count":400,"watchers_count":400,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":121,"forks":63,"open_issues":121,"watchers":400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/393"},"html":{"href":"https://github.com/awesomeWM/awesome/pull/393"},"issue":{"href":"https://api.github.com/repos/awesomeWM/awesome/issues/393"},"comments":{"href":"https://api.github.com/repos/awesomeWM/awesome/issues/393/comments"},"review_comments":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/393/comments"},"review_comment":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/393/commits"},"statuses":{"href":"https://api.github.com/repos/awesomeWM/awesome/statuses/1caec11944b3473593432df405919b5f6fe344f0"}}}}