{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/32441519","id":32441519,"diff_hunk":"@@ -821,8 +804,7 @@ def tl_gen_timeline_data\n     return unless @report\n \n     unless params[:task_id] # First time thru, kick off the report generate task\n-      options = {:userid => session[:userid]}\n-      initiate_wait_for_task(:task_id => @report.async_generate_table(options))\n+      initiate_wait_for_task(:task_id => @report.async_generate_table(:userid => session[:userid]))","path":"vmdb/app/controllers/dashboard_controller.rb","position":94,"original_position":94,"commit_id":"7827233285a04703f1add7e362c873cd4ad3e2be","original_commit_id":"7827233285a04703f1add7e362c873cd4ad3e2be","user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"body":"I'll create an issue for this. thanks","created_at":"2015-06-15T16:55:05Z","updated_at":"2015-06-15T16:55:05Z","html_url":"https://github.com/ManageIQ/manageiq/pull/3164#discussion_r32441519","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3164","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/32441519"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/3164#discussion_r32441519"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3164"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3164","id":37656385,"html_url":"https://github.com/ManageIQ/manageiq/pull/3164","diff_url":"https://github.com/ManageIQ/manageiq/pull/3164.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/3164.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3164","number":3164,"state":"open","locked":false,"title":"Session user","user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"body":"A number of places know the intimate details of `session[:userid]` and `session[:username]` and\r\n`User.current_user` (a thread local variable accessible to models).\r\n\r\nThis PR tries to move us towards a single way of accessing the currently logged in user, namely `current_user`. This will be accessible from controllers and views.\r\n\r\nThis change will allow us to change our tests to use a common test helper `login_as`, and setup the 'currently logged in user' consistently. (some tests set `User.current_user` while others set various `session` variables)\r\n\r\nEven while introducing this PR, I was surprised that a number of places were not setting up the `session`. The goal is to make this consistent so we can build upon the current user and current tenant in multi-tenancy.","created_at":"2015-06-15T03:42:07Z","updated_at":"2015-06-15T16:55:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a54afbb735825e01f1c325b19259cb431676607","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3164/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3164/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3164/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/7827233285a04703f1add7e362c873cd4ad3e2be","head":{"label":"kbrock:session_user","ref":"session_user","sha":"7827233285a04703f1add7e362c873cd4ad3e2be","user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"repo":{"id":20886492,"name":"manageiq","full_name":"kbrock/manageiq","owner":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbrock/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/kbrock/manageiq","forks_url":"https://api.github.com/repos/kbrock/manageiq/forks","keys_url":"https://api.github.com/repos/kbrock/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbrock/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbrock/manageiq/teams","hooks_url":"https://api.github.com/repos/kbrock/manageiq/hooks","issue_events_url":"https://api.github.com/repos/kbrock/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/kbrock/manageiq/events","assignees_url":"https://api.github.com/repos/kbrock/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/kbrock/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/kbrock/manageiq/tags","blobs_url":"https://api.github.com/repos/kbrock/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbrock/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbrock/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbrock/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbrock/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/kbrock/manageiq/languages","stargazers_url":"https://api.github.com/repos/kbrock/manageiq/stargazers","contributors_url":"https://api.github.com/repos/kbrock/manageiq/contributors","subscribers_url":"https://api.github.com/repos/kbrock/manageiq/subscribers","subscription_url":"https://api.github.com/repos/kbrock/manageiq/subscription","commits_url":"https://api.github.com/repos/kbrock/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbrock/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbrock/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbrock/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbrock/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/kbrock/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbrock/manageiq/merges","archive_url":"https://api.github.com/repos/kbrock/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbrock/manageiq/downloads","issues_url":"https://api.github.com/repos/kbrock/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/kbrock/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/kbrock/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/kbrock/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbrock/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/kbrock/manageiq/releases{/id}","created_at":"2014-06-16T13:49:17Z","updated_at":"2015-05-07T20:40:10Z","pushed_at":"2015-06-15T16:03:23Z","git_url":"git://github.com/kbrock/manageiq.git","ssh_url":"git@github.com:kbrock/manageiq.git","clone_url":"https://github.com/kbrock/manageiq.git","svn_url":"https://github.com/kbrock/manageiq","homepage":null,"size":75521,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"972d630e455d7443d829868406c1cb0afb1a4136","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-06-15T07:53:53Z","pushed_at":"2015-06-15T16:37:31Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":127864,"stargazers_count":116,"watchers_count":116,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":359,"forks":120,"open_issues":359,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3164"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/3164"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/3164"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/3164/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3164/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3164/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/7827233285a04703f1add7e362c873cd4ad3e2be"}}}}