{"action":"created","issue":{"url":"https://api.github.com/repos/netty/netty/issues/4391","labels_url":"https://api.github.com/repos/netty/netty/issues/4391/labels{/name}","comments_url":"https://api.github.com/repos/netty/netty/issues/4391/comments","events_url":"https://api.github.com/repos/netty/netty/issues/4391/events","html_url":"https://github.com/netty/netty/pull/4391","id":113222152,"number":4391,"title":"Refactoring to move ascii related methods from ByteString to AsciiString","user":{"login":"Spikhalskiy","id":532108,"avatar_url":"https://avatars.githubusercontent.com/u/532108?v=3","gravatar_id":"","url":"https://api.github.com/users/Spikhalskiy","html_url":"https://github.com/Spikhalskiy","followers_url":"https://api.github.com/users/Spikhalskiy/followers","following_url":"https://api.github.com/users/Spikhalskiy/following{/other_user}","gists_url":"https://api.github.com/users/Spikhalskiy/gists{/gist_id}","starred_url":"https://api.github.com/users/Spikhalskiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spikhalskiy/subscriptions","organizations_url":"https://api.github.com/users/Spikhalskiy/orgs","repos_url":"https://api.github.com/users/Spikhalskiy/repos","events_url":"https://api.github.com/users/Spikhalskiy/events{/privacy}","received_events_url":"https://api.github.com/users/Spikhalskiy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=3","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"milestone":null,"comments":11,"created_at":"2015-10-25T12:03:01Z","updated_at":"2015-10-28T00:47:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/4391","html_url":"https://github.com/netty/netty/pull/4391","diff_url":"https://github.com/netty/netty/pull/4391.diff","patch_url":"https://github.com/netty/netty/pull/4391.patch"},"body":"Motivation:\r\n\r\nByteString contains some bugs (tests provided) + there is some mess now related to ascii-only code in general ByteString while we have AsciiString\r\n\r\nModifications:\r\n\r\n1) Http2 headers have been refactored to use AsciiString instead of ByteString, because 1. they already use ascii-only methods of ByteString thru ByteStringValueConverter 2. It's valid according to spec https://http2.github.io/http2-spec/#HttpHeaders\r\n\r\n2) Ascii-only methods moved down to AsciiString and classes using this method refactored to use AsciiString class\r\n\r\n3) Error in constructor of ByteString fixed, incorrect method fromChar moved down to AsciiString and implemented for Ascii correctly\r\n\r\nResult:\r\n\r\nMostly cleanup changes to make structure and usage of AsciiString class and methods implemented only for Ascii clear."},"comment":{"url":"https://api.github.com/repos/netty/netty/issues/comments/151685534","html_url":"https://github.com/netty/netty/pull/4391#issuecomment-151685534","issue_url":"https://api.github.com/repos/netty/netty/issues/4391","id":151685534,"user":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=3","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"created_at":"2015-10-28T00:47:02Z","updated_at":"2015-10-28T00:47:02Z","body":"@Spikhalskiy - I have a PR in the works for this. I'll ping you for review."}}