{"action":"closed","number":4576,"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/4576","id":34320130,"html_url":"https://github.com/django/django/pull/4576","diff_url":"https://github.com/django/django/pull/4576.diff","patch_url":"https://github.com/django/django/pull/4576.patch","issue_url":"https://api.github.com/repos/django/django/issues/4576","number":4576,"state":"closed","locked":false,"title":"Fixed #24717 -- Fixed test failures for RHEL6 SCL","user":{"login":"timgraham","id":411869,"avatar_url":"https://avatars.githubusercontent.com/u/411869?v=3","gravatar_id":"","url":"https://api.github.com/users/timgraham","html_url":"https://github.com/timgraham","followers_url":"https://api.github.com/users/timgraham/followers","following_url":"https://api.github.com/users/timgraham/following{/other_user}","gists_url":"https://api.github.com/users/timgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/timgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timgraham/subscriptions","organizations_url":"https://api.github.com/users/timgraham/orgs","repos_url":"https://api.github.com/users/timgraham/repos","events_url":"https://api.github.com/users/timgraham/events{/privacy}","received_events_url":"https://api.github.com/users/timgraham/received_events","type":"User","site_admin":false},"body":"The test test_unpickling_when_appregistrynotready in the package\r\nmodel_regress.test_pickle fails on RHEL6 systems running python 2.7\r\nfrom a RedHat Software Collection (SCL) because this test runs an\r\nexternal python script with a stripped system environment. RedHat SCLs\r\nwork by setting a number of system environment variables when these are\r\nstripped out by this test the python 2.7 interpreter is no longer able\r\nto function properly because it can not find the system libraries needed\r\nfrom the SCL. The solution I propose is to use mock to modify the system\r\nenvironment directly instead of passing a stripped environment. I tested\r\nthis commit using using python 3.4.3 on Windows 7, and python 2.7 on\r\nWindows 7, Debian 7.8, and RHEL6 with SCLs enabled.\r\n\r\nNote that on Unix/Linux systems the code as it was before could also\r\nbreak on local installs of python to a home directory or /usr/local for\r\nexample since it was not passing variables such as LD_LIBRARY_PATH to\r\nthe python script it executes.","created_at":"2015-04-28T22:59:18Z","updated_at":"2015-04-29T16:33:44Z","closed_at":"2015-04-29T16:33:44Z","merged_at":null,"merge_commit_sha":"8390ae5224d17503ef14befaf755db4569e6f36f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/4576/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/4576/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/django/issues/4576/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/1166c4439c2ab5597fe7f062f32387ff167eaa27","head":{"label":"ddriddle:ticket_24717","ref":"ticket_24717","sha":"1166c4439c2ab5597fe7f062f32387ff167eaa27","user":{"login":"ddriddle","id":10728345,"avatar_url":"https://avatars.githubusercontent.com/u/10728345?v=3","gravatar_id":"","url":"https://api.github.com/users/ddriddle","html_url":"https://github.com/ddriddle","followers_url":"https://api.github.com/users/ddriddle/followers","following_url":"https://api.github.com/users/ddriddle/following{/other_user}","gists_url":"https://api.github.com/users/ddriddle/gists{/gist_id}","starred_url":"https://api.github.com/users/ddriddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddriddle/subscriptions","organizations_url":"https://api.github.com/users/ddriddle/orgs","repos_url":"https://api.github.com/users/ddriddle/repos","events_url":"https://api.github.com/users/ddriddle/events{/privacy}","received_events_url":"https://api.github.com/users/ddriddle/received_events","type":"User","site_admin":false},"repo":{"id":33005206,"name":"django","full_name":"ddriddle/django","owner":{"login":"ddriddle","id":10728345,"avatar_url":"https://avatars.githubusercontent.com/u/10728345?v=3","gravatar_id":"","url":"https://api.github.com/users/ddriddle","html_url":"https://github.com/ddriddle","followers_url":"https://api.github.com/users/ddriddle/followers","following_url":"https://api.github.com/users/ddriddle/following{/other_user}","gists_url":"https://api.github.com/users/ddriddle/gists{/gist_id}","starred_url":"https://api.github.com/users/ddriddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddriddle/subscriptions","organizations_url":"https://api.github.com/users/ddriddle/orgs","repos_url":"https://api.github.com/users/ddriddle/repos","events_url":"https://api.github.com/users/ddriddle/events{/privacy}","received_events_url":"https://api.github.com/users/ddriddle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ddriddle/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/ddriddle/django","forks_url":"https://api.github.com/repos/ddriddle/django/forks","keys_url":"https://api.github.com/repos/ddriddle/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddriddle/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddriddle/django/teams","hooks_url":"https://api.github.com/repos/ddriddle/django/hooks","issue_events_url":"https://api.github.com/repos/ddriddle/django/issues/events{/number}","events_url":"https://api.github.com/repos/ddriddle/django/events","assignees_url":"https://api.github.com/repos/ddriddle/django/assignees{/user}","branches_url":"https://api.github.com/repos/ddriddle/django/branches{/branch}","tags_url":"https://api.github.com/repos/ddriddle/django/tags","blobs_url":"https://api.github.com/repos/ddriddle/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddriddle/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddriddle/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddriddle/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddriddle/django/statuses/{sha}","languages_url":"https://api.github.com/repos/ddriddle/django/languages","stargazers_url":"https://api.github.com/repos/ddriddle/django/stargazers","contributors_url":"https://api.github.com/repos/ddriddle/django/contributors","subscribers_url":"https://api.github.com/repos/ddriddle/django/subscribers","subscription_url":"https://api.github.com/repos/ddriddle/django/subscription","commits_url":"https://api.github.com/repos/ddriddle/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddriddle/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddriddle/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddriddle/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddriddle/django/contents/{+path}","compare_url":"https://api.github.com/repos/ddriddle/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddriddle/django/merges","archive_url":"https://api.github.com/repos/ddriddle/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddriddle/django/downloads","issues_url":"https://api.github.com/repos/ddriddle/django/issues{/number}","pulls_url":"https://api.github.com/repos/ddriddle/django/pulls{/number}","milestones_url":"https://api.github.com/repos/ddriddle/django/milestones{/number}","notifications_url":"https://api.github.com/repos/ddriddle/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddriddle/django/labels{/name}","releases_url":"https://api.github.com/repos/ddriddle/django/releases{/id}","created_at":"2015-03-27T19:26:20Z","updated_at":"2015-04-28T16:56:22Z","pushed_at":"2015-04-29T15:10:32Z","git_url":"git://github.com/ddriddle/django.git","ssh_url":"git@github.com:ddriddle/django.git","clone_url":"https://github.com/ddriddle/django.git","svn_url":"https://github.com/ddriddle/django","homepage":"https://www.djangoproject.com/","size":131111,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"25b52d04f6eace3b702adf7c6ab68daf1867c7e3","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","created_at":"2012-04-28T02:47:18Z","updated_at":"2015-04-29T16:33:33Z","pushed_at":"2015-04-29T16:28:46Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":288248,"stargazers_count":13979,"watchers_count":13979,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5558,"mirror_url":null,"open_issues_count":72,"forks":5558,"open_issues":72,"watchers":13979,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/4576"},"html":{"href":"https://github.com/django/django/pull/4576"},"issue":{"href":"https://api.github.com/repos/django/django/issues/4576"},"comments":{"href":"https://api.github.com/repos/django/django/issues/4576/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/4576/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/4576/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/1166c4439c2ab5597fe7f062f32387ff167eaa27"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":8,"commits":1,"additions":21,"deletions":18,"changed_files":1}}