{"action":"created","issue":{"url":"https://api.github.com/repos/ajaxorg/ace/issues/2429","labels_url":"https://api.github.com/repos/ajaxorg/ace/issues/2429/labels{/name}","comments_url":"https://api.github.com/repos/ajaxorg/ace/issues/2429/comments","events_url":"https://api.github.com/repos/ajaxorg/ace/issues/2429/events","html_url":"https://github.com/ajaxorg/ace/pull/2429","id":65533050,"number":2429,"title":"add Gherkin worker leveraging offical gherkin parser","user":{"login":"chmontgomery","id":232356,"avatar_url":"https://avatars.githubusercontent.com/u/232356?v=3","gravatar_id":"","url":"https://api.github.com/users/chmontgomery","html_url":"https://github.com/chmontgomery","followers_url":"https://api.github.com/users/chmontgomery/followers","following_url":"https://api.github.com/users/chmontgomery/following{/other_user}","gists_url":"https://api.github.com/users/chmontgomery/gists{/gist_id}","starred_url":"https://api.github.com/users/chmontgomery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chmontgomery/subscriptions","organizations_url":"https://api.github.com/users/chmontgomery/orgs","repos_url":"https://api.github.com/users/chmontgomery/repos","events_url":"https://api.github.com/users/chmontgomery/events{/privacy}","received_events_url":"https://api.github.com/users/chmontgomery/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-31T19:56:58Z","updated_at":"2015-04-03T16:49:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ajaxorg/ace/pulls/2429","html_url":"https://github.com/ajaxorg/ace/pull/2429","diff_url":"https://github.com/ajaxorg/ace/pull/2429.diff","patch_url":"https://github.com/ajaxorg/ace/pull/2429.patch"},"body":"This makes a slight modification to Makefile.dryince.js so that any licenses sitting alongside specific language parsers under lib/ace/mode/<language> are also copied over to the build folder so that licenses stick with the code they apply to. This was necessary because license comment blocks are stripped from files during the build process."},"comment":{"url":"https://api.github.com/repos/ajaxorg/ace/issues/comments/89350328","html_url":"https://github.com/ajaxorg/ace/pull/2429#issuecomment-89350328","issue_url":"https://api.github.com/repos/ajaxorg/ace/issues/2429","id":89350328,"user":{"login":"aslakhellesoy","id":1000,"avatar_url":"https://avatars.githubusercontent.com/u/1000?v=3","gravatar_id":"","url":"https://api.github.com/users/aslakhellesoy","html_url":"https://github.com/aslakhellesoy","followers_url":"https://api.github.com/users/aslakhellesoy/followers","following_url":"https://api.github.com/users/aslakhellesoy/following{/other_user}","gists_url":"https://api.github.com/users/aslakhellesoy/gists{/gist_id}","starred_url":"https://api.github.com/users/aslakhellesoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslakhellesoy/subscriptions","organizations_url":"https://api.github.com/users/aslakhellesoy/orgs","repos_url":"https://api.github.com/users/aslakhellesoy/repos","events_url":"https://api.github.com/users/aslakhellesoy/events{/privacy}","received_events_url":"https://api.github.com/users/aslakhellesoy/received_events","type":"User","site_admin":false},"created_at":"2015-04-03T16:49:10Z","updated_at":"2015-04-03T16:49:10Z","body":"Gherkin3 is going to evolve in its own repo. I'm concerned that a year or two from now the copy of Gherkin3 that lives in Ace is going to be outdated because nobody is making sure it stays uptodate. (The Cucumber team who maintains Gherkin3 certainly won't).\r\n\r\nCopying source code between repositories is a practice I'm deeply sceptical about. Not from a licensing perspective, but from a fragmentation perspective.\r\n\r\nWouldn't it be better to create a Gherkin-Ace plugin that:\r\n\r\n* Lives in a separate repo\r\n* Depends on Gherkin3 via npm or bower, but doesn't *copy* the source."}}