{"action":"created","issue":{"url":"https://api.github.com/repos/Oblongmana/sublime-salesforce-reference/issues/9","labels_url":"https://api.github.com/repos/Oblongmana/sublime-salesforce-reference/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/Oblongmana/sublime-salesforce-reference/issues/9/comments","events_url":"https://api.github.com/repos/Oblongmana/sublime-salesforce-reference/issues/9/events","html_url":"https://github.com/Oblongmana/sublime-salesforce-reference/pull/9","id":99849070,"number":9,"title":"Visualforce documentation. Settings enhancement","user":{"login":"maaaaarco","id":8080936,"avatar_url":"https://avatars.githubusercontent.com/u/8080936?v=3","gravatar_id":"","url":"https://api.github.com/users/maaaaarco","html_url":"https://github.com/maaaaarco","followers_url":"https://api.github.com/users/maaaaarco/followers","following_url":"https://api.github.com/users/maaaaarco/following{/other_user}","gists_url":"https://api.github.com/users/maaaaarco/gists{/gist_id}","starred_url":"https://api.github.com/users/maaaaarco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maaaaarco/subscriptions","organizations_url":"https://api.github.com/users/maaaaarco/orgs","repos_url":"https://api.github.com/users/maaaaarco/repos","events_url":"https://api.github.com/users/maaaaarco/events{/privacy}","received_events_url":"https://api.github.com/users/maaaaarco/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-09T00:59:43Z","updated_at":"2015-08-26T01:40:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Oblongmana/sublime-salesforce-reference/pulls/9","html_url":"https://github.com/Oblongmana/sublime-salesforce-reference/pull/9","diff_url":"https://github.com/Oblongmana/sublime-salesforce-reference/pull/9.diff","patch_url":"https://github.com/Oblongmana/sublime-salesforce-reference/pull/9.patch"},"body":"Hi guys,\r\nlet me say thanks, before i start, this plugin is really awsome and save me a lot of time!\r\n\r\nI added a couple of functionality here...\r\nFirst of all, i added the method to download also Visualforce standard component references. I found it very useful when i have to deal with both Apex and Visualforce.\r\n\r\nA little bit of code refactoring. I added two method, one to retrieve Apex documentation and the other for Visualforce one.\r\n\r\nAdded two settings in plugin's setting file to let users configure what kind of documentation to download.\r\n\r\nWhat you think?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Oblongmana/sublime-salesforce-reference/issues/comments/134786470","html_url":"https://github.com/Oblongmana/sublime-salesforce-reference/pull/9#issuecomment-134786470","issue_url":"https://api.github.com/repos/Oblongmana/sublime-salesforce-reference/issues/9","id":134786470,"user":{"login":"Oblongmana","id":1976919,"avatar_url":"https://avatars.githubusercontent.com/u/1976919?v=3","gravatar_id":"","url":"https://api.github.com/users/Oblongmana","html_url":"https://github.com/Oblongmana","followers_url":"https://api.github.com/users/Oblongmana/followers","following_url":"https://api.github.com/users/Oblongmana/following{/other_user}","gists_url":"https://api.github.com/users/Oblongmana/gists{/gist_id}","starred_url":"https://api.github.com/users/Oblongmana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Oblongmana/subscriptions","organizations_url":"https://api.github.com/users/Oblongmana/orgs","repos_url":"https://api.github.com/users/Oblongmana/repos","events_url":"https://api.github.com/users/Oblongmana/events{/privacy}","received_events_url":"https://api.github.com/users/Oblongmana/received_events","type":"User","site_admin":false},"created_at":"2015-08-26T01:40:30Z","updated_at":"2015-08-26T01:40:30Z","body":"@maaaaarco \r\n\r\nNice! Having access to various different documentation types is something I'd discussed with one of my coworkers, we just hadn't worked out exactly the interface for it, or found the time yet. Will try to do a thorough review this in the next week or so, thanks!\r\n\r\nAt a quick glance over the code though: I'm not keen on having _all_ the reference entries (whether Apex, Visualforce, Service Console, or anything else we add) all in a single menu for a few reasons - mostly around possible overlap/clashes, ambiguity when selecting a reference entry, and just the sheer size the list will grow to. What I'd prefer is to split the \"Salesforce Reference\" command into 3 commands (or more, if we add other documentation types in future), each of which will present only the reference associated with that documentation type, so:\r\n  - `Salesforce Reference - Apex` \r\n  - `Salesforce Reference - Visualforce`\r\n  - `Salesforce Reference - Service Console`\r\n\r\nWould you be able to update the PR to do this, or make any comments you want to?"}}