{"action":"created","issue":{"url":"https://api.github.com/repos/stripe/brushfire/issues/76","labels_url":"https://api.github.com/repos/stripe/brushfire/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/stripe/brushfire/issues/76/comments","events_url":"https://api.github.com/repos/stripe/brushfire/issues/76/events","html_url":"https://github.com/stripe/brushfire/pull/76","id":121550354,"number":76,"title":"Make all splits binary","user":{"login":"striation","id":16106269,"avatar_url":"https://avatars.githubusercontent.com/u/16106269?v=3","gravatar_id":"","url":"https://api.github.com/users/striation","html_url":"https://github.com/striation","followers_url":"https://api.github.com/users/striation/followers","following_url":"https://api.github.com/users/striation/following{/other_user}","gists_url":"https://api.github.com/users/striation/gists{/gist_id}","starred_url":"https://api.github.com/users/striation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/striation/subscriptions","organizations_url":"https://api.github.com/users/striation/orgs","repos_url":"https://api.github.com/users/striation/repos","events_url":"https://api.github.com/users/striation/events{/privacy}","received_events_url":"https://api.github.com/users/striation/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-12-10T18:38:11Z","updated_at":"2015-12-23T22:13:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stripe/brushfire/pulls/76","html_url":"https://github.com/stripe/brushfire/pull/76","diff_url":"https://github.com/stripe/brushfire/pull/76.diff","patch_url":"https://github.com/stripe/brushfire/pull/76.patch"},"body":"This PR simplifies brushfire's conception of split nodes (and splits) so that all decisions are binary. In practice this is almost always the case.\r\n\r\nSome benefits of this:\r\n\r\n1. Should drastically reduce the number of `Predicate` instances we need.\r\n2. Avoid allocating a collection instances per split node.\r\n3. Simplify algorithms which had to encode/decode implicit binary structure.\r\n4. Nicer to use single concrete `Split` class.\r\n\r\nSome drawback:\r\n\r\n1. Different serialization format.\r\n2. Source/binary-incompatible change.\r\n\r\nWhat do you all think?"},"comment":{"url":"https://api.github.com/repos/stripe/brushfire/issues/comments/167000643","html_url":"https://github.com/stripe/brushfire/pull/76#issuecomment-167000643","issue_url":"https://api.github.com/repos/stripe/brushfire/issues/76","id":167000643,"user":{"login":"avibryant","id":9892,"avatar_url":"https://avatars.githubusercontent.com/u/9892?v=3","gravatar_id":"","url":"https://api.github.com/users/avibryant","html_url":"https://github.com/avibryant","followers_url":"https://api.github.com/users/avibryant/followers","following_url":"https://api.github.com/users/avibryant/following{/other_user}","gists_url":"https://api.github.com/users/avibryant/gists{/gist_id}","starred_url":"https://api.github.com/users/avibryant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avibryant/subscriptions","organizations_url":"https://api.github.com/users/avibryant/orgs","repos_url":"https://api.github.com/users/avibryant/repos","events_url":"https://api.github.com/users/avibryant/events{/privacy}","received_events_url":"https://api.github.com/users/avibryant/received_events","type":"User","site_admin":false},"created_at":"2015-12-23T22:13:46Z","updated_at":"2015-12-23T22:13:46Z","body":"We have three big pull requests in flight - this one, https://github.com/stripe/brushfire/pull/74, and now https://github.com/stripe/brushfire/pull/77 . @NathanHowell @striation any thoughts on the right order to try to land them in?"}}