{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/jquery/pulls/comments/43573812","id":43573812,"diff_hunk":"@@ -88,12 +88,15 @@ jQuery.ajaxTransport( function( options ) {\n \t\t\t\t\t\t\t\t\txhrSuccessStatus[ xhr.status ] || xhr.status,\n \t\t\t\t\t\t\t\t\txhr.statusText,\n \n-\t\t\t\t\t\t\t\t\t// Support: IE9\n-\t\t\t\t\t\t\t\t\t// Accessing binary-data responseText throws an exception\n-\t\t\t\t\t\t\t\t\t// (#11426)\n-\t\t\t\t\t\t\t\t\ttypeof xhr.responseText === \"string\" ? {\n-\t\t\t\t\t\t\t\t\t\ttext: xhr.responseText\n-\t\t\t\t\t\t\t\t\t} : undefined,\n+\t\t\t\t\t\t\t\t\t// XHR2 responseText throws an exception on binary data,\n+\t\t\t\t\t\t\t\t\t// return it raw and let a converter or caller handle it\n+\t\t\t\t\t\t\t\t\t// https://xhr.spec.whatwg.org/#the-responsetext-attribute\n+\t\t\t\t\t\t\t\t\t// (trac-11426, gh-2498)\n+\t\t\t\t\t\t\t\t\txhr.responseType === \"arraybuffer\" ||","path":"src/ajax/xhr.js","position":14,"original_position":14,"commit_id":"6fae2965ad12e13b93eccaffdfe60d64493546c8","original_commit_id":"6fae2965ad12e13b93eccaffdfe60d64493546c8","user":{"login":"dmethvin","id":157858,"avatar_url":"https://avatars.githubusercontent.com/u/157858?v=3","gravatar_id":"","url":"https://api.github.com/users/dmethvin","html_url":"https://github.com/dmethvin","followers_url":"https://api.github.com/users/dmethvin/followers","following_url":"https://api.github.com/users/dmethvin/following{/other_user}","gists_url":"https://api.github.com/users/dmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmethvin/subscriptions","organizations_url":"https://api.github.com/users/dmethvin/orgs","repos_url":"https://api.github.com/users/dmethvin/repos","events_url":"https://api.github.com/users/dmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/dmethvin/received_events","type":"User","site_admin":false},"body":"That will force the `json` and `document` (XML) cases down the wrong branch, or at least wrong for the current logic in ajax.js that wants to convert the `text` result explicitly rather than letting XHR do it. This was due to various bugs and/or inability to control cases like [trac-13276](http://bugs.jquery.com/ticket/13276). @jaubourg says in that ticket he could only make it happen in IE9 so maybe we could hew closer to the spec once we drop IE9 support after 3.0? At that point we should be able to drop the `typeof` check as well and just look at `.responseType`.","created_at":"2015-10-31T17:12:51Z","updated_at":"2015-10-31T17:12:51Z","html_url":"https://github.com/jquery/jquery/pull/2682#discussion_r43573812","pull_request_url":"https://api.github.com/repos/jquery/jquery/pulls/2682","_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments/43573812"},"html":{"href":"https://github.com/jquery/jquery/pull/2682#discussion_r43573812"},"pull_request":{"href":"https://api.github.com/repos/jquery/jquery/pulls/2682"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/jquery/pulls/2682","id":49351649,"html_url":"https://github.com/jquery/jquery/pull/2682","diff_url":"https://github.com/jquery/jquery/pull/2682.diff","patch_url":"https://github.com/jquery/jquery/pull/2682.patch","issue_url":"https://api.github.com/repos/jquery/jquery/issues/2682","number":2682,"state":"open","locked":false,"title":"Ajax: Don't throw exceptions on binary data response","user":{"login":"dmethvin","id":157858,"avatar_url":"https://avatars.githubusercontent.com/u/157858?v=3","gravatar_id":"","url":"https://api.github.com/users/dmethvin","html_url":"https://github.com/dmethvin","followers_url":"https://api.github.com/users/dmethvin/followers","following_url":"https://api.github.com/users/dmethvin/following{/other_user}","gists_url":"https://api.github.com/users/dmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmethvin/subscriptions","organizations_url":"https://api.github.com/users/dmethvin/orgs","repos_url":"https://api.github.com/users/dmethvin/repos","events_url":"https://api.github.com/users/dmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/dmethvin/received_events","type":"User","site_admin":false},"body":"Fixes #2498\r\n\r\nThe added unit test shows how this could be used to support an\r\nArrayBuffer return, but $.ajax does not support it natively.\r\nThe goal with this change was to avoid the exception.","created_at":"2015-10-31T15:27:33Z","updated_at":"2015-10-31T17:12:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5376e6285f1f984f70b7d57f66fe77394cec8f04","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jquery/jquery/pulls/2682/commits","review_comments_url":"https://api.github.com/repos/jquery/jquery/pulls/2682/comments","review_comment_url":"https://api.github.com/repos/jquery/jquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/jquery/issues/2682/comments","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/6fae2965ad12e13b93eccaffdfe60d64493546c8","head":{"label":"dmethvin:2498-non-text-response","ref":"2498-non-text-response","sha":"6fae2965ad12e13b93eccaffdfe60d64493546c8","user":{"login":"dmethvin","id":157858,"avatar_url":"https://avatars.githubusercontent.com/u/157858?v=3","gravatar_id":"","url":"https://api.github.com/users/dmethvin","html_url":"https://github.com/dmethvin","followers_url":"https://api.github.com/users/dmethvin/followers","following_url":"https://api.github.com/users/dmethvin/following{/other_user}","gists_url":"https://api.github.com/users/dmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmethvin/subscriptions","organizations_url":"https://api.github.com/users/dmethvin/orgs","repos_url":"https://api.github.com/users/dmethvin/repos","events_url":"https://api.github.com/users/dmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/dmethvin/received_events","type":"User","site_admin":false},"repo":{"id":1148694,"name":"jquery","full_name":"dmethvin/jquery","owner":{"login":"dmethvin","id":157858,"avatar_url":"https://avatars.githubusercontent.com/u/157858?v=3","gravatar_id":"","url":"https://api.github.com/users/dmethvin","html_url":"https://github.com/dmethvin","followers_url":"https://api.github.com/users/dmethvin/followers","following_url":"https://api.github.com/users/dmethvin/following{/other_user}","gists_url":"https://api.github.com/users/dmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmethvin/subscriptions","organizations_url":"https://api.github.com/users/dmethvin/orgs","repos_url":"https://api.github.com/users/dmethvin/repos","events_url":"https://api.github.com/users/dmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/dmethvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmethvin/jquery","description":"jQuery JavaScript Library","fork":true,"url":"https://api.github.com/repos/dmethvin/jquery","forks_url":"https://api.github.com/repos/dmethvin/jquery/forks","keys_url":"https://api.github.com/repos/dmethvin/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmethvin/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmethvin/jquery/teams","hooks_url":"https://api.github.com/repos/dmethvin/jquery/hooks","issue_events_url":"https://api.github.com/repos/dmethvin/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/dmethvin/jquery/events","assignees_url":"https://api.github.com/repos/dmethvin/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/dmethvin/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/dmethvin/jquery/tags","blobs_url":"https://api.github.com/repos/dmethvin/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmethvin/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmethvin/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmethvin/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmethvin/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/dmethvin/jquery/languages","stargazers_url":"https://api.github.com/repos/dmethvin/jquery/stargazers","contributors_url":"https://api.github.com/repos/dmethvin/jquery/contributors","subscribers_url":"https://api.github.com/repos/dmethvin/jquery/subscribers","subscription_url":"https://api.github.com/repos/dmethvin/jquery/subscription","commits_url":"https://api.github.com/repos/dmethvin/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmethvin/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmethvin/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmethvin/jquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmethvin/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/dmethvin/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmethvin/jquery/merges","archive_url":"https://api.github.com/repos/dmethvin/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmethvin/jquery/downloads","issues_url":"https://api.github.com/repos/dmethvin/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/dmethvin/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/dmethvin/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/dmethvin/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmethvin/jquery/labels{/name}","releases_url":"https://api.github.com/repos/dmethvin/jquery/releases{/id}","created_at":"2010-12-08T03:37:21Z","updated_at":"2015-08-27T06:15:45Z","pushed_at":"2015-10-31T15:26:33Z","git_url":"git://github.com/dmethvin/jquery.git","ssh_url":"git@github.com:dmethvin/jquery.git","clone_url":"https://github.com/dmethvin/jquery.git","svn_url":"https://github.com/dmethvin/jquery","homepage":"http://jquery.com/","size":21270,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"015d16c02dae770eda88e644ec69ce82f25c0412","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":167174,"name":"jquery","full_name":"jquery/jquery","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/jquery","description":"jQuery JavaScript Library","fork":false,"url":"https://api.github.com/repos/jquery/jquery","forks_url":"https://api.github.com/repos/jquery/jquery/forks","keys_url":"https://api.github.com/repos/jquery/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/jquery/teams","hooks_url":"https://api.github.com/repos/jquery/jquery/hooks","issue_events_url":"https://api.github.com/repos/jquery/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/jquery/events","assignees_url":"https://api.github.com/repos/jquery/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/jquery/tags","blobs_url":"https://api.github.com/repos/jquery/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/jquery/languages","stargazers_url":"https://api.github.com/repos/jquery/jquery/stargazers","contributors_url":"https://api.github.com/repos/jquery/jquery/contributors","subscribers_url":"https://api.github.com/repos/jquery/jquery/subscribers","subscription_url":"https://api.github.com/repos/jquery/jquery/subscription","commits_url":"https://api.github.com/repos/jquery/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/jquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/jquery/merges","archive_url":"https://api.github.com/repos/jquery/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/jquery/downloads","issues_url":"https://api.github.com/repos/jquery/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/jquery/labels{/name}","releases_url":"https://api.github.com/repos/jquery/jquery/releases{/id}","created_at":"2009-04-03T15:20:14Z","updated_at":"2015-10-31T16:35:23Z","pushed_at":"2015-10-31T15:27:33Z","git_url":"git://github.com/jquery/jquery.git","ssh_url":"git@github.com:jquery/jquery.git","clone_url":"https://github.com/jquery/jquery.git","svn_url":"https://github.com/jquery/jquery","homepage":"http://jquery.com/","size":62083,"stargazers_count":36478,"watchers_count":36478,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":9343,"mirror_url":null,"open_issues_count":90,"forks":9343,"open_issues":90,"watchers":36478,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/2682"},"html":{"href":"https://github.com/jquery/jquery/pull/2682"},"issue":{"href":"https://api.github.com/repos/jquery/jquery/issues/2682"},"comments":{"href":"https://api.github.com/repos/jquery/jquery/issues/2682/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/jquery/pulls/2682/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/jquery/pulls/2682/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/jquery/statuses/6fae2965ad12e13b93eccaffdfe60d64493546c8"}}}}