{"action":"created","comment":{"url":"https://api.github.com/repos/sunpy/sunpy/pulls/comments/26440326","id":26440326,"diff_hunk":"@@ -3,10 +3,11 @@\n from __future__ import absolute_import\n \n from sunpy.util.net import url_exists\n-from os import rename, remove\n+from os import remove\n from astropy.utils.data import download_file\n from zipfile import ZipFile\n from urllib2 import URLError\n+from shutil import move\n \n import os.path\n ","path":"sunpy/data/_sample.py","position":12,"original_position":12,"commit_id":"0de1c693171fdd48c71327c7516f8f4bba42f28f","original_commit_id":"0de1c693171fdd48c71327c7516f8f4bba42f28f","user":{"login":"gcetusic","id":1023690,"avatar_url":"https://avatars.githubusercontent.com/u/1023690?v=3","gravatar_id":"","url":"https://api.github.com/users/gcetusic","html_url":"https://github.com/gcetusic","followers_url":"https://api.github.com/users/gcetusic/followers","following_url":"https://api.github.com/users/gcetusic/following{/other_user}","gists_url":"https://api.github.com/users/gcetusic/gists{/gist_id}","starred_url":"https://api.github.com/users/gcetusic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcetusic/subscriptions","organizations_url":"https://api.github.com/users/gcetusic/orgs","repos_url":"https://api.github.com/users/gcetusic/repos","events_url":"https://api.github.com/users/gcetusic/events{/privacy}","received_events_url":"https://api.github.com/users/gcetusic/received_events","type":"User","site_admin":false},"body":"I'll have to confirm that but I think you're right. Linter can't detect that.","created_at":"2015-03-14T18:34:20Z","updated_at":"2015-03-14T18:34:20Z","html_url":"https://github.com/sunpy/sunpy/pull/1335#discussion_r26440326","pull_request_url":"https://api.github.com/repos/sunpy/sunpy/pulls/1335","_links":{"self":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/comments/26440326"},"html":{"href":"https://github.com/sunpy/sunpy/pull/1335#discussion_r26440326"},"pull_request":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1335"}}},"pull_request":{"url":"https://api.github.com/repos/sunpy/sunpy/pulls/1335","id":31186419,"html_url":"https://github.com/sunpy/sunpy/pull/1335","diff_url":"https://github.com/sunpy/sunpy/pull/1335.diff","patch_url":"https://github.com/sunpy/sunpy/pull/1335.patch","issue_url":"https://api.github.com/repos/sunpy/sunpy/issues/1335","number":1335,"state":"open","locked":false,"title":"fixed download_sample_data","user":{"login":"gcetusic","id":1023690,"avatar_url":"https://avatars.githubusercontent.com/u/1023690?v=3","gravatar_id":"","url":"https://api.github.com/users/gcetusic","html_url":"https://github.com/gcetusic","followers_url":"https://api.github.com/users/gcetusic/followers","following_url":"https://api.github.com/users/gcetusic/following{/other_user}","gists_url":"https://api.github.com/users/gcetusic/gists{/gist_id}","starred_url":"https://api.github.com/users/gcetusic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcetusic/subscriptions","organizations_url":"https://api.github.com/users/gcetusic/orgs","repos_url":"https://api.github.com/users/gcetusic/repos","events_url":"https://api.github.com/users/gcetusic/events{/privacy}","received_events_url":"https://api.github.com/users/gcetusic/received_events","type":"User","site_admin":false},"body":"Importing sunpy.data.sample notifies that no sample data is available and should be downloaded with download_sample_data but once you try that is fails when calling rename with 'invalid cross-device link' when using rename, probably because of different partitions of files. Also, the readme doesn't work because sample image that gets called by matplolib has moved to sunpy.data.sample and minor PEP8 fixes.","created_at":"2015-03-14T17:04:33Z","updated_at":"2015-03-14T18:34:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfa61dbb144f5562d5a6e41af9630190a20d1853","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sunpy/sunpy/pulls/1335/commits","review_comments_url":"https://api.github.com/repos/sunpy/sunpy/pulls/1335/comments","review_comment_url":"https://api.github.com/repos/sunpy/sunpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sunpy/sunpy/issues/1335/comments","statuses_url":"https://api.github.com/repos/sunpy/sunpy/statuses/0de1c693171fdd48c71327c7516f8f4bba42f28f","head":{"label":"gcetusic:hotfix/download_sample_data","ref":"hotfix/download_sample_data","sha":"0de1c693171fdd48c71327c7516f8f4bba42f28f","user":{"login":"gcetusic","id":1023690,"avatar_url":"https://avatars.githubusercontent.com/u/1023690?v=3","gravatar_id":"","url":"https://api.github.com/users/gcetusic","html_url":"https://github.com/gcetusic","followers_url":"https://api.github.com/users/gcetusic/followers","following_url":"https://api.github.com/users/gcetusic/following{/other_user}","gists_url":"https://api.github.com/users/gcetusic/gists{/gist_id}","starred_url":"https://api.github.com/users/gcetusic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcetusic/subscriptions","organizations_url":"https://api.github.com/users/gcetusic/orgs","repos_url":"https://api.github.com/users/gcetusic/repos","events_url":"https://api.github.com/users/gcetusic/events{/privacy}","received_events_url":"https://api.github.com/users/gcetusic/received_events","type":"User","site_admin":false},"repo":{"id":31956892,"name":"sunpy","full_name":"gcetusic/sunpy","owner":{"login":"gcetusic","id":1023690,"avatar_url":"https://avatars.githubusercontent.com/u/1023690?v=3","gravatar_id":"","url":"https://api.github.com/users/gcetusic","html_url":"https://github.com/gcetusic","followers_url":"https://api.github.com/users/gcetusic/followers","following_url":"https://api.github.com/users/gcetusic/following{/other_user}","gists_url":"https://api.github.com/users/gcetusic/gists{/gist_id}","starred_url":"https://api.github.com/users/gcetusic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcetusic/subscriptions","organizations_url":"https://api.github.com/users/gcetusic/orgs","repos_url":"https://api.github.com/users/gcetusic/repos","events_url":"https://api.github.com/users/gcetusic/events{/privacy}","received_events_url":"https://api.github.com/users/gcetusic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gcetusic/sunpy","description":"SunPy - Python for solar physics","fork":true,"url":"https://api.github.com/repos/gcetusic/sunpy","forks_url":"https://api.github.com/repos/gcetusic/sunpy/forks","keys_url":"https://api.github.com/repos/gcetusic/sunpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gcetusic/sunpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gcetusic/sunpy/teams","hooks_url":"https://api.github.com/repos/gcetusic/sunpy/hooks","issue_events_url":"https://api.github.com/repos/gcetusic/sunpy/issues/events{/number}","events_url":"https://api.github.com/repos/gcetusic/sunpy/events","assignees_url":"https://api.github.com/repos/gcetusic/sunpy/assignees{/user}","branches_url":"https://api.github.com/repos/gcetusic/sunpy/branches{/branch}","tags_url":"https://api.github.com/repos/gcetusic/sunpy/tags","blobs_url":"https://api.github.com/repos/gcetusic/sunpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gcetusic/sunpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gcetusic/sunpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gcetusic/sunpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gcetusic/sunpy/statuses/{sha}","languages_url":"https://api.github.com/repos/gcetusic/sunpy/languages","stargazers_url":"https://api.github.com/repos/gcetusic/sunpy/stargazers","contributors_url":"https://api.github.com/repos/gcetusic/sunpy/contributors","subscribers_url":"https://api.github.com/repos/gcetusic/sunpy/subscribers","subscription_url":"https://api.github.com/repos/gcetusic/sunpy/subscription","commits_url":"https://api.github.com/repos/gcetusic/sunpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gcetusic/sunpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gcetusic/sunpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gcetusic/sunpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gcetusic/sunpy/contents/{+path}","compare_url":"https://api.github.com/repos/gcetusic/sunpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gcetusic/sunpy/merges","archive_url":"https://api.github.com/repos/gcetusic/sunpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gcetusic/sunpy/downloads","issues_url":"https://api.github.com/repos/gcetusic/sunpy/issues{/number}","pulls_url":"https://api.github.com/repos/gcetusic/sunpy/pulls{/number}","milestones_url":"https://api.github.com/repos/gcetusic/sunpy/milestones{/number}","notifications_url":"https://api.github.com/repos/gcetusic/sunpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gcetusic/sunpy/labels{/name}","releases_url":"https://api.github.com/repos/gcetusic/sunpy/releases{/id}","created_at":"2015-03-10T12:45:54Z","updated_at":"2015-03-10T12:45:55Z","pushed_at":"2015-03-14T17:00:42Z","git_url":"git://github.com/gcetusic/sunpy.git","ssh_url":"git@github.com:gcetusic/sunpy.git","clone_url":"https://github.com/gcetusic/sunpy.git","svn_url":"https://github.com/gcetusic/sunpy","homepage":"http://www.sunpy.org","size":143488,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sunpy:master","ref":"master","sha":"ab3ee6e11b62f006471c3440c805a95b6184fcaa","user":{"login":"sunpy","id":963197,"avatar_url":"https://avatars.githubusercontent.com/u/963197?v=3","gravatar_id":"","url":"https://api.github.com/users/sunpy","html_url":"https://github.com/sunpy","followers_url":"https://api.github.com/users/sunpy/followers","following_url":"https://api.github.com/users/sunpy/following{/other_user}","gists_url":"https://api.github.com/users/sunpy/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpy/subscriptions","organizations_url":"https://api.github.com/users/sunpy/orgs","repos_url":"https://api.github.com/users/sunpy/repos","events_url":"https://api.github.com/users/sunpy/events{/privacy}","received_events_url":"https://api.github.com/users/sunpy/received_events","type":"Organization","site_admin":false},"repo":{"id":2165383,"name":"sunpy","full_name":"sunpy/sunpy","owner":{"login":"sunpy","id":963197,"avatar_url":"https://avatars.githubusercontent.com/u/963197?v=3","gravatar_id":"","url":"https://api.github.com/users/sunpy","html_url":"https://github.com/sunpy","followers_url":"https://api.github.com/users/sunpy/followers","following_url":"https://api.github.com/users/sunpy/following{/other_user}","gists_url":"https://api.github.com/users/sunpy/gists{/gist_id}","starred_url":"https://api.github.com/users/sunpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunpy/subscriptions","organizations_url":"https://api.github.com/users/sunpy/orgs","repos_url":"https://api.github.com/users/sunpy/repos","events_url":"https://api.github.com/users/sunpy/events{/privacy}","received_events_url":"https://api.github.com/users/sunpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sunpy/sunpy","description":"SunPy - Python for solar physics","fork":false,"url":"https://api.github.com/repos/sunpy/sunpy","forks_url":"https://api.github.com/repos/sunpy/sunpy/forks","keys_url":"https://api.github.com/repos/sunpy/sunpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sunpy/sunpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sunpy/sunpy/teams","hooks_url":"https://api.github.com/repos/sunpy/sunpy/hooks","issue_events_url":"https://api.github.com/repos/sunpy/sunpy/issues/events{/number}","events_url":"https://api.github.com/repos/sunpy/sunpy/events","assignees_url":"https://api.github.com/repos/sunpy/sunpy/assignees{/user}","branches_url":"https://api.github.com/repos/sunpy/sunpy/branches{/branch}","tags_url":"https://api.github.com/repos/sunpy/sunpy/tags","blobs_url":"https://api.github.com/repos/sunpy/sunpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sunpy/sunpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sunpy/sunpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sunpy/sunpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sunpy/sunpy/statuses/{sha}","languages_url":"https://api.github.com/repos/sunpy/sunpy/languages","stargazers_url":"https://api.github.com/repos/sunpy/sunpy/stargazers","contributors_url":"https://api.github.com/repos/sunpy/sunpy/contributors","subscribers_url":"https://api.github.com/repos/sunpy/sunpy/subscribers","subscription_url":"https://api.github.com/repos/sunpy/sunpy/subscription","commits_url":"https://api.github.com/repos/sunpy/sunpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sunpy/sunpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sunpy/sunpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sunpy/sunpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sunpy/sunpy/contents/{+path}","compare_url":"https://api.github.com/repos/sunpy/sunpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sunpy/sunpy/merges","archive_url":"https://api.github.com/repos/sunpy/sunpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sunpy/sunpy/downloads","issues_url":"https://api.github.com/repos/sunpy/sunpy/issues{/number}","pulls_url":"https://api.github.com/repos/sunpy/sunpy/pulls{/number}","milestones_url":"https://api.github.com/repos/sunpy/sunpy/milestones{/number}","notifications_url":"https://api.github.com/repos/sunpy/sunpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sunpy/sunpy/labels{/name}","releases_url":"https://api.github.com/repos/sunpy/sunpy/releases{/id}","created_at":"2011-08-06T15:34:08Z","updated_at":"2015-03-13T10:18:00Z","pushed_at":"2015-03-13T10:18:00Z","git_url":"git://github.com/sunpy/sunpy.git","ssh_url":"git@github.com:sunpy/sunpy.git","clone_url":"https://github.com/sunpy/sunpy.git","svn_url":"https://github.com/sunpy/sunpy","homepage":"http://www.sunpy.org","size":143488,"stargazers_count":176,"watchers_count":176,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":198,"forks":115,"open_issues":198,"watchers":176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1335"},"html":{"href":"https://github.com/sunpy/sunpy/pull/1335"},"issue":{"href":"https://api.github.com/repos/sunpy/sunpy/issues/1335"},"comments":{"href":"https://api.github.com/repos/sunpy/sunpy/issues/1335/comments"},"review_comments":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1335/comments"},"review_comment":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sunpy/sunpy/pulls/1335/commits"},"statuses":{"href":"https://api.github.com/repos/sunpy/sunpy/statuses/0de1c693171fdd48c71327c7516f8f4bba42f28f"}}}}