{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/pulls/9","id":52829474,"html_url":"https://github.com/ustwo/autolayout-helper-swift/pull/9","diff_url":"https://github.com/ustwo/autolayout-helper-swift/pull/9.diff","patch_url":"https://github.com/ustwo/autolayout-helper-swift/pull/9.patch","issue_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/issues/9","number":9,"state":"closed","locked":false,"title":"Fix for issue #8","user":{"login":"madhikarma","id":1456685,"avatar_url":"https://avatars.githubusercontent.com/u/1456685?v=3","gravatar_id":"","url":"https://api.github.com/users/madhikarma","html_url":"https://github.com/madhikarma","followers_url":"https://api.github.com/users/madhikarma/followers","following_url":"https://api.github.com/users/madhikarma/following{/other_user}","gists_url":"https://api.github.com/users/madhikarma/gists{/gist_id}","starred_url":"https://api.github.com/users/madhikarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhikarma/subscriptions","organizations_url":"https://api.github.com/users/madhikarma/orgs","repos_url":"https://api.github.com/users/madhikarma/repos","events_url":"https://api.github.com/users/madhikarma/events{/privacy}","received_events_url":"https://api.github.com/users/madhikarma/received_events","type":"User","site_admin":false},"body":"Fixes #8 a regression in <code>fillSuperview</code> method \r\n\r\nNote. the same thing happened on the Obj-C port ustwo/autolayout-helper-ios@d9fc906 :)\r\n\r\n### Description\r\n- Updated fillSuperview not applying negative bottom and right margins\r\n- Updated unit tests\r\n\r\n### Tasks\r\n- [x] Code review\r\n- [x] Unit tests\r\n- [x] Manual Testing\r\n\r\n### Screenshots\r\n\r\n(The red view laid out using fillSuperview method and shows that insets for the bottom and right are applied negatively within the method) \r\n\r\n<img width=\"423\" alt=\"screen shot 2015-12-07 at 10 47 43\" src=\"https://cloud.githubusercontent.com/assets/1456685/11625070/05dba2c8-9cd0-11e5-8726-fb4bdf8e99ba.png\">\r\n\r\ncc @ylibatsya @danieladias @jamaine-ustwo @chris59david ","created_at":"2015-12-07T10:49:13Z","updated_at":"2015-12-07T11:11:54Z","closed_at":"2015-12-07T11:11:53Z","merged_at":"2015-12-07T11:11:53Z","merge_commit_sha":"9a527f943c4ee5aef89f4d220660061418303767","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/pulls/9/commits","review_comments_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/pulls/9/comments","review_comment_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/issues/9/comments","statuses_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/statuses/7c47f96889ac9a197aaebfe8ebb3c474af4f4f3c","head":{"label":"ustwo:issue-8-fillsuperview","ref":"issue-8-fillsuperview","sha":"7c47f96889ac9a197aaebfe8ebb3c474af4f4f3c","user":{"login":"ustwo","id":625384,"avatar_url":"https://avatars.githubusercontent.com/u/625384?v=3","gravatar_id":"","url":"https://api.github.com/users/ustwo","html_url":"https://github.com/ustwo","followers_url":"https://api.github.com/users/ustwo/followers","following_url":"https://api.github.com/users/ustwo/following{/other_user}","gists_url":"https://api.github.com/users/ustwo/gists{/gist_id}","starred_url":"https://api.github.com/users/ustwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ustwo/subscriptions","organizations_url":"https://api.github.com/users/ustwo/orgs","repos_url":"https://api.github.com/users/ustwo/repos","events_url":"https://api.github.com/users/ustwo/events{/privacy}","received_events_url":"https://api.github.com/users/ustwo/received_events","type":"Organization","site_admin":false},"repo":{"id":37486201,"name":"autolayout-helper-swift","full_name":"ustwo/autolayout-helper-swift","owner":{"login":"ustwo","id":625384,"avatar_url":"https://avatars.githubusercontent.com/u/625384?v=3","gravatar_id":"","url":"https://api.github.com/users/ustwo","html_url":"https://github.com/ustwo","followers_url":"https://api.github.com/users/ustwo/followers","following_url":"https://api.github.com/users/ustwo/following{/other_user}","gists_url":"https://api.github.com/users/ustwo/gists{/gist_id}","starred_url":"https://api.github.com/users/ustwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ustwo/subscriptions","organizations_url":"https://api.github.com/users/ustwo/orgs","repos_url":"https://api.github.com/users/ustwo/repos","events_url":"https://api.github.com/users/ustwo/events{/privacy}","received_events_url":"https://api.github.com/users/ustwo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ustwo/autolayout-helper-swift","description":"UIView extension to ease creating Auto Layout Constraints","fork":true,"url":"https://api.github.com/repos/ustwo/autolayout-helper-swift","forks_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/forks","keys_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/teams","hooks_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/hooks","issue_events_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/issues/events{/number}","events_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/events","assignees_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/assignees{/user}","branches_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/branches{/branch}","tags_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/tags","blobs_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/statuses/{sha}","languages_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/languages","stargazers_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/stargazers","contributors_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/contributors","subscribers_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/subscribers","subscription_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/subscription","commits_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/contents/{+path}","compare_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/merges","archive_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/downloads","issues_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/issues{/number}","pulls_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/pulls{/number}","milestones_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/milestones{/number}","notifications_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/labels{/name}","releases_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/releases{/id}","created_at":"2015-06-15T19:22:36Z","updated_at":"2015-11-27T22:40:02Z","pushed_at":"2015-12-07T11:11:54Z","git_url":"git://github.com/ustwo/autolayout-helper-swift.git","ssh_url":"git@github.com:ustwo/autolayout-helper-swift.git","clone_url":"https://github.com/ustwo/autolayout-helper-swift.git","svn_url":"https://github.com/ustwo/autolayout-helper-swift","homepage":"","size":286,"stargazers_count":2,"watchers_count":2,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"ustwo:master","ref":"master","sha":"fabbc9b7c7fe5760069f7b1dc5f592dfcbd7363e","user":{"login":"ustwo","id":625384,"avatar_url":"https://avatars.githubusercontent.com/u/625384?v=3","gravatar_id":"","url":"https://api.github.com/users/ustwo","html_url":"https://github.com/ustwo","followers_url":"https://api.github.com/users/ustwo/followers","following_url":"https://api.github.com/users/ustwo/following{/other_user}","gists_url":"https://api.github.com/users/ustwo/gists{/gist_id}","starred_url":"https://api.github.com/users/ustwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ustwo/subscriptions","organizations_url":"https://api.github.com/users/ustwo/orgs","repos_url":"https://api.github.com/users/ustwo/repos","events_url":"https://api.github.com/users/ustwo/events{/privacy}","received_events_url":"https://api.github.com/users/ustwo/received_events","type":"Organization","site_admin":false},"repo":{"id":37486201,"name":"autolayout-helper-swift","full_name":"ustwo/autolayout-helper-swift","owner":{"login":"ustwo","id":625384,"avatar_url":"https://avatars.githubusercontent.com/u/625384?v=3","gravatar_id":"","url":"https://api.github.com/users/ustwo","html_url":"https://github.com/ustwo","followers_url":"https://api.github.com/users/ustwo/followers","following_url":"https://api.github.com/users/ustwo/following{/other_user}","gists_url":"https://api.github.com/users/ustwo/gists{/gist_id}","starred_url":"https://api.github.com/users/ustwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ustwo/subscriptions","organizations_url":"https://api.github.com/users/ustwo/orgs","repos_url":"https://api.github.com/users/ustwo/repos","events_url":"https://api.github.com/users/ustwo/events{/privacy}","received_events_url":"https://api.github.com/users/ustwo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ustwo/autolayout-helper-swift","description":"UIView extension to ease creating Auto Layout Constraints","fork":true,"url":"https://api.github.com/repos/ustwo/autolayout-helper-swift","forks_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/forks","keys_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/teams","hooks_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/hooks","issue_events_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/issues/events{/number}","events_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/events","assignees_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/assignees{/user}","branches_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/branches{/branch}","tags_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/tags","blobs_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/statuses/{sha}","languages_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/languages","stargazers_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/stargazers","contributors_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/contributors","subscribers_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/subscribers","subscription_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/subscription","commits_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/contents/{+path}","compare_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/merges","archive_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/downloads","issues_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/issues{/number}","pulls_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/pulls{/number}","milestones_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/milestones{/number}","notifications_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/labels{/name}","releases_url":"https://api.github.com/repos/ustwo/autolayout-helper-swift/releases{/id}","created_at":"2015-06-15T19:22:36Z","updated_at":"2015-11-27T22:40:02Z","pushed_at":"2015-12-07T11:11:54Z","git_url":"git://github.com/ustwo/autolayout-helper-swift.git","ssh_url":"git@github.com:ustwo/autolayout-helper-swift.git","clone_url":"https://github.com/ustwo/autolayout-helper-swift.git","svn_url":"https://github.com/ustwo/autolayout-helper-swift","homepage":"","size":286,"stargazers_count":2,"watchers_count":2,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ustwo/autolayout-helper-swift/pulls/9"},"html":{"href":"https://github.com/ustwo/autolayout-helper-swift/pull/9"},"issue":{"href":"https://api.github.com/repos/ustwo/autolayout-helper-swift/issues/9"},"comments":{"href":"https://api.github.com/repos/ustwo/autolayout-helper-swift/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/ustwo/autolayout-helper-swift/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/ustwo/autolayout-helper-swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ustwo/autolayout-helper-swift/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/ustwo/autolayout-helper-swift/statuses/7c47f96889ac9a197aaebfe8ebb3c474af4f4f3c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"madhikarma","id":1456685,"avatar_url":"https://avatars.githubusercontent.com/u/1456685?v=3","gravatar_id":"","url":"https://api.github.com/users/madhikarma","html_url":"https://github.com/madhikarma","followers_url":"https://api.github.com/users/madhikarma/followers","following_url":"https://api.github.com/users/madhikarma/following{/other_user}","gists_url":"https://api.github.com/users/madhikarma/gists{/gist_id}","starred_url":"https://api.github.com/users/madhikarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhikarma/subscriptions","organizations_url":"https://api.github.com/users/madhikarma/orgs","repos_url":"https://api.github.com/users/madhikarma/repos","events_url":"https://api.github.com/users/madhikarma/events{/privacy}","received_events_url":"https://api.github.com/users/madhikarma/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":8,"deletions":9,"changed_files":3}}