{"comment":{"url":"https://api.github.com/repos/trociny/ceph/comments/9984936","html_url":"https://github.com/trociny/ceph/commit/03371e6f7a540fe6956830061cf64289e64c9cef#commitcomment-9984936","id":9984936,"user":{"login":"jecluis","id":506918,"avatar_url":"https://avatars.githubusercontent.com/u/506918?v=3","gravatar_id":"","url":"https://api.github.com/users/jecluis","html_url":"https://github.com/jecluis","followers_url":"https://api.github.com/users/jecluis/followers","following_url":"https://api.github.com/users/jecluis/following{/other_user}","gists_url":"https://api.github.com/users/jecluis/gists{/gist_id}","starred_url":"https://api.github.com/users/jecluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jecluis/subscriptions","organizations_url":"https://api.github.com/users/jecluis/orgs","repos_url":"https://api.github.com/users/jecluis/repos","events_url":"https://api.github.com/users/jecluis/events{/privacy}","received_events_url":"https://api.github.com/users/jecluis/received_events","type":"User","site_admin":false},"position":142,"line":142,"path":"src/common/SubProcess.h","commit_id":"03371e6f7a540fe6956830061cf64289e64c9cef","created_at":"2015-03-02T13:28:04Z","updated_at":"2015-03-02T13:28:04Z","body":"I don't think this is wise.  Although I can see how one would like to shout to the world that we're doing it wrong (calling ``stdin()`` while passing ``false`` on the constructor), I think this is overkill.  Setting ``strerr`` with an error message, returning the default ``-1`` and let the caller handle the error would suffice.\r\n\r\nSame goes for the other two functions (``stdout()`` and ``stderr()``)."}}