{"action":"opened","number":55,"pull_request":{"url":"https://api.github.com/repos/hapijs/vision/pulls/55","id":44542436,"html_url":"https://github.com/hapijs/vision/pull/55","diff_url":"https://github.com/hapijs/vision/pull/55.diff","patch_url":"https://github.com/hapijs/vision/pull/55.patch","issue_url":"https://api.github.com/repos/hapijs/vision/issues/55","number":55,"state":"open","locked":false,"title":"Failing win tests","user":{"login":"simon-p-r","id":4668724,"avatar_url":"https://avatars.githubusercontent.com/u/4668724?v=3","gravatar_id":"","url":"https://api.github.com/users/simon-p-r","html_url":"https://github.com/simon-p-r","followers_url":"https://api.github.com/users/simon-p-r/followers","following_url":"https://api.github.com/users/simon-p-r/following{/other_user}","gists_url":"https://api.github.com/users/simon-p-r/gists{/gist_id}","starred_url":"https://api.github.com/users/simon-p-r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon-p-r/subscriptions","organizations_url":"https://api.github.com/users/simon-p-r/orgs","repos_url":"https://api.github.com/users/simon-p-r/repos","events_url":"https://api.github.com/users/simon-p-r/events{/privacy}","received_events_url":"https://api.github.com/users/simon-p-r/received_events","type":"User","site_admin":false},"body":"Hi\r\n\r\nWhen running tests of hapi on windows last night I found an issue here https://github.com/hapijs/hapi/blob/master/test/connection.js#L1089-L1118 related to vision.  I have removed string comparisons of rendered html in failing tests due to EOL issue.  The only test I couldn't fix on windows is this one https://github.com/hapijs/vision/blob/master/test/manager.js#L1307-L1330 as it uses chmodSync.  Unfortunately I cannot fix the root cause of issue as I cannot see where new lines are created for rendered object.\r\n\r\nThanks\r\nSimon","created_at":"2015-09-09T12:17:51Z","updated_at":"2015-09-09T12:17:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hapijs/vision/pulls/55/commits","review_comments_url":"https://api.github.com/repos/hapijs/vision/pulls/55/comments","review_comment_url":"https://api.github.com/repos/hapijs/vision/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hapijs/vision/issues/55/comments","statuses_url":"https://api.github.com/repos/hapijs/vision/statuses/314a4e26b679020fe1c0879eff20d087e1b1e1c6","head":{"label":"simon-p-r:win-test-eol","ref":"win-test-eol","sha":"314a4e26b679020fe1c0879eff20d087e1b1e1c6","user":{"login":"simon-p-r","id":4668724,"avatar_url":"https://avatars.githubusercontent.com/u/4668724?v=3","gravatar_id":"","url":"https://api.github.com/users/simon-p-r","html_url":"https://github.com/simon-p-r","followers_url":"https://api.github.com/users/simon-p-r/followers","following_url":"https://api.github.com/users/simon-p-r/following{/other_user}","gists_url":"https://api.github.com/users/simon-p-r/gists{/gist_id}","starred_url":"https://api.github.com/users/simon-p-r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon-p-r/subscriptions","organizations_url":"https://api.github.com/users/simon-p-r/orgs","repos_url":"https://api.github.com/users/simon-p-r/repos","events_url":"https://api.github.com/users/simon-p-r/events{/privacy}","received_events_url":"https://api.github.com/users/simon-p-r/received_events","type":"User","site_admin":false},"repo":{"id":42171562,"name":"vision","full_name":"simon-p-r/vision","owner":{"login":"simon-p-r","id":4668724,"avatar_url":"https://avatars.githubusercontent.com/u/4668724?v=3","gravatar_id":"","url":"https://api.github.com/users/simon-p-r","html_url":"https://github.com/simon-p-r","followers_url":"https://api.github.com/users/simon-p-r/followers","following_url":"https://api.github.com/users/simon-p-r/following{/other_user}","gists_url":"https://api.github.com/users/simon-p-r/gists{/gist_id}","starred_url":"https://api.github.com/users/simon-p-r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon-p-r/subscriptions","organizations_url":"https://api.github.com/users/simon-p-r/orgs","repos_url":"https://api.github.com/users/simon-p-r/repos","events_url":"https://api.github.com/users/simon-p-r/events{/privacy}","received_events_url":"https://api.github.com/users/simon-p-r/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simon-p-r/vision","description":"Templates rendering support for hapi.js","fork":true,"url":"https://api.github.com/repos/simon-p-r/vision","forks_url":"https://api.github.com/repos/simon-p-r/vision/forks","keys_url":"https://api.github.com/repos/simon-p-r/vision/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simon-p-r/vision/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simon-p-r/vision/teams","hooks_url":"https://api.github.com/repos/simon-p-r/vision/hooks","issue_events_url":"https://api.github.com/repos/simon-p-r/vision/issues/events{/number}","events_url":"https://api.github.com/repos/simon-p-r/vision/events","assignees_url":"https://api.github.com/repos/simon-p-r/vision/assignees{/user}","branches_url":"https://api.github.com/repos/simon-p-r/vision/branches{/branch}","tags_url":"https://api.github.com/repos/simon-p-r/vision/tags","blobs_url":"https://api.github.com/repos/simon-p-r/vision/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simon-p-r/vision/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simon-p-r/vision/git/refs{/sha}","trees_url":"https://api.github.com/repos/simon-p-r/vision/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simon-p-r/vision/statuses/{sha}","languages_url":"https://api.github.com/repos/simon-p-r/vision/languages","stargazers_url":"https://api.github.com/repos/simon-p-r/vision/stargazers","contributors_url":"https://api.github.com/repos/simon-p-r/vision/contributors","subscribers_url":"https://api.github.com/repos/simon-p-r/vision/subscribers","subscription_url":"https://api.github.com/repos/simon-p-r/vision/subscription","commits_url":"https://api.github.com/repos/simon-p-r/vision/commits{/sha}","git_commits_url":"https://api.github.com/repos/simon-p-r/vision/git/commits{/sha}","comments_url":"https://api.github.com/repos/simon-p-r/vision/comments{/number}","issue_comment_url":"https://api.github.com/repos/simon-p-r/vision/issues/comments{/number}","contents_url":"https://api.github.com/repos/simon-p-r/vision/contents/{+path}","compare_url":"https://api.github.com/repos/simon-p-r/vision/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simon-p-r/vision/merges","archive_url":"https://api.github.com/repos/simon-p-r/vision/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simon-p-r/vision/downloads","issues_url":"https://api.github.com/repos/simon-p-r/vision/issues{/number}","pulls_url":"https://api.github.com/repos/simon-p-r/vision/pulls{/number}","milestones_url":"https://api.github.com/repos/simon-p-r/vision/milestones{/number}","notifications_url":"https://api.github.com/repos/simon-p-r/vision/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simon-p-r/vision/labels{/name}","releases_url":"https://api.github.com/repos/simon-p-r/vision/releases{/id}","created_at":"2015-09-09T10:19:10Z","updated_at":"2015-09-09T10:19:11Z","pushed_at":"2015-09-09T12:11:11Z","git_url":"git://github.com/simon-p-r/vision.git","ssh_url":"git@github.com:simon-p-r/vision.git","clone_url":"https://github.com/simon-p-r/vision.git","svn_url":"https://github.com/simon-p-r/vision","homepage":null,"size":207,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hapijs:master","ref":"master","sha":"250c9d627ea6dbd18c671e3f4f671cdd5a3f4cec","user":{"login":"hapijs","id":3774533,"avatar_url":"https://avatars.githubusercontent.com/u/3774533?v=3","gravatar_id":"","url":"https://api.github.com/users/hapijs","html_url":"https://github.com/hapijs","followers_url":"https://api.github.com/users/hapijs/followers","following_url":"https://api.github.com/users/hapijs/following{/other_user}","gists_url":"https://api.github.com/users/hapijs/gists{/gist_id}","starred_url":"https://api.github.com/users/hapijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hapijs/subscriptions","organizations_url":"https://api.github.com/users/hapijs/orgs","repos_url":"https://api.github.com/users/hapijs/repos","events_url":"https://api.github.com/users/hapijs/events{/privacy}","received_events_url":"https://api.github.com/users/hapijs/received_events","type":"Organization","site_admin":false},"repo":{"id":24220172,"name":"vision","full_name":"hapijs/vision","owner":{"login":"hapijs","id":3774533,"avatar_url":"https://avatars.githubusercontent.com/u/3774533?v=3","gravatar_id":"","url":"https://api.github.com/users/hapijs","html_url":"https://github.com/hapijs","followers_url":"https://api.github.com/users/hapijs/followers","following_url":"https://api.github.com/users/hapijs/following{/other_user}","gists_url":"https://api.github.com/users/hapijs/gists{/gist_id}","starred_url":"https://api.github.com/users/hapijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hapijs/subscriptions","organizations_url":"https://api.github.com/users/hapijs/orgs","repos_url":"https://api.github.com/users/hapijs/repos","events_url":"https://api.github.com/users/hapijs/events{/privacy}","received_events_url":"https://api.github.com/users/hapijs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hapijs/vision","description":"Templates rendering support for hapi.js","fork":false,"url":"https://api.github.com/repos/hapijs/vision","forks_url":"https://api.github.com/repos/hapijs/vision/forks","keys_url":"https://api.github.com/repos/hapijs/vision/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hapijs/vision/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hapijs/vision/teams","hooks_url":"https://api.github.com/repos/hapijs/vision/hooks","issue_events_url":"https://api.github.com/repos/hapijs/vision/issues/events{/number}","events_url":"https://api.github.com/repos/hapijs/vision/events","assignees_url":"https://api.github.com/repos/hapijs/vision/assignees{/user}","branches_url":"https://api.github.com/repos/hapijs/vision/branches{/branch}","tags_url":"https://api.github.com/repos/hapijs/vision/tags","blobs_url":"https://api.github.com/repos/hapijs/vision/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hapijs/vision/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hapijs/vision/git/refs{/sha}","trees_url":"https://api.github.com/repos/hapijs/vision/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hapijs/vision/statuses/{sha}","languages_url":"https://api.github.com/repos/hapijs/vision/languages","stargazers_url":"https://api.github.com/repos/hapijs/vision/stargazers","contributors_url":"https://api.github.com/repos/hapijs/vision/contributors","subscribers_url":"https://api.github.com/repos/hapijs/vision/subscribers","subscription_url":"https://api.github.com/repos/hapijs/vision/subscription","commits_url":"https://api.github.com/repos/hapijs/vision/commits{/sha}","git_commits_url":"https://api.github.com/repos/hapijs/vision/git/commits{/sha}","comments_url":"https://api.github.com/repos/hapijs/vision/comments{/number}","issue_comment_url":"https://api.github.com/repos/hapijs/vision/issues/comments{/number}","contents_url":"https://api.github.com/repos/hapijs/vision/contents/{+path}","compare_url":"https://api.github.com/repos/hapijs/vision/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hapijs/vision/merges","archive_url":"https://api.github.com/repos/hapijs/vision/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hapijs/vision/downloads","issues_url":"https://api.github.com/repos/hapijs/vision/issues{/number}","pulls_url":"https://api.github.com/repos/hapijs/vision/pulls{/number}","milestones_url":"https://api.github.com/repos/hapijs/vision/milestones{/number}","notifications_url":"https://api.github.com/repos/hapijs/vision/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hapijs/vision/labels{/name}","releases_url":"https://api.github.com/repos/hapijs/vision/releases{/id}","created_at":"2014-09-19T07:16:10Z","updated_at":"2015-08-29T05:06:47Z","pushed_at":"2015-09-09T12:17:51Z","git_url":"git://github.com/hapijs/vision.git","ssh_url":"git@github.com:hapijs/vision.git","clone_url":"https://github.com/hapijs/vision.git","svn_url":"https://github.com/hapijs/vision","homepage":null,"size":554,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":1,"forks":13,"open_issues":1,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hapijs/vision/pulls/55"},"html":{"href":"https://github.com/hapijs/vision/pull/55"},"issue":{"href":"https://api.github.com/repos/hapijs/vision/issues/55"},"comments":{"href":"https://api.github.com/repos/hapijs/vision/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/hapijs/vision/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/hapijs/vision/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hapijs/vision/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/hapijs/vision/statuses/314a4e26b679020fe1c0879eff20d087e1b1e1c6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":10,"changed_files":1}}