{"action":"created","comment":{"url":"https://api.github.com/repos/ironsmile/nedomi/pulls/comments/38845351","id":38845351,"diff_hunk":"@@ -0,0 +1,84 @@\n+package buffers\n+\n+import (\n+\t\"bytes\"\n+\t\"fmt\"\n+\n+\t\"github.com/ironsmile/nedomi/config\"\n+)\n+\n+// New returns a new Buffers logger.\n+func New(cfg *config.LoggerSection) (*Buffers, error) {\n+\tb := &Buffers{\n+\t\tbuffer: new(bytes.Buffer),\n+\t}\n+\treturn b, nil\n+}\n+\n+// Buffers writes all the logs to\n+// bytes.Buffer for later examination\n+type Buffers struct {\n+\tbuffer *bytes.Buffer","path":"logger/buffers/impl.go","position":21,"original_position":21,"commit_id":"46ea854481d1b8f399838ce1bb963522e916d0bb","original_commit_id":"46ea854481d1b8f399838ce1bb963522e916d0bb","user":{"login":"na--","id":3336773,"avatar_url":"https://avatars.githubusercontent.com/u/3336773?v=3","gravatar_id":"","url":"https://api.github.com/users/na--","html_url":"https://github.com/na--","followers_url":"https://api.github.com/users/na--/followers","following_url":"https://api.github.com/users/na--/following{/other_user}","gists_url":"https://api.github.com/users/na--/gists{/gist_id}","starred_url":"https://api.github.com/users/na--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/na--/subscriptions","organizations_url":"https://api.github.com/users/na--/orgs","repos_url":"https://api.github.com/users/na--/repos","events_url":"https://api.github.com/users/na--/events{/privacy}","received_events_url":"https://api.github.com/users/na--/received_events","type":"User","site_admin":false},"body":"For this logger to be useful as a mock logger, we need some way to get the logged messages externally. Either this has to be exported or we need a getter method. Also, why use a buffer? Why not just a slice of strings that we append to?","created_at":"2015-09-07T09:08:32Z","updated_at":"2015-09-07T09:08:32Z","html_url":"https://github.com/ironsmile/nedomi/pull/60#discussion_r38845351","pull_request_url":"https://api.github.com/repos/ironsmile/nedomi/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/ironsmile/nedomi/pulls/comments/38845351"},"html":{"href":"https://github.com/ironsmile/nedomi/pull/60#discussion_r38845351"},"pull_request":{"href":"https://api.github.com/repos/ironsmile/nedomi/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/ironsmile/nedomi/pulls/60","id":44333339,"html_url":"https://github.com/ironsmile/nedomi/pull/60","diff_url":"https://github.com/ironsmile/nedomi/pull/60.diff","patch_url":"https://github.com/ironsmile/nedomi/pull/60.patch","issue_url":"https://api.github.com/repos/ironsmile/nedomi/issues/60","number":60,"state":"open","locked":false,"title":"Loggers linting","user":{"login":"MStoykov","id":312246,"avatar_url":"https://avatars.githubusercontent.com/u/312246?v=3","gravatar_id":"","url":"https://api.github.com/users/MStoykov","html_url":"https://github.com/MStoykov","followers_url":"https://api.github.com/users/MStoykov/followers","following_url":"https://api.github.com/users/MStoykov/following{/other_user}","gists_url":"https://api.github.com/users/MStoykov/gists{/gist_id}","starred_url":"https://api.github.com/users/MStoykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MStoykov/subscriptions","organizations_url":"https://api.github.com/users/MStoykov/orgs","repos_url":"https://api.github.com/users/MStoykov/repos","events_url":"https://api.github.com/users/MStoykov/events{/privacy}","received_events_url":"https://api.github.com/users/MStoykov/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-07T08:57:02Z","updated_at":"2015-09-07T09:08:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78281fbad73c53d9c8113e913915716606eb30d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ironsmile/nedomi/pulls/60/commits","review_comments_url":"https://api.github.com/repos/ironsmile/nedomi/pulls/60/comments","review_comment_url":"https://api.github.com/repos/ironsmile/nedomi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ironsmile/nedomi/issues/60/comments","statuses_url":"https://api.github.com/repos/ironsmile/nedomi/statuses/46ea854481d1b8f399838ce1bb963522e916d0bb","head":{"label":"ironsmile:loggers_linting","ref":"loggers_linting","sha":"46ea854481d1b8f399838ce1bb963522e916d0bb","user":{"login":"ironsmile","id":50431,"avatar_url":"https://avatars.githubusercontent.com/u/50431?v=3","gravatar_id":"","url":"https://api.github.com/users/ironsmile","html_url":"https://github.com/ironsmile","followers_url":"https://api.github.com/users/ironsmile/followers","following_url":"https://api.github.com/users/ironsmile/following{/other_user}","gists_url":"https://api.github.com/users/ironsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/ironsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironsmile/subscriptions","organizations_url":"https://api.github.com/users/ironsmile/orgs","repos_url":"https://api.github.com/users/ironsmile/repos","events_url":"https://api.github.com/users/ironsmile/events{/privacy}","received_events_url":"https://api.github.com/users/ironsmile/received_events","type":"User","site_admin":false},"repo":{"id":29851193,"name":"nedomi","full_name":"ironsmile/nedomi","owner":{"login":"ironsmile","id":50431,"avatar_url":"https://avatars.githubusercontent.com/u/50431?v=3","gravatar_id":"","url":"https://api.github.com/users/ironsmile","html_url":"https://github.com/ironsmile","followers_url":"https://api.github.com/users/ironsmile/followers","following_url":"https://api.github.com/users/ironsmile/following{/other_user}","gists_url":"https://api.github.com/users/ironsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/ironsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironsmile/subscriptions","organizations_url":"https://api.github.com/users/ironsmile/orgs","repos_url":"https://api.github.com/users/ironsmile/repos","events_url":"https://api.github.com/users/ironsmile/events{/privacy}","received_events_url":"https://api.github.com/users/ironsmile/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ironsmile/nedomi","description":"HTTP media cache server","fork":false,"url":"https://api.github.com/repos/ironsmile/nedomi","forks_url":"https://api.github.com/repos/ironsmile/nedomi/forks","keys_url":"https://api.github.com/repos/ironsmile/nedomi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ironsmile/nedomi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ironsmile/nedomi/teams","hooks_url":"https://api.github.com/repos/ironsmile/nedomi/hooks","issue_events_url":"https://api.github.com/repos/ironsmile/nedomi/issues/events{/number}","events_url":"https://api.github.com/repos/ironsmile/nedomi/events","assignees_url":"https://api.github.com/repos/ironsmile/nedomi/assignees{/user}","branches_url":"https://api.github.com/repos/ironsmile/nedomi/branches{/branch}","tags_url":"https://api.github.com/repos/ironsmile/nedomi/tags","blobs_url":"https://api.github.com/repos/ironsmile/nedomi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ironsmile/nedomi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ironsmile/nedomi/git/refs{/sha}","trees_url":"https://api.github.com/repos/ironsmile/nedomi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ironsmile/nedomi/statuses/{sha}","languages_url":"https://api.github.com/repos/ironsmile/nedomi/languages","stargazers_url":"https://api.github.com/repos/ironsmile/nedomi/stargazers","contributors_url":"https://api.github.com/repos/ironsmile/nedomi/contributors","subscribers_url":"https://api.github.com/repos/ironsmile/nedomi/subscribers","subscription_url":"https://api.github.com/repos/ironsmile/nedomi/subscription","commits_url":"https://api.github.com/repos/ironsmile/nedomi/commits{/sha}","git_commits_url":"https://api.github.com/repos/ironsmile/nedomi/git/commits{/sha}","comments_url":"https://api.github.com/repos/ironsmile/nedomi/comments{/number}","issue_comment_url":"https://api.github.com/repos/ironsmile/nedomi/issues/comments{/number}","contents_url":"https://api.github.com/repos/ironsmile/nedomi/contents/{+path}","compare_url":"https://api.github.com/repos/ironsmile/nedomi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ironsmile/nedomi/merges","archive_url":"https://api.github.com/repos/ironsmile/nedomi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ironsmile/nedomi/downloads","issues_url":"https://api.github.com/repos/ironsmile/nedomi/issues{/number}","pulls_url":"https://api.github.com/repos/ironsmile/nedomi/pulls{/number}","milestones_url":"https://api.github.com/repos/ironsmile/nedomi/milestones{/number}","notifications_url":"https://api.github.com/repos/ironsmile/nedomi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ironsmile/nedomi/labels{/name}","releases_url":"https://api.github.com/repos/ironsmile/nedomi/releases{/id}","created_at":"2015-01-26T08:06:40Z","updated_at":"2015-08-04T14:30:57Z","pushed_at":"2015-09-07T08:57:02Z","git_url":"git://github.com/ironsmile/nedomi.git","ssh_url":"git@github.com:ironsmile/nedomi.git","clone_url":"https://github.com/ironsmile/nedomi.git","svn_url":"https://github.com/ironsmile/nedomi","homepage":"","size":1159,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":20,"forks":3,"open_issues":20,"watchers":4,"default_branch":"master"}},"base":{"label":"ironsmile:master","ref":"master","sha":"aa818f0c67a354b62c811d684a73822cedd86483","user":{"login":"ironsmile","id":50431,"avatar_url":"https://avatars.githubusercontent.com/u/50431?v=3","gravatar_id":"","url":"https://api.github.com/users/ironsmile","html_url":"https://github.com/ironsmile","followers_url":"https://api.github.com/users/ironsmile/followers","following_url":"https://api.github.com/users/ironsmile/following{/other_user}","gists_url":"https://api.github.com/users/ironsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/ironsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironsmile/subscriptions","organizations_url":"https://api.github.com/users/ironsmile/orgs","repos_url":"https://api.github.com/users/ironsmile/repos","events_url":"https://api.github.com/users/ironsmile/events{/privacy}","received_events_url":"https://api.github.com/users/ironsmile/received_events","type":"User","site_admin":false},"repo":{"id":29851193,"name":"nedomi","full_name":"ironsmile/nedomi","owner":{"login":"ironsmile","id":50431,"avatar_url":"https://avatars.githubusercontent.com/u/50431?v=3","gravatar_id":"","url":"https://api.github.com/users/ironsmile","html_url":"https://github.com/ironsmile","followers_url":"https://api.github.com/users/ironsmile/followers","following_url":"https://api.github.com/users/ironsmile/following{/other_user}","gists_url":"https://api.github.com/users/ironsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/ironsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironsmile/subscriptions","organizations_url":"https://api.github.com/users/ironsmile/orgs","repos_url":"https://api.github.com/users/ironsmile/repos","events_url":"https://api.github.com/users/ironsmile/events{/privacy}","received_events_url":"https://api.github.com/users/ironsmile/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ironsmile/nedomi","description":"HTTP media cache server","fork":false,"url":"https://api.github.com/repos/ironsmile/nedomi","forks_url":"https://api.github.com/repos/ironsmile/nedomi/forks","keys_url":"https://api.github.com/repos/ironsmile/nedomi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ironsmile/nedomi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ironsmile/nedomi/teams","hooks_url":"https://api.github.com/repos/ironsmile/nedomi/hooks","issue_events_url":"https://api.github.com/repos/ironsmile/nedomi/issues/events{/number}","events_url":"https://api.github.com/repos/ironsmile/nedomi/events","assignees_url":"https://api.github.com/repos/ironsmile/nedomi/assignees{/user}","branches_url":"https://api.github.com/repos/ironsmile/nedomi/branches{/branch}","tags_url":"https://api.github.com/repos/ironsmile/nedomi/tags","blobs_url":"https://api.github.com/repos/ironsmile/nedomi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ironsmile/nedomi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ironsmile/nedomi/git/refs{/sha}","trees_url":"https://api.github.com/repos/ironsmile/nedomi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ironsmile/nedomi/statuses/{sha}","languages_url":"https://api.github.com/repos/ironsmile/nedomi/languages","stargazers_url":"https://api.github.com/repos/ironsmile/nedomi/stargazers","contributors_url":"https://api.github.com/repos/ironsmile/nedomi/contributors","subscribers_url":"https://api.github.com/repos/ironsmile/nedomi/subscribers","subscription_url":"https://api.github.com/repos/ironsmile/nedomi/subscription","commits_url":"https://api.github.com/repos/ironsmile/nedomi/commits{/sha}","git_commits_url":"https://api.github.com/repos/ironsmile/nedomi/git/commits{/sha}","comments_url":"https://api.github.com/repos/ironsmile/nedomi/comments{/number}","issue_comment_url":"https://api.github.com/repos/ironsmile/nedomi/issues/comments{/number}","contents_url":"https://api.github.com/repos/ironsmile/nedomi/contents/{+path}","compare_url":"https://api.github.com/repos/ironsmile/nedomi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ironsmile/nedomi/merges","archive_url":"https://api.github.com/repos/ironsmile/nedomi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ironsmile/nedomi/downloads","issues_url":"https://api.github.com/repos/ironsmile/nedomi/issues{/number}","pulls_url":"https://api.github.com/repos/ironsmile/nedomi/pulls{/number}","milestones_url":"https://api.github.com/repos/ironsmile/nedomi/milestones{/number}","notifications_url":"https://api.github.com/repos/ironsmile/nedomi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ironsmile/nedomi/labels{/name}","releases_url":"https://api.github.com/repos/ironsmile/nedomi/releases{/id}","created_at":"2015-01-26T08:06:40Z","updated_at":"2015-08-04T14:30:57Z","pushed_at":"2015-09-07T08:57:02Z","git_url":"git://github.com/ironsmile/nedomi.git","ssh_url":"git@github.com:ironsmile/nedomi.git","clone_url":"https://github.com/ironsmile/nedomi.git","svn_url":"https://github.com/ironsmile/nedomi","homepage":"","size":1159,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":20,"forks":3,"open_issues":20,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ironsmile/nedomi/pulls/60"},"html":{"href":"https://github.com/ironsmile/nedomi/pull/60"},"issue":{"href":"https://api.github.com/repos/ironsmile/nedomi/issues/60"},"comments":{"href":"https://api.github.com/repos/ironsmile/nedomi/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/ironsmile/nedomi/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/ironsmile/nedomi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ironsmile/nedomi/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/ironsmile/nedomi/statuses/46ea854481d1b8f399838ce1bb963522e916d0bb"}}}}