{"action":"created","issue":{"url":"https://api.github.com/repos/angular/material/issues/4363","labels_url":"https://api.github.com/repos/angular/material/issues/4363/labels{/name}","comments_url":"https://api.github.com/repos/angular/material/issues/4363/comments","events_url":"https://api.github.com/repos/angular/material/issues/4363/events","html_url":"https://github.com/angular/material/issues/4363","id":103712961,"number":4363,"title":"md-scroll-shrink only checks for attribute not value ","user":{"login":"langan","id":1628351,"avatar_url":"https://avatars.githubusercontent.com/u/1628351?v=3","gravatar_id":"","url":"https://api.github.com/users/langan","html_url":"https://github.com/langan","followers_url":"https://api.github.com/users/langan/followers","following_url":"https://api.github.com/users/langan/following{/other_user}","gists_url":"https://api.github.com/users/langan/gists{/gist_id}","starred_url":"https://api.github.com/users/langan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/langan/subscriptions","organizations_url":"https://api.github.com/users/langan/orgs","repos_url":"https://api.github.com/users/langan/repos","events_url":"https://api.github.com/users/langan/events{/privacy}","received_events_url":"https://api.github.com/users/langan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/material/labels/for:%20external%20contributor","name":"for: external contributor","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-28T12:44:43Z","updated_at":"2015-08-28T15:20:04Z","closed_at":null,"body":"Trying to turn on and off scroll shrink using a variable.\r\n\r\nLike this\r\n\r\n```HTML\r\n<md-toolbar md-scroll-shrink=\"scrollShrinkOn\">\r\n```\r\n\r\nBut the attribute doesn't look like it's being watched.\r\n\r\nEven\r\n\r\n```HTML\r\n<md-toolbar md-scroll-shrink=\"false\">\r\n```\r\n\r\nDoesn't work [the docs](https://material.angularjs.org/latest/#/api/material.components.toolbar/directive/mdToolbar) say it should be boolean.\r\n\r\nBut looking at the code it just checks if the attribute is defined?\r\n\r\n```JS\r\n      if (angular.isDefined(attr.mdScrollShrink)) {\r\n        setupScrollShrink();\r\n      }\r\n```\r\n\r\nWould be happy to look into a fix if needed"},"comment":{"url":"https://api.github.com/repos/angular/material/issues/comments/135803685","html_url":"https://github.com/angular/material/issues/4363#issuecomment-135803685","issue_url":"https://api.github.com/repos/angular/material/issues/4363","id":135803685,"user":{"login":"topherfangio","id":54370,"avatar_url":"https://avatars.githubusercontent.com/u/54370?v=3","gravatar_id":"","url":"https://api.github.com/users/topherfangio","html_url":"https://github.com/topherfangio","followers_url":"https://api.github.com/users/topherfangio/followers","following_url":"https://api.github.com/users/topherfangio/following{/other_user}","gists_url":"https://api.github.com/users/topherfangio/gists{/gist_id}","starred_url":"https://api.github.com/users/topherfangio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topherfangio/subscriptions","organizations_url":"https://api.github.com/users/topherfangio/orgs","repos_url":"https://api.github.com/users/topherfangio/repos","events_url":"https://api.github.com/users/topherfangio/events{/privacy}","received_events_url":"https://api.github.com/users/topherfangio/received_events","type":"User","site_admin":false},"created_at":"2015-08-28T15:20:04Z","updated_at":"2015-08-28T15:20:04Z","body":"This sounds like a fantastic community contribution if you're willing to put together a PR!\r\n\r\nGeneral principle is:\r\n\r\n1. Create a test that shows the feature you are implementing (it should look something like [this](https://github.com/angular/material/blob/master/src/components/fabSpeedDial/fabSpeedDial.spec.js#L31]))\r\n1. Change the code to make the test pass\r\n1. Add the proper docs to `toolbar.js`\r\n1. Run all tests and make sure they pass\r\n1. Submit the PR :-)\r\n\r\nPlease let us know if you have any questions along the way!"}}