{"action":"created","comment":{"url":"https://api.github.com/repos/wpengine/hgv/pulls/comments/30231129","id":30231129,"diff_hunk":"@@ -8,6 +8,17 @@ dir = Dir.pwd\n vagrant_dir = File.expand_path(File.dirname(__FILE__))\n vagrant_name = File.basename(dir)\n \n+require 'yaml'\n+\n+domains_array = ['admin.hgv.dev', 'xhprof.hgv.dev', 'mail.hgv.dev']\n+\n+# Load default domains \n+domains = YAML.load_file('./provisioning/default-sites.yml')\n+domains['default_wp']['hhvm_domains'].each do |domain|\n+    domains_array.push(domain)\n+    domains_array.push('cache.' << domain)\n+end","path":"Vagrantfile","position":13,"original_position":13,"commit_id":"a9ca515aa75876d4a7a5b29505d4fbbe851049f7","original_commit_id":"a9ca515aa75876d4a7a5b29505d4fbbe851049f7","user":{"login":"markkelnar","id":749603,"avatar_url":"https://avatars.githubusercontent.com/u/749603?v=3","gravatar_id":"","url":"https://api.github.com/users/markkelnar","html_url":"https://github.com/markkelnar","followers_url":"https://api.github.com/users/markkelnar/followers","following_url":"https://api.github.com/users/markkelnar/following{/other_user}","gists_url":"https://api.github.com/users/markkelnar/gists{/gist_id}","starred_url":"https://api.github.com/users/markkelnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markkelnar/subscriptions","organizations_url":"https://api.github.com/users/markkelnar/orgs","repos_url":"https://api.github.com/users/markkelnar/repos","events_url":"https://api.github.com/users/markkelnar/events{/privacy}","received_events_url":"https://api.github.com/users/markkelnar/received_events","type":"User","site_admin":false},"body":"Need something similar in here for the default_wp.php_domains list if it exists in the yml file.  Cause, that could be optional.?","created_at":"2015-05-13T13:43:40Z","updated_at":"2015-05-13T13:43:40Z","html_url":"https://github.com/wpengine/hgv/pull/153#discussion_r30231129","pull_request_url":"https://api.github.com/repos/wpengine/hgv/pulls/153","_links":{"self":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/comments/30231129"},"html":{"href":"https://github.com/wpengine/hgv/pull/153#discussion_r30231129"},"pull_request":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/153"}}},"pull_request":{"url":"https://api.github.com/repos/wpengine/hgv/pulls/153","id":35270432,"html_url":"https://github.com/wpengine/hgv/pull/153","diff_url":"https://github.com/wpengine/hgv/pull/153.diff","patch_url":"https://github.com/wpengine/hgv/pull/153.patch","issue_url":"https://api.github.com/repos/wpengine/hgv/issues/153","number":153,"state":"open","locked":false,"title":"Domains by variables","user":{"login":"markkelnar","id":749603,"avatar_url":"https://avatars.githubusercontent.com/u/749603?v=3","gravatar_id":"","url":"https://api.github.com/users/markkelnar","html_url":"https://github.com/markkelnar","followers_url":"https://api.github.com/users/markkelnar/followers","following_url":"https://api.github.com/users/markkelnar/following{/other_user}","gists_url":"https://api.github.com/users/markkelnar/gists{/gist_id}","starred_url":"https://api.github.com/users/markkelnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markkelnar/subscriptions","organizations_url":"https://api.github.com/users/markkelnar/orgs","repos_url":"https://api.github.com/users/markkelnar/repos","events_url":"https://api.github.com/users/markkelnar/events{/privacy}","received_events_url":"https://api.github.com/users/markkelnar/received_events","type":"User","site_admin":false},"body":"Here's my take of some things, and my own stab at custom domains.  \r\n\r\nI stole/used some of code from @zamoose's the Vagrantfile Ruby stuff.  Tried to work in the direction of not building the dependency of file names and variable names further down into the ansible roles.\r\n\r\nThis supports existing default domains (hhvm.hgv.dev, fpm.hgv.dev, php.hgv.dev) that get created and doesn't change any behavior.\r\n\r\nIn a different PR/branch I have code to work on custom YML files directory and format and triggered by the bash init script.  \r\n\r\nAgain, explored some ideas to see what it would look like and even possible with variables and yml files in a conf.d/.  One change I did make here was the move of php.hgv.dev to point to the 'hhvm' WP install on disk.  That change doesn't have to happen with all these other changes, that's fairly easy to support.\r\n\r\nThis will make it easy to add or change to the .local TLD for these installs.\r\n","created_at":"2015-05-12T21:04:44Z","updated_at":"2015-05-13T13:43:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92c32664a7d3d99d94bd46d396c7785d022cbc02","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wpengine/hgv/pulls/153/commits","review_comments_url":"https://api.github.com/repos/wpengine/hgv/pulls/153/comments","review_comment_url":"https://api.github.com/repos/wpengine/hgv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wpengine/hgv/issues/153/comments","statuses_url":"https://api.github.com/repos/wpengine/hgv/statuses/a9ca515aa75876d4a7a5b29505d4fbbe851049f7","head":{"label":"markkelnar:domains-by-variables","ref":"domains-by-variables","sha":"a9ca515aa75876d4a7a5b29505d4fbbe851049f7","user":{"login":"markkelnar","id":749603,"avatar_url":"https://avatars.githubusercontent.com/u/749603?v=3","gravatar_id":"","url":"https://api.github.com/users/markkelnar","html_url":"https://github.com/markkelnar","followers_url":"https://api.github.com/users/markkelnar/followers","following_url":"https://api.github.com/users/markkelnar/following{/other_user}","gists_url":"https://api.github.com/users/markkelnar/gists{/gist_id}","starred_url":"https://api.github.com/users/markkelnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markkelnar/subscriptions","organizations_url":"https://api.github.com/users/markkelnar/orgs","repos_url":"https://api.github.com/users/markkelnar/repos","events_url":"https://api.github.com/users/markkelnar/events{/privacy}","received_events_url":"https://api.github.com/users/markkelnar/received_events","type":"User","site_admin":false},"repo":{"id":29260509,"name":"hgv","full_name":"markkelnar/hgv","owner":{"login":"markkelnar","id":749603,"avatar_url":"https://avatars.githubusercontent.com/u/749603?v=3","gravatar_id":"","url":"https://api.github.com/users/markkelnar","html_url":"https://github.com/markkelnar","followers_url":"https://api.github.com/users/markkelnar/followers","following_url":"https://api.github.com/users/markkelnar/following{/other_user}","gists_url":"https://api.github.com/users/markkelnar/gists{/gist_id}","starred_url":"https://api.github.com/users/markkelnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markkelnar/subscriptions","organizations_url":"https://api.github.com/users/markkelnar/orgs","repos_url":"https://api.github.com/users/markkelnar/repos","events_url":"https://api.github.com/users/markkelnar/events{/privacy}","received_events_url":"https://api.github.com/users/markkelnar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markkelnar/hgv","description":"WP Engine's Mercury vagrant environment","fork":true,"url":"https://api.github.com/repos/markkelnar/hgv","forks_url":"https://api.github.com/repos/markkelnar/hgv/forks","keys_url":"https://api.github.com/repos/markkelnar/hgv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markkelnar/hgv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markkelnar/hgv/teams","hooks_url":"https://api.github.com/repos/markkelnar/hgv/hooks","issue_events_url":"https://api.github.com/repos/markkelnar/hgv/issues/events{/number}","events_url":"https://api.github.com/repos/markkelnar/hgv/events","assignees_url":"https://api.github.com/repos/markkelnar/hgv/assignees{/user}","branches_url":"https://api.github.com/repos/markkelnar/hgv/branches{/branch}","tags_url":"https://api.github.com/repos/markkelnar/hgv/tags","blobs_url":"https://api.github.com/repos/markkelnar/hgv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markkelnar/hgv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markkelnar/hgv/git/refs{/sha}","trees_url":"https://api.github.com/repos/markkelnar/hgv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markkelnar/hgv/statuses/{sha}","languages_url":"https://api.github.com/repos/markkelnar/hgv/languages","stargazers_url":"https://api.github.com/repos/markkelnar/hgv/stargazers","contributors_url":"https://api.github.com/repos/markkelnar/hgv/contributors","subscribers_url":"https://api.github.com/repos/markkelnar/hgv/subscribers","subscription_url":"https://api.github.com/repos/markkelnar/hgv/subscription","commits_url":"https://api.github.com/repos/markkelnar/hgv/commits{/sha}","git_commits_url":"https://api.github.com/repos/markkelnar/hgv/git/commits{/sha}","comments_url":"https://api.github.com/repos/markkelnar/hgv/comments{/number}","issue_comment_url":"https://api.github.com/repos/markkelnar/hgv/issues/comments{/number}","contents_url":"https://api.github.com/repos/markkelnar/hgv/contents/{+path}","compare_url":"https://api.github.com/repos/markkelnar/hgv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markkelnar/hgv/merges","archive_url":"https://api.github.com/repos/markkelnar/hgv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markkelnar/hgv/downloads","issues_url":"https://api.github.com/repos/markkelnar/hgv/issues{/number}","pulls_url":"https://api.github.com/repos/markkelnar/hgv/pulls{/number}","milestones_url":"https://api.github.com/repos/markkelnar/hgv/milestones{/number}","notifications_url":"https://api.github.com/repos/markkelnar/hgv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markkelnar/hgv/labels{/name}","releases_url":"https://api.github.com/repos/markkelnar/hgv/releases{/id}","created_at":"2015-01-14T19:02:59Z","updated_at":"2015-01-15T02:31:08Z","pushed_at":"2015-04-30T18:46:23Z","git_url":"git://github.com/markkelnar/hgv.git","ssh_url":"git@github.com:markkelnar/hgv.git","clone_url":"https://github.com/markkelnar/hgv.git","svn_url":"https://github.com/markkelnar/hgv","homepage":"http://merc.wpengine.com","size":790,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wpengine:master","ref":"master","sha":"23c32673aa74fc86c96fe8a5db1cb5c44c057142","user":{"login":"wpengine","id":749191,"avatar_url":"https://avatars.githubusercontent.com/u/749191?v=3","gravatar_id":"","url":"https://api.github.com/users/wpengine","html_url":"https://github.com/wpengine","followers_url":"https://api.github.com/users/wpengine/followers","following_url":"https://api.github.com/users/wpengine/following{/other_user}","gists_url":"https://api.github.com/users/wpengine/gists{/gist_id}","starred_url":"https://api.github.com/users/wpengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpengine/subscriptions","organizations_url":"https://api.github.com/users/wpengine/orgs","repos_url":"https://api.github.com/users/wpengine/repos","events_url":"https://api.github.com/users/wpengine/events{/privacy}","received_events_url":"https://api.github.com/users/wpengine/received_events","type":"Organization","site_admin":false},"repo":{"id":28054492,"name":"hgv","full_name":"wpengine/hgv","owner":{"login":"wpengine","id":749191,"avatar_url":"https://avatars.githubusercontent.com/u/749191?v=3","gravatar_id":"","url":"https://api.github.com/users/wpengine","html_url":"https://github.com/wpengine","followers_url":"https://api.github.com/users/wpengine/followers","following_url":"https://api.github.com/users/wpengine/following{/other_user}","gists_url":"https://api.github.com/users/wpengine/gists{/gist_id}","starred_url":"https://api.github.com/users/wpengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpengine/subscriptions","organizations_url":"https://api.github.com/users/wpengine/orgs","repos_url":"https://api.github.com/users/wpengine/repos","events_url":"https://api.github.com/users/wpengine/events{/privacy}","received_events_url":"https://api.github.com/users/wpengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wpengine/hgv","description":"WP Engine's Mercury vagrant environment","fork":false,"url":"https://api.github.com/repos/wpengine/hgv","forks_url":"https://api.github.com/repos/wpengine/hgv/forks","keys_url":"https://api.github.com/repos/wpengine/hgv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wpengine/hgv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wpengine/hgv/teams","hooks_url":"https://api.github.com/repos/wpengine/hgv/hooks","issue_events_url":"https://api.github.com/repos/wpengine/hgv/issues/events{/number}","events_url":"https://api.github.com/repos/wpengine/hgv/events","assignees_url":"https://api.github.com/repos/wpengine/hgv/assignees{/user}","branches_url":"https://api.github.com/repos/wpengine/hgv/branches{/branch}","tags_url":"https://api.github.com/repos/wpengine/hgv/tags","blobs_url":"https://api.github.com/repos/wpengine/hgv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wpengine/hgv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wpengine/hgv/git/refs{/sha}","trees_url":"https://api.github.com/repos/wpengine/hgv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wpengine/hgv/statuses/{sha}","languages_url":"https://api.github.com/repos/wpengine/hgv/languages","stargazers_url":"https://api.github.com/repos/wpengine/hgv/stargazers","contributors_url":"https://api.github.com/repos/wpengine/hgv/contributors","subscribers_url":"https://api.github.com/repos/wpengine/hgv/subscribers","subscription_url":"https://api.github.com/repos/wpengine/hgv/subscription","commits_url":"https://api.github.com/repos/wpengine/hgv/commits{/sha}","git_commits_url":"https://api.github.com/repos/wpengine/hgv/git/commits{/sha}","comments_url":"https://api.github.com/repos/wpengine/hgv/comments{/number}","issue_comment_url":"https://api.github.com/repos/wpengine/hgv/issues/comments{/number}","contents_url":"https://api.github.com/repos/wpengine/hgv/contents/{+path}","compare_url":"https://api.github.com/repos/wpengine/hgv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wpengine/hgv/merges","archive_url":"https://api.github.com/repos/wpengine/hgv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wpengine/hgv/downloads","issues_url":"https://api.github.com/repos/wpengine/hgv/issues{/number}","pulls_url":"https://api.github.com/repos/wpengine/hgv/pulls{/number}","milestones_url":"https://api.github.com/repos/wpengine/hgv/milestones{/number}","notifications_url":"https://api.github.com/repos/wpengine/hgv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wpengine/hgv/labels{/name}","releases_url":"https://api.github.com/repos/wpengine/hgv/releases{/id}","created_at":"2014-12-15T20:22:40Z","updated_at":"2015-05-13T09:33:55Z","pushed_at":"2015-05-12T21:30:52Z","git_url":"git://github.com/wpengine/hgv.git","ssh_url":"git@github.com:wpengine/hgv.git","clone_url":"https://github.com/wpengine/hgv.git","svn_url":"https://github.com/wpengine/hgv","homepage":"http://wpengine.com/mercury","size":1876,"stargazers_count":169,"watchers_count":169,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":43,"forks":23,"open_issues":43,"watchers":169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/153"},"html":{"href":"https://github.com/wpengine/hgv/pull/153"},"issue":{"href":"https://api.github.com/repos/wpengine/hgv/issues/153"},"comments":{"href":"https://api.github.com/repos/wpengine/hgv/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wpengine/hgv/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/wpengine/hgv/statuses/a9ca515aa75876d4a7a5b29505d4fbbe851049f7"}}}}