{"action":"created","issue":{"url":"https://api.github.com/repos/angular-translate/angular-translate/issues/772","labels_url":"https://api.github.com/repos/angular-translate/angular-translate/issues/772/labels{/name}","comments_url":"https://api.github.com/repos/angular-translate/angular-translate/issues/772/comments","events_url":"https://api.github.com/repos/angular-translate/angular-translate/issues/772/events","html_url":"https://github.com/angular-translate/angular-translate/issues/772","id":45091197,"number":772,"title":"recommend use angular $cacheFactory notation for useStorage method","user":{"login":"Delagen","id":783335,"avatar_url":"https://avatars.githubusercontent.com/u/783335?v=3","gravatar_id":"","url":"https://api.github.com/users/Delagen","html_url":"https://github.com/Delagen","followers_url":"https://api.github.com/users/Delagen/followers","following_url":"https://api.github.com/users/Delagen/following{/other_user}","gists_url":"https://api.github.com/users/Delagen/gists{/gist_id}","starred_url":"https://api.github.com/users/Delagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Delagen/subscriptions","organizations_url":"https://api.github.com/users/Delagen/orgs","repos_url":"https://api.github.com/users/Delagen/repos","events_url":"https://api.github.com/users/Delagen/events{/privacy}","received_events_url":"https://api.github.com/users/Delagen/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular-translate/angular-translate/labels/enhancement","name":"enhancement","color":"009800"},{"url":"https://api.github.com/repos/angular-translate/angular-translate/labels/proposal","name":"proposal","color":"5319e7"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/angular-translate/angular-translate/milestones/12","labels_url":"https://api.github.com/repos/angular-translate/angular-translate/milestones/12/labels","id":781222,"number":12,"title":"2.5.0","description":"","creator":{"login":"knalli","id":65389,"avatar_url":"https://avatars.githubusercontent.com/u/65389?v=3","gravatar_id":"","url":"https://api.github.com/users/knalli","html_url":"https://github.com/knalli","followers_url":"https://api.github.com/users/knalli/followers","following_url":"https://api.github.com/users/knalli/following{/other_user}","gists_url":"https://api.github.com/users/knalli/gists{/gist_id}","starred_url":"https://api.github.com/users/knalli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knalli/subscriptions","organizations_url":"https://api.github.com/users/knalli/orgs","repos_url":"https://api.github.com/users/knalli/repos","events_url":"https://api.github.com/users/knalli/events{/privacy}","received_events_url":"https://api.github.com/users/knalli/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":15,"state":"open","created_at":"2014-09-07T15:46:02Z","updated_at":"2014-12-09T08:02:08Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2014-10-07T10:22:52Z","updated_at":"2015-01-12T04:16:48Z","closed_at":"2014-10-21T21:23:53Z","body":"Currently\r\n```\r\n$translateProvider.useStorage(\"translateStorage\");\r\n```\r\nuse notation of \r\n```\r\n{\r\n        set: function (name, value) {\r\n        },\r\n        get: function (name) {\r\n        }\r\n}\r\n```\r\nbut common $cacheFactory use\r\n```\r\n{\r\n        put: function (name, value) {\r\n        },\r\n        get: function (name) {\r\n        }\r\n}\r\n```\r\nso need to change `set` to `put` method to simplify use of other storage engines without wrappers."},"comment":{"url":"https://api.github.com/repos/angular-translate/angular-translate/issues/comments/69528680","html_url":"https://github.com/angular-translate/angular-translate/issues/772#issuecomment-69528680","issue_url":"https://api.github.com/repos/angular-translate/angular-translate/issues/772","id":69528680,"user":{"login":"tclift","id":98344,"avatar_url":"https://avatars.githubusercontent.com/u/98344?v=3","gravatar_id":"","url":"https://api.github.com/users/tclift","html_url":"https://github.com/tclift","followers_url":"https://api.github.com/users/tclift/followers","following_url":"https://api.github.com/users/tclift/following{/other_user}","gists_url":"https://api.github.com/users/tclift/gists{/gist_id}","starred_url":"https://api.github.com/users/tclift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tclift/subscriptions","organizations_url":"https://api.github.com/users/tclift/orgs","repos_url":"https://api.github.com/users/tclift/repos","events_url":"https://api.github.com/users/tclift/events{/privacy}","received_events_url":"https://api.github.com/users/tclift/received_events","type":"User","site_admin":false},"created_at":"2015-01-12T04:16:48Z","updated_at":"2015-01-12T04:16:48Z","body":"FYI this is a breaking change for anyone implementing a custom storage provider. Due to [this guard](https://github.com/angular-translate/angular-translate/commit/ef6a613e70c0e2fcf2c32fe4b0ad1ffa51be4f0c#diff-255d6d49cbc024fa0d5bc97fdd721bf4R980) the custom storage service must implement `put`.\r\n\r\nThe commit comments suggest that this wouldn't be the case until 3.0, and the docs still refer to `set` only.\r\n\r\nPerhaps the guard should be for `get && (put || set)`?"}}