{"action":"created","comment":{"url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/pulls/comments/47036796","id":47036796,"diff_hunk":"@@ -0,0 +1,55 @@\n+'use strict';\n+\n+var AbstractTransport = require('./abstract-transport.js');\n+var net = require('net');\n+var debug = require('debug')('amqp10:connection:nettransport');\n+\n+var NetTransport = function () {\n+\tAbstractTransport.call(this);\n+\tthis._transport = null;\n+};\n+\n+NetTransport.prototype = Object.create(AbstractTransport.prototype);\n+NetTransport.prototype.constructor = NetTransport;\n+\n+NetTransport.prototype.register = function (client) {\n+\tclient.registerProtocolHandler('amqp', this);\n+};\n+\n+NetTransport.prototype.connect = function (address) {\n+\t\tdebug('Connecting to ' + address.host + ':' + address.port + ' via straight-up sockets');\n+\t\tthis._transport = net.connect({ port: address.port, host: address.host });","path":"lib/transport/net-transport.js","position":21,"original_position":21,"commit_id":"1cd6e654ca7bd52c9dfd2b09b0e5191ac9849f0e","original_commit_id":"1cd6e654ca7bd52c9dfd2b09b0e5191ac9849f0e","user":{"login":"noodlefrenzy","id":813544,"avatar_url":"https://avatars.githubusercontent.com/u/813544?v=3","gravatar_id":"","url":"https://api.github.com/users/noodlefrenzy","html_url":"https://github.com/noodlefrenzy","followers_url":"https://api.github.com/users/noodlefrenzy/followers","following_url":"https://api.github.com/users/noodlefrenzy/following{/other_user}","gists_url":"https://api.github.com/users/noodlefrenzy/gists{/gist_id}","starred_url":"https://api.github.com/users/noodlefrenzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noodlefrenzy/subscriptions","organizations_url":"https://api.github.com/users/noodlefrenzy/orgs","repos_url":"https://api.github.com/users/noodlefrenzy/repos","events_url":"https://api.github.com/users/noodlefrenzy/events{/privacy}","received_events_url":"https://api.github.com/users/noodlefrenzy/received_events","type":"User","site_admin":false},"body":"+1, good catch.","created_at":"2015-12-09T00:30:49Z","updated_at":"2015-12-09T00:30:49Z","html_url":"https://github.com/noodlefrenzy/node-amqp10/pull/195#discussion_r47036796","pull_request_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/pulls/195","_links":{"self":{"href":"https://api.github.com/repos/noodlefrenzy/node-amqp10/pulls/comments/47036796"},"html":{"href":"https://github.com/noodlefrenzy/node-amqp10/pull/195#discussion_r47036796"},"pull_request":{"href":"https://api.github.com/repos/noodlefrenzy/node-amqp10/pulls/195"}}},"pull_request":{"url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/pulls/195","id":52934972,"html_url":"https://github.com/noodlefrenzy/node-amqp10/pull/195","diff_url":"https://github.com/noodlefrenzy/node-amqp10/pull/195.diff","patch_url":"https://github.com/noodlefrenzy/node-amqp10/pull/195.patch","issue_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/issues/195","number":195,"state":"open","locked":false,"title":"Separate transport from connection - Create the basics for transport injection","user":{"login":"pierreca","id":4979572,"avatar_url":"https://avatars.githubusercontent.com/u/4979572?v=3","gravatar_id":"","url":"https://api.github.com/users/pierreca","html_url":"https://github.com/pierreca","followers_url":"https://api.github.com/users/pierreca/followers","following_url":"https://api.github.com/users/pierreca/following{/other_user}","gists_url":"https://api.github.com/users/pierreca/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreca/subscriptions","organizations_url":"https://api.github.com/users/pierreca/orgs","repos_url":"https://api.github.com/users/pierreca/repos","events_url":"https://api.github.com/users/pierreca/events{/privacy}","received_events_url":"https://api.github.com/users/pierreca/received_events","type":"User","site_admin":false},"body":"Here's a new set of changes to abstract the transport layer from the connection layer and allow new transport injection for future work with websockets, per the discussion in #194 .\r\n\r\nUnit tests should pass but I haven't tested or ran this code with any sample code, at this point it's just a base for discussion (make sure I'm going in the right direction)","created_at":"2015-12-08T03:41:37Z","updated_at":"2015-12-09T00:30:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a47638f662cf38d0096a6389f9fe1c99974897ca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/pulls/195/commits","review_comments_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/pulls/195/comments","review_comment_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/pulls/comments{/number}","comments_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/issues/195/comments","statuses_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/statuses/1cd6e654ca7bd52c9dfd2b09b0e5191ac9849f0e","head":{"label":"pierreca:separate-transport","ref":"separate-transport","sha":"1cd6e654ca7bd52c9dfd2b09b0e5191ac9849f0e","user":{"login":"pierreca","id":4979572,"avatar_url":"https://avatars.githubusercontent.com/u/4979572?v=3","gravatar_id":"","url":"https://api.github.com/users/pierreca","html_url":"https://github.com/pierreca","followers_url":"https://api.github.com/users/pierreca/followers","following_url":"https://api.github.com/users/pierreca/following{/other_user}","gists_url":"https://api.github.com/users/pierreca/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreca/subscriptions","organizations_url":"https://api.github.com/users/pierreca/orgs","repos_url":"https://api.github.com/users/pierreca/repos","events_url":"https://api.github.com/users/pierreca/events{/privacy}","received_events_url":"https://api.github.com/users/pierreca/received_events","type":"User","site_admin":false},"repo":{"id":47439709,"name":"node-amqp10","full_name":"pierreca/node-amqp10","owner":{"login":"pierreca","id":4979572,"avatar_url":"https://avatars.githubusercontent.com/u/4979572?v=3","gravatar_id":"","url":"https://api.github.com/users/pierreca","html_url":"https://github.com/pierreca","followers_url":"https://api.github.com/users/pierreca/followers","following_url":"https://api.github.com/users/pierreca/following{/other_user}","gists_url":"https://api.github.com/users/pierreca/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreca/subscriptions","organizations_url":"https://api.github.com/users/pierreca/orgs","repos_url":"https://api.github.com/users/pierreca/repos","events_url":"https://api.github.com/users/pierreca/events{/privacy}","received_events_url":"https://api.github.com/users/pierreca/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pierreca/node-amqp10","description":"amqp10 is a promise-based, AMQP 1.0 compliant node.js client","fork":true,"url":"https://api.github.com/repos/pierreca/node-amqp10","forks_url":"https://api.github.com/repos/pierreca/node-amqp10/forks","keys_url":"https://api.github.com/repos/pierreca/node-amqp10/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pierreca/node-amqp10/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pierreca/node-amqp10/teams","hooks_url":"https://api.github.com/repos/pierreca/node-amqp10/hooks","issue_events_url":"https://api.github.com/repos/pierreca/node-amqp10/issues/events{/number}","events_url":"https://api.github.com/repos/pierreca/node-amqp10/events","assignees_url":"https://api.github.com/repos/pierreca/node-amqp10/assignees{/user}","branches_url":"https://api.github.com/repos/pierreca/node-amqp10/branches{/branch}","tags_url":"https://api.github.com/repos/pierreca/node-amqp10/tags","blobs_url":"https://api.github.com/repos/pierreca/node-amqp10/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pierreca/node-amqp10/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pierreca/node-amqp10/git/refs{/sha}","trees_url":"https://api.github.com/repos/pierreca/node-amqp10/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pierreca/node-amqp10/statuses/{sha}","languages_url":"https://api.github.com/repos/pierreca/node-amqp10/languages","stargazers_url":"https://api.github.com/repos/pierreca/node-amqp10/stargazers","contributors_url":"https://api.github.com/repos/pierreca/node-amqp10/contributors","subscribers_url":"https://api.github.com/repos/pierreca/node-amqp10/subscribers","subscription_url":"https://api.github.com/repos/pierreca/node-amqp10/subscription","commits_url":"https://api.github.com/repos/pierreca/node-amqp10/commits{/sha}","git_commits_url":"https://api.github.com/repos/pierreca/node-amqp10/git/commits{/sha}","comments_url":"https://api.github.com/repos/pierreca/node-amqp10/comments{/number}","issue_comment_url":"https://api.github.com/repos/pierreca/node-amqp10/issues/comments{/number}","contents_url":"https://api.github.com/repos/pierreca/node-amqp10/contents/{+path}","compare_url":"https://api.github.com/repos/pierreca/node-amqp10/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pierreca/node-amqp10/merges","archive_url":"https://api.github.com/repos/pierreca/node-amqp10/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pierreca/node-amqp10/downloads","issues_url":"https://api.github.com/repos/pierreca/node-amqp10/issues{/number}","pulls_url":"https://api.github.com/repos/pierreca/node-amqp10/pulls{/number}","milestones_url":"https://api.github.com/repos/pierreca/node-amqp10/milestones{/number}","notifications_url":"https://api.github.com/repos/pierreca/node-amqp10/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pierreca/node-amqp10/labels{/name}","releases_url":"https://api.github.com/repos/pierreca/node-amqp10/releases{/id}","created_at":"2015-12-05T03:01:05Z","updated_at":"2015-12-05T03:01:06Z","pushed_at":"2015-12-08T23:09:13Z","git_url":"git://github.com/pierreca/node-amqp10.git","ssh_url":"git@github.com:pierreca/node-amqp10.git","clone_url":"https://github.com/pierreca/node-amqp10.git","svn_url":"https://github.com/pierreca/node-amqp10","homepage":"","size":1593,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"noodlefrenzy:master","ref":"master","sha":"9870b9b618287cd773a219e38d2fda107ac13edc","user":{"login":"noodlefrenzy","id":813544,"avatar_url":"https://avatars.githubusercontent.com/u/813544?v=3","gravatar_id":"","url":"https://api.github.com/users/noodlefrenzy","html_url":"https://github.com/noodlefrenzy","followers_url":"https://api.github.com/users/noodlefrenzy/followers","following_url":"https://api.github.com/users/noodlefrenzy/following{/other_user}","gists_url":"https://api.github.com/users/noodlefrenzy/gists{/gist_id}","starred_url":"https://api.github.com/users/noodlefrenzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noodlefrenzy/subscriptions","organizations_url":"https://api.github.com/users/noodlefrenzy/orgs","repos_url":"https://api.github.com/users/noodlefrenzy/repos","events_url":"https://api.github.com/users/noodlefrenzy/events{/privacy}","received_events_url":"https://api.github.com/users/noodlefrenzy/received_events","type":"User","site_admin":false},"repo":{"id":24899166,"name":"node-amqp10","full_name":"noodlefrenzy/node-amqp10","owner":{"login":"noodlefrenzy","id":813544,"avatar_url":"https://avatars.githubusercontent.com/u/813544?v=3","gravatar_id":"","url":"https://api.github.com/users/noodlefrenzy","html_url":"https://github.com/noodlefrenzy","followers_url":"https://api.github.com/users/noodlefrenzy/followers","following_url":"https://api.github.com/users/noodlefrenzy/following{/other_user}","gists_url":"https://api.github.com/users/noodlefrenzy/gists{/gist_id}","starred_url":"https://api.github.com/users/noodlefrenzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noodlefrenzy/subscriptions","organizations_url":"https://api.github.com/users/noodlefrenzy/orgs","repos_url":"https://api.github.com/users/noodlefrenzy/repos","events_url":"https://api.github.com/users/noodlefrenzy/events{/privacy}","received_events_url":"https://api.github.com/users/noodlefrenzy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/noodlefrenzy/node-amqp10","description":"amqp10 is a promise-based, AMQP 1.0 compliant node.js client","fork":false,"url":"https://api.github.com/repos/noodlefrenzy/node-amqp10","forks_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/forks","keys_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/teams","hooks_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/hooks","issue_events_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/issues/events{/number}","events_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/events","assignees_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/assignees{/user}","branches_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/branches{/branch}","tags_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/tags","blobs_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/git/refs{/sha}","trees_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/statuses/{sha}","languages_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/languages","stargazers_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/stargazers","contributors_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/contributors","subscribers_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/subscribers","subscription_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/subscription","commits_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/commits{/sha}","git_commits_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/git/commits{/sha}","comments_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/comments{/number}","issue_comment_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/issues/comments{/number}","contents_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/contents/{+path}","compare_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/merges","archive_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/downloads","issues_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/issues{/number}","pulls_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/pulls{/number}","milestones_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/milestones{/number}","notifications_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/labels{/name}","releases_url":"https://api.github.com/repos/noodlefrenzy/node-amqp10/releases{/id}","created_at":"2014-10-07T16:13:45Z","updated_at":"2015-11-30T06:14:16Z","pushed_at":"2015-12-08T23:09:13Z","git_url":"git://github.com/noodlefrenzy/node-amqp10.git","ssh_url":"git@github.com:noodlefrenzy/node-amqp10.git","clone_url":"https://github.com/noodlefrenzy/node-amqp10.git","svn_url":"https://github.com/noodlefrenzy/node-amqp10","homepage":"","size":1603,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":14,"forks":14,"open_issues":14,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/noodlefrenzy/node-amqp10/pulls/195"},"html":{"href":"https://github.com/noodlefrenzy/node-amqp10/pull/195"},"issue":{"href":"https://api.github.com/repos/noodlefrenzy/node-amqp10/issues/195"},"comments":{"href":"https://api.github.com/repos/noodlefrenzy/node-amqp10/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/noodlefrenzy/node-amqp10/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/noodlefrenzy/node-amqp10/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/noodlefrenzy/node-amqp10/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/noodlefrenzy/node-amqp10/statuses/1cd6e654ca7bd52c9dfd2b09b0e5191ac9849f0e"}}}}