{"action":"created","issue":{"url":"https://api.github.com/repos/boothj5/profanity/issues/480","labels_url":"https://api.github.com/repos/boothj5/profanity/issues/480/labels{/name}","comments_url":"https://api.github.com/repos/boothj5/profanity/issues/480/comments","events_url":"https://api.github.com/repos/boothj5/profanity/issues/480/events","html_url":"https://github.com/boothj5/profanity/pull/480","id":53611080,"number":480,"title":"Add support for evaluated password (keyring support)","user":{"login":"peterlvilim","id":4017543,"avatar_url":"https://avatars.githubusercontent.com/u/4017543?v=3","gravatar_id":"","url":"https://api.github.com/users/peterlvilim","html_url":"https://github.com/peterlvilim","followers_url":"https://api.github.com/users/peterlvilim/followers","following_url":"https://api.github.com/users/peterlvilim/following{/other_user}","gists_url":"https://api.github.com/users/peterlvilim/gists{/gist_id}","starred_url":"https://api.github.com/users/peterlvilim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterlvilim/subscriptions","organizations_url":"https://api.github.com/users/peterlvilim/orgs","repos_url":"https://api.github.com/users/peterlvilim/repos","events_url":"https://api.github.com/users/peterlvilim/events{/privacy}","received_events_url":"https://api.github.com/users/peterlvilim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-07T09:02:44Z","updated_at":"2015-01-09T01:08:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/boothj5/profanity/pulls/480","html_url":"https://github.com/boothj5/profanity/pull/480","diff_url":"https://github.com/boothj5/profanity/pull/480.diff","patch_url":"https://github.com/boothj5/profanity/pull/480.patch"},"body":"This pull request is intended to add support for keyrings.  The idea is that you'll now be able to include the account configuration file in your dotfiles which many people keep in a public repository.\r\n\r\nI took an approach that is similar to mutt and several other common open source projects.  There is a new field called eval_password.  This field when loaded evaluates a shell command which will return the password.  This means that the user just needs a script that accesses their keyring and avoids introducing dependencies on specific keyrings.  In my case I use: http://www.passwordstore.org/  There are scripts for gnome-keyring and other more popular keyrings as well.\r\n\r\nSo my new config line looks like:\r\neval_password = pass pvilim_xmpp@facebook.com\r\nfor my facebook account.\r\n\r\nI also added code to prevent eval_password and password being set at the same time to cut down on the chance of a user leaking their password or having configuration problems.\r\n\r\nAlso, how does the testing framework work?  I checked the dev mailing list and docs but wasn't able to find out how to run it.  Once I know that I can add some test coverage."},"comment":{"url":"https://api.github.com/repos/boothj5/profanity/issues/comments/69278905","html_url":"https://github.com/boothj5/profanity/pull/480#issuecomment-69278905","issue_url":"https://api.github.com/repos/boothj5/profanity/issues/480","id":69278905,"user":{"login":"peterlvilim","id":4017543,"avatar_url":"https://avatars.githubusercontent.com/u/4017543?v=3","gravatar_id":"","url":"https://api.github.com/users/peterlvilim","html_url":"https://github.com/peterlvilim","followers_url":"https://api.github.com/users/peterlvilim/followers","following_url":"https://api.github.com/users/peterlvilim/following{/other_user}","gists_url":"https://api.github.com/users/peterlvilim/gists{/gist_id}","starred_url":"https://api.github.com/users/peterlvilim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterlvilim/subscriptions","organizations_url":"https://api.github.com/users/peterlvilim/orgs","repos_url":"https://api.github.com/users/peterlvilim/repos","events_url":"https://api.github.com/users/peterlvilim/events{/privacy}","received_events_url":"https://api.github.com/users/peterlvilim/received_events","type":"User","site_admin":false},"created_at":"2015-01-09T01:08:47Z","updated_at":"2015-01-09T01:08:47Z","body":"Sounds good.  Thanks for the quick response.  I'll go ahead and add automated tests shortly here."}}