{"action":"created","issue":{"url":"https://api.github.com/repos/ros-controls/ros_controllers/issues/205","labels_url":"https://api.github.com/repos/ros-controls/ros_controllers/issues/205/labels{/name}","comments_url":"https://api.github.com/repos/ros-controls/ros_controllers/issues/205/comments","events_url":"https://api.github.com/repos/ros-controls/ros_controllers/issues/205/events","html_url":"https://github.com/ros-controls/ros_controllers/pull/205","id":121931411,"number":205,"title":"Parameterized diff_drive_controller's odom_frame_id","user":{"login":"tappan-at-git","id":2761108,"avatar_url":"https://avatars.githubusercontent.com/u/2761108?v=3","gravatar_id":"","url":"https://api.github.com/users/tappan-at-git","html_url":"https://github.com/tappan-at-git","followers_url":"https://api.github.com/users/tappan-at-git/followers","following_url":"https://api.github.com/users/tappan-at-git/following{/other_user}","gists_url":"https://api.github.com/users/tappan-at-git/gists{/gist_id}","starred_url":"https://api.github.com/users/tappan-at-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tappan-at-git/subscriptions","organizations_url":"https://api.github.com/users/tappan-at-git/orgs","repos_url":"https://api.github.com/users/tappan-at-git/repos","events_url":"https://api.github.com/users/tappan-at-git/events{/privacy}","received_events_url":"https://api.github.com/users/tappan-at-git/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-13T17:15:48Z","updated_at":"2015-12-15T14:38:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ros-controls/ros_controllers/pulls/205","html_url":"https://github.com/ros-controls/ros_controllers/pull/205","diff_url":"https://github.com/ros-controls/ros_controllers/pull/205.diff","patch_url":"https://github.com/ros-controls/ros_controllers/pull/205.patch"},"body":"Addressing issue #204, made odom_frame_id_ a parameter-driven value for diff_drive_controllers."},"comment":{"url":"https://api.github.com/repos/ros-controls/ros_controllers/issues/comments/164783219","html_url":"https://github.com/ros-controls/ros_controllers/pull/205#issuecomment-164783219","issue_url":"https://api.github.com/repos/ros-controls/ros_controllers/issues/205","id":164783219,"user":{"login":"efernandez","id":382167,"avatar_url":"https://avatars.githubusercontent.com/u/382167?v=3","gravatar_id":"","url":"https://api.github.com/users/efernandez","html_url":"https://github.com/efernandez","followers_url":"https://api.github.com/users/efernandez/followers","following_url":"https://api.github.com/users/efernandez/following{/other_user}","gists_url":"https://api.github.com/users/efernandez/gists{/gist_id}","starred_url":"https://api.github.com/users/efernandez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efernandez/subscriptions","organizations_url":"https://api.github.com/users/efernandez/orgs","repos_url":"https://api.github.com/users/efernandez/repos","events_url":"https://api.github.com/users/efernandez/events{/privacy}","received_events_url":"https://api.github.com/users/efernandez/received_events","type":"User","site_admin":false},"created_at":"2015-12-15T14:38:47Z","updated_at":"2015-12-15T14:38:47Z","body":"Just some minor comments related with the test.\r\n\r\nI think it's good to have the ability to set the odometry frame_id, as in `amcl`.\r\nThe implementation LGTM. Thanks for the tests; maybe it was enough with the second one.\r\n\r\n:+1: @tappan-at-git Let us know if you either address my minor comments or not, to merge this."}}