{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/26325092","id":26325092,"diff_hunk":"@@ -106,6 +106,35 @@ class SparkContextSuite extends FunSuite with LocalSparkContext {\n       sc.stop()\n     }\n   }\n+  \n+  test(\"addFile works with relative path\") {","path":"core/src/test/scala/org/apache/spark/SparkContextSuite.scala","position":5,"original_position":5,"commit_id":"0ff3fa88ae1599bd8ce67bcec7500f4647572267","original_commit_id":"0ff3fa88ae1599bd8ce67bcec7500f4647572267","user":{"login":"srowen","id":822522,"avatar_url":"https://avatars.githubusercontent.com/u/822522?v=3","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"body":"Rather than copy and paste the test I wonder if this can just be injected into the \"addFile works\" test. Like, make the test file a relative path there. Also I see that test doesn't use the framework provided temp dir which you did correctly here.","created_at":"2015-03-12T17:37:04Z","updated_at":"2015-03-12T17:37:04Z","html_url":"https://github.com/apache/spark/pull/4993#discussion_r26325092","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/4993","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/26325092"},"html":{"href":"https://github.com/apache/spark/pull/4993#discussion_r26325092"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/4993"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/4993","id":31013320,"html_url":"https://github.com/apache/spark/pull/4993","diff_url":"https://github.com/apache/spark/pull/4993.diff","patch_url":"https://github.com/apache/spark/pull/4993.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/4993","number":4993,"state":"open","locked":false,"title":"[SPARK-6300][Spark Core] sc.addFile(path) does not support the relative path.","user":{"login":"DoingDone9","id":7529754,"avatar_url":"https://avatars.githubusercontent.com/u/7529754?v=3","gravatar_id":"","url":"https://api.github.com/users/DoingDone9","html_url":"https://github.com/DoingDone9","followers_url":"https://api.github.com/users/DoingDone9/followers","following_url":"https://api.github.com/users/DoingDone9/following{/other_user}","gists_url":"https://api.github.com/users/DoingDone9/gists{/gist_id}","starred_url":"https://api.github.com/users/DoingDone9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoingDone9/subscriptions","organizations_url":"https://api.github.com/users/DoingDone9/orgs","repos_url":"https://api.github.com/users/DoingDone9/repos","events_url":"https://api.github.com/users/DoingDone9/events{/privacy}","received_events_url":"https://api.github.com/users/DoingDone9/received_events","type":"User","site_admin":false},"body":"when i run cmd like that sc.addFile(\"../test.txt\"), it did not work and throwed an exception:\r\njava.lang.IllegalArgumentException: java.net.URISyntaxException: Relative path in absolute URI: file:../test.txt\r\nat org.apache.hadoop.fs.Path.initialize(Path.java:206)\r\nat org.apache.hadoop.fs.Path.<init>(Path.java:172) \r\n........\r\n.......\r\nCaused by: java.net.URISyntaxException: Relative path in absolute URI: file:../test.txt\r\nat java.net.URI.checkPath(URI.java:1804)\r\nat java.net.URI.<init>(URI.java:752)\r\nat org.apache.hadoop.fs.Path.initialize(Path.java:203)","created_at":"2015-03-12T07:25:20Z","updated_at":"2015-03-12T17:37:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b6edd33aa0f2fb632bd727480779165ca912af9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/4993/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/4993/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/4993/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/0ff3fa88ae1599bd8ce67bcec7500f4647572267","head":{"label":"DoingDone9:relativePath","ref":"relativePath","sha":"0ff3fa88ae1599bd8ce67bcec7500f4647572267","user":{"login":"DoingDone9","id":7529754,"avatar_url":"https://avatars.githubusercontent.com/u/7529754?v=3","gravatar_id":"","url":"https://api.github.com/users/DoingDone9","html_url":"https://github.com/DoingDone9","followers_url":"https://api.github.com/users/DoingDone9/followers","following_url":"https://api.github.com/users/DoingDone9/following{/other_user}","gists_url":"https://api.github.com/users/DoingDone9/gists{/gist_id}","starred_url":"https://api.github.com/users/DoingDone9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoingDone9/subscriptions","organizations_url":"https://api.github.com/users/DoingDone9/orgs","repos_url":"https://api.github.com/users/DoingDone9/repos","events_url":"https://api.github.com/users/DoingDone9/events{/privacy}","received_events_url":"https://api.github.com/users/DoingDone9/received_events","type":"User","site_admin":false},"repo":{"id":30402760,"name":"spark","full_name":"DoingDone9/spark","owner":{"login":"DoingDone9","id":7529754,"avatar_url":"https://avatars.githubusercontent.com/u/7529754?v=3","gravatar_id":"","url":"https://api.github.com/users/DoingDone9","html_url":"https://github.com/DoingDone9","followers_url":"https://api.github.com/users/DoingDone9/followers","following_url":"https://api.github.com/users/DoingDone9/following{/other_user}","gists_url":"https://api.github.com/users/DoingDone9/gists{/gist_id}","starred_url":"https://api.github.com/users/DoingDone9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoingDone9/subscriptions","organizations_url":"https://api.github.com/users/DoingDone9/orgs","repos_url":"https://api.github.com/users/DoingDone9/repos","events_url":"https://api.github.com/users/DoingDone9/events{/privacy}","received_events_url":"https://api.github.com/users/DoingDone9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DoingDone9/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/DoingDone9/spark","forks_url":"https://api.github.com/repos/DoingDone9/spark/forks","keys_url":"https://api.github.com/repos/DoingDone9/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoingDone9/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoingDone9/spark/teams","hooks_url":"https://api.github.com/repos/DoingDone9/spark/hooks","issue_events_url":"https://api.github.com/repos/DoingDone9/spark/issues/events{/number}","events_url":"https://api.github.com/repos/DoingDone9/spark/events","assignees_url":"https://api.github.com/repos/DoingDone9/spark/assignees{/user}","branches_url":"https://api.github.com/repos/DoingDone9/spark/branches{/branch}","tags_url":"https://api.github.com/repos/DoingDone9/spark/tags","blobs_url":"https://api.github.com/repos/DoingDone9/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoingDone9/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoingDone9/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoingDone9/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoingDone9/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/DoingDone9/spark/languages","stargazers_url":"https://api.github.com/repos/DoingDone9/spark/stargazers","contributors_url":"https://api.github.com/repos/DoingDone9/spark/contributors","subscribers_url":"https://api.github.com/repos/DoingDone9/spark/subscribers","subscription_url":"https://api.github.com/repos/DoingDone9/spark/subscription","commits_url":"https://api.github.com/repos/DoingDone9/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoingDone9/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoingDone9/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoingDone9/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoingDone9/spark/contents/{+path}","compare_url":"https://api.github.com/repos/DoingDone9/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoingDone9/spark/merges","archive_url":"https://api.github.com/repos/DoingDone9/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoingDone9/spark/downloads","issues_url":"https://api.github.com/repos/DoingDone9/spark/issues{/number}","pulls_url":"https://api.github.com/repos/DoingDone9/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/DoingDone9/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/DoingDone9/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoingDone9/spark/labels{/name}","releases_url":"https://api.github.com/repos/DoingDone9/spark/releases{/id}","created_at":"2015-02-06T08:34:14Z","updated_at":"2015-03-12T06:46:30Z","pushed_at":"2015-03-12T11:23:24Z","git_url":"git://github.com/DoingDone9/spark.git","ssh_url":"git@github.com:DoingDone9/spark.git","clone_url":"https://github.com/DoingDone9/spark.git","svn_url":"https://github.com/DoingDone9/spark","homepage":null,"size":93743,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e921a665c56950c03155f4b47500627265a4ba8e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-03-12T15:56:58Z","pushed_at":"2015-03-12T15:07:33Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1385260,"stargazers_count":3168,"watchers_count":3168,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2741,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":292,"forks":2741,"open_issues":292,"watchers":3168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/4993"},"html":{"href":"https://github.com/apache/spark/pull/4993"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/4993"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/4993/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/4993/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/4993/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/0ff3fa88ae1599bd8ce67bcec7500f4647572267"}}}}