{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13462","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13462/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13462/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13462/events","html_url":"https://github.com/kubernetes/kubernetes/pull/13462","id":104350391,"number":13462,"title":"Improved test coverage for master.","user":{"login":"ashcrow","id":22706,"avatar_url":"https://avatars.githubusercontent.com/u/22706?v=3","gravatar_id":"","url":"https://api.github.com/users/ashcrow","html_url":"https://github.com/ashcrow","followers_url":"https://api.github.com/users/ashcrow/followers","following_url":"https://api.github.com/users/ashcrow/following{/other_user}","gists_url":"https://api.github.com/users/ashcrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashcrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashcrow/subscriptions","organizations_url":"https://api.github.com/users/ashcrow/orgs","repos_url":"https://api.github.com/users/ashcrow/repos","events_url":"https://api.github.com/users/ashcrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashcrow/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/ok-to-merge","name":"ok-to-merge","color":"fbca04"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900"}],"state":"open","locked":false,"assignee":{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"milestone":null,"comments":31,"created_at":"2015-09-01T20:41:03Z","updated_at":"2015-09-11T21:04:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13462","html_url":"https://github.com/kubernetes/kubernetes/pull/13462","diff_url":"https://github.com/kubernetes/kubernetes/pull/13462.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/13462.patch"},"body":"## Description\r\nThis PR attempts to improve the test coverage for master. There are still missing cases and paths **but** this boost from *13.9%* -> *~56%* will hopefully be helpful.\r\n\r\n- Added new tests for master.\r\n- Updated the already present tasks.\r\n- Now using testify for assertions.\r\n\r\n\r\n## Without Patch\r\n```\r\nRunning tests for APIVersion: v1 with etcdPrefix: registry\r\n+++ [0901 16:36:40] Saving coverage output in '/tmp/k8s_coverage/v1/20150901-163640'\r\nok      k8s.io/kubernetes/pkg/master    0.016s  coverage: 13.9% of statements\r\n+++ [0901 16:36:52] Combined coverage report: /tmp/k8s_coverage/v1/20150901-163640/combined-coverage.html\r\nRunning tests for APIVersion: v1 with etcdPrefix: kubernetes.io/registry\r\n+++ [0901 16:36:52] Saving coverage output in '/tmp/k8s_coverage/v1/20150901-163652'\r\nok      k8s.io/kubernetes/pkg/master    0.013s  coverage: 13.9% of statements\r\n+++ [0901 16:37:03] Combined coverage report: /tmp/k8s_coverage/v1/20150901-163652/combined-coverage.html\r\n```\r\n\r\n## With Patch\r\n```\r\nRunning tests for APIVersion: v1 with etcdPrefix: registry\r\n+++ [0901 16:35:47] Saving coverage output in '/tmp/k8s_coverage/v1/20150901-163547'\r\nok      k8s.io/kubernetes/pkg/master    3.607s  coverage: 56.7% of statements\r\n+++ [0901 16:36:00] Combined coverage report: /tmp/k8s_coverage/v1/20150901-163547/combined-coverage.html\r\nRunning tests for APIVersion: v1 with etcdPrefix: kubernetes.io/registry\r\n+++ [0901 16:36:00] Saving coverage output in '/tmp/k8s_coverage/v1/20150901-163600'\r\nok      k8s.io/kubernetes/pkg/master    1.374s  coverage: 56.7% of statements\r\n+++ [0901 16:36:13] Combined coverage report: /tmp/k8s_coverage/v1/20150901-163600/combined-coverage.html\r\n```"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/139661060","html_url":"https://github.com/kubernetes/kubernetes/pull/13462#issuecomment-139661060","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13462","id":139661060,"user":{"login":"quinton-hoole","id":10390785,"avatar_url":"https://avatars.githubusercontent.com/u/10390785?v=3","gravatar_id":"","url":"https://api.github.com/users/quinton-hoole","html_url":"https://github.com/quinton-hoole","followers_url":"https://api.github.com/users/quinton-hoole/followers","following_url":"https://api.github.com/users/quinton-hoole/following{/other_user}","gists_url":"https://api.github.com/users/quinton-hoole/gists{/gist_id}","starred_url":"https://api.github.com/users/quinton-hoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quinton-hoole/subscriptions","organizations_url":"https://api.github.com/users/quinton-hoole/orgs","repos_url":"https://api.github.com/users/quinton-hoole/repos","events_url":"https://api.github.com/users/quinton-hoole/events{/privacy}","received_events_url":"https://api.github.com/users/quinton-hoole/received_events","type":"User","site_admin":false},"created_at":"2015-09-11T21:04:55Z","updated_at":"2015-09-11T21:04:55Z","body":"Another, different flake.  Try again...\r\n\r\n@k8s-bot test this again please\r\n"}}