{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/24309284","id":24309284,"diff_hunk":"@@ -31,13 +31,13 @@ enum ThreadProcessorId {\n };\n \n enum ThreadStatus {\n-    THREADSTATUS_RUNNING        = 1,\n-    THREADSTATUS_READY          = 2,\n-    THREADSTATUS_WAIT           = 4,\n-    THREADSTATUS_SUSPEND        = 8,\n-    THREADSTATUS_DORMANT        = 16,\n-    THREADSTATUS_DEAD           = 32,\n-    THREADSTATUS_WAITSUSPEND    = THREADSTATUS_WAIT | THREADSTATUS_SUSPEND\n+    THREADSTATUS_RUNNING,\n+    THREADSTATUS_READY,\n+    THREADSTATUS_WAIT_ARB,\n+    THREADSTATUS_WAIT_SLEEP,\n+    THREADSTATUS_WAIT_SYNC,","path":"src/core/hle/kernel/thread.h","position":15,"original_position":15,"commit_id":"5ed194547b807b3e6d2d45b32da86cdfd70cd64e","original_commit_id":"5ed194547b807b3e6d2d45b32da86cdfd70cd64e","user":{"login":"bunnei","id":6956688,"avatar_url":"https://avatars.githubusercontent.com/u/6956688?v=3","gravatar_id":"","url":"https://api.github.com/users/bunnei","html_url":"https://github.com/bunnei","followers_url":"https://api.github.com/users/bunnei/followers","following_url":"https://api.github.com/users/bunnei/following{/other_user}","gists_url":"https://api.github.com/users/bunnei/gists{/gist_id}","starred_url":"https://api.github.com/users/bunnei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bunnei/subscriptions","organizations_url":"https://api.github.com/users/bunnei/orgs","repos_url":"https://api.github.com/users/bunnei/repos","events_url":"https://api.github.com/users/bunnei/events{/privacy}","received_events_url":"https://api.github.com/users/bunnei/received_events","type":"User","site_admin":false},"body":"I'd prefer this be called `THREADSTATUS_WAIT_SYNCH`, but perhaps that just preference (I feel like we abbreviate \"synchronization\" as \"synch\" elsewhere)","created_at":"2015-02-09T05:09:42Z","updated_at":"2015-02-09T05:09:42Z","html_url":"https://github.com/citra-emu/citra/pull/528#discussion_r24309284","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/528","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/24309284"},"html":{"href":"https://github.com/citra-emu/citra/pull/528#discussion_r24309284"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/528"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/528","id":28430920,"html_url":"https://github.com/citra-emu/citra/pull/528","diff_url":"https://github.com/citra-emu/citra/pull/528.diff","patch_url":"https://github.com/citra-emu/citra/pull/528.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/528","number":528,"state":"open","locked":false,"title":"Scheduler refactor Pt. 1","user":{"login":"kevinhartman","id":1374024,"avatar_url":"https://avatars.githubusercontent.com/u/1374024?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinhartman","html_url":"https://github.com/kevinhartman","followers_url":"https://api.github.com/users/kevinhartman/followers","following_url":"https://api.github.com/users/kevinhartman/following{/other_user}","gists_url":"https://api.github.com/users/kevinhartman/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhartman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhartman/subscriptions","organizations_url":"https://api.github.com/users/kevinhartman/orgs","repos_url":"https://api.github.com/users/kevinhartman/repos","events_url":"https://api.github.com/users/kevinhartman/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhartman/received_events","type":"User","site_admin":false},"body":"* Simplifies scheduling logic, specifically regarding thread status. It should be much clearer which statuses are valid for a thread at any given point in the system.\r\n* Removes some dead code from thread.cpp.\r\n* Moves the implementation of resetting a ThreadContext to the corresponding core's implementation.\r\n\r\nI have a more aggressive refactor in progress as well (not yet passing all waitsync tests) which builds on top of these changes.","created_at":"2015-02-01T13:14:04Z","updated_at":"2015-02-09T05:09:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e162844ccaa7367c3250ea7b15f1d1e0a1cf5da","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/528/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/528/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/{number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/528/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/5ed194547b807b3e6d2d45b32da86cdfd70cd64e","head":{"label":"kevinhartman:scheduling-logic","ref":"scheduling-logic","sha":"5ed194547b807b3e6d2d45b32da86cdfd70cd64e","user":{"login":"kevinhartman","id":1374024,"avatar_url":"https://avatars.githubusercontent.com/u/1374024?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinhartman","html_url":"https://github.com/kevinhartman","followers_url":"https://api.github.com/users/kevinhartman/followers","following_url":"https://api.github.com/users/kevinhartman/following{/other_user}","gists_url":"https://api.github.com/users/kevinhartman/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhartman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhartman/subscriptions","organizations_url":"https://api.github.com/users/kevinhartman/orgs","repos_url":"https://api.github.com/users/kevinhartman/repos","events_url":"https://api.github.com/users/kevinhartman/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhartman/received_events","type":"User","site_admin":false},"repo":{"id":22826744,"name":"citra","full_name":"kevinhartman/citra","owner":{"login":"kevinhartman","id":1374024,"avatar_url":"https://avatars.githubusercontent.com/u/1374024?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinhartman","html_url":"https://github.com/kevinhartman","followers_url":"https://api.github.com/users/kevinhartman/followers","following_url":"https://api.github.com/users/kevinhartman/following{/other_user}","gists_url":"https://api.github.com/users/kevinhartman/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhartman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhartman/subscriptions","organizations_url":"https://api.github.com/users/kevinhartman/orgs","repos_url":"https://api.github.com/users/kevinhartman/repos","events_url":"https://api.github.com/users/kevinhartman/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhartman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kevinhartman/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/kevinhartman/citra","forks_url":"https://api.github.com/repos/kevinhartman/citra/forks","keys_url":"https://api.github.com/repos/kevinhartman/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevinhartman/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevinhartman/citra/teams","hooks_url":"https://api.github.com/repos/kevinhartman/citra/hooks","issue_events_url":"https://api.github.com/repos/kevinhartman/citra/issues/events{/number}","events_url":"https://api.github.com/repos/kevinhartman/citra/events","assignees_url":"https://api.github.com/repos/kevinhartman/citra/assignees{/user}","branches_url":"https://api.github.com/repos/kevinhartman/citra/branches{/branch}","tags_url":"https://api.github.com/repos/kevinhartman/citra/tags","blobs_url":"https://api.github.com/repos/kevinhartman/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevinhartman/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevinhartman/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevinhartman/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevinhartman/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/kevinhartman/citra/languages","stargazers_url":"https://api.github.com/repos/kevinhartman/citra/stargazers","contributors_url":"https://api.github.com/repos/kevinhartman/citra/contributors","subscribers_url":"https://api.github.com/repos/kevinhartman/citra/subscribers","subscription_url":"https://api.github.com/repos/kevinhartman/citra/subscription","commits_url":"https://api.github.com/repos/kevinhartman/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevinhartman/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevinhartman/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevinhartman/citra/issues/comments/{number}","contents_url":"https://api.github.com/repos/kevinhartman/citra/contents/{+path}","compare_url":"https://api.github.com/repos/kevinhartman/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevinhartman/citra/merges","archive_url":"https://api.github.com/repos/kevinhartman/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevinhartman/citra/downloads","issues_url":"https://api.github.com/repos/kevinhartman/citra/issues{/number}","pulls_url":"https://api.github.com/repos/kevinhartman/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/kevinhartman/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/kevinhartman/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevinhartman/citra/labels{/name}","releases_url":"https://api.github.com/repos/kevinhartman/citra/releases{/id}","created_at":"2014-08-11T04:25:22Z","updated_at":"2015-02-03T04:07:14Z","pushed_at":"2015-02-08T10:47:51Z","git_url":"git://github.com/kevinhartman/citra.git","ssh_url":"git@github.com:kevinhartman/citra.git","clone_url":"https://github.com/kevinhartman/citra.git","svn_url":"https://github.com/kevinhartman/citra","homepage":null,"size":7647,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"7f730ed158bc9bba064100b9644b318134ef0bb3","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments/{number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","created_at":"2014-05-16T18:33:15Z","updated_at":"2015-02-09T02:42:24Z","pushed_at":"2015-02-08T15:29:32Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":18554,"stargazers_count":567,"watchers_count":567,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":46,"forks":141,"open_issues":46,"watchers":567,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/528"},"html":{"href":"https://github.com/citra-emu/citra/pull/528"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/528"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/528/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/528/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/528/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/5ed194547b807b3e6d2d45b32da86cdfd70cd64e"}}}}