{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/26612182","id":26612182,"diff_hunk":"@@ -21,13 +21,16 @@ const float ADJUST_LOD_DOWN_FPS = 40.0;\n const float ADJUST_LOD_UP_FPS = 55.0;\n const float DEFAULT_ADJUST_AVATAR_LOD_DOWN_FPS = 30.0f;\n \n-const quint64 ADJUST_LOD_DOWN_DELAY = 1000 * 1000 * 5;\n+const quint64 ADJUST_LOD_DOWN_DELAY = 1000 * 1000 * 0.5; // Consider adjusting LOD down after half a second","path":"interface/src/LODManager.h","position":5,"original_position":5,"commit_id":"1e03335012794e6dac20c342286d430aca9d04af","original_commit_id":"1e03335012794e6dac20c342286d430aca9d04af","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"body":"Make the adjustment happen more quickly.","created_at":"2015-03-17T20:24:29Z","updated_at":"2015-03-17T20:24:29Z","html_url":"https://github.com/highfidelity/hifi/pull/4463#discussion_r26612182","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/4463","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/26612182"},"html":{"href":"https://github.com/highfidelity/hifi/pull/4463#discussion_r26612182"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/4463"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/4463","id":31373916,"html_url":"https://github.com/highfidelity/hifi/pull/4463","diff_url":"https://github.com/highfidelity/hifi/pull/4463.diff","patch_url":"https://github.com/highfidelity/hifi/pull/4463.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/4463","number":4463,"state":"open","locked":false,"title":"MVP Task - tweaks to automatic-LOD adjustments","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"body":"This PR includes:\r\n* Tweaks to the LOD adjustment knobs to make LOD adjustment more aggressive.\r\n* Exposing the LODManager to the scripting interface to allow implementing support for progressive content as well as warnings for expensive content.\r\n\r\n**More details:**\r\n\r\n@PhilipRosedale asked that we make the automatic LOD adjustment more aggressive about culling down objects if the LOD list below the minimum threshold. This PR effectively does that.\r\n\r\nThe primary knobs to turn in the LODManager are the ADJUST_LOD_MIN_SIZE_SCALE which controls how \"low\" the auto-adjust LOD will go. It used to be set to a lower bound of 5:20 vision, meaning you'd need to be .25 meters from a 1 meter object to see it. We've now made it go as low as 1:1638400 vision... e.g. really blind!\r\n\r\nI've also adjusted the delay in the Auto-LOD tool... it used to wait 5 seconds before attempting to adjust the LOD, now it will only wait 0.5 seconds.\r\n\r\nTesting this in Apartment on my lower-end mac, I get the behavior we expect. As I turn around and look at the most \"expensive\" parts of the scene when the FPS drops to ~5-10fps, we see parts of the model start to disappear until the FPS reaches ~55fps. Then if you turn around in the room to look at less expensive parts of the scene, if the FPS remains above 55fps, you'll start to see new elements of the scene pop in.","created_at":"2015-03-17T20:21:49Z","updated_at":"2015-03-17T20:24:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73f30d6e4369150d552682e0906bf573f559021a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/4463/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/4463/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/4463/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/1e03335012794e6dac20c342286d430aca9d04af","head":{"label":"ZappoMan:LODTweaks","ref":"LODTweaks","sha":"1e03335012794e6dac20c342286d430aca9d04af","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"repo":{"id":9376434,"name":"hifi","full_name":"ZappoMan/hifi","owner":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZappoMan/hifi","description":"Test platform for various render and interface tests for next-gen VR system","fork":true,"url":"https://api.github.com/repos/ZappoMan/hifi","forks_url":"https://api.github.com/repos/ZappoMan/hifi/forks","keys_url":"https://api.github.com/repos/ZappoMan/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZappoMan/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZappoMan/hifi/teams","hooks_url":"https://api.github.com/repos/ZappoMan/hifi/hooks","issue_events_url":"https://api.github.com/repos/ZappoMan/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/ZappoMan/hifi/events","assignees_url":"https://api.github.com/repos/ZappoMan/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/ZappoMan/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/ZappoMan/hifi/tags","blobs_url":"https://api.github.com/repos/ZappoMan/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZappoMan/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZappoMan/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZappoMan/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZappoMan/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/ZappoMan/hifi/languages","stargazers_url":"https://api.github.com/repos/ZappoMan/hifi/stargazers","contributors_url":"https://api.github.com/repos/ZappoMan/hifi/contributors","subscribers_url":"https://api.github.com/repos/ZappoMan/hifi/subscribers","subscription_url":"https://api.github.com/repos/ZappoMan/hifi/subscription","commits_url":"https://api.github.com/repos/ZappoMan/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZappoMan/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZappoMan/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZappoMan/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZappoMan/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/ZappoMan/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZappoMan/hifi/merges","archive_url":"https://api.github.com/repos/ZappoMan/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZappoMan/hifi/downloads","issues_url":"https://api.github.com/repos/ZappoMan/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/ZappoMan/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/ZappoMan/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/ZappoMan/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZappoMan/hifi/labels{/name}","releases_url":"https://api.github.com/repos/ZappoMan/hifi/releases{/id}","created_at":"2013-04-11T17:41:25Z","updated_at":"2015-03-17T16:04:24Z","pushed_at":"2015-03-17T20:18:35Z","git_url":"git://github.com/ZappoMan/hifi.git","ssh_url":"git@github.com:ZappoMan/hifi.git","clone_url":"https://github.com/ZappoMan/hifi.git","svn_url":"https://github.com/ZappoMan/hifi","homepage":null,"size":155435,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"d33d3afb52927e86f02f23e5f666966d1a5f2be1","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open, decentralized virtual worlds using sensors to control avatars and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-03-17T15:06:05Z","pushed_at":"2015-03-17T15:06:05Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":198166,"stargazers_count":241,"watchers_count":241,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":51,"forks":141,"open_issues":51,"watchers":241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/4463"},"html":{"href":"https://github.com/highfidelity/hifi/pull/4463"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/4463"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/4463/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/4463/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/4463/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/1e03335012794e6dac20c342286d430aca9d04af"}}}}