{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/12832","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12832/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12832/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12832/events","html_url":"https://github.com/cms-sw/cmssw/pull/12832","id":123028831,"number":12832,"title":"Remove PHcalParameters and provide new GT for all scenarios.","user":{"login":"diguida","id":5444102,"avatar_url":"https://avatars.githubusercontent.com/u/5444102?v=3","gravatar_id":"","url":"https://api.github.com/users/diguida","html_url":"https://github.com/diguida","followers_url":"https://api.github.com/users/diguida/followers","following_url":"https://api.github.com/users/diguida/following{/other_user}","gists_url":"https://api.github.com/users/diguida/gists{/gist_id}","starred_url":"https://api.github.com/users/diguida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diguida/subscriptions","organizations_url":"https://api.github.com/users/diguida/orgs","repos_url":"https://api.github.com/users/diguida/repos","events_url":"https://api.github.com/users/diguida/events{/privacy}","received_events_url":"https://api.github.com/users/diguida/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/db-pending","name":"db-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/geometry-pending","name":"geometry-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/57","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_0_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/57/labels","id":1362157,"number":57,"title":"Next CMSSW_8_0_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":44,"closed_issues":401,"state":"open","created_at":"2015-10-18T08:35:44Z","updated_at":"2015-12-19T06:09:57Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2015-12-18T21:24:16Z","updated_at":"2015-12-19T18:08:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/12832","html_url":"https://github.com/cms-sw/cmssw/pull/12832","diff_url":"https://github.com/cms-sw/cmssw/pull/12832.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/12832.patch"},"body":"# Summary of code changes\r\nRemove `PHcalParameters` class, which is replaced by `HcalParameters`. Originally in #12817 \r\n\r\n# Summary of GT Changes\r\n\r\n## RunI Simulation\r\n* **Ideal scenario**: [`80X_mcRun1_design_v0`](https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/80X_mcRun1_design_v0): As [`76X_mcRun1_design_v11`](https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/76X_mcRun1_design_v11) with the following [changes](https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/76X_mcRun1_design_v11/80X_mcRun1_design_v0):\r\n * removed `PHcalParametersRcd`.\r\n* **Realistic scenario**: [`80X_mcRun1_realistic_v0`](https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/80X_mcRun1_realistic_v0\r\n ): As [`76X_mcRun1_realistic_v11`](https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/76X_mcRun1_realistic_v11) with the following [changes](https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/76X_mcRun1_realistic_v11/80X_mcRun1_realistic_v0):\r\n * removed `PHcalParametersRcd`.\r\n* **Heavy Ion scenario**: [`80X_mcRun1_HeavyIon_v0`](https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/80X_mcRun1_HeavyIon_v0\r\n ): As [`76X_mcRun1_HeavyIon_v11`](https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/76X_mcRun1_HeavyIon_v11) with the following [changes](https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/76X_mcRun1_HeavyIon_v11/80X_mcRun1_HeavyIon_v0):\r\n * removed `PHcalParametersRcd`.\r\n* **Proton-Lead scenario**: [`80X_mcRun1_pA_v0`](https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/80X_mcRun1_pA_v0\r\n ): As [`76X_mcRun1_pA_v11`](https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/76X_mcRun1_pA_v11) with the following [changes](https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/76X_mcRun1_pA_v11/80X_mcRun1_pA_v0):\r\n * removed `PHcalParametersRcd`.\r\n\r\n## RunII Simulation\r\n* **Ideal scenario**: 80X_mcRun2_design_v0: As 76X_mcRun2_design_v14 with the following changes:\r\n * added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type\r\n * removed PHcalParametersRcd.\r\n* **Startup scenario**: 80X_mcRun2_startup_v0: As 76X_mcRun2_startup_v13 with the following changes:\r\n * added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type\r\n * removed PHcalParametersRcd.\r\n* **Asymptotic scenario**: 80X_mcRun2_asymptotic_v0: As 76X_mcRun2_asymptotic_v14 with the following changes:\r\n * added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type\r\n * removed PHcalParametersRcd.\r\n* **Heavy Ion scenario**: 80X_mcRun2_HeavyIon_v0: As 76X_mcRun2_HeavyIon_v14 with the following changes:\r\n * added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type\r\n * removed PHcalParametersRcd.\r\n\r\n## RunII Data\r\n* **HLT processing**: 80X_dataRun2_HLT_frozen_v0: As 76X_dataRun2_HLT_frozen_v11 (snapshot time set to 2015-12-18 17:00:00 UTC) with the following changes:\r\n * added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type.\r\n* **HLT Heavy Ion processing**: 80X_dataRun2_HLTHI_frozen_v0: As 76X_dataRun2_HLTHI_frozen_v2 (snapshot time set to 2015-12-18 17:00:00 UTC) with the following changes:\r\n * added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type\r\n* **Offline processing**: 80X_dataRun2_v1: As 80X_dataRun2_v0 with the following changes:\r\n * added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type\r\n * removed PHcalParametersRcd\r\n * updated B tag discriminators for HLT with the following taggers: CombinedSVIVFV2RecoVertex, CombinedSVIVFV2PseudoVertex, CombinedSVIVFV2NoVertex, CombinedSVRecoVertex, CombinedSVPseudoVertex, CombinedSVNoVertex (as used by HLT data collection in 2015).\r\n\r\n## Upgrade 2017 Simulation\r\n* **Ideal scenario**: 80X_upgrade2017_design_v0: As 76X_upgrade2017_design_v9 with the following changes:\r\n * added new Hcal record (HcalQIETypesRcd) providing a per-HCAL-readout flag of the FE QIE electronics type\r\n * removed PHcalParametersRcd."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/166011016","html_url":"https://github.com/cms-sw/cmssw/pull/12832#issuecomment-166011016","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12832","id":166011016,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2015-12-19T18:08:56Z","updated_at":"2015-12-19T18:08:56Z","body":"Pull request #12832 was updated. @civanch, @diguida, @ianna, @mdhildreth, @cmsbuild, @franzoni, @Dr15Jones, @cerminar, @ggovi, @mmusich, @davidlange6 can you please check and sign again."}}