{"action":"closed","issue":{"url":"https://api.github.com/repos/NAVADMC/ADSM/issues/503","labels_url":"https://api.github.com/repos/NAVADMC/ADSM/issues/503/labels{/name}","comments_url":"https://api.github.com/repos/NAVADMC/ADSM/issues/503/comments","events_url":"https://api.github.com/repos/NAVADMC/ADSM/issues/503/events","html_url":"https://github.com/NAVADMC/ADSM/issues/503","id":70453760,"number":503,"title":"Population file import:  When file (csv or xml) contains invalid data, data is imported anyway and changed","user":{"login":"casesp","id":6764142,"avatar_url":"https://avatars.githubusercontent.com/u/6764142?v=3","gravatar_id":"","url":"https://api.github.com/users/casesp","html_url":"https://github.com/casesp","followers_url":"https://api.github.com/users/casesp/followers","following_url":"https://api.github.com/users/casesp/following{/other_user}","gists_url":"https://api.github.com/users/casesp/gists{/gist_id}","starred_url":"https://api.github.com/users/casesp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casesp/subscriptions","organizations_url":"https://api.github.com/users/casesp/orgs","repos_url":"https://api.github.com/users/casesp/repos","events_url":"https://api.github.com/users/casesp/events{/privacy}","received_events_url":"https://api.github.com/users/casesp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NAVADMC/ADSM/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/NAVADMC/ADSM/labels/High%20Priority","name":"High Priority","color":"eb6420"},{"url":"https://api.github.com/repos/NAVADMC/ADSM/labels/Triaged","name":"Triaged","color":"5319e7"},{"url":"https://api.github.com/repos/NAVADMC/ADSM/labels/User%20Testing","name":"User Testing","color":"5319e7"}],"state":"closed","locked":false,"assignee":{"login":"boomtown15","id":2192228,"avatar_url":"https://avatars.githubusercontent.com/u/2192228?v=3","gravatar_id":"","url":"https://api.github.com/users/boomtown15","html_url":"https://github.com/boomtown15","followers_url":"https://api.github.com/users/boomtown15/followers","following_url":"https://api.github.com/users/boomtown15/following{/other_user}","gists_url":"https://api.github.com/users/boomtown15/gists{/gist_id}","starred_url":"https://api.github.com/users/boomtown15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boomtown15/subscriptions","organizations_url":"https://api.github.com/users/boomtown15/orgs","repos_url":"https://api.github.com/users/boomtown15/repos","events_url":"https://api.github.com/users/boomtown15/events{/privacy}","received_events_url":"https://api.github.com/users/boomtown15/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/NAVADMC/ADSM/milestones/11","html_url":"https://github.com/NAVADMC/ADSM/milestones/V3.3%20Vaccination%20Improvements","labels_url":"https://api.github.com/repos/NAVADMC/ADSM/milestones/11/labels","id":706884,"number":11,"title":"V3.3 Vaccination Improvements","description":"Features from NAADSM v3.3\r\nIncludes functionality that was worked on during 2013, which is retrospective vaccination, new vaccination triggers, restart vaccination with new capacity,  protective and suppressive rings, additional vaccination prioritization.\r\n\r\nCan determine if we want markets and partial vaccination effects part of this.\r\n\r\nComes from work with DataStreamConnection.\r\nFeatures:\r\nVaccination: Partial, Priorities, Rings,\r\n","creator":{"login":"missyschoenbaum","id":6644604,"avatar_url":"https://avatars.githubusercontent.com/u/6644604?v=3","gravatar_id":"","url":"https://api.github.com/users/missyschoenbaum","html_url":"https://github.com/missyschoenbaum","followers_url":"https://api.github.com/users/missyschoenbaum/followers","following_url":"https://api.github.com/users/missyschoenbaum/following{/other_user}","gists_url":"https://api.github.com/users/missyschoenbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/missyschoenbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/missyschoenbaum/subscriptions","organizations_url":"https://api.github.com/users/missyschoenbaum/orgs","repos_url":"https://api.github.com/users/missyschoenbaum/repos","events_url":"https://api.github.com/users/missyschoenbaum/events{/privacy}","received_events_url":"https://api.github.com/users/missyschoenbaum/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":21,"state":"open","created_at":"2014-07-01T14:20:31Z","updated_at":"2015-07-01T20:12:28Z","due_on":"2015-06-12T06:00:00Z","closed_at":null},"comments":14,"created_at":"2015-04-23T16:24:31Z","updated_at":"2015-07-01T20:12:28Z","closed_at":"2015-07-01T20:12:28Z","body":"[For a quick explanation of this issue, see the **_Results_** section at the bottom of this report]\r\n\r\n**Category:** Population import\r\n**Test Name:** Import population file CSV and XML (with errors)\r\n**Software version:** ADSM 3.2.22-RC6 (2d85671)\r\n**Machine:** Win7ProVMWare11\r\n\r\n**Description**\r\nThis tests the ability to import an existing CSV population/herd file using the current format that ADSM expects (not the one specified by NAADSM 3.2.19).  This test specifically uses a CSV file that contains errors in its data validity to check how the program responds.  This test also attempts to import an XML file meeting the NAADSM 3.2.19 specifications which contains a similar error in the data validity. (Not an XML format error)\r\n\r\n\r\n**Expected Outcomes**\r\nThe program should not successfully merge and/or replace units in the population form with those taken from the CSV or XML file, and should prompt the user with some form of warning or error message.\r\n\r\n\r\n**Steps to run/create this test**\r\n1)  Open ADSM and start a new scenario. \r\n2)  Navigate to the population form \r\n3)  Select the \"choose file\" button and choose the appropriate herd CSV file: \"ADSM Simple Units. with errors.csv\"   (this file has an error value in the status column of \"Q\")\r\n4)  Select import\r\n5)  The program should not successfully import the data, note any anomalies.\r\n6)  Repeat steps 3 through 5 for the file \"ADSM Simply Units.with errors.xml\"\r\n\r\n\r\n**_Results_**\r\nADSM imports the files anyway and gives no indication that the data contained in the file makes no sense. \r\n\r\nIn this particular test case a unit status of \"Q\" was used, but the program imported the file and labeled the affected unit as \"Susceptible\"\r\n\r\nTried the same procedure again using a \"K\" value for status, with same results."}}