{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/36687314","id":36687314,"diff_hunk":"@@ -123,6 +125,13 @@ export function main() {\n                      async.done();\n                      return null;\n                    })}));\n+\n+    it('should throw if a config has a component that is not defined', () => {\n+      expect(() => new Route({path: '/', component: null}))\n+          .toThrowError('Component for route \"/\" is not defined, or is not a class.');\n+      expect(() => new AuxRoute({path: '/', component: undefined}))","path":"modules/angular2/test/router/route_config_spec.ts","position":17,"original_position":17,"commit_id":"f57a55e0b78b102e349294d6f69a86ed6a861605","original_commit_id":"f57a55e0b78b102e349294d6f69a86ed6a861605","user":{"login":"btford","id":474988,"avatar_url":"https://avatars.githubusercontent.com/u/474988?v=3","gravatar_id":"","url":"https://api.github.com/users/btford","html_url":"https://github.com/btford","followers_url":"https://api.github.com/users/btford/followers","following_url":"https://api.github.com/users/btford/following{/other_user}","gists_url":"https://api.github.com/users/btford/gists{/gist_id}","starred_url":"https://api.github.com/users/btford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btford/subscriptions","organizations_url":"https://api.github.com/users/btford/orgs","repos_url":"https://api.github.com/users/btford/repos","events_url":"https://api.github.com/users/btford/events{/privacy}","received_events_url":"https://api.github.com/users/btford/received_events","type":"User","site_admin":false},"body":"I'd like to add another assertion here with the wrong type (for ES5 users), but tsc won't even compile it. Is there a way to test ES5 code a user would write?","created_at":"2015-08-10T21:32:11Z","updated_at":"2015-08-10T21:32:11Z","html_url":"https://github.com/angular/angular/pull/3569#discussion_r36687314","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/3569","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/36687314"},"html":{"href":"https://github.com/angular/angular/pull/3569#discussion_r36687314"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/3569"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/3569","id":42063364,"html_url":"https://github.com/angular/angular/pull/3569","diff_url":"https://github.com/angular/angular/pull/3569.diff","patch_url":"https://github.com/angular/angular/pull/3569.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/3569","number":3569,"state":"open","locked":false,"title":"fix(router): throw when component in route config is not defined","user":{"login":"btford","id":474988,"avatar_url":"https://avatars.githubusercontent.com/u/474988?v=3","gravatar_id":"","url":"https://api.github.com/users/btford","html_url":"https://github.com/btford","followers_url":"https://api.github.com/users/btford/followers","following_url":"https://api.github.com/users/btford/following{/other_user}","gists_url":"https://api.github.com/users/btford/gists{/gist_id}","starred_url":"https://api.github.com/users/btford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btford/subscriptions","organizations_url":"https://api.github.com/users/btford/orgs","repos_url":"https://api.github.com/users/btford/repos","events_url":"https://api.github.com/users/btford/events{/privacy}","received_events_url":"https://api.github.com/users/btford/received_events","type":"User","site_admin":false},"body":"Close #3265","created_at":"2015-08-10T20:38:34Z","updated_at":"2015-08-10T21:32:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7a52657cd2822641b54cd1a5ca88bb64f203080","assignee":{"login":"IgorMinar","id":216296,"avatar_url":"https://avatars.githubusercontent.com/u/216296?v=3","gravatar_id":"","url":"https://api.github.com/users/IgorMinar","html_url":"https://github.com/IgorMinar","followers_url":"https://api.github.com/users/IgorMinar/followers","following_url":"https://api.github.com/users/IgorMinar/following{/other_user}","gists_url":"https://api.github.com/users/IgorMinar/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorMinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorMinar/subscriptions","organizations_url":"https://api.github.com/users/IgorMinar/orgs","repos_url":"https://api.github.com/users/IgorMinar/repos","events_url":"https://api.github.com/users/IgorMinar/events{/privacy}","received_events_url":"https://api.github.com/users/IgorMinar/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/3569/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/3569/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/3569/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/f57a55e0b78b102e349294d6f69a86ed6a861605","head":{"label":"btford:fix-router-undefined-component","ref":"fix-router-undefined-component","sha":"f57a55e0b78b102e349294d6f69a86ed6a861605","user":{"login":"btford","id":474988,"avatar_url":"https://avatars.githubusercontent.com/u/474988?v=3","gravatar_id":"","url":"https://api.github.com/users/btford","html_url":"https://github.com/btford","followers_url":"https://api.github.com/users/btford/followers","following_url":"https://api.github.com/users/btford/following{/other_user}","gists_url":"https://api.github.com/users/btford/gists{/gist_id}","starred_url":"https://api.github.com/users/btford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btford/subscriptions","organizations_url":"https://api.github.com/users/btford/orgs","repos_url":"https://api.github.com/users/btford/repos","events_url":"https://api.github.com/users/btford/events{/privacy}","received_events_url":"https://api.github.com/users/btford/received_events","type":"User","site_admin":false},"repo":{"id":28889554,"name":"angular","full_name":"btford/angular","owner":{"login":"btford","id":474988,"avatar_url":"https://avatars.githubusercontent.com/u/474988?v=3","gravatar_id":"","url":"https://api.github.com/users/btford","html_url":"https://github.com/btford","followers_url":"https://api.github.com/users/btford/followers","following_url":"https://api.github.com/users/btford/following{/other_user}","gists_url":"https://api.github.com/users/btford/gists{/gist_id}","starred_url":"https://api.github.com/users/btford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btford/subscriptions","organizations_url":"https://api.github.com/users/btford/orgs","repos_url":"https://api.github.com/users/btford/repos","events_url":"https://api.github.com/users/btford/events{/privacy}","received_events_url":"https://api.github.com/users/btford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/btford/angular","description":"","fork":true,"url":"https://api.github.com/repos/btford/angular","forks_url":"https://api.github.com/repos/btford/angular/forks","keys_url":"https://api.github.com/repos/btford/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/btford/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/btford/angular/teams","hooks_url":"https://api.github.com/repos/btford/angular/hooks","issue_events_url":"https://api.github.com/repos/btford/angular/issues/events{/number}","events_url":"https://api.github.com/repos/btford/angular/events","assignees_url":"https://api.github.com/repos/btford/angular/assignees{/user}","branches_url":"https://api.github.com/repos/btford/angular/branches{/branch}","tags_url":"https://api.github.com/repos/btford/angular/tags","blobs_url":"https://api.github.com/repos/btford/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/btford/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/btford/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/btford/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/btford/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/btford/angular/languages","stargazers_url":"https://api.github.com/repos/btford/angular/stargazers","contributors_url":"https://api.github.com/repos/btford/angular/contributors","subscribers_url":"https://api.github.com/repos/btford/angular/subscribers","subscription_url":"https://api.github.com/repos/btford/angular/subscription","commits_url":"https://api.github.com/repos/btford/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/btford/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/btford/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/btford/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/btford/angular/contents/{+path}","compare_url":"https://api.github.com/repos/btford/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/btford/angular/merges","archive_url":"https://api.github.com/repos/btford/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/btford/angular/downloads","issues_url":"https://api.github.com/repos/btford/angular/issues{/number}","pulls_url":"https://api.github.com/repos/btford/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/btford/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/btford/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/btford/angular/labels{/name}","releases_url":"https://api.github.com/repos/btford/angular/releases{/id}","created_at":"2015-01-07T00:00:47Z","updated_at":"2015-01-07T00:00:48Z","pushed_at":"2015-08-10T21:30:32Z","git_url":"git://github.com/btford/angular.git","ssh_url":"git@github.com:btford/angular.git","clone_url":"https://github.com/btford/angular.git","svn_url":"https://github.com/btford/angular","homepage":null,"size":12056,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"dfa5103b1d390ee9744548ca4fe08bfa73ce2dd5","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","created_at":"2014-09-18T16:12:01Z","updated_at":"2015-08-10T20:53:21Z","pushed_at":"2015-08-10T21:30:33Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":39157,"stargazers_count":4657,"watchers_count":4657,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1231,"mirror_url":null,"open_issues_count":430,"forks":1231,"open_issues":430,"watchers":4657,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/3569"},"html":{"href":"https://github.com/angular/angular/pull/3569"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/3569"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/3569/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/3569/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/3569/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/f57a55e0b78b102e349294d6f69a86ed6a861605"}}}}