{"action":"created","issue":{"url":"https://api.github.com/repos/documentcloud/documentcloud-pages/issues/32","labels_url":"https://api.github.com/repos/documentcloud/documentcloud-pages/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/documentcloud/documentcloud-pages/issues/32/comments","events_url":"https://api.github.com/repos/documentcloud/documentcloud-pages/issues/32/events","html_url":"https://github.com/documentcloud/documentcloud-pages/issues/32","id":115325645,"number":32,"title":"Revert to original `DC-embed/DC-embed-stub` behavior","user":{"login":"reefdog","id":4731,"avatar_url":"https://avatars.githubusercontent.com/u/4731?v=3","gravatar_id":"","url":"https://api.github.com/users/reefdog","html_url":"https://github.com/reefdog","followers_url":"https://api.github.com/users/reefdog/followers","following_url":"https://api.github.com/users/reefdog/following{/other_user}","gists_url":"https://api.github.com/users/reefdog/gists{/gist_id}","starred_url":"https://api.github.com/users/reefdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reefdog/subscriptions","organizations_url":"https://api.github.com/users/reefdog/orgs","repos_url":"https://api.github.com/users/reefdog/repos","events_url":"https://api.github.com/users/reefdog/events{/privacy}","received_events_url":"https://api.github.com/users/reefdog/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"reefdog","id":4731,"avatar_url":"https://avatars.githubusercontent.com/u/4731?v=3","gravatar_id":"","url":"https://api.github.com/users/reefdog","html_url":"https://github.com/reefdog","followers_url":"https://api.github.com/users/reefdog/followers","following_url":"https://api.github.com/users/reefdog/following{/other_user}","gists_url":"https://api.github.com/users/reefdog/gists{/gist_id}","starred_url":"https://api.github.com/users/reefdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reefdog/subscriptions","organizations_url":"https://api.github.com/users/reefdog/orgs","repos_url":"https://api.github.com/users/reefdog/repos","events_url":"https://api.github.com/users/reefdog/events{/privacy}","received_events_url":"https://api.github.com/users/reefdog/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-11-05T16:48:33Z","updated_at":"2015-11-05T16:54:12Z","closed_at":null,"body":"At first, I had the wizard creating markup whose root element had a class of `DC-embed-stub`, which our `enhance.js` then recomposed into an element with the class `DC-embed`. So `-stub` indicated it needed enhancing, no-`-stub` meant it was enhanced. Following some internal feedback, I made the wizard generate an element with the class `DC-embed` which the enhancer recomposed into `DC-embed-enhanced`. (See 1345ffd6515f5c7c509ad364e91bc693278da640.)\r\n\r\nAfter more thought, I really don't like this and am going to revert to the original model. The whole stub/enhanced thing is an intermediate step on the way to the canonical embed resource markup. It's that final markup that deserves the `DC-embed` class, particularly as we want people to be able to use the embed markup and libraries without using the enhancer.\r\n\r\nThis will break existing embeds from enhancing, but that's why it's beta."},"comment":{"url":"https://api.github.com/repos/documentcloud/documentcloud-pages/issues/comments/154120768","html_url":"https://github.com/documentcloud/documentcloud-pages/issues/32#issuecomment-154120768","issue_url":"https://api.github.com/repos/documentcloud/documentcloud-pages/issues/32","id":154120768,"user":{"login":"knowtheory","id":192,"avatar_url":"https://avatars.githubusercontent.com/u/192?v=3","gravatar_id":"","url":"https://api.github.com/users/knowtheory","html_url":"https://github.com/knowtheory","followers_url":"https://api.github.com/users/knowtheory/followers","following_url":"https://api.github.com/users/knowtheory/following{/other_user}","gists_url":"https://api.github.com/users/knowtheory/gists{/gist_id}","starred_url":"https://api.github.com/users/knowtheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knowtheory/subscriptions","organizations_url":"https://api.github.com/users/knowtheory/orgs","repos_url":"https://api.github.com/users/knowtheory/repos","events_url":"https://api.github.com/users/knowtheory/events{/privacy}","received_events_url":"https://api.github.com/users/knowtheory/received_events","type":"User","site_admin":false},"created_at":"2015-11-05T16:54:12Z","updated_at":"2015-11-05T16:54:12Z","body":"Okay, well lets talk about how the existing embeds behave.\r\n\r\nEssentially, user drops divs into the dom, and then using javascript notifies the app code to find a particular div and use that as the site into which more markup gets dumped.\r\n\r\nWith the enhancer set up, we are establishing a convention that any suitably named divs are sites at which something can happen.\r\n\r\nHow the page-embed code currently behaves differently is that it's relying upon the _site itself_ as a control structure, as opposed to merely the landing place in which something happens."}}