{"action":"closed","number":671,"pull_request":{"url":"https://api.github.com/repos/rwaldron/johnny-five/pulls/671","id":31892047,"html_url":"https://github.com/rwaldron/johnny-five/pull/671","diff_url":"https://github.com/rwaldron/johnny-five/pull/671.diff","patch_url":"https://github.com/rwaldron/johnny-five/pull/671.patch","issue_url":"https://api.github.com/repos/rwaldron/johnny-five/issues/671","number":671,"state":"closed","locked":false,"title":"use environment to declare test mode flag; resolves #669","user":{"login":"boneskull","id":924465,"avatar_url":"https://avatars.githubusercontent.com/u/924465?v=3","gravatar_id":"","url":"https://api.github.com/users/boneskull","html_url":"https://github.com/boneskull","followers_url":"https://api.github.com/users/boneskull/followers","following_url":"https://api.github.com/users/boneskull/following{/other_user}","gists_url":"https://api.github.com/users/boneskull/gists{/gist_id}","starred_url":"https://api.github.com/users/boneskull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boneskull/subscriptions","organizations_url":"https://api.github.com/users/boneskull/orgs","repos_url":"https://api.github.com/users/boneskull/repos","events_url":"https://api.github.com/users/boneskull/events{/privacy}","received_events_url":"https://api.github.com/users/boneskull/received_events","type":"User","site_admin":false},"body":"- Relevant files check `process.env.IS_TEST_MODE` instead of a global prop\r\n- The value of `IS_TEST_MODE` is assumed to be a boolean\r\n- Individual suites do not set `IS_TEST_MODE`\r\n- `bootstrap.js` is no longer necessary and has been removed\r\n- `Gruntfile.js` sets the `IS_TEST_MODE` flag; as long as you run the tests via `npm test` or `grunt`, your environment will be correct.  Otherwise, you must manually set the `IS_TEST_MODE` environment variable.\r\n- simplified test targets within `Gruntfile.js` with globs\r\n- remove `bootstrap.js` reference within `nodeunit:just`; while I was in there, corrected a potential Windows incompatibility, made slightly more flexible, and documented it for use with `grunt --help`\r\n\r\nHappy to remove the changes I snuck into `Gruntfile.js` if you wish.","created_at":"2015-03-25T04:10:13Z","updated_at":"2015-03-30T19:37:47Z","closed_at":"2015-03-30T19:37:47Z","merged_at":"2015-03-30T19:37:47Z","merge_commit_sha":"9bad3fd2de1899d7f6247fd7d310a750b0ff4a96","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rwaldron/johnny-five/pulls/671/commits","review_comments_url":"https://api.github.com/repos/rwaldron/johnny-five/pulls/671/comments","review_comment_url":"https://api.github.com/repos/rwaldron/johnny-five/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rwaldron/johnny-five/issues/671/comments","statuses_url":"https://api.github.com/repos/rwaldron/johnny-five/statuses/15f90e86ca8bbfcb876702adcbb9cbc883e97cfa","head":{"label":"boneskull:issue/669","ref":"issue/669","sha":"15f90e86ca8bbfcb876702adcbb9cbc883e97cfa","user":{"login":"boneskull","id":924465,"avatar_url":"https://avatars.githubusercontent.com/u/924465?v=3","gravatar_id":"","url":"https://api.github.com/users/boneskull","html_url":"https://github.com/boneskull","followers_url":"https://api.github.com/users/boneskull/followers","following_url":"https://api.github.com/users/boneskull/following{/other_user}","gists_url":"https://api.github.com/users/boneskull/gists{/gist_id}","starred_url":"https://api.github.com/users/boneskull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boneskull/subscriptions","organizations_url":"https://api.github.com/users/boneskull/orgs","repos_url":"https://api.github.com/users/boneskull/repos","events_url":"https://api.github.com/users/boneskull/events{/privacy}","received_events_url":"https://api.github.com/users/boneskull/received_events","type":"User","site_admin":false},"repo":{"id":28465978,"name":"johnny-five","full_name":"boneskull/johnny-five","owner":{"login":"boneskull","id":924465,"avatar_url":"https://avatars.githubusercontent.com/u/924465?v=3","gravatar_id":"","url":"https://api.github.com/users/boneskull","html_url":"https://github.com/boneskull","followers_url":"https://api.github.com/users/boneskull/followers","following_url":"https://api.github.com/users/boneskull/following{/other_user}","gists_url":"https://api.github.com/users/boneskull/gists{/gist_id}","starred_url":"https://api.github.com/users/boneskull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boneskull/subscriptions","organizations_url":"https://api.github.com/users/boneskull/orgs","repos_url":"https://api.github.com/users/boneskull/repos","events_url":"https://api.github.com/users/boneskull/events{/privacy}","received_events_url":"https://api.github.com/users/boneskull/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boneskull/johnny-five","description":"An Open Source, IoT and Robotics programming framework, developed at Bocoup.","fork":true,"url":"https://api.github.com/repos/boneskull/johnny-five","forks_url":"https://api.github.com/repos/boneskull/johnny-five/forks","keys_url":"https://api.github.com/repos/boneskull/johnny-five/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boneskull/johnny-five/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boneskull/johnny-five/teams","hooks_url":"https://api.github.com/repos/boneskull/johnny-five/hooks","issue_events_url":"https://api.github.com/repos/boneskull/johnny-five/issues/events{/number}","events_url":"https://api.github.com/repos/boneskull/johnny-five/events","assignees_url":"https://api.github.com/repos/boneskull/johnny-five/assignees{/user}","branches_url":"https://api.github.com/repos/boneskull/johnny-five/branches{/branch}","tags_url":"https://api.github.com/repos/boneskull/johnny-five/tags","blobs_url":"https://api.github.com/repos/boneskull/johnny-five/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boneskull/johnny-five/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boneskull/johnny-five/git/refs{/sha}","trees_url":"https://api.github.com/repos/boneskull/johnny-five/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boneskull/johnny-five/statuses/{sha}","languages_url":"https://api.github.com/repos/boneskull/johnny-five/languages","stargazers_url":"https://api.github.com/repos/boneskull/johnny-five/stargazers","contributors_url":"https://api.github.com/repos/boneskull/johnny-five/contributors","subscribers_url":"https://api.github.com/repos/boneskull/johnny-five/subscribers","subscription_url":"https://api.github.com/repos/boneskull/johnny-five/subscription","commits_url":"https://api.github.com/repos/boneskull/johnny-five/commits{/sha}","git_commits_url":"https://api.github.com/repos/boneskull/johnny-five/git/commits{/sha}","comments_url":"https://api.github.com/repos/boneskull/johnny-five/comments{/number}","issue_comment_url":"https://api.github.com/repos/boneskull/johnny-five/issues/comments{/number}","contents_url":"https://api.github.com/repos/boneskull/johnny-five/contents/{+path}","compare_url":"https://api.github.com/repos/boneskull/johnny-five/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boneskull/johnny-five/merges","archive_url":"https://api.github.com/repos/boneskull/johnny-five/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boneskull/johnny-five/downloads","issues_url":"https://api.github.com/repos/boneskull/johnny-five/issues{/number}","pulls_url":"https://api.github.com/repos/boneskull/johnny-five/pulls{/number}","milestones_url":"https://api.github.com/repos/boneskull/johnny-five/milestones{/number}","notifications_url":"https://api.github.com/repos/boneskull/johnny-five/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boneskull/johnny-five/labels{/name}","releases_url":"https://api.github.com/repos/boneskull/johnny-five/releases{/id}","created_at":"2014-12-25T00:49:31Z","updated_at":"2015-03-24T21:45:54Z","pushed_at":"2015-03-25T04:37:10Z","git_url":"git://github.com/boneskull/johnny-five.git","ssh_url":"git@github.com:boneskull/johnny-five.git","clone_url":"https://github.com/boneskull/johnny-five.git","svn_url":"https://github.com/boneskull/johnny-five","homepage":"","size":36966,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rwaldron:master","ref":"master","sha":"566a2a7fc9301da7e40a1d6ae288e00220cbe0e9","user":{"login":"rwaldron","id":27985,"avatar_url":"https://avatars.githubusercontent.com/u/27985?v=3","gravatar_id":"","url":"https://api.github.com/users/rwaldron","html_url":"https://github.com/rwaldron","followers_url":"https://api.github.com/users/rwaldron/followers","following_url":"https://api.github.com/users/rwaldron/following{/other_user}","gists_url":"https://api.github.com/users/rwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaldron/subscriptions","organizations_url":"https://api.github.com/users/rwaldron/orgs","repos_url":"https://api.github.com/users/rwaldron/repos","events_url":"https://api.github.com/users/rwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/rwaldron/received_events","type":"User","site_admin":false},"repo":{"id":3880513,"name":"johnny-five","full_name":"rwaldron/johnny-five","owner":{"login":"rwaldron","id":27985,"avatar_url":"https://avatars.githubusercontent.com/u/27985?v=3","gravatar_id":"","url":"https://api.github.com/users/rwaldron","html_url":"https://github.com/rwaldron","followers_url":"https://api.github.com/users/rwaldron/followers","following_url":"https://api.github.com/users/rwaldron/following{/other_user}","gists_url":"https://api.github.com/users/rwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaldron/subscriptions","organizations_url":"https://api.github.com/users/rwaldron/orgs","repos_url":"https://api.github.com/users/rwaldron/repos","events_url":"https://api.github.com/users/rwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/rwaldron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwaldron/johnny-five","description":"JavaScript Robotics and IoT programming framework, developed at Bocoup. Based on Arduino Firmata Protocol","fork":false,"url":"https://api.github.com/repos/rwaldron/johnny-five","forks_url":"https://api.github.com/repos/rwaldron/johnny-five/forks","keys_url":"https://api.github.com/repos/rwaldron/johnny-five/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwaldron/johnny-five/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwaldron/johnny-five/teams","hooks_url":"https://api.github.com/repos/rwaldron/johnny-five/hooks","issue_events_url":"https://api.github.com/repos/rwaldron/johnny-five/issues/events{/number}","events_url":"https://api.github.com/repos/rwaldron/johnny-five/events","assignees_url":"https://api.github.com/repos/rwaldron/johnny-five/assignees{/user}","branches_url":"https://api.github.com/repos/rwaldron/johnny-five/branches{/branch}","tags_url":"https://api.github.com/repos/rwaldron/johnny-five/tags","blobs_url":"https://api.github.com/repos/rwaldron/johnny-five/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwaldron/johnny-five/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwaldron/johnny-five/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwaldron/johnny-five/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwaldron/johnny-five/statuses/{sha}","languages_url":"https://api.github.com/repos/rwaldron/johnny-five/languages","stargazers_url":"https://api.github.com/repos/rwaldron/johnny-five/stargazers","contributors_url":"https://api.github.com/repos/rwaldron/johnny-five/contributors","subscribers_url":"https://api.github.com/repos/rwaldron/johnny-five/subscribers","subscription_url":"https://api.github.com/repos/rwaldron/johnny-five/subscription","commits_url":"https://api.github.com/repos/rwaldron/johnny-five/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwaldron/johnny-five/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwaldron/johnny-five/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwaldron/johnny-five/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwaldron/johnny-five/contents/{+path}","compare_url":"https://api.github.com/repos/rwaldron/johnny-five/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwaldron/johnny-five/merges","archive_url":"https://api.github.com/repos/rwaldron/johnny-five/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwaldron/johnny-five/downloads","issues_url":"https://api.github.com/repos/rwaldron/johnny-five/issues{/number}","pulls_url":"https://api.github.com/repos/rwaldron/johnny-five/pulls{/number}","milestones_url":"https://api.github.com/repos/rwaldron/johnny-five/milestones{/number}","notifications_url":"https://api.github.com/repos/rwaldron/johnny-five/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwaldron/johnny-five/labels{/name}","releases_url":"https://api.github.com/repos/rwaldron/johnny-five/releases{/id}","created_at":"2012-03-30T20:09:52Z","updated_at":"2015-03-30T19:37:47Z","pushed_at":"2015-03-30T19:37:46Z","git_url":"git://github.com/rwaldron/johnny-five.git","ssh_url":"git@github.com:rwaldron/johnny-five.git","clone_url":"https://github.com/rwaldron/johnny-five.git","svn_url":"https://github.com/rwaldron/johnny-five","homepage":"","size":43701,"stargazers_count":3402,"watchers_count":3402,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":434,"mirror_url":null,"open_issues_count":103,"forks":434,"open_issues":103,"watchers":3402,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rwaldron/johnny-five/pulls/671"},"html":{"href":"https://github.com/rwaldron/johnny-five/pull/671"},"issue":{"href":"https://api.github.com/repos/rwaldron/johnny-five/issues/671"},"comments":{"href":"https://api.github.com/repos/rwaldron/johnny-five/issues/671/comments"},"review_comments":{"href":"https://api.github.com/repos/rwaldron/johnny-five/pulls/671/comments"},"review_comment":{"href":"https://api.github.com/repos/rwaldron/johnny-five/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rwaldron/johnny-five/pulls/671/commits"},"statuses":{"href":"https://api.github.com/repos/rwaldron/johnny-five/statuses/15f90e86ca8bbfcb876702adcbb9cbc883e97cfa"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rwaldron","id":27985,"avatar_url":"https://avatars.githubusercontent.com/u/27985?v=3","gravatar_id":"","url":"https://api.github.com/users/rwaldron","html_url":"https://github.com/rwaldron","followers_url":"https://api.github.com/users/rwaldron/followers","following_url":"https://api.github.com/users/rwaldron/following{/other_user}","gists_url":"https://api.github.com/users/rwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaldron/subscriptions","organizations_url":"https://api.github.com/users/rwaldron/orgs","repos_url":"https://api.github.com/users/rwaldron/repos","events_url":"https://api.github.com/users/rwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/rwaldron/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"commits":1,"additions":12,"deletions":51,"changed_files":11}}