{"action":"created","issue":{"url":"https://api.github.com/repos/OCA/l10n-brazil/issues/250","labels_url":"https://api.github.com/repos/OCA/l10n-brazil/issues/250/labels{/name}","comments_url":"https://api.github.com/repos/OCA/l10n-brazil/issues/250/comments","events_url":"https://api.github.com/repos/OCA/l10n-brazil/issues/250/events","html_url":"https://github.com/OCA/l10n-brazil/pull/250","id":120608652,"number":250,"title":"[TODO] Migration scripts odoo-brazil to oca","user":{"login":"mileo","id":1975978,"avatar_url":"https://avatars.githubusercontent.com/u/1975978?v=3","gravatar_id":"","url":"https://api.github.com/users/mileo","html_url":"https://github.com/mileo","followers_url":"https://api.github.com/users/mileo/followers","following_url":"https://api.github.com/users/mileo/following{/other_user}","gists_url":"https://api.github.com/users/mileo/gists{/gist_id}","starred_url":"https://api.github.com/users/mileo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mileo/subscriptions","organizations_url":"https://api.github.com/users/mileo/orgs","repos_url":"https://api.github.com/users/mileo/repos","events_url":"https://api.github.com/users/mileo/events{/privacy}","received_events_url":"https://api.github.com/users/mileo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-12-06T05:16:37Z","updated_at":"2015-12-07T17:35:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OCA/l10n-brazil/pulls/250","html_url":"https://github.com/OCA/l10n-brazil/pull/250","diff_url":"https://github.com/OCA/l10n-brazil/pull/250.diff","patch_url":"https://github.com/OCA/l10n-brazil/pull/250.patch"},"body":"Hi,\r\n\r\nI performed a database analysis using https://github.com/OCA/OpenUpgrade\r\n\r\nAs i said in other topics we have this migrations issues, because the migration divergences with @akretion and other contributors with this fork: https://github.com/odoo-brazil/l10n-brazil/\r\n\r\nAnd in the end of the year we have a big issue, with the amendments as are required by the government in product invoicing:\r\n\r\nNota Técnica 2015.003 - v 1.40: ICMS em Operações Interestaduais de Vendas a Consumidor Final\r\nhttp://www.nfe.fazenda.gov.br/portal/exibirArquivo.aspx?conteudo=yldA7bYcnVg=\r\n\r\nI will work in the next days NT2015/003, I request that PSCs can work in this migration to don't stop product invoicing in any Community Odoo user.\r\n\r\nBest regards\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/OCA/l10n-brazil/issues/comments/162602201","html_url":"https://github.com/OCA/l10n-brazil/pull/250#issuecomment-162602201","issue_url":"https://api.github.com/repos/OCA/l10n-brazil/issues/250","id":162602201,"user":{"login":"renatonlima","id":211005,"avatar_url":"https://avatars.githubusercontent.com/u/211005?v=3","gravatar_id":"","url":"https://api.github.com/users/renatonlima","html_url":"https://github.com/renatonlima","followers_url":"https://api.github.com/users/renatonlima/followers","following_url":"https://api.github.com/users/renatonlima/following{/other_user}","gists_url":"https://api.github.com/users/renatonlima/gists{/gist_id}","starred_url":"https://api.github.com/users/renatonlima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renatonlima/subscriptions","organizations_url":"https://api.github.com/users/renatonlima/orgs","repos_url":"https://api.github.com/users/renatonlima/repos","events_url":"https://api.github.com/users/renatonlima/events{/privacy}","received_events_url":"https://api.github.com/users/renatonlima/received_events","type":"User","site_admin":false},"created_at":"2015-12-07T17:35:56Z","updated_at":"2015-12-07T17:35:56Z","body":"Hello guys,\r\n\r\n\r\n@mileo, @danimaribeiro, the main changes of migration that are in the report that you mentioned I had already reported here https://github.com/OCA/l10n-brazil/blob/8.0/l10n_br_account_product/migrations/8.0.2.0.0/pre-migration.py, I can do this script without problems.\r\n\r\nBut it is important to remember, I as project PSC took much of the work and responsibility in sync branches OCA / 8.0 and contributions made in Odoo-Brazil / 8.0 fork. As most of the work on migrating for the new API, because the fork Odoo-Brazil / 8.0 little was migrated for the new API, most of the major files still uses the old API:\r\n\r\nOdoo-Brazil / 8.0 - https://github.com/odoo-brazil/l10n-brazil/blob/8.0/l10n_br_account_product/account_invoice.py\r\nOCA / 8.0 - https://github.com/OCA/l10n-brazil/blob/8.0/l10n_br_account_product/models/account_invoice.py\r\n\r\nOdoo-Brazil / 8.0 - https://github.com/odoo-brazil/l10n-brazil/blob/8.0/l10n_br_account_product/l10n_br_account_product.py\r\nOCA / 8.0 - https://github.com/OCA/l10n-brazil/blob/8.0/l10n_br_account_product/models/l10n_br_account_product.py\r\n\r\nOdoo-Brazil / 8.0 - https://github.com/odoo-brazil/l10n-brazil/blob/8.0/l10n_br_sale_product/sale.py\r\nOCA / 8.0 - https://github.com/OCA/l10n-brazil/blob/8.0/l10n_br_sale_product/models/sale.py\r\n\r\nIt's just a comparison so you can see what has been done extensive work to migrate and improve code quality and this will greatly help us in migrating from version 9.0.\r\n\r\nTo support the migration process and the quality of the project I created tests in the modules of the location and we went from 47% to 64% of coverage.\r\n\r\nI did a thorough analysis of your work analyzing 2 months ago analyzing all PRs made in Odoo-Brazil / 8.0 and organized all PRs:\r\n\r\nhttps://github.com/OCA/l10n-brazil/issues?q=is%3Aissue+is%3Aopen+migration+label%3A8.0\r\n\r\nSome PRs we integrated the OCA / 8.0 others are open as you can see on the above link.\r\n\r\nNo one was busier and more than I worked in the migration process and timing of contributions and did it not to impact and work for other contributors.\r\n\r\nI do not see the migration scripts as a big problem, I guarantee you that if the teams Aketion, Kmee Trust Code and make a sprint for one day can eliminate this with little effort for everyone.\r\n\r\nI do not consider fair after all work that had to appreciate your work and integrate them into the OCA / 8.0 and organize each PR, you do not want to have minimal effort to help synchronize the PRs and generate part of the migration script, as I said I can do this part https://github.com/OCA/l10n-brazil/blob/8.0/l10n_br_account_product/migrations/8.0.2.0.0/pre-migration.py\r\n\r\n@mileo you said you are busy lot working in the NT and edoc (The CNAB are new modules that have no impact on l10n_br_core, right?), I'm too busy, I see that this is a problem because we are not working together, I could work on it as well as in other work with greater synergy in the project.\r\n\r\nMy suggestion is:\r\n\r\n1. I do the scripts of the major changes: https://github.com/OCA/l10n-brazil/blob/8.0/l10n_br_account_product/migrations/8.0.2.0.0/pre-migration.py;\r\n\r\n2. You and @danimaribeiro make the scripts of the remaining modules;\r\n\r\n3. I help and work in the development, testing and approval of NT and refactoring of electronic fiscal documents (edoc);\r\n\r\nThis is the best way to work together and take advantage of synergies of our works and contributions. This will also help us to maintain the project since it will not have to work on more than one repo."}}