{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/facebook-android-sdk/pulls/comments/42079727","id":42079727,"diff_hunk":"@@ -606,11 +606,15 @@ public static GraphRequest newCustomAudienceThirdPartyIdRequest(AccessToken acce\n         if (accessToken == null) {\n             // Only use the attributionID if we don't have an access token.  If we do, then the user\n             // token will be used to identify the user, and is more reliable than the attributionID.\n-            String udid = attributionIdentifiers.getAttributionId() != null\n-                    ? attributionIdentifiers.getAttributionId()\n-                    : attributionIdentifiers.getAndroidAdvertiserId();\n-            if (attributionIdentifiers.getAttributionId() != null) {\n-                parameters.putString(\"udid\", udid);\n+            try {\n+                String udid = attributionIdentifiers.getAttributionId() != null\n+                        ? attributionIdentifiers.getAttributionId()\n+                        : attributionIdentifiers.getAndroidAdvertiserId();\n+                if (attributionIdentifiers.getAttributionId() != null) {\n+                    parameters.putString(\"udid\", udid);\n+                }\n+            } catch (NullPointerException e) {","path":"facebook/src/com/facebook/GraphRequest.java","position":16,"original_position":16,"commit_id":"cd92da09168ed9609c2671768ffe59b645737da1","original_commit_id":"cd92da09168ed9609c2671768ffe59b645737da1","user":{"login":"gcaglar","id":1829381,"avatar_url":"https://avatars.githubusercontent.com/u/1829381?v=3","gravatar_id":"","url":"https://api.github.com/users/gcaglar","html_url":"https://github.com/gcaglar","followers_url":"https://api.github.com/users/gcaglar/followers","following_url":"https://api.github.com/users/gcaglar/following{/other_user}","gists_url":"https://api.github.com/users/gcaglar/gists{/gist_id}","starred_url":"https://api.github.com/users/gcaglar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcaglar/subscriptions","organizations_url":"https://api.github.com/users/gcaglar/orgs","repos_url":"https://api.github.com/users/gcaglar/repos","events_url":"https://api.github.com/users/gcaglar/events{/privacy}","received_events_url":"https://api.github.com/users/gcaglar/received_events","type":"User","site_admin":false},"body":"Please check that attributionIdentifiers is not null rather than catching NPE. Also attributionIdentifiers is used on 625 as well.","created_at":"2015-10-15T03:14:11Z","updated_at":"2015-10-15T03:14:11Z","html_url":"https://github.com/facebook/facebook-android-sdk/pull/447#discussion_r42079727","pull_request_url":"https://api.github.com/repos/facebook/facebook-android-sdk/pulls/447","_links":{"self":{"href":"https://api.github.com/repos/facebook/facebook-android-sdk/pulls/comments/42079727"},"html":{"href":"https://github.com/facebook/facebook-android-sdk/pull/447#discussion_r42079727"},"pull_request":{"href":"https://api.github.com/repos/facebook/facebook-android-sdk/pulls/447"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/facebook-android-sdk/pulls/447","id":47723822,"html_url":"https://github.com/facebook/facebook-android-sdk/pull/447","diff_url":"https://github.com/facebook/facebook-android-sdk/pull/447.diff","patch_url":"https://github.com/facebook/facebook-android-sdk/pull/447.patch","issue_url":"https://api.github.com/repos/facebook/facebook-android-sdk/issues/447","number":447,"state":"open","locked":false,"title":"Add try/catch for NullPointerException, as this attempt to populate...","user":{"login":"vinceis1337","id":5994871,"avatar_url":"https://avatars.githubusercontent.com/u/5994871?v=3","gravatar_id":"","url":"https://api.github.com/users/vinceis1337","html_url":"https://github.com/vinceis1337","followers_url":"https://api.github.com/users/vinceis1337/followers","following_url":"https://api.github.com/users/vinceis1337/following{/other_user}","gists_url":"https://api.github.com/users/vinceis1337/gists{/gist_id}","starred_url":"https://api.github.com/users/vinceis1337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinceis1337/subscriptions","organizations_url":"https://api.github.com/users/vinceis1337/orgs","repos_url":"https://api.github.com/users/vinceis1337/repos","events_url":"https://api.github.com/users/vinceis1337/events{/privacy}","received_events_url":"https://api.github.com/users/vinceis1337/received_events","type":"User","site_admin":false},"body":"…udid is causing NPE crashes\r\n\r\n<img width=\"720\" alt=\"screen shot 2015-10-14 at 5 27 06 pm\" src=\"https://cloud.githubusercontent.com/assets/5994871/10499840/e083c91c-7298-11e5-8ebe-a42529dd5909.png\">","created_at":"2015-10-14T22:33:05Z","updated_at":"2015-10-15T03:14:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dd0b4d9ad46124044d6474cac33010eae154fd8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/facebook-android-sdk/pulls/447/commits","review_comments_url":"https://api.github.com/repos/facebook/facebook-android-sdk/pulls/447/comments","review_comment_url":"https://api.github.com/repos/facebook/facebook-android-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/facebook-android-sdk/issues/447/comments","statuses_url":"https://api.github.com/repos/facebook/facebook-android-sdk/statuses/cd92da09168ed9609c2671768ffe59b645737da1","head":{"label":"vinceis1337:dev","ref":"dev","sha":"cd92da09168ed9609c2671768ffe59b645737da1","user":{"login":"vinceis1337","id":5994871,"avatar_url":"https://avatars.githubusercontent.com/u/5994871?v=3","gravatar_id":"","url":"https://api.github.com/users/vinceis1337","html_url":"https://github.com/vinceis1337","followers_url":"https://api.github.com/users/vinceis1337/followers","following_url":"https://api.github.com/users/vinceis1337/following{/other_user}","gists_url":"https://api.github.com/users/vinceis1337/gists{/gist_id}","starred_url":"https://api.github.com/users/vinceis1337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinceis1337/subscriptions","organizations_url":"https://api.github.com/users/vinceis1337/orgs","repos_url":"https://api.github.com/users/vinceis1337/repos","events_url":"https://api.github.com/users/vinceis1337/events{/privacy}","received_events_url":"https://api.github.com/users/vinceis1337/received_events","type":"User","site_admin":false},"repo":{"id":41886875,"name":"facebook-android-sdk","full_name":"vinceis1337/facebook-android-sdk","owner":{"login":"vinceis1337","id":5994871,"avatar_url":"https://avatars.githubusercontent.com/u/5994871?v=3","gravatar_id":"","url":"https://api.github.com/users/vinceis1337","html_url":"https://github.com/vinceis1337","followers_url":"https://api.github.com/users/vinceis1337/followers","following_url":"https://api.github.com/users/vinceis1337/following{/other_user}","gists_url":"https://api.github.com/users/vinceis1337/gists{/gist_id}","starred_url":"https://api.github.com/users/vinceis1337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinceis1337/subscriptions","organizations_url":"https://api.github.com/users/vinceis1337/orgs","repos_url":"https://api.github.com/users/vinceis1337/repos","events_url":"https://api.github.com/users/vinceis1337/events{/privacy}","received_events_url":"https://api.github.com/users/vinceis1337/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vinceis1337/facebook-android-sdk","description":"Used to integrate Android apps with Facebook Platform.","fork":true,"url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk","forks_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/forks","keys_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/teams","hooks_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/events","assignees_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/tags","blobs_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/languages","stargazers_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/subscription","commits_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/merges","archive_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/downloads","issues_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/vinceis1337/facebook-android-sdk/releases{/id}","created_at":"2015-09-03T22:29:41Z","updated_at":"2015-09-03T22:29:42Z","pushed_at":"2015-10-14T22:43:45Z","git_url":"git://github.com/vinceis1337/facebook-android-sdk.git","ssh_url":"git@github.com:vinceis1337/facebook-android-sdk.git","clone_url":"https://github.com/vinceis1337/facebook-android-sdk.git","svn_url":"https://github.com/vinceis1337/facebook-android-sdk","homepage":"https://developers.facebook.com/docs/android","size":13327,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:dev","ref":"dev","sha":"8bbc56c806639a5301401011bb3db7ccf3582763","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":659341,"name":"facebook-android-sdk","full_name":"facebook/facebook-android-sdk","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/facebook-android-sdk","description":"Used to integrate Android apps with Facebook Platform.","fork":false,"url":"https://api.github.com/repos/facebook/facebook-android-sdk","forks_url":"https://api.github.com/repos/facebook/facebook-android-sdk/forks","keys_url":"https://api.github.com/repos/facebook/facebook-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/facebook-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/facebook-android-sdk/teams","hooks_url":"https://api.github.com/repos/facebook/facebook-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/facebook/facebook-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/facebook-android-sdk/events","assignees_url":"https://api.github.com/repos/facebook/facebook-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/facebook-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/facebook-android-sdk/tags","blobs_url":"https://api.github.com/repos/facebook/facebook-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/facebook-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/facebook-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/facebook-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/facebook-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/facebook-android-sdk/languages","stargazers_url":"https://api.github.com/repos/facebook/facebook-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/facebook/facebook-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/facebook/facebook-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/facebook/facebook-android-sdk/subscription","commits_url":"https://api.github.com/repos/facebook/facebook-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/facebook-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/facebook-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/facebook-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/facebook-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/facebook-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/facebook-android-sdk/merges","archive_url":"https://api.github.com/repos/facebook/facebook-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/facebook-android-sdk/downloads","issues_url":"https://api.github.com/repos/facebook/facebook-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/facebook-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/facebook-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/facebook-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/facebook-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/facebook/facebook-android-sdk/releases{/id}","created_at":"2010-05-10T17:17:33Z","updated_at":"2015-10-14T19:14:15Z","pushed_at":"2015-10-14T22:43:46Z","git_url":"git://github.com/facebook/facebook-android-sdk.git","ssh_url":"git@github.com:facebook/facebook-android-sdk.git","clone_url":"https://github.com/facebook/facebook-android-sdk.git","svn_url":"https://github.com/facebook/facebook-android-sdk","homepage":"https://developers.facebook.com/docs/android","size":20553,"stargazers_count":3485,"watchers_count":3485,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2058,"mirror_url":null,"open_issues_count":1,"forks":2058,"open_issues":1,"watchers":3485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/facebook-android-sdk/pulls/447"},"html":{"href":"https://github.com/facebook/facebook-android-sdk/pull/447"},"issue":{"href":"https://api.github.com/repos/facebook/facebook-android-sdk/issues/447"},"comments":{"href":"https://api.github.com/repos/facebook/facebook-android-sdk/issues/447/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/facebook-android-sdk/pulls/447/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/facebook-android-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/facebook-android-sdk/pulls/447/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/facebook-android-sdk/statuses/cd92da09168ed9609c2671768ffe59b645737da1"}}}}