{"action":"created","issue":{"url":"https://api.github.com/repos/ligershark/side-waffle/issues/225","labels_url":"https://api.github.com/repos/ligershark/side-waffle/issues/225/labels{/name}","comments_url":"https://api.github.com/repos/ligershark/side-waffle/issues/225/comments","events_url":"https://api.github.com/repos/ligershark/side-waffle/issues/225/events","html_url":"https://github.com/ligershark/side-waffle/pull/225","id":57728711,"number":225,"title":"Typescript AngularJS templates updated to be Typescript 1.0 and Angular 1.3 compatible...","user":{"login":"RobHudson72","id":6771876,"avatar_url":"https://avatars.githubusercontent.com/u/6771876?v=3","gravatar_id":"","url":"https://api.github.com/users/RobHudson72","html_url":"https://github.com/RobHudson72","followers_url":"https://api.github.com/users/RobHudson72/followers","following_url":"https://api.github.com/users/RobHudson72/following{/other_user}","gists_url":"https://api.github.com/users/RobHudson72/gists{/gist_id}","starred_url":"https://api.github.com/users/RobHudson72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobHudson72/subscriptions","organizations_url":"https://api.github.com/users/RobHudson72/orgs","repos_url":"https://api.github.com/users/RobHudson72/repos","events_url":"https://api.github.com/users/RobHudson72/events{/privacy}","received_events_url":"https://api.github.com/users/RobHudson72/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-02-15T12:29:02Z","updated_at":"2015-02-18T23:48:28Z","closed_at":"2015-02-16T16:37:09Z","pull_request":{"url":"https://api.github.com/repos/ligershark/side-waffle/pulls/225","html_url":"https://github.com/ligershark/side-waffle/pull/225","diff_url":"https://github.com/ligershark/side-waffle/pull/225.diff","patch_url":"https://github.com/ligershark/side-waffle/pull/225.patch"},"body":"*  Controller templates:  changed to be implemented as functions rather\r\nthan classes; removed controllerId variable\r\n*  Factory Template:  serviceId variable was removed from the interface\r\ndefinition, since it is a static member of the class\r\n*  Directive Template:  directiveId variable was removed from the\r\ninterface definition, since it is a static member of the class\r\n\r\nThis is my first ever PR.  Feel free to chastise me if I did anything wrong.  A couple of quick notes:\r\n\r\n1)  Since I don't often work with directories or factories, I don't know if Angular 1.3 requires that those templates be converted to functions as well.  If so, it's a quick change, but feedback from Mads or JohnPapa would be helpful..\r\n2)  My version of VS won't open the template project.  As a result, I wasn't able to compile and test it.  It went over the files three times, and I don't see any typos or errors."},"comment":{"url":"https://api.github.com/repos/ligershark/side-waffle/issues/comments/74973998","html_url":"https://github.com/ligershark/side-waffle/pull/225#issuecomment-74973998","issue_url":"https://api.github.com/repos/ligershark/side-waffle/issues/225","id":74973998,"user":{"login":"sayedihashimi","id":1283154,"avatar_url":"https://avatars.githubusercontent.com/u/1283154?v=3","gravatar_id":"","url":"https://api.github.com/users/sayedihashimi","html_url":"https://github.com/sayedihashimi","followers_url":"https://api.github.com/users/sayedihashimi/followers","following_url":"https://api.github.com/users/sayedihashimi/following{/other_user}","gists_url":"https://api.github.com/users/sayedihashimi/gists{/gist_id}","starred_url":"https://api.github.com/users/sayedihashimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayedihashimi/subscriptions","organizations_url":"https://api.github.com/users/sayedihashimi/orgs","repos_url":"https://api.github.com/users/sayedihashimi/repos","events_url":"https://api.github.com/users/sayedihashimi/events{/privacy}","received_events_url":"https://api.github.com/users/sayedihashimi/received_events","type":"User","site_admin":false},"created_at":"2015-02-18T23:48:28Z","updated_at":"2015-02-18T23:48:28Z","body":"@RobHudson72 thanks for the PR.\r\n\r\nFYI we have added a release notes file at https://github.com/ligershark/side-waffle/blob/master/release-notes.html. I've added an entry for your changes there. Going forward please include the release notes update in the PR as well."}}