{"action":"created","issue":{"url":"https://api.github.com/repos/duojs/eslint-config/issues/1","labels_url":"https://api.github.com/repos/duojs/eslint-config/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/duojs/eslint-config/issues/1/comments","events_url":"https://api.github.com/repos/duojs/eslint-config/issues/1/events","html_url":"https://github.com/duojs/eslint-config/pull/1","id":93177093,"number":1,"title":"Adding some rules regarding spacing","user":{"login":"dominicbarnes","id":160197,"avatar_url":"https://avatars.githubusercontent.com/u/160197?v=3","gravatar_id":"","url":"https://api.github.com/users/dominicbarnes","html_url":"https://github.com/dominicbarnes","followers_url":"https://api.github.com/users/dominicbarnes/followers","following_url":"https://api.github.com/users/dominicbarnes/following{/other_user}","gists_url":"https://api.github.com/users/dominicbarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/dominicbarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominicbarnes/subscriptions","organizations_url":"https://api.github.com/users/dominicbarnes/orgs","repos_url":"https://api.github.com/users/dominicbarnes/repos","events_url":"https://api.github.com/users/dominicbarnes/events{/privacy}","received_events_url":"https://api.github.com/users/dominicbarnes/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-06T03:18:49Z","updated_at":"2015-07-15T16:18:52Z","closed_at":"2015-07-11T07:18:54Z","pull_request":{"url":"https://api.github.com/repos/duojs/eslint-config/pulls/1","html_url":"https://github.com/duojs/eslint-config/pull/1","diff_url":"https://github.com/duojs/eslint-config/pull/1.diff","patch_url":"https://github.com/duojs/eslint-config/pull/1.patch"},"body":"I've added the following rules to specifically address the spacing for `duojs` code. I'm open to changes here, but here are links to all the relevant rules:\r\n\r\n * [generator-star-spacing](http://eslint.org/docs/rules/generator-star-spacing)\r\n * [space-after-keywords](http://eslint.org/docs/rules/space-after-keywords)\r\n * [space-before-blocks](http://eslint.org/docs/rules/space-before-blocks)\r\n * [space-before-function-paren](http://eslint.org/docs/rules/space-before-function-paren)\r\n * [space-in-parens](http://eslint.org/docs/rules/space-in-parens)\r\n * [space-infix-ops](http://eslint.org/docs/rules/space-infix-ops)\r\n * [space-return-throw-case](http://eslint.org/docs/rules/space-return-throw-case)\r\n * [space-unary-ops](http://eslint.org/docs/rules/space-unary-ops)\r\n\r\nI've made them errors (which will cause CI to fail) since changing them will not affect how the code itself runs. (so we aren't forced to make logical changes in order to pass)"},"comment":{"url":"https://api.github.com/repos/duojs/eslint-config/issues/comments/121666587","html_url":"https://github.com/duojs/eslint-config/pull/1#issuecomment-121666587","issue_url":"https://api.github.com/repos/duojs/eslint-config/issues/1","id":121666587,"user":{"login":"dominicbarnes","id":160197,"avatar_url":"https://avatars.githubusercontent.com/u/160197?v=3","gravatar_id":"","url":"https://api.github.com/users/dominicbarnes","html_url":"https://github.com/dominicbarnes","followers_url":"https://api.github.com/users/dominicbarnes/followers","following_url":"https://api.github.com/users/dominicbarnes/following{/other_user}","gists_url":"https://api.github.com/users/dominicbarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/dominicbarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominicbarnes/subscriptions","organizations_url":"https://api.github.com/users/dominicbarnes/orgs","repos_url":"https://api.github.com/users/dominicbarnes/repos","events_url":"https://api.github.com/users/dominicbarnes/events{/privacy}","received_events_url":"https://api.github.com/users/dominicbarnes/received_events","type":"User","site_admin":false},"created_at":"2015-07-15T16:18:52Z","updated_at":"2015-07-15T16:18:52Z","body":"Yeah, I'm open to changes there @stephenmathieson.\r\n\r\nI'd like to enforce something consistently though, right now anonymous functions are \"always\" and named functions are \"never\". I presume you want to treat them all the same, so is your preference \"always\" or \"never\"?"}}