{"action":"created","issue":{"url":"https://api.github.com/repos/fkanehiro/hrpsys-base/issues/404","labels_url":"https://api.github.com/repos/fkanehiro/hrpsys-base/issues/404/labels{/name}","comments_url":"https://api.github.com/repos/fkanehiro/hrpsys-base/issues/404/comments","events_url":"https://api.github.com/repos/fkanehiro/hrpsys-base/issues/404/events","html_url":"https://github.com/fkanehiro/hrpsys-base/issues/404","id":48578923,"number":404,"title":"writeDigitalOutputWithMask often returns true on simulation","user":{"login":"130s","id":1840401,"avatar_url":"https://avatars.githubusercontent.com/u/1840401?v=3","gravatar_id":"","url":"https://api.github.com/users/130s","html_url":"https://github.com/130s","followers_url":"https://api.github.com/users/130s/followers","following_url":"https://api.github.com/users/130s/following{/other_user}","gists_url":"https://api.github.com/users/130s/gists{/gist_id}","starred_url":"https://api.github.com/users/130s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/130s/subscriptions","organizations_url":"https://api.github.com/users/130s/orgs","repos_url":"https://api.github.com/users/130s/repos","events_url":"https://api.github.com/users/130s/events{/privacy}","received_events_url":"https://api.github.com/users/130s/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2014-11-12T23:41:48Z","updated_at":"2015-03-14T07:52:19Z","closed_at":"2015-03-14T02:21:59Z","body":"`writeDigitalOutputWithMask` は，(API doc 等はっきり書かれてないように思いますが) DIO ハードウェアが無ければここは必ず False が返って来て欲しい所だと思っていますが，何らかの条件で True が帰ってくることがあるようです．\r\n\r\nhttps://github.com/fkanehiro/hrpsys-base/blob/525ac450a01e5485960cf13911879ce2ccfd6266/rtc/RobotHardware/RobotHardwareService_impl.cpp#L138\r\n\r\n```\r\nCORBA::Boolean RobotHardwareService_impl::writeDigitalOutputWithMask(const ::OpenHRP::RobotHardwareService::OctSequence& dout, const ::OpenHRP::RobotHardwareService::OctSequence& mask)\r\n{\r\nreturn m_robot->writeDigitalOutputWithMask((const char *)(dout.get_buffer()), (const char *)(mask.get_buffer()));\r\n}\r\n```\r\n\r\n例えば下流の travis で，https://travis-ci.org/tork-a/rtmros_nextage/jobs/40760573#L3096\r\n\r\n```\r\nTrue is not false\r\nFile \"/usr/lib/python2.7/unittest/case.py\", line 327, in run\r\ntestMethod()\r\nFile \"/home/travis/ros/ws_rtmros_nextage/install/share/nextage_ros_bridge/test/test_handlight.py\", line 106, in test_handlight_l_04\r\nself.assertFalse(result)\r\nFile \"/usr/lib/python2.7/unittest/case.py\", line 414, in assertFalse\r\nraise self.failureException(msg)\r\n```\r\n\r\n`True is not false` と言われているのは，test_handlight_l_04 というテストケースが assertFalse している値が True になっていて，この値は上流まで行くと `writeDigitalOutputWithMask` から返って来ます．\r\n@emijah\r\n"},"comment":{"url":"https://api.github.com/repos/fkanehiro/hrpsys-base/issues/comments/80098957","html_url":"https://github.com/fkanehiro/hrpsys-base/issues/404#issuecomment-80098957","issue_url":"https://api.github.com/repos/fkanehiro/hrpsys-base/issues/404","id":80098957,"user":{"login":"k-okada","id":493276,"avatar_url":"https://avatars.githubusercontent.com/u/493276?v=3","gravatar_id":"","url":"https://api.github.com/users/k-okada","html_url":"https://github.com/k-okada","followers_url":"https://api.github.com/users/k-okada/followers","following_url":"https://api.github.com/users/k-okada/following{/other_user}","gists_url":"https://api.github.com/users/k-okada/gists{/gist_id}","starred_url":"https://api.github.com/users/k-okada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-okada/subscriptions","organizations_url":"https://api.github.com/users/k-okada/orgs","repos_url":"https://api.github.com/users/k-okada/repos","events_url":"https://api.github.com/users/k-okada/events{/privacy}","received_events_url":"https://api.github.com/users/k-okada/received_events","type":"User","site_admin":false},"created_at":"2015-03-14T07:52:19Z","updated_at":"2015-03-14T07:52:19Z","body":"テストはベトのところではなくて，このPRのhttps://github.com/tork-a/rtmros_nextage/pull/154/files\r\nを変えたので通っています．強引に現状合わせでFalse->Trueにしていますがこれでいいかわかっていません？\r\n\r\nhttps://github.com/fkanehiro/hrpsys-base/issues/404\r\nでfalseが期待されるけとときどきTrueになる，と書いてあるものの，実際には必ずTrueになる\r\nhttps://github.com/fkanehiro/hrpsys-base/blob/master/python/hrpsys_config.py#L1319\r\nようになっているようです．\r\n\r\n--\r\n◉ Kei Okada\r\n\r\n\r\n2015-03-14 11:22 GMT+09:00 Isaac I.Y. Saito <notifications@github.com>:\r\n\r\n> この PR のテスト <https://github.com/tork-a/rtmros_nextage/pull/154>\r\n> も通っているしどうやらどこかで変更を入れて頂いたようですね．ありがとうございます．\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/fkanehiro/hrpsys-base/issues/404#issuecomment-79715106>\r\n> .\r\n>\r\n"}}