{"action":"created","comment":{"url":"https://api.github.com/repos/knalli/angular-vertxbus/pulls/comments/27571403","id":27571403,"diff_hunk":"@@ -122,9 +124,15 @@ angular.module('knalli.angular-vertxbus')\n           EventBusStub.onopen() if typeof EventBusStub.onopen is 'function'\n           return #void\n         eventBus.onclose = ->\n-          $log.debug(\"[Vert.x EB Stub] Reconnect in #{sockjsReconnectInterval}ms\") if debugEnabled\n           EventBusStub.onclose() if typeof EventBusStub.onclose is 'function'\n-          $timeout(connect, sockjsReconnectInterval) if reconnectEnabled\n+          if reconnectNowRequested\n+            $log.debug(\"[Vert.x EB Stub] Reconnect immediately\") if debugEnabled\n+            reconnectNowRequested = false\n+            connect()\n+          else\n+            if debugEnabled\n+              $log.debug(\"[Vert.x EB Stub] Reconnect in #{sockjsReconnectInterval}ms\")","path":"src/wrapper.coffee","position":22,"original_position":22,"commit_id":"5e74bd83faf96969d579255d303ae9cad07f57dd","original_commit_id":"5e74bd83faf96969d579255d303ae9cad07f57dd","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line exceeds maximum allowed length","created_at":"2015-04-01T14:04:59Z","updated_at":"2015-04-01T14:04:59Z","html_url":"https://github.com/knalli/angular-vertxbus/pull/45#discussion_r27571403","pull_request_url":"https://api.github.com/repos/knalli/angular-vertxbus/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/knalli/angular-vertxbus/pulls/comments/27571403"},"html":{"href":"https://github.com/knalli/angular-vertxbus/pull/45#discussion_r27571403"},"pull_request":{"href":"https://api.github.com/repos/knalli/angular-vertxbus/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/knalli/angular-vertxbus/pulls/45","id":32421798,"html_url":"https://github.com/knalli/angular-vertxbus/pull/45","diff_url":"https://github.com/knalli/angular-vertxbus/pull/45.diff","patch_url":"https://github.com/knalli/angular-vertxbus/pull/45.patch","issue_url":"https://api.github.com/repos/knalli/angular-vertxbus/issues/45","number":45,"state":"open","locked":false,"title":"Reconnect now","user":{"login":"de-git","id":1016473,"avatar_url":"https://avatars.githubusercontent.com/u/1016473?v=3","gravatar_id":"","url":"https://api.github.com/users/de-git","html_url":"https://github.com/de-git","followers_url":"https://api.github.com/users/de-git/followers","following_url":"https://api.github.com/users/de-git/following{/other_user}","gists_url":"https://api.github.com/users/de-git/gists{/gist_id}","starred_url":"https://api.github.com/users/de-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/de-git/subscriptions","organizations_url":"https://api.github.com/users/de-git/orgs","repos_url":"https://api.github.com/users/de-git/repos","events_url":"https://api.github.com/users/de-git/events{/privacy}","received_events_url":"https://api.github.com/users/de-git/received_events","type":"User","site_admin":false},"body":"(This replaced my previous pull request)\r\n\r\nThe current reconnect method is just closing the socket and waiting for the reconnect timeout to happen.\r\nI've added a new reconnectNow method that reconnects 'immediately'.\r\nIt also can be used to connect if the connection is currently closed.\r\n\r\nBoth could also happen within the reconnect method instead but I wasn't sure whether the existing behaviour was intentional.","created_at":"2015-04-01T14:04:52Z","updated_at":"2015-04-01T14:04:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8320c5f0bcbbdb32386d34f72738a14b63bf3bea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/knalli/angular-vertxbus/pulls/45/commits","review_comments_url":"https://api.github.com/repos/knalli/angular-vertxbus/pulls/45/comments","review_comment_url":"https://api.github.com/repos/knalli/angular-vertxbus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knalli/angular-vertxbus/issues/45/comments","statuses_url":"https://api.github.com/repos/knalli/angular-vertxbus/statuses/5e74bd83faf96969d579255d303ae9cad07f57dd","head":{"label":"de-git:reconnect-now","ref":"reconnect-now","sha":"5e74bd83faf96969d579255d303ae9cad07f57dd","user":{"login":"de-git","id":1016473,"avatar_url":"https://avatars.githubusercontent.com/u/1016473?v=3","gravatar_id":"","url":"https://api.github.com/users/de-git","html_url":"https://github.com/de-git","followers_url":"https://api.github.com/users/de-git/followers","following_url":"https://api.github.com/users/de-git/following{/other_user}","gists_url":"https://api.github.com/users/de-git/gists{/gist_id}","starred_url":"https://api.github.com/users/de-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/de-git/subscriptions","organizations_url":"https://api.github.com/users/de-git/orgs","repos_url":"https://api.github.com/users/de-git/repos","events_url":"https://api.github.com/users/de-git/events{/privacy}","received_events_url":"https://api.github.com/users/de-git/received_events","type":"User","site_admin":false},"repo":{"id":33113222,"name":"angular-vertxbus","full_name":"de-git/angular-vertxbus","owner":{"login":"de-git","id":1016473,"avatar_url":"https://avatars.githubusercontent.com/u/1016473?v=3","gravatar_id":"","url":"https://api.github.com/users/de-git","html_url":"https://github.com/de-git","followers_url":"https://api.github.com/users/de-git/followers","following_url":"https://api.github.com/users/de-git/following{/other_user}","gists_url":"https://api.github.com/users/de-git/gists{/gist_id}","starred_url":"https://api.github.com/users/de-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/de-git/subscriptions","organizations_url":"https://api.github.com/users/de-git/orgs","repos_url":"https://api.github.com/users/de-git/repos","events_url":"https://api.github.com/users/de-git/events{/privacy}","received_events_url":"https://api.github.com/users/de-git/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/de-git/angular-vertxbus","description":"AngularJS service wrapper for the Vert.x Event Bus","fork":true,"url":"https://api.github.com/repos/de-git/angular-vertxbus","forks_url":"https://api.github.com/repos/de-git/angular-vertxbus/forks","keys_url":"https://api.github.com/repos/de-git/angular-vertxbus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/de-git/angular-vertxbus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/de-git/angular-vertxbus/teams","hooks_url":"https://api.github.com/repos/de-git/angular-vertxbus/hooks","issue_events_url":"https://api.github.com/repos/de-git/angular-vertxbus/issues/events{/number}","events_url":"https://api.github.com/repos/de-git/angular-vertxbus/events","assignees_url":"https://api.github.com/repos/de-git/angular-vertxbus/assignees{/user}","branches_url":"https://api.github.com/repos/de-git/angular-vertxbus/branches{/branch}","tags_url":"https://api.github.com/repos/de-git/angular-vertxbus/tags","blobs_url":"https://api.github.com/repos/de-git/angular-vertxbus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/de-git/angular-vertxbus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/de-git/angular-vertxbus/git/refs{/sha}","trees_url":"https://api.github.com/repos/de-git/angular-vertxbus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/de-git/angular-vertxbus/statuses/{sha}","languages_url":"https://api.github.com/repos/de-git/angular-vertxbus/languages","stargazers_url":"https://api.github.com/repos/de-git/angular-vertxbus/stargazers","contributors_url":"https://api.github.com/repos/de-git/angular-vertxbus/contributors","subscribers_url":"https://api.github.com/repos/de-git/angular-vertxbus/subscribers","subscription_url":"https://api.github.com/repos/de-git/angular-vertxbus/subscription","commits_url":"https://api.github.com/repos/de-git/angular-vertxbus/commits{/sha}","git_commits_url":"https://api.github.com/repos/de-git/angular-vertxbus/git/commits{/sha}","comments_url":"https://api.github.com/repos/de-git/angular-vertxbus/comments{/number}","issue_comment_url":"https://api.github.com/repos/de-git/angular-vertxbus/issues/comments{/number}","contents_url":"https://api.github.com/repos/de-git/angular-vertxbus/contents/{+path}","compare_url":"https://api.github.com/repos/de-git/angular-vertxbus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/de-git/angular-vertxbus/merges","archive_url":"https://api.github.com/repos/de-git/angular-vertxbus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/de-git/angular-vertxbus/downloads","issues_url":"https://api.github.com/repos/de-git/angular-vertxbus/issues{/number}","pulls_url":"https://api.github.com/repos/de-git/angular-vertxbus/pulls{/number}","milestones_url":"https://api.github.com/repos/de-git/angular-vertxbus/milestones{/number}","notifications_url":"https://api.github.com/repos/de-git/angular-vertxbus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/de-git/angular-vertxbus/labels{/name}","releases_url":"https://api.github.com/repos/de-git/angular-vertxbus/releases{/id}","created_at":"2015-03-30T09:06:08Z","updated_at":"2015-03-31T14:26:44Z","pushed_at":"2015-04-01T14:02:06Z","git_url":"git://github.com/de-git/angular-vertxbus.git","ssh_url":"git@github.com:de-git/angular-vertxbus.git","clone_url":"https://github.com/de-git/angular-vertxbus.git","svn_url":"https://github.com/de-git/angular-vertxbus","homepage":"","size":964,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knalli:master","ref":"master","sha":"a69dc7cea2d85df128054884ced01b718fa6ff68","user":{"login":"knalli","id":65389,"avatar_url":"https://avatars.githubusercontent.com/u/65389?v=3","gravatar_id":"","url":"https://api.github.com/users/knalli","html_url":"https://github.com/knalli","followers_url":"https://api.github.com/users/knalli/followers","following_url":"https://api.github.com/users/knalli/following{/other_user}","gists_url":"https://api.github.com/users/knalli/gists{/gist_id}","starred_url":"https://api.github.com/users/knalli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knalli/subscriptions","organizations_url":"https://api.github.com/users/knalli/orgs","repos_url":"https://api.github.com/users/knalli/repos","events_url":"https://api.github.com/users/knalli/events{/privacy}","received_events_url":"https://api.github.com/users/knalli/received_events","type":"User","site_admin":false},"repo":{"id":15196820,"name":"angular-vertxbus","full_name":"knalli/angular-vertxbus","owner":{"login":"knalli","id":65389,"avatar_url":"https://avatars.githubusercontent.com/u/65389?v=3","gravatar_id":"","url":"https://api.github.com/users/knalli","html_url":"https://github.com/knalli","followers_url":"https://api.github.com/users/knalli/followers","following_url":"https://api.github.com/users/knalli/following{/other_user}","gists_url":"https://api.github.com/users/knalli/gists{/gist_id}","starred_url":"https://api.github.com/users/knalli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knalli/subscriptions","organizations_url":"https://api.github.com/users/knalli/orgs","repos_url":"https://api.github.com/users/knalli/repos","events_url":"https://api.github.com/users/knalli/events{/privacy}","received_events_url":"https://api.github.com/users/knalli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/knalli/angular-vertxbus","description":"AngularJS service wrapper for the Vert.x Event Bus","fork":false,"url":"https://api.github.com/repos/knalli/angular-vertxbus","forks_url":"https://api.github.com/repos/knalli/angular-vertxbus/forks","keys_url":"https://api.github.com/repos/knalli/angular-vertxbus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knalli/angular-vertxbus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knalli/angular-vertxbus/teams","hooks_url":"https://api.github.com/repos/knalli/angular-vertxbus/hooks","issue_events_url":"https://api.github.com/repos/knalli/angular-vertxbus/issues/events{/number}","events_url":"https://api.github.com/repos/knalli/angular-vertxbus/events","assignees_url":"https://api.github.com/repos/knalli/angular-vertxbus/assignees{/user}","branches_url":"https://api.github.com/repos/knalli/angular-vertxbus/branches{/branch}","tags_url":"https://api.github.com/repos/knalli/angular-vertxbus/tags","blobs_url":"https://api.github.com/repos/knalli/angular-vertxbus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knalli/angular-vertxbus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knalli/angular-vertxbus/git/refs{/sha}","trees_url":"https://api.github.com/repos/knalli/angular-vertxbus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knalli/angular-vertxbus/statuses/{sha}","languages_url":"https://api.github.com/repos/knalli/angular-vertxbus/languages","stargazers_url":"https://api.github.com/repos/knalli/angular-vertxbus/stargazers","contributors_url":"https://api.github.com/repos/knalli/angular-vertxbus/contributors","subscribers_url":"https://api.github.com/repos/knalli/angular-vertxbus/subscribers","subscription_url":"https://api.github.com/repos/knalli/angular-vertxbus/subscription","commits_url":"https://api.github.com/repos/knalli/angular-vertxbus/commits{/sha}","git_commits_url":"https://api.github.com/repos/knalli/angular-vertxbus/git/commits{/sha}","comments_url":"https://api.github.com/repos/knalli/angular-vertxbus/comments{/number}","issue_comment_url":"https://api.github.com/repos/knalli/angular-vertxbus/issues/comments{/number}","contents_url":"https://api.github.com/repos/knalli/angular-vertxbus/contents/{+path}","compare_url":"https://api.github.com/repos/knalli/angular-vertxbus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knalli/angular-vertxbus/merges","archive_url":"https://api.github.com/repos/knalli/angular-vertxbus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knalli/angular-vertxbus/downloads","issues_url":"https://api.github.com/repos/knalli/angular-vertxbus/issues{/number}","pulls_url":"https://api.github.com/repos/knalli/angular-vertxbus/pulls{/number}","milestones_url":"https://api.github.com/repos/knalli/angular-vertxbus/milestones{/number}","notifications_url":"https://api.github.com/repos/knalli/angular-vertxbus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knalli/angular-vertxbus/labels{/name}","releases_url":"https://api.github.com/repos/knalli/angular-vertxbus/releases{/id}","created_at":"2013-12-15T02:55:12Z","updated_at":"2015-03-31T13:24:32Z","pushed_at":"2015-04-01T14:04:53Z","git_url":"git://github.com/knalli/angular-vertxbus.git","ssh_url":"git@github.com:knalli/angular-vertxbus.git","clone_url":"https://github.com/knalli/angular-vertxbus.git","svn_url":"https://github.com/knalli/angular-vertxbus","homepage":"","size":964,"stargazers_count":36,"watchers_count":36,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":5,"forks":12,"open_issues":5,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knalli/angular-vertxbus/pulls/45"},"html":{"href":"https://github.com/knalli/angular-vertxbus/pull/45"},"issue":{"href":"https://api.github.com/repos/knalli/angular-vertxbus/issues/45"},"comments":{"href":"https://api.github.com/repos/knalli/angular-vertxbus/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/knalli/angular-vertxbus/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/knalli/angular-vertxbus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knalli/angular-vertxbus/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/knalli/angular-vertxbus/statuses/5e74bd83faf96969d579255d303ae9cad07f57dd"}}}}