{"action":"created","issue":{"url":"https://api.github.com/repos/tlswg/tls13-spec/issues/205","labels_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/205/labels{/name}","comments_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/205/comments","events_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/205/events","html_url":"https://github.com/tlswg/tls13-spec/pull/205","id":96000306,"number":205,"title":"tweaks for secrets to improve readability a bit","user":{"login":"davegarrett","id":8292199,"avatar_url":"https://avatars.githubusercontent.com/u/8292199?v=3","gravatar_id":"","url":"https://api.github.com/users/davegarrett","html_url":"https://github.com/davegarrett","followers_url":"https://api.github.com/users/davegarrett/followers","following_url":"https://api.github.com/users/davegarrett/following{/other_user}","gists_url":"https://api.github.com/users/davegarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/davegarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davegarrett/subscriptions","organizations_url":"https://api.github.com/users/davegarrett/orgs","repos_url":"https://api.github.com/users/davegarrett/repos","events_url":"https://api.github.com/users/davegarrett/events{/privacy}","received_events_url":"https://api.github.com/users/davegarrett/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-20T07:02:07Z","updated_at":"2015-07-20T16:13:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/205","html_url":"https://github.com/tlswg/tls13-spec/pull/205","diff_url":"https://github.com/tlswg/tls13-spec/pull/205.diff","patch_url":"https://github.com/tlswg/tls13-spec/pull/205.patch"},"body":"Just a few things I noticed that I think make it a little bit easier to follow.\r\n\r\n* Name resumption_secret consistently when used\r\n* Show full legend for each handshake flow\r\n* Simplify/clarify secret sources table a bit and make text cases consistent\r\n\r\nThe resumption secret naming was also apparently noticed by @martinthomson in issue #191."},"comment":{"url":"https://api.github.com/repos/tlswg/tls13-spec/issues/comments/122932331","html_url":"https://github.com/tlswg/tls13-spec/pull/205#issuecomment-122932331","issue_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/205","id":122932331,"user":{"login":"davegarrett","id":8292199,"avatar_url":"https://avatars.githubusercontent.com/u/8292199?v=3","gravatar_id":"","url":"https://api.github.com/users/davegarrett","html_url":"https://github.com/davegarrett","followers_url":"https://api.github.com/users/davegarrett/followers","following_url":"https://api.github.com/users/davegarrett/following{/other_user}","gists_url":"https://api.github.com/users/davegarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/davegarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davegarrett/subscriptions","organizations_url":"https://api.github.com/users/davegarrett/orgs","repos_url":"https://api.github.com/users/davegarrett/repos","events_url":"https://api.github.com/users/davegarrett/events{/privacy}","received_events_url":"https://api.github.com/users/davegarrett/received_events","type":"User","site_admin":false},"created_at":"2015-07-20T16:13:10Z","updated_at":"2015-07-20T16:13:10Z","body":"Ok, to respond to comments I've pushed a new commit.\r\n\r\nRE: capitalization: Upper or lower is fine, as long as it's consistent. I've switched it to all upper (title case) instead of all lower.\r\n\r\nRE: legend repetition: If you're just reading one section, e.g. got to it via TOC, you might not have seen the legend (recently). I've made it less wordy now and also added a line to indicate \"+\" is for extensions, as I realized that wasn't necessarily clear. (and added a \"+\" where the notation was inconsistent) We do have an extension that was previously a message, now. The basic point is consistency; make each handshake flow make sense on its own.\r\n\r\nI think repeating the legend is helpful, but if you really don't want to repeat it that I can cut this down to just the little stuff and table. Showing \"N/A\" instead of repeating things in the table is the most helpful part here, I think. It states that SS=ES in some circumstances elsewhere, but the table isn't clear that these are the exact same values, especially because the extracted ones are _not_."}}