{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3095","labels_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3095/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3095/comments","events_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3095/events","html_url":"https://github.com/mozilla/fxa-content-server/pull/3095","id":107710638,"number":3095,"title":"refactor(client): Tease appart the FxSync and FxDesktopV1 auth brokers.","user":{"login":"shane-tomlinson","id":848085,"avatar_url":"https://avatars.githubusercontent.com/u/848085?v=3","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/fxa-content-server/labels/waffle:review","name":"waffle:review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-22T13:05:54Z","updated_at":"2015-09-23T10:22:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/3095","html_url":"https://github.com/mozilla/fxa-content-server/pull/3095","diff_url":"https://github.com/mozilla/fxa-content-server/pull/3095.diff","patch_url":"https://github.com/mozilla/fxa-content-server/pull/3095.patch"},"body":"This refactor enables us to move FxDesktopV1 halt behavior and channel commands\r\ninto a separate broker and remove the overrides from all other FxDesktopV1\r\nsubclasses.\r\n\r\nThe goal is to move us towards a better place for the Fennec and\r\nWindows Migrator work where each broker type can specify behaviors and\r\ncapabilities.\r\n\r\nRef #2771, #3094 "},"comment":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/comments/142557128","html_url":"https://github.com/mozilla/fxa-content-server/pull/3095#issuecomment-142557128","issue_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3095","id":142557128,"user":{"login":"philbooth","id":64367,"avatar_url":"https://avatars.githubusercontent.com/u/64367?v=3","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"created_at":"2015-09-23T10:22:06Z","updated_at":"2015-09-23T10:22:06Z","body":"Would it be worth adding a few more tests for `auth_brokers/fx-desktop-v2.js`, now it extends a base that throws from `createChannel` and `getCommands`? Just similar to what you've already done for `v1` is all I'm thinking.\r\n"}}