{"action":"created","comment":{"url":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/comments/43681176","id":43681176,"diff_hunk":"@@ -33,8 +34,14 @@ def make_patterned_polydata(inputContours, fillareastyle=None,\n     # Scaled the size to 2 times to make the pattern image of a finer resolution\n     xBounds = bounds[1] - bounds[0]\n     yBounds = bounds[3] - bounds[2]\n-    xres = int(4.0*xBounds)\n-    yres = int(4.0*yBounds)\n+    if xBounds <= 1 and yBounds <= 1 and size is not None:\n+        xBounds *= size[0]","path":"Packages/vcs/Lib/vcsvtk/fillareautils.py","position":24,"original_position":24,"commit_id":"7869f189bdf760ce37bc848a1ea534e9eac8a4bf","original_commit_id":"7869f189bdf760ce37bc848a1ea534e9eac8a4bf","user":{"login":"doutriaux1","id":2781425,"avatar_url":"https://avatars.githubusercontent.com/u/2781425?v=3","gravatar_id":"","url":"https://api.github.com/users/doutriaux1","html_url":"https://github.com/doutriaux1","followers_url":"https://api.github.com/users/doutriaux1/followers","following_url":"https://api.github.com/users/doutriaux1/following{/other_user}","gists_url":"https://api.github.com/users/doutriaux1/gists{/gist_id}","starred_url":"https://api.github.com/users/doutriaux1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doutriaux1/subscriptions","organizations_url":"https://api.github.com/users/doutriaux1/orgs","repos_url":"https://api.github.com/users/doutriaux1/repos","events_url":"https://api.github.com/users/doutriaux1/events{/privacy}","received_events_url":"https://api.github.com/users/doutriaux1/received_events","type":"User","site_admin":false},"body":"@sankhesh is kind of right you want your pattenr to be somewhat predictable, can we try to scale this pattern by the size of the window or something?\r\n\r\n@chaosphere2112 with your changes would a fillarea pattern be different based on different values of the fa.worldcoordinate ? ","created_at":"2015-11-02T20:59:16Z","updated_at":"2015-11-02T20:59:16Z","html_url":"https://github.com/UV-CDAT/uvcdat/pull/1651#discussion_r43681176","pull_request_url":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/1651","_links":{"self":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/comments/43681176"},"html":{"href":"https://github.com/UV-CDAT/uvcdat/pull/1651#discussion_r43681176"},"pull_request":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/1651"}}},"pull_request":{"url":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/1651","id":49300544,"html_url":"https://github.com/UV-CDAT/uvcdat/pull/1651","diff_url":"https://github.com/UV-CDAT/uvcdat/pull/1651.diff","patch_url":"https://github.com/UV-CDAT/uvcdat/pull/1651.patch","issue_url":"https://api.github.com/repos/UV-CDAT/uvcdat/issues/1651","number":1651,"state":"open","locked":false,"title":"Improved pattern size","user":{"login":"chaosphere2112","id":718512,"avatar_url":"https://avatars.githubusercontent.com/u/718512?v=3","gravatar_id":"","url":"https://api.github.com/users/chaosphere2112","html_url":"https://github.com/chaosphere2112","followers_url":"https://api.github.com/users/chaosphere2112/followers","following_url":"https://api.github.com/users/chaosphere2112/following{/other_user}","gists_url":"https://api.github.com/users/chaosphere2112/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosphere2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosphere2112/subscriptions","organizations_url":"https://api.github.com/users/chaosphere2112/orgs","repos_url":"https://api.github.com/users/chaosphere2112/repos","events_url":"https://api.github.com/users/chaosphere2112/events{/privacy}","received_events_url":"https://api.github.com/users/chaosphere2112/received_events","type":"User","site_admin":false},"body":"When I was doing the test scripts in #1650, I saw that the patterns looked really wonky on large fillareas. Turns out, it was guessing that they were 32x64 pixels, which was, uh, incorrect. Made it so we can pass in screen size to the `fillareautils` code to get more realistic sizes, updated baselines to match. I also added a test for larger fillareas that makes sure they look fine. ","created_at":"2015-10-30T17:44:25Z","updated_at":"2015-11-02T20:59:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec01ca1cfadb6e17a79c858300798f1eb9e273e5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/1651/commits","review_comments_url":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/1651/comments","review_comment_url":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UV-CDAT/uvcdat/issues/1651/comments","statuses_url":"https://api.github.com/repos/UV-CDAT/uvcdat/statuses/7869f189bdf760ce37bc848a1ea534e9eac8a4bf","head":{"label":"UV-CDAT:improved_pattern_size","ref":"improved_pattern_size","sha":"7869f189bdf760ce37bc848a1ea534e9eac8a4bf","user":{"login":"UV-CDAT","id":2781444,"avatar_url":"https://avatars.githubusercontent.com/u/2781444?v=3","gravatar_id":"","url":"https://api.github.com/users/UV-CDAT","html_url":"https://github.com/UV-CDAT","followers_url":"https://api.github.com/users/UV-CDAT/followers","following_url":"https://api.github.com/users/UV-CDAT/following{/other_user}","gists_url":"https://api.github.com/users/UV-CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/UV-CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UV-CDAT/subscriptions","organizations_url":"https://api.github.com/users/UV-CDAT/orgs","repos_url":"https://api.github.com/users/UV-CDAT/repos","events_url":"https://api.github.com/users/UV-CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/UV-CDAT/received_events","type":"Organization","site_admin":false},"repo":{"id":6660536,"name":"uvcdat","full_name":"UV-CDAT/uvcdat","owner":{"login":"UV-CDAT","id":2781444,"avatar_url":"https://avatars.githubusercontent.com/u/2781444?v=3","gravatar_id":"","url":"https://api.github.com/users/UV-CDAT","html_url":"https://github.com/UV-CDAT","followers_url":"https://api.github.com/users/UV-CDAT/followers","following_url":"https://api.github.com/users/UV-CDAT/following{/other_user}","gists_url":"https://api.github.com/users/UV-CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/UV-CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UV-CDAT/subscriptions","organizations_url":"https://api.github.com/users/UV-CDAT/orgs","repos_url":"https://api.github.com/users/UV-CDAT/repos","events_url":"https://api.github.com/users/UV-CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/UV-CDAT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UV-CDAT/uvcdat","description":"Ultrascale Visualization Climate Data Analysis Tools","fork":false,"url":"https://api.github.com/repos/UV-CDAT/uvcdat","forks_url":"https://api.github.com/repos/UV-CDAT/uvcdat/forks","keys_url":"https://api.github.com/repos/UV-CDAT/uvcdat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UV-CDAT/uvcdat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UV-CDAT/uvcdat/teams","hooks_url":"https://api.github.com/repos/UV-CDAT/uvcdat/hooks","issue_events_url":"https://api.github.com/repos/UV-CDAT/uvcdat/issues/events{/number}","events_url":"https://api.github.com/repos/UV-CDAT/uvcdat/events","assignees_url":"https://api.github.com/repos/UV-CDAT/uvcdat/assignees{/user}","branches_url":"https://api.github.com/repos/UV-CDAT/uvcdat/branches{/branch}","tags_url":"https://api.github.com/repos/UV-CDAT/uvcdat/tags","blobs_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/refs{/sha}","trees_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UV-CDAT/uvcdat/statuses/{sha}","languages_url":"https://api.github.com/repos/UV-CDAT/uvcdat/languages","stargazers_url":"https://api.github.com/repos/UV-CDAT/uvcdat/stargazers","contributors_url":"https://api.github.com/repos/UV-CDAT/uvcdat/contributors","subscribers_url":"https://api.github.com/repos/UV-CDAT/uvcdat/subscribers","subscription_url":"https://api.github.com/repos/UV-CDAT/uvcdat/subscription","commits_url":"https://api.github.com/repos/UV-CDAT/uvcdat/commits{/sha}","git_commits_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/commits{/sha}","comments_url":"https://api.github.com/repos/UV-CDAT/uvcdat/comments{/number}","issue_comment_url":"https://api.github.com/repos/UV-CDAT/uvcdat/issues/comments{/number}","contents_url":"https://api.github.com/repos/UV-CDAT/uvcdat/contents/{+path}","compare_url":"https://api.github.com/repos/UV-CDAT/uvcdat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UV-CDAT/uvcdat/merges","archive_url":"https://api.github.com/repos/UV-CDAT/uvcdat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UV-CDAT/uvcdat/downloads","issues_url":"https://api.github.com/repos/UV-CDAT/uvcdat/issues{/number}","pulls_url":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls{/number}","milestones_url":"https://api.github.com/repos/UV-CDAT/uvcdat/milestones{/number}","notifications_url":"https://api.github.com/repos/UV-CDAT/uvcdat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UV-CDAT/uvcdat/labels{/name}","releases_url":"https://api.github.com/repos/UV-CDAT/uvcdat/releases{/id}","created_at":"2012-11-12T20:58:18Z","updated_at":"2015-11-02T18:52:28Z","pushed_at":"2015-11-02T19:05:26Z","git_url":"git://github.com/UV-CDAT/uvcdat.git","ssh_url":"git@github.com:UV-CDAT/uvcdat.git","clone_url":"https://github.com/UV-CDAT/uvcdat.git","svn_url":"https://github.com/UV-CDAT/uvcdat","homepage":null,"size":306539,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":276,"forks":36,"open_issues":276,"watchers":52,"default_branch":"master"}},"base":{"label":"UV-CDAT:master","ref":"master","sha":"e666a0365c35dc951536a24479388d26f8425512","user":{"login":"UV-CDAT","id":2781444,"avatar_url":"https://avatars.githubusercontent.com/u/2781444?v=3","gravatar_id":"","url":"https://api.github.com/users/UV-CDAT","html_url":"https://github.com/UV-CDAT","followers_url":"https://api.github.com/users/UV-CDAT/followers","following_url":"https://api.github.com/users/UV-CDAT/following{/other_user}","gists_url":"https://api.github.com/users/UV-CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/UV-CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UV-CDAT/subscriptions","organizations_url":"https://api.github.com/users/UV-CDAT/orgs","repos_url":"https://api.github.com/users/UV-CDAT/repos","events_url":"https://api.github.com/users/UV-CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/UV-CDAT/received_events","type":"Organization","site_admin":false},"repo":{"id":6660536,"name":"uvcdat","full_name":"UV-CDAT/uvcdat","owner":{"login":"UV-CDAT","id":2781444,"avatar_url":"https://avatars.githubusercontent.com/u/2781444?v=3","gravatar_id":"","url":"https://api.github.com/users/UV-CDAT","html_url":"https://github.com/UV-CDAT","followers_url":"https://api.github.com/users/UV-CDAT/followers","following_url":"https://api.github.com/users/UV-CDAT/following{/other_user}","gists_url":"https://api.github.com/users/UV-CDAT/gists{/gist_id}","starred_url":"https://api.github.com/users/UV-CDAT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UV-CDAT/subscriptions","organizations_url":"https://api.github.com/users/UV-CDAT/orgs","repos_url":"https://api.github.com/users/UV-CDAT/repos","events_url":"https://api.github.com/users/UV-CDAT/events{/privacy}","received_events_url":"https://api.github.com/users/UV-CDAT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UV-CDAT/uvcdat","description":"Ultrascale Visualization Climate Data Analysis Tools","fork":false,"url":"https://api.github.com/repos/UV-CDAT/uvcdat","forks_url":"https://api.github.com/repos/UV-CDAT/uvcdat/forks","keys_url":"https://api.github.com/repos/UV-CDAT/uvcdat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UV-CDAT/uvcdat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UV-CDAT/uvcdat/teams","hooks_url":"https://api.github.com/repos/UV-CDAT/uvcdat/hooks","issue_events_url":"https://api.github.com/repos/UV-CDAT/uvcdat/issues/events{/number}","events_url":"https://api.github.com/repos/UV-CDAT/uvcdat/events","assignees_url":"https://api.github.com/repos/UV-CDAT/uvcdat/assignees{/user}","branches_url":"https://api.github.com/repos/UV-CDAT/uvcdat/branches{/branch}","tags_url":"https://api.github.com/repos/UV-CDAT/uvcdat/tags","blobs_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/refs{/sha}","trees_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UV-CDAT/uvcdat/statuses/{sha}","languages_url":"https://api.github.com/repos/UV-CDAT/uvcdat/languages","stargazers_url":"https://api.github.com/repos/UV-CDAT/uvcdat/stargazers","contributors_url":"https://api.github.com/repos/UV-CDAT/uvcdat/contributors","subscribers_url":"https://api.github.com/repos/UV-CDAT/uvcdat/subscribers","subscription_url":"https://api.github.com/repos/UV-CDAT/uvcdat/subscription","commits_url":"https://api.github.com/repos/UV-CDAT/uvcdat/commits{/sha}","git_commits_url":"https://api.github.com/repos/UV-CDAT/uvcdat/git/commits{/sha}","comments_url":"https://api.github.com/repos/UV-CDAT/uvcdat/comments{/number}","issue_comment_url":"https://api.github.com/repos/UV-CDAT/uvcdat/issues/comments{/number}","contents_url":"https://api.github.com/repos/UV-CDAT/uvcdat/contents/{+path}","compare_url":"https://api.github.com/repos/UV-CDAT/uvcdat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UV-CDAT/uvcdat/merges","archive_url":"https://api.github.com/repos/UV-CDAT/uvcdat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UV-CDAT/uvcdat/downloads","issues_url":"https://api.github.com/repos/UV-CDAT/uvcdat/issues{/number}","pulls_url":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls{/number}","milestones_url":"https://api.github.com/repos/UV-CDAT/uvcdat/milestones{/number}","notifications_url":"https://api.github.com/repos/UV-CDAT/uvcdat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UV-CDAT/uvcdat/labels{/name}","releases_url":"https://api.github.com/repos/UV-CDAT/uvcdat/releases{/id}","created_at":"2012-11-12T20:58:18Z","updated_at":"2015-11-02T18:52:28Z","pushed_at":"2015-11-02T19:05:26Z","git_url":"git://github.com/UV-CDAT/uvcdat.git","ssh_url":"git@github.com:UV-CDAT/uvcdat.git","clone_url":"https://github.com/UV-CDAT/uvcdat.git","svn_url":"https://github.com/UV-CDAT/uvcdat","homepage":null,"size":306539,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":276,"forks":36,"open_issues":276,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/1651"},"html":{"href":"https://github.com/UV-CDAT/uvcdat/pull/1651"},"issue":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/issues/1651"},"comments":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/issues/1651/comments"},"review_comments":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/1651/comments"},"review_comment":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/pulls/1651/commits"},"statuses":{"href":"https://api.github.com/repos/UV-CDAT/uvcdat/statuses/7869f189bdf760ce37bc848a1ea534e9eac8a4bf"}}}}