{"action":"created","comment":{"url":"https://api.github.com/repos/dropbox/pyston/pulls/comments/37805502","id":37805502,"diff_hunk":"@@ -508,12 +508,20 @@ class BasicBlockTypePropagator : public ExprVisitor, public StmtVisitor, public\n \n     void* visit_unaryop(AST_UnaryOp* node) override {\n         CompilerType* operand = getType(node->operand);\n+        if (!hasFixedOps(operand))\n+            return UNKNOWN;\n \n         // TODO this isn't the exact behavior","path":"src/analysis/type_analysis.cpp","position":34,"original_position":34,"commit_id":"60131ac6037de6cdf071a515211fa5b803509094","original_commit_id":"60131ac6037de6cdf071a515211fa5b803509094","user":{"login":"kmod","id":271916,"avatar_url":"https://avatars.githubusercontent.com/u/271916?v=3","gravatar_id":"","url":"https://api.github.com/users/kmod","html_url":"https://github.com/kmod","followers_url":"https://api.github.com/users/kmod/followers","following_url":"https://api.github.com/users/kmod/following{/other_user}","gists_url":"https://api.github.com/users/kmod/gists{/gist_id}","starred_url":"https://api.github.com/users/kmod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmod/subscriptions","organizations_url":"https://api.github.com/users/kmod/orgs","repos_url":"https://api.github.com/users/kmod/repos","events_url":"https://api.github.com/users/kmod/events{/privacy}","received_events_url":"https://api.github.com/users/kmod/received_events","type":"User","site_admin":false},"body":"I think these comments can be removed now","created_at":"2015-08-24T21:13:19Z","updated_at":"2015-08-24T21:13:19Z","html_url":"https://github.com/dropbox/pyston/pull/861#discussion_r37805502","pull_request_url":"https://api.github.com/repos/dropbox/pyston/pulls/861","_links":{"self":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/comments/37805502"},"html":{"href":"https://github.com/dropbox/pyston/pull/861#discussion_r37805502"},"pull_request":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/861"}}},"pull_request":{"url":"https://api.github.com/repos/dropbox/pyston/pulls/861","id":43181145,"html_url":"https://github.com/dropbox/pyston/pull/861","diff_url":"https://github.com/dropbox/pyston/pull/861.diff","patch_url":"https://github.com/dropbox/pyston/pull/861.patch","issue_url":"https://api.github.com/repos/dropbox/pyston/issues/861","number":861,"state":"open","locked":false,"title":"Fix a few errors encountered while running test/cpython/test_math.py","user":{"login":"undingen","id":7397630,"avatar_url":"https://avatars.githubusercontent.com/u/7397630?v=3","gravatar_id":"","url":"https://api.github.com/users/undingen","html_url":"https://github.com/undingen","followers_url":"https://api.github.com/users/undingen/followers","following_url":"https://api.github.com/users/undingen/following{/other_user}","gists_url":"https://api.github.com/users/undingen/gists{/gist_id}","starred_url":"https://api.github.com/users/undingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/undingen/subscriptions","organizations_url":"https://api.github.com/users/undingen/orgs","repos_url":"https://api.github.com/users/undingen/repos","events_url":"https://api.github.com/users/undingen/events{/privacy}","received_events_url":"https://api.github.com/users/undingen/received_events","type":"User","site_admin":false},"body":"The first one (memory error) was the one I initially was planning to fix but then I run the test with ```-n``` and saw that there are additional problems. I'm somewhat surprised that no current test triggers them.\r\n\r\nI'm not sure if ```AbstractFunctionType::callType``` should not in addition return ```UNKNOWN``` instead of ```UNDEF```. Because of this we will trigger an assert if we can't find a function that supports the requested args instead of just throwing an exception at runtime.\r\nI don't like the ```AbstractFunctionType``` arg handling code I think it shouldn't copy so much, but I'm not currently feeling like rewriting it...\r\n","created_at":"2015-08-24T14:33:37Z","updated_at":"2015-08-24T21:13:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"292c1432c623a42e7a83766a2327755047214925","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dropbox/pyston/pulls/861/commits","review_comments_url":"https://api.github.com/repos/dropbox/pyston/pulls/861/comments","review_comment_url":"https://api.github.com/repos/dropbox/pyston/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dropbox/pyston/issues/861/comments","statuses_url":"https://api.github.com/repos/dropbox/pyston/statuses/60131ac6037de6cdf071a515211fa5b803509094","head":{"label":"undingen:math_test_fixes","ref":"math_test_fixes","sha":"60131ac6037de6cdf071a515211fa5b803509094","user":{"login":"undingen","id":7397630,"avatar_url":"https://avatars.githubusercontent.com/u/7397630?v=3","gravatar_id":"","url":"https://api.github.com/users/undingen","html_url":"https://github.com/undingen","followers_url":"https://api.github.com/users/undingen/followers","following_url":"https://api.github.com/users/undingen/following{/other_user}","gists_url":"https://api.github.com/users/undingen/gists{/gist_id}","starred_url":"https://api.github.com/users/undingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/undingen/subscriptions","organizations_url":"https://api.github.com/users/undingen/orgs","repos_url":"https://api.github.com/users/undingen/repos","events_url":"https://api.github.com/users/undingen/events{/privacy}","received_events_url":"https://api.github.com/users/undingen/received_events","type":"User","site_admin":false},"repo":{"id":19117126,"name":"pyston","full_name":"undingen/pyston","owner":{"login":"undingen","id":7397630,"avatar_url":"https://avatars.githubusercontent.com/u/7397630?v=3","gravatar_id":"","url":"https://api.github.com/users/undingen","html_url":"https://github.com/undingen","followers_url":"https://api.github.com/users/undingen/followers","following_url":"https://api.github.com/users/undingen/following{/other_user}","gists_url":"https://api.github.com/users/undingen/gists{/gist_id}","starred_url":"https://api.github.com/users/undingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/undingen/subscriptions","organizations_url":"https://api.github.com/users/undingen/orgs","repos_url":"https://api.github.com/users/undingen/repos","events_url":"https://api.github.com/users/undingen/events{/privacy}","received_events_url":"https://api.github.com/users/undingen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/undingen/pyston","description":"An open-source Python implementation using JIT techniques. ","fork":true,"url":"https://api.github.com/repos/undingen/pyston","forks_url":"https://api.github.com/repos/undingen/pyston/forks","keys_url":"https://api.github.com/repos/undingen/pyston/keys{/key_id}","collaborators_url":"https://api.github.com/repos/undingen/pyston/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/undingen/pyston/teams","hooks_url":"https://api.github.com/repos/undingen/pyston/hooks","issue_events_url":"https://api.github.com/repos/undingen/pyston/issues/events{/number}","events_url":"https://api.github.com/repos/undingen/pyston/events","assignees_url":"https://api.github.com/repos/undingen/pyston/assignees{/user}","branches_url":"https://api.github.com/repos/undingen/pyston/branches{/branch}","tags_url":"https://api.github.com/repos/undingen/pyston/tags","blobs_url":"https://api.github.com/repos/undingen/pyston/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/undingen/pyston/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/undingen/pyston/git/refs{/sha}","trees_url":"https://api.github.com/repos/undingen/pyston/git/trees{/sha}","statuses_url":"https://api.github.com/repos/undingen/pyston/statuses/{sha}","languages_url":"https://api.github.com/repos/undingen/pyston/languages","stargazers_url":"https://api.github.com/repos/undingen/pyston/stargazers","contributors_url":"https://api.github.com/repos/undingen/pyston/contributors","subscribers_url":"https://api.github.com/repos/undingen/pyston/subscribers","subscription_url":"https://api.github.com/repos/undingen/pyston/subscription","commits_url":"https://api.github.com/repos/undingen/pyston/commits{/sha}","git_commits_url":"https://api.github.com/repos/undingen/pyston/git/commits{/sha}","comments_url":"https://api.github.com/repos/undingen/pyston/comments{/number}","issue_comment_url":"https://api.github.com/repos/undingen/pyston/issues/comments{/number}","contents_url":"https://api.github.com/repos/undingen/pyston/contents/{+path}","compare_url":"https://api.github.com/repos/undingen/pyston/compare/{base}...{head}","merges_url":"https://api.github.com/repos/undingen/pyston/merges","archive_url":"https://api.github.com/repos/undingen/pyston/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/undingen/pyston/downloads","issues_url":"https://api.github.com/repos/undingen/pyston/issues{/number}","pulls_url":"https://api.github.com/repos/undingen/pyston/pulls{/number}","milestones_url":"https://api.github.com/repos/undingen/pyston/milestones{/number}","notifications_url":"https://api.github.com/repos/undingen/pyston/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/undingen/pyston/labels{/name}","releases_url":"https://api.github.com/repos/undingen/pyston/releases{/id}","created_at":"2014-04-24T17:17:10Z","updated_at":"2015-01-27T22:17:13Z","pushed_at":"2015-08-24T16:08:18Z","git_url":"git://github.com/undingen/pyston.git","ssh_url":"git@github.com:undingen/pyston.git","clone_url":"https://github.com/undingen/pyston.git","svn_url":"https://github.com/undingen/pyston","homepage":"https://tech.dropbox.com/2014/04/introducing-pyston-an-upcoming-jit-based-python-implementation/","size":27490,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dropbox:master","ref":"master","sha":"0fc53b70206e612fc2e0824e7610b9d39ff6b856","user":{"login":"dropbox","id":559357,"avatar_url":"https://avatars.githubusercontent.com/u/559357?v=3","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"repo":{"id":18320947,"name":"pyston","full_name":"dropbox/pyston","owner":{"login":"dropbox","id":559357,"avatar_url":"https://avatars.githubusercontent.com/u/559357?v=3","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dropbox/pyston","description":"An open-source Python implementation using JIT techniques. ","fork":false,"url":"https://api.github.com/repos/dropbox/pyston","forks_url":"https://api.github.com/repos/dropbox/pyston/forks","keys_url":"https://api.github.com/repos/dropbox/pyston/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dropbox/pyston/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dropbox/pyston/teams","hooks_url":"https://api.github.com/repos/dropbox/pyston/hooks","issue_events_url":"https://api.github.com/repos/dropbox/pyston/issues/events{/number}","events_url":"https://api.github.com/repos/dropbox/pyston/events","assignees_url":"https://api.github.com/repos/dropbox/pyston/assignees{/user}","branches_url":"https://api.github.com/repos/dropbox/pyston/branches{/branch}","tags_url":"https://api.github.com/repos/dropbox/pyston/tags","blobs_url":"https://api.github.com/repos/dropbox/pyston/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dropbox/pyston/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dropbox/pyston/git/refs{/sha}","trees_url":"https://api.github.com/repos/dropbox/pyston/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dropbox/pyston/statuses/{sha}","languages_url":"https://api.github.com/repos/dropbox/pyston/languages","stargazers_url":"https://api.github.com/repos/dropbox/pyston/stargazers","contributors_url":"https://api.github.com/repos/dropbox/pyston/contributors","subscribers_url":"https://api.github.com/repos/dropbox/pyston/subscribers","subscription_url":"https://api.github.com/repos/dropbox/pyston/subscription","commits_url":"https://api.github.com/repos/dropbox/pyston/commits{/sha}","git_commits_url":"https://api.github.com/repos/dropbox/pyston/git/commits{/sha}","comments_url":"https://api.github.com/repos/dropbox/pyston/comments{/number}","issue_comment_url":"https://api.github.com/repos/dropbox/pyston/issues/comments{/number}","contents_url":"https://api.github.com/repos/dropbox/pyston/contents/{+path}","compare_url":"https://api.github.com/repos/dropbox/pyston/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dropbox/pyston/merges","archive_url":"https://api.github.com/repos/dropbox/pyston/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dropbox/pyston/downloads","issues_url":"https://api.github.com/repos/dropbox/pyston/issues{/number}","pulls_url":"https://api.github.com/repos/dropbox/pyston/pulls{/number}","milestones_url":"https://api.github.com/repos/dropbox/pyston/milestones{/number}","notifications_url":"https://api.github.com/repos/dropbox/pyston/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dropbox/pyston/labels{/name}","releases_url":"https://api.github.com/repos/dropbox/pyston/releases{/id}","created_at":"2014-04-01T07:17:20Z","updated_at":"2015-08-24T10:12:47Z","pushed_at":"2015-08-24T21:05:30Z","git_url":"git://github.com/dropbox/pyston.git","ssh_url":"git@github.com:dropbox/pyston.git","clone_url":"https://github.com/dropbox/pyston.git","svn_url":"https://github.com/dropbox/pyston","homepage":"https://tech.dropbox.com/2014/04/introducing-pyston-an-upcoming-jit-based-python-implementation/","size":37836,"stargazers_count":3096,"watchers_count":3096,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":221,"mirror_url":null,"open_issues_count":71,"forks":221,"open_issues":71,"watchers":3096,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/861"},"html":{"href":"https://github.com/dropbox/pyston/pull/861"},"issue":{"href":"https://api.github.com/repos/dropbox/pyston/issues/861"},"comments":{"href":"https://api.github.com/repos/dropbox/pyston/issues/861/comments"},"review_comments":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/861/comments"},"review_comment":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/861/commits"},"statuses":{"href":"https://api.github.com/repos/dropbox/pyston/statuses/60131ac6037de6cdf071a515211fa5b803509094"}}}}