{"action":"created","comment":{"url":"https://api.github.com/repos/mono/mono/pulls/comments/29099413","id":29099413,"diff_hunk":"@@ -1232,9 +1232,13 @@ private static TimeZoneInfo ParseTZBuffer (string id, byte [] buffer, int length\n \t\t\t\t\tdst_observed = false;\n \t\t\t\t} else {\n \t\t\t\t\tif (daylightDisplayName != ttype.Name)\n-\t\t\t\t\t\tdaylightDisplayName = ttype.Name;\n-\t\t\t\t\tif (dstDelta.TotalSeconds != ttype.Offset - baseUtcOffset.TotalSeconds)\n-\t\t\t\t\t\tdstDelta = new TimeSpan(0, 0, ttype.Offset) - baseUtcOffset;\n+\t\t\t\t\tdaylightDisplayName = ttype.Name;","path":"mcs/class/corlib/System/TimeZoneInfo.cs","position":7,"original_position":7,"commit_id":"a4ba42d547bc83138a70d96b73a4bfa11510153e","original_commit_id":"a4ba42d547bc83138a70d96b73a4bfa11510153e","user":{"login":"esdrubal","id":1188095,"avatar_url":"https://avatars.githubusercontent.com/u/1188095?v=3","gravatar_id":"","url":"https://api.github.com/users/esdrubal","html_url":"https://github.com/esdrubal","followers_url":"https://api.github.com/users/esdrubal/followers","following_url":"https://api.github.com/users/esdrubal/following{/other_user}","gists_url":"https://api.github.com/users/esdrubal/gists{/gist_id}","starred_url":"https://api.github.com/users/esdrubal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esdrubal/subscriptions","organizations_url":"https://api.github.com/users/esdrubal/orgs","repos_url":"https://api.github.com/users/esdrubal/repos","events_url":"https://api.github.com/users/esdrubal/events{/privacy}","received_events_url":"https://api.github.com/users/esdrubal/received_events","type":"User","site_admin":false},"body":"Missing indentation on line 1235.","created_at":"2015-04-25T09:50:44Z","updated_at":"2015-04-25T09:50:44Z","html_url":"https://github.com/mono/mono/pull/1738#discussion_r29099413","pull_request_url":"https://api.github.com/repos/mono/mono/pulls/1738","_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/comments/29099413"},"html":{"href":"https://github.com/mono/mono/pull/1738#discussion_r29099413"},"pull_request":{"href":"https://api.github.com/repos/mono/mono/pulls/1738"}}},"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/1738","id":34039764,"html_url":"https://github.com/mono/mono/pull/1738","diff_url":"https://github.com/mono/mono/pull/1738.diff","patch_url":"https://github.com/mono/mono/pull/1738.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/1738","number":1738,"state":"open","locked":false,"title":"[corlib] Cope with the reference sources' inability to support sub-minute DST offsets","user":{"login":"rolfbjarne","id":249268,"avatar_url":"https://avatars.githubusercontent.com/u/249268?v=3","gravatar_id":"","url":"https://api.github.com/users/rolfbjarne","html_url":"https://github.com/rolfbjarne","followers_url":"https://api.github.com/users/rolfbjarne/followers","following_url":"https://api.github.com/users/rolfbjarne/following{/other_user}","gists_url":"https://api.github.com/users/rolfbjarne/gists{/gist_id}","starred_url":"https://api.github.com/users/rolfbjarne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolfbjarne/subscriptions","organizations_url":"https://api.github.com/users/rolfbjarne/orgs","repos_url":"https://api.github.com/users/rolfbjarne/repos","events_url":"https://api.github.com/users/rolfbjarne/events{/privacy}","received_events_url":"https://api.github.com/users/rolfbjarne/received_events","type":"User","site_admin":false},"body":"The reference sources do not support sub-minute DST offsets as the exception below\r\nshows, while Europe/Dublin has a DST offset of 34:39 in 1916.\r\n\r\nThere is no equivalent TimeZoneInfo for Europe/Dublin in .NET, so the problem\r\ndoesn't show up there.\r\n\r\nSystem.ArgumentException: The TimeSpan parameter cannot be specified more precisely than whole minutes.\r\n\tParameter name: daylightDelta\r\n\r\n  at System.TimeZoneInfo/AdjustmentRule.ValidateAdjustmentRule (System.DateTime,System.DateTime,System.TimeSpan,System.TimeZoneInfo/TransitionTime,System.TimeZoneInfo/TransitionTime) [0x0012c] in /work/mono/master/external/referencesource/mscorlib/system/timezoneinfo.cs:3907\r\n  at System.TimeZoneInfo/AdjustmentRule.CreateAdjustmentRule (System.DateTime,System.DateTime,System.TimeSpan,System.TimeZoneInfo/TransitionTime,System.TimeZoneInfo/TransitionTime) [0x00000] in /work/mono/master/external/referencesource/mscorlib/system/timezoneinfo.cs:3836\r\n  at System.TimeZoneInfo.ParseTZBuffer (string,byte[],int) [0x002ca] in /work/mono/master/mcs/class/corlib/System/TimeZoneInfo.cs:1230\r\n  at System.TimeZoneInfo.BuildFromStream (string,System.IO.Stream) [0x00030] in /work/mono/master/mcs/class/corlib/System/TimeZoneInfo.cs:479\r\n  at System.TimeZoneInfo.FindSystemTimeZoneByFileName (string,string) [0x00018] in /work/mono/master/mcs/class/corlib/System/TimeZoneInfo.cs:463\r\n  at System.TimeZoneInfo.FindSystemTimeZoneById (string) [0x00075] in /work/mono/master/mcs/class/corlib/System/TimeZoneInfo.cs:450\r\n  at MonoTests.System.TimeZoneInfoTest/FindSystemTimeZoneByIdTests.Dublin () [0x00015] in /work/mono/master/mcs/class/corlib/Test/System/TimeZoneInfoTest.cs:812","created_at":"2015-04-24T11:22:35Z","updated_at":"2015-04-25T09:50:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bf2dcedd0b072ffaaff66275324e5753f7f0868","assignee":{"login":"esdrubal","id":1188095,"avatar_url":"https://avatars.githubusercontent.com/u/1188095?v=3","gravatar_id":"","url":"https://api.github.com/users/esdrubal","html_url":"https://github.com/esdrubal","followers_url":"https://api.github.com/users/esdrubal/followers","following_url":"https://api.github.com/users/esdrubal/following{/other_user}","gists_url":"https://api.github.com/users/esdrubal/gists{/gist_id}","starred_url":"https://api.github.com/users/esdrubal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esdrubal/subscriptions","organizations_url":"https://api.github.com/users/esdrubal/orgs","repos_url":"https://api.github.com/users/esdrubal/repos","events_url":"https://api.github.com/users/esdrubal/events{/privacy}","received_events_url":"https://api.github.com/users/esdrubal/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/1738/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/1738/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/1738/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/a4ba42d547bc83138a70d96b73a4bfa11510153e","head":{"label":"rolfbjarne:dublin-1916-dst","ref":"dublin-1916-dst","sha":"a4ba42d547bc83138a70d96b73a4bfa11510153e","user":{"login":"rolfbjarne","id":249268,"avatar_url":"https://avatars.githubusercontent.com/u/249268?v=3","gravatar_id":"","url":"https://api.github.com/users/rolfbjarne","html_url":"https://github.com/rolfbjarne","followers_url":"https://api.github.com/users/rolfbjarne/followers","following_url":"https://api.github.com/users/rolfbjarne/following{/other_user}","gists_url":"https://api.github.com/users/rolfbjarne/gists{/gist_id}","starred_url":"https://api.github.com/users/rolfbjarne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolfbjarne/subscriptions","organizations_url":"https://api.github.com/users/rolfbjarne/orgs","repos_url":"https://api.github.com/users/rolfbjarne/repos","events_url":"https://api.github.com/users/rolfbjarne/events{/privacy}","received_events_url":"https://api.github.com/users/rolfbjarne/received_events","type":"User","site_admin":false},"repo":{"id":18690580,"name":"mono","full_name":"rolfbjarne/mono","owner":{"login":"rolfbjarne","id":249268,"avatar_url":"https://avatars.githubusercontent.com/u/249268?v=3","gravatar_id":"","url":"https://api.github.com/users/rolfbjarne","html_url":"https://github.com/rolfbjarne","followers_url":"https://api.github.com/users/rolfbjarne/followers","following_url":"https://api.github.com/users/rolfbjarne/following{/other_user}","gists_url":"https://api.github.com/users/rolfbjarne/gists{/gist_id}","starred_url":"https://api.github.com/users/rolfbjarne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolfbjarne/subscriptions","organizations_url":"https://api.github.com/users/rolfbjarne/orgs","repos_url":"https://api.github.com/users/rolfbjarne/repos","events_url":"https://api.github.com/users/rolfbjarne/events{/privacy}","received_events_url":"https://api.github.com/users/rolfbjarne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rolfbjarne/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/rolfbjarne/mono","forks_url":"https://api.github.com/repos/rolfbjarne/mono/forks","keys_url":"https://api.github.com/repos/rolfbjarne/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rolfbjarne/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rolfbjarne/mono/teams","hooks_url":"https://api.github.com/repos/rolfbjarne/mono/hooks","issue_events_url":"https://api.github.com/repos/rolfbjarne/mono/issues/events{/number}","events_url":"https://api.github.com/repos/rolfbjarne/mono/events","assignees_url":"https://api.github.com/repos/rolfbjarne/mono/assignees{/user}","branches_url":"https://api.github.com/repos/rolfbjarne/mono/branches{/branch}","tags_url":"https://api.github.com/repos/rolfbjarne/mono/tags","blobs_url":"https://api.github.com/repos/rolfbjarne/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rolfbjarne/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rolfbjarne/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/rolfbjarne/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rolfbjarne/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/rolfbjarne/mono/languages","stargazers_url":"https://api.github.com/repos/rolfbjarne/mono/stargazers","contributors_url":"https://api.github.com/repos/rolfbjarne/mono/contributors","subscribers_url":"https://api.github.com/repos/rolfbjarne/mono/subscribers","subscription_url":"https://api.github.com/repos/rolfbjarne/mono/subscription","commits_url":"https://api.github.com/repos/rolfbjarne/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/rolfbjarne/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/rolfbjarne/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/rolfbjarne/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/rolfbjarne/mono/contents/{+path}","compare_url":"https://api.github.com/repos/rolfbjarne/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rolfbjarne/mono/merges","archive_url":"https://api.github.com/repos/rolfbjarne/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rolfbjarne/mono/downloads","issues_url":"https://api.github.com/repos/rolfbjarne/mono/issues{/number}","pulls_url":"https://api.github.com/repos/rolfbjarne/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/rolfbjarne/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/rolfbjarne/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rolfbjarne/mono/labels{/name}","releases_url":"https://api.github.com/repos/rolfbjarne/mono/releases{/id}","created_at":"2014-04-11T22:26:03Z","updated_at":"2015-04-24T11:22:00Z","pushed_at":"2015-04-24T11:21:24Z","git_url":"git://github.com/rolfbjarne/mono.git","ssh_url":"git@github.com:rolfbjarne/mono.git","clone_url":"https://github.com/rolfbjarne/mono.git","svn_url":"https://github.com/rolfbjarne/mono","homepage":"http://www.mono-project.com/","size":428922,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"f0e27b34c64408edfc6779ddbfce00798df6b1df","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","created_at":"2010-07-22T18:06:36Z","updated_at":"2015-04-25T05:10:33Z","pushed_at":"2015-04-25T05:10:29Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":1372171,"stargazers_count":3312,"watchers_count":3312,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1663,"mirror_url":null,"open_issues_count":100,"forks":1663,"open_issues":100,"watchers":3312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/1738"},"html":{"href":"https://github.com/mono/mono/pull/1738"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/1738"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/1738/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/1738/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/1738/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/a4ba42d547bc83138a70d96b73a4bfa11510153e"}}}}