{"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/comments/40534162","id":40534162,"diff_hunk":"@@ -202,13 +215,20 @@ def filter(event)\n \t\t\tmap = aggregate_maps_element.map\n \n \t\t\t# execute the code to read/update map and event\n-\t\t\t@codeblock.call(event, map)\n+\t\t\tbegin\n+\t\t\t\t@codeblock.call(event, map)\n+\t\t\t\tnoError = true\n+\t\t\trescue Exception => exception","path":"lib/logstash/filters/aggregate.rb","position":93,"original_position":93,"commit_id":"b6e9ca8c1afa8a0dc17f605354640aebca8569f8","original_commit_id":"b6e9ca8c1afa8a0dc17f605354640aebca8569f8","user":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"body":"sure, also not much good :+1: thanks man.","created_at":"2015-09-28T09:43:46Z","updated_at":"2015-09-28T09:43:46Z","html_url":"https://github.com/logstash-plugins/logstash-filter-aggregate/pull/6#discussion_r40534162","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/comments/40534162"},"html":{"href":"https://github.com/logstash-plugins/logstash-filter-aggregate/pull/6#discussion_r40534162"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/6","id":46108688,"html_url":"https://github.com/logstash-plugins/logstash-filter-aggregate/pull/6","diff_url":"https://github.com/logstash-plugins/logstash-filter-aggregate/pull/6.diff","patch_url":"https://github.com/logstash-plugins/logstash-filter-aggregate/pull/6.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/issues/6","number":6,"state":"open","locked":false,"title":"Fix issue #5 on branch core-api-v1","user":{"login":"fbaligand","id":3750300,"avatar_url":"https://avatars.githubusercontent.com/u/3750300?v=3","gravatar_id":"","url":"https://api.github.com/users/fbaligand","html_url":"https://github.com/fbaligand","followers_url":"https://api.github.com/users/fbaligand/followers","following_url":"https://api.github.com/users/fbaligand/following{/other_user}","gists_url":"https://api.github.com/users/fbaligand/gists{/gist_id}","starred_url":"https://api.github.com/users/fbaligand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbaligand/subscriptions","organizations_url":"https://api.github.com/users/fbaligand/orgs","repos_url":"https://api.github.com/users/fbaligand/repos","events_url":"https://api.github.com/users/fbaligand/events{/privacy}","received_events_url":"https://api.github.com/users/fbaligand/received_events","type":"User","site_admin":false},"body":"Fix issue #5.\r\nWhen code call raises an exception, the error is logged and the event is tagged '_aggregateexception'.\r\nThus, it avoids logstash crash","created_at":"2015-09-27T20:57:46Z","updated_at":"2015-09-28T09:43:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11a19fbf2c945182af1804d8a36ee2110f60ec85","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/6/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/6/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/issues/6/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/statuses/b6e9ca8c1afa8a0dc17f605354640aebca8569f8","head":{"label":"fbaligand:core-api-v1","ref":"core-api-v1","sha":"b6e9ca8c1afa8a0dc17f605354640aebca8569f8","user":{"login":"fbaligand","id":3750300,"avatar_url":"https://avatars.githubusercontent.com/u/3750300?v=3","gravatar_id":"","url":"https://api.github.com/users/fbaligand","html_url":"https://github.com/fbaligand","followers_url":"https://api.github.com/users/fbaligand/followers","following_url":"https://api.github.com/users/fbaligand/following{/other_user}","gists_url":"https://api.github.com/users/fbaligand/gists{/gist_id}","starred_url":"https://api.github.com/users/fbaligand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbaligand/subscriptions","organizations_url":"https://api.github.com/users/fbaligand/orgs","repos_url":"https://api.github.com/users/fbaligand/repos","events_url":"https://api.github.com/users/fbaligand/events{/privacy}","received_events_url":"https://api.github.com/users/fbaligand/received_events","type":"User","site_admin":false},"repo":{"id":34081725,"name":"logstash-filter-aggregate","full_name":"fbaligand/logstash-filter-aggregate","owner":{"login":"fbaligand","id":3750300,"avatar_url":"https://avatars.githubusercontent.com/u/3750300?v=3","gravatar_id":"","url":"https://api.github.com/users/fbaligand","html_url":"https://github.com/fbaligand","followers_url":"https://api.github.com/users/fbaligand/followers","following_url":"https://api.github.com/users/fbaligand/following{/other_user}","gists_url":"https://api.github.com/users/fbaligand/gists{/gist_id}","starred_url":"https://api.github.com/users/fbaligand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbaligand/subscriptions","organizations_url":"https://api.github.com/users/fbaligand/orgs","repos_url":"https://api.github.com/users/fbaligand/repos","events_url":"https://api.github.com/users/fbaligand/events{/privacy}","received_events_url":"https://api.github.com/users/fbaligand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fbaligand/logstash-filter-aggregate","description":"The aim of this filter is to aggregate informations available among several events (typically log lines) belonging to a same task, and finally push aggregated information into final task event.","fork":true,"url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate","forks_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/forks","keys_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/teams","hooks_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/hooks","issue_events_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/issues/events{/number}","events_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/events","assignees_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/assignees{/user}","branches_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/branches{/branch}","tags_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/tags","blobs_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/statuses/{sha}","languages_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/languages","stargazers_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/stargazers","contributors_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/contributors","subscribers_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/subscribers","subscription_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/subscription","commits_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/contents/{+path}","compare_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/merges","archive_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/downloads","issues_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/issues{/number}","pulls_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/pulls{/number}","milestones_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/milestones{/number}","notifications_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/labels{/name}","releases_url":"https://api.github.com/repos/fbaligand/logstash-filter-aggregate/releases{/id}","created_at":"2015-04-16T21:32:01Z","updated_at":"2015-05-08T15:21:18Z","pushed_at":"2015-09-27T21:51:31Z","git_url":"git://github.com/fbaligand/logstash-filter-aggregate.git","ssh_url":"git@github.com:fbaligand/logstash-filter-aggregate.git","clone_url":"https://github.com/fbaligand/logstash-filter-aggregate.git","svn_url":"https://github.com/fbaligand/logstash-filter-aggregate","homepage":"","size":165,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:core-api-v1","ref":"core-api-v1","sha":"9ca9922912cf08ccaacbd3695f1c8edfc8ba5354","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":33984534,"name":"logstash-filter-aggregate","full_name":"logstash-plugins/logstash-filter-aggregate","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-filter-aggregate","description":"The aim of this filter is to aggregate informations available among several events (typically log lines) belonging to a same task, and finally push aggregated information into final task event.","fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/releases{/id}","created_at":"2015-04-15T09:16:31Z","updated_at":"2015-09-22T12:52:12Z","pushed_at":"2015-09-27T21:02:27Z","git_url":"git://github.com/logstash-plugins/logstash-filter-aggregate.git","ssh_url":"git@github.com:logstash-plugins/logstash-filter-aggregate.git","clone_url":"https://github.com/logstash-plugins/logstash-filter-aggregate.git","svn_url":"https://github.com/logstash-plugins/logstash-filter-aggregate","homepage":null,"size":198,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/6"},"html":{"href":"https://github.com/logstash-plugins/logstash-filter-aggregate/pull/6"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/issues/6"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/statuses/b6e9ca8c1afa8a0dc17f605354640aebca8569f8"}}}}