{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/fresco/pulls/comments/38540593","id":38540593,"diff_hunk":"@@ -151,6 +151,7 @@ public void draw(Canvas canvas) {\n   private final int mFailureImageIndex;\n   private final int mControllerOverlayIndex;\n \n+  private ScaleType mPlaceHolderScaleType;","path":"drawee/src/main/java/com/facebook/drawee/generic/GenericDraweeHierarchy.java","position":4,"original_position":4,"commit_id":"9e4fef4b07663cb25777708e92653254d34868a1","original_commit_id":"9e4fef4b07663cb25777708e92653254d34868a1","user":{"login":"plamenko","id":3705123,"avatar_url":"https://avatars.githubusercontent.com/u/3705123?v=3","gravatar_id":"","url":"https://api.github.com/users/plamenko","html_url":"https://github.com/plamenko","followers_url":"https://api.github.com/users/plamenko/followers","following_url":"https://api.github.com/users/plamenko/following{/other_user}","gists_url":"https://api.github.com/users/plamenko/gists{/gist_id}","starred_url":"https://api.github.com/users/plamenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plamenko/subscriptions","organizations_url":"https://api.github.com/users/plamenko/orgs","repos_url":"https://api.github.com/users/plamenko/repos","events_url":"https://api.github.com/users/plamenko/events{/privacy}","received_events_url":"https://api.github.com/users/plamenko/received_events","type":"User","site_admin":false},"body":"No need for this to be a member variable.","created_at":"2015-09-02T14:49:47Z","updated_at":"2015-09-02T14:49:47Z","html_url":"https://github.com/facebook/fresco/pull/586#discussion_r38540593","pull_request_url":"https://api.github.com/repos/facebook/fresco/pulls/586","_links":{"self":{"href":"https://api.github.com/repos/facebook/fresco/pulls/comments/38540593"},"html":{"href":"https://github.com/facebook/fresco/pull/586#discussion_r38540593"},"pull_request":{"href":"https://api.github.com/repos/facebook/fresco/pulls/586"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/fresco/pulls/586","id":43779301,"html_url":"https://github.com/facebook/fresco/pull/586","diff_url":"https://github.com/facebook/fresco/pull/586.diff","patch_url":"https://github.com/facebook/fresco/pull/586.patch","issue_url":"https://api.github.com/repos/facebook/fresco/issues/586","number":586,"state":"open","locked":false,"title":"Set default placeholder scaleType if none is provided","user":{"login":"tbruceyu","id":1342575,"avatar_url":"https://avatars.githubusercontent.com/u/1342575?v=3","gravatar_id":"","url":"https://api.github.com/users/tbruceyu","html_url":"https://github.com/tbruceyu","followers_url":"https://api.github.com/users/tbruceyu/followers","following_url":"https://api.github.com/users/tbruceyu/following{/other_user}","gists_url":"https://api.github.com/users/tbruceyu/gists{/gist_id}","starred_url":"https://api.github.com/users/tbruceyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbruceyu/subscriptions","organizations_url":"https://api.github.com/users/tbruceyu/orgs","repos_url":"https://api.github.com/users/tbruceyu/repos","events_url":"https://api.github.com/users/tbruceyu/events{/privacy}","received_events_url":"https://api.github.com/users/tbruceyu/received_events","type":"User","site_admin":false},"body":"This is a bug fix if we want to use the setPlaceHolderImage in GenericDraweeHierarchy to set a place holder image.\r\nSometimes, we need to set the placeHolder in DraweeHierarchy. But if\r\nwe never set the placeHolder before, the setPlaceholderImage would not\r\nset the scaleType. This fix added a default scale type when we set the\r\nplace holder image in code.","created_at":"2015-08-31T15:56:55Z","updated_at":"2015-09-02T14:49:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55399d2bc4532f4e7016d8b17746ccc2f9010930","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/fresco/pulls/586/commits","review_comments_url":"https://api.github.com/repos/facebook/fresco/pulls/586/comments","review_comment_url":"https://api.github.com/repos/facebook/fresco/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/fresco/issues/586/comments","statuses_url":"https://api.github.com/repos/facebook/fresco/statuses/9e4fef4b07663cb25777708e92653254d34868a1","head":{"label":"tbruceyu:master","ref":"master","sha":"9e4fef4b07663cb25777708e92653254d34868a1","user":{"login":"tbruceyu","id":1342575,"avatar_url":"https://avatars.githubusercontent.com/u/1342575?v=3","gravatar_id":"","url":"https://api.github.com/users/tbruceyu","html_url":"https://github.com/tbruceyu","followers_url":"https://api.github.com/users/tbruceyu/followers","following_url":"https://api.github.com/users/tbruceyu/following{/other_user}","gists_url":"https://api.github.com/users/tbruceyu/gists{/gist_id}","starred_url":"https://api.github.com/users/tbruceyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbruceyu/subscriptions","organizations_url":"https://api.github.com/users/tbruceyu/orgs","repos_url":"https://api.github.com/users/tbruceyu/repos","events_url":"https://api.github.com/users/tbruceyu/events{/privacy}","received_events_url":"https://api.github.com/users/tbruceyu/received_events","type":"User","site_admin":false},"repo":{"id":41679905,"name":"fresco","full_name":"tbruceyu/fresco","owner":{"login":"tbruceyu","id":1342575,"avatar_url":"https://avatars.githubusercontent.com/u/1342575?v=3","gravatar_id":"","url":"https://api.github.com/users/tbruceyu","html_url":"https://github.com/tbruceyu","followers_url":"https://api.github.com/users/tbruceyu/followers","following_url":"https://api.github.com/users/tbruceyu/following{/other_user}","gists_url":"https://api.github.com/users/tbruceyu/gists{/gist_id}","starred_url":"https://api.github.com/users/tbruceyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbruceyu/subscriptions","organizations_url":"https://api.github.com/users/tbruceyu/orgs","repos_url":"https://api.github.com/users/tbruceyu/repos","events_url":"https://api.github.com/users/tbruceyu/events{/privacy}","received_events_url":"https://api.github.com/users/tbruceyu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbruceyu/fresco","description":"An Android library for managing images and the memory they use.","fork":true,"url":"https://api.github.com/repos/tbruceyu/fresco","forks_url":"https://api.github.com/repos/tbruceyu/fresco/forks","keys_url":"https://api.github.com/repos/tbruceyu/fresco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbruceyu/fresco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbruceyu/fresco/teams","hooks_url":"https://api.github.com/repos/tbruceyu/fresco/hooks","issue_events_url":"https://api.github.com/repos/tbruceyu/fresco/issues/events{/number}","events_url":"https://api.github.com/repos/tbruceyu/fresco/events","assignees_url":"https://api.github.com/repos/tbruceyu/fresco/assignees{/user}","branches_url":"https://api.github.com/repos/tbruceyu/fresco/branches{/branch}","tags_url":"https://api.github.com/repos/tbruceyu/fresco/tags","blobs_url":"https://api.github.com/repos/tbruceyu/fresco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbruceyu/fresco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbruceyu/fresco/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbruceyu/fresco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbruceyu/fresco/statuses/{sha}","languages_url":"https://api.github.com/repos/tbruceyu/fresco/languages","stargazers_url":"https://api.github.com/repos/tbruceyu/fresco/stargazers","contributors_url":"https://api.github.com/repos/tbruceyu/fresco/contributors","subscribers_url":"https://api.github.com/repos/tbruceyu/fresco/subscribers","subscription_url":"https://api.github.com/repos/tbruceyu/fresco/subscription","commits_url":"https://api.github.com/repos/tbruceyu/fresco/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbruceyu/fresco/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbruceyu/fresco/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbruceyu/fresco/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbruceyu/fresco/contents/{+path}","compare_url":"https://api.github.com/repos/tbruceyu/fresco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbruceyu/fresco/merges","archive_url":"https://api.github.com/repos/tbruceyu/fresco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbruceyu/fresco/downloads","issues_url":"https://api.github.com/repos/tbruceyu/fresco/issues{/number}","pulls_url":"https://api.github.com/repos/tbruceyu/fresco/pulls{/number}","milestones_url":"https://api.github.com/repos/tbruceyu/fresco/milestones{/number}","notifications_url":"https://api.github.com/repos/tbruceyu/fresco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbruceyu/fresco/labels{/name}","releases_url":"https://api.github.com/repos/tbruceyu/fresco/releases{/id}","created_at":"2015-08-31T14:26:37Z","updated_at":"2015-08-31T14:26:39Z","pushed_at":"2015-08-31T15:55:03Z","git_url":"git://github.com/tbruceyu/fresco.git","ssh_url":"git@github.com:tbruceyu/fresco.git","clone_url":"https://github.com/tbruceyu/fresco.git","svn_url":"https://github.com/tbruceyu/fresco","homepage":"http://frescolib.org/","size":12943,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"0f3d52318631f2125e080d2a19f6fa13a31efb31","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":31533997,"name":"fresco","full_name":"facebook/fresco","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/fresco","description":"An Android library for managing images and the memory they use.","fork":false,"url":"https://api.github.com/repos/facebook/fresco","forks_url":"https://api.github.com/repos/facebook/fresco/forks","keys_url":"https://api.github.com/repos/facebook/fresco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/fresco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/fresco/teams","hooks_url":"https://api.github.com/repos/facebook/fresco/hooks","issue_events_url":"https://api.github.com/repos/facebook/fresco/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/fresco/events","assignees_url":"https://api.github.com/repos/facebook/fresco/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/fresco/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/fresco/tags","blobs_url":"https://api.github.com/repos/facebook/fresco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/fresco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/fresco/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/fresco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/fresco/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/fresco/languages","stargazers_url":"https://api.github.com/repos/facebook/fresco/stargazers","contributors_url":"https://api.github.com/repos/facebook/fresco/contributors","subscribers_url":"https://api.github.com/repos/facebook/fresco/subscribers","subscription_url":"https://api.github.com/repos/facebook/fresco/subscription","commits_url":"https://api.github.com/repos/facebook/fresco/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/fresco/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/fresco/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/fresco/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/fresco/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/fresco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/fresco/merges","archive_url":"https://api.github.com/repos/facebook/fresco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/fresco/downloads","issues_url":"https://api.github.com/repos/facebook/fresco/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/fresco/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/fresco/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/fresco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/fresco/labels{/name}","releases_url":"https://api.github.com/repos/facebook/fresco/releases{/id}","created_at":"2015-03-02T09:58:04Z","updated_at":"2015-09-02T10:16:30Z","pushed_at":"2015-08-31T15:56:56Z","git_url":"git://github.com/facebook/fresco.git","ssh_url":"git@github.com:facebook/fresco.git","clone_url":"https://github.com/facebook/fresco.git","svn_url":"https://github.com/facebook/fresco","homepage":"http://frescolib.org/","size":15672,"stargazers_count":5886,"watchers_count":5886,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1590,"mirror_url":null,"open_issues_count":125,"forks":1590,"open_issues":125,"watchers":5886,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/fresco/pulls/586"},"html":{"href":"https://github.com/facebook/fresco/pull/586"},"issue":{"href":"https://api.github.com/repos/facebook/fresco/issues/586"},"comments":{"href":"https://api.github.com/repos/facebook/fresco/issues/586/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/fresco/pulls/586/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/fresco/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/fresco/pulls/586/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/fresco/statuses/9e4fef4b07663cb25777708e92653254d34868a1"}}}}