{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/15324","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/15324/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/15324/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/15324/events","html_url":"https://github.com/elastic/elasticsearch/pull/15324","id":121078403,"number":15324,"title":"Enable HighlightBuilder to create SearchContextHighlight","user":{"login":"cbuescher","id":10398885,"avatar_url":"https://avatars.githubusercontent.com/u/10398885?v=3","gravatar_id":"","url":"https://api.github.com/users/cbuescher","html_url":"https://github.com/cbuescher","followers_url":"https://api.github.com/users/cbuescher/followers","following_url":"https://api.github.com/users/cbuescher/following{/other_user}","gists_url":"https://api.github.com/users/cbuescher/gists{/gist_id}","starred_url":"https://api.github.com/users/cbuescher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbuescher/subscriptions","organizations_url":"https://api.github.com/users/cbuescher/orgs","repos_url":"https://api.github.com/users/cbuescher/repos","events_url":"https://api.github.com/users/cbuescher/events{/privacy}","received_events_url":"https://api.github.com/users/cbuescher/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Highlighting","name":":Highlighting","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Search%20Refactoring","name":":Search Refactoring","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/enhancement","name":"enhancement","color":"4a4ea8"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/review","name":"review","color":"0052cc"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v3.0.0","name":"v3.0.0","color":"dddddd"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-08T19:16:56Z","updated_at":"2015-12-09T17:09:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/15324","html_url":"https://github.com/elastic/elasticsearch/pull/15324","diff_url":"https://github.com/elastic/elasticsearch/pull/15324.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/15324.patch"},"body":"This enables the HighlightBuilder to procude a SeachContextHighlight object which contains the merged global options and field options. Also adding tests that make sure the produced SearchContextHighlighter is similar to the one we would get when parsing the xContent directly with the current HighlightParseElement. The duplication of the parsing logic in HighlightBuilder and SearchContextHighlighter will be removed in subsequent PRs."},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/163326972","html_url":"https://github.com/elastic/elasticsearch/pull/15324#issuecomment-163326972","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/15324","id":163326972,"user":{"login":"cbuescher","id":10398885,"avatar_url":"https://avatars.githubusercontent.com/u/10398885?v=3","gravatar_id":"","url":"https://api.github.com/users/cbuescher","html_url":"https://github.com/cbuescher","followers_url":"https://api.github.com/users/cbuescher/followers","following_url":"https://api.github.com/users/cbuescher/following{/other_user}","gists_url":"https://api.github.com/users/cbuescher/gists{/gist_id}","starred_url":"https://api.github.com/users/cbuescher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbuescher/subscriptions","organizations_url":"https://api.github.com/users/cbuescher/orgs","repos_url":"https://api.github.com/users/cbuescher/repos","events_url":"https://api.github.com/users/cbuescher/events{/privacy}","received_events_url":"https://api.github.com/users/cbuescher/received_events","type":"User","site_admin":false},"created_at":"2015-12-09T17:09:42Z","updated_at":"2015-12-09T17:09:42Z","body":"@colings86 thanks, pushed an additional commit addressing your comments, let me know if this is okay now."}}