{"action":"opened","number":11,"pull_request":{"url":"https://api.github.com/repos/joyent/node-documentation-generator/pulls/11","id":29745483,"html_url":"https://github.com/joyent/node-documentation-generator/pull/11","diff_url":"https://github.com/joyent/node-documentation-generator/pull/11.diff","patch_url":"https://github.com/joyent/node-documentation-generator/pull/11.patch","issue_url":"https://api.github.com/repos/joyent/node-documentation-generator/issues/11","number":11,"state":"open","locked":false,"title":".markdown support","user":{"login":"robertkowalski","id":298166,"avatar_url":"https://avatars.githubusercontent.com/u/298166?v=3","gravatar_id":"","url":"https://api.github.com/users/robertkowalski","html_url":"https://github.com/robertkowalski","followers_url":"https://api.github.com/users/robertkowalski/followers","following_url":"https://api.github.com/users/robertkowalski/following{/other_user}","gists_url":"https://api.github.com/users/robertkowalski/gists{/gist_id}","starred_url":"https://api.github.com/users/robertkowalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertkowalski/subscriptions","organizations_url":"https://api.github.com/users/robertkowalski/orgs","repos_url":"https://api.github.com/users/robertkowalski/repos","events_url":"https://api.github.com/users/robertkowalski/events{/privacy}","received_events_url":"https://api.github.com/users/robertkowalski/received_events","type":"User","site_admin":false},"body":"Support both `.md` and `.markdown` files. This is needed for\r\nbuilding the node docs.\r\n\r\nI am not sure regarding the internal api of `getFileEnding `:\r\n\r\n`index.markdown` in the node repository (https://github.com/joyent/node/blob/master/doc/api/index.markdown) is the only include so far which specifies an explicit fileending (`.markdown`).\r\n\r\n`getFileEnding(err, fileending)` currently returns `null, null` if there is no fileending to guess (because it matches e.g. `/\\.markdown$/` - would it be better to return an error (e.g. `return new Error('fileending is already defined');`) and use that information?\r\n\r\nTested with doc generation for joyent/node-website and joyent/node","created_at":"2015-02-21T01:21:56Z","updated_at":"2015-02-21T01:21:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joyent/node-documentation-generator/pulls/11/commits","review_comments_url":"https://api.github.com/repos/joyent/node-documentation-generator/pulls/11/comments","review_comment_url":"https://api.github.com/repos/joyent/node-documentation-generator/pulls/comments/{number}","comments_url":"https://api.github.com/repos/joyent/node-documentation-generator/issues/11/comments","statuses_url":"https://api.github.com/repos/joyent/node-documentation-generator/statuses/3ad77289b66856b004c73c793cbe09ea0a605451","head":{"label":"robertkowalski:markdown","ref":"markdown","sha":"3ad77289b66856b004c73c793cbe09ea0a605451","user":{"login":"robertkowalski","id":298166,"avatar_url":"https://avatars.githubusercontent.com/u/298166?v=3","gravatar_id":"","url":"https://api.github.com/users/robertkowalski","html_url":"https://github.com/robertkowalski","followers_url":"https://api.github.com/users/robertkowalski/followers","following_url":"https://api.github.com/users/robertkowalski/following{/other_user}","gists_url":"https://api.github.com/users/robertkowalski/gists{/gist_id}","starred_url":"https://api.github.com/users/robertkowalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertkowalski/subscriptions","organizations_url":"https://api.github.com/users/robertkowalski/orgs","repos_url":"https://api.github.com/users/robertkowalski/repos","events_url":"https://api.github.com/users/robertkowalski/events{/privacy}","received_events_url":"https://api.github.com/users/robertkowalski/received_events","type":"User","site_admin":false},"repo":{"id":31091574,"name":"node-documentation-generator","full_name":"robertkowalski/node-documentation-generator","owner":{"login":"robertkowalski","id":298166,"avatar_url":"https://avatars.githubusercontent.com/u/298166?v=3","gravatar_id":"","url":"https://api.github.com/users/robertkowalski","html_url":"https://github.com/robertkowalski","followers_url":"https://api.github.com/users/robertkowalski/followers","following_url":"https://api.github.com/users/robertkowalski/following{/other_user}","gists_url":"https://api.github.com/users/robertkowalski/gists{/gist_id}","starred_url":"https://api.github.com/users/robertkowalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertkowalski/subscriptions","organizations_url":"https://api.github.com/users/robertkowalski/orgs","repos_url":"https://api.github.com/users/robertkowalski/repos","events_url":"https://api.github.com/users/robertkowalski/events{/privacy}","received_events_url":"https://api.github.com/users/robertkowalski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robertkowalski/node-documentation-generator","description":"","fork":true,"url":"https://api.github.com/repos/robertkowalski/node-documentation-generator","forks_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/forks","keys_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/teams","hooks_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/hooks","issue_events_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/issues/events{/number}","events_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/events","assignees_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/assignees{/user}","branches_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/branches{/branch}","tags_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/tags","blobs_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/languages","stargazers_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/stargazers","contributors_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/contributors","subscribers_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/subscribers","subscription_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/subscription","commits_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/issues/comments/{number}","contents_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/contents/{+path}","compare_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/merges","archive_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/downloads","issues_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/issues{/number}","pulls_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/labels{/name}","releases_url":"https://api.github.com/repos/robertkowalski/node-documentation-generator/releases{/id}","created_at":"2015-02-21T00:11:11Z","updated_at":"2015-02-21T00:12:51Z","pushed_at":"2015-02-21T01:01:43Z","git_url":"git://github.com/robertkowalski/node-documentation-generator.git","ssh_url":"git@github.com:robertkowalski/node-documentation-generator.git","clone_url":"https://github.com/robertkowalski/node-documentation-generator.git","svn_url":"https://github.com/robertkowalski/node-documentation-generator","homepage":null,"size":388,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joyent:master","ref":"master","sha":"df143aea79ef0b333c937f20528c17ffc26703e3","user":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"repo":{"id":29441598,"name":"node-documentation-generator","full_name":"joyent/node-documentation-generator","owner":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joyent/node-documentation-generator","description":"","fork":false,"url":"https://api.github.com/repos/joyent/node-documentation-generator","forks_url":"https://api.github.com/repos/joyent/node-documentation-generator/forks","keys_url":"https://api.github.com/repos/joyent/node-documentation-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joyent/node-documentation-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joyent/node-documentation-generator/teams","hooks_url":"https://api.github.com/repos/joyent/node-documentation-generator/hooks","issue_events_url":"https://api.github.com/repos/joyent/node-documentation-generator/issues/events{/number}","events_url":"https://api.github.com/repos/joyent/node-documentation-generator/events","assignees_url":"https://api.github.com/repos/joyent/node-documentation-generator/assignees{/user}","branches_url":"https://api.github.com/repos/joyent/node-documentation-generator/branches{/branch}","tags_url":"https://api.github.com/repos/joyent/node-documentation-generator/tags","blobs_url":"https://api.github.com/repos/joyent/node-documentation-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joyent/node-documentation-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joyent/node-documentation-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/joyent/node-documentation-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joyent/node-documentation-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/joyent/node-documentation-generator/languages","stargazers_url":"https://api.github.com/repos/joyent/node-documentation-generator/stargazers","contributors_url":"https://api.github.com/repos/joyent/node-documentation-generator/contributors","subscribers_url":"https://api.github.com/repos/joyent/node-documentation-generator/subscribers","subscription_url":"https://api.github.com/repos/joyent/node-documentation-generator/subscription","commits_url":"https://api.github.com/repos/joyent/node-documentation-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/joyent/node-documentation-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/joyent/node-documentation-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/joyent/node-documentation-generator/issues/comments/{number}","contents_url":"https://api.github.com/repos/joyent/node-documentation-generator/contents/{+path}","compare_url":"https://api.github.com/repos/joyent/node-documentation-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joyent/node-documentation-generator/merges","archive_url":"https://api.github.com/repos/joyent/node-documentation-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joyent/node-documentation-generator/downloads","issues_url":"https://api.github.com/repos/joyent/node-documentation-generator/issues{/number}","pulls_url":"https://api.github.com/repos/joyent/node-documentation-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/joyent/node-documentation-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/joyent/node-documentation-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joyent/node-documentation-generator/labels{/name}","releases_url":"https://api.github.com/repos/joyent/node-documentation-generator/releases{/id}","created_at":"2015-01-18T21:22:27Z","updated_at":"2015-02-21T00:21:39Z","pushed_at":"2015-02-21T00:21:47Z","git_url":"git://github.com/joyent/node-documentation-generator.git","ssh_url":"git@github.com:joyent/node-documentation-generator.git","clone_url":"https://github.com/joyent/node-documentation-generator.git","svn_url":"https://github.com/joyent/node-documentation-generator","homepage":null,"size":388,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joyent/node-documentation-generator/pulls/11"},"html":{"href":"https://github.com/joyent/node-documentation-generator/pull/11"},"issue":{"href":"https://api.github.com/repos/joyent/node-documentation-generator/issues/11"},"comments":{"href":"https://api.github.com/repos/joyent/node-documentation-generator/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/joyent/node-documentation-generator/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/joyent/node-documentation-generator/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/joyent/node-documentation-generator/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/joyent/node-documentation-generator/statuses/3ad77289b66856b004c73c793cbe09ea0a605451"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":212,"deletions":72,"changed_files":9}}