{"action":"created","comment":{"url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/pulls/comments/26920150","id":26920150,"diff_hunk":"@@ -126,23 +153,38 @@ def workflow_fastq_screen(input_files, output_dir, config):\n     num_threads = config.get(\"qc\", {}).get(\"fastq_screen\", {}).get(\"threads\") or 1\n     subsample_reads = config.get(\"qc\", {}).get(\"fastq_screen\", {}).get(\"subsample_reads\")\n \n+    # Determine which files need processing\n+    fastq_screen_output_file_tmpls = (\"{}_screen.png\", \"{}_screen.txt\")\n+    fastq_to_analyze = set()\n+    for elt in input_files:\n+        # This may be a read pair\n+        if type(elt) is list:\n+            # fastq_screen uses the name of the first read of the pair for output files\n+            elt = tuple(elt)","path":"ngi_pipeline/engines/qc_ngi/workflows.py","position":89,"original_position":89,"commit_id":"79272cc4c35b8b2f7df1c8c68567fbd271dcba30","original_commit_id":"79272cc4c35b8b2f7df1c8c68567fbd271dcba30","user":{"login":"mariogiov","id":2773974,"avatar_url":"https://avatars.githubusercontent.com/u/2773974?v=3","gravatar_id":"","url":"https://api.github.com/users/mariogiov","html_url":"https://github.com/mariogiov","followers_url":"https://api.github.com/users/mariogiov/followers","following_url":"https://api.github.com/users/mariogiov/following{/other_user}","gists_url":"https://api.github.com/users/mariogiov/gists{/gist_id}","starred_url":"https://api.github.com/users/mariogiov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariogiov/subscriptions","organizations_url":"https://api.github.com/users/mariogiov/orgs","repos_url":"https://api.github.com/users/mariogiov/repos","events_url":"https://api.github.com/users/mariogiov/events{/privacy}","received_events_url":"https://api.github.com/users/mariogiov/received_events","type":"User","site_admin":false},"body":"I'm making this an elt because lists aren't hashable and so I could add them to the `set()`. Maybe I should have commented that.","created_at":"2015-03-23T08:47:07Z","updated_at":"2015-03-23T08:47:07Z","html_url":"https://github.com/NationalGenomicsInfrastructure/ngi_pipeline/pull/259#discussion_r26920150","pull_request_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/pulls/259","_links":{"self":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/pulls/comments/26920150"},"html":{"href":"https://github.com/NationalGenomicsInfrastructure/ngi_pipeline/pull/259#discussion_r26920150"},"pull_request":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/pulls/259"}}},"pull_request":{"url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/pulls/259","id":31627680,"html_url":"https://github.com/NationalGenomicsInfrastructure/ngi_pipeline/pull/259","diff_url":"https://github.com/NationalGenomicsInfrastructure/ngi_pipeline/pull/259.diff","patch_url":"https://github.com/NationalGenomicsInfrastructure/ngi_pipeline/pull/259.patch","issue_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/issues/259","number":259,"state":"open","locked":false,"title":"Don't rerun QC analyses (FastQC, fastq_screen) if not needed","user":{"login":"mariogiov","id":2773974,"avatar_url":"https://avatars.githubusercontent.com/u/2773974?v=3","gravatar_id":"","url":"https://api.github.com/users/mariogiov","html_url":"https://github.com/mariogiov","followers_url":"https://api.github.com/users/mariogiov/followers","following_url":"https://api.github.com/users/mariogiov/following{/other_user}","gists_url":"https://api.github.com/users/mariogiov/gists{/gist_id}","starred_url":"https://api.github.com/users/mariogiov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariogiov/subscriptions","organizations_url":"https://api.github.com/users/mariogiov/orgs","repos_url":"https://api.github.com/users/mariogiov/repos","events_url":"https://api.github.com/users/mariogiov/events{/privacy}","received_events_url":"https://api.github.com/users/mariogiov/received_events","type":"User","site_admin":false},"body":"Checks for the existence of the output files and that they are newer (more recently modified) than the input fastq files","created_at":"2015-03-20T16:11:59Z","updated_at":"2015-03-23T08:47:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e6ad39d415a225bd426368f185f97929f28e91d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/pulls/259/commits","review_comments_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/pulls/259/comments","review_comment_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/issues/259/comments","statuses_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/statuses/79272cc4c35b8b2f7df1c8c68567fbd271dcba30","head":{"label":"mariogiov:qc_smarter","ref":"qc_smarter","sha":"79272cc4c35b8b2f7df1c8c68567fbd271dcba30","user":{"login":"mariogiov","id":2773974,"avatar_url":"https://avatars.githubusercontent.com/u/2773974?v=3","gravatar_id":"","url":"https://api.github.com/users/mariogiov","html_url":"https://github.com/mariogiov","followers_url":"https://api.github.com/users/mariogiov/followers","following_url":"https://api.github.com/users/mariogiov/following{/other_user}","gists_url":"https://api.github.com/users/mariogiov/gists{/gist_id}","starred_url":"https://api.github.com/users/mariogiov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariogiov/subscriptions","organizations_url":"https://api.github.com/users/mariogiov/orgs","repos_url":"https://api.github.com/users/mariogiov/repos","events_url":"https://api.github.com/users/mariogiov/events{/privacy}","received_events_url":"https://api.github.com/users/mariogiov/received_events","type":"User","site_admin":false},"repo":{"id":18521336,"name":"ngi_pipeline","full_name":"mariogiov/ngi_pipeline","owner":{"login":"mariogiov","id":2773974,"avatar_url":"https://avatars.githubusercontent.com/u/2773974?v=3","gravatar_id":"","url":"https://api.github.com/users/mariogiov","html_url":"https://github.com/mariogiov","followers_url":"https://api.github.com/users/mariogiov/followers","following_url":"https://api.github.com/users/mariogiov/following{/other_user}","gists_url":"https://api.github.com/users/mariogiov/gists{/gist_id}","starred_url":"https://api.github.com/users/mariogiov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariogiov/subscriptions","organizations_url":"https://api.github.com/users/mariogiov/orgs","repos_url":"https://api.github.com/users/mariogiov/repos","events_url":"https://api.github.com/users/mariogiov/events{/privacy}","received_events_url":"https://api.github.com/users/mariogiov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mariogiov/ngi_pipeline","description":"Code driving the production pipeline at SciLifeLab (not yet in production)","fork":false,"url":"https://api.github.com/repos/mariogiov/ngi_pipeline","forks_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/forks","keys_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/teams","hooks_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/hooks","issue_events_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/events","assignees_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/tags","blobs_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/languages","stargazers_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/stargazers","contributors_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/contributors","subscribers_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/subscribers","subscription_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/subscription","commits_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/merges","archive_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/downloads","issues_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/labels{/name}","releases_url":"https://api.github.com/repos/mariogiov/ngi_pipeline/releases{/id}","created_at":"2014-04-07T15:04:20Z","updated_at":"2015-03-20T14:57:46Z","pushed_at":"2015-03-20T16:11:19Z","git_url":"git://github.com/mariogiov/ngi_pipeline.git","ssh_url":"git@github.com:mariogiov/ngi_pipeline.git","clone_url":"https://github.com/mariogiov/ngi_pipeline.git","svn_url":"https://github.com/mariogiov/ngi_pipeline","homepage":null,"size":3148,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":0,"forks":9,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"NationalGenomicsInfrastructure:devel","ref":"devel","sha":"45a86d8af4a29336b018d5d39cd4416a90c44ae7","user":{"login":"NationalGenomicsInfrastructure","id":7566557,"avatar_url":"https://avatars.githubusercontent.com/u/7566557?v=3","gravatar_id":"","url":"https://api.github.com/users/NationalGenomicsInfrastructure","html_url":"https://github.com/NationalGenomicsInfrastructure","followers_url":"https://api.github.com/users/NationalGenomicsInfrastructure/followers","following_url":"https://api.github.com/users/NationalGenomicsInfrastructure/following{/other_user}","gists_url":"https://api.github.com/users/NationalGenomicsInfrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/NationalGenomicsInfrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NationalGenomicsInfrastructure/subscriptions","organizations_url":"https://api.github.com/users/NationalGenomicsInfrastructure/orgs","repos_url":"https://api.github.com/users/NationalGenomicsInfrastructure/repos","events_url":"https://api.github.com/users/NationalGenomicsInfrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/NationalGenomicsInfrastructure/received_events","type":"Organization","site_admin":false},"repo":{"id":21352546,"name":"ngi_pipeline","full_name":"NationalGenomicsInfrastructure/ngi_pipeline","owner":{"login":"NationalGenomicsInfrastructure","id":7566557,"avatar_url":"https://avatars.githubusercontent.com/u/7566557?v=3","gravatar_id":"","url":"https://api.github.com/users/NationalGenomicsInfrastructure","html_url":"https://github.com/NationalGenomicsInfrastructure","followers_url":"https://api.github.com/users/NationalGenomicsInfrastructure/followers","following_url":"https://api.github.com/users/NationalGenomicsInfrastructure/following{/other_user}","gists_url":"https://api.github.com/users/NationalGenomicsInfrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/NationalGenomicsInfrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NationalGenomicsInfrastructure/subscriptions","organizations_url":"https://api.github.com/users/NationalGenomicsInfrastructure/orgs","repos_url":"https://api.github.com/users/NationalGenomicsInfrastructure/repos","events_url":"https://api.github.com/users/NationalGenomicsInfrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/NationalGenomicsInfrastructure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NationalGenomicsInfrastructure/ngi_pipeline","description":"Code driving the production pipeline at SciLifeLab","fork":true,"url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline","forks_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/forks","keys_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/teams","hooks_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/hooks","issue_events_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/events","assignees_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/tags","blobs_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/languages","stargazers_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/stargazers","contributors_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/contributors","subscribers_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/subscribers","subscription_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/subscription","commits_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/merges","archive_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/downloads","issues_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/labels{/name}","releases_url":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/releases{/id}","created_at":"2014-06-30T13:45:35Z","updated_at":"2015-03-22T13:30:17Z","pushed_at":"2015-03-22T13:30:17Z","git_url":"git://github.com/NationalGenomicsInfrastructure/ngi_pipeline.git","ssh_url":"git@github.com:NationalGenomicsInfrastructure/ngi_pipeline.git","clone_url":"https://github.com/NationalGenomicsInfrastructure/ngi_pipeline.git","svn_url":"https://github.com/NationalGenomicsInfrastructure/ngi_pipeline","homepage":"","size":2926,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":15,"forks":7,"open_issues":15,"watchers":0,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/pulls/259"},"html":{"href":"https://github.com/NationalGenomicsInfrastructure/ngi_pipeline/pull/259"},"issue":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/issues/259"},"comments":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/issues/259/comments"},"review_comments":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/pulls/259/comments"},"review_comment":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/pulls/259/commits"},"statuses":{"href":"https://api.github.com/repos/NationalGenomicsInfrastructure/ngi_pipeline/statuses/79272cc4c35b8b2f7df1c8c68567fbd271dcba30"}}}}