{"comment":{"url":"https://api.github.com/repos/metaron-uk/xbmc/comments/13198632","html_url":"https://github.com/metaron-uk/xbmc/commit/c17547a1855cdbed8bef756d342824d2f355b63e#commitcomment-13198632","id":13198632,"user":{"login":"ksooo","id":3226626,"avatar_url":"https://avatars.githubusercontent.com/u/3226626?v=3","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"c17547a1855cdbed8bef756d342824d2f355b63e","created_at":"2015-09-12T22:14:30Z","updated_at":"2015-09-12T22:14:30Z","body":"Not sure whether it makes sense to squeeze all this into one field.\r\n\r\nRegarding expires-soon: what does 'soon' actually mean and what can the user make out of this information? imo nothing. User does not know whether 1 day or 1 week or even 1 month is left to watch a recording before it gets deleted. To be of actual use, an expiration date needs to be presented to the user. IMO it's up to the theme to decide, what is 'soon' and for being able to do so, this flag does not help. Wouldn't it be better to have new PVR_RECORDING field <code>time_t iExpirationDate</code> for this?\r\n\r\nRegarding expires-never: this is valuable, but I'd put it into new PVR_RECORDING flag <code>bool bExpiresNever</code>\r\n\r\nRegarding in-progress: Did not follow the discussion in #7905 to the end, but I had the impression that a is-recording flag would not solve the problem discussed there? Wasn't the point that dvdplayer needs to know about real-time streams to do proper caching and is-recording does not (always) mean real-time? In case I'm right, why should we introduce this flag, then?"}}