{"action":"created","issue":{"url":"https://api.github.com/repos/espruino/Espruino/issues/694","labels_url":"https://api.github.com/repos/espruino/Espruino/issues/694/labels{/name}","comments_url":"https://api.github.com/repos/espruino/Espruino/issues/694/comments","events_url":"https://api.github.com/repos/espruino/Espruino/issues/694/events","html_url":"https://github.com/espruino/Espruino/pull/694","id":115275264,"number":694,"title":"fix: typo in sleep pin indicator dump","user":{"login":"nailxx","id":146383,"avatar_url":"https://avatars.githubusercontent.com/u/146383?v=3","gravatar_id":"","url":"https://api.github.com/users/nailxx","html_url":"https://github.com/nailxx","followers_url":"https://api.github.com/users/nailxx/followers","following_url":"https://api.github.com/users/nailxx/following{/other_user}","gists_url":"https://api.github.com/users/nailxx/gists{/gist_id}","starred_url":"https://api.github.com/users/nailxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nailxx/subscriptions","organizations_url":"https://api.github.com/users/nailxx/orgs","repos_url":"https://api.github.com/users/nailxx/repos","events_url":"https://api.github.com/users/nailxx/events{/privacy}","received_events_url":"https://api.github.com/users/nailxx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-05T12:39:15Z","updated_at":"2015-11-05T13:06:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/espruino/Espruino/pulls/694","html_url":"https://github.com/espruino/Espruino/pull/694","diff_url":"https://github.com/espruino/Espruino/pull/694.diff","patch_url":"https://github.com/espruino/Espruino/pull/694.patch"},"body":"Clear copy-paste bug that lead to error while `save()` if busy pin is set and sleep pin is not.\r\n\r\nAlso, note `jspin.c:187`. Should we write `UNKNOWN` there? Maybe `undefined` is a better idea? In current state, following scenario is possible:\r\n\r\n```\r\nUncaught ReferenceError: \"UNKNOWN\" is not defined\r\n at line 1 col 19\r\nsetSleepIndicator(UNKNOWN);\r\n                  ^\r\n>dump()\r\nsetSleepIndicator(UNKNOWN);\r\n```\r\n\r\nUse of `undefined` instead of `UNKNOWN` would solve the problem."},"comment":{"url":"https://api.github.com/repos/espruino/Espruino/issues/comments/154054963","html_url":"https://github.com/espruino/Espruino/pull/694#issuecomment-154054963","issue_url":"https://api.github.com/repos/espruino/Espruino/issues/694","id":154054963,"user":{"login":"gfwilliams","id":754445,"avatar_url":"https://avatars.githubusercontent.com/u/754445?v=3","gravatar_id":"","url":"https://api.github.com/users/gfwilliams","html_url":"https://github.com/gfwilliams","followers_url":"https://api.github.com/users/gfwilliams/followers","following_url":"https://api.github.com/users/gfwilliams/following{/other_user}","gists_url":"https://api.github.com/users/gfwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/gfwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfwilliams/subscriptions","organizations_url":"https://api.github.com/users/gfwilliams/orgs","repos_url":"https://api.github.com/users/gfwilliams/repos","events_url":"https://api.github.com/users/gfwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/gfwilliams/received_events","type":"User","site_admin":false},"created_at":"2015-11-05T13:06:39Z","updated_at":"2015-11-05T13:06:39Z","body":"Good spot - thanks! Presumably this is only if you set DEFAULT_SLEEP_PIN_INDICATOR in the build itself? Good point about the pin dumping, I'll do that"}}