{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/40103184","id":40103184,"diff_hunk":"@@ -292,7 +292,7 @@ class Application : public QApplication, public AbstractViewStateInterface, publ\n     NodeToJurisdictionMap& getEntityServerJurisdictions() { return _entityServerJurisdictions; }\n \n     QStringList getRunningScripts() { return _scriptEnginesHash.keys(); }\n-    ScriptEngine* getScriptEngine(QString scriptHash) { return _scriptEnginesHash.contains(scriptHash) ? _scriptEnginesHash[scriptHash] : NULL; }\n+    ScriptEngine* getScriptEngine(const QString& scriptHash) { return _scriptEnginesHash.contains(scriptHash) ? _scriptEnginesHash[scriptHash] : NULL; }","path":"interface/src/Application.h","position":5,"original_position":5,"commit_id":"9992f4b5c5bbb557a05a0c7e09c35bf8127e533f","original_commit_id":"9992f4b5c5bbb557a05a0c7e09c35bf8127e533f","user":{"login":"AndrewMeadows","id":2186405,"avatar_url":"https://avatars.githubusercontent.com/u/2186405?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewMeadows","html_url":"https://github.com/AndrewMeadows","followers_url":"https://api.github.com/users/AndrewMeadows/followers","following_url":"https://api.github.com/users/AndrewMeadows/following{/other_user}","gists_url":"https://api.github.com/users/AndrewMeadows/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewMeadows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewMeadows/subscriptions","organizations_url":"https://api.github.com/users/AndrewMeadows/orgs","repos_url":"https://api.github.com/users/AndrewMeadows/repos","events_url":"https://api.github.com/users/AndrewMeadows/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewMeadows/received_events","type":"User","site_admin":false},"body":"Not a blocker but **getScriptEngine()** does a double lookup for existing **scriptHash**.  There is a way to implement this function that only uses one lookup.","created_at":"2015-09-22T15:47:00Z","updated_at":"2015-09-22T15:47:00Z","html_url":"https://github.com/highfidelity/hifi/pull/5825#discussion_r40103184","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5825","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/40103184"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5825#discussion_r40103184"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5825"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/5825","id":45224298,"html_url":"https://github.com/highfidelity/hifi/pull/5825","diff_url":"https://github.com/highfidelity/hifi/pull/5825.diff","patch_url":"https://github.com/highfidelity/hifi/pull/5825.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/5825","number":5825,"state":"open","locked":false,"title":"CR for Job #20655 - Add ability to close one script from another script","user":{"login":"thoys","id":607735,"avatar_url":"https://avatars.githubusercontent.com/u/607735?v=3","gravatar_id":"","url":"https://api.github.com/users/thoys","html_url":"https://github.com/thoys","followers_url":"https://api.github.com/users/thoys/followers","following_url":"https://api.github.com/users/thoys/following{/other_user}","gists_url":"https://api.github.com/users/thoys/gists{/gist_id}","starred_url":"https://api.github.com/users/thoys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoys/subscriptions","organizations_url":"https://api.github.com/users/thoys/orgs","repos_url":"https://api.github.com/users/thoys/repos","events_url":"https://api.github.com/users/thoys/events{/privacy}","received_events_url":"https://api.github.com/users/thoys/received_events","type":"User","site_admin":false},"body":"Code Review for Job #20655 - Workitem available at https://www.worklist.net/20655","created_at":"2015-09-16T21:06:21Z","updated_at":"2015-09-22T15:47:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dc4f3040ecab4504dc88350d27d40f0361e6552","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5825/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5825/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/5825/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/9992f4b5c5bbb557a05a0c7e09c35bf8127e533f","head":{"label":"thoys:20655","ref":"20655","sha":"9992f4b5c5bbb557a05a0c7e09c35bf8127e533f","user":{"login":"thoys","id":607735,"avatar_url":"https://avatars.githubusercontent.com/u/607735?v=3","gravatar_id":"","url":"https://api.github.com/users/thoys","html_url":"https://github.com/thoys","followers_url":"https://api.github.com/users/thoys/followers","following_url":"https://api.github.com/users/thoys/following{/other_user}","gists_url":"https://api.github.com/users/thoys/gists{/gist_id}","starred_url":"https://api.github.com/users/thoys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoys/subscriptions","organizations_url":"https://api.github.com/users/thoys/orgs","repos_url":"https://api.github.com/users/thoys/repos","events_url":"https://api.github.com/users/thoys/events{/privacy}","received_events_url":"https://api.github.com/users/thoys/received_events","type":"User","site_admin":false},"repo":{"id":18294345,"name":"hifi","full_name":"thoys/hifi","owner":{"login":"thoys","id":607735,"avatar_url":"https://avatars.githubusercontent.com/u/607735?v=3","gravatar_id":"","url":"https://api.github.com/users/thoys","html_url":"https://github.com/thoys","followers_url":"https://api.github.com/users/thoys/followers","following_url":"https://api.github.com/users/thoys/following{/other_user}","gists_url":"https://api.github.com/users/thoys/gists{/gist_id}","starred_url":"https://api.github.com/users/thoys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoys/subscriptions","organizations_url":"https://api.github.com/users/thoys/orgs","repos_url":"https://api.github.com/users/thoys/repos","events_url":"https://api.github.com/users/thoys/events{/privacy}","received_events_url":"https://api.github.com/users/thoys/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thoys/hifi","description":"Open, decentralized virtual world using sensors to control avatars and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.io/jobs  You can also contribute by doing jobs listed at http://worklist.net -","fork":true,"url":"https://api.github.com/repos/thoys/hifi","forks_url":"https://api.github.com/repos/thoys/hifi/forks","keys_url":"https://api.github.com/repos/thoys/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoys/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoys/hifi/teams","hooks_url":"https://api.github.com/repos/thoys/hifi/hooks","issue_events_url":"https://api.github.com/repos/thoys/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/thoys/hifi/events","assignees_url":"https://api.github.com/repos/thoys/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/thoys/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/thoys/hifi/tags","blobs_url":"https://api.github.com/repos/thoys/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoys/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoys/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoys/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoys/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/thoys/hifi/languages","stargazers_url":"https://api.github.com/repos/thoys/hifi/stargazers","contributors_url":"https://api.github.com/repos/thoys/hifi/contributors","subscribers_url":"https://api.github.com/repos/thoys/hifi/subscribers","subscription_url":"https://api.github.com/repos/thoys/hifi/subscription","commits_url":"https://api.github.com/repos/thoys/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoys/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoys/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoys/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoys/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/thoys/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoys/hifi/merges","archive_url":"https://api.github.com/repos/thoys/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoys/hifi/downloads","issues_url":"https://api.github.com/repos/thoys/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/thoys/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/thoys/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/thoys/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoys/hifi/labels{/name}","releases_url":"https://api.github.com/repos/thoys/hifi/releases{/id}","created_at":"2014-03-31T13:41:07Z","updated_at":"2015-04-09T22:03:21Z","pushed_at":"2015-09-22T14:21:06Z","git_url":"git://github.com/thoys/hifi.git","ssh_url":"git@github.com:thoys/hifi.git","clone_url":"https://github.com/thoys/hifi.git","svn_url":"https://github.com/thoys/hifi","homepage":"http://highfidelity.io","size":176811,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"4711c18f36e01fc7d26968e0be47e1bbcedb7bb3","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-09-21T20:31:57Z","pushed_at":"2015-09-22T15:46:25Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":237404,"stargazers_count":306,"watchers_count":306,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":178,"mirror_url":null,"open_issues_count":65,"forks":178,"open_issues":65,"watchers":306,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5825"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5825"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5825"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5825/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5825/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5825/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/9992f4b5c5bbb557a05a0c7e09c35bf8127e533f"}}}}