{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/22400372","id":22400372,"diff_hunk":"@@ -400,3 +400,39 @@ def test_issue_8657():\n     assert gamma(o).is_real is True\n     assert gamma(p).is_real is True\n     assert gamma(w).is_real is None\n+\n+\n+def test_issue_8524():\n+    a = Symbol('a')\n+    x = Symbol('x', integer=True)\n+    y = Symbol('y', positive=True)\n+    z = Symbol('z', negative=True)\n+    m = Symbol('m', integer=False)\n+    n = Symbol('n', positive=False)\n+    o = Symbol('o', negative=False)\n+    p = Symbol('p', real=True)\n+    q = Symbol('q', negative=True, integer=False)\n+    r = Symbol('r', negative=False, integer=True)\n+    s = Symbol('s', positive=True, integer=False)\n+    t = Symbol('t', positive=False, integer=True)\n+    u = Symbol('u', positive=True, integer=True)\n+    v = Symbol('v', nonnegative=True)\n+    assert gamma(a).is_positive is None\n+    assert gamma(x).is_positive is None\n+    assert gamma(y).is_positive is True\n+    assert gamma(z).is_positive is None\n+    assert gamma(m).is_positive is None\n+    assert gamma(n).is_positive is None\n+    assert gamma(o).is_positive is None\n+    assert gamma(p).is_positive is None\n+    assert gamma(q).is_positive is None\n+    assert gamma(r).is_positive is None\n+    assert gamma(s).is_positive is True\n+    assert gamma(t).is_positive is None\n+    assert gamma(u).is_positive is True\n+    assert gamma(v).is_positive is None\n+    assert gamma(Rational(-1, 4), evaluate=False).is_positive is False\n+    assert gamma(Rational(-9, 2), evaluate=False).is_positive is False\n+    assert gamma(Rational(-10, 3), evaluate=False).is_positive is True\n+    assert gamma(Rational(12, 5), evaluate=False).is_positive is True\n+    assert gamma(0).is_positive is None","path":"sympy/functions/special/tests/test_gamma_functions.py","position":39,"original_position":39,"commit_id":"97335c12be48c6fe0cc80dd2a1c3c002a12e8533","original_commit_id":"97335c12be48c6fe0cc80dd2a1c3c002a12e8533","user":{"login":"skirpichev","id":2155800,"avatar_url":"https://avatars.githubusercontent.com/u/2155800?v=3","gravatar_id":"","url":"https://api.github.com/users/skirpichev","html_url":"https://github.com/skirpichev","followers_url":"https://api.github.com/users/skirpichev/followers","following_url":"https://api.github.com/users/skirpichev/following{/other_user}","gists_url":"https://api.github.com/users/skirpichev/gists{/gist_id}","starred_url":"https://api.github.com/users/skirpichev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skirpichev/subscriptions","organizations_url":"https://api.github.com/users/skirpichev/orgs","repos_url":"https://api.github.com/users/skirpichev/repos","events_url":"https://api.github.com/users/skirpichev/events{/privacy}","received_events_url":"https://api.github.com/users/skirpichev/received_events","type":"User","site_admin":false},"body":"same here","created_at":"2015-01-01T16:03:03Z","updated_at":"2015-01-01T16:03:03Z","html_url":"https://github.com/sympy/sympy/pull/8719#discussion_r22400372","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/8719","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/22400372"},"html":{"href":"https://github.com/sympy/sympy/pull/8719#discussion_r22400372"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/8719"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/8719","id":26723085,"html_url":"https://github.com/sympy/sympy/pull/8719","diff_url":"https://github.com/sympy/sympy/pull/8719.diff","patch_url":"https://github.com/sympy/sympy/pull/8719.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/8719","number":8719,"state":"open","locked":false,"title":"Add Positive assumption helper for gamma function, Fixes #8524 ","user":{"login":"aktech","id":5647941,"avatar_url":"https://avatars.githubusercontent.com/u/5647941?v=3","gravatar_id":"","url":"https://api.github.com/users/aktech","html_url":"https://github.com/aktech","followers_url":"https://api.github.com/users/aktech/followers","following_url":"https://api.github.com/users/aktech/following{/other_user}","gists_url":"https://api.github.com/users/aktech/gists{/gist_id}","starred_url":"https://api.github.com/users/aktech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aktech/subscriptions","organizations_url":"https://api.github.com/users/aktech/orgs","repos_url":"https://api.github.com/users/aktech/repos","events_url":"https://api.github.com/users/aktech/events{/privacy}","received_events_url":"https://api.github.com/users/aktech/received_events","type":"User","site_admin":false},"body":"The Positive assumption helper for gamma function is missing:\r\nSo the the following code returns None:\r\n\r\n```python\r\n>>> n = Symbol('n', real=True, positive=True)\r\n>>> gamma(n).is_positive\r\n```\r\nWith this PR, Positive assumption works well for gamma function.\r\n\r\nFixes #8524 ","created_at":"2014-12-31T12:32:03Z","updated_at":"2015-01-01T16:03:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ca52e2021617fedd460cb05e140823bda55b4b2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/8719/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/8719/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/8719/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/97335c12be48c6fe0cc80dd2a1c3c002a12e8533","head":{"label":"aktech:gamma-positive","ref":"gamma-positive","sha":"97335c12be48c6fe0cc80dd2a1c3c002a12e8533","user":{"login":"aktech","id":5647941,"avatar_url":"https://avatars.githubusercontent.com/u/5647941?v=3","gravatar_id":"","url":"https://api.github.com/users/aktech","html_url":"https://github.com/aktech","followers_url":"https://api.github.com/users/aktech/followers","following_url":"https://api.github.com/users/aktech/following{/other_user}","gists_url":"https://api.github.com/users/aktech/gists{/gist_id}","starred_url":"https://api.github.com/users/aktech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aktech/subscriptions","organizations_url":"https://api.github.com/users/aktech/orgs","repos_url":"https://api.github.com/users/aktech/repos","events_url":"https://api.github.com/users/aktech/events{/privacy}","received_events_url":"https://api.github.com/users/aktech/received_events","type":"User","site_admin":false},"repo":{"id":28193645,"name":"sympy","full_name":"aktech/sympy","owner":{"login":"aktech","id":5647941,"avatar_url":"https://avatars.githubusercontent.com/u/5647941?v=3","gravatar_id":"","url":"https://api.github.com/users/aktech","html_url":"https://github.com/aktech","followers_url":"https://api.github.com/users/aktech/followers","following_url":"https://api.github.com/users/aktech/following{/other_user}","gists_url":"https://api.github.com/users/aktech/gists{/gist_id}","starred_url":"https://api.github.com/users/aktech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aktech/subscriptions","organizations_url":"https://api.github.com/users/aktech/orgs","repos_url":"https://api.github.com/users/aktech/repos","events_url":"https://api.github.com/users/aktech/events{/privacy}","received_events_url":"https://api.github.com/users/aktech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aktech/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/aktech/sympy","forks_url":"https://api.github.com/repos/aktech/sympy/forks","keys_url":"https://api.github.com/repos/aktech/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aktech/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aktech/sympy/teams","hooks_url":"https://api.github.com/repos/aktech/sympy/hooks","issue_events_url":"https://api.github.com/repos/aktech/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/aktech/sympy/events","assignees_url":"https://api.github.com/repos/aktech/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/aktech/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/aktech/sympy/tags","blobs_url":"https://api.github.com/repos/aktech/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aktech/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aktech/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/aktech/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aktech/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/aktech/sympy/languages","stargazers_url":"https://api.github.com/repos/aktech/sympy/stargazers","contributors_url":"https://api.github.com/repos/aktech/sympy/contributors","subscribers_url":"https://api.github.com/repos/aktech/sympy/subscribers","subscription_url":"https://api.github.com/repos/aktech/sympy/subscription","commits_url":"https://api.github.com/repos/aktech/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/aktech/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/aktech/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/aktech/sympy/issues/comments/{number}","contents_url":"https://api.github.com/repos/aktech/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/aktech/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aktech/sympy/merges","archive_url":"https://api.github.com/repos/aktech/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aktech/sympy/downloads","issues_url":"https://api.github.com/repos/aktech/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/aktech/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/aktech/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/aktech/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aktech/sympy/labels{/name}","releases_url":"https://api.github.com/repos/aktech/sympy/releases{/id}","created_at":"2014-12-18T17:24:39Z","updated_at":"2014-12-31T12:16:27Z","pushed_at":"2015-01-01T15:58:12Z","git_url":"git://github.com/aktech/sympy.git","ssh_url":"git@github.com:aktech/sympy.git","clone_url":"https://github.com/aktech/sympy.git","svn_url":"https://github.com/aktech/sympy","homepage":"http://sympy.org/","size":65414,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"7d7eb6731562f9a7cf25f92264613f0331f72119","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments/{number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","created_at":"2010-04-30T20:37:14Z","updated_at":"2015-01-01T15:25:53Z","pushed_at":"2015-01-01T15:25:52Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":134482,"stargazers_count":1857,"watchers_count":1857,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":869,"mirror_url":null,"open_issues_count":1765,"forks":869,"open_issues":1765,"watchers":1857,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/8719"},"html":{"href":"https://github.com/sympy/sympy/pull/8719"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/8719"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/8719/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/8719/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/8719/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/97335c12be48c6fe0cc80dd2a1c3c002a12e8533"}}}}