{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/37875199","id":37875199,"diff_hunk":"@@ -14,10 +14,9 @@\n \n define(\n 'video/01_initialize.js',\n-['video/03_video_player.js', 'video/00_i18n.js'],\n+['video/03_video_player.js', 'video/00_i18n.js', 'moment'],\n function (VideoPlayer, i18n) {\n     var moment = window.moment;","path":"common/lib/xmodule/xmodule/js/src/video/01_initialize.js","position":7,"original_position":7,"commit_id":"22d9ae74aaa85a76172eb142abc9292cf05da0de","original_commit_id":"22d9ae74aaa85a76172eb142abc9292cf05da0de","user":{"login":"andy-armstrong","id":5985072,"avatar_url":"https://avatars.githubusercontent.com/u/5985072?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-armstrong","html_url":"https://github.com/andy-armstrong","followers_url":"https://api.github.com/users/andy-armstrong/followers","following_url":"https://api.github.com/users/andy-armstrong/following{/other_user}","gists_url":"https://api.github.com/users/andy-armstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-armstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-armstrong/subscriptions","organizations_url":"https://api.github.com/users/andy-armstrong/orgs","repos_url":"https://api.github.com/users/andy-armstrong/repos","events_url":"https://api.github.com/users/andy-armstrong/events{/privacy}","received_events_url":"https://api.github.com/users/andy-armstrong/received_events","type":"User","site_admin":false},"body":"Thanks for the explanation. I think we just need to add a shim like we do for all the other vendor libraries (see https://github.com/edx/edx-platform/blob/master/lms/static/lms/js/require-config.js#L90):\r\n\r\n            \"moment\": {\r\n                exports: \"moment\"\r\n            },\r\n\r\nThat should cause it ``window.moment`` to be returned as the value of the third parameter, and then code doesn't need to access it through ``window``. \r\n\r\nIf that doesn't work, then just leave this as is.","created_at":"2015-08-25T14:57:27Z","updated_at":"2015-08-25T14:57:27Z","html_url":"https://github.com/edx/edx-platform/pull/9406#discussion_r37875199","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/9406","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/37875199"},"html":{"href":"https://github.com/edx/edx-platform/pull/9406#discussion_r37875199"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9406"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/9406","id":42942827,"html_url":"https://github.com/edx/edx-platform/pull/9406","diff_url":"https://github.com/edx/edx-platform/pull/9406.diff","patch_url":"https://github.com/edx/edx-platform/pull/9406.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/9406","number":9406,"state":"open","locked":false,"title":"Fixed duration not display on youtube player.","user":{"login":"waheedahmed","id":2851134,"avatar_url":"https://avatars.githubusercontent.com/u/2851134?v=3","gravatar_id":"","url":"https://api.github.com/users/waheedahmed","html_url":"https://github.com/waheedahmed","followers_url":"https://api.github.com/users/waheedahmed/followers","following_url":"https://api.github.com/users/waheedahmed/following{/other_user}","gists_url":"https://api.github.com/users/waheedahmed/gists{/gist_id}","starred_url":"https://api.github.com/users/waheedahmed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waheedahmed/subscriptions","organizations_url":"https://api.github.com/users/waheedahmed/orgs","repos_url":"https://api.github.com/users/waheedahmed/repos","events_url":"https://api.github.com/users/waheedahmed/events{/privacy}","received_events_url":"https://api.github.com/users/waheedahmed/received_events","type":"User","site_admin":false},"body":"[TNL-3056] (https://openedx.atlassian.net/browse/TNL-3056)\r\n\r\nFixed duration not displaying on youtube player, by adding ```moment``` as dependancy and fixed jasmine tests which were failing when we add ```moment``` as dependancy in video modules.","created_at":"2015-08-20T15:27:35Z","updated_at":"2015-08-25T14:57:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27214172356f4950ffa9f5cc1a01ebcfac348b9f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/9406/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/9406/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/9406/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/22d9ae74aaa85a76172eb142abc9292cf05da0de","head":{"label":"edx:waheed/tnl3056-fix-duration-not-displaying-for-youtube-player","ref":"waheed/tnl3056-fix-duration-not-displaying-for-youtube-player","sha":"22d9ae74aaa85a76172eb142abc9292cf05da0de","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-08-25T13:16:51Z","pushed_at":"2015-08-25T14:55:02Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2096957,"stargazers_count":2092,"watchers_count":2092,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1230,"mirror_url":null,"open_issues_count":151,"forks":1230,"open_issues":151,"watchers":2092,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"73722c47d3248802add0282b5e0168d093f21fe3","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-08-25T13:16:51Z","pushed_at":"2015-08-25T14:55:02Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2096957,"stargazers_count":2092,"watchers_count":2092,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1230,"mirror_url":null,"open_issues_count":151,"forks":1230,"open_issues":151,"watchers":2092,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9406"},"html":{"href":"https://github.com/edx/edx-platform/pull/9406"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/9406"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/9406/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9406/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9406/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/22d9ae74aaa85a76172eb142abc9292cf05da0de"}}}}