{"action":"closed","number":4450,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/4450","id":33972324,"html_url":"https://github.com/ceph/ceph/pull/4450","diff_url":"https://github.com/ceph/ceph/pull/4450.diff","patch_url":"https://github.com/ceph/ceph/pull/4450.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/4450","number":4450,"state":"closed","locked":false,"title":"FileJournal: fix check_for_full","user":{"login":"big-henry","id":12060961,"avatar_url":"https://avatars.githubusercontent.com/u/12060961?v=3","gravatar_id":"","url":"https://api.github.com/users/big-henry","html_url":"https://github.com/big-henry","followers_url":"https://api.github.com/users/big-henry/followers","following_url":"https://api.github.com/users/big-henry/following{/other_user}","gists_url":"https://api.github.com/users/big-henry/gists{/gist_id}","starred_url":"https://api.github.com/users/big-henry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/big-henry/subscriptions","organizations_url":"https://api.github.com/users/big-henry/orgs","repos_url":"https://api.github.com/users/big-henry/repos","events_url":"https://api.github.com/users/big-henry/events{/privacy}","received_events_url":"https://api.github.com/users/big-henry/received_events","type":"User","site_admin":false},"body":"The condition to test if journal is passing half full mark is\r\nincorrect. Consider the following simplified case:\r\n\r\nAssume header.max_size = 100 and journal has 48 bytes already.\r\n\r\n1st write (10 bytes):\r\nmax=100, room=52, size=10  --> condition not satisfied\r\n\r\n2nd write (4 bytes):\r\nmax=100, room=42, size=4   --> condition not satisfied\r\n\r\nIt passed the half full mark without triggering filestore commit.\r\n\r\nSigned-off-by: Henry Chang <henry@bigtera.com>","created_at":"2015-04-23T16:24:18Z","updated_at":"2015-05-11T17:37:51Z","closed_at":"2015-05-11T17:37:51Z","merged_at":"2015-05-11T17:37:51Z","merge_commit_sha":"cadfea35b4c974db5b5fff2eaeb7cb9c14fa4e1c","assignee":{"login":"tchaikov","id":59071,"avatar_url":"https://avatars.githubusercontent.com/u/59071?v=3","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/4450/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/4450/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/4450/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/972e9a5a004822b5dfe50283ce2f61e688be4d84","head":{"label":"big-henry:wip-journal","ref":"wip-journal","sha":"972e9a5a004822b5dfe50283ce2f61e688be4d84","user":{"login":"big-henry","id":12060961,"avatar_url":"https://avatars.githubusercontent.com/u/12060961?v=3","gravatar_id":"","url":"https://api.github.com/users/big-henry","html_url":"https://github.com/big-henry","followers_url":"https://api.github.com/users/big-henry/followers","following_url":"https://api.github.com/users/big-henry/following{/other_user}","gists_url":"https://api.github.com/users/big-henry/gists{/gist_id}","starred_url":"https://api.github.com/users/big-henry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/big-henry/subscriptions","organizations_url":"https://api.github.com/users/big-henry/orgs","repos_url":"https://api.github.com/users/big-henry/repos","events_url":"https://api.github.com/users/big-henry/events{/privacy}","received_events_url":"https://api.github.com/users/big-henry/received_events","type":"User","site_admin":false},"repo":{"id":34366321,"name":"ceph","full_name":"big-henry/ceph","owner":{"login":"big-henry","id":12060961,"avatar_url":"https://avatars.githubusercontent.com/u/12060961?v=3","gravatar_id":"","url":"https://api.github.com/users/big-henry","html_url":"https://github.com/big-henry","followers_url":"https://api.github.com/users/big-henry/followers","following_url":"https://api.github.com/users/big-henry/following{/other_user}","gists_url":"https://api.github.com/users/big-henry/gists{/gist_id}","starred_url":"https://api.github.com/users/big-henry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/big-henry/subscriptions","organizations_url":"https://api.github.com/users/big-henry/orgs","repos_url":"https://api.github.com/users/big-henry/repos","events_url":"https://api.github.com/users/big-henry/events{/privacy}","received_events_url":"https://api.github.com/users/big-henry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/big-henry/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/big-henry/ceph","forks_url":"https://api.github.com/repos/big-henry/ceph/forks","keys_url":"https://api.github.com/repos/big-henry/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/big-henry/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/big-henry/ceph/teams","hooks_url":"https://api.github.com/repos/big-henry/ceph/hooks","issue_events_url":"https://api.github.com/repos/big-henry/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/big-henry/ceph/events","assignees_url":"https://api.github.com/repos/big-henry/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/big-henry/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/big-henry/ceph/tags","blobs_url":"https://api.github.com/repos/big-henry/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/big-henry/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/big-henry/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/big-henry/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/big-henry/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/big-henry/ceph/languages","stargazers_url":"https://api.github.com/repos/big-henry/ceph/stargazers","contributors_url":"https://api.github.com/repos/big-henry/ceph/contributors","subscribers_url":"https://api.github.com/repos/big-henry/ceph/subscribers","subscription_url":"https://api.github.com/repos/big-henry/ceph/subscription","commits_url":"https://api.github.com/repos/big-henry/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/big-henry/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/big-henry/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/big-henry/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/big-henry/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/big-henry/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/big-henry/ceph/merges","archive_url":"https://api.github.com/repos/big-henry/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/big-henry/ceph/downloads","issues_url":"https://api.github.com/repos/big-henry/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/big-henry/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/big-henry/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/big-henry/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/big-henry/ceph/labels{/name}","releases_url":"https://api.github.com/repos/big-henry/ceph/releases{/id}","created_at":"2015-04-22T03:25:26Z","updated_at":"2015-04-22T10:16:14Z","pushed_at":"2015-04-29T02:38:51Z","git_url":"git://github.com/big-henry/ceph.git","ssh_url":"git@github.com:big-henry/ceph.git","clone_url":"https://github.com/big-henry/ceph.git","svn_url":"https://github.com/big-henry/ceph","homepage":"http://ceph.com","size":120605,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"a26a2cf6b54c2dba48fba43a3a3885dfe7d39cff","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","created_at":"2011-09-01T21:41:26Z","updated_at":"2015-05-11T10:29:33Z","pushed_at":"2015-05-11T17:37:51Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":421064,"stargazers_count":1300,"watchers_count":1300,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":706,"mirror_url":null,"open_issues_count":129,"forks":706,"open_issues":129,"watchers":1300,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4450"},"html":{"href":"https://github.com/ceph/ceph/pull/4450"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/4450"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/4450/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4450/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4450/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/972e9a5a004822b5dfe50283ce2f61e688be4d84"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"athanatos","id":544782,"avatar_url":"https://avatars.githubusercontent.com/u/544782?v=3","gravatar_id":"","url":"https://api.github.com/users/athanatos","html_url":"https://github.com/athanatos","followers_url":"https://api.github.com/users/athanatos/followers","following_url":"https://api.github.com/users/athanatos/following{/other_user}","gists_url":"https://api.github.com/users/athanatos/gists{/gist_id}","starred_url":"https://api.github.com/users/athanatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athanatos/subscriptions","organizations_url":"https://api.github.com/users/athanatos/orgs","repos_url":"https://api.github.com/users/athanatos/repos","events_url":"https://api.github.com/users/athanatos/events{/privacy}","received_events_url":"https://api.github.com/users/athanatos/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}