{"action":"created","comment":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments/33596087","id":33596087,"diff_hunk":"@@ -88,17 +88,21 @@ def junk(n=4)\n   def on_request_uri(cli, request)\n     agent = request.headers['User-Agent']\n     if agent !~ /Firefox\\/3\\.6\\.(16|17)/\n-      print_error(\"This browser is not supported: #{agent.to_s}\")\n+      print_error(\"This browser is not supported: #{agent}\")\n       send_not_found(cli)\n       return\n     end\n \n     my_target = target\n     if my_target.name == 'Automatic'\n-      if agent =~ /NT 5\\.1/ and agent =~ /Firefox\\/3\\.6\\.16/\n+      if agent =~ /NT 5\\.1/ && agent =~ /Firefox\\/3\\.6\\.16/\n         my_target = targets[1]\n-      elsif agent =~ /NT 6\\.1/ and agent =~ /Firefox\\/3\\.6\\.16/\n+      elsif agent =~ /NT 6\\.[01]/ && agent =~ /Firefox\\/3\\.6\\.16/","path":"modules/exploits/windows/browser/mozilla_reduceright.rb","position":16,"original_position":16,"commit_id":"3632cc44c59d757ed9eec12fb1e6a0c31833b45f","original_commit_id":"3632cc44c59d757ed9eec12fb1e6a0c31833b45f","user":{"login":"wvu-r7","id":4551878,"avatar_url":"https://avatars.githubusercontent.com/u/4551878?v=3","gravatar_id":"","url":"https://api.github.com/users/wvu-r7","html_url":"https://github.com/wvu-r7","followers_url":"https://api.github.com/users/wvu-r7/followers","following_url":"https://api.github.com/users/wvu-r7/following{/other_user}","gists_url":"https://api.github.com/users/wvu-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/wvu-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvu-r7/subscriptions","organizations_url":"https://api.github.com/users/wvu-r7/orgs","repos_url":"https://api.github.com/users/wvu-r7/repos","events_url":"https://api.github.com/users/wvu-r7/events{/privacy}","received_events_url":"https://api.github.com/users/wvu-r7/received_events","type":"User","site_admin":false},"body":"https://github.com/wvu-r7/metasploit-framework/blob/beug/nil/modules/exploits/windows/browser/mozilla_reduceright.rb#L65","created_at":"2015-06-30T16:57:50Z","updated_at":"2015-06-30T16:57:50Z","html_url":"https://github.com/rapid7/metasploit-framework/pull/5632#discussion_r33596087","pull_request_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/5632","_links":{"self":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments/33596087"},"html":{"href":"https://github.com/rapid7/metasploit-framework/pull/5632#discussion_r33596087"},"pull_request":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/5632"}}},"pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/5632","id":38810101,"html_url":"https://github.com/rapid7/metasploit-framework/pull/5632","diff_url":"https://github.com/rapid7/metasploit-framework/pull/5632.diff","patch_url":"https://github.com/rapid7/metasploit-framework/pull/5632.patch","issue_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/5632","number":5632,"state":"open","locked":false,"title":"Fix nil error when target not found","user":{"login":"wvu-r7","id":4551878,"avatar_url":"https://avatars.githubusercontent.com/u/4551878?v=3","gravatar_id":"","url":"https://api.github.com/users/wvu-r7","html_url":"https://github.com/wvu-r7","followers_url":"https://api.github.com/users/wvu-r7/followers","following_url":"https://api.github.com/users/wvu-r7/following{/other_user}","gists_url":"https://api.github.com/users/wvu-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/wvu-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvu-r7/subscriptions","organizations_url":"https://api.github.com/users/wvu-r7/orgs","repos_url":"https://api.github.com/users/wvu-r7/repos","events_url":"https://api.github.com/users/wvu-r7/events{/privacy}","received_events_url":"https://api.github.com/users/wvu-r7/received_events","type":"User","site_admin":false},"body":"Discovered in #5624.\r\n\r\n- [ ] Fire up ```exploit/windows/browser/mozilla_reduceright```\r\n- [ ] Test with an unexpected user agent\r\n- [ ] See a 404\r\n- [ ] Don't see a ```nil``` error in ```msfconsole```\r\n- [ ] Test with an expected user agent (```curl -A```, ```wget -U```, etc.)\r\n- [ ] See the exploit code\r\n\r\nI'm using \"NT 5.1 Firefox/3.6.16\" as a valid user agent.","created_at":"2015-06-29T19:47:38Z","updated_at":"2015-06-30T16:57:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36e7b04d1ef36bd9f9c7c02f1785003ec7a30972","assignee":{"login":"MSadek-r7","id":12971129,"avatar_url":"https://avatars.githubusercontent.com/u/12971129?v=3","gravatar_id":"","url":"https://api.github.com/users/MSadek-r7","html_url":"https://github.com/MSadek-r7","followers_url":"https://api.github.com/users/MSadek-r7/followers","following_url":"https://api.github.com/users/MSadek-r7/following{/other_user}","gists_url":"https://api.github.com/users/MSadek-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/MSadek-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSadek-r7/subscriptions","organizations_url":"https://api.github.com/users/MSadek-r7/orgs","repos_url":"https://api.github.com/users/MSadek-r7/repos","events_url":"https://api.github.com/users/MSadek-r7/events{/privacy}","received_events_url":"https://api.github.com/users/MSadek-r7/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/5632/commits","review_comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/5632/comments","review_comment_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/5632/comments","statuses_url":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/3632cc44c59d757ed9eec12fb1e6a0c31833b45f","head":{"label":"wvu-r7:beug/nil","ref":"beug/nil","sha":"3632cc44c59d757ed9eec12fb1e6a0c31833b45f","user":{"login":"wvu-r7","id":4551878,"avatar_url":"https://avatars.githubusercontent.com/u/4551878?v=3","gravatar_id":"","url":"https://api.github.com/users/wvu-r7","html_url":"https://github.com/wvu-r7","followers_url":"https://api.github.com/users/wvu-r7/followers","following_url":"https://api.github.com/users/wvu-r7/following{/other_user}","gists_url":"https://api.github.com/users/wvu-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/wvu-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvu-r7/subscriptions","organizations_url":"https://api.github.com/users/wvu-r7/orgs","repos_url":"https://api.github.com/users/wvu-r7/repos","events_url":"https://api.github.com/users/wvu-r7/events{/privacy}","received_events_url":"https://api.github.com/users/wvu-r7/received_events","type":"User","site_admin":false},"repo":{"id":10491111,"name":"metasploit-framework","full_name":"wvu-r7/metasploit-framework","owner":{"login":"wvu-r7","id":4551878,"avatar_url":"https://avatars.githubusercontent.com/u/4551878?v=3","gravatar_id":"","url":"https://api.github.com/users/wvu-r7","html_url":"https://github.com/wvu-r7","followers_url":"https://api.github.com/users/wvu-r7/followers","following_url":"https://api.github.com/users/wvu-r7/following{/other_user}","gists_url":"https://api.github.com/users/wvu-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/wvu-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvu-r7/subscriptions","organizations_url":"https://api.github.com/users/wvu-r7/orgs","repos_url":"https://api.github.com/users/wvu-r7/repos","events_url":"https://api.github.com/users/wvu-r7/events{/privacy}","received_events_url":"https://api.github.com/users/wvu-r7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wvu-r7/metasploit-framework","description":"Metasploit Framework","fork":true,"url":"https://api.github.com/repos/wvu-r7/metasploit-framework","forks_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/forks","keys_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/teams","hooks_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/hooks","issue_events_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/issues/events{/number}","events_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/events","assignees_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/assignees{/user}","branches_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/branches{/branch}","tags_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/tags","blobs_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/languages","stargazers_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/stargazers","contributors_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/contributors","subscribers_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/subscribers","subscription_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/subscription","commits_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/contents/{+path}","compare_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/merges","archive_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/downloads","issues_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/issues{/number}","pulls_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/labels{/name}","releases_url":"https://api.github.com/repos/wvu-r7/metasploit-framework/releases{/id}","created_at":"2013-06-04T23:42:41Z","updated_at":"2015-05-07T15:10:29Z","pushed_at":"2015-06-30T16:48:48Z","git_url":"git://github.com/wvu-r7/metasploit-framework.git","ssh_url":"git@github.com:wvu-r7/metasploit-framework.git","clone_url":"https://github.com/wvu-r7/metasploit-framework.git","svn_url":"https://github.com/wvu-r7/metasploit-framework","homepage":"http://www.metasploit.com/","size":282153,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"rapid7:master","ref":"master","sha":"1bfa84b37bcacb7e634a430da42053f67a942627","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":2293158,"name":"metasploit-framework","full_name":"rapid7/metasploit-framework","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/metasploit-framework","description":"Metasploit Framework","fork":false,"url":"https://api.github.com/repos/rapid7/metasploit-framework","forks_url":"https://api.github.com/repos/rapid7/metasploit-framework/forks","keys_url":"https://api.github.com/repos/rapid7/metasploit-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/metasploit-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/metasploit-framework/teams","hooks_url":"https://api.github.com/repos/rapid7/metasploit-framework/hooks","issue_events_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/metasploit-framework/events","assignees_url":"https://api.github.com/repos/rapid7/metasploit-framework/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/metasploit-framework/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/metasploit-framework/tags","blobs_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/metasploit-framework/languages","stargazers_url":"https://api.github.com/repos/rapid7/metasploit-framework/stargazers","contributors_url":"https://api.github.com/repos/rapid7/metasploit-framework/contributors","subscribers_url":"https://api.github.com/repos/rapid7/metasploit-framework/subscribers","subscription_url":"https://api.github.com/repos/rapid7/metasploit-framework/subscription","commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/metasploit-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/metasploit-framework/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/metasploit-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/metasploit-framework/merges","archive_url":"https://api.github.com/repos/rapid7/metasploit-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/metasploit-framework/downloads","issues_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/metasploit-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/metasploit-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/metasploit-framework/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/metasploit-framework/releases{/id}","created_at":"2011-08-30T06:13:20Z","updated_at":"2015-06-30T10:08:00Z","pushed_at":"2015-06-30T16:48:53Z","git_url":"git://github.com/rapid7/metasploit-framework.git","ssh_url":"git@github.com:rapid7/metasploit-framework.git","clone_url":"https://github.com/rapid7/metasploit-framework.git","svn_url":"https://github.com/rapid7/metasploit-framework","homepage":"http://www.metasploit.com/","size":1073070,"stargazers_count":4003,"watchers_count":4003,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3198,"mirror_url":null,"open_issues_count":211,"forks":3198,"open_issues":211,"watchers":4003,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/5632"},"html":{"href":"https://github.com/rapid7/metasploit-framework/pull/5632"},"issue":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/issues/5632"},"comments":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/issues/5632/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/5632/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/5632/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/metasploit-framework/statuses/3632cc44c59d757ed9eec12fb1e6a0c31833b45f"}}}}