{"action":"created","issue":{"url":"https://api.github.com/repos/learn-co-curriculum/objc-deli/issues/11","labels_url":"https://api.github.com/repos/learn-co-curriculum/objc-deli/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/learn-co-curriculum/objc-deli/issues/11/comments","events_url":"https://api.github.com/repos/learn-co-curriculum/objc-deli/issues/11/events","html_url":"https://github.com/learn-co-curriculum/objc-deli/issues/11","id":84531156,"number":11,"title":"Methods need work","user":{"login":"misterfifths","id":1193940,"avatar_url":"https://avatars.githubusercontent.com/u/1193940?v=3","gravatar_id":"","url":"https://api.github.com/users/misterfifths","html_url":"https://github.com/misterfifths","followers_url":"https://api.github.com/users/misterfifths/followers","following_url":"https://api.github.com/users/misterfifths/following{/other_user}","gists_url":"https://api.github.com/users/misterfifths/gists{/gist_id}","starred_url":"https://api.github.com/users/misterfifths/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterfifths/subscriptions","organizations_url":"https://api.github.com/users/misterfifths/orgs","repos_url":"https://api.github.com/users/misterfifths/repos","events_url":"https://api.github.com/users/misterfifths/events{/privacy}","received_events_url":"https://api.github.com/users/misterfifths/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-03T12:20:59Z","updated_at":"2015-06-24T17:34:18Z","closed_at":"2015-06-24T17:34:18Z","body":"Hm... the methods in this one and what they do/return are ... weird.\r\nA lot of them take mutable arrays, but are expected to return arrays... there is a 99% chance the student is going to modify the array argument, so why return it, too? If we don't want them to modify the argument, we shouldn't be passing a mutable array.... weird.\r\nAlso, I'd expect a method called `takeANumber...` to return a number. But... it returns an array... weird.\r\n\r\nSo some thoughts:\r\n\r\n- How important is teaching return values at this point? If it's not, I think most of these methods make a ton more sense as void.\r\n- `takeANumberWithDeliLine:name:` should maybe be `addCustomerNamed:toDeliLine:`, and return void?\r\n- `nowServingWithDeliLine:` is a totally weird name. `serveNextCustomerInDeliLine:` makes much more sense to me. Same issue as the other methods with its return value.\r\n- `deliLine:` is also a totally weird name for something that formats an array (not to mention that there's the definite potential that they'll have a property named `deliLine`, so having `deliLine` (the getter) and `deliLine:` (the method) would be super confusing). `stringWithDeliLine:` or `formatDeliLine:` would be much better. Also they don't use this method anywhere...\r\n\r\nA thought:\r\nMaybe this gets reorganized like this: the method `addCustomer...` could stay `takeANumber...` and actually *return* the position the new customer received in line. `serveNextCustomer...` could print out whose getting served, and then the remaining line, using their `stringWithDeliLine:` method. That feels much less contrived to me."},"comment":{"url":"https://api.github.com/repos/learn-co-curriculum/objc-deli/issues/comments/114949758","html_url":"https://github.com/learn-co-curriculum/objc-deli/issues/11#issuecomment-114949758","issue_url":"https://api.github.com/repos/learn-co-curriculum/objc-deli/issues/11","id":114949758,"user":{"login":"markedwardmurray","id":10505365,"avatar_url":"https://avatars.githubusercontent.com/u/10505365?v=3","gravatar_id":"","url":"https://api.github.com/users/markedwardmurray","html_url":"https://github.com/markedwardmurray","followers_url":"https://api.github.com/users/markedwardmurray/followers","following_url":"https://api.github.com/users/markedwardmurray/following{/other_user}","gists_url":"https://api.github.com/users/markedwardmurray/gists{/gist_id}","starred_url":"https://api.github.com/users/markedwardmurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markedwardmurray/subscriptions","organizations_url":"https://api.github.com/users/markedwardmurray/orgs","repos_url":"https://api.github.com/users/markedwardmurray/repos","events_url":"https://api.github.com/users/markedwardmurray/events{/privacy}","received_events_url":"https://api.github.com/users/markedwardmurray/received_events","type":"User","site_admin":false},"created_at":"2015-06-24T17:34:18Z","updated_at":"2015-06-24T17:34:18Z","body":"Methods renamed in rewrite."}}