{"action":"created","issue":{"url":"https://api.github.com/repos/square/leakcanary/issues/154","labels_url":"https://api.github.com/repos/square/leakcanary/issues/154/labels{/name}","comments_url":"https://api.github.com/repos/square/leakcanary/issues/154/comments","events_url":"https://api.github.com/repos/square/leakcanary/issues/154/events","html_url":"https://github.com/square/leakcanary/issues/154","id":81642625,"number":154,"title":"Use one leakcanary directory per app","user":{"login":"pyricau","id":557033,"avatar_url":"https://avatars.githubusercontent.com/u/557033?v=3","gravatar_id":"","url":"https://api.github.com/users/pyricau","html_url":"https://github.com/pyricau","followers_url":"https://api.github.com/users/pyricau/followers","following_url":"https://api.github.com/users/pyricau/following{/other_user}","gists_url":"https://api.github.com/users/pyricau/gists{/gist_id}","starred_url":"https://api.github.com/users/pyricau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyricau/subscriptions","organizations_url":"https://api.github.com/users/pyricau/orgs","repos_url":"https://api.github.com/users/pyricau/repos","events_url":"https://api.github.com/users/pyricau/events{/privacy}","received_events_url":"https://api.github.com/users/pyricau/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-27T21:59:05Z","updated_at":"2015-05-28T00:45:12Z","closed_at":null,"body":"Quote from @andhie in #21 :\r\n\r\n>Due to the changes to move every heap dump to /sdcard/Download/leakcanary/detected_leaks, when you have multiple LeakCanary enabled version of different apps, LeakCanary cannot differentiate whose heap dump belongs to which app and will just happily list out all. And also due to the limited of number of dumps, other apps that has leaks could not dump due to the shared location.\r\nProposed changes\r\n1) Use /sdcard/Android/data/<packagename>\r\n2) Maintain /Downloads dir, but add another packagename folder\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/square/leakcanary/issues/comments/106126270","html_url":"https://github.com/square/leakcanary/issues/154#issuecomment-106126270","issue_url":"https://api.github.com/repos/square/leakcanary/issues/154","id":106126270,"user":{"login":"sjudd","id":1627211,"avatar_url":"https://avatars.githubusercontent.com/u/1627211?v=3","gravatar_id":"","url":"https://api.github.com/users/sjudd","html_url":"https://github.com/sjudd","followers_url":"https://api.github.com/users/sjudd/followers","following_url":"https://api.github.com/users/sjudd/following{/other_user}","gists_url":"https://api.github.com/users/sjudd/gists{/gist_id}","starred_url":"https://api.github.com/users/sjudd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjudd/subscriptions","organizations_url":"https://api.github.com/users/sjudd/orgs","repos_url":"https://api.github.com/users/sjudd/repos","events_url":"https://api.github.com/users/sjudd/events{/privacy}","received_events_url":"https://api.github.com/users/sjudd/received_events","type":"User","site_admin":false},"created_at":"2015-05-28T00:45:12Z","updated_at":"2015-05-28T00:45:12Z","body":"To be clear I don't want leak canary in release builds, and certainly don't plan to ship it in release builds, but accidents happen and a heap dump contains a lot of potentially sensitive information. \r\n\r\nParticularly since you can solve the issue here and in #21 by using the internal cache directory and a content provider, there doesn't seem to be much reason not to? "}}