{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/bryanbrazil/skin.mimic/pulls/18","id":45593855,"html_url":"https://github.com/bryanbrazil/skin.mimic/pull/18","diff_url":"https://github.com/bryanbrazil/skin.mimic/pull/18.diff","patch_url":"https://github.com/bryanbrazil/skin.mimic/pull/18.patch","issue_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/issues/18","number":18,"state":"closed","locked":false,"title":"Update to utilise skinshortcuts (0.5.3) for main menu, background, widgets","user":{"login":"Ignoble61","id":12768752,"avatar_url":"https://avatars.githubusercontent.com/u/12768752?v=3","gravatar_id":"","url":"https://api.github.com/users/Ignoble61","html_url":"https://github.com/Ignoble61","followers_url":"https://api.github.com/users/Ignoble61/followers","following_url":"https://api.github.com/users/Ignoble61/following{/other_user}","gists_url":"https://api.github.com/users/Ignoble61/gists{/gist_id}","starred_url":"https://api.github.com/users/Ignoble61/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ignoble61/subscriptions","organizations_url":"https://api.github.com/users/Ignoble61/orgs","repos_url":"https://api.github.com/users/Ignoble61/repos","events_url":"https://api.github.com/users/Ignoble61/events{/privacy}","received_events_url":"https://api.github.com/users/Ignoble61/received_events","type":"User","site_admin":false},"body":"I know you've moved on to Arctic, so if you're not interested in this that's no problem at all :)\r\n\r\nI was curious just how difficult it would be to move Mimic to fully utilise Skin Shortcuts - as it is, a lot harder than I anticipated and I can understand exactly why you didn't do it! Still, I can never resist a challenge ;)\r\n\r\nI've done it as multiple commits to try and make the changes easier to follow, but if you want to merge it (absolutely your choice, I won't be offended if you don't!) I'll happily squash the commits.\r\n\r\nA couple of things to note about it:\r\n\r\n* The only testing it's had is from me as I've been making the changes. It's one of those situations where most things should be working, but there may well be bugs.\r\n* And there's at least one known bug (~~I'm sure I had a second, but can't remember it now~~ remembered and fixed the second & updated PR) - the description text for the skinshortcuts management dialog is completely wrong :) (You'll see what I mean when you select certain options in the management dialog)\r\n* It doesn't include any pre-defined menu/submenu items (the x1, x2 etc won't be used), so the menu items default to those included with the script (based off of Confluences defaults). It also doesn't have any default backgrounds/widgets for menu items.\r\n* The final commit removes custom dialogs I _think_ are unnecessary with the changes made, but I haven't fully checked this out.\r\n\r\nRegards.","created_at":"2015-09-21T20:12:21Z","updated_at":"2015-09-28T13:15:21Z","closed_at":"2015-09-28T13:15:21Z","merged_at":"2015-09-28T13:15:21Z","merge_commit_sha":"a476911ca0e0d8d26574679082042216e07ce5a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/pulls/18/commits","review_comments_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/pulls/18/comments","review_comment_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/issues/18/comments","statuses_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/statuses/7a8779d5798df42f7388951f3fa36819cb406cda","head":{"label":"Ignoble61:master","ref":"master","sha":"7a8779d5798df42f7388951f3fa36819cb406cda","user":{"login":"Ignoble61","id":12768752,"avatar_url":"https://avatars.githubusercontent.com/u/12768752?v=3","gravatar_id":"","url":"https://api.github.com/users/Ignoble61","html_url":"https://github.com/Ignoble61","followers_url":"https://api.github.com/users/Ignoble61/followers","following_url":"https://api.github.com/users/Ignoble61/following{/other_user}","gists_url":"https://api.github.com/users/Ignoble61/gists{/gist_id}","starred_url":"https://api.github.com/users/Ignoble61/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ignoble61/subscriptions","organizations_url":"https://api.github.com/users/Ignoble61/orgs","repos_url":"https://api.github.com/users/Ignoble61/repos","events_url":"https://api.github.com/users/Ignoble61/events{/privacy}","received_events_url":"https://api.github.com/users/Ignoble61/received_events","type":"User","site_admin":false},"repo":{"id":42869823,"name":"skin.mimic","full_name":"Ignoble61/skin.mimic","owner":{"login":"Ignoble61","id":12768752,"avatar_url":"https://avatars.githubusercontent.com/u/12768752?v=3","gravatar_id":"","url":"https://api.github.com/users/Ignoble61","html_url":"https://github.com/Ignoble61","followers_url":"https://api.github.com/users/Ignoble61/followers","following_url":"https://api.github.com/users/Ignoble61/following{/other_user}","gists_url":"https://api.github.com/users/Ignoble61/gists{/gist_id}","starred_url":"https://api.github.com/users/Ignoble61/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ignoble61/subscriptions","organizations_url":"https://api.github.com/users/Ignoble61/orgs","repos_url":"https://api.github.com/users/Ignoble61/repos","events_url":"https://api.github.com/users/Ignoble61/events{/privacy}","received_events_url":"https://api.github.com/users/Ignoble61/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ignoble61/skin.mimic","description":"A Kodi skin with touches of reFocus and Aeon Nox.","fork":true,"url":"https://api.github.com/repos/Ignoble61/skin.mimic","forks_url":"https://api.github.com/repos/Ignoble61/skin.mimic/forks","keys_url":"https://api.github.com/repos/Ignoble61/skin.mimic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ignoble61/skin.mimic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ignoble61/skin.mimic/teams","hooks_url":"https://api.github.com/repos/Ignoble61/skin.mimic/hooks","issue_events_url":"https://api.github.com/repos/Ignoble61/skin.mimic/issues/events{/number}","events_url":"https://api.github.com/repos/Ignoble61/skin.mimic/events","assignees_url":"https://api.github.com/repos/Ignoble61/skin.mimic/assignees{/user}","branches_url":"https://api.github.com/repos/Ignoble61/skin.mimic/branches{/branch}","tags_url":"https://api.github.com/repos/Ignoble61/skin.mimic/tags","blobs_url":"https://api.github.com/repos/Ignoble61/skin.mimic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ignoble61/skin.mimic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ignoble61/skin.mimic/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ignoble61/skin.mimic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ignoble61/skin.mimic/statuses/{sha}","languages_url":"https://api.github.com/repos/Ignoble61/skin.mimic/languages","stargazers_url":"https://api.github.com/repos/Ignoble61/skin.mimic/stargazers","contributors_url":"https://api.github.com/repos/Ignoble61/skin.mimic/contributors","subscribers_url":"https://api.github.com/repos/Ignoble61/skin.mimic/subscribers","subscription_url":"https://api.github.com/repos/Ignoble61/skin.mimic/subscription","commits_url":"https://api.github.com/repos/Ignoble61/skin.mimic/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ignoble61/skin.mimic/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ignoble61/skin.mimic/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ignoble61/skin.mimic/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ignoble61/skin.mimic/contents/{+path}","compare_url":"https://api.github.com/repos/Ignoble61/skin.mimic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ignoble61/skin.mimic/merges","archive_url":"https://api.github.com/repos/Ignoble61/skin.mimic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ignoble61/skin.mimic/downloads","issues_url":"https://api.github.com/repos/Ignoble61/skin.mimic/issues{/number}","pulls_url":"https://api.github.com/repos/Ignoble61/skin.mimic/pulls{/number}","milestones_url":"https://api.github.com/repos/Ignoble61/skin.mimic/milestones{/number}","notifications_url":"https://api.github.com/repos/Ignoble61/skin.mimic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ignoble61/skin.mimic/labels{/name}","releases_url":"https://api.github.com/repos/Ignoble61/skin.mimic/releases{/id}","created_at":"2015-09-21T14:04:24Z","updated_at":"2015-08-31T13:21:55Z","pushed_at":"2015-09-22T00:44:33Z","git_url":"git://github.com/Ignoble61/skin.mimic.git","ssh_url":"git@github.com:Ignoble61/skin.mimic.git","clone_url":"https://github.com/Ignoble61/skin.mimic.git","svn_url":"https://github.com/Ignoble61/skin.mimic","homepage":"","size":34971,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bryanbrazil:master","ref":"master","sha":"bce4105bfe4f482477df74821eacf64474202aad","user":{"login":"bryanbrazil","id":7245177,"avatar_url":"https://avatars.githubusercontent.com/u/7245177?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanbrazil","html_url":"https://github.com/bryanbrazil","followers_url":"https://api.github.com/users/bryanbrazil/followers","following_url":"https://api.github.com/users/bryanbrazil/following{/other_user}","gists_url":"https://api.github.com/users/bryanbrazil/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanbrazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanbrazil/subscriptions","organizations_url":"https://api.github.com/users/bryanbrazil/orgs","repos_url":"https://api.github.com/users/bryanbrazil/repos","events_url":"https://api.github.com/users/bryanbrazil/events{/privacy}","received_events_url":"https://api.github.com/users/bryanbrazil/received_events","type":"User","site_admin":false},"repo":{"id":27470349,"name":"skin.mimic","full_name":"bryanbrazil/skin.mimic","owner":{"login":"bryanbrazil","id":7245177,"avatar_url":"https://avatars.githubusercontent.com/u/7245177?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanbrazil","html_url":"https://github.com/bryanbrazil","followers_url":"https://api.github.com/users/bryanbrazil/followers","following_url":"https://api.github.com/users/bryanbrazil/following{/other_user}","gists_url":"https://api.github.com/users/bryanbrazil/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanbrazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanbrazil/subscriptions","organizations_url":"https://api.github.com/users/bryanbrazil/orgs","repos_url":"https://api.github.com/users/bryanbrazil/repos","events_url":"https://api.github.com/users/bryanbrazil/events{/privacy}","received_events_url":"https://api.github.com/users/bryanbrazil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bryanbrazil/skin.mimic","description":"A Kodi skin with touches of reFocus and Aeon Nox.","fork":false,"url":"https://api.github.com/repos/bryanbrazil/skin.mimic","forks_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/forks","keys_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/teams","hooks_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/hooks","issue_events_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/issues/events{/number}","events_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/events","assignees_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/assignees{/user}","branches_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/branches{/branch}","tags_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/tags","blobs_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/git/refs{/sha}","trees_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/statuses/{sha}","languages_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/languages","stargazers_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/stargazers","contributors_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/contributors","subscribers_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/subscribers","subscription_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/subscription","commits_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/commits{/sha}","git_commits_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/git/commits{/sha}","comments_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/comments{/number}","issue_comment_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/issues/comments{/number}","contents_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/contents/{+path}","compare_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/merges","archive_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/downloads","issues_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/issues{/number}","pulls_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/pulls{/number}","milestones_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/milestones{/number}","notifications_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/labels{/name}","releases_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/releases{/id}","created_at":"2014-12-03T05:07:37Z","updated_at":"2015-08-31T13:21:55Z","pushed_at":"2015-09-28T13:15:21Z","git_url":"git://github.com/bryanbrazil/skin.mimic.git","ssh_url":"git@github.com:bryanbrazil/skin.mimic.git","clone_url":"https://github.com/bryanbrazil/skin.mimic.git","svn_url":"https://github.com/bryanbrazil/skin.mimic","homepage":"","size":37039,"stargazers_count":33,"watchers_count":33,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":1,"forks":17,"open_issues":1,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bryanbrazil/skin.mimic/pulls/18"},"html":{"href":"https://github.com/bryanbrazil/skin.mimic/pull/18"},"issue":{"href":"https://api.github.com/repos/bryanbrazil/skin.mimic/issues/18"},"comments":{"href":"https://api.github.com/repos/bryanbrazil/skin.mimic/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/bryanbrazil/skin.mimic/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/bryanbrazil/skin.mimic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bryanbrazil/skin.mimic/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/bryanbrazil/skin.mimic/statuses/7a8779d5798df42f7388951f3fa36819cb406cda"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bryanbrazil","id":7245177,"avatar_url":"https://avatars.githubusercontent.com/u/7245177?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanbrazil","html_url":"https://github.com/bryanbrazil","followers_url":"https://api.github.com/users/bryanbrazil/followers","following_url":"https://api.github.com/users/bryanbrazil/following{/other_user}","gists_url":"https://api.github.com/users/bryanbrazil/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanbrazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanbrazil/subscriptions","organizations_url":"https://api.github.com/users/bryanbrazil/orgs","repos_url":"https://api.github.com/users/bryanbrazil/repos","events_url":"https://api.github.com/users/bryanbrazil/events{/privacy}","received_events_url":"https://api.github.com/users/bryanbrazil/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":6,"additions":411,"deletions":2919,"changed_files":16}}