{"push_id":683942166,"size":24,"distinct_size":24,"ref":"refs/heads/master","head":"1b62ef8e92e11a1eef521d024af0a3c74a3fc925","before":"87cd0f3d49aca809d55245c6cf9248c945d73214","commits":[{"sha":"328dda4ba39461638435e9723034a26287238c3c","author":{"email":"7aa2b466eef8222f66a6ce3eb05355785a4c9dc5@fb.com","name":"Philip Pronin"},"message":"drop V0 of EliasFanoEncoder\n\nSummary: Cleanup. Drop support for V0 in favor of V1.\n\nTest Plan: unit tests\n\nReviewed By: lucian@fb.com\n\nSubscribers: fbcode-common-diffs@, chaoyc, search-fbcode-diffs@, unicorn-diffs@, folly-diffs@, yfeldblum, tudort, chalfant\n\nFB internal diff: D2105967\n\nSignature: t1:2105967:1432781247:e420d8b4b8c69d28dfc229e8a2af6df8a580f979","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/328dda4ba39461638435e9723034a26287238c3c"},{"sha":"23bc29b8109d9dc11793367f6bdcfa1962471c27","author":{"email":"b7d94d68f2a706f68dc322cd1b880e1af3c35c03@fb.com","name":"Lucian Grijincu"},"message":"folly: MemoryMapping: madvise: round the end to lower bound\n\nTest Plan: n/a\n\nReviewed By: ott@fb.com\n\nSubscribers: ott, folly-diffs@, yfeldblum, tudort, chalfant\n\nFB internal diff: D2100535\n\nTasks: 4421175\n\nSignature: t1:2100535:1432674713:6f5f40a8462851b2b8972c68d34ae23aaf1e9340","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/23bc29b8109d9dc11793367f6bdcfa1962471c27"},{"sha":"f92ce30d990d2e8d90a056401b8e58459f733409","author":{"email":"3dcaa0c42eac86d7a3fc2bd2ca33ce3bc4514178@fb.com","name":"Sarang Masti"},"message":"Fix AsyncSocket::handleRead\n\nSummary:\nIf openssl has buffered data read from the socket, we might not get a\nread event on the socket. So, we must schedule a readCallback to ensure\nbefore exiting from AsyncSocket::handleRead if we have exhausted the\nmaxReadsPerEvent_ limit.\n\nTest Plan: -- modifying existing test to test this corner case.\n\nReviewed By: davejwatson@fb.com\n\nSubscribers: net-systems@, trunkagent, folly-diffs@, yfeldblum, chalfant\n\nFB internal diff: D2102601\n\nTasks: 7168699\n\nSignature: t1:2102601:1432837605:82e72a2a1875c08c9c1e8e831796c9c90df927fa","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/f92ce30d990d2e8d90a056401b8e58459f733409"},{"sha":"fa2487779f809c0283f16dc4fc081e9384beefa6","author":{"email":"aa81cd2030f21b5bf11d7ed340f43a6115973161@fb.com","name":"Dave Watson"},"message":"Chain interrupt handlers\n\nSummary: Chain interrupt handlers in then().  User can always choose to set a new one later.\n\nTest Plan: added unittest\n\nReviewed By: hans@fb.com\n\nSubscribers: doug, folly-diffs@, jsedgwick, yfeldblum, chalfant\n\nFB internal diff: D2091569\n\nSignature: t1:2091569:1432760579:ea7afa9b4e62e4b04b4d5f17950b9b7356a57f09","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/fa2487779f809c0283f16dc4fc081e9384beefa6"},{"sha":"5b39efc2656ebcd74b46775ad276c1ab06c3c54b","author":{"email":"5cb9ce571840ae843d133a5913dd7c2cf5583ac1@fb.com","name":"Tudor Bosman"},"message":"Fix toString() for authority-less URIs\n\nSummary: Uri(\"foo:bar\").str() would incorrectly return \"foo://bar\"\n\nTest Plan: test added\n\nReviewed By: savasp@fb.com, markisaa@fb.com\n\nSubscribers: folly-diffs@, yfeldblum, chalfant\n\nFB internal diff: D2107530\n\nTasks: 7248055\n\nSignature: t1:2107530:1432837143:c100f148c07b5b141cc036b1b39e6c8317e9bbd6","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/5b39efc2656ebcd74b46775ad276c1ab06c3c54b"},{"sha":"a95dbe434014196d44fa03d0f60d5efef662fd20","author":{"email":"74a666cc7c47a976d46f22b84cb3bbb8f8910733@fb.com","name":"Delyan Kratunov"},"message":"Extract TurnSequencer to detail/TurnSequencer\n\nSummary:\nA completely mechanical transformation that moves TurnSequencer into its own\nheader, to be used by other collections.\n\nTest Plan: Existing tests.\n\nReviewed By: jmkaldor@fb.com\n\nSubscribers: folly-diffs@, yfeldblum, chalfant\n\nFB internal diff: D2065108\n\nSignature: t1:2065108:1431474613:a3a9d063ebd2bedb31abb37be5fd33f0fb3eca6a","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/a95dbe434014196d44fa03d0f60d5efef662fd20"},{"sha":"fff701bfc7db2f23becae9da222a63a7ad86177b","author":{"email":"74a666cc7c47a976d46f22b84cb3bbb8f8910733@fb.com","name":"Delyan Kratunov"},"message":"LockFreeRingBuffer\n\nSummary:\nThis introduces a lock-free ring buffer with the following expected semantics:\n\n1. Writers can't block on readers\n2. Writers are mostly lock-free\n3. Readers can detect if they're being too slow\n4. Be usable on Android (TBD but should work as-is with the armeabi-v7a ABI; armeabi (ARMv5) support is explicitly a non-goal)\n\nNon-goals:\n1. Match MPMCQueue in level of optimization. There's no need for that yet.\n\nTest Plan: iloveunittests\n\nReviewed By: ngbronson@fb.com\n\nSubscribers: trunkagent, folly-diffs@, yfeldblum, chalfant\n\nFB internal diff: D2037718\n\nSignature: t1:2037718:1432850250:c57963510d8cda58edc006f4c3260f5ac34d4996","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/fff701bfc7db2f23becae9da222a63a7ad86177b"},{"sha":"7a4c7813e2ea74b19fb2872b4f43a6ee304e1d49","author":{"email":"74a666cc7c47a976d46f22b84cb3bbb8f8910733@fb.com","name":"Delyan Kratunov"},"message":"Make detail/Futex.cpp bionic-safe\n\nSummary:\nThe headers that the Android NDK exports are all sorts of screwed up.\nIn particular, they expose a subset of the `futex.h`, so, even though the\nkernel supports newer options, we can't reference them from the NDK headers.\n\nThis diff ensures Futex.cpp redefines all the things it uses, if the headers\nare lacking.\n\nIt also transitions away from `SYS_` to `__NR_` which is apparently the newer\nconvention.\n\nLastly, the duration usage is made explicitly `time_t`-safe for use on 32-bit\nplatforms where `time_t` is `long int` but `std::chrono:seconds` is stored as\n`long long int`.\n\nTest Plan:\nExisting tests, sample app compiled and ran cleanly on Android as well\n(tests not verified on Android due to folly largely being unported to Android yet).\n\nReviewed By: ngbronson@fb.com\n\nSubscribers: folly-diffs@, yfeldblum, chalfant\n\nFB internal diff: D2069306\n\nSignature: t1:2069306:1431721711:36c77b1afe8dd9259c1050f11a87511dcf7dd25f","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/7a4c7813e2ea74b19fb2872b4f43a6ee304e1d49"},{"sha":"8b9a09ce4320290b698f5a7804f25548ca85d10f","author":{"email":"74a666cc7c47a976d46f22b84cb3bbb8f8910733@fb.com","name":"Delyan Kratunov"},"message":"Make TurnSequencer non-x86-safe\n\nSummary:\n`TurnSequencer` uses inline assembly, which obviously won't work on ARM.\nGuard said assembly to x86{,_64} targets.\n\nTest Plan:\nAdded an always-false `static_assert` to the `ifdef` block, confirmed it gets\ntriggered (i.e., we're not removing the `pause` on x86_64).\n\nReviewed By: ngbronson@fb.com\n\nSubscribers: folly-diffs@, yfeldblum, chalfant\n\nFB internal diff: D2069320\n\nSignature: t1:2069320:1431663264:3b3fb4282cf2b755f9b26c76b608b91ff665e226","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/8b9a09ce4320290b698f5a7804f25548ca85d10f"},{"sha":"8900cad8f8156ab4228ee3ace06e998e56b4c0bb","author":{"email":"aa81cd2030f21b5bf11d7ed340f43a6115973161@fb.com","name":"Dave Watson"},"message":"Chain executor in timeout functions\n\nSummary: within, onTimeout, etc use the executor of the future if it is set.\n\nTest Plan: added unittest\n\nReviewed By: hans@fb.com\n\nSubscribers: doug, folly-diffs@, jsedgwick, yfeldblum, chalfant\n\nFB internal diff: D2104770\n\nTasks: 6958727\n\nSignature: t1:2104770:1432773599:a71c00827071bef46e5700de04c7125142e4eb17","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/8900cad8f8156ab4228ee3ace06e998e56b4c0bb"},{"sha":"b89b79d96fab7562a4cbd11c70df65bdf16b0a62","author":{"email":"3dcaa0c42eac86d7a3fc2bd2ca33ce3bc4514178@fb.com","name":"Sarang Masti"},"message":"Fix asan test crashes\n\nSummary: We need to prevent the socket from being deleted while in the loopCallback.\n\nTest Plan: --  fbconfig '--sanitize' 'address' 'folly/io/async/test' && fbmake runtests\n\nReviewed By: davejwatson@fb.com\n\nSubscribers: trunkagent, folly-diffs@, yfeldblum, chalfant\n\nFB internal diff: D2109031\n\nTasks: 7250307\n\nSignature: t1:2109031:1432918801:77f0352254925d3f33f1e004c8bba89cde63e2cf\n\nBlame Revision: D2102601","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/b89b79d96fab7562a4cbd11c70df65bdf16b0a62"},{"sha":"b044e5c9dc25309ea1045515b4ff49aa9f0e218c","author":{"email":"df8321142419d1074f83746e9b4398dad647ae79@fb.com","name":"Hans Fugal"},"message":"update wangle/rx/README.md\n\nSummary:\nhttps://github.com/facebook/wangle/pull/1\n\nTest Plan: reads better\n\nReviewed By: jsedgwick@fb.com\n\nSubscribers: fugalh, exa, folly-diffs@, jsedgwick, yfeldblum, chalfant\n\nFB internal diff: D2111498\n\nSignature: t1:2111498:1432927058:1f14b38faa324d0bdef9421ae5592244a6b78928","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/b044e5c9dc25309ea1045515b4ff49aa9f0e218c"},{"sha":"8ec98dd875fd6a810693852d63f42f95dbbaeb52","author":{"email":"7ecde348ff9cda2c3ba69a0c4543365039d0d65b@fb.com","name":"Abhik Chatterjee"},"message":"Comparing against tlsExthostname_\n\nSummary:\nInstead of comparing tlsExthostname_ with NULL, we are comparing it\nagainst tlsExthostname_.\n\nTest Plan: Automated tests\n\nReviewed By: afrind@fb.com\n\nSubscribers: folly-diffs@, yfeldblum, chalfant, moa\n\nFB internal diff: D2106257\n\nTasks: 4751985\n\nSignature: t1:2106257:1432932687:78c6244392d7842e844a3c1e654ffc4dc0e760a2","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/8ec98dd875fd6a810693852d63f42f95dbbaeb52"},{"sha":"45339b04458a02d445c680175d8daa53fb90b512","author":{"email":"b7d94d68f2a706f68dc322cd1b880e1af3c35c03@fb.com","name":"Lucian Grijincu"},"message":"folly: -Wsign-compare\n\nTest Plan: runtests\n\nReviewed By: philipp@fb.com\n\nSubscribers: folly-diffs@, jsedgwick, yfeldblum, tudort, chalfant\n\nFB internal diff: D2114063\n\nSignature: t1:2114063:1433111051:6686508d78de39ea4ea5dc283189c472e23f8f42","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/45339b04458a02d445c680175d8daa53fb90b512"},{"sha":"1706959a50b7ccb77402822beba6529ba04f354b","author":{"email":"b7d94d68f2a706f68dc322cd1b880e1af3c35c03@fb.com","name":"Lucian Grijincu"},"message":"folly: exception_tracer: add throw() to __cxa_begin_catch\n\nSummary:\nhttp://libcxxabi.llvm.org/spec.html\n\nvoid* __cxa_begin_catch(void* exceptionObject) throw();\n\n```\nfolly/experimental/exception_tracer/ExceptionTracerLib.cpp:145:7: error: '__cxa_begin_catch' is missing exception specification 'throw()' [-Werror]\nvoid* __cxa_begin_catch(void *excObj) {\n^\nthrow()\nfolly/experimental/exception_tracer/ExceptionTracerLib.cpp:35:7: note: previous declaration is here\nvoid* __cxa_begin_catch(void* excObj);\n^\n1 error generated.\n11.44s error: folly/experimental/exception_tracer/ExceptionTracerLib.cpp\nfbmake: *** [_build/opt/folly/experimental/exception_tracer/b187621/ExceptionTracerLib.o] Error 1\n```\n\nTest Plan: fbmake\n\nReviewed By: philipp@fb.com\n\nSubscribers: folly-diffs@, yfeldblum, tudort, chalfant\n\nFB internal diff: D2115305\n\nTasks: 5908365\n\nSignature: t1:2115305:1433186210:3652d81ab10effe1be6da86705322ce090fb6cd4\n\nBlame Revision: https://phabricator.fb.com/D2114085","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/1706959a50b7ccb77402822beba6529ba04f354b"},{"sha":"d9e08fac978077172eff085989fe6c018c9fcaca","author":{"email":"4a98e43d78bab283938a06f38d2ca3a3c53f0476@fb.com","name":"Woo Xie"},"message":"enrich network-quality HTTPHeader field with retransmission rate\n\nSummary:\nestimating tcp retransmission rate of the socket\n\nTest Plan: unit tests\n\nReviewed By: afrind@fb.com\n\nSubscribers: folly-diffs@, njormrod, bmatheny, trunkagent, chalfant, yfeldblum, jsedgwick\n\nFB internal diff: D2097198\n\nTasks: 4888253\n\nSignature: t1:2097198:1433196365:16db26dfd721514481497eddfc7820a453618d33","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/d9e08fac978077172eff085989fe6c018c9fcaca"},{"sha":"5a2591ef0afd71a3fd6998907fbb06c9385de329","author":{"email":"2ba0544ef3c60815b2c2565a5ffe365dc1944e32@fb.com","name":"Haim Grosman"},"message":"folly: adding folly::ltrimWhitespace / folly::rtrimWhitespace\n\nSummary:\nfolly: adding folly::trimWhitespace\n\nextending the idea of folly::skipWhitespace.\nthe reason for adding it, we want to be able to do:\n\nauto s = skipWhitespace(trimWhitespace(\" aaaa \"))\n\nvery similar to python's strip()\n\nTest Plan:\nadding unit tests:\n\n# make ; _bin/folly/test/string_test --gtest_filter=\"String.whitespace\"\n# fbmake --ccache off --distcc off dbg -j 16\nfbmake dbg -j 16\nFbmake run id: G62i4cDP42U\nNote: Google Test filter = String.whitespace\n[==========] Running 1 test from 1 test case.\n[----------] Global test environment set-up.\n[----------] 1 test from String\n[ RUN      ] String.whitespace\n[       OK ] String.whitespace (0 ms)\n[----------] 1 test from String (0 ms total)\n\n[----------] Global test environment tear-down\n[==========] 1 test from 1 test case ran. (0 ms total)\n[  PASSED  ] 1 test.\n\nReviewed By: ldbrandy@fb.com\n\nSubscribers: ldbrandy, folly-diffs@, yfeldblum, chalfant, azhavnerchik\n\nFB internal diff: D2109364\n\nSignature: t1:2109364:1433192444:862e237bba1928fcb94be1f95c57a68d457939e9","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/5a2591ef0afd71a3fd6998907fbb06c9385de329"},{"sha":"ff7e12b66345f2b70d1c7657f72bd4c35518bd10","author":{"email":"1da10a8e149dfb1ccd9eb7c1757d35a7bc8cb72a@fb.com","name":"Mark McDuff"},"message":"AsyncServerSocket: more tries for binding to a port\n\nSummary: User reports of intermittent failures at 5.  Setting up a server is expensive.  Binding to a socket is pretty cheap.  Why not 25 tries?  Why not 100?\n\nTest Plan: hope\n\nReviewed By: alandau@fb.com\n\nSubscribers: folly-diffs@, yfeldblum, chalfant\n\nFB internal diff: D2116187\n\nSignature: t1:2116187:1433199889:09d6916eddf8521f120894ce361c3e1a96905c90","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/ff7e12b66345f2b70d1c7657f72bd4c35518bd10"},{"sha":"6f8699fc809889f748c2f83a9b042a497f81d32a","author":{"email":"74a666cc7c47a976d46f22b84cb3bbb8f8910733@fb.com","name":"Delyan Kratunov"},"message":"Minor fix\n\nSummary:\n`LockFreeRingBuffer` was using `std::unique_ptr` but not importing `memory`.\nAlso, Android NDK's libstdc++ doesn't provide `std::llround`, use straight\n`llround`, we don't need the constexpr-ness anyway.\n\nTest Plan: `fbmake runtests`\n\nReviewed By: jmkaldor@fb.com\n\nSubscribers: folly-diffs@, yfeldblum, chalfant\n\nFB internal diff: D2116923\n\nSignature: t1:2116923:1433210832:9ec0ed7f558c271a51d528b8f88fbce9b466ba3a","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/6f8699fc809889f748c2f83a9b042a497f81d32a"},{"sha":"789dbd170fb1d61e9720a057f146f86ec908186c","author":{"email":"acc8fc51de3428feca4651aeb2ec44ef1dcb8720@fb.com","name":"Hannes Roth"},"message":"(Wangle) Don't use std::bind in Core\n\nSummary:\nSeems like an unnecessary indirection that might make it harder to for\nthe compiler to inline everything (if that's even possible with\n`std::bind`)?\n\nTest Plan: Run all the tests.\n\nReviewed By: hans@fb.com\n\nSubscribers: folly-diffs@, jsedgwick, yfeldblum, chalfant\n\nFB internal diff: D2115032\n\nSignature: t1:2115032:1433182233:3938d0498cad50df32c8b6ee4536de14ae5fd006","distinct":true,"url":"https://api.github.com/repos/facebook/folly/commits/789dbd170fb1d61e9720a057f146f86ec908186c"}]}