{"action":"created","issue":{"url":"https://api.github.com/repos/504rules/504rules.github.io/issues/59","labels_url":"https://api.github.com/repos/504rules/504rules.github.io/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/504rules/504rules.github.io/issues/59/comments","events_url":"https://api.github.com/repos/504rules/504rules.github.io/issues/59/events","html_url":"https://github.com/504rules/504rules.github.io/pull/59","id":119827216,"number":59,"title":"My attempt at creating tags to switch between player/president.","user":{"login":"someknave","id":8626942,"avatar_url":"https://avatars.githubusercontent.com/u/8626942?v=3","gravatar_id":"","url":"https://api.github.com/users/someknave","html_url":"https://github.com/someknave","followers_url":"https://api.github.com/users/someknave/followers","following_url":"https://api.github.com/users/someknave/following{/other_user}","gists_url":"https://api.github.com/users/someknave/gists{/gist_id}","starred_url":"https://api.github.com/users/someknave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/someknave/subscriptions","organizations_url":"https://api.github.com/users/someknave/orgs","repos_url":"https://api.github.com/users/someknave/repos","events_url":"https://api.github.com/users/someknave/events{/privacy}","received_events_url":"https://api.github.com/users/someknave/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-01T22:53:48Z","updated_at":"2015-12-02T07:27:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/504rules/504rules.github.io/pulls/59","html_url":"https://github.com/504rules/504rules.github.io/pull/59","diff_url":"https://github.com/504rules/504rules.github.io/pull/59.diff","patch_url":"https://github.com/504rules/504rules.github.io/pull/59.patch"},"body":"As discussed in issue #15, the current rules don't distinguish between whether a player is doing something or a company. I have created the following tags to try to remedy this. (the document will still need to be updated if people feel like this is the way to go forward.)\r\nentity is either player/company and agent is either player/president. I felt that in the case of stock companies these shouldn't be mixed up. The president makes decisions and moves on the board, the company owns things, loses things, and gains things.\r\nI also feel that the word \"his\" should be replaced by \"the company's\" and \"its\" depending on context. (If company isn't in the sentence yet \"the company's\" should be used otherwise \"its\" should suffice.)\r\n\r\nI don't really like my solution, I feel that there should be a more elegant way of doing this with a single function call, but all the methods I tried didn't seem to work. If anyone has any suggestions let me know.\r\n\r\nIf people are happy I will implement this through the rules.\r\n"},"comment":{"url":"https://api.github.com/repos/504rules/504rules.github.io/issues/comments/161206098","html_url":"https://github.com/504rules/504rules.github.io/pull/59#issuecomment-161206098","issue_url":"https://api.github.com/repos/504rules/504rules.github.io/issues/59","id":161206098,"user":{"login":"Arachnid","id":17865,"avatar_url":"https://avatars.githubusercontent.com/u/17865?v=3","gravatar_id":"","url":"https://api.github.com/users/Arachnid","html_url":"https://github.com/Arachnid","followers_url":"https://api.github.com/users/Arachnid/followers","following_url":"https://api.github.com/users/Arachnid/following{/other_user}","gists_url":"https://api.github.com/users/Arachnid/gists{/gist_id}","starred_url":"https://api.github.com/users/Arachnid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arachnid/subscriptions","organizations_url":"https://api.github.com/users/Arachnid/orgs","repos_url":"https://api.github.com/users/Arachnid/repos","events_url":"https://api.github.com/users/Arachnid/events{/privacy}","received_events_url":"https://api.github.com/users/Arachnid/received_events","type":"User","site_admin":false},"created_at":"2015-12-02T07:27:55Z","updated_at":"2015-12-02T07:27:55Z","body":"This does seem like the best of bad options for handling this. Thanks for putting it together.\r\n\r\nFor the script, it'd be good to see \"isCompanyGame\" functions or similar, instead of putting the logic for deciding this inline. Other than that, it looks good to me."}}