{"action":"created","comment":{"url":"https://api.github.com/repos/ClusterHQ/flocker/pulls/comments/43149483","id":43149483,"diff_hunk":"@@ -182,6 +188,132 @@ def test_next_device_in_use(self):\n                                        {u\"/dev/sdf\"})\n         self.assertEqual(result, u\"/dev/sdg\")\n \n+    def test_create_volume_gold_profile(self):\n+        \"\"\"\n+        Requesting ``gold`` profile during volume creation honors\n+        ``gold`` attributes.\n+        \"\"\"\n+        self._assert_create_volume_with_mandatory_profile(\n+            MandatoryProfiles.GOLD)\n+\n+    @capture_logging(assertHasMessage, CREATE_VOLUME_FAILURE)\n+    def test_create_too_small_volume_gold_profile(self, logger):\n+        \"\"\"\n+        Too small volume for ``gold`` attributes creates volume with\n+        ``default`` profile.\n+        \"\"\"\n+        self._assert_create_volume_with_mandatory_profile(\n+            MandatoryProfiles.GOLD, created_profile=MandatoryProfiles.DEFAULT,\n+            size_GiB=1)\n+\n+    def test_create_largest_volume_gold_profile(self):\n+        \"\"\"\n+        Largest volume with ``gold`` profile.\n+        \"\"\"\n+        raise SkipTest(u'This test is expensive (money).')\n+        self._assert_create_volume_with_mandatory_profile(\n+            MandatoryProfiles.GOLD, size_GiB=16*1024)\n+\n+    def test_create_too_large_volume_gold_profile(self):\n+        \"\"\"\n+        Too large volume (> 16TiB) for ``gold`` profile.\n+        \"\"\"\n+        self.assertRaises(EC2ResponseError,\n+                          self._assert_create_volume_with_mandatory_profile,\n+                          MandatoryProfiles.GOLD,\n+                          size_GiB=1024*1024)\n+\n+    def test_create_volume_silver_profile(self):\n+        \"\"\"\n+        Requesting ``silver`` profile during volume creation honors\n+        ``silver`` attributes.\n+        \"\"\"\n+        self._assert_create_volume_with_mandatory_profile(\n+            MandatoryProfiles.SILVER)\n+\n+    def test_create_too_large_volume_silver_profile(self):\n+        \"\"\"\n+        Too large volume (> 16TiB) for ``silver`` profile.\n+        \"\"\"\n+        self.assertRaises(EC2ResponseError,\n+                          self._assert_create_volume_with_mandatory_profile,\n+                          MandatoryProfiles.SILVER,\n+                          size_GiB=1024*1024)\n+\n+    def test_create_largest_volume_silver_profile(self):\n+        \"\"\"\n+        Largest volume with ``silver`` profile.\n+        \"\"\"\n+        raise SkipTest(u'This test is expensive (money).')\n+        self._assert_create_volume_with_mandatory_profile(\n+            MandatoryProfiles.SILVER, size_GiB=16*1024)\n+\n+    def test_create_volume_bronze_profile(self):\n+        \"\"\"\n+        Requesting ``bronze`` profile during volume creation honors\n+        ``bronze`` attributes.\n+        \"\"\"\n+        self._assert_create_volume_with_mandatory_profile(\n+            MandatoryProfiles.BRONZE)\n+\n+    def test_create_too_large_volume_bronze_profile(self):\n+        \"\"\"\n+        Too large volume for ``bronze`` profile.\n+        \"\"\"\n+        self.assertRaises(EC2ResponseError,\n+                          self._assert_create_volume_with_mandatory_profile,\n+                          MandatoryProfiles.SILVER,","path":"flocker/node/agents/functional/test_ebs.py","position":107,"original_position":107,"commit_id":"4ac86e5fd8fc04a664776584574b30ca765ed867","original_commit_id":"4ac86e5fd8fc04a664776584574b30ca765ed867","user":{"login":"itamarst","id":3266662,"avatar_url":"https://avatars.githubusercontent.com/u/3266662?v=3","gravatar_id":"","url":"https://api.github.com/users/itamarst","html_url":"https://github.com/itamarst","followers_url":"https://api.github.com/users/itamarst/followers","following_url":"https://api.github.com/users/itamarst/following{/other_user}","gists_url":"https://api.github.com/users/itamarst/gists{/gist_id}","starred_url":"https://api.github.com/users/itamarst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itamarst/subscriptions","organizations_url":"https://api.github.com/users/itamarst/orgs","repos_url":"https://api.github.com/users/itamarst/repos","events_url":"https://api.github.com/users/itamarst/events{/privacy}","received_events_url":"https://api.github.com/users/itamarst/received_events","type":"User","site_admin":false},"body":"That's silver, not bronze. And again not sure this test tells us anything useful.","created_at":"2015-10-27T16:46:07Z","updated_at":"2015-10-27T16:46:07Z","html_url":"https://github.com/ClusterHQ/flocker/pull/2082#discussion_r43149483","pull_request_url":"https://api.github.com/repos/ClusterHQ/flocker/pulls/2082","_links":{"self":{"href":"https://api.github.com/repos/ClusterHQ/flocker/pulls/comments/43149483"},"html":{"href":"https://github.com/ClusterHQ/flocker/pull/2082#discussion_r43149483"},"pull_request":{"href":"https://api.github.com/repos/ClusterHQ/flocker/pulls/2082"}}},"pull_request":{"url":"https://api.github.com/repos/ClusterHQ/flocker/pulls/2082","id":48830570,"html_url":"https://github.com/ClusterHQ/flocker/pull/2082","diff_url":"https://github.com/ClusterHQ/flocker/pull/2082.diff","patch_url":"https://github.com/ClusterHQ/flocker/pull/2082.patch","issue_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/2082","number":2082,"state":"open","locked":false,"title":"[FLOC-3276] IProfiledBlockDeviceAPI implementation for EBS driver","user":{"login":"myechuri","id":12038016,"avatar_url":"https://avatars.githubusercontent.com/u/12038016?v=3","gravatar_id":"","url":"https://api.github.com/users/myechuri","html_url":"https://github.com/myechuri","followers_url":"https://api.github.com/users/myechuri/followers","following_url":"https://api.github.com/users/myechuri/following{/other_user}","gists_url":"https://api.github.com/users/myechuri/gists{/gist_id}","starred_url":"https://api.github.com/users/myechuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myechuri/subscriptions","organizations_url":"https://api.github.com/users/myechuri/orgs","repos_url":"https://api.github.com/users/myechuri/repos","events_url":"https://api.github.com/users/myechuri/events{/privacy}","received_events_url":"https://api.github.com/users/myechuri/received_events","type":"User","site_admin":false},"body":"First step in enabling Storage Profile functionality on EBS. Allow EBS Flocker driver users to create volumes with gold/silver/bronze profiles.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/clusterhq/flocker/2082)\n<!-- Reviewable:end -->\n","created_at":"2015-10-27T05:36:37Z","updated_at":"2015-10-27T16:46:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4c1e053e98e4e320ee6cb4343497793d96d26da","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ClusterHQ/flocker/pulls/2082/commits","review_comments_url":"https://api.github.com/repos/ClusterHQ/flocker/pulls/2082/comments","review_comment_url":"https://api.github.com/repos/ClusterHQ/flocker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/2082/comments","statuses_url":"https://api.github.com/repos/ClusterHQ/flocker/statuses/4ac86e5fd8fc04a664776584574b30ca765ed867","head":{"label":"ClusterHQ:FLOC-3276-ebs-profiled-driver","ref":"FLOC-3276-ebs-profiled-driver","sha":"4ac86e5fd8fc04a664776584574b30ca765ed867","user":{"login":"ClusterHQ","id":7913449,"avatar_url":"https://avatars.githubusercontent.com/u/7913449?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterHQ","html_url":"https://github.com/ClusterHQ","followers_url":"https://api.github.com/users/ClusterHQ/followers","following_url":"https://api.github.com/users/ClusterHQ/following{/other_user}","gists_url":"https://api.github.com/users/ClusterHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterHQ/subscriptions","organizations_url":"https://api.github.com/users/ClusterHQ/orgs","repos_url":"https://api.github.com/users/ClusterHQ/repos","events_url":"https://api.github.com/users/ClusterHQ/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":19248542,"name":"flocker","full_name":"ClusterHQ/flocker","owner":{"login":"ClusterHQ","id":7913449,"avatar_url":"https://avatars.githubusercontent.com/u/7913449?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterHQ","html_url":"https://github.com/ClusterHQ","followers_url":"https://api.github.com/users/ClusterHQ/followers","following_url":"https://api.github.com/users/ClusterHQ/following{/other_user}","gists_url":"https://api.github.com/users/ClusterHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterHQ/subscriptions","organizations_url":"https://api.github.com/users/ClusterHQ/orgs","repos_url":"https://api.github.com/users/ClusterHQ/repos","events_url":"https://api.github.com/users/ClusterHQ/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClusterHQ/flocker","description":"Easily manage Docker containers & their data","fork":false,"url":"https://api.github.com/repos/ClusterHQ/flocker","forks_url":"https://api.github.com/repos/ClusterHQ/flocker/forks","keys_url":"https://api.github.com/repos/ClusterHQ/flocker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClusterHQ/flocker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClusterHQ/flocker/teams","hooks_url":"https://api.github.com/repos/ClusterHQ/flocker/hooks","issue_events_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/events{/number}","events_url":"https://api.github.com/repos/ClusterHQ/flocker/events","assignees_url":"https://api.github.com/repos/ClusterHQ/flocker/assignees{/user}","branches_url":"https://api.github.com/repos/ClusterHQ/flocker/branches{/branch}","tags_url":"https://api.github.com/repos/ClusterHQ/flocker/tags","blobs_url":"https://api.github.com/repos/ClusterHQ/flocker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClusterHQ/flocker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClusterHQ/flocker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClusterHQ/flocker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClusterHQ/flocker/statuses/{sha}","languages_url":"https://api.github.com/repos/ClusterHQ/flocker/languages","stargazers_url":"https://api.github.com/repos/ClusterHQ/flocker/stargazers","contributors_url":"https://api.github.com/repos/ClusterHQ/flocker/contributors","subscribers_url":"https://api.github.com/repos/ClusterHQ/flocker/subscribers","subscription_url":"https://api.github.com/repos/ClusterHQ/flocker/subscription","commits_url":"https://api.github.com/repos/ClusterHQ/flocker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClusterHQ/flocker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClusterHQ/flocker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ClusterHQ/flocker/contents/{+path}","compare_url":"https://api.github.com/repos/ClusterHQ/flocker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClusterHQ/flocker/merges","archive_url":"https://api.github.com/repos/ClusterHQ/flocker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClusterHQ/flocker/downloads","issues_url":"https://api.github.com/repos/ClusterHQ/flocker/issues{/number}","pulls_url":"https://api.github.com/repos/ClusterHQ/flocker/pulls{/number}","milestones_url":"https://api.github.com/repos/ClusterHQ/flocker/milestones{/number}","notifications_url":"https://api.github.com/repos/ClusterHQ/flocker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClusterHQ/flocker/labels{/name}","releases_url":"https://api.github.com/repos/ClusterHQ/flocker/releases{/id}","created_at":"2014-04-28T18:02:14Z","updated_at":"2015-10-27T09:29:37Z","pushed_at":"2015-10-27T16:37:09Z","git_url":"git://github.com/ClusterHQ/flocker.git","ssh_url":"git@github.com:ClusterHQ/flocker.git","clone_url":"https://github.com/ClusterHQ/flocker.git","svn_url":"https://github.com/ClusterHQ/flocker","homepage":"https://clusterhq.com","size":69836,"stargazers_count":1905,"watchers_count":1905,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":140,"mirror_url":null,"open_issues_count":37,"forks":140,"open_issues":37,"watchers":1905,"default_branch":"master"}},"base":{"label":"ClusterHQ:master","ref":"master","sha":"58362ba476a01bcf51bfdb0b49b84580476228c0","user":{"login":"ClusterHQ","id":7913449,"avatar_url":"https://avatars.githubusercontent.com/u/7913449?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterHQ","html_url":"https://github.com/ClusterHQ","followers_url":"https://api.github.com/users/ClusterHQ/followers","following_url":"https://api.github.com/users/ClusterHQ/following{/other_user}","gists_url":"https://api.github.com/users/ClusterHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterHQ/subscriptions","organizations_url":"https://api.github.com/users/ClusterHQ/orgs","repos_url":"https://api.github.com/users/ClusterHQ/repos","events_url":"https://api.github.com/users/ClusterHQ/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":19248542,"name":"flocker","full_name":"ClusterHQ/flocker","owner":{"login":"ClusterHQ","id":7913449,"avatar_url":"https://avatars.githubusercontent.com/u/7913449?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterHQ","html_url":"https://github.com/ClusterHQ","followers_url":"https://api.github.com/users/ClusterHQ/followers","following_url":"https://api.github.com/users/ClusterHQ/following{/other_user}","gists_url":"https://api.github.com/users/ClusterHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterHQ/subscriptions","organizations_url":"https://api.github.com/users/ClusterHQ/orgs","repos_url":"https://api.github.com/users/ClusterHQ/repos","events_url":"https://api.github.com/users/ClusterHQ/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClusterHQ/flocker","description":"Easily manage Docker containers & their data","fork":false,"url":"https://api.github.com/repos/ClusterHQ/flocker","forks_url":"https://api.github.com/repos/ClusterHQ/flocker/forks","keys_url":"https://api.github.com/repos/ClusterHQ/flocker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClusterHQ/flocker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClusterHQ/flocker/teams","hooks_url":"https://api.github.com/repos/ClusterHQ/flocker/hooks","issue_events_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/events{/number}","events_url":"https://api.github.com/repos/ClusterHQ/flocker/events","assignees_url":"https://api.github.com/repos/ClusterHQ/flocker/assignees{/user}","branches_url":"https://api.github.com/repos/ClusterHQ/flocker/branches{/branch}","tags_url":"https://api.github.com/repos/ClusterHQ/flocker/tags","blobs_url":"https://api.github.com/repos/ClusterHQ/flocker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClusterHQ/flocker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClusterHQ/flocker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClusterHQ/flocker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClusterHQ/flocker/statuses/{sha}","languages_url":"https://api.github.com/repos/ClusterHQ/flocker/languages","stargazers_url":"https://api.github.com/repos/ClusterHQ/flocker/stargazers","contributors_url":"https://api.github.com/repos/ClusterHQ/flocker/contributors","subscribers_url":"https://api.github.com/repos/ClusterHQ/flocker/subscribers","subscription_url":"https://api.github.com/repos/ClusterHQ/flocker/subscription","commits_url":"https://api.github.com/repos/ClusterHQ/flocker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClusterHQ/flocker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClusterHQ/flocker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClusterHQ/flocker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ClusterHQ/flocker/contents/{+path}","compare_url":"https://api.github.com/repos/ClusterHQ/flocker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClusterHQ/flocker/merges","archive_url":"https://api.github.com/repos/ClusterHQ/flocker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClusterHQ/flocker/downloads","issues_url":"https://api.github.com/repos/ClusterHQ/flocker/issues{/number}","pulls_url":"https://api.github.com/repos/ClusterHQ/flocker/pulls{/number}","milestones_url":"https://api.github.com/repos/ClusterHQ/flocker/milestones{/number}","notifications_url":"https://api.github.com/repos/ClusterHQ/flocker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClusterHQ/flocker/labels{/name}","releases_url":"https://api.github.com/repos/ClusterHQ/flocker/releases{/id}","created_at":"2014-04-28T18:02:14Z","updated_at":"2015-10-27T09:29:37Z","pushed_at":"2015-10-27T16:37:09Z","git_url":"git://github.com/ClusterHQ/flocker.git","ssh_url":"git@github.com:ClusterHQ/flocker.git","clone_url":"https://github.com/ClusterHQ/flocker.git","svn_url":"https://github.com/ClusterHQ/flocker","homepage":"https://clusterhq.com","size":69836,"stargazers_count":1905,"watchers_count":1905,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":140,"mirror_url":null,"open_issues_count":37,"forks":140,"open_issues":37,"watchers":1905,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ClusterHQ/flocker/pulls/2082"},"html":{"href":"https://github.com/ClusterHQ/flocker/pull/2082"},"issue":{"href":"https://api.github.com/repos/ClusterHQ/flocker/issues/2082"},"comments":{"href":"https://api.github.com/repos/ClusterHQ/flocker/issues/2082/comments"},"review_comments":{"href":"https://api.github.com/repos/ClusterHQ/flocker/pulls/2082/comments"},"review_comment":{"href":"https://api.github.com/repos/ClusterHQ/flocker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ClusterHQ/flocker/pulls/2082/commits"},"statuses":{"href":"https://api.github.com/repos/ClusterHQ/flocker/statuses/4ac86e5fd8fc04a664776584574b30ca765ed867"}}}}