{"action":"created","comment":{"url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/pulls/comments/24146110","id":24146110,"diff_hunk":"@@ -122,6 +129,20 @@ def decrypt(self, message, session):\n         else:\n             return message\n \n+    def notifyOfNewNode(self, node, session_id):\n+        \"\"\"\n+        Notifies this daemon about a newly-registered node.\n+\n+        Args:\n+            node: metadata about the new node.\n+            session_id (str): the ID of the session the new node is involved in.\n+        \"\"\"\n+\n+        if hasattr(node, 'id'):\n+            # Let's use this opportunity to update the associated session with the new NID\n+            self.sessions[session_id].updateNodeId(node.id)\n+\n+","path":"lib/JumpScale/grid/serverbase/Daemon.py","position":35,"original_position":35,"commit_id":"c271ec7b03e58931ef93bb3918c7d69519799098","original_commit_id":"c271ec7b03e58931ef93bb3918c7d69519799098","user":{"login":"grimpy","id":143869,"avatar_url":"https://avatars.githubusercontent.com/u/143869?v=3","gravatar_id":"","url":"https://api.github.com/users/grimpy","html_url":"https://github.com/grimpy","followers_url":"https://api.github.com/users/grimpy/followers","following_url":"https://api.github.com/users/grimpy/following{/other_user}","gists_url":"https://api.github.com/users/grimpy/gists{/gist_id}","starred_url":"https://api.github.com/users/grimpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimpy/subscriptions","organizations_url":"https://api.github.com/users/grimpy/orgs","repos_url":"https://api.github.com/users/grimpy/repos","events_url":"https://api.github.com/users/grimpy/events{/privacy}","received_events_url":"https://api.github.com/users/grimpy/received_events","type":"User","site_admin":false},"body":"remove a whitespace here","created_at":"2015-02-05T06:53:22Z","updated_at":"2015-02-05T06:53:22Z","html_url":"https://github.com/Jumpscale/jumpscale_core7/pull/19#discussion_r24146110","pull_request_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/Jumpscale/jumpscale_core7/pulls/comments/24146110"},"html":{"href":"https://github.com/Jumpscale/jumpscale_core7/pull/19#discussion_r24146110"},"pull_request":{"href":"https://api.github.com/repos/Jumpscale/jumpscale_core7/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/pulls/19","id":28648267,"html_url":"https://github.com/Jumpscale/jumpscale_core7/pull/19","diff_url":"https://github.com/Jumpscale/jumpscale_core7/pull/19.diff","patch_url":"https://github.com/Jumpscale/jumpscale_core7/pull/19.patch","issue_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/issues/19","number":19,"state":"open","locked":false,"title":"ControllerCMDS.registerNode() now correctly updates the Daemon's Session object with the newly-assigned Node ID","user":{"login":"amrhassan","id":130985,"avatar_url":"https://avatars.githubusercontent.com/u/130985?v=3","gravatar_id":"","url":"https://api.github.com/users/amrhassan","html_url":"https://github.com/amrhassan","followers_url":"https://api.github.com/users/amrhassan/followers","following_url":"https://api.github.com/users/amrhassan/following{/other_user}","gists_url":"https://api.github.com/users/amrhassan/gists{/gist_id}","starred_url":"https://api.github.com/users/amrhassan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrhassan/subscriptions","organizations_url":"https://api.github.com/users/amrhassan/orgs","repos_url":"https://api.github.com/users/amrhassan/repos","events_url":"https://api.github.com/users/amrhassan/events{/privacy}","received_events_url":"https://api.github.com/users/amrhassan/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-02-04T15:44:52Z","updated_at":"2015-02-05T06:53:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72da802d2a34004ff201ebfd1e31c1f295bc78ac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/pulls/19/commits","review_comments_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/pulls/19/comments","review_comment_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/issues/19/comments","statuses_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/statuses/c271ec7b03e58931ef93bb3918c7d69519799098","head":{"label":"amrhassan:master","ref":"master","sha":"c271ec7b03e58931ef93bb3918c7d69519799098","user":{"login":"amrhassan","id":130985,"avatar_url":"https://avatars.githubusercontent.com/u/130985?v=3","gravatar_id":"","url":"https://api.github.com/users/amrhassan","html_url":"https://github.com/amrhassan","followers_url":"https://api.github.com/users/amrhassan/followers","following_url":"https://api.github.com/users/amrhassan/following{/other_user}","gists_url":"https://api.github.com/users/amrhassan/gists{/gist_id}","starred_url":"https://api.github.com/users/amrhassan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrhassan/subscriptions","organizations_url":"https://api.github.com/users/amrhassan/orgs","repos_url":"https://api.github.com/users/amrhassan/repos","events_url":"https://api.github.com/users/amrhassan/events{/privacy}","received_events_url":"https://api.github.com/users/amrhassan/received_events","type":"User","site_admin":false},"repo":{"id":30241837,"name":"jumpscale_core7","full_name":"amrhassan/jumpscale_core7","owner":{"login":"amrhassan","id":130985,"avatar_url":"https://avatars.githubusercontent.com/u/130985?v=3","gravatar_id":"","url":"https://api.github.com/users/amrhassan","html_url":"https://github.com/amrhassan","followers_url":"https://api.github.com/users/amrhassan/followers","following_url":"https://api.github.com/users/amrhassan/following{/other_user}","gists_url":"https://api.github.com/users/amrhassan/gists{/gist_id}","starred_url":"https://api.github.com/users/amrhassan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrhassan/subscriptions","organizations_url":"https://api.github.com/users/amrhassan/orgs","repos_url":"https://api.github.com/users/amrhassan/repos","events_url":"https://api.github.com/users/amrhassan/events{/privacy}","received_events_url":"https://api.github.com/users/amrhassan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amrhassan/jumpscale_core7","description":"new version of jumpscale","fork":true,"url":"https://api.github.com/repos/amrhassan/jumpscale_core7","forks_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/forks","keys_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/teams","hooks_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/hooks","issue_events_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/issues/events{/number}","events_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/events","assignees_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/assignees{/user}","branches_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/branches{/branch}","tags_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/tags","blobs_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/git/refs{/sha}","trees_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/statuses/{sha}","languages_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/languages","stargazers_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/stargazers","contributors_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/contributors","subscribers_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/subscribers","subscription_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/subscription","commits_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/commits{/sha}","git_commits_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/git/commits{/sha}","comments_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/comments{/number}","issue_comment_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/issues/comments/{number}","contents_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/contents/{+path}","compare_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/merges","archive_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/downloads","issues_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/issues{/number}","pulls_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/pulls{/number}","milestones_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/milestones{/number}","notifications_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/labels{/name}","releases_url":"https://api.github.com/repos/amrhassan/jumpscale_core7/releases{/id}","created_at":"2015-02-03T12:35:55Z","updated_at":"2015-02-05T06:50:35Z","pushed_at":"2015-02-05T06:50:33Z","git_url":"git://github.com/amrhassan/jumpscale_core7.git","ssh_url":"git@github.com:amrhassan/jumpscale_core7.git","clone_url":"https://github.com/amrhassan/jumpscale_core7.git","svn_url":"https://github.com/amrhassan/jumpscale_core7","homepage":null,"size":6677,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Jumpscale:master","ref":"master","sha":"ba6180babc5cd58074e883ada785ee7997112c4c","user":{"login":"Jumpscale","id":8423908,"avatar_url":"https://avatars.githubusercontent.com/u/8423908?v=3","gravatar_id":"","url":"https://api.github.com/users/Jumpscale","html_url":"https://github.com/Jumpscale","followers_url":"https://api.github.com/users/Jumpscale/followers","following_url":"https://api.github.com/users/Jumpscale/following{/other_user}","gists_url":"https://api.github.com/users/Jumpscale/gists{/gist_id}","starred_url":"https://api.github.com/users/Jumpscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jumpscale/subscriptions","organizations_url":"https://api.github.com/users/Jumpscale/orgs","repos_url":"https://api.github.com/users/Jumpscale/repos","events_url":"https://api.github.com/users/Jumpscale/events{/privacy}","received_events_url":"https://api.github.com/users/Jumpscale/received_events","type":"Organization","site_admin":false},"repo":{"id":26467698,"name":"jumpscale_core7","full_name":"Jumpscale/jumpscale_core7","owner":{"login":"Jumpscale","id":8423908,"avatar_url":"https://avatars.githubusercontent.com/u/8423908?v=3","gravatar_id":"","url":"https://api.github.com/users/Jumpscale","html_url":"https://github.com/Jumpscale","followers_url":"https://api.github.com/users/Jumpscale/followers","following_url":"https://api.github.com/users/Jumpscale/following{/other_user}","gists_url":"https://api.github.com/users/Jumpscale/gists{/gist_id}","starred_url":"https://api.github.com/users/Jumpscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jumpscale/subscriptions","organizations_url":"https://api.github.com/users/Jumpscale/orgs","repos_url":"https://api.github.com/users/Jumpscale/repos","events_url":"https://api.github.com/users/Jumpscale/events{/privacy}","received_events_url":"https://api.github.com/users/Jumpscale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Jumpscale/jumpscale_core7","description":"new version of jumpscale","fork":false,"url":"https://api.github.com/repos/Jumpscale/jumpscale_core7","forks_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/forks","keys_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/teams","hooks_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/hooks","issue_events_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/issues/events{/number}","events_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/events","assignees_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/assignees{/user}","branches_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/branches{/branch}","tags_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/tags","blobs_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/statuses/{sha}","languages_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/languages","stargazers_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/stargazers","contributors_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/contributors","subscribers_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/subscribers","subscription_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/subscription","commits_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/issues/comments/{number}","contents_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/contents/{+path}","compare_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/merges","archive_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/downloads","issues_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/issues{/number}","pulls_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/pulls{/number}","milestones_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/milestones{/number}","notifications_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/labels{/name}","releases_url":"https://api.github.com/repos/Jumpscale/jumpscale_core7/releases{/id}","created_at":"2014-11-11T03:27:11Z","updated_at":"2015-02-04T15:57:17Z","pushed_at":"2015-02-04T15:57:16Z","git_url":"git://github.com/Jumpscale/jumpscale_core7.git","ssh_url":"git@github.com:Jumpscale/jumpscale_core7.git","clone_url":"https://github.com/Jumpscale/jumpscale_core7.git","svn_url":"https://github.com/Jumpscale/jumpscale_core7","homepage":null,"size":6677,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Jumpscale/jumpscale_core7/pulls/19"},"html":{"href":"https://github.com/Jumpscale/jumpscale_core7/pull/19"},"issue":{"href":"https://api.github.com/repos/Jumpscale/jumpscale_core7/issues/19"},"comments":{"href":"https://api.github.com/repos/Jumpscale/jumpscale_core7/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/Jumpscale/jumpscale_core7/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/Jumpscale/jumpscale_core7/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Jumpscale/jumpscale_core7/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/Jumpscale/jumpscale_core7/statuses/c271ec7b03e58931ef93bb3918c7d69519799098"}}}}