{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/29905011","id":29905011,"diff_hunk":"@@ -306,11 +320,35 @@ struct Regs {\n     TevStageConfig tev_stage2;\n     INSERT_PADDING_WORDS(0x3);\n     TevStageConfig tev_stage3;\n-    INSERT_PADDING_WORDS(0x13);\n+    INSERT_PADDING_WORDS(0x3);\n+\n+    union {\n+        // Tev stages 0-3 write their output to the combiner buffer if the corresponding bit in\n+        // these masks are set\n+        BitField< 8, 4, u32> update_mask_rgb;\n+        BitField<12, 4, u32> update_mask_a;\n+\n+        bool UpdateCombinerBufferColor(unsigned stage_index) const {\n+            return (stage_index < 4) && (update_mask_rgb & (1 << stage_index));\n+        }","path":"src/video_core/pica.h","position":47,"original_position":47,"commit_id":"523a697f0ab3fb736d27831a5fa0bde293b6e738","original_commit_id":"523a697f0ab3fb736d27831a5fa0bde293b6e738","user":{"login":"Subv","id":357072,"avatar_url":"https://avatars.githubusercontent.com/u/357072?v=3","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"body":"Can you add a line between these two functions?","created_at":"2015-05-07T23:09:06Z","updated_at":"2015-05-07T23:09:06Z","html_url":"https://github.com/citra-emu/citra/pull/726#discussion_r29905011","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/726","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/29905011"},"html":{"href":"https://github.com/citra-emu/citra/pull/726#discussion_r29905011"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/726"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/726","id":34965958,"html_url":"https://github.com/citra-emu/citra/pull/726","diff_url":"https://github.com/citra-emu/citra/pull/726.diff","patch_url":"https://github.com/citra-emu/citra/pull/726.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/726","number":726,"state":"open","locked":false,"title":"Gpu improvements","user":{"login":"bunnei","id":6956688,"avatar_url":"https://avatars.githubusercontent.com/u/6956688?v=3","gravatar_id":"","url":"https://api.github.com/users/bunnei","html_url":"https://github.com/bunnei","followers_url":"https://api.github.com/users/bunnei/followers","following_url":"https://api.github.com/users/bunnei/following{/other_user}","gists_url":"https://api.github.com/users/bunnei/gists{/gist_id}","starred_url":"https://api.github.com/users/bunnei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bunnei/subscriptions","organizations_url":"https://api.github.com/users/bunnei/orgs","repos_url":"https://api.github.com/users/bunnei/repos","events_url":"https://api.github.com/users/bunnei/events{/privacy}","received_events_url":"https://api.github.com/users/bunnei/received_events","type":"User","site_admin":false},"body":"This is a bunch of small GPU emulation fixes/improvements initially started to fix Steel Diver. Commits are all separate and should probably be individually reviewed. Summary:\r\n* Added MADI and FLR vertex shader instructions\r\n* Added combiner buffer (i.e. \"previous combiner buffer\" color source)\r\n* Added \"AddSigned\" combiner operation\r\n* Added combiner output scaling\r\n* Fixed a bug with depth testing (via @Subv)\r\n* Fixed a bug with invalid vectors being returned for unimplemented features","created_at":"2015-05-07T22:43:30Z","updated_at":"2015-05-07T23:09:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7929f722a0c610abebbc4915be2f1d5afda56a84","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/726/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/726/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/726/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/523a697f0ab3fb736d27831a5fa0bde293b6e738","head":{"label":"bunnei:gpu-improvements","ref":"gpu-improvements","sha":"523a697f0ab3fb736d27831a5fa0bde293b6e738","user":{"login":"bunnei","id":6956688,"avatar_url":"https://avatars.githubusercontent.com/u/6956688?v=3","gravatar_id":"","url":"https://api.github.com/users/bunnei","html_url":"https://github.com/bunnei","followers_url":"https://api.github.com/users/bunnei/followers","following_url":"https://api.github.com/users/bunnei/following{/other_user}","gists_url":"https://api.github.com/users/bunnei/gists{/gist_id}","starred_url":"https://api.github.com/users/bunnei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bunnei/subscriptions","organizations_url":"https://api.github.com/users/bunnei/orgs","repos_url":"https://api.github.com/users/bunnei/repos","events_url":"https://api.github.com/users/bunnei/events{/privacy}","received_events_url":"https://api.github.com/users/bunnei/received_events","type":"User","site_admin":false},"repo":{"id":19964905,"name":"citra","full_name":"bunnei/citra","owner":{"login":"bunnei","id":6956688,"avatar_url":"https://avatars.githubusercontent.com/u/6956688?v=3","gravatar_id":"","url":"https://api.github.com/users/bunnei","html_url":"https://github.com/bunnei","followers_url":"https://api.github.com/users/bunnei/followers","following_url":"https://api.github.com/users/bunnei/following{/other_user}","gists_url":"https://api.github.com/users/bunnei/gists{/gist_id}","starred_url":"https://api.github.com/users/bunnei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bunnei/subscriptions","organizations_url":"https://api.github.com/users/bunnei/orgs","repos_url":"https://api.github.com/users/bunnei/repos","events_url":"https://api.github.com/users/bunnei/events{/privacy}","received_events_url":"https://api.github.com/users/bunnei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bunnei/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/bunnei/citra","forks_url":"https://api.github.com/repos/bunnei/citra/forks","keys_url":"https://api.github.com/repos/bunnei/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bunnei/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bunnei/citra/teams","hooks_url":"https://api.github.com/repos/bunnei/citra/hooks","issue_events_url":"https://api.github.com/repos/bunnei/citra/issues/events{/number}","events_url":"https://api.github.com/repos/bunnei/citra/events","assignees_url":"https://api.github.com/repos/bunnei/citra/assignees{/user}","branches_url":"https://api.github.com/repos/bunnei/citra/branches{/branch}","tags_url":"https://api.github.com/repos/bunnei/citra/tags","blobs_url":"https://api.github.com/repos/bunnei/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bunnei/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bunnei/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/bunnei/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bunnei/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/bunnei/citra/languages","stargazers_url":"https://api.github.com/repos/bunnei/citra/stargazers","contributors_url":"https://api.github.com/repos/bunnei/citra/contributors","subscribers_url":"https://api.github.com/repos/bunnei/citra/subscribers","subscription_url":"https://api.github.com/repos/bunnei/citra/subscription","commits_url":"https://api.github.com/repos/bunnei/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/bunnei/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/bunnei/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/bunnei/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/bunnei/citra/contents/{+path}","compare_url":"https://api.github.com/repos/bunnei/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bunnei/citra/merges","archive_url":"https://api.github.com/repos/bunnei/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bunnei/citra/downloads","issues_url":"https://api.github.com/repos/bunnei/citra/issues{/number}","pulls_url":"https://api.github.com/repos/bunnei/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/bunnei/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/bunnei/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bunnei/citra/labels{/name}","releases_url":"https://api.github.com/repos/bunnei/citra/releases{/id}","created_at":"2014-05-20T02:28:14Z","updated_at":"2015-03-20T17:20:59Z","pushed_at":"2015-05-07T22:38:30Z","git_url":"git://github.com/bunnei/citra.git","ssh_url":"git@github.com:bunnei/citra.git","clone_url":"https://github.com/bunnei/citra.git","svn_url":"https://github.com/bunnei/citra","homepage":null,"size":9687,"stargazers_count":49,"watchers_count":49,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":0,"forks":12,"open_issues":0,"watchers":49,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"52654842a0fa9b4e17d5f3ed283d6a16f1f8ca2b","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","created_at":"2014-05-16T18:33:15Z","updated_at":"2015-05-07T22:55:18Z","pushed_at":"2015-05-07T22:55:18Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":22065,"stargazers_count":791,"watchers_count":791,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":201,"mirror_url":null,"open_issues_count":45,"forks":201,"open_issues":45,"watchers":791,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/726"},"html":{"href":"https://github.com/citra-emu/citra/pull/726"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/726"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/726/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/726/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/726/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/523a697f0ab3fb736d27831a5fa0bde293b6e738"}}}}