{"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/36236215","id":36236215,"diff_hunk":"@@ -139,8 +139,11 @@ namespace Algorithms\n     /**\n      * Set size of the first step. This may be overwritten by the time\n      * stepping strategy.\n+     *\n+     * @param[in] step The size of the first step, which may be overwritten by\n+     *   the time stepping strategy.\n      */\n-    void start_step (double);\n+    void start_step (double step);","path":"include/deal.II/algorithms/timestep_control.h","position":9,"original_position":9,"commit_id":"64767e826732a3ff04562ab272a44cfe2c34787f","original_commit_id":"64767e826732a3ff04562ab272a44cfe2c34787f","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"Yes, nice. Can I ask you for a small addition? In general, we mark all input arguments as `const` (here that makes no difference to the compiler, but it makes a difference to the human reader: a `const` argument must clearly be an input argument). Would you be willing to add the `const` before the `double`?","created_at":"2015-08-04T20:19:37Z","updated_at":"2015-08-04T20:19:37Z","html_url":"https://github.com/dealii/dealii/pull/1257#discussion_r36236215","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/1257","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/36236215"},"html":{"href":"https://github.com/dealii/dealii/pull/1257#discussion_r36236215"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/1257"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/1257","id":41611948,"html_url":"https://github.com/dealii/dealii/pull/1257","diff_url":"https://github.com/dealii/dealii/pull/1257.diff","patch_url":"https://github.com/dealii/dealii/pull/1257.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/1257","number":1257,"state":"open","locked":false,"title":"workshop pull request practice","user":{"login":"jhansel","id":4698392,"avatar_url":"https://avatars.githubusercontent.com/u/4698392?v=3","gravatar_id":"","url":"https://api.github.com/users/jhansel","html_url":"https://github.com/jhansel","followers_url":"https://api.github.com/users/jhansel/followers","following_url":"https://api.github.com/users/jhansel/following{/other_user}","gists_url":"https://api.github.com/users/jhansel/gists{/gist_id}","starred_url":"https://api.github.com/users/jhansel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhansel/subscriptions","organizations_url":"https://api.github.com/users/jhansel/orgs","repos_url":"https://api.github.com/users/jhansel/repos","events_url":"https://api.github.com/users/jhansel/events{/privacy}","received_events_url":"https://api.github.com/users/jhansel/received_events","type":"User","site_admin":false},"body":"Added input file description for start_step() of TimeStepControl for the purpose of practice.","created_at":"2015-08-04T20:12:23Z","updated_at":"2015-08-04T20:19:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6bb4ee2e6ce30ea148b4385639bd52b20c575ae7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/1257/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/1257/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/1257/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/64767e826732a3ff04562ab272a44cfe2c34787f","head":{"label":"jhansel:workshop_practice","ref":"workshop_practice","sha":"64767e826732a3ff04562ab272a44cfe2c34787f","user":{"login":"jhansel","id":4698392,"avatar_url":"https://avatars.githubusercontent.com/u/4698392?v=3","gravatar_id":"","url":"https://api.github.com/users/jhansel","html_url":"https://github.com/jhansel","followers_url":"https://api.github.com/users/jhansel/followers","following_url":"https://api.github.com/users/jhansel/following{/other_user}","gists_url":"https://api.github.com/users/jhansel/gists{/gist_id}","starred_url":"https://api.github.com/users/jhansel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhansel/subscriptions","organizations_url":"https://api.github.com/users/jhansel/orgs","repos_url":"https://api.github.com/users/jhansel/repos","events_url":"https://api.github.com/users/jhansel/events{/privacy}","received_events_url":"https://api.github.com/users/jhansel/received_events","type":"User","site_admin":false},"repo":{"id":40150258,"name":"dealii","full_name":"jhansel/dealii","owner":{"login":"jhansel","id":4698392,"avatar_url":"https://avatars.githubusercontent.com/u/4698392?v=3","gravatar_id":"","url":"https://api.github.com/users/jhansel","html_url":"https://github.com/jhansel","followers_url":"https://api.github.com/users/jhansel/followers","following_url":"https://api.github.com/users/jhansel/following{/other_user}","gists_url":"https://api.github.com/users/jhansel/gists{/gist_id}","starred_url":"https://api.github.com/users/jhansel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhansel/subscriptions","organizations_url":"https://api.github.com/users/jhansel/orgs","repos_url":"https://api.github.com/users/jhansel/repos","events_url":"https://api.github.com/users/jhansel/events{/privacy}","received_events_url":"https://api.github.com/users/jhansel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhansel/dealii","description":"The development repository for the deal.II finite element library.","fork":true,"url":"https://api.github.com/repos/jhansel/dealii","forks_url":"https://api.github.com/repos/jhansel/dealii/forks","keys_url":"https://api.github.com/repos/jhansel/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhansel/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhansel/dealii/teams","hooks_url":"https://api.github.com/repos/jhansel/dealii/hooks","issue_events_url":"https://api.github.com/repos/jhansel/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/jhansel/dealii/events","assignees_url":"https://api.github.com/repos/jhansel/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/jhansel/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/jhansel/dealii/tags","blobs_url":"https://api.github.com/repos/jhansel/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhansel/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhansel/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhansel/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhansel/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/jhansel/dealii/languages","stargazers_url":"https://api.github.com/repos/jhansel/dealii/stargazers","contributors_url":"https://api.github.com/repos/jhansel/dealii/contributors","subscribers_url":"https://api.github.com/repos/jhansel/dealii/subscribers","subscription_url":"https://api.github.com/repos/jhansel/dealii/subscription","commits_url":"https://api.github.com/repos/jhansel/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhansel/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhansel/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhansel/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhansel/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/jhansel/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhansel/dealii/merges","archive_url":"https://api.github.com/repos/jhansel/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhansel/dealii/downloads","issues_url":"https://api.github.com/repos/jhansel/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/jhansel/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/jhansel/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/jhansel/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhansel/dealii/labels{/name}","releases_url":"https://api.github.com/repos/jhansel/dealii/releases{/id}","created_at":"2015-08-03T22:06:05Z","updated_at":"2015-08-03T22:07:11Z","pushed_at":"2015-08-04T20:08:44Z","git_url":"git://github.com/jhansel/dealii.git","ssh_url":"git@github.com:jhansel/dealii.git","clone_url":"https://github.com/jhansel/dealii.git","svn_url":"https://github.com/jhansel/dealii","homepage":"http://www.dealii.org/","size":119750,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"217fb294d16ed493aaa593b4f8cd3932ab796f2f","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","created_at":"2014-07-17T14:00:26Z","updated_at":"2015-08-02T14:37:55Z","pushed_at":"2015-08-04T20:18:32Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":154630,"stargazers_count":75,"watchers_count":75,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":105,"forks":110,"open_issues":105,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/1257"},"html":{"href":"https://github.com/dealii/dealii/pull/1257"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/1257"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/1257/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/1257/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/1257/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/64767e826732a3ff04562ab272a44cfe2c34787f"}}}}