{"action":"created","issue":{"url":"https://api.github.com/repos/open-keychain/spongycastle/issues/5","labels_url":"https://api.github.com/repos/open-keychain/spongycastle/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/open-keychain/spongycastle/issues/5/comments","events_url":"https://api.github.com/repos/open-keychain/spongycastle/issues/5/events","html_url":"https://github.com/open-keychain/spongycastle/pull/5","id":106662977,"number":5,"title":"Skip invalid signatures","user":{"login":"adithyaphilip","id":5712241,"avatar_url":"https://avatars.githubusercontent.com/u/5712241?v=3","gravatar_id":"","url":"https://api.github.com/users/adithyaphilip","html_url":"https://github.com/adithyaphilip","followers_url":"https://api.github.com/users/adithyaphilip/followers","following_url":"https://api.github.com/users/adithyaphilip/following{/other_user}","gists_url":"https://api.github.com/users/adithyaphilip/gists{/gist_id}","starred_url":"https://api.github.com/users/adithyaphilip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adithyaphilip/subscriptions","organizations_url":"https://api.github.com/users/adithyaphilip/orgs","repos_url":"https://api.github.com/users/adithyaphilip/repos","events_url":"https://api.github.com/users/adithyaphilip/events{/privacy}","received_events_url":"https://api.github.com/users/adithyaphilip/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-09-15T22:44:02Z","updated_at":"2015-10-01T18:06:09Z","closed_at":"2015-10-01T13:27:46Z","pull_request":{"url":"https://api.github.com/repos/open-keychain/spongycastle/pulls/5","html_url":"https://github.com/open-keychain/spongycastle/pull/5","diff_url":"https://github.com/open-keychain/spongycastle/pull/5.diff","patch_url":"https://github.com/open-keychain/spongycastle/pull/5.patch"},"body":"Fixes https://github.com/open-keychain/open-keychain/issues/1531. This should let us skip signatures with invalid signature data, but in a well-formed packet. Skipping malformed packets would require changes to https://github.com/open-keychain/spongycastle/blob/openkeychain-master/pg/src/main/java/org/spongycastle/bcpg/BCPGInputStream.java#L143, though I'm not sure how we'd skip to the end of that packet (if even the body length is wrong). Would a keyserver allow malformed packets to be added to a key?"},"comment":{"url":"https://api.github.com/repos/open-keychain/spongycastle/issues/comments/144803123","html_url":"https://github.com/open-keychain/spongycastle/pull/5#issuecomment-144803123","issue_url":"https://api.github.com/repos/open-keychain/spongycastle/issues/5","id":144803123,"user":{"login":"Valodim","id":27813,"avatar_url":"https://avatars.githubusercontent.com/u/27813?v=3","gravatar_id":"","url":"https://api.github.com/users/Valodim","html_url":"https://github.com/Valodim","followers_url":"https://api.github.com/users/Valodim/followers","following_url":"https://api.github.com/users/Valodim/following{/other_user}","gists_url":"https://api.github.com/users/Valodim/gists{/gist_id}","starred_url":"https://api.github.com/users/Valodim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valodim/subscriptions","organizations_url":"https://api.github.com/users/Valodim/orgs","repos_url":"https://api.github.com/users/Valodim/repos","events_url":"https://api.github.com/users/Valodim/events{/privacy}","received_events_url":"https://api.github.com/users/Valodim/received_events","type":"User","site_admin":false},"created_at":"2015-10-01T18:06:09Z","updated_at":"2015-10-01T18:06:09Z","body":"I thought about that, and in the end I felt I wasn't very sure about it so I thought it better we stick with the conservative way. it's also questionable whether we need a lot of resilience in the parser to begin with - key files with broken files aren't exactly a common scenario"}}