{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/Caching/issues/135","labels_url":"https://api.github.com/repos/aspnet/Caching/issues/135/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/Caching/issues/135/comments","events_url":"https://api.github.com/repos/aspnet/Caching/issues/135/events","html_url":"https://github.com/aspnet/Caching/issues/135","id":124139860,"number":135,"title":"Remove Connect and ConnectAsync methods from IDistributedCache interface","user":{"login":"kichalla","id":6559784,"avatar_url":"https://avatars.githubusercontent.com/u/6559784?v=3","gravatar_id":"","url":"https://api.github.com/users/kichalla","html_url":"https://github.com/kichalla","followers_url":"https://api.github.com/users/kichalla/followers","following_url":"https://api.github.com/users/kichalla/following{/other_user}","gists_url":"https://api.github.com/users/kichalla/gists{/gist_id}","starred_url":"https://api.github.com/users/kichalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kichalla/subscriptions","organizations_url":"https://api.github.com/users/kichalla/orgs","repos_url":"https://api.github.com/users/kichalla/repos","events_url":"https://api.github.com/users/kichalla/events{/privacy}","received_events_url":"https://api.github.com/users/kichalla/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-12-28T23:17:19Z","updated_at":"2015-12-28T23:19:12Z","closed_at":null,"body":"@lodejard brought up a good point of the need of having a Connect method on the interface. They seem to be implementation details for the particular distributed cache implementation (ex: RedisCache). SqlServerCache and LocalCache(distributed MemoryCache) do not require them.\r\n\r\nhttps://github.com/aspnet/Caching/blob/dev/src/Microsoft.Extensions.Caching.Abstractions/IDistributedCache.cs#L10-L12\r\n\r\ncc @Tratcher @muratg @Eilon @davidfowl \r\n\r\nAnd regarding related issue https://github.com/aspnet/Caching/issues/131, RedisCache can implement an IDisposable interface and in the dispose method can close the connections. Currently RedisCache is registered as singleton and the DI would call the Dispose method on the singleton instance(I verified this is happening)\r\n"},"comment":{"url":"https://api.github.com/repos/aspnet/Caching/issues/comments/167677229","html_url":"https://github.com/aspnet/Caching/issues/135#issuecomment-167677229","issue_url":"https://api.github.com/repos/aspnet/Caching/issues/135","id":167677229,"user":{"login":"kichalla","id":6559784,"avatar_url":"https://avatars.githubusercontent.com/u/6559784?v=3","gravatar_id":"","url":"https://api.github.com/users/kichalla","html_url":"https://github.com/kichalla","followers_url":"https://api.github.com/users/kichalla/followers","following_url":"https://api.github.com/users/kichalla/following{/other_user}","gists_url":"https://api.github.com/users/kichalla/gists{/gist_id}","starred_url":"https://api.github.com/users/kichalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kichalla/subscriptions","organizations_url":"https://api.github.com/users/kichalla/orgs","repos_url":"https://api.github.com/users/kichalla/repos","events_url":"https://api.github.com/users/kichalla/events{/privacy}","received_events_url":"https://api.github.com/users/kichalla/received_events","type":"User","site_admin":false},"created_at":"2015-12-28T23:19:12Z","updated_at":"2015-12-28T23:19:12Z","body":"I have the following PR with the changes\r\nhttps://github.com/aspnet/Caching/pull/136"}}