{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular/issues/1090","labels_url":"https://api.github.com/repos/angular/angular/issues/1090/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/1090/comments","events_url":"https://api.github.com/repos/angular/angular/issues/1090/events","html_url":"https://github.com/angular/angular/issues/1090","id":64184153,"number":1090,"title":"Review render shadow DOM code & tests","user":{"login":"yjbanov","id":211513,"avatar_url":"https://avatars.githubusercontent.com/u/211513?v=3","gravatar_id":"","url":"https://api.github.com/users/yjbanov","html_url":"https://github.com/yjbanov","followers_url":"https://api.github.com/users/yjbanov/followers","following_url":"https://api.github.com/users/yjbanov/following{/other_user}","gists_url":"https://api.github.com/users/yjbanov/gists{/gist_id}","starred_url":"https://api.github.com/users/yjbanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjbanov/subscriptions","organizations_url":"https://api.github.com/users/yjbanov/orgs","repos_url":"https://api.github.com/users/yjbanov/repos","events_url":"https://api.github.com/users/yjbanov/events{/privacy}","received_events_url":"https://api.github.com/users/yjbanov/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-03-25T05:51:31Z","updated_at":"2015-03-25T17:27:13Z","closed_at":"2015-03-25T17:27:13Z","body":"@tbosch \r\n\r\nI added unit-tests for shadow DOM strategy (plus some minor fixes) in https://github.com/angular/angular/commit/7d63bbcdd39246b643b00a59af5250b8721083e7\r\n\r\nI had to `xit` one of the tests because the code that adds the attribute to the parent is gone. I'm assuming you removed it intentionally, so let's figure out what we want to do with the test. All other tests are passing."},"comment":{"url":"https://api.github.com/repos/angular/angular/issues/comments/86131728","html_url":"https://github.com/angular/angular/issues/1090#issuecomment-86131728","issue_url":"https://api.github.com/repos/angular/angular/issues/1090","id":86131728,"user":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"created_at":"2015-03-25T17:27:13Z","updated_at":"2015-03-25T17:27:13Z","body":"Yes, this was by purpose.\r\nLooks good. Added a new test that captures the content of the disabled tests."}}