{"action":"created","comment":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/28192473","id":28192473,"diff_hunk":"@@ -5820,7 +5820,9 @@ void RecompilationEngine::ProcessExecutionTrace(const ExecutionTrace & execution\n             }\r\n         }\r\n     }\r\n-\r\n+\t// TODO:: Syphurith: It is said that just remove_if would cause some troubles.. I don't know if that would cause Memleak. From CppCheck:\r\n+\t// The return value of std::remove_if() is ignored. This function returns an iterator to the end of the range containing those elements that should be kept.\r\n+\t// Elements past new end remain valid but with unspecified values. Use the erase method of the container to delete them.\r\n     std::remove_if(processed_execution_trace_i->second.begin(), processed_execution_trace_i->second.end(), [](const BlockEntry * b)->bool { return b->is_compiled; });\r","path":"rpcs3/Emu/Cell/PPULLVMRecompiler.cpp","position":8,"original_position":8,"commit_id":"94441d7df3b5ead9630e8c8b49fd4e1a04245184","original_commit_id":"94441d7df3b5ead9630e8c8b49fd4e1a04245184","user":{"login":"Syphurith","id":8421531,"avatar_url":"https://avatars.githubusercontent.com/u/8421531?v=3","gravatar_id":"","url":"https://api.github.com/users/Syphurith","html_url":"https://github.com/Syphurith","followers_url":"https://api.github.com/users/Syphurith/followers","following_url":"https://api.github.com/users/Syphurith/following{/other_user}","gists_url":"https://api.github.com/users/Syphurith/gists{/gist_id}","starred_url":"https://api.github.com/users/Syphurith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Syphurith/subscriptions","organizations_url":"https://api.github.com/users/Syphurith/orgs","repos_url":"https://api.github.com/users/Syphurith/repos","events_url":"https://api.github.com/users/Syphurith/events{/privacy}","received_events_url":"https://api.github.com/users/Syphurith/received_events","type":"User","site_admin":false},"body":"@Nekotekina Eh.. Now leave this as it is now? Since we all not sure about it.","created_at":"2015-04-11T05:21:56Z","updated_at":"2015-04-11T05:21:56Z","html_url":"https://github.com/RPCS3/rpcs3/pull/1059#discussion_r28192473","pull_request_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1059","_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/28192473"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/1059#discussion_r28192473"},"pull_request":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1059"}}},"pull_request":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1059","id":33046071,"html_url":"https://github.com/RPCS3/rpcs3/pull/1059","diff_url":"https://github.com/RPCS3/rpcs3/pull/1059.diff","patch_url":"https://github.com/RPCS3/rpcs3/pull/1059.patch","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1059","number":1059,"state":"open","locked":false,"title":"(Please review carefully first) CppCheck Patch Bundle for master branch","user":{"login":"Syphurith","id":8421531,"avatar_url":"https://avatars.githubusercontent.com/u/8421531?v=3","gravatar_id":"","url":"https://api.github.com/users/Syphurith","html_url":"https://github.com/Syphurith","followers_url":"https://api.github.com/users/Syphurith/followers","following_url":"https://api.github.com/users/Syphurith/following{/other_user}","gists_url":"https://api.github.com/users/Syphurith/gists{/gist_id}","starred_url":"https://api.github.com/users/Syphurith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Syphurith/subscriptions","organizations_url":"https://api.github.com/users/Syphurith/orgs","repos_url":"https://api.github.com/users/Syphurith/repos","events_url":"https://api.github.com/users/Syphurith/events{/privacy}","received_events_url":"https://api.github.com/users/Syphurith/received_events","type":"User","site_admin":false},"body":"Seen @raven02 's recent work, i tried CppCheck to find some defects. I tried to fix some severe problems and marked those i don't know how to deal. Below is what i looked with care, and those with (mark) are just marked but not dealt. Used rules (not exactly as what it reported):\r\n* out-of-bound reference\r\n* statements should return but without return\r\n* missing breaks in cases (mark)\r\n* assert with requested effect (mark)\r\n* `std::remove_if` (mark)\r\n* if (unsigned_var < 0) (mark)\r\n* never executed else-if conditions due to same condition above (mark)\r\n* some quite weird/strange line i can not understand, dealt.\r\n* Object would be immediately destroyed (mark)\r\n* remove same value aside the `||`\r\n\r\nEven i've already built one for these commits succussfully, please review with care.\r\n**Still trying to implement a custom EmulationDir, so please wait until i changed those please.**","created_at":"2015-04-10T13:23:48Z","updated_at":"2015-04-11T05:21:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2e8227a5d04fa2ccb8f14532f491542f6d504d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1059/commits","review_comments_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1059/comments","review_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/1059/comments","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/94441d7df3b5ead9630e8c8b49fd4e1a04245184","head":{"label":"Syphurith:p4-Bundle","ref":"p4-Bundle","sha":"94441d7df3b5ead9630e8c8b49fd4e1a04245184","user":{"login":"Syphurith","id":8421531,"avatar_url":"https://avatars.githubusercontent.com/u/8421531?v=3","gravatar_id":"","url":"https://api.github.com/users/Syphurith","html_url":"https://github.com/Syphurith","followers_url":"https://api.github.com/users/Syphurith/followers","following_url":"https://api.github.com/users/Syphurith/following{/other_user}","gists_url":"https://api.github.com/users/Syphurith/gists{/gist_id}","starred_url":"https://api.github.com/users/Syphurith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Syphurith/subscriptions","organizations_url":"https://api.github.com/users/Syphurith/orgs","repos_url":"https://api.github.com/users/Syphurith/repos","events_url":"https://api.github.com/users/Syphurith/events{/privacy}","received_events_url":"https://api.github.com/users/Syphurith/received_events","type":"User","site_admin":false},"repo":{"id":22855364,"name":"rpcs3","full_name":"Syphurith/rpcs3","owner":{"login":"Syphurith","id":8421531,"avatar_url":"https://avatars.githubusercontent.com/u/8421531?v=3","gravatar_id":"","url":"https://api.github.com/users/Syphurith","html_url":"https://github.com/Syphurith","followers_url":"https://api.github.com/users/Syphurith/followers","following_url":"https://api.github.com/users/Syphurith/following{/other_user}","gists_url":"https://api.github.com/users/Syphurith/gists{/gist_id}","starred_url":"https://api.github.com/users/Syphurith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Syphurith/subscriptions","organizations_url":"https://api.github.com/users/Syphurith/orgs","repos_url":"https://api.github.com/users/Syphurith/repos","events_url":"https://api.github.com/users/Syphurith/events{/privacy}","received_events_url":"https://api.github.com/users/Syphurith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Syphurith/rpcs3","description":"PS3 emulator/debugger","fork":true,"url":"https://api.github.com/repos/Syphurith/rpcs3","forks_url":"https://api.github.com/repos/Syphurith/rpcs3/forks","keys_url":"https://api.github.com/repos/Syphurith/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Syphurith/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Syphurith/rpcs3/teams","hooks_url":"https://api.github.com/repos/Syphurith/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/Syphurith/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/Syphurith/rpcs3/events","assignees_url":"https://api.github.com/repos/Syphurith/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/Syphurith/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/Syphurith/rpcs3/tags","blobs_url":"https://api.github.com/repos/Syphurith/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Syphurith/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Syphurith/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Syphurith/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Syphurith/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/Syphurith/rpcs3/languages","stargazers_url":"https://api.github.com/repos/Syphurith/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/Syphurith/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/Syphurith/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/Syphurith/rpcs3/subscription","commits_url":"https://api.github.com/repos/Syphurith/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Syphurith/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Syphurith/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Syphurith/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Syphurith/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/Syphurith/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Syphurith/rpcs3/merges","archive_url":"https://api.github.com/repos/Syphurith/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Syphurith/rpcs3/downloads","issues_url":"https://api.github.com/repos/Syphurith/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/Syphurith/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/Syphurith/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/Syphurith/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Syphurith/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/Syphurith/rpcs3/releases{/id}","created_at":"2014-08-11T21:23:28Z","updated_at":"2015-04-09T18:22:36Z","pushed_at":"2015-04-10T17:58:37Z","git_url":"git://github.com/Syphurith/rpcs3.git","ssh_url":"git@github.com:Syphurith/rpcs3.git","clone_url":"https://github.com/Syphurith/rpcs3.git","svn_url":"https://github.com/Syphurith/rpcs3","homepage":null,"size":19727,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"RPCS3:master","ref":"master","sha":"952098c00fff18d0c6c4797690c966708523e43b","user":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars.githubusercontent.com/u/8070735?v=3","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"repo":{"id":6520784,"name":"rpcs3","full_name":"RPCS3/rpcs3","owner":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars.githubusercontent.com/u/8070735?v=3","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RPCS3/rpcs3","description":"PS3 emulator/debugger","fork":false,"url":"https://api.github.com/repos/RPCS3/rpcs3","forks_url":"https://api.github.com/repos/RPCS3/rpcs3/forks","keys_url":"https://api.github.com/repos/RPCS3/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RPCS3/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RPCS3/rpcs3/teams","hooks_url":"https://api.github.com/repos/RPCS3/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/RPCS3/rpcs3/events","assignees_url":"https://api.github.com/repos/RPCS3/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/RPCS3/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/RPCS3/rpcs3/tags","blobs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RPCS3/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/RPCS3/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/RPCS3/rpcs3/languages","stargazers_url":"https://api.github.com/repos/RPCS3/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/RPCS3/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/RPCS3/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/RPCS3/rpcs3/subscription","commits_url":"https://api.github.com/repos/RPCS3/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/RPCS3/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/RPCS3/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/RPCS3/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RPCS3/rpcs3/merges","archive_url":"https://api.github.com/repos/RPCS3/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RPCS3/rpcs3/downloads","issues_url":"https://api.github.com/repos/RPCS3/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/RPCS3/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/RPCS3/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/RPCS3/rpcs3/releases{/id}","created_at":"2012-11-03T15:16:18Z","updated_at":"2015-04-10T02:22:48Z","pushed_at":"2015-04-10T17:58:38Z","git_url":"git://github.com/RPCS3/rpcs3.git","ssh_url":"git@github.com:RPCS3/rpcs3.git","clone_url":"https://github.com/RPCS3/rpcs3.git","svn_url":"https://github.com/RPCS3/rpcs3","homepage":null,"size":69875,"stargazers_count":1379,"watchers_count":1379,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":253,"mirror_url":null,"open_issues_count":26,"forks":253,"open_issues":26,"watchers":1379,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1059"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/1059"},"issue":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/1059"},"comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/1059/comments"},"review_comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1059/comments"},"review_comment":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/1059/commits"},"statuses":{"href":"https://api.github.com/repos/RPCS3/rpcs3/statuses/94441d7df3b5ead9630e8c8b49fd4e1a04245184"}}}}