{"action":"created","comment":{"url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/pulls/comments/37938480","id":37938480,"diff_hunk":"@@ -15,62 +15,50 @@\n  */\n package org.cloudfoundry.community.servicebroker.s3.service;\n \n-import java.util.List;\n-\n import org.cloudfoundry.community.servicebroker.exception.ServiceBrokerException;\n import org.cloudfoundry.community.servicebroker.exception.ServiceInstanceExistsException;\n import org.cloudfoundry.community.servicebroker.model.ServiceDefinition;\n import org.cloudfoundry.community.servicebroker.model.ServiceInstance;\n+import org.cloudfoundry.community.servicebroker.s3.plan.BasicPlan;\n import org.cloudfoundry.community.servicebroker.service.ServiceInstanceService;\n import org.springframework.beans.factory.annotation.Autowired;\n import org.springframework.stereotype.Service;\n \n-import com.amazonaws.services.s3.model.Bucket;\n+import java.util.List;\n \n /**\n  * @author David Ehringer\n  */\n @Service\n public class S3ServiceInstanceService implements ServiceInstanceService {\n-\n-    private final Iam iam;\n-    private final S3 s3;\n+    private final BasicPlan basicPlan;","path":"src/main/java/org/cloudfoundry/community/servicebroker/s3/service/S3ServiceInstanceService.java","position":26,"original_position":26,"commit_id":"9378a5431df9ecf0e251c6741a6b0a36629a32f0","original_commit_id":"9378a5431df9ecf0e251c6741a6b0a36629a32f0","user":{"login":"davidehringer","id":367987,"avatar_url":"https://avatars.githubusercontent.com/u/367987?v=3","gravatar_id":"","url":"https://api.github.com/users/davidehringer","html_url":"https://github.com/davidehringer","followers_url":"https://api.github.com/users/davidehringer/followers","following_url":"https://api.github.com/users/davidehringer/following{/other_user}","gists_url":"https://api.github.com/users/davidehringer/gists{/gist_id}","starred_url":"https://api.github.com/users/davidehringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidehringer/subscriptions","organizations_url":"https://api.github.com/users/davidehringer/orgs","repos_url":"https://api.github.com/users/davidehringer/repos","events_url":"https://api.github.com/users/davidehringer/events{/privacy}","received_events_url":"https://api.github.com/users/davidehringer/received_events","type":"User","site_admin":false},"body":"Same comment as above regarding this using BasicPlan.","created_at":"2015-08-26T01:16:26Z","updated_at":"2015-08-26T01:16:26Z","html_url":"https://github.com/cloudfoundry-community/s3-cf-service-broker/pull/8#discussion_r37938480","pull_request_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/pulls/comments/37938480"},"html":{"href":"https://github.com/cloudfoundry-community/s3-cf-service-broker/pull/8#discussion_r37938480"},"pull_request":{"href":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/pulls/8","id":43267311,"html_url":"https://github.com/cloudfoundry-community/s3-cf-service-broker/pull/8","diff_url":"https://github.com/cloudfoundry-community/s3-cf-service-broker/pull/8.diff","patch_url":"https://github.com/cloudfoundry-community/s3-cf-service-broker/pull/8.patch","issue_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/issues/8","number":8,"state":"open","locked":false,"title":"Split plans","user":{"login":"pommi","id":548668,"avatar_url":"https://avatars.githubusercontent.com/u/548668?v=3","gravatar_id":"","url":"https://api.github.com/users/pommi","html_url":"https://github.com/pommi","followers_url":"https://api.github.com/users/pommi/followers","following_url":"https://api.github.com/users/pommi/following{/other_user}","gists_url":"https://api.github.com/users/pommi/gists{/gist_id}","starred_url":"https://api.github.com/users/pommi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pommi/subscriptions","organizations_url":"https://api.github.com/users/pommi/orgs","repos_url":"https://api.github.com/users/pommi/repos","events_url":"https://api.github.com/users/pommi/events{/privacy}","received_events_url":"https://api.github.com/users/pommi/received_events","type":"User","site_admin":false},"body":"Because of some Amazon limitations ([100 buckets](http://docs.aws.amazon.com/AmazonS3/latest/dev/BucketRestrictions.html), [5000 IAM Users](http://docs.aws.amazon.com/IAM/latest/UserGuide/limits.html)), we at Mendix have been working on a \"[Shared S3 Plan](https://github.com/mendix/s3-cf-service-broker/tree/shared-plan)\", next to the Basic S3 Plan, where we share 1 bucket and 1 shared IAM account with all \"Service Instances\".\r\n\r\nIn preparation of the additional \"Shared S3 Plan\", in this Pull Request we've done some refactoring to add support for a new plan more easily, mainly:\r\n- Iam.java has been split up in iam/Iam.java and iam/plan/BasicPlanIam.java\r\n- service/S3ServiceInstanceService.java is now more generic, Basic Plan specific stuff moved to plan/BasicPlan.java","created_at":"2015-08-25T09:39:22Z","updated_at":"2015-08-26T01:16:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00ed1e853af7e2d2a1844923e6a5b79e384477e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/pulls/8/commits","review_comments_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/pulls/8/comments","review_comment_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/issues/8/comments","statuses_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/statuses/9378a5431df9ecf0e251c6741a6b0a36629a32f0","head":{"label":"mendix:split-plans","ref":"split-plans","sha":"9378a5431df9ecf0e251c6741a6b0a36629a32f0","user":{"login":"mendix","id":133443,"avatar_url":"https://avatars.githubusercontent.com/u/133443?v=3","gravatar_id":"","url":"https://api.github.com/users/mendix","html_url":"https://github.com/mendix","followers_url":"https://api.github.com/users/mendix/followers","following_url":"https://api.github.com/users/mendix/following{/other_user}","gists_url":"https://api.github.com/users/mendix/gists{/gist_id}","starred_url":"https://api.github.com/users/mendix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendix/subscriptions","organizations_url":"https://api.github.com/users/mendix/orgs","repos_url":"https://api.github.com/users/mendix/repos","events_url":"https://api.github.com/users/mendix/events{/privacy}","received_events_url":"https://api.github.com/users/mendix/received_events","type":"Organization","site_admin":false},"repo":{"id":41023180,"name":"s3-cf-service-broker","full_name":"mendix/s3-cf-service-broker","owner":{"login":"mendix","id":133443,"avatar_url":"https://avatars.githubusercontent.com/u/133443?v=3","gravatar_id":"","url":"https://api.github.com/users/mendix","html_url":"https://github.com/mendix","followers_url":"https://api.github.com/users/mendix/followers","following_url":"https://api.github.com/users/mendix/following{/other_user}","gists_url":"https://api.github.com/users/mendix/gists{/gist_id}","starred_url":"https://api.github.com/users/mendix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendix/subscriptions","organizations_url":"https://api.github.com/users/mendix/orgs","repos_url":"https://api.github.com/users/mendix/repos","events_url":"https://api.github.com/users/mendix/events{/privacy}","received_events_url":"https://api.github.com/users/mendix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mendix/s3-cf-service-broker","description":"","fork":true,"url":"https://api.github.com/repos/mendix/s3-cf-service-broker","forks_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/forks","keys_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/teams","hooks_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/hooks","issue_events_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/issues/events{/number}","events_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/events","assignees_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/assignees{/user}","branches_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/branches{/branch}","tags_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/tags","blobs_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/languages","stargazers_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/stargazers","contributors_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/contributors","subscribers_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/subscribers","subscription_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/subscription","commits_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/contents/{+path}","compare_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/merges","archive_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/downloads","issues_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/issues{/number}","pulls_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/labels{/name}","releases_url":"https://api.github.com/repos/mendix/s3-cf-service-broker/releases{/id}","created_at":"2015-08-19T08:45:52Z","updated_at":"2015-08-19T08:45:52Z","pushed_at":"2015-08-25T09:36:06Z","git_url":"git://github.com/mendix/s3-cf-service-broker.git","ssh_url":"git@github.com:mendix/s3-cf-service-broker.git","clone_url":"https://github.com/mendix/s3-cf-service-broker.git","svn_url":"https://github.com/mendix/s3-cf-service-broker","homepage":null,"size":226,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudfoundry-community:master","ref":"master","sha":"3e654a478314ded0f6cb274c3adab12e0145b737","user":{"login":"cloudfoundry-community","id":4378855,"avatar_url":"https://avatars.githubusercontent.com/u/4378855?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-community","html_url":"https://github.com/cloudfoundry-community","followers_url":"https://api.github.com/users/cloudfoundry-community/followers","following_url":"https://api.github.com/users/cloudfoundry-community/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-community/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-community/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-community/orgs","repos_url":"https://api.github.com/users/cloudfoundry-community/repos","events_url":"https://api.github.com/users/cloudfoundry-community/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-community/received_events","type":"Organization","site_admin":false},"repo":{"id":22101467,"name":"s3-cf-service-broker","full_name":"cloudfoundry-community/s3-cf-service-broker","owner":{"login":"cloudfoundry-community","id":4378855,"avatar_url":"https://avatars.githubusercontent.com/u/4378855?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-community","html_url":"https://github.com/cloudfoundry-community","followers_url":"https://api.github.com/users/cloudfoundry-community/followers","following_url":"https://api.github.com/users/cloudfoundry-community/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-community/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-community/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-community/orgs","repos_url":"https://api.github.com/users/cloudfoundry-community/repos","events_url":"https://api.github.com/users/cloudfoundry-community/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudfoundry-community/s3-cf-service-broker","description":"","fork":false,"url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker","forks_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/forks","keys_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/teams","hooks_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/hooks","issue_events_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/events","assignees_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/tags","blobs_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/languages","stargazers_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/stargazers","contributors_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/contributors","subscribers_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/subscribers","subscription_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/subscription","commits_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/merges","archive_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/downloads","issues_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/labels{/name}","releases_url":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/releases{/id}","created_at":"2014-07-22T11:27:51Z","updated_at":"2015-04-10T13:24:56Z","pushed_at":"2015-08-25T09:39:23Z","git_url":"git://github.com/cloudfoundry-community/s3-cf-service-broker.git","ssh_url":"git@github.com:cloudfoundry-community/s3-cf-service-broker.git","clone_url":"https://github.com/cloudfoundry-community/s3-cf-service-broker.git","svn_url":"https://github.com/cloudfoundry-community/s3-cf-service-broker","homepage":null,"size":476,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":3,"forks":9,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/pulls/8"},"html":{"href":"https://github.com/cloudfoundry-community/s3-cf-service-broker/pull/8"},"issue":{"href":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/issues/8"},"comments":{"href":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/cloudfoundry-community/s3-cf-service-broker/statuses/9378a5431df9ecf0e251c6741a6b0a36629a32f0"}}}}