{"action":"created","comment":{"url":"https://api.github.com/repos/getpelican/pelican/pulls/comments/32780946","id":32780946,"diff_hunk":"@@ -643,7 +643,7 @@ def generate_context(self):\n         self.hidden_pages, self.hidden_translations = (\n             process_translations(hidden_pages))\n \n-        self._update_context(('pages', ))\n+        self._update_context(('pages', 'hidden_pages'))\n         self.context['PAGES'] = self.pages","path":"pelican/generators.py","position":15,"original_position":15,"commit_id":"a61f9e2d485cc895398f0094c2d48a8517844337","original_commit_id":"a61f9e2d485cc895398f0094c2d48a8517844337","user":{"login":"ingwinlu","id":4435962,"avatar_url":"https://avatars.githubusercontent.com/u/4435962?v=3","gravatar_id":"","url":"https://api.github.com/users/ingwinlu","html_url":"https://github.com/ingwinlu","followers_url":"https://api.github.com/users/ingwinlu/followers","following_url":"https://api.github.com/users/ingwinlu/following{/other_user}","gists_url":"https://api.github.com/users/ingwinlu/gists{/gist_id}","starred_url":"https://api.github.com/users/ingwinlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingwinlu/subscriptions","organizations_url":"https://api.github.com/users/ingwinlu/orgs","repos_url":"https://api.github.com/users/ingwinlu/repos","events_url":"https://api.github.com/users/ingwinlu/events{/privacy}","received_events_url":"https://api.github.com/users/ingwinlu/received_events","type":"User","site_admin":false},"body":"should probably be removed; it is no where documented that pages is available as `pages` and `PAGES` + it is the (only?) variable I know of that actually is made available as UPPERCASE.\r\n\r\nIf suggest deprecating `PAGES`, issuing a warning if it is called, and update the default themes to use pages instead of PAGES.\r\n\r\n@avaris @justinmayer thoughts?","created_at":"2015-06-18T21:31:25Z","updated_at":"2015-06-18T21:31:25Z","html_url":"https://github.com/getpelican/pelican/pull/1760#discussion_r32780946","pull_request_url":"https://api.github.com/repos/getpelican/pelican/pulls/1760","_links":{"self":{"href":"https://api.github.com/repos/getpelican/pelican/pulls/comments/32780946"},"html":{"href":"https://github.com/getpelican/pelican/pull/1760#discussion_r32780946"},"pull_request":{"href":"https://api.github.com/repos/getpelican/pelican/pulls/1760"}}},"pull_request":{"url":"https://api.github.com/repos/getpelican/pelican/pulls/1760","id":37844317,"html_url":"https://github.com/getpelican/pelican/pull/1760","diff_url":"https://github.com/getpelican/pelican/pull/1760.diff","patch_url":"https://github.com/getpelican/pelican/pull/1760.patch","issue_url":"https://api.github.com/repos/getpelican/pelican/issues/1760","number":1760,"state":"open","locked":false,"title":"Export hidden pages in context","user":{"login":"jml","id":125674,"avatar_url":"https://avatars.githubusercontent.com/u/125674?v=3","gravatar_id":"","url":"https://api.github.com/users/jml","html_url":"https://github.com/jml","followers_url":"https://api.github.com/users/jml/followers","following_url":"https://api.github.com/users/jml/following{/other_user}","gists_url":"https://api.github.com/users/jml/gists{/gist_id}","starred_url":"https://api.github.com/users/jml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jml/subscriptions","organizations_url":"https://api.github.com/users/jml/orgs","repos_url":"https://api.github.com/users/jml/repos","events_url":"https://api.github.com/users/jml/events{/privacy}","received_events_url":"https://api.github.com/users/jml/received_events","type":"User","site_admin":false},"body":"The `PageGenerator` was building hidden pages, but not making them\r\navailable in the context. This makes it difficult for other plugins to\r\noperate on hidden pages.\r\n\r\nThis patch updates `PageGenerator` to export the hidden pages it finds\r\nin the context as `hidden_pages`.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/getpelican/pelican/1760)\n<!-- Reviewable:end -->\n","created_at":"2015-06-16T21:35:23Z","updated_at":"2015-06-18T21:31:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbdc8885e94e6315fefaa46f5d540086d90c2738","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/getpelican/pelican/pulls/1760/commits","review_comments_url":"https://api.github.com/repos/getpelican/pelican/pulls/1760/comments","review_comment_url":"https://api.github.com/repos/getpelican/pelican/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getpelican/pelican/issues/1760/comments","statuses_url":"https://api.github.com/repos/getpelican/pelican/statuses/a61f9e2d485cc895398f0094c2d48a8517844337","head":{"label":"jml:export-hidden-pages","ref":"export-hidden-pages","sha":"a61f9e2d485cc895398f0094c2d48a8517844337","user":{"login":"jml","id":125674,"avatar_url":"https://avatars.githubusercontent.com/u/125674?v=3","gravatar_id":"","url":"https://api.github.com/users/jml","html_url":"https://github.com/jml","followers_url":"https://api.github.com/users/jml/followers","following_url":"https://api.github.com/users/jml/following{/other_user}","gists_url":"https://api.github.com/users/jml/gists{/gist_id}","starred_url":"https://api.github.com/users/jml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jml/subscriptions","organizations_url":"https://api.github.com/users/jml/orgs","repos_url":"https://api.github.com/users/jml/repos","events_url":"https://api.github.com/users/jml/events{/privacy}","received_events_url":"https://api.github.com/users/jml/received_events","type":"User","site_admin":false},"repo":{"id":21526129,"name":"pelican","full_name":"jml/pelican","owner":{"login":"jml","id":125674,"avatar_url":"https://avatars.githubusercontent.com/u/125674?v=3","gravatar_id":"","url":"https://api.github.com/users/jml","html_url":"https://github.com/jml","followers_url":"https://api.github.com/users/jml/followers","following_url":"https://api.github.com/users/jml/following{/other_user}","gists_url":"https://api.github.com/users/jml/gists{/gist_id}","starred_url":"https://api.github.com/users/jml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jml/subscriptions","organizations_url":"https://api.github.com/users/jml/orgs","repos_url":"https://api.github.com/users/jml/repos","events_url":"https://api.github.com/users/jml/events{/privacy}","received_events_url":"https://api.github.com/users/jml/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jml/pelican","description":"Static site generator that supports Markdown and reST syntax. Powered by Python.","fork":true,"url":"https://api.github.com/repos/jml/pelican","forks_url":"https://api.github.com/repos/jml/pelican/forks","keys_url":"https://api.github.com/repos/jml/pelican/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jml/pelican/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jml/pelican/teams","hooks_url":"https://api.github.com/repos/jml/pelican/hooks","issue_events_url":"https://api.github.com/repos/jml/pelican/issues/events{/number}","events_url":"https://api.github.com/repos/jml/pelican/events","assignees_url":"https://api.github.com/repos/jml/pelican/assignees{/user}","branches_url":"https://api.github.com/repos/jml/pelican/branches{/branch}","tags_url":"https://api.github.com/repos/jml/pelican/tags","blobs_url":"https://api.github.com/repos/jml/pelican/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jml/pelican/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jml/pelican/git/refs{/sha}","trees_url":"https://api.github.com/repos/jml/pelican/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jml/pelican/statuses/{sha}","languages_url":"https://api.github.com/repos/jml/pelican/languages","stargazers_url":"https://api.github.com/repos/jml/pelican/stargazers","contributors_url":"https://api.github.com/repos/jml/pelican/contributors","subscribers_url":"https://api.github.com/repos/jml/pelican/subscribers","subscription_url":"https://api.github.com/repos/jml/pelican/subscription","commits_url":"https://api.github.com/repos/jml/pelican/commits{/sha}","git_commits_url":"https://api.github.com/repos/jml/pelican/git/commits{/sha}","comments_url":"https://api.github.com/repos/jml/pelican/comments{/number}","issue_comment_url":"https://api.github.com/repos/jml/pelican/issues/comments{/number}","contents_url":"https://api.github.com/repos/jml/pelican/contents/{+path}","compare_url":"https://api.github.com/repos/jml/pelican/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jml/pelican/merges","archive_url":"https://api.github.com/repos/jml/pelican/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jml/pelican/downloads","issues_url":"https://api.github.com/repos/jml/pelican/issues{/number}","pulls_url":"https://api.github.com/repos/jml/pelican/pulls{/number}","milestones_url":"https://api.github.com/repos/jml/pelican/milestones{/number}","notifications_url":"https://api.github.com/repos/jml/pelican/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jml/pelican/labels{/name}","releases_url":"https://api.github.com/repos/jml/pelican/releases{/id}","created_at":"2014-07-05T18:53:54Z","updated_at":"2014-07-05T03:12:16Z","pushed_at":"2015-06-18T21:08:33Z","git_url":"git://github.com/jml/pelican.git","ssh_url":"git@github.com:jml/pelican.git","clone_url":"https://github.com/jml/pelican.git","svn_url":"https://github.com/jml/pelican","homepage":"http://getpelican.com/","size":5012,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"getpelican:master","ref":"master","sha":"780ccfe137a910b404d651a4973f68c85adf01f2","user":{"login":"getpelican","id":2043492,"avatar_url":"https://avatars.githubusercontent.com/u/2043492?v=3","gravatar_id":"","url":"https://api.github.com/users/getpelican","html_url":"https://github.com/getpelican","followers_url":"https://api.github.com/users/getpelican/followers","following_url":"https://api.github.com/users/getpelican/following{/other_user}","gists_url":"https://api.github.com/users/getpelican/gists{/gist_id}","starred_url":"https://api.github.com/users/getpelican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getpelican/subscriptions","organizations_url":"https://api.github.com/users/getpelican/orgs","repos_url":"https://api.github.com/users/getpelican/repos","events_url":"https://api.github.com/users/getpelican/events{/privacy}","received_events_url":"https://api.github.com/users/getpelican/received_events","type":"Organization","site_admin":false},"repo":{"id":993110,"name":"pelican","full_name":"getpelican/pelican","owner":{"login":"getpelican","id":2043492,"avatar_url":"https://avatars.githubusercontent.com/u/2043492?v=3","gravatar_id":"","url":"https://api.github.com/users/getpelican","html_url":"https://github.com/getpelican","followers_url":"https://api.github.com/users/getpelican/followers","following_url":"https://api.github.com/users/getpelican/following{/other_user}","gists_url":"https://api.github.com/users/getpelican/gists{/gist_id}","starred_url":"https://api.github.com/users/getpelican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getpelican/subscriptions","organizations_url":"https://api.github.com/users/getpelican/orgs","repos_url":"https://api.github.com/users/getpelican/repos","events_url":"https://api.github.com/users/getpelican/events{/privacy}","received_events_url":"https://api.github.com/users/getpelican/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getpelican/pelican","description":"Static site generator that supports Markdown and reST syntax. Powered by Python.","fork":false,"url":"https://api.github.com/repos/getpelican/pelican","forks_url":"https://api.github.com/repos/getpelican/pelican/forks","keys_url":"https://api.github.com/repos/getpelican/pelican/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getpelican/pelican/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getpelican/pelican/teams","hooks_url":"https://api.github.com/repos/getpelican/pelican/hooks","issue_events_url":"https://api.github.com/repos/getpelican/pelican/issues/events{/number}","events_url":"https://api.github.com/repos/getpelican/pelican/events","assignees_url":"https://api.github.com/repos/getpelican/pelican/assignees{/user}","branches_url":"https://api.github.com/repos/getpelican/pelican/branches{/branch}","tags_url":"https://api.github.com/repos/getpelican/pelican/tags","blobs_url":"https://api.github.com/repos/getpelican/pelican/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getpelican/pelican/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getpelican/pelican/git/refs{/sha}","trees_url":"https://api.github.com/repos/getpelican/pelican/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getpelican/pelican/statuses/{sha}","languages_url":"https://api.github.com/repos/getpelican/pelican/languages","stargazers_url":"https://api.github.com/repos/getpelican/pelican/stargazers","contributors_url":"https://api.github.com/repos/getpelican/pelican/contributors","subscribers_url":"https://api.github.com/repos/getpelican/pelican/subscribers","subscription_url":"https://api.github.com/repos/getpelican/pelican/subscription","commits_url":"https://api.github.com/repos/getpelican/pelican/commits{/sha}","git_commits_url":"https://api.github.com/repos/getpelican/pelican/git/commits{/sha}","comments_url":"https://api.github.com/repos/getpelican/pelican/comments{/number}","issue_comment_url":"https://api.github.com/repos/getpelican/pelican/issues/comments{/number}","contents_url":"https://api.github.com/repos/getpelican/pelican/contents/{+path}","compare_url":"https://api.github.com/repos/getpelican/pelican/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getpelican/pelican/merges","archive_url":"https://api.github.com/repos/getpelican/pelican/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getpelican/pelican/downloads","issues_url":"https://api.github.com/repos/getpelican/pelican/issues{/number}","pulls_url":"https://api.github.com/repos/getpelican/pelican/pulls{/number}","milestones_url":"https://api.github.com/repos/getpelican/pelican/milestones{/number}","notifications_url":"https://api.github.com/repos/getpelican/pelican/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getpelican/pelican/labels{/name}","releases_url":"https://api.github.com/repos/getpelican/pelican/releases{/id}","created_at":"2010-10-16T18:57:40Z","updated_at":"2015-06-18T14:43:37Z","pushed_at":"2015-06-18T21:08:33Z","git_url":"git://github.com/getpelican/pelican.git","ssh_url":"git@github.com:getpelican/pelican.git","clone_url":"https://github.com/getpelican/pelican.git","svn_url":"https://github.com/getpelican/pelican","homepage":"http://getpelican.com/","size":13483,"stargazers_count":4727,"watchers_count":4727,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1066,"mirror_url":null,"open_issues_count":146,"forks":1066,"open_issues":146,"watchers":4727,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getpelican/pelican/pulls/1760"},"html":{"href":"https://github.com/getpelican/pelican/pull/1760"},"issue":{"href":"https://api.github.com/repos/getpelican/pelican/issues/1760"},"comments":{"href":"https://api.github.com/repos/getpelican/pelican/issues/1760/comments"},"review_comments":{"href":"https://api.github.com/repos/getpelican/pelican/pulls/1760/comments"},"review_comment":{"href":"https://api.github.com/repos/getpelican/pelican/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getpelican/pelican/pulls/1760/commits"},"statuses":{"href":"https://api.github.com/repos/getpelican/pelican/statuses/a61f9e2d485cc895398f0094c2d48a8517844337"}}}}