{"action":"created","issue":{"url":"https://api.github.com/repos/aodn/imos-toolbox/issues/295","labels_url":"https://api.github.com/repos/aodn/imos-toolbox/issues/295/labels{/name}","comments_url":"https://api.github.com/repos/aodn/imos-toolbox/issues/295/comments","events_url":"https://api.github.com/repos/aodn/imos-toolbox/issues/295/events","html_url":"https://github.com/aodn/imos-toolbox/pull/295","id":120105246,"number":295,"title":"Salinity from TEOS10 consistently calculated, even for dataset that a…","user":{"login":"ggalibert","id":3498686,"avatar_url":"https://avatars.githubusercontent.com/u/3498686?v=3","gravatar_id":"","url":"https://api.github.com/users/ggalibert","html_url":"https://github.com/ggalibert","followers_url":"https://api.github.com/users/ggalibert/followers","following_url":"https://api.github.com/users/ggalibert/following{/other_user}","gists_url":"https://api.github.com/users/ggalibert/gists{/gist_id}","starred_url":"https://api.github.com/users/ggalibert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggalibert/subscriptions","organizations_url":"https://api.github.com/users/ggalibert/orgs","repos_url":"https://api.github.com/users/ggalibert/repos","events_url":"https://api.github.com/users/ggalibert/events{/privacy}","received_events_url":"https://api.github.com/users/ggalibert/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-03T06:40:26Z","updated_at":"2015-12-03T06:44:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aodn/imos-toolbox/pulls/295","html_url":"https://github.com/aodn/imos-toolbox/pull/295","diff_url":"https://github.com/aodn/imos-toolbox/pull/295.diff","patch_url":"https://github.com/aodn/imos-toolbox/pull/295.patch"},"body":"…lready include salinity"},"comment":{"url":"https://api.github.com/repos/aodn/imos-toolbox/issues/comments/161533294","html_url":"https://github.com/aodn/imos-toolbox/pull/295#issuecomment-161533294","issue_url":"https://api.github.com/repos/aodn/imos-toolbox/issues/295","id":161533294,"user":{"login":"ggalibert","id":3498686,"avatar_url":"https://avatars.githubusercontent.com/u/3498686?v=3","gravatar_id":"","url":"https://api.github.com/users/ggalibert","html_url":"https://github.com/ggalibert","followers_url":"https://api.github.com/users/ggalibert/followers","following_url":"https://api.github.com/users/ggalibert/following{/other_user}","gists_url":"https://api.github.com/users/ggalibert/gists{/gist_id}","starred_url":"https://api.github.com/users/ggalibert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggalibert/subscriptions","organizations_url":"https://api.github.com/users/ggalibert/orgs","repos_url":"https://api.github.com/users/ggalibert/repos","events_url":"https://api.github.com/users/ggalibert/events{/privacy}","received_events_url":"https://api.github.com/users/ggalibert/received_events","type":"User","site_admin":false},"created_at":"2015-12-03T06:44:24Z","updated_at":"2015-12-03T06:44:24Z","body":"@sspagnol what do you think of this, could that be a good idea?\r\n\r\nInstruments/Manufacturers can still output salinity using EOS-8 while the toolbox is calculating it with TEOS-10, but only when it doesn't exist already. So for now we end up with an inconsistent collection of salinity. Is this a big deal?\r\n\r\nI've been reported:\r\n```Ruskin uses the UNESCO-80 formulae for calculation of salinity (and other quantities), giving salinity on the Practical Salinity Scale (PSS). We have talked about implementing TEOS-10 in Ruskin, but currently don't have any plans for it. The reason for this is that Absolute Salinity is calculated from Practical Salinity, and PS is still the quantity that should be archived.```"}}