{"action":"created","issue":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/787","labels_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/787/labels{/name}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/787/comments","events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/787/events","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/787","id":118351411,"number":787,"title":"Merge Onewire changes from Master into Dev","user":{"login":"TerryE","id":690173,"avatar_url":"https://avatars.githubusercontent.com/u/690173?v=3","gravatar_id":"","url":"https://api.github.com/users/TerryE","html_url":"https://github.com/TerryE","followers_url":"https://api.github.com/users/TerryE/followers","following_url":"https://api.github.com/users/TerryE/following{/other_user}","gists_url":"https://api.github.com/users/TerryE/gists{/gist_id}","starred_url":"https://api.github.com/users/TerryE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerryE/subscriptions","organizations_url":"https://api.github.com/users/TerryE/orgs","repos_url":"https://api.github.com/users/TerryE/repos","events_url":"https://api.github.com/users/TerryE/events{/privacy}","received_events_url":"https://api.github.com/users/TerryE/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-23T10:12:40Z","updated_at":"2015-11-23T16:23:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/787","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/787","diff_url":"https://github.com/nodemcu/nodemcu-firmware/pull/787.diff","patch_url":"https://github.com/nodemcu/nodemcu-firmware/pull/787.patch"},"body":"Master contained two OW changes one of which was already reimplemented in dev using the\r\ncorrect macros.  The second was from hazarkarabay (f6d0c0c) that onewire_search()\r\nreturns a device address vector even when no device is found.  I've reimplemented this\r\nbut using the correct index, rom_byte_number, rather than declaring a new temp index i."},"comment":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/comments/158986049","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/787#issuecomment-158986049","issue_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/787","id":158986049,"user":{"login":"nickandrew","id":7175,"avatar_url":"https://avatars.githubusercontent.com/u/7175?v=3","gravatar_id":"","url":"https://api.github.com/users/nickandrew","html_url":"https://github.com/nickandrew","followers_url":"https://api.github.com/users/nickandrew/followers","following_url":"https://api.github.com/users/nickandrew/following{/other_user}","gists_url":"https://api.github.com/users/nickandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/nickandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickandrew/subscriptions","organizations_url":"https://api.github.com/users/nickandrew/orgs","repos_url":"https://api.github.com/users/nickandrew/repos","events_url":"https://api.github.com/users/nickandrew/events{/privacy}","received_events_url":"https://api.github.com/users/nickandrew/received_events","type":"User","site_admin":false},"created_at":"2015-11-23T16:23:55Z","updated_at":"2015-11-23T16:23:55Z","body":"Ok, I tested everything using old and new firmware using this script: https://gist.github.com/nickandrew/54d2bfaaefeba65b1e7a\r\n\r\nThe search function wasn't actually broken before the fix; it was merely redundantly copying 8 bytes and the lua interface subsequently ignored it.\r\n\r\nTesting worked with 0, 1, 2 and 3 devices on the bus. It's good to merge."}}