{"action":"created","issue":{"url":"https://api.github.com/repos/kohana/cache/issues/71","labels_url":"https://api.github.com/repos/kohana/cache/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/kohana/cache/issues/71/comments","events_url":"https://api.github.com/repos/kohana/cache/issues/71/events","html_url":"https://github.com/kohana/cache/pull/71","id":90055969,"number":71,"title":"Cache_File driver: Fix expiry test and garbage collection","user":{"login":"enov","id":4045110,"avatar_url":"https://avatars.githubusercontent.com/u/4045110?v=3","gravatar_id":"","url":"https://api.github.com/users/enov","html_url":"https://github.com/enov","followers_url":"https://api.github.com/users/enov/followers","following_url":"https://api.github.com/users/enov/following{/other_user}","gists_url":"https://api.github.com/users/enov/gists{/gist_id}","starred_url":"https://api.github.com/users/enov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enov/subscriptions","organizations_url":"https://api.github.com/users/enov/orgs","repos_url":"https://api.github.com/users/enov/repos","events_url":"https://api.github.com/users/enov/events{/privacy}","received_events_url":"https://api.github.com/users/enov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-22T09:45:27Z","updated_at":"2015-06-24T09:09:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kohana/cache/pulls/71","html_url":"https://github.com/kohana/cache/pull/71","diff_url":"https://github.com/kohana/cache/pull/71.diff","patch_url":"https://github.com/kohana/cache/pull/71.patch"},"body":"Recursive calls of Cache_File::_delete_file should keep `$retain_parent_directory`, `$ignore_errors`, `$only_expired` variable values. Fixes garbage collection.\r\n\r\nCache_File::_delete_file was using a wrong JSON-based cache expiry test implementation.\r\n\r\nDRY things out and separate logic that tests for the expiry in a protected method.\r\n\r\nThis slightly slow things out, as a single Cache::get will open and read the cache file twice.\r\n\r\nThanks @MaciejKrol\r\nRef #70"},"comment":{"url":"https://api.github.com/repos/kohana/cache/issues/comments/114796392","html_url":"https://github.com/kohana/cache/pull/71#issuecomment-114796392","issue_url":"https://api.github.com/repos/kohana/cache/issues/71","id":114796392,"user":{"login":"acoulton","id":416566,"avatar_url":"https://avatars.githubusercontent.com/u/416566?v=3","gravatar_id":"","url":"https://api.github.com/users/acoulton","html_url":"https://github.com/acoulton","followers_url":"https://api.github.com/users/acoulton/followers","following_url":"https://api.github.com/users/acoulton/following{/other_user}","gists_url":"https://api.github.com/users/acoulton/gists{/gist_id}","starred_url":"https://api.github.com/users/acoulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acoulton/subscriptions","organizations_url":"https://api.github.com/users/acoulton/orgs","repos_url":"https://api.github.com/users/acoulton/repos","events_url":"https://api.github.com/users/acoulton/events{/privacy}","received_events_url":"https://api.github.com/users/acoulton/received_events","type":"User","site_admin":false},"created_at":"2015-06-24T09:09:09Z","updated_at":"2015-06-24T09:09:09Z","body":"@enov it's only reading the lifetime twice, right? Can't imagine any significant impact assuming the OS is doing a halfway-decent job of filesystem caching."}}