{"action":"created","issue":{"url":"https://api.github.com/repos/ocsigen/eliom/issues/215","labels_url":"https://api.github.com/repos/ocsigen/eliom/issues/215/labels{/name}","comments_url":"https://api.github.com/repos/ocsigen/eliom/issues/215/comments","events_url":"https://api.github.com/repos/ocsigen/eliom/issues/215/events","html_url":"https://github.com/ocsigen/eliom/pull/215","id":119922421,"number":215,"title":"Improved Form APIs","user":{"login":"vasilisp","id":4950946,"avatar_url":"https://avatars.githubusercontent.com/u/4950946?v=3","gravatar_id":"","url":"https://api.github.com/users/vasilisp","html_url":"https://github.com/vasilisp","followers_url":"https://api.github.com/users/vasilisp/followers","following_url":"https://api.github.com/users/vasilisp/following{/other_user}","gists_url":"https://api.github.com/users/vasilisp/gists{/gist_id}","starred_url":"https://api.github.com/users/vasilisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasilisp/subscriptions","organizations_url":"https://api.github.com/users/vasilisp/orgs","repos_url":"https://api.github.com/users/vasilisp/repos","events_url":"https://api.github.com/users/vasilisp/events{/privacy}","received_events_url":"https://api.github.com/users/vasilisp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-02T11:28:38Z","updated_at":"2015-12-02T16:34:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ocsigen/eliom/pulls/215","html_url":"https://github.com/ocsigen/eliom/pull/215","diff_url":"https://github.com/ocsigen/eliom/pull/215.diff","patch_url":"https://github.com/ocsigen/eliom/pull/215.patch"},"body":"This PR re-structures our form APIs. This is a breaking change.\r\n\r\nThe form APIs are now available under `Eliom_content.Html5.{D,F}.Form`. `a` and related functions have not moved.\r\n\r\nThe functions `${t}_${formtype}` (e.g., `int_input`) have been replaced by `${formtype}` functions with an additional \"GADT\" argument denoting the type. Internally, this is implemented with `Eliom_parameter_base.atom`. The conversion is almost mechanical; see ocsigen/eliom-base-app@ae247f1d2a210bef5d4b85cb2e6b5c62596f62a6.\r\n\r\nThe `user_type_*` functions have gone away. I don't think they are used all that much, and we probably need to re-implement them in a safe fashion anyway.\r\n\r\n`Eliom_form` has been simplified internally and merged with `Eliom_mkforms`."},"comment":{"url":"https://api.github.com/repos/ocsigen/eliom/issues/comments/161357310","html_url":"https://github.com/ocsigen/eliom/pull/215#issuecomment-161357310","issue_url":"https://api.github.com/repos/ocsigen/eliom/issues/215","id":161357310,"user":{"login":"vasilisp","id":4950946,"avatar_url":"https://avatars.githubusercontent.com/u/4950946?v=3","gravatar_id":"","url":"https://api.github.com/users/vasilisp","html_url":"https://github.com/vasilisp","followers_url":"https://api.github.com/users/vasilisp/followers","following_url":"https://api.github.com/users/vasilisp/following{/other_user}","gists_url":"https://api.github.com/users/vasilisp/gists{/gist_id}","starred_url":"https://api.github.com/users/vasilisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vasilisp/subscriptions","organizations_url":"https://api.github.com/users/vasilisp/orgs","repos_url":"https://api.github.com/users/vasilisp/repos","events_url":"https://api.github.com/users/vasilisp/events{/privacy}","received_events_url":"https://api.github.com/users/vasilisp/received_events","type":"User","site_admin":false},"created_at":"2015-12-02T16:34:58Z","updated_at":"2015-12-02T16:34:58Z","body":"Roughly speaking, we would need to re-add the functions removed by 41d3969 and 4f7688d as a separate functor, and instantiate it to produce the old API.\r\n\r\nBut to be honest, I think we should feel free to break backwards compatibility when this simplifies the APIs and the internals :). The userbase is not that huge, and temporarily maintaining the deprecated APIs adds overhead to the (needed) Eliom cleanup/simplification process."}}