{"action":"created","issue":{"url":"https://api.github.com/repos/weaveworks/weave/issues/655","labels_url":"https://api.github.com/repos/weaveworks/weave/issues/655/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/weave/issues/655/comments","events_url":"https://api.github.com/repos/weaveworks/weave/issues/655/events","html_url":"https://github.com/weaveworks/weave/pull/655","id":75988936,"number":655,"title":"Minimal implementation of the proxy","user":{"login":"paulbellamy","id":250199,"avatar_url":"https://avatars.githubusercontent.com/u/250199?v=3","gravatar_id":"","url":"https://api.github.com/users/paulbellamy","html_url":"https://github.com/paulbellamy","followers_url":"https://api.github.com/users/paulbellamy/followers","following_url":"https://api.github.com/users/paulbellamy/following{/other_user}","gists_url":"https://api.github.com/users/paulbellamy/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbellamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbellamy/subscriptions","organizations_url":"https://api.github.com/users/paulbellamy/orgs","repos_url":"https://api.github.com/users/paulbellamy/repos","events_url":"https://api.github.com/users/paulbellamy/events{/privacy}","received_events_url":"https://api.github.com/users/paulbellamy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"paulbellamy","id":250199,"avatar_url":"https://avatars.githubusercontent.com/u/250199?v=3","gravatar_id":"","url":"https://api.github.com/users/paulbellamy","html_url":"https://github.com/paulbellamy","followers_url":"https://api.github.com/users/paulbellamy/followers","following_url":"https://api.github.com/users/paulbellamy/following{/other_user}","gists_url":"https://api.github.com/users/paulbellamy/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbellamy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbellamy/subscriptions","organizations_url":"https://api.github.com/users/paulbellamy/orgs","repos_url":"https://api.github.com/users/paulbellamy/repos","events_url":"https://api.github.com/users/paulbellamy/events{/privacy}","received_events_url":"https://api.github.com/users/paulbellamy/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/weaveworks/weave/milestones/4","html_url":"https://github.com/weaveworks/weave/milestones/0.11.0","labels_url":"https://api.github.com/repos/weaveworks/weave/milestones/4/labels","id":1106531,"number":4,"title":"0.11.0","description":"","creator":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":62,"state":"open","created_at":"2015-05-12T11:25:24Z","updated_at":"2015-05-18T13:44:46Z","due_on":null,"closed_at":null},"comments":32,"created_at":"2015-05-13T13:43:17Z","updated_at":"2015-05-18T13:49:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/655","html_url":"https://github.com/weaveworks/weave/pull/655","diff_url":"https://github.com/weaveworks/weave/pull/655.diff","patch_url":"https://github.com/weaveworks/weave/pull/655.patch"},"body":"Supersedes #652 \r\n\r\nThis adds a docker remote API proxy to the weaveexec image. The proxy is NOT\r\nauto-launched when running a container with weave cli. Nor is it used at all by the weave CLI script.\r\nIt is merely provided/documented as a beta feature, so that we can gauge feedback.\r\n\r\nThe proxy currently has hooks for:\r\n\r\n Hook | Action\r\n ---- | ------\r\nPre Container Create   | Adjusts the entrypoint of a container to wait for the ethwe interface. \r\nPost Container Start         | Attaches a weave interface to a container given a WEAVE_CIDR environment entry. "},"comment":{"url":"https://api.github.com/repos/weaveworks/weave/issues/comments/103066576","html_url":"https://github.com/weaveworks/weave/pull/655#issuecomment-103066576","issue_url":"https://api.github.com/repos/weaveworks/weave/issues/655","id":103066576,"user":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"created_at":"2015-05-18T13:49:52Z","updated_at":"2015-05-18T13:49:52Z","body":"On reflection, I think it's a bit of a stretch to claim that this solves ##117. So let's leave that one open. I have split off the \"dynamically attached\" part of #400 into #688.\r\n\r\nSo, in summary, this PR should close #47,#230,#251,#400.\r\n\r\nThings left to do here:\r\n\r\n- [ ] make sure stream proxying correctly handles half-closed connections\r\n- [ ] add a smoke test for re-attachement on `docker restart`, including DNS re-population"}}