{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/fogfish/cache/pulls/7","id":27608466,"html_url":"https://github.com/fogfish/cache/pull/7","diff_url":"https://github.com/fogfish/cache/pull/7.diff","patch_url":"https://github.com/fogfish/cache/pull/7.patch","issue_url":"https://api.github.com/repos/fogfish/cache/issues/7","number":7,"state":"closed","locked":false,"title":"fix: bucket eviction check was executed 1000 times more often than required","user":{"login":"Zephyrean","id":3918007,"avatar_url":"https://avatars.githubusercontent.com/u/3918007?v=3","gravatar_id":"","url":"https://api.github.com/users/Zephyrean","html_url":"https://github.com/Zephyrean","followers_url":"https://api.github.com/users/Zephyrean/followers","following_url":"https://api.github.com/users/Zephyrean/following{/other_user}","gists_url":"https://api.github.com/users/Zephyrean/gists{/gist_id}","starred_url":"https://api.github.com/users/Zephyrean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zephyrean/subscriptions","organizations_url":"https://api.github.com/users/Zephyrean/orgs","repos_url":"https://api.github.com/users/Zephyrean/repos","events_url":"https://api.github.com/users/Zephyrean/events{/privacy}","received_events_url":"https://api.github.com/users/Zephyrean/received_events","type":"User","site_admin":false},"body":"Seconds instead of milliseconds were passed to erlang:send_after.\r\nThere are two identical functions that check buckets: check_heap and evict_heap. Seems like evict should be enough to do the job, why use another check at different intervals?","created_at":"2015-01-19T14:01:04Z","updated_at":"2015-01-24T21:08:28Z","closed_at":"2015-01-24T21:08:28Z","merged_at":"2015-01-24T21:08:28Z","merge_commit_sha":"9daac522bcf58156e53db8aa6f4f0ae3dd0a0e4f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fogfish/cache/pulls/7/commits","review_comments_url":"https://api.github.com/repos/fogfish/cache/pulls/7/comments","review_comment_url":"https://api.github.com/repos/fogfish/cache/pulls/comments/{number}","comments_url":"https://api.github.com/repos/fogfish/cache/issues/7/comments","statuses_url":"https://api.github.com/repos/fogfish/cache/statuses/e275a9fd77796a83faff337fd3be477f5092dcd1","head":{"label":"Zephyrean:master","ref":"master","sha":"e275a9fd77796a83faff337fd3be477f5092dcd1","user":{"login":"Zephyrean","id":3918007,"avatar_url":"https://avatars.githubusercontent.com/u/3918007?v=3","gravatar_id":"","url":"https://api.github.com/users/Zephyrean","html_url":"https://github.com/Zephyrean","followers_url":"https://api.github.com/users/Zephyrean/followers","following_url":"https://api.github.com/users/Zephyrean/following{/other_user}","gists_url":"https://api.github.com/users/Zephyrean/gists{/gist_id}","starred_url":"https://api.github.com/users/Zephyrean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zephyrean/subscriptions","organizations_url":"https://api.github.com/users/Zephyrean/orgs","repos_url":"https://api.github.com/users/Zephyrean/repos","events_url":"https://api.github.com/users/Zephyrean/events{/privacy}","received_events_url":"https://api.github.com/users/Zephyrean/received_events","type":"User","site_admin":false},"repo":{"id":29472903,"name":"cache","full_name":"Zephyrean/cache","owner":{"login":"Zephyrean","id":3918007,"avatar_url":"https://avatars.githubusercontent.com/u/3918007?v=3","gravatar_id":"","url":"https://api.github.com/users/Zephyrean","html_url":"https://github.com/Zephyrean","followers_url":"https://api.github.com/users/Zephyrean/followers","following_url":"https://api.github.com/users/Zephyrean/following{/other_user}","gists_url":"https://api.github.com/users/Zephyrean/gists{/gist_id}","starred_url":"https://api.github.com/users/Zephyrean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zephyrean/subscriptions","organizations_url":"https://api.github.com/users/Zephyrean/orgs","repos_url":"https://api.github.com/users/Zephyrean/repos","events_url":"https://api.github.com/users/Zephyrean/events{/privacy}","received_events_url":"https://api.github.com/users/Zephyrean/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zephyrean/cache","description":"Erlang in-memory cache","fork":true,"url":"https://api.github.com/repos/Zephyrean/cache","forks_url":"https://api.github.com/repos/Zephyrean/cache/forks","keys_url":"https://api.github.com/repos/Zephyrean/cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zephyrean/cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zephyrean/cache/teams","hooks_url":"https://api.github.com/repos/Zephyrean/cache/hooks","issue_events_url":"https://api.github.com/repos/Zephyrean/cache/issues/events{/number}","events_url":"https://api.github.com/repos/Zephyrean/cache/events","assignees_url":"https://api.github.com/repos/Zephyrean/cache/assignees{/user}","branches_url":"https://api.github.com/repos/Zephyrean/cache/branches{/branch}","tags_url":"https://api.github.com/repos/Zephyrean/cache/tags","blobs_url":"https://api.github.com/repos/Zephyrean/cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zephyrean/cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zephyrean/cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zephyrean/cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zephyrean/cache/statuses/{sha}","languages_url":"https://api.github.com/repos/Zephyrean/cache/languages","stargazers_url":"https://api.github.com/repos/Zephyrean/cache/stargazers","contributors_url":"https://api.github.com/repos/Zephyrean/cache/contributors","subscribers_url":"https://api.github.com/repos/Zephyrean/cache/subscribers","subscription_url":"https://api.github.com/repos/Zephyrean/cache/subscription","commits_url":"https://api.github.com/repos/Zephyrean/cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zephyrean/cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zephyrean/cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zephyrean/cache/issues/comments/{number}","contents_url":"https://api.github.com/repos/Zephyrean/cache/contents/{+path}","compare_url":"https://api.github.com/repos/Zephyrean/cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zephyrean/cache/merges","archive_url":"https://api.github.com/repos/Zephyrean/cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zephyrean/cache/downloads","issues_url":"https://api.github.com/repos/Zephyrean/cache/issues{/number}","pulls_url":"https://api.github.com/repos/Zephyrean/cache/pulls{/number}","milestones_url":"https://api.github.com/repos/Zephyrean/cache/milestones{/number}","notifications_url":"https://api.github.com/repos/Zephyrean/cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zephyrean/cache/labels{/name}","releases_url":"https://api.github.com/repos/Zephyrean/cache/releases{/id}","created_at":"2015-01-19T13:48:19Z","updated_at":"2015-01-19T13:55:42Z","pushed_at":"2015-01-19T13:55:42Z","git_url":"git://github.com/Zephyrean/cache.git","ssh_url":"git@github.com:Zephyrean/cache.git","clone_url":"https://github.com/Zephyrean/cache.git","svn_url":"https://github.com/Zephyrean/cache","homepage":null,"size":489,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fogfish:master","ref":"master","sha":"9a4ec485955f0a2cd9d346eed650ae552516aacc","user":{"login":"fogfish","id":716093,"avatar_url":"https://avatars.githubusercontent.com/u/716093?v=3","gravatar_id":"","url":"https://api.github.com/users/fogfish","html_url":"https://github.com/fogfish","followers_url":"https://api.github.com/users/fogfish/followers","following_url":"https://api.github.com/users/fogfish/following{/other_user}","gists_url":"https://api.github.com/users/fogfish/gists{/gist_id}","starred_url":"https://api.github.com/users/fogfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fogfish/subscriptions","organizations_url":"https://api.github.com/users/fogfish/orgs","repos_url":"https://api.github.com/users/fogfish/repos","events_url":"https://api.github.com/users/fogfish/events{/privacy}","received_events_url":"https://api.github.com/users/fogfish/received_events","type":"User","site_admin":false},"repo":{"id":6421316,"name":"cache","full_name":"fogfish/cache","owner":{"login":"fogfish","id":716093,"avatar_url":"https://avatars.githubusercontent.com/u/716093?v=3","gravatar_id":"","url":"https://api.github.com/users/fogfish","html_url":"https://github.com/fogfish","followers_url":"https://api.github.com/users/fogfish/followers","following_url":"https://api.github.com/users/fogfish/following{/other_user}","gists_url":"https://api.github.com/users/fogfish/gists{/gist_id}","starred_url":"https://api.github.com/users/fogfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fogfish/subscriptions","organizations_url":"https://api.github.com/users/fogfish/orgs","repos_url":"https://api.github.com/users/fogfish/repos","events_url":"https://api.github.com/users/fogfish/events{/privacy}","received_events_url":"https://api.github.com/users/fogfish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fogfish/cache","description":"Erlang in-memory cache","fork":false,"url":"https://api.github.com/repos/fogfish/cache","forks_url":"https://api.github.com/repos/fogfish/cache/forks","keys_url":"https://api.github.com/repos/fogfish/cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fogfish/cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fogfish/cache/teams","hooks_url":"https://api.github.com/repos/fogfish/cache/hooks","issue_events_url":"https://api.github.com/repos/fogfish/cache/issues/events{/number}","events_url":"https://api.github.com/repos/fogfish/cache/events","assignees_url":"https://api.github.com/repos/fogfish/cache/assignees{/user}","branches_url":"https://api.github.com/repos/fogfish/cache/branches{/branch}","tags_url":"https://api.github.com/repos/fogfish/cache/tags","blobs_url":"https://api.github.com/repos/fogfish/cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fogfish/cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fogfish/cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/fogfish/cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fogfish/cache/statuses/{sha}","languages_url":"https://api.github.com/repos/fogfish/cache/languages","stargazers_url":"https://api.github.com/repos/fogfish/cache/stargazers","contributors_url":"https://api.github.com/repos/fogfish/cache/contributors","subscribers_url":"https://api.github.com/repos/fogfish/cache/subscribers","subscription_url":"https://api.github.com/repos/fogfish/cache/subscription","commits_url":"https://api.github.com/repos/fogfish/cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/fogfish/cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/fogfish/cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/fogfish/cache/issues/comments/{number}","contents_url":"https://api.github.com/repos/fogfish/cache/contents/{+path}","compare_url":"https://api.github.com/repos/fogfish/cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fogfish/cache/merges","archive_url":"https://api.github.com/repos/fogfish/cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fogfish/cache/downloads","issues_url":"https://api.github.com/repos/fogfish/cache/issues{/number}","pulls_url":"https://api.github.com/repos/fogfish/cache/pulls{/number}","milestones_url":"https://api.github.com/repos/fogfish/cache/milestones{/number}","notifications_url":"https://api.github.com/repos/fogfish/cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fogfish/cache/labels{/name}","releases_url":"https://api.github.com/repos/fogfish/cache/releases{/id}","created_at":"2012-10-27T20:42:13Z","updated_at":"2015-01-13T15:10:26Z","pushed_at":"2015-01-24T21:08:28Z","git_url":"git://github.com/fogfish/cache.git","ssh_url":"git@github.com:fogfish/cache.git","clone_url":"https://github.com/fogfish/cache.git","svn_url":"https://github.com/fogfish/cache","homepage":null,"size":489,"stargazers_count":19,"watchers_count":19,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":0,"forks":12,"open_issues":0,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fogfish/cache/pulls/7"},"html":{"href":"https://github.com/fogfish/cache/pull/7"},"issue":{"href":"https://api.github.com/repos/fogfish/cache/issues/7"},"comments":{"href":"https://api.github.com/repos/fogfish/cache/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/fogfish/cache/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/fogfish/cache/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/fogfish/cache/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/fogfish/cache/statuses/e275a9fd77796a83faff337fd3be477f5092dcd1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fogfish","id":716093,"avatar_url":"https://avatars.githubusercontent.com/u/716093?v=3","gravatar_id":"","url":"https://api.github.com/users/fogfish","html_url":"https://github.com/fogfish","followers_url":"https://api.github.com/users/fogfish/followers","following_url":"https://api.github.com/users/fogfish/following{/other_user}","gists_url":"https://api.github.com/users/fogfish/gists{/gist_id}","starred_url":"https://api.github.com/users/fogfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fogfish/subscriptions","organizations_url":"https://api.github.com/users/fogfish/orgs","repos_url":"https://api.github.com/users/fogfish/repos","events_url":"https://api.github.com/users/fogfish/events{/privacy}","received_events_url":"https://api.github.com/users/fogfish/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}