{"action":"opened","number":161,"pull_request":{"url":"https://api.github.com/repos/go-kit/kit/pulls/161","id":52818904,"html_url":"https://github.com/go-kit/kit/pull/161","diff_url":"https://github.com/go-kit/kit/pull/161.diff","patch_url":"https://github.com/go-kit/kit/pull/161.patch","issue_url":"https://api.github.com/repos/go-kit/kit/issues/161","number":161,"state":"open","locked":false,"title":"Kafka zipkin collector","user":{"login":"acrmp","id":444264,"avatar_url":"https://avatars.githubusercontent.com/u/444264?v=3","gravatar_id":"","url":"https://api.github.com/users/acrmp","html_url":"https://github.com/acrmp","followers_url":"https://api.github.com/users/acrmp/followers","following_url":"https://api.github.com/users/acrmp/following{/other_user}","gists_url":"https://api.github.com/users/acrmp/gists{/gist_id}","starred_url":"https://api.github.com/users/acrmp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrmp/subscriptions","organizations_url":"https://api.github.com/users/acrmp/orgs","repos_url":"https://api.github.com/users/acrmp/repos","events_url":"https://api.github.com/users/acrmp/events{/privacy}","received_events_url":"https://api.github.com/users/acrmp/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI had a play recently with adding a Zipkin trace collector for Kafka, as [Scribe is deprecated](http://zipkin.io/Architecture.html#transport).\r\n\r\nIt would introduce a dependency on [Sarama](https://github.com/Shopify/sarama).\r\n\r\nA couple of further considerations:\r\n\r\n* Sarama requires you to call `Close()` to avoid leaks - I'm not sure if similar cleanup is performed for the existing scribe collector. How would you incorporate this?\r\n* The options for the producer need some attention - we probably don't want to expose the raw producer. What do we want to expose here?\r\n\r\nThanks,\r\n\r\nAndrew.","created_at":"2015-12-07T08:59:04Z","updated_at":"2015-12-07T08:59:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/go-kit/kit/pulls/161/commits","review_comments_url":"https://api.github.com/repos/go-kit/kit/pulls/161/comments","review_comment_url":"https://api.github.com/repos/go-kit/kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-kit/kit/issues/161/comments","statuses_url":"https://api.github.com/repos/go-kit/kit/statuses/11a0db8cb47497b153ef094088d6982c53c354da","head":{"label":"acrmp:kafka-collector","ref":"kafka-collector","sha":"11a0db8cb47497b153ef094088d6982c53c354da","user":{"login":"acrmp","id":444264,"avatar_url":"https://avatars.githubusercontent.com/u/444264?v=3","gravatar_id":"","url":"https://api.github.com/users/acrmp","html_url":"https://github.com/acrmp","followers_url":"https://api.github.com/users/acrmp/followers","following_url":"https://api.github.com/users/acrmp/following{/other_user}","gists_url":"https://api.github.com/users/acrmp/gists{/gist_id}","starred_url":"https://api.github.com/users/acrmp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrmp/subscriptions","organizations_url":"https://api.github.com/users/acrmp/orgs","repos_url":"https://api.github.com/users/acrmp/repos","events_url":"https://api.github.com/users/acrmp/events{/privacy}","received_events_url":"https://api.github.com/users/acrmp/received_events","type":"User","site_admin":false},"repo":{"id":47444058,"name":"kit","full_name":"acrmp/kit","owner":{"login":"acrmp","id":444264,"avatar_url":"https://avatars.githubusercontent.com/u/444264?v=3","gravatar_id":"","url":"https://api.github.com/users/acrmp","html_url":"https://github.com/acrmp","followers_url":"https://api.github.com/users/acrmp/followers","following_url":"https://api.github.com/users/acrmp/following{/other_user}","gists_url":"https://api.github.com/users/acrmp/gists{/gist_id}","starred_url":"https://api.github.com/users/acrmp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrmp/subscriptions","organizations_url":"https://api.github.com/users/acrmp/orgs","repos_url":"https://api.github.com/users/acrmp/repos","events_url":"https://api.github.com/users/acrmp/events{/privacy}","received_events_url":"https://api.github.com/users/acrmp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/acrmp/kit","description":"A standard library for microservices.","fork":true,"url":"https://api.github.com/repos/acrmp/kit","forks_url":"https://api.github.com/repos/acrmp/kit/forks","keys_url":"https://api.github.com/repos/acrmp/kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acrmp/kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acrmp/kit/teams","hooks_url":"https://api.github.com/repos/acrmp/kit/hooks","issue_events_url":"https://api.github.com/repos/acrmp/kit/issues/events{/number}","events_url":"https://api.github.com/repos/acrmp/kit/events","assignees_url":"https://api.github.com/repos/acrmp/kit/assignees{/user}","branches_url":"https://api.github.com/repos/acrmp/kit/branches{/branch}","tags_url":"https://api.github.com/repos/acrmp/kit/tags","blobs_url":"https://api.github.com/repos/acrmp/kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acrmp/kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acrmp/kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/acrmp/kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acrmp/kit/statuses/{sha}","languages_url":"https://api.github.com/repos/acrmp/kit/languages","stargazers_url":"https://api.github.com/repos/acrmp/kit/stargazers","contributors_url":"https://api.github.com/repos/acrmp/kit/contributors","subscribers_url":"https://api.github.com/repos/acrmp/kit/subscribers","subscription_url":"https://api.github.com/repos/acrmp/kit/subscription","commits_url":"https://api.github.com/repos/acrmp/kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/acrmp/kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/acrmp/kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/acrmp/kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/acrmp/kit/contents/{+path}","compare_url":"https://api.github.com/repos/acrmp/kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acrmp/kit/merges","archive_url":"https://api.github.com/repos/acrmp/kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acrmp/kit/downloads","issues_url":"https://api.github.com/repos/acrmp/kit/issues{/number}","pulls_url":"https://api.github.com/repos/acrmp/kit/pulls{/number}","milestones_url":"https://api.github.com/repos/acrmp/kit/milestones{/number}","notifications_url":"https://api.github.com/repos/acrmp/kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acrmp/kit/labels{/name}","releases_url":"https://api.github.com/repos/acrmp/kit/releases{/id}","created_at":"2015-12-05T05:39:58Z","updated_at":"2015-12-05T05:39:58Z","pushed_at":"2015-12-05T05:41:58Z","git_url":"git://github.com/acrmp/kit.git","ssh_url":"git@github.com:acrmp/kit.git","clone_url":"https://github.com/acrmp/kit.git","svn_url":"https://github.com/acrmp/kit","homepage":"http://gokit.io","size":4443,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"kafka-collector"}},"base":{"label":"go-kit:master","ref":"master","sha":"0733761a4c3525bdfedab1727cf92b645be29df7","user":{"login":"go-kit","id":10981023,"avatar_url":"https://avatars.githubusercontent.com/u/10981023?v=3","gravatar_id":"","url":"https://api.github.com/users/go-kit","html_url":"https://github.com/go-kit","followers_url":"https://api.github.com/users/go-kit/followers","following_url":"https://api.github.com/users/go-kit/following{/other_user}","gists_url":"https://api.github.com/users/go-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/go-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-kit/subscriptions","organizations_url":"https://api.github.com/users/go-kit/orgs","repos_url":"https://api.github.com/users/go-kit/repos","events_url":"https://api.github.com/users/go-kit/events{/privacy}","received_events_url":"https://api.github.com/users/go-kit/received_events","type":"Organization","site_admin":false},"repo":{"id":30215630,"name":"kit","full_name":"go-kit/kit","owner":{"login":"go-kit","id":10981023,"avatar_url":"https://avatars.githubusercontent.com/u/10981023?v=3","gravatar_id":"","url":"https://api.github.com/users/go-kit","html_url":"https://github.com/go-kit","followers_url":"https://api.github.com/users/go-kit/followers","following_url":"https://api.github.com/users/go-kit/following{/other_user}","gists_url":"https://api.github.com/users/go-kit/gists{/gist_id}","starred_url":"https://api.github.com/users/go-kit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-kit/subscriptions","organizations_url":"https://api.github.com/users/go-kit/orgs","repos_url":"https://api.github.com/users/go-kit/repos","events_url":"https://api.github.com/users/go-kit/events{/privacy}","received_events_url":"https://api.github.com/users/go-kit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-kit/kit","description":"A standard library for microservices.","fork":false,"url":"https://api.github.com/repos/go-kit/kit","forks_url":"https://api.github.com/repos/go-kit/kit/forks","keys_url":"https://api.github.com/repos/go-kit/kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-kit/kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-kit/kit/teams","hooks_url":"https://api.github.com/repos/go-kit/kit/hooks","issue_events_url":"https://api.github.com/repos/go-kit/kit/issues/events{/number}","events_url":"https://api.github.com/repos/go-kit/kit/events","assignees_url":"https://api.github.com/repos/go-kit/kit/assignees{/user}","branches_url":"https://api.github.com/repos/go-kit/kit/branches{/branch}","tags_url":"https://api.github.com/repos/go-kit/kit/tags","blobs_url":"https://api.github.com/repos/go-kit/kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-kit/kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-kit/kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-kit/kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-kit/kit/statuses/{sha}","languages_url":"https://api.github.com/repos/go-kit/kit/languages","stargazers_url":"https://api.github.com/repos/go-kit/kit/stargazers","contributors_url":"https://api.github.com/repos/go-kit/kit/contributors","subscribers_url":"https://api.github.com/repos/go-kit/kit/subscribers","subscription_url":"https://api.github.com/repos/go-kit/kit/subscription","commits_url":"https://api.github.com/repos/go-kit/kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-kit/kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-kit/kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-kit/kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-kit/kit/contents/{+path}","compare_url":"https://api.github.com/repos/go-kit/kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-kit/kit/merges","archive_url":"https://api.github.com/repos/go-kit/kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-kit/kit/downloads","issues_url":"https://api.github.com/repos/go-kit/kit/issues{/number}","pulls_url":"https://api.github.com/repos/go-kit/kit/pulls{/number}","milestones_url":"https://api.github.com/repos/go-kit/kit/milestones{/number}","notifications_url":"https://api.github.com/repos/go-kit/kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-kit/kit/labels{/name}","releases_url":"https://api.github.com/repos/go-kit/kit/releases{/id}","created_at":"2015-02-03T00:01:19Z","updated_at":"2015-12-06T22:11:58Z","pushed_at":"2015-12-06T17:15:32Z","git_url":"git://github.com/go-kit/kit.git","ssh_url":"git@github.com:go-kit/kit.git","clone_url":"https://github.com/go-kit/kit.git","svn_url":"https://github.com/go-kit/kit","homepage":"http://gokit.io","size":7375,"stargazers_count":2661,"watchers_count":2661,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":177,"mirror_url":null,"open_issues_count":12,"forks":177,"open_issues":12,"watchers":2661,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-kit/kit/pulls/161"},"html":{"href":"https://github.com/go-kit/kit/pull/161"},"issue":{"href":"https://api.github.com/repos/go-kit/kit/issues/161"},"comments":{"href":"https://api.github.com/repos/go-kit/kit/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/go-kit/kit/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/go-kit/kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-kit/kit/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/go-kit/kit/statuses/11a0db8cb47497b153ef094088d6982c53c354da"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":233,"deletions":0,"changed_files":2}}