{"action":"closed","number":243,"pull_request":{"url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/pulls/243","id":41167518,"html_url":"https://github.com/rabbitmq/rabbitmq-server/pull/243","diff_url":"https://github.com/rabbitmq/rabbitmq-server/pull/243.diff","patch_url":"https://github.com/rabbitmq/rabbitmq-server/pull/243.patch","issue_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/issues/243","number":243,"state":"closed","locked":false,"title":" Fixes a logic problem with NODE_IP_ADDRESS and NODE_PORT in rabbitmq-env.bat.","user":{"login":"Jakauppila","id":4100127,"avatar_url":"https://avatars.githubusercontent.com/u/4100127?v=3","gravatar_id":"","url":"https://api.github.com/users/Jakauppila","html_url":"https://github.com/Jakauppila","followers_url":"https://api.github.com/users/Jakauppila/followers","following_url":"https://api.github.com/users/Jakauppila/following{/other_user}","gists_url":"https://api.github.com/users/Jakauppila/gists{/gist_id}","starred_url":"https://api.github.com/users/Jakauppila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jakauppila/subscriptions","organizations_url":"https://api.github.com/users/Jakauppila/orgs","repos_url":"https://api.github.com/users/Jakauppila/repos","events_url":"https://api.github.com/users/Jakauppila/events{/privacy}","received_events_url":"https://api.github.com/users/Jakauppila/received_events","type":"User","site_admin":false},"body":"Fixes the logic for NODE_IP_ADDRESS and NODE_PORT. First, check for the existence of the environment variable, then the definition if set via conf file, then proceed with the original logic on setting the IP/Port variables.\r\n\r\nAs it was configured, RABBITMQ_LISTEN_ARG was not getting configured properly as it was before.","created_at":"2015-07-29T20:22:14Z","updated_at":"2015-07-29T20:24:00Z","closed_at":"2015-07-29T20:23:59Z","merged_at":"2015-07-29T20:23:59Z","merge_commit_sha":"698303b9380d2d1d0747d58b65be29bc8e8b3b4f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/pulls/243/commits","review_comments_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/pulls/243/comments","review_comment_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/issues/243/comments","statuses_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/statuses/1f61e4fae109561572beca3f0ddc9c7624622126","head":{"label":"Jakauppila:rabbitmq-server-243","ref":"rabbitmq-server-243","sha":"1f61e4fae109561572beca3f0ddc9c7624622126","user":{"login":"Jakauppila","id":4100127,"avatar_url":"https://avatars.githubusercontent.com/u/4100127?v=3","gravatar_id":"","url":"https://api.github.com/users/Jakauppila","html_url":"https://github.com/Jakauppila","followers_url":"https://api.github.com/users/Jakauppila/followers","following_url":"https://api.github.com/users/Jakauppila/following{/other_user}","gists_url":"https://api.github.com/users/Jakauppila/gists{/gist_id}","starred_url":"https://api.github.com/users/Jakauppila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jakauppila/subscriptions","organizations_url":"https://api.github.com/users/Jakauppila/orgs","repos_url":"https://api.github.com/users/Jakauppila/repos","events_url":"https://api.github.com/users/Jakauppila/events{/privacy}","received_events_url":"https://api.github.com/users/Jakauppila/received_events","type":"User","site_admin":false},"repo":{"id":39904246,"name":"rabbitmq-server","full_name":"Jakauppila/rabbitmq-server","owner":{"login":"Jakauppila","id":4100127,"avatar_url":"https://avatars.githubusercontent.com/u/4100127?v=3","gravatar_id":"","url":"https://api.github.com/users/Jakauppila","html_url":"https://github.com/Jakauppila","followers_url":"https://api.github.com/users/Jakauppila/followers","following_url":"https://api.github.com/users/Jakauppila/following{/other_user}","gists_url":"https://api.github.com/users/Jakauppila/gists{/gist_id}","starred_url":"https://api.github.com/users/Jakauppila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jakauppila/subscriptions","organizations_url":"https://api.github.com/users/Jakauppila/orgs","repos_url":"https://api.github.com/users/Jakauppila/repos","events_url":"https://api.github.com/users/Jakauppila/events{/privacy}","received_events_url":"https://api.github.com/users/Jakauppila/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jakauppila/rabbitmq-server","description":"RabbitMQ Server","fork":true,"url":"https://api.github.com/repos/Jakauppila/rabbitmq-server","forks_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/forks","keys_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/teams","hooks_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/hooks","issue_events_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/issues/events{/number}","events_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/events","assignees_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/assignees{/user}","branches_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/branches{/branch}","tags_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/tags","blobs_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/statuses/{sha}","languages_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/languages","stargazers_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/stargazers","contributors_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/contributors","subscribers_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/subscribers","subscription_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/subscription","commits_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/contents/{+path}","compare_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/merges","archive_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/downloads","issues_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/issues{/number}","pulls_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/pulls{/number}","milestones_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/milestones{/number}","notifications_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/labels{/name}","releases_url":"https://api.github.com/repos/Jakauppila/rabbitmq-server/releases{/id}","created_at":"2015-07-29T16:32:02Z","updated_at":"2015-07-29T16:32:06Z","pushed_at":"2015-07-29T20:21:01Z","git_url":"git://github.com/Jakauppila/rabbitmq-server.git","ssh_url":"git@github.com:Jakauppila/rabbitmq-server.git","clone_url":"https://github.com/Jakauppila/rabbitmq-server.git","svn_url":"https://github.com/Jakauppila/rabbitmq-server","homepage":"https://www.rabbitmq.com/","size":104422,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rabbitmq:stable","ref":"stable","sha":"28499dd69a17763bec2b83c9bc77b9ffc85b997e","user":{"login":"rabbitmq","id":96669,"avatar_url":"https://avatars.githubusercontent.com/u/96669?v=3","gravatar_id":"","url":"https://api.github.com/users/rabbitmq","html_url":"https://github.com/rabbitmq","followers_url":"https://api.github.com/users/rabbitmq/followers","following_url":"https://api.github.com/users/rabbitmq/following{/other_user}","gists_url":"https://api.github.com/users/rabbitmq/gists{/gist_id}","starred_url":"https://api.github.com/users/rabbitmq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabbitmq/subscriptions","organizations_url":"https://api.github.com/users/rabbitmq/orgs","repos_url":"https://api.github.com/users/rabbitmq/repos","events_url":"https://api.github.com/users/rabbitmq/events{/privacy}","received_events_url":"https://api.github.com/users/rabbitmq/received_events","type":"Organization","site_admin":false},"repo":{"id":924551,"name":"rabbitmq-server","full_name":"rabbitmq/rabbitmq-server","owner":{"login":"rabbitmq","id":96669,"avatar_url":"https://avatars.githubusercontent.com/u/96669?v=3","gravatar_id":"","url":"https://api.github.com/users/rabbitmq","html_url":"https://github.com/rabbitmq","followers_url":"https://api.github.com/users/rabbitmq/followers","following_url":"https://api.github.com/users/rabbitmq/following{/other_user}","gists_url":"https://api.github.com/users/rabbitmq/gists{/gist_id}","starred_url":"https://api.github.com/users/rabbitmq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabbitmq/subscriptions","organizations_url":"https://api.github.com/users/rabbitmq/orgs","repos_url":"https://api.github.com/users/rabbitmq/repos","events_url":"https://api.github.com/users/rabbitmq/events{/privacy}","received_events_url":"https://api.github.com/users/rabbitmq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rabbitmq/rabbitmq-server","description":"RabbitMQ Server","fork":false,"url":"https://api.github.com/repos/rabbitmq/rabbitmq-server","forks_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/forks","keys_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/teams","hooks_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/hooks","issue_events_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/issues/events{/number}","events_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/events","assignees_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/assignees{/user}","branches_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/branches{/branch}","tags_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/tags","blobs_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/statuses/{sha}","languages_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/languages","stargazers_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/stargazers","contributors_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/contributors","subscribers_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/subscribers","subscription_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/subscription","commits_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/contents/{+path}","compare_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/merges","archive_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/downloads","issues_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/issues{/number}","pulls_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/pulls{/number}","milestones_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/milestones{/number}","notifications_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/labels{/name}","releases_url":"https://api.github.com/repos/rabbitmq/rabbitmq-server/releases{/id}","created_at":"2010-09-20T10:29:16Z","updated_at":"2015-07-29T08:31:22Z","pushed_at":"2015-07-29T20:23:59Z","git_url":"git://github.com/rabbitmq/rabbitmq-server.git","ssh_url":"git@github.com:rabbitmq/rabbitmq-server.git","clone_url":"https://github.com/rabbitmq/rabbitmq-server.git","svn_url":"https://github.com/rabbitmq/rabbitmq-server","homepage":"https://www.rabbitmq.com/","size":104422,"stargazers_count":944,"watchers_count":944,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":234,"mirror_url":null,"open_issues_count":46,"forks":234,"open_issues":46,"watchers":944,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-server/pulls/243"},"html":{"href":"https://github.com/rabbitmq/rabbitmq-server/pull/243"},"issue":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-server/issues/243"},"comments":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-server/issues/243/comments"},"review_comments":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-server/pulls/243/comments"},"review_comment":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-server/pulls/243/commits"},"statuses":{"href":"https://api.github.com/repos/rabbitmq/rabbitmq-server/statuses/1f61e4fae109561572beca3f0ddc9c7624622126"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"michaelklishin","id":1090,"avatar_url":"https://avatars.githubusercontent.com/u/1090?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelklishin","html_url":"https://github.com/michaelklishin","followers_url":"https://api.github.com/users/michaelklishin/followers","following_url":"https://api.github.com/users/michaelklishin/following{/other_user}","gists_url":"https://api.github.com/users/michaelklishin/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelklishin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelklishin/subscriptions","organizations_url":"https://api.github.com/users/michaelklishin/orgs","repos_url":"https://api.github.com/users/michaelklishin/repos","events_url":"https://api.github.com/users/michaelklishin/events{/privacy}","received_events_url":"https://api.github.com/users/michaelklishin/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":7,"changed_files":1}}