{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/pulls/comments/27155191","id":27155191,"diff_hunk":"@@ -51,11 +51,33 @@ where `options` is a plain `Object` with any of the following:\n and `simulator` is an object containing:\n \n * `binary`: path to the simulator binary\n+* 'bin': an alias to `binary`","path":"README.md","position":4,"original_position":4,"commit_id":"e424b3e947a5eff380d4f4d4a6fb3932c37242a5","original_commit_id":"e424b3e947a5eff380d4f4d4a6fb3932c37242a5","user":{"login":"tofumatt","id":90871,"avatar_url":"https://avatars.githubusercontent.com/u/90871?v=3","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false},"body":"Should be `bin` not 'bin'","created_at":"2015-03-25T19:08:56Z","updated_at":"2015-03-25T19:08:56Z","html_url":"https://github.com/mozilla/node-firefox-start-simulator/pull/23#discussion_r27155191","pull_request_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/pulls/comments/27155191"},"html":{"href":"https://github.com/mozilla/node-firefox-start-simulator/pull/23#discussion_r27155191"},"pull_request":{"href":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/pulls/23","id":31955406,"html_url":"https://github.com/mozilla/node-firefox-start-simulator/pull/23","diff_url":"https://github.com/mozilla/node-firefox-start-simulator/pull/23.diff","patch_url":"https://github.com/mozilla/node-firefox-start-simulator/pull/23.patch","issue_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/issues/23","number":23,"state":"open","locked":false,"title":"startSimulator.all() utility to work better with findSimulators()","user":{"login":"lmorchard","id":21687,"avatar_url":"https://avatars.githubusercontent.com/u/21687?v=3","gravatar_id":"","url":"https://api.github.com/users/lmorchard","html_url":"https://github.com/lmorchard","followers_url":"https://api.github.com/users/lmorchard/followers","following_url":"https://api.github.com/users/lmorchard/following{/other_user}","gists_url":"https://api.github.com/users/lmorchard/gists{/gist_id}","starred_url":"https://api.github.com/users/lmorchard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmorchard/subscriptions","organizations_url":"https://api.github.com/users/lmorchard/orgs","repos_url":"https://api.github.com/users/lmorchard/repos","events_url":"https://api.github.com/users/lmorchard/events{/privacy}","received_events_url":"https://api.github.com/users/lmorchard/received_events","type":"User","site_admin":false},"body":"This enables simplified cooperation between `findSimulators()` and `startSimulator()` like so:\r\n```javascript\r\nfindSimulators().then(startSimulator.all({ detached: true }))\r\n```\r\nFor bonus points, I worked out how to test `startSimulator()` using mocks instead of launching external processes. I'll probably follow this PR up with refactorings to extend that approach to the other existing tests.","created_at":"2015-03-25T19:06:27Z","updated_at":"2015-03-25T19:08:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"865b696b61e327686fa0e989e3c4a0d82217ac57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/pulls/23/commits","review_comments_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/pulls/23/comments","review_comment_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/issues/23/comments","statuses_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/statuses/e424b3e947a5eff380d4f4d4a6fb3932c37242a5","head":{"label":"lmorchard:22-work-with-findsimulator","ref":"22-work-with-findsimulator","sha":"e424b3e947a5eff380d4f4d4a6fb3932c37242a5","user":{"login":"lmorchard","id":21687,"avatar_url":"https://avatars.githubusercontent.com/u/21687?v=3","gravatar_id":"","url":"https://api.github.com/users/lmorchard","html_url":"https://github.com/lmorchard","followers_url":"https://api.github.com/users/lmorchard/followers","following_url":"https://api.github.com/users/lmorchard/following{/other_user}","gists_url":"https://api.github.com/users/lmorchard/gists{/gist_id}","starred_url":"https://api.github.com/users/lmorchard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmorchard/subscriptions","organizations_url":"https://api.github.com/users/lmorchard/orgs","repos_url":"https://api.github.com/users/lmorchard/repos","events_url":"https://api.github.com/users/lmorchard/events{/privacy}","received_events_url":"https://api.github.com/users/lmorchard/received_events","type":"User","site_admin":false},"repo":{"id":29750176,"name":"node-firefox-start-simulator","full_name":"lmorchard/node-firefox-start-simulator","owner":{"login":"lmorchard","id":21687,"avatar_url":"https://avatars.githubusercontent.com/u/21687?v=3","gravatar_id":"","url":"https://api.github.com/users/lmorchard","html_url":"https://github.com/lmorchard","followers_url":"https://api.github.com/users/lmorchard/followers","following_url":"https://api.github.com/users/lmorchard/following{/other_user}","gists_url":"https://api.github.com/users/lmorchard/gists{/gist_id}","starred_url":"https://api.github.com/users/lmorchard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmorchard/subscriptions","organizations_url":"https://api.github.com/users/lmorchard/orgs","repos_url":"https://api.github.com/users/lmorchard/repos","events_url":"https://api.github.com/users/lmorchard/events{/privacy}","received_events_url":"https://api.github.com/users/lmorchard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lmorchard/node-firefox-start-simulator","description":"Start a Firefox OS simulator","fork":true,"url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator","forks_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/forks","keys_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/teams","hooks_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/hooks","issue_events_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/events","assignees_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/tags","blobs_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/languages","stargazers_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/stargazers","contributors_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/contributors","subscribers_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/subscribers","subscription_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/subscription","commits_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/merges","archive_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/downloads","issues_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/labels{/name}","releases_url":"https://api.github.com/repos/lmorchard/node-firefox-start-simulator/releases{/id}","created_at":"2015-01-23T19:51:50Z","updated_at":"2015-02-23T20:05:31Z","pushed_at":"2015-03-25T19:04:56Z","git_url":"git://github.com/lmorchard/node-firefox-start-simulator.git","ssh_url":"git@github.com:lmorchard/node-firefox-start-simulator.git","clone_url":"https://github.com/lmorchard/node-firefox-start-simulator.git","svn_url":"https://github.com/lmorchard/node-firefox-start-simulator","homepage":"","size":227,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"7ca46f60ec0e8541931fe28c6acffcef02ec114a","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":29203665,"name":"node-firefox-start-simulator","full_name":"mozilla/node-firefox-start-simulator","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/node-firefox-start-simulator","description":"Start a Firefox OS simulator","fork":false,"url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator","forks_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/forks","keys_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/teams","hooks_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/hooks","issue_events_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/events","assignees_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/tags","blobs_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/languages","stargazers_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/stargazers","contributors_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/contributors","subscribers_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/subscribers","subscription_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/subscription","commits_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/merges","archive_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/downloads","issues_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/releases{/id}","created_at":"2015-01-13T18:11:43Z","updated_at":"2015-02-23T20:02:59Z","pushed_at":"2015-03-25T19:06:28Z","git_url":"git://github.com/mozilla/node-firefox-start-simulator.git","ssh_url":"git@github.com:mozilla/node-firefox-start-simulator.git","clone_url":"https://github.com/mozilla/node-firefox-start-simulator.git","svn_url":"https://github.com/mozilla/node-firefox-start-simulator","homepage":"","size":333,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/pulls/23"},"html":{"href":"https://github.com/mozilla/node-firefox-start-simulator/pull/23"},"issue":{"href":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/issues/23"},"comments":{"href":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/node-firefox-start-simulator/statuses/e424b3e947a5eff380d4f4d4a6fb3932c37242a5"}}}}