{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5621","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5621/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5621/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5621/events","html_url":"https://github.com/bitcoin/bitcoin/pull/5621","id":53765205,"number":5621,"title":"Assert inside leveldbwrapper to avoid continuing after failure.","user":{"login":"gmaxwell","id":858454,"avatar_url":"https://avatars.githubusercontent.com/u/858454?v=3","gravatar_id":"","url":"https://api.github.com/users/gmaxwell","html_url":"https://github.com/gmaxwell","followers_url":"https://api.github.com/users/gmaxwell/followers","following_url":"https://api.github.com/users/gmaxwell/following{/other_user}","gists_url":"https://api.github.com/users/gmaxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaxwell/subscriptions","organizations_url":"https://api.github.com/users/gmaxwell/orgs","repos_url":"https://api.github.com/users/gmaxwell/repos","events_url":"https://api.github.com/users/gmaxwell/events{/privacy}","received_events_url":"https://api.github.com/users/gmaxwell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Bug","name":"Bug","color":"FBBAAB"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/14","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/14/labels","id":505738,"number":14,"title":"0.10.0","description":"","creator":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":105,"state":"open","created_at":"2013-12-05T10:34:42Z","updated_at":"2015-01-08T15:53:26Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-01-08T15:52:35Z","updated_at":"2015-01-09T14:23:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5621","html_url":"https://github.com/bitcoin/bitcoin/pull/5621","diff_url":"https://github.com/bitcoin/bitcoin/pull/5621.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/5621.patch"},"body":"Database failure due to faulty hardware could leave users on a fork where\r\n they are vulnerable to opportunistic attack because they are rejecting\r\n the longest chain.\r\n\r\nIf there is a software fault in the OS or LevelDB that causes many nodes\r\n to experience database failure at once its also important for overall\r\n consensus stability that the failing nodes shut down and not continue\r\n operating.\r\n\r\nIn theory, the exceptions in leveldbwrapper should cause shutdowns but\r\n in practice the software calls into that database from many places, some\r\n of which throw away all exceptions.\r\n\r\nA more organized approach to errors should be used in the long-term,\r\n but this works for the moment."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/69339722","html_url":"https://github.com/bitcoin/bitcoin/pull/5621#issuecomment-69339722","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5621","id":69339722,"user":{"login":"sipa","id":548488,"avatar_url":"https://avatars.githubusercontent.com/u/548488?v=3","gravatar_id":"","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"created_at":"2015-01-09T14:23:10Z","updated_at":"2015-01-09T14:23:10Z","body":"Not both. This one will cause an assert before #5619 has a chance to catch anything anyway."}}