{"action":"created","issue":{"url":"https://api.github.com/repos/Mange/roadie/issues/107","labels_url":"https://api.github.com/repos/Mange/roadie/issues/107/labels{/name}","comments_url":"https://api.github.com/repos/Mange/roadie/issues/107/comments","events_url":"https://api.github.com/repos/Mange/roadie/issues/107/events","html_url":"https://github.com/Mange/roadie/issues/107","id":74006146,"number":107,"title":"Roadie *SHOULD* extract external stylesheets by default (especially when using a CDN)","user":{"login":"dimroc","id":635121,"avatar_url":"https://avatars.githubusercontent.com/u/635121?v=3","gravatar_id":"","url":"https://api.github.com/users/dimroc","html_url":"https://github.com/dimroc","followers_url":"https://api.github.com/users/dimroc/followers","following_url":"https://api.github.com/users/dimroc/following{/other_user}","gists_url":"https://api.github.com/users/dimroc/gists{/gist_id}","starred_url":"https://api.github.com/users/dimroc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimroc/subscriptions","organizations_url":"https://api.github.com/users/dimroc/orgs","repos_url":"https://api.github.com/users/dimroc/repos","events_url":"https://api.github.com/users/dimroc/events{/privacy}","received_events_url":"https://api.github.com/users/dimroc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-07T14:28:14Z","updated_at":"2015-05-07T22:20:31Z","closed_at":null,"body":"I have a rails app that uses Fastly CDN to distribute all content, including those in an email. To support Roadie, I made a simple custom asset provider you can see here: https://gist.github.com/dimroc/eeb519c36152dbc133ae\r\n\r\nBy using a CDN in both the website and the emails, all of my .css files are external. Why you may ask? Because I wanted parity between my email previews and my actual emails.\r\n\r\nWith the change in e608038117d860e4268d45d42ff14be944edc822, roadie stops extracting external css files by default, therefore breaking my emails :-1: . I don't think this should be the case, and we should instead rely on data-roadie-ignore. But that flies in the face of #106.\r\n\r\nI propose reverting e608038117d860e4268d45d42ff14be944edc822, which I've done in my fork, but perhaps there's a better way out of this. Let me know your thoughts @Mange.\r\n\r\nThanks for a great gem!"},"comment":{"url":"https://api.github.com/repos/Mange/roadie/issues/comments/100036794","html_url":"https://github.com/Mange/roadie/issues/107#issuecomment-100036794","issue_url":"https://api.github.com/repos/Mange/roadie/issues/107","id":100036794,"user":{"login":"Mange","id":1599,"avatar_url":"https://avatars.githubusercontent.com/u/1599?v=3","gravatar_id":"","url":"https://api.github.com/users/Mange","html_url":"https://github.com/Mange","followers_url":"https://api.github.com/users/Mange/followers","following_url":"https://api.github.com/users/Mange/following{/other_user}","gists_url":"https://api.github.com/users/Mange/gists{/gist_id}","starred_url":"https://api.github.com/users/Mange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mange/subscriptions","organizations_url":"https://api.github.com/users/Mange/orgs","repos_url":"https://api.github.com/users/Mange/repos","events_url":"https://api.github.com/users/Mange/events{/privacy}","received_events_url":"https://api.github.com/users/Mange/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T22:20:31Z","updated_at":"2015-05-07T22:20:31Z","body":"Thank you for reporting this. The behavior you used was always a bug from\nthe project's perspective, so I will not revert the change.\nI will, however, implement your use case, enabling external assets to be\nfound through asset providers.\nI don't know exactly how I'll do it yet (configuration, another method on\nthe asset providers, etc) but I will add it so you should be able to\nupgrade to that future version and get everything working again.\n\nI will not implement external assets out of the box as the way to download\nand cache those assets could be highly dependent on the application, and I\ndon't want network handling added to Roadie. It's the perfect example of\nwhen it's important to support a flexible API to find assets, though.\n\nI'm sorry I broke your app. I hope my rather long (and redundant) answer\nconvince you that I won't leave it at this state.\n\nAny extra input you might have on how you'd want this feature to work is\nmost welcome. I'll read your provider's code tomorrow and gain that input,\nat least. I will also check out your fork.\n\ntors 7 maj 2015 16:28 Dimitri Roche <notifications@github.com> skrev:\n\n> I have a rails app that uses Fastly CDN to distribute all content,\n> including those in an email. To support Roadie, I made a simple custom\n> asset provider you can see here:\n> https://gist.github.com/dimroc/eeb519c36152dbc133ae\n>\n> By using a CDN in both the website and the emails, all of my .css files\n> are external. Why you may ask? Because I wanted parity between my email\n> previews and my actual emails.\n>\n> With the change in e608038\n> <https://github.com/Mange/roadie/commit/e608038117d860e4268d45d42ff14be944edc822>,\n> roadie stops extracting external css files by default, therefore breaking\n> my emails [image: :-1:] . I don't think this should be the case, and we\n> should instead rely on data-roadie-ignore. But that flies in the face of\n> #106 <https://github.com/Mange/roadie/issues/106>.\n>\n> I propose reverting e608038\n> <https://github.com/Mange/roadie/commit/e608038117d860e4268d45d42ff14be944edc822>,\n> which I've done in my fork, but perhaps there's a better way out of this.\n> Let me know your thoughts @Mange <https://github.com/Mange>.\n>\n> Thanks for a great gem!\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/Mange/roadie/issues/107>.\n>\n"}}