{"action":"created","issue":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3967","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3967/labels{/name}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3967/comments","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3967/events","html_url":"https://github.com/silverstripe/silverstripe-framework/issues/3967","id":59786717,"number":3967,"title":"Feature - Auto add module/themes to git ignore","user":{"login":"cjsewell","id":1856199,"avatar_url":"https://avatars.githubusercontent.com/u/1856199?v=3","gravatar_id":"","url":"https://api.github.com/users/cjsewell","html_url":"https://github.com/cjsewell","followers_url":"https://api.github.com/users/cjsewell/followers","following_url":"https://api.github.com/users/cjsewell/following{/other_user}","gists_url":"https://api.github.com/users/cjsewell/gists{/gist_id}","starred_url":"https://api.github.com/users/cjsewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjsewell/subscriptions","organizations_url":"https://api.github.com/users/cjsewell/orgs","repos_url":"https://api.github.com/users/cjsewell/repos","events_url":"https://api.github.com/users/cjsewell/events{/privacy}","received_events_url":"https://api.github.com/users/cjsewell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-03-04T11:42:39Z","updated_at":"2015-03-05T00:37:19Z","closed_at":null,"body":"I wrote a composer script to be used as a post-update-cmd which gets all SilverStripe themes and modules and adds them to your git ignore.\r\n\r\nIts reasonably smart and does not touch existing ignore items.\r\nYou can here it out [here](https://github.com/guru-digital/SSAutoGitIgnore/)\r\n\r\nJust got thinking, this could ship as a part of silverstripe-framework. \r\nIf it were to be a part of the framework, where would it live ( framework/dev and remove namespaces )? \r\nIf I created a pull request would it be considered or is this something better suited as a separate package? "},"comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments/77282747","html_url":"https://github.com/silverstripe/silverstripe-framework/issues/3967#issuecomment-77282747","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3967","id":77282747,"user":{"login":"cjsewell","id":1856199,"avatar_url":"https://avatars.githubusercontent.com/u/1856199?v=3","gravatar_id":"","url":"https://api.github.com/users/cjsewell","html_url":"https://github.com/cjsewell","followers_url":"https://api.github.com/users/cjsewell/followers","following_url":"https://api.github.com/users/cjsewell/following{/other_user}","gists_url":"https://api.github.com/users/cjsewell/gists{/gist_id}","starred_url":"https://api.github.com/users/cjsewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjsewell/subscriptions","organizations_url":"https://api.github.com/users/cjsewell/orgs","repos_url":"https://api.github.com/users/cjsewell/repos","events_url":"https://api.github.com/users/cjsewell/events{/privacy}","received_events_url":"https://api.github.com/users/cjsewell/received_events","type":"User","site_admin":false},"created_at":"2015-03-05T00:37:19Z","updated_at":"2015-03-05T00:37:19Z","body":"In my opinion its \"best practice\" to have composer managed modules separate from your projects repo.\r\n\r\nFor instance, if you modify a module, then do a composer update, you risk loosing your changes.\r\nMost devs would manually install a module if they wanted to modify it. If thats done, composer knows nothing about it, meaning this script wont know about it either.\r\n\r\nHaving \"sub git modules\" committed into your root repo leads to a `No submodule mapping found in .gitmodules for path 'xxx'` issue,   and if you going to manage a module via a proper [Git Submodule](http://git-scm.com/book/en/v2/Git-Tools-Submodules) it would not be managed by composer and in turn ignored by my script.\r\n\r\nHope that makes sense?"}}