{"push_id":791946237,"size":2,"distinct_size":2,"ref":"refs/heads/5.0.0","head":"7ef1e6b2adf0d13378d547895ea7eceeab929c72","before":"9a18b6ba89c401bbeeb99974f3725725f120a042","commits":[{"sha":"be2c6165a9614923b6cf9fc3cab8db328a4d7b47","author":{"email":"97bb377c30f270e63880c1ee2319b897ca202fdc@gmail.com","name":"cwardgar"},"message":"All NcML writing is done by the new NcMLWriter\n\nThis is a combination of 19 commits.\n\nAll NcML writing done by NcML writer. (WIP)\n\nAll NcML writing done by NcML writer. (WIP)\n\nAll NcML writing done by NcMLWriter. (2)\n* Made a couple of the methods \"public static\", but I decided that I don't like the design. Going to make them instance methods instead.\n\nAll NcML writing done by NcMLWriter. (3)\n\nAll NcML writing done by NcMLWriter. (4)\n* Values are no longer automatically emitted for the aggregation coordinate variable. As long as !var.isMetadata(), we don't need them in the output.\n\nAll NcML writing done by NcMLWriter. (5)\n* Static methods are now instance methods.\n* Added namespace and xmlFormat member vars, as wells as getters/setters for them.\n* Simplified the writing methods. They now all take an Element.\n* Renamed many of the methods.\n\nAll NcML writing done by NcMLWriter. (6)\n* Added variable-writing predicates.\n\nAll NcML writing done by NcMLWriter. (7)\n* Javadoc-ed NcMLWriter. I consider its API finished.\n* Fixed all clients of NcMLWriter to use the new API. Code compiles again.\n* Restored some usages of NCDumpW that I'd moved to NcMLWriter. I need to think carefully about how to reproduce the functionality with NcMLWriter.\n\nAll NcML writing done by NcMLWriter. (8)\n* Added Spock speck (NcMLWriterSpec) and all deps needed to run it.\n* NcMLWriter now uses \"\\n\" line separators, not \"\\r\\n\".\n* More NcMLWriter javadoc.\n* Good first feature method in NcMLWriterSpec. Working towards 100% code coverage.\n\nAll NcML writing done by NcMLWriter. (9)\n* More testing.\n\nAll NcML writing done by NcMLWriter. (10)\n* Added lots more tests. Just need to improve the coverage on groups, variables, and values.\n* Writers now detach Elements from any Document they may be a part of before writing. Allows Elements to be written more than once.\n* makeAttributeElement no longer has an \"elementName\" parameter. It's always \"attribute\" anyway.\n* Values for metadata vars aren't always getting written out now; will need to use writeMetadataVariablesPredicate\n\nAll NcML writing done by NcMLWriter. (11)\n* Finished tests for <variable> and <values>. Only <group> remains, plus miscellany.\n\nAll NcML writing done by NcMLWriter. (12)\n* Refactored NcMLWriterSpec: we're now producing a NcML document that exercises nearly all of NcMLWriter by itself.\n* Minor NcMLWriter tweaks. makeDimensionElement() throws an exception if the dim isn't shared.\n* Fixed a bug in NcMLReader's handling of variable-length dimensions.\n\nAll NcML writing done by NcMLWriter. (12)\n* Changed the order that elements are written in NcMLWriter to match CDL's order.\n* makeValuesElement() throws an IOException when the Variable can't be read. Updated client code to handle the change.\n* Added test coverage for all of NcMLWriter's getters and setters.\n* The last test I need is a round trip using NcMLReader!\n\nAll NcML writing done by NcMLWriter. (14)\n* NcMLWriterSpec is finally complete! 100% coverage.\n* Added an integration test that round-trips an NcML file out of NcMLWriter and into NcMLReader.\n* NcMLReader was mishandling unsigned attributes.\n* NcMLWriter separates its string-valued attribute and Variable values with '|'.\n* NcMLWriter emits the entries of an EnumTypedef in increasing order of its keys.\n\nAll NcML writing done by NcMLWriter. (15)\n* Added NcMLWriter.writeToWriter(), which makes it easier for NCdumpW to use the class. Refactored other write methods to use it.\n* NCdumpW.writeNcMLVariable() is now using NcMLWriter and producing correct results. Had to change a parameter from Formatter to Writer. Updated client code.\n\nAll NcML writing done by NcMLWriter. (16)\n* Trivial.\n\nAll NcML writing done by NcMLWriter. (17)\n* Refactored NCdumpW.writeNcML() to use NcMLWriter. It is now the only method in NCdumpW for writing NcML and it's not used by any other classes.\n* Ready to run the full test suite against the ncml branch on Jenkins.\n\nREMOVE LITTER: NcMLWriter and NCdumpW\n\nFixed some lingering merge issues btwn '5.0.0' and 'ncml'.\n* Old code needed to use the new NcMLWriter.\n* Also, updating for the unsigned data type changes.","distinct":true,"url":"https://api.github.com/repos/Unidata/thredds/commits/be2c6165a9614923b6cf9fc3cab8db328a4d7b47"},{"sha":"7ef1e6b2adf0d13378d547895ea7eceeab929c72","author":{"email":"97bb377c30f270e63880c1ee2319b897ca202fdc@unidata.ucar.edu","name":"Christian W"},"message":"Merge pull request #189 from cwardgar/ncml\n\nAll NcML writing is done by the new NcMLWriter","distinct":true,"url":"https://api.github.com/repos/Unidata/thredds/commits/7ef1e6b2adf0d13378d547895ea7eceeab929c72"}]}