{"action":"closed","issue":{"url":"https://api.github.com/repos/JedWatson/classnames/issues/3","labels_url":"https://api.github.com/repos/JedWatson/classnames/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/JedWatson/classnames/issues/3/comments","events_url":"https://api.github.com/repos/JedWatson/classnames/issues/3/events","html_url":"https://github.com/JedWatson/classnames/issues/3","id":56107210,"number":3,"title":"Some issues to make this compatible with React addon classSet","user":{"login":"chenglou","id":1909539,"avatar_url":"https://avatars.githubusercontent.com/u/1909539?v=3","gravatar_id":"","url":"https://api.github.com/users/chenglou","html_url":"https://github.com/chenglou","followers_url":"https://api.github.com/users/chenglou/followers","following_url":"https://api.github.com/users/chenglou/following{/other_user}","gists_url":"https://api.github.com/users/chenglou/gists{/gist_id}","starred_url":"https://api.github.com/users/chenglou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenglou/subscriptions","organizations_url":"https://api.github.com/users/chenglou/orgs","repos_url":"https://api.github.com/users/chenglou/repos","events_url":"https://api.github.com/users/chenglou/events{/privacy}","received_events_url":"https://api.github.com/users/chenglou/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-31T01:47:15Z","updated_at":"2015-01-31T21:16:38Z","closed_at":"2015-01-31T21:16:38Z","body":"1. `classnames('a', false)` produces `'a false'` in classSet, but classnames ignores `false`. Passing `null` crashes it. Passing `undefined` gets it ignored. Doesn't matter what the desirable behaviour is; it breaks compatibility with classSet.\r\n\r\n2. Bikeshedding: I know this has nothing to do with React, but React uses `className` so it'd be nice if this could be `classNames` camelCased.\r\n\r\n3. Empty class names return `undefined` rather than `''`."}}