{"action":"created","comment":{"url":"https://api.github.com/repos/phoenixframework/phoenix_html/pulls/comments/40063441","id":40063441,"diff_hunk":"@@ -252,8 +252,26 @@ defmodule Phoenix.HTML.FormTest do\n     assert safe_form(&search_input(&1, :key)) ==\n           ~s(<input id=\"search_key\" name=\"search[key]\" type=\"search\" value=\"value\">)\n \n-    assert safe_form(&search_input(&1, :key, value: \"foo\", id: \"key\", name: \"search[key][]\")) ==\n-          ~s(<input id=\"key\" name=\"search[key][]\" type=\"search\" value=\"foo\">)\n+    assert safe_form(&search_input(&1, :key, value: \"#123456\", id: \"key\", name: \"search[key][]\")) ==\n+          ~s(<input id=\"key\" name=\"search[key][]\" type=\"search\" value=\"#123456\">)\n+  end\n+\n+  ## color_input/3\n+\n+  test \"color_input/3\" do\n+    assert safe_to_string(color_input(:search, :key)) ==\n+          ~s(<input id=\"search_key\" name=\"search[key]\" type=\"color\">)\n+\n+    assert safe_to_string(color_input(:search, :key, value: \"#123456\", id: \"key\", name: \"search[key][]\")) ==\n+          ~s(<input id=\"key\" name=\"search[key][]\" type=\"color\" value=\"#123456\">)\n+  end\n+\n+  test \"color_input/3 with form\" do\n+    assert safe_form(&color_input(&1, :key)) ==\n+          ~s(<input id=\"search_key\" name=\"search[key]\" type=\"color\" value=\"value\">)\n+\n+    assert safe_form(&color_input(&1, :key, value: \"foo\", id: \"key\", name: \"search[key][]\")) ==\n+          ~s(<input id=\"key\" name=\"search[key][]\" type=\"color\" value=\"foo\">)","path":"test/phoenix_html/form_test.exs","position":25,"original_position":25,"commit_id":"ee1a8a6e985ba412fe86754bbd7ea7e38e2e12a7","original_commit_id":"ee1a8a6e985ba412fe86754bbd7ea7e38e2e12a7","user":{"login":"josevalim","id":9582,"avatar_url":"https://avatars.githubusercontent.com/u/9582?v=3","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"body":"This input is wrong I think.","created_at":"2015-09-22T08:40:22Z","updated_at":"2015-09-22T08:40:22Z","html_url":"https://github.com/phoenixframework/phoenix_html/pull/33#discussion_r40063441","pull_request_url":"https://api.github.com/repos/phoenixframework/phoenix_html/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/phoenixframework/phoenix_html/pulls/comments/40063441"},"html":{"href":"https://github.com/phoenixframework/phoenix_html/pull/33#discussion_r40063441"},"pull_request":{"href":"https://api.github.com/repos/phoenixframework/phoenix_html/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/phoenixframework/phoenix_html/pulls/33","id":45615400,"html_url":"https://github.com/phoenixframework/phoenix_html/pull/33","diff_url":"https://github.com/phoenixframework/phoenix_html/pull/33.diff","patch_url":"https://github.com/phoenixframework/phoenix_html/pull/33.patch","issue_url":"https://api.github.com/repos/phoenixframework/phoenix_html/issues/33","number":33,"state":"open","locked":false,"title":"Add an HTML5 color input","user":{"login":"delehef","id":1153808,"avatar_url":"https://avatars.githubusercontent.com/u/1153808?v=3","gravatar_id":"","url":"https://api.github.com/users/delehef","html_url":"https://github.com/delehef","followers_url":"https://api.github.com/users/delehef/followers","following_url":"https://api.github.com/users/delehef/following{/other_user}","gists_url":"https://api.github.com/users/delehef/gists{/gist_id}","starred_url":"https://api.github.com/users/delehef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delehef/subscriptions","organizations_url":"https://api.github.com/users/delehef/orgs","repos_url":"https://api.github.com/users/delehef/repos","events_url":"https://api.github.com/users/delehef/events{/privacy}","received_events_url":"https://api.github.com/users/delehef/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nI needed a color input for a project of mine and didn't find any in Phoenix, so I added one manually. Here is the PR if you wish to merge it.\r\n\r\nThanks for your work!","created_at":"2015-09-22T00:05:34Z","updated_at":"2015-09-22T08:40:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4cc028e5d8712bf7a13829f185ae255ed73a0d0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phoenixframework/phoenix_html/pulls/33/commits","review_comments_url":"https://api.github.com/repos/phoenixframework/phoenix_html/pulls/33/comments","review_comment_url":"https://api.github.com/repos/phoenixframework/phoenix_html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix_html/issues/33/comments","statuses_url":"https://api.github.com/repos/phoenixframework/phoenix_html/statuses/ee1a8a6e985ba412fe86754bbd7ea7e38e2e12a7","head":{"label":"delehef:master","ref":"master","sha":"ee1a8a6e985ba412fe86754bbd7ea7e38e2e12a7","user":{"login":"delehef","id":1153808,"avatar_url":"https://avatars.githubusercontent.com/u/1153808?v=3","gravatar_id":"","url":"https://api.github.com/users/delehef","html_url":"https://github.com/delehef","followers_url":"https://api.github.com/users/delehef/followers","following_url":"https://api.github.com/users/delehef/following{/other_user}","gists_url":"https://api.github.com/users/delehef/gists{/gist_id}","starred_url":"https://api.github.com/users/delehef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delehef/subscriptions","organizations_url":"https://api.github.com/users/delehef/orgs","repos_url":"https://api.github.com/users/delehef/repos","events_url":"https://api.github.com/users/delehef/events{/privacy}","received_events_url":"https://api.github.com/users/delehef/received_events","type":"User","site_admin":false},"repo":{"id":42900409,"name":"phoenix_html","full_name":"delehef/phoenix_html","owner":{"login":"delehef","id":1153808,"avatar_url":"https://avatars.githubusercontent.com/u/1153808?v=3","gravatar_id":"","url":"https://api.github.com/users/delehef","html_url":"https://github.com/delehef","followers_url":"https://api.github.com/users/delehef/followers","following_url":"https://api.github.com/users/delehef/following{/other_user}","gists_url":"https://api.github.com/users/delehef/gists{/gist_id}","starred_url":"https://api.github.com/users/delehef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delehef/subscriptions","organizations_url":"https://api.github.com/users/delehef/orgs","repos_url":"https://api.github.com/users/delehef/repos","events_url":"https://api.github.com/users/delehef/events{/privacy}","received_events_url":"https://api.github.com/users/delehef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/delehef/phoenix_html","description":"Phoenix.HTML functions for working with HTML strings and templates","fork":true,"url":"https://api.github.com/repos/delehef/phoenix_html","forks_url":"https://api.github.com/repos/delehef/phoenix_html/forks","keys_url":"https://api.github.com/repos/delehef/phoenix_html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/delehef/phoenix_html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/delehef/phoenix_html/teams","hooks_url":"https://api.github.com/repos/delehef/phoenix_html/hooks","issue_events_url":"https://api.github.com/repos/delehef/phoenix_html/issues/events{/number}","events_url":"https://api.github.com/repos/delehef/phoenix_html/events","assignees_url":"https://api.github.com/repos/delehef/phoenix_html/assignees{/user}","branches_url":"https://api.github.com/repos/delehef/phoenix_html/branches{/branch}","tags_url":"https://api.github.com/repos/delehef/phoenix_html/tags","blobs_url":"https://api.github.com/repos/delehef/phoenix_html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/delehef/phoenix_html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/delehef/phoenix_html/git/refs{/sha}","trees_url":"https://api.github.com/repos/delehef/phoenix_html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/delehef/phoenix_html/statuses/{sha}","languages_url":"https://api.github.com/repos/delehef/phoenix_html/languages","stargazers_url":"https://api.github.com/repos/delehef/phoenix_html/stargazers","contributors_url":"https://api.github.com/repos/delehef/phoenix_html/contributors","subscribers_url":"https://api.github.com/repos/delehef/phoenix_html/subscribers","subscription_url":"https://api.github.com/repos/delehef/phoenix_html/subscription","commits_url":"https://api.github.com/repos/delehef/phoenix_html/commits{/sha}","git_commits_url":"https://api.github.com/repos/delehef/phoenix_html/git/commits{/sha}","comments_url":"https://api.github.com/repos/delehef/phoenix_html/comments{/number}","issue_comment_url":"https://api.github.com/repos/delehef/phoenix_html/issues/comments{/number}","contents_url":"https://api.github.com/repos/delehef/phoenix_html/contents/{+path}","compare_url":"https://api.github.com/repos/delehef/phoenix_html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/delehef/phoenix_html/merges","archive_url":"https://api.github.com/repos/delehef/phoenix_html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/delehef/phoenix_html/downloads","issues_url":"https://api.github.com/repos/delehef/phoenix_html/issues{/number}","pulls_url":"https://api.github.com/repos/delehef/phoenix_html/pulls{/number}","milestones_url":"https://api.github.com/repos/delehef/phoenix_html/milestones{/number}","notifications_url":"https://api.github.com/repos/delehef/phoenix_html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/delehef/phoenix_html/labels{/name}","releases_url":"https://api.github.com/repos/delehef/phoenix_html/releases{/id}","created_at":"2015-09-22T00:01:38Z","updated_at":"2015-09-22T00:01:38Z","pushed_at":"2015-09-22T08:21:40Z","git_url":"git://github.com/delehef/phoenix_html.git","ssh_url":"git@github.com:delehef/phoenix_html.git","clone_url":"https://github.com/delehef/phoenix_html.git","svn_url":"https://github.com/delehef/phoenix_html","homepage":null,"size":397,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phoenixframework:master","ref":"master","sha":"287a302a423fa7be4d0e5dcfa62ea0f8e3aced8e","user":{"login":"phoenixframework","id":6510388,"avatar_url":"https://avatars.githubusercontent.com/u/6510388?v=3","gravatar_id":"","url":"https://api.github.com/users/phoenixframework","html_url":"https://github.com/phoenixframework","followers_url":"https://api.github.com/users/phoenixframework/followers","following_url":"https://api.github.com/users/phoenixframework/following{/other_user}","gists_url":"https://api.github.com/users/phoenixframework/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenixframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenixframework/subscriptions","organizations_url":"https://api.github.com/users/phoenixframework/orgs","repos_url":"https://api.github.com/users/phoenixframework/repos","events_url":"https://api.github.com/users/phoenixframework/events{/privacy}","received_events_url":"https://api.github.com/users/phoenixframework/received_events","type":"Organization","site_admin":false},"repo":{"id":34984923,"name":"phoenix_html","full_name":"phoenixframework/phoenix_html","owner":{"login":"phoenixframework","id":6510388,"avatar_url":"https://avatars.githubusercontent.com/u/6510388?v=3","gravatar_id":"","url":"https://api.github.com/users/phoenixframework","html_url":"https://github.com/phoenixframework","followers_url":"https://api.github.com/users/phoenixframework/followers","following_url":"https://api.github.com/users/phoenixframework/following{/other_user}","gists_url":"https://api.github.com/users/phoenixframework/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenixframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenixframework/subscriptions","organizations_url":"https://api.github.com/users/phoenixframework/orgs","repos_url":"https://api.github.com/users/phoenixframework/repos","events_url":"https://api.github.com/users/phoenixframework/events{/privacy}","received_events_url":"https://api.github.com/users/phoenixframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phoenixframework/phoenix_html","description":"Phoenix.HTML functions for working with HTML strings and templates","fork":false,"url":"https://api.github.com/repos/phoenixframework/phoenix_html","forks_url":"https://api.github.com/repos/phoenixframework/phoenix_html/forks","keys_url":"https://api.github.com/repos/phoenixframework/phoenix_html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phoenixframework/phoenix_html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phoenixframework/phoenix_html/teams","hooks_url":"https://api.github.com/repos/phoenixframework/phoenix_html/hooks","issue_events_url":"https://api.github.com/repos/phoenixframework/phoenix_html/issues/events{/number}","events_url":"https://api.github.com/repos/phoenixframework/phoenix_html/events","assignees_url":"https://api.github.com/repos/phoenixframework/phoenix_html/assignees{/user}","branches_url":"https://api.github.com/repos/phoenixframework/phoenix_html/branches{/branch}","tags_url":"https://api.github.com/repos/phoenixframework/phoenix_html/tags","blobs_url":"https://api.github.com/repos/phoenixframework/phoenix_html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phoenixframework/phoenix_html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phoenixframework/phoenix_html/git/refs{/sha}","trees_url":"https://api.github.com/repos/phoenixframework/phoenix_html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phoenixframework/phoenix_html/statuses/{sha}","languages_url":"https://api.github.com/repos/phoenixframework/phoenix_html/languages","stargazers_url":"https://api.github.com/repos/phoenixframework/phoenix_html/stargazers","contributors_url":"https://api.github.com/repos/phoenixframework/phoenix_html/contributors","subscribers_url":"https://api.github.com/repos/phoenixframework/phoenix_html/subscribers","subscription_url":"https://api.github.com/repos/phoenixframework/phoenix_html/subscription","commits_url":"https://api.github.com/repos/phoenixframework/phoenix_html/commits{/sha}","git_commits_url":"https://api.github.com/repos/phoenixframework/phoenix_html/git/commits{/sha}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix_html/comments{/number}","issue_comment_url":"https://api.github.com/repos/phoenixframework/phoenix_html/issues/comments{/number}","contents_url":"https://api.github.com/repos/phoenixframework/phoenix_html/contents/{+path}","compare_url":"https://api.github.com/repos/phoenixframework/phoenix_html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phoenixframework/phoenix_html/merges","archive_url":"https://api.github.com/repos/phoenixframework/phoenix_html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phoenixframework/phoenix_html/downloads","issues_url":"https://api.github.com/repos/phoenixframework/phoenix_html/issues{/number}","pulls_url":"https://api.github.com/repos/phoenixframework/phoenix_html/pulls{/number}","milestones_url":"https://api.github.com/repos/phoenixframework/phoenix_html/milestones{/number}","notifications_url":"https://api.github.com/repos/phoenixframework/phoenix_html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phoenixframework/phoenix_html/labels{/name}","releases_url":"https://api.github.com/repos/phoenixframework/phoenix_html/releases{/id}","created_at":"2015-05-03T12:14:58Z","updated_at":"2015-09-13T15:57:07Z","pushed_at":"2015-09-22T08:38:45Z","git_url":"git://github.com/phoenixframework/phoenix_html.git","ssh_url":"git@github.com:phoenixframework/phoenix_html.git","clone_url":"https://github.com/phoenixframework/phoenix_html.git","svn_url":"https://github.com/phoenixframework/phoenix_html","homepage":null,"size":397,"stargazers_count":20,"watchers_count":20,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":2,"forks":20,"open_issues":2,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phoenixframework/phoenix_html/pulls/33"},"html":{"href":"https://github.com/phoenixframework/phoenix_html/pull/33"},"issue":{"href":"https://api.github.com/repos/phoenixframework/phoenix_html/issues/33"},"comments":{"href":"https://api.github.com/repos/phoenixframework/phoenix_html/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/phoenixframework/phoenix_html/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/phoenixframework/phoenix_html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phoenixframework/phoenix_html/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/phoenixframework/phoenix_html/statuses/ee1a8a6e985ba412fe86754bbd7ea7e38e2e12a7"}}}}