{"action":"closed","number":1113,"pull_request":{"url":"https://api.github.com/repos/cinder/Cinder/pulls/1113","id":44971103,"html_url":"https://github.com/cinder/Cinder/pull/1113","diff_url":"https://github.com/cinder/Cinder/pull/1113.diff","patch_url":"https://github.com/cinder/Cinder/pull/1113.patch","issue_url":"https://api.github.com/repos/cinder/Cinder/issues/1113","number":1113,"state":"closed","locked":false,"title":"Inferring GL Texture dataType from internalFormat","user":{"login":"andrewfb","id":227107,"avatar_url":"https://avatars.githubusercontent.com/u/227107?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewfb","html_url":"https://github.com/andrewfb","followers_url":"https://api.github.com/users/andrewfb/followers","following_url":"https://api.github.com/users/andrewfb/following{/other_user}","gists_url":"https://api.github.com/users/andrewfb/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewfb/subscriptions","organizations_url":"https://api.github.com/users/andrewfb/orgs","repos_url":"https://api.github.com/users/andrewfb/repos","events_url":"https://api.github.com/users/andrewfb/events{/privacy}","received_events_url":"https://api.github.com/users/andrewfb/received_events","type":"User","site_admin":false},"body":"This should address #1099. It modifies the gl::Texture constructor that accepts an ImageSourceRef so that it automatically infers the dataType from the internalFormat. This most obviously manifests when attempting to create an integer texture. ","created_at":"2015-09-14T19:36:53Z","updated_at":"2015-09-15T15:22:59Z","closed_at":"2015-09-15T15:22:59Z","merged_at":"2015-09-15T15:22:59Z","merge_commit_sha":"0a2082c932b8e6312315e448b20ecc5b7819722d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cinder/Cinder/pulls/1113/commits","review_comments_url":"https://api.github.com/repos/cinder/Cinder/pulls/1113/comments","review_comment_url":"https://api.github.com/repos/cinder/Cinder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cinder/Cinder/issues/1113/comments","statuses_url":"https://api.github.com/repos/cinder/Cinder/statuses/56b14f339118e594550bfdf599a667eb9283cdb4","head":{"label":"andrewfb:imageSourceTex","ref":"imageSourceTex","sha":"56b14f339118e594550bfdf599a667eb9283cdb4","user":{"login":"andrewfb","id":227107,"avatar_url":"https://avatars.githubusercontent.com/u/227107?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewfb","html_url":"https://github.com/andrewfb","followers_url":"https://api.github.com/users/andrewfb/followers","following_url":"https://api.github.com/users/andrewfb/following{/other_user}","gists_url":"https://api.github.com/users/andrewfb/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewfb/subscriptions","organizations_url":"https://api.github.com/users/andrewfb/orgs","repos_url":"https://api.github.com/users/andrewfb/repos","events_url":"https://api.github.com/users/andrewfb/events{/privacy}","received_events_url":"https://api.github.com/users/andrewfb/received_events","type":"User","site_admin":false},"repo":{"id":42182697,"name":"Cinder","full_name":"andrewfb/Cinder","owner":{"login":"andrewfb","id":227107,"avatar_url":"https://avatars.githubusercontent.com/u/227107?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewfb","html_url":"https://github.com/andrewfb","followers_url":"https://api.github.com/users/andrewfb/followers","following_url":"https://api.github.com/users/andrewfb/following{/other_user}","gists_url":"https://api.github.com/users/andrewfb/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewfb/subscriptions","organizations_url":"https://api.github.com/users/andrewfb/orgs","repos_url":"https://api.github.com/users/andrewfb/repos","events_url":"https://api.github.com/users/andrewfb/events{/privacy}","received_events_url":"https://api.github.com/users/andrewfb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewfb/Cinder","description":"Cinder is a community-developed, free and open source library for professional-quality creative coding in C++.","fork":true,"url":"https://api.github.com/repos/andrewfb/Cinder","forks_url":"https://api.github.com/repos/andrewfb/Cinder/forks","keys_url":"https://api.github.com/repos/andrewfb/Cinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewfb/Cinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewfb/Cinder/teams","hooks_url":"https://api.github.com/repos/andrewfb/Cinder/hooks","issue_events_url":"https://api.github.com/repos/andrewfb/Cinder/issues/events{/number}","events_url":"https://api.github.com/repos/andrewfb/Cinder/events","assignees_url":"https://api.github.com/repos/andrewfb/Cinder/assignees{/user}","branches_url":"https://api.github.com/repos/andrewfb/Cinder/branches{/branch}","tags_url":"https://api.github.com/repos/andrewfb/Cinder/tags","blobs_url":"https://api.github.com/repos/andrewfb/Cinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewfb/Cinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewfb/Cinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewfb/Cinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewfb/Cinder/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewfb/Cinder/languages","stargazers_url":"https://api.github.com/repos/andrewfb/Cinder/stargazers","contributors_url":"https://api.github.com/repos/andrewfb/Cinder/contributors","subscribers_url":"https://api.github.com/repos/andrewfb/Cinder/subscribers","subscription_url":"https://api.github.com/repos/andrewfb/Cinder/subscription","commits_url":"https://api.github.com/repos/andrewfb/Cinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewfb/Cinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewfb/Cinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewfb/Cinder/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewfb/Cinder/contents/{+path}","compare_url":"https://api.github.com/repos/andrewfb/Cinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewfb/Cinder/merges","archive_url":"https://api.github.com/repos/andrewfb/Cinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewfb/Cinder/downloads","issues_url":"https://api.github.com/repos/andrewfb/Cinder/issues{/number}","pulls_url":"https://api.github.com/repos/andrewfb/Cinder/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewfb/Cinder/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewfb/Cinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewfb/Cinder/labels{/name}","releases_url":"https://api.github.com/repos/andrewfb/Cinder/releases{/id}","created_at":"2015-09-09T14:13:24Z","updated_at":"2015-09-09T14:13:43Z","pushed_at":"2015-09-14T19:34:05Z","git_url":"git://github.com/andrewfb/Cinder.git","ssh_url":"git@github.com:andrewfb/Cinder.git","clone_url":"https://github.com/andrewfb/Cinder.git","svn_url":"https://github.com/andrewfb/Cinder","homepage":"http://libcinder.org","size":236815,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cinder:master","ref":"master","sha":"a714d1586a50a37332405bc979a1affc54fd1f69","user":{"login":"cinder","id":154586,"avatar_url":"https://avatars.githubusercontent.com/u/154586?v=3","gravatar_id":"","url":"https://api.github.com/users/cinder","html_url":"https://github.com/cinder","followers_url":"https://api.github.com/users/cinder/followers","following_url":"https://api.github.com/users/cinder/following{/other_user}","gists_url":"https://api.github.com/users/cinder/gists{/gist_id}","starred_url":"https://api.github.com/users/cinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinder/subscriptions","organizations_url":"https://api.github.com/users/cinder/orgs","repos_url":"https://api.github.com/users/cinder/repos","events_url":"https://api.github.com/users/cinder/events{/privacy}","received_events_url":"https://api.github.com/users/cinder/received_events","type":"User","site_admin":false},"repo":{"id":622127,"name":"Cinder","full_name":"cinder/Cinder","owner":{"login":"cinder","id":154586,"avatar_url":"https://avatars.githubusercontent.com/u/154586?v=3","gravatar_id":"","url":"https://api.github.com/users/cinder","html_url":"https://github.com/cinder","followers_url":"https://api.github.com/users/cinder/followers","following_url":"https://api.github.com/users/cinder/following{/other_user}","gists_url":"https://api.github.com/users/cinder/gists{/gist_id}","starred_url":"https://api.github.com/users/cinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinder/subscriptions","organizations_url":"https://api.github.com/users/cinder/orgs","repos_url":"https://api.github.com/users/cinder/repos","events_url":"https://api.github.com/users/cinder/events{/privacy}","received_events_url":"https://api.github.com/users/cinder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cinder/Cinder","description":"Cinder is a community-developed, free and open source library for professional-quality creative coding in C++.","fork":false,"url":"https://api.github.com/repos/cinder/Cinder","forks_url":"https://api.github.com/repos/cinder/Cinder/forks","keys_url":"https://api.github.com/repos/cinder/Cinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cinder/Cinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cinder/Cinder/teams","hooks_url":"https://api.github.com/repos/cinder/Cinder/hooks","issue_events_url":"https://api.github.com/repos/cinder/Cinder/issues/events{/number}","events_url":"https://api.github.com/repos/cinder/Cinder/events","assignees_url":"https://api.github.com/repos/cinder/Cinder/assignees{/user}","branches_url":"https://api.github.com/repos/cinder/Cinder/branches{/branch}","tags_url":"https://api.github.com/repos/cinder/Cinder/tags","blobs_url":"https://api.github.com/repos/cinder/Cinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cinder/Cinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cinder/Cinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/cinder/Cinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cinder/Cinder/statuses/{sha}","languages_url":"https://api.github.com/repos/cinder/Cinder/languages","stargazers_url":"https://api.github.com/repos/cinder/Cinder/stargazers","contributors_url":"https://api.github.com/repos/cinder/Cinder/contributors","subscribers_url":"https://api.github.com/repos/cinder/Cinder/subscribers","subscription_url":"https://api.github.com/repos/cinder/Cinder/subscription","commits_url":"https://api.github.com/repos/cinder/Cinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/cinder/Cinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/cinder/Cinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/cinder/Cinder/issues/comments{/number}","contents_url":"https://api.github.com/repos/cinder/Cinder/contents/{+path}","compare_url":"https://api.github.com/repos/cinder/Cinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cinder/Cinder/merges","archive_url":"https://api.github.com/repos/cinder/Cinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cinder/Cinder/downloads","issues_url":"https://api.github.com/repos/cinder/Cinder/issues{/number}","pulls_url":"https://api.github.com/repos/cinder/Cinder/pulls{/number}","milestones_url":"https://api.github.com/repos/cinder/Cinder/milestones{/number}","notifications_url":"https://api.github.com/repos/cinder/Cinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cinder/Cinder/labels{/name}","releases_url":"https://api.github.com/repos/cinder/Cinder/releases{/id}","created_at":"2010-04-21T19:03:10Z","updated_at":"2015-09-15T06:00:43Z","pushed_at":"2015-09-15T15:22:59Z","git_url":"git://github.com/cinder/Cinder.git","ssh_url":"git@github.com:cinder/Cinder.git","clone_url":"https://github.com/cinder/Cinder.git","svn_url":"https://github.com/cinder/Cinder","homepage":"http://libcinder.org","size":353925,"stargazers_count":2114,"watchers_count":2114,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":525,"mirror_url":null,"open_issues_count":101,"forks":525,"open_issues":101,"watchers":2114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/1113"},"html":{"href":"https://github.com/cinder/Cinder/pull/1113"},"issue":{"href":"https://api.github.com/repos/cinder/Cinder/issues/1113"},"comments":{"href":"https://api.github.com/repos/cinder/Cinder/issues/1113/comments"},"review_comments":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/1113/comments"},"review_comment":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/1113/commits"},"statuses":{"href":"https://api.github.com/repos/cinder/Cinder/statuses/56b14f339118e594550bfdf599a667eb9283cdb4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"andrewfb","id":227107,"avatar_url":"https://avatars.githubusercontent.com/u/227107?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewfb","html_url":"https://github.com/andrewfb","followers_url":"https://api.github.com/users/andrewfb/followers","following_url":"https://api.github.com/users/andrewfb/following{/other_user}","gists_url":"https://api.github.com/users/andrewfb/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewfb/subscriptions","organizations_url":"https://api.github.com/users/andrewfb/orgs","repos_url":"https://api.github.com/users/andrewfb/repos","events_url":"https://api.github.com/users/andrewfb/events{/privacy}","received_events_url":"https://api.github.com/users/andrewfb/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":7,"additions":31,"deletions":29,"changed_files":5}}