{"action":"created","comment":{"url":"https://api.github.com/repos/Alexpux/Cygwin/pulls/comments/38412831","id":38412831,"diff_hunk":"@@ -734,11 +734,11 @@ path_conv::check (const char *src, unsigned opt,\n \t      need_directory = 1;\n \t      *--tail = '\\0';\n \t    }\n-\t  /* Special case for \"/\" must set need_directory, without removing\n+\t  /* Special case for \"/\" must not set need_directory, neither remove\n \t     trailing slash */\n \t  else if (tail == path_copy + 1 && isslash (tail[-1]))\n \t    {\n-\t      need_directory = 1;\n+\t      need_directory = 0;","path":"winsup/cygwin/path.cc","position":10,"original_position":10,"commit_id":"6d58126abf0d76109678483e4cc892c5f74a93b3","original_commit_id":"6d58126abf0d76109678483e4cc892c5f74a93b3","user":{"login":"dscho","id":127790,"avatar_url":"https://avatars.githubusercontent.com/u/127790?v=3","gravatar_id":"","url":"https://api.github.com/users/dscho","html_url":"https://github.com/dscho","followers_url":"https://api.github.com/users/dscho/followers","following_url":"https://api.github.com/users/dscho/following{/other_user}","gists_url":"https://api.github.com/users/dscho/gists{/gist_id}","starred_url":"https://api.github.com/users/dscho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dscho/subscriptions","organizations_url":"https://api.github.com/users/dscho/orgs","repos_url":"https://api.github.com/users/dscho/repos","events_url":"https://api.github.com/users/dscho/events{/privacy}","received_events_url":"https://api.github.com/users/dscho/received_events","type":"User","site_admin":false},"body":"Heh, this is a fix. As in: we're in a fix now... because the trailing slash breaks Git for Windows pretty badly. See https://github.com/dscho/msys2-runtime/commit/560d5675a735f2f917f49b7411a9fa01b87fa200 (The test in question is one of Git' extensive tests: https://github.com/git/git/blob/master/t/t0060-path-utils.sh)","created_at":"2015-09-01T12:31:47Z","updated_at":"2015-09-01T12:31:47Z","html_url":"https://github.com/Alexpux/Cygwin/pull/8#discussion_r38412831","pull_request_url":"https://api.github.com/repos/Alexpux/Cygwin/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/Alexpux/Cygwin/pulls/comments/38412831"},"html":{"href":"https://github.com/Alexpux/Cygwin/pull/8#discussion_r38412831"},"pull_request":{"href":"https://api.github.com/repos/Alexpux/Cygwin/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/Alexpux/Cygwin/pulls/8","id":43122538,"html_url":"https://github.com/Alexpux/Cygwin/pull/8","diff_url":"https://github.com/Alexpux/Cygwin/pull/8.diff","patch_url":"https://github.com/Alexpux/Cygwin/pull/8.patch","issue_url":"https://api.github.com/repos/Alexpux/Cygwin/issues/8","number":8,"state":"open","locked":false,"title":"Support Git for Windows 2.x","user":{"login":"dscho","id":127790,"avatar_url":"https://avatars.githubusercontent.com/u/127790?v=3","gravatar_id":"","url":"https://api.github.com/users/dscho","html_url":"https://github.com/dscho","followers_url":"https://api.github.com/users/dscho/followers","following_url":"https://api.github.com/users/dscho/following{/other_user}","gists_url":"https://api.github.com/users/dscho/gists{/gist_id}","starred_url":"https://api.github.com/users/dscho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dscho/subscriptions","organizations_url":"https://api.github.com/users/dscho/orgs","repos_url":"https://api.github.com/users/dscho/repos","events_url":"https://api.github.com/users/dscho/events{/privacy}","received_events_url":"https://api.github.com/users/dscho/received_events","type":"User","site_admin":false},"body":"This is the big one. This is the Pull Request modifying mostly the path conversion handling so that Git for Windows 2.x is backwards compatible to Git for Windows 1.x, and more importantly: so that it passes the test suite of Git proper.\r\n\r\nPlease note that I am prepared to make changes, so if there is anything you do not like, please state explicitly what you would like *instead*. Thank you.\r\n\r\nLet's get this done.","created_at":"2015-08-23T14:54:24Z","updated_at":"2015-09-01T12:31:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f08ffa44b786c66b96234c7aa4798514ec2c4a8c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Alexpux/Cygwin/pulls/8/commits","review_comments_url":"https://api.github.com/repos/Alexpux/Cygwin/pulls/8/comments","review_comment_url":"https://api.github.com/repos/Alexpux/Cygwin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alexpux/Cygwin/issues/8/comments","statuses_url":"https://api.github.com/repos/Alexpux/Cygwin/statuses/6d58126abf0d76109678483e4cc892c5f74a93b3","head":{"label":"dscho:git-for-windows","ref":"git-for-windows","sha":"6d58126abf0d76109678483e4cc892c5f74a93b3","user":{"login":"dscho","id":127790,"avatar_url":"https://avatars.githubusercontent.com/u/127790?v=3","gravatar_id":"","url":"https://api.github.com/users/dscho","html_url":"https://github.com/dscho","followers_url":"https://api.github.com/users/dscho/followers","following_url":"https://api.github.com/users/dscho/following{/other_user}","gists_url":"https://api.github.com/users/dscho/gists{/gist_id}","starred_url":"https://api.github.com/users/dscho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dscho/subscriptions","organizations_url":"https://api.github.com/users/dscho/orgs","repos_url":"https://api.github.com/users/dscho/repos","events_url":"https://api.github.com/users/dscho/events{/privacy}","received_events_url":"https://api.github.com/users/dscho/received_events","type":"User","site_admin":false},"repo":{"id":30825814,"name":"msys2-runtime","full_name":"dscho/msys2-runtime","owner":{"login":"dscho","id":127790,"avatar_url":"https://avatars.githubusercontent.com/u/127790?v=3","gravatar_id":"","url":"https://api.github.com/users/dscho","html_url":"https://github.com/dscho","followers_url":"https://api.github.com/users/dscho/followers","following_url":"https://api.github.com/users/dscho/following{/other_user}","gists_url":"https://api.github.com/users/dscho/gists{/gist_id}","starred_url":"https://api.github.com/users/dscho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dscho/subscriptions","organizations_url":"https://api.github.com/users/dscho/orgs","repos_url":"https://api.github.com/users/dscho/repos","events_url":"https://api.github.com/users/dscho/events{/privacy}","received_events_url":"https://api.github.com/users/dscho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dscho/msys2-runtime","description":"Track CYGWIN changes from cvs repository","fork":true,"url":"https://api.github.com/repos/dscho/msys2-runtime","forks_url":"https://api.github.com/repos/dscho/msys2-runtime/forks","keys_url":"https://api.github.com/repos/dscho/msys2-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dscho/msys2-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dscho/msys2-runtime/teams","hooks_url":"https://api.github.com/repos/dscho/msys2-runtime/hooks","issue_events_url":"https://api.github.com/repos/dscho/msys2-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/dscho/msys2-runtime/events","assignees_url":"https://api.github.com/repos/dscho/msys2-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/dscho/msys2-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/dscho/msys2-runtime/tags","blobs_url":"https://api.github.com/repos/dscho/msys2-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dscho/msys2-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dscho/msys2-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/dscho/msys2-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dscho/msys2-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/dscho/msys2-runtime/languages","stargazers_url":"https://api.github.com/repos/dscho/msys2-runtime/stargazers","contributors_url":"https://api.github.com/repos/dscho/msys2-runtime/contributors","subscribers_url":"https://api.github.com/repos/dscho/msys2-runtime/subscribers","subscription_url":"https://api.github.com/repos/dscho/msys2-runtime/subscription","commits_url":"https://api.github.com/repos/dscho/msys2-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/dscho/msys2-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/dscho/msys2-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/dscho/msys2-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/dscho/msys2-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/dscho/msys2-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dscho/msys2-runtime/merges","archive_url":"https://api.github.com/repos/dscho/msys2-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dscho/msys2-runtime/downloads","issues_url":"https://api.github.com/repos/dscho/msys2-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/dscho/msys2-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/dscho/msys2-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/dscho/msys2-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dscho/msys2-runtime/labels{/name}","releases_url":"https://api.github.com/repos/dscho/msys2-runtime/releases{/id}","created_at":"2015-02-15T11:40:46Z","updated_at":"2015-02-22T17:45:14Z","pushed_at":"2015-08-28T12:05:19Z","git_url":"git://github.com/dscho/msys2-runtime.git","ssh_url":"git@github.com:dscho/msys2-runtime.git","clone_url":"https://github.com/dscho/msys2-runtime.git","svn_url":"https://github.com/dscho/msys2-runtime","homepage":null,"size":104732,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Alexpux:msys2-master","ref":"msys2-master","sha":"c31530c42925be613655c4a25e99249aac29a125","user":{"login":"Alexpux","id":1898153,"avatar_url":"https://avatars.githubusercontent.com/u/1898153?v=3","gravatar_id":"","url":"https://api.github.com/users/Alexpux","html_url":"https://github.com/Alexpux","followers_url":"https://api.github.com/users/Alexpux/followers","following_url":"https://api.github.com/users/Alexpux/following{/other_user}","gists_url":"https://api.github.com/users/Alexpux/gists{/gist_id}","starred_url":"https://api.github.com/users/Alexpux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alexpux/subscriptions","organizations_url":"https://api.github.com/users/Alexpux/orgs","repos_url":"https://api.github.com/users/Alexpux/repos","events_url":"https://api.github.com/users/Alexpux/events{/privacy}","received_events_url":"https://api.github.com/users/Alexpux/received_events","type":"User","site_admin":false},"repo":{"id":7217575,"name":"Cygwin","full_name":"Alexpux/Cygwin","owner":{"login":"Alexpux","id":1898153,"avatar_url":"https://avatars.githubusercontent.com/u/1898153?v=3","gravatar_id":"","url":"https://api.github.com/users/Alexpux","html_url":"https://github.com/Alexpux","followers_url":"https://api.github.com/users/Alexpux/followers","following_url":"https://api.github.com/users/Alexpux/following{/other_user}","gists_url":"https://api.github.com/users/Alexpux/gists{/gist_id}","starred_url":"https://api.github.com/users/Alexpux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alexpux/subscriptions","organizations_url":"https://api.github.com/users/Alexpux/orgs","repos_url":"https://api.github.com/users/Alexpux/repos","events_url":"https://api.github.com/users/Alexpux/events{/privacy}","received_events_url":"https://api.github.com/users/Alexpux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Alexpux/Cygwin","description":"Track CYGWIN changes from git repository","fork":false,"url":"https://api.github.com/repos/Alexpux/Cygwin","forks_url":"https://api.github.com/repos/Alexpux/Cygwin/forks","keys_url":"https://api.github.com/repos/Alexpux/Cygwin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alexpux/Cygwin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alexpux/Cygwin/teams","hooks_url":"https://api.github.com/repos/Alexpux/Cygwin/hooks","issue_events_url":"https://api.github.com/repos/Alexpux/Cygwin/issues/events{/number}","events_url":"https://api.github.com/repos/Alexpux/Cygwin/events","assignees_url":"https://api.github.com/repos/Alexpux/Cygwin/assignees{/user}","branches_url":"https://api.github.com/repos/Alexpux/Cygwin/branches{/branch}","tags_url":"https://api.github.com/repos/Alexpux/Cygwin/tags","blobs_url":"https://api.github.com/repos/Alexpux/Cygwin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alexpux/Cygwin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alexpux/Cygwin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alexpux/Cygwin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alexpux/Cygwin/statuses/{sha}","languages_url":"https://api.github.com/repos/Alexpux/Cygwin/languages","stargazers_url":"https://api.github.com/repos/Alexpux/Cygwin/stargazers","contributors_url":"https://api.github.com/repos/Alexpux/Cygwin/contributors","subscribers_url":"https://api.github.com/repos/Alexpux/Cygwin/subscribers","subscription_url":"https://api.github.com/repos/Alexpux/Cygwin/subscription","commits_url":"https://api.github.com/repos/Alexpux/Cygwin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alexpux/Cygwin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alexpux/Cygwin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alexpux/Cygwin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alexpux/Cygwin/contents/{+path}","compare_url":"https://api.github.com/repos/Alexpux/Cygwin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alexpux/Cygwin/merges","archive_url":"https://api.github.com/repos/Alexpux/Cygwin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alexpux/Cygwin/downloads","issues_url":"https://api.github.com/repos/Alexpux/Cygwin/issues{/number}","pulls_url":"https://api.github.com/repos/Alexpux/Cygwin/pulls{/number}","milestones_url":"https://api.github.com/repos/Alexpux/Cygwin/milestones{/number}","notifications_url":"https://api.github.com/repos/Alexpux/Cygwin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alexpux/Cygwin/labels{/name}","releases_url":"https://api.github.com/repos/Alexpux/Cygwin/releases{/id}","created_at":"2012-12-18T04:35:54Z","updated_at":"2015-08-06T12:53:14Z","pushed_at":"2015-09-01T10:36:32Z","git_url":"git://github.com/Alexpux/Cygwin.git","ssh_url":"git@github.com:Alexpux/Cygwin.git","clone_url":"https://github.com/Alexpux/Cygwin.git","svn_url":"https://github.com/Alexpux/Cygwin","homepage":"","size":123989,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alexpux/Cygwin/pulls/8"},"html":{"href":"https://github.com/Alexpux/Cygwin/pull/8"},"issue":{"href":"https://api.github.com/repos/Alexpux/Cygwin/issues/8"},"comments":{"href":"https://api.github.com/repos/Alexpux/Cygwin/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/Alexpux/Cygwin/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/Alexpux/Cygwin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alexpux/Cygwin/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/Alexpux/Cygwin/statuses/6d58126abf0d76109678483e4cc892c5f74a93b3"}}}}