{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/27075571","id":27075571,"diff_hunk":"@@ -54,12 +54,12 @@ public string GetPropertyValue(string name)\n \n         protected class BuildResult\n         {\n-            public readonly MSB.Execution.BuildResult Result;\n+            public readonly bool Built;","path":"src/Workspaces/Core/Desktop/Workspace/MSBuild/ProjectFile/ProjectFile.cs","position":5,"original_position":5,"commit_id":"868417d3e5fa73e700430577611ed1b94d732be1","original_commit_id":"868417d3e5fa73e700430577611ed1b94d732be1","user":{"login":"petr-k","id":376925,"avatar_url":"https://avatars.githubusercontent.com/u/376925?v=3","gravatar_id":"","url":"https://api.github.com/users/petr-k","html_url":"https://github.com/petr-k","followers_url":"https://api.github.com/users/petr-k/followers","following_url":"https://api.github.com/users/petr-k/following{/other_user}","gists_url":"https://api.github.com/users/petr-k/gists{/gist_id}","starred_url":"https://api.github.com/users/petr-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petr-k/subscriptions","organizations_url":"https://api.github.com/users/petr-k/orgs","repos_url":"https://api.github.com/users/petr-k/repos","events_url":"https://api.github.com/users/petr-k/events{/privacy}","received_events_url":"https://api.github.com/users/petr-k/received_events","type":"User","site_admin":false},"body":"OK, will do. Should I get rid of the `BuildResult` class as well then, since it would hold just the MSBuild executed project's `ProjectInstance`?","created_at":"2015-03-24T21:32:52Z","updated_at":"2015-03-24T21:32:52Z","html_url":"https://github.com/dotnet/roslyn/pull/1531#discussion_r27075571","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/1531","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/27075571"},"html":{"href":"https://github.com/dotnet/roslyn/pull/1531#discussion_r27075571"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/1531"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/1531","id":31860321,"html_url":"https://github.com/dotnet/roslyn/pull/1531","diff_url":"https://github.com/dotnet/roslyn/pull/1531.diff","patch_url":"https://github.com/dotnet/roslyn/pull/1531.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/1531","number":1531,"state":"open","locked":false,"title":"Fixes opening a project without the CSharp or Visual Basic target imports","user":{"login":"petr-k","id":376925,"avatar_url":"https://avatars.githubusercontent.com/u/376925?v=3","gravatar_id":"","url":"https://api.github.com/users/petr-k","html_url":"https://github.com/petr-k","followers_url":"https://api.github.com/users/petr-k/followers","following_url":"https://api.github.com/users/petr-k/following{/other_user}","gists_url":"https://api.github.com/users/petr-k/gists{/gist_id}","starred_url":"https://api.github.com/users/petr-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petr-k/subscriptions","organizations_url":"https://api.github.com/users/petr-k/orgs","repos_url":"https://api.github.com/users/petr-k/repos","events_url":"https://api.github.com/users/petr-k/events{/privacy}","received_events_url":"https://api.github.com/users/petr-k/received_events","type":"User","site_admin":false},"body":"Fixes issue #1096 - when opening a project, MSBuild throws that no `Compile` target is present. This can happen if the project file does not contain the CSharp or VB target imports.\r\n\r\nHowever, we would expect Roslyn to open the project fine, just as Visual Studio does, and be able to perform code analysis on the project although it cannot be compiled using MSBuild.\r\n\r\nFor projects without a `Compile` target, the fix in this PR bypasses the default mechanism of compiler input collection, which involves \"executing\" MSBuild while providing a host with numerous callbacks. When this is bypassed and the MSBuild compilation tasks are thus not reached, the compiler inputs are initialized and populated based on the project model - this behavior is already implemented in both `Microsoft.CodeAnalysis.CSharp.CSharpProjectFileLoader.CSharpProjectFile` and `Microsoft.CodeAnalysis.VisualBasic.VisualBasicProjectFileLoader.VisualBasicProjectFile` classes.\r\n","created_at":"2015-03-24T19:13:21Z","updated_at":"2015-03-24T21:32:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f44dfb4107b19d4d20bbb57dbcd6e78f1bd0f9f7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/1531/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/1531/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/1531/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/868417d3e5fa73e700430577611ed1b94d732be1","head":{"label":"petr-k:MSBuildWorkspaceCompileTargetFix","ref":"MSBuildWorkspaceCompileTargetFix","sha":"868417d3e5fa73e700430577611ed1b94d732be1","user":{"login":"petr-k","id":376925,"avatar_url":"https://avatars.githubusercontent.com/u/376925?v=3","gravatar_id":"","url":"https://api.github.com/users/petr-k","html_url":"https://github.com/petr-k","followers_url":"https://api.github.com/users/petr-k/followers","following_url":"https://api.github.com/users/petr-k/following{/other_user}","gists_url":"https://api.github.com/users/petr-k/gists{/gist_id}","starred_url":"https://api.github.com/users/petr-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petr-k/subscriptions","organizations_url":"https://api.github.com/users/petr-k/orgs","repos_url":"https://api.github.com/users/petr-k/repos","events_url":"https://api.github.com/users/petr-k/events{/privacy}","received_events_url":"https://api.github.com/users/petr-k/received_events","type":"User","site_admin":false},"repo":{"id":31558598,"name":"roslyn","full_name":"petr-k/roslyn","owner":{"login":"petr-k","id":376925,"avatar_url":"https://avatars.githubusercontent.com/u/376925?v=3","gravatar_id":"","url":"https://api.github.com/users/petr-k","html_url":"https://github.com/petr-k","followers_url":"https://api.github.com/users/petr-k/followers","following_url":"https://api.github.com/users/petr-k/following{/other_user}","gists_url":"https://api.github.com/users/petr-k/gists{/gist_id}","starred_url":"https://api.github.com/users/petr-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petr-k/subscriptions","organizations_url":"https://api.github.com/users/petr-k/orgs","repos_url":"https://api.github.com/users/petr-k/repos","events_url":"https://api.github.com/users/petr-k/events{/privacy}","received_events_url":"https://api.github.com/users/petr-k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petr-k/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/petr-k/roslyn","forks_url":"https://api.github.com/repos/petr-k/roslyn/forks","keys_url":"https://api.github.com/repos/petr-k/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petr-k/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petr-k/roslyn/teams","hooks_url":"https://api.github.com/repos/petr-k/roslyn/hooks","issue_events_url":"https://api.github.com/repos/petr-k/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/petr-k/roslyn/events","assignees_url":"https://api.github.com/repos/petr-k/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/petr-k/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/petr-k/roslyn/tags","blobs_url":"https://api.github.com/repos/petr-k/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petr-k/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petr-k/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/petr-k/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petr-k/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/petr-k/roslyn/languages","stargazers_url":"https://api.github.com/repos/petr-k/roslyn/stargazers","contributors_url":"https://api.github.com/repos/petr-k/roslyn/contributors","subscribers_url":"https://api.github.com/repos/petr-k/roslyn/subscribers","subscription_url":"https://api.github.com/repos/petr-k/roslyn/subscription","commits_url":"https://api.github.com/repos/petr-k/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/petr-k/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/petr-k/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/petr-k/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/petr-k/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/petr-k/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petr-k/roslyn/merges","archive_url":"https://api.github.com/repos/petr-k/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petr-k/roslyn/downloads","issues_url":"https://api.github.com/repos/petr-k/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/petr-k/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/petr-k/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/petr-k/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petr-k/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/petr-k/roslyn/releases{/id}","created_at":"2015-03-02T19:29:03Z","updated_at":"2015-03-24T18:34:37Z","pushed_at":"2015-03-24T20:45:08Z","git_url":"git://github.com/petr-k/roslyn.git","ssh_url":"git@github.com:petr-k/roslyn.git","clone_url":"https://github.com/petr-k/roslyn.git","svn_url":"https://github.com/petr-k/roslyn","homepage":"","size":61185,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"684101a0ffe9a2bfddaab6e672797ede5b94f742","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-03-24T20:48:15Z","pushed_at":"2015-03-24T21:18:50Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":96254,"stargazers_count":1608,"watchers_count":1608,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":332,"mirror_url":null,"open_issues_count":616,"forks":332,"open_issues":616,"watchers":1608,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/1531"},"html":{"href":"https://github.com/dotnet/roslyn/pull/1531"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/1531"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/1531/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/1531/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/1531/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/868417d3e5fa73e700430577611ed1b94d732be1"}}}}