{"action":"created","comment":{"url":"https://api.github.com/repos/webrtc/adapter/pulls/comments/31028721","id":31028721,"diff_hunk":"@@ -63,9 +64,47 @@ if (navigator.mozGetUserMedia) {\n   // The RTCIceCandidate object.\n   window.RTCIceCandidate = mozRTCIceCandidate;\n \n-  // getUserMedia shim (only difference is the prefix).\n-  // Code from Adam Barth.\n-  getUserMedia = navigator.mozGetUserMedia.bind(navigator);\n+  // getUserMedia constraints shim.\n+  getUserMedia = (webrtcDetectedVersion < 38) ?\n+      function(c, onSuccess, onError) {\n+    var constraintsToFF37 = function(c) {","path":"adapter.js","position":18,"original_position":18,"commit_id":"ceb10d3440c7cfdd6105cc62f25a2947952d3b53","original_commit_id":"ceb10d3440c7cfdd6105cc62f25a2947952d3b53","user":{"login":"alvestrand","id":480893,"avatar_url":"https://avatars.githubusercontent.com/u/480893?v=3","gravatar_id":"","url":"https://api.github.com/users/alvestrand","html_url":"https://github.com/alvestrand","followers_url":"https://api.github.com/users/alvestrand/followers","following_url":"https://api.github.com/users/alvestrand/following{/other_user}","gists_url":"https://api.github.com/users/alvestrand/gists{/gist_id}","starred_url":"https://api.github.com/users/alvestrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvestrand/subscriptions","organizations_url":"https://api.github.com/users/alvestrand/orgs","repos_url":"https://api.github.com/users/alvestrand/repos","events_url":"https://api.github.com/users/alvestrand/events{/privacy}","received_events_url":"https://api.github.com/users/alvestrand/received_events","type":"User","site_admin":false},"body":"We would want some tests of this function - it's complex enough that there can be errors.\r\nThe FF37 format seems not to be the \"mandatory/optional\" of previous specifications - is it a FF37 only format?\r\nWhat happens on earlier Firefox versions?","created_at":"2015-05-26T12:44:40Z","updated_at":"2015-05-26T12:44:40Z","html_url":"https://github.com/webrtc/adapter/pull/22#discussion_r31028721","pull_request_url":"https://api.github.com/repos/webrtc/adapter/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/webrtc/adapter/pulls/comments/31028721"},"html":{"href":"https://github.com/webrtc/adapter/pull/22#discussion_r31028721"},"pull_request":{"href":"https://api.github.com/repos/webrtc/adapter/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/webrtc/adapter/pulls/22","id":32861242,"html_url":"https://github.com/webrtc/adapter/pull/22","diff_url":"https://github.com/webrtc/adapter/pull/22.diff","patch_url":"https://github.com/webrtc/adapter/pull/22.patch","issue_url":"https://api.github.com/repos/webrtc/adapter/issues/22","number":22,"state":"open","locked":false,"title":"Modern constraints polyfill in adapter.js","user":{"login":"jan-ivar","id":3136226,"avatar_url":"https://avatars.githubusercontent.com/u/3136226?v=3","gravatar_id":"","url":"https://api.github.com/users/jan-ivar","html_url":"https://github.com/jan-ivar","followers_url":"https://api.github.com/users/jan-ivar/followers","following_url":"https://api.github.com/users/jan-ivar/following{/other_user}","gists_url":"https://api.github.com/users/jan-ivar/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-ivar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-ivar/subscriptions","organizations_url":"https://api.github.com/users/jan-ivar/orgs","repos_url":"https://api.github.com/users/jan-ivar/repos","events_url":"https://api.github.com/users/jan-ivar/events{/privacy}","received_events_url":"https://api.github.com/users/jan-ivar/received_events","type":"User","site_admin":false},"body":"See https://github.com/webrtc/samples/pull/493","created_at":"2015-04-08T13:46:54Z","updated_at":"2015-05-26T12:44:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fafa279d8c5cc0637380fd09e57254428c8fc027","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/webrtc/adapter/pulls/22/commits","review_comments_url":"https://api.github.com/repos/webrtc/adapter/pulls/22/comments","review_comment_url":"https://api.github.com/repos/webrtc/adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webrtc/adapter/issues/22/comments","statuses_url":"https://api.github.com/repos/webrtc/adapter/statuses/ceb10d3440c7cfdd6105cc62f25a2947952d3b53","head":{"label":"jan-ivar:polyconstraints","ref":"polyconstraints","sha":"ceb10d3440c7cfdd6105cc62f25a2947952d3b53","user":{"login":"jan-ivar","id":3136226,"avatar_url":"https://avatars.githubusercontent.com/u/3136226?v=3","gravatar_id":"","url":"https://api.github.com/users/jan-ivar","html_url":"https://github.com/jan-ivar","followers_url":"https://api.github.com/users/jan-ivar/followers","following_url":"https://api.github.com/users/jan-ivar/following{/other_user}","gists_url":"https://api.github.com/users/jan-ivar/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-ivar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-ivar/subscriptions","organizations_url":"https://api.github.com/users/jan-ivar/orgs","repos_url":"https://api.github.com/users/jan-ivar/repos","events_url":"https://api.github.com/users/jan-ivar/events{/privacy}","received_events_url":"https://api.github.com/users/jan-ivar/received_events","type":"User","site_admin":false},"repo":{"id":33608409,"name":"adapter","full_name":"jan-ivar/adapter","owner":{"login":"jan-ivar","id":3136226,"avatar_url":"https://avatars.githubusercontent.com/u/3136226?v=3","gravatar_id":"","url":"https://api.github.com/users/jan-ivar","html_url":"https://github.com/jan-ivar","followers_url":"https://api.github.com/users/jan-ivar/followers","following_url":"https://api.github.com/users/jan-ivar/following{/other_user}","gists_url":"https://api.github.com/users/jan-ivar/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-ivar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-ivar/subscriptions","organizations_url":"https://api.github.com/users/jan-ivar/orgs","repos_url":"https://api.github.com/users/jan-ivar/repos","events_url":"https://api.github.com/users/jan-ivar/events{/privacy}","received_events_url":"https://api.github.com/users/jan-ivar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jan-ivar/adapter","description":"Shim to insulate apps from spec changes and prefix differences.","fork":true,"url":"https://api.github.com/repos/jan-ivar/adapter","forks_url":"https://api.github.com/repos/jan-ivar/adapter/forks","keys_url":"https://api.github.com/repos/jan-ivar/adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jan-ivar/adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jan-ivar/adapter/teams","hooks_url":"https://api.github.com/repos/jan-ivar/adapter/hooks","issue_events_url":"https://api.github.com/repos/jan-ivar/adapter/issues/events{/number}","events_url":"https://api.github.com/repos/jan-ivar/adapter/events","assignees_url":"https://api.github.com/repos/jan-ivar/adapter/assignees{/user}","branches_url":"https://api.github.com/repos/jan-ivar/adapter/branches{/branch}","tags_url":"https://api.github.com/repos/jan-ivar/adapter/tags","blobs_url":"https://api.github.com/repos/jan-ivar/adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jan-ivar/adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jan-ivar/adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/jan-ivar/adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jan-ivar/adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/jan-ivar/adapter/languages","stargazers_url":"https://api.github.com/repos/jan-ivar/adapter/stargazers","contributors_url":"https://api.github.com/repos/jan-ivar/adapter/contributors","subscribers_url":"https://api.github.com/repos/jan-ivar/adapter/subscribers","subscription_url":"https://api.github.com/repos/jan-ivar/adapter/subscription","commits_url":"https://api.github.com/repos/jan-ivar/adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/jan-ivar/adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/jan-ivar/adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/jan-ivar/adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/jan-ivar/adapter/contents/{+path}","compare_url":"https://api.github.com/repos/jan-ivar/adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jan-ivar/adapter/merges","archive_url":"https://api.github.com/repos/jan-ivar/adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jan-ivar/adapter/downloads","issues_url":"https://api.github.com/repos/jan-ivar/adapter/issues{/number}","pulls_url":"https://api.github.com/repos/jan-ivar/adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/jan-ivar/adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/jan-ivar/adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jan-ivar/adapter/labels{/name}","releases_url":"https://api.github.com/repos/jan-ivar/adapter/releases{/id}","created_at":"2015-04-08T13:26:32Z","updated_at":"2015-04-08T13:26:32Z","pushed_at":"2015-04-09T18:55:22Z","git_url":"git://github.com/jan-ivar/adapter.git","ssh_url":"git@github.com:jan-ivar/adapter.git","clone_url":"https://github.com/jan-ivar/adapter.git","svn_url":"https://github.com/jan-ivar/adapter","homepage":null,"size":2846,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webrtc:master","ref":"master","sha":"c0d55c598119a53bada9039562595a683957fae6","user":{"login":"webrtc","id":10526312,"avatar_url":"https://avatars.githubusercontent.com/u/10526312?v=3","gravatar_id":"","url":"https://api.github.com/users/webrtc","html_url":"https://github.com/webrtc","followers_url":"https://api.github.com/users/webrtc/followers","following_url":"https://api.github.com/users/webrtc/following{/other_user}","gists_url":"https://api.github.com/users/webrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/webrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webrtc/subscriptions","organizations_url":"https://api.github.com/users/webrtc/orgs","repos_url":"https://api.github.com/users/webrtc/repos","events_url":"https://api.github.com/users/webrtc/events{/privacy}","received_events_url":"https://api.github.com/users/webrtc/received_events","type":"Organization","site_admin":false},"repo":{"id":30027163,"name":"adapter","full_name":"webrtc/adapter","owner":{"login":"webrtc","id":10526312,"avatar_url":"https://avatars.githubusercontent.com/u/10526312?v=3","gravatar_id":"","url":"https://api.github.com/users/webrtc","html_url":"https://github.com/webrtc","followers_url":"https://api.github.com/users/webrtc/followers","following_url":"https://api.github.com/users/webrtc/following{/other_user}","gists_url":"https://api.github.com/users/webrtc/gists{/gist_id}","starred_url":"https://api.github.com/users/webrtc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webrtc/subscriptions","organizations_url":"https://api.github.com/users/webrtc/orgs","repos_url":"https://api.github.com/users/webrtc/repos","events_url":"https://api.github.com/users/webrtc/events{/privacy}","received_events_url":"https://api.github.com/users/webrtc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webrtc/adapter","description":"Shim to insulate apps from spec changes and prefix differences.","fork":false,"url":"https://api.github.com/repos/webrtc/adapter","forks_url":"https://api.github.com/repos/webrtc/adapter/forks","keys_url":"https://api.github.com/repos/webrtc/adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webrtc/adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webrtc/adapter/teams","hooks_url":"https://api.github.com/repos/webrtc/adapter/hooks","issue_events_url":"https://api.github.com/repos/webrtc/adapter/issues/events{/number}","events_url":"https://api.github.com/repos/webrtc/adapter/events","assignees_url":"https://api.github.com/repos/webrtc/adapter/assignees{/user}","branches_url":"https://api.github.com/repos/webrtc/adapter/branches{/branch}","tags_url":"https://api.github.com/repos/webrtc/adapter/tags","blobs_url":"https://api.github.com/repos/webrtc/adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webrtc/adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webrtc/adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/webrtc/adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webrtc/adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/webrtc/adapter/languages","stargazers_url":"https://api.github.com/repos/webrtc/adapter/stargazers","contributors_url":"https://api.github.com/repos/webrtc/adapter/contributors","subscribers_url":"https://api.github.com/repos/webrtc/adapter/subscribers","subscription_url":"https://api.github.com/repos/webrtc/adapter/subscription","commits_url":"https://api.github.com/repos/webrtc/adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/webrtc/adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/webrtc/adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/webrtc/adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/webrtc/adapter/contents/{+path}","compare_url":"https://api.github.com/repos/webrtc/adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webrtc/adapter/merges","archive_url":"https://api.github.com/repos/webrtc/adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webrtc/adapter/downloads","issues_url":"https://api.github.com/repos/webrtc/adapter/issues{/number}","pulls_url":"https://api.github.com/repos/webrtc/adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/webrtc/adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/webrtc/adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webrtc/adapter/labels{/name}","releases_url":"https://api.github.com/repos/webrtc/adapter/releases{/id}","created_at":"2015-01-29T15:41:40Z","updated_at":"2015-05-24T18:31:29Z","pushed_at":"2015-05-26T11:50:02Z","git_url":"git://github.com/webrtc/adapter.git","ssh_url":"git@github.com:webrtc/adapter.git","clone_url":"https://github.com/webrtc/adapter.git","svn_url":"https://github.com/webrtc/adapter","homepage":null,"size":3174,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":12,"forks":21,"open_issues":12,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webrtc/adapter/pulls/22"},"html":{"href":"https://github.com/webrtc/adapter/pull/22"},"issue":{"href":"https://api.github.com/repos/webrtc/adapter/issues/22"},"comments":{"href":"https://api.github.com/repos/webrtc/adapter/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/webrtc/adapter/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/webrtc/adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webrtc/adapter/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/webrtc/adapter/statuses/ceb10d3440c7cfdd6105cc62f25a2947952d3b53"}}}}