{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/pulls/comments/39625207","id":39625207,"diff_hunk":"@@ -0,0 +1,83 @@\n+# Contributing\n+\n+Anyone is welcome to help with Firefox Accounts. Feel free to get in touch with other community members on IRC, the\n+mailing list or through issues here on GitHub.\n+\n+- IRC: `#fxa` on `irc.mozilla.org`\n+- Mailing list: <https://mail.mozilla.org/listinfo/dev-fxacct>\n+- and of course, [the issues list](https://github.com/mozilla/fxa-basket-proxy/issues)\n+\n+## Bug Reports ##\n+\n+You can file issues here on GitHub. Please try to include as much information as you can and under what conditions\n+you saw the issue.\n+\n+## Sending Pull Requests ##\n+\n+Patches should be submitted as pull requests (PR).\n+\n+Before submitting a PR:\n+- Your code must run and pass all the automated tests before you submit your PR for review. \"Work in progress\" pull requests are allowed to be submitted, but should be clearly labeled as such and should not be merged until all tests pass and the code has been reviewed.\n+  - Run `grunt lint` to make sure your code passes linting.\n+  - Run `npm test` to make sure all tests still pass.\n+- Your patch should include new tests that cover your changes. It is your and your reviewer's responsibility to ensure your patch includes adequate tests.\n+\n+When submitting a PR:\n+- You agree to license your code under the project's open source license ([MPL 2.0](/LICENSE)).\n+- Base your branch off the current `master` (see below for an example workflow).\n+- Add both your code and new tests if relevant.\n+- Run `grunt eslint` and `npm test` to make sure your code passes linting and tests.\n+- Please do not include merge commits in pull requests; include only commits with the new relevant code.\n+\n+After your PR is merged:\n+- Add yourself to the [AUTHORS](/AUTHORS) file so we can publicly recognize your contribution.\n+\n+See the main [README.md](/README.md) for information on prerequisites, installing, running and testing.\n+\n+## Code Review ##\n+\n+This project is production Mozilla code and subject to our [engineering practices and quality standards](https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities). Every patch must be peer reviewed. This project is part of the [Firefox Accounts module](https://wiki.mozilla.org/Modules/Other#Firefox_Accounts), and your patch must be reviewed by one of the listed module owners or peers.\n+\n+## Example Workflow ##","path":"CONTRIBUTING.md","position":41,"original_position":41,"commit_id":"339d881e5fdcc54c860bacf8a4c200b0ed8e6b98","original_commit_id":"339d881e5fdcc54c860bacf8a4c200b0ed8e6b98","user":{"login":"shane-tomlinson","id":848085,"avatar_url":"https://avatars.githubusercontent.com/u/848085?v=3","gravatar_id":"","url":"https://api.github.com/users/shane-tomlinson","html_url":"https://github.com/shane-tomlinson","followers_url":"https://api.github.com/users/shane-tomlinson/followers","following_url":"https://api.github.com/users/shane-tomlinson/following{/other_user}","gists_url":"https://api.github.com/users/shane-tomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/shane-tomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shane-tomlinson/subscriptions","organizations_url":"https://api.github.com/users/shane-tomlinson/orgs","repos_url":"https://api.github.com/users/shane-tomlinson/repos","events_url":"https://api.github.com/users/shane-tomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/shane-tomlinson/received_events","type":"User","site_admin":false},"body":"The example workflow section is awesome documentation and should be added to the content server and any other repo that could benefit from it.","created_at":"2015-09-16T12:53:49Z","updated_at":"2015-09-16T12:53:49Z","html_url":"https://github.com/mozilla/fxa-basket-proxy/pull/2#discussion_r39625207","pull_request_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-basket-proxy/pulls/comments/39625207"},"html":{"href":"https://github.com/mozilla/fxa-basket-proxy/pull/2#discussion_r39625207"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-basket-proxy/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/pulls/2","id":44623839,"html_url":"https://github.com/mozilla/fxa-basket-proxy/pull/2","diff_url":"https://github.com/mozilla/fxa-basket-proxy/pull/2.diff","patch_url":"https://github.com/mozilla/fxa-basket-proxy/pull/2.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/issues/2","number":2,"state":"open","locked":false,"title":"Split out fxa-basket-proxy into a standalone project.","user":{"login":"rfk","id":34695,"avatar_url":"https://avatars.githubusercontent.com/u/34695?v=3","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"body":"This commit imports the fxa-basket-proxy code from [1] as a standalone\r\nproject, splitting it up into smaller chunks and adding some basic\r\nrepo infrastructure and tests.  The logic of the code itself is unchanged\r\napart from some config-loading and logging tweaks.\r\n\r\n[1] https://github.com/mozilla/fxa-content-server/blob/13a59b2457d373190f1853c513604a5b72bb5106/server/bin/basket-proxy-server.js","created_at":"2015-09-10T03:09:30Z","updated_at":"2015-09-16T12:53:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4485257cc1c2a7ca7c637e6b369f2037ab3ad5c5","assignee":{"login":"zaach","id":3903,"avatar_url":"https://avatars.githubusercontent.com/u/3903?v=3","gravatar_id":"","url":"https://api.github.com/users/zaach","html_url":"https://github.com/zaach","followers_url":"https://api.github.com/users/zaach/followers","following_url":"https://api.github.com/users/zaach/following{/other_user}","gists_url":"https://api.github.com/users/zaach/gists{/gist_id}","starred_url":"https://api.github.com/users/zaach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaach/subscriptions","organizations_url":"https://api.github.com/users/zaach/orgs","repos_url":"https://api.github.com/users/zaach/repos","events_url":"https://api.github.com/users/zaach/events{/privacy}","received_events_url":"https://api.github.com/users/zaach/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/milestones/12","html_url":"https://github.com/mozilla/fxa-basket-proxy/milestones/FxA-44:%20journeybuilder%20events","labels_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/milestones/12/labels","id":1289576,"number":12,"title":"FxA-44: journeybuilder events","description":"https://mozilla.aha.io/features/FXA-44","creator":{"login":"rfk","id":34695,"avatar_url":"https://avatars.githubusercontent.com/u/34695?v=3","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2015-09-04T06:09:13Z","updated_at":"2015-09-10T03:10:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/pulls/2/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/pulls/2/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/issues/2/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/statuses/339d881e5fdcc54c860bacf8a4c200b0ed8e6b98","head":{"label":"mozilla:initial-import-and-refactor","ref":"initial-import-and-refactor","sha":"339d881e5fdcc54c860bacf8a4c200b0ed8e6b98","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":36958680,"name":"fxa-basket-proxy","full_name":"mozilla/fxa-basket-proxy","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-basket-proxy","description":"Proxy server adding FxA authentication in front of basket","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-basket-proxy","forks_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/releases{/id}","created_at":"2015-06-05T22:32:46Z","updated_at":"2015-09-08T04:51:18Z","pushed_at":"2015-09-11T07:49:51Z","git_url":"git://github.com/mozilla/fxa-basket-proxy.git","ssh_url":"git@github.com:mozilla/fxa-basket-proxy.git","clone_url":"https://github.com/mozilla/fxa-basket-proxy.git","svn_url":"https://github.com/mozilla/fxa-basket-proxy","homepage":null,"size":236,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"4c0b000b77f73fa7f71e733e5e0d9694fac76a39","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":36958680,"name":"fxa-basket-proxy","full_name":"mozilla/fxa-basket-proxy","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-basket-proxy","description":"Proxy server adding FxA authentication in front of basket","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-basket-proxy","forks_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-basket-proxy/releases{/id}","created_at":"2015-06-05T22:32:46Z","updated_at":"2015-09-08T04:51:18Z","pushed_at":"2015-09-11T07:49:51Z","git_url":"git://github.com/mozilla/fxa-basket-proxy.git","ssh_url":"git@github.com:mozilla/fxa-basket-proxy.git","clone_url":"https://github.com/mozilla/fxa-basket-proxy.git","svn_url":"https://github.com/mozilla/fxa-basket-proxy","homepage":null,"size":236,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-basket-proxy/pulls/2"},"html":{"href":"https://github.com/mozilla/fxa-basket-proxy/pull/2"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-basket-proxy/issues/2"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-basket-proxy/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-basket-proxy/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-basket-proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-basket-proxy/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-basket-proxy/statuses/339d881e5fdcc54c860bacf8a4c200b0ed8e6b98"}}}}