{"action":"created","comment":{"url":"https://api.github.com/repos/openzipkin/docker-zipkin/pulls/comments/34280941","id":34280941,"diff_hunk":"@@ -0,0 +1,25 @@\n+cassandra:\n+  image: itszero/zipkin-cassandra\n+collector:\n+  image: itszero/zipkin-collector\n+  expose:\n+    - 9410\n+  ports:\n+    - 9410:9410\n+  links:\n+    - cassandra:db\n+query:\n+  image: itszero/zipkin-query\n+  expose:\n+    - 9411\n+  links:\n+    - cassandra:db\n+web:\n+  image: itszero/zipkin-web\n+  links:\n+    - query\n+  ports:\n+    - 8080:8080\n+  environment: {\n+    ROOTURL: \"http://172.17.42.1:8080\"","path":"deploy/docker-compose.yml","position":24,"original_position":24,"commit_id":"9b547aa9e890f3fe0547bdd040fd3b5e542f2d35","original_commit_id":"9b547aa9e890f3fe0547bdd040fd3b5e542f2d35","user":{"login":"kristofa","id":2221492,"avatar_url":"https://avatars.githubusercontent.com/u/2221492?v=3","gravatar_id":"","url":"https://api.github.com/users/kristofa","html_url":"https://github.com/kristofa","followers_url":"https://api.github.com/users/kristofa/followers","following_url":"https://api.github.com/users/kristofa/following{/other_user}","gists_url":"https://api.github.com/users/kristofa/gists{/gist_id}","starred_url":"https://api.github.com/users/kristofa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristofa/subscriptions","organizations_url":"https://api.github.com/users/kristofa/orgs","repos_url":"https://api.github.com/users/kristofa/repos","events_url":"https://api.github.com/users/kristofa/events{/privacy}","received_events_url":"https://api.github.com/users/kristofa/received_events","type":"User","site_admin":false},"body":"@zsol I don't know why the `ROOTURL` environment variable is needed for `zipkin-web`. If I remove it everything still works. Also it is a hard coded private ip address...  I guess we should remove it.\r\n\r\nCan you also try if everything still works in your environment when you remove it?\r\n","created_at":"2015-07-09T17:34:07Z","updated_at":"2015-07-09T17:34:07Z","html_url":"https://github.com/openzipkin/docker-zipkin/pull/3#discussion_r34280941","pull_request_url":"https://api.github.com/repos/openzipkin/docker-zipkin/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/openzipkin/docker-zipkin/pulls/comments/34280941"},"html":{"href":"https://github.com/openzipkin/docker-zipkin/pull/3#discussion_r34280941"},"pull_request":{"href":"https://api.github.com/repos/openzipkin/docker-zipkin/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/openzipkin/docker-zipkin/pulls/3","id":39452470,"html_url":"https://github.com/openzipkin/docker-zipkin/pull/3","diff_url":"https://github.com/openzipkin/docker-zipkin/pull/3.diff","patch_url":"https://github.com/openzipkin/docker-zipkin/pull/3.patch","issue_url":"https://api.github.com/repos/openzipkin/docker-zipkin/issues/3","number":3,"state":"open","locked":false,"title":"add docker-compose.yml for wiring up zipkin containers","user":{"login":"zsol","id":66740,"avatar_url":"https://avatars.githubusercontent.com/u/66740?v=3","gravatar_id":"","url":"https://api.github.com/users/zsol","html_url":"https://github.com/zsol","followers_url":"https://api.github.com/users/zsol/followers","following_url":"https://api.github.com/users/zsol/following{/other_user}","gists_url":"https://api.github.com/users/zsol/gists{/gist_id}","starred_url":"https://api.github.com/users/zsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsol/subscriptions","organizations_url":"https://api.github.com/users/zsol/orgs","repos_url":"https://api.github.com/users/zsol/repos","events_url":"https://api.github.com/users/zsol/events{/privacy}","received_events_url":"https://api.github.com/users/zsol/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-08T08:27:05Z","updated_at":"2015-07-09T17:34:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5c13fb3abd49ddb059a9cf94e0ba2cb22f552eb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openzipkin/docker-zipkin/pulls/3/commits","review_comments_url":"https://api.github.com/repos/openzipkin/docker-zipkin/pulls/3/comments","review_comment_url":"https://api.github.com/repos/openzipkin/docker-zipkin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzipkin/docker-zipkin/issues/3/comments","statuses_url":"https://api.github.com/repos/openzipkin/docker-zipkin/statuses/9b547aa9e890f3fe0547bdd040fd3b5e542f2d35","head":{"label":"zsol:docker-compose","ref":"docker-compose","sha":"9b547aa9e890f3fe0547bdd040fd3b5e542f2d35","user":{"login":"zsol","id":66740,"avatar_url":"https://avatars.githubusercontent.com/u/66740?v=3","gravatar_id":"","url":"https://api.github.com/users/zsol","html_url":"https://github.com/zsol","followers_url":"https://api.github.com/users/zsol/followers","following_url":"https://api.github.com/users/zsol/following{/other_user}","gists_url":"https://api.github.com/users/zsol/gists{/gist_id}","starred_url":"https://api.github.com/users/zsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsol/subscriptions","organizations_url":"https://api.github.com/users/zsol/orgs","repos_url":"https://api.github.com/users/zsol/repos","events_url":"https://api.github.com/users/zsol/events{/privacy}","received_events_url":"https://api.github.com/users/zsol/received_events","type":"User","site_admin":false},"repo":{"id":38741623,"name":"docker-zipkin","full_name":"zsol/docker-zipkin","owner":{"login":"zsol","id":66740,"avatar_url":"https://avatars.githubusercontent.com/u/66740?v=3","gravatar_id":"","url":"https://api.github.com/users/zsol","html_url":"https://github.com/zsol","followers_url":"https://api.github.com/users/zsol/followers","following_url":"https://api.github.com/users/zsol/following{/other_user}","gists_url":"https://api.github.com/users/zsol/gists{/gist_id}","starred_url":"https://api.github.com/users/zsol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsol/subscriptions","organizations_url":"https://api.github.com/users/zsol/orgs","repos_url":"https://api.github.com/users/zsol/repos","events_url":"https://api.github.com/users/zsol/events{/privacy}","received_events_url":"https://api.github.com/users/zsol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zsol/docker-zipkin","description":"Docker images for Twitter's Zipkin","fork":true,"url":"https://api.github.com/repos/zsol/docker-zipkin","forks_url":"https://api.github.com/repos/zsol/docker-zipkin/forks","keys_url":"https://api.github.com/repos/zsol/docker-zipkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zsol/docker-zipkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zsol/docker-zipkin/teams","hooks_url":"https://api.github.com/repos/zsol/docker-zipkin/hooks","issue_events_url":"https://api.github.com/repos/zsol/docker-zipkin/issues/events{/number}","events_url":"https://api.github.com/repos/zsol/docker-zipkin/events","assignees_url":"https://api.github.com/repos/zsol/docker-zipkin/assignees{/user}","branches_url":"https://api.github.com/repos/zsol/docker-zipkin/branches{/branch}","tags_url":"https://api.github.com/repos/zsol/docker-zipkin/tags","blobs_url":"https://api.github.com/repos/zsol/docker-zipkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zsol/docker-zipkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zsol/docker-zipkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/zsol/docker-zipkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zsol/docker-zipkin/statuses/{sha}","languages_url":"https://api.github.com/repos/zsol/docker-zipkin/languages","stargazers_url":"https://api.github.com/repos/zsol/docker-zipkin/stargazers","contributors_url":"https://api.github.com/repos/zsol/docker-zipkin/contributors","subscribers_url":"https://api.github.com/repos/zsol/docker-zipkin/subscribers","subscription_url":"https://api.github.com/repos/zsol/docker-zipkin/subscription","commits_url":"https://api.github.com/repos/zsol/docker-zipkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/zsol/docker-zipkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/zsol/docker-zipkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/zsol/docker-zipkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/zsol/docker-zipkin/contents/{+path}","compare_url":"https://api.github.com/repos/zsol/docker-zipkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zsol/docker-zipkin/merges","archive_url":"https://api.github.com/repos/zsol/docker-zipkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zsol/docker-zipkin/downloads","issues_url":"https://api.github.com/repos/zsol/docker-zipkin/issues{/number}","pulls_url":"https://api.github.com/repos/zsol/docker-zipkin/pulls{/number}","milestones_url":"https://api.github.com/repos/zsol/docker-zipkin/milestones{/number}","notifications_url":"https://api.github.com/repos/zsol/docker-zipkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zsol/docker-zipkin/labels{/name}","releases_url":"https://api.github.com/repos/zsol/docker-zipkin/releases{/id}","created_at":"2015-07-08T08:25:37Z","updated_at":"2015-07-08T08:25:37Z","pushed_at":"2015-07-08T14:12:46Z","git_url":"git://github.com/zsol/docker-zipkin.git","ssh_url":"git@github.com:zsol/docker-zipkin.git","clone_url":"https://github.com/zsol/docker-zipkin.git","svn_url":"https://github.com/zsol/docker-zipkin","homepage":null,"size":85,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openzipkin:master","ref":"master","sha":"d135a6d6ac4886eff80906878df4b84df25e7074","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":17066904,"name":"docker-zipkin","full_name":"openzipkin/docker-zipkin","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/docker-zipkin","description":"Docker images for Twitter's Zipkin","fork":false,"url":"https://api.github.com/repos/openzipkin/docker-zipkin","forks_url":"https://api.github.com/repos/openzipkin/docker-zipkin/forks","keys_url":"https://api.github.com/repos/openzipkin/docker-zipkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/docker-zipkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/docker-zipkin/teams","hooks_url":"https://api.github.com/repos/openzipkin/docker-zipkin/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/docker-zipkin/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/docker-zipkin/events","assignees_url":"https://api.github.com/repos/openzipkin/docker-zipkin/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/docker-zipkin/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/docker-zipkin/tags","blobs_url":"https://api.github.com/repos/openzipkin/docker-zipkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/docker-zipkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/docker-zipkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/docker-zipkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/docker-zipkin/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/docker-zipkin/languages","stargazers_url":"https://api.github.com/repos/openzipkin/docker-zipkin/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/docker-zipkin/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/docker-zipkin/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/docker-zipkin/subscription","commits_url":"https://api.github.com/repos/openzipkin/docker-zipkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/docker-zipkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/docker-zipkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/docker-zipkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/docker-zipkin/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/docker-zipkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/docker-zipkin/merges","archive_url":"https://api.github.com/repos/openzipkin/docker-zipkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/docker-zipkin/downloads","issues_url":"https://api.github.com/repos/openzipkin/docker-zipkin/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/docker-zipkin/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/docker-zipkin/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/docker-zipkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/docker-zipkin/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/docker-zipkin/releases{/id}","created_at":"2014-02-21T19:19:27Z","updated_at":"2015-06-30T07:14:22Z","pushed_at":"2015-07-08T14:12:58Z","git_url":"git://github.com/openzipkin/docker-zipkin.git","ssh_url":"git@github.com:openzipkin/docker-zipkin.git","clone_url":"https://github.com/openzipkin/docker-zipkin.git","svn_url":"https://github.com/openzipkin/docker-zipkin","homepage":null,"size":189,"stargazers_count":24,"watchers_count":24,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":3,"forks":19,"open_issues":3,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzipkin/docker-zipkin/pulls/3"},"html":{"href":"https://github.com/openzipkin/docker-zipkin/pull/3"},"issue":{"href":"https://api.github.com/repos/openzipkin/docker-zipkin/issues/3"},"comments":{"href":"https://api.github.com/repos/openzipkin/docker-zipkin/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/openzipkin/docker-zipkin/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/openzipkin/docker-zipkin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzipkin/docker-zipkin/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/openzipkin/docker-zipkin/statuses/9b547aa9e890f3fe0547bdd040fd3b5e542f2d35"}}}}