{"action":"created","comment":{"url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/comments/46679715","id":46679715,"diff_hunk":"@@ -64,54 +58,51 @@ PipeStreamerAdapter::PipeStreamer::~PipeStreamer() {\n \n bool PipeStreamerAdapter::PipeStreamer::Connect() {\n   LOG4CXX_AUTO_TRACE(logger);\n-  /*if (!file_system::CreateDirectoryRecursively(\n+  if (!file_system::CreateDirectoryRecursively(\n       profile::Profile::instance()->app_storage_folder())) {\n     LOG4CXX_ERROR(logger, \"Cannot create app folder\");\n     return false;\n   }\n \n-  if ((mkfifo(named_pipe_path_.c_str(),\n-              S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH) < 0)\n-      && (errno != EEXIST)) {\n+  if (!pipe_.Create(named_pipe_path_)) {\n     LOG4CXX_ERROR(logger, \"Cannot create pipe \"\n                   << named_pipe_path_);\n     return false;\n   }\n \n-  pipe_fd_ = open(named_pipe_path_.c_str(), O_RDWR, 0);\n-  if (-1 == pipe_fd_) {\n+  if (!pipe_.Open()) {\n     LOG4CXX_ERROR(logger, \"Cannot open pipe for writing \"\n                   << named_pipe_path_);\n     return false;\n   }\n \n   LOG4CXX_INFO(logger, \"Pipe \" << named_pipe_path_\n-                << \" was successfuly created\");*/\n+                << \" was successfuly created\");\n   return true;\n }\n \n void PipeStreamerAdapter::PipeStreamer::Disconnect() {\n   LOG4CXX_AUTO_TRACE(logger);\n-  //close(pipe_fd_);\n-  //unlink(named_pipe_path_.c_str());\n+  pipe_.Close();\n }\n \n bool PipeStreamerAdapter::PipeStreamer::Send(\n     protocol_handler::RawMessagePtr msg) {\n   LOG4CXX_AUTO_TRACE(logger);\n-  /*ssize_t ret = write(pipe_fd_, msg->data(), msg->data_size());\n+  size_t ret = pipe_.Write(reinterpret_cast<const char*>(msg->data()),","path":"src/components/media_manager/src/pipe_streamer_adapter.cc","position":67,"original_position":67,"commit_id":"0c6b45d7dc0c0d5a3d74633cf4908fe0fc887951","original_commit_id":"0c6b45d7dc0c0d5a3d74633cf4908fe0fc887951","user":{"login":"pestOO","id":1039310,"avatar_url":"https://avatars.githubusercontent.com/u/1039310?v=3","gravatar_id":"","url":"https://api.github.com/users/pestOO","html_url":"https://github.com/pestOO","followers_url":"https://api.github.com/users/pestOO/followers","following_url":"https://api.github.com/users/pestOO/following{/other_user}","gists_url":"https://api.github.com/users/pestOO/gists{/gist_id}","starred_url":"https://api.github.com/users/pestOO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pestOO/subscriptions","organizations_url":"https://api.github.com/users/pestOO/orgs","repos_url":"https://api.github.com/users/pestOO/repos","events_url":"https://api.github.com/users/pestOO/events{/privacy}","received_events_url":"https://api.github.com/users/pestOO/received_events","type":"User","site_admin":false},"body":"Could we modify interface of Write with a ```uin8_t``` type and use any cast deeply? ","created_at":"2015-12-04T13:10:22Z","updated_at":"2015-12-04T13:10:22Z","html_url":"https://github.com/LuxoftSDL/sdl_core_winport/pull/29#discussion_r46679715","pull_request_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/comments/46679715"},"html":{"href":"https://github.com/LuxoftSDL/sdl_core_winport/pull/29#discussion_r46679715"},"pull_request":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/29","id":52558057,"html_url":"https://github.com/LuxoftSDL/sdl_core_winport/pull/29","diff_url":"https://github.com/LuxoftSDL/sdl_core_winport/pull/29.diff","patch_url":"https://github.com/LuxoftSDL/sdl_core_winport/pull/29.patch","issue_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/issues/29","number":29,"state":"open","locked":false,"title":"Enable audio video streaming","user":{"login":"anosach-luxoft","id":11158680,"avatar_url":"https://avatars.githubusercontent.com/u/11158680?v=3","gravatar_id":"","url":"https://api.github.com/users/anosach-luxoft","html_url":"https://github.com/anosach-luxoft","followers_url":"https://api.github.com/users/anosach-luxoft/followers","following_url":"https://api.github.com/users/anosach-luxoft/following{/other_user}","gists_url":"https://api.github.com/users/anosach-luxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/anosach-luxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anosach-luxoft/subscriptions","organizations_url":"https://api.github.com/users/anosach-luxoft/orgs","repos_url":"https://api.github.com/users/anosach-luxoft/repos","events_url":"https://api.github.com/users/anosach-luxoft/events{/privacy}","received_events_url":"https://api.github.com/users/anosach-luxoft/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-03T16:33:12Z","updated_at":"2015-12-04T13:10:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c029559bf42ee37f5587769be5281af91bd9773","assignee":{"login":"malirod","id":1135245,"avatar_url":"https://avatars.githubusercontent.com/u/1135245?v=3","gravatar_id":"","url":"https://api.github.com/users/malirod","html_url":"https://github.com/malirod","followers_url":"https://api.github.com/users/malirod/followers","following_url":"https://api.github.com/users/malirod/following{/other_user}","gists_url":"https://api.github.com/users/malirod/gists{/gist_id}","starred_url":"https://api.github.com/users/malirod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malirod/subscriptions","organizations_url":"https://api.github.com/users/malirod/orgs","repos_url":"https://api.github.com/users/malirod/repos","events_url":"https://api.github.com/users/malirod/events{/privacy}","received_events_url":"https://api.github.com/users/malirod/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/29/commits","review_comments_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/29/comments","review_comment_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/issues/29/comments","statuses_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/statuses/0c6b45d7dc0c0d5a3d74633cf4908fe0fc887951","head":{"label":"anosach-luxoft:feature/Enable-audio-video-streaming","ref":"feature/Enable-audio-video-streaming","sha":"0c6b45d7dc0c0d5a3d74633cf4908fe0fc887951","user":{"login":"anosach-luxoft","id":11158680,"avatar_url":"https://avatars.githubusercontent.com/u/11158680?v=3","gravatar_id":"","url":"https://api.github.com/users/anosach-luxoft","html_url":"https://github.com/anosach-luxoft","followers_url":"https://api.github.com/users/anosach-luxoft/followers","following_url":"https://api.github.com/users/anosach-luxoft/following{/other_user}","gists_url":"https://api.github.com/users/anosach-luxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/anosach-luxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anosach-luxoft/subscriptions","organizations_url":"https://api.github.com/users/anosach-luxoft/orgs","repos_url":"https://api.github.com/users/anosach-luxoft/repos","events_url":"https://api.github.com/users/anosach-luxoft/events{/privacy}","received_events_url":"https://api.github.com/users/anosach-luxoft/received_events","type":"User","site_admin":false},"repo":{"id":44157837,"name":"sdl_core_winport","full_name":"anosach-luxoft/sdl_core_winport","owner":{"login":"anosach-luxoft","id":11158680,"avatar_url":"https://avatars.githubusercontent.com/u/11158680?v=3","gravatar_id":"","url":"https://api.github.com/users/anosach-luxoft","html_url":"https://github.com/anosach-luxoft","followers_url":"https://api.github.com/users/anosach-luxoft/followers","following_url":"https://api.github.com/users/anosach-luxoft/following{/other_user}","gists_url":"https://api.github.com/users/anosach-luxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/anosach-luxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anosach-luxoft/subscriptions","organizations_url":"https://api.github.com/users/anosach-luxoft/orgs","repos_url":"https://api.github.com/users/anosach-luxoft/repos","events_url":"https://api.github.com/users/anosach-luxoft/events{/privacy}","received_events_url":"https://api.github.com/users/anosach-luxoft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anosach-luxoft/sdl_core_winport","description":"","fork":true,"url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport","forks_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/forks","keys_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/teams","hooks_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/hooks","issue_events_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/issues/events{/number}","events_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/events","assignees_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/assignees{/user}","branches_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/branches{/branch}","tags_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/tags","blobs_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/git/refs{/sha}","trees_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/statuses/{sha}","languages_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/languages","stargazers_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/stargazers","contributors_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/contributors","subscribers_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/subscribers","subscription_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/subscription","commits_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/commits{/sha}","git_commits_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/git/commits{/sha}","comments_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/comments{/number}","issue_comment_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/issues/comments{/number}","contents_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/contents/{+path}","compare_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/merges","archive_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/downloads","issues_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/issues{/number}","pulls_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/pulls{/number}","milestones_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/milestones{/number}","notifications_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/labels{/name}","releases_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/releases{/id}","created_at":"2015-10-13T06:55:03Z","updated_at":"2015-10-13T06:55:14Z","pushed_at":"2015-12-04T12:21:14Z","git_url":"git://github.com/anosach-luxoft/sdl_core_winport.git","ssh_url":"git@github.com:anosach-luxoft/sdl_core_winport.git","clone_url":"https://github.com/anosach-luxoft/sdl_core_winport.git","svn_url":"https://github.com/anosach-luxoft/sdl_core_winport","homepage":null,"size":16911,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LuxoftSDL:develop","ref":"develop","sha":"fa637c9403bdce868ad76a8ed9c1f11af64b16da","user":{"login":"LuxoftSDL","id":11190760,"avatar_url":"https://avatars.githubusercontent.com/u/11190760?v=3","gravatar_id":"","url":"https://api.github.com/users/LuxoftSDL","html_url":"https://github.com/LuxoftSDL","followers_url":"https://api.github.com/users/LuxoftSDL/followers","following_url":"https://api.github.com/users/LuxoftSDL/following{/other_user}","gists_url":"https://api.github.com/users/LuxoftSDL/gists{/gist_id}","starred_url":"https://api.github.com/users/LuxoftSDL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuxoftSDL/subscriptions","organizations_url":"https://api.github.com/users/LuxoftSDL/orgs","repos_url":"https://api.github.com/users/LuxoftSDL/repos","events_url":"https://api.github.com/users/LuxoftSDL/events{/privacy}","received_events_url":"https://api.github.com/users/LuxoftSDL/received_events","type":"Organization","site_admin":false},"repo":{"id":44124645,"name":"sdl_core_winport","full_name":"LuxoftSDL/sdl_core_winport","owner":{"login":"LuxoftSDL","id":11190760,"avatar_url":"https://avatars.githubusercontent.com/u/11190760?v=3","gravatar_id":"","url":"https://api.github.com/users/LuxoftSDL","html_url":"https://github.com/LuxoftSDL","followers_url":"https://api.github.com/users/LuxoftSDL/followers","following_url":"https://api.github.com/users/LuxoftSDL/following{/other_user}","gists_url":"https://api.github.com/users/LuxoftSDL/gists{/gist_id}","starred_url":"https://api.github.com/users/LuxoftSDL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuxoftSDL/subscriptions","organizations_url":"https://api.github.com/users/LuxoftSDL/orgs","repos_url":"https://api.github.com/users/LuxoftSDL/repos","events_url":"https://api.github.com/users/LuxoftSDL/events{/privacy}","received_events_url":"https://api.github.com/users/LuxoftSDL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LuxoftSDL/sdl_core_winport","description":"","fork":false,"url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport","forks_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/forks","keys_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/teams","hooks_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/hooks","issue_events_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/issues/events{/number}","events_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/events","assignees_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/assignees{/user}","branches_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/branches{/branch}","tags_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/tags","blobs_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/git/refs{/sha}","trees_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/statuses/{sha}","languages_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/languages","stargazers_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/stargazers","contributors_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/contributors","subscribers_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/subscribers","subscription_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/subscription","commits_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/commits{/sha}","git_commits_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/git/commits{/sha}","comments_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/comments{/number}","issue_comment_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/issues/comments{/number}","contents_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/contents/{+path}","compare_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/merges","archive_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/downloads","issues_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/issues{/number}","pulls_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls{/number}","milestones_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/milestones{/number}","notifications_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/labels{/name}","releases_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/releases{/id}","created_at":"2015-10-12T17:59:45Z","updated_at":"2015-10-12T18:08:33Z","pushed_at":"2015-12-04T12:36:44Z","git_url":"git://github.com/LuxoftSDL/sdl_core_winport.git","ssh_url":"git@github.com:LuxoftSDL/sdl_core_winport.git","clone_url":"https://github.com/LuxoftSDL/sdl_core_winport.git","svn_url":"https://github.com/LuxoftSDL/sdl_core_winport","homepage":null,"size":17175,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/29"},"html":{"href":"https://github.com/LuxoftSDL/sdl_core_winport/pull/29"},"issue":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/issues/29"},"comments":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/statuses/0c6b45d7dc0c0d5a3d74633cf4908fe0fc887951"}}}}