{"action":"created","comment":{"url":"https://api.github.com/repos/nutonian/nugget/pulls/comments/47208720","id":47208720,"diff_hunk":"@@ -30,7 +31,7 @@ class Graph extends GuideLayer {\n         return 0;\n     }\n \n-    drawElement(d3Svg, xRange, yRange, axisLabels) {\n+    drawElement(d3Svg, xRange, yRange, axisLabels, dontAnimateOverride = false) {","path":"lib/views/Graph.js","position":13,"original_position":13,"commit_id":"a04776d9bc72c76d5ff8ae7585280e8ce61ea7f4","original_commit_id":"a04776d9bc72c76d5ff8ae7585280e8ce61ea7f4","user":{"login":"choochburger","id":79789,"avatar_url":"https://avatars.githubusercontent.com/u/79789?v=3","gravatar_id":"","url":"https://api.github.com/users/choochburger","html_url":"https://github.com/choochburger","followers_url":"https://api.github.com/users/choochburger/followers","following_url":"https://api.github.com/users/choochburger/following{/other_user}","gists_url":"https://api.github.com/users/choochburger/gists{/gist_id}","starred_url":"https://api.github.com/users/choochburger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choochburger/subscriptions","organizations_url":"https://api.github.com/users/choochburger/orgs","repos_url":"https://api.github.com/users/choochburger/repos","events_url":"https://api.github.com/users/choochburger/events{/privacy}","received_events_url":"https://api.github.com/users/choochburger/received_events","type":"User","site_admin":false},"body":"Took me a few reads to get this. How about `dontAnimateOverride` --> `dontAnimate`? \r\n\r\nOr maybe it would be clearer to have the argument be `animate = true`. A little bit more logic needed, but I think that might scan a little better.","created_at":"2015-12-10T10:14:58Z","updated_at":"2015-12-10T10:14:58Z","html_url":"https://github.com/nutonian/nugget/pull/5#discussion_r47208720","pull_request_url":"https://api.github.com/repos/nutonian/nugget/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/nutonian/nugget/pulls/comments/47208720"},"html":{"href":"https://github.com/nutonian/nugget/pull/5#discussion_r47208720"},"pull_request":{"href":"https://api.github.com/repos/nutonian/nugget/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/nutonian/nugget/pulls/5","id":53183183,"html_url":"https://github.com/nutonian/nugget/pull/5","diff_url":"https://github.com/nutonian/nugget/pull/5.diff","patch_url":"https://github.com/nutonian/nugget/pull/5.patch","issue_url":"https://api.github.com/repos/nutonian/nugget/issues/5","number":5,"state":"open","locked":false,"title":"Some tweaks + saucelabs integration ","user":{"login":"lshrinivas","id":1220270,"avatar_url":"https://avatars.githubusercontent.com/u/1220270?v=3","gravatar_id":"","url":"https://api.github.com/users/lshrinivas","html_url":"https://github.com/lshrinivas","followers_url":"https://api.github.com/users/lshrinivas/followers","following_url":"https://api.github.com/users/lshrinivas/following{/other_user}","gists_url":"https://api.github.com/users/lshrinivas/gists{/gist_id}","starred_url":"https://api.github.com/users/lshrinivas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lshrinivas/subscriptions","organizations_url":"https://api.github.com/users/lshrinivas/orgs","repos_url":"https://api.github.com/users/lshrinivas/repos","events_url":"https://api.github.com/users/lshrinivas/events{/privacy}","received_events_url":"https://api.github.com/users/lshrinivas/received_events","type":"User","site_admin":false},"body":"Summary of changes:\r\n\r\nAllow user to specify that they don't want axis padding when using\r\ncustom x and y ranges\r\n\r\nTrigger zoom reset, so users can add listeners\r\n\r\nDon't animate on regular zoom, since zoom already animates. This prevents\r\nthe laggy double animation on regular zoom (scroll zoom)\r\n\r\nAdded option to control scroll zoom independent of box zoom\r\n\r\nAdded sauce labs integration - it's almost working: test results\r\nshow up in the dashboard, but the success/failure status is not\r\nbeing piped through.\r\n\r\nAdded some code to reduce size of jasmine report so Sauce labs\r\ncan handle it - now we have end-to-end integration working with\r\nSauce labs!\r\n\r\n","created_at":"2015-12-09T21:50:33Z","updated_at":"2015-12-10T10:14:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0b0dd0b443e59fa706be17dcf27a25811353fae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nutonian/nugget/pulls/5/commits","review_comments_url":"https://api.github.com/repos/nutonian/nugget/pulls/5/comments","review_comment_url":"https://api.github.com/repos/nutonian/nugget/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nutonian/nugget/issues/5/comments","statuses_url":"https://api.github.com/repos/nutonian/nugget/statuses/a04776d9bc72c76d5ff8ae7585280e8ce61ea7f4","head":{"label":"nutonian:p_nugget_mjf","ref":"p_nugget_mjf","sha":"a04776d9bc72c76d5ff8ae7585280e8ce61ea7f4","user":{"login":"nutonian","id":15220314,"avatar_url":"https://avatars.githubusercontent.com/u/15220314?v=3","gravatar_id":"","url":"https://api.github.com/users/nutonian","html_url":"https://github.com/nutonian","followers_url":"https://api.github.com/users/nutonian/followers","following_url":"https://api.github.com/users/nutonian/following{/other_user}","gists_url":"https://api.github.com/users/nutonian/gists{/gist_id}","starred_url":"https://api.github.com/users/nutonian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nutonian/subscriptions","organizations_url":"https://api.github.com/users/nutonian/orgs","repos_url":"https://api.github.com/users/nutonian/repos","events_url":"https://api.github.com/users/nutonian/events{/privacy}","received_events_url":"https://api.github.com/users/nutonian/received_events","type":"Organization","site_admin":false},"repo":{"id":44632123,"name":"nugget","full_name":"nutonian/nugget","owner":{"login":"nutonian","id":15220314,"avatar_url":"https://avatars.githubusercontent.com/u/15220314?v=3","gravatar_id":"","url":"https://api.github.com/users/nutonian","html_url":"https://github.com/nutonian","followers_url":"https://api.github.com/users/nutonian/followers","following_url":"https://api.github.com/users/nutonian/following{/other_user}","gists_url":"https://api.github.com/users/nutonian/gists{/gist_id}","starred_url":"https://api.github.com/users/nutonian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nutonian/subscriptions","organizations_url":"https://api.github.com/users/nutonian/orgs","repos_url":"https://api.github.com/users/nutonian/repos","events_url":"https://api.github.com/users/nutonian/events{/privacy}","received_events_url":"https://api.github.com/users/nutonian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nutonian/nugget","description":"Nugget.js - an MVC-based composable graphing library","fork":false,"url":"https://api.github.com/repos/nutonian/nugget","forks_url":"https://api.github.com/repos/nutonian/nugget/forks","keys_url":"https://api.github.com/repos/nutonian/nugget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nutonian/nugget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nutonian/nugget/teams","hooks_url":"https://api.github.com/repos/nutonian/nugget/hooks","issue_events_url":"https://api.github.com/repos/nutonian/nugget/issues/events{/number}","events_url":"https://api.github.com/repos/nutonian/nugget/events","assignees_url":"https://api.github.com/repos/nutonian/nugget/assignees{/user}","branches_url":"https://api.github.com/repos/nutonian/nugget/branches{/branch}","tags_url":"https://api.github.com/repos/nutonian/nugget/tags","blobs_url":"https://api.github.com/repos/nutonian/nugget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nutonian/nugget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nutonian/nugget/git/refs{/sha}","trees_url":"https://api.github.com/repos/nutonian/nugget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nutonian/nugget/statuses/{sha}","languages_url":"https://api.github.com/repos/nutonian/nugget/languages","stargazers_url":"https://api.github.com/repos/nutonian/nugget/stargazers","contributors_url":"https://api.github.com/repos/nutonian/nugget/contributors","subscribers_url":"https://api.github.com/repos/nutonian/nugget/subscribers","subscription_url":"https://api.github.com/repos/nutonian/nugget/subscription","commits_url":"https://api.github.com/repos/nutonian/nugget/commits{/sha}","git_commits_url":"https://api.github.com/repos/nutonian/nugget/git/commits{/sha}","comments_url":"https://api.github.com/repos/nutonian/nugget/comments{/number}","issue_comment_url":"https://api.github.com/repos/nutonian/nugget/issues/comments{/number}","contents_url":"https://api.github.com/repos/nutonian/nugget/contents/{+path}","compare_url":"https://api.github.com/repos/nutonian/nugget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nutonian/nugget/merges","archive_url":"https://api.github.com/repos/nutonian/nugget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nutonian/nugget/downloads","issues_url":"https://api.github.com/repos/nutonian/nugget/issues{/number}","pulls_url":"https://api.github.com/repos/nutonian/nugget/pulls{/number}","milestones_url":"https://api.github.com/repos/nutonian/nugget/milestones{/number}","notifications_url":"https://api.github.com/repos/nutonian/nugget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nutonian/nugget/labels{/name}","releases_url":"https://api.github.com/repos/nutonian/nugget/releases{/id}","created_at":"2015-10-20T20:09:19Z","updated_at":"2015-11-12T17:02:42Z","pushed_at":"2015-12-09T21:50:33Z","git_url":"git://github.com/nutonian/nugget.git","ssh_url":"git@github.com:nutonian/nugget.git","clone_url":"https://github.com/nutonian/nugget.git","svn_url":"https://github.com/nutonian/nugget","homepage":"","size":475,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"nutonian:master","ref":"master","sha":"3130d3d22b2d9902a20a13a1ec753b00a8063781","user":{"login":"nutonian","id":15220314,"avatar_url":"https://avatars.githubusercontent.com/u/15220314?v=3","gravatar_id":"","url":"https://api.github.com/users/nutonian","html_url":"https://github.com/nutonian","followers_url":"https://api.github.com/users/nutonian/followers","following_url":"https://api.github.com/users/nutonian/following{/other_user}","gists_url":"https://api.github.com/users/nutonian/gists{/gist_id}","starred_url":"https://api.github.com/users/nutonian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nutonian/subscriptions","organizations_url":"https://api.github.com/users/nutonian/orgs","repos_url":"https://api.github.com/users/nutonian/repos","events_url":"https://api.github.com/users/nutonian/events{/privacy}","received_events_url":"https://api.github.com/users/nutonian/received_events","type":"Organization","site_admin":false},"repo":{"id":44632123,"name":"nugget","full_name":"nutonian/nugget","owner":{"login":"nutonian","id":15220314,"avatar_url":"https://avatars.githubusercontent.com/u/15220314?v=3","gravatar_id":"","url":"https://api.github.com/users/nutonian","html_url":"https://github.com/nutonian","followers_url":"https://api.github.com/users/nutonian/followers","following_url":"https://api.github.com/users/nutonian/following{/other_user}","gists_url":"https://api.github.com/users/nutonian/gists{/gist_id}","starred_url":"https://api.github.com/users/nutonian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nutonian/subscriptions","organizations_url":"https://api.github.com/users/nutonian/orgs","repos_url":"https://api.github.com/users/nutonian/repos","events_url":"https://api.github.com/users/nutonian/events{/privacy}","received_events_url":"https://api.github.com/users/nutonian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nutonian/nugget","description":"Nugget.js - an MVC-based composable graphing library","fork":false,"url":"https://api.github.com/repos/nutonian/nugget","forks_url":"https://api.github.com/repos/nutonian/nugget/forks","keys_url":"https://api.github.com/repos/nutonian/nugget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nutonian/nugget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nutonian/nugget/teams","hooks_url":"https://api.github.com/repos/nutonian/nugget/hooks","issue_events_url":"https://api.github.com/repos/nutonian/nugget/issues/events{/number}","events_url":"https://api.github.com/repos/nutonian/nugget/events","assignees_url":"https://api.github.com/repos/nutonian/nugget/assignees{/user}","branches_url":"https://api.github.com/repos/nutonian/nugget/branches{/branch}","tags_url":"https://api.github.com/repos/nutonian/nugget/tags","blobs_url":"https://api.github.com/repos/nutonian/nugget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nutonian/nugget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nutonian/nugget/git/refs{/sha}","trees_url":"https://api.github.com/repos/nutonian/nugget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nutonian/nugget/statuses/{sha}","languages_url":"https://api.github.com/repos/nutonian/nugget/languages","stargazers_url":"https://api.github.com/repos/nutonian/nugget/stargazers","contributors_url":"https://api.github.com/repos/nutonian/nugget/contributors","subscribers_url":"https://api.github.com/repos/nutonian/nugget/subscribers","subscription_url":"https://api.github.com/repos/nutonian/nugget/subscription","commits_url":"https://api.github.com/repos/nutonian/nugget/commits{/sha}","git_commits_url":"https://api.github.com/repos/nutonian/nugget/git/commits{/sha}","comments_url":"https://api.github.com/repos/nutonian/nugget/comments{/number}","issue_comment_url":"https://api.github.com/repos/nutonian/nugget/issues/comments{/number}","contents_url":"https://api.github.com/repos/nutonian/nugget/contents/{+path}","compare_url":"https://api.github.com/repos/nutonian/nugget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nutonian/nugget/merges","archive_url":"https://api.github.com/repos/nutonian/nugget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nutonian/nugget/downloads","issues_url":"https://api.github.com/repos/nutonian/nugget/issues{/number}","pulls_url":"https://api.github.com/repos/nutonian/nugget/pulls{/number}","milestones_url":"https://api.github.com/repos/nutonian/nugget/milestones{/number}","notifications_url":"https://api.github.com/repos/nutonian/nugget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nutonian/nugget/labels{/name}","releases_url":"https://api.github.com/repos/nutonian/nugget/releases{/id}","created_at":"2015-10-20T20:09:19Z","updated_at":"2015-11-12T17:02:42Z","pushed_at":"2015-12-09T21:50:33Z","git_url":"git://github.com/nutonian/nugget.git","ssh_url":"git@github.com:nutonian/nugget.git","clone_url":"https://github.com/nutonian/nugget.git","svn_url":"https://github.com/nutonian/nugget","homepage":"","size":475,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nutonian/nugget/pulls/5"},"html":{"href":"https://github.com/nutonian/nugget/pull/5"},"issue":{"href":"https://api.github.com/repos/nutonian/nugget/issues/5"},"comments":{"href":"https://api.github.com/repos/nutonian/nugget/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/nutonian/nugget/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/nutonian/nugget/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nutonian/nugget/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/nutonian/nugget/statuses/a04776d9bc72c76d5ff8ae7585280e8ce61ea7f4"}}}}