{"action":"created","comment":{"url":"https://api.github.com/repos/sunspot/sunspot/pulls/comments/25684348","id":25684348,"diff_hunk":"@@ -510,10 +514,10 @@ def dirty?\n     end\n \n     # \n-    # Sends a commit if the session is dirty (see #dirty?).\n+    # Sends a commit (soft or hard) if the session is dirty (see #dirty?).\n     #\n-    def commit_if_dirty\n-      session.commit_if_dirty\n+    def commit_if_dirty(softCommit = false)","path":"sunspot/lib/sunspot.rb","position":41,"original_position":41,"commit_id":"14aaa30d72ca58cf55d288c8c8abce60b38d7d4c","original_commit_id":"14aaa30d72ca58cf55d288c8c8abce60b38d7d4c","user":{"login":"joneslee85","id":135605,"avatar_url":"https://avatars.githubusercontent.com/u/135605?v=3","gravatar_id":"","url":"https://api.github.com/users/joneslee85","html_url":"https://github.com/joneslee85","followers_url":"https://api.github.com/users/joneslee85/followers","following_url":"https://api.github.com/users/joneslee85/following{/other_user}","gists_url":"https://api.github.com/users/joneslee85/gists{/gist_id}","starred_url":"https://api.github.com/users/joneslee85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joneslee85/subscriptions","organizations_url":"https://api.github.com/users/joneslee85/orgs","repos_url":"https://api.github.com/users/joneslee85/repos","events_url":"https://api.github.com/users/joneslee85/events{/privacy}","received_events_url":"https://api.github.com/users/joneslee85/received_events","type":"User","site_admin":false},"body":"can we use snake case naming here instead? that is `soft_commit=false`?","created_at":"2015-03-03T12:44:54Z","updated_at":"2015-03-03T12:44:54Z","html_url":"https://github.com/sunspot/sunspot/pull/614#discussion_r25684348","pull_request_url":"https://api.github.com/repos/sunspot/sunspot/pulls/614","_links":{"self":{"href":"https://api.github.com/repos/sunspot/sunspot/pulls/comments/25684348"},"html":{"href":"https://github.com/sunspot/sunspot/pull/614#discussion_r25684348"},"pull_request":{"href":"https://api.github.com/repos/sunspot/sunspot/pulls/614"}}},"pull_request":{"url":"https://api.github.com/repos/sunspot/sunspot/pulls/614","id":20769072,"html_url":"https://github.com/sunspot/sunspot/pull/614","diff_url":"https://github.com/sunspot/sunspot/pull/614.diff","patch_url":"https://github.com/sunspot/sunspot/pull/614.patch","issue_url":"https://api.github.com/repos/sunspot/sunspot/issues/614","number":614,"state":"open","locked":false,"title":"Enabling soft commits for Solr4","user":{"login":"hammady","id":855847,"avatar_url":"https://avatars.githubusercontent.com/u/855847?v=3","gravatar_id":"","url":"https://api.github.com/users/hammady","html_url":"https://github.com/hammady","followers_url":"https://api.github.com/users/hammady/followers","following_url":"https://api.github.com/users/hammady/following{/other_user}","gists_url":"https://api.github.com/users/hammady/gists{/gist_id}","starred_url":"https://api.github.com/users/hammady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammady/subscriptions","organizations_url":"https://api.github.com/users/hammady/orgs","repos_url":"https://api.github.com/users/hammady/repos","events_url":"https://api.github.com/users/hammady/events{/privacy}","received_events_url":"https://api.github.com/users/hammady/received_events","type":"User","site_admin":false},"body":"This pull request adds the ability to do soft commits in Solr4. Three function pairs were patched: commit, commit_if_dirty and commit_if_delete_dirty in Sunspot and Session classes. An optional boolean parameter denotes a soft commit if true. New tests are added and all tests are passing. Documentation is also updated to explain hard and soft commits.","created_at":"2014-09-04T20:06:34Z","updated_at":"2015-03-03T12:44:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e32607a789327b05226aa5265c289f7b10c2d0b8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sunspot/sunspot/pulls/614/commits","review_comments_url":"https://api.github.com/repos/sunspot/sunspot/pulls/614/comments","review_comment_url":"https://api.github.com/repos/sunspot/sunspot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sunspot/sunspot/issues/614/comments","statuses_url":"https://api.github.com/repos/sunspot/sunspot/statuses/14aaa30d72ca58cf55d288c8c8abce60b38d7d4c","head":{"label":"hammady:softcommits","ref":"softcommits","sha":"14aaa30d72ca58cf55d288c8c8abce60b38d7d4c","user":{"login":"hammady","id":855847,"avatar_url":"https://avatars.githubusercontent.com/u/855847?v=3","gravatar_id":"","url":"https://api.github.com/users/hammady","html_url":"https://github.com/hammady","followers_url":"https://api.github.com/users/hammady/followers","following_url":"https://api.github.com/users/hammady/following{/other_user}","gists_url":"https://api.github.com/users/hammady/gists{/gist_id}","starred_url":"https://api.github.com/users/hammady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammady/subscriptions","organizations_url":"https://api.github.com/users/hammady/orgs","repos_url":"https://api.github.com/users/hammady/repos","events_url":"https://api.github.com/users/hammady/events{/privacy}","received_events_url":"https://api.github.com/users/hammady/received_events","type":"User","site_admin":false},"repo":{"id":23669771,"name":"sunspot","full_name":"hammady/sunspot","owner":{"login":"hammady","id":855847,"avatar_url":"https://avatars.githubusercontent.com/u/855847?v=3","gravatar_id":"","url":"https://api.github.com/users/hammady","html_url":"https://github.com/hammady","followers_url":"https://api.github.com/users/hammady/followers","following_url":"https://api.github.com/users/hammady/following{/other_user}","gists_url":"https://api.github.com/users/hammady/gists{/gist_id}","starred_url":"https://api.github.com/users/hammady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammady/subscriptions","organizations_url":"https://api.github.com/users/hammady/orgs","repos_url":"https://api.github.com/users/hammady/repos","events_url":"https://api.github.com/users/hammady/events{/privacy}","received_events_url":"https://api.github.com/users/hammady/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hammady/sunspot","description":"Solr-powered search for Ruby objects","fork":true,"url":"https://api.github.com/repos/hammady/sunspot","forks_url":"https://api.github.com/repos/hammady/sunspot/forks","keys_url":"https://api.github.com/repos/hammady/sunspot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hammady/sunspot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hammady/sunspot/teams","hooks_url":"https://api.github.com/repos/hammady/sunspot/hooks","issue_events_url":"https://api.github.com/repos/hammady/sunspot/issues/events{/number}","events_url":"https://api.github.com/repos/hammady/sunspot/events","assignees_url":"https://api.github.com/repos/hammady/sunspot/assignees{/user}","branches_url":"https://api.github.com/repos/hammady/sunspot/branches{/branch}","tags_url":"https://api.github.com/repos/hammady/sunspot/tags","blobs_url":"https://api.github.com/repos/hammady/sunspot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hammady/sunspot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hammady/sunspot/git/refs{/sha}","trees_url":"https://api.github.com/repos/hammady/sunspot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hammady/sunspot/statuses/{sha}","languages_url":"https://api.github.com/repos/hammady/sunspot/languages","stargazers_url":"https://api.github.com/repos/hammady/sunspot/stargazers","contributors_url":"https://api.github.com/repos/hammady/sunspot/contributors","subscribers_url":"https://api.github.com/repos/hammady/sunspot/subscribers","subscription_url":"https://api.github.com/repos/hammady/sunspot/subscription","commits_url":"https://api.github.com/repos/hammady/sunspot/commits{/sha}","git_commits_url":"https://api.github.com/repos/hammady/sunspot/git/commits{/sha}","comments_url":"https://api.github.com/repos/hammady/sunspot/comments{/number}","issue_comment_url":"https://api.github.com/repos/hammady/sunspot/issues/comments{/number}","contents_url":"https://api.github.com/repos/hammady/sunspot/contents/{+path}","compare_url":"https://api.github.com/repos/hammady/sunspot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hammady/sunspot/merges","archive_url":"https://api.github.com/repos/hammady/sunspot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hammady/sunspot/downloads","issues_url":"https://api.github.com/repos/hammady/sunspot/issues{/number}","pulls_url":"https://api.github.com/repos/hammady/sunspot/pulls{/number}","milestones_url":"https://api.github.com/repos/hammady/sunspot/milestones{/number}","notifications_url":"https://api.github.com/repos/hammady/sunspot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hammady/sunspot/labels{/name}","releases_url":"https://api.github.com/repos/hammady/sunspot/releases{/id}","created_at":"2014-09-04T16:13:59Z","updated_at":"2014-09-05T11:38:22Z","pushed_at":"2014-09-07T12:03:29Z","git_url":"git://github.com/hammady/sunspot.git","ssh_url":"git@github.com:hammady/sunspot.git","clone_url":"https://github.com/hammady/sunspot.git","svn_url":"https://github.com/hammady/sunspot","homepage":"http://sunspot.github.com/","size":60549,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sunspot:master","ref":"master","sha":"691b42e73beae37e2e05953a1110f4247ec0065c","user":{"login":"sunspot","id":1027744,"avatar_url":"https://avatars.githubusercontent.com/u/1027744?v=3","gravatar_id":"","url":"https://api.github.com/users/sunspot","html_url":"https://github.com/sunspot","followers_url":"https://api.github.com/users/sunspot/followers","following_url":"https://api.github.com/users/sunspot/following{/other_user}","gists_url":"https://api.github.com/users/sunspot/gists{/gist_id}","starred_url":"https://api.github.com/users/sunspot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunspot/subscriptions","organizations_url":"https://api.github.com/users/sunspot/orgs","repos_url":"https://api.github.com/users/sunspot/repos","events_url":"https://api.github.com/users/sunspot/events{/privacy}","received_events_url":"https://api.github.com/users/sunspot/received_events","type":"Organization","site_admin":false},"repo":{"id":62509,"name":"sunspot","full_name":"sunspot/sunspot","owner":{"login":"sunspot","id":1027744,"avatar_url":"https://avatars.githubusercontent.com/u/1027744?v=3","gravatar_id":"","url":"https://api.github.com/users/sunspot","html_url":"https://github.com/sunspot","followers_url":"https://api.github.com/users/sunspot/followers","following_url":"https://api.github.com/users/sunspot/following{/other_user}","gists_url":"https://api.github.com/users/sunspot/gists{/gist_id}","starred_url":"https://api.github.com/users/sunspot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunspot/subscriptions","organizations_url":"https://api.github.com/users/sunspot/orgs","repos_url":"https://api.github.com/users/sunspot/repos","events_url":"https://api.github.com/users/sunspot/events{/privacy}","received_events_url":"https://api.github.com/users/sunspot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sunspot/sunspot","description":"Solr-powered search for Ruby objects","fork":false,"url":"https://api.github.com/repos/sunspot/sunspot","forks_url":"https://api.github.com/repos/sunspot/sunspot/forks","keys_url":"https://api.github.com/repos/sunspot/sunspot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sunspot/sunspot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sunspot/sunspot/teams","hooks_url":"https://api.github.com/repos/sunspot/sunspot/hooks","issue_events_url":"https://api.github.com/repos/sunspot/sunspot/issues/events{/number}","events_url":"https://api.github.com/repos/sunspot/sunspot/events","assignees_url":"https://api.github.com/repos/sunspot/sunspot/assignees{/user}","branches_url":"https://api.github.com/repos/sunspot/sunspot/branches{/branch}","tags_url":"https://api.github.com/repos/sunspot/sunspot/tags","blobs_url":"https://api.github.com/repos/sunspot/sunspot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sunspot/sunspot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sunspot/sunspot/git/refs{/sha}","trees_url":"https://api.github.com/repos/sunspot/sunspot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sunspot/sunspot/statuses/{sha}","languages_url":"https://api.github.com/repos/sunspot/sunspot/languages","stargazers_url":"https://api.github.com/repos/sunspot/sunspot/stargazers","contributors_url":"https://api.github.com/repos/sunspot/sunspot/contributors","subscribers_url":"https://api.github.com/repos/sunspot/sunspot/subscribers","subscription_url":"https://api.github.com/repos/sunspot/sunspot/subscription","commits_url":"https://api.github.com/repos/sunspot/sunspot/commits{/sha}","git_commits_url":"https://api.github.com/repos/sunspot/sunspot/git/commits{/sha}","comments_url":"https://api.github.com/repos/sunspot/sunspot/comments{/number}","issue_comment_url":"https://api.github.com/repos/sunspot/sunspot/issues/comments{/number}","contents_url":"https://api.github.com/repos/sunspot/sunspot/contents/{+path}","compare_url":"https://api.github.com/repos/sunspot/sunspot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sunspot/sunspot/merges","archive_url":"https://api.github.com/repos/sunspot/sunspot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sunspot/sunspot/downloads","issues_url":"https://api.github.com/repos/sunspot/sunspot/issues{/number}","pulls_url":"https://api.github.com/repos/sunspot/sunspot/pulls{/number}","milestones_url":"https://api.github.com/repos/sunspot/sunspot/milestones{/number}","notifications_url":"https://api.github.com/repos/sunspot/sunspot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sunspot/sunspot/labels{/name}","releases_url":"https://api.github.com/repos/sunspot/sunspot/releases{/id}","created_at":"2008-10-13T15:46:40Z","updated_at":"2015-03-03T12:37:11Z","pushed_at":"2015-03-03T12:37:09Z","git_url":"git://github.com/sunspot/sunspot.git","ssh_url":"git@github.com:sunspot/sunspot.git","clone_url":"https://github.com/sunspot/sunspot.git","svn_url":"https://github.com/sunspot/sunspot","homepage":"http://sunspot.github.com/","size":97031,"stargazers_count":2239,"watchers_count":2239,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":717,"mirror_url":null,"open_issues_count":190,"forks":717,"open_issues":190,"watchers":2239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sunspot/sunspot/pulls/614"},"html":{"href":"https://github.com/sunspot/sunspot/pull/614"},"issue":{"href":"https://api.github.com/repos/sunspot/sunspot/issues/614"},"comments":{"href":"https://api.github.com/repos/sunspot/sunspot/issues/614/comments"},"review_comments":{"href":"https://api.github.com/repos/sunspot/sunspot/pulls/614/comments"},"review_comment":{"href":"https://api.github.com/repos/sunspot/sunspot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sunspot/sunspot/pulls/614/commits"},"statuses":{"href":"https://api.github.com/repos/sunspot/sunspot/statuses/14aaa30d72ca58cf55d288c8c8abce60b38d7d4c"}}}}