{"action":"created","comment":{"url":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/comments/39964426","id":39964426,"diff_hunk":"@@ -1,12 +1,46 @@\n import SandboxBase from '../base';\n import { isNullOrUndefined, inaccessibleTypeToStr, isWindow, isDocument } from '../../utils/types';\n import { DOCUMENT_WRITE_BEGIN_PARAM, DOCUMENT_WRITE_END_PARAM, CALL_METHOD_METH_NAME } from '../../../processing/js';\n+import { FOCUS_PSEUDO_CLASS_ATTR } from '../../../const';\n+import { isDomElement } from '../../utils/dom';","path":"src/client/sandbox/code-instrumentation/methods.js","position":5,"original_position":5,"commit_id":"a050109b10da559fdcb9fe8fb4dde7873f685de2","original_commit_id":"a050109b10da559fdcb9fe8fb4dde7873f685de2","user":{"login":"inikulin","id":453071,"avatar_url":"https://avatars.githubusercontent.com/u/453071?v=3","gravatar_id":"","url":"https://api.github.com/users/inikulin","html_url":"https://github.com/inikulin","followers_url":"https://api.github.com/users/inikulin/followers","following_url":"https://api.github.com/users/inikulin/following{/other_user}","gists_url":"https://api.github.com/users/inikulin/gists{/gist_id}","starred_url":"https://api.github.com/users/inikulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inikulin/subscriptions","organizations_url":"https://api.github.com/users/inikulin/orgs","repos_url":"https://api.github.com/users/inikulin/repos","events_url":"https://api.github.com/users/inikulin/events{/privacy}","received_events_url":"https://api.github.com/users/inikulin/received_events","type":"User","site_admin":false},"body":"It's quite fragile logic. What should go there? Should `isShadowUIElement` be in types? `utils/types` currently is the `god-util` for me. I'd preffer to have things separated dom types in `dom` utils, style types in `style` utils and so on. @churkin I don't get what `isDomElement` checks for? At first I thought it checks for node being an `HTMLElement`, but from code it doesn't seems to be a true.","created_at":"2015-09-21T12:25:12Z","updated_at":"2015-09-21T12:25:12Z","html_url":"https://github.com/superroma/testcafe-hammerhead/pull/119#discussion_r39964426","pull_request_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/119","_links":{"self":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/comments/39964426"},"html":{"href":"https://github.com/superroma/testcafe-hammerhead/pull/119#discussion_r39964426"},"pull_request":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/119"}}},"pull_request":{"url":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/119","id":45528463,"html_url":"https://github.com/superroma/testcafe-hammerhead/pull/119","diff_url":"https://github.com/superroma/testcafe-hammerhead/pull/119.diff","patch_url":"https://github.com/superroma/testcafe-hammerhead/pull/119.patch","issue_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/issues/119","number":119,"state":"open","locked":false,"title":"Fixed querySelector when browser is not focused","user":{"login":"AndreyBelym","id":4479386,"avatar_url":"https://avatars.githubusercontent.com/u/4479386?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreyBelym","html_url":"https://github.com/AndreyBelym","followers_url":"https://api.github.com/users/AndreyBelym/followers","following_url":"https://api.github.com/users/AndreyBelym/following{/other_user}","gists_url":"https://api.github.com/users/AndreyBelym/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyBelym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyBelym/subscriptions","organizations_url":"https://api.github.com/users/AndreyBelym/orgs","repos_url":"https://api.github.com/users/AndreyBelym/repos","events_url":"https://api.github.com/users/AndreyBelym/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyBelym/received_events","type":"User","site_admin":false},"body":"\\cc @inikulin @churkin \r\nWhen Chrome and Firefox are not focused, `querySelector`/`querySelectorAll` return `null` / `[]` instead of current active element. In context of bug `T285078`.","created_at":"2015-09-21T09:31:09Z","updated_at":"2015-09-21T12:25:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2532f9c03d95cd523612a450d429e176e5ed3e77","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/119/commits","review_comments_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/119/comments","review_comment_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/comments{/number}","comments_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/issues/119/comments","statuses_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/statuses/a050109b10da559fdcb9fe8fb4dde7873f685de2","head":{"label":"AndreyBelym:T285078","ref":"T285078","sha":"a050109b10da559fdcb9fe8fb4dde7873f685de2","user":{"login":"AndreyBelym","id":4479386,"avatar_url":"https://avatars.githubusercontent.com/u/4479386?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreyBelym","html_url":"https://github.com/AndreyBelym","followers_url":"https://api.github.com/users/AndreyBelym/followers","following_url":"https://api.github.com/users/AndreyBelym/following{/other_user}","gists_url":"https://api.github.com/users/AndreyBelym/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyBelym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyBelym/subscriptions","organizations_url":"https://api.github.com/users/AndreyBelym/orgs","repos_url":"https://api.github.com/users/AndreyBelym/repos","events_url":"https://api.github.com/users/AndreyBelym/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyBelym/received_events","type":"User","site_admin":false},"repo":{"id":42710241,"name":"testcafe-hammerhead","full_name":"AndreyBelym/testcafe-hammerhead","owner":{"login":"AndreyBelym","id":4479386,"avatar_url":"https://avatars.githubusercontent.com/u/4479386?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreyBelym","html_url":"https://github.com/AndreyBelym","followers_url":"https://api.github.com/users/AndreyBelym/followers","following_url":"https://api.github.com/users/AndreyBelym/following{/other_user}","gists_url":"https://api.github.com/users/AndreyBelym/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyBelym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyBelym/subscriptions","organizations_url":"https://api.github.com/users/AndreyBelym/orgs","repos_url":"https://api.github.com/users/AndreyBelym/repos","events_url":"https://api.github.com/users/AndreyBelym/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyBelym/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndreyBelym/testcafe-hammerhead","description":"","fork":true,"url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead","forks_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/forks","keys_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/teams","hooks_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/hooks","issue_events_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/issues/events{/number}","events_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/events","assignees_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/assignees{/user}","branches_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/branches{/branch}","tags_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/tags","blobs_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/statuses/{sha}","languages_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/languages","stargazers_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/stargazers","contributors_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/contributors","subscribers_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/subscribers","subscription_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/subscription","commits_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/contents/{+path}","compare_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/merges","archive_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/downloads","issues_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/issues{/number}","pulls_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/pulls{/number}","milestones_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/milestones{/number}","notifications_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/labels{/name}","releases_url":"https://api.github.com/repos/AndreyBelym/testcafe-hammerhead/releases{/id}","created_at":"2015-09-18T08:52:01Z","updated_at":"2015-09-18T08:52:02Z","pushed_at":"2015-09-21T12:16:35Z","git_url":"git://github.com/AndreyBelym/testcafe-hammerhead.git","ssh_url":"git@github.com:AndreyBelym/testcafe-hammerhead.git","clone_url":"https://github.com/AndreyBelym/testcafe-hammerhead.git","svn_url":"https://github.com/AndreyBelym/testcafe-hammerhead","homepage":null,"size":1422,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"superroma:master","ref":"master","sha":"75133ebed22e0b6f83cc541d7d6449344a21124d","user":{"login":"superroma","id":8553464,"avatar_url":"https://avatars.githubusercontent.com/u/8553464?v=3","gravatar_id":"","url":"https://api.github.com/users/superroma","html_url":"https://github.com/superroma","followers_url":"https://api.github.com/users/superroma/followers","following_url":"https://api.github.com/users/superroma/following{/other_user}","gists_url":"https://api.github.com/users/superroma/gists{/gist_id}","starred_url":"https://api.github.com/users/superroma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superroma/subscriptions","organizations_url":"https://api.github.com/users/superroma/orgs","repos_url":"https://api.github.com/users/superroma/repos","events_url":"https://api.github.com/users/superroma/events{/privacy}","received_events_url":"https://api.github.com/users/superroma/received_events","type":"User","site_admin":false},"repo":{"id":36883823,"name":"testcafe-hammerhead","full_name":"superroma/testcafe-hammerhead","owner":{"login":"superroma","id":8553464,"avatar_url":"https://avatars.githubusercontent.com/u/8553464?v=3","gravatar_id":"","url":"https://api.github.com/users/superroma","html_url":"https://github.com/superroma","followers_url":"https://api.github.com/users/superroma/followers","following_url":"https://api.github.com/users/superroma/following{/other_user}","gists_url":"https://api.github.com/users/superroma/gists{/gist_id}","starred_url":"https://api.github.com/users/superroma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superroma/subscriptions","organizations_url":"https://api.github.com/users/superroma/orgs","repos_url":"https://api.github.com/users/superroma/repos","events_url":"https://api.github.com/users/superroma/events{/privacy}","received_events_url":"https://api.github.com/users/superroma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/superroma/testcafe-hammerhead","description":"","fork":false,"url":"https://api.github.com/repos/superroma/testcafe-hammerhead","forks_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/forks","keys_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/keys{/key_id}","collaborators_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/teams","hooks_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/hooks","issue_events_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/issues/events{/number}","events_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/events","assignees_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/assignees{/user}","branches_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/branches{/branch}","tags_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/tags","blobs_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/git/refs{/sha}","trees_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/git/trees{/sha}","statuses_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/statuses/{sha}","languages_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/languages","stargazers_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/stargazers","contributors_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/contributors","subscribers_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/subscribers","subscription_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/subscription","commits_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/commits{/sha}","git_commits_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/git/commits{/sha}","comments_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/comments{/number}","issue_comment_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/issues/comments{/number}","contents_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/contents/{+path}","compare_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/compare/{base}...{head}","merges_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/merges","archive_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/downloads","issues_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/issues{/number}","pulls_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls{/number}","milestones_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/milestones{/number}","notifications_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/labels{/name}","releases_url":"https://api.github.com/repos/superroma/testcafe-hammerhead/releases{/id}","created_at":"2015-06-04T16:56:53Z","updated_at":"2015-09-18T08:51:50Z","pushed_at":"2015-09-21T11:46:48Z","git_url":"git://github.com/superroma/testcafe-hammerhead.git","ssh_url":"git@github.com:superroma/testcafe-hammerhead.git","clone_url":"https://github.com/superroma/testcafe-hammerhead.git","svn_url":"https://github.com/superroma/testcafe-hammerhead","homepage":null,"size":1422,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":36,"forks":9,"open_issues":36,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/119"},"html":{"href":"https://github.com/superroma/testcafe-hammerhead/pull/119"},"issue":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/issues/119"},"comments":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/superroma/testcafe-hammerhead/statuses/a050109b10da559fdcb9fe8fb4dde7873f685de2"}}}}