{"action":"created","comment":{"url":"https://api.github.com/repos/laravel/framework/pulls/comments/31422431","id":31422431,"diff_hunk":"@@ -306,14 +306,17 @@ public static function currentPathResolver(Closure $resolver)\n \t * Resolve the current page or return the default value.\n \t *\n \t * @param  string  $pageName\n-\t * @param  int  $default\n+\t * @param  int     $default\n+\t * @param  int     $lastPage\n \t * @return int\n \t */\n-\tpublic static function resolveCurrentPage($pageName = 'page', $default = 1)\n+\tpublic static function resolveCurrentPage($pageName = 'page', $default = 1, $lastPage)","path":"src/Illuminate/Pagination/AbstractPaginator.php","position":10,"original_position":10,"commit_id":"44fe31637279a9fbbbc1d9adda6854cd23a6fa0b","original_commit_id":"44fe31637279a9fbbbc1d9adda6854cd23a6fa0b","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"body":"You can't have a parameter without a default following parameters with a default.","created_at":"2015-06-01T12:58:40Z","updated_at":"2015-06-01T12:58:40Z","html_url":"https://github.com/laravel/framework/pull/8968#discussion_r31422431","pull_request_url":"https://api.github.com/repos/laravel/framework/pulls/8968","_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/31422431"},"html":{"href":"https://github.com/laravel/framework/pull/8968#discussion_r31422431"},"pull_request":{"href":"https://api.github.com/repos/laravel/framework/pulls/8968"}}},"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/8968","id":36624935,"html_url":"https://github.com/laravel/framework/pull/8968","diff_url":"https://github.com/laravel/framework/pull/8968.diff","patch_url":"https://github.com/laravel/framework/pull/8968.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/8968","number":8968,"state":"open","locked":false,"title":"Added fix for last page on pagination query builder being ignored and…","user":{"login":"Sladewill","id":6969435,"avatar_url":"https://avatars.githubusercontent.com/u/6969435?v=3","gravatar_id":"","url":"https://api.github.com/users/Sladewill","html_url":"https://github.com/Sladewill","followers_url":"https://api.github.com/users/Sladewill/followers","following_url":"https://api.github.com/users/Sladewill/following{/other_user}","gists_url":"https://api.github.com/users/Sladewill/gists{/gist_id}","starred_url":"https://api.github.com/users/Sladewill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sladewill/subscriptions","organizations_url":"https://api.github.com/users/Sladewill/orgs","repos_url":"https://api.github.com/users/Sladewill/repos","events_url":"https://api.github.com/users/Sladewill/events{/privacy}","received_events_url":"https://api.github.com/users/Sladewill/received_events","type":"User","site_admin":false},"body":"… current page being used.\r\n\r\nI.e you have 61 items 30 per page, you have 3 pages, one user deletes an item now you have 2 pages of 60 items, another user refreshes on page 3 and they are stuck on a page without any results or pagination links.\r\n\r\nFixes #8252","created_at":"2015-06-01T12:44:20Z","updated_at":"2015-06-01T12:58:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc810614c7abc58d511a9f9f313c8a24475b924d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/8968/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/8968/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/8968/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/44fe31637279a9fbbbc1d9adda6854cd23a6fa0b","head":{"label":"Sladewill:master","ref":"master","sha":"44fe31637279a9fbbbc1d9adda6854cd23a6fa0b","user":{"login":"Sladewill","id":6969435,"avatar_url":"https://avatars.githubusercontent.com/u/6969435?v=3","gravatar_id":"","url":"https://api.github.com/users/Sladewill","html_url":"https://github.com/Sladewill","followers_url":"https://api.github.com/users/Sladewill/followers","following_url":"https://api.github.com/users/Sladewill/following{/other_user}","gists_url":"https://api.github.com/users/Sladewill/gists{/gist_id}","starred_url":"https://api.github.com/users/Sladewill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sladewill/subscriptions","organizations_url":"https://api.github.com/users/Sladewill/orgs","repos_url":"https://api.github.com/users/Sladewill/repos","events_url":"https://api.github.com/users/Sladewill/events{/privacy}","received_events_url":"https://api.github.com/users/Sladewill/received_events","type":"User","site_admin":false},"repo":{"id":36659044,"name":"framework","full_name":"Sladewill/framework","owner":{"login":"Sladewill","id":6969435,"avatar_url":"https://avatars.githubusercontent.com/u/6969435?v=3","gravatar_id":"","url":"https://api.github.com/users/Sladewill","html_url":"https://github.com/Sladewill","followers_url":"https://api.github.com/users/Sladewill/followers","following_url":"https://api.github.com/users/Sladewill/following{/other_user}","gists_url":"https://api.github.com/users/Sladewill/gists{/gist_id}","starred_url":"https://api.github.com/users/Sladewill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sladewill/subscriptions","organizations_url":"https://api.github.com/users/Sladewill/orgs","repos_url":"https://api.github.com/users/Sladewill/repos","events_url":"https://api.github.com/users/Sladewill/events{/privacy}","received_events_url":"https://api.github.com/users/Sladewill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sladewill/framework","description":"","fork":true,"url":"https://api.github.com/repos/Sladewill/framework","forks_url":"https://api.github.com/repos/Sladewill/framework/forks","keys_url":"https://api.github.com/repos/Sladewill/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sladewill/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sladewill/framework/teams","hooks_url":"https://api.github.com/repos/Sladewill/framework/hooks","issue_events_url":"https://api.github.com/repos/Sladewill/framework/issues/events{/number}","events_url":"https://api.github.com/repos/Sladewill/framework/events","assignees_url":"https://api.github.com/repos/Sladewill/framework/assignees{/user}","branches_url":"https://api.github.com/repos/Sladewill/framework/branches{/branch}","tags_url":"https://api.github.com/repos/Sladewill/framework/tags","blobs_url":"https://api.github.com/repos/Sladewill/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sladewill/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sladewill/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sladewill/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sladewill/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/Sladewill/framework/languages","stargazers_url":"https://api.github.com/repos/Sladewill/framework/stargazers","contributors_url":"https://api.github.com/repos/Sladewill/framework/contributors","subscribers_url":"https://api.github.com/repos/Sladewill/framework/subscribers","subscription_url":"https://api.github.com/repos/Sladewill/framework/subscription","commits_url":"https://api.github.com/repos/Sladewill/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sladewill/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sladewill/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sladewill/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sladewill/framework/contents/{+path}","compare_url":"https://api.github.com/repos/Sladewill/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sladewill/framework/merges","archive_url":"https://api.github.com/repos/Sladewill/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sladewill/framework/downloads","issues_url":"https://api.github.com/repos/Sladewill/framework/issues{/number}","pulls_url":"https://api.github.com/repos/Sladewill/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/Sladewill/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/Sladewill/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sladewill/framework/labels{/name}","releases_url":"https://api.github.com/repos/Sladewill/framework/releases{/id}","created_at":"2015-06-01T12:23:51Z","updated_at":"2015-06-01T12:23:56Z","pushed_at":"2015-06-01T12:42:24Z","git_url":"git://github.com/Sladewill/framework.git","ssh_url":"git@github.com:Sladewill/framework.git","clone_url":"https://github.com/Sladewill/framework.git","svn_url":"https://github.com/Sladewill/framework","homepage":"http://laravel.com","size":69561,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.0"}},"base":{"label":"laravel:master","ref":"master","sha":"44922a0904486f89ddef895b071917ce09ccf85b","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-06-01T11:54:45Z","pushed_at":"2015-06-01T12:44:20Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":69561,"stargazers_count":3653,"watchers_count":3653,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2019,"mirror_url":null,"open_issues_count":70,"forks":2019,"open_issues":70,"watchers":3653,"default_branch":"5.0"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/8968"},"html":{"href":"https://github.com/laravel/framework/pull/8968"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/8968"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/8968/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/8968/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/8968/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/44fe31637279a9fbbbc1d9adda6854cd23a6fa0b"}}}}