{"action":"created","comment":{"url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/pulls/comments/26892148","id":26892148,"diff_hunk":"@@ -554,7 +555,7 @@ protected function getUrl($route, $params = array(), $absolute = false)\n      *\n      * @return void\n      */\n-    public function isSuccessful($response, $success = true, $type = 'text/html')\n+    public function isSuccessful(Response $response, $success = true, $type = 'text/html')","path":"Test/WebTestCase.php","position":31,"original_position":31,"commit_id":"ee889ff301e53ea4b5329a566281e806cd64d7b7","original_commit_id":"ee889ff301e53ea4b5329a566281e806cd64d7b7","user":{"login":"lsmith77","id":300279,"avatar_url":"https://avatars.githubusercontent.com/u/300279?v=3","gravatar_id":"","url":"https://api.github.com/users/lsmith77","html_url":"https://github.com/lsmith77","followers_url":"https://api.github.com/users/lsmith77/followers","following_url":"https://api.github.com/users/lsmith77/following{/other_user}","gists_url":"https://api.github.com/users/lsmith77/gists{/gist_id}","starred_url":"https://api.github.com/users/lsmith77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsmith77/subscriptions","organizations_url":"https://api.github.com/users/lsmith77/orgs","repos_url":"https://api.github.com/users/lsmith77/repos","events_url":"https://api.github.com/users/lsmith77/events{/privacy}","received_events_url":"https://api.github.com/users/lsmith77/received_events","type":"User","site_admin":false},"body":"since others might have extended this method it would be a BC break. then again most users likely didn't extend this method. still imho as we are looking towards a 2.0 release, this change should be in a separate PR that we will merge once we begin on 2.0","created_at":"2015-03-21T14:16:23Z","updated_at":"2015-03-21T14:16:23Z","html_url":"https://github.com/liip/LiipFunctionalTestBundle/pull/147#discussion_r26892148","pull_request_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/pulls/147","_links":{"self":{"href":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/pulls/comments/26892148"},"html":{"href":"https://github.com/liip/LiipFunctionalTestBundle/pull/147#discussion_r26892148"},"pull_request":{"href":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/pulls/147"}}},"pull_request":{"url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/pulls/147","id":31667362,"html_url":"https://github.com/liip/LiipFunctionalTestBundle/pull/147","diff_url":"https://github.com/liip/LiipFunctionalTestBundle/pull/147.diff","patch_url":"https://github.com/liip/LiipFunctionalTestBundle/pull/147.patch","issue_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/issues/147","number":147,"state":"open","locked":false,"title":"fix type hints and doc comments","user":{"login":"Ma27","id":6025220,"avatar_url":"https://avatars.githubusercontent.com/u/6025220?v=3","gravatar_id":"","url":"https://api.github.com/users/Ma27","html_url":"https://github.com/Ma27","followers_url":"https://api.github.com/users/Ma27/followers","following_url":"https://api.github.com/users/Ma27/following{/other_user}","gists_url":"https://api.github.com/users/Ma27/gists{/gist_id}","starred_url":"https://api.github.com/users/Ma27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ma27/subscriptions","organizations_url":"https://api.github.com/users/Ma27/orgs","repos_url":"https://api.github.com/users/Ma27/repos","events_url":"https://api.github.com/users/Ma27/events{/privacy}","received_events_url":"https://api.github.com/users/Ma27/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-21T06:58:34Z","updated_at":"2015-03-21T14:16:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acecac516104a1492867c2c201130d070853145b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/pulls/147/commits","review_comments_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/pulls/147/comments","review_comment_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/issues/147/comments","statuses_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/statuses/ee889ff301e53ea4b5329a566281e806cd64d7b7","head":{"label":"Ma27:patch-1","ref":"patch-1","sha":"ee889ff301e53ea4b5329a566281e806cd64d7b7","user":{"login":"Ma27","id":6025220,"avatar_url":"https://avatars.githubusercontent.com/u/6025220?v=3","gravatar_id":"","url":"https://api.github.com/users/Ma27","html_url":"https://github.com/Ma27","followers_url":"https://api.github.com/users/Ma27/followers","following_url":"https://api.github.com/users/Ma27/following{/other_user}","gists_url":"https://api.github.com/users/Ma27/gists{/gist_id}","starred_url":"https://api.github.com/users/Ma27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ma27/subscriptions","organizations_url":"https://api.github.com/users/Ma27/orgs","repos_url":"https://api.github.com/users/Ma27/repos","events_url":"https://api.github.com/users/Ma27/events{/privacy}","received_events_url":"https://api.github.com/users/Ma27/received_events","type":"User","site_admin":false},"repo":{"id":32623091,"name":"LiipFunctionalTestBundle","full_name":"Ma27/LiipFunctionalTestBundle","owner":{"login":"Ma27","id":6025220,"avatar_url":"https://avatars.githubusercontent.com/u/6025220?v=3","gravatar_id":"","url":"https://api.github.com/users/Ma27","html_url":"https://github.com/Ma27","followers_url":"https://api.github.com/users/Ma27/followers","following_url":"https://api.github.com/users/Ma27/following{/other_user}","gists_url":"https://api.github.com/users/Ma27/gists{/gist_id}","starred_url":"https://api.github.com/users/Ma27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ma27/subscriptions","organizations_url":"https://api.github.com/users/Ma27/orgs","repos_url":"https://api.github.com/users/Ma27/repos","events_url":"https://api.github.com/users/Ma27/events{/privacy}","received_events_url":"https://api.github.com/users/Ma27/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ma27/LiipFunctionalTestBundle","description":"Some helper classes for writing functional tests in Symfony2","fork":true,"url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle","forks_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/forks","keys_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/teams","hooks_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/hooks","issue_events_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/issues/events{/number}","events_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/events","assignees_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/assignees{/user}","branches_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/branches{/branch}","tags_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/tags","blobs_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/languages","stargazers_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/stargazers","contributors_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/contributors","subscribers_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/subscribers","subscription_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/subscription","commits_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/contents/{+path}","compare_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/merges","archive_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/downloads","issues_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/issues{/number}","pulls_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/labels{/name}","releases_url":"https://api.github.com/repos/Ma27/LiipFunctionalTestBundle/releases{/id}","created_at":"2015-03-21T06:53:29Z","updated_at":"2015-03-21T06:53:29Z","pushed_at":"2015-03-21T06:58:27Z","git_url":"git://github.com/Ma27/LiipFunctionalTestBundle.git","ssh_url":"git@github.com:Ma27/LiipFunctionalTestBundle.git","clone_url":"https://github.com/Ma27/LiipFunctionalTestBundle.git","svn_url":"https://github.com/Ma27/LiipFunctionalTestBundle","homepage":"http://liip.ch","size":675,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"liip:master","ref":"master","sha":"0f7b983a22b59cbee27ff6e26c7a9a8d805eb5e2","user":{"login":"liip","id":166102,"avatar_url":"https://avatars.githubusercontent.com/u/166102?v=3","gravatar_id":"","url":"https://api.github.com/users/liip","html_url":"https://github.com/liip","followers_url":"https://api.github.com/users/liip/followers","following_url":"https://api.github.com/users/liip/following{/other_user}","gists_url":"https://api.github.com/users/liip/gists{/gist_id}","starred_url":"https://api.github.com/users/liip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liip/subscriptions","organizations_url":"https://api.github.com/users/liip/orgs","repos_url":"https://api.github.com/users/liip/repos","events_url":"https://api.github.com/users/liip/events{/privacy}","received_events_url":"https://api.github.com/users/liip/received_events","type":"Organization","site_admin":false},"repo":{"id":1197537,"name":"LiipFunctionalTestBundle","full_name":"liip/LiipFunctionalTestBundle","owner":{"login":"liip","id":166102,"avatar_url":"https://avatars.githubusercontent.com/u/166102?v=3","gravatar_id":"","url":"https://api.github.com/users/liip","html_url":"https://github.com/liip","followers_url":"https://api.github.com/users/liip/followers","following_url":"https://api.github.com/users/liip/following{/other_user}","gists_url":"https://api.github.com/users/liip/gists{/gist_id}","starred_url":"https://api.github.com/users/liip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liip/subscriptions","organizations_url":"https://api.github.com/users/liip/orgs","repos_url":"https://api.github.com/users/liip/repos","events_url":"https://api.github.com/users/liip/events{/privacy}","received_events_url":"https://api.github.com/users/liip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/liip/LiipFunctionalTestBundle","description":"Some helper classes for writing functional tests in Symfony2","fork":false,"url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle","forks_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/forks","keys_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/teams","hooks_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/hooks","issue_events_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/issues/events{/number}","events_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/events","assignees_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/assignees{/user}","branches_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/branches{/branch}","tags_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/tags","blobs_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/languages","stargazers_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/stargazers","contributors_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/contributors","subscribers_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/subscribers","subscription_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/subscription","commits_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/contents/{+path}","compare_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/merges","archive_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/downloads","issues_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/issues{/number}","pulls_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/labels{/name}","releases_url":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/releases{/id}","created_at":"2010-12-25T18:58:03Z","updated_at":"2015-03-21T07:01:56Z","pushed_at":"2015-03-21T06:58:34Z","git_url":"git://github.com/liip/LiipFunctionalTestBundle.git","ssh_url":"git@github.com:liip/LiipFunctionalTestBundle.git","clone_url":"https://github.com/liip/LiipFunctionalTestBundle.git","svn_url":"https://github.com/liip/LiipFunctionalTestBundle","homepage":"http://liip.ch","size":675,"stargazers_count":219,"watchers_count":219,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":74,"mirror_url":null,"open_issues_count":19,"forks":74,"open_issues":19,"watchers":219,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/pulls/147"},"html":{"href":"https://github.com/liip/LiipFunctionalTestBundle/pull/147"},"issue":{"href":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/issues/147"},"comments":{"href":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/liip/LiipFunctionalTestBundle/statuses/ee889ff301e53ea4b5329a566281e806cd64d7b7"}}}}