{"action":"opened","number":73,"pull_request":{"url":"https://api.github.com/repos/rapid7/ruby_smb/pulls/73","id":42888353,"html_url":"https://github.com/rapid7/ruby_smb/pull/73","diff_url":"https://github.com/rapid7/ruby_smb/pull/73.diff","patch_url":"https://github.com/rapid7/ruby_smb/pull/73.patch","issue_url":"https://api.github.com/repos/rapid7/ruby_smb/issues/73","number":73,"state":"open","locked":false,"title":"switch to bin data, negotiate command done","user":{"login":"lsato-r7","id":13524955,"avatar_url":"https://avatars.githubusercontent.com/u/13524955?v=3","gravatar_id":"","url":"https://api.github.com/users/lsato-r7","html_url":"https://github.com/lsato-r7","followers_url":"https://api.github.com/users/lsato-r7/followers","following_url":"https://api.github.com/users/lsato-r7/following{/other_user}","gists_url":"https://api.github.com/users/lsato-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/lsato-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsato-r7/subscriptions","organizations_url":"https://api.github.com/users/lsato-r7/orgs","repos_url":"https://api.github.com/users/lsato-r7/repos","events_url":"https://api.github.com/users/lsato-r7/events{/privacy}","received_events_url":"https://api.github.com/users/lsato-r7/received_events","type":"User","site_admin":false},"body":"MSP-12911\r\n\r\n1. Made the switch to bindata\r\n2. Negotiate command request done\r\n3. Negotiate command response done\r\n\r\nGENERAL VERIFICATION STEPS \r\n- [ ] `rake spec`\r\n- [ ] VERIFY all specs pass (version may fail because of this being a branch off of staging)\r\n\r\nNEGOTIATE COMMAND REQUEST STEPS (in bundle console)\r\n- [ ] `request = RubySMB::SMB1::Packet::NegotiateCommand::Request.new` \r\n    - creates an instance of a negotiate request with :protocol being \"\\xFFSMB\"\r\n- [ ] `request.initialize_command` \r\n    - sets :command to 0x72\r\n- [ ] `dialect = RubySMB::SMB1::Packet::NegotiateCommand::Dialect.new(:dialect_string => \"NT LM 0.12\")` \r\n    - creates an instance of a dialect with :dialect_string being \"NT LM 0.12\"\r\n    - :buffer_format should be 0x2\r\n- [ ] `request.set_dialects([dialect])`\r\n    - the request's data block should include the binary string of dialect\r\n- [ ] `request.to_binary_s` \r\n    - should return the binary string of the created negotiate request\r\n\r\n\r\nNEGOTIATE COMMAND RESPONSE STEPS (in bundle console)\r\n- [ ] `core_response_bin_s = \"\\xFF\\x53\\x4d\\x42\\x72\\x00\\x00\\x00\\x00\\x18\\x01H\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\xFF\\xFF\\x00\\x00\\x00\\x00\\x00\\x00\\x01\\x00\\x01\\x00\\x00\"`\r\n- [ ] `response = RubySMB::SMB1::Packet::NegotiateCommand::Response.parse(core_response_bin_s)`\r\n    - should return an instance of a NegotiateCommand::Response with parameter block having a :word_count of 1 and :words being 1 \r\n- [ ] `response.nt_lm_response_block` \r\n    - should return an instance of a NTLMParameterBlock with only :word_count and :words attributes\r\n- [ ] `nt_lm_response_bin_s = \"\\xFF\\x53\\x4d\\x42\\x72\\x00\\x00\\x00\\x00\\x18\\x01H\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\xFF\\xFF\\x00\\x00\\x00\\x00\\x00\\x00\\x11\\x00\\x02\\x01\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\"`\r\n- [ ] `response = RubySMB::SMB1::Packet::NegotiateCommand::Response.parse(nt_lm_response_bin_s)`\r\n    - should return an instance of a NegotiateCommand::Response with parameter block having a :word_count of 17 (for nt lm dialects)\r\n- [ ] `response.nt_lm_response_block`\r\n    - should return an instance of a NTLMParameterBlock this time with additional attributes specifically for when dialect is NT LM\r\n\r\n","created_at":"2015-08-20T03:36:47Z","updated_at":"2015-08-20T03:36:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/ruby_smb/pulls/73/commits","review_comments_url":"https://api.github.com/repos/rapid7/ruby_smb/pulls/73/comments","review_comment_url":"https://api.github.com/repos/rapid7/ruby_smb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapid7/ruby_smb/issues/73/comments","statuses_url":"https://api.github.com/repos/rapid7/ruby_smb/statuses/9b5af8bf0e29f750603c41de9a0a2c09b68510c6","head":{"label":"rapid7:staging/MSP-12911/smb1-negotiate-request-bindata","ref":"staging/MSP-12911/smb1-negotiate-request-bindata","sha":"9b5af8bf0e29f750603c41de9a0a2c09b68510c6","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":28427043,"name":"ruby_smb","full_name":"rapid7/ruby_smb","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/ruby_smb","description":"A packet parsing and manipulation library for the SMB protocol family","fork":false,"url":"https://api.github.com/repos/rapid7/ruby_smb","forks_url":"https://api.github.com/repos/rapid7/ruby_smb/forks","keys_url":"https://api.github.com/repos/rapid7/ruby_smb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/ruby_smb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/ruby_smb/teams","hooks_url":"https://api.github.com/repos/rapid7/ruby_smb/hooks","issue_events_url":"https://api.github.com/repos/rapid7/ruby_smb/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/ruby_smb/events","assignees_url":"https://api.github.com/repos/rapid7/ruby_smb/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/ruby_smb/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/ruby_smb/tags","blobs_url":"https://api.github.com/repos/rapid7/ruby_smb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/ruby_smb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/ruby_smb/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/ruby_smb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/ruby_smb/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/ruby_smb/languages","stargazers_url":"https://api.github.com/repos/rapid7/ruby_smb/stargazers","contributors_url":"https://api.github.com/repos/rapid7/ruby_smb/contributors","subscribers_url":"https://api.github.com/repos/rapid7/ruby_smb/subscribers","subscription_url":"https://api.github.com/repos/rapid7/ruby_smb/subscription","commits_url":"https://api.github.com/repos/rapid7/ruby_smb/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/ruby_smb/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/ruby_smb/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/ruby_smb/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/ruby_smb/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/ruby_smb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/ruby_smb/merges","archive_url":"https://api.github.com/repos/rapid7/ruby_smb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/ruby_smb/downloads","issues_url":"https://api.github.com/repos/rapid7/ruby_smb/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/ruby_smb/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/ruby_smb/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/ruby_smb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/ruby_smb/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/ruby_smb/releases{/id}","created_at":"2014-12-24T00:51:22Z","updated_at":"2015-07-23T15:35:16Z","pushed_at":"2015-08-20T03:36:47Z","git_url":"git://github.com/rapid7/ruby_smb.git","ssh_url":"git@github.com:rapid7/ruby_smb.git","clone_url":"https://github.com/rapid7/ruby_smb.git","svn_url":"https://github.com/rapid7/ruby_smb","homepage":"","size":1254,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":25,"forks":9,"open_issues":25,"watchers":4,"default_branch":"master"}},"base":{"label":"rapid7:staging/MSP-12911/smb1-negotiate-request","ref":"staging/MSP-12911/smb1-negotiate-request","sha":"d2a06c859bd63711214abebb357c593bfb0aa8b0","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":28427043,"name":"ruby_smb","full_name":"rapid7/ruby_smb","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/ruby_smb","description":"A packet parsing and manipulation library for the SMB protocol family","fork":false,"url":"https://api.github.com/repos/rapid7/ruby_smb","forks_url":"https://api.github.com/repos/rapid7/ruby_smb/forks","keys_url":"https://api.github.com/repos/rapid7/ruby_smb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/ruby_smb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/ruby_smb/teams","hooks_url":"https://api.github.com/repos/rapid7/ruby_smb/hooks","issue_events_url":"https://api.github.com/repos/rapid7/ruby_smb/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/ruby_smb/events","assignees_url":"https://api.github.com/repos/rapid7/ruby_smb/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/ruby_smb/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/ruby_smb/tags","blobs_url":"https://api.github.com/repos/rapid7/ruby_smb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/ruby_smb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/ruby_smb/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/ruby_smb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/ruby_smb/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/ruby_smb/languages","stargazers_url":"https://api.github.com/repos/rapid7/ruby_smb/stargazers","contributors_url":"https://api.github.com/repos/rapid7/ruby_smb/contributors","subscribers_url":"https://api.github.com/repos/rapid7/ruby_smb/subscribers","subscription_url":"https://api.github.com/repos/rapid7/ruby_smb/subscription","commits_url":"https://api.github.com/repos/rapid7/ruby_smb/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/ruby_smb/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/ruby_smb/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/ruby_smb/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/ruby_smb/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/ruby_smb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/ruby_smb/merges","archive_url":"https://api.github.com/repos/rapid7/ruby_smb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/ruby_smb/downloads","issues_url":"https://api.github.com/repos/rapid7/ruby_smb/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/ruby_smb/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/ruby_smb/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/ruby_smb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/ruby_smb/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/ruby_smb/releases{/id}","created_at":"2014-12-24T00:51:22Z","updated_at":"2015-07-23T15:35:16Z","pushed_at":"2015-08-20T03:36:47Z","git_url":"git://github.com/rapid7/ruby_smb.git","ssh_url":"git@github.com:rapid7/ruby_smb.git","clone_url":"https://github.com/rapid7/ruby_smb.git","svn_url":"https://github.com/rapid7/ruby_smb","homepage":"","size":1254,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":25,"forks":9,"open_issues":25,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/ruby_smb/pulls/73"},"html":{"href":"https://github.com/rapid7/ruby_smb/pull/73"},"issue":{"href":"https://api.github.com/repos/rapid7/ruby_smb/issues/73"},"comments":{"href":"https://api.github.com/repos/rapid7/ruby_smb/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/ruby_smb/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/ruby_smb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapid7/ruby_smb/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/ruby_smb/statuses/9b5af8bf0e29f750603c41de9a0a2c09b68510c6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":458,"deletions":69,"changed_files":22}}