{"action":"closed","number":301,"pull_request":{"url":"https://api.github.com/repos/aldeed/meteor-simple-schema/pulls/301","id":31666296,"html_url":"https://github.com/aldeed/meteor-simple-schema/pull/301","diff_url":"https://github.com/aldeed/meteor-simple-schema/pull/301.diff","patch_url":"https://github.com/aldeed/meteor-simple-schema/pull/301.patch","issue_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/issues/301","number":301,"state":"closed","locked":false,"title":"Set nested optional","user":{"login":"outluch","id":1479468,"avatar_url":"https://avatars.githubusercontent.com/u/1479468?v=3","gravatar_id":"","url":"https://api.github.com/users/outluch","html_url":"https://github.com/outluch","followers_url":"https://api.github.com/users/outluch/followers","following_url":"https://api.github.com/users/outluch/following{/other_user}","gists_url":"https://api.github.com/users/outluch/gists{/gist_id}","starred_url":"https://api.github.com/users/outluch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outluch/subscriptions","organizations_url":"https://api.github.com/users/outluch/orgs","repos_url":"https://api.github.com/users/outluch/repos","events_url":"https://api.github.com/users/outluch/events{/privacy}","received_events_url":"https://api.github.com/users/outluch/received_events","type":"User","site_admin":false},"body":"Found the bug: when I \r\n```\r\n$set {requiredObj: {requiredField: 'blah', optionalField: '' } }\r\n```\r\nIt makes clean(), and modifier becomes: \r\n```\r\n$set: {requiredObj: {requiredField: 'blah'}}, \r\n$unset: {requiredObj: {optionalField: undefined}}\r\n```\r\nand it fails on validation of requiredObj / $unset operation. But it shouldnt, because it will fail if some nested validations fails. If they optional, we shouldnt ","created_at":"2015-03-21T05:08:48Z","updated_at":"2015-03-28T16:43:11Z","closed_at":"2015-03-28T16:43:11Z","merged_at":null,"merge_commit_sha":"cad1c2b93812ccddf3c18d8dee549178dea9ec06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/pulls/301/commits","review_comments_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/pulls/301/comments","review_comment_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/issues/301/comments","statuses_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/statuses/7fe45763f88ca90895e381529438d746255b09fe","head":{"label":"outluch:set_nested_optional","ref":"set_nested_optional","sha":"7fe45763f88ca90895e381529438d746255b09fe","user":{"login":"outluch","id":1479468,"avatar_url":"https://avatars.githubusercontent.com/u/1479468?v=3","gravatar_id":"","url":"https://api.github.com/users/outluch","html_url":"https://github.com/outluch","followers_url":"https://api.github.com/users/outluch/followers","following_url":"https://api.github.com/users/outluch/following{/other_user}","gists_url":"https://api.github.com/users/outluch/gists{/gist_id}","starred_url":"https://api.github.com/users/outluch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outluch/subscriptions","organizations_url":"https://api.github.com/users/outluch/orgs","repos_url":"https://api.github.com/users/outluch/repos","events_url":"https://api.github.com/users/outluch/events{/privacy}","received_events_url":"https://api.github.com/users/outluch/received_events","type":"User","site_admin":false},"repo":{"id":32615095,"name":"meteor-simple-schema","full_name":"outluch/meteor-simple-schema","owner":{"login":"outluch","id":1479468,"avatar_url":"https://avatars.githubusercontent.com/u/1479468?v=3","gravatar_id":"","url":"https://api.github.com/users/outluch","html_url":"https://github.com/outluch","followers_url":"https://api.github.com/users/outluch/followers","following_url":"https://api.github.com/users/outluch/following{/other_user}","gists_url":"https://api.github.com/users/outluch/gists{/gist_id}","starred_url":"https://api.github.com/users/outluch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outluch/subscriptions","organizations_url":"https://api.github.com/users/outluch/orgs","repos_url":"https://api.github.com/users/outluch/repos","events_url":"https://api.github.com/users/outluch/events{/privacy}","received_events_url":"https://api.github.com/users/outluch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/outluch/meteor-simple-schema","description":"A simple, reactive schema validation smart package for Meteor.","fork":true,"url":"https://api.github.com/repos/outluch/meteor-simple-schema","forks_url":"https://api.github.com/repos/outluch/meteor-simple-schema/forks","keys_url":"https://api.github.com/repos/outluch/meteor-simple-schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/outluch/meteor-simple-schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/outluch/meteor-simple-schema/teams","hooks_url":"https://api.github.com/repos/outluch/meteor-simple-schema/hooks","issue_events_url":"https://api.github.com/repos/outluch/meteor-simple-schema/issues/events{/number}","events_url":"https://api.github.com/repos/outluch/meteor-simple-schema/events","assignees_url":"https://api.github.com/repos/outluch/meteor-simple-schema/assignees{/user}","branches_url":"https://api.github.com/repos/outluch/meteor-simple-schema/branches{/branch}","tags_url":"https://api.github.com/repos/outluch/meteor-simple-schema/tags","blobs_url":"https://api.github.com/repos/outluch/meteor-simple-schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/outluch/meteor-simple-schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/outluch/meteor-simple-schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/outluch/meteor-simple-schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/outluch/meteor-simple-schema/statuses/{sha}","languages_url":"https://api.github.com/repos/outluch/meteor-simple-schema/languages","stargazers_url":"https://api.github.com/repos/outluch/meteor-simple-schema/stargazers","contributors_url":"https://api.github.com/repos/outluch/meteor-simple-schema/contributors","subscribers_url":"https://api.github.com/repos/outluch/meteor-simple-schema/subscribers","subscription_url":"https://api.github.com/repos/outluch/meteor-simple-schema/subscription","commits_url":"https://api.github.com/repos/outluch/meteor-simple-schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/outluch/meteor-simple-schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/outluch/meteor-simple-schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/outluch/meteor-simple-schema/issues/comments{/number}","contents_url":"https://api.github.com/repos/outluch/meteor-simple-schema/contents/{+path}","compare_url":"https://api.github.com/repos/outluch/meteor-simple-schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/outluch/meteor-simple-schema/merges","archive_url":"https://api.github.com/repos/outluch/meteor-simple-schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/outluch/meteor-simple-schema/downloads","issues_url":"https://api.github.com/repos/outluch/meteor-simple-schema/issues{/number}","pulls_url":"https://api.github.com/repos/outluch/meteor-simple-schema/pulls{/number}","milestones_url":"https://api.github.com/repos/outluch/meteor-simple-schema/milestones{/number}","notifications_url":"https://api.github.com/repos/outluch/meteor-simple-schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/outluch/meteor-simple-schema/labels{/name}","releases_url":"https://api.github.com/repos/outluch/meteor-simple-schema/releases{/id}","created_at":"2015-03-21T01:15:59Z","updated_at":"2015-03-21T01:15:59Z","pushed_at":"2015-03-21T04:58:50Z","git_url":"git://github.com/outluch/meteor-simple-schema.git","ssh_url":"git@github.com:outluch/meteor-simple-schema.git","clone_url":"https://github.com/outluch/meteor-simple-schema.git","svn_url":"https://github.com/outluch/meteor-simple-schema","homepage":"https://atmospherejs.com/aldeed/simple-schema","size":910,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aldeed:master","ref":"master","sha":"7e02f9db1eb58742a83cd952cdc9e05db12b3069","user":{"login":"aldeed","id":3012067,"avatar_url":"https://avatars.githubusercontent.com/u/3012067?v=3","gravatar_id":"","url":"https://api.github.com/users/aldeed","html_url":"https://github.com/aldeed","followers_url":"https://api.github.com/users/aldeed/followers","following_url":"https://api.github.com/users/aldeed/following{/other_user}","gists_url":"https://api.github.com/users/aldeed/gists{/gist_id}","starred_url":"https://api.github.com/users/aldeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldeed/subscriptions","organizations_url":"https://api.github.com/users/aldeed/orgs","repos_url":"https://api.github.com/users/aldeed/repos","events_url":"https://api.github.com/users/aldeed/events{/privacy}","received_events_url":"https://api.github.com/users/aldeed/received_events","type":"User","site_admin":false},"repo":{"id":11591669,"name":"meteor-simple-schema","full_name":"aldeed/meteor-simple-schema","owner":{"login":"aldeed","id":3012067,"avatar_url":"https://avatars.githubusercontent.com/u/3012067?v=3","gravatar_id":"","url":"https://api.github.com/users/aldeed","html_url":"https://github.com/aldeed","followers_url":"https://api.github.com/users/aldeed/followers","following_url":"https://api.github.com/users/aldeed/following{/other_user}","gists_url":"https://api.github.com/users/aldeed/gists{/gist_id}","starred_url":"https://api.github.com/users/aldeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldeed/subscriptions","organizations_url":"https://api.github.com/users/aldeed/orgs","repos_url":"https://api.github.com/users/aldeed/repos","events_url":"https://api.github.com/users/aldeed/events{/privacy}","received_events_url":"https://api.github.com/users/aldeed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aldeed/meteor-simple-schema","description":"A simple, reactive schema validation smart package for Meteor.","fork":false,"url":"https://api.github.com/repos/aldeed/meteor-simple-schema","forks_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/forks","keys_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/teams","hooks_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/hooks","issue_events_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/issues/events{/number}","events_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/events","assignees_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/assignees{/user}","branches_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/branches{/branch}","tags_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/tags","blobs_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/statuses/{sha}","languages_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/languages","stargazers_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/stargazers","contributors_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/contributors","subscribers_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/subscribers","subscription_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/subscription","commits_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/issues/comments{/number}","contents_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/contents/{+path}","compare_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/merges","archive_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/downloads","issues_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/issues{/number}","pulls_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/pulls{/number}","milestones_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/milestones{/number}","notifications_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/labels{/name}","releases_url":"https://api.github.com/repos/aldeed/meteor-simple-schema/releases{/id}","created_at":"2013-07-22T20:27:27Z","updated_at":"2015-03-28T16:43:10Z","pushed_at":"2015-03-28T16:43:10Z","git_url":"git://github.com/aldeed/meteor-simple-schema.git","ssh_url":"git@github.com:aldeed/meteor-simple-schema.git","clone_url":"https://github.com/aldeed/meteor-simple-schema.git","svn_url":"https://github.com/aldeed/meteor-simple-schema","homepage":"https://atmospherejs.com/aldeed/simple-schema","size":2438,"stargazers_count":314,"watchers_count":314,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":51,"forks":58,"open_issues":51,"watchers":314,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aldeed/meteor-simple-schema/pulls/301"},"html":{"href":"https://github.com/aldeed/meteor-simple-schema/pull/301"},"issue":{"href":"https://api.github.com/repos/aldeed/meteor-simple-schema/issues/301"},"comments":{"href":"https://api.github.com/repos/aldeed/meteor-simple-schema/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/aldeed/meteor-simple-schema/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/aldeed/meteor-simple-schema/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aldeed/meteor-simple-schema/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/aldeed/meteor-simple-schema/statuses/7fe45763f88ca90895e381529438d746255b09fe"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":5,"additions":104,"deletions":5,"changed_files":4}}