{"action":"closed","number":55,"pull_request":{"url":"https://api.github.com/repos/facebook/planout/pulls/55","id":34783241,"html_url":"https://github.com/facebook/planout/pull/55","diff_url":"https://github.com/facebook/planout/pull/55.diff","patch_url":"https://github.com/facebook/planout/pull/55.patch","issue_url":"https://api.github.com/repos/facebook/planout/issues/55","number":55,"state":"closed","locked":false,"title":"Planout ES6 Port","user":{"login":"rawls238","id":1596135,"avatar_url":"https://avatars.githubusercontent.com/u/1596135?v=3","gravatar_id":"","url":"https://api.github.com/users/rawls238","html_url":"https://github.com/rawls238","followers_url":"https://api.github.com/users/rawls238/followers","following_url":"https://api.github.com/users/rawls238/following{/other_user}","gists_url":"https://api.github.com/users/rawls238/gists{/gist_id}","starred_url":"https://api.github.com/users/rawls238/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawls238/subscriptions","organizations_url":"https://api.github.com/users/rawls238/orgs","repos_url":"https://api.github.com/users/rawls238/repos","events_url":"https://api.github.com/users/rawls238/events{/privacy}","received_events_url":"https://api.github.com/users/rawls238/received_events","type":"User","site_admin":false},"body":"@eytan \r\n\r\nThis ports the Planout python library almost verbatim to Javascript (ES6).\r\n\r\nThere are still two major TODOs before this can be merged in:\r\n1) Right now I use 13 bits of precision for the getHash function which isn't consistent with the other planout libraries. This leads to different assignments for the JS library vs the Python library for the same salt. We can't use the basic JS Number type for this, it's going to require third-party library. I've tried a couple and none has worked correctly, but I will try a few more. \r\n\r\n2) Get the compilation to ES5 working properly so that people can also use Planout in their ES5 code as well.","created_at":"2015-05-06T01:36:35Z","updated_at":"2015-05-12T05:11:17Z","closed_at":"2015-05-12T05:11:17Z","merged_at":"2015-05-12T05:11:17Z","merge_commit_sha":"b86a768a82afff1f5c13f529aff17f7127892cd7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/planout/pulls/55/commits","review_comments_url":"https://api.github.com/repos/facebook/planout/pulls/55/comments","review_comment_url":"https://api.github.com/repos/facebook/planout/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/planout/issues/55/comments","statuses_url":"https://api.github.com/repos/facebook/planout/statuses/a7ef7ede7ba44a8e3082a5cb66214a0f48f7ca58","head":{"label":"rawls238:planout_es6","ref":"planout_es6","sha":"a7ef7ede7ba44a8e3082a5cb66214a0f48f7ca58","user":{"login":"rawls238","id":1596135,"avatar_url":"https://avatars.githubusercontent.com/u/1596135?v=3","gravatar_id":"","url":"https://api.github.com/users/rawls238","html_url":"https://github.com/rawls238","followers_url":"https://api.github.com/users/rawls238/followers","following_url":"https://api.github.com/users/rawls238/following{/other_user}","gists_url":"https://api.github.com/users/rawls238/gists{/gist_id}","starred_url":"https://api.github.com/users/rawls238/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawls238/subscriptions","organizations_url":"https://api.github.com/users/rawls238/orgs","repos_url":"https://api.github.com/users/rawls238/repos","events_url":"https://api.github.com/users/rawls238/events{/privacy}","received_events_url":"https://api.github.com/users/rawls238/received_events","type":"User","site_admin":false},"repo":{"id":34707552,"name":"planout","full_name":"rawls238/planout","owner":{"login":"rawls238","id":1596135,"avatar_url":"https://avatars.githubusercontent.com/u/1596135?v=3","gravatar_id":"","url":"https://api.github.com/users/rawls238","html_url":"https://github.com/rawls238","followers_url":"https://api.github.com/users/rawls238/followers","following_url":"https://api.github.com/users/rawls238/following{/other_user}","gists_url":"https://api.github.com/users/rawls238/gists{/gist_id}","starred_url":"https://api.github.com/users/rawls238/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rawls238/subscriptions","organizations_url":"https://api.github.com/users/rawls238/orgs","repos_url":"https://api.github.com/users/rawls238/repos","events_url":"https://api.github.com/users/rawls238/events{/privacy}","received_events_url":"https://api.github.com/users/rawls238/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rawls238/planout","description":"PlanOut is a library and interpreter for designing online experiments.","fork":true,"url":"https://api.github.com/repos/rawls238/planout","forks_url":"https://api.github.com/repos/rawls238/planout/forks","keys_url":"https://api.github.com/repos/rawls238/planout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rawls238/planout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rawls238/planout/teams","hooks_url":"https://api.github.com/repos/rawls238/planout/hooks","issue_events_url":"https://api.github.com/repos/rawls238/planout/issues/events{/number}","events_url":"https://api.github.com/repos/rawls238/planout/events","assignees_url":"https://api.github.com/repos/rawls238/planout/assignees{/user}","branches_url":"https://api.github.com/repos/rawls238/planout/branches{/branch}","tags_url":"https://api.github.com/repos/rawls238/planout/tags","blobs_url":"https://api.github.com/repos/rawls238/planout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rawls238/planout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rawls238/planout/git/refs{/sha}","trees_url":"https://api.github.com/repos/rawls238/planout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rawls238/planout/statuses/{sha}","languages_url":"https://api.github.com/repos/rawls238/planout/languages","stargazers_url":"https://api.github.com/repos/rawls238/planout/stargazers","contributors_url":"https://api.github.com/repos/rawls238/planout/contributors","subscribers_url":"https://api.github.com/repos/rawls238/planout/subscribers","subscription_url":"https://api.github.com/repos/rawls238/planout/subscription","commits_url":"https://api.github.com/repos/rawls238/planout/commits{/sha}","git_commits_url":"https://api.github.com/repos/rawls238/planout/git/commits{/sha}","comments_url":"https://api.github.com/repos/rawls238/planout/comments{/number}","issue_comment_url":"https://api.github.com/repos/rawls238/planout/issues/comments{/number}","contents_url":"https://api.github.com/repos/rawls238/planout/contents/{+path}","compare_url":"https://api.github.com/repos/rawls238/planout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rawls238/planout/merges","archive_url":"https://api.github.com/repos/rawls238/planout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rawls238/planout/downloads","issues_url":"https://api.github.com/repos/rawls238/planout/issues{/number}","pulls_url":"https://api.github.com/repos/rawls238/planout/pulls{/number}","milestones_url":"https://api.github.com/repos/rawls238/planout/milestones{/number}","notifications_url":"https://api.github.com/repos/rawls238/planout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rawls238/planout/labels{/name}","releases_url":"https://api.github.com/repos/rawls238/planout/releases{/id}","created_at":"2015-04-28T04:07:08Z","updated_at":"2015-04-28T04:07:08Z","pushed_at":"2015-05-12T03:28:45Z","git_url":"git://github.com/rawls238/planout.git","ssh_url":"git@github.com:rawls238/planout.git","clone_url":"https://github.com/rawls238/planout.git","svn_url":"https://github.com/rawls238/planout","homepage":"http://facebook.github.io/planout","size":5498,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"d2706015552aa78c23262b844f9d88ac14f352e2","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":16243124,"name":"planout","full_name":"facebook/planout","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/planout","description":"PlanOut is a library and interpreter for designing online experiments.","fork":false,"url":"https://api.github.com/repos/facebook/planout","forks_url":"https://api.github.com/repos/facebook/planout/forks","keys_url":"https://api.github.com/repos/facebook/planout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/planout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/planout/teams","hooks_url":"https://api.github.com/repos/facebook/planout/hooks","issue_events_url":"https://api.github.com/repos/facebook/planout/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/planout/events","assignees_url":"https://api.github.com/repos/facebook/planout/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/planout/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/planout/tags","blobs_url":"https://api.github.com/repos/facebook/planout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/planout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/planout/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/planout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/planout/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/planout/languages","stargazers_url":"https://api.github.com/repos/facebook/planout/stargazers","contributors_url":"https://api.github.com/repos/facebook/planout/contributors","subscribers_url":"https://api.github.com/repos/facebook/planout/subscribers","subscription_url":"https://api.github.com/repos/facebook/planout/subscription","commits_url":"https://api.github.com/repos/facebook/planout/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/planout/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/planout/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/planout/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/planout/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/planout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/planout/merges","archive_url":"https://api.github.com/repos/facebook/planout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/planout/downloads","issues_url":"https://api.github.com/repos/facebook/planout/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/planout/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/planout/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/planout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/planout/labels{/name}","releases_url":"https://api.github.com/repos/facebook/planout/releases{/id}","created_at":"2014-01-26T00:07:54Z","updated_at":"2015-05-10T12:28:06Z","pushed_at":"2015-05-12T05:11:18Z","git_url":"git://github.com/facebook/planout.git","ssh_url":"git@github.com:facebook/planout.git","clone_url":"https://github.com/facebook/planout.git","svn_url":"https://github.com/facebook/planout","homepage":"http://facebook.github.io/planout","size":7412,"stargazers_count":763,"watchers_count":763,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":89,"mirror_url":null,"open_issues_count":1,"forks":89,"open_issues":1,"watchers":763,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/planout/pulls/55"},"html":{"href":"https://github.com/facebook/planout/pull/55"},"issue":{"href":"https://api.github.com/repos/facebook/planout/issues/55"},"comments":{"href":"https://api.github.com/repos/facebook/planout/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/planout/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/planout/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/planout/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/planout/statuses/a7ef7ede7ba44a8e3082a5cb66214a0f48f7ca58"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"eytan","id":93681,"avatar_url":"https://avatars.githubusercontent.com/u/93681?v=3","gravatar_id":"","url":"https://api.github.com/users/eytan","html_url":"https://github.com/eytan","followers_url":"https://api.github.com/users/eytan/followers","following_url":"https://api.github.com/users/eytan/following{/other_user}","gists_url":"https://api.github.com/users/eytan/gists{/gist_id}","starred_url":"https://api.github.com/users/eytan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eytan/subscriptions","organizations_url":"https://api.github.com/users/eytan/orgs","repos_url":"https://api.github.com/users/eytan/repos","events_url":"https://api.github.com/users/eytan/events{/privacy}","received_events_url":"https://api.github.com/users/eytan/received_events","type":"User","site_admin":false},"comments":12,"review_comments":7,"commits":25,"additions":8810,"deletions":0,"changed_files":23}}