{"action":"created","comment":{"url":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/comments/33020539","id":33020539,"diff_hunk":"@@ -254,20 +254,28 @@ public class DefaultLocalizedStringManager : ILocalizedStringManager {\n             }\r\n         }\r\n \r\n+        private static string TrimQuote(string str) {\r\n+            if (str.StartsWith(\"\\\"\") && str.EndsWith(\"\\\"\")) {\r","path":"src/Orchard/Localization/Services/DefaultLocalizedStringManager.cs","position":5,"original_position":5,"commit_id":"104cf7d5f4c36ef9b42fffbd847479e3b02b26d2","original_commit_id":"104cf7d5f4c36ef9b42fffbd847479e3b02b26d2","user":{"login":"MpDzik","id":5750314,"avatar_url":"https://avatars.githubusercontent.com/u/5750314?v=3","gravatar_id":"","url":"https://api.github.com/users/MpDzik","html_url":"https://github.com/MpDzik","followers_url":"https://api.github.com/users/MpDzik/followers","following_url":"https://api.github.com/users/MpDzik/following{/other_user}","gists_url":"https://api.github.com/users/MpDzik/gists{/gist_id}","starred_url":"https://api.github.com/users/MpDzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MpDzik/subscriptions","organizations_url":"https://api.github.com/users/MpDzik/orgs","repos_url":"https://api.github.com/users/MpDzik/repos","events_url":"https://api.github.com/users/MpDzik/events{/privacy}","received_events_url":"https://api.github.com/users/MpDzik/received_events","type":"User","site_admin":false},"body":"Good point. I see that the `DefaultLocalizedStringManager` doesn't have any tests and it is coupled with a lot of interfaces, so I'll have to refactor it a little bit. I'll update the PR soon.","created_at":"2015-06-23T08:43:14Z","updated_at":"2015-06-23T08:43:14Z","html_url":"https://github.com/OrchardCMS/Orchard/pull/5404#discussion_r33020539","pull_request_url":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/5404","_links":{"self":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/comments/33020539"},"html":{"href":"https://github.com/OrchardCMS/Orchard/pull/5404#discussion_r33020539"},"pull_request":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/5404"}}},"pull_request":{"url":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/5404","id":38174012,"html_url":"https://github.com/OrchardCMS/Orchard/pull/5404","diff_url":"https://github.com/OrchardCMS/Orchard/pull/5404.diff","patch_url":"https://github.com/OrchardCMS/Orchard/pull/5404.patch","issue_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/5404","number":5404,"state":"open","locked":false,"title":"Fix handling localized strings with quotes","user":{"login":"MpDzik","id":5750314,"avatar_url":"https://avatars.githubusercontent.com/u/5750314?v=3","gravatar_id":"","url":"https://api.github.com/users/MpDzik","html_url":"https://github.com/MpDzik","followers_url":"https://api.github.com/users/MpDzik/followers","following_url":"https://api.github.com/users/MpDzik/following{/other_user}","gists_url":"https://api.github.com/users/MpDzik/gists{/gist_id}","starred_url":"https://api.github.com/users/MpDzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MpDzik/subscriptions","organizations_url":"https://api.github.com/users/MpDzik/orgs","repos_url":"https://api.github.com/users/MpDzik/repos","events_url":"https://api.github.com/users/MpDzik/events{/privacy}","received_events_url":"https://api.github.com/users/MpDzik/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-20T20:43:53Z","updated_at":"2015-06-23T08:43:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f198f2a2ca74f893e325ff40c0396b3a9f149fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/5404/commits","review_comments_url":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/5404/comments","review_comment_url":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/5404/comments","statuses_url":"https://api.github.com/repos/OrchardCMS/Orchard/statuses/104cf7d5f4c36ef9b42fffbd847479e3b02b26d2","head":{"label":"MpDzik:pr/localize-quote","ref":"pr/localize-quote","sha":"104cf7d5f4c36ef9b42fffbd847479e3b02b26d2","user":{"login":"MpDzik","id":5750314,"avatar_url":"https://avatars.githubusercontent.com/u/5750314?v=3","gravatar_id":"","url":"https://api.github.com/users/MpDzik","html_url":"https://github.com/MpDzik","followers_url":"https://api.github.com/users/MpDzik/followers","following_url":"https://api.github.com/users/MpDzik/following{/other_user}","gists_url":"https://api.github.com/users/MpDzik/gists{/gist_id}","starred_url":"https://api.github.com/users/MpDzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MpDzik/subscriptions","organizations_url":"https://api.github.com/users/MpDzik/orgs","repos_url":"https://api.github.com/users/MpDzik/repos","events_url":"https://api.github.com/users/MpDzik/events{/privacy}","received_events_url":"https://api.github.com/users/MpDzik/received_events","type":"User","site_admin":false},"repo":{"id":33919306,"name":"Orchard","full_name":"MpDzik/Orchard","owner":{"login":"MpDzik","id":5750314,"avatar_url":"https://avatars.githubusercontent.com/u/5750314?v=3","gravatar_id":"","url":"https://api.github.com/users/MpDzik","html_url":"https://github.com/MpDzik","followers_url":"https://api.github.com/users/MpDzik/followers","following_url":"https://api.github.com/users/MpDzik/following{/other_user}","gists_url":"https://api.github.com/users/MpDzik/gists{/gist_id}","starred_url":"https://api.github.com/users/MpDzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MpDzik/subscriptions","organizations_url":"https://api.github.com/users/MpDzik/orgs","repos_url":"https://api.github.com/users/MpDzik/repos","events_url":"https://api.github.com/users/MpDzik/events{/privacy}","received_events_url":"https://api.github.com/users/MpDzik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MpDzik/Orchard","description":"Orchard is a free, open source, community-focused Content Management System built on the ASP.NET MVC platform.","fork":true,"url":"https://api.github.com/repos/MpDzik/Orchard","forks_url":"https://api.github.com/repos/MpDzik/Orchard/forks","keys_url":"https://api.github.com/repos/MpDzik/Orchard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MpDzik/Orchard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MpDzik/Orchard/teams","hooks_url":"https://api.github.com/repos/MpDzik/Orchard/hooks","issue_events_url":"https://api.github.com/repos/MpDzik/Orchard/issues/events{/number}","events_url":"https://api.github.com/repos/MpDzik/Orchard/events","assignees_url":"https://api.github.com/repos/MpDzik/Orchard/assignees{/user}","branches_url":"https://api.github.com/repos/MpDzik/Orchard/branches{/branch}","tags_url":"https://api.github.com/repos/MpDzik/Orchard/tags","blobs_url":"https://api.github.com/repos/MpDzik/Orchard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MpDzik/Orchard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MpDzik/Orchard/git/refs{/sha}","trees_url":"https://api.github.com/repos/MpDzik/Orchard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MpDzik/Orchard/statuses/{sha}","languages_url":"https://api.github.com/repos/MpDzik/Orchard/languages","stargazers_url":"https://api.github.com/repos/MpDzik/Orchard/stargazers","contributors_url":"https://api.github.com/repos/MpDzik/Orchard/contributors","subscribers_url":"https://api.github.com/repos/MpDzik/Orchard/subscribers","subscription_url":"https://api.github.com/repos/MpDzik/Orchard/subscription","commits_url":"https://api.github.com/repos/MpDzik/Orchard/commits{/sha}","git_commits_url":"https://api.github.com/repos/MpDzik/Orchard/git/commits{/sha}","comments_url":"https://api.github.com/repos/MpDzik/Orchard/comments{/number}","issue_comment_url":"https://api.github.com/repos/MpDzik/Orchard/issues/comments{/number}","contents_url":"https://api.github.com/repos/MpDzik/Orchard/contents/{+path}","compare_url":"https://api.github.com/repos/MpDzik/Orchard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MpDzik/Orchard/merges","archive_url":"https://api.github.com/repos/MpDzik/Orchard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MpDzik/Orchard/downloads","issues_url":"https://api.github.com/repos/MpDzik/Orchard/issues{/number}","pulls_url":"https://api.github.com/repos/MpDzik/Orchard/pulls{/number}","milestones_url":"https://api.github.com/repos/MpDzik/Orchard/milestones{/number}","notifications_url":"https://api.github.com/repos/MpDzik/Orchard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MpDzik/Orchard/labels{/name}","releases_url":"https://api.github.com/repos/MpDzik/Orchard/releases{/id}","created_at":"2015-04-14T08:14:38Z","updated_at":"2015-04-14T08:14:47Z","pushed_at":"2015-06-21T15:43:28Z","git_url":"git://github.com/MpDzik/Orchard.git","ssh_url":"git@github.com:MpDzik/Orchard.git","clone_url":"https://github.com/MpDzik/Orchard.git","svn_url":"https://github.com/MpDzik/Orchard","homepage":"http://orchardproject.net","size":90296,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OrchardCMS:1.9.x","ref":"1.9.x","sha":"220c1b591a211d15cf221054ded13152299ba1ca","user":{"login":"OrchardCMS","id":1159247,"avatar_url":"https://avatars.githubusercontent.com/u/1159247?v=3","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":33889464,"name":"Orchard","full_name":"OrchardCMS/Orchard","owner":{"login":"OrchardCMS","id":1159247,"avatar_url":"https://avatars.githubusercontent.com/u/1159247?v=3","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OrchardCMS/Orchard","description":"Orchard is a free, open source, community-focused Content Management System built on the ASP.NET MVC platform.","fork":false,"url":"https://api.github.com/repos/OrchardCMS/Orchard","forks_url":"https://api.github.com/repos/OrchardCMS/Orchard/forks","keys_url":"https://api.github.com/repos/OrchardCMS/Orchard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrchardCMS/Orchard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrchardCMS/Orchard/teams","hooks_url":"https://api.github.com/repos/OrchardCMS/Orchard/hooks","issue_events_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/events{/number}","events_url":"https://api.github.com/repos/OrchardCMS/Orchard/events","assignees_url":"https://api.github.com/repos/OrchardCMS/Orchard/assignees{/user}","branches_url":"https://api.github.com/repos/OrchardCMS/Orchard/branches{/branch}","tags_url":"https://api.github.com/repos/OrchardCMS/Orchard/tags","blobs_url":"https://api.github.com/repos/OrchardCMS/Orchard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrchardCMS/Orchard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrchardCMS/Orchard/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrchardCMS/Orchard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrchardCMS/Orchard/statuses/{sha}","languages_url":"https://api.github.com/repos/OrchardCMS/Orchard/languages","stargazers_url":"https://api.github.com/repos/OrchardCMS/Orchard/stargazers","contributors_url":"https://api.github.com/repos/OrchardCMS/Orchard/contributors","subscribers_url":"https://api.github.com/repos/OrchardCMS/Orchard/subscribers","subscription_url":"https://api.github.com/repos/OrchardCMS/Orchard/subscription","commits_url":"https://api.github.com/repos/OrchardCMS/Orchard/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrchardCMS/Orchard/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrchardCMS/Orchard/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrchardCMS/Orchard/contents/{+path}","compare_url":"https://api.github.com/repos/OrchardCMS/Orchard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrchardCMS/Orchard/merges","archive_url":"https://api.github.com/repos/OrchardCMS/Orchard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrchardCMS/Orchard/downloads","issues_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues{/number}","pulls_url":"https://api.github.com/repos/OrchardCMS/Orchard/pulls{/number}","milestones_url":"https://api.github.com/repos/OrchardCMS/Orchard/milestones{/number}","notifications_url":"https://api.github.com/repos/OrchardCMS/Orchard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrchardCMS/Orchard/labels{/name}","releases_url":"https://api.github.com/repos/OrchardCMS/Orchard/releases{/id}","created_at":"2015-04-13T19:35:52Z","updated_at":"2015-06-22T20:16:47Z","pushed_at":"2015-06-22T22:55:41Z","git_url":"git://github.com/OrchardCMS/Orchard.git","ssh_url":"git@github.com:OrchardCMS/Orchard.git","clone_url":"https://github.com/OrchardCMS/Orchard.git","svn_url":"https://github.com/OrchardCMS/Orchard","homepage":"http://orchardproject.net","size":132593,"stargazers_count":281,"watchers_count":281,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":1433,"forks":162,"open_issues":1433,"watchers":281,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/5404"},"html":{"href":"https://github.com/OrchardCMS/Orchard/pull/5404"},"issue":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/issues/5404"},"comments":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/issues/5404/comments"},"review_comments":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/5404/comments"},"review_comment":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/pulls/5404/commits"},"statuses":{"href":"https://api.github.com/repos/OrchardCMS/Orchard/statuses/104cf7d5f4c36ef9b42fffbd847479e3b02b26d2"}}}}