{"action":"created","comment":{"url":"https://api.github.com/repos/springnz/sparkplug/pulls/comments/47314623","id":47314623,"diff_hunk":"@@ -37,7 +63,12 @@ class ExecutorServiceTests(_system: ActorSystem)\n \n     val clientActor = system.actorOf(Props(new Actor {\n       override def receive = {\n-        case ServerReady ⇒ probe forward ServerReady\n+        case ServerReady ⇒\n+          probe forward ServerReady\n+          sender ! ClientReady\n+\n+        case Terminated(actor) ⇒","path":"sparkplug-executor/src/test/scala/springnz/sparkplug/ExecutorServiceTests.scala","position":80,"original_position":80,"commit_id":"5e2079ee5fcdc9418fe1662bcf8a526d7f15705c","original_commit_id":"5e2079ee5fcdc9418fe1662bcf8a526d7f15705c","user":{"login":"mourednik","id":3468062,"avatar_url":"https://avatars.githubusercontent.com/u/3468062?v=3","gravatar_id":"","url":"https://api.github.com/users/mourednik","html_url":"https://github.com/mourednik","followers_url":"https://api.github.com/users/mourednik/followers","following_url":"https://api.github.com/users/mourednik/following{/other_user}","gists_url":"https://api.github.com/users/mourednik/gists{/gist_id}","starred_url":"https://api.github.com/users/mourednik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mourednik/subscriptions","organizations_url":"https://api.github.com/users/mourednik/orgs","repos_url":"https://api.github.com/users/mourednik/repos","events_url":"https://api.github.com/users/mourednik/events{/privacy}","received_events_url":"https://api.github.com/users/mourednik/received_events","type":"User","site_admin":false},"body":"this case can be deleted (since it doesn't watch any actors)","created_at":"2015-12-11T02:06:32Z","updated_at":"2015-12-11T02:06:32Z","html_url":"https://github.com/springnz/sparkplug/pull/13#discussion_r47314623","pull_request_url":"https://api.github.com/repos/springnz/sparkplug/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/springnz/sparkplug/pulls/comments/47314623"},"html":{"href":"https://github.com/springnz/sparkplug/pull/13#discussion_r47314623"},"pull_request":{"href":"https://api.github.com/repos/springnz/sparkplug/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/springnz/sparkplug/pulls/13","id":53339243,"html_url":"https://github.com/springnz/sparkplug/pull/13","diff_url":"https://github.com/springnz/sparkplug/pull/13.diff","patch_url":"https://github.com/springnz/sparkplug/pull/13.patch","issue_url":"https://api.github.com/repos/springnz/sparkplug/issues/13","number":13,"state":"open","locked":false,"title":"Lifecycle monitoring","user":{"login":"szoio","id":8020266,"avatar_url":"https://avatars.githubusercontent.com/u/8020266?v=3","gravatar_id":"","url":"https://api.github.com/users/szoio","html_url":"https://github.com/szoio","followers_url":"https://api.github.com/users/szoio/followers","following_url":"https://api.github.com/users/szoio/following{/other_user}","gists_url":"https://api.github.com/users/szoio/gists{/gist_id}","starred_url":"https://api.github.com/users/szoio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szoio/subscriptions","organizations_url":"https://api.github.com/users/szoio/orgs","repos_url":"https://api.github.com/users/szoio/repos","events_url":"https://api.github.com/users/szoio/events{/privacy}","received_events_url":"https://api.github.com/users/szoio/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-11T00:40:34Z","updated_at":"2015-12-11T02:06:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d114cd5179ae78bf53cbeac17a138b61293593d","assignee":{"login":"mourednik","id":3468062,"avatar_url":"https://avatars.githubusercontent.com/u/3468062?v=3","gravatar_id":"","url":"https://api.github.com/users/mourednik","html_url":"https://github.com/mourednik","followers_url":"https://api.github.com/users/mourednik/followers","following_url":"https://api.github.com/users/mourednik/following{/other_user}","gists_url":"https://api.github.com/users/mourednik/gists{/gist_id}","starred_url":"https://api.github.com/users/mourednik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mourednik/subscriptions","organizations_url":"https://api.github.com/users/mourednik/orgs","repos_url":"https://api.github.com/users/mourednik/repos","events_url":"https://api.github.com/users/mourednik/events{/privacy}","received_events_url":"https://api.github.com/users/mourednik/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/springnz/sparkplug/pulls/13/commits","review_comments_url":"https://api.github.com/repos/springnz/sparkplug/pulls/13/comments","review_comment_url":"https://api.github.com/repos/springnz/sparkplug/pulls/comments{/number}","comments_url":"https://api.github.com/repos/springnz/sparkplug/issues/13/comments","statuses_url":"https://api.github.com/repos/springnz/sparkplug/statuses/5e2079ee5fcdc9418fe1662bcf8a526d7f15705c","head":{"label":"springnz:lifecycle-monitoring","ref":"lifecycle-monitoring","sha":"5e2079ee5fcdc9418fe1662bcf8a526d7f15705c","user":{"login":"springnz","id":15024031,"avatar_url":"https://avatars.githubusercontent.com/u/15024031?v=3","gravatar_id":"","url":"https://api.github.com/users/springnz","html_url":"https://github.com/springnz","followers_url":"https://api.github.com/users/springnz/followers","following_url":"https://api.github.com/users/springnz/following{/other_user}","gists_url":"https://api.github.com/users/springnz/gists{/gist_id}","starred_url":"https://api.github.com/users/springnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springnz/subscriptions","organizations_url":"https://api.github.com/users/springnz/orgs","repos_url":"https://api.github.com/users/springnz/repos","events_url":"https://api.github.com/users/springnz/events{/privacy}","received_events_url":"https://api.github.com/users/springnz/received_events","type":"Organization","site_admin":false},"repo":{"id":44727660,"name":"sparkplug","full_name":"springnz/sparkplug","owner":{"login":"springnz","id":15024031,"avatar_url":"https://avatars.githubusercontent.com/u/15024031?v=3","gravatar_id":"","url":"https://api.github.com/users/springnz","html_url":"https://github.com/springnz","followers_url":"https://api.github.com/users/springnz/followers","following_url":"https://api.github.com/users/springnz/following{/other_user}","gists_url":"https://api.github.com/users/springnz/gists{/gist_id}","starred_url":"https://api.github.com/users/springnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springnz/subscriptions","organizations_url":"https://api.github.com/users/springnz/orgs","repos_url":"https://api.github.com/users/springnz/repos","events_url":"https://api.github.com/users/springnz/events{/privacy}","received_events_url":"https://api.github.com/users/springnz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/springnz/sparkplug","description":"A framework for creating composable and pluggable data processing pipelines using Apache Spark, and running them on a cluster.","fork":false,"url":"https://api.github.com/repos/springnz/sparkplug","forks_url":"https://api.github.com/repos/springnz/sparkplug/forks","keys_url":"https://api.github.com/repos/springnz/sparkplug/keys{/key_id}","collaborators_url":"https://api.github.com/repos/springnz/sparkplug/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/springnz/sparkplug/teams","hooks_url":"https://api.github.com/repos/springnz/sparkplug/hooks","issue_events_url":"https://api.github.com/repos/springnz/sparkplug/issues/events{/number}","events_url":"https://api.github.com/repos/springnz/sparkplug/events","assignees_url":"https://api.github.com/repos/springnz/sparkplug/assignees{/user}","branches_url":"https://api.github.com/repos/springnz/sparkplug/branches{/branch}","tags_url":"https://api.github.com/repos/springnz/sparkplug/tags","blobs_url":"https://api.github.com/repos/springnz/sparkplug/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/springnz/sparkplug/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/springnz/sparkplug/git/refs{/sha}","trees_url":"https://api.github.com/repos/springnz/sparkplug/git/trees{/sha}","statuses_url":"https://api.github.com/repos/springnz/sparkplug/statuses/{sha}","languages_url":"https://api.github.com/repos/springnz/sparkplug/languages","stargazers_url":"https://api.github.com/repos/springnz/sparkplug/stargazers","contributors_url":"https://api.github.com/repos/springnz/sparkplug/contributors","subscribers_url":"https://api.github.com/repos/springnz/sparkplug/subscribers","subscription_url":"https://api.github.com/repos/springnz/sparkplug/subscription","commits_url":"https://api.github.com/repos/springnz/sparkplug/commits{/sha}","git_commits_url":"https://api.github.com/repos/springnz/sparkplug/git/commits{/sha}","comments_url":"https://api.github.com/repos/springnz/sparkplug/comments{/number}","issue_comment_url":"https://api.github.com/repos/springnz/sparkplug/issues/comments{/number}","contents_url":"https://api.github.com/repos/springnz/sparkplug/contents/{+path}","compare_url":"https://api.github.com/repos/springnz/sparkplug/compare/{base}...{head}","merges_url":"https://api.github.com/repos/springnz/sparkplug/merges","archive_url":"https://api.github.com/repos/springnz/sparkplug/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/springnz/sparkplug/downloads","issues_url":"https://api.github.com/repos/springnz/sparkplug/issues{/number}","pulls_url":"https://api.github.com/repos/springnz/sparkplug/pulls{/number}","milestones_url":"https://api.github.com/repos/springnz/sparkplug/milestones{/number}","notifications_url":"https://api.github.com/repos/springnz/sparkplug/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/springnz/sparkplug/labels{/name}","releases_url":"https://api.github.com/repos/springnz/sparkplug/releases{/id}","created_at":"2015-10-22T06:56:16Z","updated_at":"2015-12-10T07:10:59Z","pushed_at":"2015-12-11T00:40:36Z","git_url":"git://github.com/springnz/sparkplug.git","ssh_url":"git@github.com:springnz/sparkplug.git","clone_url":"https://github.com/springnz/sparkplug.git","svn_url":"https://github.com/springnz/sparkplug","homepage":"","size":7271,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"springnz:master","ref":"master","sha":"1a0a0466cd194d3f742874ec51b0de4f04d8c9ae","user":{"login":"springnz","id":15024031,"avatar_url":"https://avatars.githubusercontent.com/u/15024031?v=3","gravatar_id":"","url":"https://api.github.com/users/springnz","html_url":"https://github.com/springnz","followers_url":"https://api.github.com/users/springnz/followers","following_url":"https://api.github.com/users/springnz/following{/other_user}","gists_url":"https://api.github.com/users/springnz/gists{/gist_id}","starred_url":"https://api.github.com/users/springnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springnz/subscriptions","organizations_url":"https://api.github.com/users/springnz/orgs","repos_url":"https://api.github.com/users/springnz/repos","events_url":"https://api.github.com/users/springnz/events{/privacy}","received_events_url":"https://api.github.com/users/springnz/received_events","type":"Organization","site_admin":false},"repo":{"id":44727660,"name":"sparkplug","full_name":"springnz/sparkplug","owner":{"login":"springnz","id":15024031,"avatar_url":"https://avatars.githubusercontent.com/u/15024031?v=3","gravatar_id":"","url":"https://api.github.com/users/springnz","html_url":"https://github.com/springnz","followers_url":"https://api.github.com/users/springnz/followers","following_url":"https://api.github.com/users/springnz/following{/other_user}","gists_url":"https://api.github.com/users/springnz/gists{/gist_id}","starred_url":"https://api.github.com/users/springnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springnz/subscriptions","organizations_url":"https://api.github.com/users/springnz/orgs","repos_url":"https://api.github.com/users/springnz/repos","events_url":"https://api.github.com/users/springnz/events{/privacy}","received_events_url":"https://api.github.com/users/springnz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/springnz/sparkplug","description":"A framework for creating composable and pluggable data processing pipelines using Apache Spark, and running them on a cluster.","fork":false,"url":"https://api.github.com/repos/springnz/sparkplug","forks_url":"https://api.github.com/repos/springnz/sparkplug/forks","keys_url":"https://api.github.com/repos/springnz/sparkplug/keys{/key_id}","collaborators_url":"https://api.github.com/repos/springnz/sparkplug/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/springnz/sparkplug/teams","hooks_url":"https://api.github.com/repos/springnz/sparkplug/hooks","issue_events_url":"https://api.github.com/repos/springnz/sparkplug/issues/events{/number}","events_url":"https://api.github.com/repos/springnz/sparkplug/events","assignees_url":"https://api.github.com/repos/springnz/sparkplug/assignees{/user}","branches_url":"https://api.github.com/repos/springnz/sparkplug/branches{/branch}","tags_url":"https://api.github.com/repos/springnz/sparkplug/tags","blobs_url":"https://api.github.com/repos/springnz/sparkplug/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/springnz/sparkplug/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/springnz/sparkplug/git/refs{/sha}","trees_url":"https://api.github.com/repos/springnz/sparkplug/git/trees{/sha}","statuses_url":"https://api.github.com/repos/springnz/sparkplug/statuses/{sha}","languages_url":"https://api.github.com/repos/springnz/sparkplug/languages","stargazers_url":"https://api.github.com/repos/springnz/sparkplug/stargazers","contributors_url":"https://api.github.com/repos/springnz/sparkplug/contributors","subscribers_url":"https://api.github.com/repos/springnz/sparkplug/subscribers","subscription_url":"https://api.github.com/repos/springnz/sparkplug/subscription","commits_url":"https://api.github.com/repos/springnz/sparkplug/commits{/sha}","git_commits_url":"https://api.github.com/repos/springnz/sparkplug/git/commits{/sha}","comments_url":"https://api.github.com/repos/springnz/sparkplug/comments{/number}","issue_comment_url":"https://api.github.com/repos/springnz/sparkplug/issues/comments{/number}","contents_url":"https://api.github.com/repos/springnz/sparkplug/contents/{+path}","compare_url":"https://api.github.com/repos/springnz/sparkplug/compare/{base}...{head}","merges_url":"https://api.github.com/repos/springnz/sparkplug/merges","archive_url":"https://api.github.com/repos/springnz/sparkplug/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/springnz/sparkplug/downloads","issues_url":"https://api.github.com/repos/springnz/sparkplug/issues{/number}","pulls_url":"https://api.github.com/repos/springnz/sparkplug/pulls{/number}","milestones_url":"https://api.github.com/repos/springnz/sparkplug/milestones{/number}","notifications_url":"https://api.github.com/repos/springnz/sparkplug/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/springnz/sparkplug/labels{/name}","releases_url":"https://api.github.com/repos/springnz/sparkplug/releases{/id}","created_at":"2015-10-22T06:56:16Z","updated_at":"2015-12-10T07:10:59Z","pushed_at":"2015-12-11T00:40:36Z","git_url":"git://github.com/springnz/sparkplug.git","ssh_url":"git@github.com:springnz/sparkplug.git","clone_url":"https://github.com/springnz/sparkplug.git","svn_url":"https://github.com/springnz/sparkplug","homepage":"","size":7271,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/springnz/sparkplug/pulls/13"},"html":{"href":"https://github.com/springnz/sparkplug/pull/13"},"issue":{"href":"https://api.github.com/repos/springnz/sparkplug/issues/13"},"comments":{"href":"https://api.github.com/repos/springnz/sparkplug/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/springnz/sparkplug/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/springnz/sparkplug/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/springnz/sparkplug/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/springnz/sparkplug/statuses/5e2079ee5fcdc9418fe1662bcf8a526d7f15705c"}}}}