{"action":"created","issue":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/4630","labels_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/4630/labels{/name}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/4630/comments","events_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/4630/events","html_url":"https://github.com/rapid7/metasploit-framework/pull/4630","id":55265985,"number":4630,"title":"Rewind error handling to normal","user":{"login":"wchen-r7","id":1170914,"avatar_url":"https://avatars.githubusercontent.com/u/1170914?v=3","gravatar_id":"","url":"https://api.github.com/users/wchen-r7","html_url":"https://github.com/wchen-r7","followers_url":"https://api.github.com/users/wchen-r7/followers","following_url":"https://api.github.com/users/wchen-r7/following{/other_user}","gists_url":"https://api.github.com/users/wchen-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/wchen-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchen-r7/subscriptions","organizations_url":"https://api.github.com/users/wchen-r7/orgs","repos_url":"https://api.github.com/users/wchen-r7/repos","events_url":"https://api.github.com/users/wchen-r7/events{/privacy}","received_events_url":"https://api.github.com/users/wchen-r7/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/feature","name":"feature","color":"bfe5bf"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-23T10:22:31Z","updated_at":"2015-01-24T22:35:19Z","closed_at":"2015-01-24T08:52:51Z","pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/4630","html_url":"https://github.com/rapid7/metasploit-framework/pull/4630","diff_url":"https://github.com/rapid7/metasploit-framework/pull/4630.diff","patch_url":"https://github.com/rapid7/metasploit-framework/pull/4630.patch"},"body":"This should rewind everything this pull request did: https://github.com/rapid7/metasploit-framework/pull/4473\r\n\r\nThe reason we want to rewind this is because the errors are way too verbose, and we're frequently getting complaints about it. You see a backtrace even though there is no bug.\r\n\r\nAs a developer, it's really not a super huge deal if you don't see the backtrace on the console. I mean it's pretty nice to see it so we don't have to go through a bunch of steps (setg LogLevel and then watch framework.log), but without this we should be able to figure out how to fix something anyway.\r\n\r\nWe are NOT trying to reject the idea of #4473, but clearly we need to figure out how to implement this better.\r\n\r\nA ticket is being discussed in #4552, but it looks like we're losing traction and we really need the arch team to elaborate on this since it's kind of an arch question. Before that happens and us coming up with an agreeable fix that's ready to merge (which is unlikely to happen anytime soon), we need to go back to the old way first.\r\n\r\nThis ticket is related to #4552, but does not fix it.\r\n\r\n## Verification\r\n\r\nYou should compare the code changes in #4473 vs this one. Whatever code was added in #4473 should be gone. And if you play around msfconsole, you should not see errors as verbose as before (such as #4572), but when you hit a real bug or whatever (create one for testing purposes if you want to), when you setg LogLevel 3, you should still see the backtrace in framework.log.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/comments/71341030","html_url":"https://github.com/rapid7/metasploit-framework/pull/4630#issuecomment-71341030","issue_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/4630","id":71341030,"user":{"login":"todb-r7","id":1170909,"avatar_url":"https://avatars.githubusercontent.com/u/1170909?v=3","gravatar_id":"","url":"https://api.github.com/users/todb-r7","html_url":"https://github.com/todb-r7","followers_url":"https://api.github.com/users/todb-r7/followers","following_url":"https://api.github.com/users/todb-r7/following{/other_user}","gists_url":"https://api.github.com/users/todb-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/todb-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/todb-r7/subscriptions","organizations_url":"https://api.github.com/users/todb-r7/orgs","repos_url":"https://api.github.com/users/todb-r7/repos","events_url":"https://api.github.com/users/todb-r7/events{/privacy}","received_events_url":"https://api.github.com/users/todb-r7/received_events","type":"User","site_admin":false},"created_at":"2015-01-24T22:35:19Z","updated_at":"2015-01-24T22:35:19Z","body":"Ah, i must have picked the wrong commit hash on my eyeballing. That said if you recreate and push the same branch name, you shouldn't have to open a new PR. Doesn't really matter of course, it's not like we're running out of PR numbers, just feels like unnecessary steps."}}