{"action":"created","issue":{"url":"https://api.github.com/repos/grpc/grpc-java/issues/337","labels_url":"https://api.github.com/repos/grpc/grpc-java/issues/337/labels{/name}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/337/comments","events_url":"https://api.github.com/repos/grpc/grpc-java/issues/337/events","html_url":"https://github.com/grpc/grpc-java/pull/337","id":70804151,"number":337,"title":"Fix memeory leak in MessageFramer","user":{"login":"louiscryan","id":9046588,"avatar_url":"https://avatars.githubusercontent.com/u/9046588?v=3","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":22,"created_at":"2015-04-24T21:53:51Z","updated_at":"2015-04-25T00:19:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/337","html_url":"https://github.com/grpc/grpc-java/pull/337","diff_url":"https://github.com/grpc/grpc-java/pull/337.diff","patch_url":"https://github.com/grpc/grpc-java/pull/337.patch"},"body":"Fixes\r\n\r\nhttps://github.com/grpc/grpc-java/issues/336"},"comment":{"url":"https://api.github.com/repos/grpc/grpc-java/issues/comments/96107774","html_url":"https://github.com/grpc/grpc-java/pull/337#issuecomment-96107774","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/337","id":96107774,"user":{"login":"louiscryan","id":9046588,"avatar_url":"https://avatars.githubusercontent.com/u/9046588?v=3","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},"created_at":"2015-04-25T00:19:58Z","updated_at":"2015-04-25T00:19:58Z","body":"That's true but at least with empty the semantics are clearer and the enforcement stricter.\r\n\r\nI'd still need the specialized subclass for OkHttp to enable a singleton as there are currently no capacity constraints on those buffers.\r\n\r\nI'd be happy to get rid of empty() when the funky dependency causing trailers to be triggered the way they are today for the server is fixed. Suggestions in that direction welcome"}}