{"action":"closed","number":1166,"pull_request":{"url":"https://api.github.com/repos/opal/opal/pulls/1166","id":48624747,"html_url":"https://github.com/opal/opal/pull/1166","diff_url":"https://github.com/opal/opal/pull/1166.diff","patch_url":"https://github.com/opal/opal/pull/1166.patch","issue_url":"https://api.github.com/repos/opal/opal/issues/1166","number":1166,"state":"closed","locked":false,"title":"String#gsub optimization","user":{"login":"wied03","id":297123,"avatar_url":"https://avatars.githubusercontent.com/u/297123?v=3","gravatar_id":"","url":"https://api.github.com/users/wied03","html_url":"https://github.com/wied03","followers_url":"https://api.github.com/users/wied03/followers","following_url":"https://api.github.com/users/wied03/following{/other_user}","gists_url":"https://api.github.com/users/wied03/gists{/gist_id}","starred_url":"https://api.github.com/users/wied03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wied03/subscriptions","organizations_url":"https://api.github.com/users/wied03/orgs","repos_url":"https://api.github.com/users/wied03/repos","events_url":"https://api.github.com/users/wied03/events{/privacy}","received_events_url":"https://api.github.com/users/wied03/received_events","type":"User","site_admin":false},"body":"Convert Ruby return to JS return and avoid the returner logic which adds a try {} catch around the entire method","created_at":"2015-10-23T20:13:24Z","updated_at":"2015-10-23T20:38:54Z","closed_at":"2015-10-23T20:38:54Z","merged_at":"2015-10-23T20:38:54Z","merge_commit_sha":"d4987ee226ee168db94e030bb2041c96f6b349d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opal/opal/pulls/1166/commits","review_comments_url":"https://api.github.com/repos/opal/opal/pulls/1166/comments","review_comment_url":"https://api.github.com/repos/opal/opal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opal/opal/issues/1166/comments","statuses_url":"https://api.github.com/repos/opal/opal/statuses/a011a33896a7dde4814e46acea3b9d27525bd22d","head":{"label":"wied03:string_gsub_optimize","ref":"string_gsub_optimize","sha":"a011a33896a7dde4814e46acea3b9d27525bd22d","user":{"login":"wied03","id":297123,"avatar_url":"https://avatars.githubusercontent.com/u/297123?v=3","gravatar_id":"","url":"https://api.github.com/users/wied03","html_url":"https://github.com/wied03","followers_url":"https://api.github.com/users/wied03/followers","following_url":"https://api.github.com/users/wied03/following{/other_user}","gists_url":"https://api.github.com/users/wied03/gists{/gist_id}","starred_url":"https://api.github.com/users/wied03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wied03/subscriptions","organizations_url":"https://api.github.com/users/wied03/orgs","repos_url":"https://api.github.com/users/wied03/repos","events_url":"https://api.github.com/users/wied03/events{/privacy}","received_events_url":"https://api.github.com/users/wied03/received_events","type":"User","site_admin":false},"repo":{"id":36151283,"name":"opal","full_name":"wied03/opal","owner":{"login":"wied03","id":297123,"avatar_url":"https://avatars.githubusercontent.com/u/297123?v=3","gravatar_id":"","url":"https://api.github.com/users/wied03","html_url":"https://github.com/wied03","followers_url":"https://api.github.com/users/wied03/followers","following_url":"https://api.github.com/users/wied03/following{/other_user}","gists_url":"https://api.github.com/users/wied03/gists{/gist_id}","starred_url":"https://api.github.com/users/wied03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wied03/subscriptions","organizations_url":"https://api.github.com/users/wied03/orgs","repos_url":"https://api.github.com/users/wied03/repos","events_url":"https://api.github.com/users/wied03/events{/privacy}","received_events_url":"https://api.github.com/users/wied03/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wied03/opal","description":"Ruby to Javascript compiler","fork":true,"url":"https://api.github.com/repos/wied03/opal","forks_url":"https://api.github.com/repos/wied03/opal/forks","keys_url":"https://api.github.com/repos/wied03/opal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wied03/opal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wied03/opal/teams","hooks_url":"https://api.github.com/repos/wied03/opal/hooks","issue_events_url":"https://api.github.com/repos/wied03/opal/issues/events{/number}","events_url":"https://api.github.com/repos/wied03/opal/events","assignees_url":"https://api.github.com/repos/wied03/opal/assignees{/user}","branches_url":"https://api.github.com/repos/wied03/opal/branches{/branch}","tags_url":"https://api.github.com/repos/wied03/opal/tags","blobs_url":"https://api.github.com/repos/wied03/opal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wied03/opal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wied03/opal/git/refs{/sha}","trees_url":"https://api.github.com/repos/wied03/opal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wied03/opal/statuses/{sha}","languages_url":"https://api.github.com/repos/wied03/opal/languages","stargazers_url":"https://api.github.com/repos/wied03/opal/stargazers","contributors_url":"https://api.github.com/repos/wied03/opal/contributors","subscribers_url":"https://api.github.com/repos/wied03/opal/subscribers","subscription_url":"https://api.github.com/repos/wied03/opal/subscription","commits_url":"https://api.github.com/repos/wied03/opal/commits{/sha}","git_commits_url":"https://api.github.com/repos/wied03/opal/git/commits{/sha}","comments_url":"https://api.github.com/repos/wied03/opal/comments{/number}","issue_comment_url":"https://api.github.com/repos/wied03/opal/issues/comments{/number}","contents_url":"https://api.github.com/repos/wied03/opal/contents/{+path}","compare_url":"https://api.github.com/repos/wied03/opal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wied03/opal/merges","archive_url":"https://api.github.com/repos/wied03/opal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wied03/opal/downloads","issues_url":"https://api.github.com/repos/wied03/opal/issues{/number}","pulls_url":"https://api.github.com/repos/wied03/opal/pulls{/number}","milestones_url":"https://api.github.com/repos/wied03/opal/milestones{/number}","notifications_url":"https://api.github.com/repos/wied03/opal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wied03/opal/labels{/name}","releases_url":"https://api.github.com/repos/wied03/opal/releases{/id}","created_at":"2015-05-24T01:57:35Z","updated_at":"2015-05-24T01:57:37Z","pushed_at":"2015-10-23T20:13:05Z","git_url":"git://github.com/wied03/opal.git","ssh_url":"git@github.com:wied03/opal.git","clone_url":"https://github.com/wied03/opal.git","svn_url":"https://github.com/wied03/opal","homepage":"http://opalrb.org","size":10630,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opal:master","ref":"master","sha":"23ce1c981833042ddb5aa325c7d82716268b2297","user":{"login":"opal","id":842643,"avatar_url":"https://avatars.githubusercontent.com/u/842643?v=3","gravatar_id":"","url":"https://api.github.com/users/opal","html_url":"https://github.com/opal","followers_url":"https://api.github.com/users/opal/followers","following_url":"https://api.github.com/users/opal/following{/other_user}","gists_url":"https://api.github.com/users/opal/gists{/gist_id}","starred_url":"https://api.github.com/users/opal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opal/subscriptions","organizations_url":"https://api.github.com/users/opal/orgs","repos_url":"https://api.github.com/users/opal/repos","events_url":"https://api.github.com/users/opal/events{/privacy}","received_events_url":"https://api.github.com/users/opal/received_events","type":"Organization","site_admin":false},"repo":{"id":184366,"name":"opal","full_name":"opal/opal","owner":{"login":"opal","id":842643,"avatar_url":"https://avatars.githubusercontent.com/u/842643?v=3","gravatar_id":"","url":"https://api.github.com/users/opal","html_url":"https://github.com/opal","followers_url":"https://api.github.com/users/opal/followers","following_url":"https://api.github.com/users/opal/following{/other_user}","gists_url":"https://api.github.com/users/opal/gists{/gist_id}","starred_url":"https://api.github.com/users/opal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opal/subscriptions","organizations_url":"https://api.github.com/users/opal/orgs","repos_url":"https://api.github.com/users/opal/repos","events_url":"https://api.github.com/users/opal/events{/privacy}","received_events_url":"https://api.github.com/users/opal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opal/opal","description":"Ruby to JavaScript compiler","fork":false,"url":"https://api.github.com/repos/opal/opal","forks_url":"https://api.github.com/repos/opal/opal/forks","keys_url":"https://api.github.com/repos/opal/opal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opal/opal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opal/opal/teams","hooks_url":"https://api.github.com/repos/opal/opal/hooks","issue_events_url":"https://api.github.com/repos/opal/opal/issues/events{/number}","events_url":"https://api.github.com/repos/opal/opal/events","assignees_url":"https://api.github.com/repos/opal/opal/assignees{/user}","branches_url":"https://api.github.com/repos/opal/opal/branches{/branch}","tags_url":"https://api.github.com/repos/opal/opal/tags","blobs_url":"https://api.github.com/repos/opal/opal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opal/opal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opal/opal/git/refs{/sha}","trees_url":"https://api.github.com/repos/opal/opal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opal/opal/statuses/{sha}","languages_url":"https://api.github.com/repos/opal/opal/languages","stargazers_url":"https://api.github.com/repos/opal/opal/stargazers","contributors_url":"https://api.github.com/repos/opal/opal/contributors","subscribers_url":"https://api.github.com/repos/opal/opal/subscribers","subscription_url":"https://api.github.com/repos/opal/opal/subscription","commits_url":"https://api.github.com/repos/opal/opal/commits{/sha}","git_commits_url":"https://api.github.com/repos/opal/opal/git/commits{/sha}","comments_url":"https://api.github.com/repos/opal/opal/comments{/number}","issue_comment_url":"https://api.github.com/repos/opal/opal/issues/comments{/number}","contents_url":"https://api.github.com/repos/opal/opal/contents/{+path}","compare_url":"https://api.github.com/repos/opal/opal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opal/opal/merges","archive_url":"https://api.github.com/repos/opal/opal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opal/opal/downloads","issues_url":"https://api.github.com/repos/opal/opal/issues{/number}","pulls_url":"https://api.github.com/repos/opal/opal/pulls{/number}","milestones_url":"https://api.github.com/repos/opal/opal/milestones{/number}","notifications_url":"https://api.github.com/repos/opal/opal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opal/opal/labels{/name}","releases_url":"https://api.github.com/repos/opal/opal/releases{/id}","created_at":"2009-04-24T08:53:34Z","updated_at":"2015-10-23T06:17:23Z","pushed_at":"2015-10-23T20:38:54Z","git_url":"git://github.com/opal/opal.git","ssh_url":"git@github.com:opal/opal.git","clone_url":"https://github.com/opal/opal.git","svn_url":"https://github.com/opal/opal","homepage":"http://opalrb.org","size":22305,"stargazers_count":2923,"watchers_count":2923,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":206,"mirror_url":null,"open_issues_count":134,"forks":206,"open_issues":134,"watchers":2923,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opal/opal/pulls/1166"},"html":{"href":"https://github.com/opal/opal/pull/1166"},"issue":{"href":"https://api.github.com/repos/opal/opal/issues/1166"},"comments":{"href":"https://api.github.com/repos/opal/opal/issues/1166/comments"},"review_comments":{"href":"https://api.github.com/repos/opal/opal/pulls/1166/comments"},"review_comment":{"href":"https://api.github.com/repos/opal/opal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opal/opal/pulls/1166/commits"},"statuses":{"href":"https://api.github.com/repos/opal/opal/statuses/a011a33896a7dde4814e46acea3b9d27525bd22d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"meh","id":40204,"avatar_url":"https://avatars.githubusercontent.com/u/40204?v=3","gravatar_id":"","url":"https://api.github.com/users/meh","html_url":"https://github.com/meh","followers_url":"https://api.github.com/users/meh/followers","following_url":"https://api.github.com/users/meh/following{/other_user}","gists_url":"https://api.github.com/users/meh/gists{/gist_id}","starred_url":"https://api.github.com/users/meh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meh/subscriptions","organizations_url":"https://api.github.com/users/meh/orgs","repos_url":"https://api.github.com/users/meh/repos","events_url":"https://api.github.com/users/meh/events{/privacy}","received_events_url":"https://api.github.com/users/meh/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}