{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/8046","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8046/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8046/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8046/events","html_url":"https://github.com/cms-sw/cmssw/pull/8046","id":59693644,"number":8046,"title":"Small fix to PR #7823 (Adding the retina fitter)","user":{"login":"mark-grimes","id":6480160,"avatar_url":"https://avatars.githubusercontent.com/u/6480160?v=3","gravatar_id":"","url":"https://api.github.com/users/mark-grimes","html_url":"https://github.com/mark-grimes","followers_url":"https://api.github.com/users/mark-grimes/followers","following_url":"https://api.github.com/users/mark-grimes/following{/other_user}","gists_url":"https://api.github.com/users/mark-grimes/gists{/gist_id}","starred_url":"https://api.github.com/users/mark-grimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mark-grimes/subscriptions","organizations_url":"https://api.github.com/users/mark-grimes/orgs","repos_url":"https://api.github.com/users/mark-grimes/repos","events_url":"https://api.github.com/users/mark-grimes/events{/privacy}","received_events_url":"https://api.github.com/users/mark-grimes/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fef2c0"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/l1-pending","name":"l1-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/9","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_6_2_X_SLHC","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/9/labels","id":398204,"number":9,"title":"Next CMSSW_6_2_X_SLHC","description":"","creator":{"login":"ktf","id":10544,"avatar_url":"https://avatars.githubusercontent.com/u/10544?v=3","gravatar_id":"","url":"https://api.github.com/users/ktf","html_url":"https://github.com/ktf","followers_url":"https://api.github.com/users/ktf/followers","following_url":"https://api.github.com/users/ktf/following{/other_user}","gists_url":"https://api.github.com/users/ktf/gists{/gist_id}","starred_url":"https://api.github.com/users/ktf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktf/subscriptions","organizations_url":"https://api.github.com/users/ktf/orgs","repos_url":"https://api.github.com/users/ktf/repos","events_url":"https://api.github.com/users/ktf/events{/privacy}","received_events_url":"https://api.github.com/users/ktf/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":721,"state":"open","created_at":"2013-08-09T09:55:23Z","updated_at":"2015-03-03T19:42:00Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-03-03T19:39:09Z","updated_at":"2015-03-03T19:42:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8046","html_url":"https://github.com/cms-sw/cmssw/pull/8046","diff_url":"https://github.com/cms-sw/cmssw/pull/8046.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/8046.patch"},"body":"This fixes a potential memory leak in #7823 if the `RetinaTrackFitter::fit` function returns early.  There's a comment on #7823 explaining where this can happen.  I have no idea how likely the condition is to be met, but safer not to introduce any potential for a memory leak.\r\n\r\nChanging the `hits` vector to an `edm::OwnVector` would have been a more \"CMSSW friendly\" solution, but that would have required changing the class interface since the vector is passed around.\r\n\r\n@sviret, let me know if you're happy with this solution. You should be able to see just my changes at https://github.com/cms-sw/cmssw/commit/7463d3051813ad19d742ccd04f77c7c4c2e5c0e3.\r\n\r\n(EDIT - that link for the commit with my changes isn't working for some reason. No idea why.)"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/77018826","html_url":"https://github.com/cms-sw/cmssw/pull/8046#issuecomment-77018826","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8046","id":77018826,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2015-03-03T19:42:07Z","updated_at":"2015-03-03T19:42:07Z","body":"A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.\n\nSmall fix to PR #7823 (Adding the retina fitter)\n\nIt involves the following packages:\n\nL1Trigger/TrackFindingAM\n\n\n@cmsbuild, @nclopezo, @mulhearn can you please review it and eventually sign? Thanks.\n@Martin-Grunewald this is something you requested to watch as well.\nYou can sign-off by replying to this message having '+1' in the first line of your reply.\nYou can reject by replying  to this message having '-1' in the first line of your reply.\nIf you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.\n@fratnikov, @mark-grimes you are the release manager for this.\nYou can merge this pull request by typing 'merge' in the first line of your comment."}}