{"action":"created","issue":{"url":"https://api.github.com/repos/tlycken/Interpolations.jl/issues/90","labels_url":"https://api.github.com/repos/tlycken/Interpolations.jl/issues/90/labels{/name}","comments_url":"https://api.github.com/repos/tlycken/Interpolations.jl/issues/90/comments","events_url":"https://api.github.com/repos/tlycken/Interpolations.jl/issues/90/events","html_url":"https://github.com/tlycken/Interpolations.jl/pull/90","id":116839945,"number":90,"title":"WIP on cubic","user":{"login":"spencerlyon2","id":1001948,"avatar_url":"https://avatars.githubusercontent.com/u/1001948?v=3","gravatar_id":"","url":"https://api.github.com/users/spencerlyon2","html_url":"https://github.com/spencerlyon2","followers_url":"https://api.github.com/users/spencerlyon2/followers","following_url":"https://api.github.com/users/spencerlyon2/following{/other_user}","gists_url":"https://api.github.com/users/spencerlyon2/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerlyon2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerlyon2/subscriptions","organizations_url":"https://api.github.com/users/spencerlyon2/orgs","repos_url":"https://api.github.com/users/spencerlyon2/repos","events_url":"https://api.github.com/users/spencerlyon2/events{/privacy}","received_events_url":"https://api.github.com/users/spencerlyon2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-11-13T19:51:50Z","updated_at":"2015-12-11T02:56:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tlycken/Interpolations.jl/pulls/90","html_url":"https://github.com/tlycken/Interpolations.jl/pull/90","diff_url":"https://github.com/tlycken/Interpolations.jl/pull/90.diff","patch_url":"https://github.com/tlycken/Interpolations.jl/pull/90.patch"},"body":"This is an early version of enabling cubic splines for the uniform case (non-gridded).\r\n\r\nFeatures that need to be implemented:\r\n\r\n- [x] Other boundary conditions\r\n- [x] OnGrid vs OnCell distinction\r\n- [ ] Gradient\r\n\r\nOther things that need to be done\r\n\r\n- [x] tests\r\n- [x] Fix bug in pre-filtering -- right now `BSpline(Cubic(Line()))` is not interpolating. \r\n- [x] docs\r\n- [ ] Add cubic to  benchmarks\r\n- [x] Did I mention tests?"},"comment":{"url":"https://api.github.com/repos/tlycken/Interpolations.jl/issues/comments/163821603","html_url":"https://github.com/tlycken/Interpolations.jl/pull/90#issuecomment-163821603","issue_url":"https://api.github.com/repos/tlycken/Interpolations.jl/issues/90","id":163821603,"user":{"login":"spencerlyon2","id":1001948,"avatar_url":"https://avatars.githubusercontent.com/u/1001948?v=3","gravatar_id":"","url":"https://api.github.com/users/spencerlyon2","html_url":"https://github.com/spencerlyon2","followers_url":"https://api.github.com/users/spencerlyon2/followers","following_url":"https://api.github.com/users/spencerlyon2/following{/other_user}","gists_url":"https://api.github.com/users/spencerlyon2/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerlyon2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerlyon2/subscriptions","organizations_url":"https://api.github.com/users/spencerlyon2/orgs","repos_url":"https://api.github.com/users/spencerlyon2/repos","events_url":"https://api.github.com/users/spencerlyon2/events{/privacy}","received_events_url":"https://api.github.com/users/spencerlyon2/received_events","type":"User","site_admin":false},"created_at":"2015-12-11T02:56:37Z","updated_at":"2015-12-11T02:56:37Z","body":"Hi @lstagner this does not implement monotnoic cubic splines, sorry. I'd love to see them too.\r\n\r\n@timholy and @tlycken I _think_ I have resolved most of the comments from above. Some things that still need cleaning up:\r\n\r\n- [ ] `InPlace` and `InPlaceQ`. I haven't even tried to touch them.\r\n- [ ] Could one of you take a look at how I handle padding? Tim made a comment above and I didn't change the code at all after that. \r\n- [ ] I've moved the `_build_woodbury_specs` to the bottom of this file. @timholy would you be open to a PR over at WoodburyMatrices?\r\n- [ ] As suggested by @timholy, more stringent tests of the boundary conditions would be great; although this applies to both Quadratic and Cubic and could perhaps be addressed in another PR? Happy to follow your lead on this one\r\n\r\nPlease let me know what else needs to be done to get this merged. I would suggest that I squash some of the commits before then, so please let me know before pressing that big green button ;) "}}