{"action":"created","issue":{"url":"https://api.github.com/repos/sporkmonger/addressable/issues/174","labels_url":"https://api.github.com/repos/sporkmonger/addressable/issues/174/labels{/name}","comments_url":"https://api.github.com/repos/sporkmonger/addressable/issues/174/comments","events_url":"https://api.github.com/repos/sporkmonger/addressable/issues/174/events","html_url":"https://github.com/sporkmonger/addressable/pull/174","id":47129819,"number":174,"title":"Memoize Adressable::URI instance variables","user":{"login":"sferik","id":10308,"avatar_url":"https://avatars.githubusercontent.com/u/10308?v=3","gravatar_id":"","url":"https://api.github.com/users/sferik","html_url":"https://github.com/sferik","followers_url":"https://api.github.com/users/sferik/followers","following_url":"https://api.github.com/users/sferik/following{/other_user}","gists_url":"https://api.github.com/users/sferik/gists{/gist_id}","starred_url":"https://api.github.com/users/sferik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sferik/subscriptions","organizations_url":"https://api.github.com/users/sferik/orgs","repos_url":"https://api.github.com/users/sferik/repos","events_url":"https://api.github.com/users/sferik/events{/privacy}","received_events_url":"https://api.github.com/users/sferik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":66,"created_at":"2014-10-29T10:08:22Z","updated_at":"2015-03-30T00:01:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sporkmonger/addressable/pulls/174","html_url":"https://github.com/sporkmonger/addressable/pull/174","diff_url":"https://github.com/sporkmonger/addressable/pull/174.diff","patch_url":"https://github.com/sporkmonger/addressable/pull/174.patch"},"body":"In the case where a fragment is present but empty (e.g. \"http://example.com#\"), the `normalized_fragment` method returns `nil`, so it can't be memoized with `||=`. This [patch](https://github.com/sferik/addressable/commit/67e36a4c7f406b874281037b3454d2cfd19ddc44) fixes this problem, so the `@normalized_fragment` instance variable is only ever assigned once, even when the method returns `nil`. This was causing an issue with frozen Addressable::URI (see https://github.com/sferik/t/issues/197).\r\n\r\nI hope you’ll find a moment to release this fix during your adventures in Tanzania.\r\n\r\nCheers! :beers:"},"comment":{"url":"https://api.github.com/repos/sporkmonger/addressable/issues/comments/87499598","html_url":"https://github.com/sporkmonger/addressable/pull/174#issuecomment-87499598","issue_url":"https://api.github.com/repos/sporkmonger/addressable/issues/174","id":87499598,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2015-03-30T00:01:25Z","updated_at":"2015-03-30T00:01:25Z","body":"\n[![Coverage Status](https://coveralls.io/builds/2219577/badge)](https://coveralls.io/builds/2219577)\n\nCoverage increased (+0.67%) to 96.38% when pulling **343e49765a794b3c2746e0b1c7324487ce625eca on sferik:memoize_normalized_fragment** into **b62c176a49f0243614fb0d7c095b2febb5dab05c on sporkmonger:master**.\n"}}