{"action":"created","issue":{"url":"https://api.github.com/repos/lantins/resque-lock-timeout/issues/24","labels_url":"https://api.github.com/repos/lantins/resque-lock-timeout/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/lantins/resque-lock-timeout/issues/24/comments","events_url":"https://api.github.com/repos/lantins/resque-lock-timeout/issues/24/events","html_url":"https://github.com/lantins/resque-lock-timeout/pull/24","id":45002035,"number":24,"title":"Make “loner” implementation comply with its specification","user":{"login":"amiryal","id":105565,"avatar_url":"https://avatars.githubusercontent.com/u/105565?v=3","gravatar_id":"","url":"https://api.github.com/users/amiryal","html_url":"https://github.com/amiryal","followers_url":"https://api.github.com/users/amiryal/followers","following_url":"https://api.github.com/users/amiryal/following{/other_user}","gists_url":"https://api.github.com/users/amiryal/gists{/gist_id}","starred_url":"https://api.github.com/users/amiryal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amiryal/subscriptions","organizations_url":"https://api.github.com/users/amiryal/orgs","repos_url":"https://api.github.com/users/amiryal/repos","events_url":"https://api.github.com/users/amiryal/events{/privacy}","received_events_url":"https://api.github.com/users/amiryal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2014-10-06T16:10:51Z","updated_at":"2015-01-25T16:55:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lantins/resque-lock-timeout/pulls/24","html_url":"https://github.com/lantins/resque-lock-timeout/pull/24","diff_url":"https://github.com/lantins/resque-lock-timeout/pull/24.diff","patch_url":"https://github.com/lantins/resque-lock-timeout/pull/24.patch"},"body":"The default `loner()` method is accepting `*args`, but they are not passed along where this method is called.\r\n\r\nNote, this pull request includes a test case, but it only covers one code path, whereas I fixed 3 different places."},"comment":{"url":"https://api.github.com/repos/lantins/resque-lock-timeout/issues/comments/71380911","html_url":"https://github.com/lantins/resque-lock-timeout/pull/24#issuecomment-71380911","issue_url":"https://api.github.com/repos/lantins/resque-lock-timeout/issues/24","id":71380911,"user":{"login":"amiryal","id":105565,"avatar_url":"https://avatars.githubusercontent.com/u/105565?v=3","gravatar_id":"","url":"https://api.github.com/users/amiryal","html_url":"https://github.com/amiryal","followers_url":"https://api.github.com/users/amiryal/followers","following_url":"https://api.github.com/users/amiryal/following{/other_user}","gists_url":"https://api.github.com/users/amiryal/gists{/gist_id}","starred_url":"https://api.github.com/users/amiryal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amiryal/subscriptions","organizations_url":"https://api.github.com/users/amiryal/orgs","repos_url":"https://api.github.com/users/amiryal/repos","events_url":"https://api.github.com/users/amiryal/events{/privacy}","received_events_url":"https://api.github.com/users/amiryal/received_events","type":"User","site_admin":false},"created_at":"2015-01-25T16:55:20Z","updated_at":"2015-01-25T16:55:20Z","body":"@lantins, it’s OK, it took me a little while to regain mental image, too.\r\n\r\nNotice how the method `LonelyWithArgsJob.loner()` is implemented, echoing back the argument given to it, defaulting to `false`. So, in the test, if the job is submitted with no arguments, it should not be treated as a loner, whereas submitting with an argument of `true` makes it a loner and rejects the second submission.\r\n\r\nBTW, if you run the new test on the code before this patch, the first assertion passes. It’s the other assertion that fails, because it depends on propagation of the `*args`, which the patch fixes.\r\n\r\nHope this helps."}}