{"action":"created","comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/43953248","id":43953248,"diff_hunk":"@@ -0,0 +1,166 @@\n+/*global define*/\n+define([\n+        '../Core/defaultValue',\n+        '../Core/defined',\n+        '../Core/DeveloperError',\n+        '../Core/getStringFromTypedArray',\n+        '../Core/loadArrayBuffer',\n+        './Cesium3DTileContentState',\n+        '../ThirdParty/when'\n+    ], function(\n+        defaultValue,\n+        defined,\n+        DeveloperError,\n+        getStringFromTypedArray,\n+        loadArrayBuffer,\n+        Cesium3DTileContentState,\n+        when) {\n+    \"use strict\";\n+\n+    /**\n+     * DOC_TBA\n+     */\n+    var Composite3DTileContentProvider = function(tileset, tile, url, factory) {\n+        this._url = url;\n+        this._tileset = tileset;\n+        this._tile = tile;\n+        this._contentProviders = [];","path":"Source/Scene/Composite3DTileContentProvider.js","position":29,"original_position":27,"commit_id":"cc15e6cc17504bea781babe235277da71268313c","original_commit_id":"44feffd89f403309796dc0d644197dd6a4da7b8e","user":{"login":"pjcozzi","id":782098,"avatar_url":"https://avatars.githubusercontent.com/u/782098?v=3","gravatar_id":"","url":"https://api.github.com/users/pjcozzi","html_url":"https://github.com/pjcozzi","followers_url":"https://api.github.com/users/pjcozzi/followers","following_url":"https://api.github.com/users/pjcozzi/following{/other_user}","gists_url":"https://api.github.com/users/pjcozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/pjcozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjcozzi/subscriptions","organizations_url":"https://api.github.com/users/pjcozzi/orgs","repos_url":"https://api.github.com/users/pjcozzi/repos","events_url":"https://api.github.com/users/pjcozzi/events{/privacy}","received_events_url":"https://api.github.com/users/pjcozzi/received_events","type":"User","site_admin":false},"body":"Just curious - did you test composites nested in composites?  That is test data we should have.","created_at":"2015-11-04T22:56:25Z","updated_at":"2015-11-04T22:56:25Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3158#discussion_r43953248","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3158","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/43953248"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3158#discussion_r43953248"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3158"}}},"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3158","id":49451639,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3158","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3158.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3158.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3158","number":3158,"state":"open","locked":false,"title":"Composite tiles","user":{"login":"lilleyse","id":915398,"avatar_url":"https://avatars.githubusercontent.com/u/915398?v=3","gravatar_id":"","url":"https://api.github.com/users/lilleyse","html_url":"https://github.com/lilleyse","followers_url":"https://api.github.com/users/lilleyse/followers","following_url":"https://api.github.com/users/lilleyse/following{/other_user}","gists_url":"https://api.github.com/users/lilleyse/gists{/gist_id}","starred_url":"https://api.github.com/users/lilleyse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilleyse/subscriptions","organizations_url":"https://api.github.com/users/lilleyse/orgs","repos_url":"https://api.github.com/users/lilleyse/repos","events_url":"https://api.github.com/users/lilleyse/events{/privacy}","received_events_url":"https://api.github.com/users/lilleyse/received_events","type":"User","site_admin":false},"body":"For https://github.com/AnalyticalGraphicsInc/3d-tiles/issues/23\r\n\r\nClient-side implementation of composite tiles. We should wait on merging this until the server-side code is ready, as this introduces breaking changes to the tile formats.\r\n\r\n* Added `byteLength` to all tile formats, added `batchSize` to `b3dm` tiles.\r\n* Point clouds now define their bounding sphere from the tile's oriented bounding box.\r\n* No longer using contentHeader.\r\n* Moved a lot of the `ContentProvider` loading code from `request` to `init`. Now `request` only loads the url and passes the data along to `init`. Composite tiles will call `init` when creating inner tiles.","created_at":"2015-11-02T16:19:57Z","updated_at":"2015-11-04T22:56:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28938b2e748b5eb99945d03aa11595b0857eeff5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3158/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3158/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3158/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/cc15e6cc17504bea781babe235277da71268313c","head":{"label":"lilleyse:composite-tiles","ref":"composite-tiles","sha":"cc15e6cc17504bea781babe235277da71268313c","user":{"login":"lilleyse","id":915398,"avatar_url":"https://avatars.githubusercontent.com/u/915398?v=3","gravatar_id":"","url":"https://api.github.com/users/lilleyse","html_url":"https://github.com/lilleyse","followers_url":"https://api.github.com/users/lilleyse/followers","following_url":"https://api.github.com/users/lilleyse/following{/other_user}","gists_url":"https://api.github.com/users/lilleyse/gists{/gist_id}","starred_url":"https://api.github.com/users/lilleyse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilleyse/subscriptions","organizations_url":"https://api.github.com/users/lilleyse/orgs","repos_url":"https://api.github.com/users/lilleyse/repos","events_url":"https://api.github.com/users/lilleyse/events{/privacy}","received_events_url":"https://api.github.com/users/lilleyse/received_events","type":"User","site_admin":false},"repo":{"id":41113401,"name":"cesium","full_name":"lilleyse/cesium","owner":{"login":"lilleyse","id":915398,"avatar_url":"https://avatars.githubusercontent.com/u/915398?v=3","gravatar_id":"","url":"https://api.github.com/users/lilleyse","html_url":"https://github.com/lilleyse","followers_url":"https://api.github.com/users/lilleyse/followers","following_url":"https://api.github.com/users/lilleyse/following{/other_user}","gists_url":"https://api.github.com/users/lilleyse/gists{/gist_id}","starred_url":"https://api.github.com/users/lilleyse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilleyse/subscriptions","organizations_url":"https://api.github.com/users/lilleyse/orgs","repos_url":"https://api.github.com/users/lilleyse/repos","events_url":"https://api.github.com/users/lilleyse/events{/privacy}","received_events_url":"https://api.github.com/users/lilleyse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lilleyse/cesium","description":"WebGL virtual globe and map engine","fork":true,"url":"https://api.github.com/repos/lilleyse/cesium","forks_url":"https://api.github.com/repos/lilleyse/cesium/forks","keys_url":"https://api.github.com/repos/lilleyse/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lilleyse/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lilleyse/cesium/teams","hooks_url":"https://api.github.com/repos/lilleyse/cesium/hooks","issue_events_url":"https://api.github.com/repos/lilleyse/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/lilleyse/cesium/events","assignees_url":"https://api.github.com/repos/lilleyse/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/lilleyse/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/lilleyse/cesium/tags","blobs_url":"https://api.github.com/repos/lilleyse/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lilleyse/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lilleyse/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/lilleyse/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lilleyse/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/lilleyse/cesium/languages","stargazers_url":"https://api.github.com/repos/lilleyse/cesium/stargazers","contributors_url":"https://api.github.com/repos/lilleyse/cesium/contributors","subscribers_url":"https://api.github.com/repos/lilleyse/cesium/subscribers","subscription_url":"https://api.github.com/repos/lilleyse/cesium/subscription","commits_url":"https://api.github.com/repos/lilleyse/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/lilleyse/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/lilleyse/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/lilleyse/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/lilleyse/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/lilleyse/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lilleyse/cesium/merges","archive_url":"https://api.github.com/repos/lilleyse/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lilleyse/cesium/downloads","issues_url":"https://api.github.com/repos/lilleyse/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/lilleyse/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/lilleyse/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/lilleyse/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lilleyse/cesium/labels{/name}","releases_url":"https://api.github.com/repos/lilleyse/cesium/releases{/id}","created_at":"2015-08-20T18:51:50Z","updated_at":"2015-08-20T18:51:58Z","pushed_at":"2015-11-04T22:55:12Z","git_url":"git://github.com/lilleyse/cesium.git","ssh_url":"git@github.com:lilleyse/cesium.git","clone_url":"https://github.com/lilleyse/cesium.git","svn_url":"https://github.com/lilleyse/cesium","homepage":"cesiumjs.org","size":229245,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:3d-tiles","ref":"3d-tiles","sha":"f3e2ad2fbd08412ac2b973c5fd439b46c29dfcb6","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":3606738,"name":"cesium","full_name":"AnalyticalGraphicsInc/cesium","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium","description":"WebGL virtual globe and map engine","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/releases{/id}","created_at":"2012-03-02T22:27:14Z","updated_at":"2015-11-04T16:44:09Z","pushed_at":"2015-11-04T22:55:13Z","git_url":"git://github.com/AnalyticalGraphicsInc/cesium.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/cesium.git","clone_url":"https://github.com/AnalyticalGraphicsInc/cesium.git","svn_url":"https://github.com/AnalyticalGraphicsInc/cesium","homepage":"cesiumjs.org","size":506100,"stargazers_count":1018,"watchers_count":1018,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":605,"mirror_url":null,"open_issues_count":308,"forks":605,"open_issues":308,"watchers":1018,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3158"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3158"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3158"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3158/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3158/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3158/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/cc15e6cc17504bea781babe235277da71268313c"}}}}