{"action":"created","comment":{"url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/comments/47600178","id":47600178,"diff_hunk":"@@ -17,6 +17,8 @@ Gem::Specification.new do |s|\n   s.add_runtime_dependency 'image_size'\n   s.add_runtime_dependency 'erubis'\n   s.add_runtime_dependency 'jshintrb', '~> 0.3.0'\n+  s.add_runtime_dependency 'babel-transpiler'\n+  s.add_runtime_dependency 'therubyracer'","path":"zendesk_apps_support.gemspec","position":5,"original_position":5,"commit_id":"7e3d014578481120054ff76df2f69c85e257ca07","original_commit_id":"7e3d014578481120054ff76df2f69c85e257ca07","user":{"login":"sandlerr","id":5535625,"avatar_url":"https://avatars.githubusercontent.com/u/5535625?v=3","gravatar_id":"","url":"https://api.github.com/users/sandlerr","html_url":"https://github.com/sandlerr","followers_url":"https://api.github.com/users/sandlerr/followers","following_url":"https://api.github.com/users/sandlerr/following{/other_user}","gists_url":"https://api.github.com/users/sandlerr/gists{/gist_id}","starred_url":"https://api.github.com/users/sandlerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandlerr/subscriptions","organizations_url":"https://api.github.com/users/sandlerr/orgs","repos_url":"https://api.github.com/users/sandlerr/repos","events_url":"https://api.github.com/users/sandlerr/events{/privacy}","received_events_url":"https://api.github.com/users/sandlerr/received_events","type":"User","site_admin":false},"body":"it depends on [execjs](https://github.com/babel/ruby-babel-transpiler/blob/master/babel-transpiler.gemspec#L22) if you want to not force people to install therubyracer then just go with that, and install therubyracer in our private consumer of this gem.","created_at":"2015-12-15T06:19:46Z","updated_at":"2015-12-15T06:19:46Z","html_url":"https://github.com/zendesk/zendesk_apps_support/pull/97#discussion_r47600178","pull_request_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/comments/47600178"},"html":{"href":"https://github.com/zendesk/zendesk_apps_support/pull/97#discussion_r47600178"},"pull_request":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/97","id":53059781,"html_url":"https://github.com/zendesk/zendesk_apps_support/pull/97","diff_url":"https://github.com/zendesk/zendesk_apps_support/pull/97.diff","patch_url":"https://github.com/zendesk/zendesk_apps_support/pull/97.patch","issue_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/97","number":97,"state":"open","locked":false,"title":"Olaf/es6","user":{"login":"ocke","id":5171412,"avatar_url":"https://avatars.githubusercontent.com/u/5171412?v=3","gravatar_id":"","url":"https://api.github.com/users/ocke","html_url":"https://github.com/ocke","followers_url":"https://api.github.com/users/ocke/followers","following_url":"https://api.github.com/users/ocke/following{/other_user}","gists_url":"https://api.github.com/users/ocke/gists{/gist_id}","starred_url":"https://api.github.com/users/ocke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocke/subscriptions","organizations_url":"https://api.github.com/users/ocke/orgs","repos_url":"https://api.github.com/users/ocke/repos","events_url":"https://api.github.com/users/ocke/events{/privacy}","received_events_url":"https://api.github.com/users/ocke/received_events","type":"User","site_admin":false},"body":":koala:\r\n\r\nto_es6 function for zas.\r\n\r\nI used therubyracer because node was incredible slow!\r\n- a request for plain js: 10-15ms\r\n- a request with using (babel) es6 and node: 700 ms! (man it was so slow, really annoying)\r\n- a request using babel and therubyracer: 20-25ms. (that's more like it!)\r\n\r\nI needed to change app.js to be a module, as babel only support modules, which means the top line becomes: `module.exports = {` instead of `function() { return {`.\r\n\r\nanyway have a play!\r\n\r\n/cc @zendesk/quokka\r\n\r\n### todo:\r\n- backwards compatibility for app.js\r\n\r\n### References\r\n - Jira link: \r\n\r\n### Risks\r\n - None","created_at":"2015-12-09T00:20:44Z","updated_at":"2015-12-15T06:19:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64bcb1d44e87768ec7965df4c502f1dc344709b4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/97/commits","review_comments_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/97/comments","review_comment_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/97/comments","statuses_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/statuses/7e3d014578481120054ff76df2f69c85e257ca07","head":{"label":"zendesk:olaf/es6","ref":"olaf/es6","sha":"7e3d014578481120054ff76df2f69c85e257ca07","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":6622163,"name":"zendesk_apps_support","full_name":"zendesk/zendesk_apps_support","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/zendesk_apps_support","description":"","fork":false,"url":"https://api.github.com/repos/zendesk/zendesk_apps_support","forks_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/forks","keys_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/teams","hooks_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/hooks","issue_events_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/events","assignees_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/tags","blobs_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/languages","stargazers_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/stargazers","contributors_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/contributors","subscribers_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/subscribers","subscription_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/subscription","commits_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/merges","archive_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/downloads","issues_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/releases{/id}","created_at":"2012-11-09T23:29:16Z","updated_at":"2015-03-30T02:22:53Z","pushed_at":"2015-12-09T00:20:45Z","git_url":"git://github.com/zendesk/zendesk_apps_support.git","ssh_url":"git@github.com:zendesk/zendesk_apps_support.git","clone_url":"https://github.com/zendesk/zendesk_apps_support.git","svn_url":"https://github.com/zendesk/zendesk_apps_support","homepage":null,"size":569,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"zendesk:master","ref":"master","sha":"adb29f4455d9bbbc5dabde7d583370e0326db220","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":6622163,"name":"zendesk_apps_support","full_name":"zendesk/zendesk_apps_support","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/zendesk_apps_support","description":"","fork":false,"url":"https://api.github.com/repos/zendesk/zendesk_apps_support","forks_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/forks","keys_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/teams","hooks_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/hooks","issue_events_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/events","assignees_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/tags","blobs_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/languages","stargazers_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/stargazers","contributors_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/contributors","subscribers_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/subscribers","subscription_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/subscription","commits_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/merges","archive_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/downloads","issues_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/releases{/id}","created_at":"2012-11-09T23:29:16Z","updated_at":"2015-03-30T02:22:53Z","pushed_at":"2015-12-09T00:20:45Z","git_url":"git://github.com/zendesk/zendesk_apps_support.git","ssh_url":"git@github.com:zendesk/zendesk_apps_support.git","clone_url":"https://github.com/zendesk/zendesk_apps_support.git","svn_url":"https://github.com/zendesk/zendesk_apps_support","homepage":null,"size":569,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/97"},"html":{"href":"https://github.com/zendesk/zendesk_apps_support/pull/97"},"issue":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/97"},"comments":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/statuses/7e3d014578481120054ff76df2f69c85e257ca07"}}}}