{"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/41642607","id":41642607,"diff_hunk":"@@ -5,20 +5,45 @@ class Robot\n \n   @@registry\n \n+  def new_name_using_default_generator \n+    generate_char = -> { ('A'..'Z').to_a.sample }\n+    generate_num = -> { rand(10) }\n+\n+    # pattern AB123\n+    return \"#{generate_char.call}\n+            #{generate_char.call}\n+            #{generate_num.call}\n+            #{generate_num.call}\n+            #{generate_num.call}\"\n+  end\n+\n+  def new_name_is_invalid(new_name)\n+    #garbage sorting\n+    if new_name == '' || new_name == nil \n+      return true\n+    # pattern matching\n+    elsif !(new_name !=~ /[[:alpha:]]{2}[[:digit:]]{3}/)\n+      return true\n+    # redundancy matching\n+    elsif @@registry.include?(new_name)\n+      return true\n+    end\n+    return false","path":"robot_name/robot_name.rb","position":27,"original_position":27,"commit_id":"02b796c53f6aa0382998ceafe60f0f8f630c0f14","original_commit_id":"02b796c53f6aa0382998ceafe60f0f8f630c0f14","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Redundant `return` detected.","created_at":"2015-10-09T15:24:23Z","updated_at":"2015-10-09T15:24:23Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/1003#discussion_r41642607","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1003","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/41642607"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/1003#discussion_r41642607"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1003"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1003","id":47284980,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/1003","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/1003.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/1003.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/1003","number":1003,"state":"open","locked":false,"title":"Just git","user":{"login":"athiercelin","id":11185161,"avatar_url":"https://avatars.githubusercontent.com/u/11185161?v=3","gravatar_id":"","url":"https://api.github.com/users/athiercelin","html_url":"https://github.com/athiercelin","followers_url":"https://api.github.com/users/athiercelin/followers","following_url":"https://api.github.com/users/athiercelin/following{/other_user}","gists_url":"https://api.github.com/users/athiercelin/gists{/gist_id}","starred_url":"https://api.github.com/users/athiercelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athiercelin/subscriptions","organizations_url":"https://api.github.com/users/athiercelin/orgs","repos_url":"https://api.github.com/users/athiercelin/repos","events_url":"https://api.github.com/users/athiercelin/events{/privacy}","received_events_url":"https://api.github.com/users/athiercelin/received_events","type":"User","site_admin":false},"body":"Started to implem the UI form.","created_at":"2015-10-09T15:24:03Z","updated_at":"2015-10-09T15:24:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d7a37388225ca1318072eca675e1e0411191db0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1003/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1003/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/1003/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/02b796c53f6aa0382998ceafe60f0f8f630c0f14","head":{"label":"athiercelin:just_git","ref":"just_git","sha":"02b796c53f6aa0382998ceafe60f0f8f630c0f14","user":{"login":"athiercelin","id":11185161,"avatar_url":"https://avatars.githubusercontent.com/u/11185161?v=3","gravatar_id":"","url":"https://api.github.com/users/athiercelin","html_url":"https://github.com/athiercelin","followers_url":"https://api.github.com/users/athiercelin/followers","following_url":"https://api.github.com/users/athiercelin/following{/other_user}","gists_url":"https://api.github.com/users/athiercelin/gists{/gist_id}","starred_url":"https://api.github.com/users/athiercelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athiercelin/subscriptions","organizations_url":"https://api.github.com/users/athiercelin/orgs","repos_url":"https://api.github.com/users/athiercelin/repos","events_url":"https://api.github.com/users/athiercelin/events{/privacy}","received_events_url":"https://api.github.com/users/athiercelin/received_events","type":"User","site_admin":false},"repo":{"id":43771800,"name":"level_up_exercises","full_name":"athiercelin/level_up_exercises","owner":{"login":"athiercelin","id":11185161,"avatar_url":"https://avatars.githubusercontent.com/u/11185161?v=3","gravatar_id":"","url":"https://api.github.com/users/athiercelin","html_url":"https://github.com/athiercelin","followers_url":"https://api.github.com/users/athiercelin/followers","following_url":"https://api.github.com/users/athiercelin/following{/other_user}","gists_url":"https://api.github.com/users/athiercelin/gists{/gist_id}","starred_url":"https://api.github.com/users/athiercelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athiercelin/subscriptions","organizations_url":"https://api.github.com/users/athiercelin/orgs","repos_url":"https://api.github.com/users/athiercelin/repos","events_url":"https://api.github.com/users/athiercelin/events{/privacy}","received_events_url":"https://api.github.com/users/athiercelin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/athiercelin/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/athiercelin/level_up_exercises","forks_url":"https://api.github.com/repos/athiercelin/level_up_exercises/forks","keys_url":"https://api.github.com/repos/athiercelin/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/athiercelin/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/athiercelin/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/athiercelin/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/athiercelin/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/athiercelin/level_up_exercises/events","assignees_url":"https://api.github.com/repos/athiercelin/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/athiercelin/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/athiercelin/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/athiercelin/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/athiercelin/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/athiercelin/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/athiercelin/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/athiercelin/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/athiercelin/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/athiercelin/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/athiercelin/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/athiercelin/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/athiercelin/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/athiercelin/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/athiercelin/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/athiercelin/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/athiercelin/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/athiercelin/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/athiercelin/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/athiercelin/level_up_exercises/merges","archive_url":"https://api.github.com/repos/athiercelin/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/athiercelin/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/athiercelin/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/athiercelin/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/athiercelin/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/athiercelin/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/athiercelin/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/athiercelin/level_up_exercises/releases{/id}","created_at":"2015-10-06T18:56:48Z","updated_at":"2015-10-06T18:56:49Z","pushed_at":"2015-10-09T15:24:03Z","git_url":"git://github.com/athiercelin/level_up_exercises.git","ssh_url":"git@github.com:athiercelin/level_up_exercises.git","clone_url":"https://github.com/athiercelin/level_up_exercises.git","svn_url":"https://github.com/athiercelin/level_up_exercises","homepage":"https://leveluprails.com","size":223227,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"573aed5af1dff6995e407c7c9c16cdaa9aa183ca","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2015-10-07T23:32:46Z","pushed_at":"2015-10-09T15:24:09Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":"https://leveluprails.com","size":223227,"stargazers_count":29,"watchers_count":29,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":147,"mirror_url":null,"open_issues_count":11,"forks":147,"open_issues":11,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1003"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/1003"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/1003"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/1003/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1003/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/1003/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/02b796c53f6aa0382998ceafe60f0f8f630c0f14"}}}}