{"action":"created","comment":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments/41517373","id":41517373,"diff_hunk":"@@ -29,7 +29,7 @@\n public class ContainerDrive extends AEBaseContainer\n {\n \n-\tfinal TileDrive drive;\n+\tprivate final TileDrive drive;","path":"src/main/java/appeng/container/implementations/ContainerDrive.java","position":5,"original_position":5,"commit_id":"5b8c8294dfcf19c26ab8bb8856d67d46fe9704b9","original_commit_id":"5b8c8294dfcf19c26ab8bb8856d67d46fe9704b9","user":{"login":"orod-org","id":14347709,"avatar_url":"https://avatars.githubusercontent.com/u/14347709?v=3","gravatar_id":"","url":"https://api.github.com/users/orod-org","html_url":"https://github.com/orod-org","followers_url":"https://api.github.com/users/orod-org/followers","following_url":"https://api.github.com/users/orod-org/following{/other_user}","gists_url":"https://api.github.com/users/orod-org/gists{/gist_id}","starred_url":"https://api.github.com/users/orod-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orod-org/subscriptions","organizations_url":"https://api.github.com/users/orod-org/orgs","repos_url":"https://api.github.com/users/orod-org/repos","events_url":"https://api.github.com/users/orod-org/events{/privacy}","received_events_url":"https://api.github.com/users/orod-org/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) Remove this unused \"drive\" private field. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://nemo.sonarqube.org/coding_rules#rule_key=squid%3AS1068)\n","created_at":"2015-10-08T14:11:18Z","updated_at":"2015-10-08T14:11:18Z","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1936#discussion_r41517373","pull_request_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1936","_links":{"self":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments/41517373"},"html":{"href":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1936#discussion_r41517373"},"pull_request":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1936"}}},"pull_request":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1936","id":47156898,"html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1936","diff_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1936.diff","patch_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1936.patch","issue_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1936","number":1936,"state":"open","locked":false,"title":"Make all fields private and creates necessary getters/setters","user":{"login":"yueh","id":151949,"avatar_url":"https://avatars.githubusercontent.com/u/151949?v=3","gravatar_id":"","url":"https://api.github.com/users/yueh","html_url":"https://github.com/yueh","followers_url":"https://api.github.com/users/yueh/followers","following_url":"https://api.github.com/users/yueh/following{/other_user}","gists_url":"https://api.github.com/users/yueh/gists{/gist_id}","starred_url":"https://api.github.com/users/yueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yueh/subscriptions","organizations_url":"https://api.github.com/users/yueh/orgs","repos_url":"https://api.github.com/users/yueh/repos","events_url":"https://api.github.com/users/yueh/events{/privacy}","received_events_url":"https://api.github.com/users/yueh/received_events","type":"User","site_admin":false},"body":"This makes every field private and creates a getter/setter  for it when actually necessary.\r\nThe only exceptions are currently any field with `@GuiSync` as they will not be synchronized when not public.\r\n\r\nThis will probably create a ton of issues regarding unused fields now..","created_at":"2015-10-08T14:08:07Z","updated_at":"2015-10-08T14:11:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b14e9c4f14db1d118104ab74cc699fe5e1aa7284","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1936/commits","review_comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1936/comments","review_comment_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1936/comments","statuses_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/statuses/5b8c8294dfcf19c26ab8bb8856d67d46fe9704b9","head":{"label":"yueh:feature-hide-fields","ref":"feature-hide-fields","sha":"5b8c8294dfcf19c26ab8bb8856d67d46fe9704b9","user":{"login":"yueh","id":151949,"avatar_url":"https://avatars.githubusercontent.com/u/151949?v=3","gravatar_id":"","url":"https://api.github.com/users/yueh","html_url":"https://github.com/yueh","followers_url":"https://api.github.com/users/yueh/followers","following_url":"https://api.github.com/users/yueh/following{/other_user}","gists_url":"https://api.github.com/users/yueh/gists{/gist_id}","starred_url":"https://api.github.com/users/yueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yueh/subscriptions","organizations_url":"https://api.github.com/users/yueh/orgs","repos_url":"https://api.github.com/users/yueh/repos","events_url":"https://api.github.com/users/yueh/events{/privacy}","received_events_url":"https://api.github.com/users/yueh/received_events","type":"User","site_admin":false},"repo":{"id":24421290,"name":"Applied-Energistics-2","full_name":"yueh/Applied-Energistics-2","owner":{"login":"yueh","id":151949,"avatar_url":"https://avatars.githubusercontent.com/u/151949?v=3","gravatar_id":"","url":"https://api.github.com/users/yueh","html_url":"https://github.com/yueh","followers_url":"https://api.github.com/users/yueh/followers","following_url":"https://api.github.com/users/yueh/following{/other_user}","gists_url":"https://api.github.com/users/yueh/gists{/gist_id}","starred_url":"https://api.github.com/users/yueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yueh/subscriptions","organizations_url":"https://api.github.com/users/yueh/orgs","repos_url":"https://api.github.com/users/yueh/repos","events_url":"https://api.github.com/users/yueh/events{/privacy}","received_events_url":"https://api.github.com/users/yueh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yueh/Applied-Energistics-2","description":"A Mod about Matter, Energy and using them to conquer the world..","fork":true,"url":"https://api.github.com/repos/yueh/Applied-Energistics-2","forks_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/forks","keys_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/teams","hooks_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/hooks","issue_events_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/issues/events{/number}","events_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/events","assignees_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/assignees{/user}","branches_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/branches{/branch}","tags_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/tags","blobs_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/statuses/{sha}","languages_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/languages","stargazers_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/stargazers","contributors_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/contributors","subscribers_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/subscribers","subscription_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/subscription","commits_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/contents/{+path}","compare_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/merges","archive_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/downloads","issues_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/issues{/number}","pulls_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/pulls{/number}","milestones_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/milestones{/number}","notifications_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/labels{/name}","releases_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/releases{/id}","created_at":"2014-09-24T15:45:12Z","updated_at":"2015-04-28T16:29:30Z","pushed_at":"2015-10-08T14:05:16Z","git_url":"git://github.com/yueh/Applied-Energistics-2.git","ssh_url":"git@github.com:yueh/Applied-Energistics-2.git","clone_url":"https://github.com/yueh/Applied-Energistics-2.git","svn_url":"https://github.com/yueh/Applied-Energistics-2","homepage":"http://ae-mod.info/","size":12790,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AppliedEnergistics:master","ref":"master","sha":"c14bc82a018b0b22ecd57e5e5ed2e1be2852b5bd","user":{"login":"AppliedEnergistics","id":8868712,"avatar_url":"https://avatars.githubusercontent.com/u/8868712?v=3","gravatar_id":"","url":"https://api.github.com/users/AppliedEnergistics","html_url":"https://github.com/AppliedEnergistics","followers_url":"https://api.github.com/users/AppliedEnergistics/followers","following_url":"https://api.github.com/users/AppliedEnergistics/following{/other_user}","gists_url":"https://api.github.com/users/AppliedEnergistics/gists{/gist_id}","starred_url":"https://api.github.com/users/AppliedEnergistics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppliedEnergistics/subscriptions","organizations_url":"https://api.github.com/users/AppliedEnergistics/orgs","repos_url":"https://api.github.com/users/AppliedEnergistics/repos","events_url":"https://api.github.com/users/AppliedEnergistics/events{/privacy}","received_events_url":"https://api.github.com/users/AppliedEnergistics/received_events","type":"Organization","site_admin":false},"repo":{"id":24395109,"name":"Applied-Energistics-2","full_name":"AppliedEnergistics/Applied-Energistics-2","owner":{"login":"AppliedEnergistics","id":8868712,"avatar_url":"https://avatars.githubusercontent.com/u/8868712?v=3","gravatar_id":"","url":"https://api.github.com/users/AppliedEnergistics","html_url":"https://github.com/AppliedEnergistics","followers_url":"https://api.github.com/users/AppliedEnergistics/followers","following_url":"https://api.github.com/users/AppliedEnergistics/following{/other_user}","gists_url":"https://api.github.com/users/AppliedEnergistics/gists{/gist_id}","starred_url":"https://api.github.com/users/AppliedEnergistics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppliedEnergistics/subscriptions","organizations_url":"https://api.github.com/users/AppliedEnergistics/orgs","repos_url":"https://api.github.com/users/AppliedEnergistics/repos","events_url":"https://api.github.com/users/AppliedEnergistics/events{/privacy}","received_events_url":"https://api.github.com/users/AppliedEnergistics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2","description":"A Minecraft Mod about Matter, Energy and using them to conquer the world..","fork":false,"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2","forks_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/forks","keys_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/teams","hooks_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/hooks","issue_events_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/events{/number}","events_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/events","assignees_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/assignees{/user}","branches_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/branches{/branch}","tags_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/tags","blobs_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/statuses/{sha}","languages_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/languages","stargazers_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/stargazers","contributors_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/contributors","subscribers_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/subscribers","subscription_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/subscription","commits_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/contents/{+path}","compare_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/merges","archive_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/downloads","issues_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues{/number}","pulls_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls{/number}","milestones_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/milestones{/number}","notifications_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/labels{/name}","releases_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/releases{/id}","created_at":"2014-09-24T00:48:40Z","updated_at":"2015-10-07T00:46:11Z","pushed_at":"2015-10-08T14:08:08Z","git_url":"git://github.com/AppliedEnergistics/Applied-Energistics-2.git","ssh_url":"git@github.com:AppliedEnergistics/Applied-Energistics-2.git","clone_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2.git","svn_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2","homepage":"http://ae-mod.info/","size":25988,"stargazers_count":282,"watchers_count":282,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":123,"mirror_url":null,"open_issues_count":230,"forks":123,"open_issues":230,"watchers":282,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1936"},"html":{"href":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1936"},"issue":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1936"},"comments":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1936/comments"},"review_comments":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1936/comments"},"review_comment":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1936/commits"},"statuses":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/statuses/5b8c8294dfcf19c26ab8bb8856d67d46fe9704b9"}}}}