{"action":"created","issue":{"url":"https://api.github.com/repos/cloudfoundry/php-buildpack/issues/40","labels_url":"https://api.github.com/repos/cloudfoundry/php-buildpack/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/cloudfoundry/php-buildpack/issues/40/comments","events_url":"https://api.github.com/repos/cloudfoundry/php-buildpack/issues/40/events","html_url":"https://github.com/cloudfoundry/php-buildpack/issues/40","id":56408488,"number":40,"title":"Interested in adding varnish?","user":{"login":"chregu","id":47106,"avatar_url":"https://avatars.githubusercontent.com/u/47106?v=3","gravatar_id":"","url":"https://api.github.com/users/chregu","html_url":"https://github.com/chregu","followers_url":"https://api.github.com/users/chregu/followers","following_url":"https://api.github.com/users/chregu/following{/other_user}","gists_url":"https://api.github.com/users/chregu/gists{/gist_id}","starred_url":"https://api.github.com/users/chregu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chregu/subscriptions","organizations_url":"https://api.github.com/users/chregu/orgs","repos_url":"https://api.github.com/users/chregu/repos","events_url":"https://api.github.com/users/chregu/events{/privacy}","received_events_url":"https://api.github.com/users/chregu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cloudfoundry/php-buildpack/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-02-03T17:21:38Z","updated_at":"2015-02-04T14:26:00Z","closed_at":null,"body":"I integrated varnish in the PHP buildpack\r\n\r\nWe need this mostly to be able to have a PHP listeners which listens to RabbitMQ and for example purges the cache on demand and does other stuff\r\n\r\nBut it could also be useful for having varnish directly in the same cf app for PHP applications, not the immediate need by us, but could be useful\r\n\r\nWould there be general interest to get this \"upstream\"? Or shall I just continue maintaining the fork? It's not perfect yet, but it works.\r\n\r\nHere's the branch:\r\nhttps://github.com/chregu/php-buildpack/tree/with-varnish\r\n\r\nAnd here's a small REAME:\r\n\r\nhttps://github.com/chregu/php-buildpack/blob/with-varnish/docs/varnish.md\r\n\r\nPS. it was a little bit of pain to get the $PORT changed for http and nginx when there's a varnish in front, and I'm still not sure if there isn't a better way than I did. But the env variables returned by service_environment() are not available in rewrite and PORT is anyway only very late available  (and not really in service_environment()), if I remember correctly"},"comment":{"url":"https://api.github.com/repos/cloudfoundry/php-buildpack/issues/comments/72862136","html_url":"https://github.com/cloudfoundry/php-buildpack/issues/40#issuecomment-72862136","issue_url":"https://api.github.com/repos/cloudfoundry/php-buildpack/issues/40","id":72862136,"user":{"login":"dmikusa-pivotal","id":4643262,"avatar_url":"https://avatars.githubusercontent.com/u/4643262?v=3","gravatar_id":"","url":"https://api.github.com/users/dmikusa-pivotal","html_url":"https://github.com/dmikusa-pivotal","followers_url":"https://api.github.com/users/dmikusa-pivotal/followers","following_url":"https://api.github.com/users/dmikusa-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/dmikusa-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/dmikusa-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmikusa-pivotal/subscriptions","organizations_url":"https://api.github.com/users/dmikusa-pivotal/orgs","repos_url":"https://api.github.com/users/dmikusa-pivotal/repos","events_url":"https://api.github.com/users/dmikusa-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/dmikusa-pivotal/received_events","type":"User","site_admin":false},"created_at":"2015-02-04T14:26:00Z","updated_at":"2015-02-04T14:26:00Z","body":"Thanks for the feedback!  If you're OK maintaining the fork for now, I'd say let's leave this open and see if anyone else is interested in this functionality.\r\n\r\nAs far as the patch itself, I'm a little concerned with the way it's integrated.  It's not bad, but I think the build pack could be improved to be more flexible for this type of use case.  Before pulling it in, I'd want to see if we could do something to make the integration easier and less cross cutting (i.e. so you don't have to touch the core extensions & config files).  \r\n\r\nI'm also a little concerned with testing.  It adds a new dimension of things that need to be tested.  i.e. we'd probably want to run integration tests for our current configurations and the same configurations with varnish."}}