{"action":"created","issue":{"url":"https://api.github.com/repos/marrub--/GLOOME/issues/19","labels_url":"https://api.github.com/repos/marrub--/GLOOME/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/marrub--/GLOOME/issues/19/comments","events_url":"https://api.github.com/repos/marrub--/GLOOME/issues/19/events","html_url":"https://github.com/marrub--/GLOOME/pull/19","id":114495422,"number":19,"title":"Fixed & renamed PickActor flags.","user":{"login":"j-palomo","id":4956286,"avatar_url":"https://avatars.githubusercontent.com/u/4956286?v=3","gravatar_id":"","url":"https://api.github.com/users/j-palomo","html_url":"https://github.com/j-palomo","followers_url":"https://api.github.com/users/j-palomo/followers","following_url":"https://api.github.com/users/j-palomo/following{/other_user}","gists_url":"https://api.github.com/users/j-palomo/gists{/gist_id}","starred_url":"https://api.github.com/users/j-palomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-palomo/subscriptions","organizations_url":"https://api.github.com/users/j-palomo/orgs","repos_url":"https://api.github.com/users/j-palomo/repos","events_url":"https://api.github.com/users/j-palomo/events{/privacy}","received_events_url":"https://api.github.com/users/j-palomo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-01T21:48:40Z","updated_at":"2015-11-04T10:04:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/marrub--/GLOOME/pulls/19","html_url":"https://github.com/marrub--/GLOOME/pull/19","diff_url":"https://github.com/marrub--/GLOOME/pull/19.diff","patch_url":"https://github.com/marrub--/GLOOME/pull/19.patch"},"body":"The new PickActor flags were broken, and didn't work as intended. Not only that, but it broke backwards compatibility with the old argument. I've fixed all of that. I also renamed the flags to avoid confusion with the A_PainAttack flags."},"comment":{"url":"https://api.github.com/repos/marrub--/GLOOME/issues/comments/153667667","html_url":"https://github.com/marrub--/GLOOME/pull/19#issuecomment-153667667","issue_url":"https://api.github.com/repos/marrub--/GLOOME/issues/19","id":153667667,"user":{"login":"j-palomo","id":4956286,"avatar_url":"https://avatars.githubusercontent.com/u/4956286?v=3","gravatar_id":"","url":"https://api.github.com/users/j-palomo","html_url":"https://github.com/j-palomo","followers_url":"https://api.github.com/users/j-palomo/followers","following_url":"https://api.github.com/users/j-palomo/following{/other_user}","gists_url":"https://api.github.com/users/j-palomo/gists{/gist_id}","starred_url":"https://api.github.com/users/j-palomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-palomo/subscriptions","organizations_url":"https://api.github.com/users/j-palomo/orgs","repos_url":"https://api.github.com/users/j-palomo/repos","events_url":"https://api.github.com/users/j-palomo/events{/privacy}","received_events_url":"https://api.github.com/users/j-palomo/received_events","type":"User","site_admin":false},"created_at":"2015-11-04T10:04:17Z","updated_at":"2015-11-04T10:04:17Z","body":"See [here](https://github.com/j-palomo/GLOOME/blob/pickactorfix/src/p_acs.cpp#L141):\r\n```\r\nenum\r\n{\r\n//\tPAF_FORCETID,\r\n//\tPAF_RETURNTID\r\n\tPICKAF_FORCETID = 1,\r\n\tPICKAF_RETURNTID = 2,\r\n};\r\n```\r\nThis enumeration (commented out) didn't have any numbers defined for the values. As a result, `PAF_FORCETID = 0`, and `PAF_RETURNTID = 1`. Obviously, this is an issue [because](https://github.com/marrub--/GLOOME/pull/19/files#diff-e273fd0a9e6ce6a590cdd920fc6e1c39L1055)...\r\n```\r\n#define PAF_FORCETID  1\r\n#define PAF_RETURNTID 2\r\n```\r\nThe flags never worked as intended. In the worst case, if you used the argument as it previously was (boolean forcetid), using a value of false will actually set the PAF_FORCETID flag."}}