{"action":"created","issue":{"url":"https://api.github.com/repos/artsy/Emergence/issues/66","labels_url":"https://api.github.com/repos/artsy/Emergence/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/artsy/Emergence/issues/66/comments","events_url":"https://api.github.com/repos/artsy/Emergence/issues/66/events","html_url":"https://github.com/artsy/Emergence/pull/66","id":116537823,"number":66,"title":"Remove city sections from the shows overview screen if they have no shows","user":{"login":"icanzilb","id":633862,"avatar_url":"https://avatars.githubusercontent.com/u/633862?v=3","gravatar_id":"","url":"https://api.github.com/users/icanzilb","html_url":"https://github.com/icanzilb","followers_url":"https://api.github.com/users/icanzilb/followers","following_url":"https://api.github.com/users/icanzilb/following{/other_user}","gists_url":"https://api.github.com/users/icanzilb/gists{/gist_id}","starred_url":"https://api.github.com/users/icanzilb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icanzilb/subscriptions","organizations_url":"https://api.github.com/users/icanzilb/orgs","repos_url":"https://api.github.com/users/icanzilb/repos","events_url":"https://api.github.com/users/icanzilb/events{/privacy}","received_events_url":"https://api.github.com/users/icanzilb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-11-12T12:13:13Z","updated_at":"2015-11-12T16:54:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/artsy/Emergence/pulls/66","html_url":"https://github.com/artsy/Emergence/pull/66","diff_url":"https://github.com/artsy/Emergence/pull/66.diff","patch_url":"https://github.com/artsy/Emergence/pull/66.patch"},"body":"12:21] marin: re tv app @orta - I can see cities in the list that have no shows\r\n[12:21] marin: e.g. the list of shows just ends saying Tokyo and nothing more\r\n[12:21] orta: yeah, rather lazily I’ve not bothered removing them :smile:\r\n[12:22] orta: I think I have an issue for it, but shippers gotta ship\r\n[12:22] marin: should I send you a PR?\r\n[12:22] marin: :stuck_out_tongue:\r\n[12:22] marin: though it might be faster to fix it yourself than to merge a PR for it :simple_smile:\r\n[12:40] orta: you sure can send a PR :simple_smile:\r\n[12:40] orta: I’m not touching that codebase for a little bit, so it’s free to edit\r\n* * * \r\n11:21] marin: @orta: I got to know and understand the code and I could fix the issue in few different ways, but I guess I need to know what the expected behavior is; you said there was a ticket for it ?\r\n[11:23] marin: also are the emitters expected to emit entities more times? like … if there aren’t any shows in Tokyo, could there be a signal that brings in some shows while the user has the app open ?\r\n[13:48] orta: I feel like if an emitter has no shows at all, it should be removed from the list of emitters\r\n[13:48] orta: no point in trying to make a “no shows” kind of default"},"comment":{"url":"https://api.github.com/repos/artsy/Emergence/issues/comments/156164534","html_url":"https://github.com/artsy/Emergence/pull/66#issuecomment-156164534","issue_url":"https://api.github.com/repos/artsy/Emergence/issues/66","id":156164534,"user":{"login":"orta","id":49038,"avatar_url":"https://avatars.githubusercontent.com/u/49038?v=3","gravatar_id":"","url":"https://api.github.com/users/orta","html_url":"https://github.com/orta","followers_url":"https://api.github.com/users/orta/followers","following_url":"https://api.github.com/users/orta/following{/other_user}","gists_url":"https://api.github.com/users/orta/gists{/gist_id}","starred_url":"https://api.github.com/users/orta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orta/subscriptions","organizations_url":"https://api.github.com/users/orta/orgs","repos_url":"https://api.github.com/users/orta/repos","events_url":"https://api.github.com/users/orta/events{/privacy}","received_events_url":"https://api.github.com/users/orta/received_events","type":"User","site_admin":false},"created_at":"2015-11-12T16:54:35Z","updated_at":"2015-11-12T16:54:35Z","body":":tada: - cool beans, shipping it!"}}