{"action":"created","issue":{"url":"https://api.github.com/repos/ninja-build/ninja/issues/996","labels_url":"https://api.github.com/repos/ninja-build/ninja/issues/996/labels{/name}","comments_url":"https://api.github.com/repos/ninja-build/ninja/issues/996/comments","events_url":"https://api.github.com/repos/ninja-build/ninja/issues/996/events","html_url":"https://github.com/ninja-build/ninja/pull/996","id":97416381,"number":996,"title":"Don't set /Wx for MSVC","user":{"login":"krf","id":30826,"avatar_url":"https://avatars.githubusercontent.com/u/30826?v=3","gravatar_id":"","url":"https://api.github.com/users/krf","html_url":"https://github.com/krf","followers_url":"https://api.github.com/users/krf/followers","following_url":"https://api.github.com/users/krf/following{/other_user}","gists_url":"https://api.github.com/users/krf/gists{/gist_id}","starred_url":"https://api.github.com/users/krf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krf/subscriptions","organizations_url":"https://api.github.com/users/krf/orgs","repos_url":"https://api.github.com/users/krf/repos","events_url":"https://api.github.com/users/krf/events{/privacy}","received_events_url":"https://api.github.com/users/krf/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-07-27T08:54:42Z","updated_at":"2015-11-12T01:05:57Z","closed_at":"2015-11-12T01:05:56Z","pull_request":{"url":"https://api.github.com/repos/ninja-build/ninja/pulls/996","html_url":"https://github.com/ninja-build/ninja/pull/996","diff_url":"https://github.com/ninja-build/ninja/pull/996.diff","patch_url":"https://github.com/ninja-build/ninja/pull/996.patch"},"body":"Make the code future proof: If a new compiler / Windows SDK pulls in a new warnings, we\r\ndon't automatically want to make the build fail.\r\n\r\nA good explanation can be found here: https://blog.flameeyes.eu/2009/02/future-proof-your-code-dont-use-werror#gsc.tab=0\r\n\r\nThis option was causing https://github.com/martine/ninja/issues/995"},"comment":{"url":"https://api.github.com/repos/ninja-build/ninja/issues/comments/155964794","html_url":"https://github.com/ninja-build/ninja/pull/996#issuecomment-155964794","issue_url":"https://api.github.com/repos/ninja-build/ninja/issues/996","id":155964794,"user":{"login":"nico","id":3487,"avatar_url":"https://avatars.githubusercontent.com/u/3487?v=3","gravatar_id":"","url":"https://api.github.com/users/nico","html_url":"https://github.com/nico","followers_url":"https://api.github.com/users/nico/followers","following_url":"https://api.github.com/users/nico/following{/other_user}","gists_url":"https://api.github.com/users/nico/gists{/gist_id}","starred_url":"https://api.github.com/users/nico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nico/subscriptions","organizations_url":"https://api.github.com/users/nico/orgs","repos_url":"https://api.github.com/users/nico/repos","events_url":"https://api.github.com/users/nico/events{/privacy}","received_events_url":"https://api.github.com/users/nico/received_events","type":"User","site_admin":false},"created_at":"2015-11-12T01:05:56Z","updated_at":"2015-11-12T01:05:56Z","body":"I think so far having warnings on errors has done more good than harm: It caused us to quickly fix this warning, and else we wouldn't have noticed the warning for a long time and there would have been build noise. We can revisit this if the compiler landscape on Windows becomes more diverse (e.g. if clang-cl becomes very popular)."}}