{"push_id":547466857,"size":26,"distinct_size":26,"ref":"refs/heads/master","head":"363e298c3cdfc4c3b569d4fe4053edc3b8943f0a","before":"9311d27c07d2e571294024765deb6c91b3a56b94","commits":[{"sha":"1ffd1a305c51856da09dcac43781e7f2d1b6e633","author":{"email":"206417cbf125b7bab6402ef77db554b11bf8c38a@me.com","name":"Kir Shatrov"},"message":"Section about testing xhr requests\nrails/rails#18305","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/1ffd1a305c51856da09dcac43781e7f2d1b6e633"},{"sha":"bb3c054358901e28a697643b1f76e0a29b68158e","author":{"email":"206417cbf125b7bab6402ef77db554b11bf8c38a@me.com","name":"Kir Shatrov"},"message":"Avoid double negation in test guide\nrails/rails#18305","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/bb3c054358901e28a697643b1f76e0a29b68158e"},{"sha":"4a3b9c82830b08056467524081d4dd408eb6db43","author":{"email":"206417cbf125b7bab6402ef77db554b11bf8c38a@me.com","name":"Kir Shatrov"},"message":"Docs for controller test helpers\nrails/rails#18305","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/4a3b9c82830b08056467524081d4dd408eb6db43"},{"sha":"cf87cfeb5730ab9982adcb0a6b5608c7e75b3fa0","author":{"email":"206417cbf125b7bab6402ef77db554b11bf8c38a@me.com","name":"Kir Shatrov"},"message":"Demonstrate example of `assert_emails` in testing guide\nrails/rails#18305, thanks for @dhh suggestion","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/cf87cfeb5730ab9982adcb0a6b5608c7e75b3fa0"},{"sha":"ef7274be877dc89d232b104e93b5022b56360820","author":{"email":"206417cbf125b7bab6402ef77db554b11bf8c38a@me.com","name":"Kir Shatrov"},"message":"Better example of `teardown` method in test guide\nrails/rails#18305, thanks for @dhh suggestion","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/ef7274be877dc89d232b104e93b5022b56360820"},{"sha":"9fe8e19af1db5fe82c83c9af9afc7f59883ee4e4","author":{"email":"ebd73beb044ee5759f027a56464cea105bbc60a7@gmail.com","name":"claudiob"},"message":"Fix docs for ActiveSupport::Inflector methods\n\nMany methods in ActiveSupport::Inflector were actually documenting\nthe String methods with the same name.\n\nFor instance the doc for `camelize` said:\n\n> If the argument to +camelize+ is set to <tt>:lower</tt>...\n\nwhile it should say:\n\n> If the +uppercase_first_letter+ parameter is set to false\n\n[ci skip]","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/9fe8e19af1db5fe82c83c9af9afc7f59883ee4e4"},{"sha":"283326cc61335ec62692dc550e460bb7e20b13b1","author":{"email":"ebd73beb044ee5759f027a56464cea105bbc60a7@gmail.com","name":"claudiob"},"message":"Better examples for fresh_when and stale?\n\nIt is clearer and closer to reality to use `@article.updated_at` as\nthe `:last_modified` parameter of `fresh_when` and `stale?`.\n\nUsing `@article.created_at` would result in the cache never expiring,\nsince the creation timestamp never changes.\n\n[ci skip]","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/283326cc61335ec62692dc550e460bb7e20b13b1"},{"sha":"e56ab7769339aa57a29e9b60bdf8dfc65f26068e","author":{"email":"ebd73beb044ee5759f027a56464cea105bbc60a7@gmail.com","name":"claudiob"},"message":"Fix typo \"you can be disable\"\n\nCloses https://github.com/rails/rails/issues/18372\n\n[ci skip]","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/e56ab7769339aa57a29e9b60bdf8dfc65f26068e"},{"sha":"de40b87e615252a73ea5d6b6780aa7fbf2c1cf1f","author":{"email":"9ec3f7e571af843d78cc38eb86a69c0ea3091506@gmail.com","name":"Cristian Bica"},"message":"GlobalID::Identification has been mixed into AR not AM","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/de40b87e615252a73ea5d6b6780aa7fbf2c1cf1f"},{"sha":"34dc028e75137707c46f81e1db942dad6660fb31","author":{"email":"7d8f52fe2a5e13656d86fcf6ac2c742ec11f40b8@gmail.com","name":"Vipul A M"},"message":"Fixed spacing issues on code comments in ActiveJob Basics guide.\n\nBefore: http://take.ms/z39h2\nAfter: http://take.ms/Mo0G3","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/34dc028e75137707c46f81e1db942dad6660fb31"},{"sha":"29a2977af53685e434fd814d46c56b6766f34cd3","author":{"email":"67f0c624118110e81c0d7fa9a0d327533350ff32@gmail.com","name":"Andrew Vida"},"message":"Correct views mail method sends in API docs","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/29a2977af53685e434fd814d46c56b6766f34cd3"},{"sha":"855cca0662f6a82b1eb450135f9c679e75723311","author":{"email":"84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","name":"Rafael Mendonça França"},"message":"Merge pull request #18521 from andrewvida/master\n\nCorrect the views that the mail method sends in API docs.","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/855cca0662f6a82b1eb450135f9c679e75723311"},{"sha":"aa31d21f5f4fc4d679e74a60f9df9706da7de373","author":{"email":"d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","name":"Sean Griffin"},"message":"Don't default to YAML dumping when quoting values\n\nThis behavior exists only to support fixtures, so we should handle it\nthere. Leaving it in `#quote` can cause very subtle bugs to slip\nthrough, by things appearing to work when they should be blowing up\nloudly, such as #18385.","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/aa31d21f5f4fc4d679e74a60f9df9706da7de373"},{"sha":"9a21774d73ebb1eece5ef29d71de17147be99992","author":{"email":"d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","name":"Sean Griffin"},"message":"Go through normal where logic in destroy\n\nBuilding the Arel AST, and manipulating the relation manually like this\nis prone to errors and breakage as implementation details change from\nunderneath it.","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/9a21774d73ebb1eece5ef29d71de17147be99992"},{"sha":"df73d696f5a965b67c9f177bf4dd8d85921d0214","author":{"email":"d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","name":"Sean Griffin"},"message":"Go through normal where logic in destroy with locking\n\nBuilding the Arel AST, and manipulating the relation manually like this\nis prone to errors and breakage as implementation details change from\nunderneath it.","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/df73d696f5a965b67c9f177bf4dd8d85921d0214"},{"sha":"787e22bb491bd8c36db1e9734261c4ce02c5c5fd","author":{"email":"d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","name":"Sean Griffin"},"message":"Don't use the `_before_type_cast` version of attributes in the form\n\nWe should never be ignoring valuable information that the types may need\nto give us. The reason that it originally used `_before_type_cast` is\nunclear, but appears to date back long enough that the reasons may not\nbe relevant today. There is only one test that asserts that it uses the\nbefore type cast version, but it gives no context as to why and uses a\nmock which does not simulate the real world.\n\nFixes #18523.","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/787e22bb491bd8c36db1e9734261c4ce02c5c5fd"},{"sha":"99b6cf538145fb34c08f81a6fc495e7fbb0510ae","author":{"email":"d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","name":"Sean Griffin"},"message":"Revert \"Don't use the `_before_type_cast` version of attributes in the form\"\n\nThis reverts commit 787e22bb491bd8c36db1e9734261c4ce02c5c5fd.","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/99b6cf538145fb34c08f81a6fc495e7fbb0510ae"},{"sha":"b67990cf342fb1d8f9ecab532db7e5b884981d7d","author":{"email":"d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","name":"Sean Griffin"},"message":"Add tests with an explanation of why we're using `_before_type_cast`\n\nIf you entered incorrect input into a form (particularly with a\nnumericality validation), we should not replace what you typed in with\n`0`, since clicking submit a second time would essentially be the same\nas erroneously accepting the junk input as 0.","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/b67990cf342fb1d8f9ecab532db7e5b884981d7d"},{"sha":"d8e710410ea300ec4626250c0b35946cb52bc38c","author":{"email":"d7e19930cc1f42c2d0781f4d9e6f1fe5891bf9cf@thoughtbot.com","name":"Sean Griffin"},"message":"Only use the `_before_type_cast` in the form when from user input\n\nWhile we don't want to change the form input when validations fail,\nblindly using `_before_type_cast` will cause the input to display the\nwrong data for any type which does additional work on database values.","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/d8e710410ea300ec4626250c0b35946cb52bc38c"},{"sha":"3f96b6973b82ad17e443dd1d21be05996fb6fbf0","author":{"email":"6fa5945caf8e8f3cd65cd902d129ab2b0a35637e@gmail.com","name":"Vijay Dev"},"message":"Merge branch 'master' of github.com:rails/docrails","distinct":true,"url":"https://api.github.com/repos/eileencodes/rails/commits/3f96b6973b82ad17e443dd1d21be05996fb6fbf0"}]}