{"action":"created","comment":{"url":"https://api.github.com/repos/roboptim/roboptim-trajectory/pulls/comments/30953108","id":30953108,"diff_hunk":"@@ -231,6 +231,10 @@ namespace trajectory\n \n \twhile (!found)\n \t  {\n+\t   if (t == knots_[static_cast<size_t>(imax+1)]) //We are exactly at the end of the spline\n+\t   {\n+\t     return imax;\n+\t   }","path":"src/cubic-b-spline.cc","position":7,"original_position":7,"commit_id":"9a5e61bb361005a61328ec080b071cbae11c45db","original_commit_id":"9a5e61bb361005a61328ec080b071cbae11c45db","user":{"login":"bchretien","id":2742231,"avatar_url":"https://avatars.githubusercontent.com/u/2742231?v=3","gravatar_id":"","url":"https://api.github.com/users/bchretien","html_url":"https://github.com/bchretien","followers_url":"https://api.github.com/users/bchretien/followers","following_url":"https://api.github.com/users/bchretien/following{/other_user}","gists_url":"https://api.github.com/users/bchretien/gists{/gist_id}","starred_url":"https://api.github.com/users/bchretien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchretien/subscriptions","organizations_url":"https://api.github.com/users/bchretien/orgs","repos_url":"https://api.github.com/users/bchretien/repos","events_url":"https://api.github.com/users/bchretien/events{/privacy}","received_events_url":"https://api.github.com/users/bchretien/received_events","type":"User","site_admin":false},"body":"If the problem only concerns `t = t_max`, this check should not be in the inner `while` loop either, since this will be checked at every iteration of the dichotomy.","created_at":"2015-05-24T15:14:03Z","updated_at":"2015-05-24T15:14:03Z","html_url":"https://github.com/roboptim/roboptim-trajectory/pull/29#discussion_r30953108","pull_request_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/roboptim/roboptim-trajectory/pulls/comments/30953108"},"html":{"href":"https://github.com/roboptim/roboptim-trajectory/pull/29#discussion_r30953108"},"pull_request":{"href":"https://api.github.com/repos/roboptim/roboptim-trajectory/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/roboptim/roboptim-trajectory/pulls/29","id":36102324,"html_url":"https://github.com/roboptim/roboptim-trajectory/pull/29","diff_url":"https://github.com/roboptim/roboptim-trajectory/pull/29.diff","patch_url":"https://github.com/roboptim/roboptim-trajectory/pull/29.patch","issue_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/issues/29","number":29,"state":"open","locked":false,"title":"Fixed interval computing + tests to validate it","user":{"login":"fdarricau","id":11023095,"avatar_url":"https://avatars.githubusercontent.com/u/11023095?v=3","gravatar_id":"","url":"https://api.github.com/users/fdarricau","html_url":"https://github.com/fdarricau","followers_url":"https://api.github.com/users/fdarricau/followers","following_url":"https://api.github.com/users/fdarricau/following{/other_user}","gists_url":"https://api.github.com/users/fdarricau/gists{/gist_id}","starred_url":"https://api.github.com/users/fdarricau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdarricau/subscriptions","organizations_url":"https://api.github.com/users/fdarricau/orgs","repos_url":"https://api.github.com/users/fdarricau/repos","events_url":"https://api.github.com/users/fdarricau/events{/privacy}","received_events_url":"https://api.github.com/users/fdarricau/received_events","type":"User","site_admin":false},"body":"The loop in CubicBSpline::interval would never stop when t is on the end of the time interval.","created_at":"2015-05-24T12:56:59Z","updated_at":"2015-05-24T15:14:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dbc13e603407ff3cb4aa4776a0c76fe979df02e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/pulls/29/commits","review_comments_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/pulls/29/comments","review_comment_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/issues/29/comments","statuses_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/statuses/9a5e61bb361005a61328ec080b071cbae11c45db","head":{"label":"fdarricau:master","ref":"master","sha":"9a5e61bb361005a61328ec080b071cbae11c45db","user":{"login":"fdarricau","id":11023095,"avatar_url":"https://avatars.githubusercontent.com/u/11023095?v=3","gravatar_id":"","url":"https://api.github.com/users/fdarricau","html_url":"https://github.com/fdarricau","followers_url":"https://api.github.com/users/fdarricau/followers","following_url":"https://api.github.com/users/fdarricau/following{/other_user}","gists_url":"https://api.github.com/users/fdarricau/gists{/gist_id}","starred_url":"https://api.github.com/users/fdarricau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdarricau/subscriptions","organizations_url":"https://api.github.com/users/fdarricau/orgs","repos_url":"https://api.github.com/users/fdarricau/repos","events_url":"https://api.github.com/users/fdarricau/events{/privacy}","received_events_url":"https://api.github.com/users/fdarricau/received_events","type":"User","site_admin":false},"repo":{"id":31990542,"name":"roboptim-trajectory","full_name":"fdarricau/roboptim-trajectory","owner":{"login":"fdarricau","id":11023095,"avatar_url":"https://avatars.githubusercontent.com/u/11023095?v=3","gravatar_id":"","url":"https://api.github.com/users/fdarricau","html_url":"https://github.com/fdarricau","followers_url":"https://api.github.com/users/fdarricau/followers","following_url":"https://api.github.com/users/fdarricau/following{/other_user}","gists_url":"https://api.github.com/users/fdarricau/gists{/gist_id}","starred_url":"https://api.github.com/users/fdarricau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdarricau/subscriptions","organizations_url":"https://api.github.com/users/fdarricau/orgs","repos_url":"https://api.github.com/users/fdarricau/repos","events_url":"https://api.github.com/users/fdarricau/events{/privacy}","received_events_url":"https://api.github.com/users/fdarricau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fdarricau/roboptim-trajectory","description":"RobOptim Trajectory: trajectories, splines, and more.","fork":true,"url":"https://api.github.com/repos/fdarricau/roboptim-trajectory","forks_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/forks","keys_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/teams","hooks_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/hooks","issue_events_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/issues/events{/number}","events_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/events","assignees_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/assignees{/user}","branches_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/branches{/branch}","tags_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/tags","blobs_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/git/refs{/sha}","trees_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/statuses/{sha}","languages_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/languages","stargazers_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/stargazers","contributors_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/contributors","subscribers_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/subscribers","subscription_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/subscription","commits_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/commits{/sha}","git_commits_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/git/commits{/sha}","comments_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/comments{/number}","issue_comment_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/issues/comments{/number}","contents_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/contents/{+path}","compare_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/merges","archive_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/downloads","issues_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/issues{/number}","pulls_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/pulls{/number}","milestones_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/milestones{/number}","notifications_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/labels{/name}","releases_url":"https://api.github.com/repos/fdarricau/roboptim-trajectory/releases{/id}","created_at":"2015-03-11T01:00:02Z","updated_at":"2015-05-06T04:49:41Z","pushed_at":"2015-05-24T14:58:27Z","git_url":"git://github.com/fdarricau/roboptim-trajectory.git","ssh_url":"git@github.com:fdarricau/roboptim-trajectory.git","clone_url":"https://github.com/fdarricau/roboptim-trajectory.git","svn_url":"https://github.com/fdarricau/roboptim-trajectory","homepage":"http://www.roboptim.net","size":8187,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"roboptim:master","ref":"master","sha":"f16a6e4422628e26d2017121e484ffd43851affe","user":{"login":"roboptim","id":2247067,"avatar_url":"https://avatars.githubusercontent.com/u/2247067?v=3","gravatar_id":"","url":"https://api.github.com/users/roboptim","html_url":"https://github.com/roboptim","followers_url":"https://api.github.com/users/roboptim/followers","following_url":"https://api.github.com/users/roboptim/following{/other_user}","gists_url":"https://api.github.com/users/roboptim/gists{/gist_id}","starred_url":"https://api.github.com/users/roboptim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roboptim/subscriptions","organizations_url":"https://api.github.com/users/roboptim/orgs","repos_url":"https://api.github.com/users/roboptim/repos","events_url":"https://api.github.com/users/roboptim/events{/privacy}","received_events_url":"https://api.github.com/users/roboptim/received_events","type":"Organization","site_admin":false},"repo":{"id":890119,"name":"roboptim-trajectory","full_name":"roboptim/roboptim-trajectory","owner":{"login":"roboptim","id":2247067,"avatar_url":"https://avatars.githubusercontent.com/u/2247067?v=3","gravatar_id":"","url":"https://api.github.com/users/roboptim","html_url":"https://github.com/roboptim","followers_url":"https://api.github.com/users/roboptim/followers","following_url":"https://api.github.com/users/roboptim/following{/other_user}","gists_url":"https://api.github.com/users/roboptim/gists{/gist_id}","starred_url":"https://api.github.com/users/roboptim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roboptim/subscriptions","organizations_url":"https://api.github.com/users/roboptim/orgs","repos_url":"https://api.github.com/users/roboptim/repos","events_url":"https://api.github.com/users/roboptim/events{/privacy}","received_events_url":"https://api.github.com/users/roboptim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/roboptim/roboptim-trajectory","description":"RobOptim Trajectory: trajectories, splines, and more.","fork":false,"url":"https://api.github.com/repos/roboptim/roboptim-trajectory","forks_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/forks","keys_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/teams","hooks_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/hooks","issue_events_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/issues/events{/number}","events_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/events","assignees_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/assignees{/user}","branches_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/branches{/branch}","tags_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/tags","blobs_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/git/refs{/sha}","trees_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/statuses/{sha}","languages_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/languages","stargazers_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/stargazers","contributors_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/contributors","subscribers_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/subscribers","subscription_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/subscription","commits_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/commits{/sha}","git_commits_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/git/commits{/sha}","comments_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/comments{/number}","issue_comment_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/issues/comments{/number}","contents_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/contents/{+path}","compare_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/merges","archive_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/downloads","issues_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/issues{/number}","pulls_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/pulls{/number}","milestones_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/milestones{/number}","notifications_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/labels{/name}","releases_url":"https://api.github.com/repos/roboptim/roboptim-trajectory/releases{/id}","created_at":"2010-09-05T21:09:16Z","updated_at":"2015-05-06T05:39:11Z","pushed_at":"2015-05-24T14:58:27Z","git_url":"git://github.com/roboptim/roboptim-trajectory.git","ssh_url":"git@github.com:roboptim/roboptim-trajectory.git","clone_url":"https://github.com/roboptim/roboptim-trajectory.git","svn_url":"https://github.com/roboptim/roboptim-trajectory","homepage":"http://www.roboptim.net","size":9161,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/roboptim/roboptim-trajectory/pulls/29"},"html":{"href":"https://github.com/roboptim/roboptim-trajectory/pull/29"},"issue":{"href":"https://api.github.com/repos/roboptim/roboptim-trajectory/issues/29"},"comments":{"href":"https://api.github.com/repos/roboptim/roboptim-trajectory/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/roboptim/roboptim-trajectory/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/roboptim/roboptim-trajectory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/roboptim/roboptim-trajectory/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/roboptim/roboptim-trajectory/statuses/9a5e61bb361005a61328ec080b071cbae11c45db"}}}}