{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/slimmer/issues/134","labels_url":"https://api.github.com/repos/alphagov/slimmer/issues/134/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/slimmer/issues/134/comments","events_url":"https://api.github.com/repos/alphagov/slimmer/issues/134/events","html_url":"https://github.com/alphagov/slimmer/pull/134","id":97055026,"number":134,"title":"Run GOV.UK ruby linter as part of CI builds","user":{"login":"dsingleton","id":63201,"avatar_url":"https://avatars.githubusercontent.com/u/63201?v=3","gravatar_id":"","url":"https://api.github.com/users/dsingleton","html_url":"https://github.com/dsingleton","followers_url":"https://api.github.com/users/dsingleton/followers","following_url":"https://api.github.com/users/dsingleton/following{/other_user}","gists_url":"https://api.github.com/users/dsingleton/gists{/gist_id}","starred_url":"https://api.github.com/users/dsingleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsingleton/subscriptions","organizations_url":"https://api.github.com/users/dsingleton/orgs","repos_url":"https://api.github.com/users/dsingleton/repos","events_url":"https://api.github.com/users/dsingleton/events{/privacy}","received_events_url":"https://api.github.com/users/dsingleton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-24T13:38:39Z","updated_at":"2015-07-28T09:47:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/slimmer/pulls/134","html_url":"https://github.com/alphagov/slimmer/pull/134","diff_url":"https://github.com/alphagov/slimmer/pull/134.diff","patch_url":"https://github.com/alphagov/slimmer/pull/134.patch"},"body":"It's configured to only report on the diff of changes, not the whole repo.\r\n\r\nI've run it against the whole repo and there a reasonable amount of violations,\r\nand bulk fixing them is usually contentious, so i'm ignoring that for now.\r\n\r\nWith this linting in place at least nothing new will violate the style guide\r\nand hopefully this will mean computers can give the feedback on style issues,\r\nrather humans, which computers are better at and avoids humans having to give\r\nnitpick-y feedback.\r\n\r\nCC @boffbowsh who wrote the linting gem, and @edds, @alext and @jamiecobbett as people who've worked on slimmer.\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/alphagov/slimmer/issues/comments/125525596","html_url":"https://github.com/alphagov/slimmer/pull/134#issuecomment-125525596","issue_url":"https://api.github.com/repos/alphagov/slimmer/issues/134","id":125525596,"user":{"login":"tommyp","id":449004,"avatar_url":"https://avatars.githubusercontent.com/u/449004?v=3","gravatar_id":"","url":"https://api.github.com/users/tommyp","html_url":"https://github.com/tommyp","followers_url":"https://api.github.com/users/tommyp/followers","following_url":"https://api.github.com/users/tommyp/following{/other_user}","gists_url":"https://api.github.com/users/tommyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tommyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommyp/subscriptions","organizations_url":"https://api.github.com/users/tommyp/orgs","repos_url":"https://api.github.com/users/tommyp/repos","events_url":"https://api.github.com/users/tommyp/events{/privacy}","received_events_url":"https://api.github.com/users/tommyp/received_events","type":"User","site_admin":false},"created_at":"2015-07-28T09:47:32Z","updated_at":"2015-07-28T09:47:32Z","body":"I'm in favour. We should stick to the style guide going forward if we can."}}