{"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/duritong/puppet-sysctl/pulls/35","id":36581893,"html_url":"https://github.com/duritong/puppet-sysctl/pull/35","diff_url":"https://github.com/duritong/puppet-sysctl/pull/35.diff","patch_url":"https://github.com/duritong/puppet-sysctl/pull/35.patch","issue_url":"https://api.github.com/repos/duritong/puppet-sysctl/issues/35","number":35,"state":"closed","locked":false,"title":"Fix warning on Puppet 4","user":{"login":"smoeding","id":1493064,"avatar_url":"https://avatars.githubusercontent.com/u/1493064?v=3","gravatar_id":"","url":"https://api.github.com/users/smoeding","html_url":"https://github.com/smoeding","followers_url":"https://api.github.com/users/smoeding/followers","following_url":"https://api.github.com/users/smoeding/following{/other_user}","gists_url":"https://api.github.com/users/smoeding/gists{/gist_id}","starred_url":"https://api.github.com/users/smoeding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smoeding/subscriptions","organizations_url":"https://api.github.com/users/smoeding/orgs","repos_url":"https://api.github.com/users/smoeding/repos","events_url":"https://api.github.com/users/smoeding/events{/privacy}","received_events_url":"https://api.github.com/users/smoeding/received_events","type":"User","site_admin":false},"body":"The module causes the following warning message when used with Puppet 4:\r\n\r\n`Puppet.newtype is deprecated and will be removed in a future release. Use Puppet::Type.newtype instead.`\r\n\r\nThis patch fixes the warning. I left the remaining Ruby code unmodified to make the change obvious. But it is probably a \r\ngood idea to also adjust the code indentation when commiting this fix.\r\n\r\n","created_at":"2015-05-31T13:06:51Z","updated_at":"2015-06-05T11:21:21Z","closed_at":"2015-06-05T11:21:21Z","merged_at":"2015-06-05T11:21:21Z","merge_commit_sha":"53ad0d35e1be531877ca1c37aea0ff893f8acabf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/duritong/puppet-sysctl/pulls/35/commits","review_comments_url":"https://api.github.com/repos/duritong/puppet-sysctl/pulls/35/comments","review_comment_url":"https://api.github.com/repos/duritong/puppet-sysctl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/duritong/puppet-sysctl/issues/35/comments","statuses_url":"https://api.github.com/repos/duritong/puppet-sysctl/statuses/569e3c17e7e4f35d7ae038f8b8b49ad1d7c40871","head":{"label":"smoeding:stm/fix-type-puppet-4","ref":"stm/fix-type-puppet-4","sha":"569e3c17e7e4f35d7ae038f8b8b49ad1d7c40871","user":{"login":"smoeding","id":1493064,"avatar_url":"https://avatars.githubusercontent.com/u/1493064?v=3","gravatar_id":"","url":"https://api.github.com/users/smoeding","html_url":"https://github.com/smoeding","followers_url":"https://api.github.com/users/smoeding/followers","following_url":"https://api.github.com/users/smoeding/following{/other_user}","gists_url":"https://api.github.com/users/smoeding/gists{/gist_id}","starred_url":"https://api.github.com/users/smoeding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smoeding/subscriptions","organizations_url":"https://api.github.com/users/smoeding/orgs","repos_url":"https://api.github.com/users/smoeding/repos","events_url":"https://api.github.com/users/smoeding/events{/privacy}","received_events_url":"https://api.github.com/users/smoeding/received_events","type":"User","site_admin":false},"repo":{"id":36601344,"name":"puppet-sysctl","full_name":"smoeding/puppet-sysctl","owner":{"login":"smoeding","id":1493064,"avatar_url":"https://avatars.githubusercontent.com/u/1493064?v=3","gravatar_id":"","url":"https://api.github.com/users/smoeding","html_url":"https://github.com/smoeding","followers_url":"https://api.github.com/users/smoeding/followers","following_url":"https://api.github.com/users/smoeding/following{/other_user}","gists_url":"https://api.github.com/users/smoeding/gists{/gist_id}","starred_url":"https://api.github.com/users/smoeding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smoeding/subscriptions","organizations_url":"https://api.github.com/users/smoeding/orgs","repos_url":"https://api.github.com/users/smoeding/repos","events_url":"https://api.github.com/users/smoeding/events{/privacy}","received_events_url":"https://api.github.com/users/smoeding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smoeding/puppet-sysctl","description":"Puppet module to manage sysctl","fork":true,"url":"https://api.github.com/repos/smoeding/puppet-sysctl","forks_url":"https://api.github.com/repos/smoeding/puppet-sysctl/forks","keys_url":"https://api.github.com/repos/smoeding/puppet-sysctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smoeding/puppet-sysctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smoeding/puppet-sysctl/teams","hooks_url":"https://api.github.com/repos/smoeding/puppet-sysctl/hooks","issue_events_url":"https://api.github.com/repos/smoeding/puppet-sysctl/issues/events{/number}","events_url":"https://api.github.com/repos/smoeding/puppet-sysctl/events","assignees_url":"https://api.github.com/repos/smoeding/puppet-sysctl/assignees{/user}","branches_url":"https://api.github.com/repos/smoeding/puppet-sysctl/branches{/branch}","tags_url":"https://api.github.com/repos/smoeding/puppet-sysctl/tags","blobs_url":"https://api.github.com/repos/smoeding/puppet-sysctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smoeding/puppet-sysctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smoeding/puppet-sysctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/smoeding/puppet-sysctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smoeding/puppet-sysctl/statuses/{sha}","languages_url":"https://api.github.com/repos/smoeding/puppet-sysctl/languages","stargazers_url":"https://api.github.com/repos/smoeding/puppet-sysctl/stargazers","contributors_url":"https://api.github.com/repos/smoeding/puppet-sysctl/contributors","subscribers_url":"https://api.github.com/repos/smoeding/puppet-sysctl/subscribers","subscription_url":"https://api.github.com/repos/smoeding/puppet-sysctl/subscription","commits_url":"https://api.github.com/repos/smoeding/puppet-sysctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/smoeding/puppet-sysctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/smoeding/puppet-sysctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/smoeding/puppet-sysctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/smoeding/puppet-sysctl/contents/{+path}","compare_url":"https://api.github.com/repos/smoeding/puppet-sysctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smoeding/puppet-sysctl/merges","archive_url":"https://api.github.com/repos/smoeding/puppet-sysctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smoeding/puppet-sysctl/downloads","issues_url":"https://api.github.com/repos/smoeding/puppet-sysctl/issues{/number}","pulls_url":"https://api.github.com/repos/smoeding/puppet-sysctl/pulls{/number}","milestones_url":"https://api.github.com/repos/smoeding/puppet-sysctl/milestones{/number}","notifications_url":"https://api.github.com/repos/smoeding/puppet-sysctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smoeding/puppet-sysctl/labels{/name}","releases_url":"https://api.github.com/repos/smoeding/puppet-sysctl/releases{/id}","created_at":"2015-05-31T12:08:47Z","updated_at":"2015-05-31T12:08:49Z","pushed_at":"2015-05-31T13:01:30Z","git_url":"git://github.com/smoeding/puppet-sysctl.git","ssh_url":"git@github.com:smoeding/puppet-sysctl.git","clone_url":"https://github.com/smoeding/puppet-sysctl.git","svn_url":"https://github.com/smoeding/puppet-sysctl","homepage":"http://www.immerda.ch","size":129,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"duritong:master","ref":"master","sha":"34bbda79f60fdb05e30f8c49a2e6c081f75d869a","user":{"login":"duritong","id":9511,"avatar_url":"https://avatars.githubusercontent.com/u/9511?v=3","gravatar_id":"","url":"https://api.github.com/users/duritong","html_url":"https://github.com/duritong","followers_url":"https://api.github.com/users/duritong/followers","following_url":"https://api.github.com/users/duritong/following{/other_user}","gists_url":"https://api.github.com/users/duritong/gists{/gist_id}","starred_url":"https://api.github.com/users/duritong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duritong/subscriptions","organizations_url":"https://api.github.com/users/duritong/orgs","repos_url":"https://api.github.com/users/duritong/repos","events_url":"https://api.github.com/users/duritong/events{/privacy}","received_events_url":"https://api.github.com/users/duritong/received_events","type":"User","site_admin":false},"repo":{"id":28210,"name":"puppet-sysctl","full_name":"duritong/puppet-sysctl","owner":{"login":"duritong","id":9511,"avatar_url":"https://avatars.githubusercontent.com/u/9511?v=3","gravatar_id":"","url":"https://api.github.com/users/duritong","html_url":"https://github.com/duritong","followers_url":"https://api.github.com/users/duritong/followers","following_url":"https://api.github.com/users/duritong/following{/other_user}","gists_url":"https://api.github.com/users/duritong/gists{/gist_id}","starred_url":"https://api.github.com/users/duritong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duritong/subscriptions","organizations_url":"https://api.github.com/users/duritong/orgs","repos_url":"https://api.github.com/users/duritong/repos","events_url":"https://api.github.com/users/duritong/events{/privacy}","received_events_url":"https://api.github.com/users/duritong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/duritong/puppet-sysctl","description":"Puppet module to manage sysctl","fork":false,"url":"https://api.github.com/repos/duritong/puppet-sysctl","forks_url":"https://api.github.com/repos/duritong/puppet-sysctl/forks","keys_url":"https://api.github.com/repos/duritong/puppet-sysctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duritong/puppet-sysctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duritong/puppet-sysctl/teams","hooks_url":"https://api.github.com/repos/duritong/puppet-sysctl/hooks","issue_events_url":"https://api.github.com/repos/duritong/puppet-sysctl/issues/events{/number}","events_url":"https://api.github.com/repos/duritong/puppet-sysctl/events","assignees_url":"https://api.github.com/repos/duritong/puppet-sysctl/assignees{/user}","branches_url":"https://api.github.com/repos/duritong/puppet-sysctl/branches{/branch}","tags_url":"https://api.github.com/repos/duritong/puppet-sysctl/tags","blobs_url":"https://api.github.com/repos/duritong/puppet-sysctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duritong/puppet-sysctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duritong/puppet-sysctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/duritong/puppet-sysctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duritong/puppet-sysctl/statuses/{sha}","languages_url":"https://api.github.com/repos/duritong/puppet-sysctl/languages","stargazers_url":"https://api.github.com/repos/duritong/puppet-sysctl/stargazers","contributors_url":"https://api.github.com/repos/duritong/puppet-sysctl/contributors","subscribers_url":"https://api.github.com/repos/duritong/puppet-sysctl/subscribers","subscription_url":"https://api.github.com/repos/duritong/puppet-sysctl/subscription","commits_url":"https://api.github.com/repos/duritong/puppet-sysctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/duritong/puppet-sysctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/duritong/puppet-sysctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/duritong/puppet-sysctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/duritong/puppet-sysctl/contents/{+path}","compare_url":"https://api.github.com/repos/duritong/puppet-sysctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duritong/puppet-sysctl/merges","archive_url":"https://api.github.com/repos/duritong/puppet-sysctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duritong/puppet-sysctl/downloads","issues_url":"https://api.github.com/repos/duritong/puppet-sysctl/issues{/number}","pulls_url":"https://api.github.com/repos/duritong/puppet-sysctl/pulls{/number}","milestones_url":"https://api.github.com/repos/duritong/puppet-sysctl/milestones{/number}","notifications_url":"https://api.github.com/repos/duritong/puppet-sysctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duritong/puppet-sysctl/labels{/name}","releases_url":"https://api.github.com/repos/duritong/puppet-sysctl/releases{/id}","created_at":"2008-06-24T14:33:36Z","updated_at":"2015-03-22T13:10:00Z","pushed_at":"2015-06-05T11:21:21Z","git_url":"git://github.com/duritong/puppet-sysctl.git","ssh_url":"git@github.com:duritong/puppet-sysctl.git","clone_url":"https://github.com/duritong/puppet-sysctl.git","svn_url":"https://github.com/duritong/puppet-sysctl","homepage":"http://www.immerda.ch","size":471,"stargazers_count":64,"watchers_count":64,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":1,"forks":73,"open_issues":1,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/duritong/puppet-sysctl/pulls/35"},"html":{"href":"https://github.com/duritong/puppet-sysctl/pull/35"},"issue":{"href":"https://api.github.com/repos/duritong/puppet-sysctl/issues/35"},"comments":{"href":"https://api.github.com/repos/duritong/puppet-sysctl/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/duritong/puppet-sysctl/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/duritong/puppet-sysctl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/duritong/puppet-sysctl/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/duritong/puppet-sysctl/statuses/569e3c17e7e4f35d7ae038f8b8b49ad1d7c40871"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"duritong","id":9511,"avatar_url":"https://avatars.githubusercontent.com/u/9511?v=3","gravatar_id":"","url":"https://api.github.com/users/duritong","html_url":"https://github.com/duritong","followers_url":"https://api.github.com/users/duritong/followers","following_url":"https://api.github.com/users/duritong/following{/other_user}","gists_url":"https://api.github.com/users/duritong/gists{/gist_id}","starred_url":"https://api.github.com/users/duritong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duritong/subscriptions","organizations_url":"https://api.github.com/users/duritong/orgs","repos_url":"https://api.github.com/users/duritong/repos","events_url":"https://api.github.com/users/duritong/events{/privacy}","received_events_url":"https://api.github.com/users/duritong/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":3,"changed_files":1}}