{"action":"created","comment":{"url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/pulls/comments/36580226","id":36580226,"diff_hunk":"@@ -15,7 +15,8 @@\n     \"gulp-imagemin\": \"^2.2.1\",\n     \"gulp-load-plugins\": \"^0.10.0\",\n     \"gulp-minify-css\": \"^1.1.1\",\n-    \"gulp-minify-html\": \"^1.0.0\",<% if (includeSass) { %>\n+    \"gulp-minify-html\": \"^1.0.0\",\n+    \"gulp-rev-all\": \"^0.8.0\",<% if (includeSass) { %>","path":"app/templates/_package.json","position":6,"original_position":6,"commit_id":"d58254eaa3518a2daa1b859176e88a3592a45101","original_commit_id":"d58254eaa3518a2daa1b859176e88a3592a45101","user":{"login":"silvenon","id":471278,"avatar_url":"https://avatars.githubusercontent.com/u/471278?v=3","gravatar_id":"","url":"https://api.github.com/users/silvenon","html_url":"https://github.com/silvenon","followers_url":"https://api.github.com/users/silvenon/followers","following_url":"https://api.github.com/users/silvenon/following{/other_user}","gists_url":"https://api.github.com/users/silvenon/gists{/gist_id}","starred_url":"https://api.github.com/users/silvenon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silvenon/subscriptions","organizations_url":"https://api.github.com/users/silvenon/orgs","repos_url":"https://api.github.com/users/silvenon/repos","events_url":"https://api.github.com/users/silvenon/events{/privacy}","received_events_url":"https://api.github.com/users/silvenon/received_events","type":"User","site_admin":false},"body":"Asset revisioning is pretty complicated to set up with gulp, so I'm sad that they blacklisted it, but I guess composite plugins aren't best practice.","created_at":"2015-08-08T17:43:13Z","updated_at":"2015-08-08T17:43:13Z","html_url":"https://github.com/yeoman/generator-gulp-webapp/pull/360#discussion_r36580226","pull_request_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/pulls/360","_links":{"self":{"href":"https://api.github.com/repos/yeoman/generator-gulp-webapp/pulls/comments/36580226"},"html":{"href":"https://github.com/yeoman/generator-gulp-webapp/pull/360#discussion_r36580226"},"pull_request":{"href":"https://api.github.com/repos/yeoman/generator-gulp-webapp/pulls/360"}}},"pull_request":{"url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/pulls/360","id":41427945,"html_url":"https://github.com/yeoman/generator-gulp-webapp/pull/360","diff_url":"https://github.com/yeoman/generator-gulp-webapp/pull/360.diff","patch_url":"https://github.com/yeoman/generator-gulp-webapp/pull/360.patch","issue_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/issues/360","number":360,"state":"open","locked":false,"title":"Added improved revision functionality.","user":{"login":"hivre","id":9581049,"avatar_url":"https://avatars.githubusercontent.com/u/9581049?v=3","gravatar_id":"","url":"https://api.github.com/users/hivre","html_url":"https://github.com/hivre","followers_url":"https://api.github.com/users/hivre/followers","following_url":"https://api.github.com/users/hivre/following{/other_user}","gists_url":"https://api.github.com/users/hivre/gists{/gist_id}","starred_url":"https://api.github.com/users/hivre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hivre/subscriptions","organizations_url":"https://api.github.com/users/hivre/orgs","repos_url":"https://api.github.com/users/hivre/repos","events_url":"https://api.github.com/users/hivre/events{/privacy}","received_events_url":"https://api.github.com/users/hivre/received_events","type":"User","site_admin":false},"body":"**Quick Overview**\r\n1. new `constant` revAll to get all the options possible for revving\r\n2. extended the build task to perform revving\r\n3. all files ready for revving are moved to the .tmp directory\r\n4. rev-all searches in .tmp for files, revvs them and moves them to dist folder\r\n\r\n**Elaboration**\r\n\r\n**1. new `constant`**\r\nThe new version of rev-all (> 0.8) needs an instantiation. Furthermore, many more options have been added for customization. \r\nI thought of making a new revving task, which could be re-used (e.g for deployment), but per scenario a user probably wants different options, which means a new instantiation, and thus a new task.\r\nA constant is the neatest/most compact option from my perspective.\r\n\r\n**2. / 3. New build task & .tmp**\r\nObviously the build task needed to get extended, as we want to perform all other tasks before revving.\r\nThe current setup, contrary to the previous, follows the much discussed method of prepping everything into `.tmp`, and then getting the final files stored into `dist`. (see the other PR and issue for the discussion).\r\n* Each task that would store files into the `dist` folder, now does that solely in `.tmp`.\r\n* After all build-tasks are completed, `rev-all` goes over the files in `.tmp`, revvs them accordingly, and stores them in `dist`.\r\n* two major advantages:  1. Only final-ready-to-deploy files are in the `dist` folder. 2. no need for `rev-napkin` and the like to remove un-revved and pre-revved (thus temporary) files. \r\n\r\n**Side note**\r\nI normally test my changes on my own website, however, that is still using v.0.3 and \r\na. I don't know how to elgantly upgrade the generator inside that project\r\nb. it's 2.30am so not in the mood to figure that out right now.\r\n\r\nI tested this using the standard yeoman/generator webpages that come along with the generator. I don't expect anything weird to happen when I use this on a larger project (famous last words, lol)\r\n\r\nLooking at the amount of changes since the first RP I did, I would propose to close that one. Consensus was that this (all to `.tmp`, then to `dist`) was the best method anyway...","created_at":"2015-08-03T00:34:58Z","updated_at":"2015-08-08T17:43:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9500d025154c8237180037c6af2135dc467588b0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/pulls/360/commits","review_comments_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/pulls/360/comments","review_comment_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/issues/360/comments","statuses_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/statuses/d58254eaa3518a2daa1b859176e88a3592a45101","head":{"label":"hivre:clean-asset-revision","ref":"clean-asset-revision","sha":"d58254eaa3518a2daa1b859176e88a3592a45101","user":{"login":"hivre","id":9581049,"avatar_url":"https://avatars.githubusercontent.com/u/9581049?v=3","gravatar_id":"","url":"https://api.github.com/users/hivre","html_url":"https://github.com/hivre","followers_url":"https://api.github.com/users/hivre/followers","following_url":"https://api.github.com/users/hivre/following{/other_user}","gists_url":"https://api.github.com/users/hivre/gists{/gist_id}","starred_url":"https://api.github.com/users/hivre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hivre/subscriptions","organizations_url":"https://api.github.com/users/hivre/orgs","repos_url":"https://api.github.com/users/hivre/repos","events_url":"https://api.github.com/users/hivre/events{/privacy}","received_events_url":"https://api.github.com/users/hivre/received_events","type":"User","site_admin":false},"repo":{"id":32493134,"name":"generator-gulp-webapp","full_name":"hivre/generator-gulp-webapp","owner":{"login":"hivre","id":9581049,"avatar_url":"https://avatars.githubusercontent.com/u/9581049?v=3","gravatar_id":"","url":"https://api.github.com/users/hivre","html_url":"https://github.com/hivre","followers_url":"https://api.github.com/users/hivre/followers","following_url":"https://api.github.com/users/hivre/following{/other_user}","gists_url":"https://api.github.com/users/hivre/gists{/gist_id}","starred_url":"https://api.github.com/users/hivre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hivre/subscriptions","organizations_url":"https://api.github.com/users/hivre/orgs","repos_url":"https://api.github.com/users/hivre/repos","events_url":"https://api.github.com/users/hivre/events{/privacy}","received_events_url":"https://api.github.com/users/hivre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hivre/generator-gulp-webapp","description":"A gulp.js generator for modern webapps","fork":true,"url":"https://api.github.com/repos/hivre/generator-gulp-webapp","forks_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/forks","keys_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/teams","hooks_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/hooks","issue_events_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/events","assignees_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/tags","blobs_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/languages","stargazers_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/stargazers","contributors_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/contributors","subscribers_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/subscribers","subscription_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/subscription","commits_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/merges","archive_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/downloads","issues_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/labels{/name}","releases_url":"https://api.github.com/repos/hivre/generator-gulp-webapp/releases{/id}","created_at":"2015-03-19T01:04:51Z","updated_at":"2015-03-19T01:04:51Z","pushed_at":"2015-08-03T00:14:27Z","git_url":"git://github.com/hivre/generator-gulp-webapp.git","ssh_url":"git@github.com:hivre/generator-gulp-webapp.git","clone_url":"https://github.com/hivre/generator-gulp-webapp.git","svn_url":"https://github.com/hivre/generator-gulp-webapp","homepage":"","size":3489,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yeoman:master","ref":"master","sha":"813341ddb7d6ce65627fd0ad634b12c2deb4072a","user":{"login":"yeoman","id":1714870,"avatar_url":"https://avatars.githubusercontent.com/u/1714870?v=3","gravatar_id":"","url":"https://api.github.com/users/yeoman","html_url":"https://github.com/yeoman","followers_url":"https://api.github.com/users/yeoman/followers","following_url":"https://api.github.com/users/yeoman/following{/other_user}","gists_url":"https://api.github.com/users/yeoman/gists{/gist_id}","starred_url":"https://api.github.com/users/yeoman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeoman/subscriptions","organizations_url":"https://api.github.com/users/yeoman/orgs","repos_url":"https://api.github.com/users/yeoman/repos","events_url":"https://api.github.com/users/yeoman/events{/privacy}","received_events_url":"https://api.github.com/users/yeoman/received_events","type":"Organization","site_admin":false},"repo":{"id":16458672,"name":"generator-gulp-webapp","full_name":"yeoman/generator-gulp-webapp","owner":{"login":"yeoman","id":1714870,"avatar_url":"https://avatars.githubusercontent.com/u/1714870?v=3","gravatar_id":"","url":"https://api.github.com/users/yeoman","html_url":"https://github.com/yeoman","followers_url":"https://api.github.com/users/yeoman/followers","following_url":"https://api.github.com/users/yeoman/following{/other_user}","gists_url":"https://api.github.com/users/yeoman/gists{/gist_id}","starred_url":"https://api.github.com/users/yeoman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeoman/subscriptions","organizations_url":"https://api.github.com/users/yeoman/orgs","repos_url":"https://api.github.com/users/yeoman/repos","events_url":"https://api.github.com/users/yeoman/events{/privacy}","received_events_url":"https://api.github.com/users/yeoman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yeoman/generator-gulp-webapp","description":"A gulp.js generator for modern webapps","fork":false,"url":"https://api.github.com/repos/yeoman/generator-gulp-webapp","forks_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/forks","keys_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/teams","hooks_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/hooks","issue_events_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/events","assignees_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/tags","blobs_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/languages","stargazers_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/stargazers","contributors_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/contributors","subscribers_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/subscribers","subscription_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/subscription","commits_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/merges","archive_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/downloads","issues_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/labels{/name}","releases_url":"https://api.github.com/repos/yeoman/generator-gulp-webapp/releases{/id}","created_at":"2014-02-02T17:08:27Z","updated_at":"2015-08-08T06:23:31Z","pushed_at":"2015-08-03T00:34:58Z","git_url":"git://github.com/yeoman/generator-gulp-webapp.git","ssh_url":"git@github.com:yeoman/generator-gulp-webapp.git","clone_url":"https://github.com/yeoman/generator-gulp-webapp.git","svn_url":"https://github.com/yeoman/generator-gulp-webapp","homepage":"","size":4751,"stargazers_count":1525,"watchers_count":1525,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":313,"mirror_url":null,"open_issues_count":6,"forks":313,"open_issues":6,"watchers":1525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yeoman/generator-gulp-webapp/pulls/360"},"html":{"href":"https://github.com/yeoman/generator-gulp-webapp/pull/360"},"issue":{"href":"https://api.github.com/repos/yeoman/generator-gulp-webapp/issues/360"},"comments":{"href":"https://api.github.com/repos/yeoman/generator-gulp-webapp/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/yeoman/generator-gulp-webapp/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/yeoman/generator-gulp-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yeoman/generator-gulp-webapp/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/yeoman/generator-gulp-webapp/statuses/d58254eaa3518a2daa1b859176e88a3592a45101"}}}}