{"action":"closed","number":2867,"pull_request":{"url":"https://api.github.com/repos/deis/deis/pulls/2867","id":27049667,"html_url":"https://github.com/deis/deis/pull/2867","diff_url":"https://github.com/deis/deis/pull/2867.diff","patch_url":"https://github.com/deis/deis/pull/2867.patch","issue_url":"https://api.github.com/repos/deis/deis/issues/2867","number":2867,"state":"closed","locked":false,"title":"test(controller): add expected unit test failures for response codes","user":{"login":"bacongobbler","id":1360539,"avatar_url":"https://avatars.githubusercontent.com/u/1360539?v=3","gravatar_id":"","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"body":"When testing the security holes found recently (#2826), we found a few response\r\ncodes that were not what was to be expected. Adding test coverage around\r\nthis such that we can address these tests in future refactors.","created_at":"2015-01-08T18:42:12Z","updated_at":"2015-01-09T23:54:18Z","closed_at":"2015-01-09T23:54:18Z","merged_at":"2015-01-09T23:54:18Z","merge_commit_sha":"e6bf8c7e77fdf5135af9de2dc9bf57e18323e25e","assignee":{"login":"bacongobbler","id":1360539,"avatar_url":"https://avatars.githubusercontent.com/u/1360539?v=3","gravatar_id":"","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/deis/deis/milestones/34","labels_url":"https://api.github.com/repos/deis/deis/milestones/34/labels","id":898360,"number":34,"title":"v1.3","description":"","creator":{"login":"mboersma","id":73019,"avatar_url":"https://avatars.githubusercontent.com/u/73019?v=3","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":5,"state":"open","created_at":"2014-12-10T04:45:39Z","updated_at":"2015-01-09T23:54:18Z","due_on":"2015-02-03T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/deis/deis/pulls/2867/commits","review_comments_url":"https://api.github.com/repos/deis/deis/pulls/2867/comments","review_comment_url":"https://api.github.com/repos/deis/deis/pulls/comments/{number}","comments_url":"https://api.github.com/repos/deis/deis/issues/2867/comments","statuses_url":"https://api.github.com/repos/deis/deis/statuses/aa9bb8f4d9217495c2ca821244b0439f76d698d0","head":{"label":"bacongobbler:api-errorcodes","ref":"api-errorcodes","sha":"aa9bb8f4d9217495c2ca821244b0439f76d698d0","user":{"login":"bacongobbler","id":1360539,"avatar_url":"https://avatars.githubusercontent.com/u/1360539?v=3","gravatar_id":"","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"repo":{"id":22929148,"name":"deis","full_name":"bacongobbler/deis","owner":{"login":"bacongobbler","id":1360539,"avatar_url":"https://avatars.githubusercontent.com/u/1360539?v=3","gravatar_id":"","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bacongobbler/deis","description":"Your PaaS. Your Rules. ","fork":true,"url":"https://api.github.com/repos/bacongobbler/deis","forks_url":"https://api.github.com/repos/bacongobbler/deis/forks","keys_url":"https://api.github.com/repos/bacongobbler/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bacongobbler/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bacongobbler/deis/teams","hooks_url":"https://api.github.com/repos/bacongobbler/deis/hooks","issue_events_url":"https://api.github.com/repos/bacongobbler/deis/issues/events{/number}","events_url":"https://api.github.com/repos/bacongobbler/deis/events","assignees_url":"https://api.github.com/repos/bacongobbler/deis/assignees{/user}","branches_url":"https://api.github.com/repos/bacongobbler/deis/branches{/branch}","tags_url":"https://api.github.com/repos/bacongobbler/deis/tags","blobs_url":"https://api.github.com/repos/bacongobbler/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bacongobbler/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bacongobbler/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/bacongobbler/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bacongobbler/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/bacongobbler/deis/languages","stargazers_url":"https://api.github.com/repos/bacongobbler/deis/stargazers","contributors_url":"https://api.github.com/repos/bacongobbler/deis/contributors","subscribers_url":"https://api.github.com/repos/bacongobbler/deis/subscribers","subscription_url":"https://api.github.com/repos/bacongobbler/deis/subscription","commits_url":"https://api.github.com/repos/bacongobbler/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/bacongobbler/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/bacongobbler/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/bacongobbler/deis/issues/comments/{number}","contents_url":"https://api.github.com/repos/bacongobbler/deis/contents/{+path}","compare_url":"https://api.github.com/repos/bacongobbler/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bacongobbler/deis/merges","archive_url":"https://api.github.com/repos/bacongobbler/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bacongobbler/deis/downloads","issues_url":"https://api.github.com/repos/bacongobbler/deis/issues{/number}","pulls_url":"https://api.github.com/repos/bacongobbler/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/bacongobbler/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/bacongobbler/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bacongobbler/deis/labels{/name}","releases_url":"https://api.github.com/repos/bacongobbler/deis/releases{/id}","created_at":"2014-08-13T19:53:55Z","updated_at":"2015-01-06T23:24:28Z","pushed_at":"2015-01-09T01:11:36Z","git_url":"git://github.com/bacongobbler/deis.git","ssh_url":"git@github.com:bacongobbler/deis.git","clone_url":"https://github.com/bacongobbler/deis.git","svn_url":"https://github.com/bacongobbler/deis","homepage":"http://deis.io","size":16994,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"18cf1a99d333bde630f1bd3bad8029752d1799a9","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":11589713,"name":"deis","full_name":"deis/deis","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/deis","description":"Your PaaS. Your Rules. ","fork":false,"url":"https://api.github.com/repos/deis/deis","forks_url":"https://api.github.com/repos/deis/deis/forks","keys_url":"https://api.github.com/repos/deis/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/deis/teams","hooks_url":"https://api.github.com/repos/deis/deis/hooks","issue_events_url":"https://api.github.com/repos/deis/deis/issues/events{/number}","events_url":"https://api.github.com/repos/deis/deis/events","assignees_url":"https://api.github.com/repos/deis/deis/assignees{/user}","branches_url":"https://api.github.com/repos/deis/deis/branches{/branch}","tags_url":"https://api.github.com/repos/deis/deis/tags","blobs_url":"https://api.github.com/repos/deis/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/deis/languages","stargazers_url":"https://api.github.com/repos/deis/deis/stargazers","contributors_url":"https://api.github.com/repos/deis/deis/contributors","subscribers_url":"https://api.github.com/repos/deis/deis/subscribers","subscription_url":"https://api.github.com/repos/deis/deis/subscription","commits_url":"https://api.github.com/repos/deis/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/deis/issues/comments/{number}","contents_url":"https://api.github.com/repos/deis/deis/contents/{+path}","compare_url":"https://api.github.com/repos/deis/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/deis/merges","archive_url":"https://api.github.com/repos/deis/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/deis/downloads","issues_url":"https://api.github.com/repos/deis/deis/issues{/number}","pulls_url":"https://api.github.com/repos/deis/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/deis/labels{/name}","releases_url":"https://api.github.com/repos/deis/deis/releases{/id}","created_at":"2013-07-22T19:02:40Z","updated_at":"2015-01-09T23:48:23Z","pushed_at":"2015-01-09T23:54:18Z","git_url":"git://github.com/deis/deis.git","ssh_url":"git@github.com:deis/deis.git","clone_url":"https://github.com/deis/deis.git","svn_url":"https://github.com/deis/deis","homepage":"http://deis.io","size":31383,"stargazers_count":3628,"watchers_count":3628,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":497,"mirror_url":null,"open_issues_count":176,"forks":497,"open_issues":176,"watchers":3628,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/deis/pulls/2867"},"html":{"href":"https://github.com/deis/deis/pull/2867"},"issue":{"href":"https://api.github.com/repos/deis/deis/issues/2867"},"comments":{"href":"https://api.github.com/repos/deis/deis/issues/2867/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/deis/pulls/2867/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/deis/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/deis/deis/pulls/2867/commits"},"statuses":{"href":"https://api.github.com/repos/deis/deis/statuses/aa9bb8f4d9217495c2ca821244b0439f76d698d0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bacongobbler","id":1360539,"avatar_url":"https://avatars.githubusercontent.com/u/1360539?v=3","gravatar_id":"","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":33,"deletions":0,"changed_files":2}}