{"action":"created","comment":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/comments/45892390","id":45892390,"diff_hunk":"@@ -0,0 +1,15 @@\n+//  Created by Monte Hurd on 11/23/15.\n+//  Copyright (c) 2015 Wikimedia Foundation. Provided under MIT-style license; please copy and modify!\n+\n+#import \"UITableViewCell+WMFLayout.h\"\n+#import \"NSProcessInfo+WMFOperatingSystemVersionChecks.h\"\n+\n+@implementation UITableViewCell (WMFLayout)\n+\n+- (void)wmf_layoutIfNeededIfOperatingSystemVersionLessThan9_0_0 {\n+    if ([[NSProcessInfo processInfo] wmf_isOperatingSystemVersionLessThan9_0_0]) {\n+        [self layoutIfNeeded];","path":"Wikipedia/Categories/UITableViewCell+WMFLayout.m","position":11,"original_position":11,"commit_id":"7ea72564c5b0235fca9d6da5ca7c2587ee1087c4","original_commit_id":"7ea72564c5b0235fca9d6da5ca7c2587ee1087c4","user":{"login":"montehurd","id":3143487,"avatar_url":"https://avatars.githubusercontent.com/u/3143487?v=3","gravatar_id":"","url":"https://api.github.com/users/montehurd","html_url":"https://github.com/montehurd","followers_url":"https://api.github.com/users/montehurd/followers","following_url":"https://api.github.com/users/montehurd/following{/other_user}","gists_url":"https://api.github.com/users/montehurd/gists{/gist_id}","starred_url":"https://api.github.com/users/montehurd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montehurd/subscriptions","organizations_url":"https://api.github.com/users/montehurd/orgs","repos_url":"https://api.github.com/users/montehurd/repos","events_url":"https://api.github.com/users/montehurd/events{/privacy}","received_events_url":"https://api.github.com/users/montehurd/received_events","type":"User","site_admin":false},"body":"Hmm I wasn't sure about downside - they've changed something (subtle?) about how constraints are taken into account between 8 and 9, I think, given that these bugs don't happen in 9. I thought scoping the layoutIfNeeded to 8 would be super-safe... I'm fine with removing the version check if you guys are. One nice thing about leaving it in, though - we would be we'd be notified that it's ok to remove these when we drop 8... wmf_isOperatingSystemVersionLessThan9_0_0 has a `WMF_DEPRECATED_WHEN_DEPLOY_AT_LEAST_9` check.","created_at":"2015-11-25T17:04:39Z","updated_at":"2015-11-25T17:04:39Z","html_url":"https://github.com/wikimedia/wikipedia-ios/pull/278#discussion_r45892390","pull_request_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/278","_links":{"self":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/comments/45892390"},"html":{"href":"https://github.com/wikimedia/wikipedia-ios/pull/278#discussion_r45892390"},"pull_request":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/278"}}},"pull_request":{"url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/278","id":51599083,"html_url":"https://github.com/wikimedia/wikipedia-ios/pull/278","diff_url":"https://github.com/wikimedia/wikipedia-ios/pull/278.diff","patch_url":"https://github.com/wikimedia/wikipedia-ios/pull/278.patch","issue_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/278","number":278,"state":"open","locked":false,"title":"Fix for iOS8 cell layout bugs.","user":{"login":"montehurd","id":3143487,"avatar_url":"https://avatars.githubusercontent.com/u/3143487?v=3","gravatar_id":"","url":"https://api.github.com/users/montehurd","html_url":"https://github.com/montehurd","followers_url":"https://api.github.com/users/montehurd/followers","following_url":"https://api.github.com/users/montehurd/following{/other_user}","gists_url":"https://api.github.com/users/montehurd/gists{/gist_id}","starred_url":"https://api.github.com/users/montehurd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montehurd/subscriptions","organizations_url":"https://api.github.com/users/montehurd/orgs","repos_url":"https://api.github.com/users/montehurd/repos","events_url":"https://api.github.com/users/montehurd/events{/privacy}","received_events_url":"https://api.github.com/users/montehurd/received_events","type":"User","site_admin":false},"body":"See phab ticket for repro steps and more screenshots:\r\nhttps://phabricator.wikimedia.org/T119437\r\n\r\n**Before**\r\n<img width=\"487\" alt=\"screen shot 2015-11-23 at 2 45 24 pm\" src=\"https://cloud.githubusercontent.com/assets/3143487/11353838/8b289f10-91fb-11e5-9f35-31b400c96bd0.png\">\r\n<img width=\"487\" alt=\"screen shot 2015-11-23 at 3 51 52 pm\" src=\"https://cloud.githubusercontent.com/assets/3143487/11353839/8b29fc5c-91fb-11e5-855d-91ddb1e41e85.png\">\r\n\r\n\r\n**After**\r\n<img width=\"487\" alt=\"screen shot 2015-11-23 at 4 03 05 pm\" src=\"https://cloud.githubusercontent.com/assets/3143487/11353862/d53d1ba8-91fb-11e5-9411-29e372266a7e.png\">\r\n<img width=\"487\" alt=\"screen shot 2015-11-23 at 4 03 22 pm\" src=\"https://cloud.githubusercontent.com/assets/3143487/11353861/d4d897e6-91fb-11e5-8ab2-248b4a1c1455.png\">\r\n","created_at":"2015-11-24T00:00:08Z","updated_at":"2015-11-25T17:04:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70b4bc9936984af2767a2a81a1d14a363d4e6091","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/278/commits","review_comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/278/comments","review_comment_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/278/comments","statuses_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/statuses/7ea72564c5b0235fca9d6da5ca7c2587ee1087c4","head":{"label":"wikimedia:bug/T119437/iOS8-cell-layout-bug","ref":"bug/T119437/iOS8-cell-layout-bug","sha":"7ea72564c5b0235fca9d6da5ca7c2587ee1087c4","user":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":13863130,"name":"wikipedia-ios","full_name":"wikimedia/wikipedia-ios","owner":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/wikipedia-ios","description":"The official Wikipedia iOS client.","fork":false,"url":"https://api.github.com/repos/wikimedia/wikipedia-ios","forks_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/forks","keys_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/teams","hooks_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/events","assignees_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/tags","blobs_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/languages","stargazers_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/subscription","commits_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/merges","archive_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/downloads","issues_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/releases{/id}","created_at":"2013-10-25T14:36:56Z","updated_at":"2015-11-25T17:02:37Z","pushed_at":"2015-11-25T16:53:01Z","git_url":"git://github.com/wikimedia/wikipedia-ios.git","ssh_url":"git@github.com:wikimedia/wikipedia-ios.git","clone_url":"https://github.com/wikimedia/wikipedia-ios.git","svn_url":"https://github.com/wikimedia/wikipedia-ios","homepage":"https://www.mediawiki.org/wiki/Wikimedia_Apps","size":102022,"stargazers_count":465,"watchers_count":465,"language":"Objective-C","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":4,"forks":141,"open_issues":4,"watchers":465,"default_branch":"master"}},"base":{"label":"wikimedia:master","ref":"master","sha":"b18b8b7a6aa87bd8ebdabd4f069096ee58c19c0d","user":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":13863130,"name":"wikipedia-ios","full_name":"wikimedia/wikipedia-ios","owner":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/wikipedia-ios","description":"The official Wikipedia iOS client.","fork":false,"url":"https://api.github.com/repos/wikimedia/wikipedia-ios","forks_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/forks","keys_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/teams","hooks_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/events","assignees_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/tags","blobs_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/languages","stargazers_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/subscription","commits_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/merges","archive_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/downloads","issues_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/wikipedia-ios/releases{/id}","created_at":"2013-10-25T14:36:56Z","updated_at":"2015-11-25T17:02:37Z","pushed_at":"2015-11-25T16:53:01Z","git_url":"git://github.com/wikimedia/wikipedia-ios.git","ssh_url":"git@github.com:wikimedia/wikipedia-ios.git","clone_url":"https://github.com/wikimedia/wikipedia-ios.git","svn_url":"https://github.com/wikimedia/wikipedia-ios","homepage":"https://www.mediawiki.org/wiki/Wikimedia_Apps","size":102022,"stargazers_count":465,"watchers_count":465,"language":"Objective-C","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":4,"forks":141,"open_issues":4,"watchers":465,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/278"},"html":{"href":"https://github.com/wikimedia/wikipedia-ios/pull/278"},"issue":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/278"},"comments":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/wikimedia/wikipedia-ios/statuses/7ea72564c5b0235fca9d6da5ca7c2587ee1087c4"}}}}