{"action":"created","issue":{"url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/3041","labels_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/3041/labels{/name}","comments_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/3041/comments","events_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/3041/events","html_url":"https://github.com/Beep6581/RawTherapee/issues/3041","id":123903135,"number":3041,"title":"Windows XP 32 bits and multilangmgr.cc","user":{"login":"sguyader","id":13856378,"avatar_url":"https://avatars.githubusercontent.com/u/13856378?v=3","gravatar_id":"","url":"https://api.github.com/users/sguyader","html_url":"https://github.com/sguyader","followers_url":"https://api.github.com/users/sguyader/followers","following_url":"https://api.github.com/users/sguyader/following{/other_user}","gists_url":"https://api.github.com/users/sguyader/gists{/gist_id}","starred_url":"https://api.github.com/users/sguyader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sguyader/subscriptions","organizations_url":"https://api.github.com/users/sguyader/orgs","repos_url":"https://api.github.com/users/sguyader/repos","events_url":"https://api.github.com/users/sguyader/events{/privacy}","received_events_url":"https://api.github.com/users/sguyader/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-12-26T01:34:26Z","updated_at":"2015-12-26T20:35:24Z","closed_at":null,"body":"A user sent me a message regrading the error he encounters when trying my win32 builds on his Windows XP 32 bits machine. when trying to launch the program, he gets the following error message:\r\n\r\nhttp://imgur.com/zhC5Ryx\r\n\r\nI tried the patch by @adamreichold (issue #3028) but compilation failed with this error message (in fact instead of using the patch, I modified manually the multilangmgr.cc file accordingly, I hope I didn't introduce a mistake, otherwise if someone can tell me the commands to patch the file it would be great):\r\n\r\n\tC:/Rawtherapee-sources/rtrepo/rtgui/multilangmgr.cc: In member function 'Glib::ustring MultiLangMgr::getOSUserLanguage()':\r\n\tC:/Rawtherapee-sources/rtrepo/rtgui/multilangmgr.cc:151:14: error: expected primary-expression before 'langID'\r\n\t +       LCID langID = GetUserDefaultLCID();\r\n\t\t\t\t  ^\r\n\tC:/Rawtherapee-sources/rtrepo/rtgui/multilangmgr.cc:154:27: error: 'langID' was not declared in this scope\r\n\t\t\t if (GetLocaleInfo(langID, LOCALE_SNAME, langRFC, 64) != 0 && lstrlen(langRFC) >= 2) {\r\n\t\t\t\t\t\t\t   ^\r\n\trtgui/CMakeFiles/rth.dir/build.make:2022 : la recette pour la cible « rtgui/CMakeFiles/rth.dir/multilangmgr.cc.obj » a échouée\r\n\tmake[2]: *** [rtgui/CMakeFiles/rth.dir/multilangmgr.cc.obj] Erreur 1\r\n\tmake[2]: *** Attente des tâches non terminées....\r\n\tCMakeFiles/Makefile2:235 : la recette pour la cible « rtgui/CMakeFiles/rth.dir/all » a échouée\r\n\tmake[1]: *** [rtgui/CMakeFiles/rth.dir/all] Erreur 2\r\n\tMakefile:127 : la recette pour la cible « all » a échouée\r\n\tmake: *** [all] Erreur 2\r\n"},"comment":{"url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/comments/167360755","html_url":"https://github.com/Beep6581/RawTherapee/issues/3041#issuecomment-167360755","issue_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/3041","id":167360755,"user":{"login":"sguyader","id":13856378,"avatar_url":"https://avatars.githubusercontent.com/u/13856378?v=3","gravatar_id":"","url":"https://api.github.com/users/sguyader","html_url":"https://github.com/sguyader","followers_url":"https://api.github.com/users/sguyader/followers","following_url":"https://api.github.com/users/sguyader/following{/other_user}","gists_url":"https://api.github.com/users/sguyader/gists{/gist_id}","starred_url":"https://api.github.com/users/sguyader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sguyader/subscriptions","organizations_url":"https://api.github.com/users/sguyader/orgs","repos_url":"https://api.github.com/users/sguyader/repos","events_url":"https://api.github.com/users/sguyader/events{/privacy}","received_events_url":"https://api.github.com/users/sguyader/received_events","type":"User","site_admin":false},"created_at":"2015-12-26T20:35:24Z","updated_at":"2015-12-26T20:35:24Z","body":"Should I remove this flag for the win32 builds ?\nLe 26 déc. 2015 15:51, \"adamreichold\" <notifications@github.com> a écrit :\n\n> @Beep6581 <https://github.com/Beep6581> I don't think it matters and it\n> definitely should not have any impact of whether RT runs on Windows XP or\n> not. (Which is also what my testing using VM confirmed.)\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/Beep6581/RawTherapee/issues/3041#issuecomment-167356497>\n> .\n>\n"}}