{"action":"created","comment":{"url":"https://api.github.com/repos/servo/rust-core-foundation/pulls/comments/27360013","id":27360013,"diff_hunk":"@@ -101,10 +101,12 @@ impl TCFType<CFDictionaryRef> for CFDictionary {\n \n impl CFDictionary {\n     pub fn from_CFType_pairs(pairs: &[(CFType, CFType)]) -> CFDictionary {\n-        let (keys, values): (Vec<CFTypeRef>,Vec<CFTypeRef>) =\n-            pairs.iter()\n-            .map(|&(ref key, ref value)| (key.as_CFTypeRef(), value.as_CFTypeRef()))\n-            .unzip();\n+        let mut keys = Vec::with_capacity(pairs.len());\n+        let mut values = Vec::with_capacity(pairs.len());\n+        for &(ref key, ref value) in pairs {\n+            keys.push(key.as_CFTypeRef());\n+            values.push(value.as_CFTypeRef());\n+        }","path":"src/dictionary.rs","position":13,"original_position":13,"commit_id":"d77c639576368eb711c820af8e32019156cb917c","original_commit_id":"d77c639576368eb711c820af8e32019156cb917c","user":{"login":"bjz","id":695077,"avatar_url":"https://avatars.githubusercontent.com/u/695077?v=3","gravatar_id":"","url":"https://api.github.com/users/bjz","html_url":"https://github.com/bjz","followers_url":"https://api.github.com/users/bjz/followers","following_url":"https://api.github.com/users/bjz/following{/other_user}","gists_url":"https://api.github.com/users/bjz/gists{/gist_id}","starred_url":"https://api.github.com/users/bjz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjz/subscriptions","organizations_url":"https://api.github.com/users/bjz/orgs","repos_url":"https://api.github.com/users/bjz/repos","events_url":"https://api.github.com/users/bjz/events{/privacy}","received_events_url":"https://api.github.com/users/bjz/received_events","type":"User","site_admin":false},"body":"Why did you need to remove the iterator usages?","created_at":"2015-03-29T22:28:21Z","updated_at":"2015-03-29T22:28:21Z","html_url":"https://github.com/servo/rust-core-foundation/pull/60#discussion_r27360013","pull_request_url":"https://api.github.com/repos/servo/rust-core-foundation/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/servo/rust-core-foundation/pulls/comments/27360013"},"html":{"href":"https://github.com/servo/rust-core-foundation/pull/60#discussion_r27360013"},"pull_request":{"href":"https://api.github.com/repos/servo/rust-core-foundation/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/servo/rust-core-foundation/pulls/60","id":32170608,"html_url":"https://github.com/servo/rust-core-foundation/pull/60","diff_url":"https://github.com/servo/rust-core-foundation/pull/60.diff","patch_url":"https://github.com/servo/rust-core-foundation/pull/60.patch","issue_url":"https://api.github.com/repos/servo/rust-core-foundation/issues/60","number":60,"state":"open","locked":false,"title":"Update for stable Rust by removing the core feature","user":{"login":"SSheldon","id":478311,"avatar_url":"https://avatars.githubusercontent.com/u/478311?v=3","gravatar_id":"","url":"https://api.github.com/users/SSheldon","html_url":"https://github.com/SSheldon","followers_url":"https://api.github.com/users/SSheldon/followers","following_url":"https://api.github.com/users/SSheldon/following{/other_user}","gists_url":"https://api.github.com/users/SSheldon/gists{/gist_id}","starred_url":"https://api.github.com/users/SSheldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SSheldon/subscriptions","organizations_url":"https://api.github.com/users/SSheldon/orgs","repos_url":"https://api.github.com/users/SSheldon/repos","events_url":"https://api.github.com/users/SSheldon/events{/privacy}","received_events_url":"https://api.github.com/users/SSheldon/received_events","type":"User","site_admin":false},"body":"It'd be great for libraries that depend on this crate if it worked on stable Rust. With the beta approaching soon, the unstable and deprecated APIs this crate uses are:\r\n* `std::num::ToPrimitive` and `std::num::FromPrimitive`\r\n* `std::num::Int::max_value`\r\n* `std::iter::IteratorExt::unzip`\r\n* `std::str::Str::as_slice`\r\n\r\nThis pull request replaces uses of this functionality.\r\n\r\nThe changes to `CFNumber` are a breaking change, but I only found servo/rust-core-text and servo/rust-azure that would be impacted, and the fix is simple.\r\n\r\nThis change requires the stabilization in rust-lang/rust#23549.","created_at":"2015-03-28T20:24:41Z","updated_at":"2015-03-29T22:28:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a06a79609b895165aafad185b767aec9ab552559","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/servo/rust-core-foundation/pulls/60/commits","review_comments_url":"https://api.github.com/repos/servo/rust-core-foundation/pulls/60/comments","review_comment_url":"https://api.github.com/repos/servo/rust-core-foundation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/rust-core-foundation/issues/60/comments","statuses_url":"https://api.github.com/repos/servo/rust-core-foundation/statuses/d77c639576368eb711c820af8e32019156cb917c","head":{"label":"SSheldon:stable_rust","ref":"stable_rust","sha":"d77c639576368eb711c820af8e32019156cb917c","user":{"login":"SSheldon","id":478311,"avatar_url":"https://avatars.githubusercontent.com/u/478311?v=3","gravatar_id":"","url":"https://api.github.com/users/SSheldon","html_url":"https://github.com/SSheldon","followers_url":"https://api.github.com/users/SSheldon/followers","following_url":"https://api.github.com/users/SSheldon/following{/other_user}","gists_url":"https://api.github.com/users/SSheldon/gists{/gist_id}","starred_url":"https://api.github.com/users/SSheldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SSheldon/subscriptions","organizations_url":"https://api.github.com/users/SSheldon/orgs","repos_url":"https://api.github.com/users/SSheldon/repos","events_url":"https://api.github.com/users/SSheldon/events{/privacy}","received_events_url":"https://api.github.com/users/SSheldon/received_events","type":"User","site_admin":false},"repo":{"id":33048404,"name":"rust-core-foundation","full_name":"SSheldon/rust-core-foundation","owner":{"login":"SSheldon","id":478311,"avatar_url":"https://avatars.githubusercontent.com/u/478311?v=3","gravatar_id":"","url":"https://api.github.com/users/SSheldon","html_url":"https://github.com/SSheldon","followers_url":"https://api.github.com/users/SSheldon/followers","following_url":"https://api.github.com/users/SSheldon/following{/other_user}","gists_url":"https://api.github.com/users/SSheldon/gists{/gist_id}","starred_url":"https://api.github.com/users/SSheldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SSheldon/subscriptions","organizations_url":"https://api.github.com/users/SSheldon/orgs","repos_url":"https://api.github.com/users/SSheldon/repos","events_url":"https://api.github.com/users/SSheldon/events{/privacy}","received_events_url":"https://api.github.com/users/SSheldon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SSheldon/rust-core-foundation","description":"Rust bindings to the Core Foundation library on Mac OS X and iOS","fork":true,"url":"https://api.github.com/repos/SSheldon/rust-core-foundation","forks_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/forks","keys_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/teams","hooks_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/hooks","issue_events_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/events","assignees_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/tags","blobs_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/languages","stargazers_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/stargazers","contributors_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/contributors","subscribers_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/subscribers","subscription_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/subscription","commits_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/merges","archive_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/downloads","issues_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/labels{/name}","releases_url":"https://api.github.com/repos/SSheldon/rust-core-foundation/releases{/id}","created_at":"2015-03-28T20:07:57Z","updated_at":"2015-03-28T20:07:57Z","pushed_at":"2015-03-28T20:10:48Z","git_url":"git://github.com/SSheldon/rust-core-foundation.git","ssh_url":"git@github.com:SSheldon/rust-core-foundation.git","clone_url":"https://github.com/SSheldon/rust-core-foundation.git","svn_url":"https://github.com/SSheldon/rust-core-foundation","homepage":null,"size":317,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"c577bd64b0301fe926cf7b757b9852a1ce1d521d","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":5621513,"name":"rust-core-foundation","full_name":"servo/rust-core-foundation","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/rust-core-foundation","description":"Rust bindings to the Core Foundation library on Mac OS X and iOS","fork":false,"url":"https://api.github.com/repos/servo/rust-core-foundation","forks_url":"https://api.github.com/repos/servo/rust-core-foundation/forks","keys_url":"https://api.github.com/repos/servo/rust-core-foundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/rust-core-foundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/rust-core-foundation/teams","hooks_url":"https://api.github.com/repos/servo/rust-core-foundation/hooks","issue_events_url":"https://api.github.com/repos/servo/rust-core-foundation/issues/events{/number}","events_url":"https://api.github.com/repos/servo/rust-core-foundation/events","assignees_url":"https://api.github.com/repos/servo/rust-core-foundation/assignees{/user}","branches_url":"https://api.github.com/repos/servo/rust-core-foundation/branches{/branch}","tags_url":"https://api.github.com/repos/servo/rust-core-foundation/tags","blobs_url":"https://api.github.com/repos/servo/rust-core-foundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/rust-core-foundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/rust-core-foundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/rust-core-foundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/rust-core-foundation/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/rust-core-foundation/languages","stargazers_url":"https://api.github.com/repos/servo/rust-core-foundation/stargazers","contributors_url":"https://api.github.com/repos/servo/rust-core-foundation/contributors","subscribers_url":"https://api.github.com/repos/servo/rust-core-foundation/subscribers","subscription_url":"https://api.github.com/repos/servo/rust-core-foundation/subscription","commits_url":"https://api.github.com/repos/servo/rust-core-foundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/rust-core-foundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/rust-core-foundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/rust-core-foundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/rust-core-foundation/contents/{+path}","compare_url":"https://api.github.com/repos/servo/rust-core-foundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/rust-core-foundation/merges","archive_url":"https://api.github.com/repos/servo/rust-core-foundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/rust-core-foundation/downloads","issues_url":"https://api.github.com/repos/servo/rust-core-foundation/issues{/number}","pulls_url":"https://api.github.com/repos/servo/rust-core-foundation/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/rust-core-foundation/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/rust-core-foundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/rust-core-foundation/labels{/name}","releases_url":"https://api.github.com/repos/servo/rust-core-foundation/releases{/id}","created_at":"2012-08-30T21:58:23Z","updated_at":"2015-02-28T18:55:37Z","pushed_at":"2015-03-28T20:24:42Z","git_url":"git://github.com/servo/rust-core-foundation.git","ssh_url":"git@github.com:servo/rust-core-foundation.git","clone_url":"https://github.com/servo/rust-core-foundation.git","svn_url":"https://github.com/servo/rust-core-foundation","homepage":null,"size":837,"stargazers_count":10,"watchers_count":10,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":3,"forks":22,"open_issues":3,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/rust-core-foundation/pulls/60"},"html":{"href":"https://github.com/servo/rust-core-foundation/pull/60"},"issue":{"href":"https://api.github.com/repos/servo/rust-core-foundation/issues/60"},"comments":{"href":"https://api.github.com/repos/servo/rust-core-foundation/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/rust-core-foundation/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/rust-core-foundation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/rust-core-foundation/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/servo/rust-core-foundation/statuses/d77c639576368eb711c820af8e32019156cb917c"}}}}