{"action":"closed","number":27,"pull_request":{"url":"https://api.github.com/repos/desihub/desispec/pulls/27","id":34520858,"html_url":"https://github.com/desihub/desispec/pull/27","diff_url":"https://github.com/desihub/desispec/pull/27.diff","patch_url":"https://github.com/desihub/desispec/pull/27.patch","issue_url":"https://api.github.com/repos/desihub/desispec/issues/27","number":27,"state":"closed","locked":false,"title":"Allow various rsize","user":{"login":"sbailey","id":218471,"avatar_url":"https://avatars.githubusercontent.com/u/218471?v=3","gravatar_id":"","url":"https://api.github.com/users/sbailey","html_url":"https://github.com/sbailey","followers_url":"https://api.github.com/users/sbailey/followers","following_url":"https://api.github.com/users/sbailey/following{/other_user}","gists_url":"https://api.github.com/users/sbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/sbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbailey/subscriptions","organizations_url":"https://api.github.com/users/sbailey/orgs","repos_url":"https://api.github.com/users/sbailey/repos","events_url":"https://api.github.com/users/sbailey/events{/privacy}","received_events_url":"https://api.github.com/users/sbailey/received_events","type":"User","site_admin":false},"body":"@dkirkby please take a look at this.  Several fixes:\r\n\r\n  1. Explicitly check for even number of diagonals (bad) when initializing from a dense rectangular ndarray (thanks for comment on previous pull request)\r\n  2. Fixed unit test which wouldn't have caught that anyway\r\n  3. Fix check for odd ndiag when initializing from sparse array\r\n  4. raise ValueError instead of assertions or RuntimeErrors\r\n  5. Reformat comments to fit within 80 columns (admittedly unrelated to the bugs, but I'm old-school on 80 columns...)\r\n\r\n","created_at":"2015-05-01T04:29:52Z","updated_at":"2015-05-05T05:12:31Z","closed_at":"2015-05-05T05:12:30Z","merged_at":"2015-05-05T05:12:30Z","merge_commit_sha":"40e5586d027fbcc930b07f4003a374004cd36b9a","assignee":{"login":"dkirkby","id":185007,"avatar_url":"https://avatars.githubusercontent.com/u/185007?v=3","gravatar_id":"","url":"https://api.github.com/users/dkirkby","html_url":"https://github.com/dkirkby","followers_url":"https://api.github.com/users/dkirkby/followers","following_url":"https://api.github.com/users/dkirkby/following{/other_user}","gists_url":"https://api.github.com/users/dkirkby/gists{/gist_id}","starred_url":"https://api.github.com/users/dkirkby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkirkby/subscriptions","organizations_url":"https://api.github.com/users/dkirkby/orgs","repos_url":"https://api.github.com/users/dkirkby/repos","events_url":"https://api.github.com/users/dkirkby/events{/privacy}","received_events_url":"https://api.github.com/users/dkirkby/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/desihub/desispec/milestones/1","html_url":"https://github.com/desihub/desispec/milestones/Spring%20Cleaning%202015","labels_url":"https://api.github.com/repos/desihub/desispec/milestones/1/labels","id":1079325,"number":1,"title":"Spring Cleaning 2015","description":"Time for some code cleanup.","creator":{"login":"sbailey","id":218471,"avatar_url":"https://avatars.githubusercontent.com/u/218471?v=3","gravatar_id":"","url":"https://api.github.com/users/sbailey","html_url":"https://github.com/sbailey","followers_url":"https://api.github.com/users/sbailey/followers","following_url":"https://api.github.com/users/sbailey/following{/other_user}","gists_url":"https://api.github.com/users/sbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/sbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbailey/subscriptions","organizations_url":"https://api.github.com/users/sbailey/orgs","repos_url":"https://api.github.com/users/sbailey/repos","events_url":"https://api.github.com/users/sbailey/events{/privacy}","received_events_url":"https://api.github.com/users/sbailey/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":4,"state":"open","created_at":"2015-04-22T17:46:25Z","updated_at":"2015-05-05T05:12:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/desihub/desispec/pulls/27/commits","review_comments_url":"https://api.github.com/repos/desihub/desispec/pulls/27/comments","review_comment_url":"https://api.github.com/repos/desihub/desispec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/desihub/desispec/issues/27/comments","statuses_url":"https://api.github.com/repos/desihub/desispec/statuses/5079a37afeda22c3791d58153661918aa18deacd","head":{"label":"desihub:allow_various_Rsize","ref":"allow_various_Rsize","sha":"5079a37afeda22c3791d58153661918aa18deacd","user":{"login":"desihub","id":9540621,"avatar_url":"https://avatars.githubusercontent.com/u/9540621?v=3","gravatar_id":"","url":"https://api.github.com/users/desihub","html_url":"https://github.com/desihub","followers_url":"https://api.github.com/users/desihub/followers","following_url":"https://api.github.com/users/desihub/following{/other_user}","gists_url":"https://api.github.com/users/desihub/gists{/gist_id}","starred_url":"https://api.github.com/users/desihub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desihub/subscriptions","organizations_url":"https://api.github.com/users/desihub/orgs","repos_url":"https://api.github.com/users/desihub/repos","events_url":"https://api.github.com/users/desihub/events{/privacy}","received_events_url":"https://api.github.com/users/desihub/received_events","type":"Organization","site_admin":false},"repo":{"id":26142080,"name":"desispec","full_name":"desihub/desispec","owner":{"login":"desihub","id":9540621,"avatar_url":"https://avatars.githubusercontent.com/u/9540621?v=3","gravatar_id":"","url":"https://api.github.com/users/desihub","html_url":"https://github.com/desihub","followers_url":"https://api.github.com/users/desihub/followers","following_url":"https://api.github.com/users/desihub/following{/other_user}","gists_url":"https://api.github.com/users/desihub/gists{/gist_id}","starred_url":"https://api.github.com/users/desihub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desihub/subscriptions","organizations_url":"https://api.github.com/users/desihub/orgs","repos_url":"https://api.github.com/users/desihub/repos","events_url":"https://api.github.com/users/desihub/events{/privacy}","received_events_url":"https://api.github.com/users/desihub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/desihub/desispec","description":"DESI spectral pipeline","fork":false,"url":"https://api.github.com/repos/desihub/desispec","forks_url":"https://api.github.com/repos/desihub/desispec/forks","keys_url":"https://api.github.com/repos/desihub/desispec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/desihub/desispec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/desihub/desispec/teams","hooks_url":"https://api.github.com/repos/desihub/desispec/hooks","issue_events_url":"https://api.github.com/repos/desihub/desispec/issues/events{/number}","events_url":"https://api.github.com/repos/desihub/desispec/events","assignees_url":"https://api.github.com/repos/desihub/desispec/assignees{/user}","branches_url":"https://api.github.com/repos/desihub/desispec/branches{/branch}","tags_url":"https://api.github.com/repos/desihub/desispec/tags","blobs_url":"https://api.github.com/repos/desihub/desispec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/desihub/desispec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/desihub/desispec/git/refs{/sha}","trees_url":"https://api.github.com/repos/desihub/desispec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/desihub/desispec/statuses/{sha}","languages_url":"https://api.github.com/repos/desihub/desispec/languages","stargazers_url":"https://api.github.com/repos/desihub/desispec/stargazers","contributors_url":"https://api.github.com/repos/desihub/desispec/contributors","subscribers_url":"https://api.github.com/repos/desihub/desispec/subscribers","subscription_url":"https://api.github.com/repos/desihub/desispec/subscription","commits_url":"https://api.github.com/repos/desihub/desispec/commits{/sha}","git_commits_url":"https://api.github.com/repos/desihub/desispec/git/commits{/sha}","comments_url":"https://api.github.com/repos/desihub/desispec/comments{/number}","issue_comment_url":"https://api.github.com/repos/desihub/desispec/issues/comments{/number}","contents_url":"https://api.github.com/repos/desihub/desispec/contents/{+path}","compare_url":"https://api.github.com/repos/desihub/desispec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/desihub/desispec/merges","archive_url":"https://api.github.com/repos/desihub/desispec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/desihub/desispec/downloads","issues_url":"https://api.github.com/repos/desihub/desispec/issues{/number}","pulls_url":"https://api.github.com/repos/desihub/desispec/pulls{/number}","milestones_url":"https://api.github.com/repos/desihub/desispec/milestones{/number}","notifications_url":"https://api.github.com/repos/desihub/desispec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/desihub/desispec/labels{/name}","releases_url":"https://api.github.com/repos/desihub/desispec/releases{/id}","created_at":"2014-11-03T22:34:47Z","updated_at":"2015-05-04T04:43:11Z","pushed_at":"2015-05-05T05:12:30Z","git_url":"git://github.com/desihub/desispec.git","ssh_url":"git@github.com:desihub/desispec.git","clone_url":"https://github.com/desihub/desispec.git","svn_url":"https://github.com/desihub/desispec","homepage":null,"size":1505,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":9,"forks":2,"open_issues":9,"watchers":0,"default_branch":"master"}},"base":{"label":"desihub:master","ref":"master","sha":"1465f2ff411c290fb1bb4ae35373089e8f204b38","user":{"login":"desihub","id":9540621,"avatar_url":"https://avatars.githubusercontent.com/u/9540621?v=3","gravatar_id":"","url":"https://api.github.com/users/desihub","html_url":"https://github.com/desihub","followers_url":"https://api.github.com/users/desihub/followers","following_url":"https://api.github.com/users/desihub/following{/other_user}","gists_url":"https://api.github.com/users/desihub/gists{/gist_id}","starred_url":"https://api.github.com/users/desihub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desihub/subscriptions","organizations_url":"https://api.github.com/users/desihub/orgs","repos_url":"https://api.github.com/users/desihub/repos","events_url":"https://api.github.com/users/desihub/events{/privacy}","received_events_url":"https://api.github.com/users/desihub/received_events","type":"Organization","site_admin":false},"repo":{"id":26142080,"name":"desispec","full_name":"desihub/desispec","owner":{"login":"desihub","id":9540621,"avatar_url":"https://avatars.githubusercontent.com/u/9540621?v=3","gravatar_id":"","url":"https://api.github.com/users/desihub","html_url":"https://github.com/desihub","followers_url":"https://api.github.com/users/desihub/followers","following_url":"https://api.github.com/users/desihub/following{/other_user}","gists_url":"https://api.github.com/users/desihub/gists{/gist_id}","starred_url":"https://api.github.com/users/desihub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desihub/subscriptions","organizations_url":"https://api.github.com/users/desihub/orgs","repos_url":"https://api.github.com/users/desihub/repos","events_url":"https://api.github.com/users/desihub/events{/privacy}","received_events_url":"https://api.github.com/users/desihub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/desihub/desispec","description":"DESI spectral pipeline","fork":false,"url":"https://api.github.com/repos/desihub/desispec","forks_url":"https://api.github.com/repos/desihub/desispec/forks","keys_url":"https://api.github.com/repos/desihub/desispec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/desihub/desispec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/desihub/desispec/teams","hooks_url":"https://api.github.com/repos/desihub/desispec/hooks","issue_events_url":"https://api.github.com/repos/desihub/desispec/issues/events{/number}","events_url":"https://api.github.com/repos/desihub/desispec/events","assignees_url":"https://api.github.com/repos/desihub/desispec/assignees{/user}","branches_url":"https://api.github.com/repos/desihub/desispec/branches{/branch}","tags_url":"https://api.github.com/repos/desihub/desispec/tags","blobs_url":"https://api.github.com/repos/desihub/desispec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/desihub/desispec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/desihub/desispec/git/refs{/sha}","trees_url":"https://api.github.com/repos/desihub/desispec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/desihub/desispec/statuses/{sha}","languages_url":"https://api.github.com/repos/desihub/desispec/languages","stargazers_url":"https://api.github.com/repos/desihub/desispec/stargazers","contributors_url":"https://api.github.com/repos/desihub/desispec/contributors","subscribers_url":"https://api.github.com/repos/desihub/desispec/subscribers","subscription_url":"https://api.github.com/repos/desihub/desispec/subscription","commits_url":"https://api.github.com/repos/desihub/desispec/commits{/sha}","git_commits_url":"https://api.github.com/repos/desihub/desispec/git/commits{/sha}","comments_url":"https://api.github.com/repos/desihub/desispec/comments{/number}","issue_comment_url":"https://api.github.com/repos/desihub/desispec/issues/comments{/number}","contents_url":"https://api.github.com/repos/desihub/desispec/contents/{+path}","compare_url":"https://api.github.com/repos/desihub/desispec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/desihub/desispec/merges","archive_url":"https://api.github.com/repos/desihub/desispec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/desihub/desispec/downloads","issues_url":"https://api.github.com/repos/desihub/desispec/issues{/number}","pulls_url":"https://api.github.com/repos/desihub/desispec/pulls{/number}","milestones_url":"https://api.github.com/repos/desihub/desispec/milestones{/number}","notifications_url":"https://api.github.com/repos/desihub/desispec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/desihub/desispec/labels{/name}","releases_url":"https://api.github.com/repos/desihub/desispec/releases{/id}","created_at":"2014-11-03T22:34:47Z","updated_at":"2015-05-04T04:43:11Z","pushed_at":"2015-05-05T05:12:30Z","git_url":"git://github.com/desihub/desispec.git","ssh_url":"git@github.com:desihub/desispec.git","clone_url":"https://github.com/desihub/desispec.git","svn_url":"https://github.com/desihub/desispec","homepage":null,"size":1505,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":9,"forks":2,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/desihub/desispec/pulls/27"},"html":{"href":"https://github.com/desihub/desispec/pull/27"},"issue":{"href":"https://api.github.com/repos/desihub/desispec/issues/27"},"comments":{"href":"https://api.github.com/repos/desihub/desispec/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/desihub/desispec/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/desihub/desispec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/desihub/desispec/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/desihub/desispec/statuses/5079a37afeda22c3791d58153661918aa18deacd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sbailey","id":218471,"avatar_url":"https://avatars.githubusercontent.com/u/218471?v=3","gravatar_id":"","url":"https://api.github.com/users/sbailey","html_url":"https://github.com/sbailey","followers_url":"https://api.github.com/users/sbailey/followers","following_url":"https://api.github.com/users/sbailey/following{/other_user}","gists_url":"https://api.github.com/users/sbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/sbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbailey/subscriptions","organizations_url":"https://api.github.com/users/sbailey/orgs","repos_url":"https://api.github.com/users/sbailey/repos","events_url":"https://api.github.com/users/sbailey/events{/privacy}","received_events_url":"https://api.github.com/users/sbailey/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":30,"deletions":28,"changed_files":1}}