{"action":"created","comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/24422481","id":24422481,"diff_hunk":"@@ -63,10 +63,34 @@ defineSuite([\n         return returnTileJson('Data/CesiumTerrainTileJson/OctVertexNormals.tile.json');\n     }\n \n+    function returnWaterMaskTileJson() {\n+        return returnTileJson('Data/CesiumTerrainTileJson/WaterMask.tile.json');","path":"Specs/Core/CesiumTerrainProviderSpec.js","position":5,"original_position":5,"commit_id":"92fca3975c526fbf27dd4e85877e477282e5a41d","original_commit_id":"92fca3975c526fbf27dd4e85877e477282e5a41d","user":{"login":"pjcozzi","id":782098,"avatar_url":"https://avatars.githubusercontent.com/u/782098?v=3","gravatar_id":"","url":"https://api.github.com/users/pjcozzi","html_url":"https://github.com/pjcozzi","followers_url":"https://api.github.com/users/pjcozzi/followers","following_url":"https://api.github.com/users/pjcozzi/following{/other_user}","gists_url":"https://api.github.com/users/pjcozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/pjcozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjcozzi/subscriptions","organizations_url":"https://api.github.com/users/pjcozzi/orgs","repos_url":"https://api.github.com/users/pjcozzi/repos","events_url":"https://api.github.com/users/pjcozzi/events{/privacy}","received_events_url":"https://api.github.com/users/pjcozzi/received_events","type":"User","site_admin":false},"body":"Do we have tests for both cases: all water or land, and a mix?","created_at":"2015-02-10T15:54:47Z","updated_at":"2015-02-10T15:54:47Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2229#discussion_r24422481","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2229","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/24422481"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2229#discussion_r24422481"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2229"}}},"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2229","id":23418599,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2229","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2229.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2229.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/2229","number":2229,"state":"open","locked":false,"title":"Added support for loading a watermask for Quantized-Mesh terrain tiles.","user":{"login":"abwood","id":3868547,"avatar_url":"https://avatars.githubusercontent.com/u/3868547?v=3","gravatar_id":"","url":"https://api.github.com/users/abwood","html_url":"https://github.com/abwood","followers_url":"https://api.github.com/users/abwood/followers","following_url":"https://api.github.com/users/abwood/following{/other_user}","gists_url":"https://api.github.com/users/abwood/gists{/gist_id}","starred_url":"https://api.github.com/users/abwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abwood/subscriptions","organizations_url":"https://api.github.com/users/abwood/orgs","repos_url":"https://api.github.com/users/abwood/repos","events_url":"https://api.github.com/users/abwood/events{/privacy}","received_events_url":"https://api.github.com/users/abwood/received_events","type":"User","site_admin":false},"body":"These changes add support for the new quantized-mesh extension, watermask.  This extension is meant to be a drop-in replacement for the heightmap-1.0 terrain watermask, and shares the same format; 1 byte if all land/water, 64k mask for tiles with a mix of land and water.\r\n\r\nRelated changes to the Quantized-Mesh 1.0 spec:\r\nhttps://github.com/AnalyticalGraphicsInc/cesium-assets-list/pull/6\r\n\r\nUpdates to the Cesium Terrain Tutorial, to be reviewed and merged in after this PR:\r\nhttps://github.com/AnalyticalGraphicsInc/cesium-website/tree/terraintutorial-watermaskupdate\r\n\r\n02/02 - The world tileset is almost done processing and is expected to complete by Wednesday. For review, I've hosted the 90m version that includes the watermask on cesiumtest.  To view this tileset, you can pull down the following Sandcastle gist and place it in your Apps/Sandcastle/gallery directory.\r\n\r\nAlternatively, you can just put the following in Sandcastle yourself:\r\n```\r\nvar viewer = new Cesium.Viewer('cesiumContainer');\r\nvar terrainProvider = new Cesium.CesiumTerrainProvider({\r\n    url : '//cesiumtest.cloudapp.net/stk-terrain/srtm',\r\n    requestWaterMask: true\r\n});\r\nviewer.terrainProvider = terrainProvider;\r\n```","created_at":"2014-10-27T21:43:38Z","updated_at":"2015-02-10T15:54:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf95436035bf305b45aadab239b1fe2c7678824a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2229/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2229/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/{number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/2229/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/92fca3975c526fbf27dd4e85877e477282e5a41d","head":{"label":"abwood:quantizedMeshWaterMask","ref":"quantizedMeshWaterMask","sha":"92fca3975c526fbf27dd4e85877e477282e5a41d","user":{"login":"abwood","id":3868547,"avatar_url":"https://avatars.githubusercontent.com/u/3868547?v=3","gravatar_id":"","url":"https://api.github.com/users/abwood","html_url":"https://github.com/abwood","followers_url":"https://api.github.com/users/abwood/followers","following_url":"https://api.github.com/users/abwood/following{/other_user}","gists_url":"https://api.github.com/users/abwood/gists{/gist_id}","starred_url":"https://api.github.com/users/abwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abwood/subscriptions","organizations_url":"https://api.github.com/users/abwood/orgs","repos_url":"https://api.github.com/users/abwood/repos","events_url":"https://api.github.com/users/abwood/events{/privacy}","received_events_url":"https://api.github.com/users/abwood/received_events","type":"User","site_admin":false},"repo":{"id":8785187,"name":"cesium","full_name":"abwood/cesium","owner":{"login":"abwood","id":3868547,"avatar_url":"https://avatars.githubusercontent.com/u/3868547?v=3","gravatar_id":"","url":"https://api.github.com/users/abwood","html_url":"https://github.com/abwood","followers_url":"https://api.github.com/users/abwood/followers","following_url":"https://api.github.com/users/abwood/following{/other_user}","gists_url":"https://api.github.com/users/abwood/gists{/gist_id}","starred_url":"https://api.github.com/users/abwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abwood/subscriptions","organizations_url":"https://api.github.com/users/abwood/orgs","repos_url":"https://api.github.com/users/abwood/repos","events_url":"https://api.github.com/users/abwood/events{/privacy}","received_events_url":"https://api.github.com/users/abwood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abwood/cesium","description":"WebGL virtual globe and map engine","fork":true,"url":"https://api.github.com/repos/abwood/cesium","forks_url":"https://api.github.com/repos/abwood/cesium/forks","keys_url":"https://api.github.com/repos/abwood/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abwood/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abwood/cesium/teams","hooks_url":"https://api.github.com/repos/abwood/cesium/hooks","issue_events_url":"https://api.github.com/repos/abwood/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/abwood/cesium/events","assignees_url":"https://api.github.com/repos/abwood/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/abwood/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/abwood/cesium/tags","blobs_url":"https://api.github.com/repos/abwood/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abwood/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abwood/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/abwood/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abwood/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/abwood/cesium/languages","stargazers_url":"https://api.github.com/repos/abwood/cesium/stargazers","contributors_url":"https://api.github.com/repos/abwood/cesium/contributors","subscribers_url":"https://api.github.com/repos/abwood/cesium/subscribers","subscription_url":"https://api.github.com/repos/abwood/cesium/subscription","commits_url":"https://api.github.com/repos/abwood/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/abwood/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/abwood/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/abwood/cesium/issues/comments/{number}","contents_url":"https://api.github.com/repos/abwood/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/abwood/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abwood/cesium/merges","archive_url":"https://api.github.com/repos/abwood/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abwood/cesium/downloads","issues_url":"https://api.github.com/repos/abwood/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/abwood/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/abwood/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/abwood/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abwood/cesium/labels{/name}","releases_url":"https://api.github.com/repos/abwood/cesium/releases{/id}","created_at":"2013-03-14T20:54:36Z","updated_at":"2014-12-08T15:52:45Z","pushed_at":"2015-02-02T18:54:13Z","git_url":"git://github.com/abwood/cesium.git","ssh_url":"git@github.com:abwood/cesium.git","clone_url":"https://github.com/abwood/cesium.git","svn_url":"https://github.com/abwood/cesium","homepage":"http://cesium.agi.com/","size":223281,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:master","ref":"master","sha":"8c46dd89305c8fea6d4252fdee1846a24a7db5ff","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":3606738,"name":"cesium","full_name":"AnalyticalGraphicsInc/cesium","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium","description":"WebGL virtual globe and map engine","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments/{number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/releases{/id}","created_at":"2012-03-02T22:27:14Z","updated_at":"2015-02-10T14:49:45Z","pushed_at":"2015-02-10T14:49:44Z","git_url":"git://github.com/AnalyticalGraphicsInc/cesium.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/cesium.git","clone_url":"https://github.com/AnalyticalGraphicsInc/cesium.git","svn_url":"https://github.com/AnalyticalGraphicsInc/cesium","homepage":"cesiumjs.org","size":433568,"stargazers_count":692,"watchers_count":692,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":401,"mirror_url":null,"open_issues_count":260,"forks":401,"open_issues":260,"watchers":692,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2229"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2229"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/2229"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/2229/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2229/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2229/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/92fca3975c526fbf27dd4e85877e477282e5a41d"}}}}