{"action":"created","issue":{"url":"https://api.github.com/repos/mybb/mybb/issues/2096","labels_url":"https://api.github.com/repos/mybb/mybb/issues/2096/labels{/name}","comments_url":"https://api.github.com/repos/mybb/mybb/issues/2096/comments","events_url":"https://api.github.com/repos/mybb/mybb/issues/2096/events","html_url":"https://github.com/mybb/mybb/issues/2096","id":91510152,"number":2096,"title":"1.8 upgrade on page header javascript format error","user":{"login":"Destroy666x","id":3606072,"avatar_url":"https://avatars.githubusercontent.com/u/3606072?v=3","gravatar_id":"","url":"https://api.github.com/users/Destroy666x","html_url":"https://github.com/Destroy666x","followers_url":"https://api.github.com/users/Destroy666x/followers","following_url":"https://api.github.com/users/Destroy666x/following{/other_user}","gists_url":"https://api.github.com/users/Destroy666x/gists{/gist_id}","starred_url":"https://api.github.com/users/Destroy666x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Destroy666x/subscriptions","organizations_url":"https://api.github.com/users/Destroy666x/orgs","repos_url":"https://api.github.com/users/Destroy666x/repos","events_url":"https://api.github.com/users/Destroy666x/events{/privacy}","received_events_url":"https://api.github.com/users/Destroy666x/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mybb/mybb/labels/1.8","name":"1.8","color":"5319e7"},{"url":"https://api.github.com/repos/mybb/mybb/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/mybb/mybb/labels/s:confirmed","name":"s:confirmed","color":"006b75"}],"state":"open","locked":false,"assignee":{"login":"Destroy666x","id":3606072,"avatar_url":"https://avatars.githubusercontent.com/u/3606072?v=3","gravatar_id":"","url":"https://api.github.com/users/Destroy666x","html_url":"https://github.com/Destroy666x","followers_url":"https://api.github.com/users/Destroy666x/followers","following_url":"https://api.github.com/users/Destroy666x/following{/other_user}","gists_url":"https://api.github.com/users/Destroy666x/gists{/gist_id}","starred_url":"https://api.github.com/users/Destroy666x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Destroy666x/subscriptions","organizations_url":"https://api.github.com/users/Destroy666x/orgs","repos_url":"https://api.github.com/users/Destroy666x/repos","events_url":"https://api.github.com/users/Destroy666x/events{/privacy}","received_events_url":"https://api.github.com/users/Destroy666x/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mybb/mybb/milestones/11","html_url":"https://github.com/mybb/mybb/milestones/1.8.6","labels_url":"https://api.github.com/repos/mybb/mybb/milestones/11/labels","id":1026368,"number":11,"title":"1.8.6","description":"","creator":{"login":"Sama34","id":1786584,"avatar_url":"https://avatars.githubusercontent.com/u/1786584?v=3","gravatar_id":"","url":"https://api.github.com/users/Sama34","html_url":"https://github.com/Sama34","followers_url":"https://api.github.com/users/Sama34/followers","following_url":"https://api.github.com/users/Sama34/following{/other_user}","gists_url":"https://api.github.com/users/Sama34/gists{/gist_id}","starred_url":"https://api.github.com/users/Sama34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sama34/subscriptions","organizations_url":"https://api.github.com/users/Sama34/orgs","repos_url":"https://api.github.com/users/Sama34/repos","events_url":"https://api.github.com/users/Sama34/events{/privacy}","received_events_url":"https://api.github.com/users/Sama34/received_events","type":"User","site_admin":false},"open_issues":156,"closed_issues":23,"state":"open","created_at":"2015-03-17T23:25:48Z","updated_at":"2015-06-27T20:25:05Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-06-27T20:24:41Z","updated_at":"2015-06-27T20:26:44Z","closed_at":null,"body":"\nCode:\nline 39 column 35 - Error: document type does not allow element \"br\" here\n\nline 49 column 56 - Error: document type does not allow element \"img\" here\n\nI am validating the html page, the HTML validator is complaining about these\n\n\nCode:\n&nbsp;&nbsp;&nbsp;&nbsp;var loading_text = 'Loading. &lt;br /&gt;Please Wait..';\n&nbsp;&nbsp;&nbsp;&nbsp;var spinner_image = \"/_static/images/spinner.gif\";\n\nI see this can be fixed using the html comment inside javascript tags, however do you have any better recommendation?\n\nOriginal thread: [1.8 upgrade on page header javascript format error](http://community.mybb.com/thread-168823.html)"},"comment":{"url":"https://api.github.com/repos/mybb/mybb/issues/comments/116135443","html_url":"https://github.com/mybb/mybb/issues/2096#issuecomment-116135443","issue_url":"https://api.github.com/repos/mybb/mybb/issues/2096","id":116135443,"user":{"login":"Destroy666x","id":3606072,"avatar_url":"https://avatars.githubusercontent.com/u/3606072?v=3","gravatar_id":"","url":"https://api.github.com/users/Destroy666x","html_url":"https://github.com/Destroy666x","followers_url":"https://api.github.com/users/Destroy666x/followers","following_url":"https://api.github.com/users/Destroy666x/following{/other_user}","gists_url":"https://api.github.com/users/Destroy666x/gists{/gist_id}","starred_url":"https://api.github.com/users/Destroy666x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Destroy666x/subscriptions","organizations_url":"https://api.github.com/users/Destroy666x/orgs","repos_url":"https://api.github.com/users/Destroy666x/repos","events_url":"https://api.github.com/users/Destroy666x/events{/privacy}","received_events_url":"https://api.github.com/users/Destroy666x/received_events","type":"User","site_admin":false},"created_at":"2015-06-27T20:26:44Z","updated_at":"2015-06-27T20:26:44Z","body":"IIRC I removed the comment trick from one or two templates accidentally when testing something in one of my PRs anf forgot to add it back, the rest should be ok."}}