{"action":"closed","issue":{"url":"https://api.github.com/repos/openwrt/luci/issues/245","labels_url":"https://api.github.com/repos/openwrt/luci/issues/245/labels{/name}","comments_url":"https://api.github.com/repos/openwrt/luci/issues/245/comments","events_url":"https://api.github.com/repos/openwrt/luci/issues/245/events","html_url":"https://github.com/openwrt/luci/issues/245","id":47848524,"number":245,"title":"admin-full/.../iptables.html: firewall status page links to wrong interface if interface has @ alias","user":{"login":"hnyman","id":7926856,"avatar_url":"https://avatars.githubusercontent.com/u/7926856?v=3","gravatar_id":"","url":"https://api.github.com/users/hnyman","html_url":"https://github.com/hnyman","followers_url":"https://api.github.com/users/hnyman/followers","following_url":"https://api.github.com/users/hnyman/following{/other_user}","gists_url":"https://api.github.com/users/hnyman/gists{/gist_id}","starred_url":"https://api.github.com/users/hnyman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hnyman/subscriptions","organizations_url":"https://api.github.com/users/hnyman/orgs","repos_url":"https://api.github.com/users/hnyman/repos","events_url":"https://api.github.com/users/hnyman/events{/privacy}","received_events_url":"https://api.github.com/users/hnyman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2014-11-05T15:30:58Z","updated_at":"2015-08-31T09:02:04Z","closed_at":"2015-08-31T09:02:04Z","body":"The firewall status page (Status --> Firewall) shows the label for \"In\" and \"Out\" interfaces for the rules correctly, but in some cases the provided link functionality leads to the wrong interface.\r\n\r\nFor an interface without an @ alias, the link is correct.\r\nE.g. for \"br-lan\":  https://192.168.1.1/cgi-bin/luci/;stok=.../admin/network/network/lan\r\nfor \"eth1\":  https://192.168.1.2/cgi-bin/luci/;stok=.../admin/network/network/wan\r\n\r\nBut if there is an @ alias (like \"wan6\" by default is for eth1), the link leads to editing the @ interface, even if the rule concerns the main interface:\r\nfor eth1: https://192.168.1.1/cgi-bin/luci/;stok=.../admin/network/network/wan6\r\n\r\n![luci_interface_wrong](https://cloud.githubusercontent.com/assets/7926856/4920098/8c7238f6-64ff-11e4-924b-acd63cd22c03.png)\r\n\r\nAfaik, the table element is here:\r\nhttps://github.com/openwrt/luci/blob/master/modules/luci-mod-admin-full/luasrc/view/admin_status/iptables.htm#L132\r\n\r\nApparently the function link_iface (--> wba.iface_get_network --> iface_get_network) creates a link to the @ interface, not to the main interface. Probably the @ gets found first (or last?), as this behaviour seems consistent.\r\nhttps://github.com/openwrt/luci/blob/master/modules/luci-mod-admin-full/luasrc/view/admin_status/iptables.htm#L46\r\n\r\nhttps://github.com/openwrt/luci/blob/master/modules/luci-base/luasrc/tools/webadmin.lua#L155\r\n"}}