{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5265","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5265/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5265/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5265/events","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5265","id":60569849,"number":5265,"title":"kubelet post node status to master","user":{"login":"ddysher","id":2191361,"avatar_url":"https://avatars.githubusercontent.com/u/2191361?v=3","gravatar_id":"","url":"https://api.github.com/users/ddysher","html_url":"https://github.com/ddysher","followers_url":"https://api.github.com/users/ddysher/followers","following_url":"https://api.github.com/users/ddysher/following{/other_user}","gists_url":"https://api.github.com/users/ddysher/gists{/gist_id}","starred_url":"https://api.github.com/users/ddysher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddysher/subscriptions","organizations_url":"https://api.github.com/users/ddysher/orgs","repos_url":"https://api.github.com/users/ddysher/repos","events_url":"https://api.github.com/users/ddysher/events{/privacy}","received_events_url":"https://api.github.com/users/ddysher/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"ECF7EC"}],"state":"open","locked":false,"assignee":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"milestone":null,"comments":13,"created_at":"2015-03-10T21:09:31Z","updated_at":"2015-03-11T16:59:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5265","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5265","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5265.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5265.patch"},"body":"Post node status to master (currently only NodeStatus.Conditions).   This is disabled by default, nothing will be impacted; to enable posting, we need to: \r\n1. set `status_update_frequency` in Kubelet to non-zero\r\n2. set `sync_node_status` in NodeController to false\r\n\r\nIntegration test doesn't test new behaviors yet, to test it, we need to pass different params, as stated above. E.g.\r\n```\r\n1. kubeletapp.SimpleRunKubelet(cl, nil, &fakeDocker1, machineList[0], testRootDir, manifestURL, \"127.0.0.1\", 10250, api.NamespaceDefault, empty_dir.ProbeVolumePlugins(), nil, *2*)\r\n2. nodeController.Run(5*time.Second, true, *false*)\r\n```\r\nThings to consider: \r\n1. other node status field, mostly NodeAddress.\r\n2. issue like #5243 \r\n\r\nManually tested new behavior w/ integration test and e2e test, works prettly well."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/78306284","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5265#issuecomment-78306284","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5265","id":78306284,"user":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"created_at":"2015-03-11T16:59:21Z","updated_at":"2015-03-11T16:59:21Z","body":"Ok, I saw you made the change of moving NodeStatusUpdate logic out of the main syncloop. \r\nLGTM\r\n\r\nCan you run e2e tests before I merge it?\r\n\r\n"}}