{"action":"created","comment":{"url":"https://api.github.com/repos/spotify/luigi/pulls/comments/25134180","id":25134180,"diff_hunk":"@@ -18,6 +18,14 @@\n import signal\n import subprocess\n import io\n+import os\n+import re\n+import tempfile\n+\n+from luigi import six\n+\n+if six.PY3:\n+    unicode = str","path":"luigi/format.py","position":11,"original_position":11,"commit_id":"a935782902179b06b592c3a89f23d293fd1c35ae","original_commit_id":"a935782902179b06b592c3a89f23d293fd1c35ae","user":{"login":"berkerpeksag","id":26338,"avatar_url":"https://avatars.githubusercontent.com/u/26338?v=3","gravatar_id":"","url":"https://api.github.com/users/berkerpeksag","html_url":"https://github.com/berkerpeksag","followers_url":"https://api.github.com/users/berkerpeksag/followers","following_url":"https://api.github.com/users/berkerpeksag/following{/other_user}","gists_url":"https://api.github.com/users/berkerpeksag/gists{/gist_id}","starred_url":"https://api.github.com/users/berkerpeksag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berkerpeksag/subscriptions","organizations_url":"https://api.github.com/users/berkerpeksag/orgs","repos_url":"https://api.github.com/users/berkerpeksag/repos","events_url":"https://api.github.com/users/berkerpeksag/events{/privacy}","received_events_url":"https://api.github.com/users/berkerpeksag/received_events","type":"User","site_admin":false},"body":"this looks unused (you can also use `six.text_type`)","created_at":"2015-02-22T17:32:57Z","updated_at":"2015-02-22T17:32:57Z","html_url":"https://github.com/spotify/luigi/pull/769#discussion_r25134180","pull_request_url":"https://api.github.com/repos/spotify/luigi/pulls/769","_links":{"self":{"href":"https://api.github.com/repos/spotify/luigi/pulls/comments/25134180"},"html":{"href":"https://github.com/spotify/luigi/pull/769#discussion_r25134180"},"pull_request":{"href":"https://api.github.com/repos/spotify/luigi/pulls/769"}}},"pull_request":{"url":"https://api.github.com/repos/spotify/luigi/pulls/769","id":29770329,"html_url":"https://github.com/spotify/luigi/pull/769","diff_url":"https://github.com/spotify/luigi/pull/769.diff","patch_url":"https://github.com/spotify/luigi/pull/769.patch","issue_url":"https://api.github.com/repos/spotify/luigi/issues/769","number":769,"state":"open","locked":false,"title":"Hdfs support for python3","user":{"login":"gpoulin","id":4609807,"avatar_url":"https://avatars.githubusercontent.com/u/4609807?v=3","gravatar_id":"","url":"https://api.github.com/users/gpoulin","html_url":"https://github.com/gpoulin","followers_url":"https://api.github.com/users/gpoulin/followers","following_url":"https://api.github.com/users/gpoulin/following{/other_user}","gists_url":"https://api.github.com/users/gpoulin/gists{/gist_id}","starred_url":"https://api.github.com/users/gpoulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpoulin/subscriptions","organizations_url":"https://api.github.com/users/gpoulin/orgs","repos_url":"https://api.github.com/users/gpoulin/repos","events_url":"https://api.github.com/users/gpoulin/events{/privacy}","received_events_url":"https://api.github.com/users/gpoulin/received_events","type":"User","site_admin":false},"body":"This PR add a way for the format to explicitly declare the type of there input and output. The chaining of Format do a basic to ensure that the chaining is correct based on the types.\r\n\r\nThis PR also deprecate `luigi.format.Format.hdfs_reader` and `luigi.format.Format.hdfs_writer` in favor of Format chaining and explicit declaration of output type. `HdfsTarget` still verify for `hdfs_reader` and `hdfs_writer` and use them but would raise a deprecation warning.\r\n\r\nThis PR also include other minor fixes for python3.\r\n\r\nThis PR is based on #767 only the 2 last commits are different.\r\n\r\nWith this PR and spotify/snakebite#138, all hdfs test that doesn't necessitate SnakebiteClient are passing on python3.","created_at":"2015-02-22T13:25:28Z","updated_at":"2015-02-22T17:32:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6d7c12641ad9d9fcf07d0b8b909141b903c1bc9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spotify/luigi/pulls/769/commits","review_comments_url":"https://api.github.com/repos/spotify/luigi/pulls/769/comments","review_comment_url":"https://api.github.com/repos/spotify/luigi/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spotify/luigi/issues/769/comments","statuses_url":"https://api.github.com/repos/spotify/luigi/statuses/a935782902179b06b592c3a89f23d293fd1c35ae","head":{"label":"gpoulin:hdfs_py3k","ref":"hdfs_py3k","sha":"a935782902179b06b592c3a89f23d293fd1c35ae","user":{"login":"gpoulin","id":4609807,"avatar_url":"https://avatars.githubusercontent.com/u/4609807?v=3","gravatar_id":"","url":"https://api.github.com/users/gpoulin","html_url":"https://github.com/gpoulin","followers_url":"https://api.github.com/users/gpoulin/followers","following_url":"https://api.github.com/users/gpoulin/following{/other_user}","gists_url":"https://api.github.com/users/gpoulin/gists{/gist_id}","starred_url":"https://api.github.com/users/gpoulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpoulin/subscriptions","organizations_url":"https://api.github.com/users/gpoulin/orgs","repos_url":"https://api.github.com/users/gpoulin/repos","events_url":"https://api.github.com/users/gpoulin/events{/privacy}","received_events_url":"https://api.github.com/users/gpoulin/received_events","type":"User","site_admin":false},"repo":{"id":30570607,"name":"luigi","full_name":"gpoulin/luigi","owner":{"login":"gpoulin","id":4609807,"avatar_url":"https://avatars.githubusercontent.com/u/4609807?v=3","gravatar_id":"","url":"https://api.github.com/users/gpoulin","html_url":"https://github.com/gpoulin","followers_url":"https://api.github.com/users/gpoulin/followers","following_url":"https://api.github.com/users/gpoulin/following{/other_user}","gists_url":"https://api.github.com/users/gpoulin/gists{/gist_id}","starred_url":"https://api.github.com/users/gpoulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpoulin/subscriptions","organizations_url":"https://api.github.com/users/gpoulin/orgs","repos_url":"https://api.github.com/users/gpoulin/repos","events_url":"https://api.github.com/users/gpoulin/events{/privacy}","received_events_url":"https://api.github.com/users/gpoulin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gpoulin/luigi","description":"Luigi is a Python module that helps you build complex pipelines of batch jobs. It handles dependency resolution, workflow management, visualization etc. It also comes with Hadoop support built in. ","fork":true,"url":"https://api.github.com/repos/gpoulin/luigi","forks_url":"https://api.github.com/repos/gpoulin/luigi/forks","keys_url":"https://api.github.com/repos/gpoulin/luigi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gpoulin/luigi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gpoulin/luigi/teams","hooks_url":"https://api.github.com/repos/gpoulin/luigi/hooks","issue_events_url":"https://api.github.com/repos/gpoulin/luigi/issues/events{/number}","events_url":"https://api.github.com/repos/gpoulin/luigi/events","assignees_url":"https://api.github.com/repos/gpoulin/luigi/assignees{/user}","branches_url":"https://api.github.com/repos/gpoulin/luigi/branches{/branch}","tags_url":"https://api.github.com/repos/gpoulin/luigi/tags","blobs_url":"https://api.github.com/repos/gpoulin/luigi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gpoulin/luigi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gpoulin/luigi/git/refs{/sha}","trees_url":"https://api.github.com/repos/gpoulin/luigi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gpoulin/luigi/statuses/{sha}","languages_url":"https://api.github.com/repos/gpoulin/luigi/languages","stargazers_url":"https://api.github.com/repos/gpoulin/luigi/stargazers","contributors_url":"https://api.github.com/repos/gpoulin/luigi/contributors","subscribers_url":"https://api.github.com/repos/gpoulin/luigi/subscribers","subscription_url":"https://api.github.com/repos/gpoulin/luigi/subscription","commits_url":"https://api.github.com/repos/gpoulin/luigi/commits{/sha}","git_commits_url":"https://api.github.com/repos/gpoulin/luigi/git/commits{/sha}","comments_url":"https://api.github.com/repos/gpoulin/luigi/comments{/number}","issue_comment_url":"https://api.github.com/repos/gpoulin/luigi/issues/comments{/number}","contents_url":"https://api.github.com/repos/gpoulin/luigi/contents/{+path}","compare_url":"https://api.github.com/repos/gpoulin/luigi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gpoulin/luigi/merges","archive_url":"https://api.github.com/repos/gpoulin/luigi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gpoulin/luigi/downloads","issues_url":"https://api.github.com/repos/gpoulin/luigi/issues{/number}","pulls_url":"https://api.github.com/repos/gpoulin/luigi/pulls{/number}","milestones_url":"https://api.github.com/repos/gpoulin/luigi/milestones{/number}","notifications_url":"https://api.github.com/repos/gpoulin/luigi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gpoulin/luigi/labels{/name}","releases_url":"https://api.github.com/repos/gpoulin/luigi/releases{/id}","created_at":"2015-02-10T02:25:41Z","updated_at":"2015-02-22T11:03:03Z","pushed_at":"2015-02-22T15:46:40Z","git_url":"git://github.com/gpoulin/luigi.git","ssh_url":"git@github.com:gpoulin/luigi.git","clone_url":"https://github.com/gpoulin/luigi.git","svn_url":"https://github.com/gpoulin/luigi","homepage":null,"size":4366,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"f004c3527951fa53b95e504139a32d562f6efd6f","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":5888353,"name":"luigi","full_name":"spotify/luigi","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/luigi","description":"Luigi is a Python module that helps you build complex pipelines of batch jobs. It handles dependency resolution, workflow management, visualization etc. It also comes with Hadoop support built in. ","fork":false,"url":"https://api.github.com/repos/spotify/luigi","forks_url":"https://api.github.com/repos/spotify/luigi/forks","keys_url":"https://api.github.com/repos/spotify/luigi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/luigi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/luigi/teams","hooks_url":"https://api.github.com/repos/spotify/luigi/hooks","issue_events_url":"https://api.github.com/repos/spotify/luigi/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/luigi/events","assignees_url":"https://api.github.com/repos/spotify/luigi/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/luigi/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/luigi/tags","blobs_url":"https://api.github.com/repos/spotify/luigi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/luigi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/luigi/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/luigi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/luigi/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/luigi/languages","stargazers_url":"https://api.github.com/repos/spotify/luigi/stargazers","contributors_url":"https://api.github.com/repos/spotify/luigi/contributors","subscribers_url":"https://api.github.com/repos/spotify/luigi/subscribers","subscription_url":"https://api.github.com/repos/spotify/luigi/subscription","commits_url":"https://api.github.com/repos/spotify/luigi/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/luigi/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/luigi/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/luigi/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/luigi/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/luigi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/luigi/merges","archive_url":"https://api.github.com/repos/spotify/luigi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/luigi/downloads","issues_url":"https://api.github.com/repos/spotify/luigi/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/luigi/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/luigi/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/luigi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/luigi/labels{/name}","releases_url":"https://api.github.com/repos/spotify/luigi/releases{/id}","created_at":"2012-09-20T15:06:38Z","updated_at":"2015-02-22T11:33:49Z","pushed_at":"2015-02-22T09:39:18Z","git_url":"git://github.com/spotify/luigi.git","ssh_url":"git@github.com:spotify/luigi.git","clone_url":"https://github.com/spotify/luigi.git","svn_url":"https://github.com/spotify/luigi","homepage":null,"size":11241,"stargazers_count":2217,"watchers_count":2217,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":371,"mirror_url":null,"open_issues_count":78,"forks":371,"open_issues":78,"watchers":2217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/luigi/pulls/769"},"html":{"href":"https://github.com/spotify/luigi/pull/769"},"issue":{"href":"https://api.github.com/repos/spotify/luigi/issues/769"},"comments":{"href":"https://api.github.com/repos/spotify/luigi/issues/769/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/luigi/pulls/769/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/luigi/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spotify/luigi/pulls/769/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/luigi/statuses/a935782902179b06b592c3a89f23d293fd1c35ae"}}}}