{"action":"created","comment":{"url":"https://api.github.com/repos/gamechanger/dusty/pulls/comments/34198538","id":34198538,"diff_hunk":"@@ -37,7 +37,19 @@ def _validate_lib_references(lib, specs):\n     if not_present:\n         raise ValidationException('Libs {} are not present in your specs'.format(', '.join(not_present)))\n \n+def _check_name_overlap(specs):\n+    apps = set(specs['apps'].keys())\n+    libs = set(specs['libs'].keys())\n+    services = set(specs['services'].keys())\n+    app_service_overlap = apps.intersection(services)\n+    if app_service_overlap:\n+        raise ValidationException('Apps and services cannot share names: {}'.format(app_service_overlap))\n+    app_lib_overlap = apps.intersection(libs)\n+    if app_lib_overlap:\n+        raise ValidationException('Apps and libs cannot share names: {}'.format(apps_lib_overlap))","path":"dusty/commands/validate.py","position":13,"original_position":13,"commit_id":"74055c2da0a0661ebf353e41155ff370a493cd17","original_commit_id":"74055c2da0a0661ebf353e41155ff370a493cd17","user":{"login":"thieman","id":1414305,"avatar_url":"https://avatars.githubusercontent.com/u/1414305?v=3","gravatar_id":"","url":"https://api.github.com/users/thieman","html_url":"https://github.com/thieman","followers_url":"https://api.github.com/users/thieman/followers","following_url":"https://api.github.com/users/thieman/following{/other_user}","gists_url":"https://api.github.com/users/thieman/gists{/gist_id}","starred_url":"https://api.github.com/users/thieman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thieman/subscriptions","organizations_url":"https://api.github.com/users/thieman/orgs","repos_url":"https://api.github.com/users/thieman/repos","events_url":"https://api.github.com/users/thieman/events{/privacy}","received_events_url":"https://api.github.com/users/thieman/received_events","type":"User","site_admin":false},"body":"Don't we just want to make all names unique across all types of specs?","created_at":"2015-07-08T21:06:20Z","updated_at":"2015-07-08T21:06:20Z","html_url":"https://github.com/gamechanger/dusty/pull/376#discussion_r34198538","pull_request_url":"https://api.github.com/repos/gamechanger/dusty/pulls/376","_links":{"self":{"href":"https://api.github.com/repos/gamechanger/dusty/pulls/comments/34198538"},"html":{"href":"https://github.com/gamechanger/dusty/pull/376#discussion_r34198538"},"pull_request":{"href":"https://api.github.com/repos/gamechanger/dusty/pulls/376"}}},"pull_request":{"url":"https://api.github.com/repos/gamechanger/dusty/pulls/376","id":39523280,"html_url":"https://github.com/gamechanger/dusty/pull/376","diff_url":"https://github.com/gamechanger/dusty/pull/376.diff","patch_url":"https://github.com/gamechanger/dusty/pull/376.patch","issue_url":"https://api.github.com/repos/gamechanger/dusty/issues/376","number":376,"state":"open","locked":false,"title":"Js app service lib name unique","user":{"login":"jsingle","id":3680617,"avatar_url":"https://avatars.githubusercontent.com/u/3680617?v=3","gravatar_id":"","url":"https://api.github.com/users/jsingle","html_url":"https://github.com/jsingle","followers_url":"https://api.github.com/users/jsingle/followers","following_url":"https://api.github.com/users/jsingle/following{/other_user}","gists_url":"https://api.github.com/users/jsingle/gists{/gist_id}","starred_url":"https://api.github.com/users/jsingle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsingle/subscriptions","organizations_url":"https://api.github.com/users/jsingle/orgs","repos_url":"https://api.github.com/users/jsingle/repos","events_url":"https://api.github.com/users/jsingle/events{/privacy}","received_events_url":"https://api.github.com/users/jsingle/received_events","type":"User","site_admin":false},"body":"@thieman add validation to ensure that apps do not share the same name as services or libs","created_at":"2015-07-08T21:05:32Z","updated_at":"2015-07-08T21:06:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c36a086f9ef3b9eef9e973637b10c497e86206a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gamechanger/dusty/pulls/376/commits","review_comments_url":"https://api.github.com/repos/gamechanger/dusty/pulls/376/comments","review_comment_url":"https://api.github.com/repos/gamechanger/dusty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gamechanger/dusty/issues/376/comments","statuses_url":"https://api.github.com/repos/gamechanger/dusty/statuses/74055c2da0a0661ebf353e41155ff370a493cd17","head":{"label":"gamechanger:js-app-service-lib-name-unique","ref":"js-app-service-lib-name-unique","sha":"74055c2da0a0661ebf353e41155ff370a493cd17","user":{"login":"gamechanger","id":43876,"avatar_url":"https://avatars.githubusercontent.com/u/43876?v=3","gravatar_id":"","url":"https://api.github.com/users/gamechanger","html_url":"https://github.com/gamechanger","followers_url":"https://api.github.com/users/gamechanger/followers","following_url":"https://api.github.com/users/gamechanger/following{/other_user}","gists_url":"https://api.github.com/users/gamechanger/gists{/gist_id}","starred_url":"https://api.github.com/users/gamechanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamechanger/subscriptions","organizations_url":"https://api.github.com/users/gamechanger/orgs","repos_url":"https://api.github.com/users/gamechanger/repos","events_url":"https://api.github.com/users/gamechanger/events{/privacy}","received_events_url":"https://api.github.com/users/gamechanger/received_events","type":"Organization","site_admin":false},"repo":{"id":35429030,"name":"dusty","full_name":"gamechanger/dusty","owner":{"login":"gamechanger","id":43876,"avatar_url":"https://avatars.githubusercontent.com/u/43876?v=3","gravatar_id":"","url":"https://api.github.com/users/gamechanger","html_url":"https://github.com/gamechanger","followers_url":"https://api.github.com/users/gamechanger/followers","following_url":"https://api.github.com/users/gamechanger/following{/other_user}","gists_url":"https://api.github.com/users/gamechanger/gists{/gist_id}","starred_url":"https://api.github.com/users/gamechanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamechanger/subscriptions","organizations_url":"https://api.github.com/users/gamechanger/orgs","repos_url":"https://api.github.com/users/gamechanger/repos","events_url":"https://api.github.com/users/gamechanger/events{/privacy}","received_events_url":"https://api.github.com/users/gamechanger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gamechanger/dusty","description":"Docker-powered development environments","fork":false,"url":"https://api.github.com/repos/gamechanger/dusty","forks_url":"https://api.github.com/repos/gamechanger/dusty/forks","keys_url":"https://api.github.com/repos/gamechanger/dusty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gamechanger/dusty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gamechanger/dusty/teams","hooks_url":"https://api.github.com/repos/gamechanger/dusty/hooks","issue_events_url":"https://api.github.com/repos/gamechanger/dusty/issues/events{/number}","events_url":"https://api.github.com/repos/gamechanger/dusty/events","assignees_url":"https://api.github.com/repos/gamechanger/dusty/assignees{/user}","branches_url":"https://api.github.com/repos/gamechanger/dusty/branches{/branch}","tags_url":"https://api.github.com/repos/gamechanger/dusty/tags","blobs_url":"https://api.github.com/repos/gamechanger/dusty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gamechanger/dusty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gamechanger/dusty/git/refs{/sha}","trees_url":"https://api.github.com/repos/gamechanger/dusty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gamechanger/dusty/statuses/{sha}","languages_url":"https://api.github.com/repos/gamechanger/dusty/languages","stargazers_url":"https://api.github.com/repos/gamechanger/dusty/stargazers","contributors_url":"https://api.github.com/repos/gamechanger/dusty/contributors","subscribers_url":"https://api.github.com/repos/gamechanger/dusty/subscribers","subscription_url":"https://api.github.com/repos/gamechanger/dusty/subscription","commits_url":"https://api.github.com/repos/gamechanger/dusty/commits{/sha}","git_commits_url":"https://api.github.com/repos/gamechanger/dusty/git/commits{/sha}","comments_url":"https://api.github.com/repos/gamechanger/dusty/comments{/number}","issue_comment_url":"https://api.github.com/repos/gamechanger/dusty/issues/comments{/number}","contents_url":"https://api.github.com/repos/gamechanger/dusty/contents/{+path}","compare_url":"https://api.github.com/repos/gamechanger/dusty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gamechanger/dusty/merges","archive_url":"https://api.github.com/repos/gamechanger/dusty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gamechanger/dusty/downloads","issues_url":"https://api.github.com/repos/gamechanger/dusty/issues{/number}","pulls_url":"https://api.github.com/repos/gamechanger/dusty/pulls{/number}","milestones_url":"https://api.github.com/repos/gamechanger/dusty/milestones{/number}","notifications_url":"https://api.github.com/repos/gamechanger/dusty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gamechanger/dusty/labels{/name}","releases_url":"https://api.github.com/repos/gamechanger/dusty/releases{/id}","created_at":"2015-05-11T14:27:56Z","updated_at":"2015-07-08T15:55:14Z","pushed_at":"2015-07-08T21:05:32Z","git_url":"git://github.com/gamechanger/dusty.git","ssh_url":"git@github.com:gamechanger/dusty.git","clone_url":"https://github.com/gamechanger/dusty.git","svn_url":"https://github.com/gamechanger/dusty","homepage":"http://dusty.gc.com","size":13298,"stargazers_count":37,"watchers_count":37,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":37,"default_branch":"master"}},"base":{"label":"gamechanger:master","ref":"master","sha":"c0bbb8e9d0eb76124bc70410cc15dd32ce41c50b","user":{"login":"gamechanger","id":43876,"avatar_url":"https://avatars.githubusercontent.com/u/43876?v=3","gravatar_id":"","url":"https://api.github.com/users/gamechanger","html_url":"https://github.com/gamechanger","followers_url":"https://api.github.com/users/gamechanger/followers","following_url":"https://api.github.com/users/gamechanger/following{/other_user}","gists_url":"https://api.github.com/users/gamechanger/gists{/gist_id}","starred_url":"https://api.github.com/users/gamechanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamechanger/subscriptions","organizations_url":"https://api.github.com/users/gamechanger/orgs","repos_url":"https://api.github.com/users/gamechanger/repos","events_url":"https://api.github.com/users/gamechanger/events{/privacy}","received_events_url":"https://api.github.com/users/gamechanger/received_events","type":"Organization","site_admin":false},"repo":{"id":35429030,"name":"dusty","full_name":"gamechanger/dusty","owner":{"login":"gamechanger","id":43876,"avatar_url":"https://avatars.githubusercontent.com/u/43876?v=3","gravatar_id":"","url":"https://api.github.com/users/gamechanger","html_url":"https://github.com/gamechanger","followers_url":"https://api.github.com/users/gamechanger/followers","following_url":"https://api.github.com/users/gamechanger/following{/other_user}","gists_url":"https://api.github.com/users/gamechanger/gists{/gist_id}","starred_url":"https://api.github.com/users/gamechanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamechanger/subscriptions","organizations_url":"https://api.github.com/users/gamechanger/orgs","repos_url":"https://api.github.com/users/gamechanger/repos","events_url":"https://api.github.com/users/gamechanger/events{/privacy}","received_events_url":"https://api.github.com/users/gamechanger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gamechanger/dusty","description":"Docker-powered development environments","fork":false,"url":"https://api.github.com/repos/gamechanger/dusty","forks_url":"https://api.github.com/repos/gamechanger/dusty/forks","keys_url":"https://api.github.com/repos/gamechanger/dusty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gamechanger/dusty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gamechanger/dusty/teams","hooks_url":"https://api.github.com/repos/gamechanger/dusty/hooks","issue_events_url":"https://api.github.com/repos/gamechanger/dusty/issues/events{/number}","events_url":"https://api.github.com/repos/gamechanger/dusty/events","assignees_url":"https://api.github.com/repos/gamechanger/dusty/assignees{/user}","branches_url":"https://api.github.com/repos/gamechanger/dusty/branches{/branch}","tags_url":"https://api.github.com/repos/gamechanger/dusty/tags","blobs_url":"https://api.github.com/repos/gamechanger/dusty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gamechanger/dusty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gamechanger/dusty/git/refs{/sha}","trees_url":"https://api.github.com/repos/gamechanger/dusty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gamechanger/dusty/statuses/{sha}","languages_url":"https://api.github.com/repos/gamechanger/dusty/languages","stargazers_url":"https://api.github.com/repos/gamechanger/dusty/stargazers","contributors_url":"https://api.github.com/repos/gamechanger/dusty/contributors","subscribers_url":"https://api.github.com/repos/gamechanger/dusty/subscribers","subscription_url":"https://api.github.com/repos/gamechanger/dusty/subscription","commits_url":"https://api.github.com/repos/gamechanger/dusty/commits{/sha}","git_commits_url":"https://api.github.com/repos/gamechanger/dusty/git/commits{/sha}","comments_url":"https://api.github.com/repos/gamechanger/dusty/comments{/number}","issue_comment_url":"https://api.github.com/repos/gamechanger/dusty/issues/comments{/number}","contents_url":"https://api.github.com/repos/gamechanger/dusty/contents/{+path}","compare_url":"https://api.github.com/repos/gamechanger/dusty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gamechanger/dusty/merges","archive_url":"https://api.github.com/repos/gamechanger/dusty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gamechanger/dusty/downloads","issues_url":"https://api.github.com/repos/gamechanger/dusty/issues{/number}","pulls_url":"https://api.github.com/repos/gamechanger/dusty/pulls{/number}","milestones_url":"https://api.github.com/repos/gamechanger/dusty/milestones{/number}","notifications_url":"https://api.github.com/repos/gamechanger/dusty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gamechanger/dusty/labels{/name}","releases_url":"https://api.github.com/repos/gamechanger/dusty/releases{/id}","created_at":"2015-05-11T14:27:56Z","updated_at":"2015-07-08T15:55:14Z","pushed_at":"2015-07-08T21:05:32Z","git_url":"git://github.com/gamechanger/dusty.git","ssh_url":"git@github.com:gamechanger/dusty.git","clone_url":"https://github.com/gamechanger/dusty.git","svn_url":"https://github.com/gamechanger/dusty","homepage":"http://dusty.gc.com","size":13298,"stargazers_count":37,"watchers_count":37,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gamechanger/dusty/pulls/376"},"html":{"href":"https://github.com/gamechanger/dusty/pull/376"},"issue":{"href":"https://api.github.com/repos/gamechanger/dusty/issues/376"},"comments":{"href":"https://api.github.com/repos/gamechanger/dusty/issues/376/comments"},"review_comments":{"href":"https://api.github.com/repos/gamechanger/dusty/pulls/376/comments"},"review_comment":{"href":"https://api.github.com/repos/gamechanger/dusty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gamechanger/dusty/pulls/376/commits"},"statuses":{"href":"https://api.github.com/repos/gamechanger/dusty/statuses/74055c2da0a0661ebf353e41155ff370a493cd17"}}}}