{"action":"created","issue":{"url":"https://api.github.com/repos/tgstation/-tg-station/issues/12382","labels_url":"https://api.github.com/repos/tgstation/-tg-station/issues/12382/labels{/name}","comments_url":"https://api.github.com/repos/tgstation/-tg-station/issues/12382/comments","events_url":"https://api.github.com/repos/tgstation/-tg-station/issues/12382/events","html_url":"https://github.com/tgstation/-tg-station/issues/12382","id":111309346,"number":12382,"title":"Chem sprayer chems aren't actually applied to targets","user":{"login":"Shadowlight213","id":9410002,"avatar_url":"https://avatars.githubusercontent.com/u/9410002?v=3","gravatar_id":"","url":"https://api.github.com/users/Shadowlight213","html_url":"https://github.com/Shadowlight213","followers_url":"https://api.github.com/users/Shadowlight213/followers","following_url":"https://api.github.com/users/Shadowlight213/following{/other_user}","gists_url":"https://api.github.com/users/Shadowlight213/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowlight213/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowlight213/subscriptions","organizations_url":"https://api.github.com/users/Shadowlight213/orgs","repos_url":"https://api.github.com/users/Shadowlight213/repos","events_url":"https://api.github.com/users/Shadowlight213/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowlight213/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/tgstation/-tg-station/labels/Bug","name":"Bug","color":"d7e102"},{"url":"https://api.github.com/repos/tgstation/-tg-station/labels/Priority:%20High","name":"Priority: High","color":"B30E24"}],"state":"open","locked":false,"assignee":{"login":"phil235","id":3476142,"avatar_url":"https://avatars.githubusercontent.com/u/3476142?v=3","gravatar_id":"","url":"https://api.github.com/users/phil235","html_url":"https://github.com/phil235","followers_url":"https://api.github.com/users/phil235/followers","following_url":"https://api.github.com/users/phil235/following{/other_user}","gists_url":"https://api.github.com/users/phil235/gists{/gist_id}","starred_url":"https://api.github.com/users/phil235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil235/subscriptions","organizations_url":"https://api.github.com/users/phil235/orgs","repos_url":"https://api.github.com/users/phil235/repos","events_url":"https://api.github.com/users/phil235/events{/privacy}","received_events_url":"https://api.github.com/users/phil235/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-10-14T02:38:04Z","updated_at":"2015-10-15T15:50:27Z","closed_at":null,"body":"Spraying the chems doesn't actually seem to add them to the target's reageants. As such, all it seems to do is momentarily stun targets with no later ill effects."},"comment":{"url":"https://api.github.com/repos/tgstation/-tg-station/issues/comments/148429771","html_url":"https://github.com/tgstation/-tg-station/issues/12382#issuecomment-148429771","issue_url":"https://api.github.com/repos/tgstation/-tg-station/issues/12382","id":148429771,"user":{"login":"phil235","id":3476142,"avatar_url":"https://avatars.githubusercontent.com/u/3476142?v=3","gravatar_id":"","url":"https://api.github.com/users/phil235","html_url":"https://github.com/phil235","followers_url":"https://api.github.com/users/phil235/followers","following_url":"https://api.github.com/users/phil235/following{/other_user}","gists_url":"https://api.github.com/users/phil235/gists{/gist_id}","starred_url":"https://api.github.com/users/phil235/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil235/subscriptions","organizations_url":"https://api.github.com/users/phil235/orgs","repos_url":"https://api.github.com/users/phil235/repos","events_url":"https://api.github.com/users/phil235/events{/privacy}","received_events_url":"https://api.github.com/users/phil235/received_events","type":"User","site_admin":false},"created_at":"2015-10-15T15:50:27Z","updated_at":"2015-10-15T15:50:27Z","body":"Here's what actually happens: You click a target X tiles away from you, the spray puff created calls reaction() on each turf and mob it crosses with a reaction volume of \"the sprayer's tranfer amount setting\" divided by X. Then in the reaction proc, since it's we're using a spray, it calculates how much of the mob's body is covered in more or less permeable clothes, finally for the reagents without a specific reaction_mob() proc the default action is to inject a fraction of the spray puff volume into the mob, depending on said permeability, unless the amount is too insignificant.\r\n\r\nExample with the spray bottle set on 5u and filled with initropidril, aiming at a mob 3 tiles away with some clothes and a mask(permeability protection of 0.75). The mob is injected with 5*0.75/3=1.25u (which is barely above the current significance threshold of 1). If the mob had medical clothes, gloves and mask, he probably wouldn't have been injected with anything at all.\r\n\r\nThis is consistent and realistic. How can we expect 5units sprayed from 3 tiles away to have a big effect but splashing a 100u beaker not to do much?\r\n\r\nNow let's see the problem with the chemsprayer: it has 5 different reagents, which means 1u of each in a 5u puff. No wonder nothing is injected into the mob. It also has a greater potential range which means more dilution when aiming far.\r\n\r\nNow there's many things we can do to fix that:\r\n- give the chem sprayer (and emagged medbiorg acid spray) a greater default transfer amount.\r\n- Lower the significance threshold mentioned above to 0.1\r\n"}}