{"action":"created","issue":{"url":"https://api.github.com/repos/CounterpartyXCP/counterpartyd/issues/683","labels_url":"https://api.github.com/repos/CounterpartyXCP/counterpartyd/issues/683/labels{/name}","comments_url":"https://api.github.com/repos/CounterpartyXCP/counterpartyd/issues/683/comments","events_url":"https://api.github.com/repos/CounterpartyXCP/counterpartyd/issues/683/events","html_url":"https://github.com/CounterpartyXCP/counterpartyd/issues/683","id":56126159,"number":683,"title":"Get Rid of Signing and Broadcast Functionality?","user":{"login":"adamkrellenstein","id":6189829,"avatar_url":"https://avatars.githubusercontent.com/u/6189829?v=3","gravatar_id":"","url":"https://api.github.com/users/adamkrellenstein","html_url":"https://github.com/adamkrellenstein","followers_url":"https://api.github.com/users/adamkrellenstein/followers","following_url":"https://api.github.com/users/adamkrellenstein/following{/other_user}","gists_url":"https://api.github.com/users/adamkrellenstein/gists{/gist_id}","starred_url":"https://api.github.com/users/adamkrellenstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamkrellenstein/subscriptions","organizations_url":"https://api.github.com/users/adamkrellenstein/orgs","repos_url":"https://api.github.com/users/adamkrellenstein/repos","events_url":"https://api.github.com/users/adamkrellenstein/events{/privacy}","received_events_url":"https://api.github.com/users/adamkrellenstein/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/CounterpartyXCP/counterpartyd/labels/API","name":"API","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/CounterpartyXCP/counterpartyd/milestones/7","labels_url":"https://api.github.com/repos/CounterpartyXCP/counterpartyd/milestones/7/labels","id":944196,"number":7,"title":"v9.49.4","description":"","creator":{"login":"adamkrellenstein","id":6189829,"avatar_url":"https://avatars.githubusercontent.com/u/6189829?v=3","gravatar_id":"","url":"https://api.github.com/users/adamkrellenstein","html_url":"https://github.com/adamkrellenstein","followers_url":"https://api.github.com/users/adamkrellenstein/followers","following_url":"https://api.github.com/users/adamkrellenstein/following{/other_user}","gists_url":"https://api.github.com/users/adamkrellenstein/gists{/gist_id}","starred_url":"https://api.github.com/users/adamkrellenstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamkrellenstein/subscriptions","organizations_url":"https://api.github.com/users/adamkrellenstein/orgs","repos_url":"https://api.github.com/users/adamkrellenstein/repos","events_url":"https://api.github.com/users/adamkrellenstein/events{/privacy}","received_events_url":"https://api.github.com/users/adamkrellenstein/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":2,"state":"open","created_at":"2015-01-20T20:32:40Z","updated_at":"2015-01-31T22:08:57Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-01-31T14:14:20Z","updated_at":"2015-02-01T19:57:17Z","closed_at":null,"body":"Because `counterparty-lib` no longer connects to a wallet, all of the signing only works when you're passing the private key around (and even then it's only implemented with a horrible hack). Better would be to require people to sign with the wallet themselves (e.g. with `signrawtransaction`) and broadcast on their own, too.\r\n\r\nReally all of this should be in the CLI, anyway. I propose also getting rid of `transaction.sign_tx()`, `transaction.broadcast_tx()`, `api.sign_transaction()` and `api.do_*()`. (The functions from `transaction.py` can be moved to the CLI.)\r\n\r\nIf we don't do this, we need to restore manual signing functionality here: https://github.com/CounterpartyXCP/counterparty-cli/blob/develop/counterpartycli/client.py#L298\r\n\r\nThe procedure for using a wallet with `counterparty-lib` is documented here: https://github.com/CounterpartyXCP/Documentation/blob/master/Developers/API.md#wallet-integration\r\n\r\n* [ ] Update documentation, whatever we decide.\r\n\r\n<bountysource-plugin>\r\n\r\n---\r\nWant to back this issue? **[Place a bounty on it!](https://www.bountysource.com/issues/8181221-get-rid-of-do_-api-calls?utm_campaign=plugin&utm_content=tracker%2F494307&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F494307&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"},"comment":{"url":"https://api.github.com/repos/CounterpartyXCP/counterpartyd/issues/comments/72381010","html_url":"https://github.com/CounterpartyXCP/counterpartyd/issues/683#issuecomment-72381010","issue_url":"https://api.github.com/repos/CounterpartyXCP/counterpartyd/issues/683","id":72381010,"user":{"login":"robby-dermody","id":6189538,"avatar_url":"https://avatars.githubusercontent.com/u/6189538?v=3","gravatar_id":"","url":"https://api.github.com/users/robby-dermody","html_url":"https://github.com/robby-dermody","followers_url":"https://api.github.com/users/robby-dermody/followers","following_url":"https://api.github.com/users/robby-dermody/following{/other_user}","gists_url":"https://api.github.com/users/robby-dermody/gists{/gist_id}","starred_url":"https://api.github.com/users/robby-dermody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robby-dermody/subscriptions","organizations_url":"https://api.github.com/users/robby-dermody/orgs","repos_url":"https://api.github.com/users/robby-dermody/repos","events_url":"https://api.github.com/users/robby-dermody/events{/privacy}","received_events_url":"https://api.github.com/users/robby-dermody/received_events","type":"User","site_admin":false},"created_at":"2015-02-01T19:57:17Z","updated_at":"2015-02-01T19:57:17Z","body":"ok, with a few caveats:\r\n\r\n* signing functionality is implemented in the CLI, and easy to use\r\n* the API docs are updated to include an example of signing, maybe? there are so many language lib combos though, but possibly a jquery and bitcore example would be best, since a lot of the use is webapps\r\n* @ouziel-slama feels comfortable about making the necessary changes to counterwallet, and doesn't see this as an issue there"}}