{"action":"created","issue":{"url":"https://api.github.com/repos/liferay/liferay-faces/issues/462","labels_url":"https://api.github.com/repos/liferay/liferay-faces/issues/462/labels{/name}","comments_url":"https://api.github.com/repos/liferay/liferay-faces/issues/462/comments","events_url":"https://api.github.com/repos/liferay/liferay-faces/issues/462/events","html_url":"https://github.com/liferay/liferay-faces/pull/462","id":63671513,"number":462,"title":"Append \"\" instead of \"null\" when null is appended to StringBuilder.","user":{"login":"patrikbergstrom","id":11442322,"avatar_url":"https://avatars.githubusercontent.com/u/11442322?v=3","gravatar_id":"","url":"https://api.github.com/users/patrikbergstrom","html_url":"https://github.com/patrikbergstrom","followers_url":"https://api.github.com/users/patrikbergstrom/followers","following_url":"https://api.github.com/users/patrikbergstrom/following{/other_user}","gists_url":"https://api.github.com/users/patrikbergstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/patrikbergstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrikbergstrom/subscriptions","organizations_url":"https://api.github.com/users/patrikbergstrom/orgs","repos_url":"https://api.github.com/users/patrikbergstrom/repos","events_url":"https://api.github.com/users/patrikbergstrom/events{/privacy}","received_events_url":"https://api.github.com/users/patrikbergstrom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-23T09:10:32Z","updated_at":"2015-03-23T17:13:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/liferay/liferay-faces/pulls/462","html_url":"https://github.com/liferay/liferay-faces/pull/462","diff_url":"https://github.com/liferay/liferay-faces/pull/462.diff","patch_url":"https://github.com/liferay/liferay-faces/pull/462.patch"},"body":"Hi,\r\n\r\nI'm new to this type of collaboration and may not be aware of all conventions.\r\n\r\nThat said, I experienced a \"null\" string in my markup. To reproduce I inserted `<meta name=\"viewport\" content=\"width=device-width, user-scalable=no\"/>` inside my `<h:head>` element. I located the problematic code section and changed according to the commit and the \"null\" string disappeared.\r\n\r\nIn the Javadoc for the append method in StringBuilder one can read \"If str is null, then the four characters \"null\" are appended.\". I assume this is not what we want to be appended in those cases we have null content.\r\n\r\nCheers,\r\nPatrik\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/liferay/liferay-faces/issues/comments/85101086","html_url":"https://github.com/liferay/liferay-faces/pull/462#issuecomment-85101086","issue_url":"https://api.github.com/repos/liferay/liferay-faces/issues/462","id":85101086,"user":{"login":"ngriffin7a","id":989387,"avatar_url":"https://avatars.githubusercontent.com/u/989387?v=3","gravatar_id":"","url":"https://api.github.com/users/ngriffin7a","html_url":"https://github.com/ngriffin7a","followers_url":"https://api.github.com/users/ngriffin7a/followers","following_url":"https://api.github.com/users/ngriffin7a/following{/other_user}","gists_url":"https://api.github.com/users/ngriffin7a/gists{/gist_id}","starred_url":"https://api.github.com/users/ngriffin7a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngriffin7a/subscriptions","organizations_url":"https://api.github.com/users/ngriffin7a/orgs","repos_url":"https://api.github.com/users/ngriffin7a/repos","events_url":"https://api.github.com/users/ngriffin7a/events{/privacy}","received_events_url":"https://api.github.com/users/ngriffin7a/received_events","type":"User","site_admin":false},"created_at":"2015-03-23T17:13:12Z","updated_at":"2015-03-23T17:13:12Z","body":"@patrikbergstrom Hi Patrik, thanks so much for sending the pull request. I created https://issues.liferay.com/browse/FACES-2180 to track this issue to closure. In order for me to merge your pull request, I would need you to follow the instructions in the following Wiki article: http://www.liferay.com/community/wiki/-/wiki/Main/Contributing+to+Liferay+Faces\r\nThank you. Neil"}}