{"action":"created","issue":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5197","labels_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5197/labels{/name}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5197/comments","events_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5197/events","html_url":"https://github.com/D-Programming-Language/dmd/pull/5197","id":112017051,"number":5197,"title":"Cleanup dcast.d","user":{"login":"9rnsr","id":254394,"avatar_url":"https://avatars.githubusercontent.com/u/254394?v=3","gravatar_id":"","url":"https://api.github.com/users/9rnsr","html_url":"https://github.com/9rnsr","followers_url":"https://api.github.com/users/9rnsr/followers","following_url":"https://api.github.com/users/9rnsr/following{/other_user}","gists_url":"https://api.github.com/users/9rnsr/gists{/gist_id}","starred_url":"https://api.github.com/users/9rnsr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9rnsr/subscriptions","organizations_url":"https://api.github.com/users/9rnsr/orgs","repos_url":"https://api.github.com/users/9rnsr/repos","events_url":"https://api.github.com/users/9rnsr/events{/privacy}","received_events_url":"https://api.github.com/users/9rnsr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-10-18T12:36:26Z","updated_at":"2015-10-22T15:35:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/5197","html_url":"https://github.com/D-Programming-Language/dmd/pull/5197","diff_url":"https://github.com/D-Programming-Language/dmd/pull/5197.diff","patch_url":"https://github.com/D-Programming-Language/dmd/pull/5197.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/comments/150264807","html_url":"https://github.com/D-Programming-Language/dmd/pull/5197#issuecomment-150264807","issue_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/5197","id":150264807,"user":{"login":"9rnsr","id":254394,"avatar_url":"https://avatars.githubusercontent.com/u/254394?v=3","gravatar_id":"","url":"https://api.github.com/users/9rnsr","html_url":"https://github.com/9rnsr","followers_url":"https://api.github.com/users/9rnsr/followers","following_url":"https://api.github.com/users/9rnsr/following{/other_user}","gists_url":"https://api.github.com/users/9rnsr/gists{/gist_id}","starred_url":"https://api.github.com/users/9rnsr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9rnsr/subscriptions","organizations_url":"https://api.github.com/users/9rnsr/orgs","repos_url":"https://api.github.com/users/9rnsr/repos","events_url":"https://api.github.com/users/9rnsr/events{/privacy}","received_events_url":"https://api.github.com/users/9rnsr/received_events","type":"User","site_admin":false},"created_at":"2015-10-22T15:35:49Z","updated_at":"2015-10-22T15:35:49Z","body":"Diff? It's not a matter today. When we release a dmd version, we'll forget its previous versions. The maintained release versions and development versions are managed in two distinct breanches (`master` and `stable`). If we need to trace some changes, we can use git blame. There's no serious issue.\r\n\r\nUltimately I believe program source code should have no meaningless matters. In this case, `implicitConvTo` and `castTo` do very similar things. Therefore so, their visitors' methods should be declared with identical order, if there's no other special thing.  From the view, the inconsistent positioning of `CastTo.visit(AddrExp e)` is just not good.\r\n\r\nWhy we keep code format style? Because consistent style will help to focus on the code logic. Why I recommend to reorder `AddrExp.castTo`? Because increasing similarity will highlight the logic difference between `implicitConvTo` and `castTo`.\r\n\r\nIndeed, it's a little artistic sense. However, I think and believe that making code more meaningfulness will increase code readability and maintainability. "}}