{"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/PolymerElements/gold-email-input/pulls/33","id":43270235,"html_url":"https://github.com/PolymerElements/gold-email-input/pull/33","diff_url":"https://github.com/PolymerElements/gold-email-input/pull/33.diff","patch_url":"https://github.com/PolymerElements/gold-email-input/pull/33.patch","issue_url":"https://api.github.com/repos/PolymerElements/gold-email-input/issues/33","number":33,"state":"closed","locked":false,"title":"Fixes issues in #32","user":{"login":"zerodevx","id":9677698,"avatar_url":"https://avatars.githubusercontent.com/u/9677698?v=3","gravatar_id":"","url":"https://api.github.com/users/zerodevx","html_url":"https://github.com/zerodevx","followers_url":"https://api.github.com/users/zerodevx/followers","following_url":"https://api.github.com/users/zerodevx/following{/other_user}","gists_url":"https://api.github.com/users/zerodevx/gists{/gist_id}","starred_url":"https://api.github.com/users/zerodevx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerodevx/subscriptions","organizations_url":"https://api.github.com/users/zerodevx/orgs","repos_url":"https://api.github.com/users/zerodevx/repos","events_url":"https://api.github.com/users/zerodevx/events{/privacy}","received_events_url":"https://api.github.com/users/zerodevx/received_events","type":"User","site_admin":false},"body":"@notwaldorf - referencing #32, the expected `auto-validate` behaviours are:\r\n\r\nCase 1: When auto-validate=true and required=true, an empty input should be **invalid**.\r\nCase 2: When auto-validate=true and required=false, an empty input should be **valid**.\r\n\r\nCurrently, that's not the case - repro: http://jsbin.com/hodeyakuzu/edit?html,output\r\n\r\nNotes:\r\n\r\n1. I moved `value` observer from the `properties` object to the `observers` array because it is probably cleaner (I want to avoid any unexpected behaviour when Polymer mixes duplicate properties).\r\n2. Removed the `_handleAutoValidate()` call from `ready()` callback since a) we always want to validate even if value is empty; and b) `_onValueChanged()` will definitely trigger once on first load.\r\n3. Check if `paper-input-container` actually needs updating before updating.","created_at":"2015-08-25T10:16:39Z","updated_at":"2015-08-26T17:25:25Z","closed_at":"2015-08-26T17:25:25Z","merged_at":"2015-08-26T17:25:25Z","merge_commit_sha":"65ebee048eb58a74cfaff2018f64bdaf27c55426","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PolymerElements/gold-email-input/pulls/33/commits","review_comments_url":"https://api.github.com/repos/PolymerElements/gold-email-input/pulls/33/comments","review_comment_url":"https://api.github.com/repos/PolymerElements/gold-email-input/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerElements/gold-email-input/issues/33/comments","statuses_url":"https://api.github.com/repos/PolymerElements/gold-email-input/statuses/3b50830e898090031ee7b1145349ecb9d20cc562","head":{"label":"zerodevx:bugfixes-2","ref":"bugfixes-2","sha":"3b50830e898090031ee7b1145349ecb9d20cc562","user":{"login":"zerodevx","id":9677698,"avatar_url":"https://avatars.githubusercontent.com/u/9677698?v=3","gravatar_id":"","url":"https://api.github.com/users/zerodevx","html_url":"https://github.com/zerodevx","followers_url":"https://api.github.com/users/zerodevx/followers","following_url":"https://api.github.com/users/zerodevx/following{/other_user}","gists_url":"https://api.github.com/users/zerodevx/gists{/gist_id}","starred_url":"https://api.github.com/users/zerodevx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerodevx/subscriptions","organizations_url":"https://api.github.com/users/zerodevx/orgs","repos_url":"https://api.github.com/users/zerodevx/repos","events_url":"https://api.github.com/users/zerodevx/events{/privacy}","received_events_url":"https://api.github.com/users/zerodevx/received_events","type":"User","site_admin":false},"repo":{"id":41088476,"name":"gold-email-input","full_name":"zerodevx/gold-email-input","owner":{"login":"zerodevx","id":9677698,"avatar_url":"https://avatars.githubusercontent.com/u/9677698?v=3","gravatar_id":"","url":"https://api.github.com/users/zerodevx","html_url":"https://github.com/zerodevx","followers_url":"https://api.github.com/users/zerodevx/followers","following_url":"https://api.github.com/users/zerodevx/following{/other_user}","gists_url":"https://api.github.com/users/zerodevx/gists{/gist_id}","starred_url":"https://api.github.com/users/zerodevx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerodevx/subscriptions","organizations_url":"https://api.github.com/users/zerodevx/orgs","repos_url":"https://api.github.com/users/zerodevx/repos","events_url":"https://api.github.com/users/zerodevx/events{/privacy}","received_events_url":"https://api.github.com/users/zerodevx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zerodevx/gold-email-input","description":"An input element that only allows emails","fork":true,"url":"https://api.github.com/repos/zerodevx/gold-email-input","forks_url":"https://api.github.com/repos/zerodevx/gold-email-input/forks","keys_url":"https://api.github.com/repos/zerodevx/gold-email-input/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zerodevx/gold-email-input/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zerodevx/gold-email-input/teams","hooks_url":"https://api.github.com/repos/zerodevx/gold-email-input/hooks","issue_events_url":"https://api.github.com/repos/zerodevx/gold-email-input/issues/events{/number}","events_url":"https://api.github.com/repos/zerodevx/gold-email-input/events","assignees_url":"https://api.github.com/repos/zerodevx/gold-email-input/assignees{/user}","branches_url":"https://api.github.com/repos/zerodevx/gold-email-input/branches{/branch}","tags_url":"https://api.github.com/repos/zerodevx/gold-email-input/tags","blobs_url":"https://api.github.com/repos/zerodevx/gold-email-input/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zerodevx/gold-email-input/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zerodevx/gold-email-input/git/refs{/sha}","trees_url":"https://api.github.com/repos/zerodevx/gold-email-input/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zerodevx/gold-email-input/statuses/{sha}","languages_url":"https://api.github.com/repos/zerodevx/gold-email-input/languages","stargazers_url":"https://api.github.com/repos/zerodevx/gold-email-input/stargazers","contributors_url":"https://api.github.com/repos/zerodevx/gold-email-input/contributors","subscribers_url":"https://api.github.com/repos/zerodevx/gold-email-input/subscribers","subscription_url":"https://api.github.com/repos/zerodevx/gold-email-input/subscription","commits_url":"https://api.github.com/repos/zerodevx/gold-email-input/commits{/sha}","git_commits_url":"https://api.github.com/repos/zerodevx/gold-email-input/git/commits{/sha}","comments_url":"https://api.github.com/repos/zerodevx/gold-email-input/comments{/number}","issue_comment_url":"https://api.github.com/repos/zerodevx/gold-email-input/issues/comments{/number}","contents_url":"https://api.github.com/repos/zerodevx/gold-email-input/contents/{+path}","compare_url":"https://api.github.com/repos/zerodevx/gold-email-input/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zerodevx/gold-email-input/merges","archive_url":"https://api.github.com/repos/zerodevx/gold-email-input/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zerodevx/gold-email-input/downloads","issues_url":"https://api.github.com/repos/zerodevx/gold-email-input/issues{/number}","pulls_url":"https://api.github.com/repos/zerodevx/gold-email-input/pulls{/number}","milestones_url":"https://api.github.com/repos/zerodevx/gold-email-input/milestones{/number}","notifications_url":"https://api.github.com/repos/zerodevx/gold-email-input/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zerodevx/gold-email-input/labels{/name}","releases_url":"https://api.github.com/repos/zerodevx/gold-email-input/releases{/id}","created_at":"2015-08-20T09:50:33Z","updated_at":"2015-08-20T09:50:33Z","pushed_at":"2015-08-26T06:54:48Z","git_url":"git://github.com/zerodevx/gold-email-input.git","ssh_url":"git@github.com:zerodevx/gold-email-input.git","clone_url":"https://github.com/zerodevx/gold-email-input.git","svn_url":"https://github.com/zerodevx/gold-email-input","homepage":"","size":119,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PolymerElements:master","ref":"master","sha":"a46730861c07f194db756276840107041eeaa8ce","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":35243730,"name":"gold-email-input","full_name":"PolymerElements/gold-email-input","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/gold-email-input","description":"An input element that only allows emails","fork":false,"url":"https://api.github.com/repos/PolymerElements/gold-email-input","forks_url":"https://api.github.com/repos/PolymerElements/gold-email-input/forks","keys_url":"https://api.github.com/repos/PolymerElements/gold-email-input/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/gold-email-input/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/gold-email-input/teams","hooks_url":"https://api.github.com/repos/PolymerElements/gold-email-input/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/gold-email-input/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/gold-email-input/events","assignees_url":"https://api.github.com/repos/PolymerElements/gold-email-input/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/gold-email-input/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/gold-email-input/tags","blobs_url":"https://api.github.com/repos/PolymerElements/gold-email-input/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/gold-email-input/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/gold-email-input/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/gold-email-input/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/gold-email-input/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/gold-email-input/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/gold-email-input/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/gold-email-input/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/gold-email-input/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/gold-email-input/subscription","commits_url":"https://api.github.com/repos/PolymerElements/gold-email-input/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/gold-email-input/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/gold-email-input/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/gold-email-input/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/gold-email-input/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/gold-email-input/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/gold-email-input/merges","archive_url":"https://api.github.com/repos/PolymerElements/gold-email-input/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/gold-email-input/downloads","issues_url":"https://api.github.com/repos/PolymerElements/gold-email-input/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/gold-email-input/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/gold-email-input/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/gold-email-input/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/gold-email-input/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/gold-email-input/releases{/id}","created_at":"2015-05-07T21:10:20Z","updated_at":"2015-07-25T20:31:20Z","pushed_at":"2015-08-26T17:25:25Z","git_url":"git://github.com/PolymerElements/gold-email-input.git","ssh_url":"git@github.com:PolymerElements/gold-email-input.git","clone_url":"https://github.com/PolymerElements/gold-email-input.git","svn_url":"https://github.com/PolymerElements/gold-email-input","homepage":"","size":346,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":9,"forks":11,"open_issues":9,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/gold-email-input/pulls/33"},"html":{"href":"https://github.com/PolymerElements/gold-email-input/pull/33"},"issue":{"href":"https://api.github.com/repos/PolymerElements/gold-email-input/issues/33"},"comments":{"href":"https://api.github.com/repos/PolymerElements/gold-email-input/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerElements/gold-email-input/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerElements/gold-email-input/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerElements/gold-email-input/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerElements/gold-email-input/statuses/3b50830e898090031ee7b1145349ecb9d20cc562"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"notwaldorf","id":1369170,"avatar_url":"https://avatars.githubusercontent.com/u/1369170?v=3","gravatar_id":"","url":"https://api.github.com/users/notwaldorf","html_url":"https://github.com/notwaldorf","followers_url":"https://api.github.com/users/notwaldorf/followers","following_url":"https://api.github.com/users/notwaldorf/following{/other_user}","gists_url":"https://api.github.com/users/notwaldorf/gists{/gist_id}","starred_url":"https://api.github.com/users/notwaldorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notwaldorf/subscriptions","organizations_url":"https://api.github.com/users/notwaldorf/orgs","repos_url":"https://api.github.com/users/notwaldorf/repos","events_url":"https://api.github.com/users/notwaldorf/events{/privacy}","received_events_url":"https://api.github.com/users/notwaldorf/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":14,"deletions":13,"changed_files":1}}