{"action":"created","issue":{"url":"https://api.github.com/repos/YorickPeterse/oga/issues/72","labels_url":"https://api.github.com/repos/YorickPeterse/oga/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/YorickPeterse/oga/issues/72/comments","events_url":"https://api.github.com/repos/YorickPeterse/oga/issues/72/events","html_url":"https://github.com/YorickPeterse/oga/issues/72","id":53141053,"number":72,"title":"Support for multi_xml","user":{"login":"YorickPeterse","id":86065,"avatar_url":"https://avatars.githubusercontent.com/u/86065?v=3","gravatar_id":"","url":"https://api.github.com/users/YorickPeterse","html_url":"https://github.com/YorickPeterse","followers_url":"https://api.github.com/users/YorickPeterse/followers","following_url":"https://api.github.com/users/YorickPeterse/following{/other_user}","gists_url":"https://api.github.com/users/YorickPeterse/gists{/gist_id}","starred_url":"https://api.github.com/users/YorickPeterse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YorickPeterse/subscriptions","organizations_url":"https://api.github.com/users/YorickPeterse/orgs","repos_url":"https://api.github.com/users/YorickPeterse/repos","events_url":"https://api.github.com/users/YorickPeterse/events{/privacy}","received_events_url":"https://api.github.com/users/YorickPeterse/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/YorickPeterse/oga/labels/Feature","name":"Feature","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2014-12-30T19:41:35Z","updated_at":"2015-05-21T08:33:09Z","closed_at":null,"body":"multi_xml should support for Oga, most likely by using the SAX API of Oga. This will allow me to use v2 of the aws-sdk without having to rely on Nokogiri, or worse: REXML."},"comment":{"url":"https://api.github.com/repos/YorickPeterse/oga/issues/comments/104180961","html_url":"https://github.com/YorickPeterse/oga/issues/72#issuecomment-104180961","issue_url":"https://api.github.com/repos/YorickPeterse/oga/issues/72","id":104180961,"user":{"login":"YorickPeterse","id":86065,"avatar_url":"https://avatars.githubusercontent.com/u/86065?v=3","gravatar_id":"","url":"https://api.github.com/users/YorickPeterse","html_url":"https://github.com/YorickPeterse","followers_url":"https://api.github.com/users/YorickPeterse/followers","following_url":"https://api.github.com/users/YorickPeterse/following{/other_user}","gists_url":"https://api.github.com/users/YorickPeterse/gists{/gist_id}","starred_url":"https://api.github.com/users/YorickPeterse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YorickPeterse/subscriptions","organizations_url":"https://api.github.com/users/YorickPeterse/orgs","repos_url":"https://api.github.com/users/YorickPeterse/repos","events_url":"https://api.github.com/users/YorickPeterse/events{/privacy}","received_events_url":"https://api.github.com/users/YorickPeterse/received_events","type":"User","site_admin":false},"created_at":"2015-05-21T08:33:09Z","updated_at":"2015-05-21T08:33:09Z","body":"> The only hook I see is the #parser_error method and I haven't been able to trigger it. Thoughts?\r\n\r\nThis particular method is more meant for parser authors to either enhance error messages or add custom handling of errors. For example, https://github.com/YorickPeterse/oga/blob/098cd51ab730721c19bb4d7d172e3c203901a062/lib/oga/xml/parser.rll#L279-L295 is used to add some extra text to error messages to indicate what kind of data caused the error.\r\n\r\nCurrently Oga's XML lexer is pretty lax and makes sure that most input can be processed. However, you can break it by using for example input such as this:\r\n\r\n    Oga.parse_xml('<!--') # => LL::ParserError: Unexpected end of input, expected T_COMMENT_END instead on line 1\r\n\r\nDoes the AWS SDK actually require the parser to raise errors for invalid XML? In most cases one probably doesn't want to bother with this, hence Oga tries to parse as much as possible by default. Seeing how this is now the potential 3rd request for a \"strict\" option I can look into adding this if needed."}}