{"action":"closed","number":32,"pull_request":{"url":"https://api.github.com/repos/gds-operations/puppet-aptly/pulls/32","id":39914888,"html_url":"https://github.com/gds-operations/puppet-aptly/pull/32","diff_url":"https://github.com/gds-operations/puppet-aptly/pull/32.diff","patch_url":"https://github.com/gds-operations/puppet-aptly/pull/32.patch","issue_url":"https://api.github.com/repos/gds-operations/puppet-aptly/issues/32","number":32,"state":"closed","locked":false,"title":"Extend repo,mirror add snapshot","user":{"login":"mklette","id":1333486,"avatar_url":"https://avatars.githubusercontent.com/u/1333486?v=3","gravatar_id":"","url":"https://api.github.com/users/mklette","html_url":"https://github.com/mklette","followers_url":"https://api.github.com/users/mklette/followers","following_url":"https://api.github.com/users/mklette/following{/other_user}","gists_url":"https://api.github.com/users/mklette/gists{/gist_id}","starred_url":"https://api.github.com/users/mklette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklette/subscriptions","organizations_url":"https://api.github.com/users/mklette/orgs","repos_url":"https://api.github.com/users/mklette/repos","events_url":"https://api.github.com/users/mklette/events{/privacy}","received_events_url":"https://api.github.com/users/mklette/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\na few words about these changes:\r\n1. init: config_file:\r\nWe required to use a custom path for Aptly configuration in the past. Meanwhile we use default paths too, but I wonder if it might still be helpful?\r\n\r\n2. adding snapshot.pp\r\nWe use additional scripts to automate updating any of the mirrors Puppet creates. In this regards it was easier to provide snapshots already from beginning when we need to took care of failure handling in those scripts. It's probably not useful to most users but hopefully useful enough to keep it included?\r\n\r\n3. adding attributes to repo.pp\r\nOur internal Apt structure required to define the default distribution of the repository. Other parameters were added as we evaluated Aptly. They seem reasonable enough to keep them.\r\n\r\n4. adding attributes to mirror.pp\r\nQuite similar to last paragraph we included additional arguments while evaluating Aptly. 'with_sources' is important for our build-hosts while 'with_udebs' must be included to setup proper mirrors for serving installation packages (i.e. PXE installations from local mirror). Restricting the list of architectures helps us to control the disk space needed for our mirrors.\r\n\r\nLet me know if you have any doubts to merge these changes!\r\nCheers!\r\nMathias\r\n","created_at":"2015-07-14T13:24:32Z","updated_at":"2015-08-05T13:59:56Z","closed_at":"2015-08-05T13:59:56Z","merged_at":"2015-08-05T13:59:56Z","merge_commit_sha":"e95d21648096e81ce4bfa136ce28913db386964d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gds-operations/puppet-aptly/pulls/32/commits","review_comments_url":"https://api.github.com/repos/gds-operations/puppet-aptly/pulls/32/comments","review_comment_url":"https://api.github.com/repos/gds-operations/puppet-aptly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gds-operations/puppet-aptly/issues/32/comments","statuses_url":"https://api.github.com/repos/gds-operations/puppet-aptly/statuses/09c4216c767e2d68774655743d820e835487d2d1","head":{"label":"mklette:extend-repo,mirror-add-snapshot","ref":"extend-repo,mirror-add-snapshot","sha":"09c4216c767e2d68774655743d820e835487d2d1","user":{"login":"mklette","id":1333486,"avatar_url":"https://avatars.githubusercontent.com/u/1333486?v=3","gravatar_id":"","url":"https://api.github.com/users/mklette","html_url":"https://github.com/mklette","followers_url":"https://api.github.com/users/mklette/followers","following_url":"https://api.github.com/users/mklette/following{/other_user}","gists_url":"https://api.github.com/users/mklette/gists{/gist_id}","starred_url":"https://api.github.com/users/mklette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklette/subscriptions","organizations_url":"https://api.github.com/users/mklette/orgs","repos_url":"https://api.github.com/users/mklette/repos","events_url":"https://api.github.com/users/mklette/events{/privacy}","received_events_url":"https://api.github.com/users/mklette/received_events","type":"User","site_admin":false},"repo":{"id":23898111,"name":"puppet-aptly","full_name":"mklette/puppet-aptly","owner":{"login":"mklette","id":1333486,"avatar_url":"https://avatars.githubusercontent.com/u/1333486?v=3","gravatar_id":"","url":"https://api.github.com/users/mklette","html_url":"https://github.com/mklette","followers_url":"https://api.github.com/users/mklette/followers","following_url":"https://api.github.com/users/mklette/following{/other_user}","gists_url":"https://api.github.com/users/mklette/gists{/gist_id}","starred_url":"https://api.github.com/users/mklette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklette/subscriptions","organizations_url":"https://api.github.com/users/mklette/orgs","repos_url":"https://api.github.com/users/mklette/repos","events_url":"https://api.github.com/users/mklette/events{/privacy}","received_events_url":"https://api.github.com/users/mklette/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mklette/puppet-aptly","description":"Puppet module for aptly","fork":true,"url":"https://api.github.com/repos/mklette/puppet-aptly","forks_url":"https://api.github.com/repos/mklette/puppet-aptly/forks","keys_url":"https://api.github.com/repos/mklette/puppet-aptly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mklette/puppet-aptly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mklette/puppet-aptly/teams","hooks_url":"https://api.github.com/repos/mklette/puppet-aptly/hooks","issue_events_url":"https://api.github.com/repos/mklette/puppet-aptly/issues/events{/number}","events_url":"https://api.github.com/repos/mklette/puppet-aptly/events","assignees_url":"https://api.github.com/repos/mklette/puppet-aptly/assignees{/user}","branches_url":"https://api.github.com/repos/mklette/puppet-aptly/branches{/branch}","tags_url":"https://api.github.com/repos/mklette/puppet-aptly/tags","blobs_url":"https://api.github.com/repos/mklette/puppet-aptly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mklette/puppet-aptly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mklette/puppet-aptly/git/refs{/sha}","trees_url":"https://api.github.com/repos/mklette/puppet-aptly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mklette/puppet-aptly/statuses/{sha}","languages_url":"https://api.github.com/repos/mklette/puppet-aptly/languages","stargazers_url":"https://api.github.com/repos/mklette/puppet-aptly/stargazers","contributors_url":"https://api.github.com/repos/mklette/puppet-aptly/contributors","subscribers_url":"https://api.github.com/repos/mklette/puppet-aptly/subscribers","subscription_url":"https://api.github.com/repos/mklette/puppet-aptly/subscription","commits_url":"https://api.github.com/repos/mklette/puppet-aptly/commits{/sha}","git_commits_url":"https://api.github.com/repos/mklette/puppet-aptly/git/commits{/sha}","comments_url":"https://api.github.com/repos/mklette/puppet-aptly/comments{/number}","issue_comment_url":"https://api.github.com/repos/mklette/puppet-aptly/issues/comments{/number}","contents_url":"https://api.github.com/repos/mklette/puppet-aptly/contents/{+path}","compare_url":"https://api.github.com/repos/mklette/puppet-aptly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mklette/puppet-aptly/merges","archive_url":"https://api.github.com/repos/mklette/puppet-aptly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mklette/puppet-aptly/downloads","issues_url":"https://api.github.com/repos/mklette/puppet-aptly/issues{/number}","pulls_url":"https://api.github.com/repos/mklette/puppet-aptly/pulls{/number}","milestones_url":"https://api.github.com/repos/mklette/puppet-aptly/milestones{/number}","notifications_url":"https://api.github.com/repos/mklette/puppet-aptly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mklette/puppet-aptly/labels{/name}","releases_url":"https://api.github.com/repos/mklette/puppet-aptly/releases{/id}","created_at":"2014-09-11T00:43:11Z","updated_at":"2015-01-27T13:42:33Z","pushed_at":"2015-07-15T09:34:51Z","git_url":"git://github.com/mklette/puppet-aptly.git","ssh_url":"git@github.com:mklette/puppet-aptly.git","clone_url":"https://github.com/mklette/puppet-aptly.git","svn_url":"https://github.com/mklette/puppet-aptly","homepage":null,"size":184,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gds-operations:master","ref":"master","sha":"e96dcf66307180c2228b4011de8ede53c167cb57","user":{"login":"gds-operations","id":4703760,"avatar_url":"https://avatars.githubusercontent.com/u/4703760?v=3","gravatar_id":"","url":"https://api.github.com/users/gds-operations","html_url":"https://github.com/gds-operations","followers_url":"https://api.github.com/users/gds-operations/followers","following_url":"https://api.github.com/users/gds-operations/following{/other_user}","gists_url":"https://api.github.com/users/gds-operations/gists{/gist_id}","starred_url":"https://api.github.com/users/gds-operations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gds-operations/subscriptions","organizations_url":"https://api.github.com/users/gds-operations/orgs","repos_url":"https://api.github.com/users/gds-operations/repos","events_url":"https://api.github.com/users/gds-operations/events{/privacy}","received_events_url":"https://api.github.com/users/gds-operations/received_events","type":"Organization","site_admin":false},"repo":{"id":18286318,"name":"puppet-aptly","full_name":"gds-operations/puppet-aptly","owner":{"login":"gds-operations","id":4703760,"avatar_url":"https://avatars.githubusercontent.com/u/4703760?v=3","gravatar_id":"","url":"https://api.github.com/users/gds-operations","html_url":"https://github.com/gds-operations","followers_url":"https://api.github.com/users/gds-operations/followers","following_url":"https://api.github.com/users/gds-operations/following{/other_user}","gists_url":"https://api.github.com/users/gds-operations/gists{/gist_id}","starred_url":"https://api.github.com/users/gds-operations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gds-operations/subscriptions","organizations_url":"https://api.github.com/users/gds-operations/orgs","repos_url":"https://api.github.com/users/gds-operations/repos","events_url":"https://api.github.com/users/gds-operations/events{/privacy}","received_events_url":"https://api.github.com/users/gds-operations/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gds-operations/puppet-aptly","description":"Puppet module for aptly","fork":false,"url":"https://api.github.com/repos/gds-operations/puppet-aptly","forks_url":"https://api.github.com/repos/gds-operations/puppet-aptly/forks","keys_url":"https://api.github.com/repos/gds-operations/puppet-aptly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gds-operations/puppet-aptly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gds-operations/puppet-aptly/teams","hooks_url":"https://api.github.com/repos/gds-operations/puppet-aptly/hooks","issue_events_url":"https://api.github.com/repos/gds-operations/puppet-aptly/issues/events{/number}","events_url":"https://api.github.com/repos/gds-operations/puppet-aptly/events","assignees_url":"https://api.github.com/repos/gds-operations/puppet-aptly/assignees{/user}","branches_url":"https://api.github.com/repos/gds-operations/puppet-aptly/branches{/branch}","tags_url":"https://api.github.com/repos/gds-operations/puppet-aptly/tags","blobs_url":"https://api.github.com/repos/gds-operations/puppet-aptly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gds-operations/puppet-aptly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gds-operations/puppet-aptly/git/refs{/sha}","trees_url":"https://api.github.com/repos/gds-operations/puppet-aptly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gds-operations/puppet-aptly/statuses/{sha}","languages_url":"https://api.github.com/repos/gds-operations/puppet-aptly/languages","stargazers_url":"https://api.github.com/repos/gds-operations/puppet-aptly/stargazers","contributors_url":"https://api.github.com/repos/gds-operations/puppet-aptly/contributors","subscribers_url":"https://api.github.com/repos/gds-operations/puppet-aptly/subscribers","subscription_url":"https://api.github.com/repos/gds-operations/puppet-aptly/subscription","commits_url":"https://api.github.com/repos/gds-operations/puppet-aptly/commits{/sha}","git_commits_url":"https://api.github.com/repos/gds-operations/puppet-aptly/git/commits{/sha}","comments_url":"https://api.github.com/repos/gds-operations/puppet-aptly/comments{/number}","issue_comment_url":"https://api.github.com/repos/gds-operations/puppet-aptly/issues/comments{/number}","contents_url":"https://api.github.com/repos/gds-operations/puppet-aptly/contents/{+path}","compare_url":"https://api.github.com/repos/gds-operations/puppet-aptly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gds-operations/puppet-aptly/merges","archive_url":"https://api.github.com/repos/gds-operations/puppet-aptly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gds-operations/puppet-aptly/downloads","issues_url":"https://api.github.com/repos/gds-operations/puppet-aptly/issues{/number}","pulls_url":"https://api.github.com/repos/gds-operations/puppet-aptly/pulls{/number}","milestones_url":"https://api.github.com/repos/gds-operations/puppet-aptly/milestones{/number}","notifications_url":"https://api.github.com/repos/gds-operations/puppet-aptly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gds-operations/puppet-aptly/labels{/name}","releases_url":"https://api.github.com/repos/gds-operations/puppet-aptly/releases{/id}","created_at":"2014-03-31T08:20:05Z","updated_at":"2015-08-03T13:07:48Z","pushed_at":"2015-08-05T13:59:56Z","git_url":"git://github.com/gds-operations/puppet-aptly.git","ssh_url":"git@github.com:gds-operations/puppet-aptly.git","clone_url":"https://github.com/gds-operations/puppet-aptly.git","svn_url":"https://github.com/gds-operations/puppet-aptly","homepage":null,"size":479,"stargazers_count":17,"watchers_count":17,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":5,"forks":15,"open_issues":5,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gds-operations/puppet-aptly/pulls/32"},"html":{"href":"https://github.com/gds-operations/puppet-aptly/pull/32"},"issue":{"href":"https://api.github.com/repos/gds-operations/puppet-aptly/issues/32"},"comments":{"href":"https://api.github.com/repos/gds-operations/puppet-aptly/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/gds-operations/puppet-aptly/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/gds-operations/puppet-aptly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gds-operations/puppet-aptly/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/gds-operations/puppet-aptly/statuses/09c4216c767e2d68774655743d820e835487d2d1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ajlanghorn","id":683665,"avatar_url":"https://avatars.githubusercontent.com/u/683665?v=3","gravatar_id":"","url":"https://api.github.com/users/ajlanghorn","html_url":"https://github.com/ajlanghorn","followers_url":"https://api.github.com/users/ajlanghorn/followers","following_url":"https://api.github.com/users/ajlanghorn/following{/other_user}","gists_url":"https://api.github.com/users/ajlanghorn/gists{/gist_id}","starred_url":"https://api.github.com/users/ajlanghorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajlanghorn/subscriptions","organizations_url":"https://api.github.com/users/ajlanghorn/orgs","repos_url":"https://api.github.com/users/ajlanghorn/repos","events_url":"https://api.github.com/users/ajlanghorn/events{/privacy}","received_events_url":"https://api.github.com/users/ajlanghorn/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":8,"additions":439,"deletions":48,"changed_files":8}}