{"action":"opened","number":4037,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/4037","id":31341376,"html_url":"https://github.com/ceph/ceph/pull/4037","diff_url":"https://github.com/ceph/ceph/pull/4037.diff","patch_url":"https://github.com/ceph/ceph/pull/4037.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/4037","number":4037,"state":"open","locked":false,"title":"Fix \"disk zap\" sgdisk invocation","user":{"login":"osynge","id":669365,"avatar_url":"https://avatars.githubusercontent.com/u/669365?v=3","gravatar_id":"","url":"https://api.github.com/users/osynge","html_url":"https://github.com/osynge","followers_url":"https://api.github.com/users/osynge/followers","following_url":"https://api.github.com/users/osynge/following{/other_user}","gists_url":"https://api.github.com/users/osynge/gists{/gist_id}","starred_url":"https://api.github.com/users/osynge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osynge/subscriptions","organizations_url":"https://api.github.com/users/osynge/orgs","repos_url":"https://api.github.com/users/osynge/repos","events_url":"https://api.github.com/users/osynge/events{/privacy}","received_events_url":"https://api.github.com/users/osynge/received_events","type":"User","site_admin":false},"body":"If the metadata on the disk is truly invalid, sgdisk would fail to zero\r\nit in one go, because --mbrtogpt apparently tried to operate on the\r\nmetadata it read before executing --zap-all.\r\n\r\nSplitting this up into two separate invocations to first zap everything\r\nand then clear it properly fixes this issue.\r\n\r\nBased on patch by Lars Marowsky-Bree <lmb@suse.com> in ceph-deploy.\r\nCreated by Vincent Untz <vuntz@suse.com>\r\n\r\nSigned-off-by: Owen Synge <osynge@suse.com>\r\nSigned-off-by: Thorsten Behrens <tbehrens@suse.com>\r\n(cherry picked from commit d54a8b1f5b8ffbd948503cfbf27e7c3f55b5c542)\r\n(cherry picked from commit 328cd17546187fb3e17766a1148012c43e25e205)","created_at":"2015-03-17T14:45:57Z","updated_at":"2015-03-17T14:45:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/4037/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/4037/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/4037/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/8fb96e1b2191294fcd5beca2ee317c0cd2a9b7a2","head":{"label":"osynge:wip-fix-disk-zap-sgdisk-invocation","ref":"wip-fix-disk-zap-sgdisk-invocation","sha":"8fb96e1b2191294fcd5beca2ee317c0cd2a9b7a2","user":{"login":"osynge","id":669365,"avatar_url":"https://avatars.githubusercontent.com/u/669365?v=3","gravatar_id":"","url":"https://api.github.com/users/osynge","html_url":"https://github.com/osynge","followers_url":"https://api.github.com/users/osynge/followers","following_url":"https://api.github.com/users/osynge/following{/other_user}","gists_url":"https://api.github.com/users/osynge/gists{/gist_id}","starred_url":"https://api.github.com/users/osynge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osynge/subscriptions","organizations_url":"https://api.github.com/users/osynge/orgs","repos_url":"https://api.github.com/users/osynge/repos","events_url":"https://api.github.com/users/osynge/events{/privacy}","received_events_url":"https://api.github.com/users/osynge/received_events","type":"User","site_admin":false},"repo":{"id":22383336,"name":"ceph","full_name":"osynge/ceph","owner":{"login":"osynge","id":669365,"avatar_url":"https://avatars.githubusercontent.com/u/669365?v=3","gravatar_id":"","url":"https://api.github.com/users/osynge","html_url":"https://github.com/osynge","followers_url":"https://api.github.com/users/osynge/followers","following_url":"https://api.github.com/users/osynge/following{/other_user}","gists_url":"https://api.github.com/users/osynge/gists{/gist_id}","starred_url":"https://api.github.com/users/osynge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osynge/subscriptions","organizations_url":"https://api.github.com/users/osynge/orgs","repos_url":"https://api.github.com/users/osynge/repos","events_url":"https://api.github.com/users/osynge/events{/privacy}","received_events_url":"https://api.github.com/users/osynge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/osynge/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/osynge/ceph","forks_url":"https://api.github.com/repos/osynge/ceph/forks","keys_url":"https://api.github.com/repos/osynge/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osynge/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osynge/ceph/teams","hooks_url":"https://api.github.com/repos/osynge/ceph/hooks","issue_events_url":"https://api.github.com/repos/osynge/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/osynge/ceph/events","assignees_url":"https://api.github.com/repos/osynge/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/osynge/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/osynge/ceph/tags","blobs_url":"https://api.github.com/repos/osynge/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osynge/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osynge/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/osynge/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osynge/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/osynge/ceph/languages","stargazers_url":"https://api.github.com/repos/osynge/ceph/stargazers","contributors_url":"https://api.github.com/repos/osynge/ceph/contributors","subscribers_url":"https://api.github.com/repos/osynge/ceph/subscribers","subscription_url":"https://api.github.com/repos/osynge/ceph/subscription","commits_url":"https://api.github.com/repos/osynge/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/osynge/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/osynge/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/osynge/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/osynge/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/osynge/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osynge/ceph/merges","archive_url":"https://api.github.com/repos/osynge/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osynge/ceph/downloads","issues_url":"https://api.github.com/repos/osynge/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/osynge/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/osynge/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/osynge/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osynge/ceph/labels{/name}","releases_url":"https://api.github.com/repos/osynge/ceph/releases{/id}","created_at":"2014-07-29T14:45:01Z","updated_at":"2015-03-17T14:10:50Z","pushed_at":"2015-03-17T14:44:41Z","git_url":"git://github.com/osynge/ceph.git","ssh_url":"git@github.com:osynge/ceph.git","clone_url":"https://github.com/osynge/ceph.git","svn_url":"https://github.com/osynge/ceph","homepage":"http://ceph.com","size":94049,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"c87b655845e950efef949539556835187bfdd645","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","created_at":"2011-09-01T21:41:26Z","updated_at":"2015-03-17T11:13:32Z","pushed_at":"2015-03-17T13:44:15Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":378315,"stargazers_count":1183,"watchers_count":1183,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":627,"mirror_url":null,"open_issues_count":132,"forks":627,"open_issues":132,"watchers":1183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4037"},"html":{"href":"https://github.com/ceph/ceph/pull/4037"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/4037"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/4037/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4037/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4037/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/8fb96e1b2191294fcd5beca2ee317c0cd2a9b7a2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":0,"changed_files":1}}