{"action":"created","issue":{"url":"https://api.github.com/repos/rotty3000/liferay-portal/issues/711","labels_url":"https://api.github.com/repos/rotty3000/liferay-portal/issues/711/labels{/name}","comments_url":"https://api.github.com/repos/rotty3000/liferay-portal/issues/711/comments","events_url":"https://api.github.com/repos/rotty3000/liferay-portal/issues/711/events","html_url":"https://github.com/rotty3000/liferay-portal/pull/711","id":57788673,"number":711,"title":"LPS-53373 Add assign Default Portlet Data Handler when portlet does not declare one","user":{"login":"epgarcia","id":1579803,"avatar_url":"https://avatars.githubusercontent.com/u/1579803?v=3","gravatar_id":"","url":"https://api.github.com/users/epgarcia","html_url":"https://github.com/epgarcia","followers_url":"https://api.github.com/users/epgarcia/followers","following_url":"https://api.github.com/users/epgarcia/following{/other_user}","gists_url":"https://api.github.com/users/epgarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/epgarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epgarcia/subscriptions","organizations_url":"https://api.github.com/users/epgarcia/orgs","repos_url":"https://api.github.com/users/epgarcia/repos","events_url":"https://api.github.com/users/epgarcia/events{/privacy}","received_events_url":"https://api.github.com/users/epgarcia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-16T10:40:49Z","updated_at":"2015-02-17T17:04:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rotty3000/liferay-portal/pulls/711","html_url":"https://github.com/rotty3000/liferay-portal/pull/711","diff_url":"https://github.com/rotty3000/liferay-portal/pull/711.diff","patch_url":"https://github.com/rotty3000/liferay-portal/pull/711.patch"},"body":"Hi @rotty3000,\r\n\r\nWe need every portlet to have a PortletDataHandler (see LPS-35835). This default PDH would have the lowest service.ranking, so that any alternative registered PDH would be used instead. For legacy portlets, the default PDH would be that declared in the liferay-portlet.xml. For any others, we use the DefaultConfigurationPDH. \r\n\r\nI noticed we're using a ServiceTrackerList as a register for the PDHs of a portlet. Is there any reason to use a list, when there can only be a PDH for portlet? (actually, in PortletImpl#getPortletDataHandlerInstance we obtain the first one) And is that list somehow ordered by service.ranking, so that we're sure that the first position is the registered implementation of a PDH for my portlet with the highest service ranking?\r\n\r\nThanks!\r\n\r\n@matethurzo\r\n@juliocamarero"},"comment":{"url":"https://api.github.com/repos/rotty3000/liferay-portal/issues/comments/74705055","html_url":"https://github.com/rotty3000/liferay-portal/pull/711#issuecomment-74705055","issue_url":"https://api.github.com/repos/rotty3000/liferay-portal/issues/711","id":74705055,"user":{"login":"rotty3000","id":146764,"avatar_url":"https://avatars.githubusercontent.com/u/146764?v=3","gravatar_id":"","url":"https://api.github.com/users/rotty3000","html_url":"https://github.com/rotty3000","followers_url":"https://api.github.com/users/rotty3000/followers","following_url":"https://api.github.com/users/rotty3000/following{/other_user}","gists_url":"https://api.github.com/users/rotty3000/gists{/gist_id}","starred_url":"https://api.github.com/users/rotty3000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rotty3000/subscriptions","organizations_url":"https://api.github.com/users/rotty3000/orgs","repos_url":"https://api.github.com/users/rotty3000/repos","events_url":"https://api.github.com/users/rotty3000/events{/privacy}","received_events_url":"https://api.github.com/users/rotty3000/received_events","type":"User","site_admin":false},"created_at":"2015-02-17T17:04:34Z","updated_at":"2015-02-17T17:04:34Z","body":"Just started reviewing :) <br><br>:octocat: *Sent from [GH](http://nodegh.io).*"}}