{"action":"closed","number":11677,"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/11677","id":34605344,"html_url":"https://github.com/cocos2d/cocos2d-x/pull/11677","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/11677.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/11677.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/11677","number":11677,"state":"closed","locked":false,"title":"Fix setSprite never updating progress on ProgressTimer","user":{"login":"tankorsmash","id":1312390,"avatar_url":"https://avatars.githubusercontent.com/u/1312390?v=3","gravatar_id":"","url":"https://api.github.com/users/tankorsmash","html_url":"https://github.com/tankorsmash","followers_url":"https://api.github.com/users/tankorsmash/followers","following_url":"https://api.github.com/users/tankorsmash/following{/other_user}","gists_url":"https://api.github.com/users/tankorsmash/gists{/gist_id}","starred_url":"https://api.github.com/users/tankorsmash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tankorsmash/subscriptions","organizations_url":"https://api.github.com/users/tankorsmash/orgs","repos_url":"https://api.github.com/users/tankorsmash/repos","events_url":"https://api.github.com/users/tankorsmash/events{/privacy}","received_events_url":"https://api.github.com/users/tankorsmash/received_events","type":"User","site_admin":false},"body":"Basically whenever you set a new sprite on a ProgressTimer, the new sprite is hidden.\r\n\r\n Calling setPercentage once with the same value doesn't work because the new percentage is the same as the old one. I've got a workaround setting the percentage to 0 and then back to the old value, but this change seems to solve that issue entirely.","created_at":"2015-05-03T18:36:00Z","updated_at":"2015-05-19T03:42:20Z","closed_at":"2015-05-19T03:42:20Z","merged_at":"2015-05-19T03:42:20Z","merge_commit_sha":"f2080b5532d63898d0ae30ddf01b76a1081ff614","assignee":{"login":"WenhaiLin","id":5234286,"avatar_url":"https://avatars.githubusercontent.com/u/5234286?v=3","gravatar_id":"","url":"https://api.github.com/users/WenhaiLin","html_url":"https://github.com/WenhaiLin","followers_url":"https://api.github.com/users/WenhaiLin/followers","following_url":"https://api.github.com/users/WenhaiLin/following{/other_user}","gists_url":"https://api.github.com/users/WenhaiLin/gists{/gist_id}","starred_url":"https://api.github.com/users/WenhaiLin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WenhaiLin/subscriptions","organizations_url":"https://api.github.com/users/WenhaiLin/orgs","repos_url":"https://api.github.com/users/WenhaiLin/repos","events_url":"https://api.github.com/users/WenhaiLin/events{/privacy}","received_events_url":"https://api.github.com/users/WenhaiLin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/11677/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/11677/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/11677/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/88833213ca791eed3f762eaf5fcec6b238acdabf","head":{"label":"tankorsmash:patch-1","ref":"patch-1","sha":"88833213ca791eed3f762eaf5fcec6b238acdabf","user":{"login":"tankorsmash","id":1312390,"avatar_url":"https://avatars.githubusercontent.com/u/1312390?v=3","gravatar_id":"","url":"https://api.github.com/users/tankorsmash","html_url":"https://github.com/tankorsmash","followers_url":"https://api.github.com/users/tankorsmash/followers","following_url":"https://api.github.com/users/tankorsmash/following{/other_user}","gists_url":"https://api.github.com/users/tankorsmash/gists{/gist_id}","starred_url":"https://api.github.com/users/tankorsmash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tankorsmash/subscriptions","organizations_url":"https://api.github.com/users/tankorsmash/orgs","repos_url":"https://api.github.com/users/tankorsmash/repos","events_url":"https://api.github.com/users/tankorsmash/events{/privacy}","received_events_url":"https://api.github.com/users/tankorsmash/received_events","type":"User","site_admin":false},"repo":{"id":34996241,"name":"cocos2d-x","full_name":"tankorsmash/cocos2d-x","owner":{"login":"tankorsmash","id":1312390,"avatar_url":"https://avatars.githubusercontent.com/u/1312390?v=3","gravatar_id":"","url":"https://api.github.com/users/tankorsmash","html_url":"https://github.com/tankorsmash","followers_url":"https://api.github.com/users/tankorsmash/followers","following_url":"https://api.github.com/users/tankorsmash/following{/other_user}","gists_url":"https://api.github.com/users/tankorsmash/gists{/gist_id}","starred_url":"https://api.github.com/users/tankorsmash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tankorsmash/subscriptions","organizations_url":"https://api.github.com/users/tankorsmash/orgs","repos_url":"https://api.github.com/users/tankorsmash/repos","events_url":"https://api.github.com/users/tankorsmash/events{/privacy}","received_events_url":"https://api.github.com/users/tankorsmash/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tankorsmash/cocos2d-x","description":"cocos2d-x for C++","fork":true,"url":"https://api.github.com/repos/tankorsmash/cocos2d-x","forks_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/forks","keys_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/events","assignees_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/merges","archive_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/tankorsmash/cocos2d-x/releases{/id}","created_at":"2015-05-03T18:32:21Z","updated_at":"2015-05-03T18:32:38Z","pushed_at":"2015-05-03T18:35:52Z","git_url":"git://github.com/tankorsmash/cocos2d-x.git","ssh_url":"git@github.com:tankorsmash/cocos2d-x.git","clone_url":"https://github.com/tankorsmash/cocos2d-x.git","svn_url":"https://github.com/tankorsmash/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":823367,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v3"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"254a4b0b0c84e352850b8a1c126d4afe4f176abe","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"cocos2d-x for C++","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","created_at":"2010-11-18T23:17:00Z","updated_at":"2015-05-19T01:57:53Z","pushed_at":"2015-05-19T03:42:20Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1428973,"stargazers_count":5892,"watchers_count":5892,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4263,"mirror_url":null,"open_issues_count":643,"forks":4263,"open_issues":643,"watchers":5892,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/11677"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/11677"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/11677"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/11677/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/11677/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/11677/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/88833213ca791eed3f762eaf5fcec6b238acdabf"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"minggo","id":488203,"avatar_url":"https://avatars.githubusercontent.com/u/488203?v=3","gravatar_id":"","url":"https://api.github.com/users/minggo","html_url":"https://github.com/minggo","followers_url":"https://api.github.com/users/minggo/followers","following_url":"https://api.github.com/users/minggo/following{/other_user}","gists_url":"https://api.github.com/users/minggo/gists{/gist_id}","starred_url":"https://api.github.com/users/minggo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggo/subscriptions","organizations_url":"https://api.github.com/users/minggo/orgs","repos_url":"https://api.github.com/users/minggo/repos","events_url":"https://api.github.com/users/minggo/events{/privacy}","received_events_url":"https://api.github.com/users/minggo/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":0,"changed_files":1}}