{"action":"created","issue":{"url":"https://api.github.com/repos/playframework/playframework/issues/4948","labels_url":"https://api.github.com/repos/playframework/playframework/issues/4948/labels{/name}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/4948/comments","events_url":"https://api.github.com/repos/playframework/playframework/issues/4948/events","html_url":"https://github.com/playframework/playframework/pull/4948","id":99321669,"number":4948,"title":"Configure the logger for compile time DI","user":{"login":"rmmeans","id":3507512,"avatar_url":"https://avatars.githubusercontent.com/u/3507512?v=3","gravatar_id":"","url":"https://api.github.com/users/rmmeans","html_url":"https://github.com/rmmeans","followers_url":"https://api.github.com/users/rmmeans/followers","following_url":"https://api.github.com/users/rmmeans/following{/other_user}","gists_url":"https://api.github.com/users/rmmeans/gists{/gist_id}","starred_url":"https://api.github.com/users/rmmeans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmmeans/subscriptions","organizations_url":"https://api.github.com/users/rmmeans/orgs","repos_url":"https://api.github.com/users/rmmeans/repos","events_url":"https://api.github.com/users/rmmeans/events{/privacy}","received_events_url":"https://api.github.com/users/rmmeans/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-05T23:35:59Z","updated_at":"2015-08-05T23:37:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/4948","html_url":"https://github.com/playframework/playframework/pull/4948","diff_url":"https://github.com/playframework/playframework/pull/4948.diff","patch_url":"https://github.com/playframework/playframework/pull/4948.patch"},"body":"The logger was not configured for compile time DI helpers like it was configured under the covers for the default Guice based injection. This can lead developers and ops teams into a frenzy trying to figure out why logging won't work via the custom configuration using -Dlogger.resource and -Dlogger.file as the documentation says it should.\r\n\r\nThe proposed solution is to apply the same setup as what is happening in the GuiceApplicationBuilder in the BuiltInComponents trait. I feel that we need to provide these settings by default, or we're going to need to make really clear documentation that if you use compile time DI, you must configure the logger yourself in your Custom Application Loader (workaround for now)"},"comment":{"url":"https://api.github.com/repos/playframework/playframework/issues/comments/128184050","html_url":"https://github.com/playframework/playframework/pull/4948#issuecomment-128184050","issue_url":"https://api.github.com/repos/playframework/playframework/issues/4948","id":128184050,"user":{"login":"rmmeans","id":3507512,"avatar_url":"https://avatars.githubusercontent.com/u/3507512?v=3","gravatar_id":"","url":"https://api.github.com/users/rmmeans","html_url":"https://github.com/rmmeans","followers_url":"https://api.github.com/users/rmmeans/followers","following_url":"https://api.github.com/users/rmmeans/following{/other_user}","gists_url":"https://api.github.com/users/rmmeans/gists{/gist_id}","starred_url":"https://api.github.com/users/rmmeans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmmeans/subscriptions","organizations_url":"https://api.github.com/users/rmmeans/orgs","repos_url":"https://api.github.com/users/rmmeans/repos","events_url":"https://api.github.com/users/rmmeans/events{/privacy}","received_events_url":"https://api.github.com/users/rmmeans/received_events","type":"User","site_admin":false},"created_at":"2015-08-05T23:37:00Z","updated_at":"2015-08-05T23:37:00Z","body":"Not sure the standard practice here -- this change also needs to happen on master. I'm guessing it would have been better to push it at Master, and then backport it? I can open another PR for master if needed."}}