{"action":"created","issue":{"url":"https://api.github.com/repos/CGRU/cgru/issues/156","labels_url":"https://api.github.com/repos/CGRU/cgru/issues/156/labels{/name}","comments_url":"https://api.github.com/repos/CGRU/cgru/issues/156/comments","events_url":"https://api.github.com/repos/CGRU/cgru/issues/156/events","html_url":"https://github.com/CGRU/cgru/issues/156","id":114031522,"number":156,"title":"sourcing setup.sh with zsh","user":{"login":"predat","id":90415,"avatar_url":"https://avatars.githubusercontent.com/u/90415?v=3","gravatar_id":"","url":"https://api.github.com/users/predat","html_url":"https://github.com/predat","followers_url":"https://api.github.com/users/predat/followers","following_url":"https://api.github.com/users/predat/following{/other_user}","gists_url":"https://api.github.com/users/predat/gists{/gist_id}","starred_url":"https://api.github.com/users/predat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/predat/subscriptions","organizations_url":"https://api.github.com/users/predat/orgs","repos_url":"https://api.github.com/users/predat/repos","events_url":"https://api.github.com/users/predat/events{/privacy}","received_events_url":"https://api.github.com/users/predat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-29T11:34:38Z","updated_at":"2015-10-29T13:01:55Z","closed_at":null,"body":"Hello Timur,\r\n\r\nas zsh is my main shell, it has problems to loop over setup files.\r\n```setup_files=`ls setup_*.sh```` is the culprit.\r\n\r\nIs it possible to change setup.sh like this:\r\n```diff\r\ndiff --git a/setup.sh b/setup.sh\r\nindex b12e547..7a39ff3 100755\r\n--- a/setup.sh\r\n+++ b/setup.sh\r\n@@ -22,11 +22,9 @@ export CGRU_VERSION=`cat version.txt`\r\n echo \"CGRU_VERSION $CGRU_VERSION : '$CGRU_LOCATION'\"\r\n \r\n # Source custom setup if any exists:\r\n-setup_files=`ls setup_*.sh`\r\n-if [ ! -z \"$setup_files\" ] ; then\r\n-   for setup_file in $setup_files; do\r\n-      [ -z \"$setup_file\" ] && continue\r\n-      [ -f \"$setup_file\" ] || continue\r\n-      source ./$setup_file \"\"\r\n-   done\r\n-fi\r\n+for setup_file in setup_*.sh\r\n+do\r\n+       [ -z \"$setup_file\"  ] && continue\r\n+       [ -f \"$setup_file\"  ] || continue\r\n+       source ./$setup_file \"\"\r\n+done\r\n```"},"comment":{"url":"https://api.github.com/repos/CGRU/cgru/issues/comments/152173451","html_url":"https://github.com/CGRU/cgru/issues/156#issuecomment-152173451","issue_url":"https://api.github.com/repos/CGRU/cgru/issues/156","id":152173451,"user":{"login":"timurhai","id":1492143,"avatar_url":"https://avatars.githubusercontent.com/u/1492143?v=3","gravatar_id":"","url":"https://api.github.com/users/timurhai","html_url":"https://github.com/timurhai","followers_url":"https://api.github.com/users/timurhai/followers","following_url":"https://api.github.com/users/timurhai/following{/other_user}","gists_url":"https://api.github.com/users/timurhai/gists{/gist_id}","starred_url":"https://api.github.com/users/timurhai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timurhai/subscriptions","organizations_url":"https://api.github.com/users/timurhai/orgs","repos_url":"https://api.github.com/users/timurhai/repos","events_url":"https://api.github.com/users/timurhai/events{/privacy}","received_events_url":"https://api.github.com/users/timurhai/received_events","type":"User","site_admin":false},"created_at":"2015-10-29T13:01:55Z","updated_at":"2015-10-29T13:01:55Z","body":"Hi.\r\nWill it works on bash after it?\r\n\r\nAlso, if there are some incompatible changes, some applications has and various scripts for each shell."}}