{"action":"created","comment":{"url":"https://api.github.com/repos/uber/ringpop/pulls/comments/25906305","id":25906305,"diff_hunk":"@@ -531,23 +531,6 @@ RingPop.prototype.onMemberFaulty = function onMemberFaulty(member) {\n     this.suspicion.stop(member);\n };\n \n-RingPop.prototype.onMemberJoined = function onMemberJoined(member) {\n-    this.stat('increment', 'membership-update.new');\n-    this.logger.debug('member has joined', {\n-        local: this.membership.localMember.address,\n-        joined: member.address\n-    });\n-\n-    this.ring.addServer(member.address);","path":"index.js","position":11,"original_position":11,"commit_id":"f924c099cddc559fe60891c64ebae1c3943add13","original_commit_id":"f924c099cddc559fe60891c64ebae1c3943add13","user":{"login":"jwolski","id":16902,"avatar_url":"https://avatars.githubusercontent.com/u/16902?v=3","gravatar_id":"","url":"https://api.github.com/users/jwolski","html_url":"https://github.com/jwolski","followers_url":"https://api.github.com/users/jwolski/followers","following_url":"https://api.github.com/users/jwolski/following{/other_user}","gists_url":"https://api.github.com/users/jwolski/gists{/gist_id}","starred_url":"https://api.github.com/users/jwolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwolski/subscriptions","organizations_url":"https://api.github.com/users/jwolski/orgs","repos_url":"https://api.github.com/users/jwolski/repos","events_url":"https://api.github.com/users/jwolski/events{/privacy}","received_events_url":"https://api.github.com/users/jwolski/received_events","type":"User","site_admin":false},"body":"when a \"new\" member is added to the membership list, we need to use the status of that member determine how to modify the ring/membership list. Prior to this change, `new` and `alive` were treated the exact same.","created_at":"2015-03-05T22:03:35Z","updated_at":"2015-03-05T22:03:35Z","html_url":"https://github.com/uber/ringpop/pull/43#discussion_r25906305","pull_request_url":"https://api.github.com/repos/uber/ringpop/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/uber/ringpop/pulls/comments/25906305"},"html":{"href":"https://github.com/uber/ringpop/pull/43#discussion_r25906305"},"pull_request":{"href":"https://api.github.com/repos/uber/ringpop/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/uber/ringpop/pulls/43","id":30597489,"html_url":"https://github.com/uber/ringpop/pull/43","diff_url":"https://github.com/uber/ringpop/pull/43.diff","patch_url":"https://github.com/uber/ringpop/pull/43.patch","issue_url":"https://api.github.com/repos/uber/ringpop/issues/43","number":43,"state":"open","locked":false,"title":"Do not assume update type for first time member","user":{"login":"jwolski","id":16902,"avatar_url":"https://avatars.githubusercontent.com/u/16902?v=3","gravatar_id":"","url":"https://api.github.com/users/jwolski","html_url":"https://github.com/jwolski","followers_url":"https://api.github.com/users/jwolski/followers","following_url":"https://api.github.com/users/jwolski/following{/other_user}","gists_url":"https://api.github.com/users/jwolski/gists{/gist_id}","starred_url":"https://api.github.com/users/jwolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwolski/subscriptions","organizations_url":"https://api.github.com/users/jwolski/orgs","repos_url":"https://api.github.com/users/jwolski/repos","events_url":"https://api.github.com/users/jwolski/events{/privacy}","received_events_url":"https://api.github.com/users/jwolski/received_events","type":"User","site_admin":false},"body":"This is a nasty bug in ringpop. Ringpop will assume that the update type is `alive` no matter what the status of the member is at the time they're added into the membership list.\r\n\r\n@Raynos @iproctor @sunweik @robskillington @leizha ","created_at":"2015-03-05T21:29:32Z","updated_at":"2015-03-05T22:03:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"513bb757073b4adae7d8b53ee21382033a84c48c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/ringpop/pulls/43/commits","review_comments_url":"https://api.github.com/repos/uber/ringpop/pulls/43/comments","review_comment_url":"https://api.github.com/repos/uber/ringpop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/ringpop/issues/43/comments","statuses_url":"https://api.github.com/repos/uber/ringpop/statuses/f924c099cddc559fe60891c64ebae1c3943add13","head":{"label":"uber:faultybug","ref":"faultybug","sha":"f924c099cddc559fe60891c64ebae1c3943add13","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":29378455,"name":"ringpop","full_name":"uber/ringpop","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/ringpop","description":"Scalable, fault-tolerant application-layer sharding","fork":false,"url":"https://api.github.com/repos/uber/ringpop","forks_url":"https://api.github.com/repos/uber/ringpop/forks","keys_url":"https://api.github.com/repos/uber/ringpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/ringpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/ringpop/teams","hooks_url":"https://api.github.com/repos/uber/ringpop/hooks","issue_events_url":"https://api.github.com/repos/uber/ringpop/issues/events{/number}","events_url":"https://api.github.com/repos/uber/ringpop/events","assignees_url":"https://api.github.com/repos/uber/ringpop/assignees{/user}","branches_url":"https://api.github.com/repos/uber/ringpop/branches{/branch}","tags_url":"https://api.github.com/repos/uber/ringpop/tags","blobs_url":"https://api.github.com/repos/uber/ringpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/ringpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/ringpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/ringpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/ringpop/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/ringpop/languages","stargazers_url":"https://api.github.com/repos/uber/ringpop/stargazers","contributors_url":"https://api.github.com/repos/uber/ringpop/contributors","subscribers_url":"https://api.github.com/repos/uber/ringpop/subscribers","subscription_url":"https://api.github.com/repos/uber/ringpop/subscription","commits_url":"https://api.github.com/repos/uber/ringpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/ringpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/ringpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/ringpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/ringpop/contents/{+path}","compare_url":"https://api.github.com/repos/uber/ringpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/ringpop/merges","archive_url":"https://api.github.com/repos/uber/ringpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/ringpop/downloads","issues_url":"https://api.github.com/repos/uber/ringpop/issues{/number}","pulls_url":"https://api.github.com/repos/uber/ringpop/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/ringpop/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/ringpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/ringpop/labels{/name}","releases_url":"https://api.github.com/repos/uber/ringpop/releases{/id}","created_at":"2015-01-17T03:26:35Z","updated_at":"2015-03-05T05:16:04Z","pushed_at":"2015-03-05T21:58:54Z","git_url":"git://github.com/uber/ringpop.git","ssh_url":"git@github.com:uber/ringpop.git","clone_url":"https://github.com/uber/ringpop.git","svn_url":"https://github.com/uber/ringpop","homepage":"","size":2008,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":20,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"9a0ae8745fabae7d76ce07a87388c1461b2c89bb","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":29378455,"name":"ringpop","full_name":"uber/ringpop","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/ringpop","description":"Scalable, fault-tolerant application-layer sharding","fork":false,"url":"https://api.github.com/repos/uber/ringpop","forks_url":"https://api.github.com/repos/uber/ringpop/forks","keys_url":"https://api.github.com/repos/uber/ringpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/ringpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/ringpop/teams","hooks_url":"https://api.github.com/repos/uber/ringpop/hooks","issue_events_url":"https://api.github.com/repos/uber/ringpop/issues/events{/number}","events_url":"https://api.github.com/repos/uber/ringpop/events","assignees_url":"https://api.github.com/repos/uber/ringpop/assignees{/user}","branches_url":"https://api.github.com/repos/uber/ringpop/branches{/branch}","tags_url":"https://api.github.com/repos/uber/ringpop/tags","blobs_url":"https://api.github.com/repos/uber/ringpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/ringpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/ringpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/ringpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/ringpop/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/ringpop/languages","stargazers_url":"https://api.github.com/repos/uber/ringpop/stargazers","contributors_url":"https://api.github.com/repos/uber/ringpop/contributors","subscribers_url":"https://api.github.com/repos/uber/ringpop/subscribers","subscription_url":"https://api.github.com/repos/uber/ringpop/subscription","commits_url":"https://api.github.com/repos/uber/ringpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/ringpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/ringpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/ringpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/ringpop/contents/{+path}","compare_url":"https://api.github.com/repos/uber/ringpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/ringpop/merges","archive_url":"https://api.github.com/repos/uber/ringpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/ringpop/downloads","issues_url":"https://api.github.com/repos/uber/ringpop/issues{/number}","pulls_url":"https://api.github.com/repos/uber/ringpop/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/ringpop/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/ringpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/ringpop/labels{/name}","releases_url":"https://api.github.com/repos/uber/ringpop/releases{/id}","created_at":"2015-01-17T03:26:35Z","updated_at":"2015-03-05T05:16:04Z","pushed_at":"2015-03-05T21:58:54Z","git_url":"git://github.com/uber/ringpop.git","ssh_url":"git@github.com:uber/ringpop.git","clone_url":"https://github.com/uber/ringpop.git","svn_url":"https://github.com/uber/ringpop","homepage":"","size":2008,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/ringpop/pulls/43"},"html":{"href":"https://github.com/uber/ringpop/pull/43"},"issue":{"href":"https://api.github.com/repos/uber/ringpop/issues/43"},"comments":{"href":"https://api.github.com/repos/uber/ringpop/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/ringpop/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/ringpop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/ringpop/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/uber/ringpop/statuses/f924c099cddc559fe60891c64ebae1c3943add13"}}}}