{"action":"created","comment":{"url":"https://api.github.com/repos/nemomobile/libqofono/pulls/comments/42065028","id":42065028,"diff_hunk":"@@ -106,6 +106,7 @@ void QOfonoManager::onModemRemoved(const QDBusObjectPath& path)\n void QOfonoManager::onGetModemsFinished(QDBusPendingCallWatcher* watcher)\n {\n     QDBusPendingReply<ObjectPathPropertiesList> reply(*watcher);\n+    watcher->deleteLater();","path":"src/qofonomanager.cpp","position":4,"original_position":4,"commit_id":"78b67573e5be385d0821e739566fea8961fbe25c","original_commit_id":"78b67573e5be385d0821e739566fea8961fbe25c","user":{"login":"matthewvogt","id":2569784,"avatar_url":"https://avatars.githubusercontent.com/u/2569784?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewvogt","html_url":"https://github.com/matthewvogt","followers_url":"https://api.github.com/users/matthewvogt/followers","following_url":"https://api.github.com/users/matthewvogt/following{/other_user}","gists_url":"https://api.github.com/users/matthewvogt/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewvogt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewvogt/subscriptions","organizations_url":"https://api.github.com/users/matthewvogt/orgs","repos_url":"https://api.github.com/users/matthewvogt/repos","events_url":"https://api.github.com/users/matthewvogt/events{/privacy}","received_events_url":"https://api.github.com/users/matthewvogt/received_events","type":"User","site_admin":false},"body":"I don't understand how this changes anything.  The watcher won't be deleted unless control returns to the event loop, and I don't see anything between here and line 127 that looks like it will affect the event loop.","created_at":"2015-10-14T22:59:12Z","updated_at":"2015-10-14T22:59:12Z","html_url":"https://github.com/nemomobile/libqofono/pull/88#discussion_r42065028","pull_request_url":"https://api.github.com/repos/nemomobile/libqofono/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/nemomobile/libqofono/pulls/comments/42065028"},"html":{"href":"https://github.com/nemomobile/libqofono/pull/88#discussion_r42065028"},"pull_request":{"href":"https://api.github.com/repos/nemomobile/libqofono/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/nemomobile/libqofono/pulls/88","id":47595581,"html_url":"https://github.com/nemomobile/libqofono/pull/88","diff_url":"https://github.com/nemomobile/libqofono/pull/88.diff","patch_url":"https://github.com/nemomobile/libqofono/pull/88.patch","issue_url":"https://api.github.com/repos/nemomobile/libqofono/issues/88","number":88,"state":"open","locked":false,"title":"Fix nemo-transfer-engine crashes","user":{"login":"monich","id":5909522,"avatar_url":"https://avatars.githubusercontent.com/u/5909522?v=3","gravatar_id":"","url":"https://api.github.com/users/monich","html_url":"https://github.com/monich","followers_url":"https://api.github.com/users/monich/followers","following_url":"https://api.github.com/users/monich/following{/other_user}","gists_url":"https://api.github.com/users/monich/gists{/gist_id}","starred_url":"https://api.github.com/users/monich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monich/subscriptions","organizations_url":"https://api.github.com/users/monich/orgs","repos_url":"https://api.github.com/users/monich/repos","events_url":"https://api.github.com/users/monich/events{/privacy}","received_events_url":"https://api.github.com/users/monich/received_events","type":"User","site_admin":false},"body":"Basically, if a QObject emits a signal, the signal handler can directly or indirectly delete QObject that issued the signal. Normally, this sort of problem is easy to resolve by temporarily incrementing object's refcount but since QObject isn't refcountable... I couldn't come up with anything better than this.\r\n\r\nEach of these commits would fix the crash in question but they both make sense to me, I couldn't decide which one is better and left both in.","created_at":"2015-10-13T22:11:23Z","updated_at":"2015-10-14T22:59:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a50662ac53b0a83385066b9acf4ba806db527697","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nemomobile/libqofono/pulls/88/commits","review_comments_url":"https://api.github.com/repos/nemomobile/libqofono/pulls/88/comments","review_comment_url":"https://api.github.com/repos/nemomobile/libqofono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nemomobile/libqofono/issues/88/comments","statuses_url":"https://api.github.com/repos/nemomobile/libqofono/statuses/78b67573e5be385d0821e739566fea8961fbe25c","head":{"label":"monich:jb32810","ref":"jb32810","sha":"78b67573e5be385d0821e739566fea8961fbe25c","user":{"login":"monich","id":5909522,"avatar_url":"https://avatars.githubusercontent.com/u/5909522?v=3","gravatar_id":"","url":"https://api.github.com/users/monich","html_url":"https://github.com/monich","followers_url":"https://api.github.com/users/monich/followers","following_url":"https://api.github.com/users/monich/following{/other_user}","gists_url":"https://api.github.com/users/monich/gists{/gist_id}","starred_url":"https://api.github.com/users/monich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monich/subscriptions","organizations_url":"https://api.github.com/users/monich/orgs","repos_url":"https://api.github.com/users/monich/repos","events_url":"https://api.github.com/users/monich/events{/privacy}","received_events_url":"https://api.github.com/users/monich/received_events","type":"User","site_admin":false},"repo":{"id":16818667,"name":"libqofono","full_name":"monich/libqofono","owner":{"login":"monich","id":5909522,"avatar_url":"https://avatars.githubusercontent.com/u/5909522?v=3","gravatar_id":"","url":"https://api.github.com/users/monich","html_url":"https://github.com/monich","followers_url":"https://api.github.com/users/monich/followers","following_url":"https://api.github.com/users/monich/following{/other_user}","gists_url":"https://api.github.com/users/monich/gists{/gist_id}","starred_url":"https://api.github.com/users/monich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monich/subscriptions","organizations_url":"https://api.github.com/users/monich/orgs","repos_url":"https://api.github.com/users/monich/repos","events_url":"https://api.github.com/users/monich/events{/privacy}","received_events_url":"https://api.github.com/users/monich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/monich/libqofono","description":"Rewritten version of libofono-qt","fork":true,"url":"https://api.github.com/repos/monich/libqofono","forks_url":"https://api.github.com/repos/monich/libqofono/forks","keys_url":"https://api.github.com/repos/monich/libqofono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monich/libqofono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monich/libqofono/teams","hooks_url":"https://api.github.com/repos/monich/libqofono/hooks","issue_events_url":"https://api.github.com/repos/monich/libqofono/issues/events{/number}","events_url":"https://api.github.com/repos/monich/libqofono/events","assignees_url":"https://api.github.com/repos/monich/libqofono/assignees{/user}","branches_url":"https://api.github.com/repos/monich/libqofono/branches{/branch}","tags_url":"https://api.github.com/repos/monich/libqofono/tags","blobs_url":"https://api.github.com/repos/monich/libqofono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monich/libqofono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monich/libqofono/git/refs{/sha}","trees_url":"https://api.github.com/repos/monich/libqofono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monich/libqofono/statuses/{sha}","languages_url":"https://api.github.com/repos/monich/libqofono/languages","stargazers_url":"https://api.github.com/repos/monich/libqofono/stargazers","contributors_url":"https://api.github.com/repos/monich/libqofono/contributors","subscribers_url":"https://api.github.com/repos/monich/libqofono/subscribers","subscription_url":"https://api.github.com/repos/monich/libqofono/subscription","commits_url":"https://api.github.com/repos/monich/libqofono/commits{/sha}","git_commits_url":"https://api.github.com/repos/monich/libqofono/git/commits{/sha}","comments_url":"https://api.github.com/repos/monich/libqofono/comments{/number}","issue_comment_url":"https://api.github.com/repos/monich/libqofono/issues/comments{/number}","contents_url":"https://api.github.com/repos/monich/libqofono/contents/{+path}","compare_url":"https://api.github.com/repos/monich/libqofono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monich/libqofono/merges","archive_url":"https://api.github.com/repos/monich/libqofono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monich/libqofono/downloads","issues_url":"https://api.github.com/repos/monich/libqofono/issues{/number}","pulls_url":"https://api.github.com/repos/monich/libqofono/pulls{/number}","milestones_url":"https://api.github.com/repos/monich/libqofono/milestones{/number}","notifications_url":"https://api.github.com/repos/monich/libqofono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monich/libqofono/labels{/name}","releases_url":"https://api.github.com/repos/monich/libqofono/releases{/id}","created_at":"2014-02-13T22:00:27Z","updated_at":"2015-04-23T09:21:00Z","pushed_at":"2015-10-13T21:53:32Z","git_url":"git://github.com/monich/libqofono.git","ssh_url":"git@github.com:monich/libqofono.git","clone_url":"https://github.com/monich/libqofono.git","svn_url":"https://github.com/monich/libqofono","homepage":null,"size":1390,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nemomobile:master","ref":"master","sha":"7676636a619bc1d09f64c95dd0141621c42bcf94","user":{"login":"nemomobile","id":1088947,"avatar_url":"https://avatars.githubusercontent.com/u/1088947?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile","html_url":"https://github.com/nemomobile","followers_url":"https://api.github.com/users/nemomobile/followers","following_url":"https://api.github.com/users/nemomobile/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile/subscriptions","organizations_url":"https://api.github.com/users/nemomobile/orgs","repos_url":"https://api.github.com/users/nemomobile/repos","events_url":"https://api.github.com/users/nemomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile/received_events","type":"Organization","site_admin":false},"repo":{"id":7874435,"name":"libqofono","full_name":"nemomobile/libqofono","owner":{"login":"nemomobile","id":1088947,"avatar_url":"https://avatars.githubusercontent.com/u/1088947?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile","html_url":"https://github.com/nemomobile","followers_url":"https://api.github.com/users/nemomobile/followers","following_url":"https://api.github.com/users/nemomobile/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile/subscriptions","organizations_url":"https://api.github.com/users/nemomobile/orgs","repos_url":"https://api.github.com/users/nemomobile/repos","events_url":"https://api.github.com/users/nemomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nemomobile/libqofono","description":"Rewritten version of libofono-qt","fork":false,"url":"https://api.github.com/repos/nemomobile/libqofono","forks_url":"https://api.github.com/repos/nemomobile/libqofono/forks","keys_url":"https://api.github.com/repos/nemomobile/libqofono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nemomobile/libqofono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nemomobile/libqofono/teams","hooks_url":"https://api.github.com/repos/nemomobile/libqofono/hooks","issue_events_url":"https://api.github.com/repos/nemomobile/libqofono/issues/events{/number}","events_url":"https://api.github.com/repos/nemomobile/libqofono/events","assignees_url":"https://api.github.com/repos/nemomobile/libqofono/assignees{/user}","branches_url":"https://api.github.com/repos/nemomobile/libqofono/branches{/branch}","tags_url":"https://api.github.com/repos/nemomobile/libqofono/tags","blobs_url":"https://api.github.com/repos/nemomobile/libqofono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nemomobile/libqofono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nemomobile/libqofono/git/refs{/sha}","trees_url":"https://api.github.com/repos/nemomobile/libqofono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nemomobile/libqofono/statuses/{sha}","languages_url":"https://api.github.com/repos/nemomobile/libqofono/languages","stargazers_url":"https://api.github.com/repos/nemomobile/libqofono/stargazers","contributors_url":"https://api.github.com/repos/nemomobile/libqofono/contributors","subscribers_url":"https://api.github.com/repos/nemomobile/libqofono/subscribers","subscription_url":"https://api.github.com/repos/nemomobile/libqofono/subscription","commits_url":"https://api.github.com/repos/nemomobile/libqofono/commits{/sha}","git_commits_url":"https://api.github.com/repos/nemomobile/libqofono/git/commits{/sha}","comments_url":"https://api.github.com/repos/nemomobile/libqofono/comments{/number}","issue_comment_url":"https://api.github.com/repos/nemomobile/libqofono/issues/comments{/number}","contents_url":"https://api.github.com/repos/nemomobile/libqofono/contents/{+path}","compare_url":"https://api.github.com/repos/nemomobile/libqofono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nemomobile/libqofono/merges","archive_url":"https://api.github.com/repos/nemomobile/libqofono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nemomobile/libqofono/downloads","issues_url":"https://api.github.com/repos/nemomobile/libqofono/issues{/number}","pulls_url":"https://api.github.com/repos/nemomobile/libqofono/pulls{/number}","milestones_url":"https://api.github.com/repos/nemomobile/libqofono/milestones{/number}","notifications_url":"https://api.github.com/repos/nemomobile/libqofono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nemomobile/libqofono/labels{/name}","releases_url":"https://api.github.com/repos/nemomobile/libqofono/releases{/id}","created_at":"2013-01-28T17:04:20Z","updated_at":"2015-04-26T15:48:12Z","pushed_at":"2015-10-13T22:11:23Z","git_url":"git://github.com/nemomobile/libqofono.git","ssh_url":"git@github.com:nemomobile/libqofono.git","clone_url":"https://github.com/nemomobile/libqofono.git","svn_url":"https://github.com/nemomobile/libqofono","homepage":null,"size":1799,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":2,"forks":21,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nemomobile/libqofono/pulls/88"},"html":{"href":"https://github.com/nemomobile/libqofono/pull/88"},"issue":{"href":"https://api.github.com/repos/nemomobile/libqofono/issues/88"},"comments":{"href":"https://api.github.com/repos/nemomobile/libqofono/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/nemomobile/libqofono/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/nemomobile/libqofono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nemomobile/libqofono/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/nemomobile/libqofono/statuses/78b67573e5be385d0821e739566fea8961fbe25c"}}}}