{"action":"created","comment":{"url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/comments/24301414","id":24301414,"diff_hunk":"@@ -89,26 +100,28 @@ class FtdiWidgetInfo {\n     std::string m_name;\n     std::string m_serial;\n     int unsigned m_id;\n+    int m_vid;\n+    int m_pid;\n };\n \n-\n /**\n  * An FTDI widget\n  */\n class FtdiWidget {\n  public:\n-    static const int VID = 0x0403;  // FTDI Vendor ID\n-    static const int PID = 0x6001;  // FTDI Product ID\n-\n     /**\n      * Construct a new FtdiWidget instance for one widget.\n      * @param serial The widget's USB serial number\n      * @param name The widget's USB name (description)\n      * @param id The ID of the device (used only when FTD2XX is the backend)\n+     * @param vid The VendorID of the device, defaults to old value of FtdiWidget::VID","path":"plugins/ftdidmx/FtdiWidget.h","position":98,"original_position":96,"commit_id":"7b5b8b0f607306bcc3cab1394aea52f94d7f415a","original_commit_id":"130c4fa04e8f7483de98b321db0cb5b15a543250","user":{"login":"peternewman","id":6216436,"avatar_url":"https://avatars.githubusercontent.com/u/6216436?v=3","gravatar_id":"","url":"https://api.github.com/users/peternewman","html_url":"https://github.com/peternewman","followers_url":"https://api.github.com/users/peternewman/followers","following_url":"https://api.github.com/users/peternewman/following{/other_user}","gists_url":"https://api.github.com/users/peternewman/gists{/gist_id}","starred_url":"https://api.github.com/users/peternewman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peternewman/subscriptions","organizations_url":"https://api.github.com/users/peternewman/orgs","repos_url":"https://api.github.com/users/peternewman/repos","events_url":"https://api.github.com/users/peternewman/events{/privacy}","received_events_url":"https://api.github.com/users/peternewman/received_events","type":"User","site_admin":false},"body":"@Keeper-of-the-Keys this still needs fixing please.","created_at":"2015-02-08T19:30:30Z","updated_at":"2015-02-08T19:30:30Z","html_url":"https://github.com/OpenLightingProject/ola/pull/433#discussion_r24301414","pull_request_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/433","_links":{"self":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/comments/24301414"},"html":{"href":"https://github.com/OpenLightingProject/ola/pull/433#discussion_r24301414"},"pull_request":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/433"}}},"pull_request":{"url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/433","id":18365752,"html_url":"https://github.com/OpenLightingProject/ola/pull/433","diff_url":"https://github.com/OpenLightingProject/ola/pull/433.diff","patch_url":"https://github.com/OpenLightingProject/ola/pull/433.patch","issue_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/433","number":433,"state":"open","locked":false,"title":"Ftdi Support for chips with multiple interfaces (ie. FT4232H, 4 interfaces)","user":{"login":"Keeper-of-the-Keys","id":1500246,"avatar_url":"https://avatars.githubusercontent.com/u/1500246?v=3","gravatar_id":"","url":"https://api.github.com/users/Keeper-of-the-Keys","html_url":"https://github.com/Keeper-of-the-Keys","followers_url":"https://api.github.com/users/Keeper-of-the-Keys/followers","following_url":"https://api.github.com/users/Keeper-of-the-Keys/following{/other_user}","gists_url":"https://api.github.com/users/Keeper-of-the-Keys/gists{/gist_id}","starred_url":"https://api.github.com/users/Keeper-of-the-Keys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keeper-of-the-Keys/subscriptions","organizations_url":"https://api.github.com/users/Keeper-of-the-Keys/orgs","repos_url":"https://api.github.com/users/Keeper-of-the-Keys/repos","events_url":"https://api.github.com/users/Keeper-of-the-Keys/events{/privacy}","received_events_url":"https://api.github.com/users/Keeper-of-the-Keys/received_events","type":"User","site_admin":false},"body":"This was originally meant a scratch to be redone, as far as I recall the code isn't too terrible, but if you think I need to clean up more and split FtdiInterface into seperate .h and .c files I'll be happy to sit down more on it.\r\n\r\nI really wanted to do more work before I sent the pull req but I see I haven't had time to work on it for a while and it's a pity to let it sit. ","created_at":"2014-07-14T18:40:16Z","updated_at":"2015-02-08T19:30:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f908da0acd43a6633ff0d79690cf6c1f2a288fe2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/433/commits","review_comments_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/433/comments","review_comment_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls/comments/{number}","comments_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/433/comments","statuses_url":"https://api.github.com/repos/OpenLightingProject/ola/statuses/7b5b8b0f607306bcc3cab1394aea52f94d7f415a","head":{"label":"Keeper-of-the-Keys:ftdi_scratch","ref":"ftdi_scratch","sha":"7b5b8b0f607306bcc3cab1394aea52f94d7f415a","user":{"login":"Keeper-of-the-Keys","id":1500246,"avatar_url":"https://avatars.githubusercontent.com/u/1500246?v=3","gravatar_id":"","url":"https://api.github.com/users/Keeper-of-the-Keys","html_url":"https://github.com/Keeper-of-the-Keys","followers_url":"https://api.github.com/users/Keeper-of-the-Keys/followers","following_url":"https://api.github.com/users/Keeper-of-the-Keys/following{/other_user}","gists_url":"https://api.github.com/users/Keeper-of-the-Keys/gists{/gist_id}","starred_url":"https://api.github.com/users/Keeper-of-the-Keys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keeper-of-the-Keys/subscriptions","organizations_url":"https://api.github.com/users/Keeper-of-the-Keys/orgs","repos_url":"https://api.github.com/users/Keeper-of-the-Keys/repos","events_url":"https://api.github.com/users/Keeper-of-the-Keys/events{/privacy}","received_events_url":"https://api.github.com/users/Keeper-of-the-Keys/received_events","type":"User","site_admin":false},"repo":{"id":18859745,"name":"ola","full_name":"Keeper-of-the-Keys/ola","owner":{"login":"Keeper-of-the-Keys","id":1500246,"avatar_url":"https://avatars.githubusercontent.com/u/1500246?v=3","gravatar_id":"","url":"https://api.github.com/users/Keeper-of-the-Keys","html_url":"https://github.com/Keeper-of-the-Keys","followers_url":"https://api.github.com/users/Keeper-of-the-Keys/followers","following_url":"https://api.github.com/users/Keeper-of-the-Keys/following{/other_user}","gists_url":"https://api.github.com/users/Keeper-of-the-Keys/gists{/gist_id}","starred_url":"https://api.github.com/users/Keeper-of-the-Keys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keeper-of-the-Keys/subscriptions","organizations_url":"https://api.github.com/users/Keeper-of-the-Keys/orgs","repos_url":"https://api.github.com/users/Keeper-of-the-Keys/repos","events_url":"https://api.github.com/users/Keeper-of-the-Keys/events{/privacy}","received_events_url":"https://api.github.com/users/Keeper-of-the-Keys/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Keeper-of-the-Keys/ola","description":"The Open Lighting Architecture","fork":true,"url":"https://api.github.com/repos/Keeper-of-the-Keys/ola","forks_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/forks","keys_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/teams","hooks_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/hooks","issue_events_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/issues/events{/number}","events_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/events","assignees_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/assignees{/user}","branches_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/branches{/branch}","tags_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/tags","blobs_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/git/refs{/sha}","trees_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/statuses/{sha}","languages_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/languages","stargazers_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/stargazers","contributors_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/contributors","subscribers_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/subscribers","subscription_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/subscription","commits_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/commits{/sha}","git_commits_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/git/commits{/sha}","comments_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/comments{/number}","issue_comment_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/issues/comments/{number}","contents_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/contents/{+path}","compare_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/merges","archive_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/downloads","issues_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/issues{/number}","pulls_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/pulls{/number}","milestones_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/milestones{/number}","notifications_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/labels{/name}","releases_url":"https://api.github.com/repos/Keeper-of-the-Keys/ola/releases{/id}","created_at":"2014-04-16T23:09:57Z","updated_at":"2015-01-04T12:45:36Z","pushed_at":"2015-02-08T17:49:05Z","git_url":"git://github.com/Keeper-of-the-Keys/ola.git","ssh_url":"git@github.com:Keeper-of-the-Keys/ola.git","clone_url":"https://github.com/Keeper-of-the-Keys/ola.git","svn_url":"https://github.com/Keeper-of-the-Keys/ola","homepage":null,"size":14851,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenLightingProject:master","ref":"master","sha":"2d050602da3e0fdacf2073ba28cf0b11d6de5ff4","user":{"login":"OpenLightingProject","id":6199314,"avatar_url":"https://avatars.githubusercontent.com/u/6199314?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenLightingProject","html_url":"https://github.com/OpenLightingProject","followers_url":"https://api.github.com/users/OpenLightingProject/followers","following_url":"https://api.github.com/users/OpenLightingProject/following{/other_user}","gists_url":"https://api.github.com/users/OpenLightingProject/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLightingProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLightingProject/subscriptions","organizations_url":"https://api.github.com/users/OpenLightingProject/orgs","repos_url":"https://api.github.com/users/OpenLightingProject/repos","events_url":"https://api.github.com/users/OpenLightingProject/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLightingProject/received_events","type":"Organization","site_admin":false},"repo":{"id":15233168,"name":"ola","full_name":"OpenLightingProject/ola","owner":{"login":"OpenLightingProject","id":6199314,"avatar_url":"https://avatars.githubusercontent.com/u/6199314?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenLightingProject","html_url":"https://github.com/OpenLightingProject","followers_url":"https://api.github.com/users/OpenLightingProject/followers","following_url":"https://api.github.com/users/OpenLightingProject/following{/other_user}","gists_url":"https://api.github.com/users/OpenLightingProject/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenLightingProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenLightingProject/subscriptions","organizations_url":"https://api.github.com/users/OpenLightingProject/orgs","repos_url":"https://api.github.com/users/OpenLightingProject/repos","events_url":"https://api.github.com/users/OpenLightingProject/events{/privacy}","received_events_url":"https://api.github.com/users/OpenLightingProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenLightingProject/ola","description":"The Open Lighting Architecture","fork":false,"url":"https://api.github.com/repos/OpenLightingProject/ola","forks_url":"https://api.github.com/repos/OpenLightingProject/ola/forks","keys_url":"https://api.github.com/repos/OpenLightingProject/ola/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenLightingProject/ola/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenLightingProject/ola/teams","hooks_url":"https://api.github.com/repos/OpenLightingProject/ola/hooks","issue_events_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/events{/number}","events_url":"https://api.github.com/repos/OpenLightingProject/ola/events","assignees_url":"https://api.github.com/repos/OpenLightingProject/ola/assignees{/user}","branches_url":"https://api.github.com/repos/OpenLightingProject/ola/branches{/branch}","tags_url":"https://api.github.com/repos/OpenLightingProject/ola/tags","blobs_url":"https://api.github.com/repos/OpenLightingProject/ola/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenLightingProject/ola/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenLightingProject/ola/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenLightingProject/ola/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenLightingProject/ola/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenLightingProject/ola/languages","stargazers_url":"https://api.github.com/repos/OpenLightingProject/ola/stargazers","contributors_url":"https://api.github.com/repos/OpenLightingProject/ola/contributors","subscribers_url":"https://api.github.com/repos/OpenLightingProject/ola/subscribers","subscription_url":"https://api.github.com/repos/OpenLightingProject/ola/subscription","commits_url":"https://api.github.com/repos/OpenLightingProject/ola/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenLightingProject/ola/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenLightingProject/ola/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenLightingProject/ola/issues/comments/{number}","contents_url":"https://api.github.com/repos/OpenLightingProject/ola/contents/{+path}","compare_url":"https://api.github.com/repos/OpenLightingProject/ola/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenLightingProject/ola/merges","archive_url":"https://api.github.com/repos/OpenLightingProject/ola/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenLightingProject/ola/downloads","issues_url":"https://api.github.com/repos/OpenLightingProject/ola/issues{/number}","pulls_url":"https://api.github.com/repos/OpenLightingProject/ola/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenLightingProject/ola/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenLightingProject/ola/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenLightingProject/ola/labels{/name}","releases_url":"https://api.github.com/repos/OpenLightingProject/ola/releases{/id}","created_at":"2013-12-16T18:06:52Z","updated_at":"2015-02-08T19:13:08Z","pushed_at":"2015-02-08T19:13:08Z","git_url":"git://github.com/OpenLightingProject/ola.git","ssh_url":"git@github.com:OpenLightingProject/ola.git","clone_url":"https://github.com/OpenLightingProject/ola.git","svn_url":"https://github.com/OpenLightingProject/ola","homepage":"https://www.openlighting.org/ola/","size":21023,"stargazers_count":67,"watchers_count":67,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":72,"forks":40,"open_issues":72,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/433"},"html":{"href":"https://github.com/OpenLightingProject/ola/pull/433"},"issue":{"href":"https://api.github.com/repos/OpenLightingProject/ola/issues/433"},"comments":{"href":"https://api.github.com/repos/OpenLightingProject/ola/issues/433/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/433/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/OpenLightingProject/ola/pulls/433/commits"},"statuses":{"href":"https://api.github.com/repos/OpenLightingProject/ola/statuses/7b5b8b0f607306bcc3cab1394aea52f94d7f415a"}}}}