{"action":"created","comment":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/27542378","id":27542378,"diff_hunk":"@@ -1,247 +1,191 @@\n //= depend_on_asset \"active_admin/datepicker/datepicker-input-icon.png\"\n-// -------------------------------------- Active Admin Forms\n-form {\n-  /* Reset margins & Padding */\n-  ul, ol, li, fieldset, legend, input, textarea, select, p { margin:0; padding:0; }\n-  ol, ul { list-style: none }\n+\n+input[type=text],\n+input[type=password],\n+input[type=email],\n+input[type=number],\n+input[type=url],\n+input[type=tel],\n+textarea {\n+  border: $border-width solid #c9d0d6;\n+  border-radius: 3px;\n+  display: inline-block;\n+  outline: none;\n+  padding: 6px 8px;\n+  width: calc(80% - #{$text-input-total-padding});\n+\n+  &:focus {\n+    border: $border-width solid #99a2aa;\n+    box-shadow: 0 0 4px #99a2aa;\n+  }\n+}\n+\n+.formtastic {\n+  ol, ul {\n+    list-style: none;\n+    margin: 0;\n+    padding: 0;\n+  }\n+\n+  .hidden {\n+    display: none;\n+  }\n+\n+  .input {\n+    margin-bottom: 15px;\n+  }\n+\n+  .label {\n+    color: $form-label-color;\n+    display: block;\n+    float: left;\n+    font-weight: bold;\n+    width: 20%;\n+\n+    abbr {\n+      border: none;\n+      color:  $required-field-marker-color;\n+      margin-left: 0.3em;\n+    }\n+  }\n+\n+  .inputs {\n+    @include section-background;\n+\n+    > ol {\n+      padding: 15px;\n+    }\n+  }\n \n   fieldset {\n     border: 0;\n-    padding: 10px 0;\n-    margin-bottom: 20px;\n-\n-    &.inputs { @include section-background; }\n+    margin: 0 0 20px 0;\n+    padding: 0;\n+    position: relative; // for abosolute positioning sub fieldset legends for choices/fragments\n \n     legend {\n       width: 100%;\n-      span { display: block; @include section-header; }\n-    }\n \n-    ol > li {\n-      padding: 10px;\n-      label {\n+      span {\n         display: block;\n-        width: 20%;\n-        float: left;\n-        font-size: 1.0em;\n-        font-weight: bold;\n-        color: $form-label-color;\n-        abbr {\n-          border: none;\n-          color:  $required-field-marker-color;\n-        }\n+        @include section-header;\n       }\n     }\n \n-    ol > li.has_many_container {\n-      padding: 20px 10px;\n+    .has_many_container {\n       h3 {\n-        font-size: 12px;\n-        font-weight: bold;\n-      }\n-      .has_many_fields { margin: 10px 0 }\n-    }\n-\n-    ol > li > li label {\n-      line-height:100%;\n-      padding-top:0;\n-      input {\n-        line-height:100%;\n-        vertical-align:middle;\n-        margin-top:-0.1em;\n+        border-bottom: 1px solid #e8e8e8;\n+        margin-bottom: 20px;\n       }\n     }\n   }\n \n   // relative so the absolutely-positioned handle will fit\n-  .has_many_fields { position: relative }\n+  .has_many_fields {\n+    border-bottom: 1px solid #e8e8e8;","path":"app/assets/stylesheets/active_admin/_forms.scss","position":124,"original_position":124,"commit_id":"a211e52a9d52132fd82e1a9b5b3abf57fafa1ed6","original_commit_id":"a211e52a9d52132fd82e1a9b5b3abf57fafa1ed6","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Color literals like `#e8e8e8` should only be used in variable declarations; they should be referred to via variable everywhere else.","created_at":"2015-04-01T03:24:34Z","updated_at":"2015-04-01T03:24:34Z","html_url":"https://github.com/activeadmin/activeadmin/pull/3862#discussion_r27542378","pull_request_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862","_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/27542378"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/3862#discussion_r27542378"},"pull_request":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862"}}},"pull_request":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862","id":31797608,"html_url":"https://github.com/activeadmin/activeadmin/pull/3862","diff_url":"https://github.com/activeadmin/activeadmin/pull/3862.diff","patch_url":"https://github.com/activeadmin/activeadmin/pull/3862.patch","issue_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3862","number":3862,"state":"open","locked":false,"title":"WIP: Overhaul CSS for maintainability and customization","user":{"login":"javierjulio","id":198547,"avatar_url":"https://avatars.githubusercontent.com/u/198547?v=3","gravatar_id":"","url":"https://api.github.com/users/javierjulio","html_url":"https://github.com/javierjulio","followers_url":"https://api.github.com/users/javierjulio/followers","following_url":"https://api.github.com/users/javierjulio/following{/other_user}","gists_url":"https://api.github.com/users/javierjulio/gists{/gist_id}","starred_url":"https://api.github.com/users/javierjulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierjulio/subscriptions","organizations_url":"https://api.github.com/users/javierjulio/orgs","repos_url":"https://api.github.com/users/javierjulio/repos","events_url":"https://api.github.com/users/javierjulio/events{/privacy}","received_events_url":"https://api.github.com/users/javierjulio/received_events","type":"User","site_admin":false},"body":"I've seen mention about CSS overhauls but nothing seems active, if anything years old. I'm streamlining the CSS to make it easier to maintain, improve and customize. This should make it much easier to move to a framework like Bootstrap or Foundation.\r\n\r\n- [x] Replace reset with normalize.css (resets make debugging horrendously difficult)\r\n- [ ] Remove excessive styles e.g. gradients, shadows (keep default theme basic, only what’s necessary and we can build from there)\r\n- [ ] Remove unnecessary styles (many have no effect or are repetitive, apply smarter defaults)\r\n  - [x] Clean up typography\r\n  - [x] Replace strip table even/odd classes with nth-child selectors \r\n  - [x] Fix calc in forms due to box-sizing:border-box global change\r\n- [ ] Reduce selector specificity (3 ids and 1 class in one selector 😩)\r\n- [ ] Replace id based selectors with class based ones but keeping ids in HTML in place\r\n- [x] Streamline Formtastic CSS (I've done the best I can here in just CSS, would to need to tweak HTML)\r\n- [ ] Deploy demo app to Heroku to demonstrate changes\r\n- [ ] Configure component styles using variables (e.g. Foundation)\r\n- [ ] Stop Hound'n me!\r\n- [ ] Summery of removed assets and removed SASS variables for the changelog (by @timoschilling)\r\n\r\n## How can you help?\r\n\r\n* use my branch to test out how the changes are affecting your admin\r\n* there is an icons mixin file, where and how is that used? sample code?\r\n* translate new \"commented on\" locale text for other languages\r\n* sample code for other ActiveAdmin features to include in the generated test project, features I don’t know (tabs in header, icons, popovers, modals, etc.)\r\n\r\n## Tasks when merging\r\n\r\n* New locale text \"commented on\" for Comments (only added to `config/locales/en.yml`)","created_at":"2015-03-24T05:04:13Z","updated_at":"2015-04-01T03:24:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fc7f20d22547e00d8e86c1de07465620a991e15","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862/commits","review_comments_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862/comments","review_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3862/comments","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/a211e52a9d52132fd82e1a9b5b3abf57fafa1ed6","head":{"label":"javierjulio:update-css-with-overhaul","ref":"update-css-with-overhaul","sha":"a211e52a9d52132fd82e1a9b5b3abf57fafa1ed6","user":{"login":"javierjulio","id":198547,"avatar_url":"https://avatars.githubusercontent.com/u/198547?v=3","gravatar_id":"","url":"https://api.github.com/users/javierjulio","html_url":"https://github.com/javierjulio","followers_url":"https://api.github.com/users/javierjulio/followers","following_url":"https://api.github.com/users/javierjulio/following{/other_user}","gists_url":"https://api.github.com/users/javierjulio/gists{/gist_id}","starred_url":"https://api.github.com/users/javierjulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierjulio/subscriptions","organizations_url":"https://api.github.com/users/javierjulio/orgs","repos_url":"https://api.github.com/users/javierjulio/repos","events_url":"https://api.github.com/users/javierjulio/events{/privacy}","received_events_url":"https://api.github.com/users/javierjulio/received_events","type":"User","site_admin":false},"repo":{"id":32771575,"name":"activeadmin","full_name":"javierjulio/activeadmin","owner":{"login":"javierjulio","id":198547,"avatar_url":"https://avatars.githubusercontent.com/u/198547?v=3","gravatar_id":"","url":"https://api.github.com/users/javierjulio","html_url":"https://github.com/javierjulio","followers_url":"https://api.github.com/users/javierjulio/followers","following_url":"https://api.github.com/users/javierjulio/following{/other_user}","gists_url":"https://api.github.com/users/javierjulio/gists{/gist_id}","starred_url":"https://api.github.com/users/javierjulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierjulio/subscriptions","organizations_url":"https://api.github.com/users/javierjulio/orgs","repos_url":"https://api.github.com/users/javierjulio/repos","events_url":"https://api.github.com/users/javierjulio/events{/privacy}","received_events_url":"https://api.github.com/users/javierjulio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javierjulio/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":true,"url":"https://api.github.com/repos/javierjulio/activeadmin","forks_url":"https://api.github.com/repos/javierjulio/activeadmin/forks","keys_url":"https://api.github.com/repos/javierjulio/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javierjulio/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javierjulio/activeadmin/teams","hooks_url":"https://api.github.com/repos/javierjulio/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/javierjulio/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/javierjulio/activeadmin/events","assignees_url":"https://api.github.com/repos/javierjulio/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/javierjulio/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/javierjulio/activeadmin/tags","blobs_url":"https://api.github.com/repos/javierjulio/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javierjulio/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javierjulio/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/javierjulio/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javierjulio/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/javierjulio/activeadmin/languages","stargazers_url":"https://api.github.com/repos/javierjulio/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/javierjulio/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/javierjulio/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/javierjulio/activeadmin/subscription","commits_url":"https://api.github.com/repos/javierjulio/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/javierjulio/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/javierjulio/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/javierjulio/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/javierjulio/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/javierjulio/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javierjulio/activeadmin/merges","archive_url":"https://api.github.com/repos/javierjulio/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javierjulio/activeadmin/downloads","issues_url":"https://api.github.com/repos/javierjulio/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/javierjulio/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/javierjulio/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/javierjulio/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javierjulio/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/javierjulio/activeadmin/releases{/id}","created_at":"2015-03-24T02:32:35Z","updated_at":"2015-03-24T02:32:38Z","pushed_at":"2015-04-01T03:24:23Z","git_url":"git://github.com/javierjulio/activeadmin.git","ssh_url":"git@github.com:javierjulio/activeadmin.git","clone_url":"https://github.com/javierjulio/activeadmin.git","svn_url":"https://github.com/javierjulio/activeadmin","homepage":"activeadmin.info","size":7232,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"activeadmin:master","ref":"master","sha":"078f234288a15982217ab2594631ef259985b16f","user":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":611921,"name":"activeadmin","full_name":"activeadmin/activeadmin","owner":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/activeadmin/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":false,"url":"https://api.github.com/repos/activeadmin/activeadmin","forks_url":"https://api.github.com/repos/activeadmin/activeadmin/forks","keys_url":"https://api.github.com/repos/activeadmin/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activeadmin/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activeadmin/activeadmin/teams","hooks_url":"https://api.github.com/repos/activeadmin/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/activeadmin/activeadmin/events","assignees_url":"https://api.github.com/repos/activeadmin/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/activeadmin/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/activeadmin/activeadmin/tags","blobs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activeadmin/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/activeadmin/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/activeadmin/activeadmin/languages","stargazers_url":"https://api.github.com/repos/activeadmin/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/activeadmin/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/activeadmin/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/activeadmin/activeadmin/subscription","commits_url":"https://api.github.com/repos/activeadmin/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/activeadmin/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/activeadmin/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/activeadmin/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activeadmin/activeadmin/merges","archive_url":"https://api.github.com/repos/activeadmin/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activeadmin/activeadmin/downloads","issues_url":"https://api.github.com/repos/activeadmin/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/activeadmin/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/activeadmin/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activeadmin/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/activeadmin/activeadmin/releases{/id}","created_at":"2010-04-15T14:26:03Z","updated_at":"2015-03-31T12:27:26Z","pushed_at":"2015-04-01T03:24:24Z","git_url":"git://github.com/activeadmin/activeadmin.git","ssh_url":"git@github.com:activeadmin/activeadmin.git","clone_url":"https://github.com/activeadmin/activeadmin.git","svn_url":"https://github.com/activeadmin/activeadmin","homepage":"activeadmin.info","size":19527,"stargazers_count":5819,"watchers_count":5819,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2075,"mirror_url":null,"open_issues_count":190,"forks":2075,"open_issues":190,"watchers":5819,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/3862"},"issue":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/3862"},"comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/3862/comments"},"review_comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862/comments"},"review_comment":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862/commits"},"statuses":{"href":"https://api.github.com/repos/activeadmin/activeadmin/statuses/a211e52a9d52132fd82e1a9b5b3abf57fafa1ed6"}}}}