{"action":"created","issue":{"url":"https://api.github.com/repos/klauspost/rawspeed/issues/123","labels_url":"https://api.github.com/repos/klauspost/rawspeed/issues/123/labels{/name}","comments_url":"https://api.github.com/repos/klauspost/rawspeed/issues/123/comments","events_url":"https://api.github.com/repos/klauspost/rawspeed/issues/123/events","html_url":"https://github.com/klauspost/rawspeed/issues/123","id":119370447,"number":123,"title":"clang 3.8 throws up some warnings in the ljpeg big table code","user":{"login":"pedrocr","id":246322,"avatar_url":"https://avatars.githubusercontent.com/u/246322?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrocr","html_url":"https://github.com/pedrocr","followers_url":"https://api.github.com/users/pedrocr/followers","following_url":"https://api.github.com/users/pedrocr/following{/other_user}","gists_url":"https://api.github.com/users/pedrocr/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrocr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrocr/subscriptions","organizations_url":"https://api.github.com/users/pedrocr/orgs","repos_url":"https://api.github.com/users/pedrocr/repos","events_url":"https://api.github.com/users/pedrocr/events{/privacy}","received_events_url":"https://api.github.com/users/pedrocr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-29T16:59:07Z","updated_at":"2015-11-29T17:35:47Z","closed_at":null,"body":"@LebedevRI found that when compiling rawspeed with clang 3.8 we get these warnings:\r\n\r\n```\r\nrawspeed/RawSpeed/LJpegDecompressor.cpp:507:37: warning: shifting a negative signed value is undefined [-Wshift-negative-value]\r\n        htbl->bigTable[i] = (-32768 << 8) | (16 + l);\r\n                             ~~~~~~ ^\r\nrawspeed/RawSpeed/LJpegDecompressor.cpp:509:37: warning: shifting a negative signed value is undefined [-Wshift-negative-value]\r\n        htbl->bigTable[i] = (-32768 << 8) | l;\r\n                             ~~~~~~ ^\r\n```\r\n\r\nWe think we can just change (-32768 << 8) to -(32768 << 8) and have the same effect. Do you see any possible way this could be wrong?"},"comment":{"url":"https://api.github.com/repos/klauspost/rawspeed/issues/comments/160435007","html_url":"https://github.com/klauspost/rawspeed/issues/123#issuecomment-160435007","issue_url":"https://api.github.com/repos/klauspost/rawspeed/issues/123","id":160435007,"user":{"login":"klauspost","id":5663952,"avatar_url":"https://avatars.githubusercontent.com/u/5663952?v=3","gravatar_id":"","url":"https://api.github.com/users/klauspost","html_url":"https://github.com/klauspost","followers_url":"https://api.github.com/users/klauspost/followers","following_url":"https://api.github.com/users/klauspost/following{/other_user}","gists_url":"https://api.github.com/users/klauspost/gists{/gist_id}","starred_url":"https://api.github.com/users/klauspost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klauspost/subscriptions","organizations_url":"https://api.github.com/users/klauspost/orgs","repos_url":"https://api.github.com/users/klauspost/repos","events_url":"https://api.github.com/users/klauspost/events{/privacy}","received_events_url":"https://api.github.com/users/klauspost/received_events","type":"User","site_admin":false},"created_at":"2015-11-29T17:35:47Z","updated_at":"2015-11-29T17:35:47Z","body":"It should be the same AFAICT."}}