{"action":"closed","issue":{"url":"https://api.github.com/repos/weaveworks/guides/issues/84","labels_url":"https://api.github.com/repos/weaveworks/guides/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/guides/issues/84/comments","events_url":"https://api.github.com/repos/weaveworks/guides/issues/84/events","html_url":"https://github.com/weaveworks/guides/issues/84","id":108652923,"number":84,"title":"Improvements to weave-and-docker-platform guide","user":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars.githubusercontent.com/u/8125524?v=3","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-28T12:57:58Z","updated_at":"2015-09-28T19:36:51Z","closed_at":"2015-09-28T19:36:51Z","body":"I worked through the guide, and jotted down some notes:\r\n\r\nThe script `scripts/1-machine-create.sh` repeats 4 lines, which is a potential source of error.\r\n\r\n> Next launch Weave onto each of the virtual machines.\r\n> On weave-1 run:\r\n\r\nIt is not made very clear how you specifically go about doing this. I think you are supposed to do `eval \"$(docker-machine env weave-1)\"` then run `weave`.\r\n\r\n[note: the split between `weave launch-router` and `weave launch-proxy` could be avoided if the script split off the tls arguments, or `weaver` ignored them.]\r\n\r\n> weave-1 is the bootstrap node, and so its target should be 0. Only weave-2 and weave-3 need to have --init-peer-count set to 3 at launch\r\n\r\nThis distinction is unnecessary, and indeed is not followed by the script provided.\r\n\r\n> and finally, set the weave environment variable for weave-1 \r\n> eval $(weave env)\r\n\r\nSetting this is a bad idea at this point, since on the next line we need to point the docker CLI at weave-2.\r\n\r\n> Specify the TLS settings if asked:\r\n\r\nIt is unnecessary to re-set `$tlsargs`, since it doesn't vary from machine to machine.\r\n\r\n> Check that they are in a Swarm:\r\n\r\nThe guide doesn't say which part of the output indicates a Swarm, or what to do if you see something different.\r\n\r\n> like we did in the two previous chapters.\r\n\r\nwe are in chapter 2 right now; how come there are two previous chapters?\r\n\r\n> Before we tear down these two running containers,\r\n\r\nthis part does not go as described because the `nc` has exited upon connection closure, hence the \"pingme\" container does not appear in the list."}}