{"action":"closed","number":91,"pull_request":{"url":"https://api.github.com/repos/koding/kite/pulls/91","id":29364772,"html_url":"https://github.com/koding/kite/pull/91","diff_url":"https://github.com/koding/kite/pull/91.diff","patch_url":"https://github.com/koding/kite/pull/91.patch","issue_url":"https://api.github.com/repos/koding/kite/issues/91","number":91,"state":"closed","locked":false,"title":"heartbeat: fix not re-registering when registerHTTP fails","user":{"login":"fatih","id":438920,"avatar_url":"https://avatars.githubusercontent.com/u/438920?v=3","gravatar_id":"","url":"https://api.github.com/users/fatih","html_url":"https://github.com/fatih","followers_url":"https://api.github.com/users/fatih/followers","following_url":"https://api.github.com/users/fatih/following{/other_user}","gists_url":"https://api.github.com/users/fatih/gists{/gist_id}","starred_url":"https://api.github.com/users/fatih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatih/subscriptions","organizations_url":"https://api.github.com/users/fatih/orgs","repos_url":"https://api.github.com/users/fatih/repos","events_url":"https://api.github.com/users/fatih/events{/privacy}","received_events_url":"https://api.github.com/users/fatih/received_events","type":"User","site_admin":false},"body":"Normally registration is forever, until you stop the APP. However if it\r\nfails once to send an heartbeat and Kontrol sends a `registerAgain`, it\r\nwould try to re-register it. The problem here is, the registration part\r\nis done once only. So if something goes wrong and the registration\r\nfails, we need to try to register until we are again the loop.\r\n\r\nBy changing the RegisterHTTP to RegisterHTTPForever, it'll try to\r\nregister until it's successfull. Once registered, the heartbeat will be\r\nstarting again.","created_at":"2015-02-16T11:03:16Z","updated_at":"2015-02-16T11:57:13Z","closed_at":"2015-02-16T11:57:13Z","merged_at":"2015-02-16T11:57:13Z","merge_commit_sha":"ae2dcf3d29fbb91003e2a14046aedd82dc503244","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/koding/kite/pulls/91/commits","review_comments_url":"https://api.github.com/repos/koding/kite/pulls/91/comments","review_comment_url":"https://api.github.com/repos/koding/kite/pulls/comments/{number}","comments_url":"https://api.github.com/repos/koding/kite/issues/91/comments","statuses_url":"https://api.github.com/repos/koding/kite/statuses/9dceb306cffd3b607ceaafa0960e39d3d4627791","head":{"label":"koding:fix-forever-heartbeat","ref":"fix-forever-heartbeat","sha":"9dceb306cffd3b607ceaafa0960e39d3d4627791","user":{"login":"koding","id":1066754,"avatar_url":"https://avatars.githubusercontent.com/u/1066754?v=3","gravatar_id":"","url":"https://api.github.com/users/koding","html_url":"https://github.com/koding","followers_url":"https://api.github.com/users/koding/followers","following_url":"https://api.github.com/users/koding/following{/other_user}","gists_url":"https://api.github.com/users/koding/gists{/gist_id}","starred_url":"https://api.github.com/users/koding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koding/subscriptions","organizations_url":"https://api.github.com/users/koding/orgs","repos_url":"https://api.github.com/users/koding/repos","events_url":"https://api.github.com/users/koding/events{/privacy}","received_events_url":"https://api.github.com/users/koding/received_events","type":"Organization","site_admin":false},"repo":{"id":17035868,"name":"kite","full_name":"koding/kite","owner":{"login":"koding","id":1066754,"avatar_url":"https://avatars.githubusercontent.com/u/1066754?v=3","gravatar_id":"","url":"https://api.github.com/users/koding","html_url":"https://github.com/koding","followers_url":"https://api.github.com/users/koding/followers","following_url":"https://api.github.com/users/koding/following{/other_user}","gists_url":"https://api.github.com/users/koding/gists{/gist_id}","starred_url":"https://api.github.com/users/koding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koding/subscriptions","organizations_url":"https://api.github.com/users/koding/orgs","repos_url":"https://api.github.com/users/koding/repos","events_url":"https://api.github.com/users/koding/events{/privacy}","received_events_url":"https://api.github.com/users/koding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/koding/kite","description":"Micro-service framework in Go","fork":false,"url":"https://api.github.com/repos/koding/kite","forks_url":"https://api.github.com/repos/koding/kite/forks","keys_url":"https://api.github.com/repos/koding/kite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koding/kite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koding/kite/teams","hooks_url":"https://api.github.com/repos/koding/kite/hooks","issue_events_url":"https://api.github.com/repos/koding/kite/issues/events{/number}","events_url":"https://api.github.com/repos/koding/kite/events","assignees_url":"https://api.github.com/repos/koding/kite/assignees{/user}","branches_url":"https://api.github.com/repos/koding/kite/branches{/branch}","tags_url":"https://api.github.com/repos/koding/kite/tags","blobs_url":"https://api.github.com/repos/koding/kite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koding/kite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koding/kite/git/refs{/sha}","trees_url":"https://api.github.com/repos/koding/kite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koding/kite/statuses/{sha}","languages_url":"https://api.github.com/repos/koding/kite/languages","stargazers_url":"https://api.github.com/repos/koding/kite/stargazers","contributors_url":"https://api.github.com/repos/koding/kite/contributors","subscribers_url":"https://api.github.com/repos/koding/kite/subscribers","subscription_url":"https://api.github.com/repos/koding/kite/subscription","commits_url":"https://api.github.com/repos/koding/kite/commits{/sha}","git_commits_url":"https://api.github.com/repos/koding/kite/git/commits{/sha}","comments_url":"https://api.github.com/repos/koding/kite/comments{/number}","issue_comment_url":"https://api.github.com/repos/koding/kite/issues/comments/{number}","contents_url":"https://api.github.com/repos/koding/kite/contents/{+path}","compare_url":"https://api.github.com/repos/koding/kite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koding/kite/merges","archive_url":"https://api.github.com/repos/koding/kite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koding/kite/downloads","issues_url":"https://api.github.com/repos/koding/kite/issues{/number}","pulls_url":"https://api.github.com/repos/koding/kite/pulls{/number}","milestones_url":"https://api.github.com/repos/koding/kite/milestones{/number}","notifications_url":"https://api.github.com/repos/koding/kite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koding/kite/labels{/name}","releases_url":"https://api.github.com/repos/koding/kite/releases{/id}","created_at":"2014-02-20T21:14:43Z","updated_at":"2015-02-16T11:57:13Z","pushed_at":"2015-02-16T11:57:13Z","git_url":"git://github.com/koding/kite.git","ssh_url":"git@github.com:koding/kite.git","clone_url":"https://github.com/koding/kite.git","svn_url":"https://github.com/koding/kite","homepage":"https://godoc.org/github.com/koding/kite","size":6018,"stargazers_count":545,"watchers_count":545,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":11,"forks":15,"open_issues":11,"watchers":545,"default_branch":"master"}},"base":{"label":"koding:master","ref":"master","sha":"0beeb580abe6f4fd0793ffccef3addb83bcac6f5","user":{"login":"koding","id":1066754,"avatar_url":"https://avatars.githubusercontent.com/u/1066754?v=3","gravatar_id":"","url":"https://api.github.com/users/koding","html_url":"https://github.com/koding","followers_url":"https://api.github.com/users/koding/followers","following_url":"https://api.github.com/users/koding/following{/other_user}","gists_url":"https://api.github.com/users/koding/gists{/gist_id}","starred_url":"https://api.github.com/users/koding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koding/subscriptions","organizations_url":"https://api.github.com/users/koding/orgs","repos_url":"https://api.github.com/users/koding/repos","events_url":"https://api.github.com/users/koding/events{/privacy}","received_events_url":"https://api.github.com/users/koding/received_events","type":"Organization","site_admin":false},"repo":{"id":17035868,"name":"kite","full_name":"koding/kite","owner":{"login":"koding","id":1066754,"avatar_url":"https://avatars.githubusercontent.com/u/1066754?v=3","gravatar_id":"","url":"https://api.github.com/users/koding","html_url":"https://github.com/koding","followers_url":"https://api.github.com/users/koding/followers","following_url":"https://api.github.com/users/koding/following{/other_user}","gists_url":"https://api.github.com/users/koding/gists{/gist_id}","starred_url":"https://api.github.com/users/koding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koding/subscriptions","organizations_url":"https://api.github.com/users/koding/orgs","repos_url":"https://api.github.com/users/koding/repos","events_url":"https://api.github.com/users/koding/events{/privacy}","received_events_url":"https://api.github.com/users/koding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/koding/kite","description":"Micro-service framework in Go","fork":false,"url":"https://api.github.com/repos/koding/kite","forks_url":"https://api.github.com/repos/koding/kite/forks","keys_url":"https://api.github.com/repos/koding/kite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koding/kite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koding/kite/teams","hooks_url":"https://api.github.com/repos/koding/kite/hooks","issue_events_url":"https://api.github.com/repos/koding/kite/issues/events{/number}","events_url":"https://api.github.com/repos/koding/kite/events","assignees_url":"https://api.github.com/repos/koding/kite/assignees{/user}","branches_url":"https://api.github.com/repos/koding/kite/branches{/branch}","tags_url":"https://api.github.com/repos/koding/kite/tags","blobs_url":"https://api.github.com/repos/koding/kite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koding/kite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koding/kite/git/refs{/sha}","trees_url":"https://api.github.com/repos/koding/kite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koding/kite/statuses/{sha}","languages_url":"https://api.github.com/repos/koding/kite/languages","stargazers_url":"https://api.github.com/repos/koding/kite/stargazers","contributors_url":"https://api.github.com/repos/koding/kite/contributors","subscribers_url":"https://api.github.com/repos/koding/kite/subscribers","subscription_url":"https://api.github.com/repos/koding/kite/subscription","commits_url":"https://api.github.com/repos/koding/kite/commits{/sha}","git_commits_url":"https://api.github.com/repos/koding/kite/git/commits{/sha}","comments_url":"https://api.github.com/repos/koding/kite/comments{/number}","issue_comment_url":"https://api.github.com/repos/koding/kite/issues/comments/{number}","contents_url":"https://api.github.com/repos/koding/kite/contents/{+path}","compare_url":"https://api.github.com/repos/koding/kite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koding/kite/merges","archive_url":"https://api.github.com/repos/koding/kite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koding/kite/downloads","issues_url":"https://api.github.com/repos/koding/kite/issues{/number}","pulls_url":"https://api.github.com/repos/koding/kite/pulls{/number}","milestones_url":"https://api.github.com/repos/koding/kite/milestones{/number}","notifications_url":"https://api.github.com/repos/koding/kite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koding/kite/labels{/name}","releases_url":"https://api.github.com/repos/koding/kite/releases{/id}","created_at":"2014-02-20T21:14:43Z","updated_at":"2015-02-16T11:57:13Z","pushed_at":"2015-02-16T11:57:13Z","git_url":"git://github.com/koding/kite.git","ssh_url":"git@github.com:koding/kite.git","clone_url":"https://github.com/koding/kite.git","svn_url":"https://github.com/koding/kite","homepage":"https://godoc.org/github.com/koding/kite","size":6018,"stargazers_count":545,"watchers_count":545,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":11,"forks":15,"open_issues":11,"watchers":545,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/koding/kite/pulls/91"},"html":{"href":"https://github.com/koding/kite/pull/91"},"issue":{"href":"https://api.github.com/repos/koding/kite/issues/91"},"comments":{"href":"https://api.github.com/repos/koding/kite/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/koding/kite/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/koding/kite/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/koding/kite/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/koding/kite/statuses/9dceb306cffd3b607ceaafa0960e39d3d4627791"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fatih","id":438920,"avatar_url":"https://avatars.githubusercontent.com/u/438920?v=3","gravatar_id":"","url":"https://api.github.com/users/fatih","html_url":"https://github.com/fatih","followers_url":"https://api.github.com/users/fatih/followers","following_url":"https://api.github.com/users/fatih/following{/other_user}","gists_url":"https://api.github.com/users/fatih/gists{/gist_id}","starred_url":"https://api.github.com/users/fatih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatih/subscriptions","organizations_url":"https://api.github.com/users/fatih/orgs","repos_url":"https://api.github.com/users/fatih/repos","events_url":"https://api.github.com/users/fatih/events{/privacy}","received_events_url":"https://api.github.com/users/fatih/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":7,"deletions":3,"changed_files":1}}