{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments/43984911","id":43984911,"diff_hunk":"@@ -0,0 +1,96 @@\n+/*\n+ * Copyright 2015 the original author or authors.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.springframework.cloud.dataflow.module.deployer.marathon;\n+\n+import java.util.HashMap;\n+import java.util.Map;\n+\n+import org.springframework.boot.context.properties.ConfigurationProperties;\n+\n+/**\n+ * Configuration properties for connecting to a Marathon installation.\n+ *\n+ * @author Eric Bottard\n+ */\n+@ConfigurationProperties(\"marathon\")\n+public class MarathonProperties {\n+\n+\t/**\n+\t * The location of the Marathon REST endpoint.\n+\t */\n+\tprivate String apiEndpoint = \"http://10.141.141.10:8080\";\n+\n+\t/**\n+\t * The docker image to use for launching modules.\n+\t */\n+\tprivate String image = \"springcloud/stream-module-launcher\";","path":"spring-cloud-dataflow-module-deployers/spring-cloud-dataflow-module-deployer-marathon/src/main/java/org/springframework/cloud/dataflow/module/deployer/marathon/MarathonProperties.java","position":40,"original_position":40,"commit_id":"f414be1d2ce677632d3c6244d02084bfc19450ec","original_commit_id":"f414be1d2ce677632d3c6244d02084bfc19450ec","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"body":"Given this image is used by multiple deployers, can we move this as constant to `ModuleDeployer` interface?","created_at":"2015-11-05T07:56:21Z","updated_at":"2015-11-05T07:56:21Z","html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/134#discussion_r43984911","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments/43984911"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/134#discussion_r43984911"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/134","id":49583576,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/134","diff_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/134.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/134.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/134","number":134,"state":"open","locked":false,"title":"XD-3672: Mesos/Marathon Deployer implementation","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"body":null,"created_at":"2015-11-03T17:14:22Z","updated_at":"2015-11-05T07:56:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f273778fd7329a093eeecf1e5ab53721f91b6b4e","assignee":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/134/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/134/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/134/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/f414be1d2ce677632d3c6244d02084bfc19450ec","head":{"label":"ericbottard:MarathonDeployer","ref":"MarathonDeployer","sha":"f414be1d2ce677632d3c6244d02084bfc19450ec","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"repo":{"id":40243328,"name":"spring-cloud-dataflow","full_name":"ericbottard/spring-cloud-dataflow","owner":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericbottard/spring-cloud-dataflow","description":"","fork":true,"url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/releases{/id}","created_at":"2015-08-05T12:13:08Z","updated_at":"2015-09-07T07:14:40Z","pushed_at":"2015-11-03T17:12:57Z","git_url":"git://github.com/ericbottard/spring-cloud-dataflow.git","ssh_url":"git@github.com:ericbottard/spring-cloud-dataflow.git","clone_url":"https://github.com/ericbottard/spring-cloud-dataflow.git","svn_url":"https://github.com/ericbottard/spring-cloud-dataflow","homepage":null,"size":1233,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"2a5d8acda3c2f02b027a2e6f34349c90ba032221","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":39469487,"name":"spring-cloud-dataflow","full_name":"spring-cloud/spring-cloud-dataflow","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow","description":"","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/releases{/id}","created_at":"2015-07-21T20:56:11Z","updated_at":"2015-10-23T11:57:12Z","pushed_at":"2015-11-04T14:45:41Z","git_url":"git://github.com/spring-cloud/spring-cloud-dataflow.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-dataflow.git","clone_url":"https://github.com/spring-cloud/spring-cloud-dataflow.git","svn_url":"https://github.com/spring-cloud/spring-cloud-dataflow","homepage":null,"size":3095,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"open_issues_count":10,"forks":28,"open_issues":10,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/134"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/134"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/134"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/f414be1d2ce677632d3c6244d02084bfc19450ec"}}}}