{"action":"closed","number":25,"pull_request":{"url":"https://api.github.com/repos/chef/mixlib-install/pulls/25","id":52445913,"html_url":"https://github.com/chef/mixlib-install/pull/25","diff_url":"https://github.com/chef/mixlib-install/pull/25.diff","patch_url":"https://github.com/chef/mixlib-install/pull/25.patch","issue_url":"https://api.github.com/repos/chef/mixlib-install/issues/25","number":25,"state":"closed","locked":false,"title":"Move product matrix and its documentation from chef-ingredient.","user":{"login":"sersut","id":1695955,"avatar_url":"https://avatars.githubusercontent.com/u/1695955?v=3","gravatar_id":"","url":"https://api.github.com/users/sersut","html_url":"https://github.com/sersut","followers_url":"https://api.github.com/users/sersut/followers","following_url":"https://api.github.com/users/sersut/following{/other_user}","gists_url":"https://api.github.com/users/sersut/gists{/gist_id}","starred_url":"https://api.github.com/users/sersut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sersut/subscriptions","organizations_url":"https://api.github.com/users/sersut/orgs","repos_url":"https://api.github.com/users/sersut/repos","events_url":"https://api.github.com/users/sersut/events{/privacy}","received_events_url":"https://api.github.com/users/sersut/received_events","type":"User","site_admin":false},"body":"This PR moves [product matrix](https://github.com/chef-cookbooks/chef-ingredient/blob/master/PRODUCT_MATRIX.md) and its helper methods from chef-cookbooks/chef-ingredient to here. A few things to keep in mind while reviewing:\r\n\r\n1. I do not think the `package_name` column in the `PRODUCT_MATRIX.md` makes sense. I think we should add a description column for it to be more useful for the end user. But I did not do that and copied over only what we have. \r\n2. @jtimberman can you double check the version based logic in the matrix. I have double checked it but just in case :smile: \r\n\r\n/cc: @chef/engineering-services, @thommay ","created_at":"2015-12-02T19:58:09Z","updated_at":"2015-12-03T19:10:52Z","closed_at":"2015-12-03T19:10:52Z","merged_at":"2015-12-03T19:10:52Z","merge_commit_sha":"4c1c68a88221f379f04e11dbf7cdd5f9f3d52d06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef/mixlib-install/pulls/25/commits","review_comments_url":"https://api.github.com/repos/chef/mixlib-install/pulls/25/comments","review_comment_url":"https://api.github.com/repos/chef/mixlib-install/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/mixlib-install/issues/25/comments","statuses_url":"https://api.github.com/repos/chef/mixlib-install/statuses/6b4091cfc7bc87cbbd8546ca34b6f9bab2f29224","head":{"label":"chef:sersut/product-matrix","ref":"sersut/product-matrix","sha":"6b4091cfc7bc87cbbd8546ca34b6f9bab2f29224","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":39073784,"name":"mixlib-install","full_name":"chef/mixlib-install","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/mixlib-install","description":"A mixin to help with omnitruck installs","fork":false,"url":"https://api.github.com/repos/chef/mixlib-install","forks_url":"https://api.github.com/repos/chef/mixlib-install/forks","keys_url":"https://api.github.com/repos/chef/mixlib-install/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/mixlib-install/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/mixlib-install/teams","hooks_url":"https://api.github.com/repos/chef/mixlib-install/hooks","issue_events_url":"https://api.github.com/repos/chef/mixlib-install/issues/events{/number}","events_url":"https://api.github.com/repos/chef/mixlib-install/events","assignees_url":"https://api.github.com/repos/chef/mixlib-install/assignees{/user}","branches_url":"https://api.github.com/repos/chef/mixlib-install/branches{/branch}","tags_url":"https://api.github.com/repos/chef/mixlib-install/tags","blobs_url":"https://api.github.com/repos/chef/mixlib-install/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/mixlib-install/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/mixlib-install/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/mixlib-install/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/mixlib-install/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/mixlib-install/languages","stargazers_url":"https://api.github.com/repos/chef/mixlib-install/stargazers","contributors_url":"https://api.github.com/repos/chef/mixlib-install/contributors","subscribers_url":"https://api.github.com/repos/chef/mixlib-install/subscribers","subscription_url":"https://api.github.com/repos/chef/mixlib-install/subscription","commits_url":"https://api.github.com/repos/chef/mixlib-install/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/mixlib-install/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/mixlib-install/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/mixlib-install/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/mixlib-install/contents/{+path}","compare_url":"https://api.github.com/repos/chef/mixlib-install/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/mixlib-install/merges","archive_url":"https://api.github.com/repos/chef/mixlib-install/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/mixlib-install/downloads","issues_url":"https://api.github.com/repos/chef/mixlib-install/issues{/number}","pulls_url":"https://api.github.com/repos/chef/mixlib-install/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/mixlib-install/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/mixlib-install/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/mixlib-install/labels{/name}","releases_url":"https://api.github.com/repos/chef/mixlib-install/releases{/id}","created_at":"2015-07-14T12:34:25Z","updated_at":"2015-09-15T01:32:52Z","pushed_at":"2015-12-03T19:10:52Z","git_url":"git://github.com/chef/mixlib-install.git","ssh_url":"git@github.com:chef/mixlib-install.git","clone_url":"https://github.com/chef/mixlib-install.git","svn_url":"https://github.com/chef/mixlib-install","homepage":"","size":115,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":11,"forks":6,"open_issues":11,"watchers":3,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"8a617d3c4df80f9bfc813382562fa84b12d0e9db","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":39073784,"name":"mixlib-install","full_name":"chef/mixlib-install","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/mixlib-install","description":"A mixin to help with omnitruck installs","fork":false,"url":"https://api.github.com/repos/chef/mixlib-install","forks_url":"https://api.github.com/repos/chef/mixlib-install/forks","keys_url":"https://api.github.com/repos/chef/mixlib-install/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/mixlib-install/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/mixlib-install/teams","hooks_url":"https://api.github.com/repos/chef/mixlib-install/hooks","issue_events_url":"https://api.github.com/repos/chef/mixlib-install/issues/events{/number}","events_url":"https://api.github.com/repos/chef/mixlib-install/events","assignees_url":"https://api.github.com/repos/chef/mixlib-install/assignees{/user}","branches_url":"https://api.github.com/repos/chef/mixlib-install/branches{/branch}","tags_url":"https://api.github.com/repos/chef/mixlib-install/tags","blobs_url":"https://api.github.com/repos/chef/mixlib-install/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/mixlib-install/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/mixlib-install/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/mixlib-install/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/mixlib-install/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/mixlib-install/languages","stargazers_url":"https://api.github.com/repos/chef/mixlib-install/stargazers","contributors_url":"https://api.github.com/repos/chef/mixlib-install/contributors","subscribers_url":"https://api.github.com/repos/chef/mixlib-install/subscribers","subscription_url":"https://api.github.com/repos/chef/mixlib-install/subscription","commits_url":"https://api.github.com/repos/chef/mixlib-install/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/mixlib-install/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/mixlib-install/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/mixlib-install/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/mixlib-install/contents/{+path}","compare_url":"https://api.github.com/repos/chef/mixlib-install/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/mixlib-install/merges","archive_url":"https://api.github.com/repos/chef/mixlib-install/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/mixlib-install/downloads","issues_url":"https://api.github.com/repos/chef/mixlib-install/issues{/number}","pulls_url":"https://api.github.com/repos/chef/mixlib-install/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/mixlib-install/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/mixlib-install/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/mixlib-install/labels{/name}","releases_url":"https://api.github.com/repos/chef/mixlib-install/releases{/id}","created_at":"2015-07-14T12:34:25Z","updated_at":"2015-09-15T01:32:52Z","pushed_at":"2015-12-03T19:10:52Z","git_url":"git://github.com/chef/mixlib-install.git","ssh_url":"git@github.com:chef/mixlib-install.git","clone_url":"https://github.com/chef/mixlib-install.git","svn_url":"https://github.com/chef/mixlib-install","homepage":"","size":115,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":11,"forks":6,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/mixlib-install/pulls/25"},"html":{"href":"https://github.com/chef/mixlib-install/pull/25"},"issue":{"href":"https://api.github.com/repos/chef/mixlib-install/issues/25"},"comments":{"href":"https://api.github.com/repos/chef/mixlib-install/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/mixlib-install/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/mixlib-install/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/mixlib-install/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/chef/mixlib-install/statuses/6b4091cfc7bc87cbbd8546ca34b6f9bab2f29224"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sersut","id":1695955,"avatar_url":"https://avatars.githubusercontent.com/u/1695955?v=3","gravatar_id":"","url":"https://api.github.com/users/sersut","html_url":"https://github.com/sersut","followers_url":"https://api.github.com/users/sersut/followers","following_url":"https://api.github.com/users/sersut/following{/other_user}","gists_url":"https://api.github.com/users/sersut/gists{/gist_id}","starred_url":"https://api.github.com/users/sersut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sersut/subscriptions","organizations_url":"https://api.github.com/users/sersut/orgs","repos_url":"https://api.github.com/users/sersut/repos","events_url":"https://api.github.com/users/sersut/events{/privacy}","received_events_url":"https://api.github.com/users/sersut/received_events","type":"User","site_admin":false},"comments":4,"review_comments":15,"commits":2,"additions":557,"deletions":0,"changed_files":4}}