{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/21193","labels_url":"https://api.github.com/repos/saltstack/salt/issues/21193/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/21193/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/21193/events","html_url":"https://github.com/saltstack/salt/issues/21193","id":59418158,"number":21193,"title":"do we add back download/download_cache to venv mod","user":{"login":"kiorky","id":90111,"avatar_url":"https://avatars.githubusercontent.com/u/90111?v=3","gravatar_id":"","url":"https://api.github.com/users/kiorky","html_url":"https://github.com/kiorky","followers_url":"https://api.github.com/users/kiorky/followers","following_url":"https://api.github.com/users/kiorky/following{/other_user}","gists_url":"https://api.github.com/users/kiorky/gists{/gist_id}","starred_url":"https://api.github.com/users/kiorky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiorky/subscriptions","organizations_url":"https://api.github.com/users/kiorky/orgs","repos_url":"https://api.github.com/users/kiorky/repos","events_url":"https://api.github.com/users/kiorky/events{/privacy}","received_events_url":"https://api.github.com/users/kiorky/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Bug","name":"Bug","color":"e11d21"},{"url":"https://api.github.com/repos/saltstack/salt/labels/Core","name":"Core","color":"006b75"},{"url":"https://api.github.com/repos/saltstack/salt/labels/High%20Severity","name":"High Severity","color":"ff9143"},{"url":"https://api.github.com/repos/saltstack/salt/labels/P4","name":"P4","color":"031a39"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/saltstack/salt/milestones/13","html_url":"https://github.com/saltstack/salt/milestones/Approved","labels_url":"https://api.github.com/repos/saltstack/salt/milestones/13/labels","id":9265,"number":13,"title":"Approved","description":"All issues that are ready to be worked on, both bugs and features.","creator":{"login":"thatch45","id":507599,"avatar_url":"https://avatars.githubusercontent.com/u/507599?v=3","gravatar_id":"","url":"https://api.github.com/users/thatch45","html_url":"https://github.com/thatch45","followers_url":"https://api.github.com/users/thatch45/followers","following_url":"https://api.github.com/users/thatch45/following{/other_user}","gists_url":"https://api.github.com/users/thatch45/gists{/gist_id}","starred_url":"https://api.github.com/users/thatch45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thatch45/subscriptions","organizations_url":"https://api.github.com/users/thatch45/orgs","repos_url":"https://api.github.com/users/thatch45/repos","events_url":"https://api.github.com/users/thatch45/events{/privacy}","received_events_url":"https://api.github.com/users/thatch45/received_events","type":"User","site_admin":false},"open_issues":2260,"closed_issues":2011,"state":"open","created_at":"2011-05-14T04:00:56Z","updated_at":"2015-05-19T20:25:43Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2015-03-01T21:21:56Z","updated_at":"2015-05-19T20:25:58Z","closed_at":null,"body":"to @s0undt3ch & @thatch45 \r\n\r\nAlways related to the kwarg deprecation enforcement,\r\n\r\nGetting now the warning in virtualenv.managed which i used in a lot a place.\r\nI used in there \"download\" & \"download_cache\" in place of their pip_download* counterpart.\r\n\r\nI cant say anymore that i'm too lazy to look at it, but from virtualenv, can i post a PR that add back those 2 params as they are more intuitive than \"pip_download\" & \"pip_download_cache\" & print a deprecation log on them.\r\n\r\nAnd always and again, im really pushing for having that toggle option to never hardfails but always those lovely warning we have at this time, and that always forever."},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/103659022","html_url":"https://github.com/saltstack/salt/issues/21193#issuecomment-103659022","issue_url":"https://api.github.com/repos/saltstack/salt/issues/21193","id":103659022,"user":{"login":"kiorky","id":90111,"avatar_url":"https://avatars.githubusercontent.com/u/90111?v=3","gravatar_id":"","url":"https://api.github.com/users/kiorky","html_url":"https://github.com/kiorky","followers_url":"https://api.github.com/users/kiorky/followers","following_url":"https://api.github.com/users/kiorky/following{/other_user}","gists_url":"https://api.github.com/users/kiorky/gists{/gist_id}","starred_url":"https://api.github.com/users/kiorky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiorky/subscriptions","organizations_url":"https://api.github.com/users/kiorky/orgs","repos_url":"https://api.github.com/users/kiorky/repos","events_url":"https://api.github.com/users/kiorky/events{/privacy}","received_events_url":"https://api.github.com/users/kiorky/received_events","type":"User","site_admin":false},"created_at":"2015-05-19T20:25:58Z","updated_at":"2015-05-19T20:25:58Z","body":"well the deprecation discusssion which flamed a while ago just stalled as all related bugs,\r\nnothing has been decided afaik on on that deadly point about warnings which should be changed to hard failures.\r\n\r\nToward this specific bug, i didnt see any commit addressing the issue."}}