{"action":"created","comment":{"url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/comments/27890442","id":27890442,"diff_hunk":"@@ -0,0 +1,59 @@\n+require.config({\r\n+\r\n+  paths: {\r\n+    'my-app': 'my-app.js'\r\n+    /* TODO: Incorporate the <scripts/> that are being globally imported in frame.html\r","path":"angularjs-portal-frame/src/main/webapp/main.js","position":5,"original_position":5,"commit_id":"20ff32eccc6b3d30338ae6fdcc098d83af7b6c62","original_commit_id":"20ff32eccc6b3d30338ae6fdcc098d83af7b6c62","user":{"login":"timlevett","id":3534544,"avatar_url":"https://avatars.githubusercontent.com/u/3534544?v=3","gravatar_id":"","url":"https://api.github.com/users/timlevett","html_url":"https://github.com/timlevett","followers_url":"https://api.github.com/users/timlevett/followers","following_url":"https://api.github.com/users/timlevett/following{/other_user}","gists_url":"https://api.github.com/users/timlevett/gists{/gist_id}","starred_url":"https://api.github.com/users/timlevett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timlevett/subscriptions","organizations_url":"https://api.github.com/users/timlevett/orgs","repos_url":"https://api.github.com/users/timlevett/repos","events_url":"https://api.github.com/users/timlevett/events{/privacy}","received_events_url":"https://api.github.com/users/timlevett/received_events","type":"User","site_admin":false},"body":"Ah, i see. Yes then I agree to wait.","created_at":"2015-04-07T15:45:28Z","updated_at":"2015-04-07T15:45:28Z","html_url":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/185#discussion_r27890442","pull_request_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/comments/27890442"},"html":{"href":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/185#discussion_r27890442"},"pull_request":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/185","id":32704868,"html_url":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/185","diff_url":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/185.diff","patch_url":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/185.patch","issue_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/185","number":185,"state":"open","locked":false,"title":"Use RequireJS to make my-app more extensible","user":{"login":"paulerickson","id":50889,"avatar_url":"https://avatars.githubusercontent.com/u/50889?v=3","gravatar_id":"","url":"https://api.github.com/users/paulerickson","html_url":"https://github.com/paulerickson","followers_url":"https://api.github.com/users/paulerickson/followers","following_url":"https://api.github.com/users/paulerickson/following{/other_user}","gists_url":"https://api.github.com/users/paulerickson/gists{/gist_id}","starred_url":"https://api.github.com/users/paulerickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulerickson/subscriptions","organizations_url":"https://api.github.com/users/paulerickson/orgs","repos_url":"https://api.github.com/users/paulerickson/repos","events_url":"https://api.github.com/users/paulerickson/events{/privacy}","received_events_url":"https://api.github.com/users/paulerickson/received_events","type":"User","site_admin":false},"body":"With all the scripts included in frame.html, it is easy to overlay the single my-app.js file, but hard to accommodate a modular app with many js files.\r\n\r\nWith this change, a downstream application can use require to pull in their own dependencies within their overlaid my-app.js (which is now a require module).  Angular will initialize only afterward (this is in lieu of the ng-app directive).\r\n\r\nIf this works well, a good next step would be to isolate the rest of the javascript resources behind require, so that the frame and app can be organized into their own modules with no risk of interfering with each other through the global namespace.","created_at":"2015-04-06T19:48:24Z","updated_at":"2015-04-07T15:45:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba855ff68dfe7c38ef86cdd29c316ab15a2cf824","assignee":{"login":"paulerickson","id":50889,"avatar_url":"https://avatars.githubusercontent.com/u/50889?v=3","gravatar_id":"","url":"https://api.github.com/users/paulerickson","html_url":"https://github.com/paulerickson","followers_url":"https://api.github.com/users/paulerickson/followers","following_url":"https://api.github.com/users/paulerickson/following{/other_user}","gists_url":"https://api.github.com/users/paulerickson/gists{/gist_id}","starred_url":"https://api.github.com/users/paulerickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulerickson/subscriptions","organizations_url":"https://api.github.com/users/paulerickson/orgs","repos_url":"https://api.github.com/users/paulerickson/repos","events_url":"https://api.github.com/users/paulerickson/events{/privacy}","received_events_url":"https://api.github.com/users/paulerickson/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/185/commits","review_comments_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/185/comments","review_comment_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/185/comments","statuses_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/statuses/20ff32eccc6b3d30338ae6fdcc098d83af7b6c62","head":{"label":"paulerickson:requirejs","ref":"requirejs","sha":"20ff32eccc6b3d30338ae6fdcc098d83af7b6c62","user":{"login":"paulerickson","id":50889,"avatar_url":"https://avatars.githubusercontent.com/u/50889?v=3","gravatar_id":"","url":"https://api.github.com/users/paulerickson","html_url":"https://github.com/paulerickson","followers_url":"https://api.github.com/users/paulerickson/followers","following_url":"https://api.github.com/users/paulerickson/following{/other_user}","gists_url":"https://api.github.com/users/paulerickson/gists{/gist_id}","starred_url":"https://api.github.com/users/paulerickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulerickson/subscriptions","organizations_url":"https://api.github.com/users/paulerickson/orgs","repos_url":"https://api.github.com/users/paulerickson/repos","events_url":"https://api.github.com/users/paulerickson/events{/privacy}","received_events_url":"https://api.github.com/users/paulerickson/received_events","type":"User","site_admin":false},"repo":{"id":33331946,"name":"angularjs-portal","full_name":"paulerickson/angularjs-portal","owner":{"login":"paulerickson","id":50889,"avatar_url":"https://avatars.githubusercontent.com/u/50889?v=3","gravatar_id":"","url":"https://api.github.com/users/paulerickson","html_url":"https://github.com/paulerickson","followers_url":"https://api.github.com/users/paulerickson/followers","following_url":"https://api.github.com/users/paulerickson/following{/other_user}","gists_url":"https://api.github.com/users/paulerickson/gists{/gist_id}","starred_url":"https://api.github.com/users/paulerickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulerickson/subscriptions","organizations_url":"https://api.github.com/users/paulerickson/orgs","repos_url":"https://api.github.com/users/paulerickson/repos","events_url":"https://api.github.com/users/paulerickson/events{/privacy}","received_events_url":"https://api.github.com/users/paulerickson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulerickson/angularjs-portal","description":"AngularJS alternative UI for MyUW portal (built for uPortal).","fork":true,"url":"https://api.github.com/repos/paulerickson/angularjs-portal","forks_url":"https://api.github.com/repos/paulerickson/angularjs-portal/forks","keys_url":"https://api.github.com/repos/paulerickson/angularjs-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulerickson/angularjs-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulerickson/angularjs-portal/teams","hooks_url":"https://api.github.com/repos/paulerickson/angularjs-portal/hooks","issue_events_url":"https://api.github.com/repos/paulerickson/angularjs-portal/issues/events{/number}","events_url":"https://api.github.com/repos/paulerickson/angularjs-portal/events","assignees_url":"https://api.github.com/repos/paulerickson/angularjs-portal/assignees{/user}","branches_url":"https://api.github.com/repos/paulerickson/angularjs-portal/branches{/branch}","tags_url":"https://api.github.com/repos/paulerickson/angularjs-portal/tags","blobs_url":"https://api.github.com/repos/paulerickson/angularjs-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulerickson/angularjs-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulerickson/angularjs-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulerickson/angularjs-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulerickson/angularjs-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/paulerickson/angularjs-portal/languages","stargazers_url":"https://api.github.com/repos/paulerickson/angularjs-portal/stargazers","contributors_url":"https://api.github.com/repos/paulerickson/angularjs-portal/contributors","subscribers_url":"https://api.github.com/repos/paulerickson/angularjs-portal/subscribers","subscription_url":"https://api.github.com/repos/paulerickson/angularjs-portal/subscription","commits_url":"https://api.github.com/repos/paulerickson/angularjs-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulerickson/angularjs-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulerickson/angularjs-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulerickson/angularjs-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulerickson/angularjs-portal/contents/{+path}","compare_url":"https://api.github.com/repos/paulerickson/angularjs-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulerickson/angularjs-portal/merges","archive_url":"https://api.github.com/repos/paulerickson/angularjs-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulerickson/angularjs-portal/downloads","issues_url":"https://api.github.com/repos/paulerickson/angularjs-portal/issues{/number}","pulls_url":"https://api.github.com/repos/paulerickson/angularjs-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/paulerickson/angularjs-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/paulerickson/angularjs-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulerickson/angularjs-portal/labels{/name}","releases_url":"https://api.github.com/repos/paulerickson/angularjs-portal/releases{/id}","created_at":"2015-04-02T21:08:32Z","updated_at":"2015-04-02T21:08:33Z","pushed_at":"2015-04-06T19:25:54Z","git_url":"git://github.com/paulerickson/angularjs-portal.git","ssh_url":"git@github.com:paulerickson/angularjs-portal.git","clone_url":"https://github.com/paulerickson/angularjs-portal.git","svn_url":"https://github.com/paulerickson/angularjs-portal","homepage":"","size":9497,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"UW-Madison-DoIT:master","ref":"master","sha":"5b0b2630acf6b2964a011afbdaef299efc844471","user":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"repo":{"id":24428594,"name":"angularjs-portal","full_name":"UW-Madison-DoIT/angularjs-portal","owner":{"login":"UW-Madison-DoIT","id":1629635,"avatar_url":"https://avatars.githubusercontent.com/u/1629635?v=3","gravatar_id":"","url":"https://api.github.com/users/UW-Madison-DoIT","html_url":"https://github.com/UW-Madison-DoIT","followers_url":"https://api.github.com/users/UW-Madison-DoIT/followers","following_url":"https://api.github.com/users/UW-Madison-DoIT/following{/other_user}","gists_url":"https://api.github.com/users/UW-Madison-DoIT/gists{/gist_id}","starred_url":"https://api.github.com/users/UW-Madison-DoIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UW-Madison-DoIT/subscriptions","organizations_url":"https://api.github.com/users/UW-Madison-DoIT/orgs","repos_url":"https://api.github.com/users/UW-Madison-DoIT/repos","events_url":"https://api.github.com/users/UW-Madison-DoIT/events{/privacy}","received_events_url":"https://api.github.com/users/UW-Madison-DoIT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UW-Madison-DoIT/angularjs-portal","description":"AngularJS alternative UI for MyUW portal (built for uPortal).","fork":false,"url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal","forks_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/forks","keys_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/teams","hooks_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/hooks","issue_events_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/events{/number}","events_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/events","assignees_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/assignees{/user}","branches_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/branches{/branch}","tags_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/tags","blobs_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/languages","stargazers_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/stargazers","contributors_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/contributors","subscribers_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/subscribers","subscription_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/subscription","commits_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/contents/{+path}","compare_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/merges","archive_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/downloads","issues_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues{/number}","pulls_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/labels{/name}","releases_url":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/releases{/id}","created_at":"2014-09-24T19:04:44Z","updated_at":"2015-04-02T14:55:59Z","pushed_at":"2015-04-06T19:48:25Z","git_url":"git://github.com/UW-Madison-DoIT/angularjs-portal.git","ssh_url":"git@github.com:UW-Madison-DoIT/angularjs-portal.git","clone_url":"https://github.com/UW-Madison-DoIT/angularjs-portal.git","svn_url":"https://github.com/UW-Madison-DoIT/angularjs-portal","homepage":"","size":12890,"stargazers_count":3,"watchers_count":3,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/185"},"html":{"href":"https://github.com/UW-Madison-DoIT/angularjs-portal/pull/185"},"issue":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/185"},"comments":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/UW-Madison-DoIT/angularjs-portal/statuses/20ff32eccc6b3d30338ae6fdcc098d83af7b6c62"}}}}