{"action":"created","issue":{"url":"https://api.github.com/repos/cucumber/aruba/issues/217","labels_url":"https://api.github.com/repos/cucumber/aruba/issues/217/labels{/name}","comments_url":"https://api.github.com/repos/cucumber/aruba/issues/217/comments","events_url":"https://api.github.com/repos/cucumber/aruba/issues/217/events","html_url":"https://github.com/cucumber/aruba/pull/217","id":43955351,"number":217,"title":"Use simplecov for coverage reports for specs and cucumber","user":{"login":"limhoff-r7","id":2230482,"avatar_url":"https://avatars.githubusercontent.com/u/2230482?v=3","gravatar_id":"","url":"https://api.github.com/users/limhoff-r7","html_url":"https://github.com/limhoff-r7","followers_url":"https://api.github.com/users/limhoff-r7/followers","following_url":"https://api.github.com/users/limhoff-r7/following{/other_user}","gists_url":"https://api.github.com/users/limhoff-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/limhoff-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/limhoff-r7/subscriptions","organizations_url":"https://api.github.com/users/limhoff-r7/orgs","repos_url":"https://api.github.com/users/limhoff-r7/repos","events_url":"https://api.github.com/users/limhoff-r7/events{/privacy}","received_events_url":"https://api.github.com/users/limhoff-r7/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2014-09-25T19:09:37Z","updated_at":"2015-05-13T18:23:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cucumber/aruba/pulls/217","html_url":"https://github.com/cucumber/aruba/pull/217","diff_url":"https://github.com/cucumber/aruba/pull/217.diff","patch_url":"https://github.com/cucumber/aruba/pull/217.patch"},"body":"simplecov is a wrapper on the built-in coverage library for Ruby 1.9+.  When running `rake spec` or `rake cucumber`, a coverage report will be output in coverage/index.html.  If you run both tasks or all tasks with `rake spec` within a close enough time window (I think 10 minutes) the results will all be merged so you can get coverage across both the specs and features.  If this PR is accepts, then I'll add another to use coveralls.io to publish the coverage reports to coveralls.io, but someone with admin access will have to setup the hooks on coveralls.io for that.  Additionally, the reports from simplecov are a confirmation that not all steps are being exercised, include the ones dealing with rvm.  I have a fix for that too that I can post in a later PR.\r\n\r\n![screen shot 2014-09-25 at 2 04 16 pm](https://cloud.githubusercontent.com/assets/2230482/4410585/09ea8eb6-44e7-11e4-9572-f7f83ba28451.png)\r\n\r\n# Verifications Steps\r\n\r\n## specs\r\n\r\n- [ ] `rake spec`\r\n- [ ] VERIFY no failures\r\n- [ ] `open coverage/index.html`\r\n- [ ] VERIFY coverage report includes specs\r\n- [ ] `rm -rf coverage`\r\n\r\n## cucumber\r\n\r\n- [ ] `rake cucumber`\r\n- [ ] VERIFY no failures\r\n- [ ] `open coverage/index.html`\r\n- [ ] VIERFY coverage report includes features and steps\r\n- [ ] `rm -rf coverage`\r\n\r\n## all\r\n\r\n- [ ] `rake`\r\n- [ ] VERIFY no failures\r\n- [ ] `open coverage/index.html`\r\n- [ ] VERIFY coverage includes specs, features, and steps\r\n"},"comment":{"url":"https://api.github.com/repos/cucumber/aruba/issues/comments/101767282","html_url":"https://github.com/cucumber/aruba/pull/217#issuecomment-101767282","issue_url":"https://api.github.com/repos/cucumber/aruba/issues/217","id":101767282,"user":{"login":"maxmeyer","id":114236,"avatar_url":"https://avatars.githubusercontent.com/u/114236?v=3","gravatar_id":"","url":"https://api.github.com/users/maxmeyer","html_url":"https://github.com/maxmeyer","followers_url":"https://api.github.com/users/maxmeyer/followers","following_url":"https://api.github.com/users/maxmeyer/following{/other_user}","gists_url":"https://api.github.com/users/maxmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/maxmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxmeyer/subscriptions","organizations_url":"https://api.github.com/users/maxmeyer/orgs","repos_url":"https://api.github.com/users/maxmeyer/repos","events_url":"https://api.github.com/users/maxmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/maxmeyer/received_events","type":"User","site_admin":false},"created_at":"2015-05-13T18:23:24Z","updated_at":"2015-05-13T18:23:24Z","body":"@limhoff-r7 \r\n\r\nIf you like, please fix the things mentioned above + rebase again + squash commits - all changes which belong together should be in a single commit:\r\n\r\n* Integrate into spec\r\n* Integrate into features\r\n* [...]\r\n\r\nAnd so on. All \"helper\" commits like \"Fixed offense\" should be gone after this. Then I'll be happy to merge this.\r\n\r\nThanks a lot."}}