{"action":"created","issue":{"url":"https://api.github.com/repos/holidayextras/loggly-interface/issues/4","labels_url":"https://api.github.com/repos/holidayextras/loggly-interface/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/holidayextras/loggly-interface/issues/4/comments","events_url":"https://api.github.com/repos/holidayextras/loggly-interface/issues/4/events","html_url":"https://github.com/holidayextras/loggly-interface/pull/4","id":108420402,"number":4,"title":"Moving to CircleCi","user":{"login":"notABluesSinger","id":6094305,"avatar_url":"https://avatars.githubusercontent.com/u/6094305?v=3","gravatar_id":"","url":"https://api.github.com/users/notABluesSinger","html_url":"https://github.com/notABluesSinger","followers_url":"https://api.github.com/users/notABluesSinger/followers","following_url":"https://api.github.com/users/notABluesSinger/following{/other_user}","gists_url":"https://api.github.com/users/notABluesSinger/gists{/gist_id}","starred_url":"https://api.github.com/users/notABluesSinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notABluesSinger/subscriptions","organizations_url":"https://api.github.com/users/notABluesSinger/orgs","repos_url":"https://api.github.com/users/notABluesSinger/repos","events_url":"https://api.github.com/users/notABluesSinger/events{/privacy}","received_events_url":"https://api.github.com/users/notABluesSinger/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/holidayextras/loggly-interface/labels/ready%20for%20review","name":"ready for review","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-25T22:54:52Z","updated_at":"2015-09-29T10:36:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/holidayextras/loggly-interface/pulls/4","html_url":"https://github.com/holidayextras/loggly-interface/pull/4","diff_url":"https://github.com/holidayextras/loggly-interface/pull/4.diff","patch_url":"https://github.com/holidayextras/loggly-interface/pull/4.patch"},"body":"#### What are the links to relevant tickets?\r\n[WEB-5164](https://hxshortbreaks.atlassian.net/browse/WEB-5164)\r\n#### What does this PR do?\r\nMoves the build agent from shippable over to CircleCI.\r\n#### What functional/unit tests does this PR have?\r\nN/A\r\n#### How should a developer review this?\r\nEyes\r\n#### Any background context you want to provide?\r\nYou know... shippable and all that\r\n#### Screenshots (if appropriate)\r\n---\r\n\r\n#### Quality checklist (for PR author to complete BEFORE code review):\r\n- [x] Bumped version in `package.json`.\r\n- [x] Created `circle.yml` in project.\r\n- [x] Deleted `shippable.yml`.\r\n- [ ] Split any deploy script to `deployToStaging.sh` & `deployToProduction.sh`.\r\n- [x] Update Readme with new build badge`.\r\n- [x] Setup `GHUSER` environment variable in Circle.\r\n- [x] Setup `GHPASS` environment variable in Circle.\r\n- [x] Setup `GRAPHITE_API_KEY` environment variable in Circle.\r\n- [x] Setup `GRAPHITE_ENDPOINT_PREFIX` environment variable in Circle.\r\n- [x] Setup **slack** webhook and *quiet* mode.\r\n- [x] Setup API **status** token in Circle.\r\n- [ ] Added AWS credentials for **shortbreaksBuildAgent**\r\n- [x] Added **shortbreaksBuildAgent** Deploy Key\r\n- [x] I am ready for this to be code reviewed, merged and tested.\r\n\r\n#### Reviewer 1\r\n- [ ] I agree with the assumptions made in the quality checklist.\r\n- [ ] I’ve witnessed the work behaving as expected.\r\n- [ ] I’ve checked for appropriate test coverage.\r\n- [ ] I’ve checked for coding anti-patterns.\r\n- [ ] I've checked this work against the requirements of the Jira.\r\n- [ ] I don’t believe this work introduces unnecessary technical debt.\r\n- [ ] +1 from me!\r\n\r\n#### Reviewer 2\r\n- [ ] I agree with the assumptions made in the quality checklist.\r\n- [ ] I’ve witnessed the work behaving as expected.\r\n- [ ] I’ve checked for appropriate test coverage.\r\n- [ ] I’ve checked for coding anti-patterns.\r\n- [ ] I've checked this work against the requirements of the Jira.\r\n- [ ] I don’t believe this work introduces unnecessary technical debt.\r\n- [ ] +1 from me!"},"comment":{"url":"https://api.github.com/repos/holidayextras/loggly-interface/issues/comments/144019626","html_url":"https://github.com/holidayextras/loggly-interface/pull/4#issuecomment-144019626","issue_url":"https://api.github.com/repos/holidayextras/loggly-interface/issues/4","id":144019626,"user":{"login":"philmeehan","id":46255,"avatar_url":"https://avatars.githubusercontent.com/u/46255?v=3","gravatar_id":"","url":"https://api.github.com/users/philmeehan","html_url":"https://github.com/philmeehan","followers_url":"https://api.github.com/users/philmeehan/followers","following_url":"https://api.github.com/users/philmeehan/following{/other_user}","gists_url":"https://api.github.com/users/philmeehan/gists{/gist_id}","starred_url":"https://api.github.com/users/philmeehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philmeehan/subscriptions","organizations_url":"https://api.github.com/users/philmeehan/orgs","repos_url":"https://api.github.com/users/philmeehan/repos","events_url":"https://api.github.com/users/philmeehan/events{/privacy}","received_events_url":"https://api.github.com/users/philmeehan/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T10:36:50Z","updated_at":"2015-09-29T10:36:50Z","body":"Just to log the conversation we just had\r\n\r\nI downloaded the repo and ran npm i and npm test and I got an error saying that jq isn't installed.\r\n\r\nOn rojo's machine typing in which jq finds it but on mine and Marc's it hasn't been installed.\r\n\r\nRojo is going to investigate..."}}