{"action":"created","comment":{"url":"https://api.github.com/repos/mybb/mybb/pulls/comments/32988741","id":32988741,"diff_hunk":"@@ -0,0 +1,46 @@\n+<?php\n+/**\n+ * MyBB 1.8\n+ * Copyright 2014 MyBB Group, All Rights Reserved\n+ *\n+ * Website: http://www.mybb.com\n+ * License: http://www.mybb.com/about/license\n+ *\n+ */\n+\n+/**\n+ * Upgrade Script: 1.8.5\n+ */\n+\n+$upgrade_detail = array(\n+\t\"revert_all_templates\" => 0,\n+\t\"revert_all_themes\" => 0,\n+\t\"revert_all_settings\" => 0\n+);\n+\n+@set_time_limit(0);\n+\n+function upgrade34_dbchanges()\n+{\n+\tglobal $db, $output;\n+\n+\t$query = $db->simple_select('settings', 'value', \"name='username_method'\");","path":"install/resources/upgrade34.php","position":27,"original_position":27,"commit_id":"80c324661f093a02e7f44a0e06054cc2be0f5bd2","original_commit_id":"80c324661f093a02e7f44a0e06054cc2be0f5bd2","user":{"login":"Sama34","id":1786584,"avatar_url":"https://avatars.githubusercontent.com/u/1786584?v=3","gravatar_id":"","url":"https://api.github.com/users/Sama34","html_url":"https://github.com/Sama34","followers_url":"https://api.github.com/users/Sama34/followers","following_url":"https://api.github.com/users/Sama34/following{/other_user}","gists_url":"https://api.github.com/users/Sama34/gists{/gist_id}","starred_url":"https://api.github.com/users/Sama34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sama34/subscriptions","organizations_url":"https://api.github.com/users/Sama34/orgs","repos_url":"https://api.github.com/users/Sama34/repos","events_url":"https://api.github.com/users/Sama34/events{/privacy}","received_events_url":"https://api.github.com/users/Sama34/received_events","type":"User","site_admin":false},"body":"Nah. You got me with that last line. I will update the code later.\r\n\r\n> Otherwise it means __the cache is trustable enough__ to not do that.\r\n\r\nIf no case has been reported yet then it means it indeed is trust-able enough.","created_at":"2015-06-22T21:57:22Z","updated_at":"2015-06-22T21:57:22Z","html_url":"https://github.com/mybb/mybb/pull/1858#discussion_r32988741","pull_request_url":"https://api.github.com/repos/mybb/mybb/pulls/1858","_links":{"self":{"href":"https://api.github.com/repos/mybb/mybb/pulls/comments/32988741"},"html":{"href":"https://github.com/mybb/mybb/pull/1858#discussion_r32988741"},"pull_request":{"href":"https://api.github.com/repos/mybb/mybb/pulls/1858"}}},"pull_request":{"url":"https://api.github.com/repos/mybb/mybb/pulls/1858","id":29584052,"html_url":"https://github.com/mybb/mybb/pull/1858","diff_url":"https://github.com/mybb/mybb/pull/1858.diff","patch_url":"https://github.com/mybb/mybb/pull/1858.patch","issue_url":"https://api.github.com/repos/mybb/mybb/issues/1858","number":1858,"state":"open","locked":false,"title":"Fix #298 Login per E-Mail","user":{"login":"Sama34","id":1786584,"avatar_url":"https://avatars.githubusercontent.com/u/1786584?v=3","gravatar_id":"","url":"https://api.github.com/users/Sama34","html_url":"https://github.com/Sama34","followers_url":"https://api.github.com/users/Sama34/followers","following_url":"https://api.github.com/users/Sama34/following{/other_user}","gists_url":"https://api.github.com/users/Sama34/gists{/gist_id}","starred_url":"https://api.github.com/users/Sama34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sama34/subscriptions","organizations_url":"https://api.github.com/users/Sama34/orgs","repos_url":"https://api.github.com/users/Sama34/repos","events_url":"https://api.github.com/users/Sama34/events{/privacy}","received_events_url":"https://api.github.com/users/Sama34/received_events","type":"User","site_admin":false},"body":"Fix #298 Login per E-Mail","created_at":"2015-02-19T03:01:47Z","updated_at":"2015-06-22T21:57:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce5e367fce3cec32dbad2e0e588a871e65d780c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mybb/mybb/pulls/1858/commits","review_comments_url":"https://api.github.com/repos/mybb/mybb/pulls/1858/comments","review_comment_url":"https://api.github.com/repos/mybb/mybb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mybb/mybb/issues/1858/comments","statuses_url":"https://api.github.com/repos/mybb/mybb/statuses/80c324661f093a02e7f44a0e06054cc2be0f5bd2","head":{"label":"Sama34:fix-298","ref":"fix-298","sha":"80c324661f093a02e7f44a0e06054cc2be0f5bd2","user":{"login":"Sama34","id":1786584,"avatar_url":"https://avatars.githubusercontent.com/u/1786584?v=3","gravatar_id":"","url":"https://api.github.com/users/Sama34","html_url":"https://github.com/Sama34","followers_url":"https://api.github.com/users/Sama34/followers","following_url":"https://api.github.com/users/Sama34/following{/other_user}","gists_url":"https://api.github.com/users/Sama34/gists{/gist_id}","starred_url":"https://api.github.com/users/Sama34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sama34/subscriptions","organizations_url":"https://api.github.com/users/Sama34/orgs","repos_url":"https://api.github.com/users/Sama34/repos","events_url":"https://api.github.com/users/Sama34/events{/privacy}","received_events_url":"https://api.github.com/users/Sama34/received_events","type":"User","site_admin":false},"repo":{"id":28308785,"name":"mybb","full_name":"Sama34/mybb","owner":{"login":"Sama34","id":1786584,"avatar_url":"https://avatars.githubusercontent.com/u/1786584?v=3","gravatar_id":"","url":"https://api.github.com/users/Sama34","html_url":"https://github.com/Sama34","followers_url":"https://api.github.com/users/Sama34/followers","following_url":"https://api.github.com/users/Sama34/following{/other_user}","gists_url":"https://api.github.com/users/Sama34/gists{/gist_id}","starred_url":"https://api.github.com/users/Sama34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sama34/subscriptions","organizations_url":"https://api.github.com/users/Sama34/orgs","repos_url":"https://api.github.com/users/Sama34/repos","events_url":"https://api.github.com/users/Sama34/events{/privacy}","received_events_url":"https://api.github.com/users/Sama34/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sama34/mybb","description":"MyBB is a free and open source forum software.","fork":true,"url":"https://api.github.com/repos/Sama34/mybb","forks_url":"https://api.github.com/repos/Sama34/mybb/forks","keys_url":"https://api.github.com/repos/Sama34/mybb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sama34/mybb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sama34/mybb/teams","hooks_url":"https://api.github.com/repos/Sama34/mybb/hooks","issue_events_url":"https://api.github.com/repos/Sama34/mybb/issues/events{/number}","events_url":"https://api.github.com/repos/Sama34/mybb/events","assignees_url":"https://api.github.com/repos/Sama34/mybb/assignees{/user}","branches_url":"https://api.github.com/repos/Sama34/mybb/branches{/branch}","tags_url":"https://api.github.com/repos/Sama34/mybb/tags","blobs_url":"https://api.github.com/repos/Sama34/mybb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sama34/mybb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sama34/mybb/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sama34/mybb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sama34/mybb/statuses/{sha}","languages_url":"https://api.github.com/repos/Sama34/mybb/languages","stargazers_url":"https://api.github.com/repos/Sama34/mybb/stargazers","contributors_url":"https://api.github.com/repos/Sama34/mybb/contributors","subscribers_url":"https://api.github.com/repos/Sama34/mybb/subscribers","subscription_url":"https://api.github.com/repos/Sama34/mybb/subscription","commits_url":"https://api.github.com/repos/Sama34/mybb/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sama34/mybb/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sama34/mybb/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sama34/mybb/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sama34/mybb/contents/{+path}","compare_url":"https://api.github.com/repos/Sama34/mybb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sama34/mybb/merges","archive_url":"https://api.github.com/repos/Sama34/mybb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sama34/mybb/downloads","issues_url":"https://api.github.com/repos/Sama34/mybb/issues{/number}","pulls_url":"https://api.github.com/repos/Sama34/mybb/pulls{/number}","milestones_url":"https://api.github.com/repos/Sama34/mybb/milestones{/number}","notifications_url":"https://api.github.com/repos/Sama34/mybb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sama34/mybb/labels{/name}","releases_url":"https://api.github.com/repos/Sama34/mybb/releases{/id}","created_at":"2014-12-21T18:32:44Z","updated_at":"2015-02-18T21:09:36Z","pushed_at":"2015-06-14T00:13:15Z","git_url":"git://github.com/Sama34/mybb.git","ssh_url":"git@github.com:Sama34/mybb.git","clone_url":"https://github.com/Sama34/mybb.git","svn_url":"https://github.com/Sama34/mybb","homepage":"http://www.mybb.com","size":27073,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"feature"}},"base":{"label":"mybb:feature","ref":"feature","sha":"eb3b6c59115c37a820f6f7daaadf1ee21823a365","user":{"login":"mybb","id":328641,"avatar_url":"https://avatars.githubusercontent.com/u/328641?v=3","gravatar_id":"","url":"https://api.github.com/users/mybb","html_url":"https://github.com/mybb","followers_url":"https://api.github.com/users/mybb/followers","following_url":"https://api.github.com/users/mybb/following{/other_user}","gists_url":"https://api.github.com/users/mybb/gists{/gist_id}","starred_url":"https://api.github.com/users/mybb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mybb/subscriptions","organizations_url":"https://api.github.com/users/mybb/orgs","repos_url":"https://api.github.com/users/mybb/repos","events_url":"https://api.github.com/users/mybb/events{/privacy}","received_events_url":"https://api.github.com/users/mybb/received_events","type":"Organization","site_admin":false},"repo":{"id":4649599,"name":"mybb","full_name":"mybb/mybb","owner":{"login":"mybb","id":328641,"avatar_url":"https://avatars.githubusercontent.com/u/328641?v=3","gravatar_id":"","url":"https://api.github.com/users/mybb","html_url":"https://github.com/mybb","followers_url":"https://api.github.com/users/mybb/followers","following_url":"https://api.github.com/users/mybb/following{/other_user}","gists_url":"https://api.github.com/users/mybb/gists{/gist_id}","starred_url":"https://api.github.com/users/mybb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mybb/subscriptions","organizations_url":"https://api.github.com/users/mybb/orgs","repos_url":"https://api.github.com/users/mybb/repos","events_url":"https://api.github.com/users/mybb/events{/privacy}","received_events_url":"https://api.github.com/users/mybb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mybb/mybb","description":"MyBB is a free and open source forum software.","fork":false,"url":"https://api.github.com/repos/mybb/mybb","forks_url":"https://api.github.com/repos/mybb/mybb/forks","keys_url":"https://api.github.com/repos/mybb/mybb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mybb/mybb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mybb/mybb/teams","hooks_url":"https://api.github.com/repos/mybb/mybb/hooks","issue_events_url":"https://api.github.com/repos/mybb/mybb/issues/events{/number}","events_url":"https://api.github.com/repos/mybb/mybb/events","assignees_url":"https://api.github.com/repos/mybb/mybb/assignees{/user}","branches_url":"https://api.github.com/repos/mybb/mybb/branches{/branch}","tags_url":"https://api.github.com/repos/mybb/mybb/tags","blobs_url":"https://api.github.com/repos/mybb/mybb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mybb/mybb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mybb/mybb/git/refs{/sha}","trees_url":"https://api.github.com/repos/mybb/mybb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mybb/mybb/statuses/{sha}","languages_url":"https://api.github.com/repos/mybb/mybb/languages","stargazers_url":"https://api.github.com/repos/mybb/mybb/stargazers","contributors_url":"https://api.github.com/repos/mybb/mybb/contributors","subscribers_url":"https://api.github.com/repos/mybb/mybb/subscribers","subscription_url":"https://api.github.com/repos/mybb/mybb/subscription","commits_url":"https://api.github.com/repos/mybb/mybb/commits{/sha}","git_commits_url":"https://api.github.com/repos/mybb/mybb/git/commits{/sha}","comments_url":"https://api.github.com/repos/mybb/mybb/comments{/number}","issue_comment_url":"https://api.github.com/repos/mybb/mybb/issues/comments{/number}","contents_url":"https://api.github.com/repos/mybb/mybb/contents/{+path}","compare_url":"https://api.github.com/repos/mybb/mybb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mybb/mybb/merges","archive_url":"https://api.github.com/repos/mybb/mybb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mybb/mybb/downloads","issues_url":"https://api.github.com/repos/mybb/mybb/issues{/number}","pulls_url":"https://api.github.com/repos/mybb/mybb/pulls{/number}","milestones_url":"https://api.github.com/repos/mybb/mybb/milestones{/number}","notifications_url":"https://api.github.com/repos/mybb/mybb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mybb/mybb/labels{/name}","releases_url":"https://api.github.com/repos/mybb/mybb/releases{/id}","created_at":"2012-06-13T10:34:46Z","updated_at":"2015-06-20T11:26:51Z","pushed_at":"2015-06-22T20:07:54Z","git_url":"git://github.com/mybb/mybb.git","ssh_url":"git@github.com:mybb/mybb.git","clone_url":"https://github.com/mybb/mybb.git","svn_url":"https://github.com/mybb/mybb","homepage":"http://www.mybb.com","size":40011,"stargazers_count":252,"watchers_count":252,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":202,"mirror_url":null,"open_issues_count":166,"forks":202,"open_issues":166,"watchers":252,"default_branch":"feature"}},"_links":{"self":{"href":"https://api.github.com/repos/mybb/mybb/pulls/1858"},"html":{"href":"https://github.com/mybb/mybb/pull/1858"},"issue":{"href":"https://api.github.com/repos/mybb/mybb/issues/1858"},"comments":{"href":"https://api.github.com/repos/mybb/mybb/issues/1858/comments"},"review_comments":{"href":"https://api.github.com/repos/mybb/mybb/pulls/1858/comments"},"review_comment":{"href":"https://api.github.com/repos/mybb/mybb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mybb/mybb/pulls/1858/commits"},"statuses":{"href":"https://api.github.com/repos/mybb/mybb/statuses/80c324661f093a02e7f44a0e06054cc2be0f5bd2"}}}}