{"action":"created","comment":{"url":"https://api.github.com/repos/frida/frida-gum/pulls/comments/28863973","id":28863973,"diff_hunk":"@@ -64,11 +63,16 @@ gum_arm_reader_try_get_indirect_jump_target (gconstpointer address)\n       op1->type == ARM_OP_REG && op1->reg == ARM_REG_R12 &&\n       op2->type == ARM_OP_IMM)\n   {\n-    /* I couldn't really find the documentation of WHY this\n-     * should be shifted by 12, but it seems to be how both\n-     * objdump and IDA decode.\n-     */\n-    result += (op2->imm << 12);\n+    if (insn->detail->arm.op_count == 4)\n+    {\n+      /* I couldn't really find the documentation of WHY this","path":"gum/arch-arm/gumarmreader.c","position":19,"original_position":19,"commit_id":"aea11a496513a7dc4b8dbe749923a46dcf24ae5d","original_commit_id":"aea11a496513a7dc4b8dbe749923a46dcf24ae5d","user":{"login":"oleavr","id":735197,"avatar_url":"https://avatars.githubusercontent.com/u/735197?v=3","gravatar_id":"","url":"https://api.github.com/users/oleavr","html_url":"https://github.com/oleavr","followers_url":"https://api.github.com/users/oleavr/followers","following_url":"https://api.github.com/users/oleavr/following{/other_user}","gists_url":"https://api.github.com/users/oleavr/gists{/gist_id}","starred_url":"https://api.github.com/users/oleavr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleavr/subscriptions","organizations_url":"https://api.github.com/users/oleavr/orgs","repos_url":"https://api.github.com/users/oleavr/repos","events_url":"https://api.github.com/users/oleavr/events{/privacy}","received_events_url":"https://api.github.com/users/oleavr/received_events","type":"User","site_admin":false},"body":"Sorry, I missed this: Comments, unless single-line, should have a blank opening line, like:\r\n\r\n```C\r\n/*\r\n * Foo\r\n * Bar\r\n */\r\n```","created_at":"2015-04-22T11:29:58Z","updated_at":"2015-04-22T11:29:58Z","html_url":"https://github.com/frida/frida-gum/pull/38#discussion_r28863973","pull_request_url":"https://api.github.com/repos/frida/frida-gum/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/frida/frida-gum/pulls/comments/28863973"},"html":{"href":"https://github.com/frida/frida-gum/pull/38#discussion_r28863973"},"pull_request":{"href":"https://api.github.com/repos/frida/frida-gum/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/frida/frida-gum/pulls/38","id":33838293,"html_url":"https://github.com/frida/frida-gum/pull/38","diff_url":"https://github.com/frida/frida-gum/pull/38.diff","patch_url":"https://github.com/frida/frida-gum/pull/38.patch","issue_url":"https://api.github.com/repos/frida/frida-gum/issues/38","number":38,"state":"open","locked":false,"title":"Fix bugs in gumarmrelocator and gumarmreader related to improper instruction assembly/decoding. Also, implement rewrite for pc-relative add.","user":{"login":"s1341","id":5682183,"avatar_url":"https://avatars.githubusercontent.com/u/5682183?v=3","gravatar_id":"","url":"https://api.github.com/users/s1341","html_url":"https://github.com/s1341","followers_url":"https://api.github.com/users/s1341/followers","following_url":"https://api.github.com/users/s1341/following{/other_user}","gists_url":"https://api.github.com/users/s1341/gists{/gist_id}","starred_url":"https://api.github.com/users/s1341/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1341/subscriptions","organizations_url":"https://api.github.com/users/s1341/orgs","repos_url":"https://api.github.com/users/s1341/repos","events_url":"https://api.github.com/users/s1341/events{/privacy}","received_events_url":"https://api.github.com/users/s1341/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-22T09:00:00Z","updated_at":"2015-04-22T11:29:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c0f661344016827baa58fcb274f99a25de3b1ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/frida/frida-gum/pulls/38/commits","review_comments_url":"https://api.github.com/repos/frida/frida-gum/pulls/38/comments","review_comment_url":"https://api.github.com/repos/frida/frida-gum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/frida/frida-gum/issues/38/comments","statuses_url":"https://api.github.com/repos/frida/frida-gum/statuses/aea11a496513a7dc4b8dbe749923a46dcf24ae5d","head":{"label":"s1341:master","ref":"master","sha":"aea11a496513a7dc4b8dbe749923a46dcf24ae5d","user":{"login":"s1341","id":5682183,"avatar_url":"https://avatars.githubusercontent.com/u/5682183?v=3","gravatar_id":"","url":"https://api.github.com/users/s1341","html_url":"https://github.com/s1341","followers_url":"https://api.github.com/users/s1341/followers","following_url":"https://api.github.com/users/s1341/following{/other_user}","gists_url":"https://api.github.com/users/s1341/gists{/gist_id}","starred_url":"https://api.github.com/users/s1341/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1341/subscriptions","organizations_url":"https://api.github.com/users/s1341/orgs","repos_url":"https://api.github.com/users/s1341/repos","events_url":"https://api.github.com/users/s1341/events{/privacy}","received_events_url":"https://api.github.com/users/s1341/received_events","type":"User","site_admin":false},"repo":{"id":32918011,"name":"frida-gum","full_name":"s1341/frida-gum","owner":{"login":"s1341","id":5682183,"avatar_url":"https://avatars.githubusercontent.com/u/5682183?v=3","gravatar_id":"","url":"https://api.github.com/users/s1341","html_url":"https://github.com/s1341","followers_url":"https://api.github.com/users/s1341/followers","following_url":"https://api.github.com/users/s1341/following{/other_user}","gists_url":"https://api.github.com/users/s1341/gists{/gist_id}","starred_url":"https://api.github.com/users/s1341/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1341/subscriptions","organizations_url":"https://api.github.com/users/s1341/orgs","repos_url":"https://api.github.com/users/s1341/repos","events_url":"https://api.github.com/users/s1341/events{/privacy}","received_events_url":"https://api.github.com/users/s1341/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/s1341/frida-gum","description":"Low-level code instrumentation library used by frida-core","fork":true,"url":"https://api.github.com/repos/s1341/frida-gum","forks_url":"https://api.github.com/repos/s1341/frida-gum/forks","keys_url":"https://api.github.com/repos/s1341/frida-gum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s1341/frida-gum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s1341/frida-gum/teams","hooks_url":"https://api.github.com/repos/s1341/frida-gum/hooks","issue_events_url":"https://api.github.com/repos/s1341/frida-gum/issues/events{/number}","events_url":"https://api.github.com/repos/s1341/frida-gum/events","assignees_url":"https://api.github.com/repos/s1341/frida-gum/assignees{/user}","branches_url":"https://api.github.com/repos/s1341/frida-gum/branches{/branch}","tags_url":"https://api.github.com/repos/s1341/frida-gum/tags","blobs_url":"https://api.github.com/repos/s1341/frida-gum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s1341/frida-gum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s1341/frida-gum/git/refs{/sha}","trees_url":"https://api.github.com/repos/s1341/frida-gum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s1341/frida-gum/statuses/{sha}","languages_url":"https://api.github.com/repos/s1341/frida-gum/languages","stargazers_url":"https://api.github.com/repos/s1341/frida-gum/stargazers","contributors_url":"https://api.github.com/repos/s1341/frida-gum/contributors","subscribers_url":"https://api.github.com/repos/s1341/frida-gum/subscribers","subscription_url":"https://api.github.com/repos/s1341/frida-gum/subscription","commits_url":"https://api.github.com/repos/s1341/frida-gum/commits{/sha}","git_commits_url":"https://api.github.com/repos/s1341/frida-gum/git/commits{/sha}","comments_url":"https://api.github.com/repos/s1341/frida-gum/comments{/number}","issue_comment_url":"https://api.github.com/repos/s1341/frida-gum/issues/comments{/number}","contents_url":"https://api.github.com/repos/s1341/frida-gum/contents/{+path}","compare_url":"https://api.github.com/repos/s1341/frida-gum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s1341/frida-gum/merges","archive_url":"https://api.github.com/repos/s1341/frida-gum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s1341/frida-gum/downloads","issues_url":"https://api.github.com/repos/s1341/frida-gum/issues{/number}","pulls_url":"https://api.github.com/repos/s1341/frida-gum/pulls{/number}","milestones_url":"https://api.github.com/repos/s1341/frida-gum/milestones{/number}","notifications_url":"https://api.github.com/repos/s1341/frida-gum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s1341/frida-gum/labels{/name}","releases_url":"https://api.github.com/repos/s1341/frida-gum/releases{/id}","created_at":"2015-03-26T09:23:31Z","updated_at":"2015-04-22T11:24:22Z","pushed_at":"2015-04-22T11:24:22Z","git_url":"git://github.com/s1341/frida-gum.git","ssh_url":"git@github.com:s1341/frida-gum.git","clone_url":"https://github.com/s1341/frida-gum.git","svn_url":"https://github.com/s1341/frida-gum","homepage":"","size":8079,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"frida:master","ref":"master","sha":"b0baee25edf4b6bd2ddaee198c682f0f502a7edf","user":{"login":"frida","id":4073090,"avatar_url":"https://avatars.githubusercontent.com/u/4073090?v=3","gravatar_id":"","url":"https://api.github.com/users/frida","html_url":"https://github.com/frida","followers_url":"https://api.github.com/users/frida/followers","following_url":"https://api.github.com/users/frida/following{/other_user}","gists_url":"https://api.github.com/users/frida/gists{/gist_id}","starred_url":"https://api.github.com/users/frida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frida/subscriptions","organizations_url":"https://api.github.com/users/frida/orgs","repos_url":"https://api.github.com/users/frida/repos","events_url":"https://api.github.com/users/frida/events{/privacy}","received_events_url":"https://api.github.com/users/frida/received_events","type":"Organization","site_admin":false},"repo":{"id":9340574,"name":"frida-gum","full_name":"frida/frida-gum","owner":{"login":"frida","id":4073090,"avatar_url":"https://avatars.githubusercontent.com/u/4073090?v=3","gravatar_id":"","url":"https://api.github.com/users/frida","html_url":"https://github.com/frida","followers_url":"https://api.github.com/users/frida/followers","following_url":"https://api.github.com/users/frida/following{/other_user}","gists_url":"https://api.github.com/users/frida/gists{/gist_id}","starred_url":"https://api.github.com/users/frida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frida/subscriptions","organizations_url":"https://api.github.com/users/frida/orgs","repos_url":"https://api.github.com/users/frida/repos","events_url":"https://api.github.com/users/frida/events{/privacy}","received_events_url":"https://api.github.com/users/frida/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frida/frida-gum","description":"Low-level code instrumentation library used by frida-core","fork":false,"url":"https://api.github.com/repos/frida/frida-gum","forks_url":"https://api.github.com/repos/frida/frida-gum/forks","keys_url":"https://api.github.com/repos/frida/frida-gum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frida/frida-gum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frida/frida-gum/teams","hooks_url":"https://api.github.com/repos/frida/frida-gum/hooks","issue_events_url":"https://api.github.com/repos/frida/frida-gum/issues/events{/number}","events_url":"https://api.github.com/repos/frida/frida-gum/events","assignees_url":"https://api.github.com/repos/frida/frida-gum/assignees{/user}","branches_url":"https://api.github.com/repos/frida/frida-gum/branches{/branch}","tags_url":"https://api.github.com/repos/frida/frida-gum/tags","blobs_url":"https://api.github.com/repos/frida/frida-gum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frida/frida-gum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frida/frida-gum/git/refs{/sha}","trees_url":"https://api.github.com/repos/frida/frida-gum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frida/frida-gum/statuses/{sha}","languages_url":"https://api.github.com/repos/frida/frida-gum/languages","stargazers_url":"https://api.github.com/repos/frida/frida-gum/stargazers","contributors_url":"https://api.github.com/repos/frida/frida-gum/contributors","subscribers_url":"https://api.github.com/repos/frida/frida-gum/subscribers","subscription_url":"https://api.github.com/repos/frida/frida-gum/subscription","commits_url":"https://api.github.com/repos/frida/frida-gum/commits{/sha}","git_commits_url":"https://api.github.com/repos/frida/frida-gum/git/commits{/sha}","comments_url":"https://api.github.com/repos/frida/frida-gum/comments{/number}","issue_comment_url":"https://api.github.com/repos/frida/frida-gum/issues/comments{/number}","contents_url":"https://api.github.com/repos/frida/frida-gum/contents/{+path}","compare_url":"https://api.github.com/repos/frida/frida-gum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frida/frida-gum/merges","archive_url":"https://api.github.com/repos/frida/frida-gum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frida/frida-gum/downloads","issues_url":"https://api.github.com/repos/frida/frida-gum/issues{/number}","pulls_url":"https://api.github.com/repos/frida/frida-gum/pulls{/number}","milestones_url":"https://api.github.com/repos/frida/frida-gum/milestones{/number}","notifications_url":"https://api.github.com/repos/frida/frida-gum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frida/frida-gum/labels{/name}","releases_url":"https://api.github.com/repos/frida/frida-gum/releases{/id}","created_at":"2013-04-10T07:25:56Z","updated_at":"2015-04-21T17:18:42Z","pushed_at":"2015-04-22T11:24:23Z","git_url":"git://github.com/frida/frida-gum.git","ssh_url":"git@github.com:frida/frida-gum.git","clone_url":"https://github.com/frida/frida-gum.git","svn_url":"https://github.com/frida/frida-gum","homepage":"","size":10034,"stargazers_count":40,"watchers_count":40,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":6,"forks":12,"open_issues":6,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/frida/frida-gum/pulls/38"},"html":{"href":"https://github.com/frida/frida-gum/pull/38"},"issue":{"href":"https://api.github.com/repos/frida/frida-gum/issues/38"},"comments":{"href":"https://api.github.com/repos/frida/frida-gum/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/frida/frida-gum/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/frida/frida-gum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/frida/frida-gum/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/frida/frida-gum/statuses/aea11a496513a7dc4b8dbe749923a46dcf24ae5d"}}}}