{"action":"created","comment":{"url":"https://api.github.com/repos/google/cadvisor/pulls/comments/29512261","id":29512261,"diff_hunk":"@@ -137,7 +137,7 @@ func New(memoryStorage *memory.InMemoryStorage, sysfs sysfs.SysFs) (Manager, err\n \tglog.Infof(\"Version: %+v\", newManager.versionInfo)\n \n \t// TODO(vmarmol): Make configurable.\n-\tnewManager.eventHandler = events.NewEventManager(24 * time.Hour)\n+\tnewManager.eventHandler = events.NewEventManager(24*time.Hour, 100000)","path":"manager/manager.go","position":5,"original_position":5,"commit_id":"1c25746cf0d759b1c1185380dcf6e43293a08661","original_commit_id":"1c25746cf0d759b1c1185380dcf6e43293a08661","user":{"login":"rjnagal","id":5420489,"avatar_url":"https://avatars.githubusercontent.com/u/5420489?v=3","gravatar_id":"","url":"https://api.github.com/users/rjnagal","html_url":"https://github.com/rjnagal","followers_url":"https://api.github.com/users/rjnagal/followers","following_url":"https://api.github.com/users/rjnagal/following{/other_user}","gists_url":"https://api.github.com/users/rjnagal/gists{/gist_id}","starred_url":"https://api.github.com/users/rjnagal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjnagal/subscriptions","organizations_url":"https://api.github.com/users/rjnagal/orgs","repos_url":"https://api.github.com/users/rjnagal/repos","events_url":"https://api.github.com/users/rjnagal/events{/privacy}","received_events_url":"https://api.github.com/users/rjnagal/received_events","type":"User","site_admin":false},"body":"Can we make this a flag?","created_at":"2015-05-01T16:22:14Z","updated_at":"2015-05-01T16:22:14Z","html_url":"https://github.com/google/cadvisor/pull/671#discussion_r29512261","pull_request_url":"https://api.github.com/repos/google/cadvisor/pulls/671","_links":{"self":{"href":"https://api.github.com/repos/google/cadvisor/pulls/comments/29512261"},"html":{"href":"https://github.com/google/cadvisor/pull/671#discussion_r29512261"},"pull_request":{"href":"https://api.github.com/repos/google/cadvisor/pulls/671"}}},"pull_request":{"url":"https://api.github.com/repos/google/cadvisor/pulls/671","id":34524649,"html_url":"https://github.com/google/cadvisor/pull/671","diff_url":"https://github.com/google/cadvisor/pull/671.diff","patch_url":"https://github.com/google/cadvisor/pull/671.patch","issue_url":"https://api.github.com/repos/google/cadvisor/issues/671","number":671,"state":"open","locked":false,"title":"Add an item limit to TimedStore","user":{"login":"vmarmol","id":985208,"avatar_url":"https://avatars.githubusercontent.com/u/985208?v=3","gravatar_id":"","url":"https://api.github.com/users/vmarmol","html_url":"https://github.com/vmarmol","followers_url":"https://api.github.com/users/vmarmol/followers","following_url":"https://api.github.com/users/vmarmol/following{/other_user}","gists_url":"https://api.github.com/users/vmarmol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarmol/subscriptions","organizations_url":"https://api.github.com/users/vmarmol/orgs","repos_url":"https://api.github.com/users/vmarmol/repos","events_url":"https://api.github.com/users/vmarmol/events{/privacy}","received_events_url":"https://api.github.com/users/vmarmol/received_events","type":"User","site_admin":false},"body":"Made the default limit 100,000 elements which is a little over 1 event per second for a day and assuming 250 bytes per event it would take up ~24MiB per event type.\r\n\r\n/cc @rjnagal ","created_at":"2015-05-01T07:05:42Z","updated_at":"2015-05-01T16:22:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d8efed003a062f84c0c8fa6527563ff4e025546","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/cadvisor/pulls/671/commits","review_comments_url":"https://api.github.com/repos/google/cadvisor/pulls/671/comments","review_comment_url":"https://api.github.com/repos/google/cadvisor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/cadvisor/issues/671/comments","statuses_url":"https://api.github.com/repos/google/cadvisor/statuses/1c25746cf0d759b1c1185380dcf6e43293a08661","head":{"label":"vmarmol:limit","ref":"limit","sha":"1c25746cf0d759b1c1185380dcf6e43293a08661","user":{"login":"vmarmol","id":985208,"avatar_url":"https://avatars.githubusercontent.com/u/985208?v=3","gravatar_id":"","url":"https://api.github.com/users/vmarmol","html_url":"https://github.com/vmarmol","followers_url":"https://api.github.com/users/vmarmol/followers","following_url":"https://api.github.com/users/vmarmol/following{/other_user}","gists_url":"https://api.github.com/users/vmarmol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarmol/subscriptions","organizations_url":"https://api.github.com/users/vmarmol/orgs","repos_url":"https://api.github.com/users/vmarmol/repos","events_url":"https://api.github.com/users/vmarmol/events{/privacy}","received_events_url":"https://api.github.com/users/vmarmol/received_events","type":"User","site_admin":false},"repo":{"id":20785216,"name":"cadvisor","full_name":"vmarmol/cadvisor","owner":{"login":"vmarmol","id":985208,"avatar_url":"https://avatars.githubusercontent.com/u/985208?v=3","gravatar_id":"","url":"https://api.github.com/users/vmarmol","html_url":"https://github.com/vmarmol","followers_url":"https://api.github.com/users/vmarmol/followers","following_url":"https://api.github.com/users/vmarmol/following{/other_user}","gists_url":"https://api.github.com/users/vmarmol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarmol/subscriptions","organizations_url":"https://api.github.com/users/vmarmol/orgs","repos_url":"https://api.github.com/users/vmarmol/repos","events_url":"https://api.github.com/users/vmarmol/events{/privacy}","received_events_url":"https://api.github.com/users/vmarmol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vmarmol/cadvisor","description":"Analyzes resource usage and performance characteristics of running containers.","fork":true,"url":"https://api.github.com/repos/vmarmol/cadvisor","forks_url":"https://api.github.com/repos/vmarmol/cadvisor/forks","keys_url":"https://api.github.com/repos/vmarmol/cadvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmarmol/cadvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmarmol/cadvisor/teams","hooks_url":"https://api.github.com/repos/vmarmol/cadvisor/hooks","issue_events_url":"https://api.github.com/repos/vmarmol/cadvisor/issues/events{/number}","events_url":"https://api.github.com/repos/vmarmol/cadvisor/events","assignees_url":"https://api.github.com/repos/vmarmol/cadvisor/assignees{/user}","branches_url":"https://api.github.com/repos/vmarmol/cadvisor/branches{/branch}","tags_url":"https://api.github.com/repos/vmarmol/cadvisor/tags","blobs_url":"https://api.github.com/repos/vmarmol/cadvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmarmol/cadvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmarmol/cadvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmarmol/cadvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmarmol/cadvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/vmarmol/cadvisor/languages","stargazers_url":"https://api.github.com/repos/vmarmol/cadvisor/stargazers","contributors_url":"https://api.github.com/repos/vmarmol/cadvisor/contributors","subscribers_url":"https://api.github.com/repos/vmarmol/cadvisor/subscribers","subscription_url":"https://api.github.com/repos/vmarmol/cadvisor/subscription","commits_url":"https://api.github.com/repos/vmarmol/cadvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmarmol/cadvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmarmol/cadvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmarmol/cadvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmarmol/cadvisor/contents/{+path}","compare_url":"https://api.github.com/repos/vmarmol/cadvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmarmol/cadvisor/merges","archive_url":"https://api.github.com/repos/vmarmol/cadvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmarmol/cadvisor/downloads","issues_url":"https://api.github.com/repos/vmarmol/cadvisor/issues{/number}","pulls_url":"https://api.github.com/repos/vmarmol/cadvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/vmarmol/cadvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/vmarmol/cadvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmarmol/cadvisor/labels{/name}","releases_url":"https://api.github.com/repos/vmarmol/cadvisor/releases{/id}","created_at":"2014-06-12T22:43:07Z","updated_at":"2015-03-19T15:50:25Z","pushed_at":"2015-05-01T07:04:11Z","git_url":"git://github.com/vmarmol/cadvisor.git","ssh_url":"git@github.com:vmarmol/cadvisor.git","clone_url":"https://github.com/vmarmol/cadvisor.git","svn_url":"https://github.com/vmarmol/cadvisor","homepage":"","size":19458,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"95f1ee9c405712ba1e423b7922403836b846b93e","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":20653934,"name":"cadvisor","full_name":"google/cadvisor","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/cadvisor","description":"Analyzes resource usage and performance characteristics of running containers.","fork":false,"url":"https://api.github.com/repos/google/cadvisor","forks_url":"https://api.github.com/repos/google/cadvisor/forks","keys_url":"https://api.github.com/repos/google/cadvisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/cadvisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/cadvisor/teams","hooks_url":"https://api.github.com/repos/google/cadvisor/hooks","issue_events_url":"https://api.github.com/repos/google/cadvisor/issues/events{/number}","events_url":"https://api.github.com/repos/google/cadvisor/events","assignees_url":"https://api.github.com/repos/google/cadvisor/assignees{/user}","branches_url":"https://api.github.com/repos/google/cadvisor/branches{/branch}","tags_url":"https://api.github.com/repos/google/cadvisor/tags","blobs_url":"https://api.github.com/repos/google/cadvisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/cadvisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/cadvisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/cadvisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/cadvisor/statuses/{sha}","languages_url":"https://api.github.com/repos/google/cadvisor/languages","stargazers_url":"https://api.github.com/repos/google/cadvisor/stargazers","contributors_url":"https://api.github.com/repos/google/cadvisor/contributors","subscribers_url":"https://api.github.com/repos/google/cadvisor/subscribers","subscription_url":"https://api.github.com/repos/google/cadvisor/subscription","commits_url":"https://api.github.com/repos/google/cadvisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/cadvisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/cadvisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/cadvisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/cadvisor/contents/{+path}","compare_url":"https://api.github.com/repos/google/cadvisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/cadvisor/merges","archive_url":"https://api.github.com/repos/google/cadvisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/cadvisor/downloads","issues_url":"https://api.github.com/repos/google/cadvisor/issues{/number}","pulls_url":"https://api.github.com/repos/google/cadvisor/pulls{/number}","milestones_url":"https://api.github.com/repos/google/cadvisor/milestones{/number}","notifications_url":"https://api.github.com/repos/google/cadvisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/cadvisor/labels{/name}","releases_url":"https://api.github.com/repos/google/cadvisor/releases{/id}","created_at":"2014-06-09T16:36:33Z","updated_at":"2015-05-01T16:20:43Z","pushed_at":"2015-05-01T16:20:43Z","git_url":"git://github.com/google/cadvisor.git","ssh_url":"git@github.com:google/cadvisor.git","clone_url":"https://github.com/google/cadvisor.git","svn_url":"https://github.com/google/cadvisor","homepage":"","size":22838,"stargazers_count":2254,"watchers_count":2254,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":243,"mirror_url":null,"open_issues_count":49,"forks":243,"open_issues":49,"watchers":2254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/cadvisor/pulls/671"},"html":{"href":"https://github.com/google/cadvisor/pull/671"},"issue":{"href":"https://api.github.com/repos/google/cadvisor/issues/671"},"comments":{"href":"https://api.github.com/repos/google/cadvisor/issues/671/comments"},"review_comments":{"href":"https://api.github.com/repos/google/cadvisor/pulls/671/comments"},"review_comment":{"href":"https://api.github.com/repos/google/cadvisor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/cadvisor/pulls/671/commits"},"statuses":{"href":"https://api.github.com/repos/google/cadvisor/statuses/1c25746cf0d759b1c1185380dcf6e43293a08661"}}}}