{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/28116490","id":28116490,"diff_hunk":"@@ -90,7 +90,7 @@ unix://[/path/to/socket] to use.\n   Set key=value labels to the daemon (displayed in `docker info`)\n \n **--log-driver**=\"*json-file*|*syslog*|*none*\"","path":"docs/man/docker.1.md","position":3,"original_position":3,"commit_id":"a4b7a9e1e5505983aea3f6d7e246c57a6f4f6170","original_commit_id":"a4b7a9e1e5505983aea3f6d7e246c57a6f4f6170","user":{"login":"moxiegirl","id":1347209,"avatar_url":"https://avatars.githubusercontent.com/u/1347209?v=3","gravatar_id":"","url":"https://api.github.com/users/moxiegirl","html_url":"https://github.com/moxiegirl","followers_url":"https://api.github.com/users/moxiegirl/followers","following_url":"https://api.github.com/users/moxiegirl/following{/other_user}","gists_url":"https://api.github.com/users/moxiegirl/gists{/gist_id}","starred_url":"https://api.github.com/users/moxiegirl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxiegirl/subscriptions","organizations_url":"https://api.github.com/users/moxiegirl/orgs","repos_url":"https://api.github.com/users/moxiegirl/repos","events_url":"https://api.github.com/users/moxiegirl/events{/privacy}","received_events_url":"https://api.github.com/users/moxiegirl/received_events","type":"User","site_admin":false},"body":"Since you hit the line underneath, any objects to making it match what you have added to cli.md?","created_at":"2015-04-10T01:01:02Z","updated_at":"2015-04-10T01:01:02Z","html_url":"https://github.com/docker/docker/pull/12209#discussion_r28116490","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/12209","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/28116490"},"html":{"href":"https://github.com/docker/docker/pull/12209#discussion_r28116490"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/12209"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/12209","id":32913156,"html_url":"https://github.com/docker/docker/pull/12209","diff_url":"https://github.com/docker/docker/pull/12209.diff","patch_url":"https://github.com/docker/docker/pull/12209.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/12209","number":12209,"state":"open","locked":false,"title":"cli: Better wording for daemon --log-driver","user":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"body":"This flag is passed to the daemon CLI. In my opinion, \"Container's\r\nlogging driver\" is not accurate and refers to 'one container'.\r\n\r\n```diff\r\n-      --log-driver=\"json-file\"               Container's logging driver (json-file/none)\r\n+      --log-driver=\"json-file\"               Default driver for container logs\r\n```\r\n\r\nAlso the `syslog` driver was missing from the list. Having the list\r\nof all logging drivers won't scale here (should be <80 chars per line)\r\nand we have `rotation` driver coming up in the pipeline as well (gh11485).\r\n\r\nBonus: maybe we can say \"Default logging driver for container logs\" but this is longer.\r\n\r\nSigned-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>\r\ncc: @LK4D4 ","created_at":"2015-04-08T23:41:21Z","updated_at":"2015-04-10T01:01:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ef3d619479c70268d953dbcc2a64e665c1d00df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/12209/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/12209/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/12209/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/a4b7a9e1e5505983aea3f6d7e246c57a6f4f6170","head":{"label":"ahmetalpbalkan:daemon/cli-help-log-driver-reword","ref":"daemon/cli-help-log-driver-reword","sha":"a4b7a9e1e5505983aea3f6d7e246c57a6f4f6170","user":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"repo":{"id":30384043,"name":"docker","full_name":"ahmetalpbalkan/docker","owner":{"login":"ahmetalpbalkan","id":159209,"avatar_url":"https://avatars.githubusercontent.com/u/159209?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetalpbalkan","html_url":"https://github.com/ahmetalpbalkan","followers_url":"https://api.github.com/users/ahmetalpbalkan/followers","following_url":"https://api.github.com/users/ahmetalpbalkan/following{/other_user}","gists_url":"https://api.github.com/users/ahmetalpbalkan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetalpbalkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetalpbalkan/subscriptions","organizations_url":"https://api.github.com/users/ahmetalpbalkan/orgs","repos_url":"https://api.github.com/users/ahmetalpbalkan/repos","events_url":"https://api.github.com/users/ahmetalpbalkan/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetalpbalkan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahmetalpbalkan/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/ahmetalpbalkan/docker","forks_url":"https://api.github.com/repos/ahmetalpbalkan/docker/forks","keys_url":"https://api.github.com/repos/ahmetalpbalkan/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahmetalpbalkan/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahmetalpbalkan/docker/teams","hooks_url":"https://api.github.com/repos/ahmetalpbalkan/docker/hooks","issue_events_url":"https://api.github.com/repos/ahmetalpbalkan/docker/issues/events{/number}","events_url":"https://api.github.com/repos/ahmetalpbalkan/docker/events","assignees_url":"https://api.github.com/repos/ahmetalpbalkan/docker/assignees{/user}","branches_url":"https://api.github.com/repos/ahmetalpbalkan/docker/branches{/branch}","tags_url":"https://api.github.com/repos/ahmetalpbalkan/docker/tags","blobs_url":"https://api.github.com/repos/ahmetalpbalkan/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahmetalpbalkan/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahmetalpbalkan/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahmetalpbalkan/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahmetalpbalkan/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/ahmetalpbalkan/docker/languages","stargazers_url":"https://api.github.com/repos/ahmetalpbalkan/docker/stargazers","contributors_url":"https://api.github.com/repos/ahmetalpbalkan/docker/contributors","subscribers_url":"https://api.github.com/repos/ahmetalpbalkan/docker/subscribers","subscription_url":"https://api.github.com/repos/ahmetalpbalkan/docker/subscription","commits_url":"https://api.github.com/repos/ahmetalpbalkan/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahmetalpbalkan/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahmetalpbalkan/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahmetalpbalkan/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahmetalpbalkan/docker/contents/{+path}","compare_url":"https://api.github.com/repos/ahmetalpbalkan/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahmetalpbalkan/docker/merges","archive_url":"https://api.github.com/repos/ahmetalpbalkan/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahmetalpbalkan/docker/downloads","issues_url":"https://api.github.com/repos/ahmetalpbalkan/docker/issues{/number}","pulls_url":"https://api.github.com/repos/ahmetalpbalkan/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/ahmetalpbalkan/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/ahmetalpbalkan/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahmetalpbalkan/docker/labels{/name}","releases_url":"https://api.github.com/repos/ahmetalpbalkan/docker/releases{/id}","created_at":"2015-02-05T23:23:10Z","updated_at":"2015-03-09T20:45:26Z","pushed_at":"2015-04-09T11:11:27Z","git_url":"git://github.com/ahmetalpbalkan/docker.git","ssh_url":"git@github.com:ahmetalpbalkan/docker.git","clone_url":"https://github.com/ahmetalpbalkan/docker.git","svn_url":"https://github.com/ahmetalpbalkan/docker","homepage":"http://www.docker.com","size":49141,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"91abff41dda96244ee3e4ae47e7c37c5067657a7","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-04-10T00:01:00Z","pushed_at":"2015-04-10T00:50:01Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":170673,"stargazers_count":20691,"watchers_count":20691,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4695,"mirror_url":null,"open_issues_count":895,"forks":4695,"open_issues":895,"watchers":20691,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/12209"},"html":{"href":"https://github.com/docker/docker/pull/12209"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/12209"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/12209/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/12209/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/12209/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/a4b7a9e1e5505983aea3f6d7e246c57a6f4f6170"}}}}