{"action":"created","issue":{"url":"https://api.github.com/repos/certik/symengine/issues/6","labels_url":"https://api.github.com/repos/certik/symengine/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/certik/symengine/issues/6/comments","events_url":"https://api.github.com/repos/certik/symengine/issues/6/events","html_url":"https://github.com/certik/symengine/pull/6","id":92513764,"number":6,"title":"Refactored CRCPBasic in C wrappers and tests","user":{"login":"abinashmeher999","id":6918379,"avatar_url":"https://avatars.githubusercontent.com/u/6918379?v=3","gravatar_id":"","url":"https://api.github.com/users/abinashmeher999","html_url":"https://github.com/abinashmeher999","followers_url":"https://api.github.com/users/abinashmeher999/followers","following_url":"https://api.github.com/users/abinashmeher999/following{/other_user}","gists_url":"https://api.github.com/users/abinashmeher999/gists{/gist_id}","starred_url":"https://api.github.com/users/abinashmeher999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abinashmeher999/subscriptions","organizations_url":"https://api.github.com/users/abinashmeher999/orgs","repos_url":"https://api.github.com/users/abinashmeher999/repos","events_url":"https://api.github.com/users/abinashmeher999/events{/privacy}","received_events_url":"https://api.github.com/users/abinashmeher999/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-02T00:18:26Z","updated_at":"2015-07-02T00:39:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/certik/symengine/pulls/6","html_url":"https://github.com/certik/symengine/pull/6","diff_url":"https://github.com/certik/symengine/pull/6.diff","patch_url":"https://github.com/certik/symengine/pull/6.patch"},"body":"Regarding [PR#495](https://github.com/sympy/symengine/pull/495)\r\n> And that's how we need to allocate the `CRCPBasic` type. The approach of `vectorint_placement_new` is very general, since the C wrappers do not know its size, but for `CRCPBasic` we know its size, so we'll use the same trick that we already implemented in `basic_init`.\r\n\r\nThis is still pending. Meanwhile in the tests, I am getting [this](https://gist.github.com/abinashmeher999/38138341fbd9ac5c867e) error. I am not able to find the reason. I will fix this before adding the refactored Ruby C wrappers. The next target is to make the ctests `test_cwrapper` pass before adding the refactored Ruby C wrappers."},"comment":{"url":"https://api.github.com/repos/certik/symengine/issues/comments/117861829","html_url":"https://github.com/certik/symengine/pull/6#issuecomment-117861829","issue_url":"https://api.github.com/repos/certik/symengine/issues/6","id":117861829,"user":{"login":"certik","id":20568,"avatar_url":"https://avatars.githubusercontent.com/u/20568?v=3","gravatar_id":"","url":"https://api.github.com/users/certik","html_url":"https://github.com/certik","followers_url":"https://api.github.com/users/certik/followers","following_url":"https://api.github.com/users/certik/following{/other_user}","gists_url":"https://api.github.com/users/certik/gists{/gist_id}","starred_url":"https://api.github.com/users/certik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certik/subscriptions","organizations_url":"https://api.github.com/users/certik/orgs","repos_url":"https://api.github.com/users/certik/repos","events_url":"https://api.github.com/users/certik/events{/privacy}","received_events_url":"https://api.github.com/users/certik/received_events","type":"User","site_admin":false},"created_at":"2015-07-02T00:39:55Z","updated_at":"2015-07-02T00:39:55Z","body":"The error means you didn't define the type fully. It's a bit tricky, we\nmight need to use some ifdefs\n\nSent from my mobile phone.\nOn Jul 1, 2015 6:18 PM, \"Abinash Meher\" <notifications@github.com> wrote:\n\n> Regarding PR#495 <https://github.com/sympy/symengine/pull/495>\n>\n> And that's how we need to allocate the CRCPBasic type. The approach of\n> vectorint_placement_new is very general, since the C wrappers do not know\n> its size, but for CRCPBasic we know its size, so we'll use the same trick\n> that we already implemented in basic_init.\n>\n> This is still pending. Meanwhile in the tests, I am getting this\n> <https://gist.github.com/abinashmeher999/38138341fbd9ac5c867e> error. I\n> am not able to find the reason. I will fix this before adding the\n> refactored Ruby C wrappers. The next target is to make the ctests\n> test_cwrapper pass before adding the refactored Ruby C wrappers.\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/certik/symengine/pull/6\n> Commit Summary\n>\n>    - Refactored CRCPBasic in C wrappers and tests\n>\n> File Changes\n>\n>    - *M* symengine/cwrapper.cpp\n>    <https://github.com/certik/symengine/pull/6/files#diff-0> (321)\n>    - *M* symengine/cwrapper.h\n>    <https://github.com/certik/symengine/pull/6/files#diff-1> (106)\n>    - *M* symengine/tests/cwrapper/test_cwrapper.c\n>    <https://github.com/certik/symengine/pull/6/files#diff-2> (50)\n>\n> Patch Links:\n>\n>    - https://github.com/certik/symengine/pull/6.patch\n>    - https://github.com/certik/symengine/pull/6.diff\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/certik/symengine/pull/6>.\n>\n"}}