{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/29493722","id":29493722,"diff_hunk":"@@ -95,13 +99,17 @@ public JmsSource(JmsPluginConfig config) {\n    */\n   public void initialize(RealtimeContext context) throws Exception {\n     super.initialize(context);\n-    Map<String, String> runtimeArguments = context.getPluginProperties().getProperties();\n+    Map<String, String> runtimeArguments = Maps.newHashMap();\n+    if (config.getProperties() != null) {\n+      runtimeArguments.putAll(config.getProperties().getProperties());\n+    }\n \n     Integer configMessagesToReceive = config.messagesToReceive;\n     messagesToReceive = configMessagesToReceive.intValue();\n \n-    // Try get the destination name\n-    String destinationName = config.destinationName;\n+    // Set initial context factory name and provider URL\n+    runtimeArguments.put(Context.INITIAL_CONTEXT_FACTORY, config.initialContextFactory);\n+    runtimeArguments.put(Context.PROVIDER_URL, config.providerUrl);\n \n     // Get environment vars - this would be prefixed with java.naming.*\n     final Hashtable<String, String> envVars = new Hashtable<String, String>();","path":"cdap-app-templates/cdap-etl/cdap-etl-lib/src/main/java/co/cask/cdap/templates/etl/realtime/sources/JmsSource.java","position":38,"original_position":38,"commit_id":"26ddac97e33a7d625fd42784ef174fabb8d151c7","original_commit_id":"26ddac97e33a7d625fd42784ef174fabb8d151c7","user":{"login":"henry-cask","id":11763016,"avatar_url":"https://avatars.githubusercontent.com/u/11763016?v=3","gravatar_id":"","url":"https://api.github.com/users/henry-cask","html_url":"https://github.com/henry-cask","followers_url":"https://api.github.com/users/henry-cask/followers","following_url":"https://api.github.com/users/henry-cask/following{/other_user}","gists_url":"https://api.github.com/users/henry-cask/gists{/gist_id}","starred_url":"https://api.github.com/users/henry-cask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henry-cask/subscriptions","organizations_url":"https://api.github.com/users/henry-cask/orgs","repos_url":"https://api.github.com/users/henry-cask/repos","events_url":"https://api.github.com/users/henry-cask/events{/privacy}","received_events_url":"https://api.github.com/users/henry-cask/received_events","type":"User","site_admin":false},"body":"This will eventually be passed to JmsProvider which later be pushed to InitialContext which only take HashTable. Either do HashTable now or convert later =(\r\n\r\nThis  is what happen when we use 10 year old tech =P","created_at":"2015-05-01T08:29:46Z","updated_at":"2015-05-01T08:29:46Z","html_url":"https://github.com/caskdata/cdap/pull/2477#discussion_r29493722","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/2477","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/29493722"},"html":{"href":"https://github.com/caskdata/cdap/pull/2477#discussion_r29493722"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2477"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/2477","id":34521923,"html_url":"https://github.com/caskdata/cdap/pull/2477","diff_url":"https://github.com/caskdata/cdap/pull/2477.diff","patch_url":"https://github.com/caskdata/cdap/pull/2477.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/2477","number":2477,"state":"open","locked":false,"title":"Fix JMS realtime source to pass the right properties via the PluginConfig","user":{"login":"henry-cask","id":11763016,"avatar_url":"https://avatars.githubusercontent.com/u/11763016?v=3","gravatar_id":"","url":"https://api.github.com/users/henry-cask","html_url":"https://github.com/henry-cask","followers_url":"https://api.github.com/users/henry-cask/followers","following_url":"https://api.github.com/users/henry-cask/following{/other_user}","gists_url":"https://api.github.com/users/henry-cask/gists{/gist_id}","starred_url":"https://api.github.com/users/henry-cask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henry-cask/subscriptions","organizations_url":"https://api.github.com/users/henry-cask/orgs","repos_url":"https://api.github.com/users/henry-cask/repos","events_url":"https://api.github.com/users/henry-cask/events{/privacy}","received_events_url":"https://api.github.com/users/henry-cask/received_events","type":"User","site_admin":false},"body":"Add more required parameters for JMS JNDI naming via the JmsPluginConfig fields rather than\r\npass through from PluginConfig properties to help testing.\r\n\r\nThis PR makes testing easier because the parent PluginConfig's properties is a private memeber\r\nand the method to get the properties is final so need to push some of the java naming\r\nproperties as top level fields in JmsPluginConfig class which extends the PluginConfig","created_at":"2015-05-01T05:14:14Z","updated_at":"2015-05-01T08:29:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f1272c7983bf79b276885c88ce6ec801bb492cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/2477/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/2477/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/2477/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/26ddac97e33a7d625fd42784ef174fabb8d151c7","head":{"label":"caskdata:feature-adapter/fix_jms_sourcce_for_plugin_config_mode","ref":"feature-adapter/fix_jms_sourcce_for_plugin_config_mode","sha":"26ddac97e33a7d625fd42784ef174fabb8d151c7","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-05-01T05:23:29Z","pushed_at":"2015-05-01T08:21:00Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":865790,"stargazers_count":45,"watchers_count":45,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":16,"forks":16,"open_issues":16,"watchers":45,"default_branch":"develop"}},"base":{"label":"caskdata:release/3.0","ref":"release/3.0","sha":"62e550f50ff312c03fde8ee0541678a7c858e3e0","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-05-01T05:23:29Z","pushed_at":"2015-05-01T08:21:00Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":865790,"stargazers_count":45,"watchers_count":45,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":16,"forks":16,"open_issues":16,"watchers":45,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2477"},"html":{"href":"https://github.com/caskdata/cdap/pull/2477"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/2477"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/2477/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2477/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2477/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/26ddac97e33a7d625fd42784ef174fabb8d151c7"}}}}