{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/33290158","id":33290158,"diff_hunk":"@@ -156,41 +156,124 @@ public Task<Stream> GetStreamAsync(string requestUri)\n         // Unbuffered by default\n         public Task<Stream> GetStreamAsync(Uri requestUri)\n         {\n-            return GetContentAsync(requestUri, HttpCompletionOption.ResponseHeadersRead, Stream.Null,\n+            return GetStreamContentAsync(requestUri, HttpCompletionOption.ResponseHeadersRead,\n                 content => content.ReadAsStreamAsync());\n         }\n \n-        private Task<T> GetContentAsync<T>(Uri requestUri, HttpCompletionOption completionOption, T defaultValue,\n-            Func<HttpContent, Task<T>> readAs)\n+        private Task<string> GetStringContentAsync(Uri requestUri, HttpCompletionOption completionOption, \n+            Func<HttpContent, Task<string>> readAs)\n         {\n-            TaskCompletionSource<T> tcs = new TaskCompletionSource<T>();\n+            var tcs = new TaskCompletionSource<string>(readAs);","path":"src/System.Net.Http/src/System/Net/HttpClient.cs","position":33,"original_position":33,"commit_id":"5f8fb16d8a1ac9851c72ec2beedebe9256a6245f","original_commit_id":"5f8fb16d8a1ac9851c72ec2beedebe9256a6245f","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"This ```readAs``` delegate is now going to be exposed from the returned ```Task```'s AsyncState property.  That's probably undesirable, but it's up to @davidsh et al whether they're comfortable with that.","created_at":"2015-06-25T18:43:30Z","updated_at":"2015-06-25T18:43:30Z","html_url":"https://github.com/dotnet/corefx/pull/2153#discussion_r33290158","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/2153","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/33290158"},"html":{"href":"https://github.com/dotnet/corefx/pull/2153#discussion_r33290158"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2153"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/2153","id":38484723,"html_url":"https://github.com/dotnet/corefx/pull/2153","diff_url":"https://github.com/dotnet/corefx/pull/2153.diff","patch_url":"https://github.com/dotnet/corefx/pull/2153.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/2153","number":2153,"state":"open","locked":false,"title":"Eliminate closure allocations in System.Net.Http","user":{"login":"Maxwe11","id":1083827,"avatar_url":"https://avatars.githubusercontent.com/u/1083827?v=3","gravatar_id":"","url":"https://api.github.com/users/Maxwe11","html_url":"https://github.com/Maxwe11","followers_url":"https://api.github.com/users/Maxwe11/followers","following_url":"https://api.github.com/users/Maxwe11/following{/other_user}","gists_url":"https://api.github.com/users/Maxwe11/gists{/gist_id}","starred_url":"https://api.github.com/users/Maxwe11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maxwe11/subscriptions","organizations_url":"https://api.github.com/users/Maxwe11/orgs","repos_url":"https://api.github.com/users/Maxwe11/repos","events_url":"https://api.github.com/users/Maxwe11/events{/privacy}","received_events_url":"https://api.github.com/users/Maxwe11/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-24T20:37:44Z","updated_at":"2015-06-25T18:43:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b529da375dbe5a5633c1d2e19795650c870c0db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/2153/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/2153/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/2153/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/5f8fb16d8a1ac9851c72ec2beedebe9256a6245f","head":{"label":"Maxwe11:system.net.http-closure","ref":"system.net.http-closure","sha":"5f8fb16d8a1ac9851c72ec2beedebe9256a6245f","user":{"login":"Maxwe11","id":1083827,"avatar_url":"https://avatars.githubusercontent.com/u/1083827?v=3","gravatar_id":"","url":"https://api.github.com/users/Maxwe11","html_url":"https://github.com/Maxwe11","followers_url":"https://api.github.com/users/Maxwe11/followers","following_url":"https://api.github.com/users/Maxwe11/following{/other_user}","gists_url":"https://api.github.com/users/Maxwe11/gists{/gist_id}","starred_url":"https://api.github.com/users/Maxwe11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maxwe11/subscriptions","organizations_url":"https://api.github.com/users/Maxwe11/orgs","repos_url":"https://api.github.com/users/Maxwe11/repos","events_url":"https://api.github.com/users/Maxwe11/events{/privacy}","received_events_url":"https://api.github.com/users/Maxwe11/received_events","type":"User","site_admin":false},"repo":{"id":29371653,"name":"corefx","full_name":"Maxwe11/corefx","owner":{"login":"Maxwe11","id":1083827,"avatar_url":"https://avatars.githubusercontent.com/u/1083827?v=3","gravatar_id":"","url":"https://api.github.com/users/Maxwe11","html_url":"https://github.com/Maxwe11","followers_url":"https://api.github.com/users/Maxwe11/followers","following_url":"https://api.github.com/users/Maxwe11/following{/other_user}","gists_url":"https://api.github.com/users/Maxwe11/gists{/gist_id}","starred_url":"https://api.github.com/users/Maxwe11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maxwe11/subscriptions","organizations_url":"https://api.github.com/users/Maxwe11/orgs","repos_url":"https://api.github.com/users/Maxwe11/repos","events_url":"https://api.github.com/users/Maxwe11/events{/privacy}","received_events_url":"https://api.github.com/users/Maxwe11/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Maxwe11/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/Maxwe11/corefx","forks_url":"https://api.github.com/repos/Maxwe11/corefx/forks","keys_url":"https://api.github.com/repos/Maxwe11/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Maxwe11/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Maxwe11/corefx/teams","hooks_url":"https://api.github.com/repos/Maxwe11/corefx/hooks","issue_events_url":"https://api.github.com/repos/Maxwe11/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/Maxwe11/corefx/events","assignees_url":"https://api.github.com/repos/Maxwe11/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/Maxwe11/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/Maxwe11/corefx/tags","blobs_url":"https://api.github.com/repos/Maxwe11/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Maxwe11/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Maxwe11/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Maxwe11/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Maxwe11/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/Maxwe11/corefx/languages","stargazers_url":"https://api.github.com/repos/Maxwe11/corefx/stargazers","contributors_url":"https://api.github.com/repos/Maxwe11/corefx/contributors","subscribers_url":"https://api.github.com/repos/Maxwe11/corefx/subscribers","subscription_url":"https://api.github.com/repos/Maxwe11/corefx/subscription","commits_url":"https://api.github.com/repos/Maxwe11/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Maxwe11/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Maxwe11/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Maxwe11/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Maxwe11/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/Maxwe11/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Maxwe11/corefx/merges","archive_url":"https://api.github.com/repos/Maxwe11/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Maxwe11/corefx/downloads","issues_url":"https://api.github.com/repos/Maxwe11/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/Maxwe11/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/Maxwe11/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/Maxwe11/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Maxwe11/corefx/labels{/name}","releases_url":"https://api.github.com/repos/Maxwe11/corefx/releases{/id}","created_at":"2015-01-16T22:56:30Z","updated_at":"2015-05-08T11:08:07Z","pushed_at":"2015-06-25T10:37:29Z","git_url":"git://github.com/Maxwe11/corefx.git","ssh_url":"git@github.com:Maxwe11/corefx.git","clone_url":"https://github.com/Maxwe11/corefx.git","svn_url":"https://github.com/Maxwe11/corefx","homepage":"","size":22660,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"39cbff972a11a01026b9d8b481d36742707bd691","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-06-25T18:37:28Z","pushed_at":"2015-06-25T18:24:04Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":49116,"stargazers_count":7961,"watchers_count":7961,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1632,"mirror_url":null,"open_issues_count":439,"forks":1632,"open_issues":439,"watchers":7961,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2153"},"html":{"href":"https://github.com/dotnet/corefx/pull/2153"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2153"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2153/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2153/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2153/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/5f8fb16d8a1ac9851c72ec2beedebe9256a6245f"}}}}