{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/41676230","id":41676230,"diff_hunk":"@@ -0,0 +1,51 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.spark.crypto\n+\n+import org.apache.hadoop.io.Text\n+\n+/**\n+ * Constant variables\n+ */\n+object CommonConfigurationKeys {\n+  val SPARK_SHUFFLE_TOKEN = new Text(\"SPARK_SHUFFLE_TOKEN\")\n+  val SPARK_SECURITY_CRYPTO_BUFFER_SIZE_DEFAULT = 8192\n+  val SPARK_SECURITY_CRYPTO_CIPHER_SUITE_DEFAULT = \"AES/CTR/NoPadding\"\n+  val SPARK_SECURITY_CRYPTO_CIPHER_SUITE_KEY = \"spark.security.crypto.cipher.suite\"\n+  val SPARK_SECURITY_CRYPTO_CODEC_CLASSES_KEY_PREFIX = \"spark.security.crypto.codec.classes\"\n+  val SPARK_SECURITY_CRYPTO_CODEC_CLASSES_AES_CTR_NOPADDING_KEY =\n+    SPARK_SECURITY_CRYPTO_CODEC_CLASSES_KEY_PREFIX + AES_CTR_NOPADDING.getConfigSuffix()\n+  val SPARK_SECURITY_JAVA_SECURE_RANDOM_ALGORITHM_KEY =\n+    \"spark.security.java.secure.random.algorithm\"\n+  val SPARK_SECURITY_JAVA_SECURE_RANDOM_ALGORITHM_DEFAULT = \"SHA1PRNG\"\n+  val SPARK_SECURITY_SECURE_RANDOM_IMPL_KEY = \"spark.security.secure.random.impl\"\n+  val SPARK_ENCRYPTED_INTERMEDIATE_DATA_BUFFER_KB = \"spark.job\" +\n+    \".encrypted-intermediate-data.buffer.kb\"\n+  val DEFAULT_SPARK_ENCRYPTED_INTERMEDIATE_DATA_BUFFER_KB = 128\n+  val SPARK_SECURITY_SECURE_RANDOM_DEVICE_FILE_PATH_KEY = \"spark.security.random.device.file.path\"\n+  val SPARK_SECURITY_SECURE_RANDOM_DEVICE_FILE_PATH_DEFAULT = \"/dev/urandom\"\n+  val SPARK_ENCRYPTED_INTERMEDIATE_DATA = \"spark.job.encrypted-intermediate-data\"","path":"core/src/main/scala/org/apache/spark/crypto/CommonConfigurationKeys.scala","position":41,"original_position":41,"commit_id":"acb5c89efb0e987acf476020db850ba9add14a75","original_commit_id":"acb5c89efb0e987acf476020db850ba9add14a75","user":{"login":"vanzin","id":1694083,"avatar_url":"https://avatars.githubusercontent.com/u/1694083?v=3","gravatar_id":"","url":"https://api.github.com/users/vanzin","html_url":"https://github.com/vanzin","followers_url":"https://api.github.com/users/vanzin/followers","following_url":"https://api.github.com/users/vanzin/following{/other_user}","gists_url":"https://api.github.com/users/vanzin/gists{/gist_id}","starred_url":"https://api.github.com/users/vanzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanzin/subscriptions","organizations_url":"https://api.github.com/users/vanzin/orgs","repos_url":"https://api.github.com/users/vanzin/repos","events_url":"https://api.github.com/users/vanzin/events{/privacy}","received_events_url":"https://api.github.com/users/vanzin/received_events","type":"User","site_admin":false},"body":"Also, regarding the `SPARK_ENCRYPTED_INTERMEDIATE_DATA` config itself, what is it supposed to do? The only place where it's used is for defining the key length used for encryption. If it's not needed right now, I'd suggest removing it.","created_at":"2015-10-09T20:47:02Z","updated_at":"2015-10-09T20:47:02Z","html_url":"https://github.com/apache/spark/pull/8880#discussion_r41676230","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/8880","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/41676230"},"html":{"href":"https://github.com/apache/spark/pull/8880#discussion_r41676230"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/8880"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/8880","id":45748848,"html_url":"https://github.com/apache/spark/pull/8880","diff_url":"https://github.com/apache/spark/pull/8880.diff","patch_url":"https://github.com/apache/spark/pull/8880.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/8880","number":8880,"state":"open","locked":false,"title":"SPARK-10771: Implement the shuffle encryption with AES-CTR crypto using JCE key provider.","user":{"login":"winningsix","id":2278268,"avatar_url":"https://avatars.githubusercontent.com/u/2278268?v=3","gravatar_id":"","url":"https://api.github.com/users/winningsix","html_url":"https://github.com/winningsix","followers_url":"https://api.github.com/users/winningsix/followers","following_url":"https://api.github.com/users/winningsix/following{/other_user}","gists_url":"https://api.github.com/users/winningsix/gists{/gist_id}","starred_url":"https://api.github.com/users/winningsix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winningsix/subscriptions","organizations_url":"https://api.github.com/users/winningsix/orgs","repos_url":"https://api.github.com/users/winningsix/repos","events_url":"https://api.github.com/users/winningsix/events{/privacy}","received_events_url":"https://api.github.com/users/winningsix/received_events","type":"User","site_admin":false},"body":"This patch is using JCE key provider and it's a subtask of SPARK-5682. We will add openssl to accelerate the performance.","created_at":"2015-09-23T07:05:21Z","updated_at":"2015-10-09T20:47:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59852bb678b0b363fd4f110f382a33733f1a27dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/8880/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/8880/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/8880/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/acb5c89efb0e987acf476020db850ba9add14a75","head":{"label":"winningsix:SPARK-10771","ref":"SPARK-10771","sha":"acb5c89efb0e987acf476020db850ba9add14a75","user":{"login":"winningsix","id":2278268,"avatar_url":"https://avatars.githubusercontent.com/u/2278268?v=3","gravatar_id":"","url":"https://api.github.com/users/winningsix","html_url":"https://github.com/winningsix","followers_url":"https://api.github.com/users/winningsix/followers","following_url":"https://api.github.com/users/winningsix/following{/other_user}","gists_url":"https://api.github.com/users/winningsix/gists{/gist_id}","starred_url":"https://api.github.com/users/winningsix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winningsix/subscriptions","organizations_url":"https://api.github.com/users/winningsix/orgs","repos_url":"https://api.github.com/users/winningsix/repos","events_url":"https://api.github.com/users/winningsix/events{/privacy}","received_events_url":"https://api.github.com/users/winningsix/received_events","type":"User","site_admin":false},"repo":{"id":39115505,"name":"spark","full_name":"winningsix/spark","owner":{"login":"winningsix","id":2278268,"avatar_url":"https://avatars.githubusercontent.com/u/2278268?v=3","gravatar_id":"","url":"https://api.github.com/users/winningsix","html_url":"https://github.com/winningsix","followers_url":"https://api.github.com/users/winningsix/followers","following_url":"https://api.github.com/users/winningsix/following{/other_user}","gists_url":"https://api.github.com/users/winningsix/gists{/gist_id}","starred_url":"https://api.github.com/users/winningsix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winningsix/subscriptions","organizations_url":"https://api.github.com/users/winningsix/orgs","repos_url":"https://api.github.com/users/winningsix/repos","events_url":"https://api.github.com/users/winningsix/events{/privacy}","received_events_url":"https://api.github.com/users/winningsix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/winningsix/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/winningsix/spark","forks_url":"https://api.github.com/repos/winningsix/spark/forks","keys_url":"https://api.github.com/repos/winningsix/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/winningsix/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/winningsix/spark/teams","hooks_url":"https://api.github.com/repos/winningsix/spark/hooks","issue_events_url":"https://api.github.com/repos/winningsix/spark/issues/events{/number}","events_url":"https://api.github.com/repos/winningsix/spark/events","assignees_url":"https://api.github.com/repos/winningsix/spark/assignees{/user}","branches_url":"https://api.github.com/repos/winningsix/spark/branches{/branch}","tags_url":"https://api.github.com/repos/winningsix/spark/tags","blobs_url":"https://api.github.com/repos/winningsix/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/winningsix/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/winningsix/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/winningsix/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/winningsix/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/winningsix/spark/languages","stargazers_url":"https://api.github.com/repos/winningsix/spark/stargazers","contributors_url":"https://api.github.com/repos/winningsix/spark/contributors","subscribers_url":"https://api.github.com/repos/winningsix/spark/subscribers","subscription_url":"https://api.github.com/repos/winningsix/spark/subscription","commits_url":"https://api.github.com/repos/winningsix/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/winningsix/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/winningsix/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/winningsix/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/winningsix/spark/contents/{+path}","compare_url":"https://api.github.com/repos/winningsix/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/winningsix/spark/merges","archive_url":"https://api.github.com/repos/winningsix/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/winningsix/spark/downloads","issues_url":"https://api.github.com/repos/winningsix/spark/issues{/number}","pulls_url":"https://api.github.com/repos/winningsix/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/winningsix/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/winningsix/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/winningsix/spark/labels{/name}","releases_url":"https://api.github.com/repos/winningsix/spark/releases{/id}","created_at":"2015-07-15T04:04:04Z","updated_at":"2015-07-15T04:04:26Z","pushed_at":"2015-10-08T02:04:16Z","git_url":"git://github.com/winningsix/spark.git","ssh_url":"git@github.com:winningsix/spark.git","clone_url":"https://github.com/winningsix/spark.git","svn_url":"https://github.com/winningsix/spark","homepage":null,"size":125216,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3aff0866a8601b4daf760d6bf175f68d5a0c8912","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-10-09T20:40:28Z","pushed_at":"2015-10-09T20:37:07Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1630667,"stargazers_count":5711,"watchers_count":5711,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5300,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":343,"forks":5300,"open_issues":343,"watchers":5711,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/8880"},"html":{"href":"https://github.com/apache/spark/pull/8880"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/8880"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/8880/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/8880/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/8880/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/acb5c89efb0e987acf476020db850ba9add14a75"}}}}