{"action":"created","issue":{"url":"https://api.github.com/repos/kytrinyx/approvals/issues/65","labels_url":"https://api.github.com/repos/kytrinyx/approvals/issues/65/labels{/name}","comments_url":"https://api.github.com/repos/kytrinyx/approvals/issues/65/comments","events_url":"https://api.github.com/repos/kytrinyx/approvals/issues/65/events","html_url":"https://github.com/kytrinyx/approvals/pull/65","id":79544302,"number":65,"title":"Run without warnings","user":{"login":"randycoulman","id":1406203,"avatar_url":"https://avatars.githubusercontent.com/u/1406203?v=3","gravatar_id":"","url":"https://api.github.com/users/randycoulman","html_url":"https://github.com/randycoulman","followers_url":"https://api.github.com/users/randycoulman/followers","following_url":"https://api.github.com/users/randycoulman/following{/other_user}","gists_url":"https://api.github.com/users/randycoulman/gists{/gist_id}","starred_url":"https://api.github.com/users/randycoulman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randycoulman/subscriptions","organizations_url":"https://api.github.com/users/randycoulman/orgs","repos_url":"https://api.github.com/users/randycoulman/repos","events_url":"https://api.github.com/users/randycoulman/events{/privacy}","received_events_url":"https://api.github.com/users/randycoulman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-05-22T17:43:20Z","updated_at":"2015-05-25T16:07:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kytrinyx/approvals/pulls/65","html_url":"https://github.com/kytrinyx/approvals/pull/65","diff_url":"https://github.com/kytrinyx/approvals/pull/65.diff","patch_url":"https://github.com/kytrinyx/approvals/pull/65.patch"},"body":"When using approvals in a project, running with Ruby 2.2, a number of warnings were being shown.  The various commits in this PR fix all of the warnings.\r\n\r\nThere are a couple of commits where I'm concerned about breaking existing functionality, so please review those carefully, notably the commit that fixes the redefinition of the `write` method in `BinaryWriter`.  All of the tests are still passing, though.\r\n\r\nI really hate having to explicitly initialize an instance variable to nil when it's using the lazy-initialization pattern, but without it, there is a really annoying warning message printed for each individual spec that uses approvals.\r\n\r\nSee the individual commit comments for more details on each change.\r\n\r\nWith this version, approvals runs with no warnings in my test rspec project."},"comment":{"url":"https://api.github.com/repos/kytrinyx/approvals/issues/comments/105257507","html_url":"https://github.com/kytrinyx/approvals/pull/65#issuecomment-105257507","issue_url":"https://api.github.com/repos/kytrinyx/approvals/issues/65","id":105257507,"user":{"login":"kytrinyx","id":276834,"avatar_url":"https://avatars.githubusercontent.com/u/276834?v=3","gravatar_id":"","url":"https://api.github.com/users/kytrinyx","html_url":"https://github.com/kytrinyx","followers_url":"https://api.github.com/users/kytrinyx/followers","following_url":"https://api.github.com/users/kytrinyx/following{/other_user}","gists_url":"https://api.github.com/users/kytrinyx/gists{/gist_id}","starred_url":"https://api.github.com/users/kytrinyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kytrinyx/subscriptions","organizations_url":"https://api.github.com/users/kytrinyx/orgs","repos_url":"https://api.github.com/users/kytrinyx/repos","events_url":"https://api.github.com/users/kytrinyx/events{/privacy}","received_events_url":"https://api.github.com/users/kytrinyx/received_events","type":"User","site_admin":false},"created_at":"2015-05-25T16:07:25Z","updated_at":"2015-05-25T16:07:25Z","body":"> It does reveal that the namers use inheritance where (I suspect) composition would be better\r\n\r\nYah, back when I wrote this I was experimenting with all sorts of things (singleton, anyone?) and would certainly not solve it the same way again.\r\n\r\nI am fine with removing the binary writer if nobody adopts it."}}