{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/jquery/pulls/comments/44416827","id":44416827,"diff_hunk":"@@ -462,14 +462,14 @@ jQuery.extend( {\n \n \t\t\t\t// Raw string\n \t\t\t\tgetAllResponseHeaders: function() {\n-\t\t\t\t\treturn state === 2 ? responseHeadersString : null;\n+\t\t\t\t\treturn completed ? responseHeadersString : null;\n \t\t\t\t},\n \n \t\t\t\t// Caches the header\n \t\t\t\tsetRequestHeader: function( name, value ) {\n-\t\t\t\t\tvar lname = name.toLowerCase();\n-\t\t\t\t\tif ( !state ) {\n-\t\t\t\t\t\tname = requestHeadersNames[ lname ] = requestHeadersNames[ lname ] || name;\n+\t\t\t\t\tif ( completed == null ) {","path":"src/ajax.js","position":42,"original_position":42,"commit_id":"6c1ef341de20ab5ff2e46042dc727c63ef9529d1","original_commit_id":"6c1ef341de20ab5ff2e46042dc727c63ef9529d1","user":{"login":"dmethvin","id":157858,"avatar_url":"https://avatars.githubusercontent.com/u/157858?v=3","gravatar_id":"","url":"https://api.github.com/users/dmethvin","html_url":"https://github.com/dmethvin","followers_url":"https://api.github.com/users/dmethvin/followers","following_url":"https://api.github.com/users/dmethvin/following{/other_user}","gists_url":"https://api.github.com/users/dmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmethvin/subscriptions","organizations_url":"https://api.github.com/users/dmethvin/orgs","repos_url":"https://api.github.com/users/dmethvin/repos","events_url":"https://api.github.com/users/dmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/dmethvin/received_events","type":"User","site_admin":false},"body":"I'm okay with that as long as we document it somewhere. The first thing I did when I saw this was look for a place where it might be assigned `null` thinking the check for both was important. The style guide example [implies](http://contribute.jquery.org/style-guide/js/#equality) we do it to check for both.","created_at":"2015-11-10T15:10:07Z","updated_at":"2015-11-10T15:10:07Z","html_url":"https://github.com/jquery/jquery/pull/2699#discussion_r44416827","pull_request_url":"https://api.github.com/repos/jquery/jquery/pulls/2699","_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments/44416827"},"html":{"href":"https://github.com/jquery/jquery/pull/2699#discussion_r44416827"},"pull_request":{"href":"https://api.github.com/repos/jquery/jquery/pulls/2699"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/jquery/pulls/2699","id":50080058,"html_url":"https://github.com/jquery/jquery/pull/2699","diff_url":"https://github.com/jquery/jquery/pull/2699.diff","patch_url":"https://github.com/jquery/jquery/pull/2699.patch","issue_url":"https://api.github.com/repos/jquery/jquery/issues/2699","number":2699,"state":"open","locked":false,"title":"Ajax: Golf away 21 bytes","user":{"login":"gibson042","id":1199584,"avatar_url":"https://avatars.githubusercontent.com/u/1199584?v=3","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-09T02:53:49Z","updated_at":"2015-11-10T15:10:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b477daef47cfa8f24c9f0ec9f3af7ed81e82728","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jquery/jquery/pulls/2699/commits","review_comments_url":"https://api.github.com/repos/jquery/jquery/pulls/2699/comments","review_comment_url":"https://api.github.com/repos/jquery/jquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/jquery/issues/2699/comments","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/6c1ef341de20ab5ff2e46042dc727c63ef9529d1","head":{"label":"gibson042:2015-11-compress-ajax","ref":"2015-11-compress-ajax","sha":"6c1ef341de20ab5ff2e46042dc727c63ef9529d1","user":{"login":"gibson042","id":1199584,"avatar_url":"https://avatars.githubusercontent.com/u/1199584?v=3","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"repo":{"id":2789504,"name":"jquery","full_name":"gibson042/jquery","owner":{"login":"gibson042","id":1199584,"avatar_url":"https://avatars.githubusercontent.com/u/1199584?v=3","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gibson042/jquery","description":"jQuery JavaScript Library","fork":true,"url":"https://api.github.com/repos/gibson042/jquery","forks_url":"https://api.github.com/repos/gibson042/jquery/forks","keys_url":"https://api.github.com/repos/gibson042/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gibson042/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gibson042/jquery/teams","hooks_url":"https://api.github.com/repos/gibson042/jquery/hooks","issue_events_url":"https://api.github.com/repos/gibson042/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/gibson042/jquery/events","assignees_url":"https://api.github.com/repos/gibson042/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/gibson042/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/gibson042/jquery/tags","blobs_url":"https://api.github.com/repos/gibson042/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gibson042/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gibson042/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/gibson042/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gibson042/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/gibson042/jquery/languages","stargazers_url":"https://api.github.com/repos/gibson042/jquery/stargazers","contributors_url":"https://api.github.com/repos/gibson042/jquery/contributors","subscribers_url":"https://api.github.com/repos/gibson042/jquery/subscribers","subscription_url":"https://api.github.com/repos/gibson042/jquery/subscription","commits_url":"https://api.github.com/repos/gibson042/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/gibson042/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/gibson042/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/gibson042/jquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/gibson042/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/gibson042/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gibson042/jquery/merges","archive_url":"https://api.github.com/repos/gibson042/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gibson042/jquery/downloads","issues_url":"https://api.github.com/repos/gibson042/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/gibson042/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/gibson042/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/gibson042/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gibson042/jquery/labels{/name}","releases_url":"https://api.github.com/repos/gibson042/jquery/releases{/id}","created_at":"2011-11-16T17:17:24Z","updated_at":"2015-04-30T19:54:05Z","pushed_at":"2015-11-09T19:11:54Z","git_url":"git://github.com/gibson042/jquery.git","ssh_url":"git@github.com:gibson042/jquery.git","clone_url":"https://github.com/gibson042/jquery.git","svn_url":"https://github.com/gibson042/jquery","homepage":"http://jquery.com/","size":22065,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"67fa2eab6ef323b1d894e9e7f054c6e8c844d304","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":167174,"name":"jquery","full_name":"jquery/jquery","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/jquery","description":"jQuery JavaScript Library","fork":false,"url":"https://api.github.com/repos/jquery/jquery","forks_url":"https://api.github.com/repos/jquery/jquery/forks","keys_url":"https://api.github.com/repos/jquery/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/jquery/teams","hooks_url":"https://api.github.com/repos/jquery/jquery/hooks","issue_events_url":"https://api.github.com/repos/jquery/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/jquery/events","assignees_url":"https://api.github.com/repos/jquery/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/jquery/tags","blobs_url":"https://api.github.com/repos/jquery/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/jquery/languages","stargazers_url":"https://api.github.com/repos/jquery/jquery/stargazers","contributors_url":"https://api.github.com/repos/jquery/jquery/contributors","subscribers_url":"https://api.github.com/repos/jquery/jquery/subscribers","subscription_url":"https://api.github.com/repos/jquery/jquery/subscription","commits_url":"https://api.github.com/repos/jquery/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/jquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/jquery/merges","archive_url":"https://api.github.com/repos/jquery/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/jquery/downloads","issues_url":"https://api.github.com/repos/jquery/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/jquery/labels{/name}","releases_url":"https://api.github.com/repos/jquery/jquery/releases{/id}","created_at":"2009-04-03T15:20:14Z","updated_at":"2015-11-10T14:20:01Z","pushed_at":"2015-11-10T15:04:11Z","git_url":"git://github.com/jquery/jquery.git","ssh_url":"git@github.com:jquery/jquery.git","clone_url":"https://github.com/jquery/jquery.git","svn_url":"https://github.com/jquery/jquery","homepage":"http://jquery.com/","size":61315,"stargazers_count":36642,"watchers_count":36642,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":9396,"mirror_url":null,"open_issues_count":75,"forks":9396,"open_issues":75,"watchers":36642,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/2699"},"html":{"href":"https://github.com/jquery/jquery/pull/2699"},"issue":{"href":"https://api.github.com/repos/jquery/jquery/issues/2699"},"comments":{"href":"https://api.github.com/repos/jquery/jquery/issues/2699/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/jquery/pulls/2699/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/jquery/pulls/2699/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/jquery/statuses/6c1ef341de20ab5ff2e46042dc727c63ef9529d1"}}}}