{"action":"created","issue":{"url":"https://api.github.com/repos/ratal/mdfreader/issues/11","labels_url":"https://api.github.com/repos/ratal/mdfreader/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/ratal/mdfreader/issues/11/comments","events_url":"https://api.github.com/repos/ratal/mdfreader/issues/11/events","html_url":"https://github.com/ratal/mdfreader/pull/11","id":99649417,"number":11,"title":"Added a try/catch if the channel does not have a physical unit","user":{"login":"jedediahfrey","id":223258,"avatar_url":"https://avatars.githubusercontent.com/u/223258?v=3","gravatar_id":"","url":"https://api.github.com/users/jedediahfrey","html_url":"https://github.com/jedediahfrey","followers_url":"https://api.github.com/users/jedediahfrey/followers","following_url":"https://api.github.com/users/jedediahfrey/following{/other_user}","gists_url":"https://api.github.com/users/jedediahfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/jedediahfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedediahfrey/subscriptions","organizations_url":"https://api.github.com/users/jedediahfrey/orgs","repos_url":"https://api.github.com/users/jedediahfrey/repos","events_url":"https://api.github.com/users/jedediahfrey/events{/privacy}","received_events_url":"https://api.github.com/users/jedediahfrey/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-07T13:42:23Z","updated_at":"2015-08-13T23:29:05Z","closed_at":"2015-08-13T23:29:05Z","pull_request":{"url":"https://api.github.com/repos/ratal/mdfreader/pulls/11","html_url":"https://github.com/ratal/mdfreader/pull/11","diff_url":"https://github.com/ratal/mdfreader/pull/11.diff","patch_url":"https://github.com/ratal/mdfreader/pull/11.patch"},"body":"mdfreader was failing on our MDF files. Not all of the channels we record have physical units assigned.\r\n\r\nThere is probably a better way to test for this than a ```try/except```. I also only changed md3reader since my files are all MDF3."},"comment":{"url":"https://api.github.com/repos/ratal/mdfreader/issues/comments/130880854","html_url":"https://github.com/ratal/mdfreader/pull/11#issuecomment-130880854","issue_url":"https://api.github.com/repos/ratal/mdfreader/issues/11","id":130880854,"user":{"login":"ratal","id":5404948,"avatar_url":"https://avatars.githubusercontent.com/u/5404948?v=3","gravatar_id":"","url":"https://api.github.com/users/ratal","html_url":"https://github.com/ratal","followers_url":"https://api.github.com/users/ratal/followers","following_url":"https://api.github.com/users/ratal/following{/other_user}","gists_url":"https://api.github.com/users/ratal/gists{/gist_id}","starred_url":"https://api.github.com/users/ratal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ratal/subscriptions","organizations_url":"https://api.github.com/users/ratal/orgs","repos_url":"https://api.github.com/users/ratal/repos","events_url":"https://api.github.com/users/ratal/events{/privacy}","received_events_url":"https://api.github.com/users/ratal/received_events","type":"User","site_admin":false},"created_at":"2015-08-13T23:29:05Z","updated_at":"2015-08-13T23:29:05Z","body":"Thanks for this proposal. I actually also recently faced this problem with data logger data. I push your modification with the latest commit but not with try/except, instead with just a check if physicalUnit is in the channel dict. Also getChannelUnit in mdfreader are modified accordingly because many other export/manipulation methods are expecting units -> replace with empty string, not None."}}