{"action":"created","comment":{"url":"https://api.github.com/repos/laravel/framework/pulls/comments/32224510","id":32224510,"diff_hunk":"@@ -440,6 +439,25 @@ protected static function formatGroupPrefix($new, $old)\n \n         return $oldPrefix;\n     }\n+    \n+    /**\n+     * Format the as prefix for the new group attributes.\n+     *\n+     * @param  array  $new\n+     * @param  array  $old\n+     * @return string|null\n+     */\n+    protected static function formatAsPrefix($new, $old)\n+    {\n+        if (isset($new['as']) && isset($old['as'])) {\n+            return $old['as'].$new['as'];\n+        }\n+        if (isset($new['as'])) {","path":"src/Illuminate/Routing/Router.php","position":54,"original_position":54,"commit_id":"048944e12a673220bb127b4110fe2f121d8594d4","original_commit_id":"048944e12a673220bb127b4110fe2f121d8594d4","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"body":"Actually, you shouldn't be doing the isset new check twice.","created_at":"2015-06-11T14:15:31Z","updated_at":"2015-06-11T14:15:31Z","html_url":"https://github.com/laravel/framework/pull/9198#discussion_r32224510","pull_request_url":"https://api.github.com/repos/laravel/framework/pulls/9198","_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/32224510"},"html":{"href":"https://github.com/laravel/framework/pull/9198#discussion_r32224510"},"pull_request":{"href":"https://api.github.com/repos/laravel/framework/pulls/9198"}}},"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/9198","id":37415101,"html_url":"https://github.com/laravel/framework/pull/9198","diff_url":"https://github.com/laravel/framework/pull/9198.diff","patch_url":"https://github.com/laravel/framework/pull/9198.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/9198","number":9198,"state":"open","locked":false,"title":"[5.1] Nested Route Groups with as missing \"in the middle\"","user":{"login":"ebynum","id":33896,"avatar_url":"https://avatars.githubusercontent.com/u/33896?v=3","gravatar_id":"","url":"https://api.github.com/users/ebynum","html_url":"https://github.com/ebynum","followers_url":"https://api.github.com/users/ebynum/followers","following_url":"https://api.github.com/users/ebynum/following{/other_user}","gists_url":"https://api.github.com/users/ebynum/gists{/gist_id}","starred_url":"https://api.github.com/users/ebynum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebynum/subscriptions","organizations_url":"https://api.github.com/users/ebynum/orgs","repos_url":"https://api.github.com/users/ebynum/repos","events_url":"https://api.github.com/users/ebynum/events{/privacy}","received_events_url":"https://api.github.com/users/ebynum/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-10T23:19:28Z","updated_at":"2015-06-11T14:15:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87cf57fd1e8562a20982a42a61ac730b5621d062","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/9198/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/9198/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/9198/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/048944e12a673220bb127b4110fe2f121d8594d4","head":{"label":"ebynum:5.1","ref":"5.1","sha":"048944e12a673220bb127b4110fe2f121d8594d4","user":{"login":"ebynum","id":33896,"avatar_url":"https://avatars.githubusercontent.com/u/33896?v=3","gravatar_id":"","url":"https://api.github.com/users/ebynum","html_url":"https://github.com/ebynum","followers_url":"https://api.github.com/users/ebynum/followers","following_url":"https://api.github.com/users/ebynum/following{/other_user}","gists_url":"https://api.github.com/users/ebynum/gists{/gist_id}","starred_url":"https://api.github.com/users/ebynum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebynum/subscriptions","organizations_url":"https://api.github.com/users/ebynum/orgs","repos_url":"https://api.github.com/users/ebynum/repos","events_url":"https://api.github.com/users/ebynum/events{/privacy}","received_events_url":"https://api.github.com/users/ebynum/received_events","type":"User","site_admin":false},"repo":{"id":37225179,"name":"framework","full_name":"ebynum/framework","owner":{"login":"ebynum","id":33896,"avatar_url":"https://avatars.githubusercontent.com/u/33896?v=3","gravatar_id":"","url":"https://api.github.com/users/ebynum","html_url":"https://github.com/ebynum","followers_url":"https://api.github.com/users/ebynum/followers","following_url":"https://api.github.com/users/ebynum/following{/other_user}","gists_url":"https://api.github.com/users/ebynum/gists{/gist_id}","starred_url":"https://api.github.com/users/ebynum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebynum/subscriptions","organizations_url":"https://api.github.com/users/ebynum/orgs","repos_url":"https://api.github.com/users/ebynum/repos","events_url":"https://api.github.com/users/ebynum/events{/privacy}","received_events_url":"https://api.github.com/users/ebynum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ebynum/framework","description":"","fork":true,"url":"https://api.github.com/repos/ebynum/framework","forks_url":"https://api.github.com/repos/ebynum/framework/forks","keys_url":"https://api.github.com/repos/ebynum/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebynum/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebynum/framework/teams","hooks_url":"https://api.github.com/repos/ebynum/framework/hooks","issue_events_url":"https://api.github.com/repos/ebynum/framework/issues/events{/number}","events_url":"https://api.github.com/repos/ebynum/framework/events","assignees_url":"https://api.github.com/repos/ebynum/framework/assignees{/user}","branches_url":"https://api.github.com/repos/ebynum/framework/branches{/branch}","tags_url":"https://api.github.com/repos/ebynum/framework/tags","blobs_url":"https://api.github.com/repos/ebynum/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebynum/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebynum/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebynum/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebynum/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/ebynum/framework/languages","stargazers_url":"https://api.github.com/repos/ebynum/framework/stargazers","contributors_url":"https://api.github.com/repos/ebynum/framework/contributors","subscribers_url":"https://api.github.com/repos/ebynum/framework/subscribers","subscription_url":"https://api.github.com/repos/ebynum/framework/subscription","commits_url":"https://api.github.com/repos/ebynum/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebynum/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebynum/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebynum/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebynum/framework/contents/{+path}","compare_url":"https://api.github.com/repos/ebynum/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebynum/framework/merges","archive_url":"https://api.github.com/repos/ebynum/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebynum/framework/downloads","issues_url":"https://api.github.com/repos/ebynum/framework/issues{/number}","pulls_url":"https://api.github.com/repos/ebynum/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/ebynum/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/ebynum/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebynum/framework/labels{/name}","releases_url":"https://api.github.com/repos/ebynum/framework/releases{/id}","created_at":"2015-06-10T22:06:11Z","updated_at":"2015-06-10T22:06:16Z","pushed_at":"2015-06-11T14:10:52Z","git_url":"git://github.com/ebynum/framework.git","ssh_url":"git@github.com:ebynum/framework.git","clone_url":"https://github.com/ebynum/framework.git","svn_url":"https://github.com/ebynum/framework","homepage":"http://laravel.com","size":17259,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.1"}},"base":{"label":"laravel:5.1","ref":"5.1","sha":"9595134cab1680ecaa645c419ebba6c5de4f8c38","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-06-11T13:46:42Z","pushed_at":"2015-06-11T14:10:56Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":62842,"stargazers_count":3712,"watchers_count":3712,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2054,"mirror_url":null,"open_issues_count":64,"forks":2054,"open_issues":64,"watchers":3712,"default_branch":"5.1"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/9198"},"html":{"href":"https://github.com/laravel/framework/pull/9198"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/9198"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/9198/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/9198/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/9198/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/048944e12a673220bb127b4110fe2f121d8594d4"}}}}