{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/ushahidi/platform-client/pulls/9","id":44173628,"html_url":"https://github.com/ushahidi/platform-client/pull/9","diff_url":"https://github.com/ushahidi/platform-client/pull/9.diff","patch_url":"https://github.com/ushahidi/platform-client/pull/9.patch","issue_url":"https://api.github.com/repos/ushahidi/platform-client/issues/9","number":9,"state":"closed","locked":false,"title":"Add first time login config screens","user":{"login":"rjmackay","id":7965,"avatar_url":"https://avatars.githubusercontent.com/u/7965?v=3","gravatar_id":"","url":"https://api.github.com/users/rjmackay","html_url":"https://github.com/rjmackay","followers_url":"https://api.github.com/users/rjmackay/followers","following_url":"https://api.github.com/users/rjmackay/following{/other_user}","gists_url":"https://api.github.com/users/rjmackay/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmackay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmackay/subscriptions","organizations_url":"https://api.github.com/users/rjmackay/orgs","repos_url":"https://api.github.com/users/rjmackay/repos","events_url":"https://api.github.com/users/rjmackay/events{/privacy}","received_events_url":"https://api.github.com/users/rjmackay/received_events","type":"User","site_admin":false},"body":"Also:\r\n- Simplify modal logic: if visible is true, just open the modal.\r\n- Default to close modal on overlay click\r\n- Add option to show/hide modal close button\r\n- Move appearance and general settings all into 1 directive\r\n\r\nTest plan:\r\n- Load the client\r\n- Log in as admin \r\nFirst time config will popup\r\n- Check various combinations of skipping, customizing etc.\r\nTo reset state: remove the 'first_login' flag from config table in db\r\n\r\nTest general settings:\r\n- Load /settings/general and check uploading header image works as expected.\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/ushahidi/platform-client/9)\r\n<!-- Reviewable:end -->\r\n\r\nFixes ushahidi/platform#494\r\nFixes ushahidi/platform#677","created_at":"2015-09-04T00:41:41Z","updated_at":"2015-09-11T00:00:59Z","closed_at":"2015-09-11T00:00:58Z","merged_at":"2015-09-11T00:00:58Z","merge_commit_sha":"8938be062a0f499def104eb89676420fdeb355dc","assignee":{"login":"willdoran","id":2694405,"avatar_url":"https://avatars.githubusercontent.com/u/2694405?v=3","gravatar_id":"","url":"https://api.github.com/users/willdoran","html_url":"https://github.com/willdoran","followers_url":"https://api.github.com/users/willdoran/followers","following_url":"https://api.github.com/users/willdoran/following{/other_user}","gists_url":"https://api.github.com/users/willdoran/gists{/gist_id}","starred_url":"https://api.github.com/users/willdoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willdoran/subscriptions","organizations_url":"https://api.github.com/users/willdoran/orgs","repos_url":"https://api.github.com/users/willdoran/repos","events_url":"https://api.github.com/users/willdoran/events{/privacy}","received_events_url":"https://api.github.com/users/willdoran/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ushahidi/platform-client/pulls/9/commits","review_comments_url":"https://api.github.com/repos/ushahidi/platform-client/pulls/9/comments","review_comment_url":"https://api.github.com/repos/ushahidi/platform-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ushahidi/platform-client/issues/9/comments","statuses_url":"https://api.github.com/repos/ushahidi/platform-client/statuses/1c17caa5ba18cb83606e8dae2a68dd65a26b5f93","head":{"label":"ushahidi:494-first-time-config","ref":"494-first-time-config","sha":"1c17caa5ba18cb83606e8dae2a68dd65a26b5f93","user":{"login":"ushahidi","id":16959,"avatar_url":"https://avatars.githubusercontent.com/u/16959?v=3","gravatar_id":"","url":"https://api.github.com/users/ushahidi","html_url":"https://github.com/ushahidi","followers_url":"https://api.github.com/users/ushahidi/followers","following_url":"https://api.github.com/users/ushahidi/following{/other_user}","gists_url":"https://api.github.com/users/ushahidi/gists{/gist_id}","starred_url":"https://api.github.com/users/ushahidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ushahidi/subscriptions","organizations_url":"https://api.github.com/users/ushahidi/orgs","repos_url":"https://api.github.com/users/ushahidi/repos","events_url":"https://api.github.com/users/ushahidi/events{/privacy}","received_events_url":"https://api.github.com/users/ushahidi/received_events","type":"Organization","site_admin":false},"repo":{"id":22108131,"name":"platform-client","full_name":"ushahidi/platform-client","owner":{"login":"ushahidi","id":16959,"avatar_url":"https://avatars.githubusercontent.com/u/16959?v=3","gravatar_id":"","url":"https://api.github.com/users/ushahidi","html_url":"https://github.com/ushahidi","followers_url":"https://api.github.com/users/ushahidi/followers","following_url":"https://api.github.com/users/ushahidi/following{/other_user}","gists_url":"https://api.github.com/users/ushahidi/gists{/gist_id}","starred_url":"https://api.github.com/users/ushahidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ushahidi/subscriptions","organizations_url":"https://api.github.com/users/ushahidi/orgs","repos_url":"https://api.github.com/users/ushahidi/repos","events_url":"https://api.github.com/users/ushahidi/events{/privacy}","received_events_url":"https://api.github.com/users/ushahidi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ushahidi/platform-client","description":"Ushahidi Platform Client","fork":false,"url":"https://api.github.com/repos/ushahidi/platform-client","forks_url":"https://api.github.com/repos/ushahidi/platform-client/forks","keys_url":"https://api.github.com/repos/ushahidi/platform-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ushahidi/platform-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ushahidi/platform-client/teams","hooks_url":"https://api.github.com/repos/ushahidi/platform-client/hooks","issue_events_url":"https://api.github.com/repos/ushahidi/platform-client/issues/events{/number}","events_url":"https://api.github.com/repos/ushahidi/platform-client/events","assignees_url":"https://api.github.com/repos/ushahidi/platform-client/assignees{/user}","branches_url":"https://api.github.com/repos/ushahidi/platform-client/branches{/branch}","tags_url":"https://api.github.com/repos/ushahidi/platform-client/tags","blobs_url":"https://api.github.com/repos/ushahidi/platform-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ushahidi/platform-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ushahidi/platform-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/ushahidi/platform-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ushahidi/platform-client/statuses/{sha}","languages_url":"https://api.github.com/repos/ushahidi/platform-client/languages","stargazers_url":"https://api.github.com/repos/ushahidi/platform-client/stargazers","contributors_url":"https://api.github.com/repos/ushahidi/platform-client/contributors","subscribers_url":"https://api.github.com/repos/ushahidi/platform-client/subscribers","subscription_url":"https://api.github.com/repos/ushahidi/platform-client/subscription","commits_url":"https://api.github.com/repos/ushahidi/platform-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/ushahidi/platform-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/ushahidi/platform-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/ushahidi/platform-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/ushahidi/platform-client/contents/{+path}","compare_url":"https://api.github.com/repos/ushahidi/platform-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ushahidi/platform-client/merges","archive_url":"https://api.github.com/repos/ushahidi/platform-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ushahidi/platform-client/downloads","issues_url":"https://api.github.com/repos/ushahidi/platform-client/issues{/number}","pulls_url":"https://api.github.com/repos/ushahidi/platform-client/pulls{/number}","milestones_url":"https://api.github.com/repos/ushahidi/platform-client/milestones{/number}","notifications_url":"https://api.github.com/repos/ushahidi/platform-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ushahidi/platform-client/labels{/name}","releases_url":"https://api.github.com/repos/ushahidi/platform-client/releases{/id}","created_at":"2014-07-22T14:53:40Z","updated_at":"2015-09-05T22:49:10Z","pushed_at":"2015-09-11T00:01:00Z","git_url":"git://github.com/ushahidi/platform-client.git","ssh_url":"git@github.com:ushahidi/platform-client.git","clone_url":"https://github.com/ushahidi/platform-client.git","svn_url":"https://github.com/ushahidi/platform-client","homepage":"http://ushahidi.com","size":3888,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":15,"default_branch":"master"}},"base":{"label":"ushahidi:master","ref":"master","sha":"6a07c180a4b9f8fec910d2256927942ace77022e","user":{"login":"ushahidi","id":16959,"avatar_url":"https://avatars.githubusercontent.com/u/16959?v=3","gravatar_id":"","url":"https://api.github.com/users/ushahidi","html_url":"https://github.com/ushahidi","followers_url":"https://api.github.com/users/ushahidi/followers","following_url":"https://api.github.com/users/ushahidi/following{/other_user}","gists_url":"https://api.github.com/users/ushahidi/gists{/gist_id}","starred_url":"https://api.github.com/users/ushahidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ushahidi/subscriptions","organizations_url":"https://api.github.com/users/ushahidi/orgs","repos_url":"https://api.github.com/users/ushahidi/repos","events_url":"https://api.github.com/users/ushahidi/events{/privacy}","received_events_url":"https://api.github.com/users/ushahidi/received_events","type":"Organization","site_admin":false},"repo":{"id":22108131,"name":"platform-client","full_name":"ushahidi/platform-client","owner":{"login":"ushahidi","id":16959,"avatar_url":"https://avatars.githubusercontent.com/u/16959?v=3","gravatar_id":"","url":"https://api.github.com/users/ushahidi","html_url":"https://github.com/ushahidi","followers_url":"https://api.github.com/users/ushahidi/followers","following_url":"https://api.github.com/users/ushahidi/following{/other_user}","gists_url":"https://api.github.com/users/ushahidi/gists{/gist_id}","starred_url":"https://api.github.com/users/ushahidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ushahidi/subscriptions","organizations_url":"https://api.github.com/users/ushahidi/orgs","repos_url":"https://api.github.com/users/ushahidi/repos","events_url":"https://api.github.com/users/ushahidi/events{/privacy}","received_events_url":"https://api.github.com/users/ushahidi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ushahidi/platform-client","description":"Ushahidi Platform Client","fork":false,"url":"https://api.github.com/repos/ushahidi/platform-client","forks_url":"https://api.github.com/repos/ushahidi/platform-client/forks","keys_url":"https://api.github.com/repos/ushahidi/platform-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ushahidi/platform-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ushahidi/platform-client/teams","hooks_url":"https://api.github.com/repos/ushahidi/platform-client/hooks","issue_events_url":"https://api.github.com/repos/ushahidi/platform-client/issues/events{/number}","events_url":"https://api.github.com/repos/ushahidi/platform-client/events","assignees_url":"https://api.github.com/repos/ushahidi/platform-client/assignees{/user}","branches_url":"https://api.github.com/repos/ushahidi/platform-client/branches{/branch}","tags_url":"https://api.github.com/repos/ushahidi/platform-client/tags","blobs_url":"https://api.github.com/repos/ushahidi/platform-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ushahidi/platform-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ushahidi/platform-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/ushahidi/platform-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ushahidi/platform-client/statuses/{sha}","languages_url":"https://api.github.com/repos/ushahidi/platform-client/languages","stargazers_url":"https://api.github.com/repos/ushahidi/platform-client/stargazers","contributors_url":"https://api.github.com/repos/ushahidi/platform-client/contributors","subscribers_url":"https://api.github.com/repos/ushahidi/platform-client/subscribers","subscription_url":"https://api.github.com/repos/ushahidi/platform-client/subscription","commits_url":"https://api.github.com/repos/ushahidi/platform-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/ushahidi/platform-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/ushahidi/platform-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/ushahidi/platform-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/ushahidi/platform-client/contents/{+path}","compare_url":"https://api.github.com/repos/ushahidi/platform-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ushahidi/platform-client/merges","archive_url":"https://api.github.com/repos/ushahidi/platform-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ushahidi/platform-client/downloads","issues_url":"https://api.github.com/repos/ushahidi/platform-client/issues{/number}","pulls_url":"https://api.github.com/repos/ushahidi/platform-client/pulls{/number}","milestones_url":"https://api.github.com/repos/ushahidi/platform-client/milestones{/number}","notifications_url":"https://api.github.com/repos/ushahidi/platform-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ushahidi/platform-client/labels{/name}","releases_url":"https://api.github.com/repos/ushahidi/platform-client/releases{/id}","created_at":"2014-07-22T14:53:40Z","updated_at":"2015-09-05T22:49:10Z","pushed_at":"2015-09-11T00:01:00Z","git_url":"git://github.com/ushahidi/platform-client.git","ssh_url":"git@github.com:ushahidi/platform-client.git","clone_url":"https://github.com/ushahidi/platform-client.git","svn_url":"https://github.com/ushahidi/platform-client","homepage":"http://ushahidi.com","size":3888,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ushahidi/platform-client/pulls/9"},"html":{"href":"https://github.com/ushahidi/platform-client/pull/9"},"issue":{"href":"https://api.github.com/repos/ushahidi/platform-client/issues/9"},"comments":{"href":"https://api.github.com/repos/ushahidi/platform-client/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/ushahidi/platform-client/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/ushahidi/platform-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ushahidi/platform-client/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/ushahidi/platform-client/statuses/1c17caa5ba18cb83606e8dae2a68dd65a26b5f93"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rjmackay","id":7965,"avatar_url":"https://avatars.githubusercontent.com/u/7965?v=3","gravatar_id":"","url":"https://api.github.com/users/rjmackay","html_url":"https://github.com/rjmackay","followers_url":"https://api.github.com/users/rjmackay/followers","following_url":"https://api.github.com/users/rjmackay/following{/other_user}","gists_url":"https://api.github.com/users/rjmackay/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmackay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmackay/subscriptions","organizations_url":"https://api.github.com/users/rjmackay/orgs","repos_url":"https://api.github.com/users/rjmackay/repos","events_url":"https://api.github.com/users/rjmackay/events{/privacy}","received_events_url":"https://api.github.com/users/rjmackay/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":9,"additions":407,"deletions":201,"changed_files":22}}