{"action":"created","comment":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/30794236","id":30794236,"diff_hunk":"@@ -1260,8 +1260,8 @@ var/list/WALLITEMS = list(\n \t\"/obj/machinery/newscaster\", \"/obj/machinery/firealarm\", \"/obj/structure/noticeboard\", \"/obj/machinery/door_control\",\r\n \t\"/obj/machinery/computer/security/telescreen\", \"/obj/machinery/embedded_controller/radio/simple_vent_controller\",\r\n \t\"/obj/item/weapon/storage/secure/safe\", \"/obj/machinery/door_timer\", \"/obj/machinery/flasher\", \"/obj/machinery/keycard_auth\",\r\n-\t\"/obj/structure/mirror\", \"/obj/structure/closet/fireaxecabinet\", \"/obj/machinery/computer/security/telescreen/entertainment\",\r\n-\t\"obj/structure/sign\"\r\n+\t\"/obj/structure/mirror\", \"/obj/structure/closet/fireaxecabinet\", \"/obj/structure/closet/fireaxecabinet/empty\", \r","path":"code/__HELPERS/unsorted.dm","position":6,"original_position":6,"commit_id":"652c82dc2cb46caaef75272b9c087c7d375f45ab","original_commit_id":"652c82dc2cb46caaef75272b9c087c7d375f45ab","user":{"login":"ComicIronic","id":7339857,"avatar_url":"https://avatars.githubusercontent.com/u/7339857?v=3","gravatar_id":"","url":"https://api.github.com/users/ComicIronic","html_url":"https://github.com/ComicIronic","followers_url":"https://api.github.com/users/ComicIronic/followers","following_url":"https://api.github.com/users/ComicIronic/following{/other_user}","gists_url":"https://api.github.com/users/ComicIronic/gists{/gist_id}","starred_url":"https://api.github.com/users/ComicIronic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComicIronic/subscriptions","organizations_url":"https://api.github.com/users/ComicIronic/orgs","repos_url":"https://api.github.com/users/ComicIronic/repos","events_url":"https://api.github.com/users/ComicIronic/events{/privacy}","received_events_url":"https://api.github.com/users/ComicIronic/received_events","type":"User","site_admin":false},"body":"Test taking it out, I'm not seeing any code reason in gotwallitem that would require having both.","created_at":"2015-05-21T11:47:43Z","updated_at":"2015-05-21T11:47:43Z","html_url":"https://github.com/d3athrow/vgstation13/pull/4573#discussion_r30794236","pull_request_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4573","_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/30794236"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/4573#discussion_r30794236"},"pull_request":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4573"}}},"pull_request":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4573","id":35892368,"html_url":"https://github.com/d3athrow/vgstation13/pull/4573","diff_url":"https://github.com/d3athrow/vgstation13/pull/4573.diff","patch_url":"https://github.com/d3athrow/vgstation13/pull/4573.patch","issue_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/4573","number":4573,"state":"open","locked":false,"title":"Fireaxe cabinet construction fixes","user":{"login":"Exxion","id":9827785,"avatar_url":"https://avatars.githubusercontent.com/u/9827785?v=3","gravatar_id":"","url":"https://api.github.com/users/Exxion","html_url":"https://github.com/Exxion","followers_url":"https://api.github.com/users/Exxion/followers","following_url":"https://api.github.com/users/Exxion/following{/other_user}","gists_url":"https://api.github.com/users/Exxion/gists{/gist_id}","starred_url":"https://api.github.com/users/Exxion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exxion/subscriptions","organizations_url":"https://api.github.com/users/Exxion/orgs","repos_url":"https://api.github.com/users/Exxion/repos","events_url":"https://api.github.com/users/Exxion/events{/privacy}","received_events_url":"https://api.github.com/users/Exxion/received_events","type":"User","site_admin":false},"body":"I *love* the mountable frames code\r\n\r\n- Building a fireaxe cabinet with plasteel gives you a fireaxe cabinet frame rather than just builds a cabinet where you're standing.\r\n  - Fireaxe cabinet frame has a sprite intended to be a placeholder, though I guess it could stay. It looks just like an empty fireaxe cabinet that's half open.\r\n  - This can be placed on a wall just like any other frame.\r\n  - Fireaxe cabinets placed with a frame start empty, open, and unlocked.\r\n    - They also, like all mounted frames that appear \"inside\" a wall (except air alarms), correctly prevent other frames from being placed on the same side of the same wall as themselves, which was substantially harder to get working than it should have been for reasons I don't entirely understand.\r\n- Fireaxe cabinets now render just above the turf layer because their sprites are huge and tended to cover up the sprites of other objects mounted on other sides of the same wall.\r\n\r\nIssues I noticed while testing this but did not fix:\r\n- Air alarms (possibly other things, but I only noticed air alarms failing to do this) do not prevent you from placing other frames on the same side of the same wall as themselves. Not totally sure why.\r\n- Fireaxe cabinets are always placed in the center of the wall they are placed on, while everything else is offset somewhat depending on the side. This means that two fireaxe cabinets placed on different sides of the same wall will cover each other up and each will only be accessible from certain angles because BYOND has trouble deciding which should be rendered on top. Fixing this for constructed cabinets would be easy, and I can do it in this PR if asked, but fixing it in general would require map changes, which I don't want to do because of possible conflicts.\r\n- There is, as far as I can tell, no legitimate access requirement for the fireaxe cabinet other than the AI. Assistants and captains alike need to either break it or multitool it.\r\n\r\nFixes #4278","created_at":"2015-05-21T01:26:57Z","updated_at":"2015-05-21T11:47:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86a79027dafee1ebd845fabbc569bba4d7b55bee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4573/commits","review_comments_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4573/comments","review_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/4573/comments","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/652c82dc2cb46caaef75272b9c087c7d375f45ab","head":{"label":"Exxion:fireaxe","ref":"fireaxe","sha":"652c82dc2cb46caaef75272b9c087c7d375f45ab","user":{"login":"Exxion","id":9827785,"avatar_url":"https://avatars.githubusercontent.com/u/9827785?v=3","gravatar_id":"","url":"https://api.github.com/users/Exxion","html_url":"https://github.com/Exxion","followers_url":"https://api.github.com/users/Exxion/followers","following_url":"https://api.github.com/users/Exxion/following{/other_user}","gists_url":"https://api.github.com/users/Exxion/gists{/gist_id}","starred_url":"https://api.github.com/users/Exxion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exxion/subscriptions","organizations_url":"https://api.github.com/users/Exxion/orgs","repos_url":"https://api.github.com/users/Exxion/repos","events_url":"https://api.github.com/users/Exxion/events{/privacy}","received_events_url":"https://api.github.com/users/Exxion/received_events","type":"User","site_admin":false},"repo":{"id":30894557,"name":"vgstation13","full_name":"Exxion/vgstation13","owner":{"login":"Exxion","id":9827785,"avatar_url":"https://avatars.githubusercontent.com/u/9827785?v=3","gravatar_id":"","url":"https://api.github.com/users/Exxion","html_url":"https://github.com/Exxion","followers_url":"https://api.github.com/users/Exxion/followers","following_url":"https://api.github.com/users/Exxion/following{/other_user}","gists_url":"https://api.github.com/users/Exxion/gists{/gist_id}","starred_url":"https://api.github.com/users/Exxion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Exxion/subscriptions","organizations_url":"https://api.github.com/users/Exxion/orgs","repos_url":"https://api.github.com/users/Exxion/repos","events_url":"https://api.github.com/users/Exxion/events{/privacy}","received_events_url":"https://api.github.com/users/Exxion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Exxion/vgstation13","description":"This is the vgstation's fork of baystation12's code.","fork":true,"url":"https://api.github.com/repos/Exxion/vgstation13","forks_url":"https://api.github.com/repos/Exxion/vgstation13/forks","keys_url":"https://api.github.com/repos/Exxion/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Exxion/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Exxion/vgstation13/teams","hooks_url":"https://api.github.com/repos/Exxion/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/Exxion/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/Exxion/vgstation13/events","assignees_url":"https://api.github.com/repos/Exxion/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/Exxion/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/Exxion/vgstation13/tags","blobs_url":"https://api.github.com/repos/Exxion/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Exxion/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Exxion/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/Exxion/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Exxion/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/Exxion/vgstation13/languages","stargazers_url":"https://api.github.com/repos/Exxion/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/Exxion/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/Exxion/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/Exxion/vgstation13/subscription","commits_url":"https://api.github.com/repos/Exxion/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/Exxion/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/Exxion/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/Exxion/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/Exxion/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/Exxion/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Exxion/vgstation13/merges","archive_url":"https://api.github.com/repos/Exxion/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Exxion/vgstation13/downloads","issues_url":"https://api.github.com/repos/Exxion/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/Exxion/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/Exxion/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/Exxion/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Exxion/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/Exxion/vgstation13/releases{/id}","created_at":"2015-02-16T23:51:09Z","updated_at":"2015-05-08T13:46:59Z","pushed_at":"2015-05-21T01:33:07Z","git_url":"git://github.com/Exxion/vgstation13.git","ssh_url":"git@github.com:Exxion/vgstation13.git","clone_url":"https://github.com/Exxion/vgstation13.git","svn_url":"https://github.com/Exxion/vgstation13","homepage":"","size":877594,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"Bleeding-Edge"}},"base":{"label":"d3athrow:Bleeding-Edge","ref":"Bleeding-Edge","sha":"73922e9be1830c714ef4e09204512b32ca41f3f1","user":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"repo":{"id":10441188,"name":"vgstation13","full_name":"d3athrow/vgstation13","owner":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d3athrow/vgstation13","description":"This is the vgstation's fork of baystation12's code.","fork":true,"url":"https://api.github.com/repos/d3athrow/vgstation13","forks_url":"https://api.github.com/repos/d3athrow/vgstation13/forks","keys_url":"https://api.github.com/repos/d3athrow/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3athrow/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3athrow/vgstation13/teams","hooks_url":"https://api.github.com/repos/d3athrow/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/d3athrow/vgstation13/events","assignees_url":"https://api.github.com/repos/d3athrow/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/d3athrow/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/d3athrow/vgstation13/tags","blobs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3athrow/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3athrow/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/d3athrow/vgstation13/languages","stargazers_url":"https://api.github.com/repos/d3athrow/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/d3athrow/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/d3athrow/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/d3athrow/vgstation13/subscription","commits_url":"https://api.github.com/repos/d3athrow/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3athrow/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3athrow/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/d3athrow/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3athrow/vgstation13/merges","archive_url":"https://api.github.com/repos/d3athrow/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3athrow/vgstation13/downloads","issues_url":"https://api.github.com/repos/d3athrow/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/d3athrow/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/d3athrow/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3athrow/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/d3athrow/vgstation13/releases{/id}","created_at":"2013-06-02T19:39:54Z","updated_at":"2015-05-08T09:36:58Z","pushed_at":"2015-05-21T09:53:47Z","git_url":"git://github.com/d3athrow/vgstation13.git","ssh_url":"git@github.com:d3athrow/vgstation13.git","clone_url":"https://github.com/d3athrow/vgstation13.git","svn_url":"https://github.com/d3athrow/vgstation13","homepage":"","size":1086573,"stargazers_count":58,"watchers_count":58,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":525,"forks":168,"open_issues":525,"watchers":58,"default_branch":"Bleeding-Edge"}},"_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4573"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/4573"},"issue":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/4573"},"comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/4573/comments"},"review_comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4573/comments"},"review_comment":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/4573/commits"},"statuses":{"href":"https://api.github.com/repos/d3athrow/vgstation13/statuses/652c82dc2cb46caaef75272b9c087c7d375f45ab"}}}}