{"action":"created","comment":{"url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/comments/28755583","id":28755583,"diff_hunk":"@@ -267,9 +267,23 @@ local function get_gregorioversion()\n   return internalversion\n end\n \n+local function map_fonts()\n+  -- use greciliae because it is the most complete font\n+  local font_info = fontloader.open(kpse.find_file('greciliae', 'truetype fonts'))","path":"tex/gregoriotex.lua","position":6,"original_position":6,"commit_id":"d933626bb78acf40ffa8f75a2157af9686e6c1b5","original_commit_id":"d933626bb78acf40ffa8f75a2157af9686e6c1b5","user":{"login":"eroux","id":60868,"avatar_url":"https://avatars.githubusercontent.com/u/60868?v=3","gravatar_id":"","url":"https://api.github.com/users/eroux","html_url":"https://github.com/eroux","followers_url":"https://api.github.com/users/eroux/followers","following_url":"https://api.github.com/users/eroux/following{/other_user}","gists_url":"https://api.github.com/users/eroux/gists{/gist_id}","starred_url":"https://api.github.com/users/eroux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eroux/subscriptions","organizations_url":"https://api.github.com/users/eroux/orgs","repos_url":"https://api.github.com/users/eroux/repos","events_url":"https://api.github.com/users/eroux/events{/privacy}","received_events_url":"https://api.github.com/users/eroux/received_events","type":"User","site_admin":false},"body":"In addition, it might be better to use\r\n\r\n    fonts.names.font_file_lookup('greciliae.ttf')\r\n\r\n(untested). This is defined [in luaotfload](https://github.com/lualatex/luaotfload/blob/master/src/luaotfload-database.lua).","created_at":"2015-04-21T07:32:32Z","updated_at":"2015-04-21T07:32:32Z","html_url":"https://github.com/gregorio-project/gregorio/pull/292#discussion_r28755583","pull_request_url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/292","_links":{"self":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/comments/28755583"},"html":{"href":"https://github.com/gregorio-project/gregorio/pull/292#discussion_r28755583"},"pull_request":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/292"}}},"pull_request":{"url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/292","id":33596559,"html_url":"https://github.com/gregorio-project/gregorio/pull/292","diff_url":"https://github.com/gregorio-project/gregorio/pull/292.diff","patch_url":"https://github.com/gregorio-project/gregorio/pull/292.patch","issue_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/292","number":292,"state":"closed","locked":false,"title":"Remove hard-coding of code points","user":{"login":"henryso","id":421318,"avatar_url":"https://avatars.githubusercontent.com/u/421318?v=3","gravatar_id":"","url":"https://api.github.com/users/henryso","html_url":"https://github.com/henryso","followers_url":"https://api.github.com/users/henryso/followers","following_url":"https://api.github.com/users/henryso/following{/other_user}","gists_url":"https://api.github.com/users/henryso/gists{/gist_id}","starred_url":"https://api.github.com/users/henryso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryso/subscriptions","organizations_url":"https://api.github.com/users/henryso/orgs","repos_url":"https://api.github.com/users/henryso/repos","events_url":"https://api.github.com/users/henryso/events{/privacy}","received_events_url":"https://api.github.com/users/henryso/received_events","type":"User","site_admin":false},"body":"This is a fix for #279.\r\n\r\nThus far, I've only done the main glyph fonts.  I still probably need to do at least the `greextra.ttf` font to eliminate the remaining code points in `gregoriotex-chars.tex`.\r\n\r\nIn addition to this refactor, I also took the opportunity to eliminate interposed blank glyphs since the glyph number formula would no longer be needed.  This allowed me to fit the glyphs in the BMP PUA using ISO10646-1 encoding, which then  did.\r\n\r\nI have not done much performance testing, but it appears to be pretty similar in my document set.\r\n\r\nAll tests pass except the gabc-to-gtex tests, which I expect to fail due to this change itself.\r\n\r\nPlease review.  If possible, please try this in TeX Live 2013 as well and let me know the outcome.","created_at":"2015-04-18T04:51:25Z","updated_at":"2015-04-21T07:32:32Z","closed_at":"2015-04-20T19:22:27Z","merged_at":"2015-04-20T19:22:27Z","merge_commit_sha":"7e425d2d6aa92aa5eddcb7b0e2356ea85abc4961","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/292/commits","review_comments_url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/292/comments","review_comment_url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/292/comments","statuses_url":"https://api.github.com/repos/gregorio-project/gregorio/statuses/d933626bb78acf40ffa8f75a2157af9686e6c1b5","head":{"label":"henryso:fix-297","ref":"fix-297","sha":"d933626bb78acf40ffa8f75a2157af9686e6c1b5","user":{"login":"henryso","id":421318,"avatar_url":"https://avatars.githubusercontent.com/u/421318?v=3","gravatar_id":"","url":"https://api.github.com/users/henryso","html_url":"https://github.com/henryso","followers_url":"https://api.github.com/users/henryso/followers","following_url":"https://api.github.com/users/henryso/following{/other_user}","gists_url":"https://api.github.com/users/henryso/gists{/gist_id}","starred_url":"https://api.github.com/users/henryso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryso/subscriptions","organizations_url":"https://api.github.com/users/henryso/orgs","repos_url":"https://api.github.com/users/henryso/repos","events_url":"https://api.github.com/users/henryso/events{/privacy}","received_events_url":"https://api.github.com/users/henryso/received_events","type":"User","site_admin":false},"repo":{"id":32427414,"name":"gregorio","full_name":"henryso/gregorio","owner":{"login":"henryso","id":421318,"avatar_url":"https://avatars.githubusercontent.com/u/421318?v=3","gravatar_id":"","url":"https://api.github.com/users/henryso","html_url":"https://github.com/henryso","followers_url":"https://api.github.com/users/henryso/followers","following_url":"https://api.github.com/users/henryso/following{/other_user}","gists_url":"https://api.github.com/users/henryso/gists{/gist_id}","starred_url":"https://api.github.com/users/henryso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryso/subscriptions","organizations_url":"https://api.github.com/users/henryso/orgs","repos_url":"https://api.github.com/users/henryso/repos","events_url":"https://api.github.com/users/henryso/events{/privacy}","received_events_url":"https://api.github.com/users/henryso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/henryso/gregorio","description":"source for the gregorio project","fork":true,"url":"https://api.github.com/repos/henryso/gregorio","forks_url":"https://api.github.com/repos/henryso/gregorio/forks","keys_url":"https://api.github.com/repos/henryso/gregorio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/henryso/gregorio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/henryso/gregorio/teams","hooks_url":"https://api.github.com/repos/henryso/gregorio/hooks","issue_events_url":"https://api.github.com/repos/henryso/gregorio/issues/events{/number}","events_url":"https://api.github.com/repos/henryso/gregorio/events","assignees_url":"https://api.github.com/repos/henryso/gregorio/assignees{/user}","branches_url":"https://api.github.com/repos/henryso/gregorio/branches{/branch}","tags_url":"https://api.github.com/repos/henryso/gregorio/tags","blobs_url":"https://api.github.com/repos/henryso/gregorio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/henryso/gregorio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/henryso/gregorio/git/refs{/sha}","trees_url":"https://api.github.com/repos/henryso/gregorio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/henryso/gregorio/statuses/{sha}","languages_url":"https://api.github.com/repos/henryso/gregorio/languages","stargazers_url":"https://api.github.com/repos/henryso/gregorio/stargazers","contributors_url":"https://api.github.com/repos/henryso/gregorio/contributors","subscribers_url":"https://api.github.com/repos/henryso/gregorio/subscribers","subscription_url":"https://api.github.com/repos/henryso/gregorio/subscription","commits_url":"https://api.github.com/repos/henryso/gregorio/commits{/sha}","git_commits_url":"https://api.github.com/repos/henryso/gregorio/git/commits{/sha}","comments_url":"https://api.github.com/repos/henryso/gregorio/comments{/number}","issue_comment_url":"https://api.github.com/repos/henryso/gregorio/issues/comments{/number}","contents_url":"https://api.github.com/repos/henryso/gregorio/contents/{+path}","compare_url":"https://api.github.com/repos/henryso/gregorio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/henryso/gregorio/merges","archive_url":"https://api.github.com/repos/henryso/gregorio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/henryso/gregorio/downloads","issues_url":"https://api.github.com/repos/henryso/gregorio/issues{/number}","pulls_url":"https://api.github.com/repos/henryso/gregorio/pulls{/number}","milestones_url":"https://api.github.com/repos/henryso/gregorio/milestones{/number}","notifications_url":"https://api.github.com/repos/henryso/gregorio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/henryso/gregorio/labels{/name}","releases_url":"https://api.github.com/repos/henryso/gregorio/releases{/id}","created_at":"2015-03-17T23:57:54Z","updated_at":"2015-04-16T15:09:11Z","pushed_at":"2015-04-21T03:54:27Z","git_url":"git://github.com/henryso/gregorio.git","ssh_url":"git@github.com:henryso/gregorio.git","clone_url":"https://github.com/henryso/gregorio.git","svn_url":"https://github.com/henryso/gregorio","homepage":"http://home.gna.org/gregorio/","size":64837,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gregorio-project:develop","ref":"develop","sha":"498408b97518e0b6300b95cefe5a15b3ac3d7dd5","user":{"login":"gregorio-project","id":7902256,"avatar_url":"https://avatars.githubusercontent.com/u/7902256?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorio-project","html_url":"https://github.com/gregorio-project","followers_url":"https://api.github.com/users/gregorio-project/followers","following_url":"https://api.github.com/users/gregorio-project/following{/other_user}","gists_url":"https://api.github.com/users/gregorio-project/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorio-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorio-project/subscriptions","organizations_url":"https://api.github.com/users/gregorio-project/orgs","repos_url":"https://api.github.com/users/gregorio-project/repos","events_url":"https://api.github.com/users/gregorio-project/events{/privacy}","received_events_url":"https://api.github.com/users/gregorio-project/received_events","type":"Organization","site_admin":false},"repo":{"id":20884374,"name":"gregorio","full_name":"gregorio-project/gregorio","owner":{"login":"gregorio-project","id":7902256,"avatar_url":"https://avatars.githubusercontent.com/u/7902256?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorio-project","html_url":"https://github.com/gregorio-project","followers_url":"https://api.github.com/users/gregorio-project/followers","following_url":"https://api.github.com/users/gregorio-project/following{/other_user}","gists_url":"https://api.github.com/users/gregorio-project/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorio-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorio-project/subscriptions","organizations_url":"https://api.github.com/users/gregorio-project/orgs","repos_url":"https://api.github.com/users/gregorio-project/repos","events_url":"https://api.github.com/users/gregorio-project/events{/privacy}","received_events_url":"https://api.github.com/users/gregorio-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gregorio-project/gregorio","description":"The Gregorio Project","fork":false,"url":"https://api.github.com/repos/gregorio-project/gregorio","forks_url":"https://api.github.com/repos/gregorio-project/gregorio/forks","keys_url":"https://api.github.com/repos/gregorio-project/gregorio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gregorio-project/gregorio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gregorio-project/gregorio/teams","hooks_url":"https://api.github.com/repos/gregorio-project/gregorio/hooks","issue_events_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/events{/number}","events_url":"https://api.github.com/repos/gregorio-project/gregorio/events","assignees_url":"https://api.github.com/repos/gregorio-project/gregorio/assignees{/user}","branches_url":"https://api.github.com/repos/gregorio-project/gregorio/branches{/branch}","tags_url":"https://api.github.com/repos/gregorio-project/gregorio/tags","blobs_url":"https://api.github.com/repos/gregorio-project/gregorio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gregorio-project/gregorio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gregorio-project/gregorio/git/refs{/sha}","trees_url":"https://api.github.com/repos/gregorio-project/gregorio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gregorio-project/gregorio/statuses/{sha}","languages_url":"https://api.github.com/repos/gregorio-project/gregorio/languages","stargazers_url":"https://api.github.com/repos/gregorio-project/gregorio/stargazers","contributors_url":"https://api.github.com/repos/gregorio-project/gregorio/contributors","subscribers_url":"https://api.github.com/repos/gregorio-project/gregorio/subscribers","subscription_url":"https://api.github.com/repos/gregorio-project/gregorio/subscription","commits_url":"https://api.github.com/repos/gregorio-project/gregorio/commits{/sha}","git_commits_url":"https://api.github.com/repos/gregorio-project/gregorio/git/commits{/sha}","comments_url":"https://api.github.com/repos/gregorio-project/gregorio/comments{/number}","issue_comment_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/comments{/number}","contents_url":"https://api.github.com/repos/gregorio-project/gregorio/contents/{+path}","compare_url":"https://api.github.com/repos/gregorio-project/gregorio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gregorio-project/gregorio/merges","archive_url":"https://api.github.com/repos/gregorio-project/gregorio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gregorio-project/gregorio/downloads","issues_url":"https://api.github.com/repos/gregorio-project/gregorio/issues{/number}","pulls_url":"https://api.github.com/repos/gregorio-project/gregorio/pulls{/number}","milestones_url":"https://api.github.com/repos/gregorio-project/gregorio/milestones{/number}","notifications_url":"https://api.github.com/repos/gregorio-project/gregorio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gregorio-project/gregorio/labels{/name}","releases_url":"https://api.github.com/repos/gregorio-project/gregorio/releases{/id}","created_at":"2014-06-16T12:41:52Z","updated_at":"2015-04-18T10:51:16Z","pushed_at":"2015-04-21T06:20:30Z","git_url":"git://github.com/gregorio-project/gregorio.git","ssh_url":"git@github.com:gregorio-project/gregorio.git","clone_url":"https://github.com/gregorio-project/gregorio.git","svn_url":"https://github.com/gregorio-project/gregorio","homepage":"http://gregorio-project.github.io","size":67141,"stargazers_count":17,"watchers_count":17,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":28,"forks":8,"open_issues":28,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/292"},"html":{"href":"https://github.com/gregorio-project/gregorio/pull/292"},"issue":{"href":"https://api.github.com/repos/gregorio-project/gregorio/issues/292"},"comments":{"href":"https://api.github.com/repos/gregorio-project/gregorio/issues/292/comments"},"review_comments":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/292/comments"},"review_comment":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/292/commits"},"statuses":{"href":"https://api.github.com/repos/gregorio-project/gregorio/statuses/d933626bb78acf40ffa8f75a2157af9686e6c1b5"}}}}