{"action":"opened","number":520,"pull_request":{"url":"https://api.github.com/repos/H-uru/Plasma/pulls/520","id":42543577,"html_url":"https://github.com/H-uru/Plasma/pull/520","diff_url":"https://github.com/H-uru/Plasma/pull/520.diff","patch_url":"https://github.com/H-uru/Plasma/pull/520.patch","issue_url":"https://api.github.com/repos/H-uru/Plasma/issues/520","number":520,"state":"open","locked":false,"title":"WIP: plCreatable modernizing","user":{"login":"dpogue","id":241708,"avatar_url":"https://avatars.githubusercontent.com/u/241708?v=3","gravatar_id":"","url":"https://api.github.com/users/dpogue","html_url":"https://github.com/dpogue","followers_url":"https://api.github.com/users/dpogue/followers","following_url":"https://api.github.com/users/dpogue/following{/other_user}","gists_url":"https://api.github.com/users/dpogue/gists{/gist_id}","starred_url":"https://api.github.com/users/dpogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpogue/subscriptions","organizations_url":"https://api.github.com/users/dpogue/orgs","repos_url":"https://api.github.com/users/dpogue/repos","events_url":"https://api.github.com/users/dpogue/events{/privacy}","received_events_url":"https://api.github.com/users/dpogue/received_events","type":"User","site_admin":false},"body":"Mostly just changing the creatable macros to properly use C++-style casts, and the creatable types to use the `override` keyword properly.\r\n\r\nI started in NucleusLib, and then got distracted with investigating some of the old plKey loading stuff. Eventually we'll want all creatable classes in all libs to properly use `override`.\r\n\r\nClang (and gcc) warn about missing overrides, so the goal is to have no override warnings.","created_at":"2015-08-16T21:18:15Z","updated_at":"2015-08-16T21:18:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/H-uru/Plasma/pulls/520/commits","review_comments_url":"https://api.github.com/repos/H-uru/Plasma/pulls/520/comments","review_comment_url":"https://api.github.com/repos/H-uru/Plasma/pulls/comments{/number}","comments_url":"https://api.github.com/repos/H-uru/Plasma/issues/520/comments","statuses_url":"https://api.github.com/repos/H-uru/Plasma/statuses/23ae3004473c5ebf2f4c6cc2120f5983d0b675f3","head":{"label":"dpogue:safety-class","ref":"safety-class","sha":"23ae3004473c5ebf2f4c6cc2120f5983d0b675f3","user":{"login":"dpogue","id":241708,"avatar_url":"https://avatars.githubusercontent.com/u/241708?v=3","gravatar_id":"","url":"https://api.github.com/users/dpogue","html_url":"https://github.com/dpogue","followers_url":"https://api.github.com/users/dpogue/followers","following_url":"https://api.github.com/users/dpogue/following{/other_user}","gists_url":"https://api.github.com/users/dpogue/gists{/gist_id}","starred_url":"https://api.github.com/users/dpogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpogue/subscriptions","organizations_url":"https://api.github.com/users/dpogue/orgs","repos_url":"https://api.github.com/users/dpogue/repos","events_url":"https://api.github.com/users/dpogue/events{/privacy}","received_events_url":"https://api.github.com/users/dpogue/received_events","type":"User","site_admin":false},"repo":{"id":1879776,"name":"Plasma","full_name":"dpogue/Plasma","owner":{"login":"dpogue","id":241708,"avatar_url":"https://avatars.githubusercontent.com/u/241708?v=3","gravatar_id":"","url":"https://api.github.com/users/dpogue","html_url":"https://github.com/dpogue","followers_url":"https://api.github.com/users/dpogue/followers","following_url":"https://api.github.com/users/dpogue/following{/other_user}","gists_url":"https://api.github.com/users/dpogue/gists{/gist_id}","starred_url":"https://api.github.com/users/dpogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpogue/subscriptions","organizations_url":"https://api.github.com/users/dpogue/orgs","repos_url":"https://api.github.com/users/dpogue/repos","events_url":"https://api.github.com/users/dpogue/events{/privacy}","received_events_url":"https://api.github.com/users/dpogue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpogue/Plasma","description":"Cyan Worlds's Plasma game engine","fork":true,"url":"https://api.github.com/repos/dpogue/Plasma","forks_url":"https://api.github.com/repos/dpogue/Plasma/forks","keys_url":"https://api.github.com/repos/dpogue/Plasma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpogue/Plasma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpogue/Plasma/teams","hooks_url":"https://api.github.com/repos/dpogue/Plasma/hooks","issue_events_url":"https://api.github.com/repos/dpogue/Plasma/issues/events{/number}","events_url":"https://api.github.com/repos/dpogue/Plasma/events","assignees_url":"https://api.github.com/repos/dpogue/Plasma/assignees{/user}","branches_url":"https://api.github.com/repos/dpogue/Plasma/branches{/branch}","tags_url":"https://api.github.com/repos/dpogue/Plasma/tags","blobs_url":"https://api.github.com/repos/dpogue/Plasma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpogue/Plasma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpogue/Plasma/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpogue/Plasma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpogue/Plasma/statuses/{sha}","languages_url":"https://api.github.com/repos/dpogue/Plasma/languages","stargazers_url":"https://api.github.com/repos/dpogue/Plasma/stargazers","contributors_url":"https://api.github.com/repos/dpogue/Plasma/contributors","subscribers_url":"https://api.github.com/repos/dpogue/Plasma/subscribers","subscription_url":"https://api.github.com/repos/dpogue/Plasma/subscription","commits_url":"https://api.github.com/repos/dpogue/Plasma/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpogue/Plasma/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpogue/Plasma/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpogue/Plasma/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpogue/Plasma/contents/{+path}","compare_url":"https://api.github.com/repos/dpogue/Plasma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpogue/Plasma/merges","archive_url":"https://api.github.com/repos/dpogue/Plasma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpogue/Plasma/downloads","issues_url":"https://api.github.com/repos/dpogue/Plasma/issues{/number}","pulls_url":"https://api.github.com/repos/dpogue/Plasma/pulls{/number}","milestones_url":"https://api.github.com/repos/dpogue/Plasma/milestones{/number}","notifications_url":"https://api.github.com/repos/dpogue/Plasma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpogue/Plasma/labels{/name}","releases_url":"https://api.github.com/repos/dpogue/Plasma/releases{/id}","created_at":"2011-06-11T10:22:10Z","updated_at":"2015-02-14T05:40:43Z","pushed_at":"2015-08-16T21:10:39Z","git_url":"git://github.com/dpogue/Plasma.git","ssh_url":"git@github.com:dpogue/Plasma.git","clone_url":"https://github.com/dpogue/Plasma.git","svn_url":"https://github.com/dpogue/Plasma","homepage":"","size":38030,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"H-uru:master","ref":"master","sha":"9a6a565a94050d05ecfddf5a5636d4da7a3bb7a9","user":{"login":"H-uru","id":714185,"avatar_url":"https://avatars.githubusercontent.com/u/714185?v=3","gravatar_id":"","url":"https://api.github.com/users/H-uru","html_url":"https://github.com/H-uru","followers_url":"https://api.github.com/users/H-uru/followers","following_url":"https://api.github.com/users/H-uru/following{/other_user}","gists_url":"https://api.github.com/users/H-uru/gists{/gist_id}","starred_url":"https://api.github.com/users/H-uru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/H-uru/subscriptions","organizations_url":"https://api.github.com/users/H-uru/orgs","repos_url":"https://api.github.com/users/H-uru/repos","events_url":"https://api.github.com/users/H-uru/events{/privacy}","received_events_url":"https://api.github.com/users/H-uru/received_events","type":"Organization","site_admin":false},"repo":{"id":1579856,"name":"Plasma","full_name":"H-uru/Plasma","owner":{"login":"H-uru","id":714185,"avatar_url":"https://avatars.githubusercontent.com/u/714185?v=3","gravatar_id":"","url":"https://api.github.com/users/H-uru","html_url":"https://github.com/H-uru","followers_url":"https://api.github.com/users/H-uru/followers","following_url":"https://api.github.com/users/H-uru/following{/other_user}","gists_url":"https://api.github.com/users/H-uru/gists{/gist_id}","starred_url":"https://api.github.com/users/H-uru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/H-uru/subscriptions","organizations_url":"https://api.github.com/users/H-uru/orgs","repos_url":"https://api.github.com/users/H-uru/repos","events_url":"https://api.github.com/users/H-uru/events{/privacy}","received_events_url":"https://api.github.com/users/H-uru/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/H-uru/Plasma","description":"Cyan Worlds's Plasma game engine","fork":false,"url":"https://api.github.com/repos/H-uru/Plasma","forks_url":"https://api.github.com/repos/H-uru/Plasma/forks","keys_url":"https://api.github.com/repos/H-uru/Plasma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/H-uru/Plasma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/H-uru/Plasma/teams","hooks_url":"https://api.github.com/repos/H-uru/Plasma/hooks","issue_events_url":"https://api.github.com/repos/H-uru/Plasma/issues/events{/number}","events_url":"https://api.github.com/repos/H-uru/Plasma/events","assignees_url":"https://api.github.com/repos/H-uru/Plasma/assignees{/user}","branches_url":"https://api.github.com/repos/H-uru/Plasma/branches{/branch}","tags_url":"https://api.github.com/repos/H-uru/Plasma/tags","blobs_url":"https://api.github.com/repos/H-uru/Plasma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/H-uru/Plasma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/H-uru/Plasma/git/refs{/sha}","trees_url":"https://api.github.com/repos/H-uru/Plasma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/H-uru/Plasma/statuses/{sha}","languages_url":"https://api.github.com/repos/H-uru/Plasma/languages","stargazers_url":"https://api.github.com/repos/H-uru/Plasma/stargazers","contributors_url":"https://api.github.com/repos/H-uru/Plasma/contributors","subscribers_url":"https://api.github.com/repos/H-uru/Plasma/subscribers","subscription_url":"https://api.github.com/repos/H-uru/Plasma/subscription","commits_url":"https://api.github.com/repos/H-uru/Plasma/commits{/sha}","git_commits_url":"https://api.github.com/repos/H-uru/Plasma/git/commits{/sha}","comments_url":"https://api.github.com/repos/H-uru/Plasma/comments{/number}","issue_comment_url":"https://api.github.com/repos/H-uru/Plasma/issues/comments{/number}","contents_url":"https://api.github.com/repos/H-uru/Plasma/contents/{+path}","compare_url":"https://api.github.com/repos/H-uru/Plasma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/H-uru/Plasma/merges","archive_url":"https://api.github.com/repos/H-uru/Plasma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/H-uru/Plasma/downloads","issues_url":"https://api.github.com/repos/H-uru/Plasma/issues{/number}","pulls_url":"https://api.github.com/repos/H-uru/Plasma/pulls{/number}","milestones_url":"https://api.github.com/repos/H-uru/Plasma/milestones{/number}","notifications_url":"https://api.github.com/repos/H-uru/Plasma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/H-uru/Plasma/labels{/name}","releases_url":"https://api.github.com/repos/H-uru/Plasma/releases{/id}","created_at":"2011-04-06T23:41:12Z","updated_at":"2015-06-12T02:12:08Z","pushed_at":"2015-08-16T21:18:16Z","git_url":"git://github.com/H-uru/Plasma.git","ssh_url":"git@github.com:H-uru/Plasma.git","clone_url":"https://github.com/H-uru/Plasma.git","svn_url":"https://github.com/H-uru/Plasma","homepage":"","size":41827,"stargazers_count":75,"watchers_count":75,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"open_issues_count":38,"forks":33,"open_issues":38,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/H-uru/Plasma/pulls/520"},"html":{"href":"https://github.com/H-uru/Plasma/pull/520"},"issue":{"href":"https://api.github.com/repos/H-uru/Plasma/issues/520"},"comments":{"href":"https://api.github.com/repos/H-uru/Plasma/issues/520/comments"},"review_comments":{"href":"https://api.github.com/repos/H-uru/Plasma/pulls/520/comments"},"review_comment":{"href":"https://api.github.com/repos/H-uru/Plasma/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/H-uru/Plasma/pulls/520/commits"},"statuses":{"href":"https://api.github.com/repos/H-uru/Plasma/statuses/23ae3004473c5ebf2f4c6cc2120f5983d0b675f3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":6,"additions":775,"deletions":723,"changed_files":54}}