{"push_id":784045811,"size":21,"distinct_size":21,"ref":"refs/heads/master","head":"a507885254c593f41793d737c31c1dd1b4882771","before":"13e1fd436a1cf2606543cb3e9b259c63d58e23a5","commits":[{"sha":"6915011067d619780c390e3ad9ecb820132bbe84","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@epriestley.com","name":"epriestley"},"message":"Provide an AphrontController implementation of willSendResponse()\n\nSummary: This is required by Aphront now but not given a default implementation in the base class.\n\nTest Plan: CORGI sites now work.\n\nReviewers: chad\n\nReviewed By: chad\n\nDifferential Revision: https://secure.phabricator.com/D14079","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/6915011067d619780c390e3ad9ecb820132bbe84"},{"sha":"b8fcee3e03f9e6393e13f226e04a16d00393db05","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"[FreeBSD] FreeBSD prefers 8 space tabs rather than 2","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/b8fcee3e03f9e6393e13f226e04a16d00393db05"},{"sha":"c11e1dc37dd27b76b777bf372258cea3a14e1eae","author":{"email":"aeb8da9b93f4f35c2ddc1280821f190e432a94e3@freebsd.org","name":"Ed Maste"},"message":"[FreeBSD] Avoid \"ready to land\" terminology\n\nReport only that a change has had a positive review, allowing the\nsubmitter to follow usual workflow conventions in FreeBSD. We use\nPhabricator as a standalone tool to facilitate review if desired,\nbut its use is not required, and does not dictate our workflow.\n\nClaiming a change is \"ready to land\" after one positive review does not\nmesh with the usual workflow in the FreeBSD community. Some changes may\nrequire more than one reviewer or additional testing, for example.","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/c11e1dc37dd27b76b777bf372258cea3a14e1eae"},{"sha":"611bb4d44ae4555c9d5c8ca0c12c4dce2e9d8900","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"[FreeBSD] Permit to join IRC channels with keys","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/611bb4d44ae4555c9d5c8ca0c12c4dce2e9d8900"},{"sha":"41a9f8e5a634f9d90c518144183f2023ff6dfe30","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"[FreeBSD] Don't ignore extensions in the FreeBSD install\n\nwe use them, so don't ignore them by default","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/41a9f8e5a634f9d90c518144183f2023ff6dfe30"},{"sha":"3760a88d12666bf32ac2a812dd20c3c047385189","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"[FreeBSD] Unbreak notification handler","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/3760a88d12666bf32ac2a812dd20c3c047385189"},{"sha":"628ee28b2ddc108e10e6d1d37308585b29b1da87","author":{"email":"25b6170de171dac8b38030674da0d668d8db4286@uber.com","name":"Povilas Balzaravicius Pawka"},"message":"[Early] Fix exception when same tag as primary slug is provided during project creation.\n\nSummary: T8509\n\nTest Plan: Follow steps described in T8509.\n\nReviewers: #blessed_reviewers, eadler\n\nReviewed By: eadler\n\nSubscribers: epriestley\n\nManiphest Tasks: T8509\n\nDifferential Revision: https://secure.phabricator.com/D13244","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/628ee28b2ddc108e10e6d1d37308585b29b1da87"},{"sha":"8d4d104b6131e68661300dfe5b7340b29c22d4aa","author":{"email":"c028c213ed5efcf30c3f4fc7361dbde0c893c5b7@joshuaspence.com","name":"Joshua Spence"},"message":"[Early] Allow differential changesets to be marked as generated via diff properties\n\nSummary:\nRef T784. Allow differential changesets to be marked as generated with a `DifferentialDiffProperty`. The expectation is that `arc diff` will submit an `arc:generated` diff property (which will be populated out of the local `.arcconfig` file). These paths will then be automatically marked as generated when rendering the differential changeset.\n\nCurrently, the only way to achieve this is with `differential.generated-paths`. The main issue with `differential.generated-paths` is that it is a global setting and cannot be varied across repositories. A natural extension from `differential.generated-paths` would be to move this configuration into the per-repository configuration, however I feel that this approach would be too inflexible to be useful. Specifically, this setting would need to be updated whenever generated paths are added/removed/changed for a particular repository (although I would expect this to be a fairly infrequent occurrence).\n\nUnfortunately, this functionality will not be retrofitted to existing differentials. We //could// possibly add a migration which populates `arc:generated` for all existing differentials based on the value of `differential.generated-paths`, although I'm not convinced that this is worth pursuing.\n\nTest Plan:\nUploaded a diff (using `arc diff`) and set paths for `arc:generated` with `arc call-conduit 'differential.setdiffproperty'`. Loaded the differential in the UI and noticed that the paths were marked as generated as expected.\n\nOne interesting thing to note (I'm not sure if I would consider this to be a bug or expected behavior) is that lint messages takes a higher precedence over generated paths. If a path matches a regular expression in `arc:generated` but has some linter messages associated with that path, then the file will //not// be shown as generated in the UI. This is mainly an issue until after D11537.\n\nReviewers: epriestley, #blessed_reviewers\n\nSubscribers: Korvin, epriestley\n\nManiphest Tasks: T784\n\nDifferential Revision: https://secure.phabricator.com/D11535","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/8d4d104b6131e68661300dfe5b7340b29c22d4aa"},{"sha":"e6b83557a0aca4e54b9d44205f90554f7039bfd9","author":{"email":"a35f9abe9153679d6785d3abe801ca381209e572@siemens.com","name":"David Schumann"},"message":"[Early] Fixed T7000\n\nSummary: Fixed T7000\n\nTest Plan:\n1) Create repository with limited access for only one user\n2) Make phabricator public\n3) Push/Pull to the repository\n\nReviewers: #blessed_reviewers, epriestley\n\nSubscribers: joshuaspence, epriestley\n\nManiphest Tasks: T7000\n\nDifferential Revision: https://secure.phabricator.com/D11462","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/e6b83557a0aca4e54b9d44205f90554f7039bfd9"},{"sha":"cd40f68670ecc622e929527ee1d9038ecf8bf597","author":{"email":"e2d743f4419ca2fe77d9cd7ed477fc3369433991@gmail.com","name":"Alexander Obuhovich"},"message":"[Early] Show SVN property changes on commit page\n\nSummary:\nAllows to see changes within SVN properties on commit page.\n\nThis is actually the improved version of D8478, that supports also SVN 1.6 clients.\nIf this diff is to be merged, then that one needs to be closed.\n\nFixes T4255\n\nTest Plan:\n\nReviewers: #blessed_reviewers\n\nSubscribers: altendky, epriestley\n\nManiphest Tasks: T4255\n\nDifferential Revision: https://secure.phabricator.com/D10977","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/cd40f68670ecc622e929527ee1d9038ecf8bf597"},{"sha":"d378c71e34375507a5e8a6f132db88451739eaaa","author":{"email":"777050ab89cbd335c2d6340e3a3f373c8bfafb3a@gmail.com","name":"Tal Shiri"},"message":"[Early] Don't force main menu search form to use POST\n\nSummary:\nThis allows browsers (Chorme, Firefox) to add Phabricator as a search engine.\n\nThe CSRF token that was previously generated (as it was a POST) was not checked anyway, and I don't think this is exploitable.\n\nTest Plan: Right clicked on Chrome, as \"Add As Search Engine\". Tried out the search and it worked.\n\nReviewers: #blessed_reviewers, epriestley\n\nSubscribers: Korvin, epriestley\n\nDifferential Revision: https://secure.phabricator.com/D10954","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/d378c71e34375507a5e8a6f132db88451739eaaa"},{"sha":"52d85557d8e50d464cbb7ccdd61325757c22cb1d","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"[FreeBSD] Always suppress mail from the audit application when 'a commit is\ncreated'","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/52d85557d8e50d464cbb7ccdd61325757c22cb1d"},{"sha":"c7ea86c93a37d4dcefa5217c64259cf3bbd9caab","author":{"email":"16bef47ba68b0e0a74efc3286dc0590b5d7d2c26@automatic.com","name":"Aniruddha Maru"},"message":"[Early] Allow pastes to be edited from conduit call.\n\nSummary: Allow pastes to be edited from conduit call.\n\nTest Plan: Test using `arcanist paste --edit` command\n\nReviewers: epriestley, #blessed_reviewers\n\nSubscribers: epriestley, Korvin\n\nDifferential Revision: https://secure.phabricator.com/D10097","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/c7ea86c93a37d4dcefa5217c64259cf3bbd9caab"},{"sha":"ec5c34c299ab7e6ba44861e6c8a24c1a95192199","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"[FreeBSD] Be a bit less serious\n\nIn some cases being serious is the wrong thing.  Be less serious.","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/ec5c34c299ab7e6ba44861e6c8a24c1a95192199"},{"sha":"51b986913f66d928f11fc67733abe375a32008a4","author":{"email":"ffa6706ff2127a749973072756f83c532e43ed02@thera.be","name":"Tomasz bla Fortuna"},"message":"[Rejected] Handle websockets with reverse-provied phabricator.\n\nSummary:\nConfiguration:\nNginx (SSL + reverse proxy) -> Apache (PHP)\nwouldn't work because request, as seen by apache, was never\nover HTTPS and http/https setting on client-uri was ignored.\n\nTest Plan:\nCreate configuration with TLS terminated before apache (running phabricator) sees it.\nThen try to use websockets/notifications according to documentation at\nhttps://secure.phabricator.com/book/phabricator/article/notifications/\n\nChromium has a bit better error messages than firefox. Both won't be able to connect\nbecause of security policies.\n\nReviewers: #blessed_reviewers, epriestley\n\nSubscribers: eadler, epriestley\n\nDifferential Revision: https://secure.phabricator.com/D13538","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/51b986913f66d928f11fc67733abe375a32008a4"},{"sha":"5fe05deae6615b1116732adf9e790f65f561296c","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"[FreeBSD] Teach PhabricatorBotObjectNameHandler not to respond to all 1 number objects","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/5fe05deae6615b1116732adf9e790f65f561296c"},{"sha":"35cd8ba09a62e54e10ee2073c641b7718bb7ce74","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"[FreeBSD] attempt to respond to man pages","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/35cd8ba09a62e54e10ee2073c641b7718bb7ce74"},{"sha":"adb892d861c1b947a992822c81abee7b0c2eb015","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"[FreeBSD] Arc liberate - lets see if this helps?","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/adb892d861c1b947a992822c81abee7b0c2eb015"},{"sha":"a3b4c48597a54c5e5fc8c3bb6d88d11247b1e7e1","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"[FreeBSD] arc liberate most removal of some herald custom actions","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/a3b4c48597a54c5e5fc8c3bb6d88d11247b1e7e1"},{"sha":"e1ae41e1b2e1ae38246551131e826622557c9038","author":{"email":"da2ea5bee82302925a2874f529684e980c179d70@eitanadler.com","name":"Eitan Adler"},"message":"[FreeBSD] use badges early","distinct":true,"url":"https://api.github.com/repos/freebsd/phabricator/commits/e1ae41e1b2e1ae38246551131e826622557c9038"}]}