{"action":"created","comment":{"url":"https://api.github.com/repos/jp9000/obs-studio/pulls/comments/22804928","id":22804928,"diff_hunk":"@@ -188,3 +214,36 @@ void OBSBasicProperties::Init()\n \t\tobs_display_add_draw_callback(display,\n \t\t\t\tOBSBasicProperties::DrawPreview, this);\n }\n+\n+void OBSBasicProperties::CheckSettings()\n+{\n+\tOBSData currentSettings = obs_source_get_settings(source);\n+\tconst char *oldSettingsJson = obs_data_get_json(oldSettings);\n+\tconst char *currentSettingsJson = obs_data_get_json(currentSettings);\n+\n+\tif (strcmp(currentSettingsJson, oldSettingsJson) != 0) {\n+\t\tQMessageBox msgBox;\n+\t\tmsgBox.setText(\"Source Settings Changed.\");","path":"obs/window-basic-properties.cpp","position":82,"original_position":82,"commit_id":"84809a7dddd26c84613baf515898ff906bec74f1","original_commit_id":"84809a7dddd26c84613baf515898ff906bec74f1","user":{"login":"ThoNohT","id":3800650,"avatar_url":"https://avatars.githubusercontent.com/u/3800650?v=3","gravatar_id":"","url":"https://api.github.com/users/ThoNohT","html_url":"https://github.com/ThoNohT","followers_url":"https://api.github.com/users/ThoNohT/followers","following_url":"https://api.github.com/users/ThoNohT/following{/other_user}","gists_url":"https://api.github.com/users/ThoNohT/gists{/gist_id}","starred_url":"https://api.github.com/users/ThoNohT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThoNohT/subscriptions","organizations_url":"https://api.github.com/users/ThoNohT/orgs","repos_url":"https://api.github.com/users/ThoNohT/repos","events_url":"https://api.github.com/users/ThoNohT/events{/privacy}","received_events_url":"https://api.github.com/users/ThoNohT/received_events","type":"User","site_admin":false},"body":"These strings should be localized.","created_at":"2015-01-12T17:18:17Z","updated_at":"2015-01-12T17:18:17Z","html_url":"https://github.com/jp9000/obs-studio/pull/329#discussion_r22804928","pull_request_url":"https://api.github.com/repos/jp9000/obs-studio/pulls/329","_links":{"self":{"href":"https://api.github.com/repos/jp9000/obs-studio/pulls/comments/22804928"},"html":{"href":"https://github.com/jp9000/obs-studio/pull/329#discussion_r22804928"},"pull_request":{"href":"https://api.github.com/repos/jp9000/obs-studio/pulls/329"}}},"pull_request":{"url":"https://api.github.com/repos/jp9000/obs-studio/pulls/329","id":27169522,"html_url":"https://github.com/jp9000/obs-studio/pull/329","diff_url":"https://github.com/jp9000/obs-studio/pull/329.diff","patch_url":"https://github.com/jp9000/obs-studio/pull/329.patch","issue_url":"https://api.github.com/repos/jp9000/obs-studio/issues/329","number":329,"state":"open","locked":false,"title":"UI: Add Okay/Cancel Buttons to Properties Dialog","user":{"login":"Weikardzaena","id":10414738,"avatar_url":"https://avatars.githubusercontent.com/u/10414738?v=3","gravatar_id":"","url":"https://api.github.com/users/Weikardzaena","html_url":"https://github.com/Weikardzaena","followers_url":"https://api.github.com/users/Weikardzaena/followers","following_url":"https://api.github.com/users/Weikardzaena/following{/other_user}","gists_url":"https://api.github.com/users/Weikardzaena/gists{/gist_id}","starred_url":"https://api.github.com/users/Weikardzaena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Weikardzaena/subscriptions","organizations_url":"https://api.github.com/users/Weikardzaena/orgs","repos_url":"https://api.github.com/users/Weikardzaena/repos","events_url":"https://api.github.com/users/Weikardzaena/events{/privacy}","received_events_url":"https://api.github.com/users/Weikardzaena/received_events","type":"User","site_admin":false},"body":"Use QDialogButtonBox to add \"Okay\" and \"Cancel\" buttons to the\r\nproperties dialog.  The core functionality of the dialog is not changed;\r\nI.E. the settings are still applied to the source as the user changes\r\nthem.  If the user clicks \"Okay\", the dialog simply exits.  If the user\r\nclicks \"Cancel\", the original settings are reapplied to the source then\r\nthe dialog exits.  If the window is closed by any other means (I.E. by\r\nthe main obs window closing) then the properties dialog prompts the user\r\nif they changed anything and asks if they wish to save their settings.\r\n\r\nIn order to implement this last feature, a method of checking for open\r\ndialogs and sending each a quit message is added to the closeEvent()\r\nmethod for OBSBasic.","created_at":"2015-01-11T22:41:42Z","updated_at":"2015-01-12T17:18:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbb04d6680c29580bdf4c69c4a4a8f0904c85e8a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jp9000/obs-studio/pulls/329/commits","review_comments_url":"https://api.github.com/repos/jp9000/obs-studio/pulls/329/comments","review_comment_url":"https://api.github.com/repos/jp9000/obs-studio/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jp9000/obs-studio/issues/329/comments","statuses_url":"https://api.github.com/repos/jp9000/obs-studio/statuses/84809a7dddd26c84613baf515898ff906bec74f1","head":{"label":"Weikardzaena:ui-properties","ref":"ui-properties","sha":"84809a7dddd26c84613baf515898ff906bec74f1","user":{"login":"Weikardzaena","id":10414738,"avatar_url":"https://avatars.githubusercontent.com/u/10414738?v=3","gravatar_id":"","url":"https://api.github.com/users/Weikardzaena","html_url":"https://github.com/Weikardzaena","followers_url":"https://api.github.com/users/Weikardzaena/followers","following_url":"https://api.github.com/users/Weikardzaena/following{/other_user}","gists_url":"https://api.github.com/users/Weikardzaena/gists{/gist_id}","starred_url":"https://api.github.com/users/Weikardzaena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Weikardzaena/subscriptions","organizations_url":"https://api.github.com/users/Weikardzaena/orgs","repos_url":"https://api.github.com/users/Weikardzaena/repos","events_url":"https://api.github.com/users/Weikardzaena/events{/privacy}","received_events_url":"https://api.github.com/users/Weikardzaena/received_events","type":"User","site_admin":false},"repo":{"id":28853513,"name":"obs-studio","full_name":"Weikardzaena/obs-studio","owner":{"login":"Weikardzaena","id":10414738,"avatar_url":"https://avatars.githubusercontent.com/u/10414738?v=3","gravatar_id":"","url":"https://api.github.com/users/Weikardzaena","html_url":"https://github.com/Weikardzaena","followers_url":"https://api.github.com/users/Weikardzaena/followers","following_url":"https://api.github.com/users/Weikardzaena/following{/other_user}","gists_url":"https://api.github.com/users/Weikardzaena/gists{/gist_id}","starred_url":"https://api.github.com/users/Weikardzaena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Weikardzaena/subscriptions","organizations_url":"https://api.github.com/users/Weikardzaena/orgs","repos_url":"https://api.github.com/users/Weikardzaena/repos","events_url":"https://api.github.com/users/Weikardzaena/events{/privacy}","received_events_url":"https://api.github.com/users/Weikardzaena/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Weikardzaena/obs-studio","description":"OBS","fork":true,"url":"https://api.github.com/repos/Weikardzaena/obs-studio","forks_url":"https://api.github.com/repos/Weikardzaena/obs-studio/forks","keys_url":"https://api.github.com/repos/Weikardzaena/obs-studio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Weikardzaena/obs-studio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Weikardzaena/obs-studio/teams","hooks_url":"https://api.github.com/repos/Weikardzaena/obs-studio/hooks","issue_events_url":"https://api.github.com/repos/Weikardzaena/obs-studio/issues/events{/number}","events_url":"https://api.github.com/repos/Weikardzaena/obs-studio/events","assignees_url":"https://api.github.com/repos/Weikardzaena/obs-studio/assignees{/user}","branches_url":"https://api.github.com/repos/Weikardzaena/obs-studio/branches{/branch}","tags_url":"https://api.github.com/repos/Weikardzaena/obs-studio/tags","blobs_url":"https://api.github.com/repos/Weikardzaena/obs-studio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Weikardzaena/obs-studio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Weikardzaena/obs-studio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Weikardzaena/obs-studio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Weikardzaena/obs-studio/statuses/{sha}","languages_url":"https://api.github.com/repos/Weikardzaena/obs-studio/languages","stargazers_url":"https://api.github.com/repos/Weikardzaena/obs-studio/stargazers","contributors_url":"https://api.github.com/repos/Weikardzaena/obs-studio/contributors","subscribers_url":"https://api.github.com/repos/Weikardzaena/obs-studio/subscribers","subscription_url":"https://api.github.com/repos/Weikardzaena/obs-studio/subscription","commits_url":"https://api.github.com/repos/Weikardzaena/obs-studio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Weikardzaena/obs-studio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Weikardzaena/obs-studio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Weikardzaena/obs-studio/issues/comments/{number}","contents_url":"https://api.github.com/repos/Weikardzaena/obs-studio/contents/{+path}","compare_url":"https://api.github.com/repos/Weikardzaena/obs-studio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Weikardzaena/obs-studio/merges","archive_url":"https://api.github.com/repos/Weikardzaena/obs-studio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Weikardzaena/obs-studio/downloads","issues_url":"https://api.github.com/repos/Weikardzaena/obs-studio/issues{/number}","pulls_url":"https://api.github.com/repos/Weikardzaena/obs-studio/pulls{/number}","milestones_url":"https://api.github.com/repos/Weikardzaena/obs-studio/milestones{/number}","notifications_url":"https://api.github.com/repos/Weikardzaena/obs-studio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Weikardzaena/obs-studio/labels{/name}","releases_url":"https://api.github.com/repos/Weikardzaena/obs-studio/releases{/id}","created_at":"2015-01-06T08:14:36Z","updated_at":"2015-01-10T21:08:16Z","pushed_at":"2015-01-12T00:40:18Z","git_url":"git://github.com/Weikardzaena/obs-studio.git","ssh_url":"git@github.com:Weikardzaena/obs-studio.git","clone_url":"https://github.com/Weikardzaena/obs-studio.git","svn_url":"https://github.com/Weikardzaena/obs-studio","homepage":"https://obsproject.com/mantis/","size":9804,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jp9000:master","ref":"master","sha":"6d2226bde88465c36284aa549ac9dfc06fac1353","user":{"login":"jp9000","id":2084112,"avatar_url":"https://avatars.githubusercontent.com/u/2084112?v=3","gravatar_id":"","url":"https://api.github.com/users/jp9000","html_url":"https://github.com/jp9000","followers_url":"https://api.github.com/users/jp9000/followers","following_url":"https://api.github.com/users/jp9000/following{/other_user}","gists_url":"https://api.github.com/users/jp9000/gists{/gist_id}","starred_url":"https://api.github.com/users/jp9000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jp9000/subscriptions","organizations_url":"https://api.github.com/users/jp9000/orgs","repos_url":"https://api.github.com/users/jp9000/repos","events_url":"https://api.github.com/users/jp9000/events{/privacy}","received_events_url":"https://api.github.com/users/jp9000/received_events","type":"User","site_admin":false},"repo":{"id":13233158,"name":"obs-studio","full_name":"jp9000/obs-studio","owner":{"login":"jp9000","id":2084112,"avatar_url":"https://avatars.githubusercontent.com/u/2084112?v=3","gravatar_id":"","url":"https://api.github.com/users/jp9000","html_url":"https://github.com/jp9000","followers_url":"https://api.github.com/users/jp9000/followers","following_url":"https://api.github.com/users/jp9000/following{/other_user}","gists_url":"https://api.github.com/users/jp9000/gists{/gist_id}","starred_url":"https://api.github.com/users/jp9000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jp9000/subscriptions","organizations_url":"https://api.github.com/users/jp9000/orgs","repos_url":"https://api.github.com/users/jp9000/repos","events_url":"https://api.github.com/users/jp9000/events{/privacy}","received_events_url":"https://api.github.com/users/jp9000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jp9000/obs-studio","description":"OBS","fork":false,"url":"https://api.github.com/repos/jp9000/obs-studio","forks_url":"https://api.github.com/repos/jp9000/obs-studio/forks","keys_url":"https://api.github.com/repos/jp9000/obs-studio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jp9000/obs-studio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jp9000/obs-studio/teams","hooks_url":"https://api.github.com/repos/jp9000/obs-studio/hooks","issue_events_url":"https://api.github.com/repos/jp9000/obs-studio/issues/events{/number}","events_url":"https://api.github.com/repos/jp9000/obs-studio/events","assignees_url":"https://api.github.com/repos/jp9000/obs-studio/assignees{/user}","branches_url":"https://api.github.com/repos/jp9000/obs-studio/branches{/branch}","tags_url":"https://api.github.com/repos/jp9000/obs-studio/tags","blobs_url":"https://api.github.com/repos/jp9000/obs-studio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jp9000/obs-studio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jp9000/obs-studio/git/refs{/sha}","trees_url":"https://api.github.com/repos/jp9000/obs-studio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jp9000/obs-studio/statuses/{sha}","languages_url":"https://api.github.com/repos/jp9000/obs-studio/languages","stargazers_url":"https://api.github.com/repos/jp9000/obs-studio/stargazers","contributors_url":"https://api.github.com/repos/jp9000/obs-studio/contributors","subscribers_url":"https://api.github.com/repos/jp9000/obs-studio/subscribers","subscription_url":"https://api.github.com/repos/jp9000/obs-studio/subscription","commits_url":"https://api.github.com/repos/jp9000/obs-studio/commits{/sha}","git_commits_url":"https://api.github.com/repos/jp9000/obs-studio/git/commits{/sha}","comments_url":"https://api.github.com/repos/jp9000/obs-studio/comments{/number}","issue_comment_url":"https://api.github.com/repos/jp9000/obs-studio/issues/comments/{number}","contents_url":"https://api.github.com/repos/jp9000/obs-studio/contents/{+path}","compare_url":"https://api.github.com/repos/jp9000/obs-studio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jp9000/obs-studio/merges","archive_url":"https://api.github.com/repos/jp9000/obs-studio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jp9000/obs-studio/downloads","issues_url":"https://api.github.com/repos/jp9000/obs-studio/issues{/number}","pulls_url":"https://api.github.com/repos/jp9000/obs-studio/pulls{/number}","milestones_url":"https://api.github.com/repos/jp9000/obs-studio/milestones{/number}","notifications_url":"https://api.github.com/repos/jp9000/obs-studio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jp9000/obs-studio/labels{/name}","releases_url":"https://api.github.com/repos/jp9000/obs-studio/releases{/id}","created_at":"2013-10-01T02:40:31Z","updated_at":"2015-01-12T16:25:45Z","pushed_at":"2015-01-11T07:50:25Z","git_url":"git://github.com/jp9000/obs-studio.git","ssh_url":"git@github.com:jp9000/obs-studio.git","clone_url":"https://github.com/jp9000/obs-studio.git","svn_url":"https://github.com/jp9000/obs-studio","homepage":"https://obsproject.com/mantis/","size":20859,"stargazers_count":790,"watchers_count":790,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"open_issues_count":36,"forks":179,"open_issues":36,"watchers":790,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jp9000/obs-studio/pulls/329"},"html":{"href":"https://github.com/jp9000/obs-studio/pull/329"},"issue":{"href":"https://api.github.com/repos/jp9000/obs-studio/issues/329"},"comments":{"href":"https://api.github.com/repos/jp9000/obs-studio/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/jp9000/obs-studio/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/jp9000/obs-studio/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jp9000/obs-studio/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/jp9000/obs-studio/statuses/84809a7dddd26c84613baf515898ff906bec74f1"}}}}