{"action":"created","issue":{"url":"https://api.github.com/repos/AltSchool/django-scheduler/issues/4","labels_url":"https://api.github.com/repos/AltSchool/django-scheduler/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/AltSchool/django-scheduler/issues/4/comments","events_url":"https://api.github.com/repos/AltSchool/django-scheduler/issues/4/events","html_url":"https://github.com/AltSchool/django-scheduler/pull/4","id":65359274,"number":4,"title":"ASENG-99 Optimization to use rrule.between() calls less often since thos...","user":{"login":"fanwar","id":701511,"avatar_url":"https://avatars.githubusercontent.com/u/701511?v=3","gravatar_id":"","url":"https://api.github.com/users/fanwar","html_url":"https://github.com/fanwar","followers_url":"https://api.github.com/users/fanwar/followers","following_url":"https://api.github.com/users/fanwar/following{/other_user}","gists_url":"https://api.github.com/users/fanwar/gists{/gist_id}","starred_url":"https://api.github.com/users/fanwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanwar/subscriptions","organizations_url":"https://api.github.com/users/fanwar/orgs","repos_url":"https://api.github.com/users/fanwar/repos","events_url":"https://api.github.com/users/fanwar/events{/privacy}","received_events_url":"https://api.github.com/users/fanwar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-31T03:55:54Z","updated_at":"2015-03-31T03:58:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AltSchool/django-scheduler/pulls/4","html_url":"https://github.com/AltSchool/django-scheduler/pull/4","diff_url":"https://github.com/AltSchool/django-scheduler/pull/4.diff","patch_url":"https://github.com/AltSchool/django-scheduler/pull/4.patch"},"body":"...e are time-consuming. \r\n\r\nNote that this change causes the [testRecurringInclusion test](https://github.com/AltSchool/vishnu-backend/blob/master/vishnu/tests/models/test_event.py) to fail because of boundary conditions. I believe that test is invalid and should be changed so that the start/end for get_occurrences is not at the boundary, or we expect boundary values to match to events that end at the boundary as well as events that start at the boundary. "},"comment":{"url":"https://api.github.com/repos/AltSchool/django-scheduler/issues/comments/87926462","html_url":"https://github.com/AltSchool/django-scheduler/pull/4#issuecomment-87926462","issue_url":"https://api.github.com/repos/AltSchool/django-scheduler/issues/4","id":87926462,"user":{"login":"sganeriwal","id":5436873,"avatar_url":"https://avatars.githubusercontent.com/u/5436873?v=3","gravatar_id":"","url":"https://api.github.com/users/sganeriwal","html_url":"https://github.com/sganeriwal","followers_url":"https://api.github.com/users/sganeriwal/followers","following_url":"https://api.github.com/users/sganeriwal/following{/other_user}","gists_url":"https://api.github.com/users/sganeriwal/gists{/gist_id}","starred_url":"https://api.github.com/users/sganeriwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sganeriwal/subscriptions","organizations_url":"https://api.github.com/users/sganeriwal/orgs","repos_url":"https://api.github.com/users/sganeriwal/repos","events_url":"https://api.github.com/users/sganeriwal/events{/privacy}","received_events_url":"https://api.github.com/users/sganeriwal/received_events","type":"User","site_admin":false},"created_at":"2015-03-31T03:58:41Z","updated_at":"2015-03-31T03:58:41Z","body":"This is awesome. Scott, can you take a look and do you remember why you\nmade this change in the first place. Context is that is is causing serious\nperformance issues.\n\nOn Mon, Mar 30, 2015 at 8:55 PM, Faisal Anwar <notifications@github.com>\nwrote:\n\n> ...e are time-consuming.\n>\n> Note that this change causes the testRecurringInclusion test\n> <https://github.com/AltSchool/vishnu-backend/blob/master/vishnu/tests/models/test_event.py>\n> to fail because of boundary conditions. I believe that test is invalid and\n> should be changed so that the start/end for get_occurrences is not at the\n> boundary, or we expect boundary values to match to events that end at the\n> boundary as well as events that start at the boundary.\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/AltSchool/django-scheduler/pull/4\n> Commit Summary\n>\n>    - ASENG-99 Optimization to use rrule.between() calls less often since\n>    those are time-consuming\n>\n> File Changes\n>\n>    - *M* schedule/models/events.py\n>    <https://github.com/AltSchool/django-scheduler/pull/4/files#diff-0>\n>    (11)\n>    - *M* tests/test_event.py\n>    <https://github.com/AltSchool/django-scheduler/pull/4/files#diff-1>\n>    (108)\n>\n> Patch Links:\n>\n>    - https://github.com/AltSchool/django-scheduler/pull/4.patch\n>    - https://github.com/AltSchool/django-scheduler/pull/4.diff\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/AltSchool/django-scheduler/pull/4>.\n>\n"}}