{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/41872628","id":41872628,"diff_hunk":"@@ -60,33 +57,13 @@ def wcs(self):\n     @abstractproperty\n     def meta(self):\n         \"\"\"\n-        Metadata, if any, must be dict-like.\n+        Meta information, if any.","path":"astropy/nddata/nddata_base.py","position":43,"original_position":43,"commit_id":"3e9b8fa1188cde45057fd1579f114eb3163bbdd7","original_commit_id":"3e9b8fa1188cde45057fd1579f114eb3163bbdd7","user":{"login":"MSeifert04","id":14200878,"avatar_url":"https://avatars.githubusercontent.com/u/14200878?v=3","gravatar_id":"","url":"https://api.github.com/users/MSeifert04","html_url":"https://github.com/MSeifert04","followers_url":"https://api.github.com/users/MSeifert04/followers","following_url":"https://api.github.com/users/MSeifert04/following{/other_user}","gists_url":"https://api.github.com/users/MSeifert04/gists{/gist_id}","starred_url":"https://api.github.com/users/MSeifert04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSeifert04/subscriptions","organizations_url":"https://api.github.com/users/MSeifert04/orgs","repos_url":"https://api.github.com/users/MSeifert04/repos","events_url":"https://api.github.com/users/MSeifert04/events{/privacy}","received_events_url":"https://api.github.com/users/MSeifert04/received_events","type":"User","site_admin":false},"body":"answer to both your comments: Since ``NDDataBase`` only defines the general interface for the container with meta informations I felt they were wrong there and moved them to ``NDData`` where that is actually enforced or at least recommended (because of the mixins). I can move them back or copy the docstrings of the ``NDData`` class into ``NDDataBase``.","created_at":"2015-10-13T14:30:30Z","updated_at":"2015-10-13T14:30:30Z","html_url":"https://github.com/astropy/astropy/pull/4234#discussion_r41872628","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/4234","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/41872628"},"html":{"href":"https://github.com/astropy/astropy/pull/4234#discussion_r41872628"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4234"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/4234","id":47350640,"html_url":"https://github.com/astropy/astropy/pull/4234","diff_url":"https://github.com/astropy/astropy/pull/4234.diff","patch_url":"https://github.com/astropy/astropy/pull/4234.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/4234","number":4234,"state":"open","locked":false,"title":"WIP: NDData several bug fixes and added functionality (Refactoring it)","user":{"login":"MSeifert04","id":14200878,"avatar_url":"https://avatars.githubusercontent.com/u/14200878?v=3","gravatar_id":"","url":"https://api.github.com/users/MSeifert04","html_url":"https://github.com/MSeifert04","followers_url":"https://api.github.com/users/MSeifert04/followers","following_url":"https://api.github.com/users/MSeifert04/following{/other_user}","gists_url":"https://api.github.com/users/MSeifert04/gists{/gist_id}","starred_url":"https://api.github.com/users/MSeifert04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSeifert04/subscriptions","organizations_url":"https://api.github.com/users/MSeifert04/orgs","repos_url":"https://api.github.com/users/MSeifert04/repos","events_url":"https://api.github.com/users/MSeifert04/events{/privacy}","received_events_url":"https://api.github.com/users/MSeifert04/received_events","type":"User","site_admin":false},"body":"These are just some things I have been changing on my local computer to get some more functionality out of NDDataBase and it's subclasses. This is not very complete (I haven't touched NDArithmeticMixin as much as I wanted so most of the tests will break for the latest commits) but I am still working on it.\r\n\r\nIn the next days I can provide some more information (if wanted) for now this is just to get some feedback if that kind of refactoring would be appreciated or not (there are some API changes in there but I tried to keep them low). Unfortunatly I have forgotten the skip ci on some of the commits but since these are very few I hope that's not too bad.\r\n\r\nI hope it is ok to just create a PR for such a large change.","created_at":"2015-10-10T18:07:05Z","updated_at":"2015-10-13T14:30:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7175f06c12a64b008648dddb90d6811130a2823","assignee":{"login":"mwcraig","id":1147167,"avatar_url":"https://avatars.githubusercontent.com/u/1147167?v=3","gravatar_id":"","url":"https://api.github.com/users/mwcraig","html_url":"https://github.com/mwcraig","followers_url":"https://api.github.com/users/mwcraig/followers","following_url":"https://api.github.com/users/mwcraig/following{/other_user}","gists_url":"https://api.github.com/users/mwcraig/gists{/gist_id}","starred_url":"https://api.github.com/users/mwcraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwcraig/subscriptions","organizations_url":"https://api.github.com/users/mwcraig/orgs","repos_url":"https://api.github.com/users/mwcraig/repos","events_url":"https://api.github.com/users/mwcraig/events{/privacy}","received_events_url":"https://api.github.com/users/mwcraig/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/4234/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/4234/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/4234/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/3e9b8fa1188cde45057fd1579f114eb3163bbdd7","head":{"label":"MSeifert04:nddata_several_fixes","ref":"nddata_several_fixes","sha":"3e9b8fa1188cde45057fd1579f114eb3163bbdd7","user":{"login":"MSeifert04","id":14200878,"avatar_url":"https://avatars.githubusercontent.com/u/14200878?v=3","gravatar_id":"","url":"https://api.github.com/users/MSeifert04","html_url":"https://github.com/MSeifert04","followers_url":"https://api.github.com/users/MSeifert04/followers","following_url":"https://api.github.com/users/MSeifert04/following{/other_user}","gists_url":"https://api.github.com/users/MSeifert04/gists{/gist_id}","starred_url":"https://api.github.com/users/MSeifert04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSeifert04/subscriptions","organizations_url":"https://api.github.com/users/MSeifert04/orgs","repos_url":"https://api.github.com/users/MSeifert04/repos","events_url":"https://api.github.com/users/MSeifert04/events{/privacy}","received_events_url":"https://api.github.com/users/MSeifert04/received_events","type":"User","site_admin":false},"repo":{"id":42801766,"name":"astropy","full_name":"MSeifert04/astropy","owner":{"login":"MSeifert04","id":14200878,"avatar_url":"https://avatars.githubusercontent.com/u/14200878?v=3","gravatar_id":"","url":"https://api.github.com/users/MSeifert04","html_url":"https://github.com/MSeifert04","followers_url":"https://api.github.com/users/MSeifert04/followers","following_url":"https://api.github.com/users/MSeifert04/following{/other_user}","gists_url":"https://api.github.com/users/MSeifert04/gists{/gist_id}","starred_url":"https://api.github.com/users/MSeifert04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSeifert04/subscriptions","organizations_url":"https://api.github.com/users/MSeifert04/orgs","repos_url":"https://api.github.com/users/MSeifert04/repos","events_url":"https://api.github.com/users/MSeifert04/events{/privacy}","received_events_url":"https://api.github.com/users/MSeifert04/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MSeifert04/astropy","description":"Repository for the Astropy core package","fork":true,"url":"https://api.github.com/repos/MSeifert04/astropy","forks_url":"https://api.github.com/repos/MSeifert04/astropy/forks","keys_url":"https://api.github.com/repos/MSeifert04/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MSeifert04/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MSeifert04/astropy/teams","hooks_url":"https://api.github.com/repos/MSeifert04/astropy/hooks","issue_events_url":"https://api.github.com/repos/MSeifert04/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/MSeifert04/astropy/events","assignees_url":"https://api.github.com/repos/MSeifert04/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/MSeifert04/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/MSeifert04/astropy/tags","blobs_url":"https://api.github.com/repos/MSeifert04/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MSeifert04/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MSeifert04/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/MSeifert04/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MSeifert04/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/MSeifert04/astropy/languages","stargazers_url":"https://api.github.com/repos/MSeifert04/astropy/stargazers","contributors_url":"https://api.github.com/repos/MSeifert04/astropy/contributors","subscribers_url":"https://api.github.com/repos/MSeifert04/astropy/subscribers","subscription_url":"https://api.github.com/repos/MSeifert04/astropy/subscription","commits_url":"https://api.github.com/repos/MSeifert04/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/MSeifert04/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/MSeifert04/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/MSeifert04/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/MSeifert04/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/MSeifert04/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MSeifert04/astropy/merges","archive_url":"https://api.github.com/repos/MSeifert04/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MSeifert04/astropy/downloads","issues_url":"https://api.github.com/repos/MSeifert04/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/MSeifert04/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/MSeifert04/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/MSeifert04/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MSeifert04/astropy/labels{/name}","releases_url":"https://api.github.com/repos/MSeifert04/astropy/releases{/id}","created_at":"2015-09-20T05:43:07Z","updated_at":"2015-09-20T05:43:16Z","pushed_at":"2015-10-13T06:02:02Z","git_url":"git://github.com/MSeifert04/astropy.git","ssh_url":"git@github.com:MSeifert04/astropy.git","clone_url":"https://github.com/MSeifert04/astropy.git","svn_url":"https://github.com/MSeifert04/astropy","homepage":"www.astropy.org","size":40758,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"37b53fbdb3a611cfa68191055ea4e67e46cb4ebe","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","created_at":"2011-07-21T01:33:49Z","updated_at":"2015-10-12T21:45:55Z","pushed_at":"2015-10-13T14:28:51Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":67997,"stargazers_count":676,"watchers_count":676,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":437,"mirror_url":null,"open_issues_count":595,"forks":437,"open_issues":595,"watchers":676,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4234"},"html":{"href":"https://github.com/astropy/astropy/pull/4234"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/4234"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/4234/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4234/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4234/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/3e9b8fa1188cde45057fd1579f114eb3163bbdd7"}}}}