{"push_id":579617015,"size":3,"distinct_size":3,"ref":"refs/heads/no_port_conflict","head":"cb80134bf3ea4e0d8a7e09f8d868470b29da5842","before":"e4e68e2fa5a94c0a325ad74959594c8244a5fba5","commits":[{"sha":"2c3045504882fab11326ec2e56173e67997b8726","author":{"email":"cff910f56e4f0c6cc1915bb07d447f6bbf4e6414@google.com","name":"Daniel Smith"},"message":"fix docs","distinct":true,"url":"https://api.github.com/repos/erictune/kubernetes/commits/2c3045504882fab11326ec2e56173e67997b8726"},{"sha":"d2cf55e1a8d7fb6b966e71d9942b962bc2ae167d","author":{"email":"cff910f56e4f0c6cc1915bb07d447f6bbf4e6414@google.com","name":"Daniel Smith"},"message":"Merge pull request #4617 from lavalamp/fix4\n\nfix docs","distinct":true,"url":"https://api.github.com/repos/erictune/kubernetes/commits/d2cf55e1a8d7fb6b966e71d9942b962bc2ae167d"},{"sha":"cb80134bf3ea4e0d8a7e09f8d868470b29da5842","author":{"email":"eb0e322e74060bb4753a9f4aec9333246612275c@google.com","name":"Eric Tune"},"message":"Remove HostPort conflict checking.\n\nWe decided to get rid of boundPods.   Removing this check is\na prerequisite for that.  This check had some value before we had\nIP-per-Pod.  However, AIUI, use of HostPort is strongly discouraged\nin Kubernetes.  It still exists as part of a Pod spec because\nof ContainerVM, where it is used.  But, this change does not affect\nContainerVM, where there is no master.\n\nIf someone did create pods with HostPort using kubernetes, the following\nwould happen:\n  - The scheduler would try not to put two conflicting pods on the same\n    machine (pkg/scheduler/predicates.go : PodFitsPorts() )\n  - I'm not sure if it is currently possible for a race to occur where\n    the PodFitsPorts check were bypassed.   Maybe it could happen.\n  - If the kubelet was sent conflicting pods, it would detect them in\n    ( pkg/kubelet/kubelet.go :  filterHostPortConflicts() ).  It would\n    arbitrarily pick one pod to run and another to ignore.\n  - If all of the above happened and the user filed and issue on github,\n    we might figure out that the user used HostPort and tell the user to stop.\n\nTODO:\n - e2e test\n - Several of the demos in examples/ use hostPort.  Change them to\n   not specify hostPort and have a service instead.","distinct":true,"url":"https://api.github.com/repos/erictune/kubernetes/commits/cb80134bf3ea4e0d8a7e09f8d868470b29da5842"}]}