{"action":"closed","number":22,"pull_request":{"url":"https://api.github.com/repos/erikdstock/juke-pro/pulls/22","id":53078605,"html_url":"https://github.com/erikdstock/juke-pro/pull/22","diff_url":"https://github.com/erikdstock/juke-pro/pull/22.diff","patch_url":"https://github.com/erikdstock/juke-pro/pull/22.patch","issue_url":"https://api.github.com/repos/erikdstock/juke-pro/issues/22","number":22,"state":"closed","locked":false,"title":"Create jukeboxes","user":{"login":"erikdstock","id":9088720,"avatar_url":"https://avatars.githubusercontent.com/u/9088720?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdstock","html_url":"https://github.com/erikdstock","followers_url":"https://api.github.com/users/erikdstock/followers","following_url":"https://api.github.com/users/erikdstock/following{/other_user}","gists_url":"https://api.github.com/users/erikdstock/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdstock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdstock/subscriptions","organizations_url":"https://api.github.com/users/erikdstock/orgs","repos_url":"https://api.github.com/users/erikdstock/repos","events_url":"https://api.github.com/users/erikdstock/events{/privacy}","received_events_url":"https://api.github.com/users/erikdstock/received_events","type":"User","site_admin":false},"body":"fixed stubs. not totally happy with it, but the crux of the issue was that I was trying to load entire hashes into erb yaml (the spotify_hash via rspotify stub helpers module in testing)- trying to inject that into the yaml was causing havoc, and it's just a limitation I think of our current way of setting this up with activerecord models that mirror rspotify api models... for lack of a better way to put it.\r\n\r\nthoughtbot gives one alternative which is to stub out your external services using a separate gem, so we could make api calls and just specify what we will return in test helpers. I actually think this would be better:\r\nhttps://robots.thoughtbot.com/how-to-stub-external-services-in-tests\r\n\r\nthus we don't have to stub out the innerworkings of rspotify (the gem itself tests against real-world users and playlists) but just specify a few standard api responses.\r\n\r\nespecially as we move into track listings and such that might become more of an issue.","created_at":"2015-12-09T05:34:53Z","updated_at":"2015-12-09T13:26:49Z","closed_at":"2015-12-09T13:26:49Z","merged_at":"2015-12-09T13:26:49Z","merge_commit_sha":"6e534ba442205cedd1f336ae98f42ca2e393370d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/erikdstock/juke-pro/pulls/22/commits","review_comments_url":"https://api.github.com/repos/erikdstock/juke-pro/pulls/22/comments","review_comment_url":"https://api.github.com/repos/erikdstock/juke-pro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/erikdstock/juke-pro/issues/22/comments","statuses_url":"https://api.github.com/repos/erikdstock/juke-pro/statuses/94afb0af79dcc73426ebd226ec8127c9d6e3eef8","head":{"label":"erikdstock:create-jukeboxes","ref":"create-jukeboxes","sha":"94afb0af79dcc73426ebd226ec8127c9d6e3eef8","user":{"login":"erikdstock","id":9088720,"avatar_url":"https://avatars.githubusercontent.com/u/9088720?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdstock","html_url":"https://github.com/erikdstock","followers_url":"https://api.github.com/users/erikdstock/followers","following_url":"https://api.github.com/users/erikdstock/following{/other_user}","gists_url":"https://api.github.com/users/erikdstock/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdstock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdstock/subscriptions","organizations_url":"https://api.github.com/users/erikdstock/orgs","repos_url":"https://api.github.com/users/erikdstock/repos","events_url":"https://api.github.com/users/erikdstock/events{/privacy}","received_events_url":"https://api.github.com/users/erikdstock/received_events","type":"User","site_admin":false},"repo":{"id":44285904,"name":"juke-pro","full_name":"erikdstock/juke-pro","owner":{"login":"erikdstock","id":9088720,"avatar_url":"https://avatars.githubusercontent.com/u/9088720?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdstock","html_url":"https://github.com/erikdstock","followers_url":"https://api.github.com/users/erikdstock/followers","following_url":"https://api.github.com/users/erikdstock/following{/other_user}","gists_url":"https://api.github.com/users/erikdstock/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdstock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdstock/subscriptions","organizations_url":"https://api.github.com/users/erikdstock/orgs","repos_url":"https://api.github.com/users/erikdstock/repos","events_url":"https://api.github.com/users/erikdstock/events{/privacy}","received_events_url":"https://api.github.com/users/erikdstock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikdstock/juke-pro","description":"","fork":false,"url":"https://api.github.com/repos/erikdstock/juke-pro","forks_url":"https://api.github.com/repos/erikdstock/juke-pro/forks","keys_url":"https://api.github.com/repos/erikdstock/juke-pro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikdstock/juke-pro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikdstock/juke-pro/teams","hooks_url":"https://api.github.com/repos/erikdstock/juke-pro/hooks","issue_events_url":"https://api.github.com/repos/erikdstock/juke-pro/issues/events{/number}","events_url":"https://api.github.com/repos/erikdstock/juke-pro/events","assignees_url":"https://api.github.com/repos/erikdstock/juke-pro/assignees{/user}","branches_url":"https://api.github.com/repos/erikdstock/juke-pro/branches{/branch}","tags_url":"https://api.github.com/repos/erikdstock/juke-pro/tags","blobs_url":"https://api.github.com/repos/erikdstock/juke-pro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikdstock/juke-pro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikdstock/juke-pro/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikdstock/juke-pro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikdstock/juke-pro/statuses/{sha}","languages_url":"https://api.github.com/repos/erikdstock/juke-pro/languages","stargazers_url":"https://api.github.com/repos/erikdstock/juke-pro/stargazers","contributors_url":"https://api.github.com/repos/erikdstock/juke-pro/contributors","subscribers_url":"https://api.github.com/repos/erikdstock/juke-pro/subscribers","subscription_url":"https://api.github.com/repos/erikdstock/juke-pro/subscription","commits_url":"https://api.github.com/repos/erikdstock/juke-pro/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikdstock/juke-pro/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikdstock/juke-pro/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikdstock/juke-pro/issues/comments{/number}","contents_url":"https://api.github.com/repos/erikdstock/juke-pro/contents/{+path}","compare_url":"https://api.github.com/repos/erikdstock/juke-pro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikdstock/juke-pro/merges","archive_url":"https://api.github.com/repos/erikdstock/juke-pro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikdstock/juke-pro/downloads","issues_url":"https://api.github.com/repos/erikdstock/juke-pro/issues{/number}","pulls_url":"https://api.github.com/repos/erikdstock/juke-pro/pulls{/number}","milestones_url":"https://api.github.com/repos/erikdstock/juke-pro/milestones{/number}","notifications_url":"https://api.github.com/repos/erikdstock/juke-pro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikdstock/juke-pro/labels{/name}","releases_url":"https://api.github.com/repos/erikdstock/juke-pro/releases{/id}","created_at":"2015-10-15T01:17:41Z","updated_at":"2015-10-15T01:33:00Z","pushed_at":"2015-12-09T13:26:49Z","git_url":"git://github.com/erikdstock/juke-pro.git","ssh_url":"git@github.com:erikdstock/juke-pro.git","clone_url":"https://github.com/erikdstock/juke-pro.git","svn_url":"https://github.com/erikdstock/juke-pro","homepage":null,"size":103,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"erikdstock:master","ref":"master","sha":"0cd1a7cd838ceb36d0d38d3ab84097d92d30a6aa","user":{"login":"erikdstock","id":9088720,"avatar_url":"https://avatars.githubusercontent.com/u/9088720?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdstock","html_url":"https://github.com/erikdstock","followers_url":"https://api.github.com/users/erikdstock/followers","following_url":"https://api.github.com/users/erikdstock/following{/other_user}","gists_url":"https://api.github.com/users/erikdstock/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdstock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdstock/subscriptions","organizations_url":"https://api.github.com/users/erikdstock/orgs","repos_url":"https://api.github.com/users/erikdstock/repos","events_url":"https://api.github.com/users/erikdstock/events{/privacy}","received_events_url":"https://api.github.com/users/erikdstock/received_events","type":"User","site_admin":false},"repo":{"id":44285904,"name":"juke-pro","full_name":"erikdstock/juke-pro","owner":{"login":"erikdstock","id":9088720,"avatar_url":"https://avatars.githubusercontent.com/u/9088720?v=3","gravatar_id":"","url":"https://api.github.com/users/erikdstock","html_url":"https://github.com/erikdstock","followers_url":"https://api.github.com/users/erikdstock/followers","following_url":"https://api.github.com/users/erikdstock/following{/other_user}","gists_url":"https://api.github.com/users/erikdstock/gists{/gist_id}","starred_url":"https://api.github.com/users/erikdstock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikdstock/subscriptions","organizations_url":"https://api.github.com/users/erikdstock/orgs","repos_url":"https://api.github.com/users/erikdstock/repos","events_url":"https://api.github.com/users/erikdstock/events{/privacy}","received_events_url":"https://api.github.com/users/erikdstock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikdstock/juke-pro","description":"","fork":false,"url":"https://api.github.com/repos/erikdstock/juke-pro","forks_url":"https://api.github.com/repos/erikdstock/juke-pro/forks","keys_url":"https://api.github.com/repos/erikdstock/juke-pro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikdstock/juke-pro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikdstock/juke-pro/teams","hooks_url":"https://api.github.com/repos/erikdstock/juke-pro/hooks","issue_events_url":"https://api.github.com/repos/erikdstock/juke-pro/issues/events{/number}","events_url":"https://api.github.com/repos/erikdstock/juke-pro/events","assignees_url":"https://api.github.com/repos/erikdstock/juke-pro/assignees{/user}","branches_url":"https://api.github.com/repos/erikdstock/juke-pro/branches{/branch}","tags_url":"https://api.github.com/repos/erikdstock/juke-pro/tags","blobs_url":"https://api.github.com/repos/erikdstock/juke-pro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikdstock/juke-pro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikdstock/juke-pro/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikdstock/juke-pro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikdstock/juke-pro/statuses/{sha}","languages_url":"https://api.github.com/repos/erikdstock/juke-pro/languages","stargazers_url":"https://api.github.com/repos/erikdstock/juke-pro/stargazers","contributors_url":"https://api.github.com/repos/erikdstock/juke-pro/contributors","subscribers_url":"https://api.github.com/repos/erikdstock/juke-pro/subscribers","subscription_url":"https://api.github.com/repos/erikdstock/juke-pro/subscription","commits_url":"https://api.github.com/repos/erikdstock/juke-pro/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikdstock/juke-pro/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikdstock/juke-pro/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikdstock/juke-pro/issues/comments{/number}","contents_url":"https://api.github.com/repos/erikdstock/juke-pro/contents/{+path}","compare_url":"https://api.github.com/repos/erikdstock/juke-pro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikdstock/juke-pro/merges","archive_url":"https://api.github.com/repos/erikdstock/juke-pro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikdstock/juke-pro/downloads","issues_url":"https://api.github.com/repos/erikdstock/juke-pro/issues{/number}","pulls_url":"https://api.github.com/repos/erikdstock/juke-pro/pulls{/number}","milestones_url":"https://api.github.com/repos/erikdstock/juke-pro/milestones{/number}","notifications_url":"https://api.github.com/repos/erikdstock/juke-pro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikdstock/juke-pro/labels{/name}","releases_url":"https://api.github.com/repos/erikdstock/juke-pro/releases{/id}","created_at":"2015-10-15T01:17:41Z","updated_at":"2015-10-15T01:33:00Z","pushed_at":"2015-12-09T13:26:49Z","git_url":"git://github.com/erikdstock/juke-pro.git","ssh_url":"git@github.com:erikdstock/juke-pro.git","clone_url":"https://github.com/erikdstock/juke-pro.git","svn_url":"https://github.com/erikdstock/juke-pro","homepage":null,"size":103,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/erikdstock/juke-pro/pulls/22"},"html":{"href":"https://github.com/erikdstock/juke-pro/pull/22"},"issue":{"href":"https://api.github.com/repos/erikdstock/juke-pro/issues/22"},"comments":{"href":"https://api.github.com/repos/erikdstock/juke-pro/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/erikdstock/juke-pro/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/erikdstock/juke-pro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/erikdstock/juke-pro/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/erikdstock/juke-pro/statuses/94afb0af79dcc73426ebd226ec8127c9d6e3eef8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"alexandergknoll","id":9630849,"avatar_url":"https://avatars.githubusercontent.com/u/9630849?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandergknoll","html_url":"https://github.com/alexandergknoll","followers_url":"https://api.github.com/users/alexandergknoll/followers","following_url":"https://api.github.com/users/alexandergknoll/following{/other_user}","gists_url":"https://api.github.com/users/alexandergknoll/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandergknoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandergknoll/subscriptions","organizations_url":"https://api.github.com/users/alexandergknoll/orgs","repos_url":"https://api.github.com/users/alexandergknoll/repos","events_url":"https://api.github.com/users/alexandergknoll/events{/privacy}","received_events_url":"https://api.github.com/users/alexandergknoll/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":7,"additions":115,"deletions":95,"changed_files":11}}