{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/31430688","id":31430688,"diff_hunk":"@@ -155,6 +156,15 @@\n     */\n    NotifyingFuture<Boolean> replaceWithVersionAsync(K key, V newValue, long version, int lifespanSeconds, int maxIdleSeconds);\n \n+   /**\n+    * Retrieve entries from the server\n+    *\n+    * @param filterConverterFactory Factory name for the KeyValueFilterConverter or null\n+    * @param segments               The segments to iterate on or null if all segments should be iterated\n+    * @param batchSize              The number of entries transferred from the server at a time\n+    * @return Iterator for the entries\n+    */\n+   CloseableIterator<Entry<Object, Object>> retrieveEntries(String filterConverterFactory, Set<Integer> segments, int batchSize);","path":"client/hotrod-client/src/main/java/org/infinispan/client/hotrod/RemoteCache.java","position":20,"original_position":20,"commit_id":"8286f31481121ea18a48eb468dde37fe6b95bc48","original_commit_id":"8286f31481121ea18a48eb468dde37fe6b95bc48","user":{"login":"wburns","id":648175,"avatar_url":"https://avatars.githubusercontent.com/u/648175?v=3","gravatar_id":"","url":"https://api.github.com/users/wburns","html_url":"https://github.com/wburns","followers_url":"https://api.github.com/users/wburns/followers","following_url":"https://api.github.com/users/wburns/following{/other_user}","gists_url":"https://api.github.com/users/wburns/gists{/gist_id}","starred_url":"https://api.github.com/users/wburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wburns/subscriptions","organizations_url":"https://api.github.com/users/wburns/orgs","repos_url":"https://api.github.com/users/wburns/repos","events_url":"https://api.github.com/users/wburns/events{/privacy}","received_events_url":"https://api.github.com/users/wburns/received_events","type":"User","site_admin":false},"body":"I don't think the client itself should ever care about how to map keys to segments.  We should be able to do that internally ourselves.  The client however may want to do some sort of partitioning, in which case doing this by segment is a very logical thing.\r\n\r\nIt seems what we really need are these methods somewhere:\r\n```\r\nSet<Integer> getSegments()\r\nMap<Address, Set<Integer>> getSegmentsByServer()\r\n```\r\n\r\nAnd then the RemoteCache would have the current method that @gustavonalle added.\r\n\r\nDo we want another one like getAll but instead returns an iterator?  Something like:\r\n\r\n```\r\nCloseableIterator<Entry<K, Object>> retrieveEntries(String filterConverterFactory, Set<? extends K> keys, int batchSize);\r\n```","created_at":"2015-06-01T14:35:17Z","updated_at":"2015-06-01T14:35:17Z","html_url":"https://github.com/infinispan/infinispan/pull/3511#discussion_r31430688","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3511","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/31430688"},"html":{"href":"https://github.com/infinispan/infinispan/pull/3511#discussion_r31430688"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3511"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/3511","id":36245725,"html_url":"https://github.com/infinispan/infinispan/pull/3511","diff_url":"https://github.com/infinispan/infinispan/pull/3511.diff","patch_url":"https://github.com/infinispan/infinispan/pull/3511.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/3511","number":3511,"state":"open","locked":false,"title":"ISPN-5219 Expose Distributed Iterators over HotRod","user":{"login":"gustavonalle","id":440989,"avatar_url":"https://avatars.githubusercontent.com/u/440989?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavonalle","html_url":"https://github.com/gustavonalle","followers_url":"https://api.github.com/users/gustavonalle/followers","following_url":"https://api.github.com/users/gustavonalle/following{/other_user}","gists_url":"https://api.github.com/users/gustavonalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavonalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavonalle/subscriptions","organizations_url":"https://api.github.com/users/gustavonalle/orgs","repos_url":"https://api.github.com/users/gustavonalle/repos","events_url":"https://api.github.com/users/gustavonalle/events{/privacy}","received_events_url":"https://api.github.com/users/gustavonalle/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/ISPN-5219\r\n\r\nImplementation following design at https://github.com/infinispan/infinispan/wiki/Remote-Iterator","created_at":"2015-05-26T21:07:41Z","updated_at":"2015-06-01T14:35:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab98a94c87f79843d3f2609a57b29fd393e94196","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3511/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/3511/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/3511/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/8286f31481121ea18a48eb468dde37fe6b95bc48","head":{"label":"gustavonalle:remote_iterator","ref":"remote_iterator","sha":"8286f31481121ea18a48eb468dde37fe6b95bc48","user":{"login":"gustavonalle","id":440989,"avatar_url":"https://avatars.githubusercontent.com/u/440989?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavonalle","html_url":"https://github.com/gustavonalle","followers_url":"https://api.github.com/users/gustavonalle/followers","following_url":"https://api.github.com/users/gustavonalle/following{/other_user}","gists_url":"https://api.github.com/users/gustavonalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavonalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavonalle/subscriptions","organizations_url":"https://api.github.com/users/gustavonalle/orgs","repos_url":"https://api.github.com/users/gustavonalle/repos","events_url":"https://api.github.com/users/gustavonalle/events{/privacy}","received_events_url":"https://api.github.com/users/gustavonalle/received_events","type":"User","site_admin":false},"repo":{"id":20231400,"name":"infinispan","full_name":"gustavonalle/infinispan","owner":{"login":"gustavonalle","id":440989,"avatar_url":"https://avatars.githubusercontent.com/u/440989?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavonalle","html_url":"https://github.com/gustavonalle","followers_url":"https://api.github.com/users/gustavonalle/followers","following_url":"https://api.github.com/users/gustavonalle/following{/other_user}","gists_url":"https://api.github.com/users/gustavonalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavonalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavonalle/subscriptions","organizations_url":"https://api.github.com/users/gustavonalle/orgs","repos_url":"https://api.github.com/users/gustavonalle/repos","events_url":"https://api.github.com/users/gustavonalle/events{/privacy}","received_events_url":"https://api.github.com/users/gustavonalle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gustavonalle/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/gustavonalle/infinispan","forks_url":"https://api.github.com/repos/gustavonalle/infinispan/forks","keys_url":"https://api.github.com/repos/gustavonalle/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gustavonalle/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gustavonalle/infinispan/teams","hooks_url":"https://api.github.com/repos/gustavonalle/infinispan/hooks","issue_events_url":"https://api.github.com/repos/gustavonalle/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/gustavonalle/infinispan/events","assignees_url":"https://api.github.com/repos/gustavonalle/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/gustavonalle/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/gustavonalle/infinispan/tags","blobs_url":"https://api.github.com/repos/gustavonalle/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gustavonalle/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gustavonalle/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/gustavonalle/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gustavonalle/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/gustavonalle/infinispan/languages","stargazers_url":"https://api.github.com/repos/gustavonalle/infinispan/stargazers","contributors_url":"https://api.github.com/repos/gustavonalle/infinispan/contributors","subscribers_url":"https://api.github.com/repos/gustavonalle/infinispan/subscribers","subscription_url":"https://api.github.com/repos/gustavonalle/infinispan/subscription","commits_url":"https://api.github.com/repos/gustavonalle/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/gustavonalle/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/gustavonalle/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/gustavonalle/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/gustavonalle/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/gustavonalle/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gustavonalle/infinispan/merges","archive_url":"https://api.github.com/repos/gustavonalle/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gustavonalle/infinispan/downloads","issues_url":"https://api.github.com/repos/gustavonalle/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/gustavonalle/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/gustavonalle/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/gustavonalle/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gustavonalle/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/gustavonalle/infinispan/releases{/id}","created_at":"2014-05-27T18:52:33Z","updated_at":"2015-05-06T08:02:25Z","pushed_at":"2015-05-27T19:12:12Z","git_url":"git://github.com/gustavonalle/infinispan.git","ssh_url":"git@github.com:gustavonalle/infinispan.git","clone_url":"https://github.com/gustavonalle/infinispan.git","svn_url":"https://github.com/gustavonalle/infinispan","homepage":"http://www.infinispan.org","size":67567,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"4a37550e36201d7ace60f82b412ff06d3b043bfe","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","created_at":"2010-11-04T12:33:19Z","updated_at":"2015-05-20T16:43:16Z","pushed_at":"2015-06-01T14:29:06Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":153561,"stargazers_count":381,"watchers_count":381,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":289,"mirror_url":null,"open_issues_count":13,"forks":289,"open_issues":13,"watchers":381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3511"},"html":{"href":"https://github.com/infinispan/infinispan/pull/3511"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/3511"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/3511/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3511/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/3511/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/8286f31481121ea18a48eb468dde37fe6b95bc48"}}}}