{"action":"created","issue":{"url":"https://api.github.com/repos/googlesamples/android-Camera2Video/issues/7","labels_url":"https://api.github.com/repos/googlesamples/android-Camera2Video/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/googlesamples/android-Camera2Video/issues/7/comments","events_url":"https://api.github.com/repos/googlesamples/android-Camera2Video/issues/7/events","html_url":"https://github.com/googlesamples/android-Camera2Video/issues/7","id":76550147,"number":7,"title":"Incorrect Video Size Limitation in ChooseVideoSize()?","user":{"login":"dathat","id":12453365,"avatar_url":"https://avatars.githubusercontent.com/u/12453365?v=3","gravatar_id":"","url":"https://api.github.com/users/dathat","html_url":"https://github.com/dathat","followers_url":"https://api.github.com/users/dathat/followers","following_url":"https://api.github.com/users/dathat/following{/other_user}","gists_url":"https://api.github.com/users/dathat/gists{/gist_id}","starred_url":"https://api.github.com/users/dathat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dathat/subscriptions","organizations_url":"https://api.github.com/users/dathat/orgs","repos_url":"https://api.github.com/users/dathat/repos","events_url":"https://api.github.com/users/dathat/events{/privacy}","received_events_url":"https://api.github.com/users/dathat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-15T01:31:32Z","updated_at":"2015-08-25T22:02:48Z","closed_at":null,"body":"Function specifies: \r\n* In this sample, we choose a video size with 3x4 aspect ratio. Also, we don't use sizes larger\r\n* than 1080p, since MediaRecorder cannot handle such a high-resolution video.\r\n\r\nShould this: \r\n\"if (size.getWidth() == size.getHeight() * 4 / 3 && size.getWidth() <= 1080)\"\r\n\r\nBe this (restrict height to 1080 instead of width)?:\r\n\"if (size.getWidth() == size.getHeight() * 4 / 3 && size.getHeight() <= 1080)\""},"comment":{"url":"https://api.github.com/repos/googlesamples/android-Camera2Video/issues/comments/134755612","html_url":"https://github.com/googlesamples/android-Camera2Video/issues/7#issuecomment-134755612","issue_url":"https://api.github.com/repos/googlesamples/android-Camera2Video/issues/7","id":134755612,"user":{"login":"kmturley","id":1710493,"avatar_url":"https://avatars.githubusercontent.com/u/1710493?v=3","gravatar_id":"","url":"https://api.github.com/users/kmturley","html_url":"https://github.com/kmturley","followers_url":"https://api.github.com/users/kmturley/followers","following_url":"https://api.github.com/users/kmturley/following{/other_user}","gists_url":"https://api.github.com/users/kmturley/gists{/gist_id}","starred_url":"https://api.github.com/users/kmturley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmturley/subscriptions","organizations_url":"https://api.github.com/users/kmturley/orgs","repos_url":"https://api.github.com/users/kmturley/repos","events_url":"https://api.github.com/users/kmturley/events{/privacy}","received_events_url":"https://api.github.com/users/kmturley/received_events","type":"User","site_admin":false},"created_at":"2015-08-25T22:02:48Z","updated_at":"2015-08-25T22:02:48Z","body":"I found another issues around:\r\n\r\nCamera2VideoFragment.java\r\nline 238\r\n\r\n    if (size.getWidth() == size.getHeight() * 16 / 9 && size.getHeight() <= 1080) {\r\n\r\nline 264\r\n\r\n    if (option.getHeight() == option.getWidth() * h / w && option.getWidth() <= width && option.getHeight() <= height) {\r\n\r\nThis ensures the camera is recording 16:9 HD video and the preview is also large but not too large that green lines appear on the display"}}