{"action":"reopened","number":4461,"pull_request":{"url":"https://api.github.com/repos/deis/deis/pulls/4461","id":44863357,"html_url":"https://github.com/deis/deis/pull/4461","diff_url":"https://github.com/deis/deis/pull/4461.diff","patch_url":"https://github.com/deis/deis/pull/4461.patch","issue_url":"https://api.github.com/repos/deis/deis/issues/4461","number":4461,"state":"open","locked":false,"title":"fix(controller): validate config keys at the api level","user":{"login":"benwilber","id":165319,"avatar_url":"https://avatars.githubusercontent.com/u/165319?v=3","gravatar_id":"","url":"https://api.github.com/users/benwilber","html_url":"https://github.com/benwilber","followers_url":"https://api.github.com/users/benwilber/followers","following_url":"https://api.github.com/users/benwilber/following{/other_user}","gists_url":"https://api.github.com/users/benwilber/gists{/gist_id}","starred_url":"https://api.github.com/users/benwilber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwilber/subscriptions","organizations_url":"https://api.github.com/users/benwilber/orgs","repos_url":"https://api.github.com/users/benwilber/repos","events_url":"https://api.github.com/users/benwilber/events{/privacy}","received_events_url":"https://api.github.com/users/benwilber/received_events","type":"User","site_admin":false},"body":"Config keys are currently only validated in the `deis` client.  By using the REST API directly it's possible to write invalid config keys, potentially overwriting other keys in `etcd`.","created_at":"2015-09-12T23:22:40Z","updated_at":"2015-09-15T01:21:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e23b06ddf8e424754ad525f8d92434e1d72053e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/deis/deis/pulls/4461/commits","review_comments_url":"https://api.github.com/repos/deis/deis/pulls/4461/comments","review_comment_url":"https://api.github.com/repos/deis/deis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deis/deis/issues/4461/comments","statuses_url":"https://api.github.com/repos/deis/deis/statuses/039456648f5271afa8e4957c975b06a494e45088","head":{"label":"benwilber:fix/validate-config-keys","ref":"fix/validate-config-keys","sha":"039456648f5271afa8e4957c975b06a494e45088","user":{"login":"benwilber","id":165319,"avatar_url":"https://avatars.githubusercontent.com/u/165319?v=3","gravatar_id":"","url":"https://api.github.com/users/benwilber","html_url":"https://github.com/benwilber","followers_url":"https://api.github.com/users/benwilber/followers","following_url":"https://api.github.com/users/benwilber/following{/other_user}","gists_url":"https://api.github.com/users/benwilber/gists{/gist_id}","starred_url":"https://api.github.com/users/benwilber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwilber/subscriptions","organizations_url":"https://api.github.com/users/benwilber/orgs","repos_url":"https://api.github.com/users/benwilber/repos","events_url":"https://api.github.com/users/benwilber/events{/privacy}","received_events_url":"https://api.github.com/users/benwilber/received_events","type":"User","site_admin":false},"repo":{"id":42206516,"name":"deis","full_name":"benwilber/deis","owner":{"login":"benwilber","id":165319,"avatar_url":"https://avatars.githubusercontent.com/u/165319?v=3","gravatar_id":"","url":"https://api.github.com/users/benwilber","html_url":"https://github.com/benwilber","followers_url":"https://api.github.com/users/benwilber/followers","following_url":"https://api.github.com/users/benwilber/following{/other_user}","gists_url":"https://api.github.com/users/benwilber/gists{/gist_id}","starred_url":"https://api.github.com/users/benwilber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwilber/subscriptions","organizations_url":"https://api.github.com/users/benwilber/orgs","repos_url":"https://api.github.com/users/benwilber/repos","events_url":"https://api.github.com/users/benwilber/events{/privacy}","received_events_url":"https://api.github.com/users/benwilber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benwilber/deis","description":"Your PaaS. Your Rules. ","fork":true,"url":"https://api.github.com/repos/benwilber/deis","forks_url":"https://api.github.com/repos/benwilber/deis/forks","keys_url":"https://api.github.com/repos/benwilber/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benwilber/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benwilber/deis/teams","hooks_url":"https://api.github.com/repos/benwilber/deis/hooks","issue_events_url":"https://api.github.com/repos/benwilber/deis/issues/events{/number}","events_url":"https://api.github.com/repos/benwilber/deis/events","assignees_url":"https://api.github.com/repos/benwilber/deis/assignees{/user}","branches_url":"https://api.github.com/repos/benwilber/deis/branches{/branch}","tags_url":"https://api.github.com/repos/benwilber/deis/tags","blobs_url":"https://api.github.com/repos/benwilber/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benwilber/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benwilber/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/benwilber/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benwilber/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/benwilber/deis/languages","stargazers_url":"https://api.github.com/repos/benwilber/deis/stargazers","contributors_url":"https://api.github.com/repos/benwilber/deis/contributors","subscribers_url":"https://api.github.com/repos/benwilber/deis/subscribers","subscription_url":"https://api.github.com/repos/benwilber/deis/subscription","commits_url":"https://api.github.com/repos/benwilber/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/benwilber/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/benwilber/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/benwilber/deis/issues/comments{/number}","contents_url":"https://api.github.com/repos/benwilber/deis/contents/{+path}","compare_url":"https://api.github.com/repos/benwilber/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benwilber/deis/merges","archive_url":"https://api.github.com/repos/benwilber/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benwilber/deis/downloads","issues_url":"https://api.github.com/repos/benwilber/deis/issues{/number}","pulls_url":"https://api.github.com/repos/benwilber/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/benwilber/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/benwilber/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benwilber/deis/labels{/name}","releases_url":"https://api.github.com/repos/benwilber/deis/releases{/id}","created_at":"2015-09-09T21:45:31Z","updated_at":"2015-09-09T21:45:33Z","pushed_at":"2015-09-13T00:32:06Z","git_url":"git://github.com/benwilber/deis.git","ssh_url":"git@github.com:benwilber/deis.git","clone_url":"https://github.com/benwilber/deis.git","svn_url":"https://github.com/benwilber/deis","homepage":"http://deis.io","size":18990,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"3838a0ad238baba12bc3128a8c8073431563cbc8","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":11589713,"name":"deis","full_name":"deis/deis","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/deis","description":"Your PaaS. Your Rules. ","fork":false,"url":"https://api.github.com/repos/deis/deis","forks_url":"https://api.github.com/repos/deis/deis/forks","keys_url":"https://api.github.com/repos/deis/deis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/deis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/deis/teams","hooks_url":"https://api.github.com/repos/deis/deis/hooks","issue_events_url":"https://api.github.com/repos/deis/deis/issues/events{/number}","events_url":"https://api.github.com/repos/deis/deis/events","assignees_url":"https://api.github.com/repos/deis/deis/assignees{/user}","branches_url":"https://api.github.com/repos/deis/deis/branches{/branch}","tags_url":"https://api.github.com/repos/deis/deis/tags","blobs_url":"https://api.github.com/repos/deis/deis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/deis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/deis/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/deis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/deis/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/deis/languages","stargazers_url":"https://api.github.com/repos/deis/deis/stargazers","contributors_url":"https://api.github.com/repos/deis/deis/contributors","subscribers_url":"https://api.github.com/repos/deis/deis/subscribers","subscription_url":"https://api.github.com/repos/deis/deis/subscription","commits_url":"https://api.github.com/repos/deis/deis/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/deis/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/deis/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/deis/issues/comments{/number}","contents_url":"https://api.github.com/repos/deis/deis/contents/{+path}","compare_url":"https://api.github.com/repos/deis/deis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/deis/merges","archive_url":"https://api.github.com/repos/deis/deis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/deis/downloads","issues_url":"https://api.github.com/repos/deis/deis/issues{/number}","pulls_url":"https://api.github.com/repos/deis/deis/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/deis/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/deis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/deis/labels{/name}","releases_url":"https://api.github.com/repos/deis/deis/releases{/id}","created_at":"2013-07-22T19:02:40Z","updated_at":"2015-09-14T22:20:01Z","pushed_at":"2015-09-15T01:16:05Z","git_url":"git://github.com/deis/deis.git","ssh_url":"git@github.com:deis/deis.git","clone_url":"https://github.com/deis/deis.git","svn_url":"https://github.com/deis/deis","homepage":"http://deis.io","size":44638,"stargazers_count":4721,"watchers_count":4721,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":743,"mirror_url":null,"open_issues_count":279,"forks":743,"open_issues":279,"watchers":4721,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/deis/pulls/4461"},"html":{"href":"https://github.com/deis/deis/pull/4461"},"issue":{"href":"https://api.github.com/repos/deis/deis/issues/4461"},"comments":{"href":"https://api.github.com/repos/deis/deis/issues/4461/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/deis/pulls/4461/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/deis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deis/deis/pulls/4461/commits"},"statuses":{"href":"https://api.github.com/repos/deis/deis/statuses/039456648f5271afa8e4957c975b06a494e45088"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":0,"commits":3,"additions":44,"deletions":0,"changed_files":2}}