{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/zopefoundation/zodbpickle/pulls/12","id":32417136,"html_url":"https://github.com/zopefoundation/zodbpickle/pull/12","diff_url":"https://github.com/zopefoundation/zodbpickle/pull/12.diff","patch_url":"https://github.com/zopefoundation/zodbpickle/pull/12.patch","issue_url":"https://api.github.com/repos/zopefoundation/zodbpickle/issues/12","number":12,"state":"closed","locked":false,"title":"Restore `noload` to its Python 2.6 functionality and provide it for PyPy","user":{"login":"jamadden","id":1256082,"avatar_url":"https://avatars.githubusercontent.com/u/1256082?v=3","gravatar_id":"","url":"https://api.github.com/users/jamadden","html_url":"https://github.com/jamadden","followers_url":"https://api.github.com/users/jamadden/followers","following_url":"https://api.github.com/users/jamadden/following{/other_user}","gists_url":"https://api.github.com/users/jamadden/gists{/gist_id}","starred_url":"https://api.github.com/users/jamadden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamadden/subscriptions","organizations_url":"https://api.github.com/users/jamadden/orgs","repos_url":"https://api.github.com/users/jamadden/repos","events_url":"https://api.github.com/users/jamadden/events{/privacy}","received_events_url":"https://api.github.com/users/jamadden/received_events","type":"User","site_admin":false},"body":"As described in #9, `noload` was broken by the fix to [Python bug 1101399]( http://bugs.python.org/issue1101399), which was merged into Python 2.7. This in turn breaks code such as `zc.zodbdgc`. \r\n\r\nThis PR makes `noload` return to its 2.6 roots, but keeps the bug fix from upstream: intrinsic objects are loaded and populated, but subclasses of them are ignored.\r\n\r\nFurthermore, because `noload` was only implemented in C for Python 2, it couldn't be used from PyPy, so it also adds `noload` to the Python implementation for Python 2.\r\n\r\nThe Python developers seem to consider 'noload' an undocumented extension, and it seems to be removed in Python 3 anyway, so to me it seems that diverging on the behaviour is probably okay.\r\n\r\nI tested under Python 2.6, 2.7, 3.2 and 3.3, along with PyPy 2.5.1. (The tests are broken under Python 3.4, I'll try to submit another PR that adds support for 3.4 later.)","created_at":"2015-04-01T13:11:18Z","updated_at":"2015-04-02T13:02:42Z","closed_at":"2015-04-02T13:02:42Z","merged_at":"2015-04-02T13:02:42Z","merge_commit_sha":"7bae3cbd5f8886d72fe8cb588c4af1d3c029b546","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zopefoundation/zodbpickle/pulls/12/commits","review_comments_url":"https://api.github.com/repos/zopefoundation/zodbpickle/pulls/12/comments","review_comment_url":"https://api.github.com/repos/zopefoundation/zodbpickle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zopefoundation/zodbpickle/issues/12/comments","statuses_url":"https://api.github.com/repos/zopefoundation/zodbpickle/statuses/578ac70d7f95cddafa93a6441f0f70c4c6e440c1","head":{"label":"NextThought:noload","ref":"noload","sha":"578ac70d7f95cddafa93a6441f0f70c4c6e440c1","user":{"login":"NextThought","id":2072248,"avatar_url":"https://avatars.githubusercontent.com/u/2072248?v=3","gravatar_id":"","url":"https://api.github.com/users/NextThought","html_url":"https://github.com/NextThought","followers_url":"https://api.github.com/users/NextThought/followers","following_url":"https://api.github.com/users/NextThought/following{/other_user}","gists_url":"https://api.github.com/users/NextThought/gists{/gist_id}","starred_url":"https://api.github.com/users/NextThought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NextThought/subscriptions","organizations_url":"https://api.github.com/users/NextThought/orgs","repos_url":"https://api.github.com/users/NextThought/repos","events_url":"https://api.github.com/users/NextThought/events{/privacy}","received_events_url":"https://api.github.com/users/NextThought/received_events","type":"Organization","site_admin":false},"repo":{"id":33010706,"name":"zodbpickle","full_name":"NextThought/zodbpickle","owner":{"login":"NextThought","id":2072248,"avatar_url":"https://avatars.githubusercontent.com/u/2072248?v=3","gravatar_id":"","url":"https://api.github.com/users/NextThought","html_url":"https://github.com/NextThought","followers_url":"https://api.github.com/users/NextThought/followers","following_url":"https://api.github.com/users/NextThought/following{/other_user}","gists_url":"https://api.github.com/users/NextThought/gists{/gist_id}","starred_url":"https://api.github.com/users/NextThought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NextThought/subscriptions","organizations_url":"https://api.github.com/users/NextThought/orgs","repos_url":"https://api.github.com/users/NextThought/repos","events_url":"https://api.github.com/users/NextThought/events{/privacy}","received_events_url":"https://api.github.com/users/NextThought/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NextThought/zodbpickle","description":"Fork of Python's pickle module to work with ZODB","fork":true,"url":"https://api.github.com/repos/NextThought/zodbpickle","forks_url":"https://api.github.com/repos/NextThought/zodbpickle/forks","keys_url":"https://api.github.com/repos/NextThought/zodbpickle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NextThought/zodbpickle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NextThought/zodbpickle/teams","hooks_url":"https://api.github.com/repos/NextThought/zodbpickle/hooks","issue_events_url":"https://api.github.com/repos/NextThought/zodbpickle/issues/events{/number}","events_url":"https://api.github.com/repos/NextThought/zodbpickle/events","assignees_url":"https://api.github.com/repos/NextThought/zodbpickle/assignees{/user}","branches_url":"https://api.github.com/repos/NextThought/zodbpickle/branches{/branch}","tags_url":"https://api.github.com/repos/NextThought/zodbpickle/tags","blobs_url":"https://api.github.com/repos/NextThought/zodbpickle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NextThought/zodbpickle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NextThought/zodbpickle/git/refs{/sha}","trees_url":"https://api.github.com/repos/NextThought/zodbpickle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NextThought/zodbpickle/statuses/{sha}","languages_url":"https://api.github.com/repos/NextThought/zodbpickle/languages","stargazers_url":"https://api.github.com/repos/NextThought/zodbpickle/stargazers","contributors_url":"https://api.github.com/repos/NextThought/zodbpickle/contributors","subscribers_url":"https://api.github.com/repos/NextThought/zodbpickle/subscribers","subscription_url":"https://api.github.com/repos/NextThought/zodbpickle/subscription","commits_url":"https://api.github.com/repos/NextThought/zodbpickle/commits{/sha}","git_commits_url":"https://api.github.com/repos/NextThought/zodbpickle/git/commits{/sha}","comments_url":"https://api.github.com/repos/NextThought/zodbpickle/comments{/number}","issue_comment_url":"https://api.github.com/repos/NextThought/zodbpickle/issues/comments{/number}","contents_url":"https://api.github.com/repos/NextThought/zodbpickle/contents/{+path}","compare_url":"https://api.github.com/repos/NextThought/zodbpickle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NextThought/zodbpickle/merges","archive_url":"https://api.github.com/repos/NextThought/zodbpickle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NextThought/zodbpickle/downloads","issues_url":"https://api.github.com/repos/NextThought/zodbpickle/issues{/number}","pulls_url":"https://api.github.com/repos/NextThought/zodbpickle/pulls{/number}","milestones_url":"https://api.github.com/repos/NextThought/zodbpickle/milestones{/number}","notifications_url":"https://api.github.com/repos/NextThought/zodbpickle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NextThought/zodbpickle/labels{/name}","releases_url":"https://api.github.com/repos/NextThought/zodbpickle/releases{/id}","created_at":"2015-03-27T21:49:31Z","updated_at":"2015-03-27T21:49:32Z","pushed_at":"2015-04-01T14:22:43Z","git_url":"git://github.com/NextThought/zodbpickle.git","ssh_url":"git@github.com:NextThought/zodbpickle.git","clone_url":"https://github.com/NextThought/zodbpickle.git","svn_url":"https://github.com/NextThought/zodbpickle","homepage":null,"size":309,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zopefoundation:master","ref":"master","sha":"3df9479b527f5a2d1e35f9dd64367152799acc81","user":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars.githubusercontent.com/u/1163184?v=3","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":8208647,"name":"zodbpickle","full_name":"zopefoundation/zodbpickle","owner":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars.githubusercontent.com/u/1163184?v=3","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zopefoundation/zodbpickle","description":"Fork of Python's pickle module to work with ZODB","fork":false,"url":"https://api.github.com/repos/zopefoundation/zodbpickle","forks_url":"https://api.github.com/repos/zopefoundation/zodbpickle/forks","keys_url":"https://api.github.com/repos/zopefoundation/zodbpickle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zopefoundation/zodbpickle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zopefoundation/zodbpickle/teams","hooks_url":"https://api.github.com/repos/zopefoundation/zodbpickle/hooks","issue_events_url":"https://api.github.com/repos/zopefoundation/zodbpickle/issues/events{/number}","events_url":"https://api.github.com/repos/zopefoundation/zodbpickle/events","assignees_url":"https://api.github.com/repos/zopefoundation/zodbpickle/assignees{/user}","branches_url":"https://api.github.com/repos/zopefoundation/zodbpickle/branches{/branch}","tags_url":"https://api.github.com/repos/zopefoundation/zodbpickle/tags","blobs_url":"https://api.github.com/repos/zopefoundation/zodbpickle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zopefoundation/zodbpickle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zopefoundation/zodbpickle/git/refs{/sha}","trees_url":"https://api.github.com/repos/zopefoundation/zodbpickle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zopefoundation/zodbpickle/statuses/{sha}","languages_url":"https://api.github.com/repos/zopefoundation/zodbpickle/languages","stargazers_url":"https://api.github.com/repos/zopefoundation/zodbpickle/stargazers","contributors_url":"https://api.github.com/repos/zopefoundation/zodbpickle/contributors","subscribers_url":"https://api.github.com/repos/zopefoundation/zodbpickle/subscribers","subscription_url":"https://api.github.com/repos/zopefoundation/zodbpickle/subscription","commits_url":"https://api.github.com/repos/zopefoundation/zodbpickle/commits{/sha}","git_commits_url":"https://api.github.com/repos/zopefoundation/zodbpickle/git/commits{/sha}","comments_url":"https://api.github.com/repos/zopefoundation/zodbpickle/comments{/number}","issue_comment_url":"https://api.github.com/repos/zopefoundation/zodbpickle/issues/comments{/number}","contents_url":"https://api.github.com/repos/zopefoundation/zodbpickle/contents/{+path}","compare_url":"https://api.github.com/repos/zopefoundation/zodbpickle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zopefoundation/zodbpickle/merges","archive_url":"https://api.github.com/repos/zopefoundation/zodbpickle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zopefoundation/zodbpickle/downloads","issues_url":"https://api.github.com/repos/zopefoundation/zodbpickle/issues{/number}","pulls_url":"https://api.github.com/repos/zopefoundation/zodbpickle/pulls{/number}","milestones_url":"https://api.github.com/repos/zopefoundation/zodbpickle/milestones{/number}","notifications_url":"https://api.github.com/repos/zopefoundation/zodbpickle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zopefoundation/zodbpickle/labels{/name}","releases_url":"https://api.github.com/repos/zopefoundation/zodbpickle/releases{/id}","created_at":"2013-02-14T22:05:01Z","updated_at":"2015-04-02T13:02:42Z","pushed_at":"2015-04-02T13:02:42Z","git_url":"git://github.com/zopefoundation/zodbpickle.git","ssh_url":"git@github.com:zopefoundation/zodbpickle.git","clone_url":"https://github.com/zopefoundation/zodbpickle.git","svn_url":"https://github.com/zopefoundation/zodbpickle","homepage":null,"size":507,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zopefoundation/zodbpickle/pulls/12"},"html":{"href":"https://github.com/zopefoundation/zodbpickle/pull/12"},"issue":{"href":"https://api.github.com/repos/zopefoundation/zodbpickle/issues/12"},"comments":{"href":"https://api.github.com/repos/zopefoundation/zodbpickle/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/zopefoundation/zodbpickle/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/zopefoundation/zodbpickle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zopefoundation/zodbpickle/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/zopefoundation/zodbpickle/statuses/578ac70d7f95cddafa93a6441f0f70c4c6e440c1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":502,"deletions":57,"changed_files":10}}