{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/barseghyanartur/tld/pulls/6","id":45844727,"html_url":"https://github.com/barseghyanartur/tld/pull/6","diff_url":"https://github.com/barseghyanartur/tld/pull/6.diff","patch_url":"https://github.com/barseghyanartur/tld/pull/6.patch","issue_url":"https://api.github.com/repos/barseghyanartur/tld/issues/6","number":6,"state":"closed","locked":false,"title":"Exposed TLD initialization as `get_tld_names`","user":{"login":"twolfson","id":902488,"avatar_url":"https://avatars.githubusercontent.com/u/902488?v=3","gravatar_id":"","url":"https://api.github.com/users/twolfson","html_url":"https://github.com/twolfson","followers_url":"https://api.github.com/users/twolfson/followers","following_url":"https://api.github.com/users/twolfson/following{/other_user}","gists_url":"https://api.github.com/users/twolfson/gists{/gist_id}","starred_url":"https://api.github.com/users/twolfson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twolfson/subscriptions","organizations_url":"https://api.github.com/users/twolfson/orgs","repos_url":"https://api.github.com/users/twolfson/repos","events_url":"https://api.github.com/users/twolfson/events{/privacy}","received_events_url":"https://api.github.com/users/twolfson/received_events","type":"User","site_admin":false},"body":"We want to perform some custom string manipulation based on TLD's. In order to avoid hacks like eagerly running `get_tld('')`, we decided to expose the existing `init` function as a loader itself. In this PR:\r\n\r\n- Added `get_tld_names` function (originally known as `init`) to fetch set of `tld_names`\r\n\r\n**Notes:**\r\n\r\nThere are currently no tests for this functionality because:\r\n\r\n- The function is being utilized by higher level functions already\r\n- This is a personal request and might be outside of the scope of the project","created_at":"2015-09-23T23:37:28Z","updated_at":"2015-09-23T23:43:48Z","closed_at":"2015-09-23T23:43:48Z","merged_at":"2015-09-23T23:43:48Z","merge_commit_sha":"91bb848796a8ce3da7449ab68897312274804642","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/barseghyanartur/tld/pulls/6/commits","review_comments_url":"https://api.github.com/repos/barseghyanartur/tld/pulls/6/comments","review_comment_url":"https://api.github.com/repos/barseghyanartur/tld/pulls/comments{/number}","comments_url":"https://api.github.com/repos/barseghyanartur/tld/issues/6/comments","statuses_url":"https://api.github.com/repos/barseghyanartur/tld/statuses/ceadc486acb6c4dcaa51b397b03186d191b39588","head":{"label":"underdogio:dev/expose.tld.list.sqwished","ref":"dev/expose.tld.list.sqwished","sha":"ceadc486acb6c4dcaa51b397b03186d191b39588","user":{"login":"underdogio","id":7798128,"avatar_url":"https://avatars.githubusercontent.com/u/7798128?v=3","gravatar_id":"","url":"https://api.github.com/users/underdogio","html_url":"https://github.com/underdogio","followers_url":"https://api.github.com/users/underdogio/followers","following_url":"https://api.github.com/users/underdogio/following{/other_user}","gists_url":"https://api.github.com/users/underdogio/gists{/gist_id}","starred_url":"https://api.github.com/users/underdogio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/underdogio/subscriptions","organizations_url":"https://api.github.com/users/underdogio/orgs","repos_url":"https://api.github.com/users/underdogio/repos","events_url":"https://api.github.com/users/underdogio/events{/privacy}","received_events_url":"https://api.github.com/users/underdogio/received_events","type":"Organization","site_admin":false},"repo":{"id":43032647,"name":"tld","full_name":"underdogio/tld","owner":{"login":"underdogio","id":7798128,"avatar_url":"https://avatars.githubusercontent.com/u/7798128?v=3","gravatar_id":"","url":"https://api.github.com/users/underdogio","html_url":"https://github.com/underdogio","followers_url":"https://api.github.com/users/underdogio/followers","following_url":"https://api.github.com/users/underdogio/following{/other_user}","gists_url":"https://api.github.com/users/underdogio/gists{/gist_id}","starred_url":"https://api.github.com/users/underdogio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/underdogio/subscriptions","organizations_url":"https://api.github.com/users/underdogio/orgs","repos_url":"https://api.github.com/users/underdogio/repos","events_url":"https://api.github.com/users/underdogio/events{/privacy}","received_events_url":"https://api.github.com/users/underdogio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/underdogio/tld","description":"Extracts the top level domain (TLD) from the URL given.","fork":true,"url":"https://api.github.com/repos/underdogio/tld","forks_url":"https://api.github.com/repos/underdogio/tld/forks","keys_url":"https://api.github.com/repos/underdogio/tld/keys{/key_id}","collaborators_url":"https://api.github.com/repos/underdogio/tld/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/underdogio/tld/teams","hooks_url":"https://api.github.com/repos/underdogio/tld/hooks","issue_events_url":"https://api.github.com/repos/underdogio/tld/issues/events{/number}","events_url":"https://api.github.com/repos/underdogio/tld/events","assignees_url":"https://api.github.com/repos/underdogio/tld/assignees{/user}","branches_url":"https://api.github.com/repos/underdogio/tld/branches{/branch}","tags_url":"https://api.github.com/repos/underdogio/tld/tags","blobs_url":"https://api.github.com/repos/underdogio/tld/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/underdogio/tld/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/underdogio/tld/git/refs{/sha}","trees_url":"https://api.github.com/repos/underdogio/tld/git/trees{/sha}","statuses_url":"https://api.github.com/repos/underdogio/tld/statuses/{sha}","languages_url":"https://api.github.com/repos/underdogio/tld/languages","stargazers_url":"https://api.github.com/repos/underdogio/tld/stargazers","contributors_url":"https://api.github.com/repos/underdogio/tld/contributors","subscribers_url":"https://api.github.com/repos/underdogio/tld/subscribers","subscription_url":"https://api.github.com/repos/underdogio/tld/subscription","commits_url":"https://api.github.com/repos/underdogio/tld/commits{/sha}","git_commits_url":"https://api.github.com/repos/underdogio/tld/git/commits{/sha}","comments_url":"https://api.github.com/repos/underdogio/tld/comments{/number}","issue_comment_url":"https://api.github.com/repos/underdogio/tld/issues/comments{/number}","contents_url":"https://api.github.com/repos/underdogio/tld/contents/{+path}","compare_url":"https://api.github.com/repos/underdogio/tld/compare/{base}...{head}","merges_url":"https://api.github.com/repos/underdogio/tld/merges","archive_url":"https://api.github.com/repos/underdogio/tld/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/underdogio/tld/downloads","issues_url":"https://api.github.com/repos/underdogio/tld/issues{/number}","pulls_url":"https://api.github.com/repos/underdogio/tld/pulls{/number}","milestones_url":"https://api.github.com/repos/underdogio/tld/milestones{/number}","notifications_url":"https://api.github.com/repos/underdogio/tld/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/underdogio/tld/labels{/name}","releases_url":"https://api.github.com/repos/underdogio/tld/releases{/id}","created_at":"2015-09-23T23:21:18Z","updated_at":"2015-09-23T23:21:19Z","pushed_at":"2015-09-23T23:33:25Z","git_url":"git://github.com/underdogio/tld.git","ssh_url":"git@github.com:underdogio/tld.git","clone_url":"https://github.com/underdogio/tld.git","svn_url":"https://github.com/underdogio/tld","homepage":"https://pypi.python.org/pypi/tld","size":223,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"barseghyanartur:master","ref":"master","sha":"990ab697601a207c02e89c09df17bd7e6037a5b1","user":{"login":"barseghyanartur","id":4925587,"avatar_url":"https://avatars.githubusercontent.com/u/4925587?v=3","gravatar_id":"","url":"https://api.github.com/users/barseghyanartur","html_url":"https://github.com/barseghyanartur","followers_url":"https://api.github.com/users/barseghyanartur/followers","following_url":"https://api.github.com/users/barseghyanartur/following{/other_user}","gists_url":"https://api.github.com/users/barseghyanartur/gists{/gist_id}","starred_url":"https://api.github.com/users/barseghyanartur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barseghyanartur/subscriptions","organizations_url":"https://api.github.com/users/barseghyanartur/orgs","repos_url":"https://api.github.com/users/barseghyanartur/repos","events_url":"https://api.github.com/users/barseghyanartur/events{/privacy}","received_events_url":"https://api.github.com/users/barseghyanartur/received_events","type":"User","site_admin":false},"repo":{"id":11746687,"name":"tld","full_name":"barseghyanartur/tld","owner":{"login":"barseghyanartur","id":4925587,"avatar_url":"https://avatars.githubusercontent.com/u/4925587?v=3","gravatar_id":"","url":"https://api.github.com/users/barseghyanartur","html_url":"https://github.com/barseghyanartur","followers_url":"https://api.github.com/users/barseghyanartur/followers","following_url":"https://api.github.com/users/barseghyanartur/following{/other_user}","gists_url":"https://api.github.com/users/barseghyanartur/gists{/gist_id}","starred_url":"https://api.github.com/users/barseghyanartur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barseghyanartur/subscriptions","organizations_url":"https://api.github.com/users/barseghyanartur/orgs","repos_url":"https://api.github.com/users/barseghyanartur/repos","events_url":"https://api.github.com/users/barseghyanartur/events{/privacy}","received_events_url":"https://api.github.com/users/barseghyanartur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/barseghyanartur/tld","description":"Extracts the top level domain (TLD) from the URL given.","fork":false,"url":"https://api.github.com/repos/barseghyanartur/tld","forks_url":"https://api.github.com/repos/barseghyanartur/tld/forks","keys_url":"https://api.github.com/repos/barseghyanartur/tld/keys{/key_id}","collaborators_url":"https://api.github.com/repos/barseghyanartur/tld/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/barseghyanartur/tld/teams","hooks_url":"https://api.github.com/repos/barseghyanartur/tld/hooks","issue_events_url":"https://api.github.com/repos/barseghyanartur/tld/issues/events{/number}","events_url":"https://api.github.com/repos/barseghyanartur/tld/events","assignees_url":"https://api.github.com/repos/barseghyanartur/tld/assignees{/user}","branches_url":"https://api.github.com/repos/barseghyanartur/tld/branches{/branch}","tags_url":"https://api.github.com/repos/barseghyanartur/tld/tags","blobs_url":"https://api.github.com/repos/barseghyanartur/tld/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/barseghyanartur/tld/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/barseghyanartur/tld/git/refs{/sha}","trees_url":"https://api.github.com/repos/barseghyanartur/tld/git/trees{/sha}","statuses_url":"https://api.github.com/repos/barseghyanartur/tld/statuses/{sha}","languages_url":"https://api.github.com/repos/barseghyanartur/tld/languages","stargazers_url":"https://api.github.com/repos/barseghyanartur/tld/stargazers","contributors_url":"https://api.github.com/repos/barseghyanartur/tld/contributors","subscribers_url":"https://api.github.com/repos/barseghyanartur/tld/subscribers","subscription_url":"https://api.github.com/repos/barseghyanartur/tld/subscription","commits_url":"https://api.github.com/repos/barseghyanartur/tld/commits{/sha}","git_commits_url":"https://api.github.com/repos/barseghyanartur/tld/git/commits{/sha}","comments_url":"https://api.github.com/repos/barseghyanartur/tld/comments{/number}","issue_comment_url":"https://api.github.com/repos/barseghyanartur/tld/issues/comments{/number}","contents_url":"https://api.github.com/repos/barseghyanartur/tld/contents/{+path}","compare_url":"https://api.github.com/repos/barseghyanartur/tld/compare/{base}...{head}","merges_url":"https://api.github.com/repos/barseghyanartur/tld/merges","archive_url":"https://api.github.com/repos/barseghyanartur/tld/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/barseghyanartur/tld/downloads","issues_url":"https://api.github.com/repos/barseghyanartur/tld/issues{/number}","pulls_url":"https://api.github.com/repos/barseghyanartur/tld/pulls{/number}","milestones_url":"https://api.github.com/repos/barseghyanartur/tld/milestones{/number}","notifications_url":"https://api.github.com/repos/barseghyanartur/tld/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/barseghyanartur/tld/labels{/name}","releases_url":"https://api.github.com/repos/barseghyanartur/tld/releases{/id}","created_at":"2013-07-29T18:33:46Z","updated_at":"2015-09-08T11:16:50Z","pushed_at":"2015-09-23T23:43:48Z","git_url":"git://github.com/barseghyanartur/tld.git","ssh_url":"git@github.com:barseghyanartur/tld.git","clone_url":"https://github.com/barseghyanartur/tld.git","svn_url":"https://github.com/barseghyanartur/tld","homepage":"https://pypi.python.org/pypi/tld","size":344,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/barseghyanartur/tld/pulls/6"},"html":{"href":"https://github.com/barseghyanartur/tld/pull/6"},"issue":{"href":"https://api.github.com/repos/barseghyanartur/tld/issues/6"},"comments":{"href":"https://api.github.com/repos/barseghyanartur/tld/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/barseghyanartur/tld/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/barseghyanartur/tld/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/barseghyanartur/tld/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/barseghyanartur/tld/statuses/ceadc486acb6c4dcaa51b397b03186d191b39588"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"barseghyanartur","id":4925587,"avatar_url":"https://avatars.githubusercontent.com/u/4925587?v=3","gravatar_id":"","url":"https://api.github.com/users/barseghyanartur","html_url":"https://github.com/barseghyanartur","followers_url":"https://api.github.com/users/barseghyanartur/followers","following_url":"https://api.github.com/users/barseghyanartur/following{/other_user}","gists_url":"https://api.github.com/users/barseghyanartur/gists{/gist_id}","starred_url":"https://api.github.com/users/barseghyanartur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barseghyanartur/subscriptions","organizations_url":"https://api.github.com/users/barseghyanartur/orgs","repos_url":"https://api.github.com/users/barseghyanartur/repos","events_url":"https://api.github.com/users/barseghyanartur/events{/privacy}","received_events_url":"https://api.github.com/users/barseghyanartur/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":56,"deletions":51,"changed_files":2}}