{"action":"closed","number":477,"pull_request":{"url":"https://api.github.com/repos/lukesampson/scoop/pulls/477","id":43462770,"html_url":"https://github.com/lukesampson/scoop/pull/477","diff_url":"https://github.com/lukesampson/scoop/pull/477.diff","patch_url":"https://github.com/lukesampson/scoop/pull/477.patch","issue_url":"https://api.github.com/repos/lukesampson/scoop/issues/477","number":477,"state":"closed","locked":false,"title":"fix Scoop-Core tests for Win10 (#hack)","user":{"login":"rivy","id":80132,"avatar_url":"https://avatars.githubusercontent.com/u/80132?v=3","gravatar_id":"","url":"https://api.github.com/users/rivy","html_url":"https://github.com/rivy","followers_url":"https://api.github.com/users/rivy/followers","following_url":"https://api.github.com/users/rivy/following{/other_user}","gists_url":"https://api.github.com/users/rivy/gists{/gist_id}","starred_url":"https://api.github.com/users/rivy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rivy/subscriptions","organizations_url":"https://api.github.com/users/rivy/orgs","repos_url":"https://api.github.com/users/rivy/repos","events_url":"https://api.github.com/users/rivy/events{/privacy}","received_events_url":"https://api.github.com/users/rivy/received_events","type":"User","site_admin":false},"body":"* fixes tests by coercing the `test-unzip` return value back into a valid path string\r\n* fixes #476\r\n\r\n.# Discussion\r\n\r\nFor Win10 machines, `test-unzip` returns a bugged value, causing test failures.\r\n\r\nInvestigation shows that the combination of Pester, COM (used within unzip_old), and\r\nWin10 leads to the odd/bugged return value. The return value contains the correct\r\nstring, but it is prefaced with a leading space which arises de-novo during the\r\nexecution return process from `test-unzip`. The value is correct and usable at the end\r\nof `test-unzip` but is bugged upon receiving the value at the caller. Removing the COM\r\ncall from within `unzip_old` or using a Windows version earlier than Win10 fixes the\r\nproblem, but are obviously not useful as solutions.\r\n\r\nGiven the nature of the returned value and COM involvement, the real problem is likely\r\nstack corruption. But it's not clear whether the issue is with Pester, Win10/PowerShell,\r\nor possibly even some subtle bug within unzip_old.\r\n\r\nThis, admittedly hacky, coercion fixes the problem for all Windows versions and also\r\nkeeps Appveyor satisfied.","created_at":"2015-08-26T23:08:01Z","updated_at":"2015-09-01T10:46:02Z","closed_at":"2015-09-01T10:46:02Z","merged_at":"2015-09-01T10:46:02Z","merge_commit_sha":"43c3ee93ddfd95be9326b0807548aaada376d08f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lukesampson/scoop/pulls/477/commits","review_comments_url":"https://api.github.com/repos/lukesampson/scoop/pulls/477/comments","review_comment_url":"https://api.github.com/repos/lukesampson/scoop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lukesampson/scoop/issues/477/comments","statuses_url":"https://api.github.com/repos/lukesampson/scoop/statuses/2453136312632870722add405ce5b398c937dc29","head":{"label":"rivy:fix-tests-core-Win10","ref":"fix-tests-core-Win10","sha":"2453136312632870722add405ce5b398c937dc29","user":{"login":"rivy","id":80132,"avatar_url":"https://avatars.githubusercontent.com/u/80132?v=3","gravatar_id":"","url":"https://api.github.com/users/rivy","html_url":"https://github.com/rivy","followers_url":"https://api.github.com/users/rivy/followers","following_url":"https://api.github.com/users/rivy/following{/other_user}","gists_url":"https://api.github.com/users/rivy/gists{/gist_id}","starred_url":"https://api.github.com/users/rivy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rivy/subscriptions","organizations_url":"https://api.github.com/users/rivy/orgs","repos_url":"https://api.github.com/users/rivy/repos","events_url":"https://api.github.com/users/rivy/events{/privacy}","received_events_url":"https://api.github.com/users/rivy/received_events","type":"User","site_admin":false},"repo":{"id":29839019,"name":"scoop","full_name":"rivy/scoop","owner":{"login":"rivy","id":80132,"avatar_url":"https://avatars.githubusercontent.com/u/80132?v=3","gravatar_id":"","url":"https://api.github.com/users/rivy","html_url":"https://github.com/rivy","followers_url":"https://api.github.com/users/rivy/followers","following_url":"https://api.github.com/users/rivy/following{/other_user}","gists_url":"https://api.github.com/users/rivy/gists{/gist_id}","starred_url":"https://api.github.com/users/rivy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rivy/subscriptions","organizations_url":"https://api.github.com/users/rivy/orgs","repos_url":"https://api.github.com/users/rivy/repos","events_url":"https://api.github.com/users/rivy/events{/privacy}","received_events_url":"https://api.github.com/users/rivy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rivy/scoop","description":"A command-line installer for Windows.","fork":true,"url":"https://api.github.com/repos/rivy/scoop","forks_url":"https://api.github.com/repos/rivy/scoop/forks","keys_url":"https://api.github.com/repos/rivy/scoop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rivy/scoop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rivy/scoop/teams","hooks_url":"https://api.github.com/repos/rivy/scoop/hooks","issue_events_url":"https://api.github.com/repos/rivy/scoop/issues/events{/number}","events_url":"https://api.github.com/repos/rivy/scoop/events","assignees_url":"https://api.github.com/repos/rivy/scoop/assignees{/user}","branches_url":"https://api.github.com/repos/rivy/scoop/branches{/branch}","tags_url":"https://api.github.com/repos/rivy/scoop/tags","blobs_url":"https://api.github.com/repos/rivy/scoop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rivy/scoop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rivy/scoop/git/refs{/sha}","trees_url":"https://api.github.com/repos/rivy/scoop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rivy/scoop/statuses/{sha}","languages_url":"https://api.github.com/repos/rivy/scoop/languages","stargazers_url":"https://api.github.com/repos/rivy/scoop/stargazers","contributors_url":"https://api.github.com/repos/rivy/scoop/contributors","subscribers_url":"https://api.github.com/repos/rivy/scoop/subscribers","subscription_url":"https://api.github.com/repos/rivy/scoop/subscription","commits_url":"https://api.github.com/repos/rivy/scoop/commits{/sha}","git_commits_url":"https://api.github.com/repos/rivy/scoop/git/commits{/sha}","comments_url":"https://api.github.com/repos/rivy/scoop/comments{/number}","issue_comment_url":"https://api.github.com/repos/rivy/scoop/issues/comments{/number}","contents_url":"https://api.github.com/repos/rivy/scoop/contents/{+path}","compare_url":"https://api.github.com/repos/rivy/scoop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rivy/scoop/merges","archive_url":"https://api.github.com/repos/rivy/scoop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rivy/scoop/downloads","issues_url":"https://api.github.com/repos/rivy/scoop/issues{/number}","pulls_url":"https://api.github.com/repos/rivy/scoop/pulls{/number}","milestones_url":"https://api.github.com/repos/rivy/scoop/milestones{/number}","notifications_url":"https://api.github.com/repos/rivy/scoop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rivy/scoop/labels{/name}","releases_url":"https://api.github.com/repos/rivy/scoop/releases{/id}","created_at":"2015-01-26T01:04:20Z","updated_at":"2015-01-26T01:04:23Z","pushed_at":"2015-09-01T04:26:10Z","git_url":"git://github.com/rivy/scoop.git","ssh_url":"git@github.com:rivy/scoop.git","clone_url":"https://github.com/rivy/scoop.git","svn_url":"https://github.com/rivy/scoop","homepage":"scoop.sh","size":1645,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lukesampson:master","ref":"master","sha":"e3749a79ca14f2a5dbcd166fbbfaddb27ff3f63e","user":{"login":"lukesampson","id":103446,"avatar_url":"https://avatars.githubusercontent.com/u/103446?v=3","gravatar_id":"","url":"https://api.github.com/users/lukesampson","html_url":"https://github.com/lukesampson","followers_url":"https://api.github.com/users/lukesampson/followers","following_url":"https://api.github.com/users/lukesampson/following{/other_user}","gists_url":"https://api.github.com/users/lukesampson/gists{/gist_id}","starred_url":"https://api.github.com/users/lukesampson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukesampson/subscriptions","organizations_url":"https://api.github.com/users/lukesampson/orgs","repos_url":"https://api.github.com/users/lukesampson/repos","events_url":"https://api.github.com/users/lukesampson/events{/privacy}","received_events_url":"https://api.github.com/users/lukesampson/received_events","type":"User","site_admin":false},"repo":{"id":9994688,"name":"scoop","full_name":"lukesampson/scoop","owner":{"login":"lukesampson","id":103446,"avatar_url":"https://avatars.githubusercontent.com/u/103446?v=3","gravatar_id":"","url":"https://api.github.com/users/lukesampson","html_url":"https://github.com/lukesampson","followers_url":"https://api.github.com/users/lukesampson/followers","following_url":"https://api.github.com/users/lukesampson/following{/other_user}","gists_url":"https://api.github.com/users/lukesampson/gists{/gist_id}","starred_url":"https://api.github.com/users/lukesampson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukesampson/subscriptions","organizations_url":"https://api.github.com/users/lukesampson/orgs","repos_url":"https://api.github.com/users/lukesampson/repos","events_url":"https://api.github.com/users/lukesampson/events{/privacy}","received_events_url":"https://api.github.com/users/lukesampson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukesampson/scoop","description":"A command-line installer for Windows.","fork":false,"url":"https://api.github.com/repos/lukesampson/scoop","forks_url":"https://api.github.com/repos/lukesampson/scoop/forks","keys_url":"https://api.github.com/repos/lukesampson/scoop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukesampson/scoop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukesampson/scoop/teams","hooks_url":"https://api.github.com/repos/lukesampson/scoop/hooks","issue_events_url":"https://api.github.com/repos/lukesampson/scoop/issues/events{/number}","events_url":"https://api.github.com/repos/lukesampson/scoop/events","assignees_url":"https://api.github.com/repos/lukesampson/scoop/assignees{/user}","branches_url":"https://api.github.com/repos/lukesampson/scoop/branches{/branch}","tags_url":"https://api.github.com/repos/lukesampson/scoop/tags","blobs_url":"https://api.github.com/repos/lukesampson/scoop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukesampson/scoop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukesampson/scoop/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukesampson/scoop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukesampson/scoop/statuses/{sha}","languages_url":"https://api.github.com/repos/lukesampson/scoop/languages","stargazers_url":"https://api.github.com/repos/lukesampson/scoop/stargazers","contributors_url":"https://api.github.com/repos/lukesampson/scoop/contributors","subscribers_url":"https://api.github.com/repos/lukesampson/scoop/subscribers","subscription_url":"https://api.github.com/repos/lukesampson/scoop/subscription","commits_url":"https://api.github.com/repos/lukesampson/scoop/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukesampson/scoop/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukesampson/scoop/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukesampson/scoop/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukesampson/scoop/contents/{+path}","compare_url":"https://api.github.com/repos/lukesampson/scoop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukesampson/scoop/merges","archive_url":"https://api.github.com/repos/lukesampson/scoop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukesampson/scoop/downloads","issues_url":"https://api.github.com/repos/lukesampson/scoop/issues{/number}","pulls_url":"https://api.github.com/repos/lukesampson/scoop/pulls{/number}","milestones_url":"https://api.github.com/repos/lukesampson/scoop/milestones{/number}","notifications_url":"https://api.github.com/repos/lukesampson/scoop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukesampson/scoop/labels{/name}","releases_url":"https://api.github.com/repos/lukesampson/scoop/releases{/id}","created_at":"2013-05-11T03:52:15Z","updated_at":"2015-08-31T19:08:04Z","pushed_at":"2015-09-01T10:46:02Z","git_url":"git://github.com/lukesampson/scoop.git","ssh_url":"git@github.com:lukesampson/scoop.git","clone_url":"https://github.com/lukesampson/scoop.git","svn_url":"https://github.com/lukesampson/scoop","homepage":"scoop.sh","size":5276,"stargazers_count":904,"watchers_count":904,"language":"PowerShell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":92,"mirror_url":null,"open_issues_count":18,"forks":92,"open_issues":18,"watchers":904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lukesampson/scoop/pulls/477"},"html":{"href":"https://github.com/lukesampson/scoop/pull/477"},"issue":{"href":"https://api.github.com/repos/lukesampson/scoop/issues/477"},"comments":{"href":"https://api.github.com/repos/lukesampson/scoop/issues/477/comments"},"review_comments":{"href":"https://api.github.com/repos/lukesampson/scoop/pulls/477/comments"},"review_comment":{"href":"https://api.github.com/repos/lukesampson/scoop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lukesampson/scoop/pulls/477/commits"},"statuses":{"href":"https://api.github.com/repos/lukesampson/scoop/statuses/2453136312632870722add405ce5b398c937dc29"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"deevus","id":856194,"avatar_url":"https://avatars.githubusercontent.com/u/856194?v=3","gravatar_id":"","url":"https://api.github.com/users/deevus","html_url":"https://github.com/deevus","followers_url":"https://api.github.com/users/deevus/followers","following_url":"https://api.github.com/users/deevus/following{/other_user}","gists_url":"https://api.github.com/users/deevus/gists{/gist_id}","starred_url":"https://api.github.com/users/deevus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deevus/subscriptions","organizations_url":"https://api.github.com/users/deevus/orgs","repos_url":"https://api.github.com/users/deevus/repos","events_url":"https://api.github.com/users/deevus/events{/privacy}","received_events_url":"https://api.github.com/users/deevus/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":14,"deletions":3,"changed_files":1}}