{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/827","labels_url":"https://api.github.com/repos/openshift/origin/issues/827/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/827/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/827/events","html_url":"https://github.com/openshift/origin/pull/827","id":56233388,"number":827,"title":"Support parameter substitution for all string fields in Template","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-02-02T12:54:00Z","updated_at":"2015-04-20T10:24:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/827","html_url":"https://github.com/openshift/origin/pull/827","diff_url":"https://github.com/openshift/origin/pull/827.diff","patch_url":"https://github.com/openshift/origin/pull/827.patch"},"body":"This patch allow generic substitution for **all** `string` fields in any object we have. It allows referencing parameters in fields like 'host', 'output->registry', annotations, etc...\r\n\r\nThe current state is that we support substitution only for Env fields and only for certain types. There is also no documentation that would say this... I think it would be better to say:\r\n\r\n\"we support parameter substitution for **all** string fields\" vs \"we support parameter substitution for all Env fields defined for these types: ....\""},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/94416548","html_url":"https://github.com/openshift/origin/pull/827#issuecomment-94416548","issue_url":"https://api.github.com/repos/openshift/origin/issues/827","id":94416548,"user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"created_at":"2015-04-20T10:24:58Z","updated_at":"2015-04-20T10:24:58Z","body":"@smarterclayton @kargakis one more change, I changed the name to 'VisitObjectStrings' as this func can also substitute arrays/etc (not just structs). Also I switched to use table tests (which looks pretty cool now). Please let me know if you want to add more test cases."}}