{"action":"created","issue":{"url":"https://api.github.com/repos/bvaughn/angular-form-for/issues/132","labels_url":"https://api.github.com/repos/bvaughn/angular-form-for/issues/132/labels{/name}","comments_url":"https://api.github.com/repos/bvaughn/angular-form-for/issues/132/comments","events_url":"https://api.github.com/repos/bvaughn/angular-form-for/issues/132/events","html_url":"https://github.com/bvaughn/angular-form-for/issues/132","id":92054363,"number":132,"title":"Angular 1.4.1 compatibility with $attributes service","user":{"login":"hutzelknecht","id":1176155,"avatar_url":"https://avatars.githubusercontent.com/u/1176155?v=3","gravatar_id":"","url":"https://api.github.com/users/hutzelknecht","html_url":"https://github.com/hutzelknecht","followers_url":"https://api.github.com/users/hutzelknecht/followers","following_url":"https://api.github.com/users/hutzelknecht/following{/other_user}","gists_url":"https://api.github.com/users/hutzelknecht/gists{/gist_id}","starred_url":"https://api.github.com/users/hutzelknecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hutzelknecht/subscriptions","organizations_url":"https://api.github.com/users/hutzelknecht/orgs","repos_url":"https://api.github.com/users/hutzelknecht/repos","events_url":"https://api.github.com/users/hutzelknecht/events{/privacy}","received_events_url":"https://api.github.com/users/hutzelknecht/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-30T10:25:34Z","updated_at":"2015-06-30T15:40:45Z","closed_at":null,"body":"Hi Brian,\r\n\r\nthanks for all the busy work you put into form-for the last few weeks. I just migrated to Angular 1.4.1 and noticed that in directives, the $attributes service now actually has all the attributes as properties with a value of undefined. This makes the following lines break:\r\n\r\n    $scope.onFocus = function () {\r\n        if ($attributes.hasOwnProperty('focused')) {\r\n            $scope.focused();\r\n        }\r\n    };\r\n\r\nso the output of the generated form-for code would have to check not only with \"hasOwnProperty\", but also for a truthy value or the existance of a function before calling it:\r\n\r\n    $scope.onFocus = function () {\r\n        if (typeof $attributes['focused'] === 'function') {\r\n            $scope.focused();\r\n        }\r\n    };\r\n\r\nNo idea how to accomplish this in typescript. but this is really the only issue i found so far with compatibility with angular 1.4.1"},"comment":{"url":"https://api.github.com/repos/bvaughn/angular-form-for/issues/comments/117232639","html_url":"https://github.com/bvaughn/angular-form-for/issues/132#issuecomment-117232639","issue_url":"https://api.github.com/repos/bvaughn/angular-form-for/issues/132","id":117232639,"user":{"login":"bvaughn","id":29597,"avatar_url":"https://avatars.githubusercontent.com/u/29597?v=3","gravatar_id":"","url":"https://api.github.com/users/bvaughn","html_url":"https://github.com/bvaughn","followers_url":"https://api.github.com/users/bvaughn/followers","following_url":"https://api.github.com/users/bvaughn/following{/other_user}","gists_url":"https://api.github.com/users/bvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/bvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvaughn/subscriptions","organizations_url":"https://api.github.com/users/bvaughn/orgs","repos_url":"https://api.github.com/users/bvaughn/repos","events_url":"https://api.github.com/users/bvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/bvaughn/received_events","type":"User","site_admin":false},"created_at":"2015-06-30T15:40:45Z","updated_at":"2015-06-30T15:40:45Z","body":"Hi @hutzelknecht,\r\n\r\nYou're welcome. And thank you. :)\r\n\r\nI'll try to take a look at this this evening. Off the top of my head, I don't know what may have changed between versions that would have caused this. (What version did you upgrade from?)"}}