{"action":"created","comment":{"url":"https://api.github.com/repos/indutny/elliptic/pulls/comments/34548406","id":34548406,"diff_hunk":"@@ -147,6 +156,10 @@ Point.prototype.mulAdd = function mulAdd() {\n   throw new Error('Not supported on Montgomery curve');\n };\n \n+Point.prototype.eq = function eq(other) {","path":"lib/elliptic/curve/mont.js","position":27,"original_position":27,"commit_id":"40bfb3c064a0b1f27ead4c575bdbc8eb46395690","original_commit_id":"99cb8233cf28a7295a41c02f9b78c59b927c586e","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"body":"OK ;)","created_at":"2015-07-14T08:56:13Z","updated_at":"2015-07-14T08:56:13Z","html_url":"https://github.com/indutny/elliptic/pull/48#discussion_r34548406","pull_request_url":"https://api.github.com/repos/indutny/elliptic/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/indutny/elliptic/pulls/comments/34548406"},"html":{"href":"https://github.com/indutny/elliptic/pull/48#discussion_r34548406"},"pull_request":{"href":"https://api.github.com/repos/indutny/elliptic/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/indutny/elliptic/pulls/48","id":39357653,"html_url":"https://github.com/indutny/elliptic/pull/48","diff_url":"https://github.com/indutny/elliptic/pull/48.diff","patch_url":"https://github.com/indutny/elliptic/pull/48.patch","issue_url":"https://api.github.com/repos/indutny/elliptic/issues/48","number":48,"state":"open","locked":false,"title":"[WIP] Move point codec code from ec/key to curve/base","user":{"login":"sublimator","id":525211,"avatar_url":"https://avatars.githubusercontent.com/u/525211?v=3","gravatar_id":"","url":"https://api.github.com/users/sublimator","html_url":"https://github.com/sublimator","followers_url":"https://api.github.com/users/sublimator/followers","following_url":"https://api.github.com/users/sublimator/following{/other_user}","gists_url":"https://api.github.com/users/sublimator/gists{/gist_id}","starred_url":"https://api.github.com/users/sublimator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sublimator/subscriptions","organizations_url":"https://api.github.com/users/sublimator/orgs","repos_url":"https://api.github.com/users/sublimator/repos","events_url":"https://api.github.com/users/sublimator/events{/privacy}","received_events_url":"https://api.github.com/users/sublimator/received_events","type":"User","site_admin":false},"body":"re #42 \r\n\r\nThis just takes the existing point codec code that was inside the KeyPair class and moves it the BaseCurve / BasePoint classes. It didn't really seem advantageous to go to unnatural lengths to have default implementation and various over-rides. Thoughts?","created_at":"2015-07-07T10:56:13Z","updated_at":"2015-07-14T08:56:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e452ee3b36502b23c6a7b1131cc287109a5d20a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/indutny/elliptic/pulls/48/commits","review_comments_url":"https://api.github.com/repos/indutny/elliptic/pulls/48/comments","review_comment_url":"https://api.github.com/repos/indutny/elliptic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/indutny/elliptic/issues/48/comments","statuses_url":"https://api.github.com/repos/indutny/elliptic/statuses/40bfb3c064a0b1f27ead4c575bdbc8eb46395690","head":{"label":"sublimator:point-codec","ref":"point-codec","sha":"40bfb3c064a0b1f27ead4c575bdbc8eb46395690","user":{"login":"sublimator","id":525211,"avatar_url":"https://avatars.githubusercontent.com/u/525211?v=3","gravatar_id":"","url":"https://api.github.com/users/sublimator","html_url":"https://github.com/sublimator","followers_url":"https://api.github.com/users/sublimator/followers","following_url":"https://api.github.com/users/sublimator/following{/other_user}","gists_url":"https://api.github.com/users/sublimator/gists{/gist_id}","starred_url":"https://api.github.com/users/sublimator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sublimator/subscriptions","organizations_url":"https://api.github.com/users/sublimator/orgs","repos_url":"https://api.github.com/users/sublimator/repos","events_url":"https://api.github.com/users/sublimator/events{/privacy}","received_events_url":"https://api.github.com/users/sublimator/received_events","type":"User","site_admin":false},"repo":{"id":35797744,"name":"elliptic","full_name":"sublimator/elliptic","owner":{"login":"sublimator","id":525211,"avatar_url":"https://avatars.githubusercontent.com/u/525211?v=3","gravatar_id":"","url":"https://api.github.com/users/sublimator","html_url":"https://github.com/sublimator","followers_url":"https://api.github.com/users/sublimator/followers","following_url":"https://api.github.com/users/sublimator/following{/other_user}","gists_url":"https://api.github.com/users/sublimator/gists{/gist_id}","starred_url":"https://api.github.com/users/sublimator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sublimator/subscriptions","organizations_url":"https://api.github.com/users/sublimator/orgs","repos_url":"https://api.github.com/users/sublimator/repos","events_url":"https://api.github.com/users/sublimator/events{/privacy}","received_events_url":"https://api.github.com/users/sublimator/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sublimator/elliptic","description":"Fast Elliptic Curve Cryptography in plain javascript","fork":true,"url":"https://api.github.com/repos/sublimator/elliptic","forks_url":"https://api.github.com/repos/sublimator/elliptic/forks","keys_url":"https://api.github.com/repos/sublimator/elliptic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sublimator/elliptic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sublimator/elliptic/teams","hooks_url":"https://api.github.com/repos/sublimator/elliptic/hooks","issue_events_url":"https://api.github.com/repos/sublimator/elliptic/issues/events{/number}","events_url":"https://api.github.com/repos/sublimator/elliptic/events","assignees_url":"https://api.github.com/repos/sublimator/elliptic/assignees{/user}","branches_url":"https://api.github.com/repos/sublimator/elliptic/branches{/branch}","tags_url":"https://api.github.com/repos/sublimator/elliptic/tags","blobs_url":"https://api.github.com/repos/sublimator/elliptic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sublimator/elliptic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sublimator/elliptic/git/refs{/sha}","trees_url":"https://api.github.com/repos/sublimator/elliptic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sublimator/elliptic/statuses/{sha}","languages_url":"https://api.github.com/repos/sublimator/elliptic/languages","stargazers_url":"https://api.github.com/repos/sublimator/elliptic/stargazers","contributors_url":"https://api.github.com/repos/sublimator/elliptic/contributors","subscribers_url":"https://api.github.com/repos/sublimator/elliptic/subscribers","subscription_url":"https://api.github.com/repos/sublimator/elliptic/subscription","commits_url":"https://api.github.com/repos/sublimator/elliptic/commits{/sha}","git_commits_url":"https://api.github.com/repos/sublimator/elliptic/git/commits{/sha}","comments_url":"https://api.github.com/repos/sublimator/elliptic/comments{/number}","issue_comment_url":"https://api.github.com/repos/sublimator/elliptic/issues/comments{/number}","contents_url":"https://api.github.com/repos/sublimator/elliptic/contents/{+path}","compare_url":"https://api.github.com/repos/sublimator/elliptic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sublimator/elliptic/merges","archive_url":"https://api.github.com/repos/sublimator/elliptic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sublimator/elliptic/downloads","issues_url":"https://api.github.com/repos/sublimator/elliptic/issues{/number}","pulls_url":"https://api.github.com/repos/sublimator/elliptic/pulls{/number}","milestones_url":"https://api.github.com/repos/sublimator/elliptic/milestones{/number}","notifications_url":"https://api.github.com/repos/sublimator/elliptic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sublimator/elliptic/labels{/name}","releases_url":"https://api.github.com/repos/sublimator/elliptic/releases{/id}","created_at":"2015-05-18T05:02:48Z","updated_at":"2015-06-12T17:04:25Z","pushed_at":"2015-07-14T08:46:00Z","git_url":"git://github.com/sublimator/elliptic.git","ssh_url":"git@github.com:sublimator/elliptic.git","clone_url":"https://github.com/sublimator/elliptic.git","svn_url":"https://github.com/sublimator/elliptic","homepage":"","size":1866,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"derivations-test"}},"base":{"label":"indutny:master","ref":"master","sha":"397d5f72750a55ce1a6497965f5ad17f0aa299cb","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"repo":{"id":19029120,"name":"elliptic","full_name":"indutny/elliptic","owner":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/indutny/elliptic","description":"Fast Elliptic Curve Cryptography in plain javascript","fork":false,"url":"https://api.github.com/repos/indutny/elliptic","forks_url":"https://api.github.com/repos/indutny/elliptic/forks","keys_url":"https://api.github.com/repos/indutny/elliptic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indutny/elliptic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indutny/elliptic/teams","hooks_url":"https://api.github.com/repos/indutny/elliptic/hooks","issue_events_url":"https://api.github.com/repos/indutny/elliptic/issues/events{/number}","events_url":"https://api.github.com/repos/indutny/elliptic/events","assignees_url":"https://api.github.com/repos/indutny/elliptic/assignees{/user}","branches_url":"https://api.github.com/repos/indutny/elliptic/branches{/branch}","tags_url":"https://api.github.com/repos/indutny/elliptic/tags","blobs_url":"https://api.github.com/repos/indutny/elliptic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indutny/elliptic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indutny/elliptic/git/refs{/sha}","trees_url":"https://api.github.com/repos/indutny/elliptic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indutny/elliptic/statuses/{sha}","languages_url":"https://api.github.com/repos/indutny/elliptic/languages","stargazers_url":"https://api.github.com/repos/indutny/elliptic/stargazers","contributors_url":"https://api.github.com/repos/indutny/elliptic/contributors","subscribers_url":"https://api.github.com/repos/indutny/elliptic/subscribers","subscription_url":"https://api.github.com/repos/indutny/elliptic/subscription","commits_url":"https://api.github.com/repos/indutny/elliptic/commits{/sha}","git_commits_url":"https://api.github.com/repos/indutny/elliptic/git/commits{/sha}","comments_url":"https://api.github.com/repos/indutny/elliptic/comments{/number}","issue_comment_url":"https://api.github.com/repos/indutny/elliptic/issues/comments{/number}","contents_url":"https://api.github.com/repos/indutny/elliptic/contents/{+path}","compare_url":"https://api.github.com/repos/indutny/elliptic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indutny/elliptic/merges","archive_url":"https://api.github.com/repos/indutny/elliptic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indutny/elliptic/downloads","issues_url":"https://api.github.com/repos/indutny/elliptic/issues{/number}","pulls_url":"https://api.github.com/repos/indutny/elliptic/pulls{/number}","milestones_url":"https://api.github.com/repos/indutny/elliptic/milestones{/number}","notifications_url":"https://api.github.com/repos/indutny/elliptic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indutny/elliptic/labels{/name}","releases_url":"https://api.github.com/repos/indutny/elliptic/releases{/id}","created_at":"2014-04-22T12:42:51Z","updated_at":"2015-07-07T17:50:56Z","pushed_at":"2015-07-14T08:46:00Z","git_url":"git://github.com/indutny/elliptic.git","ssh_url":"git@github.com:indutny/elliptic.git","clone_url":"https://github.com/indutny/elliptic.git","svn_url":"https://github.com/indutny/elliptic","homepage":"","size":2971,"stargazers_count":120,"watchers_count":120,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":8,"forks":23,"open_issues":8,"watchers":120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/indutny/elliptic/pulls/48"},"html":{"href":"https://github.com/indutny/elliptic/pull/48"},"issue":{"href":"https://api.github.com/repos/indutny/elliptic/issues/48"},"comments":{"href":"https://api.github.com/repos/indutny/elliptic/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/indutny/elliptic/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/indutny/elliptic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/indutny/elliptic/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/indutny/elliptic/statuses/40bfb3c064a0b1f27ead4c575bdbc8eb46395690"}}}}