{"action":"created","comment":{"url":"https://api.github.com/repos/dennyb87/pycity/pulls/comments/44400737","id":44400737,"diff_hunk":"@@ -0,0 +1,16 @@\n+import unittest\n+\n+\n+class Test(unittest.TestCase):","path":"week5/feet_meters_test.py","position":4,"original_position":4,"commit_id":"9c07835a08fea7e72bfa2c4ce2f9242ec24ae3e2","original_commit_id":"9c07835a08fea7e72bfa2c4ce2f9242ec24ae3e2","user":{"login":"matthieuchoplin","id":1380333,"avatar_url":"https://avatars.githubusercontent.com/u/1380333?v=3","gravatar_id":"","url":"https://api.github.com/users/matthieuchoplin","html_url":"https://github.com/matthieuchoplin","followers_url":"https://api.github.com/users/matthieuchoplin/followers","following_url":"https://api.github.com/users/matthieuchoplin/following{/other_user}","gists_url":"https://api.github.com/users/matthieuchoplin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthieuchoplin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthieuchoplin/subscriptions","organizations_url":"https://api.github.com/users/matthieuchoplin/orgs","repos_url":"https://api.github.com/users/matthieuchoplin/repos","events_url":"https://api.github.com/users/matthieuchoplin/events{/privacy}","received_events_url":"https://api.github.com/users/matthieuchoplin/received_events","type":"User","site_admin":false},"body":"The name of the class is too generic, I suppose that it could be used by an other standard library. Prefer a more explicit name such as `FeetMeterTest`","created_at":"2015-11-10T12:32:26Z","updated_at":"2015-11-10T12:32:26Z","html_url":"https://github.com/dennyb87/pycity/pull/9#discussion_r44400737","pull_request_url":"https://api.github.com/repos/dennyb87/pycity/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/dennyb87/pycity/pulls/comments/44400737"},"html":{"href":"https://github.com/dennyb87/pycity/pull/9#discussion_r44400737"},"pull_request":{"href":"https://api.github.com/repos/dennyb87/pycity/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/dennyb87/pycity/pulls/9","id":50244262,"html_url":"https://github.com/dennyb87/pycity/pull/9","diff_url":"https://github.com/dennyb87/pycity/pull/9.diff","patch_url":"https://github.com/dennyb87/pycity/pull/9.patch","issue_url":"https://api.github.com/repos/dennyb87/pycity/issues/9","number":9,"state":"open","locked":false,"title":"Exercises week5 completed","user":{"login":"dennyb87","id":7195133,"avatar_url":"https://avatars.githubusercontent.com/u/7195133?v=3","gravatar_id":"","url":"https://api.github.com/users/dennyb87","html_url":"https://github.com/dennyb87","followers_url":"https://api.github.com/users/dennyb87/followers","following_url":"https://api.github.com/users/dennyb87/following{/other_user}","gists_url":"https://api.github.com/users/dennyb87/gists{/gist_id}","starred_url":"https://api.github.com/users/dennyb87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennyb87/subscriptions","organizations_url":"https://api.github.com/users/dennyb87/orgs","repos_url":"https://api.github.com/users/dennyb87/repos","events_url":"https://api.github.com/users/dennyb87/events{/privacy}","received_events_url":"https://api.github.com/users/dennyb87/received_events","type":"User","site_admin":false},"body":"I know is a lot of stuff, I know you are busy so take your time :)\r\nSee you later!\r\n\r\nPS:\r\nAlso because of my english I did not understand how I should use these funcions in card_validation exercise:\r\nprefixMatched, getSize, getPrefix\r\n\r\nI would also like to understand if it's possible to create a \"generic\" test for the card_validation exercise, because as you can see changing the card_number attribute it will break everything.","created_at":"2015-11-10T11:47:24Z","updated_at":"2015-11-10T12:32:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3409b12faac029b4362dfa7a3d6bdfd97f662cf","assignee":{"login":"matthieuchoplin","id":1380333,"avatar_url":"https://avatars.githubusercontent.com/u/1380333?v=3","gravatar_id":"","url":"https://api.github.com/users/matthieuchoplin","html_url":"https://github.com/matthieuchoplin","followers_url":"https://api.github.com/users/matthieuchoplin/followers","following_url":"https://api.github.com/users/matthieuchoplin/following{/other_user}","gists_url":"https://api.github.com/users/matthieuchoplin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthieuchoplin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthieuchoplin/subscriptions","organizations_url":"https://api.github.com/users/matthieuchoplin/orgs","repos_url":"https://api.github.com/users/matthieuchoplin/repos","events_url":"https://api.github.com/users/matthieuchoplin/events{/privacy}","received_events_url":"https://api.github.com/users/matthieuchoplin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dennyb87/pycity/pulls/9/commits","review_comments_url":"https://api.github.com/repos/dennyb87/pycity/pulls/9/comments","review_comment_url":"https://api.github.com/repos/dennyb87/pycity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dennyb87/pycity/issues/9/comments","statuses_url":"https://api.github.com/repos/dennyb87/pycity/statuses/9c07835a08fea7e72bfa2c4ce2f9242ec24ae3e2","head":{"label":"dennyb87:dev","ref":"dev","sha":"9c07835a08fea7e72bfa2c4ce2f9242ec24ae3e2","user":{"login":"dennyb87","id":7195133,"avatar_url":"https://avatars.githubusercontent.com/u/7195133?v=3","gravatar_id":"","url":"https://api.github.com/users/dennyb87","html_url":"https://github.com/dennyb87","followers_url":"https://api.github.com/users/dennyb87/followers","following_url":"https://api.github.com/users/dennyb87/following{/other_user}","gists_url":"https://api.github.com/users/dennyb87/gists{/gist_id}","starred_url":"https://api.github.com/users/dennyb87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennyb87/subscriptions","organizations_url":"https://api.github.com/users/dennyb87/orgs","repos_url":"https://api.github.com/users/dennyb87/repos","events_url":"https://api.github.com/users/dennyb87/events{/privacy}","received_events_url":"https://api.github.com/users/dennyb87/received_events","type":"User","site_admin":false},"repo":{"id":44674962,"name":"pycity","full_name":"dennyb87/pycity","owner":{"login":"dennyb87","id":7195133,"avatar_url":"https://avatars.githubusercontent.com/u/7195133?v=3","gravatar_id":"","url":"https://api.github.com/users/dennyb87","html_url":"https://github.com/dennyb87","followers_url":"https://api.github.com/users/dennyb87/followers","following_url":"https://api.github.com/users/dennyb87/following{/other_user}","gists_url":"https://api.github.com/users/dennyb87/gists{/gist_id}","starred_url":"https://api.github.com/users/dennyb87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennyb87/subscriptions","organizations_url":"https://api.github.com/users/dennyb87/orgs","repos_url":"https://api.github.com/users/dennyb87/repos","events_url":"https://api.github.com/users/dennyb87/events{/privacy}","received_events_url":"https://api.github.com/users/dennyb87/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dennyb87/pycity","description":"Collection of exercises from the python course at City University London","fork":false,"url":"https://api.github.com/repos/dennyb87/pycity","forks_url":"https://api.github.com/repos/dennyb87/pycity/forks","keys_url":"https://api.github.com/repos/dennyb87/pycity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dennyb87/pycity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dennyb87/pycity/teams","hooks_url":"https://api.github.com/repos/dennyb87/pycity/hooks","issue_events_url":"https://api.github.com/repos/dennyb87/pycity/issues/events{/number}","events_url":"https://api.github.com/repos/dennyb87/pycity/events","assignees_url":"https://api.github.com/repos/dennyb87/pycity/assignees{/user}","branches_url":"https://api.github.com/repos/dennyb87/pycity/branches{/branch}","tags_url":"https://api.github.com/repos/dennyb87/pycity/tags","blobs_url":"https://api.github.com/repos/dennyb87/pycity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dennyb87/pycity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dennyb87/pycity/git/refs{/sha}","trees_url":"https://api.github.com/repos/dennyb87/pycity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dennyb87/pycity/statuses/{sha}","languages_url":"https://api.github.com/repos/dennyb87/pycity/languages","stargazers_url":"https://api.github.com/repos/dennyb87/pycity/stargazers","contributors_url":"https://api.github.com/repos/dennyb87/pycity/contributors","subscribers_url":"https://api.github.com/repos/dennyb87/pycity/subscribers","subscription_url":"https://api.github.com/repos/dennyb87/pycity/subscription","commits_url":"https://api.github.com/repos/dennyb87/pycity/commits{/sha}","git_commits_url":"https://api.github.com/repos/dennyb87/pycity/git/commits{/sha}","comments_url":"https://api.github.com/repos/dennyb87/pycity/comments{/number}","issue_comment_url":"https://api.github.com/repos/dennyb87/pycity/issues/comments{/number}","contents_url":"https://api.github.com/repos/dennyb87/pycity/contents/{+path}","compare_url":"https://api.github.com/repos/dennyb87/pycity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dennyb87/pycity/merges","archive_url":"https://api.github.com/repos/dennyb87/pycity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dennyb87/pycity/downloads","issues_url":"https://api.github.com/repos/dennyb87/pycity/issues{/number}","pulls_url":"https://api.github.com/repos/dennyb87/pycity/pulls{/number}","milestones_url":"https://api.github.com/repos/dennyb87/pycity/milestones{/number}","notifications_url":"https://api.github.com/repos/dennyb87/pycity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dennyb87/pycity/labels{/name}","releases_url":"https://api.github.com/repos/dennyb87/pycity/releases{/id}","created_at":"2015-10-21T12:35:40Z","updated_at":"2015-10-23T15:52:07Z","pushed_at":"2015-11-10T11:47:25Z","git_url":"git://github.com/dennyb87/pycity.git","ssh_url":"git@github.com:dennyb87/pycity.git","clone_url":"https://github.com/dennyb87/pycity.git","svn_url":"https://github.com/dennyb87/pycity","homepage":null,"size":256,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"dennyb87:master","ref":"master","sha":"f7923ad1151be522ad0092800ced6a43f7ca84fe","user":{"login":"dennyb87","id":7195133,"avatar_url":"https://avatars.githubusercontent.com/u/7195133?v=3","gravatar_id":"","url":"https://api.github.com/users/dennyb87","html_url":"https://github.com/dennyb87","followers_url":"https://api.github.com/users/dennyb87/followers","following_url":"https://api.github.com/users/dennyb87/following{/other_user}","gists_url":"https://api.github.com/users/dennyb87/gists{/gist_id}","starred_url":"https://api.github.com/users/dennyb87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennyb87/subscriptions","organizations_url":"https://api.github.com/users/dennyb87/orgs","repos_url":"https://api.github.com/users/dennyb87/repos","events_url":"https://api.github.com/users/dennyb87/events{/privacy}","received_events_url":"https://api.github.com/users/dennyb87/received_events","type":"User","site_admin":false},"repo":{"id":44674962,"name":"pycity","full_name":"dennyb87/pycity","owner":{"login":"dennyb87","id":7195133,"avatar_url":"https://avatars.githubusercontent.com/u/7195133?v=3","gravatar_id":"","url":"https://api.github.com/users/dennyb87","html_url":"https://github.com/dennyb87","followers_url":"https://api.github.com/users/dennyb87/followers","following_url":"https://api.github.com/users/dennyb87/following{/other_user}","gists_url":"https://api.github.com/users/dennyb87/gists{/gist_id}","starred_url":"https://api.github.com/users/dennyb87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennyb87/subscriptions","organizations_url":"https://api.github.com/users/dennyb87/orgs","repos_url":"https://api.github.com/users/dennyb87/repos","events_url":"https://api.github.com/users/dennyb87/events{/privacy}","received_events_url":"https://api.github.com/users/dennyb87/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dennyb87/pycity","description":"Collection of exercises from the python course at City University London","fork":false,"url":"https://api.github.com/repos/dennyb87/pycity","forks_url":"https://api.github.com/repos/dennyb87/pycity/forks","keys_url":"https://api.github.com/repos/dennyb87/pycity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dennyb87/pycity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dennyb87/pycity/teams","hooks_url":"https://api.github.com/repos/dennyb87/pycity/hooks","issue_events_url":"https://api.github.com/repos/dennyb87/pycity/issues/events{/number}","events_url":"https://api.github.com/repos/dennyb87/pycity/events","assignees_url":"https://api.github.com/repos/dennyb87/pycity/assignees{/user}","branches_url":"https://api.github.com/repos/dennyb87/pycity/branches{/branch}","tags_url":"https://api.github.com/repos/dennyb87/pycity/tags","blobs_url":"https://api.github.com/repos/dennyb87/pycity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dennyb87/pycity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dennyb87/pycity/git/refs{/sha}","trees_url":"https://api.github.com/repos/dennyb87/pycity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dennyb87/pycity/statuses/{sha}","languages_url":"https://api.github.com/repos/dennyb87/pycity/languages","stargazers_url":"https://api.github.com/repos/dennyb87/pycity/stargazers","contributors_url":"https://api.github.com/repos/dennyb87/pycity/contributors","subscribers_url":"https://api.github.com/repos/dennyb87/pycity/subscribers","subscription_url":"https://api.github.com/repos/dennyb87/pycity/subscription","commits_url":"https://api.github.com/repos/dennyb87/pycity/commits{/sha}","git_commits_url":"https://api.github.com/repos/dennyb87/pycity/git/commits{/sha}","comments_url":"https://api.github.com/repos/dennyb87/pycity/comments{/number}","issue_comment_url":"https://api.github.com/repos/dennyb87/pycity/issues/comments{/number}","contents_url":"https://api.github.com/repos/dennyb87/pycity/contents/{+path}","compare_url":"https://api.github.com/repos/dennyb87/pycity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dennyb87/pycity/merges","archive_url":"https://api.github.com/repos/dennyb87/pycity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dennyb87/pycity/downloads","issues_url":"https://api.github.com/repos/dennyb87/pycity/issues{/number}","pulls_url":"https://api.github.com/repos/dennyb87/pycity/pulls{/number}","milestones_url":"https://api.github.com/repos/dennyb87/pycity/milestones{/number}","notifications_url":"https://api.github.com/repos/dennyb87/pycity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dennyb87/pycity/labels{/name}","releases_url":"https://api.github.com/repos/dennyb87/pycity/releases{/id}","created_at":"2015-10-21T12:35:40Z","updated_at":"2015-10-23T15:52:07Z","pushed_at":"2015-11-10T11:47:25Z","git_url":"git://github.com/dennyb87/pycity.git","ssh_url":"git@github.com:dennyb87/pycity.git","clone_url":"https://github.com/dennyb87/pycity.git","svn_url":"https://github.com/dennyb87/pycity","homepage":null,"size":256,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dennyb87/pycity/pulls/9"},"html":{"href":"https://github.com/dennyb87/pycity/pull/9"},"issue":{"href":"https://api.github.com/repos/dennyb87/pycity/issues/9"},"comments":{"href":"https://api.github.com/repos/dennyb87/pycity/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/dennyb87/pycity/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/dennyb87/pycity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dennyb87/pycity/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/dennyb87/pycity/statuses/9c07835a08fea7e72bfa2c4ce2f9242ec24ae3e2"}}}}