{"action":"created","comment":{"url":"https://api.github.com/repos/gaia-components/gaia-header/pulls/comments/22462718","id":22462718,"diff_hunk":"@@ -1,5 +1,25 @@\n ;(function(define){'use strict';define(function(require,exports,module){\n \n+  /* This map holds values specific to a heading.\n+   * The key is the heading node itself. Because it's a WeakMap, it should be\n+   * freed by the GC when the node is removed from the DOM.\n+   */\n+  var privMap = new WeakMap();\n+\n+  function getPriv(instance) {","path":"lib/font-fit.js","position":9,"original_position":9,"commit_id":"2335cc4ce2fbf25a7b7ee375b9637fa6db591dc9","original_commit_id":"2335cc4ce2fbf25a7b7ee375b9637fa6db591dc9","user":{"login":"wilsonpage","id":1020551,"avatar_url":"https://avatars.githubusercontent.com/u/1020551?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonpage","html_url":"https://github.com/wilsonpage","followers_url":"https://api.github.com/users/wilsonpage/followers","following_url":"https://api.github.com/users/wilsonpage/following{/other_user}","gists_url":"https://api.github.com/users/wilsonpage/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonpage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonpage/subscriptions","organizations_url":"https://api.github.com/users/wilsonpage/orgs","repos_url":"https://api.github.com/users/wilsonpage/repos","events_url":"https://api.github.com/users/wilsonpage/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonpage/received_events","type":"User","site_admin":false},"body":"This seems like quite a complicated way to cache `start` and `end` attributes? Can't we just store them on the heading instance?\r\n\r\n```js\r\nheading.dataset.start = start;\r\nheading.dataset.end = end;\r\n```","created_at":"2015-01-05T14:28:08Z","updated_at":"2015-01-05T14:28:08Z","html_url":"https://github.com/gaia-components/gaia-header/pull/16#discussion_r22462718","pull_request_url":"https://api.github.com/repos/gaia-components/gaia-header/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/gaia-components/gaia-header/pulls/comments/22462718"},"html":{"href":"https://github.com/gaia-components/gaia-header/pull/16#discussion_r22462718"},"pull_request":{"href":"https://api.github.com/repos/gaia-components/gaia-header/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/gaia-components/gaia-header/pulls/16","id":26333696,"html_url":"https://github.com/gaia-components/gaia-header/pull/16","diff_url":"https://github.com/gaia-components/gaia-header/pull/16.diff","patch_url":"https://github.com/gaia-components/gaia-header/pull/16.patch","issue_url":"https://api.github.com/repos/gaia-components/gaia-header/issues/16","number":16,"state":"open","locked":false,"title":"Bug 1112131 - Start end attributes rtl friendly","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-18T21:35:56Z","updated_at":"2015-01-05T14:28:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c50adaa606bcb8ca771afd234d3aa0f777ec6610","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gaia-components/gaia-header/pulls/16/commits","review_comments_url":"https://api.github.com/repos/gaia-components/gaia-header/pulls/16/comments","review_comment_url":"https://api.github.com/repos/gaia-components/gaia-header/pulls/comments/{number}","comments_url":"https://api.github.com/repos/gaia-components/gaia-header/issues/16/comments","statuses_url":"https://api.github.com/repos/gaia-components/gaia-header/statuses/2335cc4ce2fbf25a7b7ee375b9637fa6db591dc9","head":{"label":"julienw:start-end-attributes-rtl-friendly","ref":"start-end-attributes-rtl-friendly","sha":"2335cc4ce2fbf25a7b7ee375b9637fa6db591dc9","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"repo":{"id":26873457,"name":"gaia-header","full_name":"julienw/gaia-header","owner":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julienw/gaia-header","description":"","fork":true,"url":"https://api.github.com/repos/julienw/gaia-header","forks_url":"https://api.github.com/repos/julienw/gaia-header/forks","keys_url":"https://api.github.com/repos/julienw/gaia-header/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julienw/gaia-header/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julienw/gaia-header/teams","hooks_url":"https://api.github.com/repos/julienw/gaia-header/hooks","issue_events_url":"https://api.github.com/repos/julienw/gaia-header/issues/events{/number}","events_url":"https://api.github.com/repos/julienw/gaia-header/events","assignees_url":"https://api.github.com/repos/julienw/gaia-header/assignees{/user}","branches_url":"https://api.github.com/repos/julienw/gaia-header/branches{/branch}","tags_url":"https://api.github.com/repos/julienw/gaia-header/tags","blobs_url":"https://api.github.com/repos/julienw/gaia-header/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julienw/gaia-header/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julienw/gaia-header/git/refs{/sha}","trees_url":"https://api.github.com/repos/julienw/gaia-header/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julienw/gaia-header/statuses/{sha}","languages_url":"https://api.github.com/repos/julienw/gaia-header/languages","stargazers_url":"https://api.github.com/repos/julienw/gaia-header/stargazers","contributors_url":"https://api.github.com/repos/julienw/gaia-header/contributors","subscribers_url":"https://api.github.com/repos/julienw/gaia-header/subscribers","subscription_url":"https://api.github.com/repos/julienw/gaia-header/subscription","commits_url":"https://api.github.com/repos/julienw/gaia-header/commits{/sha}","git_commits_url":"https://api.github.com/repos/julienw/gaia-header/git/commits{/sha}","comments_url":"https://api.github.com/repos/julienw/gaia-header/comments{/number}","issue_comment_url":"https://api.github.com/repos/julienw/gaia-header/issues/comments/{number}","contents_url":"https://api.github.com/repos/julienw/gaia-header/contents/{+path}","compare_url":"https://api.github.com/repos/julienw/gaia-header/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julienw/gaia-header/merges","archive_url":"https://api.github.com/repos/julienw/gaia-header/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julienw/gaia-header/downloads","issues_url":"https://api.github.com/repos/julienw/gaia-header/issues{/number}","pulls_url":"https://api.github.com/repos/julienw/gaia-header/pulls{/number}","milestones_url":"https://api.github.com/repos/julienw/gaia-header/milestones{/number}","notifications_url":"https://api.github.com/repos/julienw/gaia-header/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julienw/gaia-header/labels{/name}","releases_url":"https://api.github.com/repos/julienw/gaia-header/releases{/id}","created_at":"2014-11-19T17:42:46Z","updated_at":"2014-11-19T17:42:46Z","pushed_at":"2015-01-05T12:26:32Z","git_url":"git://github.com/julienw/gaia-header.git","ssh_url":"git@github.com:julienw/gaia-header.git","clone_url":"https://github.com/julienw/gaia-header.git","svn_url":"https://github.com/julienw/gaia-header","homepage":null,"size":434,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gaia-components:master","ref":"master","sha":"c30afb3c7b2cfc0c0bd598cf22c32df5077e257e","user":{"login":"gaia-components","id":7851599,"avatar_url":"https://avatars.githubusercontent.com/u/7851599?v=3","gravatar_id":"","url":"https://api.github.com/users/gaia-components","html_url":"https://github.com/gaia-components","followers_url":"https://api.github.com/users/gaia-components/followers","following_url":"https://api.github.com/users/gaia-components/following{/other_user}","gists_url":"https://api.github.com/users/gaia-components/gists{/gist_id}","starred_url":"https://api.github.com/users/gaia-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaia-components/subscriptions","organizations_url":"https://api.github.com/users/gaia-components/orgs","repos_url":"https://api.github.com/users/gaia-components/repos","events_url":"https://api.github.com/users/gaia-components/events{/privacy}","received_events_url":"https://api.github.com/users/gaia-components/received_events","type":"Organization","site_admin":false},"repo":{"id":20662827,"name":"gaia-header","full_name":"gaia-components/gaia-header","owner":{"login":"gaia-components","id":7851599,"avatar_url":"https://avatars.githubusercontent.com/u/7851599?v=3","gravatar_id":"","url":"https://api.github.com/users/gaia-components","html_url":"https://github.com/gaia-components","followers_url":"https://api.github.com/users/gaia-components/followers","following_url":"https://api.github.com/users/gaia-components/following{/other_user}","gists_url":"https://api.github.com/users/gaia-components/gists{/gist_id}","starred_url":"https://api.github.com/users/gaia-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaia-components/subscriptions","organizations_url":"https://api.github.com/users/gaia-components/orgs","repos_url":"https://api.github.com/users/gaia-components/repos","events_url":"https://api.github.com/users/gaia-components/events{/privacy}","received_events_url":"https://api.github.com/users/gaia-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gaia-components/gaia-header","description":"","fork":false,"url":"https://api.github.com/repos/gaia-components/gaia-header","forks_url":"https://api.github.com/repos/gaia-components/gaia-header/forks","keys_url":"https://api.github.com/repos/gaia-components/gaia-header/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaia-components/gaia-header/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaia-components/gaia-header/teams","hooks_url":"https://api.github.com/repos/gaia-components/gaia-header/hooks","issue_events_url":"https://api.github.com/repos/gaia-components/gaia-header/issues/events{/number}","events_url":"https://api.github.com/repos/gaia-components/gaia-header/events","assignees_url":"https://api.github.com/repos/gaia-components/gaia-header/assignees{/user}","branches_url":"https://api.github.com/repos/gaia-components/gaia-header/branches{/branch}","tags_url":"https://api.github.com/repos/gaia-components/gaia-header/tags","blobs_url":"https://api.github.com/repos/gaia-components/gaia-header/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaia-components/gaia-header/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaia-components/gaia-header/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaia-components/gaia-header/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaia-components/gaia-header/statuses/{sha}","languages_url":"https://api.github.com/repos/gaia-components/gaia-header/languages","stargazers_url":"https://api.github.com/repos/gaia-components/gaia-header/stargazers","contributors_url":"https://api.github.com/repos/gaia-components/gaia-header/contributors","subscribers_url":"https://api.github.com/repos/gaia-components/gaia-header/subscribers","subscription_url":"https://api.github.com/repos/gaia-components/gaia-header/subscription","commits_url":"https://api.github.com/repos/gaia-components/gaia-header/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaia-components/gaia-header/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaia-components/gaia-header/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaia-components/gaia-header/issues/comments/{number}","contents_url":"https://api.github.com/repos/gaia-components/gaia-header/contents/{+path}","compare_url":"https://api.github.com/repos/gaia-components/gaia-header/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaia-components/gaia-header/merges","archive_url":"https://api.github.com/repos/gaia-components/gaia-header/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaia-components/gaia-header/downloads","issues_url":"https://api.github.com/repos/gaia-components/gaia-header/issues{/number}","pulls_url":"https://api.github.com/repos/gaia-components/gaia-header/pulls{/number}","milestones_url":"https://api.github.com/repos/gaia-components/gaia-header/milestones{/number}","notifications_url":"https://api.github.com/repos/gaia-components/gaia-header/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaia-components/gaia-header/labels{/name}","releases_url":"https://api.github.com/repos/gaia-components/gaia-header/releases{/id}","created_at":"2014-06-09T21:27:31Z","updated_at":"2015-01-05T10:28:53Z","pushed_at":"2015-01-05T10:28:53Z","git_url":"git://github.com/gaia-components/gaia-header.git","ssh_url":"git@github.com:gaia-components/gaia-header.git","clone_url":"https://github.com/gaia-components/gaia-header.git","svn_url":"https://github.com/gaia-components/gaia-header","homepage":null,"size":1764,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":6,"forks":12,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gaia-components/gaia-header/pulls/16"},"html":{"href":"https://github.com/gaia-components/gaia-header/pull/16"},"issue":{"href":"https://api.github.com/repos/gaia-components/gaia-header/issues/16"},"comments":{"href":"https://api.github.com/repos/gaia-components/gaia-header/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/gaia-components/gaia-header/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/gaia-components/gaia-header/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/gaia-components/gaia-header/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/gaia-components/gaia-header/statuses/2335cc4ce2fbf25a7b7ee375b9637fa6db591dc9"}}}}