{"action":"closed","number":22785,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/22785","id":54548834,"html_url":"https://github.com/rails/rails/pull/22785","diff_url":"https://github.com/rails/rails/pull/22785.diff","patch_url":"https://github.com/rails/rails/pull/22785.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/22785","number":22785,"state":"closed","locked":false,"title":"Improve documentation for `config.ssl_options`","user":{"login":"timrogers","id":116134,"avatar_url":"https://avatars.githubusercontent.com/u/116134?v=3","gravatar_id":"","url":"https://api.github.com/users/timrogers","html_url":"https://github.com/timrogers","followers_url":"https://api.github.com/users/timrogers/followers","following_url":"https://api.github.com/users/timrogers/following{/other_user}","gists_url":"https://api.github.com/users/timrogers/gists{/gist_id}","starred_url":"https://api.github.com/users/timrogers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timrogers/subscriptions","organizations_url":"https://api.github.com/users/timrogers/orgs","repos_url":"https://api.github.com/users/timrogers/repos","events_url":"https://api.github.com/users/timrogers/events{/privacy}","received_events_url":"https://api.github.com/users/timrogers/received_events","type":"User","site_admin":false},"body":"There's not much documentation around about how to use `config.ssl_options` (and even its existence is seldom mentioned). It's really helpful, especially if you want to customise the behaviour for HSTS in `ActionDispatch::SSL` (enabled by `config.force_ssl`).\r\n\r\nThis PR improves the documentation in the guides, and makes the comments in the code more comprehensible, and fixes an error which refers to deprecated means of configuration.","created_at":"2015-12-24T12:36:35Z","updated_at":"2015-12-24T22:58:10Z","closed_at":"2015-12-24T22:58:09Z","merged_at":"2015-12-24T22:58:09Z","merge_commit_sha":"f2142b3757a17d389362ae35d6e3cf1aac43db0c","assignee":{"login":"schneems","id":59744,"avatar_url":"https://avatars.githubusercontent.com/u/59744?v=3","gravatar_id":"","url":"https://api.github.com/users/schneems","html_url":"https://github.com/schneems","followers_url":"https://api.github.com/users/schneems/followers","following_url":"https://api.github.com/users/schneems/following{/other_user}","gists_url":"https://api.github.com/users/schneems/gists{/gist_id}","starred_url":"https://api.github.com/users/schneems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneems/subscriptions","organizations_url":"https://api.github.com/users/schneems/orgs","repos_url":"https://api.github.com/users/schneems/repos","events_url":"https://api.github.com/users/schneems/events{/privacy}","received_events_url":"https://api.github.com/users/schneems/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/22785/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/22785/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/22785/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/9e0fa4cddd55f9ba71b073f52c5e9ab231a39856","head":{"label":"timrogers:master","ref":"master","sha":"9e0fa4cddd55f9ba71b073f52c5e9ab231a39856","user":{"login":"timrogers","id":116134,"avatar_url":"https://avatars.githubusercontent.com/u/116134?v=3","gravatar_id":"","url":"https://api.github.com/users/timrogers","html_url":"https://github.com/timrogers","followers_url":"https://api.github.com/users/timrogers/followers","following_url":"https://api.github.com/users/timrogers/following{/other_user}","gists_url":"https://api.github.com/users/timrogers/gists{/gist_id}","starred_url":"https://api.github.com/users/timrogers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timrogers/subscriptions","organizations_url":"https://api.github.com/users/timrogers/orgs","repos_url":"https://api.github.com/users/timrogers/repos","events_url":"https://api.github.com/users/timrogers/events{/privacy}","received_events_url":"https://api.github.com/users/timrogers/received_events","type":"User","site_admin":false},"repo":{"id":48541453,"name":"rails","full_name":"timrogers/rails","owner":{"login":"timrogers","id":116134,"avatar_url":"https://avatars.githubusercontent.com/u/116134?v=3","gravatar_id":"","url":"https://api.github.com/users/timrogers","html_url":"https://github.com/timrogers","followers_url":"https://api.github.com/users/timrogers/followers","following_url":"https://api.github.com/users/timrogers/following{/other_user}","gists_url":"https://api.github.com/users/timrogers/gists{/gist_id}","starred_url":"https://api.github.com/users/timrogers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timrogers/subscriptions","organizations_url":"https://api.github.com/users/timrogers/orgs","repos_url":"https://api.github.com/users/timrogers/repos","events_url":"https://api.github.com/users/timrogers/events{/privacy}","received_events_url":"https://api.github.com/users/timrogers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timrogers/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/timrogers/rails","forks_url":"https://api.github.com/repos/timrogers/rails/forks","keys_url":"https://api.github.com/repos/timrogers/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timrogers/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timrogers/rails/teams","hooks_url":"https://api.github.com/repos/timrogers/rails/hooks","issue_events_url":"https://api.github.com/repos/timrogers/rails/issues/events{/number}","events_url":"https://api.github.com/repos/timrogers/rails/events","assignees_url":"https://api.github.com/repos/timrogers/rails/assignees{/user}","branches_url":"https://api.github.com/repos/timrogers/rails/branches{/branch}","tags_url":"https://api.github.com/repos/timrogers/rails/tags","blobs_url":"https://api.github.com/repos/timrogers/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timrogers/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timrogers/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/timrogers/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timrogers/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/timrogers/rails/languages","stargazers_url":"https://api.github.com/repos/timrogers/rails/stargazers","contributors_url":"https://api.github.com/repos/timrogers/rails/contributors","subscribers_url":"https://api.github.com/repos/timrogers/rails/subscribers","subscription_url":"https://api.github.com/repos/timrogers/rails/subscription","commits_url":"https://api.github.com/repos/timrogers/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/timrogers/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/timrogers/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/timrogers/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/timrogers/rails/contents/{+path}","compare_url":"https://api.github.com/repos/timrogers/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timrogers/rails/merges","archive_url":"https://api.github.com/repos/timrogers/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timrogers/rails/downloads","issues_url":"https://api.github.com/repos/timrogers/rails/issues{/number}","pulls_url":"https://api.github.com/repos/timrogers/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/timrogers/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/timrogers/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timrogers/rails/labels{/name}","releases_url":"https://api.github.com/repos/timrogers/rails/releases{/id}","created_at":"2015-12-24T12:15:45Z","updated_at":"2015-12-24T12:16:48Z","pushed_at":"2015-12-24T17:43:16Z","git_url":"git://github.com/timrogers/rails.git","ssh_url":"git@github.com:timrogers/rails.git","clone_url":"https://github.com/timrogers/rails.git","svn_url":"https://github.com/timrogers/rails","homepage":"http://rubyonrails.org","size":122237,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"fefd76e82af28decb895c22bbe1bbf265a2a8b75","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2015-12-24T16:09:16Z","pushed_at":"2015-12-24T22:58:10Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":320001,"stargazers_count":28873,"watchers_count":28873,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11697,"mirror_url":null,"open_issues_count":851,"forks":11697,"open_issues":851,"watchers":28873,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/22785"},"html":{"href":"https://github.com/rails/rails/pull/22785"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/22785"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/22785/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/22785/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/22785/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/9e0fa4cddd55f9ba71b073f52c5e9ab231a39856"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"schneems","id":59744,"avatar_url":"https://avatars.githubusercontent.com/u/59744?v=3","gravatar_id":"","url":"https://api.github.com/users/schneems","html_url":"https://github.com/schneems","followers_url":"https://api.github.com/users/schneems/followers","following_url":"https://api.github.com/users/schneems/following{/other_user}","gists_url":"https://api.github.com/users/schneems/gists{/gist_id}","starred_url":"https://api.github.com/users/schneems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneems/subscriptions","organizations_url":"https://api.github.com/users/schneems/orgs","repos_url":"https://api.github.com/users/schneems/repos","events_url":"https://api.github.com/users/schneems/events{/privacy}","received_events_url":"https://api.github.com/users/schneems/received_events","type":"User","site_admin":false},"comments":2,"review_comments":2,"commits":2,"additions":16,"deletions":14,"changed_files":2}}