{"push_id":902986633,"size":20,"distinct_size":1,"ref":"refs/heads/spencerkimball/update-hwt","head":"d97e9adddae8e5f546bdf6d5b982dd7b24bf82f4","before":"bf94f44cb3511bfbe0022ff95798d486630d6324","commits":[{"sha":"6d7cef95137616394e7b96ef5d13d496a54ab957","author":{"email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com","name":"Peter Mattis"},"message":"Replace check for static binaries.\n\nThe old check is no longer valid since we're linking glibc\ndynamically. Now we check that there are no unexpected shared libraries.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/6d7cef95137616394e7b96ef5d13d496a54ab957"},{"sha":"0a4e12b05ede1acee48f6f839443924b6c932c2c","author":{"email":"45aefc834abf4b6844854d63a474b67e53b69671@gmail.com","name":"Spencer Kimball"},"message":"Guard against endless forwarding loops and bottomless bootstraps\n\nA situation arose in AWS testing where a node received a forwards\nto nodes which were already full, in large part because that node\nwas already connected to each. Also, gossip was not protecting\nnodes from connecting to themselves. We now ignore forwarding\nresponses which direct to an already-connected node, either\nincoming or outgoing.\n\nAlso rejiggered the logging to indicate nodes in most cases and\nnode addresses only where helpful. Added a unittest for the case\nof a node connecting to itself.\n\nAlso now preventing endless bootstrap attempts (via load balancer)\nfrom connecting to the same client. We now enforce a single local\naddress per node ID. Added unittest.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/0a4e12b05ede1acee48f6f839443924b6c932c2c"},{"sha":"2f3a1df96045c9368c052f8cabbc7cbdd67c584f","author":{"email":"4b8373d016f277527198385ba72fda0feb5da015@cockroachlabs.com","name":"Peter Mattis"},"message":"Merge pull request #3416 from cockroachdb/pmattis/build-static-binaries\n\nRemove check for static binaries.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/2f3a1df96045c9368c052f8cabbc7cbdd67c584f"},{"sha":"b4a03039f3ce60dcd92407277d141c08d714e931","author":{"email":"45aefc834abf4b6844854d63a474b67e53b69671@gmail.com","name":"Spencer Kimball"},"message":"Merge pull request #3393 from cockroachdb/spencerkimball/gossip-prod-issues\n\nGuard against any endless gossip forwarding loops.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/b4a03039f3ce60dcd92407277d141c08d714e931"},{"sha":"8bdea3d0d27dcc443bb50896c416dd9850135a30","author":{"email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com","name":"Peter Mattis"},"message":"Update dependencies.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/8bdea3d0d27dcc443bb50896c416dd9850135a30"},{"sha":"4aca712d213137634325c0f5a96749fd3b2b0d52","author":{"email":"45aefc834abf4b6844854d63a474b67e53b69671@gmail.com","name":"Spencer Kimball"},"message":"Update README.md\n\nUpdated title description of CockroachDB","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/4aca712d213137634325c0f5a96749fd3b2b0d52"},{"sha":"59bd9c02576ffe3b18b746a43d410e6c0e13d9b6","author":{"email":"4b8373d016f277527198385ba72fda0feb5da015@cockroachlabs.com","name":"Peter Mattis"},"message":"Merge pull request #3420 from cockroachdb/pmattis/glockfile\n\nUpdate dependencies.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/59bd9c02576ffe3b18b746a43d410e6c0e13d9b6"},{"sha":"5ca652618d28508d55f9c1ca99ad18dfc7d569f3","author":{"email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com","name":"Peter Mattis"},"message":"Fix a bit of test flakiness.\n\nSome of the kv tests were overwriting client.DefaultTxnRetryOptions and\nsetting MaxRetries to 2. This was fine for those tests, but not for\nsubsequent tests. This manifested as RPCs failing due to an unhealthy\nclient. Now tests that need to change client.DefaultTxnRetryOptions our\ngood citizens and reset it back to its original value.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/5ca652618d28508d55f9c1ca99ad18dfc7d569f3"},{"sha":"c8cb2576a8d04ff9909a92268a32b50659bf2ec2","author":{"email":"4b8373d016f277527198385ba72fda0feb5da015@cockroachlabs.com","name":"Peter Mattis"},"message":"Merge pull request #3421 from cockroachdb/pmattis/kv-test-flakiness\n\nFix a bit of test flakiness.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/c8cb2576a8d04ff9909a92268a32b50659bf2ec2"},{"sha":"80b5efd5d0f5ce110b742cee5d72a4750fed94d7","author":{"email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com","name":"Peter Mattis"},"message":"Output the offending json when it cannot be parsed.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/80b5efd5d0f5ce110b742cee5d72a4750fed94d7"},{"sha":"a38f5f746fe18ea2c53d6e52e6f471cc02cf5fbd","author":{"email":"4b8373d016f277527198385ba72fda0feb5da015@cockroachlabs.com","name":"Peter Mattis"},"message":"Merge pull request #3423 from cockroachdb/pmattis/debug-test-build-info\n\nOutput the offending json when it cannot be parsed.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/a38f5f746fe18ea2c53d6e52e6f471cc02cf5fbd"},{"sha":"f2ded031ded59ee4e2682812e005c7f6e4a7aff7","author":{"email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com","name":"Tobias Schottdorf"},"message":"no more busybox\n\nwith an image that links `glibc`.\nalso reinstated running the acceptance tests\nagainst the generated deply image. this appears\nto have been lost somewhere during restructuring.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/f2ded031ded59ee4e2682812e005c7f6e4a7aff7"},{"sha":"a73deea1ef54787a2f4e7d545525533cd946ac88","author":{"email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com","name":"Tobias Schottdorf"},"message":"Merge pull request #3427 from tschottdorf/fix_docker\n\nno more busybox","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/a73deea1ef54787a2f4e7d545525533cd946ac88"},{"sha":"1a6ce81222eeabaf779ed09e9d6f69805c4e43bf","author":{"email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com","name":"Tobias Schottdorf"},"message":"fix up acceptance invocation\n\nbotched this in the last PR.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/1a6ce81222eeabaf779ed09e9d6f69805c4e43bf"},{"sha":"bb9d31643b1e66a1c120130c709ecf26b0beb925","author":{"email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com","name":"Tobias Schottdorf"},"message":"Merge pull request #3429 from tschottdorf/fix_acceptance\n\nfix up acceptance invocation","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/bb9d31643b1e66a1c120130c709ecf26b0beb925"},{"sha":"0864cb6f7f71c6dce03b63b9ea657d963d90145b","author":{"email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com","name":"Tobias Schottdorf"},"message":"another acceptance fix\n\nmy last fix still didn't do the trick.\n\nDoesn't work (test doesn't realize that `-num-local` is set)\n`time acceptance/acceptance.test -test.v -test.timeout 5m \\ -i cockroachdb/cockroach -num-local 3`\n\nworks (note the removed `\\`):\n`time acceptance/acceptance.test -test.v -test.timeout 5m  -i cockroachdb/cockroach -num-local 3`\n\nI think the newlines don't count in `yaml` and so we're trying to escape a\nsimple space, but there's nothing to escape and we get a literal backslash.\nThat ends the flag parsing, and so this was broken.\n\nAdditionally, there's no condition here to fail the test run. We rely on the\nfile `excerpt.txt`, but that is created and checked in `circle-test.sh`.\nThis seems ripe for some refactoring by anyone interested.\n\nFor now, I'm just going to run the test directly and without any piping that\nwould obscure the exit code.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/0864cb6f7f71c6dce03b63b9ea657d963d90145b"},{"sha":"1d33352e3b00dd3ecd5be910697884a1f0383bce","author":{"email":"25fad7a39062a81fcaf88abd782f9f69679c0bdf@gmail.com","name":"Tobias Schottdorf"},"message":"Merge pull request #3430 from tschottdorf/fix_acceptance_for_reals\n\nanother acceptance fix","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/1d33352e3b00dd3ecd5be910697884a1f0383bce"},{"sha":"ea15121d5af9309ca9e08694fe4f409f6f2de6a6","author":{"email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com","name":"Peter Mattis"},"message":"Mark table_descriptor_lease as completed.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/ea15121d5af9309ca9e08694fe4f409f6f2de6a6"},{"sha":"9ab7621d373735a673055308b230ed96229d37ca","author":{"email":"4b8373d016f277527198385ba72fda0feb5da015@cockroachlabs.com","name":"Peter Mattis"},"message":"Merge pull request #3433 from cockroachdb/pmattis/table-descriptor-lease-rfc\n\nMark table_descriptor_lease as completed.","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/9ab7621d373735a673055308b230ed96229d37ca"},{"sha":"d97e9adddae8e5f546bdf6d5b982dd7b24bf82f4","author":{"email":"45aefc834abf4b6844854d63a474b67e53b69671@gmail.com","name":"Spencer Kimball"},"message":"Always pass in updated high water timestamp map when pushing gossip\n\nThis reduces a lot of unnecessary passing of unfresh infos. By as much\nas 3x, though I expect the number to be higher as the number of nodes\nincreases.","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/d97e9adddae8e5f546bdf6d5b982dd7b24bf82f4"}]}