{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/37096751","id":37096751,"diff_hunk":"@@ -296,26 +296,31 @@ void SampleUtil::convertS16ToFloat32(CSAMPLE* _RESTRICT pDest, const SAMPLE* _RE\n }\n \n // static\n-bool SampleUtil::sumAbsPerChannel(CSAMPLE* pfAbsL, CSAMPLE* pfAbsR,\n+SampleUtil::CLIPPING SampleUtil::sumAbsPerChannel(CSAMPLE* pfAbsL, CSAMPLE* pfAbsR,\n         const CSAMPLE* pBuffer, int iNumSamples) {\n     CSAMPLE fAbsL = CSAMPLE_ZERO;\n     CSAMPLE fAbsR = CSAMPLE_ZERO;\n-    CSAMPLE clipped = 0;\n+    CSAMPLE clippedL = 0;\n+    CSAMPLE clippedR = 0;","path":"src/sampleutil.cpp","position":11,"original_position":11,"commit_id":"38b25fa1b1144d24243592717769fff4d9261bca","original_commit_id":"e7205122626ec1b8a4f5185d1a43cf9652de98a0","user":{"login":"ywwg","id":888940,"avatar_url":"https://avatars.githubusercontent.com/u/888940?v=3","gravatar_id":"","url":"https://api.github.com/users/ywwg","html_url":"https://github.com/ywwg","followers_url":"https://api.github.com/users/ywwg/followers","following_url":"https://api.github.com/users/ywwg/following{/other_user}","gists_url":"https://api.github.com/users/ywwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ywwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywwg/subscriptions","organizations_url":"https://api.github.com/users/ywwg/orgs","repos_url":"https://api.github.com/users/ywwg/repos","events_url":"https://api.github.com/users/ywwg/events{/privacy}","received_events_url":"https://api.github.com/users/ywwg/received_events","type":"User","site_admin":false},"body":"he means that you don't need two CSAMPLES for holding the clipped value, you just OR the appropriate value when a clipped value is detected\r\n\r\nif (sample[0] is clipped) { clipped |= CLIPPING_LEFT; }\r\nif (sample[1] is clipped) { clipped |= CLIPPING RIGHT;} ","created_at":"2015-08-14T17:08:51Z","updated_at":"2015-08-14T17:08:51Z","html_url":"https://github.com/mixxxdj/mixxx/pull/674#discussion_r37096751","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/674","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/37096751"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/674#discussion_r37096751"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/674"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/674","id":41961350,"html_url":"https://github.com/mixxxdj/mixxx/pull/674","diff_url":"https://github.com/mixxxdj/mixxx/pull/674.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/674.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/674","number":674,"state":"open","locked":false,"title":"Deere vu meters + PeakIndicator[L/R] CO + vu meter tooltips improvements ","user":{"login":"ferranpujolcamins","id":6429775,"avatar_url":"https://avatars.githubusercontent.com/u/6429775?v=3","gravatar_id":"","url":"https://api.github.com/users/ferranpujolcamins","html_url":"https://github.com/ferranpujolcamins","followers_url":"https://api.github.com/users/ferranpujolcamins/followers","following_url":"https://api.github.com/users/ferranpujolcamins/following{/other_user}","gists_url":"https://api.github.com/users/ferranpujolcamins/gists{/gist_id}","starred_url":"https://api.github.com/users/ferranpujolcamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferranpujolcamins/subscriptions","organizations_url":"https://api.github.com/users/ferranpujolcamins/orgs","repos_url":"https://api.github.com/users/ferranpujolcamins/repos","events_url":"https://api.github.com/users/ferranpujolcamins/events{/privacy}","received_events_url":"https://api.github.com/users/ferranpujolcamins/received_events","type":"User","site_admin":false},"body":"Hello! I've added channel vu-meters to Deere. Since there were space for L and R channel vu-meters, I've also created \"PeakIndicatorL\" and \"PeakIndicatorr\" control objects, which were missing. I've propagated this to the master clipping indicators on LateNight and Shade.\r\n\r\nI've also updated to vu-meter tooltips in all three skins.\r\n\r\nI'm sorry for the mixed PR, but theses things were very related. I've tried to make small simple commits, I hope you will be able to review this easily.","created_at":"2015-08-08T22:04:45Z","updated_at":"2015-08-14T17:08:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"711b9e34b04f7661a0cd1f8602f22c4a2ababacb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/674/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/674/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/674/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/38b25fa1b1144d24243592717769fff4d9261bca","head":{"label":"ferranpujolcamins:Deere-VU-Meters","ref":"Deere-VU-Meters","sha":"38b25fa1b1144d24243592717769fff4d9261bca","user":{"login":"ferranpujolcamins","id":6429775,"avatar_url":"https://avatars.githubusercontent.com/u/6429775?v=3","gravatar_id":"","url":"https://api.github.com/users/ferranpujolcamins","html_url":"https://github.com/ferranpujolcamins","followers_url":"https://api.github.com/users/ferranpujolcamins/followers","following_url":"https://api.github.com/users/ferranpujolcamins/following{/other_user}","gists_url":"https://api.github.com/users/ferranpujolcamins/gists{/gist_id}","starred_url":"https://api.github.com/users/ferranpujolcamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferranpujolcamins/subscriptions","organizations_url":"https://api.github.com/users/ferranpujolcamins/orgs","repos_url":"https://api.github.com/users/ferranpujolcamins/repos","events_url":"https://api.github.com/users/ferranpujolcamins/events{/privacy}","received_events_url":"https://api.github.com/users/ferranpujolcamins/received_events","type":"User","site_admin":false},"repo":{"id":24024558,"name":"mixxx","full_name":"ferranpujolcamins/mixxx","owner":{"login":"ferranpujolcamins","id":6429775,"avatar_url":"https://avatars.githubusercontent.com/u/6429775?v=3","gravatar_id":"","url":"https://api.github.com/users/ferranpujolcamins","html_url":"https://github.com/ferranpujolcamins","followers_url":"https://api.github.com/users/ferranpujolcamins/followers","following_url":"https://api.github.com/users/ferranpujolcamins/following{/other_user}","gists_url":"https://api.github.com/users/ferranpujolcamins/gists{/gist_id}","starred_url":"https://api.github.com/users/ferranpujolcamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferranpujolcamins/subscriptions","organizations_url":"https://api.github.com/users/ferranpujolcamins/orgs","repos_url":"https://api.github.com/users/ferranpujolcamins/repos","events_url":"https://api.github.com/users/ferranpujolcamins/events{/privacy}","received_events_url":"https://api.github.com/users/ferranpujolcamins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferranpujolcamins/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/ferranpujolcamins/mixxx","forks_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/forks","keys_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/teams","hooks_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/hooks","issue_events_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/events","assignees_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/tags","blobs_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/languages","stargazers_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/stargazers","contributors_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/contributors","subscribers_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/subscribers","subscription_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/subscription","commits_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/merges","archive_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/downloads","issues_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/ferranpujolcamins/mixxx/releases{/id}","created_at":"2014-09-14T14:51:40Z","updated_at":"2015-04-20T18:07:35Z","pushed_at":"2015-08-14T00:09:14Z","git_url":"git://github.com/ferranpujolcamins/mixxx.git","ssh_url":"git@github.com:ferranpujolcamins/mixxx.git","clone_url":"https://github.com/ferranpujolcamins/mixxx.git","svn_url":"https://github.com/ferranpujolcamins/mixxx","homepage":"http://mixxx.org","size":251809,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:1.12","ref":"1.12","sha":"47639ad2e8230502d014e719817e1825cdfd72fd","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","created_at":"2013-05-17T15:14:38Z","updated_at":"2015-08-13T13:56:17Z","pushed_at":"2015-08-14T00:09:15Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":327778,"stargazers_count":341,"watchers_count":341,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":230,"mirror_url":null,"open_issues_count":58,"forks":230,"open_issues":58,"watchers":341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/674"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/674"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/674"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/674/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/674/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/674/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/38b25fa1b1144d24243592717769fff4d9261bca"}}}}