{"push_id":623910326,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"aec9699c1be9485a05eda9c7bcec9d768b86fbfd","before":"963d63585955cbb48e1a8eaed8725c7c1590a541","commits":[{"sha":"aec9699c1be9485a05eda9c7bcec9d768b86fbfd","author":{"email":"2535ff6dd8d6ee039abf6cb23d587c980803da82@redhat.com","name":"Shmuel Melamud"},"message":"engine: Removed AddVmPoolCommand class\n\nRemoved AddVmPoolCommand class, because it is no longer used:\n\n1. VdcActionType.AddVmPool is never used.\n2. CommonVmPoolWithVmsCommand extends AddVmPoolCommand, but this\n   inheritance is useless:\n  a. AddVmPoolCommand.executeCommand() is never called from\n     CommonVmPoolWithVmsCommand.executeCommand(), the same work is done\n     by AddVmPoolWithVmsCommand.getPoolId().\n  b. AddVmPoolCommand.getAuditLogTypeValue() is never called.\n  c. AddVmPoolCommand.getValidationGroups() does the same as\n     AddVmPoolWithVmsCommand.getValidationGroups() and was merged to\n     UpdateVmPoolWithVmsCommand.getValidationGroups().\n  d. AddVmPoolCommand() constructor code is merged to\n     CommonVmPoolWithVmsCommand() constructor.\n3. The hierarchy where UpdateVmPoolWithVmsCommand is inherited\n   indirectly from AddVmPoolCommand seems illogical.\n\nChange-Id: I6941ff975c7051d14a077dc7126b59b5e0fea114\nSigned-off-by: Shmuel Melamud <smelamud@redhat.com>","distinct":true,"url":"https://api.github.com/repos/oVirt/ovirt-engine/commits/aec9699c1be9485a05eda9c7bcec9d768b86fbfd"}]}