{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/26251585","id":26251585,"diff_hunk":"@@ -193,6 +193,7 @@ struct ExecutorStats {\n   1: required map<string, map<string, i64>> emitted;\n   2: required map<string, map<string, i64>> transferred;\n   3: required ExecutorSpecificStats specific;\n+  4: required double rate;","path":"storm-core/src/storm.thrift","position":4,"original_position":4,"commit_id":"5a66bb6d2ffbae8c1b7ea929dcb256413bee5b50","original_commit_id":"539a6a21464acada9d051b3d5ce67990ffa2a239","user":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"body":"Older client newer server works, newer client with older server brakes because rate is required behavior. I think this is acceptable and would hate to change a required param to optional to support this.","created_at":"2015-03-11T20:24:35Z","updated_at":"2015-03-11T20:24:35Z","html_url":"https://github.com/apache/storm/pull/414#discussion_r26251585","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/414","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/26251585"},"html":{"href":"https://github.com/apache/storm/pull/414#discussion_r26251585"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/414"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/414","id":28583297,"html_url":"https://github.com/apache/storm/pull/414","diff_url":"https://github.com/apache/storm/pull/414.diff","patch_url":"https://github.com/apache/storm/pull/414.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/414","number":414,"state":"open","locked":false,"title":"STORM-634: Storm serialization changed to thrift to support rolling upgrade.","user":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"body":" Converting SupervisorInfo,Assignment,StormBase,TopologyStatus,ZKWorkerHeartbeat,ErrorInfo,Credentials to thrift and defaulting the serialization delegate to thrift serialization. Added class as a param to serialization delegate interface.","created_at":"2015-02-03T19:56:30Z","updated_at":"2015-03-11T20:24:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa214dcec4cb77c893c1c10509cc7830725dd1f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/414/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/414/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/414/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/5a66bb6d2ffbae8c1b7ea929dcb256413bee5b50","head":{"label":"Parth-Brahmbhatt:STORM-634","ref":"STORM-634","sha":"5a66bb6d2ffbae8c1b7ea929dcb256413bee5b50","user":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"repo":{"id":20899571,"name":"incubator-storm","full_name":"Parth-Brahmbhatt/incubator-storm","owner":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Parth-Brahmbhatt/incubator-storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm","forks_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/forks","keys_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/teams","hooks_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/hooks","issue_events_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/issues/events{/number}","events_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/events","assignees_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/assignees{/user}","branches_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/branches{/branch}","tags_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/tags","blobs_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/statuses/{sha}","languages_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/languages","stargazers_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/stargazers","contributors_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/contributors","subscribers_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/subscribers","subscription_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/subscription","commits_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/contents/{+path}","compare_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/merges","archive_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/downloads","issues_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/issues{/number}","pulls_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/pulls{/number}","milestones_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/milestones{/number}","notifications_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/labels{/name}","releases_url":"https://api.github.com/repos/Parth-Brahmbhatt/incubator-storm/releases{/id}","created_at":"2014-06-16T20:27:09Z","updated_at":"2015-01-14T20:29:44Z","pushed_at":"2015-03-11T20:04:51Z","git_url":"git://github.com/Parth-Brahmbhatt/incubator-storm.git","ssh_url":"git@github.com:Parth-Brahmbhatt/incubator-storm.git","clone_url":"https://github.com/Parth-Brahmbhatt/incubator-storm.git","svn_url":"https://github.com/Parth-Brahmbhatt/incubator-storm","homepage":null,"size":19762,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"5eff2e761cc8c981a82e46333b72810d2ed5c5c6","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","created_at":"2013-11-05T08:00:14Z","updated_at":"2015-03-11T20:10:34Z","pushed_at":"2015-03-11T20:10:33Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":861198,"stargazers_count":1639,"watchers_count":1639,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1054,"mirror_url":"git://git.apache.org/incubator-storm.git","open_issues_count":57,"forks":1054,"open_issues":57,"watchers":1639,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/414"},"html":{"href":"https://github.com/apache/storm/pull/414"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/414"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/414/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/414/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/414/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/5a66bb6d2ffbae8c1b7ea929dcb256413bee5b50"}}}}