{"action":"created","comment":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments/37703913","id":37703913,"diff_hunk":"@@ -18,4 +18,11 @@\n     inspect_source(cop, '# AZaz1@$%~,;*_`|')\n     expect(cop.offenses).to be_empty\n   end\n+\n+  it 'accepts comments with one non-ascii character' do","path":"spec/rubocop/cop/style/ascii_comments_spec.rb","position":5,"original_position":5,"commit_id":"98c89ca97bb0216c1203ec670f9828e222a265cf","original_commit_id":"98c89ca97bb0216c1203ec670f9828e222a265cf","user":{"login":"jonas054","id":336720,"avatar_url":"https://avatars.githubusercontent.com/u/336720?v=3","gravatar_id":"","url":"https://api.github.com/users/jonas054","html_url":"https://github.com/jonas054","followers_url":"https://api.github.com/users/jonas054/followers","following_url":"https://api.github.com/users/jonas054/following{/other_user}","gists_url":"https://api.github.com/users/jonas054/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas054/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas054/subscriptions","organizations_url":"https://api.github.com/users/jonas054/orgs","repos_url":"https://api.github.com/users/jonas054/repos","events_url":"https://api.github.com/users/jonas054/events{/privacy}","received_events_url":"https://api.github.com/users/jonas054/received_events","type":"User","site_admin":false},"body":"Perhaps \"accepts comments with no more than one consecutive non-ascii character\".","created_at":"2015-08-23T08:47:50Z","updated_at":"2015-08-23T08:47:50Z","html_url":"https://github.com/bbatsov/rubocop/pull/2156#discussion_r37703913","pull_request_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/2156","_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments/37703913"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/2156#discussion_r37703913"},"pull_request":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/2156"}}},"pull_request":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/2156","id":42686870,"html_url":"https://github.com/bbatsov/rubocop/pull/2156","diff_url":"https://github.com/bbatsov/rubocop/pull/2156.diff","patch_url":"https://github.com/bbatsov/rubocop/pull/2156.patch","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/2156","number":2156,"state":"open","locked":false,"title":"Allow individual non ASCII characters in comments","user":{"login":"agrimm","id":20378,"avatar_url":"https://avatars.githubusercontent.com/u/20378?v=3","gravatar_id":"","url":"https://api.github.com/users/agrimm","html_url":"https://github.com/agrimm","followers_url":"https://api.github.com/users/agrimm/followers","following_url":"https://api.github.com/users/agrimm/following{/other_user}","gists_url":"https://api.github.com/users/agrimm/gists{/gist_id}","starred_url":"https://api.github.com/users/agrimm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrimm/subscriptions","organizations_url":"https://api.github.com/users/agrimm/orgs","repos_url":"https://api.github.com/users/agrimm/repos","events_url":"https://api.github.com/users/agrimm/events{/privacy}","received_events_url":"https://api.github.com/users/agrimm/received_events","type":"User","site_admin":false},"body":"I agree with https://github.com/bbatsov/ruby-style-guide#english-comments , but I sometimes have code falling foul of the cop for individual characters, such as a Euro symbol or a smart apostrophe. This allows one non-ASCII character at a time.\r\n\r\nThis doesn't have the number of non-ASCII characters configurable, but I don't see a good rationale for allowing more than one character at a time without turning the cop off.","created_at":"2015-08-18T11:16:41Z","updated_at":"2015-08-23T08:47:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"415c10466b3bf2e74275361f58ed02cd400d1d1f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/2156/commits","review_comments_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/2156/comments","review_comment_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/2156/comments","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/98c89ca97bb0216c1203ec670f9828e222a265cf","head":{"label":"agrimm:allow_single_non_ascii","ref":"allow_single_non_ascii","sha":"98c89ca97bb0216c1203ec670f9828e222a265cf","user":{"login":"agrimm","id":20378,"avatar_url":"https://avatars.githubusercontent.com/u/20378?v=3","gravatar_id":"","url":"https://api.github.com/users/agrimm","html_url":"https://github.com/agrimm","followers_url":"https://api.github.com/users/agrimm/followers","following_url":"https://api.github.com/users/agrimm/following{/other_user}","gists_url":"https://api.github.com/users/agrimm/gists{/gist_id}","starred_url":"https://api.github.com/users/agrimm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrimm/subscriptions","organizations_url":"https://api.github.com/users/agrimm/orgs","repos_url":"https://api.github.com/users/agrimm/repos","events_url":"https://api.github.com/users/agrimm/events{/privacy}","received_events_url":"https://api.github.com/users/agrimm/received_events","type":"User","site_admin":false},"repo":{"id":13911232,"name":"rubocop","full_name":"agrimm/rubocop","owner":{"login":"agrimm","id":20378,"avatar_url":"https://avatars.githubusercontent.com/u/20378?v=3","gravatar_id":"","url":"https://api.github.com/users/agrimm","html_url":"https://github.com/agrimm","followers_url":"https://api.github.com/users/agrimm/followers","following_url":"https://api.github.com/users/agrimm/following{/other_user}","gists_url":"https://api.github.com/users/agrimm/gists{/gist_id}","starred_url":"https://api.github.com/users/agrimm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrimm/subscriptions","organizations_url":"https://api.github.com/users/agrimm/orgs","repos_url":"https://api.github.com/users/agrimm/repos","events_url":"https://api.github.com/users/agrimm/events{/privacy}","received_events_url":"https://api.github.com/users/agrimm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agrimm/rubocop","description":"An experimental Ruby code analyzer, based on the community Ruby style guide.","fork":true,"url":"https://api.github.com/repos/agrimm/rubocop","forks_url":"https://api.github.com/repos/agrimm/rubocop/forks","keys_url":"https://api.github.com/repos/agrimm/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agrimm/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agrimm/rubocop/teams","hooks_url":"https://api.github.com/repos/agrimm/rubocop/hooks","issue_events_url":"https://api.github.com/repos/agrimm/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/agrimm/rubocop/events","assignees_url":"https://api.github.com/repos/agrimm/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/agrimm/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/agrimm/rubocop/tags","blobs_url":"https://api.github.com/repos/agrimm/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agrimm/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agrimm/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/agrimm/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agrimm/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/agrimm/rubocop/languages","stargazers_url":"https://api.github.com/repos/agrimm/rubocop/stargazers","contributors_url":"https://api.github.com/repos/agrimm/rubocop/contributors","subscribers_url":"https://api.github.com/repos/agrimm/rubocop/subscribers","subscription_url":"https://api.github.com/repos/agrimm/rubocop/subscription","commits_url":"https://api.github.com/repos/agrimm/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/agrimm/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/agrimm/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/agrimm/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/agrimm/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/agrimm/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agrimm/rubocop/merges","archive_url":"https://api.github.com/repos/agrimm/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agrimm/rubocop/downloads","issues_url":"https://api.github.com/repos/agrimm/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/agrimm/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/agrimm/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/agrimm/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agrimm/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/agrimm/rubocop/releases{/id}","created_at":"2013-10-27T22:04:55Z","updated_at":"2014-06-21T06:19:46Z","pushed_at":"2015-08-18T11:27:02Z","git_url":"git://github.com/agrimm/rubocop.git","ssh_url":"git@github.com:agrimm/rubocop.git","clone_url":"https://github.com/agrimm/rubocop.git","svn_url":"https://github.com/agrimm/rubocop","homepage":"http://batsov.com/rubocop","size":9845,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bbatsov:master","ref":"master","sha":"e210464059f7d68bb2c6735e517d68bb3a26d6b5","user":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=3","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"repo":{"id":4095287,"name":"rubocop","full_name":"bbatsov/rubocop","owner":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=3","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbatsov/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":false,"url":"https://api.github.com/repos/bbatsov/rubocop","forks_url":"https://api.github.com/repos/bbatsov/rubocop/forks","keys_url":"https://api.github.com/repos/bbatsov/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbatsov/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbatsov/rubocop/teams","hooks_url":"https://api.github.com/repos/bbatsov/rubocop/hooks","issue_events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/bbatsov/rubocop/events","assignees_url":"https://api.github.com/repos/bbatsov/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/bbatsov/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/bbatsov/rubocop/tags","blobs_url":"https://api.github.com/repos/bbatsov/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbatsov/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbatsov/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbatsov/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/bbatsov/rubocop/languages","stargazers_url":"https://api.github.com/repos/bbatsov/rubocop/stargazers","contributors_url":"https://api.github.com/repos/bbatsov/rubocop/contributors","subscribers_url":"https://api.github.com/repos/bbatsov/rubocop/subscribers","subscription_url":"https://api.github.com/repos/bbatsov/rubocop/subscription","commits_url":"https://api.github.com/repos/bbatsov/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbatsov/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbatsov/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/bbatsov/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbatsov/rubocop/merges","archive_url":"https://api.github.com/repos/bbatsov/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbatsov/rubocop/downloads","issues_url":"https://api.github.com/repos/bbatsov/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/bbatsov/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/bbatsov/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/bbatsov/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbatsov/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/bbatsov/rubocop/releases{/id}","created_at":"2012-04-21T10:09:58Z","updated_at":"2015-08-23T03:18:10Z","pushed_at":"2015-08-23T08:39:16Z","git_url":"git://github.com/bbatsov/rubocop.git","ssh_url":"git@github.com:bbatsov/rubocop.git","clone_url":"https://github.com/bbatsov/rubocop.git","svn_url":"https://github.com/bbatsov/rubocop","homepage":"","size":21420,"stargazers_count":4983,"watchers_count":4983,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":566,"mirror_url":null,"open_issues_count":107,"forks":566,"open_issues":107,"watchers":4983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/2156"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/2156"},"issue":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/2156"},"comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/2156/comments"},"review_comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/2156/comments"},"review_comment":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/2156/commits"},"statuses":{"href":"https://api.github.com/repos/bbatsov/rubocop/statuses/98c89ca97bb0216c1203ec670f9828e222a265cf"}}}}