{"action":"created","comment":{"url":"https://api.github.com/repos/NICTA/nationalmap/pulls/comments/28484664","id":28484664,"diff_hunk":"@@ -59,20 +65,43 @@ var CsvCatalogItem = function(application, url) {\n     this.data = undefined;\n \n     /**\n-     * Gets or sets the URL from which the {@link CsvCatalogItem#data} was obtained.\n-     * @type {String}\n+     * Gets or sets the tableStyle object\n+     * @type {Object}\n      */\n-    this.dataSourceUrl = undefined;\n+    this.tableStyle = undefined;\n \n-    /**\n-     * Gets or sets a value indicating whether data points in the CSV are color-coded based on the\n-     * value column.\n-     * @type {Boolean}\n-     * @default true\n+   /**\n+     * Gets or sets the opacity (alpha) of the data item, where 0.0 is fully transparent and 1.0 is\n+     * fully opaque.  This property is observable.\n+     * @type {Number}\n+     * @default 0.6\n      */\n-    this.colorByValue = true;\n+    this.opacity = 0.6;\n \n-    knockout.track(this, ['url', 'data', 'dataSourceUrl', 'colorByValue']);\n+    knockout.track(this, ['url', 'data', 'tableStyle', 'opacity', '_clock']);\n+\n+    knockout.getObservable(this, 'opacity').subscribe(function(newValue) {\n+        updateOpacity(this);\n+    }, this);\n+\n+    delete this.__knockoutObservables.clock;","path":"src/Models/CsvCatalogItem.js","position":68,"original_position":68,"commit_id":"91abcff056b5eb285d519917bb29f239bd2fa703","original_commit_id":"91abcff056b5eb285d519917bb29f239bd2fa703","user":{"login":"kring","id":924374,"avatar_url":"https://avatars.githubusercontent.com/u/924374?v=3","gravatar_id":"","url":"https://api.github.com/users/kring","html_url":"https://github.com/kring","followers_url":"https://api.github.com/users/kring/followers","following_url":"https://api.github.com/users/kring/following{/other_user}","gists_url":"https://api.github.com/users/kring/gists{/gist_id}","starred_url":"https://api.github.com/users/kring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kring/subscriptions","organizations_url":"https://api.github.com/users/kring/orgs","repos_url":"https://api.github.com/users/kring/repos","events_url":"https://api.github.com/users/kring/events{/privacy}","received_events_url":"https://api.github.com/users/kring/received_events","type":"User","site_admin":false},"body":"I guess this was copied from `ImageryLayerCatalogItem`, but the clock property's getter there has special logic that is absent here.","created_at":"2015-04-16T05:26:11Z","updated_at":"2015-04-16T05:26:11Z","html_url":"https://github.com/NICTA/nationalmap/pull/635#discussion_r28484664","pull_request_url":"https://api.github.com/repos/NICTA/nationalmap/pulls/635","_links":{"self":{"href":"https://api.github.com/repos/NICTA/nationalmap/pulls/comments/28484664"},"html":{"href":"https://github.com/NICTA/nationalmap/pull/635#discussion_r28484664"},"pull_request":{"href":"https://api.github.com/repos/NICTA/nationalmap/pulls/635"}}},"pull_request":{"url":"https://api.github.com/repos/NICTA/nationalmap/pulls/635","id":33415475,"html_url":"https://github.com/NICTA/nationalmap/pull/635","diff_url":"https://github.com/NICTA/nationalmap/pull/635.diff","patch_url":"https://github.com/NICTA/nationalmap/pull/635.patch","issue_url":"https://api.github.com/repos/NICTA/nationalmap/issues/635","number":635,"state":"open","locked":false,"title":"Region mapping updates","user":{"login":"kgrochow","id":2225249,"avatar_url":"https://avatars.githubusercontent.com/u/2225249?v=3","gravatar_id":"","url":"https://api.github.com/users/kgrochow","html_url":"https://github.com/kgrochow","followers_url":"https://api.github.com/users/kgrochow/followers","following_url":"https://api.github.com/users/kgrochow/following{/other_user}","gists_url":"https://api.github.com/users/kgrochow/gists{/gist_id}","starred_url":"https://api.github.com/users/kgrochow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgrochow/subscriptions","organizations_url":"https://api.github.com/users/kgrochow/orgs","repos_url":"https://api.github.com/users/kgrochow/repos","events_url":"https://api.github.com/users/kgrochow/events{/privacy}","received_events_url":"https://api.github.com/users/kgrochow/received_events","type":"User","site_admin":false},"body":"To make the abs merge a bit more manageable, this is the updates to the CsvCatalogItem and everything below it.  New stuff\r\n - region mapping based on string region ids (example in countries.csv)\r\n - time based region mapping (example in droughts.csv)\r\n - table styling in init file (examples in test.json and in DataTable docs)\r\n - general refactor of TableDataSource, DataTable, and DataVariable\r\n - Improved legend visuals to go with the now viewing panel\r\n - added country regions\r\n - added country region test files\r\n - cleaned up existing test csv files (date formats mainly)","created_at":"2015-04-16T03:04:26Z","updated_at":"2015-04-16T05:26:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6af388e12e31139ebb1ce6d227359ec7c8e0598f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NICTA/nationalmap/pulls/635/commits","review_comments_url":"https://api.github.com/repos/NICTA/nationalmap/pulls/635/comments","review_comment_url":"https://api.github.com/repos/NICTA/nationalmap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NICTA/nationalmap/issues/635/comments","statuses_url":"https://api.github.com/repos/NICTA/nationalmap/statuses/91abcff056b5eb285d519917bb29f239bd2fa703","head":{"label":"NICTA:regionMappingUpdates","ref":"regionMappingUpdates","sha":"91abcff056b5eb285d519917bb29f239bd2fa703","user":{"login":"NICTA","id":1151968,"avatar_url":"https://avatars.githubusercontent.com/u/1151968?v=3","gravatar_id":"","url":"https://api.github.com/users/NICTA","html_url":"https://github.com/NICTA","followers_url":"https://api.github.com/users/NICTA/followers","following_url":"https://api.github.com/users/NICTA/following{/other_user}","gists_url":"https://api.github.com/users/NICTA/gists{/gist_id}","starred_url":"https://api.github.com/users/NICTA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NICTA/subscriptions","organizations_url":"https://api.github.com/users/NICTA/orgs","repos_url":"https://api.github.com/users/NICTA/repos","events_url":"https://api.github.com/users/NICTA/events{/privacy}","received_events_url":"https://api.github.com/users/NICTA/received_events","type":"Organization","site_admin":false},"repo":{"id":17163720,"name":"nationalmap","full_name":"NICTA/nationalmap","owner":{"login":"NICTA","id":1151968,"avatar_url":"https://avatars.githubusercontent.com/u/1151968?v=3","gravatar_id":"","url":"https://api.github.com/users/NICTA","html_url":"https://github.com/NICTA","followers_url":"https://api.github.com/users/NICTA/followers","following_url":"https://api.github.com/users/NICTA/following{/other_user}","gists_url":"https://api.github.com/users/NICTA/gists{/gist_id}","starred_url":"https://api.github.com/users/NICTA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NICTA/subscriptions","organizations_url":"https://api.github.com/users/NICTA/orgs","repos_url":"https://api.github.com/users/NICTA/repos","events_url":"https://api.github.com/users/NICTA/events{/privacy}","received_events_url":"https://api.github.com/users/NICTA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NICTA/nationalmap","description":"","fork":false,"url":"https://api.github.com/repos/NICTA/nationalmap","forks_url":"https://api.github.com/repos/NICTA/nationalmap/forks","keys_url":"https://api.github.com/repos/NICTA/nationalmap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NICTA/nationalmap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NICTA/nationalmap/teams","hooks_url":"https://api.github.com/repos/NICTA/nationalmap/hooks","issue_events_url":"https://api.github.com/repos/NICTA/nationalmap/issues/events{/number}","events_url":"https://api.github.com/repos/NICTA/nationalmap/events","assignees_url":"https://api.github.com/repos/NICTA/nationalmap/assignees{/user}","branches_url":"https://api.github.com/repos/NICTA/nationalmap/branches{/branch}","tags_url":"https://api.github.com/repos/NICTA/nationalmap/tags","blobs_url":"https://api.github.com/repos/NICTA/nationalmap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NICTA/nationalmap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NICTA/nationalmap/git/refs{/sha}","trees_url":"https://api.github.com/repos/NICTA/nationalmap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NICTA/nationalmap/statuses/{sha}","languages_url":"https://api.github.com/repos/NICTA/nationalmap/languages","stargazers_url":"https://api.github.com/repos/NICTA/nationalmap/stargazers","contributors_url":"https://api.github.com/repos/NICTA/nationalmap/contributors","subscribers_url":"https://api.github.com/repos/NICTA/nationalmap/subscribers","subscription_url":"https://api.github.com/repos/NICTA/nationalmap/subscription","commits_url":"https://api.github.com/repos/NICTA/nationalmap/commits{/sha}","git_commits_url":"https://api.github.com/repos/NICTA/nationalmap/git/commits{/sha}","comments_url":"https://api.github.com/repos/NICTA/nationalmap/comments{/number}","issue_comment_url":"https://api.github.com/repos/NICTA/nationalmap/issues/comments{/number}","contents_url":"https://api.github.com/repos/NICTA/nationalmap/contents/{+path}","compare_url":"https://api.github.com/repos/NICTA/nationalmap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NICTA/nationalmap/merges","archive_url":"https://api.github.com/repos/NICTA/nationalmap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NICTA/nationalmap/downloads","issues_url":"https://api.github.com/repos/NICTA/nationalmap/issues{/number}","pulls_url":"https://api.github.com/repos/NICTA/nationalmap/pulls{/number}","milestones_url":"https://api.github.com/repos/NICTA/nationalmap/milestones{/number}","notifications_url":"https://api.github.com/repos/NICTA/nationalmap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NICTA/nationalmap/labels{/name}","releases_url":"https://api.github.com/repos/NICTA/nationalmap/releases{/id}","created_at":"2014-02-25T06:30:13Z","updated_at":"2015-04-16T04:41:29Z","pushed_at":"2015-04-16T05:11:49Z","git_url":"git://github.com/NICTA/nationalmap.git","ssh_url":"git@github.com:NICTA/nationalmap.git","clone_url":"https://github.com/NICTA/nationalmap.git","svn_url":"https://github.com/NICTA/nationalmap","homepage":null,"size":48610,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":60,"forks":16,"open_issues":60,"watchers":23,"default_branch":"master"}},"base":{"label":"NICTA:master","ref":"master","sha":"17f55260bd59ca17c1b6b5c3782bcaddf6e54962","user":{"login":"NICTA","id":1151968,"avatar_url":"https://avatars.githubusercontent.com/u/1151968?v=3","gravatar_id":"","url":"https://api.github.com/users/NICTA","html_url":"https://github.com/NICTA","followers_url":"https://api.github.com/users/NICTA/followers","following_url":"https://api.github.com/users/NICTA/following{/other_user}","gists_url":"https://api.github.com/users/NICTA/gists{/gist_id}","starred_url":"https://api.github.com/users/NICTA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NICTA/subscriptions","organizations_url":"https://api.github.com/users/NICTA/orgs","repos_url":"https://api.github.com/users/NICTA/repos","events_url":"https://api.github.com/users/NICTA/events{/privacy}","received_events_url":"https://api.github.com/users/NICTA/received_events","type":"Organization","site_admin":false},"repo":{"id":17163720,"name":"nationalmap","full_name":"NICTA/nationalmap","owner":{"login":"NICTA","id":1151968,"avatar_url":"https://avatars.githubusercontent.com/u/1151968?v=3","gravatar_id":"","url":"https://api.github.com/users/NICTA","html_url":"https://github.com/NICTA","followers_url":"https://api.github.com/users/NICTA/followers","following_url":"https://api.github.com/users/NICTA/following{/other_user}","gists_url":"https://api.github.com/users/NICTA/gists{/gist_id}","starred_url":"https://api.github.com/users/NICTA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NICTA/subscriptions","organizations_url":"https://api.github.com/users/NICTA/orgs","repos_url":"https://api.github.com/users/NICTA/repos","events_url":"https://api.github.com/users/NICTA/events{/privacy}","received_events_url":"https://api.github.com/users/NICTA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NICTA/nationalmap","description":"","fork":false,"url":"https://api.github.com/repos/NICTA/nationalmap","forks_url":"https://api.github.com/repos/NICTA/nationalmap/forks","keys_url":"https://api.github.com/repos/NICTA/nationalmap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NICTA/nationalmap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NICTA/nationalmap/teams","hooks_url":"https://api.github.com/repos/NICTA/nationalmap/hooks","issue_events_url":"https://api.github.com/repos/NICTA/nationalmap/issues/events{/number}","events_url":"https://api.github.com/repos/NICTA/nationalmap/events","assignees_url":"https://api.github.com/repos/NICTA/nationalmap/assignees{/user}","branches_url":"https://api.github.com/repos/NICTA/nationalmap/branches{/branch}","tags_url":"https://api.github.com/repos/NICTA/nationalmap/tags","blobs_url":"https://api.github.com/repos/NICTA/nationalmap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NICTA/nationalmap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NICTA/nationalmap/git/refs{/sha}","trees_url":"https://api.github.com/repos/NICTA/nationalmap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NICTA/nationalmap/statuses/{sha}","languages_url":"https://api.github.com/repos/NICTA/nationalmap/languages","stargazers_url":"https://api.github.com/repos/NICTA/nationalmap/stargazers","contributors_url":"https://api.github.com/repos/NICTA/nationalmap/contributors","subscribers_url":"https://api.github.com/repos/NICTA/nationalmap/subscribers","subscription_url":"https://api.github.com/repos/NICTA/nationalmap/subscription","commits_url":"https://api.github.com/repos/NICTA/nationalmap/commits{/sha}","git_commits_url":"https://api.github.com/repos/NICTA/nationalmap/git/commits{/sha}","comments_url":"https://api.github.com/repos/NICTA/nationalmap/comments{/number}","issue_comment_url":"https://api.github.com/repos/NICTA/nationalmap/issues/comments{/number}","contents_url":"https://api.github.com/repos/NICTA/nationalmap/contents/{+path}","compare_url":"https://api.github.com/repos/NICTA/nationalmap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NICTA/nationalmap/merges","archive_url":"https://api.github.com/repos/NICTA/nationalmap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NICTA/nationalmap/downloads","issues_url":"https://api.github.com/repos/NICTA/nationalmap/issues{/number}","pulls_url":"https://api.github.com/repos/NICTA/nationalmap/pulls{/number}","milestones_url":"https://api.github.com/repos/NICTA/nationalmap/milestones{/number}","notifications_url":"https://api.github.com/repos/NICTA/nationalmap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NICTA/nationalmap/labels{/name}","releases_url":"https://api.github.com/repos/NICTA/nationalmap/releases{/id}","created_at":"2014-02-25T06:30:13Z","updated_at":"2015-04-16T04:41:29Z","pushed_at":"2015-04-16T05:11:49Z","git_url":"git://github.com/NICTA/nationalmap.git","ssh_url":"git@github.com:NICTA/nationalmap.git","clone_url":"https://github.com/NICTA/nationalmap.git","svn_url":"https://github.com/NICTA/nationalmap","homepage":null,"size":48610,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":60,"forks":16,"open_issues":60,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NICTA/nationalmap/pulls/635"},"html":{"href":"https://github.com/NICTA/nationalmap/pull/635"},"issue":{"href":"https://api.github.com/repos/NICTA/nationalmap/issues/635"},"comments":{"href":"https://api.github.com/repos/NICTA/nationalmap/issues/635/comments"},"review_comments":{"href":"https://api.github.com/repos/NICTA/nationalmap/pulls/635/comments"},"review_comment":{"href":"https://api.github.com/repos/NICTA/nationalmap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NICTA/nationalmap/pulls/635/commits"},"statuses":{"href":"https://api.github.com/repos/NICTA/nationalmap/statuses/91abcff056b5eb285d519917bb29f239bd2fa703"}}}}