{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3528","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3528/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3528/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3528/events","html_url":"https://github.com/ManageIQ/manageiq/pull/3528","id":96077201,"number":3528,"title":"[WIP] numeric report charts","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-07-20T14:31:59Z","updated_at":"2015-07-21T14:50:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3528","html_url":"https://github.com/ManageIQ/manageiq/pull/3528","diff_url":"https://github.com/ManageIQ/manageiq/pull/3528.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/3528.patch"},"body":"Work towards numeric report charts...\r\n\r\n![chart_num_dim1](https://cloud.githubusercontent.com/assets/51095/8778215/c96485f8-2efc-11e5-9680-9bd3df0452c9.png)\r\n![chart_num_dim2](https://cloud.githubusercontent.com/assets/51095/8778218/cc8c29de-2efc-11e5-8199-bec93ee1e077.png)\r\n![chart_num_dim2-cols](https://cloud.githubusercontent.com/assets/51095/8778219/ce9a5034-2efc-11e5-9249-429d1e682389.png)\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/123355061","html_url":"https://github.com/ManageIQ/manageiq/pull/3528#issuecomment-123355061","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3528","id":123355061,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2015-07-21T14:50:50Z","updated_at":"2015-07-21T14:50:50Z","body":"<rubocop />Checked commits https://github.com/martinpovolny/manageiq/commit/5e26c14d8605c9b2be0c9b0210f0fa1a7cacb6ba .. https://github.com/martinpovolny/manageiq/commit/01e6d4d343585ef427202f417368d45fa2b09790 with rubocop 0.32.0\n7 files checked, 43 offenses detected\n\n**vmdb/app/controllers/report_controller/reports/editor.rb**\n- [ ] :large_orange_diamond: - [Line 747](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/app/controllers/report_controller/reports/editor.rb#L747), Col 36 - [Style/SpaceAroundOperators](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/SpaceAroundOperators) - Operator `||=` should be surrounded with a single space.\n- [ ] :large_orange_diamond: - [Line 748](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/app/controllers/report_controller/reports/editor.rb#L748), Col 36 - [Style/SpaceAroundOperators](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/SpaceAroundOperators) - Operator `||=` should be surrounded with a single space.\n- [ ] :large_orange_diamond: - [Line 1481](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/app/controllers/report_controller/reports/editor.rb#L1481), Col 5 - [Style/IndentationWidth](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/IndentationWidth) - Use 2 (not 0) spaces for indentation.\n- [ ] :large_orange_diamond: - [Line 1482](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/app/controllers/report_controller/reports/editor.rb#L1482), Col 7 - [Style/IndentationConsistency](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/IndentationConsistency) - Inconsistent indentation detected.\n- [ ] :large_orange_diamond: - [Line 1483](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/app/controllers/report_controller/reports/editor.rb#L1483), Col 7 - [Style/IndentationConsistency](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/IndentationConsistency) - Inconsistent indentation detected.\n- [ ] :large_orange_diamond: - [Line 1484](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/app/controllers/report_controller/reports/editor.rb#L1484), Col 7 - [Style/IndentationConsistency](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/IndentationConsistency) - Inconsistent indentation detected.\n- [ ] :large_orange_diamond: - [Line 1485](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/app/controllers/report_controller/reports/editor.rb#L1485), Col 7 - [Style/IndentationConsistency](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/IndentationConsistency) - Inconsistent indentation detected.\n\n**vmdb/app/helpers/report_helper.rb**\n- [ ] :large_orange_diamond: - [Line 29](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/app/helpers/report_helper.rb#L29), Col 1 - [Style/EmptyLines](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/EmptyLines) - Extra blank line detected.\n\n**vmdb/app/views/report/_form_chart.html.haml**\n- [ ] :red_circle: **Warn** - [Line 22](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/app/views/report/_form_chart.html.haml#L22), Col  -  - Style/WordArray: Use `%w` or `%W` for array of words.\n- [ ] :red_circle: **Warn** - [Line 22](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/app/views/report/_form_chart.html.haml#L22), Col  -  - Style/WordArray: Use `%w` or `%W` for array of words.\n- [ ] :red_circle: **Warn** - [Line 23](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/app/views/report/_form_chart.html.haml#L23), Col  -  - Line is too long. [103/80]\n- [ ] :red_circle: **Warn** - [Line 34](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/app/views/report/_form_chart.html.haml#L34), Col  -  - Line is too long. [81/80]\n\n**vmdb/lib/report_formatter/chart_common.rb**\n- [ ] :red_circle: **Warn** - [Line 365](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L365), Col 59 - [Lint/UselessAssignment](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Lint/UselessAssignment) - Useless assignment to variable - `sum`. Use just operator `+`.\n- [ ] :red_circle: **Warn** - [Line 366](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L366), Col 20 - [Lint/BlockAlignment](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Lint/BlockAlignment) - `end` at 366, 19 is not aligned with `group_sums = groups.each_with_object({}) do |(key, rows), h|` at 364, 6\n- [ ] :red_circle: **Warn** - [Line 367](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L367), Col 43 - [Lint/UnusedBlockArgument](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Lint/UnusedBlockArgument) - Unused block argument - `key`. If it's necessary, use `_` or `_key` as an argument name to indicate that it won't be used.\n- [ ] :red_circle: **Warn** - [Line 386](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L386), Col 17 - [Lint/BlockAlignment](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Lint/BlockAlignment) - `end` at 386, 16 is not aligned with `other = other_groups.each_with_object(Hash.new(0)) do |(key, _), o|` at 382, 8\n- [ ] :red_circle: **Warn** - [Line 413](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L413), Col 9 - [Lint/UselessAssignment](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Lint/UselessAssignment) - Useless assignment to variable - `model`. Use `_` or `_model` as a variable name to indicate that it won't be used.\n- [ ] :red_circle: **Warn** - [Line 434](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L434), Col 42 - [Lint/UselessAssignment](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Lint/UselessAssignment) - Useless assignment to variable - `sum`. Use just operator `+`.\n- [ ] :red_circle: **Warn** - [Line 501](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L501), Col 39 - [Lint/UnusedMethodArgument](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Lint/UnusedMethodArgument) - Unused method argument - `maxcols`. If it's necessary, use `_` or `_maxcols` as an argument name to indicate that it won't be used. You can also write as `build_reporting_chart_numeric(*)` if you want the method to accept any arguments but don't care about them.\n- [ ] :red_circle: **Warn** - [Line 501](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L501), Col 48 - [Lint/UnusedMethodArgument](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Lint/UnusedMethodArgument) - Unused method argument - `divider`. If it's necessary, use `_` or `_divider` as an argument name to indicate that it won't be used. You can also write as `build_reporting_chart_numeric(*)` if you want the method to accept any arguments but don't care about them.\n- [ ] :large_orange_diamond: - [Line 393](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L393), Col 1 - [Style/EmptyLinesAroundBlockBody](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/EmptyLinesAroundBlockBody) - Extra empty line detected at block body beginning.\n- [ ] :large_orange_diamond: - [Line 421](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L421), Col 15 - [Style/TrailingUnderscoreVariable](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/TrailingUnderscoreVariable) - Do not use trailing `_`s in parallel assignment.\n- [ ] :large_orange_diamond: - [Line 425](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L425), Col 46 - [Style/DotPosition](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/DotPosition) - Place the . on the next line, together with the method name.\n- [ ] :large_orange_diamond: - [Line 433](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L433), Col 59 - [Style/DotPosition](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/DotPosition) - Place the . on the next line, together with the method name.\n- [ ] :large_orange_diamond: - [Line 434](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L434), Col 19 - [Style/MultilineOperationIndentation](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/MultilineOperationIndentation) - Align the operands of an expression in an assignment spanning multiple lines.\n- [ ] :large_orange_diamond: - [Line 502](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L502), Col 21 - [Style/SpaceAroundOperators](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/SpaceAroundOperators) - Operator `?` should be surrounded with a single space.\n- [ ] :small_blue_diamond: - [Line 356](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L356), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for build_reporting_chart_dim2_numeric is too high. [68.61/15]\n- [ ] :small_blue_diamond: - [Line 356](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L356), Col 5 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for build_reporting_chart_dim2_numeric is too high. [7/6]\n- [ ] :small_blue_diamond: - [Line 356](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L356), Col 5 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [38/25]\n- [ ] :small_blue_diamond: - [Line 419](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/chart_common.rb#L419), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for build_reporting_chart_other_numeric is too high. [42.17/15]\n\n**vmdb/lib/report_formatter/jqplot.rb**\n- [ ] :small_blue_diamond: - [Line 85](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/jqplot.rb#L85), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for axis_category_labels_ticks is too high. [25.2/15]\n- [ ] :small_blue_diamond: - [Line 90](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/jqplot.rb#L90), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [124/120]\n- [ ] :small_blue_diamond: - [Line 138](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/jqplot.rb#L138), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for build_reporting_chart_other_numeric is too high. [22.09/15]\n- [ ] :small_blue_diamond: - [Line 151](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/lib/report_formatter/jqplot.rb#L151), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for build_reporting_chart_dim2_numeric is too high. [22.2/15]\n\n**vmdb/spec/lib/report_formater/jqplot_formater_spec.rb**\n- [ ] :red_circle: **Warn** - [Line 4](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/spec/lib/report_formater/jqplot_formater_spec.rb#L4), Col 9 - [Lint/ParenthesesAsGroupedExpression](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Lint/ParenthesesAsGroupedExpression) - `(...)` interpreted as grouped expression.\n- [ ] :large_orange_diamond: - [Line 13](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/spec/lib/report_formater/jqplot_formater_spec.rb#L13), Col 1 - [Style/EmptyLines](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/EmptyLines) - Extra blank line detected.\n- [ ] :large_orange_diamond: - [Line 20](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/spec/lib/report_formater/jqplot_formater_spec.rb#L20), Col 97 - [Style/LeadingCommentSpace](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/LeadingCommentSpace) - Missing space after #.\n- [ ] :large_orange_diamond: - [Line 20](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/spec/lib/report_formater/jqplot_formater_spec.rb#L20), Col 97 - [Style/SpaceBeforeComment](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/SpaceBeforeComment) - Put a space before an end-of-line comment.\n- [ ] :large_orange_diamond: - [Line 23](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/spec/lib/report_formater/jqplot_formater_spec.rb#L23), Col 11 - [Style/FirstParameterIndentation](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/FirstParameterIndentation) - Indent the first parameter one step more than the previous line.\n- [ ] :large_orange_diamond: - [Line 26](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/spec/lib/report_formater/jqplot_formater_spec.rb#L26), Col 27 - [Style/WordArray](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/WordArray) - Use `%w` or `%W` for array of words.\n- [ ] :large_orange_diamond: - [Line 28](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/spec/lib/report_formater/jqplot_formater_spec.rb#L28), Col 27 - [Style/WordArray](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Style/WordArray) - Use `%w` or `%W` for array of words.\n- [ ] :small_blue_diamond: - [Line 20](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/spec/lib/report_formater/jqplot_formater_spec.rb#L20), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [122/120]\n- [ ] :small_blue_diamond: - [Line 32](https://github.com/martinpovolny/manageiq/blob/01e6d4d343585ef427202f417368d45fa2b09790/vmdb/spec/lib/report_formater/jqplot_formater_spec.rb#L32), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.32.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [126/120]\n"}}