{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/28427782","id":28427782,"diff_hunk":"@@ -0,0 +1,54 @@\n+class RemovePortConfigFromContainerService < ActiveRecord::Migration\n+  def up\n+    create_table :container_service_port_configs do |t|\n+      t.string     :ems_ref\n+      t.string     :name\n+      t.integer    :port\n+      t.string     :target_port\n+      t.string     :protocol\n+      t.belongs_to :container_service, :type => :bigint\n+    end\n+\n+    copy_over_configs\n+    remove_columns\n+  end\n+\n+  def copy_over_configs\n+    ContainerService.find_each do |service|\n+      ContainerServicePortConfig.create(\n+          :ems_ref              => \"#{service[:ems_ref]}_#{service[:port]}_\"\\\n+                                   \"#{service[:container_port]}_#{service[:protocol]}\",\n+          :port                 => service.port,\n+          :protocol             => service.protocol,\n+          :target_port          => service.container_port,\n+          :container_service_id => service.id\n+      )\n+    end\n+  end\n+\n+  def add_columns\n+    add_column :container_services, :port, :integer\n+    add_column :container_services, :protocol, :string\n+    add_column :container_services, :container_port, :integer\n+  end\n+\n+  def remove_columns\n+    remove_column :container_services, :port\n+    remove_column :container_services, :protocol\n+    remove_column :container_services, :container_port\n+  end\n+\n+  def down\n+    add_columns\n+\n+    ContainerServicePortConfig.find_each do |port_config|\n+      s = ContainerService.where(:id => port_config[:container_service_id]).first # There should be only one","path":"vmdb/db/migrate/20150405141637_remove_port_config_from_container_service.rb","position":45,"original_position":45,"commit_id":"44a0e6f32b1b93330f3b7787b23aa0e438ff8352","original_commit_id":"44a0e6f32b1b93330f3b7787b23aa0e438ff8352","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"Doing this query in a loop can be expensive.  You can do this outside the loop once and use `index_by` to put it into a Hash: `indexed_containers = ContainerService.all.index_by(&:id)`.  Then that Hash can be used in the loop withioutt the N+1 penalty: `s = indexed_containers[port_config[:container_service_id]]`","created_at":"2015-04-15T15:04:26Z","updated_at":"2015-04-15T15:04:26Z","html_url":"https://github.com/ManageIQ/manageiq/pull/2523#discussion_r28427782","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2523","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/28427782"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/2523#discussion_r28427782"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2523"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2523","id":32665822,"html_url":"https://github.com/ManageIQ/manageiq/pull/2523","diff_url":"https://github.com/ManageIQ/manageiq/pull/2523.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/2523.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2523","number":2523,"state":"open","locked":false,"title":"FIX #2486 Kubernetes provider - service - port was changed to ports","user":{"login":"zeari","id":11256940,"avatar_url":"https://avatars.githubusercontent.com/u/11256940?v=3","gravatar_id":"","url":"https://api.github.com/users/zeari","html_url":"https://github.com/zeari","followers_url":"https://api.github.com/users/zeari/followers","following_url":"https://api.github.com/users/zeari/following{/other_user}","gists_url":"https://api.github.com/users/zeari/gists{/gist_id}","starred_url":"https://api.github.com/users/zeari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeari/subscriptions","organizations_url":"https://api.github.com/users/zeari/orgs","repos_url":"https://api.github.com/users/zeari/repos","events_url":"https://api.github.com/users/zeari/events{/privacy}","received_events_url":"https://api.github.com/users/zeari/received_events","type":"User","site_admin":false},"body":"port, container_port and protocol moved to a new model (container_service_port_config) to accommodate the changes to kubernetes listed here: [GoogleCloudPlatform/kubernetes/pull/6182](https://github.com/GoogleCloudPlatform/kubernetes/pull/6182)\r\nThis patch also migrates existing data.\r\n\r\n\r\n","created_at":"2015-04-06T07:33:15Z","updated_at":"2015-04-15T15:04:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca697d76d87698751ee8da1e4ffd882649e39caf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2523/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2523/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2523/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/44a0e6f32b1b93330f3b7787b23aa0e438ff8352","head":{"label":"zeari:multipleserviceports","ref":"multipleserviceports","sha":"44a0e6f32b1b93330f3b7787b23aa0e438ff8352","user":{"login":"zeari","id":11256940,"avatar_url":"https://avatars.githubusercontent.com/u/11256940?v=3","gravatar_id":"","url":"https://api.github.com/users/zeari","html_url":"https://github.com/zeari","followers_url":"https://api.github.com/users/zeari/followers","following_url":"https://api.github.com/users/zeari/following{/other_user}","gists_url":"https://api.github.com/users/zeari/gists{/gist_id}","starred_url":"https://api.github.com/users/zeari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeari/subscriptions","organizations_url":"https://api.github.com/users/zeari/orgs","repos_url":"https://api.github.com/users/zeari/repos","events_url":"https://api.github.com/users/zeari/events{/privacy}","received_events_url":"https://api.github.com/users/zeari/received_events","type":"User","site_admin":false},"repo":{"id":32809554,"name":"manageiq","full_name":"zeari/manageiq","owner":{"login":"zeari","id":11256940,"avatar_url":"https://avatars.githubusercontent.com/u/11256940?v=3","gravatar_id":"","url":"https://api.github.com/users/zeari","html_url":"https://github.com/zeari","followers_url":"https://api.github.com/users/zeari/followers","following_url":"https://api.github.com/users/zeari/following{/other_user}","gists_url":"https://api.github.com/users/zeari/gists{/gist_id}","starred_url":"https://api.github.com/users/zeari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeari/subscriptions","organizations_url":"https://api.github.com/users/zeari/orgs","repos_url":"https://api.github.com/users/zeari/repos","events_url":"https://api.github.com/users/zeari/events{/privacy}","received_events_url":"https://api.github.com/users/zeari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zeari/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/zeari/manageiq","forks_url":"https://api.github.com/repos/zeari/manageiq/forks","keys_url":"https://api.github.com/repos/zeari/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeari/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeari/manageiq/teams","hooks_url":"https://api.github.com/repos/zeari/manageiq/hooks","issue_events_url":"https://api.github.com/repos/zeari/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/zeari/manageiq/events","assignees_url":"https://api.github.com/repos/zeari/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/zeari/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/zeari/manageiq/tags","blobs_url":"https://api.github.com/repos/zeari/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeari/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeari/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeari/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeari/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/zeari/manageiq/languages","stargazers_url":"https://api.github.com/repos/zeari/manageiq/stargazers","contributors_url":"https://api.github.com/repos/zeari/manageiq/contributors","subscribers_url":"https://api.github.com/repos/zeari/manageiq/subscribers","subscription_url":"https://api.github.com/repos/zeari/manageiq/subscription","commits_url":"https://api.github.com/repos/zeari/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeari/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeari/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeari/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeari/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/zeari/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeari/manageiq/merges","archive_url":"https://api.github.com/repos/zeari/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeari/manageiq/downloads","issues_url":"https://api.github.com/repos/zeari/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/zeari/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/zeari/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/zeari/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeari/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/zeari/manageiq/releases{/id}","created_at":"2015-03-24T16:05:33Z","updated_at":"2015-04-02T12:09:06Z","pushed_at":"2015-04-14T17:16:06Z","git_url":"git://github.com/zeari/manageiq.git","ssh_url":"git@github.com:zeari/manageiq.git","clone_url":"https://github.com/zeari/manageiq.git","svn_url":"https://github.com/zeari/manageiq","homepage":"manageiq.org","size":68770,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"858e13cda0c0f3b54ffb14da2b000060d02ad594","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-04-15T15:02:46Z","pushed_at":"2015-04-15T15:02:46Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":119978,"stargazers_count":102,"watchers_count":102,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":367,"forks":101,"open_issues":367,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2523"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/2523"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/2523"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/2523/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2523/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2523/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/44a0e6f32b1b93330f3b7787b23aa0e438ff8352"}}}}