{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/43179197","id":43179197,"diff_hunk":"@@ -0,0 +1,79 @@\n+// in test/support/pages/Common.js\n+define(function (require) {\n+\n+  var registerSuite = require('intern!object');\n+  var expect = require('intern/dojo/node!expect.js');\n+  var Promise = require('bluebird');\n+  var moment = require('moment');\n+\n+\n+  // the page object is created as a constructor\n+  // so we can provide the remote Command object\n+  // at runtime\n+  function Common(remote) {\n+    this.remote = remote;\n+  }\n+\n+  var defaultTimeout = 5000;\n+\n+  Common.prototype = {\n+    constructor: Common,\n+\n+\n+    tryForTime: function tryForTime(timeout, block) {\n+      var self = this;\n+      var start = Date.now();\n+      var lastTry = 0;\n+\n+      function attempt() {\n+        lastTry = Date.now();\n+\n+        if (lastTry - start > timeout) {\n+          throw new Error('timeout');\n+        }\n+\n+        return Promise\n+          .try(block)\n+          .then(function tryForTimeSuccess() {\n+            self.log('tryForTime success in about ' + (lastTry - start) + ' milliseconds');\n+            return (lastTry - start);\n+          })\n+          .catch(function tryForTimeCatch(err) {\n+            self.log('failed with \"' + err.message + '\"');\n+            self.log('trying again in 1/2 second');\n+            return Promise.delay(500).then(attempt);\n+          });\n+      }\n+\n+      return Promise.try(attempt);\n+    },\n+\n+\n+    log: function log(logString) {\n+      console.log(moment().format('HH:mm:ss.SSS') + ': ' + logString);\n+    },\n+\n+\n+    sleep: function sleep(sleepMilliseconds) {\n+      var self = this;","path":"test/support/pages/Common.js","position":58,"original_position":58,"commit_id":"b2f33bbfc6ced16087b40cbd747118851a96d24c","original_commit_id":"b2f33bbfc6ced16087b40cbd747118851a96d24c","user":{"login":"jbudz","id":3143860,"avatar_url":"https://avatars.githubusercontent.com/u/3143860?v=3","gravatar_id":"","url":"https://api.github.com/users/jbudz","html_url":"https://github.com/jbudz","followers_url":"https://api.github.com/users/jbudz/followers","following_url":"https://api.github.com/users/jbudz/following{/other_user}","gists_url":"https://api.github.com/users/jbudz/gists{/gist_id}","starred_url":"https://api.github.com/users/jbudz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbudz/subscriptions","organizations_url":"https://api.github.com/users/jbudz/orgs","repos_url":"https://api.github.com/users/jbudz/repos","events_url":"https://api.github.com/users/jbudz/events{/privacy}","received_events_url":"https://api.github.com/users/jbudz/received_events","type":"User","site_admin":false},"body":"could this be a promise that resolves after sleepMilliseconds instead of looking for an element? ","created_at":"2015-10-27T20:11:13Z","updated_at":"2015-10-27T20:11:13Z","html_url":"https://github.com/elastic/kibana/pull/5154#discussion_r43179197","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/5154","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/43179197"},"html":{"href":"https://github.com/elastic/kibana/pull/5154#discussion_r43179197"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/5154"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/5154","id":48328995,"html_url":"https://github.com/elastic/kibana/pull/5154","diff_url":"https://github.com/elastic/kibana/pull/5154.diff","patch_url":"https://github.com/elastic/kibana/pull/5154.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/5154","number":5154,"state":"open","locked":false,"title":"Initial Kibana functional UI tests (testSettings) ","user":{"login":"LeeDr","id":13542669,"avatar_url":"https://avatars.githubusercontent.com/u/13542669?v=3","gravatar_id":"","url":"https://api.github.com/users/LeeDr","html_url":"https://github.com/LeeDr","followers_url":"https://api.github.com/users/LeeDr/followers","following_url":"https://api.github.com/users/LeeDr/following{/other_user}","gists_url":"https://api.github.com/users/LeeDr/gists{/gist_id}","starred_url":"https://api.github.com/users/LeeDr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeeDr/subscriptions","organizations_url":"https://api.github.com/users/LeeDr/orgs","repos_url":"https://api.github.com/users/LeeDr/repos","events_url":"https://api.github.com/users/LeeDr/events{/privacy}","received_events_url":"https://api.github.com/users/LeeDr/received_events","type":"User","site_admin":false},"body":" I merged jbudz changes from PR    [functional testing] Load scenarios #5115 so I'm also seeing his changes now vs. master.\r\n\r\nMy changes are;\r\n* test/AutomationNotes.MD\r\n* test/fixtures/scenarioManager.js (added loadIfEmpty)\r\n* test/functional/status.js (modified use the port from intern.js instead of hard-coded)\r\n* test/functional/testSettings.js (7 new tests for Settings tab)\r\n* test/intern.js (added tests)\r\n* test/support/pages/Common.js (common functions shared across functional tests)\r\n* test/support/pages/HeaderPage.js (page object for tabs)\r\n* test/support/pages/SettingsPage.js (page object for Settings tab)","created_at":"2015-10-21T13:12:52Z","updated_at":"2015-10-27T20:11:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6673b3472dd44230bfbabc5a14d1762750a618eb","assignee":{"login":"lukasolson","id":1178348,"avatar_url":"https://avatars.githubusercontent.com/u/1178348?v=3","gravatar_id":"","url":"https://api.github.com/users/lukasolson","html_url":"https://github.com/lukasolson","followers_url":"https://api.github.com/users/lukasolson/followers","following_url":"https://api.github.com/users/lukasolson/following{/other_user}","gists_url":"https://api.github.com/users/lukasolson/gists{/gist_id}","starred_url":"https://api.github.com/users/lukasolson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukasolson/subscriptions","organizations_url":"https://api.github.com/users/lukasolson/orgs","repos_url":"https://api.github.com/users/lukasolson/repos","events_url":"https://api.github.com/users/lukasolson/events{/privacy}","received_events_url":"https://api.github.com/users/lukasolson/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/5154/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/5154/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/5154/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/b2f33bbfc6ced16087b40cbd747118851a96d24c","head":{"label":"LeeDr:testSettings","ref":"testSettings","sha":"b2f33bbfc6ced16087b40cbd747118851a96d24c","user":{"login":"LeeDr","id":13542669,"avatar_url":"https://avatars.githubusercontent.com/u/13542669?v=3","gravatar_id":"","url":"https://api.github.com/users/LeeDr","html_url":"https://github.com/LeeDr","followers_url":"https://api.github.com/users/LeeDr/followers","following_url":"https://api.github.com/users/LeeDr/following{/other_user}","gists_url":"https://api.github.com/users/LeeDr/gists{/gist_id}","starred_url":"https://api.github.com/users/LeeDr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeeDr/subscriptions","organizations_url":"https://api.github.com/users/LeeDr/orgs","repos_url":"https://api.github.com/users/LeeDr/repos","events_url":"https://api.github.com/users/LeeDr/events{/privacy}","received_events_url":"https://api.github.com/users/LeeDr/received_events","type":"User","site_admin":false},"repo":{"id":39850757,"name":"kibana","full_name":"LeeDr/kibana","owner":{"login":"LeeDr","id":13542669,"avatar_url":"https://avatars.githubusercontent.com/u/13542669?v=3","gravatar_id":"","url":"https://api.github.com/users/LeeDr","html_url":"https://github.com/LeeDr","followers_url":"https://api.github.com/users/LeeDr/followers","following_url":"https://api.github.com/users/LeeDr/following{/other_user}","gists_url":"https://api.github.com/users/LeeDr/gists{/gist_id}","starred_url":"https://api.github.com/users/LeeDr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeeDr/subscriptions","organizations_url":"https://api.github.com/users/LeeDr/orgs","repos_url":"https://api.github.com/users/LeeDr/repos","events_url":"https://api.github.com/users/LeeDr/events{/privacy}","received_events_url":"https://api.github.com/users/LeeDr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LeeDr/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/LeeDr/kibana","forks_url":"https://api.github.com/repos/LeeDr/kibana/forks","keys_url":"https://api.github.com/repos/LeeDr/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LeeDr/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LeeDr/kibana/teams","hooks_url":"https://api.github.com/repos/LeeDr/kibana/hooks","issue_events_url":"https://api.github.com/repos/LeeDr/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/LeeDr/kibana/events","assignees_url":"https://api.github.com/repos/LeeDr/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/LeeDr/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/LeeDr/kibana/tags","blobs_url":"https://api.github.com/repos/LeeDr/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LeeDr/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LeeDr/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/LeeDr/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LeeDr/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/LeeDr/kibana/languages","stargazers_url":"https://api.github.com/repos/LeeDr/kibana/stargazers","contributors_url":"https://api.github.com/repos/LeeDr/kibana/contributors","subscribers_url":"https://api.github.com/repos/LeeDr/kibana/subscribers","subscription_url":"https://api.github.com/repos/LeeDr/kibana/subscription","commits_url":"https://api.github.com/repos/LeeDr/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/LeeDr/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/LeeDr/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/LeeDr/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/LeeDr/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/LeeDr/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LeeDr/kibana/merges","archive_url":"https://api.github.com/repos/LeeDr/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LeeDr/kibana/downloads","issues_url":"https://api.github.com/repos/LeeDr/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/LeeDr/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/LeeDr/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/LeeDr/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LeeDr/kibana/labels{/name}","releases_url":"https://api.github.com/repos/LeeDr/kibana/releases{/id}","created_at":"2015-07-28T18:24:24Z","updated_at":"2015-07-28T18:24:27Z","pushed_at":"2015-10-27T18:59:50Z","git_url":"git://github.com/LeeDr/kibana.git","ssh_url":"git@github.com:LeeDr/kibana.git","clone_url":"https://github.com/LeeDr/kibana.git","svn_url":"https://github.com/LeeDr/kibana","homepage":"https://www.elastic.co/products/kibana","size":68483,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"11083a585c0e130ccd4352e5667bd7c1852656dd","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":"Kibana","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","created_at":"2013-01-26T04:00:59Z","updated_at":"2015-10-27T17:52:33Z","pushed_at":"2015-10-27T19:25:58Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":97233,"stargazers_count":4318,"watchers_count":4318,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1597,"mirror_url":null,"open_issues_count":680,"forks":1597,"open_issues":680,"watchers":4318,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/5154"},"html":{"href":"https://github.com/elastic/kibana/pull/5154"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/5154"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/5154/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/5154/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/5154/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/b2f33bbfc6ced16087b40cbd747118851a96d24c"}}}}