{"action":"created","comment":{"url":"https://api.github.com/repos/nemomobile/lipstick/pulls/comments/24887362","id":24887362,"diff_hunk":"@@ -337,7 +348,6 @@ void LipstickCompositorWindow::handleTouchCancel()\n         inputDevice->sendTouchCancelEvent();\n         inputDevice->setMouseFocus(0, QPointF());\n     }\n-    window()->removeEventFilter(this);","path":"src/compositor/lipstickcompositorwindow.cpp","position":40,"original_position":40,"commit_id":"f65be3c1d3deda034853e1141d00084689ffbc80","original_commit_id":"f65be3c1d3deda034853e1141d00084689ffbc80","user":{"login":"giucam","id":680260,"avatar_url":"https://avatars.githubusercontent.com/u/680260?v=3","gravatar_id":"","url":"https://api.github.com/users/giucam","html_url":"https://github.com/giucam","followers_url":"https://api.github.com/users/giucam/followers","following_url":"https://api.github.com/users/giucam/following{/other_user}","gists_url":"https://api.github.com/users/giucam/gists{/gist_id}","starred_url":"https://api.github.com/users/giucam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giucam/subscriptions","organizations_url":"https://api.github.com/users/giucam/orgs","repos_url":"https://api.github.com/users/giucam/repos","events_url":"https://api.github.com/users/giucam/events{/privacy}","received_events_url":"https://api.github.com/users/giucam/received_events","type":"User","site_admin":false},"body":"This seems dangerous to me. Are we sure an item is always going to be removed from the scene when it is hidden/disabled?","created_at":"2015-02-18T09:10:54Z","updated_at":"2015-02-18T09:10:54Z","html_url":"https://github.com/nemomobile/lipstick/pull/235#discussion_r24887362","pull_request_url":"https://api.github.com/repos/nemomobile/lipstick/pulls/235","_links":{"self":{"href":"https://api.github.com/repos/nemomobile/lipstick/pulls/comments/24887362"},"html":{"href":"https://github.com/nemomobile/lipstick/pull/235#discussion_r24887362"},"pull_request":{"href":"https://api.github.com/repos/nemomobile/lipstick/pulls/235"}}},"pull_request":{"url":"https://api.github.com/repos/nemomobile/lipstick/pulls/235","id":29504226,"html_url":"https://github.com/nemomobile/lipstick/pull/235","diff_url":"https://github.com/nemomobile/lipstick/pull/235.diff","patch_url":"https://github.com/nemomobile/lipstick/pull/235.patch","issue_url":"https://api.github.com/repos/nemomobile/lipstick/issues/235","number":235,"state":"open","locked":false,"title":"[lipstick] Allow other event filters to run before touch interception.","user":{"login":"amccarthy","id":4606666,"avatar_url":"https://avatars.githubusercontent.com/u/4606666?v=3","gravatar_id":"","url":"https://api.github.com/users/amccarthy","html_url":"https://github.com/amccarthy","followers_url":"https://api.github.com/users/amccarthy/followers","following_url":"https://api.github.com/users/amccarthy/following{/other_user}","gists_url":"https://api.github.com/users/amccarthy/gists{/gist_id}","starred_url":"https://api.github.com/users/amccarthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amccarthy/subscriptions","organizations_url":"https://api.github.com/users/amccarthy/orgs","repos_url":"https://api.github.com/users/amccarthy/repos","events_url":"https://api.github.com/users/amccarthy/events{/privacy}","received_events_url":"https://api.github.com/users/amccarthy/received_events","type":"User","site_admin":false},"body":"LipstickCompositorWindow was installing an event filter when a\r\nTouchBegin event was received. This resulted in it being the first\r\nfilter to be run for subsequent events. Instead install and remove\r\nthe interception filter on scene change. This ensures that other\r\nfilters have a chance to see the events.","created_at":"2015-02-18T06:31:48Z","updated_at":"2015-02-18T09:10:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b45d18d95cca75a80c873b2f77208ec55c4496a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nemomobile/lipstick/pulls/235/commits","review_comments_url":"https://api.github.com/repos/nemomobile/lipstick/pulls/235/comments","review_comment_url":"https://api.github.com/repos/nemomobile/lipstick/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nemomobile/lipstick/issues/235/comments","statuses_url":"https://api.github.com/repos/nemomobile/lipstick/statuses/f65be3c1d3deda034853e1141d00084689ffbc80","head":{"label":"nemomobile:touch-interception","ref":"touch-interception","sha":"f65be3c1d3deda034853e1141d00084689ffbc80","user":{"login":"nemomobile","id":1088947,"avatar_url":"https://avatars.githubusercontent.com/u/1088947?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile","html_url":"https://github.com/nemomobile","followers_url":"https://api.github.com/users/nemomobile/followers","following_url":"https://api.github.com/users/nemomobile/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile/subscriptions","organizations_url":"https://api.github.com/users/nemomobile/orgs","repos_url":"https://api.github.com/users/nemomobile/repos","events_url":"https://api.github.com/users/nemomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile/received_events","type":"Organization","site_admin":false},"repo":{"id":2480286,"name":"lipstick","full_name":"nemomobile/lipstick","owner":{"login":"nemomobile","id":1088947,"avatar_url":"https://avatars.githubusercontent.com/u/1088947?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile","html_url":"https://github.com/nemomobile","followers_url":"https://api.github.com/users/nemomobile/followers","following_url":"https://api.github.com/users/nemomobile/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile/subscriptions","organizations_url":"https://api.github.com/users/nemomobile/orgs","repos_url":"https://api.github.com/users/nemomobile/repos","events_url":"https://api.github.com/users/nemomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nemomobile/lipstick","description":"QML desktop","fork":false,"url":"https://api.github.com/repos/nemomobile/lipstick","forks_url":"https://api.github.com/repos/nemomobile/lipstick/forks","keys_url":"https://api.github.com/repos/nemomobile/lipstick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nemomobile/lipstick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nemomobile/lipstick/teams","hooks_url":"https://api.github.com/repos/nemomobile/lipstick/hooks","issue_events_url":"https://api.github.com/repos/nemomobile/lipstick/issues/events{/number}","events_url":"https://api.github.com/repos/nemomobile/lipstick/events","assignees_url":"https://api.github.com/repos/nemomobile/lipstick/assignees{/user}","branches_url":"https://api.github.com/repos/nemomobile/lipstick/branches{/branch}","tags_url":"https://api.github.com/repos/nemomobile/lipstick/tags","blobs_url":"https://api.github.com/repos/nemomobile/lipstick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nemomobile/lipstick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nemomobile/lipstick/git/refs{/sha}","trees_url":"https://api.github.com/repos/nemomobile/lipstick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nemomobile/lipstick/statuses/{sha}","languages_url":"https://api.github.com/repos/nemomobile/lipstick/languages","stargazers_url":"https://api.github.com/repos/nemomobile/lipstick/stargazers","contributors_url":"https://api.github.com/repos/nemomobile/lipstick/contributors","subscribers_url":"https://api.github.com/repos/nemomobile/lipstick/subscribers","subscription_url":"https://api.github.com/repos/nemomobile/lipstick/subscription","commits_url":"https://api.github.com/repos/nemomobile/lipstick/commits{/sha}","git_commits_url":"https://api.github.com/repos/nemomobile/lipstick/git/commits{/sha}","comments_url":"https://api.github.com/repos/nemomobile/lipstick/comments{/number}","issue_comment_url":"https://api.github.com/repos/nemomobile/lipstick/issues/comments/{number}","contents_url":"https://api.github.com/repos/nemomobile/lipstick/contents/{+path}","compare_url":"https://api.github.com/repos/nemomobile/lipstick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nemomobile/lipstick/merges","archive_url":"https://api.github.com/repos/nemomobile/lipstick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nemomobile/lipstick/downloads","issues_url":"https://api.github.com/repos/nemomobile/lipstick/issues{/number}","pulls_url":"https://api.github.com/repos/nemomobile/lipstick/pulls{/number}","milestones_url":"https://api.github.com/repos/nemomobile/lipstick/milestones{/number}","notifications_url":"https://api.github.com/repos/nemomobile/lipstick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nemomobile/lipstick/labels{/name}","releases_url":"https://api.github.com/repos/nemomobile/lipstick/releases{/id}","created_at":"2011-09-29T06:34:07Z","updated_at":"2015-02-18T05:29:58Z","pushed_at":"2015-02-18T06:30:33Z","git_url":"git://github.com/nemomobile/lipstick.git","ssh_url":"git@github.com:nemomobile/lipstick.git","clone_url":"https://github.com/nemomobile/lipstick.git","svn_url":"https://github.com/nemomobile/lipstick","homepage":"","size":14738,"stargazers_count":28,"watchers_count":28,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":7,"forks":49,"open_issues":7,"watchers":28,"default_branch":"master"}},"base":{"label":"nemomobile:master","ref":"master","sha":"86c38cbb5738029f3254cb4805487dfe918dc0ba","user":{"login":"nemomobile","id":1088947,"avatar_url":"https://avatars.githubusercontent.com/u/1088947?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile","html_url":"https://github.com/nemomobile","followers_url":"https://api.github.com/users/nemomobile/followers","following_url":"https://api.github.com/users/nemomobile/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile/subscriptions","organizations_url":"https://api.github.com/users/nemomobile/orgs","repos_url":"https://api.github.com/users/nemomobile/repos","events_url":"https://api.github.com/users/nemomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile/received_events","type":"Organization","site_admin":false},"repo":{"id":2480286,"name":"lipstick","full_name":"nemomobile/lipstick","owner":{"login":"nemomobile","id":1088947,"avatar_url":"https://avatars.githubusercontent.com/u/1088947?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile","html_url":"https://github.com/nemomobile","followers_url":"https://api.github.com/users/nemomobile/followers","following_url":"https://api.github.com/users/nemomobile/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile/subscriptions","organizations_url":"https://api.github.com/users/nemomobile/orgs","repos_url":"https://api.github.com/users/nemomobile/repos","events_url":"https://api.github.com/users/nemomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nemomobile/lipstick","description":"QML desktop","fork":false,"url":"https://api.github.com/repos/nemomobile/lipstick","forks_url":"https://api.github.com/repos/nemomobile/lipstick/forks","keys_url":"https://api.github.com/repos/nemomobile/lipstick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nemomobile/lipstick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nemomobile/lipstick/teams","hooks_url":"https://api.github.com/repos/nemomobile/lipstick/hooks","issue_events_url":"https://api.github.com/repos/nemomobile/lipstick/issues/events{/number}","events_url":"https://api.github.com/repos/nemomobile/lipstick/events","assignees_url":"https://api.github.com/repos/nemomobile/lipstick/assignees{/user}","branches_url":"https://api.github.com/repos/nemomobile/lipstick/branches{/branch}","tags_url":"https://api.github.com/repos/nemomobile/lipstick/tags","blobs_url":"https://api.github.com/repos/nemomobile/lipstick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nemomobile/lipstick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nemomobile/lipstick/git/refs{/sha}","trees_url":"https://api.github.com/repos/nemomobile/lipstick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nemomobile/lipstick/statuses/{sha}","languages_url":"https://api.github.com/repos/nemomobile/lipstick/languages","stargazers_url":"https://api.github.com/repos/nemomobile/lipstick/stargazers","contributors_url":"https://api.github.com/repos/nemomobile/lipstick/contributors","subscribers_url":"https://api.github.com/repos/nemomobile/lipstick/subscribers","subscription_url":"https://api.github.com/repos/nemomobile/lipstick/subscription","commits_url":"https://api.github.com/repos/nemomobile/lipstick/commits{/sha}","git_commits_url":"https://api.github.com/repos/nemomobile/lipstick/git/commits{/sha}","comments_url":"https://api.github.com/repos/nemomobile/lipstick/comments{/number}","issue_comment_url":"https://api.github.com/repos/nemomobile/lipstick/issues/comments/{number}","contents_url":"https://api.github.com/repos/nemomobile/lipstick/contents/{+path}","compare_url":"https://api.github.com/repos/nemomobile/lipstick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nemomobile/lipstick/merges","archive_url":"https://api.github.com/repos/nemomobile/lipstick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nemomobile/lipstick/downloads","issues_url":"https://api.github.com/repos/nemomobile/lipstick/issues{/number}","pulls_url":"https://api.github.com/repos/nemomobile/lipstick/pulls{/number}","milestones_url":"https://api.github.com/repos/nemomobile/lipstick/milestones{/number}","notifications_url":"https://api.github.com/repos/nemomobile/lipstick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nemomobile/lipstick/labels{/name}","releases_url":"https://api.github.com/repos/nemomobile/lipstick/releases{/id}","created_at":"2011-09-29T06:34:07Z","updated_at":"2015-02-18T05:29:58Z","pushed_at":"2015-02-18T06:30:33Z","git_url":"git://github.com/nemomobile/lipstick.git","ssh_url":"git@github.com:nemomobile/lipstick.git","clone_url":"https://github.com/nemomobile/lipstick.git","svn_url":"https://github.com/nemomobile/lipstick","homepage":"","size":14738,"stargazers_count":28,"watchers_count":28,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":7,"forks":49,"open_issues":7,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nemomobile/lipstick/pulls/235"},"html":{"href":"https://github.com/nemomobile/lipstick/pull/235"},"issue":{"href":"https://api.github.com/repos/nemomobile/lipstick/issues/235"},"comments":{"href":"https://api.github.com/repos/nemomobile/lipstick/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/nemomobile/lipstick/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/nemomobile/lipstick/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nemomobile/lipstick/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/nemomobile/lipstick/statuses/f65be3c1d3deda034853e1141d00084689ffbc80"}}}}