{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/29343764","id":29343764,"diff_hunk":"@@ -34,6 +34,9 @@\n from .externals.six.moves import zip\n \n \n+DEFAULTS = dict(scalings=dict(eeg=1e6, grad=1e13, mag=1e15))","path":"mne/cov.py","position":4,"original_position":4,"commit_id":"341a20a437dc58fa9c1434f609713d0c0f88e4a6","original_commit_id":"341a20a437dc58fa9c1434f609713d0c0f88e4a6","user":{"login":"dengemann","id":1908618,"avatar_url":"https://avatars.githubusercontent.com/u/1908618?v=3","gravatar_id":"","url":"https://api.github.com/users/dengemann","html_url":"https://github.com/dengemann","followers_url":"https://api.github.com/users/dengemann/followers","following_url":"https://api.github.com/users/dengemann/following{/other_user}","gists_url":"https://api.github.com/users/dengemann/gists{/gist_id}","starred_url":"https://api.github.com/users/dengemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengemann/subscriptions","organizations_url":"https://api.github.com/users/dengemann/orgs","repos_url":"https://api.github.com/users/dengemann/repos","events_url":"https://api.github.com/users/dengemann/events{/privacy}","received_events_url":"https://api.github.com/users/dengemann/received_events","type":"User","site_admin":false},"body":"these values are not always the best. For whitening the valus that you removed were better.","created_at":"2015-04-29T14:56:43Z","updated_at":"2015-04-29T14:56:43Z","html_url":"https://github.com/mne-tools/mne-python/pull/2033#discussion_r29343764","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2033","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/29343764"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/2033#discussion_r29343764"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2033"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2033","id":34205280,"html_url":"https://github.com/mne-tools/mne-python/pull/2033","diff_url":"https://github.com/mne-tools/mne-python/pull/2033.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/2033.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2033","number":2033,"state":"open","locked":false,"title":"FIX: scalings for mne.cov._estimate_rank_meeg_signals","user":{"login":"adykstra","id":2804716,"avatar_url":"https://avatars.githubusercontent.com/u/2804716?v=3","gravatar_id":"","url":"https://api.github.com/users/adykstra","html_url":"https://github.com/adykstra","followers_url":"https://api.github.com/users/adykstra/followers","following_url":"https://api.github.com/users/adykstra/following{/other_user}","gists_url":"https://api.github.com/users/adykstra/gists{/gist_id}","starred_url":"https://api.github.com/users/adykstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adykstra/subscriptions","organizations_url":"https://api.github.com/users/adykstra/orgs","repos_url":"https://api.github.com/users/adykstra/repos","events_url":"https://api.github.com/users/adykstra/events{/privacy}","received_events_url":"https://api.github.com/users/adykstra/received_events","type":"User","site_admin":false},"body":"Addresses #2032 ","created_at":"2015-04-27T20:10:40Z","updated_at":"2015-04-29T14:56:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2602d668235e6f1d696bf6fa58fb4a181d805e7","assignee":null,"milestone":{"url":"https://api.github.com/repos/mne-tools/mne-python/milestones/5","html_url":"https://github.com/mne-tools/mne-python/milestones/0.9","labels_url":"https://api.github.com/repos/mne-tools/mne-python/milestones/5/labels","id":1011721,"number":5,"title":"0.9","description":null,"creator":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":111,"state":"open","created_at":"2015-03-09T03:10:39Z","updated_at":"2015-04-29T07:39:24Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2033/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2033/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2033/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/341a20a437dc58fa9c1434f609713d0c0f88e4a6","head":{"label":"adykstra:bugfix_rank_signals","ref":"bugfix_rank_signals","sha":"341a20a437dc58fa9c1434f609713d0c0f88e4a6","user":{"login":"adykstra","id":2804716,"avatar_url":"https://avatars.githubusercontent.com/u/2804716?v=3","gravatar_id":"","url":"https://api.github.com/users/adykstra","html_url":"https://github.com/adykstra","followers_url":"https://api.github.com/users/adykstra/followers","following_url":"https://api.github.com/users/adykstra/following{/other_user}","gists_url":"https://api.github.com/users/adykstra/gists{/gist_id}","starred_url":"https://api.github.com/users/adykstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adykstra/subscriptions","organizations_url":"https://api.github.com/users/adykstra/orgs","repos_url":"https://api.github.com/users/adykstra/repos","events_url":"https://api.github.com/users/adykstra/events{/privacy}","received_events_url":"https://api.github.com/users/adykstra/received_events","type":"User","site_admin":false},"repo":{"id":22030752,"name":"mne-python","full_name":"adykstra/mne-python","owner":{"login":"adykstra","id":2804716,"avatar_url":"https://avatars.githubusercontent.com/u/2804716?v=3","gravatar_id":"","url":"https://api.github.com/users/adykstra","html_url":"https://github.com/adykstra","followers_url":"https://api.github.com/users/adykstra/followers","following_url":"https://api.github.com/users/adykstra/following{/other_user}","gists_url":"https://api.github.com/users/adykstra/gists{/gist_id}","starred_url":"https://api.github.com/users/adykstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adykstra/subscriptions","organizations_url":"https://api.github.com/users/adykstra/orgs","repos_url":"https://api.github.com/users/adykstra/repos","events_url":"https://api.github.com/users/adykstra/events{/privacy}","received_events_url":"https://api.github.com/users/adykstra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adykstra/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/adykstra/mne-python","forks_url":"https://api.github.com/repos/adykstra/mne-python/forks","keys_url":"https://api.github.com/repos/adykstra/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adykstra/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adykstra/mne-python/teams","hooks_url":"https://api.github.com/repos/adykstra/mne-python/hooks","issue_events_url":"https://api.github.com/repos/adykstra/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/adykstra/mne-python/events","assignees_url":"https://api.github.com/repos/adykstra/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/adykstra/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/adykstra/mne-python/tags","blobs_url":"https://api.github.com/repos/adykstra/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adykstra/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adykstra/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/adykstra/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adykstra/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/adykstra/mne-python/languages","stargazers_url":"https://api.github.com/repos/adykstra/mne-python/stargazers","contributors_url":"https://api.github.com/repos/adykstra/mne-python/contributors","subscribers_url":"https://api.github.com/repos/adykstra/mne-python/subscribers","subscription_url":"https://api.github.com/repos/adykstra/mne-python/subscription","commits_url":"https://api.github.com/repos/adykstra/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/adykstra/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/adykstra/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/adykstra/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/adykstra/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/adykstra/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adykstra/mne-python/merges","archive_url":"https://api.github.com/repos/adykstra/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adykstra/mne-python/downloads","issues_url":"https://api.github.com/repos/adykstra/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/adykstra/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/adykstra/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/adykstra/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adykstra/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/adykstra/mne-python/releases{/id}","created_at":"2014-07-20T10:13:01Z","updated_at":"2015-04-27T15:05:53Z","pushed_at":"2015-04-29T08:19:25Z","git_url":"git://github.com/adykstra/mne-python.git","ssh_url":"git@github.com:adykstra/mne-python.git","clone_url":"https://github.com/adykstra/mne-python.git","svn_url":"https://github.com/adykstra/mne-python","homepage":"http://martinos.org/mne/","size":76690,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"3ca64e9318468153f8b9900373e6a45f93f82830","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","created_at":"2011-01-28T03:31:13Z","updated_at":"2015-04-29T07:39:24Z","pushed_at":"2015-04-29T08:19:27Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":168899,"stargazers_count":127,"watchers_count":127,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":127,"forks":112,"open_issues":127,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2033"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/2033"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/2033"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/2033/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2033/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/2033/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/341a20a437dc58fa9c1434f609713d0c0f88e4a6"}}}}