{"action":"created","comment":{"url":"https://api.github.com/repos/47deg/scala-sqlite-droid/pulls/comments/33457464","id":33457464,"diff_hunk":"@@ -0,0 +1,688 @@\n+package com.fortysevendeg.android.sqlite.resultset\n+\n+import java.io._\n+import java.math.BigDecimal\n+import java.net.URL\n+import java.sql._\n+import java.text.SimpleDateFormat\n+import java.util\n+import java.util.Calendar\n+\n+import android.database.Cursor\n+import com.fortysevendeg.android.sqlite._\n+\n+import scala.util.{Failure, Success, Try}\n+import scala.{Array => SArray}\n+\n+class SQLDroidResultSet(\n+  cursor: Cursor,\n+  log: LogWrapper = new AndroidLogWrapper())\n+  extends ResultSet\n+  with NonEditableResultSet\n+  with WrapperNotSupported {\n+\n+  private[this] var lastColumnRead: Option[Int] = None\n+\n+  private[this] def moveOp(f: => Boolean): Boolean =\n+    f match {\n+      case true =>\n+        lastColumnRead = None\n+        true\n+      case false =>\n+        false\n+    }\n+\n+  private[this] def getOp[T](index: Int)(f: Int => T): T = {","path":"src/main/scala/com/fortysevendeg/android/sqlite/resultset/SQLDroidResultSet.scala","position":35,"original_position":35,"commit_id":"366df272214652c675ec4ba1b4263677209c51ab","original_commit_id":"366df272214652c675ec4ba1b4263677209c51ab","user":{"login":"juanpedromoreno","id":4879373,"avatar_url":"https://avatars.githubusercontent.com/u/4879373?v=3","gravatar_id":"","url":"https://api.github.com/users/juanpedromoreno","html_url":"https://github.com/juanpedromoreno","followers_url":"https://api.github.com/users/juanpedromoreno/followers","following_url":"https://api.github.com/users/juanpedromoreno/following{/other_user}","gists_url":"https://api.github.com/users/juanpedromoreno/gists{/gist_id}","starred_url":"https://api.github.com/users/juanpedromoreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanpedromoreno/subscriptions","organizations_url":"https://api.github.com/users/juanpedromoreno/orgs","repos_url":"https://api.github.com/users/juanpedromoreno/repos","events_url":"https://api.github.com/users/juanpedromoreno/events{/privacy}","received_events_url":"https://api.github.com/users/juanpedromoreno/received_events","type":"User","site_admin":false},"body":"I've seen that this function is always using a method when the result returned is a false... Does it make sense if this _getOp_ method returns a Option[T]?\r\n\r\n```\r\ngetOp(columnIndex.index)(cursor.isNull) match {\r\n   case true => None\r\n   case false => Option(f)\r\n}\r\n```\r\ncould replaced by:\r\n```\r\ngetOp(columnIndex.index)(cursor.isNull)\r\n```\r\n","created_at":"2015-06-29T12:16:08Z","updated_at":"2015-06-29T12:16:08Z","html_url":"https://github.com/47deg/scala-sqlite-droid/pull/4#discussion_r33457464","pull_request_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/47deg/scala-sqlite-droid/pulls/comments/33457464"},"html":{"href":"https://github.com/47deg/scala-sqlite-droid/pull/4#discussion_r33457464"},"pull_request":{"href":"https://api.github.com/repos/47deg/scala-sqlite-droid/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/47deg/scala-sqlite-droid/pulls/4","id":38765893,"html_url":"https://github.com/47deg/scala-sqlite-droid/pull/4","diff_url":"https://github.com/47deg/scala-sqlite-droid/pull/4.diff","patch_url":"https://github.com/47deg/scala-sqlite-droid/pull/4.patch","issue_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/issues/4","number":4,"state":"open","locked":false,"title":"ResultSet implementation","user":{"login":"fedefernandez","id":720923,"avatar_url":"https://avatars.githubusercontent.com/u/720923?v=3","gravatar_id":"","url":"https://api.github.com/users/fedefernandez","html_url":"https://github.com/fedefernandez","followers_url":"https://api.github.com/users/fedefernandez/followers","following_url":"https://api.github.com/users/fedefernandez/following{/other_user}","gists_url":"https://api.github.com/users/fedefernandez/gists{/gist_id}","starred_url":"https://api.github.com/users/fedefernandez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedefernandez/subscriptions","organizations_url":"https://api.github.com/users/fedefernandez/orgs","repos_url":"https://api.github.com/users/fedefernandez/repos","events_url":"https://api.github.com/users/fedefernandez/events{/privacy}","received_events_url":"https://api.github.com/users/fedefernandez/received_events","type":"User","site_admin":false},"body":"This PR adds the ResultSet implementation.\r\n\r\nNotes:\r\n- Classes `SQLDroidDatabaseMetaData.java`, `SQLDroidPreparedStatement.java`, `SQLDroidStatement.java` modified to make it compiles\r\n- Added `AbstractCursor.java` and `MatrixCursor.java` from android source code for the tests\r\n\r\nPlease @juanpedromoreno could you review? Thanks!","created_at":"2015-06-29T11:52:21Z","updated_at":"2015-06-29T12:16:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2804d1821c755faa9a26fa64314103c042f4868","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/pulls/4/commits","review_comments_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/pulls/4/comments","review_comment_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/issues/4/comments","statuses_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/statuses/366df272214652c675ec4ba1b4263677209c51ab","head":{"label":"47deg:fede-result-set","ref":"fede-result-set","sha":"366df272214652c675ec4ba1b4263677209c51ab","user":{"login":"47deg","id":479857,"avatar_url":"https://avatars.githubusercontent.com/u/479857?v=3","gravatar_id":"","url":"https://api.github.com/users/47deg","html_url":"https://github.com/47deg","followers_url":"https://api.github.com/users/47deg/followers","following_url":"https://api.github.com/users/47deg/following{/other_user}","gists_url":"https://api.github.com/users/47deg/gists{/gist_id}","starred_url":"https://api.github.com/users/47deg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/47deg/subscriptions","organizations_url":"https://api.github.com/users/47deg/orgs","repos_url":"https://api.github.com/users/47deg/repos","events_url":"https://api.github.com/users/47deg/events{/privacy}","received_events_url":"https://api.github.com/users/47deg/received_events","type":"Organization","site_admin":false},"repo":{"id":37643527,"name":"scala-sqlite-droid","full_name":"47deg/scala-sqlite-droid","owner":{"login":"47deg","id":479857,"avatar_url":"https://avatars.githubusercontent.com/u/479857?v=3","gravatar_id":"","url":"https://api.github.com/users/47deg","html_url":"https://github.com/47deg","followers_url":"https://api.github.com/users/47deg/followers","following_url":"https://api.github.com/users/47deg/following{/other_user}","gists_url":"https://api.github.com/users/47deg/gists{/gist_id}","starred_url":"https://api.github.com/users/47deg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/47deg/subscriptions","organizations_url":"https://api.github.com/users/47deg/orgs","repos_url":"https://api.github.com/users/47deg/repos","events_url":"https://api.github.com/users/47deg/events{/privacy}","received_events_url":"https://api.github.com/users/47deg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/47deg/scala-sqlite-droid","description":"SQLite JDBC Driver for Android in Scala","fork":false,"url":"https://api.github.com/repos/47deg/scala-sqlite-droid","forks_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/forks","keys_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/teams","hooks_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/hooks","issue_events_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/issues/events{/number}","events_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/events","assignees_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/assignees{/user}","branches_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/branches{/branch}","tags_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/tags","blobs_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/git/refs{/sha}","trees_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/statuses/{sha}","languages_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/languages","stargazers_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/stargazers","contributors_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/contributors","subscribers_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/subscribers","subscription_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/subscription","commits_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/commits{/sha}","git_commits_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/git/commits{/sha}","comments_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/comments{/number}","issue_comment_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/issues/comments{/number}","contents_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/contents/{+path}","compare_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/merges","archive_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/downloads","issues_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/issues{/number}","pulls_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/pulls{/number}","milestones_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/milestones{/number}","notifications_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/labels{/name}","releases_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/releases{/id}","created_at":"2015-06-18T07:08:05Z","updated_at":"2015-06-18T07:13:20Z","pushed_at":"2015-06-29T11:52:21Z","git_url":"git://github.com/47deg/scala-sqlite-droid.git","ssh_url":"git@github.com:47deg/scala-sqlite-droid.git","clone_url":"https://github.com/47deg/scala-sqlite-droid.git","svn_url":"https://github.com/47deg/scala-sqlite-droid","homepage":null,"size":19400,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"47deg:master","ref":"master","sha":"c08cb391f1f509948bf39b311b2c374781d15228","user":{"login":"47deg","id":479857,"avatar_url":"https://avatars.githubusercontent.com/u/479857?v=3","gravatar_id":"","url":"https://api.github.com/users/47deg","html_url":"https://github.com/47deg","followers_url":"https://api.github.com/users/47deg/followers","following_url":"https://api.github.com/users/47deg/following{/other_user}","gists_url":"https://api.github.com/users/47deg/gists{/gist_id}","starred_url":"https://api.github.com/users/47deg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/47deg/subscriptions","organizations_url":"https://api.github.com/users/47deg/orgs","repos_url":"https://api.github.com/users/47deg/repos","events_url":"https://api.github.com/users/47deg/events{/privacy}","received_events_url":"https://api.github.com/users/47deg/received_events","type":"Organization","site_admin":false},"repo":{"id":37643527,"name":"scala-sqlite-droid","full_name":"47deg/scala-sqlite-droid","owner":{"login":"47deg","id":479857,"avatar_url":"https://avatars.githubusercontent.com/u/479857?v=3","gravatar_id":"","url":"https://api.github.com/users/47deg","html_url":"https://github.com/47deg","followers_url":"https://api.github.com/users/47deg/followers","following_url":"https://api.github.com/users/47deg/following{/other_user}","gists_url":"https://api.github.com/users/47deg/gists{/gist_id}","starred_url":"https://api.github.com/users/47deg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/47deg/subscriptions","organizations_url":"https://api.github.com/users/47deg/orgs","repos_url":"https://api.github.com/users/47deg/repos","events_url":"https://api.github.com/users/47deg/events{/privacy}","received_events_url":"https://api.github.com/users/47deg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/47deg/scala-sqlite-droid","description":"SQLite JDBC Driver for Android in Scala","fork":false,"url":"https://api.github.com/repos/47deg/scala-sqlite-droid","forks_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/forks","keys_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/teams","hooks_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/hooks","issue_events_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/issues/events{/number}","events_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/events","assignees_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/assignees{/user}","branches_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/branches{/branch}","tags_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/tags","blobs_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/git/refs{/sha}","trees_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/statuses/{sha}","languages_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/languages","stargazers_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/stargazers","contributors_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/contributors","subscribers_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/subscribers","subscription_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/subscription","commits_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/commits{/sha}","git_commits_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/git/commits{/sha}","comments_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/comments{/number}","issue_comment_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/issues/comments{/number}","contents_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/contents/{+path}","compare_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/merges","archive_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/downloads","issues_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/issues{/number}","pulls_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/pulls{/number}","milestones_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/milestones{/number}","notifications_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/labels{/name}","releases_url":"https://api.github.com/repos/47deg/scala-sqlite-droid/releases{/id}","created_at":"2015-06-18T07:08:05Z","updated_at":"2015-06-18T07:13:20Z","pushed_at":"2015-06-29T11:52:21Z","git_url":"git://github.com/47deg/scala-sqlite-droid.git","ssh_url":"git@github.com:47deg/scala-sqlite-droid.git","clone_url":"https://github.com/47deg/scala-sqlite-droid.git","svn_url":"https://github.com/47deg/scala-sqlite-droid","homepage":null,"size":19400,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/47deg/scala-sqlite-droid/pulls/4"},"html":{"href":"https://github.com/47deg/scala-sqlite-droid/pull/4"},"issue":{"href":"https://api.github.com/repos/47deg/scala-sqlite-droid/issues/4"},"comments":{"href":"https://api.github.com/repos/47deg/scala-sqlite-droid/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/47deg/scala-sqlite-droid/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/47deg/scala-sqlite-droid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/47deg/scala-sqlite-droid/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/47deg/scala-sqlite-droid/statuses/366df272214652c675ec4ba1b4263677209c51ab"}}}}