{"action":"created","issue":{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3303","labels_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3303/labels{/name}","comments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3303/comments","events_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3303/events","html_url":"https://github.com/pioneerspacesim/pioneer/pull/3303","id":53302642,"number":3303,"title":"Remove DrawPoints & DrawLines methods","user":{"login":"fluffyfreak","id":825083,"avatar_url":"https://avatars.githubusercontent.com/u/825083?v=3","gravatar_id":"","url":"https://api.github.com/users/fluffyfreak","html_url":"https://github.com/fluffyfreak","followers_url":"https://api.github.com/users/fluffyfreak/followers","following_url":"https://api.github.com/users/fluffyfreak/following{/other_user}","gists_url":"https://api.github.com/users/fluffyfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffyfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffyfreak/subscriptions","organizations_url":"https://api.github.com/users/fluffyfreak/orgs","repos_url":"https://api.github.com/users/fluffyfreak/repos","events_url":"https://api.github.com/users/fluffyfreak/events{/privacy}","received_events_url":"https://api.github.com/users/fluffyfreak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/labels/Cleanup","name":"Cleanup","color":"446eff"},{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/labels/in+progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/labels/Optimization","name":"Optimization","color":"e10c02"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-01-03T12:13:34Z","updated_at":"2015-01-04T13:02:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3303","html_url":"https://github.com/pioneerspacesim/pioneer/pull/3303","diff_url":"https://github.com/pioneerspacesim/pioneer/pull/3303.diff","patch_url":"https://github.com/pioneerspacesim/pioneer/pull/3303.patch"},"body":"This removes the `DrawPoints` and `DrawLines` methods from the renderer replacing all of the calls to them with a new `Drawables::Points` class and the existing `Drawables::Lines` class.\r\n\r\nIt affects the Scanner widget, the SectorView, targetting crosshairs, SystemView selection boxes, the GalacticView \"You Are here\" green indicator, HudTrails, SpeedLines, TextEntry and probably a few other bits I've forgotten to list.\r\n\r\nI.e: everything it changes should be quite visible, so if you would like to test then please take a look and compare how it used to look to how it currently does. \r\nI've tried to do this as I've gone along but some of the changes affect a number of areas and I might have missed them.\r\n\r\nOn some platforms / combinations of hardware / drivers it might improve performance due to it reusing buffers instead of allocating and releasing them constantly but this is difficult to measure as I don't have a wide enough range of equipment to test on.\r\n\r\nAndy"},"comment":{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/comments/68632119","html_url":"https://github.com/pioneerspacesim/pioneer/pull/3303#issuecomment-68632119","issue_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3303","id":68632119,"user":{"login":"walterar","id":1334989,"avatar_url":"https://avatars.githubusercontent.com/u/1334989?v=3","gravatar_id":"","url":"https://api.github.com/users/walterar","html_url":"https://github.com/walterar","followers_url":"https://api.github.com/users/walterar/followers","following_url":"https://api.github.com/users/walterar/following{/other_user}","gists_url":"https://api.github.com/users/walterar/gists{/gist_id}","starred_url":"https://api.github.com/users/walterar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walterar/subscriptions","organizations_url":"https://api.github.com/users/walterar/orgs","repos_url":"https://api.github.com/users/walterar/repos","events_url":"https://api.github.com/users/walterar/events{/privacy}","received_events_url":"https://api.github.com/users/walterar/received_events","type":"User","site_admin":false},"created_at":"2015-01-04T13:02:09Z","updated_at":"2015-01-04T13:02:09Z","body":"I have more, but I tell you one by one. :)"}}