{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/43172870","id":43172870,"diff_hunk":"@@ -79,11 +79,41 @@ void avatarDataFromScriptValue(const QScriptValue &object, AvatarData* &out) {\n QScriptValue inputControllerToScriptValue(QScriptEngine *engine, AbstractInputController* const &in) {\n     return engine->newQObject(in);\n }\n-\n void inputControllerFromScriptValue(const QScriptValue &object, AbstractInputController* &out) {\n     out = qobject_cast<AbstractInputController*>(object.toQObject());\n }\n \n+bool checkSyntax(const QScriptProgram& program) {","path":"libraries/script-engine/src/ScriptEngine.cpp","position":9,"original_position":9,"commit_id":"ffe73348fb9157186005b9e93e8ef24cb96a5a99","original_commit_id":"ffe73348fb9157186005b9e93e8ef24cb96a5a99","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"body":"should we make this \"static\" so that the symbols are not exposed outside of the scope of this file? not a big deal but for completeness... like you said, it's not needed outisde of here.","created_at":"2015-10-27T19:22:20Z","updated_at":"2015-10-27T19:22:20Z","html_url":"https://github.com/highfidelity/hifi/pull/6182#discussion_r43172870","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6182","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/43172870"},"html":{"href":"https://github.com/highfidelity/hifi/pull/6182#discussion_r43172870"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6182"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/6182","id":48781119,"html_url":"https://github.com/highfidelity/hifi/pull/6182","diff_url":"https://github.com/highfidelity/hifi/pull/6182.diff","patch_url":"https://github.com/highfidelity/hifi/pull/6182.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/6182","number":6182,"state":"open","locked":false,"title":"Improved ScriptEngine debug messages","user":{"login":"Atlante45","id":4036492,"avatar_url":"https://avatars.githubusercontent.com/u/4036492?v=3","gravatar_id":"","url":"https://api.github.com/users/Atlante45","html_url":"https://github.com/Atlante45","followers_url":"https://api.github.com/users/Atlante45/followers","following_url":"https://api.github.com/users/Atlante45/following{/other_user}","gists_url":"https://api.github.com/users/Atlante45/gists{/gist_id}","starred_url":"https://api.github.com/users/Atlante45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atlante45/subscriptions","organizations_url":"https://api.github.com/users/Atlante45/orgs","repos_url":"https://api.github.com/users/Atlante45/repos","events_url":"https://api.github.com/users/Atlante45/events{/privacy}","received_events_url":"https://api.github.com/users/Atlante45/received_events","type":"User","site_admin":false},"body":"- Check local scripts syntax before evaluating them.\r\n- Display backtrace in case of exceptions.\r\n- Make sure to pass a filename to `evaluate` for easier exception tracking.\r\n- Cleaned up handler callbacks code.\r\n\r\nSince we're checking the syntax before running a local script now, it might break scripts that had a syntax error in a very rarely used code path. I fixed 2 scripts and made sure all the script in defaultScript.js ran correctly.\r\n\r\nBut if you notice a script is not running, check your log for those tags: `[SyntaxError]` `[UncaughtException]`\r\n\r\nNew messages:\r\n```\r\n[10/26 11:43:06] [WARNING] [SyntaxError] Expected `identifier' in file:///Users/clement/hifi/examples/libraries/entityCameraTool.js:569(5)\r\n```\r\n\r\n```\r\n[10/26 11:47:16] [WARNING] [UncaughtException] ReferenceError: Can't find variable: event in /Users/clement/hifi/examples/edit.js:1719\r\n[10/26 11:47:16] [WARNING] [Backtrace]\r\n[10/26 11:47:16] [WARNING]     <anonymous>(name = 'Show in Marketplace') at /Users/clement/hifi/examples/edit.js:1719\r\n[10/26 11:47:16] [WARNING]     <global>() at /Users/clement/hifi/examples/edit.js:1847\r\n```","created_at":"2015-10-26T18:50:43Z","updated_at":"2015-10-27T19:22:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa7a833dcf143f12b6fcc51426fd1b464a9ec26e","assignee":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6182/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6182/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/6182/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/ffe73348fb9157186005b9e93e8ef24cb96a5a99","head":{"label":"Atlante45:script-engine","ref":"script-engine","sha":"ffe73348fb9157186005b9e93e8ef24cb96a5a99","user":{"login":"Atlante45","id":4036492,"avatar_url":"https://avatars.githubusercontent.com/u/4036492?v=3","gravatar_id":"","url":"https://api.github.com/users/Atlante45","html_url":"https://github.com/Atlante45","followers_url":"https://api.github.com/users/Atlante45/followers","following_url":"https://api.github.com/users/Atlante45/following{/other_user}","gists_url":"https://api.github.com/users/Atlante45/gists{/gist_id}","starred_url":"https://api.github.com/users/Atlante45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atlante45/subscriptions","organizations_url":"https://api.github.com/users/Atlante45/orgs","repos_url":"https://api.github.com/users/Atlante45/repos","events_url":"https://api.github.com/users/Atlante45/events{/privacy}","received_events_url":"https://api.github.com/users/Atlante45/received_events","type":"User","site_admin":false},"repo":{"id":11436474,"name":"hifi","full_name":"Atlante45/hifi","owner":{"login":"Atlante45","id":4036492,"avatar_url":"https://avatars.githubusercontent.com/u/4036492?v=3","gravatar_id":"","url":"https://api.github.com/users/Atlante45","html_url":"https://github.com/Atlante45","followers_url":"https://api.github.com/users/Atlante45/followers","following_url":"https://api.github.com/users/Atlante45/following{/other_user}","gists_url":"https://api.github.com/users/Atlante45/gists{/gist_id}","starred_url":"https://api.github.com/users/Atlante45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atlante45/subscriptions","organizations_url":"https://api.github.com/users/Atlante45/orgs","repos_url":"https://api.github.com/users/Atlante45/repos","events_url":"https://api.github.com/users/Atlante45/events{/privacy}","received_events_url":"https://api.github.com/users/Atlante45/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Atlante45/hifi","description":"Test platform for various render and interface tests for next-gen VR system","fork":true,"url":"https://api.github.com/repos/Atlante45/hifi","forks_url":"https://api.github.com/repos/Atlante45/hifi/forks","keys_url":"https://api.github.com/repos/Atlante45/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Atlante45/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Atlante45/hifi/teams","hooks_url":"https://api.github.com/repos/Atlante45/hifi/hooks","issue_events_url":"https://api.github.com/repos/Atlante45/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/Atlante45/hifi/events","assignees_url":"https://api.github.com/repos/Atlante45/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/Atlante45/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/Atlante45/hifi/tags","blobs_url":"https://api.github.com/repos/Atlante45/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Atlante45/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Atlante45/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Atlante45/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Atlante45/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/Atlante45/hifi/languages","stargazers_url":"https://api.github.com/repos/Atlante45/hifi/stargazers","contributors_url":"https://api.github.com/repos/Atlante45/hifi/contributors","subscribers_url":"https://api.github.com/repos/Atlante45/hifi/subscribers","subscription_url":"https://api.github.com/repos/Atlante45/hifi/subscription","commits_url":"https://api.github.com/repos/Atlante45/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Atlante45/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Atlante45/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Atlante45/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Atlante45/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/Atlante45/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Atlante45/hifi/merges","archive_url":"https://api.github.com/repos/Atlante45/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Atlante45/hifi/downloads","issues_url":"https://api.github.com/repos/Atlante45/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/Atlante45/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/Atlante45/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/Atlante45/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Atlante45/hifi/labels{/name}","releases_url":"https://api.github.com/repos/Atlante45/hifi/releases{/id}","created_at":"2013-07-15T23:52:30Z","updated_at":"2015-05-08T13:17:34Z","pushed_at":"2015-10-27T19:18:15Z","git_url":"git://github.com/Atlante45/hifi.git","ssh_url":"git@github.com:Atlante45/hifi.git","clone_url":"https://github.com/Atlante45/hifi.git","svn_url":"https://github.com/Atlante45/hifi","homepage":null,"size":189065,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"bc07de389292e6f2be538b4eb9d35091d294d9c8","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-10-25T16:15:19Z","pushed_at":"2015-10-27T19:20:53Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":245732,"stargazers_count":316,"watchers_count":316,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":185,"mirror_url":null,"open_issues_count":66,"forks":185,"open_issues":66,"watchers":316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6182"},"html":{"href":"https://github.com/highfidelity/hifi/pull/6182"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/6182"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/6182/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6182/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6182/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/ffe73348fb9157186005b9e93e8ef24cb96a5a99"}}}}