{"action":"created","issue":{"url":"https://api.github.com/repos/spanishdict/supermodal/issues/1","labels_url":"https://api.github.com/repos/spanishdict/supermodal/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/spanishdict/supermodal/issues/1/comments","events_url":"https://api.github.com/repos/spanishdict/supermodal/issues/1/events","html_url":"https://github.com/spanishdict/supermodal/pull/1","id":56050422,"number":1,"title":"Initial Commit","user":{"login":"daiweilu","id":2153667,"avatar_url":"https://avatars.githubusercontent.com/u/2153667?v=3","gravatar_id":"","url":"https://api.github.com/users/daiweilu","html_url":"https://github.com/daiweilu","followers_url":"https://api.github.com/users/daiweilu/followers","following_url":"https://api.github.com/users/daiweilu/following{/other_user}","gists_url":"https://api.github.com/users/daiweilu/gists{/gist_id}","starred_url":"https://api.github.com/users/daiweilu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daiweilu/subscriptions","organizations_url":"https://api.github.com/users/daiweilu/orgs","repos_url":"https://api.github.com/users/daiweilu/repos","events_url":"https://api.github.com/users/daiweilu/events{/privacy}","received_events_url":"https://api.github.com/users/daiweilu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"sandinmyjoints","id":606772,"avatar_url":"https://avatars.githubusercontent.com/u/606772?v=3","gravatar_id":"","url":"https://api.github.com/users/sandinmyjoints","html_url":"https://github.com/sandinmyjoints","followers_url":"https://api.github.com/users/sandinmyjoints/followers","following_url":"https://api.github.com/users/sandinmyjoints/following{/other_user}","gists_url":"https://api.github.com/users/sandinmyjoints/gists{/gist_id}","starred_url":"https://api.github.com/users/sandinmyjoints/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandinmyjoints/subscriptions","organizations_url":"https://api.github.com/users/sandinmyjoints/orgs","repos_url":"https://api.github.com/users/sandinmyjoints/repos","events_url":"https://api.github.com/users/sandinmyjoints/events{/privacy}","received_events_url":"https://api.github.com/users/sandinmyjoints/received_events","type":"User","site_admin":false},"milestone":null,"comments":13,"created_at":"2015-01-30T15:59:14Z","updated_at":"2015-02-03T17:51:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spanishdict/supermodal/pulls/1","html_url":"https://github.com/spanishdict/supermodal/pull/1","diff_url":"https://github.com/spanishdict/supermodal/pull/1.diff","patch_url":"https://github.com/spanishdict/supermodal/pull/1.patch"},"body":"@sandinmyjoints \r\n\r\nNeodarwin mobile modal evolves into :star: **supermodal** :star:. Use `gulp serve` to test on local.\r\n\r\n### Why Gulp again??\r\n\r\nI tried to just use npm, I found a steep learning curve, especially when watching file changes. Besides, the [onchange](https://www.npmjs.com/package/onchange) module we used in other places were 2 months old, and the [gaze](https://www.npmjs.com/package/gaze) module it used is not as good as [chokidar](https://github.com/paulmillr/chokidar), which is used by `gulp.watch`.\r\n\r\n/cc @CarsonBanov @danpaz "},"comment":{"url":"https://api.github.com/repos/spanishdict/supermodal/issues/comments/72699287","html_url":"https://github.com/spanishdict/supermodal/pull/1#issuecomment-72699287","issue_url":"https://api.github.com/repos/spanishdict/supermodal/issues/1","id":72699287,"user":{"login":"sandinmyjoints","id":606772,"avatar_url":"https://avatars.githubusercontent.com/u/606772?v=3","gravatar_id":"","url":"https://api.github.com/users/sandinmyjoints","html_url":"https://github.com/sandinmyjoints","followers_url":"https://api.github.com/users/sandinmyjoints/followers","following_url":"https://api.github.com/users/sandinmyjoints/following{/other_user}","gists_url":"https://api.github.com/users/sandinmyjoints/gists{/gist_id}","starred_url":"https://api.github.com/users/sandinmyjoints/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandinmyjoints/subscriptions","organizations_url":"https://api.github.com/users/sandinmyjoints/orgs","repos_url":"https://api.github.com/users/sandinmyjoints/repos","events_url":"https://api.github.com/users/sandinmyjoints/events{/privacy}","received_events_url":"https://api.github.com/users/sandinmyjoints/received_events","type":"User","site_admin":false},"created_at":"2015-02-03T17:51:53Z","updated_at":"2015-02-03T17:51:53Z","body":"Lots of good questions. Here are some thoughts:\r\n- I agree that the `style` task should run static analysis on js and css. It's fine to make a task called `eslint`, but I think there should also be a task called `style` that runs `eslint` and also runs whatever css linting we choose to use later. Every other project that we have built has a `style` task that runs all of the static analysis checks (js and css), and reusing task names is an easy win for consistency among our projects.\r\n- \"Variables within the same declaration block should be sorted alphabetically sort-vars\" -- I'm OK with changing this rule to allow flexibility in the order of declaring variables. I can see the value in grouping them in other ways than alphabetical. If @CarsonBanov or @danpaz feel differently, we can have a conversation about it when they return.\r\n- \"'addEventListener' is read only\" -- this is because supermodal.js appears to be be stomping on `window.addEventListener`. You are relying on browserify to wrap supermodal.js in a closure in the build but eslint doesn't know that. Possible solutions:\r\n  - Only run eslint on the build. Downside: then you have to build in order to run linting.\r\n  - Wrap supermodal.js in a closure.\r\n  - Use a name other than `addEventListener`, such as `_addEventListener` or `listen`. Bonus: less confusing to anyone reading the code because no one will think that you actually *are* trying to overwrite the native `addEventListener`. \r\n- Thanks for raising those points about the 80-char line length limit. I think there are tradeoffs for keeping it at 80 and also for changing it. \r\n- For `dict` as an object type, do you intend to mean a flat (one-level) dictionary with no nesting? Or can it have more than one level of nesting? Can values be arrays? How is `dict` different from JSON (or is it the same)?"}}