{"action":"created","comment":{"url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments/41642987","id":41642987,"diff_hunk":"@@ -237,6 +240,44 @@\n       },\n       'keyword': function(predicate, item){\n         return !!~item.name.toLowerCase().indexOf(predicate);\n+      },\n+      'light': function(predicate, item){\n+        if (predicate.length === 0 || item.primStat == undefined) return false;\n+        if (item.primStat.statHash != '3897883278' && item.primStat.statHash != '368428387') return false;","path":"app/scripts/shell/dimSearchFilter.directive.js","position":17,"original_position":17,"commit_id":"cc188c84d62f42d5241cb5be0447811f97c0e608","original_commit_id":"cc188c84d62f42d5241cb5be0447811f97c0e608","user":{"login":"kyleshay","id":424158,"avatar_url":"https://avatars.githubusercontent.com/u/424158?v=3","gravatar_id":"","url":"https://api.github.com/users/kyleshay","html_url":"https://github.com/kyleshay","followers_url":"https://api.github.com/users/kyleshay/followers","following_url":"https://api.github.com/users/kyleshay/following{/other_user}","gists_url":"https://api.github.com/users/kyleshay/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleshay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleshay/subscriptions","organizations_url":"https://api.github.com/users/kyleshay/orgs","repos_url":"https://api.github.com/users/kyleshay/repos","events_url":"https://api.github.com/users/kyleshay/events{/privacy}","received_events_url":"https://api.github.com/users/kyleshay/received_events","type":"User","site_admin":false},"body":"what are these values ?","created_at":"2015-10-09T15:27:37Z","updated_at":"2015-10-09T15:27:37Z","html_url":"https://github.com/DestinyItemManager/DIM/pull/284#discussion_r41642987","pull_request_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/284","_links":{"self":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments/41642987"},"html":{"href":"https://github.com/DestinyItemManager/DIM/pull/284#discussion_r41642987"},"pull_request":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/284"}}},"pull_request":{"url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/284","id":47262619,"html_url":"https://github.com/DestinyItemManager/DIM/pull/284","diff_url":"https://github.com/DestinyItemManager/DIM/pull/284.diff","patch_url":"https://github.com/DestinyItemManager/DIM/pull/284.patch","issue_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/284","number":284,"state":"open","locked":false,"title":"Filter by Light/Level of Armor and Weapons","user":{"login":"Denifia","id":2015251,"avatar_url":"https://avatars.githubusercontent.com/u/2015251?v=3","gravatar_id":"","url":"https://api.github.com/users/Denifia","html_url":"https://github.com/Denifia","followers_url":"https://api.github.com/users/Denifia/followers","following_url":"https://api.github.com/users/Denifia/following{/other_user}","gists_url":"https://api.github.com/users/Denifia/gists{/gist_id}","starred_url":"https://api.github.com/users/Denifia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Denifia/subscriptions","organizations_url":"https://api.github.com/users/Denifia/orgs","repos_url":"https://api.github.com/users/Denifia/repos","events_url":"https://api.github.com/users/Denifia/events{/privacy}","received_events_url":"https://api.github.com/users/Denifia/received_events","type":"User","site_admin":false},"body":"Implemented feature as described in #279 \r\n\r\n* Search using 'light' or 'level' keywords\r\n* Operands available are =, >=, >, <, <=\r\n* Filter is explained in the filter popup (including interaction with prompt for light value)\r\n* Compatible in combination with itself or other filters","created_at":"2015-10-09T11:49:39Z","updated_at":"2015-10-09T15:27:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebff353168ab0c83c28873f6620a27472834b2c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/284/commits","review_comments_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/284/comments","review_comment_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/284/comments","statuses_url":"https://api.github.com/repos/DestinyItemManager/DIM/statuses/cc188c84d62f42d5241cb5be0447811f97c0e608","head":{"label":"Denifia:dev","ref":"dev","sha":"cc188c84d62f42d5241cb5be0447811f97c0e608","user":{"login":"Denifia","id":2015251,"avatar_url":"https://avatars.githubusercontent.com/u/2015251?v=3","gravatar_id":"","url":"https://api.github.com/users/Denifia","html_url":"https://github.com/Denifia","followers_url":"https://api.github.com/users/Denifia/followers","following_url":"https://api.github.com/users/Denifia/following{/other_user}","gists_url":"https://api.github.com/users/Denifia/gists{/gist_id}","starred_url":"https://api.github.com/users/Denifia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Denifia/subscriptions","organizations_url":"https://api.github.com/users/Denifia/orgs","repos_url":"https://api.github.com/users/Denifia/repos","events_url":"https://api.github.com/users/Denifia/events{/privacy}","received_events_url":"https://api.github.com/users/Denifia/received_events","type":"User","site_admin":false},"repo":{"id":43875868,"name":"DIM","full_name":"Denifia/DIM","owner":{"login":"Denifia","id":2015251,"avatar_url":"https://avatars.githubusercontent.com/u/2015251?v=3","gravatar_id":"","url":"https://api.github.com/users/Denifia","html_url":"https://github.com/Denifia","followers_url":"https://api.github.com/users/Denifia/followers","following_url":"https://api.github.com/users/Denifia/following{/other_user}","gists_url":"https://api.github.com/users/Denifia/gists{/gist_id}","starred_url":"https://api.github.com/users/Denifia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Denifia/subscriptions","organizations_url":"https://api.github.com/users/Denifia/orgs","repos_url":"https://api.github.com/users/Denifia/repos","events_url":"https://api.github.com/users/Denifia/events{/privacy}","received_events_url":"https://api.github.com/users/Denifia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Denifia/DIM","description":"Destiny Item Manager","fork":true,"url":"https://api.github.com/repos/Denifia/DIM","forks_url":"https://api.github.com/repos/Denifia/DIM/forks","keys_url":"https://api.github.com/repos/Denifia/DIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Denifia/DIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Denifia/DIM/teams","hooks_url":"https://api.github.com/repos/Denifia/DIM/hooks","issue_events_url":"https://api.github.com/repos/Denifia/DIM/issues/events{/number}","events_url":"https://api.github.com/repos/Denifia/DIM/events","assignees_url":"https://api.github.com/repos/Denifia/DIM/assignees{/user}","branches_url":"https://api.github.com/repos/Denifia/DIM/branches{/branch}","tags_url":"https://api.github.com/repos/Denifia/DIM/tags","blobs_url":"https://api.github.com/repos/Denifia/DIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Denifia/DIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Denifia/DIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/Denifia/DIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Denifia/DIM/statuses/{sha}","languages_url":"https://api.github.com/repos/Denifia/DIM/languages","stargazers_url":"https://api.github.com/repos/Denifia/DIM/stargazers","contributors_url":"https://api.github.com/repos/Denifia/DIM/contributors","subscribers_url":"https://api.github.com/repos/Denifia/DIM/subscribers","subscription_url":"https://api.github.com/repos/Denifia/DIM/subscription","commits_url":"https://api.github.com/repos/Denifia/DIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/Denifia/DIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/Denifia/DIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/Denifia/DIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/Denifia/DIM/contents/{+path}","compare_url":"https://api.github.com/repos/Denifia/DIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Denifia/DIM/merges","archive_url":"https://api.github.com/repos/Denifia/DIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Denifia/DIM/downloads","issues_url":"https://api.github.com/repos/Denifia/DIM/issues{/number}","pulls_url":"https://api.github.com/repos/Denifia/DIM/pulls{/number}","milestones_url":"https://api.github.com/repos/Denifia/DIM/milestones{/number}","notifications_url":"https://api.github.com/repos/Denifia/DIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Denifia/DIM/labels{/name}","releases_url":"https://api.github.com/repos/Denifia/DIM/releases{/id}","created_at":"2015-10-08T09:02:47Z","updated_at":"2015-10-08T09:02:55Z","pushed_at":"2015-10-09T11:44:10Z","git_url":"git://github.com/Denifia/DIM.git","ssh_url":"git@github.com:Denifia/DIM.git","clone_url":"https://github.com/Denifia/DIM.git","svn_url":"https://github.com/Denifia/DIM","homepage":"https://chrome.google.com/webstore/detail/destiny-item-manager/apghicjnekejhfancbkahkhdckhdagna","size":101777,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"DestinyItemManager:dev","ref":"dev","sha":"3814f88f905f2b27e3cfc753da4dc0e7338dbe68","user":{"login":"DestinyItemManager","id":12777189,"avatar_url":"https://avatars.githubusercontent.com/u/12777189?v=3","gravatar_id":"","url":"https://api.github.com/users/DestinyItemManager","html_url":"https://github.com/DestinyItemManager","followers_url":"https://api.github.com/users/DestinyItemManager/followers","following_url":"https://api.github.com/users/DestinyItemManager/following{/other_user}","gists_url":"https://api.github.com/users/DestinyItemManager/gists{/gist_id}","starred_url":"https://api.github.com/users/DestinyItemManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DestinyItemManager/subscriptions","organizations_url":"https://api.github.com/users/DestinyItemManager/orgs","repos_url":"https://api.github.com/users/DestinyItemManager/repos","events_url":"https://api.github.com/users/DestinyItemManager/events{/privacy}","received_events_url":"https://api.github.com/users/DestinyItemManager/received_events","type":"Organization","site_admin":false},"repo":{"id":31681575,"name":"DIM","full_name":"DestinyItemManager/DIM","owner":{"login":"DestinyItemManager","id":12777189,"avatar_url":"https://avatars.githubusercontent.com/u/12777189?v=3","gravatar_id":"","url":"https://api.github.com/users/DestinyItemManager","html_url":"https://github.com/DestinyItemManager","followers_url":"https://api.github.com/users/DestinyItemManager/followers","following_url":"https://api.github.com/users/DestinyItemManager/following{/other_user}","gists_url":"https://api.github.com/users/DestinyItemManager/gists{/gist_id}","starred_url":"https://api.github.com/users/DestinyItemManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DestinyItemManager/subscriptions","organizations_url":"https://api.github.com/users/DestinyItemManager/orgs","repos_url":"https://api.github.com/users/DestinyItemManager/repos","events_url":"https://api.github.com/users/DestinyItemManager/events{/privacy}","received_events_url":"https://api.github.com/users/DestinyItemManager/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DestinyItemManager/DIM","description":"Destiny Item Manager","fork":false,"url":"https://api.github.com/repos/DestinyItemManager/DIM","forks_url":"https://api.github.com/repos/DestinyItemManager/DIM/forks","keys_url":"https://api.github.com/repos/DestinyItemManager/DIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DestinyItemManager/DIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DestinyItemManager/DIM/teams","hooks_url":"https://api.github.com/repos/DestinyItemManager/DIM/hooks","issue_events_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/events{/number}","events_url":"https://api.github.com/repos/DestinyItemManager/DIM/events","assignees_url":"https://api.github.com/repos/DestinyItemManager/DIM/assignees{/user}","branches_url":"https://api.github.com/repos/DestinyItemManager/DIM/branches{/branch}","tags_url":"https://api.github.com/repos/DestinyItemManager/DIM/tags","blobs_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DestinyItemManager/DIM/statuses/{sha}","languages_url":"https://api.github.com/repos/DestinyItemManager/DIM/languages","stargazers_url":"https://api.github.com/repos/DestinyItemManager/DIM/stargazers","contributors_url":"https://api.github.com/repos/DestinyItemManager/DIM/contributors","subscribers_url":"https://api.github.com/repos/DestinyItemManager/DIM/subscribers","subscription_url":"https://api.github.com/repos/DestinyItemManager/DIM/subscription","commits_url":"https://api.github.com/repos/DestinyItemManager/DIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/DestinyItemManager/DIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/DestinyItemManager/DIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/DestinyItemManager/DIM/contents/{+path}","compare_url":"https://api.github.com/repos/DestinyItemManager/DIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DestinyItemManager/DIM/merges","archive_url":"https://api.github.com/repos/DestinyItemManager/DIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DestinyItemManager/DIM/downloads","issues_url":"https://api.github.com/repos/DestinyItemManager/DIM/issues{/number}","pulls_url":"https://api.github.com/repos/DestinyItemManager/DIM/pulls{/number}","milestones_url":"https://api.github.com/repos/DestinyItemManager/DIM/milestones{/number}","notifications_url":"https://api.github.com/repos/DestinyItemManager/DIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DestinyItemManager/DIM/labels{/name}","releases_url":"https://api.github.com/repos/DestinyItemManager/DIM/releases{/id}","created_at":"2015-03-04T21:46:50Z","updated_at":"2015-10-09T12:17:00Z","pushed_at":"2015-10-09T11:49:39Z","git_url":"git://github.com/DestinyItemManager/DIM.git","ssh_url":"git@github.com:DestinyItemManager/DIM.git","clone_url":"https://github.com/DestinyItemManager/DIM.git","svn_url":"https://github.com/DestinyItemManager/DIM","homepage":"https://chrome.google.com/webstore/detail/destiny-item-manager/apghicjnekejhfancbkahkhdckhdagna","size":101777,"stargazers_count":234,"watchers_count":234,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"open_issues_count":83,"forks":118,"open_issues":83,"watchers":234,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/284"},"html":{"href":"https://github.com/DestinyItemManager/DIM/pull/284"},"issue":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/issues/284"},"comments":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/DestinyItemManager/DIM/statuses/cc188c84d62f42d5241cb5be0447811f97c0e608"}}}}