{"action":"created","issue":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/90","labels_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/90/labels{/name}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/90/comments","events_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/90/events","html_url":"https://github.com/kaldi-asr/kaldi/issues/90","id":102879382,"number":90,"title":"Completion of error handling","user":{"login":"elfring","id":660477,"avatar_url":"https://avatars.githubusercontent.com/u/660477?v=3","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-24T20:02:09Z","updated_at":"2015-08-24T20:29:27Z","closed_at":null,"body":"Would you like to add more error handling for return values from functions like the following?\r\n- [fopen](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fopen.html \"Open a stream.\") ⇒ [TrainModelThread](https://github.com/kaldi-asr/kaldi/blob/1a59ece8f53e904d10cfce1758222a258e9a148e/tools/rnnlm-hs-0.1b/rnnlm.c#L410)\r\n- [fscanf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fscanf.html \"Convert formatted input.\") ⇒ [ReadVocab](https://github.com/kaldi-asr/kaldi/blob/1a59ece8f53e904d10cfce1758222a258e9a148e/tools/rnnlm-hs-0.1b/rnnlm.c#L333)"},"comment":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/comments/134369151","html_url":"https://github.com/kaldi-asr/kaldi/issues/90#issuecomment-134369151","issue_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/90","id":134369151,"user":{"login":"ilya-edrenkin","id":13562803,"avatar_url":"https://avatars.githubusercontent.com/u/13562803?v=3","gravatar_id":"","url":"https://api.github.com/users/ilya-edrenkin","html_url":"https://github.com/ilya-edrenkin","followers_url":"https://api.github.com/users/ilya-edrenkin/followers","following_url":"https://api.github.com/users/ilya-edrenkin/following{/other_user}","gists_url":"https://api.github.com/users/ilya-edrenkin/gists{/gist_id}","starred_url":"https://api.github.com/users/ilya-edrenkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilya-edrenkin/subscriptions","organizations_url":"https://api.github.com/users/ilya-edrenkin/orgs","repos_url":"https://api.github.com/users/ilya-edrenkin/repos","events_url":"https://api.github.com/users/ilya-edrenkin/events{/privacy}","received_events_url":"https://api.github.com/users/ilya-edrenkin/received_events","type":"User","site_admin":false},"created_at":"2015-08-24T20:29:27Z","updated_at":"2015-08-24T20:29:27Z","body":"Hi, \r\n\r\nI think it is a good idea.\r\n\r\nFurthermore, @akhti has completely rewritten the rnnlm code and published it at https://github.com/yandex/faster-rnnlm\r\nIt is (almost) identical to rnnlm-hs-0.1b in terms of modeling capability, but also it:\r\n1) is nearly 3 times faster;\r\n2) supports NCE in addition to HS output;\r\n3) greatly improved on style.\r\nProbably we should replace the rnnlm in kaldi with this one since it is definitely better. Dan, what do you think about it?"}}