{"action":"created","issue":{"url":"https://api.github.com/repos/xaque208/puppet-bsd/issues/76","labels_url":"https://api.github.com/repos/xaque208/puppet-bsd/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/xaque208/puppet-bsd/issues/76/comments","events_url":"https://api.github.com/repos/xaque208/puppet-bsd/issues/76/events","html_url":"https://github.com/xaque208/puppet-bsd/pull/76","id":103324027,"number":76,"title":"fix issue #75: add values parameter to all network/interface/*.pp classes","user":{"login":"buzzdeee","id":8383396,"avatar_url":"https://avatars.githubusercontent.com/u/8383396?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzdeee","html_url":"https://github.com/buzzdeee","followers_url":"https://api.github.com/users/buzzdeee/followers","following_url":"https://api.github.com/users/buzzdeee/following{/other_user}","gists_url":"https://api.github.com/users/buzzdeee/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzdeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzdeee/subscriptions","organizations_url":"https://api.github.com/users/buzzdeee/orgs","repos_url":"https://api.github.com/users/buzzdeee/repos","events_url":"https://api.github.com/users/buzzdeee/events{/privacy}","received_events_url":"https://api.github.com/users/buzzdeee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-26T17:22:21Z","updated_at":"2015-09-06T15:21:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xaque208/puppet-bsd/pulls/76","html_url":"https://github.com/xaque208/puppet-bsd/pull/76","diff_url":"https://github.com/xaque208/puppet-bsd/pull/76.diff","patch_url":"https://github.com/xaque208/puppet-bsd/pull/76.patch"},"body":"The values parameter, an array of strings, is intended to allow the user to set alias IP addresses, as well as shell commands, i.e. setting routes via !commands.\r\n\r\nThe values array, if given, is concatenated to the returned string of get_hostname_if_<INTERFACE_TYPE> functions, and then handed over to the values parameter of 'bsd::network::interface'\r\n\r\nI only need it soon for carp interfaces, but thought all classes in that subdirectory should follow the same pattern, so I added it for all of them.\r\n\r\nHowever, the vlan.pp was not following the pattern of the others, and now the FreeBSD test for vlan interfaces fails. I don't have a FreeBSD system around to test that. Do you have a possibility to verify that it creates a valid working FreeBSD config?\r\nOn OpenBSD, the config it created for VLAN interfaces was odd, looking like the following:\r\n```\r\n172.16.0.1/24 vlan 100 vlandev trunk0\r\n inet 172.16.0.1 255.255.255.0 NONE\r\n up\r\n```\r\n\r\nNow after the change, it creates files like:\r\n```\r\nvlan 100 vlandev trunk0\r\ninet 172.16.0.1 255.255.255.0 NONE\r\nup\r\n```\r\n\r\nThe odd version it created was working fine, but the version it now creates is from my point of view saner.\r\n\r\nIn short: do you can let me know if VLANs for FreeBSD are now broken or do they work?\r\nWhen they work, I'd rather go and adapt the spec test, if I broke it, I'll rework the vlan.pp in \r\norder to resemble behaviour as it was before."},"comment":{"url":"https://api.github.com/repos/xaque208/puppet-bsd/issues/comments/138092503","html_url":"https://github.com/xaque208/puppet-bsd/pull/76#issuecomment-138092503","issue_url":"https://api.github.com/repos/xaque208/puppet-bsd/issues/76","id":138092503,"user":{"login":"buzzdeee","id":8383396,"avatar_url":"https://avatars.githubusercontent.com/u/8383396?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzdeee","html_url":"https://github.com/buzzdeee","followers_url":"https://api.github.com/users/buzzdeee/followers","following_url":"https://api.github.com/users/buzzdeee/following{/other_user}","gists_url":"https://api.github.com/users/buzzdeee/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzdeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzdeee/subscriptions","organizations_url":"https://api.github.com/users/buzzdeee/orgs","repos_url":"https://api.github.com/users/buzzdeee/repos","events_url":"https://api.github.com/users/buzzdeee/events{/privacy}","received_events_url":"https://api.github.com/users/buzzdeee/received_events","type":"User","site_admin":false},"created_at":"2015-09-06T15:21:49Z","updated_at":"2015-09-06T15:21:49Z","body":"The idea I had in mind, didn't worked out. The bsd::network::interface defined type should have an address parameter, instead of giving the addresses in the values.\r\nSomething I'll look into later on. \r\nTherefore I kept the VLAN defined type a bit differently, to make the spec tests happy. \r\n\r\nFor whatever reason, there now seems to be a conflict in the vlan.pp :(\r\n\r\nSebastian\r\n"}}