{"action":"created","issue":{"url":"https://api.github.com/repos/doctrine/mongodb-odm/issues/1257","labels_url":"https://api.github.com/repos/doctrine/mongodb-odm/issues/1257/labels{/name}","comments_url":"https://api.github.com/repos/doctrine/mongodb-odm/issues/1257/comments","events_url":"https://api.github.com/repos/doctrine/mongodb-odm/issues/1257/events","html_url":"https://github.com/doctrine/mongodb-odm/pull/1257","id":114054624,"number":1257,"title":"NOTIFY change tracking policy fixes","user":{"login":"banrobert","id":900202,"avatar_url":"https://avatars.githubusercontent.com/u/900202?v=3","gravatar_id":"","url":"https://api.github.com/users/banrobert","html_url":"https://github.com/banrobert","followers_url":"https://api.github.com/users/banrobert/followers","following_url":"https://api.github.com/users/banrobert/following{/other_user}","gists_url":"https://api.github.com/users/banrobert/gists{/gist_id}","starred_url":"https://api.github.com/users/banrobert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banrobert/subscriptions","organizations_url":"https://api.github.com/users/banrobert/orgs","repos_url":"https://api.github.com/users/banrobert/repos","events_url":"https://api.github.com/users/banrobert/events{/privacy}","received_events_url":"https://api.github.com/users/banrobert/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/doctrine/mongodb-odm/labels/bug","name":"bug","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/doctrine/mongodb-odm/milestones/11","html_url":"https://github.com/doctrine/mongodb-odm/milestones/1.0.3","labels_url":"https://api.github.com/repos/doctrine/mongodb-odm/milestones/11/labels","id":1282053,"number":11,"title":"1.0.3","description":"","creator":{"login":"jmikola","id":244663,"avatar_url":"https://avatars.githubusercontent.com/u/244663?v=3","gravatar_id":"","url":"https://api.github.com/users/jmikola","html_url":"https://github.com/jmikola","followers_url":"https://api.github.com/users/jmikola/followers","following_url":"https://api.github.com/users/jmikola/following{/other_user}","gists_url":"https://api.github.com/users/jmikola/gists{/gist_id}","starred_url":"https://api.github.com/users/jmikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmikola/subscriptions","organizations_url":"https://api.github.com/users/jmikola/orgs","repos_url":"https://api.github.com/users/jmikola/repos","events_url":"https://api.github.com/users/jmikola/events{/privacy}","received_events_url":"https://api.github.com/users/jmikola/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":14,"state":"open","created_at":"2015-08-31T14:56:26Z","updated_at":"2015-10-30T09:47:56Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-10-29T13:55:03Z","updated_at":"2015-10-30T10:16:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/doctrine/mongodb-odm/pulls/1257","html_url":"https://github.com/doctrine/mongodb-odm/pull/1257","diff_url":"https://github.com/doctrine/mongodb-odm/pull/1257.diff","patch_url":"https://github.com/doctrine/mongodb-odm/pull/1257.patch"},"body":"This PR fixes some issues with documents using the NOTIFY change tracking policy, namely:\r\n* Committing a document of this kind multiple times raised an `Undefined index` notice as reported in #740. Fixed the error and created a test case for it.\r\n* Committing only a single document made the UnitOfWork lose changes of all other managed documents with NOTIFY change tracking policy. Fixed this too and also created a test case for it.\r\n* Additionally I found that the current test case for the this change tracking policy (namely: `UnitOfWorkTest::testChangeTrackingNotify`) used a document without the required `@ODM\\ChangeTrackingPolicy(\"NOTIFY\")` annotation as its test subject, so the test didn't test what it supposed to test. I added the missing annotation to this dummy document."},"comment":{"url":"https://api.github.com/repos/doctrine/mongodb-odm/issues/comments/152483042","html_url":"https://github.com/doctrine/mongodb-odm/pull/1257#issuecomment-152483042","issue_url":"https://api.github.com/repos/doctrine/mongodb-odm/issues/1257","id":152483042,"user":{"login":"banrobert","id":900202,"avatar_url":"https://avatars.githubusercontent.com/u/900202?v=3","gravatar_id":"","url":"https://api.github.com/users/banrobert","html_url":"https://github.com/banrobert","followers_url":"https://api.github.com/users/banrobert/followers","following_url":"https://api.github.com/users/banrobert/following{/other_user}","gists_url":"https://api.github.com/users/banrobert/gists{/gist_id}","starred_url":"https://api.github.com/users/banrobert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banrobert/subscriptions","organizations_url":"https://api.github.com/users/banrobert/orgs","repos_url":"https://api.github.com/users/banrobert/repos","events_url":"https://api.github.com/users/banrobert/events{/privacy}","received_events_url":"https://api.github.com/users/banrobert/received_events","type":"User","site_admin":false},"created_at":"2015-10-30T10:16:10Z","updated_at":"2015-10-30T10:16:10Z","body":"Removed the commits, never rebased before, didn't know this was possible, cool feature.\r\n\r\nAnd regarding #1149 i would also say that implementing the single document flush differently than the ORM but making it clearer by not flushing anything else that is not related to the document in question is the way to go. Hope the team agrees!"}}