{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/33095092","id":33095092,"diff_hunk":"@@ -32,7 +31,11 @@ using namespace dev::shh;\n WhisperPeer::WhisperPeer(Session* _s, HostCapabilityFace* _h, unsigned _i, CapDesc const&): Capability(_s, _h, _i)\n {\n \tRLPStream s;\n-\tsealAndSend(prep(s, StatusPacket, 1) << version());\n+\t//sealAndSend(prep(s, StatusPacket, 1) << version());","path":"libwhisper/WhisperPeer.cpp","position":18,"original_position":18,"commit_id":"7c19232b6a6bc56bfa9500cb87d18f0932055322","original_commit_id":"7c19232b6a6bc56bfa9500cb87d18f0932055322","user":{"login":"subtly","id":6557250,"avatar_url":"https://avatars.githubusercontent.com/u/6557250?v=3","gravatar_id":"","url":"https://api.github.com/users/subtly","html_url":"https://github.com/subtly","followers_url":"https://api.github.com/users/subtly/followers","following_url":"https://api.github.com/users/subtly/following{/other_user}","gists_url":"https://api.github.com/users/subtly/gists{/gist_id}","starred_url":"https://api.github.com/users/subtly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subtly/subscriptions","organizations_url":"https://api.github.com/users/subtly/orgs","repos_url":"https://api.github.com/users/subtly/repos","events_url":"https://api.github.com/users/subtly/events{/privacy}","received_events_url":"https://api.github.com/users/subtly/received_events","type":"User","site_admin":false},"body":"It's safe to remove this. However, please also bump the protocol version for whisper capability. This will cause the capability to be disabled for older client versions; accordingly, we won't need the commented out code.","created_at":"2015-06-23T21:31:26Z","updated_at":"2015-06-23T21:31:26Z","html_url":"https://github.com/ethereum/cpp-ethereum/pull/2263#discussion_r33095092","pull_request_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/2263","_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/33095092"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/2263#discussion_r33095092"},"pull_request":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/2263"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/2263","id":38328414,"html_url":"https://github.com/ethereum/cpp-ethereum/pull/2263","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/2263.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/2263.patch","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/2263","number":2263,"state":"open","locked":false,"title":"topic advertisement","user":{"login":"gluk256","id":9915581,"avatar_url":"https://avatars.githubusercontent.com/u/9915581?v=3","gravatar_id":"","url":"https://api.github.com/users/gluk256","html_url":"https://github.com/gluk256","followers_url":"https://api.github.com/users/gluk256/followers","following_url":"https://api.github.com/users/gluk256/following{/other_user}","gists_url":"https://api.github.com/users/gluk256/gists{/gist_id}","starred_url":"https://api.github.com/users/gluk256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluk256/subscriptions","organizations_url":"https://api.github.com/users/gluk256/orgs","repos_url":"https://api.github.com/users/gluk256/repos","events_url":"https://api.github.com/users/gluk256/events{/privacy}","received_events_url":"https://api.github.com/users/gluk256/received_events","type":"User","site_admin":false},"body":"Exchange Protocol for Topic Advertisement, including tests.","created_at":"2015-06-23T11:58:30Z","updated_at":"2015-06-23T21:31:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe4d252d8859583deada1e376e00c01a91f8ab1d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/2263/commits","review_comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/2263/comments","review_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/2263/comments","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/7c19232b6a6bc56bfa9500cb87d18f0932055322","head":{"label":"gluk256:_topic_advert","ref":"_topic_advert","sha":"7c19232b6a6bc56bfa9500cb87d18f0932055322","user":{"login":"gluk256","id":9915581,"avatar_url":"https://avatars.githubusercontent.com/u/9915581?v=3","gravatar_id":"","url":"https://api.github.com/users/gluk256","html_url":"https://github.com/gluk256","followers_url":"https://api.github.com/users/gluk256/followers","following_url":"https://api.github.com/users/gluk256/following{/other_user}","gists_url":"https://api.github.com/users/gluk256/gists{/gist_id}","starred_url":"https://api.github.com/users/gluk256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluk256/subscriptions","organizations_url":"https://api.github.com/users/gluk256/orgs","repos_url":"https://api.github.com/users/gluk256/repos","events_url":"https://api.github.com/users/gluk256/events{/privacy}","received_events_url":"https://api.github.com/users/gluk256/received_events","type":"User","site_admin":false},"repo":{"id":34257981,"name":"cpp-ethereum","full_name":"gluk256/cpp-ethereum","owner":{"login":"gluk256","id":9915581,"avatar_url":"https://avatars.githubusercontent.com/u/9915581?v=3","gravatar_id":"","url":"https://api.github.com/users/gluk256","html_url":"https://github.com/gluk256","followers_url":"https://api.github.com/users/gluk256/followers","following_url":"https://api.github.com/users/gluk256/following{/other_user}","gists_url":"https://api.github.com/users/gluk256/gists{/gist_id}","starred_url":"https://api.github.com/users/gluk256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gluk256/subscriptions","organizations_url":"https://api.github.com/users/gluk256/orgs","repos_url":"https://api.github.com/users/gluk256/repos","events_url":"https://api.github.com/users/gluk256/events{/privacy}","received_events_url":"https://api.github.com/users/gluk256/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gluk256/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":true,"url":"https://api.github.com/repos/gluk256/cpp-ethereum","forks_url":"https://api.github.com/repos/gluk256/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/gluk256/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gluk256/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gluk256/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/gluk256/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/gluk256/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/gluk256/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/gluk256/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/gluk256/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/gluk256/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/gluk256/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gluk256/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gluk256/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/gluk256/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gluk256/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/gluk256/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/gluk256/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/gluk256/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/gluk256/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/gluk256/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/gluk256/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/gluk256/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/gluk256/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/gluk256/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/gluk256/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/gluk256/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gluk256/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/gluk256/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gluk256/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/gluk256/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/gluk256/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/gluk256/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/gluk256/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gluk256/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/gluk256/cpp-ethereum/releases{/id}","created_at":"2015-04-20T12:05:28Z","updated_at":"2015-05-05T10:47:19Z","pushed_at":"2015-06-23T13:01:04Z","git_url":"git://github.com/gluk256/cpp-ethereum.git","ssh_url":"git@github.com:gluk256/cpp-ethereum.git","clone_url":"https://github.com/gluk256/cpp-ethereum.git","svn_url":"https://github.com/gluk256/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":25874,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"afd4af51eeabe7ff8ceeef0e394514e2fb7d6157","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","created_at":"2013-12-26T21:26:06Z","updated_at":"2015-06-22T10:54:44Z","pushed_at":"2015-06-23T21:02:14Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":100558,"stargazers_count":485,"watchers_count":485,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":181,"mirror_url":null,"open_issues_count":190,"forks":181,"open_issues":190,"watchers":485,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/2263"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/2263"},"issue":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/2263"},"comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/2263/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/2263/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/2263/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/7c19232b6a6bc56bfa9500cb87d18f0932055322"}}}}