{"action":"created","comment":{"url":"https://api.github.com/repos/derekparker/delve/pulls/comments/40486528","id":40486528,"diff_hunk":"@@ -733,19 +759,21 @@ func (thread *Thread) readComplex(addr uintptr, size int64) (string, error) {\n \tdefault:\n \t\treturn \"\", fmt.Errorf(\"invalid size (%d) for complex type\", size)\n \t}\n-\tr, err := thread.readFloat(addr, fs)\n+\tr, err := addr.readFloat(fs)\n \tif err != nil {\n \t\treturn \"\", err\n \t}\n-\ti, err := thread.readFloat(addr+uintptr(fs), fs)\n+\timagaddr := *addr\n+\timagaddr.Addr += uintptr(fs)\n+\ti, err := imagaddr.readFloat(fs)\n \tif err != nil {\n \t\treturn \"\", err\n \t}\n-\treturn fmt.Sprintf(\"(%s, %si)\", r, i), nil\n+\treturn fmt.Sprintf(\"(%s + %si)\", r, i), nil","path":"proc/variables.go","position":615,"original_position":615,"commit_id":"9b901dd5fb3efefedeb36a011b350262948d59e5","original_commit_id":"9b901dd5fb3efefedeb36a011b350262948d59e5","user":{"login":"derekparker","id":1314079,"avatar_url":"https://avatars.githubusercontent.com/u/1314079?v=3","gravatar_id":"","url":"https://api.github.com/users/derekparker","html_url":"https://github.com/derekparker","followers_url":"https://api.github.com/users/derekparker/followers","following_url":"https://api.github.com/users/derekparker/following{/other_user}","gists_url":"https://api.github.com/users/derekparker/gists{/gist_id}","starred_url":"https://api.github.com/users/derekparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekparker/subscriptions","organizations_url":"https://api.github.com/users/derekparker/orgs","repos_url":"https://api.github.com/users/derekparker/repos","events_url":"https://api.github.com/users/derekparker/events{/privacy}","received_events_url":"https://api.github.com/users/derekparker/received_events","type":"User","site_admin":false},"body":"Nice catch, I should've seen the incorrect notation before.","created_at":"2015-09-26T00:08:45Z","updated_at":"2015-09-26T00:08:45Z","html_url":"https://github.com/derekparker/delve/pull/248#discussion_r40486528","pull_request_url":"https://api.github.com/repos/derekparker/delve/pulls/248","_links":{"self":{"href":"https://api.github.com/repos/derekparker/delve/pulls/comments/40486528"},"html":{"href":"https://github.com/derekparker/delve/pull/248#discussion_r40486528"},"pull_request":{"href":"https://api.github.com/repos/derekparker/delve/pulls/248"}}},"pull_request":{"url":"https://api.github.com/repos/derekparker/delve/pulls/248","id":45517246,"html_url":"https://github.com/derekparker/delve/pull/248","diff_url":"https://github.com/derekparker/delve/pull/248.diff","patch_url":"https://github.com/derekparker/delve/pull/248.patch","issue_url":"https://api.github.com/repos/derekparker/delve/issues/248","number":248,"state":"open","locked":false,"title":"proc/variables: Split address calculations from value extraction","user":{"login":"aarzilli","id":303620,"avatar_url":"https://avatars.githubusercontent.com/u/303620?v=3","gravatar_id":"","url":"https://api.github.com/users/aarzilli","html_url":"https://github.com/aarzilli","followers_url":"https://api.github.com/users/aarzilli/followers","following_url":"https://api.github.com/users/aarzilli/following{/other_user}","gists_url":"https://api.github.com/users/aarzilli/gists{/gist_id}","starred_url":"https://api.github.com/users/aarzilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarzilli/subscriptions","organizations_url":"https://api.github.com/users/aarzilli/orgs","repos_url":"https://api.github.com/users/aarzilli/repos","events_url":"https://api.github.com/users/aarzilli/events{/privacy}","received_events_url":"https://api.github.com/users/aarzilli/received_events","type":"User","site_admin":false},"body":"Refactored variables.go to separate calculation of a variable's address from\r\nreading its value. This change is useful to implement the 'set' command\r\nas well as the evaluation of more complex expressions (in the future).\r\nIntroduces the types VarAddr (a typed address in the target program) and\r\nArrayAddr (a typed sequence of addresses in the target program).","created_at":"2015-09-21T06:25:53Z","updated_at":"2015-09-26T00:08:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d005e541a681057a33978f184ea0f0a6e83d4b6b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/derekparker/delve/pulls/248/commits","review_comments_url":"https://api.github.com/repos/derekparker/delve/pulls/248/comments","review_comment_url":"https://api.github.com/repos/derekparker/delve/pulls/comments{/number}","comments_url":"https://api.github.com/repos/derekparker/delve/issues/248/comments","statuses_url":"https://api.github.com/repos/derekparker/delve/statuses/9b901dd5fb3efefedeb36a011b350262948d59e5","head":{"label":"aarzilli:varaddr","ref":"varaddr","sha":"9b901dd5fb3efefedeb36a011b350262948d59e5","user":{"login":"aarzilli","id":303620,"avatar_url":"https://avatars.githubusercontent.com/u/303620?v=3","gravatar_id":"","url":"https://api.github.com/users/aarzilli","html_url":"https://github.com/aarzilli","followers_url":"https://api.github.com/users/aarzilli/followers","following_url":"https://api.github.com/users/aarzilli/following{/other_user}","gists_url":"https://api.github.com/users/aarzilli/gists{/gist_id}","starred_url":"https://api.github.com/users/aarzilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarzilli/subscriptions","organizations_url":"https://api.github.com/users/aarzilli/orgs","repos_url":"https://api.github.com/users/aarzilli/repos","events_url":"https://api.github.com/users/aarzilli/events{/privacy}","received_events_url":"https://api.github.com/users/aarzilli/received_events","type":"User","site_admin":false},"repo":{"id":37608792,"name":"delve","full_name":"aarzilli/delve","owner":{"login":"aarzilli","id":303620,"avatar_url":"https://avatars.githubusercontent.com/u/303620?v=3","gravatar_id":"","url":"https://api.github.com/users/aarzilli","html_url":"https://github.com/aarzilli","followers_url":"https://api.github.com/users/aarzilli/followers","following_url":"https://api.github.com/users/aarzilli/following{/other_user}","gists_url":"https://api.github.com/users/aarzilli/gists{/gist_id}","starred_url":"https://api.github.com/users/aarzilli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarzilli/subscriptions","organizations_url":"https://api.github.com/users/aarzilli/orgs","repos_url":"https://api.github.com/users/aarzilli/repos","events_url":"https://api.github.com/users/aarzilli/events{/privacy}","received_events_url":"https://api.github.com/users/aarzilli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aarzilli/delve","description":"Delve is a debugger for the Go programming language.","fork":true,"url":"https://api.github.com/repos/aarzilli/delve","forks_url":"https://api.github.com/repos/aarzilli/delve/forks","keys_url":"https://api.github.com/repos/aarzilli/delve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aarzilli/delve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aarzilli/delve/teams","hooks_url":"https://api.github.com/repos/aarzilli/delve/hooks","issue_events_url":"https://api.github.com/repos/aarzilli/delve/issues/events{/number}","events_url":"https://api.github.com/repos/aarzilli/delve/events","assignees_url":"https://api.github.com/repos/aarzilli/delve/assignees{/user}","branches_url":"https://api.github.com/repos/aarzilli/delve/branches{/branch}","tags_url":"https://api.github.com/repos/aarzilli/delve/tags","blobs_url":"https://api.github.com/repos/aarzilli/delve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aarzilli/delve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aarzilli/delve/git/refs{/sha}","trees_url":"https://api.github.com/repos/aarzilli/delve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aarzilli/delve/statuses/{sha}","languages_url":"https://api.github.com/repos/aarzilli/delve/languages","stargazers_url":"https://api.github.com/repos/aarzilli/delve/stargazers","contributors_url":"https://api.github.com/repos/aarzilli/delve/contributors","subscribers_url":"https://api.github.com/repos/aarzilli/delve/subscribers","subscription_url":"https://api.github.com/repos/aarzilli/delve/subscription","commits_url":"https://api.github.com/repos/aarzilli/delve/commits{/sha}","git_commits_url":"https://api.github.com/repos/aarzilli/delve/git/commits{/sha}","comments_url":"https://api.github.com/repos/aarzilli/delve/comments{/number}","issue_comment_url":"https://api.github.com/repos/aarzilli/delve/issues/comments{/number}","contents_url":"https://api.github.com/repos/aarzilli/delve/contents/{+path}","compare_url":"https://api.github.com/repos/aarzilli/delve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aarzilli/delve/merges","archive_url":"https://api.github.com/repos/aarzilli/delve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aarzilli/delve/downloads","issues_url":"https://api.github.com/repos/aarzilli/delve/issues{/number}","pulls_url":"https://api.github.com/repos/aarzilli/delve/pulls{/number}","milestones_url":"https://api.github.com/repos/aarzilli/delve/milestones{/number}","notifications_url":"https://api.github.com/repos/aarzilli/delve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aarzilli/delve/labels{/name}","releases_url":"https://api.github.com/repos/aarzilli/delve/releases{/id}","created_at":"2015-06-17T17:05:12Z","updated_at":"2015-06-17T17:05:12Z","pushed_at":"2015-09-21T16:26:13Z","git_url":"git://github.com/aarzilli/delve.git","ssh_url":"git@github.com:aarzilli/delve.git","clone_url":"https://github.com/aarzilli/delve.git","svn_url":"https://github.com/aarzilli/delve","homepage":"","size":8885,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"derekparker:master","ref":"master","sha":"5ba043538215e82b9c2d27f5fae173440c12e9e9","user":{"login":"derekparker","id":1314079,"avatar_url":"https://avatars.githubusercontent.com/u/1314079?v=3","gravatar_id":"","url":"https://api.github.com/users/derekparker","html_url":"https://github.com/derekparker","followers_url":"https://api.github.com/users/derekparker/followers","following_url":"https://api.github.com/users/derekparker/following{/other_user}","gists_url":"https://api.github.com/users/derekparker/gists{/gist_id}","starred_url":"https://api.github.com/users/derekparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekparker/subscriptions","organizations_url":"https://api.github.com/users/derekparker/orgs","repos_url":"https://api.github.com/users/derekparker/repos","events_url":"https://api.github.com/users/derekparker/events{/privacy}","received_events_url":"https://api.github.com/users/derekparker/received_events","type":"User","site_admin":false},"repo":{"id":19994257,"name":"delve","full_name":"derekparker/delve","owner":{"login":"derekparker","id":1314079,"avatar_url":"https://avatars.githubusercontent.com/u/1314079?v=3","gravatar_id":"","url":"https://api.github.com/users/derekparker","html_url":"https://github.com/derekparker","followers_url":"https://api.github.com/users/derekparker/followers","following_url":"https://api.github.com/users/derekparker/following{/other_user}","gists_url":"https://api.github.com/users/derekparker/gists{/gist_id}","starred_url":"https://api.github.com/users/derekparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekparker/subscriptions","organizations_url":"https://api.github.com/users/derekparker/orgs","repos_url":"https://api.github.com/users/derekparker/repos","events_url":"https://api.github.com/users/derekparker/events{/privacy}","received_events_url":"https://api.github.com/users/derekparker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/derekparker/delve","description":"Delve is a debugger for the Go programming language.","fork":false,"url":"https://api.github.com/repos/derekparker/delve","forks_url":"https://api.github.com/repos/derekparker/delve/forks","keys_url":"https://api.github.com/repos/derekparker/delve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/derekparker/delve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/derekparker/delve/teams","hooks_url":"https://api.github.com/repos/derekparker/delve/hooks","issue_events_url":"https://api.github.com/repos/derekparker/delve/issues/events{/number}","events_url":"https://api.github.com/repos/derekparker/delve/events","assignees_url":"https://api.github.com/repos/derekparker/delve/assignees{/user}","branches_url":"https://api.github.com/repos/derekparker/delve/branches{/branch}","tags_url":"https://api.github.com/repos/derekparker/delve/tags","blobs_url":"https://api.github.com/repos/derekparker/delve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/derekparker/delve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/derekparker/delve/git/refs{/sha}","trees_url":"https://api.github.com/repos/derekparker/delve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/derekparker/delve/statuses/{sha}","languages_url":"https://api.github.com/repos/derekparker/delve/languages","stargazers_url":"https://api.github.com/repos/derekparker/delve/stargazers","contributors_url":"https://api.github.com/repos/derekparker/delve/contributors","subscribers_url":"https://api.github.com/repos/derekparker/delve/subscribers","subscription_url":"https://api.github.com/repos/derekparker/delve/subscription","commits_url":"https://api.github.com/repos/derekparker/delve/commits{/sha}","git_commits_url":"https://api.github.com/repos/derekparker/delve/git/commits{/sha}","comments_url":"https://api.github.com/repos/derekparker/delve/comments{/number}","issue_comment_url":"https://api.github.com/repos/derekparker/delve/issues/comments{/number}","contents_url":"https://api.github.com/repos/derekparker/delve/contents/{+path}","compare_url":"https://api.github.com/repos/derekparker/delve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/derekparker/delve/merges","archive_url":"https://api.github.com/repos/derekparker/delve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/derekparker/delve/downloads","issues_url":"https://api.github.com/repos/derekparker/delve/issues{/number}","pulls_url":"https://api.github.com/repos/derekparker/delve/pulls{/number}","milestones_url":"https://api.github.com/repos/derekparker/delve/milestones{/number}","notifications_url":"https://api.github.com/repos/derekparker/delve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/derekparker/delve/labels{/name}","releases_url":"https://api.github.com/repos/derekparker/delve/releases{/id}","created_at":"2014-05-20T19:24:43Z","updated_at":"2015-09-25T09:05:51Z","pushed_at":"2015-09-26T00:08:44Z","git_url":"git://github.com/derekparker/delve.git","ssh_url":"git@github.com:derekparker/delve.git","clone_url":"https://github.com/derekparker/delve.git","svn_url":"https://github.com/derekparker/delve","homepage":"","size":11967,"stargazers_count":2409,"watchers_count":2409,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":138,"mirror_url":null,"open_issues_count":51,"forks":138,"open_issues":51,"watchers":2409,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/derekparker/delve/pulls/248"},"html":{"href":"https://github.com/derekparker/delve/pull/248"},"issue":{"href":"https://api.github.com/repos/derekparker/delve/issues/248"},"comments":{"href":"https://api.github.com/repos/derekparker/delve/issues/248/comments"},"review_comments":{"href":"https://api.github.com/repos/derekparker/delve/pulls/248/comments"},"review_comment":{"href":"https://api.github.com/repos/derekparker/delve/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/derekparker/delve/pulls/248/commits"},"statuses":{"href":"https://api.github.com/repos/derekparker/delve/statuses/9b901dd5fb3efefedeb36a011b350262948d59e5"}}}}