{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/mozdownload/issues/259","labels_url":"https://api.github.com/repos/mozilla/mozdownload/issues/259/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/mozdownload/issues/259/comments","events_url":"https://api.github.com/repos/mozilla/mozdownload/issues/259/events","html_url":"https://github.com/mozilla/mozdownload/pull/259","id":58634284,"number":259,"title":"Fails when specifying --type=tinderbox --platform=win32 --branch=mozilla...","user":{"login":"sydvicious","id":984554,"avatar_url":"https://avatars.githubusercontent.com/u/984554?v=3","gravatar_id":"","url":"https://api.github.com/users/sydvicious","html_url":"https://github.com/sydvicious","followers_url":"https://api.github.com/users/sydvicious/followers","following_url":"https://api.github.com/users/sydvicious/following{/other_user}","gists_url":"https://api.github.com/users/sydvicious/gists{/gist_id}","starred_url":"https://api.github.com/users/sydvicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sydvicious/subscriptions","organizations_url":"https://api.github.com/users/sydvicious/orgs","repos_url":"https://api.github.com/users/sydvicious/repos","events_url":"https://api.github.com/users/sydvicious/events{/privacy}","received_events_url":"https://api.github.com/users/sydvicious/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-23T19:21:18Z","updated_at":"2015-02-26T14:34:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/mozdownload/pulls/259","html_url":"https://github.com/mozilla/mozdownload/pull/259","diff_url":"https://github.com/mozilla/mozdownload/pull/259.diff","patch_url":"https://github.com/mozilla/mozdownload/pull/259.patch"},"body":"@whimboo - Please review. This addresses issue #258.\r\n\r\nHave the regular expressions for the windows binaries match the ones used for release."},"comment":{"url":"https://api.github.com/repos/mozilla/mozdownload/issues/comments/76187792","html_url":"https://github.com/mozilla/mozdownload/pull/259#issuecomment-76187792","issue_url":"https://api.github.com/repos/mozilla/mozdownload/issues/259","id":76187792,"user":{"login":"whimboo","id":129603,"avatar_url":"https://avatars.githubusercontent.com/u/129603?v=3","gravatar_id":"","url":"https://api.github.com/users/whimboo","html_url":"https://github.com/whimboo","followers_url":"https://api.github.com/users/whimboo/followers","following_url":"https://api.github.com/users/whimboo/following{/other_user}","gists_url":"https://api.github.com/users/whimboo/gists{/gist_id}","starred_url":"https://api.github.com/users/whimboo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whimboo/subscriptions","organizations_url":"https://api.github.com/users/whimboo/orgs","repos_url":"https://api.github.com/users/whimboo/repos","events_url":"https://api.github.com/users/whimboo/events{/privacy}","received_events_url":"https://api.github.com/users/whimboo/received_events","type":"User","site_admin":false},"created_at":"2015-02-26T14:34:52Z","updated_at":"2015-02-26T14:34:52Z","body":"The patch looks fine, but I would appreciate if you could add tests for it. Here my suggestion:\r\n\r\n1. For the daily scraper add a test which fetches the zip build of the 2013-10-01 nightly build from mozilla-central\r\n2. For tinderbox also use mozilla-central and use one of the three existent builds. That should be enough\r\n3. For try-builds we have only a single build so it is easy\r\n4. We don't need any tests for candidate and release builds given that we do not have zip archives for those.\r\n\r\nThanks"}}