{"push_id":695727180,"size":2,"distinct_size":2,"ref":"refs/heads/2.3","head":"a6b7a4b894de9d7e5e0db1b3f1c1dd0b07abc690","before":"901ff88b7a46eff64d90ea46f6a6aedce1d3adf6","commits":[{"sha":"0afb8dcc5886ae6d29e07c0173ecaa1bb2492368","author":{"email":"bab18efef71e2d17e309f92125c46f10bf8dce45@gmail.com","name":"Javier Eguiluz"},"message":"Standardize the name of the exception variables","distinct":true,"url":"https://api.github.com/repos/symfony/DependencyInjection/commits/0afb8dcc5886ae6d29e07c0173ecaa1bb2492368"},{"sha":"a6b7a4b894de9d7e5e0db1b3f1c1dd0b07abc690","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"minor #14937 Standardize the name of the exception variables (javiereguiluz)\n\nThis PR was squashed before being merged into the 2.3 branch (closes #14937).\n\nDiscussion\n----------\n\nStandardize the name of the exception variables\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | no\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | -\n| License       | MIT\n| Doc PR        | -\n\nSee https://github.com/symfony/symfony-docs/pull/4491 for the context of this change.\n\nIn Symfony source code there are 410 `try ... catch` blocks. More than 95% of them use `$e` as the name of the exception variable. After applying these changes, 407 out of 410 variables are named `$e`.\n\nThese are the three cases where I didn't change the name of the `$e` variable:\n\n  * Nested exception in https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Routing/Matcher/RedirectableUrlMatcher.php#L40. It uses `$e2` as the name of the nested variable.\n  * Nested exception in https://github.com/symfony/symfony/blob/2.3/src/Symfony/Bundle/TwigBundle/TwigEngine.php#L82. I changed the name of the `$ex` variable to `$e2` to match the previous syntax.\n  * https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Console/Helper/DialogHelper.php#L463. I don't know if it's safe to change the name of the `$error` exception variable.\n\nCommits\n-------\n\ne8b924c Standardize the name of the exception variables","distinct":true,"url":"https://api.github.com/repos/symfony/DependencyInjection/commits/a6b7a4b894de9d7e5e0db1b3f1c1dd0b07abc690"}]}