{"action":"created","comment":{"url":"https://api.github.com/repos/slamdata/slamengine/pulls/comments/24430625","id":24430625,"diff_hunk":"@@ -62,21 +62,27 @@ sealed trait MongoDbFileSystem extends FileSystem {\n         } yield ()\n       })\n \n-  def append(path: Path, values: Process[Task, RenderedJson]) =\n+  def append(path: Path, values: Process[Task, Data]) =\n     Collection.fromPath(path).fold(\n       e => Process.fail(e),\n       col => {\n         import process1._\n \n-        val chunks: Process[Task, Vector[(RenderedJson, Option[com.mongodb.DBObject])]] = values.map(json => json -> db.parse(json)) pipe chunk(ChunkSize)\n+        val chunks: Process[Task, Vector[(Data, String \\/ com.mongodb.DBObject)]] = {\n+          def unwrap(obj: AnyRef) = obj match {","path":"core/src/main/scala/slamdata/engine/physical/mongodb/filesystem.scala","position":40,"original_position":40,"commit_id":"2ef3bcd94331f22702468f0fcf1d789773202377","original_commit_id":"2ef3bcd94331f22702468f0fcf1d789773202377","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"body":"Yup, it turns out I can.","created_at":"2015-02-10T17:20:52Z","updated_at":"2015-02-10T17:20:52Z","html_url":"https://github.com/slamdata/slamengine/pull/595#discussion_r24430625","pull_request_url":"https://api.github.com/repos/slamdata/slamengine/pulls/595","_links":{"self":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/comments/24430625"},"html":{"href":"https://github.com/slamdata/slamengine/pull/595#discussion_r24430625"},"pull_request":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/595"}}},"pull_request":{"url":"https://api.github.com/repos/slamdata/slamengine/pulls/595","id":28658293,"html_url":"https://github.com/slamdata/slamengine/pull/595","diff_url":"https://github.com/slamdata/slamengine/pull/595.diff","patch_url":"https://github.com/slamdata/slamengine/pull/595.patch","issue_url":"https://api.github.com/repos/slamdata/slamengine/issues/595","number":595,"state":"open","locked":false,"title":"Precise and Readable JSON encodings (Fixes #255)","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"body":"Explicitly translate between Data and one of two JSON encodings. That means\nalso back-translating from MongoDB's native types to our Bson type, and then\nfrom Bson to Data, where we previously just rendered the mongo objects to\nstrings and assumed they would parse if anyone happened to try.\n\nJSON rendering in the REPL is improved, since it now uses the Readable\nencoding but more importantly uses a proper Argonaut pretty printer.\n\nFor now the choice of encoding for each interface (admin UI, REPL, API) is\nhard-coded. See TODOs referring to #592.","created_at":"2015-02-04T17:38:18Z","updated_at":"2015-02-10T17:20:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a5d75bd2b394d4253ad31080c22a6d8d2b65966","assignee":{"login":"sellout","id":33031,"avatar_url":"https://avatars.githubusercontent.com/u/33031?v=3","gravatar_id":"","url":"https://api.github.com/users/sellout","html_url":"https://github.com/sellout","followers_url":"https://api.github.com/users/sellout/followers","following_url":"https://api.github.com/users/sellout/following{/other_user}","gists_url":"https://api.github.com/users/sellout/gists{/gist_id}","starred_url":"https://api.github.com/users/sellout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sellout/subscriptions","organizations_url":"https://api.github.com/users/sellout/orgs","repos_url":"https://api.github.com/users/sellout/repos","events_url":"https://api.github.com/users/sellout/events{/privacy}","received_events_url":"https://api.github.com/users/sellout/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/slamdata/slamengine/pulls/595/commits","review_comments_url":"https://api.github.com/repos/slamdata/slamengine/pulls/595/comments","review_comment_url":"https://api.github.com/repos/slamdata/slamengine/pulls/comments/{number}","comments_url":"https://api.github.com/repos/slamdata/slamengine/issues/595/comments","statuses_url":"https://api.github.com/repos/slamdata/slamengine/statuses/2ef3bcd94331f22702468f0fcf1d789773202377","head":{"label":"mossprescott:ready/255","ref":"ready/255","sha":"2ef3bcd94331f22702468f0fcf1d789773202377","user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"repo":{"id":21178367,"name":"slamengine","full_name":"mossprescott/slamengine","owner":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mossprescott/slamengine","description":"The engine for SlamData","fork":true,"url":"https://api.github.com/repos/mossprescott/slamengine","forks_url":"https://api.github.com/repos/mossprescott/slamengine/forks","keys_url":"https://api.github.com/repos/mossprescott/slamengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mossprescott/slamengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mossprescott/slamengine/teams","hooks_url":"https://api.github.com/repos/mossprescott/slamengine/hooks","issue_events_url":"https://api.github.com/repos/mossprescott/slamengine/issues/events{/number}","events_url":"https://api.github.com/repos/mossprescott/slamengine/events","assignees_url":"https://api.github.com/repos/mossprescott/slamengine/assignees{/user}","branches_url":"https://api.github.com/repos/mossprescott/slamengine/branches{/branch}","tags_url":"https://api.github.com/repos/mossprescott/slamengine/tags","blobs_url":"https://api.github.com/repos/mossprescott/slamengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mossprescott/slamengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mossprescott/slamengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/mossprescott/slamengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mossprescott/slamengine/statuses/{sha}","languages_url":"https://api.github.com/repos/mossprescott/slamengine/languages","stargazers_url":"https://api.github.com/repos/mossprescott/slamengine/stargazers","contributors_url":"https://api.github.com/repos/mossprescott/slamengine/contributors","subscribers_url":"https://api.github.com/repos/mossprescott/slamengine/subscribers","subscription_url":"https://api.github.com/repos/mossprescott/slamengine/subscription","commits_url":"https://api.github.com/repos/mossprescott/slamengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/mossprescott/slamengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/mossprescott/slamengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/mossprescott/slamengine/issues/comments/{number}","contents_url":"https://api.github.com/repos/mossprescott/slamengine/contents/{+path}","compare_url":"https://api.github.com/repos/mossprescott/slamengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mossprescott/slamengine/merges","archive_url":"https://api.github.com/repos/mossprescott/slamengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mossprescott/slamengine/downloads","issues_url":"https://api.github.com/repos/mossprescott/slamengine/issues{/number}","pulls_url":"https://api.github.com/repos/mossprescott/slamengine/pulls{/number}","milestones_url":"https://api.github.com/repos/mossprescott/slamengine/milestones{/number}","notifications_url":"https://api.github.com/repos/mossprescott/slamengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mossprescott/slamengine/labels{/name}","releases_url":"https://api.github.com/repos/mossprescott/slamengine/releases{/id}","created_at":"2014-06-24T19:43:22Z","updated_at":"2015-01-08T17:19:20Z","pushed_at":"2015-02-09T23:45:46Z","git_url":"git://github.com/mossprescott/slamengine.git","ssh_url":"git@github.com:mossprescott/slamengine.git","clone_url":"https://github.com/mossprescott/slamengine.git","svn_url":"https://github.com/mossprescott/slamengine","homepage":null,"size":5404,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CHECK-UPSTREAM-REPO"}},"base":{"label":"slamdata:master","ref":"master","sha":"d9c9ac0fcdff8e78b49e6d118be7c78e82cb7f5b","user":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?v=3","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"repo":{"id":16515058,"name":"slamengine","full_name":"slamdata/slamengine","owner":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?v=3","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slamdata/slamengine","description":"The engine for SlamData","fork":false,"url":"https://api.github.com/repos/slamdata/slamengine","forks_url":"https://api.github.com/repos/slamdata/slamengine/forks","keys_url":"https://api.github.com/repos/slamdata/slamengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slamdata/slamengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slamdata/slamengine/teams","hooks_url":"https://api.github.com/repos/slamdata/slamengine/hooks","issue_events_url":"https://api.github.com/repos/slamdata/slamengine/issues/events{/number}","events_url":"https://api.github.com/repos/slamdata/slamengine/events","assignees_url":"https://api.github.com/repos/slamdata/slamengine/assignees{/user}","branches_url":"https://api.github.com/repos/slamdata/slamengine/branches{/branch}","tags_url":"https://api.github.com/repos/slamdata/slamengine/tags","blobs_url":"https://api.github.com/repos/slamdata/slamengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slamdata/slamengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slamdata/slamengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/slamdata/slamengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slamdata/slamengine/statuses/{sha}","languages_url":"https://api.github.com/repos/slamdata/slamengine/languages","stargazers_url":"https://api.github.com/repos/slamdata/slamengine/stargazers","contributors_url":"https://api.github.com/repos/slamdata/slamengine/contributors","subscribers_url":"https://api.github.com/repos/slamdata/slamengine/subscribers","subscription_url":"https://api.github.com/repos/slamdata/slamengine/subscription","commits_url":"https://api.github.com/repos/slamdata/slamengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/slamdata/slamengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/slamdata/slamengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/slamdata/slamengine/issues/comments/{number}","contents_url":"https://api.github.com/repos/slamdata/slamengine/contents/{+path}","compare_url":"https://api.github.com/repos/slamdata/slamengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slamdata/slamengine/merges","archive_url":"https://api.github.com/repos/slamdata/slamengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slamdata/slamengine/downloads","issues_url":"https://api.github.com/repos/slamdata/slamengine/issues{/number}","pulls_url":"https://api.github.com/repos/slamdata/slamengine/pulls{/number}","milestones_url":"https://api.github.com/repos/slamdata/slamengine/milestones{/number}","notifications_url":"https://api.github.com/repos/slamdata/slamengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slamdata/slamengine/labels{/name}","releases_url":"https://api.github.com/repos/slamdata/slamengine/releases{/id}","created_at":"2014-02-04T15:01:27Z","updated_at":"2015-02-09T16:37:21Z","pushed_at":"2015-02-09T16:52:32Z","git_url":"git://github.com/slamdata/slamengine.git","ssh_url":"git@github.com:slamdata/slamengine.git","clone_url":"https://github.com/slamdata/slamengine.git","svn_url":"https://github.com/slamdata/slamengine","homepage":null,"size":7457,"stargazers_count":91,"watchers_count":91,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":123,"forks":21,"open_issues":123,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/595"},"html":{"href":"https://github.com/slamdata/slamengine/pull/595"},"issue":{"href":"https://api.github.com/repos/slamdata/slamengine/issues/595"},"comments":{"href":"https://api.github.com/repos/slamdata/slamengine/issues/595/comments"},"review_comments":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/595/comments"},"review_comment":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/slamdata/slamengine/pulls/595/commits"},"statuses":{"href":"https://api.github.com/repos/slamdata/slamengine/statuses/2ef3bcd94331f22702468f0fcf1d789773202377"}}}}