{"action":"created","comment":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/47357831","id":47357831,"diff_hunk":"@@ -503,14 +503,82 @@ static std::vector<nt::idx_t> query(nt::Type_e requested_type, std::string reque\n         if (fail) {\n             throw e;\n         }\n-        BOOST_CHECK_MESSAGE(false, \" error on ptref request\" + std::string(e.what()));\n+        BOOST_CHECK_MESSAGE(false, \" error on ptref request \" + std::string(e.what()));\n         return {};\n     }\n }\n \n /*\n+ * Test the meta-vj filtering on vj\n+ */\n+BOOST_AUTO_TEST_CASE(mvj_filtering) {\n+    ed::builder builder(\"20130311\");\n+    builder.generate_dummy_basis();\n+    // Date  11    12    13    14\n+    // A      -   08:00 08:00   -\n+    // B    10:00 10:00   -   10:00\n+    // C      -     -     -   10:00\n+    builder.vj(\"A\", \"0110\")(\"stop1\", \"08:00\"_t);\n+    builder.vj(\"B\", \"1011\")(\"stop3\", \"10:00\"_t);\n+    builder.vj(\"C\", \"1000\")(\"stop3\", \"10:00\"_t);\n+    builder.finish();\n+    nt::idx_t a = 0;\n+    nt::idx_t b = 1;\n+    nt::idx_t c = 2;\n+\n+    auto check = [](const std::vector<nt::idx_t>& col, std::set<nt::idx_t> s_ref) {\n+        std::set<nt::idx_t> s_col(std::begin(col), std::end(col));\n+        BOOST_CHECK_EQUAL(s_col, s_ref);","path":"source/ptreferential/tests/ptref_test.cpp","position":30,"original_position":30,"commit_id":"5aa0697e0499a3a7993b9c64af97e263f441c560","original_commit_id":"5aa0697e0499a3a7993b9c64af97e263f441c560","user":{"login":"antoine-de","id":3987698,"avatar_url":"https://avatars.githubusercontent.com/u/3987698?v=3","gravatar_id":"","url":"https://api.github.com/users/antoine-de","html_url":"https://github.com/antoine-de","followers_url":"https://api.github.com/users/antoine-de/followers","following_url":"https://api.github.com/users/antoine-de/following{/other_user}","gists_url":"https://api.github.com/users/antoine-de/gists{/gist_id}","starred_url":"https://api.github.com/users/antoine-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoine-de/subscriptions","organizations_url":"https://api.github.com/users/antoine-de/orgs","repos_url":"https://api.github.com/users/antoine-de/repos","events_url":"https://api.github.com/users/antoine-de/events{/privacy}","received_events_url":"https://api.github.com/users/antoine-de/received_events","type":"User","site_admin":false},"body":"why not use BOOST_RANGE_EQUALS  (or whatever the name of the macro is) ?","created_at":"2015-12-11T14:09:44Z","updated_at":"2015-12-11T14:09:44Z","html_url":"https://github.com/CanalTP/navitia/pull/1328#discussion_r47357831","pull_request_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1328","_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments/47357831"},"html":{"href":"https://github.com/CanalTP/navitia/pull/1328#discussion_r47357831"},"pull_request":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1328"}}},"pull_request":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/1328","id":53394306,"html_url":"https://github.com/CanalTP/navitia/pull/1328","diff_url":"https://github.com/CanalTP/navitia/pull/1328.diff","patch_url":"https://github.com/CanalTP/navitia/pull/1328.patch","issue_url":"https://api.github.com/repos/CanalTP/navitia/issues/1328","number":1328,"state":"open","locked":false,"title":"PTRef: add meta-vj","user":{"login":"pbougue","id":12812530,"avatar_url":"https://avatars.githubusercontent.com/u/12812530?v=3","gravatar_id":"","url":"https://api.github.com/users/pbougue","html_url":"https://github.com/pbougue","followers_url":"https://api.github.com/users/pbougue/followers","following_url":"https://api.github.com/users/pbougue/following{/other_user}","gists_url":"https://api.github.com/users/pbougue/gists{/gist_id}","starred_url":"https://api.github.com/users/pbougue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbougue/subscriptions","organizations_url":"https://api.github.com/users/pbougue/orgs","repos_url":"https://api.github.com/users/pbougue/repos","events_url":"https://api.github.com/users/pbougue/events{/privacy}","received_events_url":"https://api.github.com/users/pbougue/received_events","type":"User","site_admin":false},"body":"links:\r\n* meta-vj <--> vj\r\n* meta-vj  ---> impact","created_at":"2015-12-11T13:49:04Z","updated_at":"2015-12-11T14:09:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1fde5cee313261262033227cae8bb6458db3d6f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1328/commits","review_comments_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1328/comments","review_comment_url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanalTP/navitia/issues/1328/comments","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/5aa0697e0499a3a7993b9c64af97e263f441c560","head":{"label":"pbougue:ptref_add_metavj","ref":"ptref_add_metavj","sha":"5aa0697e0499a3a7993b9c64af97e263f441c560","user":{"login":"pbougue","id":12812530,"avatar_url":"https://avatars.githubusercontent.com/u/12812530?v=3","gravatar_id":"","url":"https://api.github.com/users/pbougue","html_url":"https://github.com/pbougue","followers_url":"https://api.github.com/users/pbougue/followers","following_url":"https://api.github.com/users/pbougue/following{/other_user}","gists_url":"https://api.github.com/users/pbougue/gists{/gist_id}","starred_url":"https://api.github.com/users/pbougue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbougue/subscriptions","organizations_url":"https://api.github.com/users/pbougue/orgs","repos_url":"https://api.github.com/users/pbougue/repos","events_url":"https://api.github.com/users/pbougue/events{/privacy}","received_events_url":"https://api.github.com/users/pbougue/received_events","type":"User","site_admin":false},"repo":{"id":37126861,"name":"navitia","full_name":"pbougue/navitia","owner":{"login":"pbougue","id":12812530,"avatar_url":"https://avatars.githubusercontent.com/u/12812530?v=3","gravatar_id":"","url":"https://api.github.com/users/pbougue","html_url":"https://github.com/pbougue","followers_url":"https://api.github.com/users/pbougue/followers","following_url":"https://api.github.com/users/pbougue/following{/other_user}","gists_url":"https://api.github.com/users/pbougue/gists{/gist_id}","starred_url":"https://api.github.com/users/pbougue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbougue/subscriptions","organizations_url":"https://api.github.com/users/pbougue/orgs","repos_url":"https://api.github.com/users/pbougue/repos","events_url":"https://api.github.com/users/pbougue/events{/privacy}","received_events_url":"https://api.github.com/users/pbougue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pbougue/navitia","description":"The REST API to build cool stuff with public transport","fork":true,"url":"https://api.github.com/repos/pbougue/navitia","forks_url":"https://api.github.com/repos/pbougue/navitia/forks","keys_url":"https://api.github.com/repos/pbougue/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pbougue/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pbougue/navitia/teams","hooks_url":"https://api.github.com/repos/pbougue/navitia/hooks","issue_events_url":"https://api.github.com/repos/pbougue/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/pbougue/navitia/events","assignees_url":"https://api.github.com/repos/pbougue/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/pbougue/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/pbougue/navitia/tags","blobs_url":"https://api.github.com/repos/pbougue/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pbougue/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pbougue/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/pbougue/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pbougue/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/pbougue/navitia/languages","stargazers_url":"https://api.github.com/repos/pbougue/navitia/stargazers","contributors_url":"https://api.github.com/repos/pbougue/navitia/contributors","subscribers_url":"https://api.github.com/repos/pbougue/navitia/subscribers","subscription_url":"https://api.github.com/repos/pbougue/navitia/subscription","commits_url":"https://api.github.com/repos/pbougue/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/pbougue/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/pbougue/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/pbougue/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/pbougue/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/pbougue/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pbougue/navitia/merges","archive_url":"https://api.github.com/repos/pbougue/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pbougue/navitia/downloads","issues_url":"https://api.github.com/repos/pbougue/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/pbougue/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/pbougue/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/pbougue/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pbougue/navitia/labels{/name}","releases_url":"https://api.github.com/repos/pbougue/navitia/releases{/id}","created_at":"2015-06-09T10:57:48Z","updated_at":"2015-06-09T10:57:50Z","pushed_at":"2015-12-11T13:52:11Z","git_url":"git://github.com/pbougue/navitia.git","ssh_url":"git@github.com:pbougue/navitia.git","clone_url":"https://github.com/pbougue/navitia.git","svn_url":"https://github.com/pbougue/navitia","homepage":"http://www.navitia.io","size":26992,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"CanalTP:dev","ref":"dev","sha":"dfd2323ee533fe66070d7870a70d2cd51433fe36","user":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"repo":{"id":10797333,"name":"navitia","full_name":"CanalTP/navitia","owner":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanalTP/navitia","description":"The REST API to build cool stuff with public transport","fork":false,"url":"https://api.github.com/repos/CanalTP/navitia","forks_url":"https://api.github.com/repos/CanalTP/navitia/forks","keys_url":"https://api.github.com/repos/CanalTP/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanalTP/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanalTP/navitia/teams","hooks_url":"https://api.github.com/repos/CanalTP/navitia/hooks","issue_events_url":"https://api.github.com/repos/CanalTP/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/CanalTP/navitia/events","assignees_url":"https://api.github.com/repos/CanalTP/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/CanalTP/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/CanalTP/navitia/tags","blobs_url":"https://api.github.com/repos/CanalTP/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanalTP/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanalTP/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanalTP/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/CanalTP/navitia/languages","stargazers_url":"https://api.github.com/repos/CanalTP/navitia/stargazers","contributors_url":"https://api.github.com/repos/CanalTP/navitia/contributors","subscribers_url":"https://api.github.com/repos/CanalTP/navitia/subscribers","subscription_url":"https://api.github.com/repos/CanalTP/navitia/subscription","commits_url":"https://api.github.com/repos/CanalTP/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanalTP/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanalTP/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanalTP/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanalTP/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/CanalTP/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanalTP/navitia/merges","archive_url":"https://api.github.com/repos/CanalTP/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanalTP/navitia/downloads","issues_url":"https://api.github.com/repos/CanalTP/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/CanalTP/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/CanalTP/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/CanalTP/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanalTP/navitia/labels{/name}","releases_url":"https://api.github.com/repos/CanalTP/navitia/releases{/id}","created_at":"2013-06-19T15:34:30Z","updated_at":"2015-12-11T06:04:34Z","pushed_at":"2015-12-11T13:52:11Z","git_url":"git://github.com/CanalTP/navitia.git","ssh_url":"git@github.com:CanalTP/navitia.git","clone_url":"https://github.com/CanalTP/navitia.git","svn_url":"https://github.com/CanalTP/navitia","homepage":"http://www.navitia.io","size":27885,"stargazers_count":134,"watchers_count":134,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":16,"forks":47,"open_issues":16,"watchers":134,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1328"},"html":{"href":"https://github.com/CanalTP/navitia/pull/1328"},"issue":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/1328"},"comments":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/1328/comments"},"review_comments":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1328/comments"},"review_comment":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1328/commits"},"statuses":{"href":"https://api.github.com/repos/CanalTP/navitia/statuses/5aa0697e0499a3a7993b9c64af97e263f441c560"}}}}