{"action":"closed","issue":{"url":"https://api.github.com/repos/mapbox/mapnik-vector-tile/issues/95","labels_url":"https://api.github.com/repos/mapbox/mapnik-vector-tile/issues/95/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapnik-vector-tile/issues/95/comments","events_url":"https://api.github.com/repos/mapbox/mapnik-vector-tile/issues/95/events","html_url":"https://github.com/mapbox/mapnik-vector-tile/issues/95","id":64887974,"number":95,"title":"Code coverage","user":{"login":"springmeyer","id":20300,"avatar_url":"https://avatars.githubusercontent.com/u/20300?v=3","gravatar_id":"","url":"https://api.github.com/users/springmeyer","html_url":"https://github.com/springmeyer","followers_url":"https://api.github.com/users/springmeyer/followers","following_url":"https://api.github.com/users/springmeyer/following{/other_user}","gists_url":"https://api.github.com/users/springmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/springmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/springmeyer/subscriptions","organizations_url":"https://api.github.com/users/springmeyer/orgs","repos_url":"https://api.github.com/users/springmeyer/repos","events_url":"https://api.github.com/users/springmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/springmeyer/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-28T02:20:48Z","updated_at":"2015-05-07T20:02:29Z","closed_at":"2015-05-07T20:02:29Z","body":"Code coverage I think is going to be poor for this repo, so will be great to see. The changes coming up in #93 are large so coverage I think would make sense to start on after we merge #93 (or in the https://github.com/mapbox/mapnik-vector-tile/tree/mapnik-geometry branch).\r\n\r\nA big reason why coverage is crap is the lack of a good harness in C++ for writing visual tests and/or tests that use external fixtures (like directory of expected geojson fixtures). So I think we should start on that. I still like the idea of this existing outside of mapnik.\r\n\r\nResources:\r\n\r\n - @talaj mentioned he's got a c++ runner going for visual tests in mapnik core: https://github.com/mapnik/mapnik/issues/2744#issuecomment-86835227 as part of https://github.com/mapnik/mapnik/issues/2575\r\n - code from https://github.com/mapnik/mapnik/blob/master/benchmark/bench_framework.hpp and https://github.com/mapnik/mapnik/blob/master/benchmark/compare_images.hpp could be stolen too\r\n - The JSON input and output grammars in the mapnik-geometry branch are way nicer now (since they work on `mapnik::geometry` objects rather than vertex_converters (aka paths) so using them to read and serialize fixtures would be great."}}