{"action":"created","comment":{"url":"https://api.github.com/repos/modxcms/revolution/pulls/comments/33555293","id":33555293,"diff_hunk":"@@ -10,7 +10,8 @@ public function checkPermissions() {\n         return $this->modx->hasPermission('error_log_erase');\n     }\n     public function process() {\n-        $file = $this->modx->getOption(xPDO::OPT_CACHE_PATH).'logs/error.log';\n+        $error_log_path = $this->modx->getOption('error_log_path');\n+        $file = MODX_BASE_PATH.$error_log_path.'error.log';","path":"core/model/modx/processors/system/errorlog/clear.class.php","position":6,"original_position":6,"commit_id":"11ab1e1e26200547c548dc8bef4c5b6801d6f1bc","original_commit_id":"11ab1e1e26200547c548dc8bef4c5b6801d6f1bc","user":{"login":"goldsky","id":308524,"avatar_url":"https://avatars.githubusercontent.com/u/308524?v=3","gravatar_id":"","url":"https://api.github.com/users/goldsky","html_url":"https://github.com/goldsky","followers_url":"https://api.github.com/users/goldsky/followers","following_url":"https://api.github.com/users/goldsky/following{/other_user}","gists_url":"https://api.github.com/users/goldsky/gists{/gist_id}","starred_url":"https://api.github.com/users/goldsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldsky/subscriptions","organizations_url":"https://api.github.com/users/goldsky/orgs","repos_url":"https://api.github.com/users/goldsky/repos","events_url":"https://api.github.com/users/goldsky/events{/privacy}","received_events_url":"https://api.github.com/users/goldsky/received_events","type":"User","site_admin":false},"body":"This should be an absolute path, eg `/home/website.tld/core/error.log`","created_at":"2015-06-30T09:29:58Z","updated_at":"2015-06-30T09:29:58Z","html_url":"https://github.com/modxcms/revolution/pull/12352#discussion_r33555293","pull_request_url":"https://api.github.com/repos/modxcms/revolution/pulls/12352","_links":{"self":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/comments/33555293"},"html":{"href":"https://github.com/modxcms/revolution/pull/12352#discussion_r33555293"},"pull_request":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12352"}}},"pull_request":{"url":"https://api.github.com/repos/modxcms/revolution/pulls/12352","id":28882920,"html_url":"https://github.com/modxcms/revolution/pull/12352","diff_url":"https://github.com/modxcms/revolution/pull/12352.diff","patch_url":"https://github.com/modxcms/revolution/pull/12352.patch","issue_url":"https://api.github.com/repos/modxcms/revolution/issues/12352","number":12352,"state":"open","locked":false,"title":"add system setting for error.log which defaults to 'logs/' and uses this configurable path for logging","user":{"login":"gerrit1986","id":2026215,"avatar_url":"https://avatars.githubusercontent.com/u/2026215?v=3","gravatar_id":"","url":"https://api.github.com/users/gerrit1986","html_url":"https://github.com/gerrit1986","followers_url":"https://api.github.com/users/gerrit1986/followers","following_url":"https://api.github.com/users/gerrit1986/following{/other_user}","gists_url":"https://api.github.com/users/gerrit1986/gists{/gist_id}","starred_url":"https://api.github.com/users/gerrit1986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerrit1986/subscriptions","organizations_url":"https://api.github.com/users/gerrit1986/orgs","repos_url":"https://api.github.com/users/gerrit1986/repos","events_url":"https://api.github.com/users/gerrit1986/events{/privacy}","received_events_url":"https://api.github.com/users/gerrit1986/received_events","type":"User","site_admin":false},"body":"worked on this at modx ccc 2015. \r\ni hope it does not break anything. \r\nany feedback is appreciated.\r\nhttps://github.com/modx-ccc-2015/whishlist/issues/39","created_at":"2015-02-08T16:58:09Z","updated_at":"2015-06-30T09:29:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea8efbf88d6e55126d7ca99779c9523982fa078d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/modxcms/revolution/pulls/12352/commits","review_comments_url":"https://api.github.com/repos/modxcms/revolution/pulls/12352/comments","review_comment_url":"https://api.github.com/repos/modxcms/revolution/pulls/comments{/number}","comments_url":"https://api.github.com/repos/modxcms/revolution/issues/12352/comments","statuses_url":"https://api.github.com/repos/modxcms/revolution/statuses/11ab1e1e26200547c548dc8bef4c5b6801d6f1bc","head":{"label":"gerrit1986:errorlog","ref":"errorlog","sha":"11ab1e1e26200547c548dc8bef4c5b6801d6f1bc","user":{"login":"gerrit1986","id":2026215,"avatar_url":"https://avatars.githubusercontent.com/u/2026215?v=3","gravatar_id":"","url":"https://api.github.com/users/gerrit1986","html_url":"https://github.com/gerrit1986","followers_url":"https://api.github.com/users/gerrit1986/followers","following_url":"https://api.github.com/users/gerrit1986/following{/other_user}","gists_url":"https://api.github.com/users/gerrit1986/gists{/gist_id}","starred_url":"https://api.github.com/users/gerrit1986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerrit1986/subscriptions","organizations_url":"https://api.github.com/users/gerrit1986/orgs","repos_url":"https://api.github.com/users/gerrit1986/repos","events_url":"https://api.github.com/users/gerrit1986/events{/privacy}","received_events_url":"https://api.github.com/users/gerrit1986/received_events","type":"User","site_admin":false},"repo":{"id":30469191,"name":"revolution","full_name":"gerrit1986/revolution","owner":{"login":"gerrit1986","id":2026215,"avatar_url":"https://avatars.githubusercontent.com/u/2026215?v=3","gravatar_id":"","url":"https://api.github.com/users/gerrit1986","html_url":"https://github.com/gerrit1986","followers_url":"https://api.github.com/users/gerrit1986/followers","following_url":"https://api.github.com/users/gerrit1986/following{/other_user}","gists_url":"https://api.github.com/users/gerrit1986/gists{/gist_id}","starred_url":"https://api.github.com/users/gerrit1986/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerrit1986/subscriptions","organizations_url":"https://api.github.com/users/gerrit1986/orgs","repos_url":"https://api.github.com/users/gerrit1986/repos","events_url":"https://api.github.com/users/gerrit1986/events{/privacy}","received_events_url":"https://api.github.com/users/gerrit1986/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gerrit1986/revolution","description":"MODX Revolution - Content Application Platform","fork":true,"url":"https://api.github.com/repos/gerrit1986/revolution","forks_url":"https://api.github.com/repos/gerrit1986/revolution/forks","keys_url":"https://api.github.com/repos/gerrit1986/revolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gerrit1986/revolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gerrit1986/revolution/teams","hooks_url":"https://api.github.com/repos/gerrit1986/revolution/hooks","issue_events_url":"https://api.github.com/repos/gerrit1986/revolution/issues/events{/number}","events_url":"https://api.github.com/repos/gerrit1986/revolution/events","assignees_url":"https://api.github.com/repos/gerrit1986/revolution/assignees{/user}","branches_url":"https://api.github.com/repos/gerrit1986/revolution/branches{/branch}","tags_url":"https://api.github.com/repos/gerrit1986/revolution/tags","blobs_url":"https://api.github.com/repos/gerrit1986/revolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gerrit1986/revolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gerrit1986/revolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/gerrit1986/revolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gerrit1986/revolution/statuses/{sha}","languages_url":"https://api.github.com/repos/gerrit1986/revolution/languages","stargazers_url":"https://api.github.com/repos/gerrit1986/revolution/stargazers","contributors_url":"https://api.github.com/repos/gerrit1986/revolution/contributors","subscribers_url":"https://api.github.com/repos/gerrit1986/revolution/subscribers","subscription_url":"https://api.github.com/repos/gerrit1986/revolution/subscription","commits_url":"https://api.github.com/repos/gerrit1986/revolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/gerrit1986/revolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/gerrit1986/revolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/gerrit1986/revolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/gerrit1986/revolution/contents/{+path}","compare_url":"https://api.github.com/repos/gerrit1986/revolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gerrit1986/revolution/merges","archive_url":"https://api.github.com/repos/gerrit1986/revolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gerrit1986/revolution/downloads","issues_url":"https://api.github.com/repos/gerrit1986/revolution/issues{/number}","pulls_url":"https://api.github.com/repos/gerrit1986/revolution/pulls{/number}","milestones_url":"https://api.github.com/repos/gerrit1986/revolution/milestones{/number}","notifications_url":"https://api.github.com/repos/gerrit1986/revolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gerrit1986/revolution/labels{/name}","releases_url":"https://api.github.com/repos/gerrit1986/revolution/releases{/id}","created_at":"2015-02-07T20:31:35Z","updated_at":"2015-02-08T20:40:22Z","pushed_at":"2015-02-08T16:07:54Z","git_url":"git://github.com/gerrit1986/revolution.git","ssh_url":"git@github.com:gerrit1986/revolution.git","clone_url":"https://github.com/gerrit1986/revolution.git","svn_url":"https://github.com/gerrit1986/revolution","homepage":"http://rtfm.modx.com/revolution/2.x/","size":43973,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"modxcms:develop","ref":"develop","sha":"e80c9bd31fb68ca9714bea8394a1ad121424af9e","user":{"login":"modxcms","id":232723,"avatar_url":"https://avatars.githubusercontent.com/u/232723?v=3","gravatar_id":"","url":"https://api.github.com/users/modxcms","html_url":"https://github.com/modxcms","followers_url":"https://api.github.com/users/modxcms/followers","following_url":"https://api.github.com/users/modxcms/following{/other_user}","gists_url":"https://api.github.com/users/modxcms/gists{/gist_id}","starred_url":"https://api.github.com/users/modxcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modxcms/subscriptions","organizations_url":"https://api.github.com/users/modxcms/orgs","repos_url":"https://api.github.com/users/modxcms/repos","events_url":"https://api.github.com/users/modxcms/events{/privacy}","received_events_url":"https://api.github.com/users/modxcms/received_events","type":"Organization","site_admin":false},"repo":{"id":806201,"name":"revolution","full_name":"modxcms/revolution","owner":{"login":"modxcms","id":232723,"avatar_url":"https://avatars.githubusercontent.com/u/232723?v=3","gravatar_id":"","url":"https://api.github.com/users/modxcms","html_url":"https://github.com/modxcms","followers_url":"https://api.github.com/users/modxcms/followers","following_url":"https://api.github.com/users/modxcms/following{/other_user}","gists_url":"https://api.github.com/users/modxcms/gists{/gist_id}","starred_url":"https://api.github.com/users/modxcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modxcms/subscriptions","organizations_url":"https://api.github.com/users/modxcms/orgs","repos_url":"https://api.github.com/users/modxcms/repos","events_url":"https://api.github.com/users/modxcms/events{/privacy}","received_events_url":"https://api.github.com/users/modxcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/modxcms/revolution","description":"MODX Revolution - Content Application Platform","fork":false,"url":"https://api.github.com/repos/modxcms/revolution","forks_url":"https://api.github.com/repos/modxcms/revolution/forks","keys_url":"https://api.github.com/repos/modxcms/revolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modxcms/revolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modxcms/revolution/teams","hooks_url":"https://api.github.com/repos/modxcms/revolution/hooks","issue_events_url":"https://api.github.com/repos/modxcms/revolution/issues/events{/number}","events_url":"https://api.github.com/repos/modxcms/revolution/events","assignees_url":"https://api.github.com/repos/modxcms/revolution/assignees{/user}","branches_url":"https://api.github.com/repos/modxcms/revolution/branches{/branch}","tags_url":"https://api.github.com/repos/modxcms/revolution/tags","blobs_url":"https://api.github.com/repos/modxcms/revolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modxcms/revolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modxcms/revolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/modxcms/revolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modxcms/revolution/statuses/{sha}","languages_url":"https://api.github.com/repos/modxcms/revolution/languages","stargazers_url":"https://api.github.com/repos/modxcms/revolution/stargazers","contributors_url":"https://api.github.com/repos/modxcms/revolution/contributors","subscribers_url":"https://api.github.com/repos/modxcms/revolution/subscribers","subscription_url":"https://api.github.com/repos/modxcms/revolution/subscription","commits_url":"https://api.github.com/repos/modxcms/revolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/modxcms/revolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/modxcms/revolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/modxcms/revolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/modxcms/revolution/contents/{+path}","compare_url":"https://api.github.com/repos/modxcms/revolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modxcms/revolution/merges","archive_url":"https://api.github.com/repos/modxcms/revolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modxcms/revolution/downloads","issues_url":"https://api.github.com/repos/modxcms/revolution/issues{/number}","pulls_url":"https://api.github.com/repos/modxcms/revolution/pulls{/number}","milestones_url":"https://api.github.com/repos/modxcms/revolution/milestones{/number}","notifications_url":"https://api.github.com/repos/modxcms/revolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modxcms/revolution/labels{/name}","releases_url":"https://api.github.com/repos/modxcms/revolution/releases{/id}","created_at":"2010-07-29T21:03:57Z","updated_at":"2015-06-22T16:07:18Z","pushed_at":"2015-06-29T14:05:47Z","git_url":"git://github.com/modxcms/revolution.git","ssh_url":"git@github.com:modxcms/revolution.git","clone_url":"https://github.com/modxcms/revolution.git","svn_url":"https://github.com/modxcms/revolution","homepage":"http://rtfm.modx.com/revolution/2.x/","size":78684,"stargazers_count":687,"watchers_count":687,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":346,"mirror_url":null,"open_issues_count":950,"forks":346,"open_issues":950,"watchers":687,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12352"},"html":{"href":"https://github.com/modxcms/revolution/pull/12352"},"issue":{"href":"https://api.github.com/repos/modxcms/revolution/issues/12352"},"comments":{"href":"https://api.github.com/repos/modxcms/revolution/issues/12352/comments"},"review_comments":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12352/comments"},"review_comment":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12352/commits"},"statuses":{"href":"https://api.github.com/repos/modxcms/revolution/statuses/11ab1e1e26200547c548dc8bef4c5b6801d6f1bc"}}}}