{"action":"opened","number":23,"pull_request":{"url":"https://api.github.com/repos/sctb/lumen/pulls/23","id":48161633,"html_url":"https://github.com/sctb/lumen/pull/23","diff_url":"https://github.com/sctb/lumen/pull/23.diff","patch_url":"https://github.com/sctb/lumen/pull/23.patch","issue_url":"https://api.github.com/repos/sctb/lumen/issues/23","number":23,"state":"open","locked":false,"title":"LUMEN_HOST=node is broken.","user":{"login":"laarc","id":13237912,"avatar_url":"https://avatars.githubusercontent.com/u/13237912?v=3","gravatar_id":"","url":"https://api.github.com/users/laarc","html_url":"https://github.com/laarc","followers_url":"https://api.github.com/users/laarc/followers","following_url":"https://api.github.com/users/laarc/following{/other_user}","gists_url":"https://api.github.com/users/laarc/gists{/gist_id}","starred_url":"https://api.github.com/users/laarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laarc/subscriptions","organizations_url":"https://api.github.com/users/laarc/orgs","repos_url":"https://api.github.com/users/laarc/repos","events_url":"https://api.github.com/users/laarc/events{/privacy}","received_events_url":"https://api.github.com/users/laarc/received_events","type":"User","site_admin":false},"body":"This PR fixes `LUMEN_HOST=node`. My earlier commit 435eb45 broke the node host in two different ways:\r\n\r\n- I added the `literals` table into `reader.l`, causing `(read-string \"toString\")` to incorrectly return a `function` rather than `\"toString\"`:\r\n\r\n```sh\r\n$ LUMEN_HOST=node bin/lumen -e '((get (require \"reader\") \"read-string\") \"toString\")'\r\nfunction\r\n```\r\n\r\n- I neglected to add `nan?` and `inf?` checks to `compile-atom`.  Since 435eb45 changed the reader to output literal `NaN` and `Infinity` rather than `\"nan\"` and `\"inf\"`, `compile-atom` therefore needed to check for those cases, just like it checks for `boolean?`.\r\n\r\n```sh\r\n$ LUMEN_HOST=node bin/lumen -e '(compile inf)'\r\n\"Infinity\"\r\n```\r\n\r\nSorry about that.  The root of the problem was that I was too reliant on unit tests.  I should have run `export LUMEN_HOST=node; make clean; make; make test` before submitting the pull request, which would have revealed the problem.\r\n\r\n","created_at":"2015-10-20T06:34:22Z","updated_at":"2015-10-20T06:34:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sctb/lumen/pulls/23/commits","review_comments_url":"https://api.github.com/repos/sctb/lumen/pulls/23/comments","review_comment_url":"https://api.github.com/repos/sctb/lumen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sctb/lumen/issues/23/comments","statuses_url":"https://api.github.com/repos/sctb/lumen/statuses/fc356f2ba3a688f39553bbc29ddd2fae7d997422","head":{"label":"laarc:0008-reader-fix","ref":"0008-reader-fix","sha":"fc356f2ba3a688f39553bbc29ddd2fae7d997422","user":{"login":"laarc","id":13237912,"avatar_url":"https://avatars.githubusercontent.com/u/13237912?v=3","gravatar_id":"","url":"https://api.github.com/users/laarc","html_url":"https://github.com/laarc","followers_url":"https://api.github.com/users/laarc/followers","following_url":"https://api.github.com/users/laarc/following{/other_user}","gists_url":"https://api.github.com/users/laarc/gists{/gist_id}","starred_url":"https://api.github.com/users/laarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laarc/subscriptions","organizations_url":"https://api.github.com/users/laarc/orgs","repos_url":"https://api.github.com/users/laarc/repos","events_url":"https://api.github.com/users/laarc/events{/privacy}","received_events_url":"https://api.github.com/users/laarc/received_events","type":"User","site_admin":false},"repo":{"id":42559881,"name":"lumen","full_name":"laarc/lumen","owner":{"login":"laarc","id":13237912,"avatar_url":"https://avatars.githubusercontent.com/u/13237912?v=3","gravatar_id":"","url":"https://api.github.com/users/laarc","html_url":"https://github.com/laarc","followers_url":"https://api.github.com/users/laarc/followers","following_url":"https://api.github.com/users/laarc/following{/other_user}","gists_url":"https://api.github.com/users/laarc/gists{/gist_id}","starred_url":"https://api.github.com/users/laarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laarc/subscriptions","organizations_url":"https://api.github.com/users/laarc/orgs","repos_url":"https://api.github.com/users/laarc/repos","events_url":"https://api.github.com/users/laarc/events{/privacy}","received_events_url":"https://api.github.com/users/laarc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laarc/lumen","description":"A Lisp for Lua and JavaScript","fork":true,"url":"https://api.github.com/repos/laarc/lumen","forks_url":"https://api.github.com/repos/laarc/lumen/forks","keys_url":"https://api.github.com/repos/laarc/lumen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laarc/lumen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laarc/lumen/teams","hooks_url":"https://api.github.com/repos/laarc/lumen/hooks","issue_events_url":"https://api.github.com/repos/laarc/lumen/issues/events{/number}","events_url":"https://api.github.com/repos/laarc/lumen/events","assignees_url":"https://api.github.com/repos/laarc/lumen/assignees{/user}","branches_url":"https://api.github.com/repos/laarc/lumen/branches{/branch}","tags_url":"https://api.github.com/repos/laarc/lumen/tags","blobs_url":"https://api.github.com/repos/laarc/lumen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laarc/lumen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laarc/lumen/git/refs{/sha}","trees_url":"https://api.github.com/repos/laarc/lumen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laarc/lumen/statuses/{sha}","languages_url":"https://api.github.com/repos/laarc/lumen/languages","stargazers_url":"https://api.github.com/repos/laarc/lumen/stargazers","contributors_url":"https://api.github.com/repos/laarc/lumen/contributors","subscribers_url":"https://api.github.com/repos/laarc/lumen/subscribers","subscription_url":"https://api.github.com/repos/laarc/lumen/subscription","commits_url":"https://api.github.com/repos/laarc/lumen/commits{/sha}","git_commits_url":"https://api.github.com/repos/laarc/lumen/git/commits{/sha}","comments_url":"https://api.github.com/repos/laarc/lumen/comments{/number}","issue_comment_url":"https://api.github.com/repos/laarc/lumen/issues/comments{/number}","contents_url":"https://api.github.com/repos/laarc/lumen/contents/{+path}","compare_url":"https://api.github.com/repos/laarc/lumen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laarc/lumen/merges","archive_url":"https://api.github.com/repos/laarc/lumen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laarc/lumen/downloads","issues_url":"https://api.github.com/repos/laarc/lumen/issues{/number}","pulls_url":"https://api.github.com/repos/laarc/lumen/pulls{/number}","milestones_url":"https://api.github.com/repos/laarc/lumen/milestones{/number}","notifications_url":"https://api.github.com/repos/laarc/lumen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laarc/lumen/labels{/name}","releases_url":"https://api.github.com/repos/laarc/lumen/releases{/id}","created_at":"2015-09-16T02:33:47Z","updated_at":"2015-09-16T02:33:47Z","pushed_at":"2015-10-20T06:08:33Z","git_url":"git://github.com/laarc/lumen.git","ssh_url":"git@github.com:laarc/lumen.git","clone_url":"https://github.com/laarc/lumen.git","svn_url":"https://github.com/laarc/lumen","homepage":"","size":5417,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sctb:master","ref":"master","sha":"37fbe95622b7c2d9264ede6aa9f3ce5523dca252","user":{"login":"sctb","id":41661,"avatar_url":"https://avatars.githubusercontent.com/u/41661?v=3","gravatar_id":"","url":"https://api.github.com/users/sctb","html_url":"https://github.com/sctb","followers_url":"https://api.github.com/users/sctb/followers","following_url":"https://api.github.com/users/sctb/following{/other_user}","gists_url":"https://api.github.com/users/sctb/gists{/gist_id}","starred_url":"https://api.github.com/users/sctb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sctb/subscriptions","organizations_url":"https://api.github.com/users/sctb/orgs","repos_url":"https://api.github.com/users/sctb/repos","events_url":"https://api.github.com/users/sctb/events{/privacy}","received_events_url":"https://api.github.com/users/sctb/received_events","type":"User","site_admin":false},"repo":{"id":5433309,"name":"lumen","full_name":"sctb/lumen","owner":{"login":"sctb","id":41661,"avatar_url":"https://avatars.githubusercontent.com/u/41661?v=3","gravatar_id":"","url":"https://api.github.com/users/sctb","html_url":"https://github.com/sctb","followers_url":"https://api.github.com/users/sctb/followers","following_url":"https://api.github.com/users/sctb/following{/other_user}","gists_url":"https://api.github.com/users/sctb/gists{/gist_id}","starred_url":"https://api.github.com/users/sctb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sctb/subscriptions","organizations_url":"https://api.github.com/users/sctb/orgs","repos_url":"https://api.github.com/users/sctb/repos","events_url":"https://api.github.com/users/sctb/events{/privacy}","received_events_url":"https://api.github.com/users/sctb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sctb/lumen","description":"A Lisp for Lua and JavaScript","fork":false,"url":"https://api.github.com/repos/sctb/lumen","forks_url":"https://api.github.com/repos/sctb/lumen/forks","keys_url":"https://api.github.com/repos/sctb/lumen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sctb/lumen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sctb/lumen/teams","hooks_url":"https://api.github.com/repos/sctb/lumen/hooks","issue_events_url":"https://api.github.com/repos/sctb/lumen/issues/events{/number}","events_url":"https://api.github.com/repos/sctb/lumen/events","assignees_url":"https://api.github.com/repos/sctb/lumen/assignees{/user}","branches_url":"https://api.github.com/repos/sctb/lumen/branches{/branch}","tags_url":"https://api.github.com/repos/sctb/lumen/tags","blobs_url":"https://api.github.com/repos/sctb/lumen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sctb/lumen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sctb/lumen/git/refs{/sha}","trees_url":"https://api.github.com/repos/sctb/lumen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sctb/lumen/statuses/{sha}","languages_url":"https://api.github.com/repos/sctb/lumen/languages","stargazers_url":"https://api.github.com/repos/sctb/lumen/stargazers","contributors_url":"https://api.github.com/repos/sctb/lumen/contributors","subscribers_url":"https://api.github.com/repos/sctb/lumen/subscribers","subscription_url":"https://api.github.com/repos/sctb/lumen/subscription","commits_url":"https://api.github.com/repos/sctb/lumen/commits{/sha}","git_commits_url":"https://api.github.com/repos/sctb/lumen/git/commits{/sha}","comments_url":"https://api.github.com/repos/sctb/lumen/comments{/number}","issue_comment_url":"https://api.github.com/repos/sctb/lumen/issues/comments{/number}","contents_url":"https://api.github.com/repos/sctb/lumen/contents/{+path}","compare_url":"https://api.github.com/repos/sctb/lumen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sctb/lumen/merges","archive_url":"https://api.github.com/repos/sctb/lumen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sctb/lumen/downloads","issues_url":"https://api.github.com/repos/sctb/lumen/issues{/number}","pulls_url":"https://api.github.com/repos/sctb/lumen/pulls{/number}","milestones_url":"https://api.github.com/repos/sctb/lumen/milestones{/number}","notifications_url":"https://api.github.com/repos/sctb/lumen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sctb/lumen/labels{/name}","releases_url":"https://api.github.com/repos/sctb/lumen/releases{/id}","created_at":"2012-08-16T00:36:00Z","updated_at":"2015-10-17T06:40:55Z","pushed_at":"2015-10-08T18:17:17Z","git_url":"git://github.com/sctb/lumen.git","ssh_url":"git@github.com:sctb/lumen.git","clone_url":"https://github.com/sctb/lumen.git","svn_url":"https://github.com/sctb/lumen","homepage":"","size":6975,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sctb/lumen/pulls/23"},"html":{"href":"https://github.com/sctb/lumen/pull/23"},"issue":{"href":"https://api.github.com/repos/sctb/lumen/issues/23"},"comments":{"href":"https://api.github.com/repos/sctb/lumen/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/sctb/lumen/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/sctb/lumen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sctb/lumen/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/sctb/lumen/statuses/fc356f2ba3a688f39553bbc29ddd2fae7d997422"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":146,"deletions":84,"changed_files":7}}