{"action":"created","comment":{"url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/comments/29721196","id":29721196,"diff_hunk":"@@ -359,22 +359,12 @@ def ready_image(action_handler, image_spec, image_options)\n     end\n \n     def destroy_image(action_handler, image_spec, image_options)\n-      actual_image = image_for(image_spec)\n-      if actual_image.nil? || !actual_image.exists?\n-        Chef::Log.warn \"Image #{image_spec.name} doesn't exist\"\n-      else\n-        snapshots = actual_image.block_device_mappings.map do |dev, opts|\n-          ec2.snapshots[opts[:snapshot_id]]\n-        end\n-        action_handler.perform_action \"De-registering image #{image_spec.name}\" do\n-          actual_image.deregister\n-        end\n-        if snapshots.any?\n-          action_handler.perform_action \"Deleting image #{image_spec.name} snapshots\" do\n-            snapshots.each do |snap|\n-              snap.delete\n-            end\n-          end\n+      # TODO the driver should automatically be set by `inline_resource`\n+      d = self\n+      Provisioning.inline_resource(action_handler) do","path":"lib/chef/provisioning/aws_driver/driver.rb","position":22,"original_position":22,"commit_id":"12596ab9365db4566be3bc9a6214e72d69966699","original_commit_id":"12596ab9365db4566be3bc9a6214e72d69966699","user":{"login":"tyler-ball","id":2481463,"avatar_url":"https://avatars.githubusercontent.com/u/2481463?v=3","gravatar_id":"","url":"https://api.github.com/users/tyler-ball","html_url":"https://github.com/tyler-ball","followers_url":"https://api.github.com/users/tyler-ball/followers","following_url":"https://api.github.com/users/tyler-ball/following{/other_user}","gists_url":"https://api.github.com/users/tyler-ball/gists{/gist_id}","starred_url":"https://api.github.com/users/tyler-ball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyler-ball/subscriptions","organizations_url":"https://api.github.com/users/tyler-ball/orgs","repos_url":"https://api.github.com/users/tyler-ball/repos","events_url":"https://api.github.com/users/tyler-ball/events{/privacy}","received_events_url":"https://api.github.com/users/tyler-ball/received_events","type":"User","site_admin":false},"body":"TODO try propogating the driver, the event queue, chef_provisioning, etc.\r\n\r\nWe could also call `with_driver`, `with_chef_server`, etc. at the beginning of the recipe.\r\n\r\nMake `Provisioning.inline_resource` accept driver as an optional parameter.","created_at":"2015-05-05T22:43:28Z","updated_at":"2015-05-05T22:43:28Z","html_url":"https://github.com/chef/chef-provisioning-aws/pull/192#discussion_r29721196","pull_request_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/192","_links":{"self":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/comments/29721196"},"html":{"href":"https://github.com/chef/chef-provisioning-aws/pull/192#discussion_r29721196"},"pull_request":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/192"}}},"pull_request":{"url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/192","id":34233386,"html_url":"https://github.com/chef/chef-provisioning-aws/pull/192","diff_url":"https://github.com/chef/chef-provisioning-aws/pull/192.diff","patch_url":"https://github.com/chef/chef-provisioning-aws/pull/192.patch","issue_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/192","number":192,"state":"open","locked":false,"title":"Updating ref files to run correctly","user":{"login":"tyler-ball","id":2481463,"avatar_url":"https://avatars.githubusercontent.com/u/2481463?v=3","gravatar_id":"","url":"https://api.github.com/users/tyler-ball","html_url":"https://github.com/tyler-ball","followers_url":"https://api.github.com/users/tyler-ball/followers","following_url":"https://api.github.com/users/tyler-ball/following{/other_user}","gists_url":"https://api.github.com/users/tyler-ball/gists{/gist_id}","starred_url":"https://api.github.com/users/tyler-ball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyler-ball/subscriptions","organizations_url":"https://api.github.com/users/tyler-ball/orgs","repos_url":"https://api.github.com/users/tyler-ball/repos","events_url":"https://api.github.com/users/tyler-ball/events{/privacy}","received_events_url":"https://api.github.com/users/tyler-ball/received_events","type":"User","site_admin":false},"body":"There are a few failures with the current ref files:\r\n\r\n1. Creating objects in the EU is triggering timeouts trying to ssh into the machines, even they are created successfully.  Updating to faster instances in a local AZ.\r\n1. Machine images are not correctly waiting for their template machines to become terminated before shutting themselves down\r\n1. You cannot delete the main route table or update the main route table except through creating a new main route table.  This means only a `:purge` on the VPC will delete the default route table created and delete the currently assigned route table.","created_at":"2015-04-28T04:47:59Z","updated_at":"2015-05-05T22:43:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"725a73652d16e9a339acb06ccf3d5895f2cb17a6","assignee":{"login":"tyler-ball","id":2481463,"avatar_url":"https://avatars.githubusercontent.com/u/2481463?v=3","gravatar_id":"","url":"https://api.github.com/users/tyler-ball","html_url":"https://github.com/tyler-ball","followers_url":"https://api.github.com/users/tyler-ball/followers","following_url":"https://api.github.com/users/tyler-ball/following{/other_user}","gists_url":"https://api.github.com/users/tyler-ball/gists{/gist_id}","starred_url":"https://api.github.com/users/tyler-ball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyler-ball/subscriptions","organizations_url":"https://api.github.com/users/tyler-ball/orgs","repos_url":"https://api.github.com/users/tyler-ball/repos","events_url":"https://api.github.com/users/tyler-ball/events{/privacy}","received_events_url":"https://api.github.com/users/tyler-ball/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/192/commits","review_comments_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/192/comments","review_comment_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/192/comments","statuses_url":"https://api.github.com/repos/chef/chef-provisioning-aws/statuses/12596ab9365db4566be3bc9a6214e72d69966699","head":{"label":"chef:tball/ref","ref":"tball/ref","sha":"12596ab9365db4566be3bc9a6214e72d69966699","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":24198103,"name":"chef-provisioning-aws","full_name":"chef/chef-provisioning-aws","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-provisioning-aws","description":"AWS driver and resources for Chef that uses the AWS SDK","fork":false,"url":"https://api.github.com/repos/chef/chef-provisioning-aws","forks_url":"https://api.github.com/repos/chef/chef-provisioning-aws/forks","keys_url":"https://api.github.com/repos/chef/chef-provisioning-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-provisioning-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-provisioning-aws/teams","hooks_url":"https://api.github.com/repos/chef/chef-provisioning-aws/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-provisioning-aws/events","assignees_url":"https://api.github.com/repos/chef/chef-provisioning-aws/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-provisioning-aws/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-provisioning-aws/tags","blobs_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-provisioning-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-provisioning-aws/languages","stargazers_url":"https://api.github.com/repos/chef/chef-provisioning-aws/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-provisioning-aws/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-provisioning-aws/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-provisioning-aws/subscription","commits_url":"https://api.github.com/repos/chef/chef-provisioning-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-provisioning-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-provisioning-aws/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-provisioning-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-provisioning-aws/merges","archive_url":"https://api.github.com/repos/chef/chef-provisioning-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-provisioning-aws/downloads","issues_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-provisioning-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-provisioning-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-provisioning-aws/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-provisioning-aws/releases{/id}","created_at":"2014-09-18T17:32:40Z","updated_at":"2015-05-05T06:00:07Z","pushed_at":"2015-05-05T15:40:21Z","git_url":"git://github.com/chef/chef-provisioning-aws.git","ssh_url":"git@github.com:chef/chef-provisioning-aws.git","clone_url":"https://github.com/chef/chef-provisioning-aws.git","svn_url":"https://github.com/chef/chef-provisioning-aws","homepage":"","size":3396,"stargazers_count":36,"watchers_count":36,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":61,"forks":27,"open_issues":61,"watchers":36,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"ec601d86b2ee496161369a7c8dad3d200c438236","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":24198103,"name":"chef-provisioning-aws","full_name":"chef/chef-provisioning-aws","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-provisioning-aws","description":"AWS driver and resources for Chef that uses the AWS SDK","fork":false,"url":"https://api.github.com/repos/chef/chef-provisioning-aws","forks_url":"https://api.github.com/repos/chef/chef-provisioning-aws/forks","keys_url":"https://api.github.com/repos/chef/chef-provisioning-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-provisioning-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-provisioning-aws/teams","hooks_url":"https://api.github.com/repos/chef/chef-provisioning-aws/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-provisioning-aws/events","assignees_url":"https://api.github.com/repos/chef/chef-provisioning-aws/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-provisioning-aws/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-provisioning-aws/tags","blobs_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-provisioning-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-provisioning-aws/languages","stargazers_url":"https://api.github.com/repos/chef/chef-provisioning-aws/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-provisioning-aws/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-provisioning-aws/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-provisioning-aws/subscription","commits_url":"https://api.github.com/repos/chef/chef-provisioning-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-provisioning-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-provisioning-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-provisioning-aws/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-provisioning-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-provisioning-aws/merges","archive_url":"https://api.github.com/repos/chef/chef-provisioning-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-provisioning-aws/downloads","issues_url":"https://api.github.com/repos/chef/chef-provisioning-aws/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-provisioning-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-provisioning-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-provisioning-aws/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-provisioning-aws/releases{/id}","created_at":"2014-09-18T17:32:40Z","updated_at":"2015-05-05T06:00:07Z","pushed_at":"2015-05-05T15:40:21Z","git_url":"git://github.com/chef/chef-provisioning-aws.git","ssh_url":"git@github.com:chef/chef-provisioning-aws.git","clone_url":"https://github.com/chef/chef-provisioning-aws.git","svn_url":"https://github.com/chef/chef-provisioning-aws","homepage":"","size":3396,"stargazers_count":36,"watchers_count":36,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":61,"forks":27,"open_issues":61,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/192"},"html":{"href":"https://github.com/chef/chef-provisioning-aws/pull/192"},"issue":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/192"},"comments":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/issues/192/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/192/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/pulls/192/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef-provisioning-aws/statuses/12596ab9365db4566be3bc9a6214e72d69966699"}}}}