{"action":"closed","number":309,"pull_request":{"url":"https://api.github.com/repos/mirage/irmin/pulls/309","id":46913653,"html_url":"https://github.com/mirage/irmin/pull/309","diff_url":"https://github.com/mirage/irmin/pull/309.diff","patch_url":"https://github.com/mirage/irmin/pull/309.patch","issue_url":"https://api.github.com/repos/mirage/irmin/issues/309","number":309,"state":"closed","locked":false,"title":"Remove Irmin.Basic","user":{"login":"talex5","id":554131,"avatar_url":"https://avatars.githubusercontent.com/u/554131?v=3","gravatar_id":"","url":"https://api.github.com/users/talex5","html_url":"https://github.com/talex5","followers_url":"https://api.github.com/users/talex5/followers","following_url":"https://api.github.com/users/talex5/following{/other_user}","gists_url":"https://api.github.com/users/talex5/gists{/gist_id}","starred_url":"https://api.github.com/users/talex5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talex5/subscriptions","organizations_url":"https://api.github.com/users/talex5/orgs","repos_url":"https://api.github.com/users/talex5/repos","events_url":"https://api.github.com/users/talex5/events{/privacy}","received_events_url":"https://api.github.com/users/talex5/received_events","type":"User","site_admin":false},"body":"The `Basic` functor makes things confusing for users by hiding what's going on, and restricts all back-ends to providing only the base API.\r\n\r\nThis branch removes it, changing the examples to use the more explicit form. As back-ends can now provide additional functions, `Irmin_git.Internals` is moved inside the store and the hacks removed (or, at least, moved to just the unit-tests). i.e. you can now only ask for a Git commit object from a Git store.\r\n\r\nI also deleted `Ir_bc.Make` and `Ir_bc.MAKER` because a) they were confusing me, b) they aren't used within Irmin, and c) they are not exposed to users of the API.\r\n\r\nCode needs to be updated from e.g.\r\n    \r\n    module S = Irmin.Basic(Irmin_git.FS)(Irmin.Contents.String)\r\n    \r\nto\r\n    \r\n    module S = Irmin_git.FS(Irmin.Contents.String)(Irmin.Ref.String)(Irmin.Hash.SHA1)","created_at":"2015-10-06T14:55:57Z","updated_at":"2015-10-06T16:00:43Z","closed_at":"2015-10-06T16:00:43Z","merged_at":"2015-10-06T16:00:43Z","merge_commit_sha":"66d6ff4fb8c82d40cd571e12caee5454380d66ab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mirage/irmin/pulls/309/commits","review_comments_url":"https://api.github.com/repos/mirage/irmin/pulls/309/comments","review_comment_url":"https://api.github.com/repos/mirage/irmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mirage/irmin/issues/309/comments","statuses_url":"https://api.github.com/repos/mirage/irmin/statuses/bc1ddaf2d4a81c20fe4e9d85fa2c8d321f3fe4c5","head":{"label":"talex5:no-basic","ref":"no-basic","sha":"bc1ddaf2d4a81c20fe4e9d85fa2c8d321f3fe4c5","user":{"login":"talex5","id":554131,"avatar_url":"https://avatars.githubusercontent.com/u/554131?v=3","gravatar_id":"","url":"https://api.github.com/users/talex5","html_url":"https://github.com/talex5","followers_url":"https://api.github.com/users/talex5/followers","following_url":"https://api.github.com/users/talex5/following{/other_user}","gists_url":"https://api.github.com/users/talex5/gists{/gist_id}","starred_url":"https://api.github.com/users/talex5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talex5/subscriptions","organizations_url":"https://api.github.com/users/talex5/orgs","repos_url":"https://api.github.com/users/talex5/repos","events_url":"https://api.github.com/users/talex5/events{/privacy}","received_events_url":"https://api.github.com/users/talex5/received_events","type":"User","site_admin":false},"repo":{"id":32873616,"name":"irmin","full_name":"talex5/irmin","owner":{"login":"talex5","id":554131,"avatar_url":"https://avatars.githubusercontent.com/u/554131?v=3","gravatar_id":"","url":"https://api.github.com/users/talex5","html_url":"https://github.com/talex5","followers_url":"https://api.github.com/users/talex5/followers","following_url":"https://api.github.com/users/talex5/following{/other_user}","gists_url":"https://api.github.com/users/talex5/gists{/gist_id}","starred_url":"https://api.github.com/users/talex5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talex5/subscriptions","organizations_url":"https://api.github.com/users/talex5/orgs","repos_url":"https://api.github.com/users/talex5/repos","events_url":"https://api.github.com/users/talex5/events{/privacy}","received_events_url":"https://api.github.com/users/talex5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/talex5/irmin","description":"Irmin is a distributed database that follows the same design principles as Git","fork":true,"url":"https://api.github.com/repos/talex5/irmin","forks_url":"https://api.github.com/repos/talex5/irmin/forks","keys_url":"https://api.github.com/repos/talex5/irmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talex5/irmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talex5/irmin/teams","hooks_url":"https://api.github.com/repos/talex5/irmin/hooks","issue_events_url":"https://api.github.com/repos/talex5/irmin/issues/events{/number}","events_url":"https://api.github.com/repos/talex5/irmin/events","assignees_url":"https://api.github.com/repos/talex5/irmin/assignees{/user}","branches_url":"https://api.github.com/repos/talex5/irmin/branches{/branch}","tags_url":"https://api.github.com/repos/talex5/irmin/tags","blobs_url":"https://api.github.com/repos/talex5/irmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talex5/irmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talex5/irmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/talex5/irmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talex5/irmin/statuses/{sha}","languages_url":"https://api.github.com/repos/talex5/irmin/languages","stargazers_url":"https://api.github.com/repos/talex5/irmin/stargazers","contributors_url":"https://api.github.com/repos/talex5/irmin/contributors","subscribers_url":"https://api.github.com/repos/talex5/irmin/subscribers","subscription_url":"https://api.github.com/repos/talex5/irmin/subscription","commits_url":"https://api.github.com/repos/talex5/irmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/talex5/irmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/talex5/irmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/talex5/irmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/talex5/irmin/contents/{+path}","compare_url":"https://api.github.com/repos/talex5/irmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talex5/irmin/merges","archive_url":"https://api.github.com/repos/talex5/irmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talex5/irmin/downloads","issues_url":"https://api.github.com/repos/talex5/irmin/issues{/number}","pulls_url":"https://api.github.com/repos/talex5/irmin/pulls{/number}","milestones_url":"https://api.github.com/repos/talex5/irmin/milestones{/number}","notifications_url":"https://api.github.com/repos/talex5/irmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talex5/irmin/labels{/name}","releases_url":"https://api.github.com/repos/talex5/irmin/releases{/id}","created_at":"2015-03-25T15:32:52Z","updated_at":"2015-03-25T15:32:53Z","pushed_at":"2015-10-06T15:46:41Z","git_url":"git://github.com/talex5/irmin.git","ssh_url":"git@github.com:talex5/irmin.git","clone_url":"https://github.com/talex5/irmin.git","svn_url":"https://github.com/talex5/irmin","homepage":"","size":6507,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mirage:master","ref":"master","sha":"d33912d39bc7cac9d8cfa2cd3596e52114ce67b3","user":{"login":"mirage","id":131943,"avatar_url":"https://avatars.githubusercontent.com/u/131943?v=3","gravatar_id":"","url":"https://api.github.com/users/mirage","html_url":"https://github.com/mirage","followers_url":"https://api.github.com/users/mirage/followers","following_url":"https://api.github.com/users/mirage/following{/other_user}","gists_url":"https://api.github.com/users/mirage/gists{/gist_id}","starred_url":"https://api.github.com/users/mirage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirage/subscriptions","organizations_url":"https://api.github.com/users/mirage/orgs","repos_url":"https://api.github.com/users/mirage/repos","events_url":"https://api.github.com/users/mirage/events{/privacy}","received_events_url":"https://api.github.com/users/mirage/received_events","type":"Organization","site_admin":false},"repo":{"id":9595928,"name":"irmin","full_name":"mirage/irmin","owner":{"login":"mirage","id":131943,"avatar_url":"https://avatars.githubusercontent.com/u/131943?v=3","gravatar_id":"","url":"https://api.github.com/users/mirage","html_url":"https://github.com/mirage","followers_url":"https://api.github.com/users/mirage/followers","following_url":"https://api.github.com/users/mirage/following{/other_user}","gists_url":"https://api.github.com/users/mirage/gists{/gist_id}","starred_url":"https://api.github.com/users/mirage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirage/subscriptions","organizations_url":"https://api.github.com/users/mirage/orgs","repos_url":"https://api.github.com/users/mirage/repos","events_url":"https://api.github.com/users/mirage/events{/privacy}","received_events_url":"https://api.github.com/users/mirage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mirage/irmin","description":"Irmin is a distributed database that follows the same design principles as Git","fork":false,"url":"https://api.github.com/repos/mirage/irmin","forks_url":"https://api.github.com/repos/mirage/irmin/forks","keys_url":"https://api.github.com/repos/mirage/irmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirage/irmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirage/irmin/teams","hooks_url":"https://api.github.com/repos/mirage/irmin/hooks","issue_events_url":"https://api.github.com/repos/mirage/irmin/issues/events{/number}","events_url":"https://api.github.com/repos/mirage/irmin/events","assignees_url":"https://api.github.com/repos/mirage/irmin/assignees{/user}","branches_url":"https://api.github.com/repos/mirage/irmin/branches{/branch}","tags_url":"https://api.github.com/repos/mirage/irmin/tags","blobs_url":"https://api.github.com/repos/mirage/irmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirage/irmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirage/irmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirage/irmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirage/irmin/statuses/{sha}","languages_url":"https://api.github.com/repos/mirage/irmin/languages","stargazers_url":"https://api.github.com/repos/mirage/irmin/stargazers","contributors_url":"https://api.github.com/repos/mirage/irmin/contributors","subscribers_url":"https://api.github.com/repos/mirage/irmin/subscribers","subscription_url":"https://api.github.com/repos/mirage/irmin/subscription","commits_url":"https://api.github.com/repos/mirage/irmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirage/irmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirage/irmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirage/irmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mirage/irmin/contents/{+path}","compare_url":"https://api.github.com/repos/mirage/irmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirage/irmin/merges","archive_url":"https://api.github.com/repos/mirage/irmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirage/irmin/downloads","issues_url":"https://api.github.com/repos/mirage/irmin/issues{/number}","pulls_url":"https://api.github.com/repos/mirage/irmin/pulls{/number}","milestones_url":"https://api.github.com/repos/mirage/irmin/milestones{/number}","notifications_url":"https://api.github.com/repos/mirage/irmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirage/irmin/labels{/name}","releases_url":"https://api.github.com/repos/mirage/irmin/releases{/id}","created_at":"2013-04-22T09:52:58Z","updated_at":"2015-10-01T11:34:14Z","pushed_at":"2015-10-06T16:00:43Z","git_url":"git://github.com/mirage/irmin.git","ssh_url":"git@github.com:mirage/irmin.git","clone_url":"https://github.com/mirage/irmin.git","svn_url":"https://github.com/mirage/irmin","homepage":"","size":8658,"stargazers_count":346,"watchers_count":346,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":78,"forks":38,"open_issues":78,"watchers":346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mirage/irmin/pulls/309"},"html":{"href":"https://github.com/mirage/irmin/pull/309"},"issue":{"href":"https://api.github.com/repos/mirage/irmin/issues/309"},"comments":{"href":"https://api.github.com/repos/mirage/irmin/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/mirage/irmin/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/mirage/irmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mirage/irmin/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/mirage/irmin/statuses/bc1ddaf2d4a81c20fe4e9d85fa2c8d321f3fe4c5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"samoht","id":103693,"avatar_url":"https://avatars.githubusercontent.com/u/103693?v=3","gravatar_id":"","url":"https://api.github.com/users/samoht","html_url":"https://github.com/samoht","followers_url":"https://api.github.com/users/samoht/followers","following_url":"https://api.github.com/users/samoht/following{/other_user}","gists_url":"https://api.github.com/users/samoht/gists{/gist_id}","starred_url":"https://api.github.com/users/samoht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samoht/subscriptions","organizations_url":"https://api.github.com/users/samoht/orgs","repos_url":"https://api.github.com/users/samoht/repos","events_url":"https://api.github.com/users/samoht/events{/privacy}","received_events_url":"https://api.github.com/users/samoht/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":3,"additions":103,"deletions":125,"changed_files":23}}