{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/45515653","id":45515653,"diff_hunk":"@@ -629,6 +630,33 @@ def test_get_hosts_to_run_on(self, load_facts_mock, run_playbook_mock):\n                                          exp_hosts_to_run_on_len=2,\n                                          force=False)\n \n+    #interactive multimaster\n+    @patch('ooinstall.openshift_ansible.run_main_playbook')\n+    @patch('ooinstall.openshift_ansible.load_system_facts')\n+    def test_quick_ha(self, load_facts_mock, run_playbook_mock):\n+        load_facts_mock.return_value = (MOCK_FACTS, 0)\n+        run_playbook_mock.return_value = 0\n+\n+        cli_input = self._build_input(hosts=[\n+            ('10.0.0.1', True),\n+            ('10.0.0.2', True),\n+            ('10.0.0.3', False),\n+            ('10.0.0.4', True)],\n+                                      ssh_user='root',\n+                                      variant_num=1,\n+                                      confirm_facts='y')\n+        self.cli_args.append(\"install\")\n+        result = self.runner.invoke(cli.cli, self.cli_args,\n+            input=cli_input)\n+        self.assert_result(result, 0)\n+\n+        self._verify_load_facts(load_facts_mock)\n+        self._verify_run_playbook(run_playbook_mock, 3, 3)\n+\n+        written_config = self._read_yaml(self.config_file)\n+        self._verify_config_hosts(written_config, 3)\n+\n+        return","path":"utils/test/cli_installer_tests.py","position":180,"original_position":38,"commit_id":"0326017b222ef3e84f822f2d1680e6236033cb27","original_commit_id":"c5ab58790539fb24acf92ce51ee7fead6cb0766e","user":{"login":"dgoodwin","id":51265,"avatar_url":"https://avatars.githubusercontent.com/u/51265?v=3","gravatar_id":"","url":"https://api.github.com/users/dgoodwin","html_url":"https://github.com/dgoodwin","followers_url":"https://api.github.com/users/dgoodwin/followers","following_url":"https://api.github.com/users/dgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/dgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoodwin/subscriptions","organizations_url":"https://api.github.com/users/dgoodwin/orgs","repos_url":"https://api.github.com/users/dgoodwin/repos","events_url":"https://api.github.com/users/dgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/dgoodwin/received_events","type":"User","site_admin":false},"body":"@smunilla I actually had that change in a branch here I haven't finished for showing the right docs links for the selected release, definitely a change we should make I think, very fair to ask for the variant before hosts.","created_at":"2015-11-20T20:39:19Z","updated_at":"2015-11-20T20:39:19Z","html_url":"https://github.com/openshift/openshift-ansible/pull/947#discussion_r45515653","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/947","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/45515653"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/947#discussion_r45515653"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/947"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/947","id":51371364,"html_url":"https://github.com/openshift/openshift-ansible/pull/947","diff_url":"https://github.com/openshift/openshift-ansible/pull/947.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/947.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/947","number":947,"state":"open","locked":false,"title":" atomic-openshift-installer: HA for quick installer ","user":{"login":"smunilla","id":873968,"avatar_url":"https://avatars.githubusercontent.com/u/873968?v=3","gravatar_id":"","url":"https://api.github.com/users/smunilla","html_url":"https://github.com/smunilla","followers_url":"https://api.github.com/users/smunilla/followers","following_url":"https://api.github.com/users/smunilla/following{/other_user}","gists_url":"https://api.github.com/users/smunilla/gists{/gist_id}","starred_url":"https://api.github.com/users/smunilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smunilla/subscriptions","organizations_url":"https://api.github.com/users/smunilla/orgs","repos_url":"https://api.github.com/users/smunilla/repos","events_url":"https://api.github.com/users/smunilla/events{/privacy}","received_events_url":"https://api.github.com/users/smunilla/received_events","type":"User","site_admin":false},"body":"This adds the ability to quickly set up a multi-master environment.\r\n\r\nVery much in need of heavy testing.","created_at":"2015-11-20T15:43:33Z","updated_at":"2015-11-20T20:39:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2a4ef612892db6d253aa48ccc8ce56c249fb5d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/947/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/947/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/947/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/0326017b222ef3e84f822f2d1680e6236033cb27","head":{"label":"smunilla:quick_ha","ref":"quick_ha","sha":"0326017b222ef3e84f822f2d1680e6236033cb27","user":{"login":"smunilla","id":873968,"avatar_url":"https://avatars.githubusercontent.com/u/873968?v=3","gravatar_id":"","url":"https://api.github.com/users/smunilla","html_url":"https://github.com/smunilla","followers_url":"https://api.github.com/users/smunilla/followers","following_url":"https://api.github.com/users/smunilla/following{/other_user}","gists_url":"https://api.github.com/users/smunilla/gists{/gist_id}","starred_url":"https://api.github.com/users/smunilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smunilla/subscriptions","organizations_url":"https://api.github.com/users/smunilla/orgs","repos_url":"https://api.github.com/users/smunilla/repos","events_url":"https://api.github.com/users/smunilla/events{/privacy}","received_events_url":"https://api.github.com/users/smunilla/received_events","type":"User","site_admin":false},"repo":{"id":43496991,"name":"openshift-ansible","full_name":"smunilla/openshift-ansible","owner":{"login":"smunilla","id":873968,"avatar_url":"https://avatars.githubusercontent.com/u/873968?v=3","gravatar_id":"","url":"https://api.github.com/users/smunilla","html_url":"https://github.com/smunilla","followers_url":"https://api.github.com/users/smunilla/followers","following_url":"https://api.github.com/users/smunilla/following{/other_user}","gists_url":"https://api.github.com/users/smunilla/gists{/gist_id}","starred_url":"https://api.github.com/users/smunilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smunilla/subscriptions","organizations_url":"https://api.github.com/users/smunilla/orgs","repos_url":"https://api.github.com/users/smunilla/repos","events_url":"https://api.github.com/users/smunilla/events{/privacy}","received_events_url":"https://api.github.com/users/smunilla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smunilla/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/smunilla/openshift-ansible","forks_url":"https://api.github.com/repos/smunilla/openshift-ansible/forks","keys_url":"https://api.github.com/repos/smunilla/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smunilla/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smunilla/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/smunilla/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/smunilla/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/smunilla/openshift-ansible/events","assignees_url":"https://api.github.com/repos/smunilla/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/smunilla/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/smunilla/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/smunilla/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smunilla/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smunilla/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/smunilla/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smunilla/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/smunilla/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/smunilla/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/smunilla/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/smunilla/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/smunilla/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/smunilla/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/smunilla/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/smunilla/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/smunilla/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/smunilla/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/smunilla/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smunilla/openshift-ansible/merges","archive_url":"https://api.github.com/repos/smunilla/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smunilla/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/smunilla/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/smunilla/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/smunilla/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/smunilla/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smunilla/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/smunilla/openshift-ansible/releases{/id}","created_at":"2015-10-01T13:08:40Z","updated_at":"2015-10-01T13:08:41Z","pushed_at":"2015-11-20T20:37:09Z","git_url":"git://github.com/smunilla/openshift-ansible.git","ssh_url":"git@github.com:smunilla/openshift-ansible.git","clone_url":"https://github.com/smunilla/openshift-ansible.git","svn_url":"https://github.com/smunilla/openshift-ansible","homepage":"","size":2045,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"f0d13819c35727300101a7e31b8ff9b0022e683f","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","created_at":"2014-09-16T17:07:51Z","updated_at":"2015-11-19T21:46:26Z","pushed_at":"2015-11-20T20:37:10Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"install.openshift.com","size":2911,"stargazers_count":91,"watchers_count":91,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":164,"mirror_url":null,"open_issues_count":137,"forks":164,"open_issues":137,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/947"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/947"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/947"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/947/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/947/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/947/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/0326017b222ef3e84f822f2d1680e6236033cb27"}}}}