{"action":"closed","number":12498,"pull_request":{"url":"https://api.github.com/repos/modxcms/revolution/pulls/12498","id":38902983,"html_url":"https://github.com/modxcms/revolution/pull/12498","diff_url":"https://github.com/modxcms/revolution/pull/12498.diff","patch_url":"https://github.com/modxcms/revolution/pull/12498.patch","issue_url":"https://api.github.com/repos/modxcms/revolution/issues/12498","number":12498,"state":"closed","locked":false,"title":"Fiting portrait and landscape imageTV thumbs into a max. area of 400x400px","user":{"login":"mindeffects","id":458619,"avatar_url":"https://avatars.githubusercontent.com/u/458619?v=3","gravatar_id":"","url":"https://api.github.com/users/mindeffects","html_url":"https://github.com/mindeffects","followers_url":"https://api.github.com/users/mindeffects/followers","following_url":"https://api.github.com/users/mindeffects/following{/other_user}","gists_url":"https://api.github.com/users/mindeffects/gists{/gist_id}","starred_url":"https://api.github.com/users/mindeffects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindeffects/subscriptions","organizations_url":"https://api.github.com/users/mindeffects/orgs","repos_url":"https://api.github.com/users/mindeffects/repos","events_url":"https://api.github.com/users/mindeffects/events{/privacy}","received_events_url":"https://api.github.com/users/mindeffects/received_events","type":"User","site_admin":false},"body":"### Summary\r\nThis is an improvement for #12491 which only limited the width to 400px, the height remained unlimited.\r\nNow the script also handles very tall images like skyscraper banners (120x600px) and fits them into a 400x400px area. This saves a lot of vertical space for portrait format images.\r\nSmaller images remain unaltered.\r\n\r\n### Step to reproduce\r\nJust select an image for a TV. Here are examples for 120x120, 600x120, 120x600 and 600x600px:\r\n\r\n##### 120x120 #####\r\n![image](https://cloud.githubusercontent.com/assets/458619/8437056/e7114a00-1f5c-11e5-8348-4b0e04484211.png)\r\n\r\n##### 600x120 #####\r\n![image](https://cloud.githubusercontent.com/assets/458619/8437078/01610d14-1f5d-11e5-9b4c-b02839c5b60d.png)\r\n\r\n##### 120x600 #####\r\n![image](https://cloud.githubusercontent.com/assets/458619/8437093/143d0438-1f5d-11e5-92c2-f377d5466024.png)\r\n\r\n##### 600x600 #####\r\n![image](https://cloud.githubusercontent.com/assets/458619/8437103/223c3aea-1f5d-11e5-9725-961847f22f18.png)\r\n\r\n### Observed behavior\r\nThe maximum thumbnail size is now fitted into 400x400px, no matter what kind or proportions the image has.\r\n\r\n### Expected behavior\r\nJust as observed. ;-)","created_at":"2015-06-30T17:25:29Z","updated_at":"2015-07-12T18:22:05Z","closed_at":"2015-07-12T18:22:04Z","merged_at":"2015-07-12T18:22:04Z","merge_commit_sha":"c082a11b41f6c538b2b0de6e4d26801649dbbc2a","assignee":{"login":"Mark-H","id":312944,"avatar_url":"https://avatars.githubusercontent.com/u/312944?v=3","gravatar_id":"","url":"https://api.github.com/users/Mark-H","html_url":"https://github.com/Mark-H","followers_url":"https://api.github.com/users/Mark-H/followers","following_url":"https://api.github.com/users/Mark-H/following{/other_user}","gists_url":"https://api.github.com/users/Mark-H/gists{/gist_id}","starred_url":"https://api.github.com/users/Mark-H/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mark-H/subscriptions","organizations_url":"https://api.github.com/users/Mark-H/orgs","repos_url":"https://api.github.com/users/Mark-H/repos","events_url":"https://api.github.com/users/Mark-H/events{/privacy}","received_events_url":"https://api.github.com/users/Mark-H/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/modxcms/revolution/milestones/64","html_url":"https://github.com/modxcms/revolution/milestones/v2.3.6-pl","labels_url":"https://api.github.com/repos/modxcms/revolution/milestones/64/labels","id":1182565,"number":64,"title":"v2.3.6-pl","description":null,"creator":{"login":"theboxer","id":845220,"avatar_url":"https://avatars.githubusercontent.com/u/845220?v=3","gravatar_id":"","url":"https://api.github.com/users/theboxer","html_url":"https://github.com/theboxer","followers_url":"https://api.github.com/users/theboxer/followers","following_url":"https://api.github.com/users/theboxer/following{/other_user}","gists_url":"https://api.github.com/users/theboxer/gists{/gist_id}","starred_url":"https://api.github.com/users/theboxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theboxer/subscriptions","organizations_url":"https://api.github.com/users/theboxer/orgs","repos_url":"https://api.github.com/users/theboxer/repos","events_url":"https://api.github.com/users/theboxer/events{/privacy}","received_events_url":"https://api.github.com/users/theboxer/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":4,"state":"open","created_at":"2015-06-26T13:00:16Z","updated_at":"2015-07-12T18:22:04Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/modxcms/revolution/pulls/12498/commits","review_comments_url":"https://api.github.com/repos/modxcms/revolution/pulls/12498/comments","review_comment_url":"https://api.github.com/repos/modxcms/revolution/pulls/comments{/number}","comments_url":"https://api.github.com/repos/modxcms/revolution/issues/12498/comments","statuses_url":"https://api.github.com/repos/modxcms/revolution/statuses/45504bcd5ef5acc53b619e99cc4efc0a0f9900d1","head":{"label":"mindeffects:patch-4","ref":"patch-4","sha":"45504bcd5ef5acc53b619e99cc4efc0a0f9900d1","user":{"login":"mindeffects","id":458619,"avatar_url":"https://avatars.githubusercontent.com/u/458619?v=3","gravatar_id":"","url":"https://api.github.com/users/mindeffects","html_url":"https://github.com/mindeffects","followers_url":"https://api.github.com/users/mindeffects/followers","following_url":"https://api.github.com/users/mindeffects/following{/other_user}","gists_url":"https://api.github.com/users/mindeffects/gists{/gist_id}","starred_url":"https://api.github.com/users/mindeffects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindeffects/subscriptions","organizations_url":"https://api.github.com/users/mindeffects/orgs","repos_url":"https://api.github.com/users/mindeffects/repos","events_url":"https://api.github.com/users/mindeffects/events{/privacy}","received_events_url":"https://api.github.com/users/mindeffects/received_events","type":"User","site_admin":false},"repo":{"id":30465836,"name":"revolution","full_name":"mindeffects/revolution","owner":{"login":"mindeffects","id":458619,"avatar_url":"https://avatars.githubusercontent.com/u/458619?v=3","gravatar_id":"","url":"https://api.github.com/users/mindeffects","html_url":"https://github.com/mindeffects","followers_url":"https://api.github.com/users/mindeffects/followers","following_url":"https://api.github.com/users/mindeffects/following{/other_user}","gists_url":"https://api.github.com/users/mindeffects/gists{/gist_id}","starred_url":"https://api.github.com/users/mindeffects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindeffects/subscriptions","organizations_url":"https://api.github.com/users/mindeffects/orgs","repos_url":"https://api.github.com/users/mindeffects/repos","events_url":"https://api.github.com/users/mindeffects/events{/privacy}","received_events_url":"https://api.github.com/users/mindeffects/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mindeffects/revolution","description":"MODX Revolution - Content Application Platform","fork":true,"url":"https://api.github.com/repos/mindeffects/revolution","forks_url":"https://api.github.com/repos/mindeffects/revolution/forks","keys_url":"https://api.github.com/repos/mindeffects/revolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mindeffects/revolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mindeffects/revolution/teams","hooks_url":"https://api.github.com/repos/mindeffects/revolution/hooks","issue_events_url":"https://api.github.com/repos/mindeffects/revolution/issues/events{/number}","events_url":"https://api.github.com/repos/mindeffects/revolution/events","assignees_url":"https://api.github.com/repos/mindeffects/revolution/assignees{/user}","branches_url":"https://api.github.com/repos/mindeffects/revolution/branches{/branch}","tags_url":"https://api.github.com/repos/mindeffects/revolution/tags","blobs_url":"https://api.github.com/repos/mindeffects/revolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mindeffects/revolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mindeffects/revolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/mindeffects/revolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mindeffects/revolution/statuses/{sha}","languages_url":"https://api.github.com/repos/mindeffects/revolution/languages","stargazers_url":"https://api.github.com/repos/mindeffects/revolution/stargazers","contributors_url":"https://api.github.com/repos/mindeffects/revolution/contributors","subscribers_url":"https://api.github.com/repos/mindeffects/revolution/subscribers","subscription_url":"https://api.github.com/repos/mindeffects/revolution/subscription","commits_url":"https://api.github.com/repos/mindeffects/revolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/mindeffects/revolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/mindeffects/revolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/mindeffects/revolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/mindeffects/revolution/contents/{+path}","compare_url":"https://api.github.com/repos/mindeffects/revolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mindeffects/revolution/merges","archive_url":"https://api.github.com/repos/mindeffects/revolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mindeffects/revolution/downloads","issues_url":"https://api.github.com/repos/mindeffects/revolution/issues{/number}","pulls_url":"https://api.github.com/repos/mindeffects/revolution/pulls{/number}","milestones_url":"https://api.github.com/repos/mindeffects/revolution/milestones{/number}","notifications_url":"https://api.github.com/repos/mindeffects/revolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mindeffects/revolution/labels{/name}","releases_url":"https://api.github.com/repos/mindeffects/revolution/releases{/id}","created_at":"2015-02-07T18:41:26Z","updated_at":"2015-02-07T18:49:08Z","pushed_at":"2015-06-30T17:12:36Z","git_url":"git://github.com/mindeffects/revolution.git","ssh_url":"git@github.com:mindeffects/revolution.git","clone_url":"https://github.com/mindeffects/revolution.git","svn_url":"https://github.com/mindeffects/revolution","homepage":"http://rtfm.modx.com/revolution/2.x/","size":44340,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"modxcms:master","ref":"master","sha":"40e491a93ccd14c5865f083aebc9bcea3b9f36cf","user":{"login":"modxcms","id":232723,"avatar_url":"https://avatars.githubusercontent.com/u/232723?v=3","gravatar_id":"","url":"https://api.github.com/users/modxcms","html_url":"https://github.com/modxcms","followers_url":"https://api.github.com/users/modxcms/followers","following_url":"https://api.github.com/users/modxcms/following{/other_user}","gists_url":"https://api.github.com/users/modxcms/gists{/gist_id}","starred_url":"https://api.github.com/users/modxcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modxcms/subscriptions","organizations_url":"https://api.github.com/users/modxcms/orgs","repos_url":"https://api.github.com/users/modxcms/repos","events_url":"https://api.github.com/users/modxcms/events{/privacy}","received_events_url":"https://api.github.com/users/modxcms/received_events","type":"Organization","site_admin":false},"repo":{"id":806201,"name":"revolution","full_name":"modxcms/revolution","owner":{"login":"modxcms","id":232723,"avatar_url":"https://avatars.githubusercontent.com/u/232723?v=3","gravatar_id":"","url":"https://api.github.com/users/modxcms","html_url":"https://github.com/modxcms","followers_url":"https://api.github.com/users/modxcms/followers","following_url":"https://api.github.com/users/modxcms/following{/other_user}","gists_url":"https://api.github.com/users/modxcms/gists{/gist_id}","starred_url":"https://api.github.com/users/modxcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modxcms/subscriptions","organizations_url":"https://api.github.com/users/modxcms/orgs","repos_url":"https://api.github.com/users/modxcms/repos","events_url":"https://api.github.com/users/modxcms/events{/privacy}","received_events_url":"https://api.github.com/users/modxcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/modxcms/revolution","description":"MODX Revolution - Content Application Platform","fork":false,"url":"https://api.github.com/repos/modxcms/revolution","forks_url":"https://api.github.com/repos/modxcms/revolution/forks","keys_url":"https://api.github.com/repos/modxcms/revolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modxcms/revolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modxcms/revolution/teams","hooks_url":"https://api.github.com/repos/modxcms/revolution/hooks","issue_events_url":"https://api.github.com/repos/modxcms/revolution/issues/events{/number}","events_url":"https://api.github.com/repos/modxcms/revolution/events","assignees_url":"https://api.github.com/repos/modxcms/revolution/assignees{/user}","branches_url":"https://api.github.com/repos/modxcms/revolution/branches{/branch}","tags_url":"https://api.github.com/repos/modxcms/revolution/tags","blobs_url":"https://api.github.com/repos/modxcms/revolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modxcms/revolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modxcms/revolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/modxcms/revolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modxcms/revolution/statuses/{sha}","languages_url":"https://api.github.com/repos/modxcms/revolution/languages","stargazers_url":"https://api.github.com/repos/modxcms/revolution/stargazers","contributors_url":"https://api.github.com/repos/modxcms/revolution/contributors","subscribers_url":"https://api.github.com/repos/modxcms/revolution/subscribers","subscription_url":"https://api.github.com/repos/modxcms/revolution/subscription","commits_url":"https://api.github.com/repos/modxcms/revolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/modxcms/revolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/modxcms/revolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/modxcms/revolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/modxcms/revolution/contents/{+path}","compare_url":"https://api.github.com/repos/modxcms/revolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modxcms/revolution/merges","archive_url":"https://api.github.com/repos/modxcms/revolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modxcms/revolution/downloads","issues_url":"https://api.github.com/repos/modxcms/revolution/issues{/number}","pulls_url":"https://api.github.com/repos/modxcms/revolution/pulls{/number}","milestones_url":"https://api.github.com/repos/modxcms/revolution/milestones{/number}","notifications_url":"https://api.github.com/repos/modxcms/revolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modxcms/revolution/labels{/name}","releases_url":"https://api.github.com/repos/modxcms/revolution/releases{/id}","created_at":"2010-07-29T21:03:57Z","updated_at":"2015-07-06T15:27:25Z","pushed_at":"2015-07-12T18:22:03Z","git_url":"git://github.com/modxcms/revolution.git","ssh_url":"git@github.com:modxcms/revolution.git","clone_url":"https://github.com/modxcms/revolution.git","svn_url":"https://github.com/modxcms/revolution","homepage":"http://rtfm.modx.com/revolution/2.x/","size":77409,"stargazers_count":689,"watchers_count":689,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":348,"mirror_url":null,"open_issues_count":946,"forks":348,"open_issues":946,"watchers":689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12498"},"html":{"href":"https://github.com/modxcms/revolution/pull/12498"},"issue":{"href":"https://api.github.com/repos/modxcms/revolution/issues/12498"},"comments":{"href":"https://api.github.com/repos/modxcms/revolution/issues/12498/comments"},"review_comments":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12498/comments"},"review_comment":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12498/commits"},"statuses":{"href":"https://api.github.com/repos/modxcms/revolution/statuses/45504bcd5ef5acc53b619e99cc4efc0a0f9900d1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Mark-H","id":312944,"avatar_url":"https://avatars.githubusercontent.com/u/312944?v=3","gravatar_id":"","url":"https://api.github.com/users/Mark-H","html_url":"https://github.com/Mark-H","followers_url":"https://api.github.com/users/Mark-H/followers","following_url":"https://api.github.com/users/Mark-H/following{/other_user}","gists_url":"https://api.github.com/users/Mark-H/gists{/gist_id}","starred_url":"https://api.github.com/users/Mark-H/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mark-H/subscriptions","organizations_url":"https://api.github.com/users/Mark-H/orgs","repos_url":"https://api.github.com/users/Mark-H/repos","events_url":"https://api.github.com/users/Mark-H/events{/privacy}","received_events_url":"https://api.github.com/users/Mark-H/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}