{"action":"created","issue":{"url":"https://api.github.com/repos/bensu/doo/issues/83","labels_url":"https://api.github.com/repos/bensu/doo/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/bensu/doo/issues/83/comments","events_url":"https://api.github.com/repos/bensu/doo/issues/83/events","html_url":"https://github.com/bensu/doo/issues/83","id":122721891,"number":83,"title":"lein-doo exits on React warnings","user":{"login":"r0man","id":21566,"avatar_url":"https://avatars.githubusercontent.com/u/21566?v=3","gravatar_id":"","url":"https://api.github.com/users/r0man","html_url":"https://github.com/r0man","followers_url":"https://api.github.com/users/r0man/followers","following_url":"https://api.github.com/users/r0man/following{/other_user}","gists_url":"https://api.github.com/users/r0man/gists{/gist_id}","starred_url":"https://api.github.com/users/r0man/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r0man/subscriptions","organizations_url":"https://api.github.com/users/r0man/orgs","repos_url":"https://api.github.com/users/r0man/repos","events_url":"https://api.github.com/users/r0man/events{/privacy}","received_events_url":"https://api.github.com/users/r0man/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-17T12:00:48Z","updated_at":"2015-12-28T03:12:55Z","closed_at":null,"body":"Hi Bensu,\r\n\r\nI'm using lein-doo to test sablono and run into an issue with\r\nReact warnings. Whenever React issues a warning lein-doo exits,\r\nbecause this hook is called.\r\n\r\nhttps://github.com/bensu/doo/blob/master/library/resources/runners/headless.js#L43\r\n\r\nI'm not exactly sure how those React warnings end up in\r\nlein-doo (via js/Error or console.warn).\r\n\r\nLooking at the clojurescript.test runner it looks like it only\r\ncalls exit when something failed with clojurescript.test itself.\r\n\r\nSo, my question is, is it neccesarry to have this exit call here?\r\nI removed it in a local branch and everything seems to work as\r\nexpected. lein-doo doesn't exit on warnings.\r\n\r\nWhat do you think?\r\n\r\nRoman\r\n"},"comment":{"url":"https://api.github.com/repos/bensu/doo/issues/comments/167466377","html_url":"https://github.com/bensu/doo/issues/83#issuecomment-167466377","issue_url":"https://api.github.com/repos/bensu/doo/issues/83","id":167466377,"user":{"login":"bensu","id":5066487,"avatar_url":"https://avatars.githubusercontent.com/u/5066487?v=3","gravatar_id":"","url":"https://api.github.com/users/bensu","html_url":"https://github.com/bensu","followers_url":"https://api.github.com/users/bensu/followers","following_url":"https://api.github.com/users/bensu/following{/other_user}","gists_url":"https://api.github.com/users/bensu/gists{/gist_id}","starred_url":"https://api.github.com/users/bensu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bensu/subscriptions","organizations_url":"https://api.github.com/users/bensu/orgs","repos_url":"https://api.github.com/users/bensu/repos","events_url":"https://api.github.com/users/bensu/events{/privacy}","received_events_url":"https://api.github.com/users/bensu/received_events","type":"User","site_admin":false},"created_at":"2015-12-28T03:12:55Z","updated_at":"2015-12-28T03:12:55Z","body":"I think I'm misunderstanding something, is `p.onError` only called when `console.error` or also when there is an unhandled exception?\r\n\r\nFrom [the docs](http://phantomjs.org/api/webpage/handler/on-error.html) it seems to be for both exceptions (it uses \"unhandled\") and `console.error` (your case). As long as `onError` gets unhandled exceptions, it should exit with an error code."}}