{"action":"created","issue":{"url":"https://api.github.com/repos/foosel/OctoPrint/issues/872","labels_url":"https://api.github.com/repos/foosel/OctoPrint/issues/872/labels{/name}","comments_url":"https://api.github.com/repos/foosel/OctoPrint/issues/872/comments","events_url":"https://api.github.com/repos/foosel/OctoPrint/issues/872/events","html_url":"https://github.com/foosel/OctoPrint/pull/872","id":70749891,"number":872,"title":"Last line number fix for Marlin","user":{"login":"Booli","id":5080263,"avatar_url":"https://avatars.githubusercontent.com/u/5080263?v=3","gravatar_id":"","url":"https://api.github.com/users/Booli","html_url":"https://github.com/Booli","followers_url":"https://api.github.com/users/Booli/followers","following_url":"https://api.github.com/users/Booli/following{/other_user}","gists_url":"https://api.github.com/users/Booli/gists{/gist_id}","starred_url":"https://api.github.com/users/Booli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Booli/subscriptions","organizations_url":"https://api.github.com/users/Booli/orgs","repos_url":"https://api.github.com/users/Booli/repos","events_url":"https://api.github.com/users/Booli/events{/privacy}","received_events_url":"https://api.github.com/users/Booli/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-24T17:39:20Z","updated_at":"2015-05-05T20:00:31Z","closed_at":"2015-05-05T20:00:31Z","pull_request":{"url":"https://api.github.com/repos/foosel/OctoPrint/pulls/872","html_url":"https://github.com/foosel/OctoPrint/pull/872","diff_url":"https://github.com/foosel/OctoPrint/pull/872.diff","patch_url":"https://github.com/foosel/OctoPrint/pull/872.patch"},"body":"I had issues with last line number being resend over and over. \r\n\r\nthe_handleResendRequest looks for the wrong string to check for in Marlin. \r\n\r\n\"line number is not line number\"  should be \"line number is not last line number\" as per:\r\n\r\nhttps://github.com/MarlinFirmware/Marlin/blob/5e3bb4bdf3a6434dbde9b0873e3b7d0c84c0e96d/Marlin/language.h#L125\r\n\r\nAlso checking against this might break different language Marlin, this is a quick fix for English.\r\n\r\n(sorry I have a parethesis change in another file in here too :( it's late on friday)\r\n\r\nBooli"},"comment":{"url":"https://api.github.com/repos/foosel/OctoPrint/issues/comments/99203564","html_url":"https://github.com/foosel/OctoPrint/pull/872#issuecomment-99203564","issue_url":"https://api.github.com/repos/foosel/OctoPrint/issues/872","id":99203564,"user":{"login":"foosel","id":83657,"avatar_url":"https://avatars.githubusercontent.com/u/83657?v=3","gravatar_id":"","url":"https://api.github.com/users/foosel","html_url":"https://github.com/foosel","followers_url":"https://api.github.com/users/foosel/followers","following_url":"https://api.github.com/users/foosel/following{/other_user}","gists_url":"https://api.github.com/users/foosel/gists{/gist_id}","starred_url":"https://api.github.com/users/foosel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foosel/subscriptions","organizations_url":"https://api.github.com/users/foosel/orgs","repos_url":"https://api.github.com/users/foosel/repos","events_url":"https://api.github.com/users/foosel/events{/privacy}","received_events_url":"https://api.github.com/users/foosel/received_events","type":"User","site_admin":false},"created_at":"2015-05-05T20:00:31Z","updated_at":"2015-05-05T20:00:31Z","body":"Made obsolete by making the whole line more flexible, see commit 517a32f08fdb676bb7b349681f3da2c8c058a2b8"}}