{"action":"closed","number":1088,"pull_request":{"url":"https://api.github.com/repos/e14n/pump.io/pulls/1088","id":40838318,"html_url":"https://github.com/e14n/pump.io/pull/1088","diff_url":"https://github.com/e14n/pump.io/pull/1088.diff","patch_url":"https://github.com/e14n/pump.io/pull/1088.patch","issue_url":"https://api.github.com/repos/e14n/pump.io/issues/1088","number":1088,"state":"closed","locked":false,"title":"now ALL scripts in the bin dir omit the ':port' when port is 443","user":{"login":"profOnno","id":6004086,"avatar_url":"https://avatars.githubusercontent.com/u/6004086?v=3","gravatar_id":"","url":"https://api.github.com/users/profOnno","html_url":"https://github.com/profOnno","followers_url":"https://api.github.com/users/profOnno/followers","following_url":"https://api.github.com/users/profOnno/following{/other_user}","gists_url":"https://api.github.com/users/profOnno/gists{/gist_id}","starred_url":"https://api.github.com/users/profOnno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/profOnno/subscriptions","organizations_url":"https://api.github.com/users/profOnno/orgs","repos_url":"https://api.github.com/users/profOnno/repos","events_url":"https://api.github.com/users/profOnno/events{/privacy}","received_events_url":"https://api.github.com/users/profOnno/received_events","type":"User","site_admin":false},"body":"github/pump noob here.\r\nAs i was testing some scripts on my online pump server i found that the pump-register-app was not working. I changed the lines that make up the host variables to also omit the ':port' when the port is 433. Tested only the pump-register-app and with the change it worked. If i understand it correctly the other scripts in the bin file should also ommit the ':port' part when using port 443.","created_at":"2015-07-25T15:20:38Z","updated_at":"2015-09-08T18:35:12Z","closed_at":"2015-09-08T18:35:12Z","merged_at":null,"merge_commit_sha":"3b71ef7f97f54de0559bcc38eb66970c3bf30a10","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/e14n/pump.io/pulls/1088/commits","review_comments_url":"https://api.github.com/repos/e14n/pump.io/pulls/1088/comments","review_comment_url":"https://api.github.com/repos/e14n/pump.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/e14n/pump.io/issues/1088/comments","statuses_url":"https://api.github.com/repos/e14n/pump.io/statuses/d9ee14b5a5e6a63b10963f1984613dc53bc7974b","head":{"label":"profOnno:master","ref":"master","sha":"d9ee14b5a5e6a63b10963f1984613dc53bc7974b","user":{"login":"profOnno","id":6004086,"avatar_url":"https://avatars.githubusercontent.com/u/6004086?v=3","gravatar_id":"","url":"https://api.github.com/users/profOnno","html_url":"https://github.com/profOnno","followers_url":"https://api.github.com/users/profOnno/followers","following_url":"https://api.github.com/users/profOnno/following{/other_user}","gists_url":"https://api.github.com/users/profOnno/gists{/gist_id}","starred_url":"https://api.github.com/users/profOnno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/profOnno/subscriptions","organizations_url":"https://api.github.com/users/profOnno/orgs","repos_url":"https://api.github.com/users/profOnno/repos","events_url":"https://api.github.com/users/profOnno/events{/privacy}","received_events_url":"https://api.github.com/users/profOnno/received_events","type":"User","site_admin":false},"repo":{"id":39681702,"name":"pump.io","full_name":"profOnno/pump.io","owner":{"login":"profOnno","id":6004086,"avatar_url":"https://avatars.githubusercontent.com/u/6004086?v=3","gravatar_id":"","url":"https://api.github.com/users/profOnno","html_url":"https://github.com/profOnno","followers_url":"https://api.github.com/users/profOnno/followers","following_url":"https://api.github.com/users/profOnno/following{/other_user}","gists_url":"https://api.github.com/users/profOnno/gists{/gist_id}","starred_url":"https://api.github.com/users/profOnno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/profOnno/subscriptions","organizations_url":"https://api.github.com/users/profOnno/orgs","repos_url":"https://api.github.com/users/profOnno/repos","events_url":"https://api.github.com/users/profOnno/events{/privacy}","received_events_url":"https://api.github.com/users/profOnno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/profOnno/pump.io","description":"Social server with an ActivityStreams API","fork":true,"url":"https://api.github.com/repos/profOnno/pump.io","forks_url":"https://api.github.com/repos/profOnno/pump.io/forks","keys_url":"https://api.github.com/repos/profOnno/pump.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/profOnno/pump.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/profOnno/pump.io/teams","hooks_url":"https://api.github.com/repos/profOnno/pump.io/hooks","issue_events_url":"https://api.github.com/repos/profOnno/pump.io/issues/events{/number}","events_url":"https://api.github.com/repos/profOnno/pump.io/events","assignees_url":"https://api.github.com/repos/profOnno/pump.io/assignees{/user}","branches_url":"https://api.github.com/repos/profOnno/pump.io/branches{/branch}","tags_url":"https://api.github.com/repos/profOnno/pump.io/tags","blobs_url":"https://api.github.com/repos/profOnno/pump.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/profOnno/pump.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/profOnno/pump.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/profOnno/pump.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/profOnno/pump.io/statuses/{sha}","languages_url":"https://api.github.com/repos/profOnno/pump.io/languages","stargazers_url":"https://api.github.com/repos/profOnno/pump.io/stargazers","contributors_url":"https://api.github.com/repos/profOnno/pump.io/contributors","subscribers_url":"https://api.github.com/repos/profOnno/pump.io/subscribers","subscription_url":"https://api.github.com/repos/profOnno/pump.io/subscription","commits_url":"https://api.github.com/repos/profOnno/pump.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/profOnno/pump.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/profOnno/pump.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/profOnno/pump.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/profOnno/pump.io/contents/{+path}","compare_url":"https://api.github.com/repos/profOnno/pump.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/profOnno/pump.io/merges","archive_url":"https://api.github.com/repos/profOnno/pump.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/profOnno/pump.io/downloads","issues_url":"https://api.github.com/repos/profOnno/pump.io/issues{/number}","pulls_url":"https://api.github.com/repos/profOnno/pump.io/pulls{/number}","milestones_url":"https://api.github.com/repos/profOnno/pump.io/milestones{/number}","notifications_url":"https://api.github.com/repos/profOnno/pump.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/profOnno/pump.io/labels{/name}","releases_url":"https://api.github.com/repos/profOnno/pump.io/releases{/id}","created_at":"2015-07-25T11:10:00Z","updated_at":"2015-08-27T20:56:40Z","pushed_at":"2015-09-08T18:35:12Z","git_url":"git://github.com/profOnno/pump.io.git","ssh_url":"git@github.com:profOnno/pump.io.git","clone_url":"https://github.com/profOnno/pump.io.git","svn_url":"https://github.com/profOnno/pump.io","homepage":"http://pump.io/","size":8866,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":0,"default_branch":"master"}},"base":{"label":"e14n:master","ref":"master","sha":"1029ac71b94dec2b51f6b2aa461b5b2a514e585a","user":{"login":"e14n","id":2396961,"avatar_url":"https://avatars.githubusercontent.com/u/2396961?v=3","gravatar_id":"","url":"https://api.github.com/users/e14n","html_url":"https://github.com/e14n","followers_url":"https://api.github.com/users/e14n/followers","following_url":"https://api.github.com/users/e14n/following{/other_user}","gists_url":"https://api.github.com/users/e14n/gists{/gist_id}","starred_url":"https://api.github.com/users/e14n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e14n/subscriptions","organizations_url":"https://api.github.com/users/e14n/orgs","repos_url":"https://api.github.com/users/e14n/repos","events_url":"https://api.github.com/users/e14n/events{/privacy}","received_events_url":"https://api.github.com/users/e14n/received_events","type":"Organization","site_admin":false},"repo":{"id":2314534,"name":"pump.io","full_name":"e14n/pump.io","owner":{"login":"e14n","id":2396961,"avatar_url":"https://avatars.githubusercontent.com/u/2396961?v=3","gravatar_id":"","url":"https://api.github.com/users/e14n","html_url":"https://github.com/e14n","followers_url":"https://api.github.com/users/e14n/followers","following_url":"https://api.github.com/users/e14n/following{/other_user}","gists_url":"https://api.github.com/users/e14n/gists{/gist_id}","starred_url":"https://api.github.com/users/e14n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e14n/subscriptions","organizations_url":"https://api.github.com/users/e14n/orgs","repos_url":"https://api.github.com/users/e14n/repos","events_url":"https://api.github.com/users/e14n/events{/privacy}","received_events_url":"https://api.github.com/users/e14n/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/e14n/pump.io","description":"Social server with an ActivityStreams API","fork":false,"url":"https://api.github.com/repos/e14n/pump.io","forks_url":"https://api.github.com/repos/e14n/pump.io/forks","keys_url":"https://api.github.com/repos/e14n/pump.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/e14n/pump.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/e14n/pump.io/teams","hooks_url":"https://api.github.com/repos/e14n/pump.io/hooks","issue_events_url":"https://api.github.com/repos/e14n/pump.io/issues/events{/number}","events_url":"https://api.github.com/repos/e14n/pump.io/events","assignees_url":"https://api.github.com/repos/e14n/pump.io/assignees{/user}","branches_url":"https://api.github.com/repos/e14n/pump.io/branches{/branch}","tags_url":"https://api.github.com/repos/e14n/pump.io/tags","blobs_url":"https://api.github.com/repos/e14n/pump.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/e14n/pump.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/e14n/pump.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/e14n/pump.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/e14n/pump.io/statuses/{sha}","languages_url":"https://api.github.com/repos/e14n/pump.io/languages","stargazers_url":"https://api.github.com/repos/e14n/pump.io/stargazers","contributors_url":"https://api.github.com/repos/e14n/pump.io/contributors","subscribers_url":"https://api.github.com/repos/e14n/pump.io/subscribers","subscription_url":"https://api.github.com/repos/e14n/pump.io/subscription","commits_url":"https://api.github.com/repos/e14n/pump.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/e14n/pump.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/e14n/pump.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/e14n/pump.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/e14n/pump.io/contents/{+path}","compare_url":"https://api.github.com/repos/e14n/pump.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/e14n/pump.io/merges","archive_url":"https://api.github.com/repos/e14n/pump.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/e14n/pump.io/downloads","issues_url":"https://api.github.com/repos/e14n/pump.io/issues{/number}","pulls_url":"https://api.github.com/repos/e14n/pump.io/pulls{/number}","milestones_url":"https://api.github.com/repos/e14n/pump.io/milestones{/number}","notifications_url":"https://api.github.com/repos/e14n/pump.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/e14n/pump.io/labels{/name}","releases_url":"https://api.github.com/repos/e14n/pump.io/releases{/id}","created_at":"2011-09-02T15:07:31Z","updated_at":"2015-09-04T13:48:13Z","pushed_at":"2015-09-08T18:14:57Z","git_url":"git://github.com/e14n/pump.io.git","ssh_url":"git@github.com:e14n/pump.io.git","clone_url":"https://github.com/e14n/pump.io.git","svn_url":"https://github.com/e14n/pump.io","homepage":"http://pump.io/","size":14853,"stargazers_count":1287,"watchers_count":1287,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":230,"mirror_url":null,"open_issues_count":467,"forks":230,"open_issues":467,"watchers":1287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/e14n/pump.io/pulls/1088"},"html":{"href":"https://github.com/e14n/pump.io/pull/1088"},"issue":{"href":"https://api.github.com/repos/e14n/pump.io/issues/1088"},"comments":{"href":"https://api.github.com/repos/e14n/pump.io/issues/1088/comments"},"review_comments":{"href":"https://api.github.com/repos/e14n/pump.io/pulls/1088/comments"},"review_comment":{"href":"https://api.github.com/repos/e14n/pump.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/e14n/pump.io/pulls/1088/commits"},"statuses":{"href":"https://api.github.com/repos/e14n/pump.io/statuses/d9ee14b5a5e6a63b10963f1984613dc53bc7974b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":0,"additions":0,"deletions":0,"changed_files":0}}