{"action":"created","issue":{"url":"https://api.github.com/repos/esl/escalus/issues/61","labels_url":"https://api.github.com/repos/esl/escalus/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/esl/escalus/issues/61/comments","events_url":"https://api.github.com/repos/esl/escalus/issues/61/events","html_url":"https://github.com/esl/escalus/pull/61","id":65217859,"number":61,"title":"Metrics check","user":{"login":"michalwski","id":705828,"avatar_url":"https://avatars.githubusercontent.com/u/705828?v=3","gravatar_id":"","url":"https://api.github.com/users/michalwski","html_url":"https://github.com/michalwski","followers_url":"https://api.github.com/users/michalwski/followers","following_url":"https://api.github.com/users/michalwski/following{/other_user}","gists_url":"https://api.github.com/users/michalwski/gists{/gist_id}","starred_url":"https://api.github.com/users/michalwski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalwski/subscriptions","organizations_url":"https://api.github.com/users/michalwski/orgs","repos_url":"https://api.github.com/users/michalwski/repos","events_url":"https://api.github.com/users/michalwski/events{/privacy}","received_events_url":"https://api.github.com/users/michalwski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-30T13:56:21Z","updated_at":"2015-03-31T10:18:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/esl/escalus/pulls/61","html_url":"https://github.com/esl/escalus/pull/61","diff_url":"https://github.com/esl/escalus/pull/61.diff","patch_url":"https://github.com/esl/escalus/pull/61.patch"},"body":"Allow to verify mongoose's metrics change after escalus story.\r\n\r\nExample usage is [metrics_roster_SUITE here](https://github.com/esl/ejabberd_tests/blob/more-metrics-2/tests/metrics_roster_SUITE.erl#L64-L71) and [here](https://github.com/esl/ejabberd_tests/blob/more-metrics-2/tests/metrics_roster_SUITE.erl#L143-L144) and also in [clustering_commands_SUITE](https://github.com/esl/ejabberd_tests/blob/more-metrics-2/tests/cluster_commands_SUITE.erl#L97-L98)\r\n\r\nThis PR is for esl/ejabberd_tests#116"},"comment":{"url":"https://api.github.com/repos/esl/escalus/issues/comments/88029648","html_url":"https://github.com/esl/escalus/pull/61#issuecomment-88029648","issue_url":"https://api.github.com/repos/esl/escalus/issues/61","id":88029648,"user":{"login":"michalwski","id":705828,"avatar_url":"https://avatars.githubusercontent.com/u/705828?v=3","gravatar_id":"","url":"https://api.github.com/users/michalwski","html_url":"https://github.com/michalwski","followers_url":"https://api.github.com/users/michalwski/followers","following_url":"https://api.github.com/users/michalwski/following{/other_user}","gists_url":"https://api.github.com/users/michalwski/gists{/gist_id}","starred_url":"https://api.github.com/users/michalwski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalwski/subscriptions","organizations_url":"https://api.github.com/users/michalwski/orgs","repos_url":"https://api.github.com/users/michalwski/repos","events_url":"https://api.github.com/users/michalwski/events{/privacy}","received_events_url":"https://api.github.com/users/michalwski/received_events","type":"User","site_admin":false},"created_at":"2015-03-31T10:18:36Z","updated_at":"2015-03-31T10:18:36Z","body":"Valuable feedback is always much appreciated :D. Here's what I suggest:\r\n1. `escalus_story` will have lines like:\r\n    *  `Config = escalus_server:pre_story(ConfigIn)` instead of `CountersToCheck = counters_to_check(ConfigIn),`\r\n    *  `escalus_server:post_story(Config)` instead of `post_story_check_counters(CountersToCheck)`\r\n2. `escalus_server` will dispatch above function to relevant implementation based on the Config parameter.\r\n\r\nWhat would you say?"}}