{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/45900398","id":45900398,"diff_hunk":"@@ -888,7 +888,7 @@ pub enum Ty_ {\n pub struct InlineAsm {\n     pub asm: InternedString,\n     pub asm_str_style: StrStyle,\n-    pub outputs: Vec<(InternedString, P<Expr>, bool)>,\n+    pub outputs: Vec<(InternedString, P<Expr>, bool, bool)>,","path":"src/librustc_front/hir.rs","position":5,"original_position":5,"commit_id":"48da5b20c7c0aed66e9fa67b58b051e58daf2989","original_commit_id":"48da5b20c7c0aed66e9fa67b58b051e58daf2989","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"body":"Could we use an enum here instead of two bools?","created_at":"2015-11-25T18:12:10Z","updated_at":"2015-11-25T18:12:10Z","html_url":"https://github.com/rust-lang/rust/pull/29735#discussion_r45900398","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/29735","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/45900398"},"html":{"href":"https://github.com/rust-lang/rust/pull/29735#discussion_r45900398"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/29735"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/29735","id":50209876,"html_url":"https://github.com/rust-lang/rust/pull/29735","diff_url":"https://github.com/rust-lang/rust/pull/29735.diff","patch_url":"https://github.com/rust-lang/rust/pull/29735.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/29735","number":29735,"state":"open","locked":false,"title":"Properly support inline asm indirect output operands","user":{"login":"Amanieu","id":278509,"avatar_url":"https://avatars.githubusercontent.com/u/278509?v=3","gravatar_id":"","url":"https://api.github.com/users/Amanieu","html_url":"https://github.com/Amanieu","followers_url":"https://api.github.com/users/Amanieu/followers","following_url":"https://api.github.com/users/Amanieu/following{/other_user}","gists_url":"https://api.github.com/users/Amanieu/gists{/gist_id}","starred_url":"https://api.github.com/users/Amanieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amanieu/subscriptions","organizations_url":"https://api.github.com/users/Amanieu/orgs","repos_url":"https://api.github.com/users/Amanieu/repos","events_url":"https://api.github.com/users/Amanieu/events{/privacy}","received_events_url":"https://api.github.com/users/Amanieu/received_events","type":"User","site_admin":false},"body":"This PR reverts #29543 and instead implements proper support for \"=*m\" and \"+*m\" indirect output operands. This provides a framework on top of which support for plain memory operands (\"m\", \"=m\" and \"+m\") can be implemented.\r\n\r\nThis also fixes the liveness analysis pass not handling read/write operands correctly.","created_at":"2015-11-10T03:20:35Z","updated_at":"2015-11-25T18:12:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fd1e994dfcb76aff8371117250b5855dbb80867","assignee":{"login":"pnkfelix","id":173127,"avatar_url":"https://avatars.githubusercontent.com/u/173127?v=3","gravatar_id":"","url":"https://api.github.com/users/pnkfelix","html_url":"https://github.com/pnkfelix","followers_url":"https://api.github.com/users/pnkfelix/followers","following_url":"https://api.github.com/users/pnkfelix/following{/other_user}","gists_url":"https://api.github.com/users/pnkfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/pnkfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnkfelix/subscriptions","organizations_url":"https://api.github.com/users/pnkfelix/orgs","repos_url":"https://api.github.com/users/pnkfelix/repos","events_url":"https://api.github.com/users/pnkfelix/events{/privacy}","received_events_url":"https://api.github.com/users/pnkfelix/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/29735/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/29735/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/29735/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/48da5b20c7c0aed66e9fa67b58b051e58daf2989","head":{"label":"Amanieu:asm_indirect_constraint","ref":"asm_indirect_constraint","sha":"48da5b20c7c0aed66e9fa67b58b051e58daf2989","user":{"login":"Amanieu","id":278509,"avatar_url":"https://avatars.githubusercontent.com/u/278509?v=3","gravatar_id":"","url":"https://api.github.com/users/Amanieu","html_url":"https://github.com/Amanieu","followers_url":"https://api.github.com/users/Amanieu/followers","following_url":"https://api.github.com/users/Amanieu/following{/other_user}","gists_url":"https://api.github.com/users/Amanieu/gists{/gist_id}","starred_url":"https://api.github.com/users/Amanieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amanieu/subscriptions","organizations_url":"https://api.github.com/users/Amanieu/orgs","repos_url":"https://api.github.com/users/Amanieu/repos","events_url":"https://api.github.com/users/Amanieu/events{/privacy}","received_events_url":"https://api.github.com/users/Amanieu/received_events","type":"User","site_admin":false},"repo":{"id":45469588,"name":"rust","full_name":"Amanieu/rust","owner":{"login":"Amanieu","id":278509,"avatar_url":"https://avatars.githubusercontent.com/u/278509?v=3","gravatar_id":"","url":"https://api.github.com/users/Amanieu","html_url":"https://github.com/Amanieu","followers_url":"https://api.github.com/users/Amanieu/followers","following_url":"https://api.github.com/users/Amanieu/following{/other_user}","gists_url":"https://api.github.com/users/Amanieu/gists{/gist_id}","starred_url":"https://api.github.com/users/Amanieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amanieu/subscriptions","organizations_url":"https://api.github.com/users/Amanieu/orgs","repos_url":"https://api.github.com/users/Amanieu/repos","events_url":"https://api.github.com/users/Amanieu/events{/privacy}","received_events_url":"https://api.github.com/users/Amanieu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Amanieu/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/Amanieu/rust","forks_url":"https://api.github.com/repos/Amanieu/rust/forks","keys_url":"https://api.github.com/repos/Amanieu/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Amanieu/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Amanieu/rust/teams","hooks_url":"https://api.github.com/repos/Amanieu/rust/hooks","issue_events_url":"https://api.github.com/repos/Amanieu/rust/issues/events{/number}","events_url":"https://api.github.com/repos/Amanieu/rust/events","assignees_url":"https://api.github.com/repos/Amanieu/rust/assignees{/user}","branches_url":"https://api.github.com/repos/Amanieu/rust/branches{/branch}","tags_url":"https://api.github.com/repos/Amanieu/rust/tags","blobs_url":"https://api.github.com/repos/Amanieu/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Amanieu/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Amanieu/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Amanieu/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Amanieu/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/Amanieu/rust/languages","stargazers_url":"https://api.github.com/repos/Amanieu/rust/stargazers","contributors_url":"https://api.github.com/repos/Amanieu/rust/contributors","subscribers_url":"https://api.github.com/repos/Amanieu/rust/subscribers","subscription_url":"https://api.github.com/repos/Amanieu/rust/subscription","commits_url":"https://api.github.com/repos/Amanieu/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Amanieu/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Amanieu/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Amanieu/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/Amanieu/rust/contents/{+path}","compare_url":"https://api.github.com/repos/Amanieu/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Amanieu/rust/merges","archive_url":"https://api.github.com/repos/Amanieu/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Amanieu/rust/downloads","issues_url":"https://api.github.com/repos/Amanieu/rust/issues{/number}","pulls_url":"https://api.github.com/repos/Amanieu/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/Amanieu/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/Amanieu/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Amanieu/rust/labels{/name}","releases_url":"https://api.github.com/repos/Amanieu/rust/releases{/id}","created_at":"2015-11-03T13:52:04Z","updated_at":"2015-11-03T13:52:55Z","pushed_at":"2015-11-19T05:02:59Z","git_url":"git://github.com/Amanieu/rust.git","ssh_url":"git@github.com:Amanieu/rust.git","clone_url":"https://github.com/Amanieu/rust.git","svn_url":"https://github.com/Amanieu/rust","homepage":"http://www.rust-lang.org","size":329441,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"3e48b0e380319dc586a329baac640b9457feb87a","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-11-25T17:23:16Z","pushed_at":"2015-11-25T17:56:05Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":390439,"stargazers_count":14279,"watchers_count":14279,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2787,"mirror_url":null,"open_issues_count":2312,"forks":2787,"open_issues":2312,"watchers":14279,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/29735"},"html":{"href":"https://github.com/rust-lang/rust/pull/29735"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/29735"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/29735/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/29735/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/29735/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/48da5b20c7c0aed66e9fa67b58b051e58daf2989"}}}}