{"action":"created","issue":{"url":"https://api.github.com/repos/unclebob/fitnesse/issues/780","labels_url":"https://api.github.com/repos/unclebob/fitnesse/issues/780/labels{/name}","comments_url":"https://api.github.com/repos/unclebob/fitnesse/issues/780/comments","events_url":"https://api.github.com/repos/unclebob/fitnesse/issues/780/events","html_url":"https://github.com/unclebob/fitnesse/issues/780","id":98607086,"number":780,"title":"Symbol names concatenated with text don't work in the Java Agent ","user":{"login":"six42","id":5906592,"avatar_url":"https://avatars.githubusercontent.com/u/5906592?v=3","gravatar_id":"","url":"https://api.github.com/users/six42","html_url":"https://github.com/six42","followers_url":"https://api.github.com/users/six42/followers","following_url":"https://api.github.com/users/six42/following{/other_user}","gists_url":"https://api.github.com/users/six42/gists{/gist_id}","starred_url":"https://api.github.com/users/six42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/six42/subscriptions","organizations_url":"https://api.github.com/users/six42/orgs","repos_url":"https://api.github.com/users/six42/repos","events_url":"https://api.github.com/users/six42/events{/privacy}","received_events_url":"https://api.github.com/users/six42/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-08-02T12:40:26Z","updated_at":"2015-09-18T17:30:25Z","closed_at":null,"body":"The below junit test claims that the slim test below should work.\r\nBut the slim test must fail as the slim agent doesn't implements this logic.\r\nDoes other slim agents other than Java implement this?\r\n\r\nTo make concatenation with text work I would like to change the symbol pattern to allow an optional $ to mark the end of the symbol name. What do others think about this? \r\n\r\n\r\nJunit:\r\ntest\\fitnesse\\testsystems\\slim\\tables\\SlimTableTest.java\r\nreplaceSymbols_ShouldReplaceConcutenatedSymbols\r\n\r\nSlim Test which fails:\r\n|import            |\r\n|fitnesse.slim.test|\r\n\r\n|script                    |\r\n|$X=  |echo int|99         |\r\n|check|echo    |$X   |99   |pass|\r\n|check|echo    |$X1  |991  | fail|\r\n|check|echo    |$Xabc|99abc| fail|\r\n\r\nNew proposed Syntax:\r\n|script                    |\r\n|$X=  |echo int|99         |\r\n|$y=  |echo int|7         |\r\n|check|echo    |$X   |99   |\r\n|check|echo    |$X$1  |991  | \r\n|check|echo    |$X$abc|99abc|\r\n|check|echo    |$X$$Y|997|\r\n\r\nFinally I feel that this test is not doing what he claims.\r\nI can't see in the code that $$ is implemented anywhere. Is this used by other non Java Agents?\r\nOtherwise I would remove this test.\r\nhttp://fitnesse.org/FitNesse.SuiteAcceptanceTests.SuiteSlimTests.SlimSymbolDollarDollar\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/unclebob/fitnesse/issues/comments/141514300","html_url":"https://github.com/unclebob/fitnesse/issues/780#issuecomment-141514300","issue_url":"https://api.github.com/repos/unclebob/fitnesse/issues/780","id":141514300,"user":{"login":"jplambert","id":10744293,"avatar_url":"https://avatars.githubusercontent.com/u/10744293?v=3","gravatar_id":"","url":"https://api.github.com/users/jplambert","html_url":"https://github.com/jplambert","followers_url":"https://api.github.com/users/jplambert/followers","following_url":"https://api.github.com/users/jplambert/following{/other_user}","gists_url":"https://api.github.com/users/jplambert/gists{/gist_id}","starred_url":"https://api.github.com/users/jplambert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jplambert/subscriptions","organizations_url":"https://api.github.com/users/jplambert/orgs","repos_url":"https://api.github.com/users/jplambert/repos","events_url":"https://api.github.com/users/jplambert/events{/privacy}","received_events_url":"https://api.github.com/users/jplambert/received_events","type":"User","site_admin":false},"created_at":"2015-09-18T17:30:24Z","updated_at":"2015-09-18T17:30:24Z","body":"@six42 \r\n\r\nWell, so far, it is kind of a non-issue for us. I mean, it is clearly poor design on FitNesse's side, but we managed to live with it by using camelCase to name our symbols.\r\n\r\nUnless I am missing something, you can always rename your symbols -- they are specific to your wiki, you have full control over them. Sure we lost time at the beginning discovering and then renaming our symbols, but now we know it and it's over.\r\n\r\nSo I'd rather say: shall we do things right or do nothing at all? I am feeling like FitNesse is now an old tool, and its age shows -- in things like that. Adding what you suggest won't really improve FitNesse: it will still have many quirks that makes you hate the tool when you use it everyday.\r\n\r\n(Disclaimer: I am a daily user of FitNesse and I love the tool. Well, using it extensively has made it become some kind of love-hate relationship. I am also looking what other tools are available out there and seeing tools with a regular syntax and a coherent behavior makes me want to switch tool.)\r\n\r\nSo, to conclude.\r\n- I believe FitNesse needs an overhaul, but I don't see it happen.\r\n- I don't think the change you propose is worth it, just use camelCase to name your symbols.\r\n- Having said that, I see no objection in adding the feature to FitNesse if you do the job :-)\r\n\r\nBy the way, if we change the way FitNesse handles symbols, we can also provide some automatic migration tool that would solve the compatibility problem."}}