{"action":"closed","number":22026,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/22026","id":28851269,"html_url":"https://github.com/rust-lang/rust/pull/22026","diff_url":"https://github.com/rust-lang/rust/pull/22026.diff","patch_url":"https://github.com/rust-lang/rust/pull/22026.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/22026","number":22026,"state":"closed","locked":false,"title":"Use a crate attribute to load plugins","user":{"login":"kmcallister","id":444997,"avatar_url":"https://avatars.githubusercontent.com/u/444997?v=3","gravatar_id":"","url":"https://api.github.com/users/kmcallister","html_url":"https://github.com/kmcallister","followers_url":"https://api.github.com/users/kmcallister/followers","following_url":"https://api.github.com/users/kmcallister/following{/other_user}","gists_url":"https://api.github.com/users/kmcallister/gists{/gist_id}","starred_url":"https://api.github.com/users/kmcallister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmcallister/subscriptions","organizations_url":"https://api.github.com/users/kmcallister/orgs","repos_url":"https://api.github.com/users/kmcallister/repos","events_url":"https://api.github.com/users/kmcallister/events{/privacy}","received_events_url":"https://api.github.com/users/kmcallister/received_events","type":"User","site_admin":false},"body":"```rust\r\n#[plugin] #[no_link] extern crate bleh;\r\n```\r\n\r\nbecomes a crate attribute\r\n\r\n```rust\r\n#![plugin(bleh)]\r\n```\r\n\r\nThe feature gate is still required.\r\n\r\nIt's almost never correct to link a plugin into the resulting library / executable, because it will bring all of libsyntax and librustc with it. However if you really want this behavior, you can get it with a separate `extern crate` item in addition to the `plugin` attribute.\r\n\r\nFixes #21043.\r\nFixes #20769.\r\n\r\n[breaking-change]","created_at":"2015-02-06T23:32:02Z","updated_at":"2015-02-10T13:23:33Z","closed_at":"2015-02-10T13:23:33Z","merged_at":"2015-02-10T13:23:33Z","merge_commit_sha":"b969893aa812f1fe679041b34ceb52e25149678c","assignee":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/22026/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/22026/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/22026/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/1aedc45f85fe9feb70971f9d0c743c4af550a080","head":{"label":"kmcallister:plugin","ref":"plugin","sha":"1aedc45f85fe9feb70971f9d0c743c4af550a080","user":{"login":"kmcallister","id":444997,"avatar_url":"https://avatars.githubusercontent.com/u/444997?v=3","gravatar_id":"","url":"https://api.github.com/users/kmcallister","html_url":"https://github.com/kmcallister","followers_url":"https://api.github.com/users/kmcallister/followers","following_url":"https://api.github.com/users/kmcallister/following{/other_user}","gists_url":"https://api.github.com/users/kmcallister/gists{/gist_id}","starred_url":"https://api.github.com/users/kmcallister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmcallister/subscriptions","organizations_url":"https://api.github.com/users/kmcallister/orgs","repos_url":"https://api.github.com/users/kmcallister/repos","events_url":"https://api.github.com/users/kmcallister/events{/privacy}","received_events_url":"https://api.github.com/users/kmcallister/received_events","type":"User","site_admin":false},"repo":{"id":11487393,"name":"rust","full_name":"kmcallister/rust","owner":{"login":"kmcallister","id":444997,"avatar_url":"https://avatars.githubusercontent.com/u/444997?v=3","gravatar_id":"","url":"https://api.github.com/users/kmcallister","html_url":"https://github.com/kmcallister","followers_url":"https://api.github.com/users/kmcallister/followers","following_url":"https://api.github.com/users/kmcallister/following{/other_user}","gists_url":"https://api.github.com/users/kmcallister/gists{/gist_id}","starred_url":"https://api.github.com/users/kmcallister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmcallister/subscriptions","organizations_url":"https://api.github.com/users/kmcallister/orgs","repos_url":"https://api.github.com/users/kmcallister/repos","events_url":"https://api.github.com/users/kmcallister/events{/privacy}","received_events_url":"https://api.github.com/users/kmcallister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kmcallister/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/kmcallister/rust","forks_url":"https://api.github.com/repos/kmcallister/rust/forks","keys_url":"https://api.github.com/repos/kmcallister/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kmcallister/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kmcallister/rust/teams","hooks_url":"https://api.github.com/repos/kmcallister/rust/hooks","issue_events_url":"https://api.github.com/repos/kmcallister/rust/issues/events{/number}","events_url":"https://api.github.com/repos/kmcallister/rust/events","assignees_url":"https://api.github.com/repos/kmcallister/rust/assignees{/user}","branches_url":"https://api.github.com/repos/kmcallister/rust/branches{/branch}","tags_url":"https://api.github.com/repos/kmcallister/rust/tags","blobs_url":"https://api.github.com/repos/kmcallister/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kmcallister/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kmcallister/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/kmcallister/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kmcallister/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/kmcallister/rust/languages","stargazers_url":"https://api.github.com/repos/kmcallister/rust/stargazers","contributors_url":"https://api.github.com/repos/kmcallister/rust/contributors","subscribers_url":"https://api.github.com/repos/kmcallister/rust/subscribers","subscription_url":"https://api.github.com/repos/kmcallister/rust/subscription","commits_url":"https://api.github.com/repos/kmcallister/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/kmcallister/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/kmcallister/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/kmcallister/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/kmcallister/rust/contents/{+path}","compare_url":"https://api.github.com/repos/kmcallister/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kmcallister/rust/merges","archive_url":"https://api.github.com/repos/kmcallister/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kmcallister/rust/downloads","issues_url":"https://api.github.com/repos/kmcallister/rust/issues{/number}","pulls_url":"https://api.github.com/repos/kmcallister/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/kmcallister/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/kmcallister/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kmcallister/rust/labels{/name}","releases_url":"https://api.github.com/repos/kmcallister/rust/releases{/id}","created_at":"2013-07-17T20:58:11Z","updated_at":"2014-06-25T03:42:03Z","pushed_at":"2015-02-09T22:26:17Z","git_url":"git://github.com/kmcallister/rust.git","ssh_url":"git@github.com:kmcallister/rust.git","clone_url":"https://github.com/kmcallister/rust.git","svn_url":"https://github.com/kmcallister/rust","homepage":"http://www.rust-lang.org","size":232211,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"0ba9e1fa52627404a1e5b90f745f96a872a0c564","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-02-10T13:23:28Z","pushed_at":"2015-02-10T13:23:30Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":471461,"stargazers_count":9292,"watchers_count":9292,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1778,"mirror_url":null,"open_issues_count":2039,"forks":1778,"open_issues":2039,"watchers":9292,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/22026"},"html":{"href":"https://github.com/rust-lang/rust/pull/22026"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/22026"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/22026/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/22026/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/22026/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/1aedc45f85fe9feb70971f9d0c743c4af550a080"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"avatar_url":"https://avatars.githubusercontent.com/u/3372342?v=3","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":14,"review_comments":1,"commits":2,"additions":156,"deletions":165,"changed_files":37}}