{"action":"created","issue":{"url":"https://api.github.com/repos/dobtco/dvl-core/issues/196","labels_url":"https://api.github.com/repos/dobtco/dvl-core/issues/196/labels{/name}","comments_url":"https://api.github.com/repos/dobtco/dvl-core/issues/196/comments","events_url":"https://api.github.com/repos/dobtco/dvl-core/issues/196/events","html_url":"https://github.com/dobtco/dvl-core/pull/196","id":113845614,"number":196,"title":"New flash styles","user":{"login":"ajb","id":1270317,"avatar_url":"https://avatars.githubusercontent.com/u/1270317?v=3","gravatar_id":"","url":"https://api.github.com/users/ajb","html_url":"https://github.com/ajb","followers_url":"https://api.github.com/users/ajb/followers","following_url":"https://api.github.com/users/ajb/following{/other_user}","gists_url":"https://api.github.com/users/ajb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajb/subscriptions","organizations_url":"https://api.github.com/users/ajb/orgs","repos_url":"https://api.github.com/users/ajb/repos","events_url":"https://api.github.com/users/ajb/events{/privacy}","received_events_url":"https://api.github.com/users/ajb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jrubenoff","id":1328849,"avatar_url":"https://avatars.githubusercontent.com/u/1328849?v=3","gravatar_id":"","url":"https://api.github.com/users/jrubenoff","html_url":"https://github.com/jrubenoff","followers_url":"https://api.github.com/users/jrubenoff/followers","following_url":"https://api.github.com/users/jrubenoff/following{/other_user}","gists_url":"https://api.github.com/users/jrubenoff/gists{/gist_id}","starred_url":"https://api.github.com/users/jrubenoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrubenoff/subscriptions","organizations_url":"https://api.github.com/users/jrubenoff/orgs","repos_url":"https://api.github.com/users/jrubenoff/repos","events_url":"https://api.github.com/users/jrubenoff/events{/privacy}","received_events_url":"https://api.github.com/users/jrubenoff/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-10-28T15:19:18Z","updated_at":"2015-10-28T21:46:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dobtco/dvl-core/pulls/196","html_url":"https://github.com/dobtco/dvl-core/pull/196","diff_url":"https://github.com/dobtco/dvl-core/pull/196.diff","patch_url":"https://github.com/dobtco/dvl-core/pull/196.patch"},"body":"Rebase of #83.\r\n\r\nI refactored some of the code and tried to fix the bugs that I found with transitions, etc.\r\n\r\n@jrubenoff: assuming the output looks good, do you want to take a quick look to see if there's any refactoring you can do of the CSS? It looks a little messy to my eyes, which would make sense given the many iterations of flashes that we went through.\r\n"},"comment":{"url":"https://api.github.com/repos/dobtco/dvl-core/issues/comments/152004560","html_url":"https://github.com/dobtco/dvl-core/pull/196#issuecomment-152004560","issue_url":"https://api.github.com/repos/dobtco/dvl-core/issues/196","id":152004560,"user":{"login":"ajb","id":1270317,"avatar_url":"https://avatars.githubusercontent.com/u/1270317?v=3","gravatar_id":"","url":"https://api.github.com/users/ajb","html_url":"https://github.com/ajb","followers_url":"https://api.github.com/users/ajb/followers","following_url":"https://api.github.com/users/ajb/following{/other_user}","gists_url":"https://api.github.com/users/ajb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajb/subscriptions","organizations_url":"https://api.github.com/users/ajb/orgs","repos_url":"https://api.github.com/users/ajb/repos","events_url":"https://api.github.com/users/ajb/events{/privacy}","received_events_url":"https://api.github.com/users/ajb/received_events","type":"User","site_admin":false},"created_at":"2015-10-28T21:46:13Z","updated_at":"2015-10-28T21:46:13Z","body":"It looks like persistent flashes are \"any flashes that have links\". Is this\nan incorrect assumption?\n\nOn Wed, Oct 28, 2015 at 2:44 PM, Josh Rubenoff <notifications@github.com>\nwrote:\n\n> Fixed some styles:\n>\n> [image: screen shot 2015-10-28 at 2 43 38 pm]\n> <https://cloud.githubusercontent.com/assets/1328849/10803993/538c3ebe-7d82-11e5-9387-2545a2900eda.png>\n>\n> Where did the persistent flashes go? We need them for shortcuts.\n>\n> Shortcut flashes will just have the .flash_shortcut class in Screendoor.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/dobtco/dvl-core/pull/196#issuecomment-152004296>.\n>\n\n\n\n-- \nAdam Becker\n(951) 9-BECKER\n@AdamJacobBecker\n"}}