{"action":"created","comment":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/comments/44995646","id":44995646,"diff_hunk":"@@ -43,14 +43,36 @@\n   }\n }\n \n+// Page Layout\n+//---------------------------------------------------\n+.admin-nav {\n+  @include position(absolute, 0 null 0 0);\n+  width: $width-sidebar;\n+}\n+\n+.main-content {\n+  margin-left: $width-sidebar;\n+}\n+\n // Header\n //---------------------------------------------------\n-#header {\n+.admin-nav-header {\n+  padding: 15px;\n+  height: 31px * (0.67); // height of .page-title\n+  box-sizing: content-box;\n   background-color: $color-1;\n-  padding: 5px 0;\n-}\n+  border-bottom: 1px solid $color-border;\n+\n+  a {\n+    display: inline-block;\n+    line-height: 64px;\n+  }\n \n-#logo { height: 40px }\n+  img {\n+    vertical-align: middle;\n+    margin-top: -12px; // hand-tweaking because the solid logo is bottom heavy","path":"backend/app/assets/stylesheets/spree/backend/shared/_layout.scss","position":35,"original_position":35,"commit_id":"808f5cf3e62d2586fc4a76c2e73a9708c3f597db","original_commit_id":"808f5cf3e62d2586fc4a76c2e73a9708c3f597db","user":{"login":"Sinetheta","id":1529452,"avatar_url":"https://avatars.githubusercontent.com/u/1529452?v=3","gravatar_id":"","url":"https://api.github.com/users/Sinetheta","html_url":"https://github.com/Sinetheta","followers_url":"https://api.github.com/users/Sinetheta/followers","following_url":"https://api.github.com/users/Sinetheta/following{/other_user}","gists_url":"https://api.github.com/users/Sinetheta/gists{/gist_id}","starred_url":"https://api.github.com/users/Sinetheta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sinetheta/subscriptions","organizations_url":"https://api.github.com/users/Sinetheta/orgs","repos_url":"https://api.github.com/users/Sinetheta/repos","events_url":"https://api.github.com/users/Sinetheta/events{/privacy}","received_events_url":"https://api.github.com/users/Sinetheta/received_events","type":"User","site_admin":false},"body":"Good call. That corner is bound to be problematic. Either it's a part of the sidebar which \"happens\" to be the same height as the `.page-title ` or part of the main content with happens to be the same width as the sidebar.\r\n\r\nI'm thinking that the latter might help with this positioning problem since the sidebar currently has a static width.","created_at":"2015-11-16T22:39:38Z","updated_at":"2015-11-16T22:39:38Z","html_url":"https://github.com/solidusio/solidus/pull/509#discussion_r44995646","pull_request_url":"https://api.github.com/repos/solidusio/solidus/pulls/509","_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments/44995646"},"html":{"href":"https://github.com/solidusio/solidus/pull/509#discussion_r44995646"},"pull_request":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/509"}}},"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/509","id":50697349,"html_url":"https://github.com/solidusio/solidus/pull/509","diff_url":"https://github.com/solidusio/solidus/pull/509.diff","patch_url":"https://github.com/solidusio/solidus/pull/509.patch","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/509","number":509,"state":"open","locked":false,"title":"Admin navigation sidebar","user":{"login":"Sinetheta","id":1529452,"avatar_url":"https://avatars.githubusercontent.com/u/1529452?v=3","gravatar_id":"","url":"https://api.github.com/users/Sinetheta","html_url":"https://github.com/Sinetheta","followers_url":"https://api.github.com/users/Sinetheta/followers","following_url":"https://api.github.com/users/Sinetheta/following{/other_user}","gists_url":"https://api.github.com/users/Sinetheta/gists{/gist_id}","starred_url":"https://api.github.com/users/Sinetheta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sinetheta/subscriptions","organizations_url":"https://api.github.com/users/Sinetheta/orgs","repos_url":"https://api.github.com/users/Sinetheta/repos","events_url":"https://api.github.com/users/Sinetheta/events{/privacy}","received_events_url":"https://api.github.com/users/Sinetheta/received_events","type":"User","site_admin":false},"body":"- Adds a full height sidebar to the admin area\r\n- Moves the admin nav from the header to the sidebar\r\n- Nests the subnav in the main nav (visible as an open \"accordion\")\r\n- Adds a flyout for not active subnavs\r\n\r\n![screen shot 2015-11-13 at 1 54 09 pm](https://cloud.githubusercontent.com/assets/1529452/11158575/1027ad32-8a0e-11e5-9ee8-9aea23ea37e0.png)\r\n\r\nThis will be accompanied by a tiny patch to solidus_auth_devise since the current user nav items (logged in as, account, logout) have been moved as well.\r\n\r\nresolves #498\r\nresolves #505\r\nadvances #487","created_at":"2015-11-13T21:58:01Z","updated_at":"2015-11-16T22:39:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5aa261f6e2b0668d0a64a600eafb284a78a54b7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus/pulls/509/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus/pulls/509/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/509/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/808f5cf3e62d2586fc4a76c2e73a9708c3f597db","head":{"label":"Sinetheta:admin-nav","ref":"admin-nav","sha":"808f5cf3e62d2586fc4a76c2e73a9708c3f597db","user":{"login":"Sinetheta","id":1529452,"avatar_url":"https://avatars.githubusercontent.com/u/1529452?v=3","gravatar_id":"","url":"https://api.github.com/users/Sinetheta","html_url":"https://github.com/Sinetheta","followers_url":"https://api.github.com/users/Sinetheta/followers","following_url":"https://api.github.com/users/Sinetheta/following{/other_user}","gists_url":"https://api.github.com/users/Sinetheta/gists{/gist_id}","starred_url":"https://api.github.com/users/Sinetheta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sinetheta/subscriptions","organizations_url":"https://api.github.com/users/Sinetheta/orgs","repos_url":"https://api.github.com/users/Sinetheta/repos","events_url":"https://api.github.com/users/Sinetheta/events{/privacy}","received_events_url":"https://api.github.com/users/Sinetheta/received_events","type":"User","site_admin":false},"repo":{"id":39987794,"name":"solidus","full_name":"Sinetheta/solidus","owner":{"login":"Sinetheta","id":1529452,"avatar_url":"https://avatars.githubusercontent.com/u/1529452?v=3","gravatar_id":"","url":"https://api.github.com/users/Sinetheta","html_url":"https://github.com/Sinetheta","followers_url":"https://api.github.com/users/Sinetheta/followers","following_url":"https://api.github.com/users/Sinetheta/following{/other_user}","gists_url":"https://api.github.com/users/Sinetheta/gists{/gist_id}","starred_url":"https://api.github.com/users/Sinetheta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sinetheta/subscriptions","organizations_url":"https://api.github.com/users/Sinetheta/orgs","repos_url":"https://api.github.com/users/Sinetheta/repos","events_url":"https://api.github.com/users/Sinetheta/events{/privacy}","received_events_url":"https://api.github.com/users/Sinetheta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sinetheta/solidus","description":"Solidus e-commerce system","fork":true,"url":"https://api.github.com/repos/Sinetheta/solidus","forks_url":"https://api.github.com/repos/Sinetheta/solidus/forks","keys_url":"https://api.github.com/repos/Sinetheta/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sinetheta/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sinetheta/solidus/teams","hooks_url":"https://api.github.com/repos/Sinetheta/solidus/hooks","issue_events_url":"https://api.github.com/repos/Sinetheta/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/Sinetheta/solidus/events","assignees_url":"https://api.github.com/repos/Sinetheta/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/Sinetheta/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/Sinetheta/solidus/tags","blobs_url":"https://api.github.com/repos/Sinetheta/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sinetheta/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sinetheta/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sinetheta/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sinetheta/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/Sinetheta/solidus/languages","stargazers_url":"https://api.github.com/repos/Sinetheta/solidus/stargazers","contributors_url":"https://api.github.com/repos/Sinetheta/solidus/contributors","subscribers_url":"https://api.github.com/repos/Sinetheta/solidus/subscribers","subscription_url":"https://api.github.com/repos/Sinetheta/solidus/subscription","commits_url":"https://api.github.com/repos/Sinetheta/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sinetheta/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sinetheta/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sinetheta/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sinetheta/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/Sinetheta/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sinetheta/solidus/merges","archive_url":"https://api.github.com/repos/Sinetheta/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sinetheta/solidus/downloads","issues_url":"https://api.github.com/repos/Sinetheta/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/Sinetheta/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/Sinetheta/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/Sinetheta/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sinetheta/solidus/labels{/name}","releases_url":"https://api.github.com/repos/Sinetheta/solidus/releases{/id}","created_at":"2015-07-31T05:10:46Z","updated_at":"2015-07-31T05:10:49Z","pushed_at":"2015-11-16T19:58:10Z","git_url":"git://github.com/Sinetheta/solidus.git","ssh_url":"git@github.com:Sinetheta/solidus.git","clone_url":"https://github.com/Sinetheta/solidus.git","svn_url":"https://github.com/Sinetheta/solidus","homepage":"","size":59953,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"b97a3740f23ecdf378fb29901b7e07ddc4b447da","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":30985840,"name":"solidus","full_name":"solidusio/solidus","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus","description":"Solidus, Rails eCommerce System","fork":false,"url":"https://api.github.com/repos/solidusio/solidus","forks_url":"https://api.github.com/repos/solidusio/solidus/forks","keys_url":"https://api.github.com/repos/solidusio/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus/events","assignees_url":"https://api.github.com/repos/solidusio/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus/merges","archive_url":"https://api.github.com/repos/solidusio/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus/releases{/id}","created_at":"2015-02-18T20:41:58Z","updated_at":"2015-11-16T22:37:01Z","pushed_at":"2015-11-16T19:58:10Z","git_url":"git://github.com/solidusio/solidus.git","ssh_url":"git@github.com:solidusio/solidus.git","clone_url":"https://github.com/solidusio/solidus.git","svn_url":"https://github.com/solidusio/solidus","homepage":"http://solidus.io/","size":68100,"stargazers_count":227,"watchers_count":227,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":70,"forks":65,"open_issues":70,"watchers":227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/509"},"html":{"href":"https://github.com/solidusio/solidus/pull/509"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus/issues/509"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus/issues/509/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/509/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/509/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus/statuses/808f5cf3e62d2586fc4a76c2e73a9708c3f597db"}}}}