{"action":"created","comment":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/comments/28130693","id":28130693,"diff_hunk":"@@ -52,7 +52,7 @@ DNS_IMAGE=$BASE_DNS_IMAGE:$IMAGE_VERSION\n EXEC_IMAGE=$BASE_EXEC_IMAGE:$IMAGE_VERSION\n \n exec_remote() {\n-    docker run -t --rm \\\n+    docker run --sig-proxy=true --rm \\","path":"weave","position":5,"original_position":5,"commit_id":"9d97b1d1ed334cf0d125950f492c2be3adc7ff19","original_commit_id":"9d97b1d1ed334cf0d125950f492c2be3adc7ff19","user":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"body":"yes","created_at":"2015-04-10T09:01:05Z","updated_at":"2015-04-10T09:01:05Z","html_url":"https://github.com/weaveworks/weave/pull/523#discussion_r28130693","pull_request_url":"https://api.github.com/repos/weaveworks/weave/pulls/523","_links":{"self":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/comments/28130693"},"html":{"href":"https://github.com/weaveworks/weave/pull/523#discussion_r28130693"},"pull_request":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/523"}}},"pull_request":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/523","id":32842177,"html_url":"https://github.com/weaveworks/weave/pull/523","diff_url":"https://github.com/weaveworks/weave/pull/523.diff","patch_url":"https://github.com/weaveworks/weave/pull/523.patch","issue_url":"https://api.github.com/repos/weaveworks/weave/issues/523","number":523,"state":"open","locked":false,"title":"Implement weaveexec signal proxy","user":{"login":"awh","id":1504438,"avatar_url":"https://avatars.githubusercontent.com/u/1504438?v=3","gravatar_id":"","url":"https://api.github.com/users/awh","html_url":"https://github.com/awh","followers_url":"https://api.github.com/users/awh/followers","following_url":"https://api.github.com/users/awh/following{/other_user}","gists_url":"https://api.github.com/users/awh/gists{/gist_id}","starred_url":"https://api.github.com/users/awh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awh/subscriptions","organizations_url":"https://api.github.com/users/awh/orgs","repos_url":"https://api.github.com/users/awh/repos","events_url":"https://api.github.com/users/awh/events{/privacy}","received_events_url":"https://api.github.com/users/awh/received_events","type":"User","site_admin":false},"body":"Address #507 (`weave` and `weave --local` behave differently).\r\n\r\nIntroduce an intermediate signal proxying process that:\r\n\r\n* Runs as PID 1 inside the weaveexec container\r\n* Installs a SIGINT handler\r\n* Forks and execs the weave script\r\n* Redelivers inbound SIGINTs (received from `docker run --sig-proxy=true`) to its own process group, which includes the shell running the weave script and any subprocesses (such as `curl`) it is executing\r\n* Waits for child to exit and then exits with child's exit status\r\n\r\nAs a consequence we can disable the problematic docker pseudoterminal allocation without losing the ability to interrupt the script running in the weaveexec container. ","created_at":"2015-04-08T09:27:19Z","updated_at":"2015-04-10T09:01:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"674b830e238f65e10413dbd5bd0699b8f26390ff","assignee":{"login":"awh","id":1504438,"avatar_url":"https://avatars.githubusercontent.com/u/1504438?v=3","gravatar_id":"","url":"https://api.github.com/users/awh","html_url":"https://github.com/awh","followers_url":"https://api.github.com/users/awh/followers","following_url":"https://api.github.com/users/awh/following{/other_user}","gists_url":"https://api.github.com/users/awh/gists{/gist_id}","starred_url":"https://api.github.com/users/awh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awh/subscriptions","organizations_url":"https://api.github.com/users/awh/orgs","repos_url":"https://api.github.com/users/awh/repos","events_url":"https://api.github.com/users/awh/events{/privacy}","received_events_url":"https://api.github.com/users/awh/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/weave/pulls/523/commits","review_comments_url":"https://api.github.com/repos/weaveworks/weave/pulls/523/comments","review_comment_url":"https://api.github.com/repos/weaveworks/weave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/weave/issues/523/comments","statuses_url":"https://api.github.com/repos/weaveworks/weave/statuses/9d97b1d1ed334cf0d125950f492c2be3adc7ff19","head":{"label":"awh:handle_signals_without_tty","ref":"handle_signals_without_tty","sha":"9d97b1d1ed334cf0d125950f492c2be3adc7ff19","user":{"login":"awh","id":1504438,"avatar_url":"https://avatars.githubusercontent.com/u/1504438?v=3","gravatar_id":"","url":"https://api.github.com/users/awh","html_url":"https://github.com/awh","followers_url":"https://api.github.com/users/awh/followers","following_url":"https://api.github.com/users/awh/following{/other_user}","gists_url":"https://api.github.com/users/awh/gists{/gist_id}","starred_url":"https://api.github.com/users/awh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awh/subscriptions","organizations_url":"https://api.github.com/users/awh/orgs","repos_url":"https://api.github.com/users/awh/repos","events_url":"https://api.github.com/users/awh/events{/privacy}","received_events_url":"https://api.github.com/users/awh/received_events","type":"User","site_admin":false},"repo":{"id":30765046,"name":"weave","full_name":"awh/weave","owner":{"login":"awh","id":1504438,"avatar_url":"https://avatars.githubusercontent.com/u/1504438?v=3","gravatar_id":"","url":"https://api.github.com/users/awh","html_url":"https://github.com/awh","followers_url":"https://api.github.com/users/awh/followers","following_url":"https://api.github.com/users/awh/following{/other_user}","gists_url":"https://api.github.com/users/awh/gists{/gist_id}","starred_url":"https://api.github.com/users/awh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awh/subscriptions","organizations_url":"https://api.github.com/users/awh/orgs","repos_url":"https://api.github.com/users/awh/repos","events_url":"https://api.github.com/users/awh/events{/privacy}","received_events_url":"https://api.github.com/users/awh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awh/weave","description":"The Docker Network","fork":true,"url":"https://api.github.com/repos/awh/weave","forks_url":"https://api.github.com/repos/awh/weave/forks","keys_url":"https://api.github.com/repos/awh/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awh/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awh/weave/teams","hooks_url":"https://api.github.com/repos/awh/weave/hooks","issue_events_url":"https://api.github.com/repos/awh/weave/issues/events{/number}","events_url":"https://api.github.com/repos/awh/weave/events","assignees_url":"https://api.github.com/repos/awh/weave/assignees{/user}","branches_url":"https://api.github.com/repos/awh/weave/branches{/branch}","tags_url":"https://api.github.com/repos/awh/weave/tags","blobs_url":"https://api.github.com/repos/awh/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awh/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awh/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/awh/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awh/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/awh/weave/languages","stargazers_url":"https://api.github.com/repos/awh/weave/stargazers","contributors_url":"https://api.github.com/repos/awh/weave/contributors","subscribers_url":"https://api.github.com/repos/awh/weave/subscribers","subscription_url":"https://api.github.com/repos/awh/weave/subscription","commits_url":"https://api.github.com/repos/awh/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/awh/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/awh/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/awh/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/awh/weave/contents/{+path}","compare_url":"https://api.github.com/repos/awh/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awh/weave/merges","archive_url":"https://api.github.com/repos/awh/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awh/weave/downloads","issues_url":"https://api.github.com/repos/awh/weave/issues{/number}","pulls_url":"https://api.github.com/repos/awh/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/awh/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/awh/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awh/weave/labels{/name}","releases_url":"https://api.github.com/repos/awh/weave/releases{/id}","created_at":"2015-02-13T16:32:58Z","updated_at":"2015-04-07T08:36:35Z","pushed_at":"2015-04-08T13:29:35Z","git_url":"git://github.com/awh/weave.git","ssh_url":"git@github.com:awh/weave.git","clone_url":"https://github.com/awh/weave.git","svn_url":"https://github.com/awh/weave","homepage":"","size":2041,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"weaveworks:master","ref":"master","sha":"86abc6ac2b2c7ff6ff2028594b3e12b79adff747","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":23059575,"name":"weave","full_name":"weaveworks/weave","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/weave","description":"The Docker Network","fork":false,"url":"https://api.github.com/repos/weaveworks/weave","forks_url":"https://api.github.com/repos/weaveworks/weave/forks","keys_url":"https://api.github.com/repos/weaveworks/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/weave/teams","hooks_url":"https://api.github.com/repos/weaveworks/weave/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/weave/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/weave/events","assignees_url":"https://api.github.com/repos/weaveworks/weave/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/weave/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/weave/tags","blobs_url":"https://api.github.com/repos/weaveworks/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/weave/languages","stargazers_url":"https://api.github.com/repos/weaveworks/weave/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/weave/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/weave/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/weave/subscription","commits_url":"https://api.github.com/repos/weaveworks/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/weave/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/weave/merges","archive_url":"https://api.github.com/repos/weaveworks/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/weave/downloads","issues_url":"https://api.github.com/repos/weaveworks/weave/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/weave/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/weave/releases{/id}","created_at":"2014-08-18T05:19:07Z","updated_at":"2015-04-10T07:18:58Z","pushed_at":"2015-04-10T08:49:31Z","git_url":"git://github.com/weaveworks/weave.git","ssh_url":"git@github.com:weaveworks/weave.git","clone_url":"https://github.com/weaveworks/weave.git","svn_url":"https://github.com/weaveworks/weave","homepage":"","size":7517,"stargazers_count":3124,"watchers_count":3124,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":164,"mirror_url":null,"open_issues_count":106,"forks":164,"open_issues":106,"watchers":3124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/523"},"html":{"href":"https://github.com/weaveworks/weave/pull/523"},"issue":{"href":"https://api.github.com/repos/weaveworks/weave/issues/523"},"comments":{"href":"https://api.github.com/repos/weaveworks/weave/issues/523/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/523/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/523/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/weave/statuses/9d97b1d1ed334cf0d125950f492c2be3adc7ff19"}}}}