{"action":"created","issue":{"url":"https://api.github.com/repos/modxcms/revolution/issues/12538","labels_url":"https://api.github.com/repos/modxcms/revolution/issues/12538/labels{/name}","comments_url":"https://api.github.com/repos/modxcms/revolution/issues/12538/comments","events_url":"https://api.github.com/repos/modxcms/revolution/issues/12538/events","html_url":"https://github.com/modxcms/revolution/pull/12538","id":99704089,"number":12538,"title":"Set compress_js and compress_css system settings to false by default.","user":{"login":"sottwell","id":1073780,"avatar_url":"https://avatars.githubusercontent.com/u/1073780?v=3","gravatar_id":"","url":"https://api.github.com/users/sottwell","html_url":"https://github.com/sottwell","followers_url":"https://api.github.com/users/sottwell/followers","following_url":"https://api.github.com/users/sottwell/following{/other_user}","gists_url":"https://api.github.com/users/sottwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sottwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sottwell/subscriptions","organizations_url":"https://api.github.com/users/sottwell/orgs","repos_url":"https://api.github.com/users/sottwell/repos","events_url":"https://api.github.com/users/sottwell/events{/privacy}","received_events_url":"https://api.github.com/users/sottwell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-08-07T18:33:37Z","updated_at":"2015-08-26T00:29:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/modxcms/revolution/pulls/12538","html_url":"https://github.com/modxcms/revolution/pull/12538","diff_url":"https://github.com/modxcms/revolution/pull/12538.diff","patch_url":"https://github.com/modxcms/revolution/pull/12538.patch"},"body":"Set compress_css and compress_js to false by default in System Settings on installation.\r\n_build/data/transport.core.system_settings.php on lines 318 and 327"},"comment":{"url":"https://api.github.com/repos/modxcms/revolution/issues/comments/134778246","html_url":"https://github.com/modxcms/revolution/pull/12538#issuecomment-134778246","issue_url":"https://api.github.com/repos/modxcms/revolution/issues/12538","id":134778246,"user":{"login":"Mark-H","id":312944,"avatar_url":"https://avatars.githubusercontent.com/u/312944?v=3","gravatar_id":"","url":"https://api.github.com/users/Mark-H","html_url":"https://github.com/Mark-H","followers_url":"https://api.github.com/users/Mark-H/followers","following_url":"https://api.github.com/users/Mark-H/following{/other_user}","gists_url":"https://api.github.com/users/Mark-H/gists{/gist_id}","starred_url":"https://api.github.com/users/Mark-H/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mark-H/subscriptions","organizations_url":"https://api.github.com/users/Mark-H/orgs","repos_url":"https://api.github.com/users/Mark-H/repos","events_url":"https://api.github.com/users/Mark-H/events{/privacy}","received_events_url":"https://api.github.com/users/Mark-H/received_events","type":"User","site_admin":false},"created_at":"2015-08-26T00:29:44Z","updated_at":"2015-08-26T00:29:44Z","body":"One last thing JP, I'm just as tired of dealing with compress_js issues as\nyou are. Just cause I'm not religiously doing everything I can to nuke it\ndoesn't mean I think we should keep using it forever. I just want whatever\nsolution ends up being used to be better than before (and we differ on the\ndefinition of better).\n\nI've got other things that I prefer putting energy in, so please stop\ntrying to put this one on me whenever it comes up.\n\nI'm flattered you believe I am the person that needs to be convinced in\norder to get this or a similar PR merged :)\n\nI do think taking out the compression (or disabling by default) has big\nbenefits. I also think I'd like to see something like a grunt workflow that\ncombines and minifies the set of files that are always included would be\ngood to replace it with at that time. There's just too many core js files\nand too much pointless whitespace and comments. It will take a long time\nfor HTTP2 to make it to commodity hosting so let's at least do some\noptimization while the web is upgrading.\n\nThat said, you don't seem to realize there are on my last count 5 other\npeople with commit access that might just be happy to just nuke it as is\nand be done with it. While I think it's important that there is consensus\namong integrators, that doesn't mean it has to be unanimous.\n\nThere's one concern in terms of backwards compatibility and that's custom\nmanager themes might need to be fixed with the minifier gone because it is\nreferred to in the header. For that reason I would slate removal of the\nminifier for 2.5, even leaving towards 3.0. Changing a setting default is\nprobably fine in a minor.\nOp 26 aug. 2015 1:39 AM schreef \"JP DeVries\" <notifications@github.com>:\n\n> You're preaching to the choir here, I think.\n>\n> I know, but the problem is I still don't think I've convinced @Mark-H\n> <https://github.com/Mark-H>. I recall he once said that if I proved it\n> wasn't performant he would remove them himself. Apparently I've failed to\n> do so even after having this debate going on well over a year now.\n>\n> http://forums.modx.com/thread/91496/why-compress-css-and-compress-js-are-silly#dis-post-500377\n>\n> The problem is you have to keep in mind the performance is relevant to the\n> CPU load on the server AND that the process itself is keeping the server\n> from doing other things. There may be test cases where the initial doc\n> ready load time is quicker for a given MODX Dashboard with a cleared cache\n> and compress settings on. I'll give you that. There also may be cases were\n> it isn't. There definitely are cases where it breaks the manager entirely.\n>\n> I guess my question is specially what else @Mark-H\n> <https://github.com/Mark-H> needs to be convinced these settings should\n> go.\n>\n> @Mark-H <https://github.com/Mark-H> you ask for numbers but you don't\n> seem to acknowledge is that this isn't just about the numbers. Any\n> performance that could be measured is relative to:\n>\n>    - servers hardware\n>    - server software\n>    - server load\n>    - potential errors\n>\n> Design isn't about pulling best practices out of a hat and applying them\n> blindly. We're designing for a Manager interface that is entirely dependent\n> on Javascript. We have numerous critical bugs related to these settings.\n> MODX is all about having control over every character of your code yet if I\n> draft some amazing Javascript how can you ensure me compress_js won't\n> destroy it?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/modxcms/revolution/pull/12538#issuecomment-134771208>.\n>\n"}}