{"action":"opened","number":452,"pull_request":{"url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/452","id":32090794,"html_url":"https://github.com/BabylonJS/Babylon.js/pull/452","diff_url":"https://github.com/BabylonJS/Babylon.js/pull/452.diff","patch_url":"https://github.com/BabylonJS/Babylon.js/pull/452.patch","issue_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/452","number":452,"state":"open","locked":false,"title":"Material onBind callback improvement","user":{"login":"jahow","id":10629150,"avatar_url":"https://avatars.githubusercontent.com/u/10629150?v=3","gravatar_id":"","url":"https://api.github.com/users/jahow","html_url":"https://github.com/jahow","followers_url":"https://api.github.com/users/jahow/followers","following_url":"https://api.github.com/users/jahow/following{/other_user}","gists_url":"https://api.github.com/users/jahow/gists{/gist_id}","starred_url":"https://api.github.com/users/jahow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahow/subscriptions","organizations_url":"https://api.github.com/users/jahow/orgs","repos_url":"https://api.github.com/users/jahow/repos","events_url":"https://api.github.com/users/jahow/events{/privacy}","received_events_url":"https://api.github.com/users/jahow/received_events","type":"User","site_admin":false},"body":"A minor modification that allows this callback to be much more useful.\r\n\r\nBy passing the current mesh as an argument, it is possible to change material/shader parameters according to custom properties.\r\n\r\nI've also changed the ShaderMaterial bind() function since I've noticed it wasn't passing the current mesh as an argument to its parent function.","created_at":"2015-03-27T08:42:01Z","updated_at":"2015-03-27T08:42:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/452/commits","review_comments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/452/comments","review_comment_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/452/comments","statuses_url":"https://api.github.com/repos/BabylonJS/Babylon.js/statuses/4a549390a890cb5637a435ec0bacfa672b0e5a08","head":{"label":"jahow:patch-3","ref":"patch-3","sha":"4a549390a890cb5637a435ec0bacfa672b0e5a08","user":{"login":"jahow","id":10629150,"avatar_url":"https://avatars.githubusercontent.com/u/10629150?v=3","gravatar_id":"","url":"https://api.github.com/users/jahow","html_url":"https://github.com/jahow","followers_url":"https://api.github.com/users/jahow/followers","following_url":"https://api.github.com/users/jahow/following{/other_user}","gists_url":"https://api.github.com/users/jahow/gists{/gist_id}","starred_url":"https://api.github.com/users/jahow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahow/subscriptions","organizations_url":"https://api.github.com/users/jahow/orgs","repos_url":"https://api.github.com/users/jahow/repos","events_url":"https://api.github.com/users/jahow/events{/privacy}","received_events_url":"https://api.github.com/users/jahow/received_events","type":"User","site_admin":false},"repo":{"id":31603001,"name":"Babylon.js","full_name":"jahow/Babylon.js","owner":{"login":"jahow","id":10629150,"avatar_url":"https://avatars.githubusercontent.com/u/10629150?v=3","gravatar_id":"","url":"https://api.github.com/users/jahow","html_url":"https://github.com/jahow","followers_url":"https://api.github.com/users/jahow/followers","following_url":"https://api.github.com/users/jahow/following{/other_user}","gists_url":"https://api.github.com/users/jahow/gists{/gist_id}","starred_url":"https://api.github.com/users/jahow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahow/subscriptions","organizations_url":"https://api.github.com/users/jahow/orgs","repos_url":"https://api.github.com/users/jahow/repos","events_url":"https://api.github.com/users/jahow/events{/privacy}","received_events_url":"https://api.github.com/users/jahow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jahow/Babylon.js","description":"Babylon.js: a complete JavaScript framework for building 3D games with HTML 5 and WebGL","fork":true,"url":"https://api.github.com/repos/jahow/Babylon.js","forks_url":"https://api.github.com/repos/jahow/Babylon.js/forks","keys_url":"https://api.github.com/repos/jahow/Babylon.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jahow/Babylon.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jahow/Babylon.js/teams","hooks_url":"https://api.github.com/repos/jahow/Babylon.js/hooks","issue_events_url":"https://api.github.com/repos/jahow/Babylon.js/issues/events{/number}","events_url":"https://api.github.com/repos/jahow/Babylon.js/events","assignees_url":"https://api.github.com/repos/jahow/Babylon.js/assignees{/user}","branches_url":"https://api.github.com/repos/jahow/Babylon.js/branches{/branch}","tags_url":"https://api.github.com/repos/jahow/Babylon.js/tags","blobs_url":"https://api.github.com/repos/jahow/Babylon.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jahow/Babylon.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jahow/Babylon.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/jahow/Babylon.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jahow/Babylon.js/statuses/{sha}","languages_url":"https://api.github.com/repos/jahow/Babylon.js/languages","stargazers_url":"https://api.github.com/repos/jahow/Babylon.js/stargazers","contributors_url":"https://api.github.com/repos/jahow/Babylon.js/contributors","subscribers_url":"https://api.github.com/repos/jahow/Babylon.js/subscribers","subscription_url":"https://api.github.com/repos/jahow/Babylon.js/subscription","commits_url":"https://api.github.com/repos/jahow/Babylon.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/jahow/Babylon.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/jahow/Babylon.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/jahow/Babylon.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/jahow/Babylon.js/contents/{+path}","compare_url":"https://api.github.com/repos/jahow/Babylon.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jahow/Babylon.js/merges","archive_url":"https://api.github.com/repos/jahow/Babylon.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jahow/Babylon.js/downloads","issues_url":"https://api.github.com/repos/jahow/Babylon.js/issues{/number}","pulls_url":"https://api.github.com/repos/jahow/Babylon.js/pulls{/number}","milestones_url":"https://api.github.com/repos/jahow/Babylon.js/milestones{/number}","notifications_url":"https://api.github.com/repos/jahow/Babylon.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jahow/Babylon.js/labels{/name}","releases_url":"https://api.github.com/repos/jahow/Babylon.js/releases{/id}","created_at":"2015-03-03T14:39:13Z","updated_at":"2015-03-27T07:39:21Z","pushed_at":"2015-03-27T08:39:10Z","git_url":"git://github.com/jahow/Babylon.js.git","ssh_url":"git@github.com:jahow/Babylon.js.git","clone_url":"https://github.com/jahow/Babylon.js.git","svn_url":"https://github.com/jahow/Babylon.js","homepage":null,"size":416407,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BabylonJS:master","ref":"master","sha":"04b71bc401dd3af358a02f50fa4baf50f9aebee1","user":{"login":"BabylonJS","id":4855800,"avatar_url":"https://avatars.githubusercontent.com/u/4855800?v=3","gravatar_id":"","url":"https://api.github.com/users/BabylonJS","html_url":"https://github.com/BabylonJS","followers_url":"https://api.github.com/users/BabylonJS/followers","following_url":"https://api.github.com/users/BabylonJS/following{/other_user}","gists_url":"https://api.github.com/users/BabylonJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BabylonJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BabylonJS/subscriptions","organizations_url":"https://api.github.com/users/BabylonJS/orgs","repos_url":"https://api.github.com/users/BabylonJS/repos","events_url":"https://api.github.com/users/BabylonJS/events{/privacy}","received_events_url":"https://api.github.com/users/BabylonJS/received_events","type":"Organization","site_admin":false},"repo":{"id":11007313,"name":"Babylon.js","full_name":"BabylonJS/Babylon.js","owner":{"login":"BabylonJS","id":4855800,"avatar_url":"https://avatars.githubusercontent.com/u/4855800?v=3","gravatar_id":"","url":"https://api.github.com/users/BabylonJS","html_url":"https://github.com/BabylonJS","followers_url":"https://api.github.com/users/BabylonJS/followers","following_url":"https://api.github.com/users/BabylonJS/following{/other_user}","gists_url":"https://api.github.com/users/BabylonJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BabylonJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BabylonJS/subscriptions","organizations_url":"https://api.github.com/users/BabylonJS/orgs","repos_url":"https://api.github.com/users/BabylonJS/repos","events_url":"https://api.github.com/users/BabylonJS/events{/privacy}","received_events_url":"https://api.github.com/users/BabylonJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BabylonJS/Babylon.js","description":"Babylon.js: a complete JavaScript framework for building 3D games with HTML 5 and WebGL","fork":false,"url":"https://api.github.com/repos/BabylonJS/Babylon.js","forks_url":"https://api.github.com/repos/BabylonJS/Babylon.js/forks","keys_url":"https://api.github.com/repos/BabylonJS/Babylon.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BabylonJS/Babylon.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BabylonJS/Babylon.js/teams","hooks_url":"https://api.github.com/repos/BabylonJS/Babylon.js/hooks","issue_events_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/events{/number}","events_url":"https://api.github.com/repos/BabylonJS/Babylon.js/events","assignees_url":"https://api.github.com/repos/BabylonJS/Babylon.js/assignees{/user}","branches_url":"https://api.github.com/repos/BabylonJS/Babylon.js/branches{/branch}","tags_url":"https://api.github.com/repos/BabylonJS/Babylon.js/tags","blobs_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BabylonJS/Babylon.js/statuses/{sha}","languages_url":"https://api.github.com/repos/BabylonJS/Babylon.js/languages","stargazers_url":"https://api.github.com/repos/BabylonJS/Babylon.js/stargazers","contributors_url":"https://api.github.com/repos/BabylonJS/Babylon.js/contributors","subscribers_url":"https://api.github.com/repos/BabylonJS/Babylon.js/subscribers","subscription_url":"https://api.github.com/repos/BabylonJS/Babylon.js/subscription","commits_url":"https://api.github.com/repos/BabylonJS/Babylon.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/BabylonJS/Babylon.js/contents/{+path}","compare_url":"https://api.github.com/repos/BabylonJS/Babylon.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BabylonJS/Babylon.js/merges","archive_url":"https://api.github.com/repos/BabylonJS/Babylon.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BabylonJS/Babylon.js/downloads","issues_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues{/number}","pulls_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls{/number}","milestones_url":"https://api.github.com/repos/BabylonJS/Babylon.js/milestones{/number}","notifications_url":"https://api.github.com/repos/BabylonJS/Babylon.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BabylonJS/Babylon.js/labels{/name}","releases_url":"https://api.github.com/repos/BabylonJS/Babylon.js/releases{/id}","created_at":"2013-06-27T20:40:42Z","updated_at":"2015-03-27T03:20:47Z","pushed_at":"2015-03-27T08:42:01Z","git_url":"git://github.com/BabylonJS/Babylon.js.git","ssh_url":"git@github.com:BabylonJS/Babylon.js.git","clone_url":"https://github.com/BabylonJS/Babylon.js.git","svn_url":"https://github.com/BabylonJS/Babylon.js","homepage":null,"size":424570,"stargazers_count":1732,"watchers_count":1732,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":458,"mirror_url":null,"open_issues_count":3,"forks":458,"open_issues":3,"watchers":1732,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/452"},"html":{"href":"https://github.com/BabylonJS/Babylon.js/pull/452"},"issue":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/452"},"comments":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/452/comments"},"review_comments":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/452/comments"},"review_comment":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/452/commits"},"statuses":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/statuses/4a549390a890cb5637a435ec0bacfa672b0e5a08"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":5,"deletions":5,"changed_files":2}}