{"comment":{"url":"https://api.github.com/repos/Nyansa/elasticsearch-rails/comments/13603929","html_url":"https://github.com/Nyansa/elasticsearch-rails/commit/194607b62e64269bc1a1eeec1c52b15187f70c71#commitcomment-13603929","id":13603929,"user":{"login":"jason-nyansa","id":8259538,"avatar_url":"https://avatars.githubusercontent.com/u/8259538?v=3","gravatar_id":"","url":"https://api.github.com/users/jason-nyansa","html_url":"https://github.com/jason-nyansa","followers_url":"https://api.github.com/users/jason-nyansa/followers","following_url":"https://api.github.com/users/jason-nyansa/following{/other_user}","gists_url":"https://api.github.com/users/jason-nyansa/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-nyansa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-nyansa/subscriptions","organizations_url":"https://api.github.com/users/jason-nyansa/orgs","repos_url":"https://api.github.com/users/jason-nyansa/repos","events_url":"https://api.github.com/users/jason-nyansa/events{/privacy}","received_events_url":"https://api.github.com/users/jason-nyansa/received_events","type":"User","site_admin":false},"position":19,"line":28,"path":"elasticsearch-persistence/lib/elasticsearch/persistence/repository/naming.rb","commit_id":"194607b62e64269bc1a1eeec1c52b15187f70c71","created_at":"2015-10-05T23:00:53Z","updated_at":"2015-10-05T23:00:53Z","body":"this is only assigning `name` or the current `@index_name` or the \"local block\" back to `@index_name` right?\r\nI'm talking about the block passed into this method, i.e.:\r\n```\r\nif name || block_given?\r\n  return (@index_name = name || block)\r\n```\r\n\r\nso currently we use index_name this way `index_name { some lazily evaluated code to generate the index name }`\r\nthis block will not be passed in as the parameter `name`, with your change it doesn't seem to assign that block to `@index_name`"}}