{"action":"created","comment":{"url":"https://api.github.com/repos/wso2-dev/andes/pulls/comments/23369751","id":23369751,"diff_hunk":"@@ -565,6 +565,15 @@ public long generateNewMessageId() {\n         return messageId;\n     }\n \n+    /**\n+     * Generate an unique ID.\n+     *\n+     * @return id generated\n+     */\n+    public long generateUniqueId(){\n+        return generateNewMessageId();\n+    }\n+","path":"modules/andes-core/broker/src/main/java/org/wso2/andes/kernel/MessagingEngine.java","position":12,"original_position":12,"commit_id":"811d4e0e78a15325d21d4b8fcd3f1ff8d05e4170","original_commit_id":"78641ec792e40eef6124bd65a68dcea3cc154eaf","user":{"login":"a5anka","id":1148405,"avatar_url":"https://avatars.githubusercontent.com/u/1148405?v=3","gravatar_id":"","url":"https://api.github.com/users/a5anka","html_url":"https://github.com/a5anka","followers_url":"https://api.github.com/users/a5anka/followers","following_url":"https://api.github.com/users/a5anka/following{/other_user}","gists_url":"https://api.github.com/users/a5anka/gists{/gist_id}","starred_url":"https://api.github.com/users/a5anka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a5anka/subscriptions","organizations_url":"https://api.github.com/users/a5anka/orgs","repos_url":"https://api.github.com/users/a5anka/repos","events_url":"https://api.github.com/users/a5anka/events{/privacy}","received_events_url":"https://api.github.com/users/a5anka/received_events","type":"User","site_admin":false},"body":"This method just forward the call to `generateNewMessageId()`. Therefore I think this is not needed. Why do you think we need it? Can't we directly call `generateNewMessageId()`.","created_at":"2015-01-22T11:36:05Z","updated_at":"2015-01-22T11:36:05Z","html_url":"https://github.com/wso2-dev/andes/pull/249#discussion_r23369751","pull_request_url":"https://api.github.com/repos/wso2-dev/andes/pulls/249","_links":{"self":{"href":"https://api.github.com/repos/wso2-dev/andes/pulls/comments/23369751"},"html":{"href":"https://github.com/wso2-dev/andes/pull/249#discussion_r23369751"},"pull_request":{"href":"https://api.github.com/repos/wso2-dev/andes/pulls/249"}}},"pull_request":{"url":"https://api.github.com/repos/wso2-dev/andes/pulls/249","id":27735320,"html_url":"https://github.com/wso2-dev/andes/pull/249","diff_url":"https://github.com/wso2-dev/andes/pull/249.diff","patch_url":"https://github.com/wso2-dev/andes/pull/249.patch","issue_url":"https://api.github.com/repos/wso2-dev/andes/issues/249","number":249,"state":"open","locked":false,"title":"Jms selectors","user":{"login":"madhawa30","id":6748599,"avatar_url":"https://avatars.githubusercontent.com/u/6748599?v=3","gravatar_id":"","url":"https://api.github.com/users/madhawa30","html_url":"https://github.com/madhawa30","followers_url":"https://api.github.com/users/madhawa30/followers","following_url":"https://api.github.com/users/madhawa30/following{/other_user}","gists_url":"https://api.github.com/users/madhawa30/gists{/gist_id}","starred_url":"https://api.github.com/users/madhawa30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhawa30/subscriptions","organizations_url":"https://api.github.com/users/madhawa30/orgs","repos_url":"https://api.github.com/users/madhawa30/repos","events_url":"https://api.github.com/users/madhawa30/events{/privacy}","received_events_url":"https://api.github.com/users/madhawa30/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-21T04:53:17Z","updated_at":"2015-01-22T11:36:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f550e587011d1a54f9ac41c37a1e7cc1e9ff290d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wso2-dev/andes/pulls/249/commits","review_comments_url":"https://api.github.com/repos/wso2-dev/andes/pulls/249/comments","review_comment_url":"https://api.github.com/repos/wso2-dev/andes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wso2-dev/andes/issues/249/comments","statuses_url":"https://api.github.com/repos/wso2-dev/andes/statuses/811d4e0e78a15325d21d4b8fcd3f1ff8d05e4170","head":{"label":"madhawa30:jms-selectors","ref":"jms-selectors","sha":"811d4e0e78a15325d21d4b8fcd3f1ff8d05e4170","user":{"login":"madhawa30","id":6748599,"avatar_url":"https://avatars.githubusercontent.com/u/6748599?v=3","gravatar_id":"","url":"https://api.github.com/users/madhawa30","html_url":"https://github.com/madhawa30","followers_url":"https://api.github.com/users/madhawa30/followers","following_url":"https://api.github.com/users/madhawa30/following{/other_user}","gists_url":"https://api.github.com/users/madhawa30/gists{/gist_id}","starred_url":"https://api.github.com/users/madhawa30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhawa30/subscriptions","organizations_url":"https://api.github.com/users/madhawa30/orgs","repos_url":"https://api.github.com/users/madhawa30/repos","events_url":"https://api.github.com/users/madhawa30/events{/privacy}","received_events_url":"https://api.github.com/users/madhawa30/received_events","type":"User","site_admin":false},"repo":{"id":27473880,"name":"andes","full_name":"madhawa30/andes","owner":{"login":"madhawa30","id":6748599,"avatar_url":"https://avatars.githubusercontent.com/u/6748599?v=3","gravatar_id":"","url":"https://api.github.com/users/madhawa30","html_url":"https://github.com/madhawa30","followers_url":"https://api.github.com/users/madhawa30/followers","following_url":"https://api.github.com/users/madhawa30/following{/other_user}","gists_url":"https://api.github.com/users/madhawa30/gists{/gist_id}","starred_url":"https://api.github.com/users/madhawa30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhawa30/subscriptions","organizations_url":"https://api.github.com/users/madhawa30/orgs","repos_url":"https://api.github.com/users/madhawa30/repos","events_url":"https://api.github.com/users/madhawa30/events{/privacy}","received_events_url":"https://api.github.com/users/madhawa30/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/madhawa30/andes","description":"","fork":true,"url":"https://api.github.com/repos/madhawa30/andes","forks_url":"https://api.github.com/repos/madhawa30/andes/forks","keys_url":"https://api.github.com/repos/madhawa30/andes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madhawa30/andes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madhawa30/andes/teams","hooks_url":"https://api.github.com/repos/madhawa30/andes/hooks","issue_events_url":"https://api.github.com/repos/madhawa30/andes/issues/events{/number}","events_url":"https://api.github.com/repos/madhawa30/andes/events","assignees_url":"https://api.github.com/repos/madhawa30/andes/assignees{/user}","branches_url":"https://api.github.com/repos/madhawa30/andes/branches{/branch}","tags_url":"https://api.github.com/repos/madhawa30/andes/tags","blobs_url":"https://api.github.com/repos/madhawa30/andes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madhawa30/andes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madhawa30/andes/git/refs{/sha}","trees_url":"https://api.github.com/repos/madhawa30/andes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madhawa30/andes/statuses/{sha}","languages_url":"https://api.github.com/repos/madhawa30/andes/languages","stargazers_url":"https://api.github.com/repos/madhawa30/andes/stargazers","contributors_url":"https://api.github.com/repos/madhawa30/andes/contributors","subscribers_url":"https://api.github.com/repos/madhawa30/andes/subscribers","subscription_url":"https://api.github.com/repos/madhawa30/andes/subscription","commits_url":"https://api.github.com/repos/madhawa30/andes/commits{/sha}","git_commits_url":"https://api.github.com/repos/madhawa30/andes/git/commits{/sha}","comments_url":"https://api.github.com/repos/madhawa30/andes/comments{/number}","issue_comment_url":"https://api.github.com/repos/madhawa30/andes/issues/comments/{number}","contents_url":"https://api.github.com/repos/madhawa30/andes/contents/{+path}","compare_url":"https://api.github.com/repos/madhawa30/andes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madhawa30/andes/merges","archive_url":"https://api.github.com/repos/madhawa30/andes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madhawa30/andes/downloads","issues_url":"https://api.github.com/repos/madhawa30/andes/issues{/number}","pulls_url":"https://api.github.com/repos/madhawa30/andes/pulls{/number}","milestones_url":"https://api.github.com/repos/madhawa30/andes/milestones{/number}","notifications_url":"https://api.github.com/repos/madhawa30/andes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madhawa30/andes/labels{/name}","releases_url":"https://api.github.com/repos/madhawa30/andes/releases{/id}","created_at":"2014-12-03T06:55:10Z","updated_at":"2014-12-18T10:07:23Z","pushed_at":"2015-01-22T11:27:27Z","git_url":"git://github.com/madhawa30/andes.git","ssh_url":"git@github.com:madhawa30/andes.git","clone_url":"https://github.com/madhawa30/andes.git","svn_url":"https://github.com/madhawa30/andes","homepage":null,"size":63615,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2-dev:master","ref":"master","sha":"3ee1a8a2281ebfbf493e55c5a33b24e3429daf3e","user":{"login":"wso2-dev","id":6744733,"avatar_url":"https://avatars.githubusercontent.com/u/6744733?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2-dev","html_url":"https://github.com/wso2-dev","followers_url":"https://api.github.com/users/wso2-dev/followers","following_url":"https://api.github.com/users/wso2-dev/following{/other_user}","gists_url":"https://api.github.com/users/wso2-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-dev/subscriptions","organizations_url":"https://api.github.com/users/wso2-dev/orgs","repos_url":"https://api.github.com/users/wso2-dev/repos","events_url":"https://api.github.com/users/wso2-dev/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":20559274,"name":"andes","full_name":"wso2-dev/andes","owner":{"login":"wso2-dev","id":6744733,"avatar_url":"https://avatars.githubusercontent.com/u/6744733?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2-dev","html_url":"https://github.com/wso2-dev","followers_url":"https://api.github.com/users/wso2-dev/followers","following_url":"https://api.github.com/users/wso2-dev/following{/other_user}","gists_url":"https://api.github.com/users/wso2-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-dev/subscriptions","organizations_url":"https://api.github.com/users/wso2-dev/orgs","repos_url":"https://api.github.com/users/wso2-dev/repos","events_url":"https://api.github.com/users/wso2-dev/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2-dev/andes","description":"","fork":true,"url":"https://api.github.com/repos/wso2-dev/andes","forks_url":"https://api.github.com/repos/wso2-dev/andes/forks","keys_url":"https://api.github.com/repos/wso2-dev/andes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2-dev/andes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2-dev/andes/teams","hooks_url":"https://api.github.com/repos/wso2-dev/andes/hooks","issue_events_url":"https://api.github.com/repos/wso2-dev/andes/issues/events{/number}","events_url":"https://api.github.com/repos/wso2-dev/andes/events","assignees_url":"https://api.github.com/repos/wso2-dev/andes/assignees{/user}","branches_url":"https://api.github.com/repos/wso2-dev/andes/branches{/branch}","tags_url":"https://api.github.com/repos/wso2-dev/andes/tags","blobs_url":"https://api.github.com/repos/wso2-dev/andes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2-dev/andes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2-dev/andes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2-dev/andes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2-dev/andes/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2-dev/andes/languages","stargazers_url":"https://api.github.com/repos/wso2-dev/andes/stargazers","contributors_url":"https://api.github.com/repos/wso2-dev/andes/contributors","subscribers_url":"https://api.github.com/repos/wso2-dev/andes/subscribers","subscription_url":"https://api.github.com/repos/wso2-dev/andes/subscription","commits_url":"https://api.github.com/repos/wso2-dev/andes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2-dev/andes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2-dev/andes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2-dev/andes/issues/comments/{number}","contents_url":"https://api.github.com/repos/wso2-dev/andes/contents/{+path}","compare_url":"https://api.github.com/repos/wso2-dev/andes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2-dev/andes/merges","archive_url":"https://api.github.com/repos/wso2-dev/andes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2-dev/andes/downloads","issues_url":"https://api.github.com/repos/wso2-dev/andes/issues{/number}","pulls_url":"https://api.github.com/repos/wso2-dev/andes/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2-dev/andes/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2-dev/andes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2-dev/andes/labels{/name}","releases_url":"https://api.github.com/repos/wso2-dev/andes/releases{/id}","created_at":"2014-06-06T10:04:30Z","updated_at":"2015-01-21T18:11:19Z","pushed_at":"2015-01-21T18:11:19Z","git_url":"git://github.com/wso2-dev/andes.git","ssh_url":"git@github.com:wso2-dev/andes.git","clone_url":"https://github.com/wso2-dev/andes.git","svn_url":"https://github.com/wso2-dev/andes","homepage":null,"size":65417,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":5,"forks":21,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2-dev/andes/pulls/249"},"html":{"href":"https://github.com/wso2-dev/andes/pull/249"},"issue":{"href":"https://api.github.com/repos/wso2-dev/andes/issues/249"},"comments":{"href":"https://api.github.com/repos/wso2-dev/andes/issues/249/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2-dev/andes/pulls/249/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2-dev/andes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wso2-dev/andes/pulls/249/commits"},"statuses":{"href":"https://api.github.com/repos/wso2-dev/andes/statuses/811d4e0e78a15325d21d4b8fcd3f1ff8d05e4170"}}}}