{"action":"closed","number":44,"pull_request":{"url":"https://api.github.com/repos/petitparser/dart-petitparser/pulls/44","id":28806057,"html_url":"https://github.com/petitparser/dart-petitparser/pull/44","diff_url":"https://github.com/petitparser/dart-petitparser/pull/44.diff","patch_url":"https://github.com/petitparser/dart-petitparser/pull/44.patch","issue_url":"https://api.github.com/repos/petitparser/dart-petitparser/issues/44","number":44,"state":"closed","locked":false,"title":"Rename local variable","user":{"login":"mindplay-dk","id":103348,"avatar_url":"https://avatars.githubusercontent.com/u/103348?v=3","gravatar_id":"","url":"https://api.github.com/users/mindplay-dk","html_url":"https://github.com/mindplay-dk","followers_url":"https://api.github.com/users/mindplay-dk/followers","following_url":"https://api.github.com/users/mindplay-dk/following{/other_user}","gists_url":"https://api.github.com/users/mindplay-dk/gists{/gist_id}","starred_url":"https://api.github.com/users/mindplay-dk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindplay-dk/subscriptions","organizations_url":"https://api.github.com/users/mindplay-dk/orgs","repos_url":"https://api.github.com/users/mindplay-dk/repos","events_url":"https://api.github.com/users/mindplay-dk/events{/privacy}","received_events_url":"https://api.github.com/users/mindplay-dk/received_events","type":"User","site_admin":false},"body":"Two variables with the same name in the same scope? Ouch!\r\n\r\nI know you can get away with this in Dart, but... this just cost me half a day of debugging and tracing through the code, and was the cause of a major bug in my PHP port, where the argument `parser` was being overwritten by the variable `parser` ... ouch! ;-)\r\n\r\nMaybe pass this on to the Dart IDE team? It really would make sense to get a warning in the IDE when doing this. I'm pretty sure you didn't do that deliberately? And it's probably not considered good practice? There are benefits to locally scoped variables, but ambiguous symbols is not one of them ;-)","created_at":"2015-02-06T12:49:22Z","updated_at":"2015-02-08T08:41:31Z","closed_at":"2015-02-08T08:41:31Z","merged_at":"2015-02-08T08:41:31Z","merge_commit_sha":"a8b0f50198c44ed0e0e71d9ed7ef9988012888a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/petitparser/dart-petitparser/pulls/44/commits","review_comments_url":"https://api.github.com/repos/petitparser/dart-petitparser/pulls/44/comments","review_comment_url":"https://api.github.com/repos/petitparser/dart-petitparser/pulls/comments/{number}","comments_url":"https://api.github.com/repos/petitparser/dart-petitparser/issues/44/comments","statuses_url":"https://api.github.com/repos/petitparser/dart-petitparser/statuses/84378209cdc225be18c11f1aeac79c198d86c6a9","head":{"label":"mindplay-dk:patch-1","ref":"patch-1","sha":"84378209cdc225be18c11f1aeac79c198d86c6a9","user":{"login":"mindplay-dk","id":103348,"avatar_url":"https://avatars.githubusercontent.com/u/103348?v=3","gravatar_id":"","url":"https://api.github.com/users/mindplay-dk","html_url":"https://github.com/mindplay-dk","followers_url":"https://api.github.com/users/mindplay-dk/followers","following_url":"https://api.github.com/users/mindplay-dk/following{/other_user}","gists_url":"https://api.github.com/users/mindplay-dk/gists{/gist_id}","starred_url":"https://api.github.com/users/mindplay-dk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindplay-dk/subscriptions","organizations_url":"https://api.github.com/users/mindplay-dk/orgs","repos_url":"https://api.github.com/users/mindplay-dk/repos","events_url":"https://api.github.com/users/mindplay-dk/events{/privacy}","received_events_url":"https://api.github.com/users/mindplay-dk/received_events","type":"User","site_admin":false},"repo":{"id":30411739,"name":"dart-petitparser","full_name":"mindplay-dk/dart-petitparser","owner":{"login":"mindplay-dk","id":103348,"avatar_url":"https://avatars.githubusercontent.com/u/103348?v=3","gravatar_id":"","url":"https://api.github.com/users/mindplay-dk","html_url":"https://github.com/mindplay-dk","followers_url":"https://api.github.com/users/mindplay-dk/followers","following_url":"https://api.github.com/users/mindplay-dk/following{/other_user}","gists_url":"https://api.github.com/users/mindplay-dk/gists{/gist_id}","starred_url":"https://api.github.com/users/mindplay-dk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindplay-dk/subscriptions","organizations_url":"https://api.github.com/users/mindplay-dk/orgs","repos_url":"https://api.github.com/users/mindplay-dk/repos","events_url":"https://api.github.com/users/mindplay-dk/events{/privacy}","received_events_url":"https://api.github.com/users/mindplay-dk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mindplay-dk/dart-petitparser","description":"Dynamic Grammars in Dart","fork":true,"url":"https://api.github.com/repos/mindplay-dk/dart-petitparser","forks_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/forks","keys_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/teams","hooks_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/hooks","issue_events_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/issues/events{/number}","events_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/events","assignees_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/assignees{/user}","branches_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/branches{/branch}","tags_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/tags","blobs_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/git/refs{/sha}","trees_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/statuses/{sha}","languages_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/languages","stargazers_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/stargazers","contributors_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/contributors","subscribers_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/subscribers","subscription_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/subscription","commits_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/commits{/sha}","git_commits_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/git/commits{/sha}","comments_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/comments{/number}","issue_comment_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/issues/comments/{number}","contents_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/contents/{+path}","compare_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/merges","archive_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/downloads","issues_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/issues{/number}","pulls_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/pulls{/number}","milestones_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/milestones{/number}","notifications_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/labels{/name}","releases_url":"https://api.github.com/repos/mindplay-dk/dart-petitparser/releases{/id}","created_at":"2015-02-06T12:43:35Z","updated_at":"2015-02-06T12:43:35Z","pushed_at":"2015-02-06T12:49:00Z","git_url":"git://github.com/mindplay-dk/dart-petitparser.git","ssh_url":"git@github.com:mindplay-dk/dart-petitparser.git","clone_url":"https://github.com/mindplay-dk/dart-petitparser.git","svn_url":"https://github.com/mindplay-dk/dart-petitparser","homepage":"","size":893,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"petitparser:master","ref":"master","sha":"3ba18393343977780a155277310dddfa2c3caa4d","user":{"login":"petitparser","id":9660699,"avatar_url":"https://avatars.githubusercontent.com/u/9660699?v=3","gravatar_id":"","url":"https://api.github.com/users/petitparser","html_url":"https://github.com/petitparser","followers_url":"https://api.github.com/users/petitparser/followers","following_url":"https://api.github.com/users/petitparser/following{/other_user}","gists_url":"https://api.github.com/users/petitparser/gists{/gist_id}","starred_url":"https://api.github.com/users/petitparser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petitparser/subscriptions","organizations_url":"https://api.github.com/users/petitparser/orgs","repos_url":"https://api.github.com/users/petitparser/repos","events_url":"https://api.github.com/users/petitparser/events{/privacy}","received_events_url":"https://api.github.com/users/petitparser/received_events","type":"Organization","site_admin":false},"repo":{"id":4460928,"name":"dart-petitparser","full_name":"petitparser/dart-petitparser","owner":{"login":"petitparser","id":9660699,"avatar_url":"https://avatars.githubusercontent.com/u/9660699?v=3","gravatar_id":"","url":"https://api.github.com/users/petitparser","html_url":"https://github.com/petitparser","followers_url":"https://api.github.com/users/petitparser/followers","following_url":"https://api.github.com/users/petitparser/following{/other_user}","gists_url":"https://api.github.com/users/petitparser/gists{/gist_id}","starred_url":"https://api.github.com/users/petitparser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petitparser/subscriptions","organizations_url":"https://api.github.com/users/petitparser/orgs","repos_url":"https://api.github.com/users/petitparser/repos","events_url":"https://api.github.com/users/petitparser/events{/privacy}","received_events_url":"https://api.github.com/users/petitparser/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/petitparser/dart-petitparser","description":"Dynamic Grammars in Dart","fork":false,"url":"https://api.github.com/repos/petitparser/dart-petitparser","forks_url":"https://api.github.com/repos/petitparser/dart-petitparser/forks","keys_url":"https://api.github.com/repos/petitparser/dart-petitparser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petitparser/dart-petitparser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petitparser/dart-petitparser/teams","hooks_url":"https://api.github.com/repos/petitparser/dart-petitparser/hooks","issue_events_url":"https://api.github.com/repos/petitparser/dart-petitparser/issues/events{/number}","events_url":"https://api.github.com/repos/petitparser/dart-petitparser/events","assignees_url":"https://api.github.com/repos/petitparser/dart-petitparser/assignees{/user}","branches_url":"https://api.github.com/repos/petitparser/dart-petitparser/branches{/branch}","tags_url":"https://api.github.com/repos/petitparser/dart-petitparser/tags","blobs_url":"https://api.github.com/repos/petitparser/dart-petitparser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petitparser/dart-petitparser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petitparser/dart-petitparser/git/refs{/sha}","trees_url":"https://api.github.com/repos/petitparser/dart-petitparser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petitparser/dart-petitparser/statuses/{sha}","languages_url":"https://api.github.com/repos/petitparser/dart-petitparser/languages","stargazers_url":"https://api.github.com/repos/petitparser/dart-petitparser/stargazers","contributors_url":"https://api.github.com/repos/petitparser/dart-petitparser/contributors","subscribers_url":"https://api.github.com/repos/petitparser/dart-petitparser/subscribers","subscription_url":"https://api.github.com/repos/petitparser/dart-petitparser/subscription","commits_url":"https://api.github.com/repos/petitparser/dart-petitparser/commits{/sha}","git_commits_url":"https://api.github.com/repos/petitparser/dart-petitparser/git/commits{/sha}","comments_url":"https://api.github.com/repos/petitparser/dart-petitparser/comments{/number}","issue_comment_url":"https://api.github.com/repos/petitparser/dart-petitparser/issues/comments/{number}","contents_url":"https://api.github.com/repos/petitparser/dart-petitparser/contents/{+path}","compare_url":"https://api.github.com/repos/petitparser/dart-petitparser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petitparser/dart-petitparser/merges","archive_url":"https://api.github.com/repos/petitparser/dart-petitparser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petitparser/dart-petitparser/downloads","issues_url":"https://api.github.com/repos/petitparser/dart-petitparser/issues{/number}","pulls_url":"https://api.github.com/repos/petitparser/dart-petitparser/pulls{/number}","milestones_url":"https://api.github.com/repos/petitparser/dart-petitparser/milestones{/number}","notifications_url":"https://api.github.com/repos/petitparser/dart-petitparser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petitparser/dart-petitparser/labels{/name}","releases_url":"https://api.github.com/repos/petitparser/dart-petitparser/releases{/id}","created_at":"2012-05-27T09:28:10Z","updated_at":"2015-01-27T07:08:13Z","pushed_at":"2015-02-08T08:41:31Z","git_url":"git://github.com/petitparser/dart-petitparser.git","ssh_url":"git@github.com:petitparser/dart-petitparser.git","clone_url":"https://github.com/petitparser/dart-petitparser.git","svn_url":"https://github.com/petitparser/dart-petitparser","homepage":"","size":1851,"stargazers_count":46,"watchers_count":46,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":3,"forks":12,"open_issues":3,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/petitparser/dart-petitparser/pulls/44"},"html":{"href":"https://github.com/petitparser/dart-petitparser/pull/44"},"issue":{"href":"https://api.github.com/repos/petitparser/dart-petitparser/issues/44"},"comments":{"href":"https://api.github.com/repos/petitparser/dart-petitparser/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/petitparser/dart-petitparser/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/petitparser/dart-petitparser/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/petitparser/dart-petitparser/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/petitparser/dart-petitparser/statuses/84378209cdc225be18c11f1aeac79c198d86c6a9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"renggli","id":131610,"avatar_url":"https://avatars.githubusercontent.com/u/131610?v=3","gravatar_id":"","url":"https://api.github.com/users/renggli","html_url":"https://github.com/renggli","followers_url":"https://api.github.com/users/renggli/followers","following_url":"https://api.github.com/users/renggli/following{/other_user}","gists_url":"https://api.github.com/users/renggli/gists{/gist_id}","starred_url":"https://api.github.com/users/renggli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renggli/subscriptions","organizations_url":"https://api.github.com/users/renggli/orgs","repos_url":"https://api.github.com/users/renggli/repos","events_url":"https://api.github.com/users/renggli/events{/privacy}","received_events_url":"https://api.github.com/users/renggli/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}