{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/7068","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/7068/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/7068/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/7068/events","html_url":"https://github.com/xbmc/xbmc/pull/7068","id":73321218,"number":7068,"title":"[messenger] fix wrong parameter usage for TMSG_GUI_WINDOW_CLOSE","user":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Fix","name":"Fix","color":"02e10c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-05T13:53:24Z","updated_at":"2015-05-05T14:01:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/7068","html_url":"https://github.com/xbmc/xbmc/pull/7068","diff_url":"https://github.com/xbmc/xbmc/pull/7068.diff","patch_url":"https://github.com/xbmc/xbmc/pull/7068.patch"},"body":"I've spotted this while I'm working on something other. We use the wrong parameter from the ThreadMessage in case we call close for a window.\r\n\r\n`param2` is used to hold the corresponding value, see\r\nhttps://github.com/xhaggi/xbmc/blob/7e3e9bb783714485b6785dc0787fb93eb18727de/xbmc/ApplicationMessenger.cpp#L1254\r\n\r\n@Montellese @mkortstiege mind taking a look"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/99086306","html_url":"https://github.com/xbmc/xbmc/pull/7068#issuecomment-99086306","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/7068","id":99086306,"user":{"login":"xhaggi","id":1878991,"avatar_url":"https://avatars.githubusercontent.com/u/1878991?v=3","gravatar_id":"","url":"https://api.github.com/users/xhaggi","html_url":"https://github.com/xhaggi","followers_url":"https://api.github.com/users/xhaggi/followers","following_url":"https://api.github.com/users/xhaggi/following{/other_user}","gists_url":"https://api.github.com/users/xhaggi/gists{/gist_id}","starred_url":"https://api.github.com/users/xhaggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhaggi/subscriptions","organizations_url":"https://api.github.com/users/xhaggi/orgs","repos_url":"https://api.github.com/users/xhaggi/repos","events_url":"https://api.github.com/users/xhaggi/events{/privacy}","received_events_url":"https://api.github.com/users/xhaggi/received_events","type":"User","site_admin":false},"created_at":"2015-05-05T14:01:44Z","updated_at":"2015-05-05T14:01:44Z","body":"@FernetMenta ping you too because I'm not sure who maintains the app messenger."}}