{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin-solutions/multibit-hd/issues/371","labels_url":"https://api.github.com/repos/bitcoin-solutions/multibit-hd/issues/371/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin-solutions/multibit-hd/issues/371/comments","events_url":"https://api.github.com/repos/bitcoin-solutions/multibit-hd/issues/371/events","html_url":"https://github.com/bitcoin-solutions/multibit-hd/issues/371","id":55415285,"number":371,"title":"Verify signed transaction from Trezor is the same as original","user":{"login":"gary-rowe","id":342133,"avatar_url":"https://avatars.githubusercontent.com/u/342133?v=3","gravatar_id":"","url":"https://api.github.com/users/gary-rowe","html_url":"https://github.com/gary-rowe","followers_url":"https://api.github.com/users/gary-rowe/followers","following_url":"https://api.github.com/users/gary-rowe/following{/other_user}","gists_url":"https://api.github.com/users/gary-rowe/gists{/gist_id}","starred_url":"https://api.github.com/users/gary-rowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gary-rowe/subscriptions","organizations_url":"https://api.github.com/users/gary-rowe/orgs","repos_url":"https://api.github.com/users/gary-rowe/repos","events_url":"https://api.github.com/users/gary-rowe/events{/privacy}","received_events_url":"https://api.github.com/users/gary-rowe/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin-solutions/multibit-hd/labels/awaiting%20review","name":"awaiting review","color":"fbca04"},{"url":"https://api.github.com/repos/bitcoin-solutions/multibit-hd/labels/trezor","name":"trezor","color":"bfe5bf"}],"state":"closed","locked":false,"assignee":{"login":"jim618","id":919427,"avatar_url":"https://avatars.githubusercontent.com/u/919427?v=3","gravatar_id":"","url":"https://api.github.com/users/jim618","html_url":"https://github.com/jim618","followers_url":"https://api.github.com/users/jim618/followers","following_url":"https://api.github.com/users/jim618/following{/other_user}","gists_url":"https://api.github.com/users/jim618/gists{/gist_id}","starred_url":"https://api.github.com/users/jim618/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim618/subscriptions","organizations_url":"https://api.github.com/users/jim618/orgs","repos_url":"https://api.github.com/users/jim618/repos","events_url":"https://api.github.com/users/jim618/events{/privacy}","received_events_url":"https://api.github.com/users/jim618/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/bitcoin-solutions/multibit-hd/milestones/7","labels_url":"https://api.github.com/repos/bitcoin-solutions/multibit-hd/milestones/7/labels","id":775499,"number":7,"title":"Beta 5 Trezor","description":"Entry conditions:\r\nPrivate beta 4 is available on the private beta group site or main web site\r\n\r\nExit conditions:\r\nTrezor support is reliable across Window, Mac and Linux. \r\nAround 200 people have successfully used the MVP feature set under a variety of operating systems\r\nNo outstanding issues\r\nThe Beta 5 installer is available on the beta web site\r\n","creator":{"login":"gary-rowe","id":342133,"avatar_url":"https://avatars.githubusercontent.com/u/342133?v=3","gravatar_id":"","url":"https://api.github.com/users/gary-rowe","html_url":"https://github.com/gary-rowe","followers_url":"https://api.github.com/users/gary-rowe/followers","following_url":"https://api.github.com/users/gary-rowe/following{/other_user}","gists_url":"https://api.github.com/users/gary-rowe/gists{/gist_id}","starred_url":"https://api.github.com/users/gary-rowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gary-rowe/subscriptions","organizations_url":"https://api.github.com/users/gary-rowe/orgs","repos_url":"https://api.github.com/users/gary-rowe/repos","events_url":"https://api.github.com/users/gary-rowe/events{/privacy}","received_events_url":"https://api.github.com/users/gary-rowe/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":140,"state":"open","created_at":"2014-09-02T16:25:46Z","updated_at":"2015-01-27T22:45:04Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-01-25T13:12:49Z","updated_at":"2015-01-27T22:45:04Z","closed_at":"2015-01-27T22:45:04Z","body":"We have an opportunity to verify the returned signed transaction from the Trezor to ensure that it contains the same information that we sent. \r\n\r\nThis should detect any tampering on the wire during the send process that the user may miss on the Trezor screen. For example, an opportunistic shifted decimal place for a low value: 0.005432 vs 0.0005432 BTC and/or an additional output to an unknown address.\r\n\r\nOf course this is no defence against a rooted machine but it closes off a potential attack vector for malware."},"comment":{"url":"https://api.github.com/repos/bitcoin-solutions/multibit-hd/issues/comments/71744430","html_url":"https://github.com/bitcoin-solutions/multibit-hd/issues/371#issuecomment-71744430","issue_url":"https://api.github.com/repos/bitcoin-solutions/multibit-hd/issues/371","id":71744430,"user":{"login":"gary-rowe","id":342133,"avatar_url":"https://avatars.githubusercontent.com/u/342133?v=3","gravatar_id":"","url":"https://api.github.com/users/gary-rowe","html_url":"https://github.com/gary-rowe","followers_url":"https://api.github.com/users/gary-rowe/followers","following_url":"https://api.github.com/users/gary-rowe/following{/other_user}","gists_url":"https://api.github.com/users/gary-rowe/gists{/gist_id}","starred_url":"https://api.github.com/users/gary-rowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gary-rowe/subscriptions","organizations_url":"https://api.github.com/users/gary-rowe/orgs","repos_url":"https://api.github.com/users/gary-rowe/repos","events_url":"https://api.github.com/users/gary-rowe/events{/privacy}","received_events_url":"https://api.github.com/users/gary-rowe/received_events","type":"User","site_admin":false},"created_at":"2015-01-27T22:45:03Z","updated_at":"2015-01-27T22:45:03Z","body":"Code reviewed in MultiBit HD and Hardware and the code looks thorough. I made a small formatting change to improve clarity but otherwise it's all good.\r\n\r\nClosing."}}