{"action":"closed","number":8038,"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/8038","id":28603212,"html_url":"https://github.com/Baystation12/Baystation12/pull/8038","diff_url":"https://github.com/Baystation12/Baystation12/pull/8038.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/8038.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/8038","number":8038,"state":"closed","locked":false,"title":"Hydroponics rewrite, kitchen changes.","user":{"login":"Zuhayr","id":2468979,"avatar_url":"https://avatars.githubusercontent.com/u/2468979?v=3","gravatar_id":"","url":"https://api.github.com/users/Zuhayr","html_url":"https://github.com/Zuhayr","followers_url":"https://api.github.com/users/Zuhayr/followers","following_url":"https://api.github.com/users/Zuhayr/following{/other_user}","gists_url":"https://api.github.com/users/Zuhayr/gists{/gist_id}","starred_url":"https://api.github.com/users/Zuhayr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zuhayr/subscriptions","organizations_url":"https://api.github.com/users/Zuhayr/orgs","repos_url":"https://api.github.com/users/Zuhayr/repos","events_url":"https://api.github.com/users/Zuhayr/events{/privacy}","received_events_url":"https://api.github.com/users/Zuhayr/received_events","type":"User","site_admin":false},"body":"*Reopening #7971 because of a misguided --force push. Will update when I get back tonight.*\r\nImages in this gallery: http://imgur.com/a/BTtYT\r\n\r\n**XENOBOTANY**\r\n- Xenobotanist is now a subtype of Xenobiologist rather than Scientist.\r\n- Xenobiologist slots increased by 1, Scientist slots dropped by 1.\r\n- The plant scanner can print a plant report.\r\n- Plants now have twelve genes, up from six.\r\n- Hydroponics trays will now automatically update their name with a currently growing plant descriptor.\r\n- Hydroponics trays can be labelled.\r\n- Hydroponics trays can now be examined at any distance to see their properties. Examining them from an adjacent square replaces the clicking with empty hand behavior.\r\n- Hydroponics trays can be opened or closed with alt-click.\r\n\r\n**VERBS**\r\n- Spawn Fruit and Spawn Plant verbs added for debugging.\r\n\r\n**PLANTS**\r\n- Plants no longer die of old age.\r\n- Plant, vine and fruit icons are now built on the fly from greyscale version of a number of existing icons.\r\n- Plants with spread 2 can be planted outside of trays to form a spreading plant with size based on potency.\r\n- Several new seed traits have been converted from hardcoded fruit powers - juicy for the tomato splatter behavior, stinging for reworked nettle behaviour, and teleporting for the bluespace tomato behaviour.\r\n- An explosive trait has been added.\r\n\r\n**PLANT MOBS**\r\n- All mobs produced by plants search for a player with BE_DIONA ticked.\r\n- Mob-producing plants have a chance of self-harvesting.\r\n- Walking mushrooms can now detonate to create a spreading plant version of their parent seed.\r\n\r\n**VINES AND BIOMASS**\r\n- Vines are now processed by a dedicated controller, which also contains various global lists and vars.\r\n- Vines and biomass have been unified and entirely rewritten.\r\n- Vines now use seed data more effectively and have multiple icon types (vines, biomass, mold and writhing worms).\r\n- Carnivorous vines can eat mice and lizards.\r\n- Vines of a certain potency will now grab mobs from adjacent squares, making them more dangerous to fight.\r\n- Treading on vines will sting you if your feet are bare, and being grabbed by them will sting you period.\r\n\r\n**REFACTORING**\r\n- Deleted unused distillery code as it is no longer compatible with plantcode and is unused.\r\n- Quite a bit of plant file splitting-up and reorganising.\r\n- The seed datum now handles gas exchange and light checks rather than the hydroponics tray.\r\n- All grown plant products are unified under the same item definition.\r\n- All grown plants now include their product reagents as part of the fruit object, rather than through juicer/processor magic.\r\n- Seed traits have been refactored to work in a more modular and easy to change fashion.\r\n- Minor Enter() wet floor/shoe honking code refactoring.\r\n- Deleted an unticked and accidentally included WIP file from the mining asteroid generation code.\r\n\r\n**KITCHEN**\r\n- Ketchup is now made from two parts tomato juice, one part water and one part sugar.\r\n- The reagent processor now only has one option, grind, and converts anything containing reagents into a reagent soup.\r\n- Quite a few icon changes and shuffle-arounds.\r\n- Recipes now make use a kitchen_tag var on fruits instead of specific fruit object types.\r\n- Kitchen recipes have a new list, fruit, which is an assoc list with a fruit type (corresponding to kitchen_tag) and a quantity.\r\n- Flour is a reagent again. Grind wheat to produce it.\r\n- The food processor has been removed.\r\n- Meatballs are now made by mixing protein (from grinding meat) and flour.\r\n- Carrot sticks and potato fries are made from slicing up carrots and potatoes respectively.\r\n- Slime jelly is now a reagent in all slime extracts. Grinding up a slime extract will allow you to harvest it.\r\n- Eggs can be broken into containers or ground up to produce the egg reagent.\r\n- Dough is made from mixing egg and flour.\r\n- Spaghetti is made from slicing up dough, then slicing the dough slices. This is the best I can do without a pasta press.\r\n- A basic cake is now 5 milk, 15 flour, 15 sugar, and 9 egg.\r\n- An apple cake requires an additional 2 apples.\r\n- Lemon, lime and orange cakes require 1 of the respective fruit and 3 of the respective juice. They also need only 5 sugar.\r\n- Chocolate cakes require 1 chocolate bar and 4 units of cocoa. As above, only needs 5 sugar.\r\n- Birthday cakes require a cake hat.\r\n- Brain cakes require a brain.\r\n- Cheesecake requires two wedges of cheese.\r\n- Monkey's delight, apple tart, soylent viridians, soylent green, pumpkin pie and fish fingers now require 10 flour instead of bags.\r\n- Plump helmet biscuits now require 5 flour instead of a bag.\r\n\r\n**NOT BEING ADDED IN THIS PR**\r\n- Add the capacity for conductive vines to draw power from wiring they are covering to cause electrical shocks.\r\n- Add the capacity for fruits to be converted into poultices irrespective of whether or not they are snowflake Tajaran bullshit.\r\n- Allow living mob products to make use of the seed datum for various traits (dionaea too).\r\n- Add random name generator for seeds.\r\n- Alter the grass and wood flooring turfs to take a colour from the planks used to build them, and allow planks to take a colour from the fruit they are created from.\r\n- Rework and relevel all the greyscale icons to be less ugly/codersprite-y.\r\n- Add random seed types to the asteroid at roundstart.\r\n\r\n**TODO**\r\n- [x] Review spreading plant icon updating.\r\n- [x] Review hydroponics tray plant icon updating.\r\n- [x] Unify plant tray/vine attack messages.\r\n- [x] Readd a way to grind mineral sheets into reagents.\r\n- [ ] Test everything extensively.","created_at":"2015-02-04T00:29:52Z","updated_at":"2015-02-24T07:34:08Z","closed_at":"2015-02-24T07:34:08Z","merged_at":"2015-02-24T07:34:08Z","merge_commit_sha":"a9064578deccc7350709eea4e44a762390a7e212","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/8038/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/8038/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/8038/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/8fc4b31238d18171f049950083fb6582d3a97fb5","head":{"label":"Zuhayr:xenohydro","ref":"xenohydro","sha":"8fc4b31238d18171f049950083fb6582d3a97fb5","user":{"login":"Zuhayr","id":2468979,"avatar_url":"https://avatars.githubusercontent.com/u/2468979?v=3","gravatar_id":"","url":"https://api.github.com/users/Zuhayr","html_url":"https://github.com/Zuhayr","followers_url":"https://api.github.com/users/Zuhayr/followers","following_url":"https://api.github.com/users/Zuhayr/following{/other_user}","gists_url":"https://api.github.com/users/Zuhayr/gists{/gist_id}","starred_url":"https://api.github.com/users/Zuhayr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zuhayr/subscriptions","organizations_url":"https://api.github.com/users/Zuhayr/orgs","repos_url":"https://api.github.com/users/Zuhayr/repos","events_url":"https://api.github.com/users/Zuhayr/events{/privacy}","received_events_url":"https://api.github.com/users/Zuhayr/received_events","type":"User","site_admin":false},"repo":{"id":6039946,"name":"Baystation12","full_name":"Zuhayr/Baystation12","owner":{"login":"Zuhayr","id":2468979,"avatar_url":"https://avatars.githubusercontent.com/u/2468979?v=3","gravatar_id":"","url":"https://api.github.com/users/Zuhayr","html_url":"https://github.com/Zuhayr","followers_url":"https://api.github.com/users/Zuhayr/followers","following_url":"https://api.github.com/users/Zuhayr/following{/other_user}","gists_url":"https://api.github.com/users/Zuhayr/gists{/gist_id}","starred_url":"https://api.github.com/users/Zuhayr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zuhayr/subscriptions","organizations_url":"https://api.github.com/users/Zuhayr/orgs","repos_url":"https://api.github.com/users/Zuhayr/repos","events_url":"https://api.github.com/users/Zuhayr/events{/privacy}","received_events_url":"https://api.github.com/users/Zuhayr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zuhayr/Baystation12","description":"The code for Baystation12's branch of SS13. Developers: please don't forget to update the changelog. Thanks!","fork":true,"url":"https://api.github.com/repos/Zuhayr/Baystation12","forks_url":"https://api.github.com/repos/Zuhayr/Baystation12/forks","keys_url":"https://api.github.com/repos/Zuhayr/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zuhayr/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zuhayr/Baystation12/teams","hooks_url":"https://api.github.com/repos/Zuhayr/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Zuhayr/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Zuhayr/Baystation12/events","assignees_url":"https://api.github.com/repos/Zuhayr/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Zuhayr/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Zuhayr/Baystation12/tags","blobs_url":"https://api.github.com/repos/Zuhayr/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zuhayr/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zuhayr/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zuhayr/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zuhayr/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Zuhayr/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Zuhayr/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Zuhayr/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Zuhayr/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Zuhayr/Baystation12/subscription","commits_url":"https://api.github.com/repos/Zuhayr/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zuhayr/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zuhayr/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zuhayr/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zuhayr/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Zuhayr/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zuhayr/Baystation12/merges","archive_url":"https://api.github.com/repos/Zuhayr/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zuhayr/Baystation12/downloads","issues_url":"https://api.github.com/repos/Zuhayr/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Zuhayr/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Zuhayr/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Zuhayr/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zuhayr/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Zuhayr/Baystation12/releases{/id}","created_at":"2012-10-02T04:00:17Z","updated_at":"2015-02-22T05:49:29Z","pushed_at":"2015-02-24T07:32:19Z","git_url":"git://github.com/Zuhayr/Baystation12.git","ssh_url":"git@github.com:Zuhayr/Baystation12.git","clone_url":"https://github.com/Zuhayr/Baystation12.git","svn_url":"https://github.com/Zuhayr/Baystation12","homepage":"http://baystation12.net/","size":724937,"stargazers_count":2,"watchers_count":2,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"Baystation12:dev","ref":"dev","sha":"b73d541c65d0e8b76d95b4bbf11a540f3cf65c35","user":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","created_at":"2011-11-05T16:12:41Z","updated_at":"2015-02-23T21:19:40Z","pushed_at":"2015-02-24T07:34:08Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"git@github.com:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":1247111,"stargazers_count":177,"watchers_count":177,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":699,"mirror_url":null,"open_issues_count":137,"forks":699,"open_issues":137,"watchers":177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/8038"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/8038"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/8038"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/8038/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/8038/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/8038/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/8fc4b31238d18171f049950083fb6582d3a97fb5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"comma","id":1300258,"avatar_url":"https://avatars.githubusercontent.com/u/1300258?v=3","gravatar_id":"","url":"https://api.github.com/users/comma","html_url":"https://github.com/comma","followers_url":"https://api.github.com/users/comma/followers","following_url":"https://api.github.com/users/comma/following{/other_user}","gists_url":"https://api.github.com/users/comma/gists{/gist_id}","starred_url":"https://api.github.com/users/comma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comma/subscriptions","organizations_url":"https://api.github.com/users/comma/orgs","repos_url":"https://api.github.com/users/comma/repos","events_url":"https://api.github.com/users/comma/events{/privacy}","received_events_url":"https://api.github.com/users/comma/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":81,"additions":4240,"deletions":5678,"changed_files":103}}