{"action":"created","comment":{"url":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/comments/43505050","id":43505050,"diff_hunk":"@@ -171,7 +203,7 @@ systemd_loadunit_result(DBusMessage *reply, svc_action_t * op)\n                                DBUS_TYPE_INVALID);\n     }\n \n-    if(op) {\n+    if(op && path) {","path":"lib/services/systemd.c","position":55,"original_position":55,"commit_id":"a861d6c37b9763a5c3c8fce3b53165649956aca7","original_commit_id":"a861d6c37b9763a5c3c8fce3b53165649956aca7","user":{"login":"gao-yan","id":1002242,"avatar_url":"https://avatars.githubusercontent.com/u/1002242?v=3","gravatar_id":"","url":"https://api.github.com/users/gao-yan","html_url":"https://github.com/gao-yan","followers_url":"https://api.github.com/users/gao-yan/followers","following_url":"https://api.github.com/users/gao-yan/following{/other_user}","gists_url":"https://api.github.com/users/gao-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/gao-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gao-yan/subscriptions","organizations_url":"https://api.github.com/users/gao-yan/orgs","repos_url":"https://api.github.com/users/gao-yan/repos","events_url":"https://api.github.com/users/gao-yan/events{/privacy}","received_events_url":"https://api.github.com/users/gao-yan/received_events","type":"User","site_admin":false},"body":"The op->rc is initialized to PCMK_OCF_UNKNOWN_ERROR in systemd_unit_exec() ;-)","created_at":"2015-10-30T14:07:53Z","updated_at":"2015-10-30T14:07:53Z","html_url":"https://github.com/ClusterLabs/pacemaker/pull/824#discussion_r43505050","pull_request_url":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/824","_links":{"self":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/comments/43505050"},"html":{"href":"https://github.com/ClusterLabs/pacemaker/pull/824#discussion_r43505050"},"pull_request":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/824"}}},"pull_request":{"url":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/824","id":49170157,"html_url":"https://github.com/ClusterLabs/pacemaker/pull/824","diff_url":"https://github.com/ClusterLabs/pacemaker/pull/824.diff","patch_url":"https://github.com/ClusterLabs/pacemaker/pull/824.patch","issue_url":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/824","number":824,"state":"open","locked":false,"title":"Fix: systemd: Return PCMK_OCF_UNKNOWN_ERROR instead of PCMK_OCF_NOT_INSTALLED for uncertain errors on LoadUnit","user":{"login":"gao-yan","id":1002242,"avatar_url":"https://avatars.githubusercontent.com/u/1002242?v=3","gravatar_id":"","url":"https://api.github.com/users/gao-yan","html_url":"https://github.com/gao-yan","followers_url":"https://api.github.com/users/gao-yan/followers","following_url":"https://api.github.com/users/gao-yan/following{/other_user}","gists_url":"https://api.github.com/users/gao-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/gao-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gao-yan/subscriptions","organizations_url":"https://api.github.com/users/gao-yan/orgs","repos_url":"https://api.github.com/users/gao-yan/repos","events_url":"https://api.github.com/users/gao-yan/events{/privacy}","received_events_url":"https://api.github.com/users/gao-yan/received_events","type":"User","site_admin":false},"body":"Previously, as long as we could not get the path of the unit via\r\nLoadUnit, it would return PCMK_OCF_NOT_INSTALLED, which is a hard error.\r\n\r\nIt should not return PCMK_OCF_NOT_INSTALLED unless it's sure about that.\r\nFor uncertain errors such as \"org.freedesktop.DBus.Error.NoReply\", it\r\nshould return PCMK_OCF_UNKNOWN_ERROR instead.","created_at":"2015-10-29T17:09:25Z","updated_at":"2015-10-30T14:07:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48a5cabf5aba79fc746eae28053fcf88d2b23584","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/824/commits","review_comments_url":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/824/comments","review_comment_url":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/824/comments","statuses_url":"https://api.github.com/repos/ClusterLabs/pacemaker/statuses/a861d6c37b9763a5c3c8fce3b53165649956aca7","head":{"label":"gao-yan:systemd-loadunit-error","ref":"systemd-loadunit-error","sha":"a861d6c37b9763a5c3c8fce3b53165649956aca7","user":{"login":"gao-yan","id":1002242,"avatar_url":"https://avatars.githubusercontent.com/u/1002242?v=3","gravatar_id":"","url":"https://api.github.com/users/gao-yan","html_url":"https://github.com/gao-yan","followers_url":"https://api.github.com/users/gao-yan/followers","following_url":"https://api.github.com/users/gao-yan/following{/other_user}","gists_url":"https://api.github.com/users/gao-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/gao-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gao-yan/subscriptions","organizations_url":"https://api.github.com/users/gao-yan/orgs","repos_url":"https://api.github.com/users/gao-yan/repos","events_url":"https://api.github.com/users/gao-yan/events{/privacy}","received_events_url":"https://api.github.com/users/gao-yan/received_events","type":"User","site_admin":false},"repo":{"id":2312809,"name":"pacemaker","full_name":"gao-yan/pacemaker","owner":{"login":"gao-yan","id":1002242,"avatar_url":"https://avatars.githubusercontent.com/u/1002242?v=3","gravatar_id":"","url":"https://api.github.com/users/gao-yan","html_url":"https://github.com/gao-yan","followers_url":"https://api.github.com/users/gao-yan/followers","following_url":"https://api.github.com/users/gao-yan/following{/other_user}","gists_url":"https://api.github.com/users/gao-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/gao-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gao-yan/subscriptions","organizations_url":"https://api.github.com/users/gao-yan/orgs","repos_url":"https://api.github.com/users/gao-yan/repos","events_url":"https://api.github.com/users/gao-yan/events{/privacy}","received_events_url":"https://api.github.com/users/gao-yan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gao-yan/pacemaker","description":"Releases containing new features that will end up in Pacemaker","fork":true,"url":"https://api.github.com/repos/gao-yan/pacemaker","forks_url":"https://api.github.com/repos/gao-yan/pacemaker/forks","keys_url":"https://api.github.com/repos/gao-yan/pacemaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gao-yan/pacemaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gao-yan/pacemaker/teams","hooks_url":"https://api.github.com/repos/gao-yan/pacemaker/hooks","issue_events_url":"https://api.github.com/repos/gao-yan/pacemaker/issues/events{/number}","events_url":"https://api.github.com/repos/gao-yan/pacemaker/events","assignees_url":"https://api.github.com/repos/gao-yan/pacemaker/assignees{/user}","branches_url":"https://api.github.com/repos/gao-yan/pacemaker/branches{/branch}","tags_url":"https://api.github.com/repos/gao-yan/pacemaker/tags","blobs_url":"https://api.github.com/repos/gao-yan/pacemaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gao-yan/pacemaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gao-yan/pacemaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/gao-yan/pacemaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gao-yan/pacemaker/statuses/{sha}","languages_url":"https://api.github.com/repos/gao-yan/pacemaker/languages","stargazers_url":"https://api.github.com/repos/gao-yan/pacemaker/stargazers","contributors_url":"https://api.github.com/repos/gao-yan/pacemaker/contributors","subscribers_url":"https://api.github.com/repos/gao-yan/pacemaker/subscribers","subscription_url":"https://api.github.com/repos/gao-yan/pacemaker/subscription","commits_url":"https://api.github.com/repos/gao-yan/pacemaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/gao-yan/pacemaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/gao-yan/pacemaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/gao-yan/pacemaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/gao-yan/pacemaker/contents/{+path}","compare_url":"https://api.github.com/repos/gao-yan/pacemaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gao-yan/pacemaker/merges","archive_url":"https://api.github.com/repos/gao-yan/pacemaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gao-yan/pacemaker/downloads","issues_url":"https://api.github.com/repos/gao-yan/pacemaker/issues{/number}","pulls_url":"https://api.github.com/repos/gao-yan/pacemaker/pulls{/number}","milestones_url":"https://api.github.com/repos/gao-yan/pacemaker/milestones{/number}","notifications_url":"https://api.github.com/repos/gao-yan/pacemaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gao-yan/pacemaker/labels{/name}","releases_url":"https://api.github.com/repos/gao-yan/pacemaker/releases{/id}","created_at":"2011-09-02T08:58:35Z","updated_at":"2015-02-02T10:32:12Z","pushed_at":"2015-10-30T12:32:58Z","git_url":"git://github.com/gao-yan/pacemaker.git","ssh_url":"git@github.com:gao-yan/pacemaker.git","clone_url":"https://github.com/gao-yan/pacemaker.git","svn_url":"https://github.com/gao-yan/pacemaker","homepage":"http://www.clusterlabs.org","size":136831,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"ClusterLabs:master","ref":"master","sha":"908071c49b71a68ed6cb9b00fbce7f9c4e1ce933","user":{"login":"ClusterLabs","id":574912,"avatar_url":"https://avatars.githubusercontent.com/u/574912?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterLabs","html_url":"https://github.com/ClusterLabs","followers_url":"https://api.github.com/users/ClusterLabs/followers","following_url":"https://api.github.com/users/ClusterLabs/following{/other_user}","gists_url":"https://api.github.com/users/ClusterLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterLabs/subscriptions","organizations_url":"https://api.github.com/users/ClusterLabs/orgs","repos_url":"https://api.github.com/users/ClusterLabs/repos","events_url":"https://api.github.com/users/ClusterLabs/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2304962,"name":"pacemaker","full_name":"ClusterLabs/pacemaker","owner":{"login":"ClusterLabs","id":574912,"avatar_url":"https://avatars.githubusercontent.com/u/574912?v=3","gravatar_id":"","url":"https://api.github.com/users/ClusterLabs","html_url":"https://github.com/ClusterLabs","followers_url":"https://api.github.com/users/ClusterLabs/followers","following_url":"https://api.github.com/users/ClusterLabs/following{/other_user}","gists_url":"https://api.github.com/users/ClusterLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/ClusterLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClusterLabs/subscriptions","organizations_url":"https://api.github.com/users/ClusterLabs/orgs","repos_url":"https://api.github.com/users/ClusterLabs/repos","events_url":"https://api.github.com/users/ClusterLabs/events{/privacy}","received_events_url":"https://api.github.com/users/ClusterLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClusterLabs/pacemaker","description":"Pacemaker is an advanced, scalable High-Availability cluster resource manager","fork":false,"url":"https://api.github.com/repos/ClusterLabs/pacemaker","forks_url":"https://api.github.com/repos/ClusterLabs/pacemaker/forks","keys_url":"https://api.github.com/repos/ClusterLabs/pacemaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClusterLabs/pacemaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClusterLabs/pacemaker/teams","hooks_url":"https://api.github.com/repos/ClusterLabs/pacemaker/hooks","issue_events_url":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/events{/number}","events_url":"https://api.github.com/repos/ClusterLabs/pacemaker/events","assignees_url":"https://api.github.com/repos/ClusterLabs/pacemaker/assignees{/user}","branches_url":"https://api.github.com/repos/ClusterLabs/pacemaker/branches{/branch}","tags_url":"https://api.github.com/repos/ClusterLabs/pacemaker/tags","blobs_url":"https://api.github.com/repos/ClusterLabs/pacemaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClusterLabs/pacemaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClusterLabs/pacemaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClusterLabs/pacemaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClusterLabs/pacemaker/statuses/{sha}","languages_url":"https://api.github.com/repos/ClusterLabs/pacemaker/languages","stargazers_url":"https://api.github.com/repos/ClusterLabs/pacemaker/stargazers","contributors_url":"https://api.github.com/repos/ClusterLabs/pacemaker/contributors","subscribers_url":"https://api.github.com/repos/ClusterLabs/pacemaker/subscribers","subscription_url":"https://api.github.com/repos/ClusterLabs/pacemaker/subscription","commits_url":"https://api.github.com/repos/ClusterLabs/pacemaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClusterLabs/pacemaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClusterLabs/pacemaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ClusterLabs/pacemaker/contents/{+path}","compare_url":"https://api.github.com/repos/ClusterLabs/pacemaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClusterLabs/pacemaker/merges","archive_url":"https://api.github.com/repos/ClusterLabs/pacemaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClusterLabs/pacemaker/downloads","issues_url":"https://api.github.com/repos/ClusterLabs/pacemaker/issues{/number}","pulls_url":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls{/number}","milestones_url":"https://api.github.com/repos/ClusterLabs/pacemaker/milestones{/number}","notifications_url":"https://api.github.com/repos/ClusterLabs/pacemaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClusterLabs/pacemaker/labels{/name}","releases_url":"https://api.github.com/repos/ClusterLabs/pacemaker/releases{/id}","created_at":"2011-09-01T00:08:16Z","updated_at":"2015-10-29T06:13:48Z","pushed_at":"2015-10-30T12:29:01Z","git_url":"git://github.com/ClusterLabs/pacemaker.git","ssh_url":"git@github.com:ClusterLabs/pacemaker.git","clone_url":"https://github.com/ClusterLabs/pacemaker.git","svn_url":"https://github.com/ClusterLabs/pacemaker","homepage":"http://www.clusterlabs.org","size":159270,"stargazers_count":262,"watchers_count":262,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":129,"mirror_url":null,"open_issues_count":10,"forks":129,"open_issues":10,"watchers":262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/824"},"html":{"href":"https://github.com/ClusterLabs/pacemaker/pull/824"},"issue":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/824"},"comments":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/issues/824/comments"},"review_comments":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/824/comments"},"review_comment":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/pulls/824/commits"},"statuses":{"href":"https://api.github.com/repos/ClusterLabs/pacemaker/statuses/a861d6c37b9763a5c3c8fce3b53165649956aca7"}}}}