{"action":"created","issue":{"url":"https://api.github.com/repos/okamstudio/godot/issues/2449","labels_url":"https://api.github.com/repos/okamstudio/godot/issues/2449/labels{/name}","comments_url":"https://api.github.com/repos/okamstudio/godot/issues/2449/comments","events_url":"https://api.github.com/repos/okamstudio/godot/issues/2449/events","html_url":"https://github.com/okamstudio/godot/pull/2449","id":105261178,"number":2449,"title":"reworked Label class","user":{"login":"leezh","id":185322,"avatar_url":"https://avatars.githubusercontent.com/u/185322?v=3","gravatar_id":"","url":"https://api.github.com/users/leezh","html_url":"https://github.com/leezh","followers_url":"https://api.github.com/users/leezh/followers","following_url":"https://api.github.com/users/leezh/following{/other_user}","gists_url":"https://api.github.com/users/leezh/gists{/gist_id}","starred_url":"https://api.github.com/users/leezh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leezh/subscriptions","organizations_url":"https://api.github.com/users/leezh/orgs","repos_url":"https://api.github.com/users/leezh/repos","events_url":"https://api.github.com/users/leezh/events{/privacy}","received_events_url":"https://api.github.com/users/leezh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-07T19:38:48Z","updated_at":"2015-09-24T13:18:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/okamstudio/godot/pulls/2449","html_url":"https://github.com/okamstudio/godot/pull/2449","diff_url":"https://github.com/okamstudio/godot/pull/2449.diff","patch_url":"https://github.com/okamstudio/godot/pull/2449.patch"},"body":" - no longer inherits Range - instead, more sensible\r\n   function names controlling lines visible\r\n - more accurate vertical alignment\r\n - percent_visible preserved even after setting new text\r\n\r\nLargely motivated by the frustratingly inaccurate vertical alignment, particularly with large fonts.\r\nBefore: https://gfycat.com/WaterySimpleHornedtoad\r\nAfter: https://gfycat.com/NeighboringMetallicKilldeer\r\n\r\nThe code for controlling the lines visible was already there, but I changed it so that instead of using `set_val()` and `set_max()` you now use `set_lines_skipped()` and `set_max_lines_visible()`.\r\n\r\nAlso, `percent_visible` and `visible_chars` are now recalculated properly each time you use `set_text()` because that could change the total length, and when you use `set_visible_characters()`."},"comment":{"url":"https://api.github.com/repos/okamstudio/godot/issues/comments/142924479","html_url":"https://github.com/okamstudio/godot/pull/2449#issuecomment-142924479","issue_url":"https://api.github.com/repos/okamstudio/godot/issues/2449","id":142924479,"user":{"login":"reduz","id":6265307,"avatar_url":"https://avatars.githubusercontent.com/u/6265307?v=3","gravatar_id":"","url":"https://api.github.com/users/reduz","html_url":"https://github.com/reduz","followers_url":"https://api.github.com/users/reduz/followers","following_url":"https://api.github.com/users/reduz/following{/other_user}","gists_url":"https://api.github.com/users/reduz/gists{/gist_id}","starred_url":"https://api.github.com/users/reduz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reduz/subscriptions","organizations_url":"https://api.github.com/users/reduz/orgs","repos_url":"https://api.github.com/users/reduz/repos","events_url":"https://api.github.com/users/reduz/events{/privacy}","received_events_url":"https://api.github.com/users/reduz/received_events","type":"User","site_admin":false},"created_at":"2015-09-24T13:18:49Z","updated_at":"2015-09-24T13:18:49Z","body":"@akien-mga should I merge or wait for the doc to be updated somewhere else?"}}