{"action":"created","comment":{"url":"https://api.github.com/repos/appc/acbuild/pulls/comments/40789212","id":40789212,"diff_hunk":"@@ -0,0 +1,59 @@\n+// Copyright 2015 The appc Authors\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package main\n+\n+import (\n+\t\"github.com/spf13/cobra\"\n+\n+\t\"github.com/appc/acbuild/libacb\"\n+)\n+\n+var (\n+\tcmdAddAnno = &cobra.Command{\n+\t\tUse:     \"add-anno NAME VALUE\",","path":"acbuild/add-anno.go","position":25,"original_position":25,"commit_id":"cd778b6a5e684f10798cf8a0ff2aef7b0643e393","original_commit_id":"cd778b6a5e684f10798cf8a0ff2aef7b0643e393","user":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"body":"About `command object` vs `object command` I don't have a strong opinion. Given that the command that works on objects are just `add` and `rm` while the objects can be a a lot it'll be more easy to group the objects under them...\r\nWith cobra it's also easy to add subcommands. ","created_at":"2015-09-30T12:53:01Z","updated_at":"2015-09-30T12:53:01Z","html_url":"https://github.com/appc/acbuild/pull/11#discussion_r40789212","pull_request_url":"https://api.github.com/repos/appc/acbuild/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/appc/acbuild/pulls/comments/40789212"},"html":{"href":"https://github.com/appc/acbuild/pull/11#discussion_r40789212"},"pull_request":{"href":"https://api.github.com/repos/appc/acbuild/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/appc/acbuild/pulls/11","id":46319585,"html_url":"https://github.com/appc/acbuild/pull/11","diff_url":"https://github.com/appc/acbuild/pull/11.diff","patch_url":"https://github.com/appc/acbuild/pull/11.patch","issue_url":"https://api.github.com/repos/appc/acbuild/issues/11","number":11,"state":"open","locked":false,"title":"Added initial implementation","user":{"login":"dgonyeo","id":2439413,"avatar_url":"https://avatars.githubusercontent.com/u/2439413?v=3","gravatar_id":"","url":"https://api.github.com/users/dgonyeo","html_url":"https://github.com/dgonyeo","followers_url":"https://api.github.com/users/dgonyeo/followers","following_url":"https://api.github.com/users/dgonyeo/following{/other_user}","gists_url":"https://api.github.com/users/dgonyeo/gists{/gist_id}","starred_url":"https://api.github.com/users/dgonyeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgonyeo/subscriptions","organizations_url":"https://api.github.com/users/dgonyeo/orgs","repos_url":"https://api.github.com/users/dgonyeo/repos","events_url":"https://api.github.com/users/dgonyeo/events{/privacy}","received_events_url":"https://api.github.com/users/dgonyeo/received_events","type":"User","site_admin":false},"body":"There's still a good amount of work to be done on parts of this, but I think it's reached a usable state so I suppose it's a good time to kick this up for review.\r\n\r\nI've deviated some from the README that was written. Notable differences:\r\n- Context-free mode isn't implemented, and the contextual mode behaves a little different\r\n- Exec only supports an un-layered build with overlayfs (overlayfs not required if there are no dependencies)\r\n\r\nWith this implementation the intermediate ACI is stored uncompressed and untarred until `acbuild finish` is called. This results in good performance for every command except `init` and `finish` regardless of ACI size.\r\n\r\nAt this stage the thing I'm least happy about is the way it stores dependencies, and will focus on improving that next. The current method feels very brittle. There are also parts around dependency fetching that need work.\r\n\r\nAn example build script with > 5 steps is available [here](https://github.com/dgonyeo/containers/blob/master/rkt/plex/build-plex.sh).","created_at":"2015-09-29T19:17:31Z","updated_at":"2015-09-30T12:53:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c398165cfc1576a2793cf5d7e7edbb6279d177d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appc/acbuild/pulls/11/commits","review_comments_url":"https://api.github.com/repos/appc/acbuild/pulls/11/comments","review_comment_url":"https://api.github.com/repos/appc/acbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appc/acbuild/issues/11/comments","statuses_url":"https://api.github.com/repos/appc/acbuild/statuses/cd778b6a5e684f10798cf8a0ff2aef7b0643e393","head":{"label":"dgonyeo:master","ref":"master","sha":"cd778b6a5e684f10798cf8a0ff2aef7b0643e393","user":{"login":"dgonyeo","id":2439413,"avatar_url":"https://avatars.githubusercontent.com/u/2439413?v=3","gravatar_id":"","url":"https://api.github.com/users/dgonyeo","html_url":"https://github.com/dgonyeo","followers_url":"https://api.github.com/users/dgonyeo/followers","following_url":"https://api.github.com/users/dgonyeo/following{/other_user}","gists_url":"https://api.github.com/users/dgonyeo/gists{/gist_id}","starred_url":"https://api.github.com/users/dgonyeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgonyeo/subscriptions","organizations_url":"https://api.github.com/users/dgonyeo/orgs","repos_url":"https://api.github.com/users/dgonyeo/repos","events_url":"https://api.github.com/users/dgonyeo/events{/privacy}","received_events_url":"https://api.github.com/users/dgonyeo/received_events","type":"User","site_admin":false},"repo":{"id":43033577,"name":"acbuild","full_name":"dgonyeo/acbuild","owner":{"login":"dgonyeo","id":2439413,"avatar_url":"https://avatars.githubusercontent.com/u/2439413?v=3","gravatar_id":"","url":"https://api.github.com/users/dgonyeo","html_url":"https://github.com/dgonyeo","followers_url":"https://api.github.com/users/dgonyeo/followers","following_url":"https://api.github.com/users/dgonyeo/following{/other_user}","gists_url":"https://api.github.com/users/dgonyeo/gists{/gist_id}","starred_url":"https://api.github.com/users/dgonyeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgonyeo/subscriptions","organizations_url":"https://api.github.com/users/dgonyeo/orgs","repos_url":"https://api.github.com/users/dgonyeo/repos","events_url":"https://api.github.com/users/dgonyeo/events{/privacy}","received_events_url":"https://api.github.com/users/dgonyeo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgonyeo/acbuild","description":"","fork":true,"url":"https://api.github.com/repos/dgonyeo/acbuild","forks_url":"https://api.github.com/repos/dgonyeo/acbuild/forks","keys_url":"https://api.github.com/repos/dgonyeo/acbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgonyeo/acbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgonyeo/acbuild/teams","hooks_url":"https://api.github.com/repos/dgonyeo/acbuild/hooks","issue_events_url":"https://api.github.com/repos/dgonyeo/acbuild/issues/events{/number}","events_url":"https://api.github.com/repos/dgonyeo/acbuild/events","assignees_url":"https://api.github.com/repos/dgonyeo/acbuild/assignees{/user}","branches_url":"https://api.github.com/repos/dgonyeo/acbuild/branches{/branch}","tags_url":"https://api.github.com/repos/dgonyeo/acbuild/tags","blobs_url":"https://api.github.com/repos/dgonyeo/acbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgonyeo/acbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgonyeo/acbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgonyeo/acbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgonyeo/acbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/dgonyeo/acbuild/languages","stargazers_url":"https://api.github.com/repos/dgonyeo/acbuild/stargazers","contributors_url":"https://api.github.com/repos/dgonyeo/acbuild/contributors","subscribers_url":"https://api.github.com/repos/dgonyeo/acbuild/subscribers","subscription_url":"https://api.github.com/repos/dgonyeo/acbuild/subscription","commits_url":"https://api.github.com/repos/dgonyeo/acbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgonyeo/acbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgonyeo/acbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgonyeo/acbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgonyeo/acbuild/contents/{+path}","compare_url":"https://api.github.com/repos/dgonyeo/acbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgonyeo/acbuild/merges","archive_url":"https://api.github.com/repos/dgonyeo/acbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgonyeo/acbuild/downloads","issues_url":"https://api.github.com/repos/dgonyeo/acbuild/issues{/number}","pulls_url":"https://api.github.com/repos/dgonyeo/acbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/dgonyeo/acbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/dgonyeo/acbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgonyeo/acbuild/labels{/name}","releases_url":"https://api.github.com/repos/dgonyeo/acbuild/releases{/id}","created_at":"2015-09-23T23:49:57Z","updated_at":"2015-09-24T00:03:34Z","pushed_at":"2015-09-29T20:52:34Z","git_url":"git://github.com/dgonyeo/acbuild.git","ssh_url":"git@github.com:dgonyeo/acbuild.git","clone_url":"https://github.com/dgonyeo/acbuild.git","svn_url":"https://github.com/dgonyeo/acbuild","homepage":null,"size":157,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appc:master","ref":"master","sha":"965e8dad8718106f905e4995ff110fdaef78b9e4","user":{"login":"appc","id":10080092,"avatar_url":"https://avatars.githubusercontent.com/u/10080092?v=3","gravatar_id":"","url":"https://api.github.com/users/appc","html_url":"https://github.com/appc","followers_url":"https://api.github.com/users/appc/followers","following_url":"https://api.github.com/users/appc/following{/other_user}","gists_url":"https://api.github.com/users/appc/gists{/gist_id}","starred_url":"https://api.github.com/users/appc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appc/subscriptions","organizations_url":"https://api.github.com/users/appc/orgs","repos_url":"https://api.github.com/users/appc/repos","events_url":"https://api.github.com/users/appc/events{/privacy}","received_events_url":"https://api.github.com/users/appc/received_events","type":"Organization","site_admin":false},"repo":{"id":36900260,"name":"acbuild","full_name":"appc/acbuild","owner":{"login":"appc","id":10080092,"avatar_url":"https://avatars.githubusercontent.com/u/10080092?v=3","gravatar_id":"","url":"https://api.github.com/users/appc","html_url":"https://github.com/appc","followers_url":"https://api.github.com/users/appc/followers","following_url":"https://api.github.com/users/appc/following{/other_user}","gists_url":"https://api.github.com/users/appc/gists{/gist_id}","starred_url":"https://api.github.com/users/appc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appc/subscriptions","organizations_url":"https://api.github.com/users/appc/orgs","repos_url":"https://api.github.com/users/appc/repos","events_url":"https://api.github.com/users/appc/events{/privacy}","received_events_url":"https://api.github.com/users/appc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appc/acbuild","description":"","fork":false,"url":"https://api.github.com/repos/appc/acbuild","forks_url":"https://api.github.com/repos/appc/acbuild/forks","keys_url":"https://api.github.com/repos/appc/acbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appc/acbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appc/acbuild/teams","hooks_url":"https://api.github.com/repos/appc/acbuild/hooks","issue_events_url":"https://api.github.com/repos/appc/acbuild/issues/events{/number}","events_url":"https://api.github.com/repos/appc/acbuild/events","assignees_url":"https://api.github.com/repos/appc/acbuild/assignees{/user}","branches_url":"https://api.github.com/repos/appc/acbuild/branches{/branch}","tags_url":"https://api.github.com/repos/appc/acbuild/tags","blobs_url":"https://api.github.com/repos/appc/acbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appc/acbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appc/acbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/appc/acbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appc/acbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/appc/acbuild/languages","stargazers_url":"https://api.github.com/repos/appc/acbuild/stargazers","contributors_url":"https://api.github.com/repos/appc/acbuild/contributors","subscribers_url":"https://api.github.com/repos/appc/acbuild/subscribers","subscription_url":"https://api.github.com/repos/appc/acbuild/subscription","commits_url":"https://api.github.com/repos/appc/acbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/appc/acbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/appc/acbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/appc/acbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/appc/acbuild/contents/{+path}","compare_url":"https://api.github.com/repos/appc/acbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appc/acbuild/merges","archive_url":"https://api.github.com/repos/appc/acbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appc/acbuild/downloads","issues_url":"https://api.github.com/repos/appc/acbuild/issues{/number}","pulls_url":"https://api.github.com/repos/appc/acbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/appc/acbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/appc/acbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appc/acbuild/labels{/name}","releases_url":"https://api.github.com/repos/appc/acbuild/releases{/id}","created_at":"2015-06-04T23:02:32Z","updated_at":"2015-09-24T01:11:29Z","pushed_at":"2015-09-29T20:52:34Z","git_url":"git://github.com/appc/acbuild.git","ssh_url":"git@github.com:appc/acbuild.git","clone_url":"https://github.com/appc/acbuild.git","svn_url":"https://github.com/appc/acbuild","homepage":null,"size":4133,"stargazers_count":13,"watchers_count":13,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appc/acbuild/pulls/11"},"html":{"href":"https://github.com/appc/acbuild/pull/11"},"issue":{"href":"https://api.github.com/repos/appc/acbuild/issues/11"},"comments":{"href":"https://api.github.com/repos/appc/acbuild/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/appc/acbuild/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/appc/acbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appc/acbuild/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/appc/acbuild/statuses/cd778b6a5e684f10798cf8a0ff2aef7b0643e393"}}}}