{"action":"created","issue":{"url":"https://api.github.com/repos/iojs/io.js/issues/607","labels_url":"https://api.github.com/repos/iojs/io.js/issues/607/labels{/name}","comments_url":"https://api.github.com/repos/iojs/io.js/issues/607/comments","events_url":"https://api.github.com/repos/iojs/io.js/issues/607/events","html_url":"https://github.com/iojs/io.js/issues/607","id":55460074,"number":607,"title":"replace util.isType() with typeof ","user":{"login":"micnic","id":1449826,"avatar_url":"https://avatars.githubusercontent.com/u/1449826?v=3","gravatar_id":"","url":"https://api.github.com/users/micnic","html_url":"https://github.com/micnic","followers_url":"https://api.github.com/users/micnic/followers","following_url":"https://api.github.com/users/micnic/following{/other_user}","gists_url":"https://api.github.com/users/micnic/gists{/gist_id}","starred_url":"https://api.github.com/users/micnic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micnic/subscriptions","organizations_url":"https://api.github.com/users/micnic/orgs","repos_url":"https://api.github.com/users/micnic/repos","events_url":"https://api.github.com/users/micnic/events{/privacy}","received_events_url":"https://api.github.com/users/micnic/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/iojs/io.js/labels/tc-agenda","name":"tc-agenda","color":"5319e7"},{"url":"https://api.github.com/repos/iojs/io.js/labels/util","name":"util","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-01-26T09:11:34Z","updated_at":"2015-02-01T04:55:12Z","closed_at":"2015-02-01T04:55:12Z","body":"In the last PRs (#601 #605)  I observed that the contributors replaced `util.isString(data)` with `typeof data === 'string'` or `util.isFunction(callback)` with `typeof callback === 'function'`, the reason for these changes are some performance optimizations, I guess these optimizations are quite insignificant, but they are still improving the performance of the code. From my point of view it's also a code style change, so my question is: Should we allow such changes in the code style? if it's \"yes\" then we should replace them everywhere where `util.isType()` is used.\r\n\r\ncc TC members @chrisdickinson @bnoordhuis"},"comment":{"url":"https://api.github.com/repos/iojs/io.js/issues/comments/72351676","html_url":"https://github.com/iojs/io.js/issues/607#issuecomment-72351676","issue_url":"https://api.github.com/repos/iojs/io.js/issues/607","id":72351676,"user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"created_at":"2015-02-01T04:55:12Z","updated_at":"2015-02-01T04:55:12Z","body":"Closed in 6ac8bdc0aba5f60f4b4f2da5abd36d664062aa40"}}