{"comment":{"url":"https://api.github.com/repos/mziccard/gcloud-java/comments/14050941","html_url":"https://github.com/mziccard/gcloud-java/commit/f90e70c4e9784d1d99784d863a5ae2c5ec257985#commitcomment-14050941","id":14050941,"user":{"login":"aozarov","id":8921691,"avatar_url":"https://avatars.githubusercontent.com/u/8921691?v=3","gravatar_id":"","url":"https://api.github.com/users/aozarov","html_url":"https://github.com/aozarov","followers_url":"https://api.github.com/users/aozarov/followers","following_url":"https://api.github.com/users/aozarov/following{/other_user}","gists_url":"https://api.github.com/users/aozarov/gists{/gist_id}","starred_url":"https://api.github.com/users/aozarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aozarov/subscriptions","organizations_url":"https://api.github.com/users/aozarov/orgs","repos_url":"https://api.github.com/users/aozarov/repos","events_url":"https://api.github.com/users/aozarov/events{/privacy}","received_events_url":"https://api.github.com/users/aozarov/received_events","type":"User","site_admin":false},"position":5,"line":542,"path":"gcloud-java-storage/src/main/java/com/google/gcloud/spi/DefaultStorageRpc.java","commit_id":"f90e70c4e9784d1d99784d863a5ae2c5ec257985","created_at":"2015-10-28T20:23:47Z","updated_at":"2015-10-28T20:23:47Z","body":"Yes, now it is consistent with the previous copy, but I do wonder if that is the right thing to do (silently\r\nignore any other overridable content such as metadata if content-type is missing...)\r\n\r\nAt the very least we should probably document `CopyRequest.Builder.target(BlobInfo)` (is that the only place\r\nwhere one could provide BlobInfo for a target?) with this kind of side-effect.\r\n\r\nAnother possible way to make this issue less surprising could be by changing `CopyRequest.Builder` \r\nto have 2 separate type of setters for target: `target(BlobId)` and `target(BlobInfo, BlobTargetOption...)` [and/or `target(BlobInfo, Iterable<BlobTargetOption>)`]. In that case, we could document [and possible throw an IllegalArgumentException] if the given BlobInfo is missing `content-type`.\r\n\r\n\r\n/cc @BrandonY"}}