{"action":"created","issue":{"url":"https://api.github.com/repos/ryandub/omnibus-ohai-solo/issues/11","labels_url":"https://api.github.com/repos/ryandub/omnibus-ohai-solo/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/ryandub/omnibus-ohai-solo/issues/11/comments","events_url":"https://api.github.com/repos/ryandub/omnibus-ohai-solo/issues/11/events","html_url":"https://github.com/ryandub/omnibus-ohai-solo/issues/11","id":63260002,"number":11,"title":"Insure use of files in /tmp","user":{"login":"mgeisler","id":89623,"avatar_url":"https://avatars.githubusercontent.com/u/89623?v=3","gravatar_id":"","url":"https://api.github.com/users/mgeisler","html_url":"https://github.com/mgeisler","followers_url":"https://api.github.com/users/mgeisler/followers","following_url":"https://api.github.com/users/mgeisler/following{/other_user}","gists_url":"https://api.github.com/users/mgeisler/gists{/gist_id}","starred_url":"https://api.github.com/users/mgeisler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgeisler/subscriptions","organizations_url":"https://api.github.com/users/mgeisler/orgs","repos_url":"https://api.github.com/users/mgeisler/repos","events_url":"https://api.github.com/users/mgeisler/events{/privacy}","received_events_url":"https://api.github.com/users/mgeisler/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-20T16:34:03Z","updated_at":"2015-03-25T21:20:08Z","closed_at":"2015-03-25T21:20:08Z","body":"The `install.sh` script writes to a number of files with fixed names in `/tmp`. This opens up the possibility of the old symlink-trick where an attacker symlinks `/tmp/nocheck` to, say, `/etc/passwd`. After writing to `/tmp/nocheck`, the system is left in a bad state since the password file has been overwritten with garbage.\r\n\r\nTo be secure, a temporary directory needs to be created (securely!) and all files should be written inside it."},"comment":{"url":"https://api.github.com/repos/ryandub/omnibus-ohai-solo/issues/comments/86221542","html_url":"https://github.com/ryandub/omnibus-ohai-solo/issues/11#issuecomment-86221542","issue_url":"https://api.github.com/repos/ryandub/omnibus-ohai-solo/issues/11","id":86221542,"user":{"login":"mgeisler","id":89623,"avatar_url":"https://avatars.githubusercontent.com/u/89623?v=3","gravatar_id":"","url":"https://api.github.com/users/mgeisler","html_url":"https://github.com/mgeisler","followers_url":"https://api.github.com/users/mgeisler/followers","following_url":"https://api.github.com/users/mgeisler/following{/other_user}","gists_url":"https://api.github.com/users/mgeisler/gists{/gist_id}","starred_url":"https://api.github.com/users/mgeisler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgeisler/subscriptions","organizations_url":"https://api.github.com/users/mgeisler/orgs","repos_url":"https://api.github.com/users/mgeisler/repos","events_url":"https://api.github.com/users/mgeisler/events{/privacy}","received_events_url":"https://api.github.com/users/mgeisler/received_events","type":"User","site_admin":false},"created_at":"2015-03-25T21:20:08Z","updated_at":"2015-03-25T21:20:08Z","body":"Thanks, I agree it should change in the upstream repository then."}}