{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/27441859","id":27441859,"diff_hunk":"@@ -340,30 +341,29 @@ def test_gpu_contiguous():\n     assert f(a_val, 2).flags.c_contiguous\n \n \n-class G_reshape(T_reshape):\n+class G_reshape(test_basic.T_reshape):\n     def shortDescription(self):\n         return None\n \n     def __init__(self, name):\n-        T_reshape.__init__(self, name,\n-                           shared=gpuarray_shared_constructor,\n-                           op=GpuReshape,\n-                           mode=mode_with_gpu,\n-                           # avoid errors with limited devices\n-#                             dtype='float32',\n-                           ignore_topo=(HostFromGpu, GpuFromHost,\n-                                        theano.compile.DeepCopyOp,\n-                                        theano.sandbox.gpuarray.elemwise.GpuElemwise,\n-                                        theano.tensor.opt.Shape_i,\n-                                        theano.tensor.opt.MakeVector))\n+        test_basic.T_reshape.__init__(\n+            self, name,\n+            shared=gpuarray_shared_constructor,\n+            op=GpuReshape,\n+            mode=mode_with_gpu,\n+            ignore_topo=(HostFromGpu, GpuFromHost,\n+                         theano.compile.DeepCopyOp,\n+                         theano.sandbox.gpuarray.elemwise.GpuElemwise,\n+                         theano.tensor.opt.Shape_i,\n+                         theano.tensor.opt.MakeVector))\n         assert self.op == GpuReshape\n \n \n-class G_Join_and_Split(T_Join_and_Split):\n+class G_Join_and_Split(test_basic.T_Join_and_Split):\n     def setUp(self):\n         super(G_Join_and_Split, self).setUp()\n         self.mode = mode_with_gpu.excluding('constant_folding')\n-        self.join_op = GpuJoin\n+        self.join_op = GpuJoin()\n         self.split_op = GpuSplit\n         # Use join instead of MakeVector since there is no MakeVector on GPU\n         self.make_vector_op = GpuJoin","path":"theano/sandbox/gpuarray/tests/test_basic_ops.py","position":66,"original_position":66,"commit_id":"35d8b8b4437046249f37c8bc9bb9c6da817114ee","original_commit_id":"35d8b8b4437046249f37c8bc9bb9c6da817114ee","user":{"login":"lamblin","id":178249,"avatar_url":"https://avatars.githubusercontent.com/u/178249?v=3","gravatar_id":"","url":"https://api.github.com/users/lamblin","html_url":"https://github.com/lamblin","followers_url":"https://api.github.com/users/lamblin/followers","following_url":"https://api.github.com/users/lamblin/following{/other_user}","gists_url":"https://api.github.com/users/lamblin/gists{/gist_id}","starred_url":"https://api.github.com/users/lamblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamblin/subscriptions","organizations_url":"https://api.github.com/users/lamblin/orgs","repos_url":"https://api.github.com/users/lamblin/repos","events_url":"https://api.github.com/users/lamblin/events{/privacy}","received_events_url":"https://api.github.com/users/lamblin/received_events","type":"User","site_admin":false},"body":"It is kind of confusing to have some Op classes and some Op instances, all named `..._op`.\r\nI understand that we cannot pre-instantiate `GpuSplit` because the number of splits is a constructor argument, but we should name the members differently then.","created_at":"2015-03-30T23:28:31Z","updated_at":"2015-03-30T23:28:31Z","html_url":"https://github.com/Theano/Theano/pull/2706#discussion_r27441859","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/2706","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/27441859"},"html":{"href":"https://github.com/Theano/Theano/pull/2706#discussion_r27441859"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2706"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/2706","id":32271971,"html_url":"https://github.com/Theano/Theano/pull/2706","diff_url":"https://github.com/Theano/Theano/pull/2706.diff","patch_url":"https://github.com/Theano/Theano/pull/2706.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/2706","number":2706,"state":"open","locked":false,"title":"Merge test fixes","user":{"login":"abergeron","id":1002504,"avatar_url":"https://avatars.githubusercontent.com/u/1002504?v=3","gravatar_id":"","url":"https://api.github.com/users/abergeron","html_url":"https://github.com/abergeron","followers_url":"https://api.github.com/users/abergeron/followers","following_url":"https://api.github.com/users/abergeron/following{/other_user}","gists_url":"https://api.github.com/users/abergeron/gists{/gist_id}","starred_url":"https://api.github.com/users/abergeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abergeron/subscriptions","organizations_url":"https://api.github.com/users/abergeron/orgs","repos_url":"https://api.github.com/users/abergeron/repos","events_url":"https://api.github.com/users/abergeron/events{/privacy}","received_events_url":"https://api.github.com/users/abergeron/received_events","type":"User","site_admin":false},"body":"These are most of the test fixes that I will need for multi-gpu for code that is outside sandbox/gpuarray/","created_at":"2015-03-30T21:59:13Z","updated_at":"2015-03-30T23:28:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77339d00685de17c6ea6247d8d44ab5aae2da4ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/2706/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/2706/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/2706/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/35d8b8b4437046249f37c8bc9bb9c6da817114ee","head":{"label":"abergeron:merge_test_fixes","ref":"merge_test_fixes","sha":"35d8b8b4437046249f37c8bc9bb9c6da817114ee","user":{"login":"abergeron","id":1002504,"avatar_url":"https://avatars.githubusercontent.com/u/1002504?v=3","gravatar_id":"","url":"https://api.github.com/users/abergeron","html_url":"https://github.com/abergeron","followers_url":"https://api.github.com/users/abergeron/followers","following_url":"https://api.github.com/users/abergeron/following{/other_user}","gists_url":"https://api.github.com/users/abergeron/gists{/gist_id}","starred_url":"https://api.github.com/users/abergeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abergeron/subscriptions","organizations_url":"https://api.github.com/users/abergeron/orgs","repos_url":"https://api.github.com/users/abergeron/repos","events_url":"https://api.github.com/users/abergeron/events{/privacy}","received_events_url":"https://api.github.com/users/abergeron/received_events","type":"User","site_admin":false},"repo":{"id":2264121,"name":"Theano","full_name":"abergeron/Theano","owner":{"login":"abergeron","id":1002504,"avatar_url":"https://avatars.githubusercontent.com/u/1002504?v=3","gravatar_id":"","url":"https://api.github.com/users/abergeron","html_url":"https://github.com/abergeron","followers_url":"https://api.github.com/users/abergeron/followers","following_url":"https://api.github.com/users/abergeron/following{/other_user}","gists_url":"https://api.github.com/users/abergeron/gists{/gist_id}","starred_url":"https://api.github.com/users/abergeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abergeron/subscriptions","organizations_url":"https://api.github.com/users/abergeron/orgs","repos_url":"https://api.github.com/users/abergeron/repos","events_url":"https://api.github.com/users/abergeron/events{/privacy}","received_events_url":"https://api.github.com/users/abergeron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abergeron/Theano","description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","fork":true,"url":"https://api.github.com/repos/abergeron/Theano","forks_url":"https://api.github.com/repos/abergeron/Theano/forks","keys_url":"https://api.github.com/repos/abergeron/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abergeron/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abergeron/Theano/teams","hooks_url":"https://api.github.com/repos/abergeron/Theano/hooks","issue_events_url":"https://api.github.com/repos/abergeron/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/abergeron/Theano/events","assignees_url":"https://api.github.com/repos/abergeron/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/abergeron/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/abergeron/Theano/tags","blobs_url":"https://api.github.com/repos/abergeron/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abergeron/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abergeron/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/abergeron/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abergeron/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/abergeron/Theano/languages","stargazers_url":"https://api.github.com/repos/abergeron/Theano/stargazers","contributors_url":"https://api.github.com/repos/abergeron/Theano/contributors","subscribers_url":"https://api.github.com/repos/abergeron/Theano/subscribers","subscription_url":"https://api.github.com/repos/abergeron/Theano/subscription","commits_url":"https://api.github.com/repos/abergeron/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/abergeron/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/abergeron/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/abergeron/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/abergeron/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/abergeron/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abergeron/Theano/merges","archive_url":"https://api.github.com/repos/abergeron/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abergeron/Theano/downloads","issues_url":"https://api.github.com/repos/abergeron/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/abergeron/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/abergeron/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/abergeron/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abergeron/Theano/labels{/name}","releases_url":"https://api.github.com/repos/abergeron/Theano/releases{/id}","created_at":"2011-08-24T20:28:59Z","updated_at":"2015-03-30T16:42:05Z","pushed_at":"2015-03-30T22:51:30Z","git_url":"git://github.com/abergeron/Theano.git","ssh_url":"git@github.com:abergeron/Theano.git","clone_url":"https://github.com/abergeron/Theano.git","svn_url":"https://github.com/abergeron/Theano","homepage":"http://www.deeplearning.net/software/theano","size":29782,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"73a6651fcf41aea7440ce4eed95c86d8fd0a1919","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","created_at":"2011-08-10T03:48:06Z","updated_at":"2015-03-30T23:10:34Z","pushed_at":"2015-03-30T23:07:51Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":41547,"stargazers_count":1325,"watchers_count":1325,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":487,"mirror_url":null,"open_issues_count":333,"forks":487,"open_issues":333,"watchers":1325,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2706"},"html":{"href":"https://github.com/Theano/Theano/pull/2706"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/2706"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/2706/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2706/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2706/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/35d8b8b4437046249f37c8bc9bb9c6da817114ee"}}}}