{"action":"created","issue":{"url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/issues/7","labels_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/issues/7/comments","events_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/issues/7/events","html_url":"https://github.com/dnanexus-rnd/GLnexus/pull/7","id":99742357,"number":7,"title":"Split gvcf into chromosomes","user":{"login":"orodeh","id":7037561,"avatar_url":"https://avatars.githubusercontent.com/u/7037561?v=3","gravatar_id":"","url":"https://api.github.com/users/orodeh","html_url":"https://github.com/orodeh","followers_url":"https://api.github.com/users/orodeh/followers","following_url":"https://api.github.com/users/orodeh/following{/other_user}","gists_url":"https://api.github.com/users/orodeh/gists{/gist_id}","starred_url":"https://api.github.com/users/orodeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orodeh/subscriptions","organizations_url":"https://api.github.com/users/orodeh/orgs","repos_url":"https://api.github.com/users/orodeh/repos","events_url":"https://api.github.com/users/orodeh/events{/privacy}","received_events_url":"https://api.github.com/users/orodeh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-07T22:44:33Z","updated_at":"2015-08-18T18:00:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/pulls/7","html_url":"https://github.com/dnanexus-rnd/GLnexus/pull/7","diff_url":"https://github.com/dnanexus-rnd/GLnexus/pull/7.diff","patch_url":"https://github.com/dnanexus-rnd/GLnexus/pull/7.patch"},"body":"This branch is based on ubcf. It would make sense to first review the ubcf branch, merge, and only then review this code."},"comment":{"url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/issues/comments/132298698","html_url":"https://github.com/dnanexus-rnd/GLnexus/pull/7#issuecomment-132298698","issue_url":"https://api.github.com/repos/dnanexus-rnd/GLnexus/issues/7","id":132298698,"user":{"login":"mlin","id":356550,"avatar_url":"https://avatars.githubusercontent.com/u/356550?v=3","gravatar_id":"","url":"https://api.github.com/users/mlin","html_url":"https://github.com/mlin","followers_url":"https://api.github.com/users/mlin/followers","following_url":"https://api.github.com/users/mlin/following{/other_user}","gists_url":"https://api.github.com/users/mlin/gists{/gist_id}","starred_url":"https://api.github.com/users/mlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlin/subscriptions","organizations_url":"https://api.github.com/users/mlin/orgs","repos_url":"https://api.github.com/users/mlin/repos","events_url":"https://api.github.com/users/mlin/events{/privacy}","received_events_url":"https://api.github.com/users/mlin/received_events","type":"User","site_admin":false},"created_at":"2015-08-18T18:00:54Z","updated_at":"2015-08-18T18:00:54Z","body":"This looks good to me except that there are no specific tests of the new schema. We'll need to work out good test cases for the storage engine to ensure it behaves correctly with the expected read & write amplification going forward. It may not be worth working out all the detailed cases for the chromosome-level buckets, since we plan to move to range buckets in short order, but I suspect cycles devoted to thinking through what they'd be like will be reusable."}}