{"action":"created","issue":{"url":"https://api.github.com/repos/w3c/web-platform-tests/issues/1876","labels_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/1876/labels{/name}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/1876/comments","events_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/1876/events","html_url":"https://github.com/w3c/web-platform-tests/pull/1876","id":85441063,"number":1876,"title":"Convert shapes-rect-01-t-manual.svg to reftests.","user":{"login":"heycam","id":1484434,"avatar_url":"https://avatars.githubusercontent.com/u/1484434?v=3","gravatar_id":"","url":"https://api.github.com/users/heycam","html_url":"https://github.com/heycam","followers_url":"https://api.github.com/users/heycam/followers","following_url":"https://api.github.com/users/heycam/following{/other_user}","gists_url":"https://api.github.com/users/heycam/gists{/gist_id}","starred_url":"https://api.github.com/users/heycam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heycam/subscriptions","organizations_url":"https://api.github.com/users/heycam/orgs","repos_url":"https://api.github.com/users/heycam/repos","events_url":"https://api.github.com/users/heycam/events{/privacy}","received_events_url":"https://api.github.com/users/heycam/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/w3c/web-platform-tests/labels/svg","name":"svg","color":"ededed"},{"url":"https://api.github.com/repos/w3c/web-platform-tests/labels/wg-svg","name":"wg-svg","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-05T05:52:10Z","updated_at":"2015-06-05T05:52:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/1876","html_url":"https://github.com/w3c/web-platform-tests/pull/1876","diff_url":"https://github.com/w3c/web-platform-tests/pull/1876.diff","patch_url":"https://github.com/w3c/web-platform-tests/pull/1876.patch"},"body":"This is my first attempt at converting a test from the SVG 1.1 test suite to web-platform-tests reftest format.  I'm looking for feedback that the approach I'm using here is correct.  There are very few SVG reftests in the tree to copy from.  While ugly, I think the structure and namespacing of the `metadata` element and its contents is what Shepherd expects, so I assume that's what we want here too.\r\n\r\nNote that I haven't slavishly copied the test; instead I've added simpler reftests that cover what the original test was going for.\r\n\r\nAlso note that I've pointed the `<link rel=help>` elements to the undated SVG 2 TR/ link.  Hopefully that's the right thing to do."},"comment":{"url":"https://api.github.com/repos/w3c/web-platform-tests/issues/comments/109171002","html_url":"https://github.com/w3c/web-platform-tests/pull/1876#issuecomment-109171002","issue_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/1876","id":109171002,"user":{"login":"hoppipolla-critic-bot","id":4663992,"avatar_url":"https://avatars.githubusercontent.com/u/4663992?v=3","gravatar_id":"","url":"https://api.github.com/users/hoppipolla-critic-bot","html_url":"https://github.com/hoppipolla-critic-bot","followers_url":"https://api.github.com/users/hoppipolla-critic-bot/followers","following_url":"https://api.github.com/users/hoppipolla-critic-bot/following{/other_user}","gists_url":"https://api.github.com/users/hoppipolla-critic-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/hoppipolla-critic-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoppipolla-critic-bot/subscriptions","organizations_url":"https://api.github.com/users/hoppipolla-critic-bot/orgs","repos_url":"https://api.github.com/users/hoppipolla-critic-bot/repos","events_url":"https://api.github.com/users/hoppipolla-critic-bot/events{/privacy}","received_events_url":"https://api.github.com/users/hoppipolla-critic-bot/received_events","type":"User","site_admin":false},"created_at":"2015-06-05T05:52:14Z","updated_at":"2015-06-05T05:52:14Z","body":"Critic review: https://critic.hoppipolla.co.uk/r/5192\n\nThis is an external review system which you may optionally use for the code review of your pull request.\n\nIn order to help critic track your changes, please do *not* make in-place history rewrites (e.g. via `git rebase -i` or `git commit --amend`) when updating this pull request.\n"}}