{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/17350","labels_url":"https://api.github.com/repos/docker/docker/issues/17350/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/17350/comments","events_url":"https://api.github.com/repos/docker/docker/issues/17350/events","html_url":"https://github.com/docker/docker/pull/17350","id":113239288,"number":17350,"title":"dockerversion placeholder for library-import","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/1-design-review","name":"status/1-design-review","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-10-25T17:47:50Z","updated_at":"2015-10-26T19:58:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/17350","html_url":"https://github.com/docker/docker/pull/17350","diff_url":"https://github.com/docker/docker/pull/17350.diff","patch_url":"https://github.com/docker/docker/pull/17350.patch"},"body":"Little bit scared to do this PR 😱 but here we go. This is *implementing* the idea of @erikh from #11699. Kinda want **some thoughts and opinions** on this and ideas to move forward, that's why the PR 🎅.\r\n\r\n> what about doing this, instead, as a placeholder? https://gist.github.com/erikh/e6f0c5e4b7b6c2483d52\r\n> \r\n> you could leave this in the repository so it's still go-gettable, but then overwrite it during the build. how does this sound?\r\n\r\nTo add to the discussion, quotation from @ibuildthecloud \r\n\r\n> I know people shouldn't import non-pkg code but I don't like that effectively docker makes it not possible. If people want to import stuff at their own risk, just let them.\r\n\r\n/ping @tianon @jfrazelle @docker/maintainers \r\n\r\n🐸\r\n\r\nSigned-off-by: Vincent Demeester <vincent@sbr.pm>"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/151265903","html_url":"https://github.com/docker/docker/pull/17350#issuecomment-151265903","issue_url":"https://api.github.com/repos/docker/docker/issues/17350","id":151265903,"user":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"created_at":"2015-10-26T19:58:45Z","updated_at":"2015-10-26T19:58:45Z","body":"I agree with @stevvooe that if we're going to have this static it should not be under `autogen`. Maybe we could have it under `docker/version`, so the import path would be something like `github.com/docker/docker/version`. We could have this static file called `version_lib.go` and let make create a `version_autogen.go`.\r\n\r\n:+1: to build tags too."}}