{"action":"created","comment":{"url":"https://api.github.com/repos/domokit/sky_engine/pulls/comments/36141992","id":36141992,"diff_hunk":"@@ -139,33 +139,48 @@ class Drawer extends StatefulComponent {\n \n   void _settle() { _isMostlyClosed ? _performance.reverse() : _performance.play(); }\n \n-  void handleMaskTap(_) { _performance.reverse(); }\n+  EventDisposition handleMaskTap(_) {\n+    _performance.reverse();\n+    return EventDisposition.processed;","path":"sky/packages/sky/lib/widgets/drawer.dart","position":7,"original_position":7,"commit_id":"4733d816e1d4b153da337dc0c757fca7fc62a295","original_commit_id":"4733d816e1d4b153da337dc0c757fca7fc62a295","user":{"login":"abarth","id":112007,"avatar_url":"https://avatars.githubusercontent.com/u/112007?v=3","gravatar_id":"","url":"https://api.github.com/users/abarth","html_url":"https://github.com/abarth","followers_url":"https://api.github.com/users/abarth/followers","following_url":"https://api.github.com/users/abarth/following{/other_user}","gists_url":"https://api.github.com/users/abarth/gists{/gist_id}","starred_url":"https://api.github.com/users/abarth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abarth/subscriptions","organizations_url":"https://api.github.com/users/abarth/orgs","repos_url":"https://api.github.com/users/abarth/repos","events_url":"https://api.github.com/users/abarth/events{/privacy}","received_events_url":"https://api.github.com/users/abarth/received_events","type":"User","site_admin":false},"body":"Why not consumed here?","created_at":"2015-08-03T23:07:19Z","updated_at":"2015-08-03T23:07:19Z","html_url":"https://github.com/domokit/sky_engine/pull/436#discussion_r36141992","pull_request_url":"https://api.github.com/repos/domokit/sky_engine/pulls/436","_links":{"self":{"href":"https://api.github.com/repos/domokit/sky_engine/pulls/comments/36141992"},"html":{"href":"https://github.com/domokit/sky_engine/pull/436#discussion_r36141992"},"pull_request":{"href":"https://api.github.com/repos/domokit/sky_engine/pulls/436"}}},"pull_request":{"url":"https://api.github.com/repos/domokit/sky_engine/pulls/436","id":41519066,"html_url":"https://github.com/domokit/sky_engine/pull/436","diff_url":"https://github.com/domokit/sky_engine/pull/436.diff","patch_url":"https://github.com/domokit/sky_engine/pull/436.patch","issue_url":"https://api.github.com/repos/domokit/sky_engine/issues/436","number":436,"state":"open","locked":false,"title":"Teach event system about disposition and make 'consumed' disposition …","user":{"login":"jamesr","id":7497301,"avatar_url":"https://avatars.githubusercontent.com/u/7497301?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesr","html_url":"https://github.com/jamesr","followers_url":"https://api.github.com/users/jamesr/followers","following_url":"https://api.github.com/users/jamesr/following{/other_user}","gists_url":"https://api.github.com/users/jamesr/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesr/subscriptions","organizations_url":"https://api.github.com/users/jamesr/orgs","repos_url":"https://api.github.com/users/jamesr/repos","events_url":"https://api.github.com/users/jamesr/events{/privacy}","received_events_url":"https://api.github.com/users/jamesr/received_events","type":"User","site_admin":false},"body":"…terminal\r\n\r\nThis introduces the notion of event disposition and allows event\r\ntargets (widgets and render objects) to consume events that should not\r\nbe processed further. This is needed by the Switch component in the\r\nDrawer in the stocks example. The Switch is embedded in a DrawerItem.\r\nThe Switch handles the gesture tap event to toggle its state and should\r\nhandle pointer events to allow swiping and draw its own radial\r\nreaction. The DrawerItem also handles gesture taps to allow toggling\r\nthe switch value when tapping anywhere on the drawer and to draw its\r\nown ink splash. When tapping on the switch, both the switch's render\r\nobject and the DrawerItem's listener are in the event dispatch path.\r\nThe Switch needs to signal in some fashion that it consumed the event\r\nso the DrawerItem does not also try to toggle the switch's state.","created_at":"2015-08-03T23:01:18Z","updated_at":"2015-08-03T23:07:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87ee9ae788e31730ab4dc615d9b24bd3c2bce790","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/domokit/sky_engine/pulls/436/commits","review_comments_url":"https://api.github.com/repos/domokit/sky_engine/pulls/436/comments","review_comment_url":"https://api.github.com/repos/domokit/sky_engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/domokit/sky_engine/issues/436/comments","statuses_url":"https://api.github.com/repos/domokit/sky_engine/statuses/4733d816e1d4b153da337dc0c757fca7fc62a295","head":{"label":"jamesr:event_disposition","ref":"event_disposition","sha":"4733d816e1d4b153da337dc0c757fca7fc62a295","user":{"login":"jamesr","id":7497301,"avatar_url":"https://avatars.githubusercontent.com/u/7497301?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesr","html_url":"https://github.com/jamesr","followers_url":"https://api.github.com/users/jamesr/followers","following_url":"https://api.github.com/users/jamesr/following{/other_user}","gists_url":"https://api.github.com/users/jamesr/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesr/subscriptions","organizations_url":"https://api.github.com/users/jamesr/orgs","repos_url":"https://api.github.com/users/jamesr/repos","events_url":"https://api.github.com/users/jamesr/events{/privacy}","received_events_url":"https://api.github.com/users/jamesr/received_events","type":"User","site_admin":false},"repo":{"id":39583074,"name":"sky_engine","full_name":"jamesr/sky_engine","owner":{"login":"jamesr","id":7497301,"avatar_url":"https://avatars.githubusercontent.com/u/7497301?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesr","html_url":"https://github.com/jamesr","followers_url":"https://api.github.com/users/jamesr/followers","following_url":"https://api.github.com/users/jamesr/following{/other_user}","gists_url":"https://api.github.com/users/jamesr/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesr/subscriptions","organizations_url":"https://api.github.com/users/jamesr/orgs","repos_url":"https://api.github.com/users/jamesr/repos","events_url":"https://api.github.com/users/jamesr/events{/privacy}","received_events_url":"https://api.github.com/users/jamesr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamesr/sky_engine","description":"The Sky engine","fork":true,"url":"https://api.github.com/repos/jamesr/sky_engine","forks_url":"https://api.github.com/repos/jamesr/sky_engine/forks","keys_url":"https://api.github.com/repos/jamesr/sky_engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamesr/sky_engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamesr/sky_engine/teams","hooks_url":"https://api.github.com/repos/jamesr/sky_engine/hooks","issue_events_url":"https://api.github.com/repos/jamesr/sky_engine/issues/events{/number}","events_url":"https://api.github.com/repos/jamesr/sky_engine/events","assignees_url":"https://api.github.com/repos/jamesr/sky_engine/assignees{/user}","branches_url":"https://api.github.com/repos/jamesr/sky_engine/branches{/branch}","tags_url":"https://api.github.com/repos/jamesr/sky_engine/tags","blobs_url":"https://api.github.com/repos/jamesr/sky_engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamesr/sky_engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamesr/sky_engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamesr/sky_engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamesr/sky_engine/statuses/{sha}","languages_url":"https://api.github.com/repos/jamesr/sky_engine/languages","stargazers_url":"https://api.github.com/repos/jamesr/sky_engine/stargazers","contributors_url":"https://api.github.com/repos/jamesr/sky_engine/contributors","subscribers_url":"https://api.github.com/repos/jamesr/sky_engine/subscribers","subscription_url":"https://api.github.com/repos/jamesr/sky_engine/subscription","commits_url":"https://api.github.com/repos/jamesr/sky_engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamesr/sky_engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamesr/sky_engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamesr/sky_engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamesr/sky_engine/contents/{+path}","compare_url":"https://api.github.com/repos/jamesr/sky_engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamesr/sky_engine/merges","archive_url":"https://api.github.com/repos/jamesr/sky_engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamesr/sky_engine/downloads","issues_url":"https://api.github.com/repos/jamesr/sky_engine/issues{/number}","pulls_url":"https://api.github.com/repos/jamesr/sky_engine/pulls{/number}","milestones_url":"https://api.github.com/repos/jamesr/sky_engine/milestones{/number}","notifications_url":"https://api.github.com/repos/jamesr/sky_engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamesr/sky_engine/labels{/name}","releases_url":"https://api.github.com/repos/jamesr/sky_engine/releases{/id}","created_at":"2015-07-23T18:07:08Z","updated_at":"2015-07-23T18:07:27Z","pushed_at":"2015-08-03T23:00:53Z","git_url":"git://github.com/jamesr/sky_engine.git","ssh_url":"git@github.com:jamesr/sky_engine.git","clone_url":"https://github.com/jamesr/sky_engine.git","svn_url":"https://github.com/jamesr/sky_engine","homepage":null,"size":71575,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"domokit:master","ref":"master","sha":"54f29d86d2fc8bf9ff6e53503278045decd8029e","user":{"login":"domokit","id":8664152,"avatar_url":"https://avatars.githubusercontent.com/u/8664152?v=3","gravatar_id":"","url":"https://api.github.com/users/domokit","html_url":"https://github.com/domokit","followers_url":"https://api.github.com/users/domokit/followers","following_url":"https://api.github.com/users/domokit/following{/other_user}","gists_url":"https://api.github.com/users/domokit/gists{/gist_id}","starred_url":"https://api.github.com/users/domokit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domokit/subscriptions","organizations_url":"https://api.github.com/users/domokit/orgs","repos_url":"https://api.github.com/users/domokit/repos","events_url":"https://api.github.com/users/domokit/events{/privacy}","received_events_url":"https://api.github.com/users/domokit/received_events","type":"Organization","site_admin":false},"repo":{"id":39211337,"name":"sky_engine","full_name":"domokit/sky_engine","owner":{"login":"domokit","id":8664152,"avatar_url":"https://avatars.githubusercontent.com/u/8664152?v=3","gravatar_id":"","url":"https://api.github.com/users/domokit","html_url":"https://github.com/domokit","followers_url":"https://api.github.com/users/domokit/followers","following_url":"https://api.github.com/users/domokit/following{/other_user}","gists_url":"https://api.github.com/users/domokit/gists{/gist_id}","starred_url":"https://api.github.com/users/domokit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domokit/subscriptions","organizations_url":"https://api.github.com/users/domokit/orgs","repos_url":"https://api.github.com/users/domokit/repos","events_url":"https://api.github.com/users/domokit/events{/privacy}","received_events_url":"https://api.github.com/users/domokit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/domokit/sky_engine","description":"The Sky engine","fork":false,"url":"https://api.github.com/repos/domokit/sky_engine","forks_url":"https://api.github.com/repos/domokit/sky_engine/forks","keys_url":"https://api.github.com/repos/domokit/sky_engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/domokit/sky_engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/domokit/sky_engine/teams","hooks_url":"https://api.github.com/repos/domokit/sky_engine/hooks","issue_events_url":"https://api.github.com/repos/domokit/sky_engine/issues/events{/number}","events_url":"https://api.github.com/repos/domokit/sky_engine/events","assignees_url":"https://api.github.com/repos/domokit/sky_engine/assignees{/user}","branches_url":"https://api.github.com/repos/domokit/sky_engine/branches{/branch}","tags_url":"https://api.github.com/repos/domokit/sky_engine/tags","blobs_url":"https://api.github.com/repos/domokit/sky_engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/domokit/sky_engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/domokit/sky_engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/domokit/sky_engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/domokit/sky_engine/statuses/{sha}","languages_url":"https://api.github.com/repos/domokit/sky_engine/languages","stargazers_url":"https://api.github.com/repos/domokit/sky_engine/stargazers","contributors_url":"https://api.github.com/repos/domokit/sky_engine/contributors","subscribers_url":"https://api.github.com/repos/domokit/sky_engine/subscribers","subscription_url":"https://api.github.com/repos/domokit/sky_engine/subscription","commits_url":"https://api.github.com/repos/domokit/sky_engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/domokit/sky_engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/domokit/sky_engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/domokit/sky_engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/domokit/sky_engine/contents/{+path}","compare_url":"https://api.github.com/repos/domokit/sky_engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/domokit/sky_engine/merges","archive_url":"https://api.github.com/repos/domokit/sky_engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/domokit/sky_engine/downloads","issues_url":"https://api.github.com/repos/domokit/sky_engine/issues{/number}","pulls_url":"https://api.github.com/repos/domokit/sky_engine/pulls{/number}","milestones_url":"https://api.github.com/repos/domokit/sky_engine/milestones{/number}","notifications_url":"https://api.github.com/repos/domokit/sky_engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/domokit/sky_engine/labels{/name}","releases_url":"https://api.github.com/repos/domokit/sky_engine/releases{/id}","created_at":"2015-07-16T17:39:56Z","updated_at":"2015-08-03T18:18:34Z","pushed_at":"2015-08-03T23:06:11Z","git_url":"git://github.com/domokit/sky_engine.git","ssh_url":"git@github.com:domokit/sky_engine.git","clone_url":"https://github.com/domokit/sky_engine.git","svn_url":"https://github.com/domokit/sky_engine","homepage":null,"size":74496,"stargazers_count":94,"watchers_count":94,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":117,"forks":30,"open_issues":117,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/domokit/sky_engine/pulls/436"},"html":{"href":"https://github.com/domokit/sky_engine/pull/436"},"issue":{"href":"https://api.github.com/repos/domokit/sky_engine/issues/436"},"comments":{"href":"https://api.github.com/repos/domokit/sky_engine/issues/436/comments"},"review_comments":{"href":"https://api.github.com/repos/domokit/sky_engine/pulls/436/comments"},"review_comment":{"href":"https://api.github.com/repos/domokit/sky_engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/domokit/sky_engine/pulls/436/commits"},"statuses":{"href":"https://api.github.com/repos/domokit/sky_engine/statuses/4733d816e1d4b153da337dc0c757fca7fc62a295"}}}}