{"action":"created","issue":{"url":"https://api.github.com/repos/wikipathways/pvjs/issues/344","labels_url":"https://api.github.com/repos/wikipathways/pvjs/issues/344/labels{/name}","comments_url":"https://api.github.com/repos/wikipathways/pvjs/issues/344/comments","events_url":"https://api.github.com/repos/wikipathways/pvjs/issues/344/events","html_url":"https://github.com/wikipathways/pvjs/issues/344","id":97143794,"number":344,"title":"save&close is not triggered when changing datasource or id","user":{"login":"AlexanderPico","id":1418193,"avatar_url":"https://avatars.githubusercontent.com/u/1418193?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexanderPico","html_url":"https://github.com/AlexanderPico","followers_url":"https://api.github.com/users/AlexanderPico/followers","following_url":"https://api.github.com/users/AlexanderPico/following{/other_user}","gists_url":"https://api.github.com/users/AlexanderPico/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexanderPico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexanderPico/subscriptions","organizations_url":"https://api.github.com/users/AlexanderPico/orgs","repos_url":"https://api.github.com/users/AlexanderPico/repos","events_url":"https://api.github.com/users/AlexanderPico/events{/privacy}","received_events_url":"https://api.github.com/users/AlexanderPico/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/wikipathways/pvjs/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"ariutta","id":1296771,"avatar_url":"https://avatars.githubusercontent.com/u/1296771?v=3","gravatar_id":"","url":"https://api.github.com/users/ariutta","html_url":"https://github.com/ariutta","followers_url":"https://api.github.com/users/ariutta/followers","following_url":"https://api.github.com/users/ariutta/following{/other_user}","gists_url":"https://api.github.com/users/ariutta/gists{/gist_id}","starred_url":"https://api.github.com/users/ariutta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariutta/subscriptions","organizations_url":"https://api.github.com/users/ariutta/orgs","repos_url":"https://api.github.com/users/ariutta/repos","events_url":"https://api.github.com/users/ariutta/events{/privacy}","received_events_url":"https://api.github.com/users/ariutta/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/wikipathways/pvjs/milestones/8","html_url":"https://github.com/wikipathways/pvjs/milestones/editor-v1","labels_url":"https://api.github.com/repos/wikipathways/pvjs/milestones/8/labels","id":1176036,"number":8,"title":"editor-v1","description":"","creator":{"login":"ariutta","id":1296771,"avatar_url":"https://avatars.githubusercontent.com/u/1296771?v=3","gravatar_id":"","url":"https://api.github.com/users/ariutta","html_url":"https://github.com/ariutta","followers_url":"https://api.github.com/users/ariutta/followers","following_url":"https://api.github.com/users/ariutta/following{/other_user}","gists_url":"https://api.github.com/users/ariutta/gists{/gist_id}","starred_url":"https://api.github.com/users/ariutta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariutta/subscriptions","organizations_url":"https://api.github.com/users/ariutta/orgs","repos_url":"https://api.github.com/users/ariutta/repos","events_url":"https://api.github.com/users/ariutta/events{/privacy}","received_events_url":"https://api.github.com/users/ariutta/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":18,"state":"open","created_at":"2015-06-22T20:16:27Z","updated_at":"2015-07-28T18:19:40Z","due_on":"2015-07-31T07:00:00Z","closed_at":null},"comments":4,"created_at":"2015-07-24T20:47:43Z","updated_at":"2015-07-28T18:39:22Z","closed_at":null,"body":"steps to reproduce:\r\n1. click datanode and open editor (or vice versa)\r\n2. change datasource and/or id\r\n\r\nexpected:\r\n* save&close tab/button is active\r\n\r\nobserved:\r\n* not active; can only close without saving"},"comment":{"url":"https://api.github.com/repos/wikipathways/pvjs/issues/comments/125708469","html_url":"https://github.com/wikipathways/pvjs/issues/344#issuecomment-125708469","issue_url":"https://api.github.com/repos/wikipathways/pvjs/issues/344","id":125708469,"user":{"login":"khanspers","id":1442197,"avatar_url":"https://avatars.githubusercontent.com/u/1442197?v=3","gravatar_id":"","url":"https://api.github.com/users/khanspers","html_url":"https://github.com/khanspers","followers_url":"https://api.github.com/users/khanspers/followers","following_url":"https://api.github.com/users/khanspers/following{/other_user}","gists_url":"https://api.github.com/users/khanspers/gists{/gist_id}","starred_url":"https://api.github.com/users/khanspers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khanspers/subscriptions","organizations_url":"https://api.github.com/users/khanspers/orgs","repos_url":"https://api.github.com/users/khanspers/repos","events_url":"https://api.github.com/users/khanspers/events{/privacy}","received_events_url":"https://api.github.com/users/khanspers/received_events","type":"User","site_admin":false},"created_at":"2015-07-28T18:39:22Z","updated_at":"2015-07-28T18:39:22Z","body":"Works for me on Chrome, but there is a delay (~2seconds) before the button changes state. Also, an immediate reversal of the change without closing QuickEdit (i.e. changing the data source back to what it was originally, or adding the last number of the identifier that was just deleted), doesn't trigger the button state to go back to Close. \r\nIn contrast, changes to the display name don't have the same delay in button state change, and reversal works as expected.  "}}