{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Routing/pulls/comments/24538190","id":24538190,"diff_hunk":"@@ -917,7 +917,7 @@ public void GetVirtualPath_RejectedByHandler()\n \n             // Assert\n             Assert.False(context.IsBound);\n-            Assert.Null(path);\n+            Assert.Equal(\"Home\", path);","path":"test/Microsoft.AspNet.Routing.Tests/Template/TemplateRouteTest.cs","position":5,"original_position":5,"commit_id":"fff65bd40ce98bfd9331a45df83a9c15b30467ce","original_commit_id":"fff65bd40ce98bfd9331a45df83a9c15b30467ce","user":{"login":"rynowak","id":1430011,"avatar_url":"https://avatars.githubusercontent.com/u/1430011?v=3","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"body":"done","created_at":"2015-02-11T22:04:11Z","updated_at":"2015-02-11T22:04:11Z","html_url":"https://github.com/aspnet/Routing/pull/150#discussion_r24538190","pull_request_url":"https://api.github.com/repos/aspnet/Routing/pulls/150","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Routing/pulls/comments/24538190"},"html":{"href":"https://github.com/aspnet/Routing/pull/150#discussion_r24538190"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Routing/pulls/150"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Routing/pulls/150","id":28978247,"html_url":"https://github.com/aspnet/Routing/pull/150","diff_url":"https://github.com/aspnet/Routing/pull/150.diff","patch_url":"https://github.com/aspnet/Routing/pull/150.patch","issue_url":"https://api.github.com/repos/aspnet/Routing/issues/150","number":150,"state":"open","locked":false,"title":"Add support for best-effort link-generation","user":{"login":"rynowak","id":1430011,"avatar_url":"https://avatars.githubusercontent.com/u/1430011?v=3","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"body":"This change adds a feature needed for aspnet/Mvc#302\r\n\r\nThere's a new option in routing that allows link-generation to proceed\r\nwhen the route values cannot be validated. The key scenario for this is\r\nduring development of an MVC site. Routing will refuse to generate a link\r\nto actions which don't exists, this is a breaking change from the MVC5\r\nbehavior. Setting UseBestEffortLinkGeneration will allow routing to return\r\na value even when we can't match the action.\r\n\r\nThis option will remain off by default - setting this to on will impact\r\nlink-generation in a bunch of scenarios involving areas where we've\r\nimproved the logic for MVC6. If you're considering leaving this on outside\r\nof development scenarios, then make sure to be as explicit with route values\r\nas possible (don't rely on ambient values).\r\n\r\nFunctional tests to follow up in the MVC repo.","created_at":"2015-02-10T03:26:18Z","updated_at":"2015-02-11T22:04:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9173a816d7a55920aba84d69976926bec8413c94","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Routing/pulls/150/commits","review_comments_url":"https://api.github.com/repos/aspnet/Routing/pulls/150/comments","review_comment_url":"https://api.github.com/repos/aspnet/Routing/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aspnet/Routing/issues/150/comments","statuses_url":"https://api.github.com/repos/aspnet/Routing/statuses/fff65bd40ce98bfd9331a45df83a9c15b30467ce","head":{"label":"aspnet:best-effort","ref":"best-effort","sha":"fff65bd40ce98bfd9331a45df83a9c15b30467ce","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16300347,"name":"Routing","full_name":"aspnet/Routing","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Routing","description":"Middleware for routing requests to application logic.","fork":false,"url":"https://api.github.com/repos/aspnet/Routing","forks_url":"https://api.github.com/repos/aspnet/Routing/forks","keys_url":"https://api.github.com/repos/aspnet/Routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Routing/teams","hooks_url":"https://api.github.com/repos/aspnet/Routing/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Routing/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Routing/events","assignees_url":"https://api.github.com/repos/aspnet/Routing/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Routing/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Routing/tags","blobs_url":"https://api.github.com/repos/aspnet/Routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Routing/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Routing/languages","stargazers_url":"https://api.github.com/repos/aspnet/Routing/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Routing/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Routing/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Routing/subscription","commits_url":"https://api.github.com/repos/aspnet/Routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Routing/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Routing/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Routing/merges","archive_url":"https://api.github.com/repos/aspnet/Routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Routing/downloads","issues_url":"https://api.github.com/repos/aspnet/Routing/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Routing/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Routing/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Routing/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Routing/releases{/id}","created_at":"2014-01-28T02:50:39Z","updated_at":"2015-02-10T19:19:20Z","pushed_at":"2015-02-11T21:52:42Z","git_url":"git://github.com/aspnet/Routing.git","ssh_url":"git@github.com:aspnet/Routing.git","clone_url":"https://github.com/aspnet/Routing.git","svn_url":"https://github.com/aspnet/Routing","homepage":"","size":2826,"stargazers_count":100,"watchers_count":100,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":14,"forks":34,"open_issues":14,"watchers":100,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"67dcdbf8a1f4c1f45f8ce1a245e726bb14fb7ac9","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16300347,"name":"Routing","full_name":"aspnet/Routing","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Routing","description":"Middleware for routing requests to application logic.","fork":false,"url":"https://api.github.com/repos/aspnet/Routing","forks_url":"https://api.github.com/repos/aspnet/Routing/forks","keys_url":"https://api.github.com/repos/aspnet/Routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Routing/teams","hooks_url":"https://api.github.com/repos/aspnet/Routing/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Routing/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Routing/events","assignees_url":"https://api.github.com/repos/aspnet/Routing/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Routing/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Routing/tags","blobs_url":"https://api.github.com/repos/aspnet/Routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Routing/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Routing/languages","stargazers_url":"https://api.github.com/repos/aspnet/Routing/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Routing/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Routing/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Routing/subscription","commits_url":"https://api.github.com/repos/aspnet/Routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Routing/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Routing/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Routing/merges","archive_url":"https://api.github.com/repos/aspnet/Routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Routing/downloads","issues_url":"https://api.github.com/repos/aspnet/Routing/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Routing/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Routing/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Routing/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Routing/releases{/id}","created_at":"2014-01-28T02:50:39Z","updated_at":"2015-02-10T19:19:20Z","pushed_at":"2015-02-11T21:52:42Z","git_url":"git://github.com/aspnet/Routing.git","ssh_url":"git@github.com:aspnet/Routing.git","clone_url":"https://github.com/aspnet/Routing.git","svn_url":"https://github.com/aspnet/Routing","homepage":"","size":2826,"stargazers_count":100,"watchers_count":100,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":14,"forks":34,"open_issues":14,"watchers":100,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Routing/pulls/150"},"html":{"href":"https://github.com/aspnet/Routing/pull/150"},"issue":{"href":"https://api.github.com/repos/aspnet/Routing/issues/150"},"comments":{"href":"https://api.github.com/repos/aspnet/Routing/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Routing/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Routing/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Routing/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Routing/statuses/fff65bd40ce98bfd9331a45df83a9c15b30467ce"}}}}