{"action":"closed","number":631,"pull_request":{"url":"https://api.github.com/repos/linkedin/dustjs/pulls/631","id":33195520,"html_url":"https://github.com/linkedin/dustjs/pull/631","diff_url":"https://github.com/linkedin/dustjs/pull/631.diff","patch_url":"https://github.com/linkedin/dustjs/pull/631.patch","issue_url":"https://api.github.com/repos/linkedin/dustjs/issues/631","number":631,"state":"closed","locked":false,"title":"Try to avoid creating Stacks with no content when possible","user":{"login":"sethkinast","id":1399532,"avatar_url":"https://avatars.githubusercontent.com/u/1399532?v=3","gravatar_id":"","url":"https://api.github.com/users/sethkinast","html_url":"https://github.com/sethkinast","followers_url":"https://api.github.com/users/sethkinast/followers","following_url":"https://api.github.com/users/sethkinast/following{/other_user}","gists_url":"https://api.github.com/users/sethkinast/gists{/gist_id}","starred_url":"https://api.github.com/users/sethkinast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethkinast/subscriptions","organizations_url":"https://api.github.com/users/sethkinast/orgs","repos_url":"https://api.github.com/users/sethkinast/repos","events_url":"https://api.github.com/users/sethkinast/events{/privacy}","received_events_url":"https://api.github.com/users/sethkinast/received_events","type":"User","site_admin":false},"body":"https://github.com/linkedin/dustjs-helpers/pull/128 showed that it's possible to get nasty Stacks that only contain `undefined` when you use `dust.makeBase`. As much as possible this behavior should be avoided.\r\n\r\nNow the only way you can get one is if you explicitly push `undefined` onto a context stack... but then it's your own fault.\r\n\r\nContext pop and clone exercise a lot of context creation behavior, and we didn't have tests for them yet anyways, so killing all the birds with one PR.","created_at":"2015-04-13T19:33:14Z","updated_at":"2015-04-17T22:09:42Z","closed_at":"2015-04-17T22:09:42Z","merged_at":"2015-04-17T22:09:42Z","merge_commit_sha":"2f7112fe2c3c525dc578561da2c49d72a2cc91d9","assignee":null,"milestone":{"url":"https://api.github.com/repos/linkedin/dustjs/milestones/10","html_url":"https://github.com/linkedin/dustjs/milestones/2.7","labels_url":"https://api.github.com/repos/linkedin/dustjs/milestones/10/labels","id":1061141,"number":10,"title":"2.7","description":"","creator":{"login":"sethkinast","id":1399532,"avatar_url":"https://avatars.githubusercontent.com/u/1399532?v=3","gravatar_id":"","url":"https://api.github.com/users/sethkinast","html_url":"https://github.com/sethkinast","followers_url":"https://api.github.com/users/sethkinast/followers","following_url":"https://api.github.com/users/sethkinast/following{/other_user}","gists_url":"https://api.github.com/users/sethkinast/gists{/gist_id}","starred_url":"https://api.github.com/users/sethkinast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethkinast/subscriptions","organizations_url":"https://api.github.com/users/sethkinast/orgs","repos_url":"https://api.github.com/users/sethkinast/repos","events_url":"https://api.github.com/users/sethkinast/events{/privacy}","received_events_url":"https://api.github.com/users/sethkinast/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":12,"state":"open","created_at":"2015-04-09T22:56:07Z","updated_at":"2015-04-17T22:09:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/linkedin/dustjs/pulls/631/commits","review_comments_url":"https://api.github.com/repos/linkedin/dustjs/pulls/631/comments","review_comment_url":"https://api.github.com/repos/linkedin/dustjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/dustjs/issues/631/comments","statuses_url":"https://api.github.com/repos/linkedin/dustjs/statuses/8d6faec39d1fe1f59cda2b83a771838673871ab8","head":{"label":"sethkinast:undefined-head","ref":"undefined-head","sha":"8d6faec39d1fe1f59cda2b83a771838673871ab8","user":{"login":"sethkinast","id":1399532,"avatar_url":"https://avatars.githubusercontent.com/u/1399532?v=3","gravatar_id":"","url":"https://api.github.com/users/sethkinast","html_url":"https://github.com/sethkinast","followers_url":"https://api.github.com/users/sethkinast/followers","following_url":"https://api.github.com/users/sethkinast/following{/other_user}","gists_url":"https://api.github.com/users/sethkinast/gists{/gist_id}","starred_url":"https://api.github.com/users/sethkinast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethkinast/subscriptions","organizations_url":"https://api.github.com/users/sethkinast/orgs","repos_url":"https://api.github.com/users/sethkinast/repos","events_url":"https://api.github.com/users/sethkinast/events{/privacy}","received_events_url":"https://api.github.com/users/sethkinast/received_events","type":"User","site_admin":false},"repo":{"id":23441887,"name":"dustjs","full_name":"sethkinast/dustjs","owner":{"login":"sethkinast","id":1399532,"avatar_url":"https://avatars.githubusercontent.com/u/1399532?v=3","gravatar_id":"","url":"https://api.github.com/users/sethkinast","html_url":"https://github.com/sethkinast","followers_url":"https://api.github.com/users/sethkinast/followers","following_url":"https://api.github.com/users/sethkinast/following{/other_user}","gists_url":"https://api.github.com/users/sethkinast/gists{/gist_id}","starred_url":"https://api.github.com/users/sethkinast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethkinast/subscriptions","organizations_url":"https://api.github.com/users/sethkinast/orgs","repos_url":"https://api.github.com/users/sethkinast/repos","events_url":"https://api.github.com/users/sethkinast/events{/privacy}","received_events_url":"https://api.github.com/users/sethkinast/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sethkinast/dustjs","description":"Asynchronous templates for the browser and node.js","fork":true,"url":"https://api.github.com/repos/sethkinast/dustjs","forks_url":"https://api.github.com/repos/sethkinast/dustjs/forks","keys_url":"https://api.github.com/repos/sethkinast/dustjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sethkinast/dustjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sethkinast/dustjs/teams","hooks_url":"https://api.github.com/repos/sethkinast/dustjs/hooks","issue_events_url":"https://api.github.com/repos/sethkinast/dustjs/issues/events{/number}","events_url":"https://api.github.com/repos/sethkinast/dustjs/events","assignees_url":"https://api.github.com/repos/sethkinast/dustjs/assignees{/user}","branches_url":"https://api.github.com/repos/sethkinast/dustjs/branches{/branch}","tags_url":"https://api.github.com/repos/sethkinast/dustjs/tags","blobs_url":"https://api.github.com/repos/sethkinast/dustjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sethkinast/dustjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sethkinast/dustjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sethkinast/dustjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sethkinast/dustjs/statuses/{sha}","languages_url":"https://api.github.com/repos/sethkinast/dustjs/languages","stargazers_url":"https://api.github.com/repos/sethkinast/dustjs/stargazers","contributors_url":"https://api.github.com/repos/sethkinast/dustjs/contributors","subscribers_url":"https://api.github.com/repos/sethkinast/dustjs/subscribers","subscription_url":"https://api.github.com/repos/sethkinast/dustjs/subscription","commits_url":"https://api.github.com/repos/sethkinast/dustjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sethkinast/dustjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sethkinast/dustjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sethkinast/dustjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/sethkinast/dustjs/contents/{+path}","compare_url":"https://api.github.com/repos/sethkinast/dustjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sethkinast/dustjs/merges","archive_url":"https://api.github.com/repos/sethkinast/dustjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sethkinast/dustjs/downloads","issues_url":"https://api.github.com/repos/sethkinast/dustjs/issues{/number}","pulls_url":"https://api.github.com/repos/sethkinast/dustjs/pulls{/number}","milestones_url":"https://api.github.com/repos/sethkinast/dustjs/milestones{/number}","notifications_url":"https://api.github.com/repos/sethkinast/dustjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sethkinast/dustjs/labels{/name}","releases_url":"https://api.github.com/repos/sethkinast/dustjs/releases{/id}","created_at":"2014-08-28T20:27:51Z","updated_at":"2015-04-14T22:51:09Z","pushed_at":"2015-04-17T22:03:22Z","git_url":"git://github.com/sethkinast/dustjs.git","ssh_url":"git@github.com:sethkinast/dustjs.git","clone_url":"https://github.com/sethkinast/dustjs.git","svn_url":"https://github.com/sethkinast/dustjs","homepage":"","size":10034,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"7dd81eed25ccf63210cabfb99b5063079f6d184a","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":3813151,"name":"dustjs","full_name":"linkedin/dustjs","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/dustjs","description":"Asynchronous Javascript templating for the browser and server","fork":false,"url":"https://api.github.com/repos/linkedin/dustjs","forks_url":"https://api.github.com/repos/linkedin/dustjs/forks","keys_url":"https://api.github.com/repos/linkedin/dustjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/dustjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/dustjs/teams","hooks_url":"https://api.github.com/repos/linkedin/dustjs/hooks","issue_events_url":"https://api.github.com/repos/linkedin/dustjs/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/dustjs/events","assignees_url":"https://api.github.com/repos/linkedin/dustjs/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/dustjs/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/dustjs/tags","blobs_url":"https://api.github.com/repos/linkedin/dustjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/dustjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/dustjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/dustjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/dustjs/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/dustjs/languages","stargazers_url":"https://api.github.com/repos/linkedin/dustjs/stargazers","contributors_url":"https://api.github.com/repos/linkedin/dustjs/contributors","subscribers_url":"https://api.github.com/repos/linkedin/dustjs/subscribers","subscription_url":"https://api.github.com/repos/linkedin/dustjs/subscription","commits_url":"https://api.github.com/repos/linkedin/dustjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/dustjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/dustjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/dustjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/dustjs/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/dustjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/dustjs/merges","archive_url":"https://api.github.com/repos/linkedin/dustjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/dustjs/downloads","issues_url":"https://api.github.com/repos/linkedin/dustjs/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/dustjs/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/dustjs/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/dustjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/dustjs/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/dustjs/releases{/id}","created_at":"2012-03-23T22:20:39Z","updated_at":"2015-04-17T21:57:31Z","pushed_at":"2015-04-17T22:09:42Z","git_url":"git://github.com/linkedin/dustjs.git","ssh_url":"git@github.com:linkedin/dustjs.git","clone_url":"https://github.com/linkedin/dustjs.git","svn_url":"https://github.com/linkedin/dustjs","homepage":"http://dustjs.com","size":13316,"stargazers_count":1785,"watchers_count":1785,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":332,"mirror_url":null,"open_issues_count":52,"forks":332,"open_issues":52,"watchers":1785,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/dustjs/pulls/631"},"html":{"href":"https://github.com/linkedin/dustjs/pull/631"},"issue":{"href":"https://api.github.com/repos/linkedin/dustjs/issues/631"},"comments":{"href":"https://api.github.com/repos/linkedin/dustjs/issues/631/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/dustjs/pulls/631/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/dustjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/dustjs/pulls/631/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/dustjs/statuses/8d6faec39d1fe1f59cda2b83a771838673871ab8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"prashn64","id":1528886,"avatar_url":"https://avatars.githubusercontent.com/u/1528886?v=3","gravatar_id":"","url":"https://api.github.com/users/prashn64","html_url":"https://github.com/prashn64","followers_url":"https://api.github.com/users/prashn64/followers","following_url":"https://api.github.com/users/prashn64/following{/other_user}","gists_url":"https://api.github.com/users/prashn64/gists{/gist_id}","starred_url":"https://api.github.com/users/prashn64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prashn64/subscriptions","organizations_url":"https://api.github.com/users/prashn64/orgs","repos_url":"https://api.github.com/users/prashn64/repos","events_url":"https://api.github.com/users/prashn64/events{/privacy}","received_events_url":"https://api.github.com/users/prashn64/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":48,"deletions":10,"changed_files":3}}