{"action":"created","issue":{"url":"https://api.github.com/repos/01org/parameter-framework/issues/248","labels_url":"https://api.github.com/repos/01org/parameter-framework/issues/248/labels{/name}","comments_url":"https://api.github.com/repos/01org/parameter-framework/issues/248/comments","events_url":"https://api.github.com/repos/01org/parameter-framework/issues/248/events","html_url":"https://github.com/01org/parameter-framework/pull/248","id":107944305,"number":248,"title":"xmlserializer: load Xsd Schema from xml attribute","user":{"login":"miguelgaio","id":12096004,"avatar_url":"https://avatars.githubusercontent.com/u/12096004?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelgaio","html_url":"https://github.com/miguelgaio","followers_url":"https://api.github.com/users/miguelgaio/followers","following_url":"https://api.github.com/users/miguelgaio/following{/other_user}","gists_url":"https://api.github.com/users/miguelgaio/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelgaio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelgaio/subscriptions","organizations_url":"https://api.github.com/users/miguelgaio/orgs","repos_url":"https://api.github.com/users/miguelgaio/repos","events_url":"https://api.github.com/users/miguelgaio/events{/privacy}","received_events_url":"https://api.github.com/users/miguelgaio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/01org/parameter-framework/milestones/3","html_url":"https://github.com/01org/parameter-framework/milestones/Windows%20port","labels_url":"https://api.github.com/repos/01org/parameter-framework/milestones/3/labels","id":1297260,"number":3,"title":"Windows port","description":"Have the Parameter Framework compile on Windows.","creator":{"login":"dawagner","id":6430928,"avatar_url":"https://avatars.githubusercontent.com/u/6430928?v=3","gravatar_id":"","url":"https://api.github.com/users/dawagner","html_url":"https://github.com/dawagner","followers_url":"https://api.github.com/users/dawagner/followers","following_url":"https://api.github.com/users/dawagner/following{/other_user}","gists_url":"https://api.github.com/users/dawagner/gists{/gist_id}","starred_url":"https://api.github.com/users/dawagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawagner/subscriptions","organizations_url":"https://api.github.com/users/dawagner/orgs","repos_url":"https://api.github.com/users/dawagner/repos","events_url":"https://api.github.com/users/dawagner/events{/privacy}","received_events_url":"https://api.github.com/users/dawagner/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":48,"state":"open","created_at":"2015-09-09T08:28:52Z","updated_at":"2015-09-28T08:48:00Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-09-23T15:19:53Z","updated_at":"2015-09-28T11:39:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/01org/parameter-framework/pulls/248","html_url":"https://github.com/01org/parameter-framework/pull/248","diff_url":"https://github.com/01org/parameter-framework/pull/248.diff","patch_url":"https://github.com/01org/parameter-framework/pull/248.patch"},"body":"xsi:noNamespaceSchemaLocation provides xsd location.\r\nUse libxml2 API and the attribute to found out xsd schemas\r\n\r\nSigned-off-by: Miguel Gaio <miguel.gaio@intel.com>\r\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/01org/parameter-framework/pull/248%23issuecomment-142637504%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/248%23discussion_r40217333%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/248%23discussion_r40218494%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/248%23discussion_r40229458%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/248%23discussion_r40314448%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/248%23discussion_r40314653%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/248%23discussion_r40315214%22%2C%20%22https%3A//github.com/01org/parameter-framework/commit/6d585019284e04d0431848a7dba05d0df0c9929d%23commitcomment-13464296%22%2C%20%22https%3A//github.com/01org/parameter-framework/commit/6d585019284e04d0431848a7dba05d0df0c9929d%23commitcomment-13464298%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/248%23issuecomment-142637504%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%40dawagner%20%40krocard%20%40OznOg%20%40cc6565%20please%20review%22%2C%20%22created_at%22%3A%20%222015-09-23T15%3A20%3A34Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12096004%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/miguelgaio%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%207a207c7fd3341ebaf18501bf9f6b2f3d0efb0372%20test/functional-tests/CMakeLists.txt%204%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/248%23discussion_r40314653%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22unrelated%20change%22%2C%20%22created_at%22%3A%20%222015-09-24T12%3A50%3A43Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20test/functional-tests/CMakeLists.txt%3AL42-49%22%7D%2C%20%22Commit%206d585019284e04d0431848a7dba05d0df0c9929d%20test/functional-tests-legacy/Util/PfwUnitTestLib.py%204%2077%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/commit/6d585019284e04d0431848a7dba05d0df0c9929d%23commitcomment-13464296%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%60self.sendCmd%28%5C%22setValidateSchemasOnStart%20true%5C%22%29%60%22%2C%20%22created_at%22%3A%20%222015-09-28T09%3A42%3A08Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20test/functional-tests-legacy/Util/PfwUnitTestLib.py%3AL77%20%286d58501%29%22%7D%2C%20%22Pull%20d14954fb9e808b40ee07233c4f805e8f3962e1b1%20xmlserializer/XmlDocSource.cpp%2078%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/248%23discussion_r40217333%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22all%20those%20free%20could%20be%20removed%20with%20unique_ptr...%22%2C%20%22created_at%22%3A%20%222015-09-23T15%3A26%3A53Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6862950%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/krocard%22%7D%7D%2C%20%7B%22body%22%3A%20%22I%27m%20not%20sure%2C%20xmlFree%20is%20not%20delete%20or%20free%28%29%22%2C%20%22created_at%22%3A%20%222015-09-23T15%3A34%3A50Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12096004%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/miguelgaio%22%7D%7D%2C%20%7B%22body%22%3A%20%22unique_ptr%20can%20be%20provided%20with%20a%20custom%20deleter%20%28default%20is%20delete%2C%20not%20%5Cnfree%29.%5Cn%5CnOn%2009/23/2015%2005%3A34%20PM%2C%20miguelgaio%20wrote%3A%5Cn%3E%5Cn%3E%20In%20xmlserializer/XmlDocSource.cpp%20%5Cn%3E%20%3Chttps%3A//github.com/01org/parameter-framework/pull/248%23discussion_r40218494%3E%3A%5Cn%3E%5Cn%3E%20%3E%20%40%40%20-216%2C6%20%2B225%2C7%20%40%40%20bool%20CXmlDocSource%3A%3AisInstanceDocumentValid%28%29%5Cn%3E%20%3E%20%20%20%20%20%20xmlSchemaFree%28pSchema%29%3B%5Cn%3E%20%3E%20%20%20%20%20%20xmlSchemaFreeParserCtxt%28pParserCtxt%29%3B%5Cn%3E%20%3E%20%20%20%20%20%20xmlFreeDoc%28pSchemaDoc%29%3B%5Cn%3E%20%3E%20%2B%20%20%20%20xmlFree%28schemaURI%29%3B%5Cn%3E%5Cn%3E%20I%27m%20not%20sure%2C%20xmlFree%20is%20not%20delete%20or%20free%28%29%5Cn%3E%5Cn%3E%20%5Cu2014%5Cn%3E%20Reply%20to%20this%20email%20directly%20or%20view%20it%20on%20GitHub%20%5Cn%3E%20%3Chttps%3A//github.com/01org/parameter-framework/pull/248/files%23r40218494%3E.%5Cn%3E%5Cn%5Cn---------------------------------------------------------------------%5CnIntel%20Corporation%20SAS%20%28French%20simplified%20joint%20stock%20company%29%5CnRegistered%20headquarters%3A%20%5C%22Les%20Montalets%5C%22-%202%2C%20rue%20de%20Paris%2C%20%5Cn92196%20Meudon%20Cedex%2C%20France%5CnRegistration%20Number%3A%20%20302%20456%20199%20R.C.S.%20NANTERRE%5CnCapital%3A%204%2C572%2C000%20Euros%5Cn%5CnThis%20e-mail%20and%20any%20attachments%20may%20contain%20confidential%20material%20for%5Cnthe%20sole%20use%20of%20the%20intended%20recipient%28s%29.%20Any%20review%20or%20distribution%5Cnby%20others%20is%20strictly%20prohibited.%20If%20you%20are%20not%20the%20intended%5Cnrecipient%2C%20please%20contact%20the%20sender%20and%20delete%20all%20copies.%5Cn%22%2C%20%22created_at%22%3A%20%222015-09-23T17%3A07%3A18Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6862950%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/krocard%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20xmlserializer/XmlDocSource.cpp%3AL225-232%22%7D%2C%20%22Pull%207a207c7fd3341ebaf18501bf9f6b2f3d0efb0372%20test/CMakeLists.txt%204%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/248%23discussion_r40314448%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22It%20could%20be%20worth%20copying%20this%20directory%20in%20the%20legacy%20functional%20test%20dir%20too%20%28or%20instead%29.%20And%20if%20so%2C%20it%20should%20be%20done%20in%20%60functional-tests-legacy/CMakeLists.txt%60.%22%2C%20%22created_at%22%3A%20%222015-09-24T12%3A48%3A13Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20test/CMakeLists.txt%3AL26-34%22%7D%2C%20%22Commit%206d585019284e04d0431848a7dba05d0df0c9929d%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/commit/6d585019284e04d0431848a7dba05d0df0c9929d%23commitcomment-13464298%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A-1%3A%20%22%2C%20%22created_at%22%3A%20%222015-09-28T09%3A42%3A12Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22Commit%206d58501%20comments%22%7D%2C%20%22Pull%207a207c7fd3341ebaf18501bf9f6b2f3d0efb0372%20xmlserializer/XmlDocSource.h%205%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/248%23discussion_r40315214%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22This%20constructor%20seems%20unused.%20If%20so%2C%20you%20may%20remove%20it%20altogether%20%28in%20a%20separate%20patch%29.%22%2C%20%22created_at%22%3A%20%222015-09-24T12%3A57%3A41Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20xmlserializer/XmlDocSource.h%3AL57-75%22%7D%7D%7D'></a>\r\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\r\n- [x] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/248#issuecomment-142637504'>General Comment</a></b>\r\n- <a href='https://github.com/miguelgaio'><img border=0 src='https://avatars.githubusercontent.com/u/12096004?v=3' height=16 width=16'></a> @dawagner @krocard @OznOg @cc6565 please review\r\n- [x] <a href='#crh-comment-Pull d14954fb9e808b40ee07233c4f805e8f3962e1b1 xmlserializer/XmlDocSource.cpp 78'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/248#discussion_r40217333'>File: xmlserializer/XmlDocSource.cpp:L225-232</a></b>\r\n- <a href='https://github.com/krocard'><img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'></a> all those free could be removed with unique_ptr...\r\n- <a href='https://github.com/miguelgaio'><img border=0 src='https://avatars.githubusercontent.com/u/12096004?v=3' height=16 width=16'></a> I'm not sure, xmlFree is not delete or free()\r\n- <a href='https://github.com/krocard'><img border=0 src='https://avatars.githubusercontent.com/u/6862950?v=3' height=16 width=16'></a> unique_ptr can be provided with a custom deleter (default is delete, not\r\nfree).\r\nOn 09/23/2015 05:34 PM, miguelgaio wrote:\r\n>\r\n> In xmlserializer/XmlDocSource.cpp\r\n> <https://github.com/01org/parameter-framework/pull/248#discussion_r40218494>:\r\n>\r\n> > @@ -216,6 +225,7 @@ bool CXmlDocSource::isInstanceDocumentValid()\r\n> >      xmlSchemaFree(pSchema);\r\n> >      xmlSchemaFreeParserCtxt(pParserCtxt);\r\n> >      xmlFreeDoc(pSchemaDoc);\r\n> > +    xmlFree(schemaURI);\r\n>\r\n> I'm not sure, xmlFree is not delete or free()\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/01org/parameter-framework/pull/248/files#r40218494>.\r\n>\r\n---------------------------------------------------------------------\r\nIntel Corporation SAS (French simplified joint stock company)\r\nRegistered headquarters: \"Les Montalets\"- 2, rue de Paris,\r\n92196 Meudon Cedex, France\r\nRegistration Number:  302 456 199 R.C.S. NANTERRE\r\nCapital: 4,572,000 Euros\r\nThis e-mail and any attachments may contain confidential material for\r\nthe sole use of the intended recipient(s). Any review or distribution\r\nby others is strictly prohibited. If you are not the intended\r\nrecipient, please contact the sender and delete all copies.\r\n- [x] <a href='#crh-comment-Pull 7a207c7fd3341ebaf18501bf9f6b2f3d0efb0372 test/CMakeLists.txt 4'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/248#discussion_r40314448'>File: test/CMakeLists.txt:L26-34</a></b>\r\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> It could be worth copying this directory in the legacy functional test dir too (or instead). And if so, it should be done in `functional-tests-legacy/CMakeLists.txt`.\r\n- [x] <a href='#crh-comment-Pull 7a207c7fd3341ebaf18501bf9f6b2f3d0efb0372 test/functional-tests/CMakeLists.txt 4'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/248#discussion_r40314653'>File: test/functional-tests/CMakeLists.txt:L42-49</a></b>\r\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> unrelated change\r\n- [x] <a href='#crh-comment-Pull 7a207c7fd3341ebaf18501bf9f6b2f3d0efb0372 xmlserializer/XmlDocSource.h 5'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/248#discussion_r40315214'>File: xmlserializer/XmlDocSource.h:L57-75</a></b>\r\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> This constructor seems unused. If so, you may remove it altogether (in a separate patch).\r\n- [x] <a href='#crh-comment-Commit 6d585019284e04d0431848a7dba05d0df0c9929d test/functional-tests-legacy/Util/PfwUnitTestLib.py 4 77'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/commit/6d585019284e04d0431848a7dba05d0df0c9929d#commitcomment-13464296'>File: test/functional-tests-legacy/Util/PfwUnitTestLib.py:L77 (6d58501)</a></b>\r\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> `self.sendCmd(\"setValidateSchemasOnStart true\")`\r\n- [x] <a href='#crh-comment-Commit 6d585019284e04d0431848a7dba05d0df0c9929d'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/commit/6d585019284e04d0431848a7dba05d0df0c9929d#commitcomment-13464298'>Commit 6d58501 comments</a></b>\r\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> :-1:\r\n\r\n\r\n<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/248?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/248?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/01org/parameter-framework/pull/248'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\r\n<a href='#crh-end'></a>"},"comment":{"url":"https://api.github.com/repos/01org/parameter-framework/issues/comments/143719469","html_url":"https://github.com/01org/parameter-framework/pull/248#issuecomment-143719469","issue_url":"https://api.github.com/repos/01org/parameter-framework/issues/248","id":143719469,"user":{"login":"miguelgaio","id":12096004,"avatar_url":"https://avatars.githubusercontent.com/u/12096004?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelgaio","html_url":"https://github.com/miguelgaio","followers_url":"https://api.github.com/users/miguelgaio/followers","following_url":"https://api.github.com/users/miguelgaio/following{/other_user}","gists_url":"https://api.github.com/users/miguelgaio/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelgaio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelgaio/subscriptions","organizations_url":"https://api.github.com/users/miguelgaio/orgs","repos_url":"https://api.github.com/users/miguelgaio/repos","events_url":"https://api.github.com/users/miguelgaio/events{/privacy}","received_events_url":"https://api.github.com/users/miguelgaio/received_events","type":"User","site_admin":false},"created_at":"2015-09-28T11:39:26Z","updated_at":"2015-09-28T11:39:26Z","body":":+1:<a href='#crh-update-none'></a>"}}