{"action":"created","comment":{"url":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/comments/31793432","id":31793432,"diff_hunk":"@@ -34,11 +34,11 @@ def _get_client(cls=None, **kwargs):\n \n     params = {'startup_nodes': [{'host': '127.0.0.1', 'port': 7000}], 'socket_timeout': 10, 'decode_responses': False}\n     params.update(kwargs)\n-    return StrictRedisCluster(**params)\n+    return cls(**params)","path":"tests/conftest.py","position":14,"original_position":14,"commit_id":"6d2f49997226cb69f6ffcb196d8a2b13275c02fc","original_commit_id":"071ab3fcde3e577e4d8643a95d175ca51e258446","user":{"login":"iandyh","id":431658,"avatar_url":"https://avatars.githubusercontent.com/u/431658?v=3","gravatar_id":"","url":"https://api.github.com/users/iandyh","html_url":"https://github.com/iandyh","followers_url":"https://api.github.com/users/iandyh/followers","following_url":"https://api.github.com/users/iandyh/following{/other_user}","gists_url":"https://api.github.com/users/iandyh/gists{/gist_id}","starred_url":"https://api.github.com/users/iandyh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iandyh/subscriptions","organizations_url":"https://api.github.com/users/iandyh/orgs","repos_url":"https://api.github.com/users/iandyh/repos","events_url":"https://api.github.com/users/iandyh/events{/privacy}","received_events_url":"https://api.github.com/users/iandyh/received_events","type":"User","site_admin":false},"body":"@Grokzen Thanks for the fix. The UT fails because of this line and it was a bug before that providing a `cls` argument doesn't have any effect. ","created_at":"2015-06-05T07:51:08Z","updated_at":"2015-06-05T07:51:08Z","html_url":"https://github.com/Grokzen/redis-py-cluster/pull/73#discussion_r31793432","pull_request_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/comments/31793432"},"html":{"href":"https://github.com/Grokzen/redis-py-cluster/pull/73#discussion_r31793432"},"pull_request":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/73","id":35720365,"html_url":"https://github.com/Grokzen/redis-py-cluster/pull/73","diff_url":"https://github.com/Grokzen/redis-py-cluster/pull/73.diff","patch_url":"https://github.com/Grokzen/redis-py-cluster/pull/73.patch","issue_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/issues/73","number":73,"state":"open","locked":false,"title":"add redis cluster management commands: slots, info and nodes","user":{"login":"iandyh","id":431658,"avatar_url":"https://avatars.githubusercontent.com/u/431658?v=3","gravatar_id":"","url":"https://api.github.com/users/iandyh","html_url":"https://github.com/iandyh","followers_url":"https://api.github.com/users/iandyh/followers","following_url":"https://api.github.com/users/iandyh/following{/other_user}","gists_url":"https://api.github.com/users/iandyh/gists{/gist_id}","starred_url":"https://api.github.com/users/iandyh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iandyh/subscriptions","organizations_url":"https://api.github.com/users/iandyh/orgs","repos_url":"https://api.github.com/users/iandyh/repos","events_url":"https://api.github.com/users/iandyh/events{/privacy}","received_events_url":"https://api.github.com/users/iandyh/received_events","type":"User","site_admin":false},"body":"A quick implementation.\r\n\r\nThe usage will be: `rcm = RedisClusterMgt(startup_nodes); rcm.info()`\r\n\r\nThere are some reasons behind the design: \r\n\r\n1. Since the class `RedisClusterMgt` will focus on cluster operation specific commands, it makes no sense to pass `cluster` command every time. Instead, directly calling `info` or `nodes` will be more concise. This does make newbies confusing because it is different from the official documentation. But they can grasp the concept quickly IMO.\r\n\r\n2. Currently only three commands are implemented which are the ones related to meta data retrieval. The necessity of other types of commands is unknown since `redis-tri.rb` can do them well especially for complex commands like `addslots`\r\n\r\nI am open for discussion. And if the current design is enough, I can work on some other commands and the tests.\r\n\r\nThanks!\r\n","created_at":"2015-05-19T11:30:35Z","updated_at":"2015-06-05T07:51:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f877e8810221568468ce1f492e0de8553225c29","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/73/commits","review_comments_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/73/comments","review_comment_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/issues/73/comments","statuses_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/statuses/6d2f49997226cb69f6ffcb196d8a2b13275c02fc","head":{"label":"iandyh:cmds","ref":"cmds","sha":"6d2f49997226cb69f6ffcb196d8a2b13275c02fc","user":{"login":"iandyh","id":431658,"avatar_url":"https://avatars.githubusercontent.com/u/431658?v=3","gravatar_id":"","url":"https://api.github.com/users/iandyh","html_url":"https://github.com/iandyh","followers_url":"https://api.github.com/users/iandyh/followers","following_url":"https://api.github.com/users/iandyh/following{/other_user}","gists_url":"https://api.github.com/users/iandyh/gists{/gist_id}","starred_url":"https://api.github.com/users/iandyh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iandyh/subscriptions","organizations_url":"https://api.github.com/users/iandyh/orgs","repos_url":"https://api.github.com/users/iandyh/repos","events_url":"https://api.github.com/users/iandyh/events{/privacy}","received_events_url":"https://api.github.com/users/iandyh/received_events","type":"User","site_admin":false},"repo":{"id":33717867,"name":"redis-py-cluster","full_name":"iandyh/redis-py-cluster","owner":{"login":"iandyh","id":431658,"avatar_url":"https://avatars.githubusercontent.com/u/431658?v=3","gravatar_id":"","url":"https://api.github.com/users/iandyh","html_url":"https://github.com/iandyh","followers_url":"https://api.github.com/users/iandyh/followers","following_url":"https://api.github.com/users/iandyh/following{/other_user}","gists_url":"https://api.github.com/users/iandyh/gists{/gist_id}","starred_url":"https://api.github.com/users/iandyh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iandyh/subscriptions","organizations_url":"https://api.github.com/users/iandyh/orgs","repos_url":"https://api.github.com/users/iandyh/repos","events_url":"https://api.github.com/users/iandyh/events{/privacy}","received_events_url":"https://api.github.com/users/iandyh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iandyh/redis-py-cluster","description":"Python cluster client for the official cluster support targeted for redis 3.0","fork":true,"url":"https://api.github.com/repos/iandyh/redis-py-cluster","forks_url":"https://api.github.com/repos/iandyh/redis-py-cluster/forks","keys_url":"https://api.github.com/repos/iandyh/redis-py-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iandyh/redis-py-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iandyh/redis-py-cluster/teams","hooks_url":"https://api.github.com/repos/iandyh/redis-py-cluster/hooks","issue_events_url":"https://api.github.com/repos/iandyh/redis-py-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/iandyh/redis-py-cluster/events","assignees_url":"https://api.github.com/repos/iandyh/redis-py-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/iandyh/redis-py-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/iandyh/redis-py-cluster/tags","blobs_url":"https://api.github.com/repos/iandyh/redis-py-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iandyh/redis-py-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iandyh/redis-py-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/iandyh/redis-py-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iandyh/redis-py-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/iandyh/redis-py-cluster/languages","stargazers_url":"https://api.github.com/repos/iandyh/redis-py-cluster/stargazers","contributors_url":"https://api.github.com/repos/iandyh/redis-py-cluster/contributors","subscribers_url":"https://api.github.com/repos/iandyh/redis-py-cluster/subscribers","subscription_url":"https://api.github.com/repos/iandyh/redis-py-cluster/subscription","commits_url":"https://api.github.com/repos/iandyh/redis-py-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/iandyh/redis-py-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/iandyh/redis-py-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/iandyh/redis-py-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/iandyh/redis-py-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/iandyh/redis-py-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iandyh/redis-py-cluster/merges","archive_url":"https://api.github.com/repos/iandyh/redis-py-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iandyh/redis-py-cluster/downloads","issues_url":"https://api.github.com/repos/iandyh/redis-py-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/iandyh/redis-py-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/iandyh/redis-py-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/iandyh/redis-py-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iandyh/redis-py-cluster/labels{/name}","releases_url":"https://api.github.com/repos/iandyh/redis-py-cluster/releases{/id}","created_at":"2015-04-10T08:38:20Z","updated_at":"2015-04-10T08:38:20Z","pushed_at":"2015-06-05T07:48:32Z","git_url":"git://github.com/iandyh/redis-py-cluster.git","ssh_url":"git@github.com:iandyh/redis-py-cluster.git","clone_url":"https://github.com/iandyh/redis-py-cluster.git","svn_url":"https://github.com/iandyh/redis-py-cluster","homepage":null,"size":413,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"unstable"}},"base":{"label":"Grokzen:unstable","ref":"unstable","sha":"9534a2c06a8155c490157b9c4de7800cea192f23","user":{"login":"Grokzen","id":892309,"avatar_url":"https://avatars.githubusercontent.com/u/892309?v=3","gravatar_id":"","url":"https://api.github.com/users/Grokzen","html_url":"https://github.com/Grokzen","followers_url":"https://api.github.com/users/Grokzen/followers","following_url":"https://api.github.com/users/Grokzen/following{/other_user}","gists_url":"https://api.github.com/users/Grokzen/gists{/gist_id}","starred_url":"https://api.github.com/users/Grokzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grokzen/subscriptions","organizations_url":"https://api.github.com/users/Grokzen/orgs","repos_url":"https://api.github.com/users/Grokzen/repos","events_url":"https://api.github.com/users/Grokzen/events{/privacy}","received_events_url":"https://api.github.com/users/Grokzen/received_events","type":"User","site_admin":false},"repo":{"id":10189555,"name":"redis-py-cluster","full_name":"Grokzen/redis-py-cluster","owner":{"login":"Grokzen","id":892309,"avatar_url":"https://avatars.githubusercontent.com/u/892309?v=3","gravatar_id":"","url":"https://api.github.com/users/Grokzen","html_url":"https://github.com/Grokzen","followers_url":"https://api.github.com/users/Grokzen/followers","following_url":"https://api.github.com/users/Grokzen/following{/other_user}","gists_url":"https://api.github.com/users/Grokzen/gists{/gist_id}","starred_url":"https://api.github.com/users/Grokzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grokzen/subscriptions","organizations_url":"https://api.github.com/users/Grokzen/orgs","repos_url":"https://api.github.com/users/Grokzen/repos","events_url":"https://api.github.com/users/Grokzen/events{/privacy}","received_events_url":"https://api.github.com/users/Grokzen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Grokzen/redis-py-cluster","description":"Python cluster client for the official cluster support targeted for redis 3.0","fork":false,"url":"https://api.github.com/repos/Grokzen/redis-py-cluster","forks_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/forks","keys_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/teams","hooks_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/hooks","issue_events_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/events","assignees_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/tags","blobs_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/languages","stargazers_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/stargazers","contributors_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/contributors","subscribers_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/subscribers","subscription_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/subscription","commits_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/merges","archive_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/downloads","issues_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/labels{/name}","releases_url":"https://api.github.com/repos/Grokzen/redis-py-cluster/releases{/id}","created_at":"2013-05-21T06:41:34Z","updated_at":"2015-06-04T08:19:55Z","pushed_at":"2015-06-05T07:48:33Z","git_url":"git://github.com/Grokzen/redis-py-cluster.git","ssh_url":"git@github.com:Grokzen/redis-py-cluster.git","clone_url":"https://github.com/Grokzen/redis-py-cluster.git","svn_url":"https://github.com/Grokzen/redis-py-cluster","homepage":null,"size":1333,"stargazers_count":98,"watchers_count":98,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":10,"forks":29,"open_issues":10,"watchers":98,"default_branch":"unstable"}},"_links":{"self":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/73"},"html":{"href":"https://github.com/Grokzen/redis-py-cluster/pull/73"},"issue":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/issues/73"},"comments":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/Grokzen/redis-py-cluster/statuses/6d2f49997226cb69f6ffcb196d8a2b13275c02fc"}}}}