{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/cerner/cerner_kafka/pulls/18","id":35855471,"html_url":"https://github.com/cerner/cerner_kafka/pull/18","diff_url":"https://github.com/cerner/cerner_kafka/pull/18.diff","patch_url":"https://github.com/cerner/cerner_kafka/pull/18.patch","issue_url":"https://api.github.com/repos/cerner/cerner_kafka/issues/18","number":18,"state":"closed","locked":false,"title":"fix adding nil if hostname isn't set up first","user":{"login":"TD-4242","id":3487671,"avatar_url":"https://avatars.githubusercontent.com/u/3487671?v=3","gravatar_id":"","url":"https://api.github.com/users/TD-4242","html_url":"https://github.com/TD-4242","followers_url":"https://api.github.com/users/TD-4242/followers","following_url":"https://api.github.com/users/TD-4242/following{/other_user}","gists_url":"https://api.github.com/users/TD-4242/gists{/gist_id}","starred_url":"https://api.github.com/users/TD-4242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TD-4242/subscriptions","organizations_url":"https://api.github.com/users/TD-4242/orgs","repos_url":"https://api.github.com/users/TD-4242/repos","events_url":"https://api.github.com/users/TD-4242/events{/privacy}","received_events_url":"https://api.github.com/users/TD-4242/received_events","type":"User","site_admin":false},"body":"This one small block of code had caused me more headache then anything else so I wanted to send a fix.\r\n\r\nIn my chef runs the hostname may not be setup prior to the first run so I would always get a compile error if cerner_kafka was in my run_list with:\r\n```\r\nundefined method `+' for nil:NilClass\r\n```\r\nThen the entire run would die and it would never setup the host.  by moving the brokerId increment after the check and using a return I can now bail out of the cerner_kafka cookbook on my first run and allow the host to be setup and kafka can get setup on a consecutive run.  I also added a bit better message to output so I could see what each item was set to and what it was looking for.\r\n\r\nA better way may be to do a lazy evaluation of the broker ID prior to writing the template.","created_at":"2015-05-20T17:21:20Z","updated_at":"2015-05-29T15:46:49Z","closed_at":"2015-05-29T15:46:49Z","merged_at":"2015-05-29T15:46:49Z","merge_commit_sha":"e203514b78306b4c3acdce2062ee8fe067c33e2d","assignee":null,"milestone":{"url":"https://api.github.com/repos/cerner/cerner_kafka/milestones/2","html_url":"https://github.com/cerner/cerner_kafka/milestones/1.1.0","labels_url":"https://api.github.com/repos/cerner/cerner_kafka/milestones/2/labels","id":836450,"number":2,"title":"1.1.0","description":"","creator":{"login":"bbaugher","id":2530095,"avatar_url":"https://avatars.githubusercontent.com/u/2530095?v=3","gravatar_id":"","url":"https://api.github.com/users/bbaugher","html_url":"https://github.com/bbaugher","followers_url":"https://api.github.com/users/bbaugher/followers","following_url":"https://api.github.com/users/bbaugher/following{/other_user}","gists_url":"https://api.github.com/users/bbaugher/gists{/gist_id}","starred_url":"https://api.github.com/users/bbaugher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbaugher/subscriptions","organizations_url":"https://api.github.com/users/bbaugher/orgs","repos_url":"https://api.github.com/users/bbaugher/repos","events_url":"https://api.github.com/users/bbaugher/events{/privacy}","received_events_url":"https://api.github.com/users/bbaugher/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":7,"state":"open","created_at":"2014-10-22T19:54:46Z","updated_at":"2015-05-29T15:46:49Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cerner/cerner_kafka/pulls/18/commits","review_comments_url":"https://api.github.com/repos/cerner/cerner_kafka/pulls/18/comments","review_comment_url":"https://api.github.com/repos/cerner/cerner_kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerner/cerner_kafka/issues/18/comments","statuses_url":"https://api.github.com/repos/cerner/cerner_kafka/statuses/2e80da43530f89a728424c3bd36071384108159b","head":{"label":"TD-4242:master","ref":"master","sha":"2e80da43530f89a728424c3bd36071384108159b","user":{"login":"TD-4242","id":3487671,"avatar_url":"https://avatars.githubusercontent.com/u/3487671?v=3","gravatar_id":"","url":"https://api.github.com/users/TD-4242","html_url":"https://github.com/TD-4242","followers_url":"https://api.github.com/users/TD-4242/followers","following_url":"https://api.github.com/users/TD-4242/following{/other_user}","gists_url":"https://api.github.com/users/TD-4242/gists{/gist_id}","starred_url":"https://api.github.com/users/TD-4242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TD-4242/subscriptions","organizations_url":"https://api.github.com/users/TD-4242/orgs","repos_url":"https://api.github.com/users/TD-4242/repos","events_url":"https://api.github.com/users/TD-4242/events{/privacy}","received_events_url":"https://api.github.com/users/TD-4242/received_events","type":"User","site_admin":false},"repo":{"id":35962332,"name":"cerner_kafka","full_name":"TD-4242/cerner_kafka","owner":{"login":"TD-4242","id":3487671,"avatar_url":"https://avatars.githubusercontent.com/u/3487671?v=3","gravatar_id":"","url":"https://api.github.com/users/TD-4242","html_url":"https://github.com/TD-4242","followers_url":"https://api.github.com/users/TD-4242/followers","following_url":"https://api.github.com/users/TD-4242/following{/other_user}","gists_url":"https://api.github.com/users/TD-4242/gists{/gist_id}","starred_url":"https://api.github.com/users/TD-4242/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TD-4242/subscriptions","organizations_url":"https://api.github.com/users/TD-4242/orgs","repos_url":"https://api.github.com/users/TD-4242/repos","events_url":"https://api.github.com/users/TD-4242/events{/privacy}","received_events_url":"https://api.github.com/users/TD-4242/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TD-4242/cerner_kafka","description":"A Kafka Cookbook for Chef","fork":true,"url":"https://api.github.com/repos/TD-4242/cerner_kafka","forks_url":"https://api.github.com/repos/TD-4242/cerner_kafka/forks","keys_url":"https://api.github.com/repos/TD-4242/cerner_kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TD-4242/cerner_kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TD-4242/cerner_kafka/teams","hooks_url":"https://api.github.com/repos/TD-4242/cerner_kafka/hooks","issue_events_url":"https://api.github.com/repos/TD-4242/cerner_kafka/issues/events{/number}","events_url":"https://api.github.com/repos/TD-4242/cerner_kafka/events","assignees_url":"https://api.github.com/repos/TD-4242/cerner_kafka/assignees{/user}","branches_url":"https://api.github.com/repos/TD-4242/cerner_kafka/branches{/branch}","tags_url":"https://api.github.com/repos/TD-4242/cerner_kafka/tags","blobs_url":"https://api.github.com/repos/TD-4242/cerner_kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TD-4242/cerner_kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TD-4242/cerner_kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/TD-4242/cerner_kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TD-4242/cerner_kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/TD-4242/cerner_kafka/languages","stargazers_url":"https://api.github.com/repos/TD-4242/cerner_kafka/stargazers","contributors_url":"https://api.github.com/repos/TD-4242/cerner_kafka/contributors","subscribers_url":"https://api.github.com/repos/TD-4242/cerner_kafka/subscribers","subscription_url":"https://api.github.com/repos/TD-4242/cerner_kafka/subscription","commits_url":"https://api.github.com/repos/TD-4242/cerner_kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/TD-4242/cerner_kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/TD-4242/cerner_kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/TD-4242/cerner_kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/TD-4242/cerner_kafka/contents/{+path}","compare_url":"https://api.github.com/repos/TD-4242/cerner_kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TD-4242/cerner_kafka/merges","archive_url":"https://api.github.com/repos/TD-4242/cerner_kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TD-4242/cerner_kafka/downloads","issues_url":"https://api.github.com/repos/TD-4242/cerner_kafka/issues{/number}","pulls_url":"https://api.github.com/repos/TD-4242/cerner_kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/TD-4242/cerner_kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/TD-4242/cerner_kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TD-4242/cerner_kafka/labels{/name}","releases_url":"https://api.github.com/repos/TD-4242/cerner_kafka/releases{/id}","created_at":"2015-05-20T17:11:52Z","updated_at":"2015-05-20T17:11:52Z","pushed_at":"2015-05-21T20:36:29Z","git_url":"git://github.com/TD-4242/cerner_kafka.git","ssh_url":"git@github.com:TD-4242/cerner_kafka.git","clone_url":"https://github.com/TD-4242/cerner_kafka.git","svn_url":"https://github.com/TD-4242/cerner_kafka","homepage":null,"size":163,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cerner:master","ref":"master","sha":"49ea4d5e6af29fc070f8be095487864247b61e83","user":{"login":"cerner","id":1873208,"avatar_url":"https://avatars.githubusercontent.com/u/1873208?v=3","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":24905148,"name":"cerner_kafka","full_name":"cerner/cerner_kafka","owner":{"login":"cerner","id":1873208,"avatar_url":"https://avatars.githubusercontent.com/u/1873208?v=3","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerner/cerner_kafka","description":"A Kafka Cookbook for Chef","fork":false,"url":"https://api.github.com/repos/cerner/cerner_kafka","forks_url":"https://api.github.com/repos/cerner/cerner_kafka/forks","keys_url":"https://api.github.com/repos/cerner/cerner_kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/cerner_kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/cerner_kafka/teams","hooks_url":"https://api.github.com/repos/cerner/cerner_kafka/hooks","issue_events_url":"https://api.github.com/repos/cerner/cerner_kafka/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/cerner_kafka/events","assignees_url":"https://api.github.com/repos/cerner/cerner_kafka/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/cerner_kafka/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/cerner_kafka/tags","blobs_url":"https://api.github.com/repos/cerner/cerner_kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/cerner_kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/cerner_kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/cerner_kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/cerner_kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/cerner_kafka/languages","stargazers_url":"https://api.github.com/repos/cerner/cerner_kafka/stargazers","contributors_url":"https://api.github.com/repos/cerner/cerner_kafka/contributors","subscribers_url":"https://api.github.com/repos/cerner/cerner_kafka/subscribers","subscription_url":"https://api.github.com/repos/cerner/cerner_kafka/subscription","commits_url":"https://api.github.com/repos/cerner/cerner_kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/cerner_kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/cerner_kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/cerner_kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/cerner_kafka/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/cerner_kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/cerner_kafka/merges","archive_url":"https://api.github.com/repos/cerner/cerner_kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/cerner_kafka/downloads","issues_url":"https://api.github.com/repos/cerner/cerner_kafka/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/cerner_kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/cerner_kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/cerner_kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/cerner_kafka/labels{/name}","releases_url":"https://api.github.com/repos/cerner/cerner_kafka/releases{/id}","created_at":"2014-10-07T18:30:24Z","updated_at":"2015-04-15T02:41:29Z","pushed_at":"2015-05-29T15:46:49Z","git_url":"git://github.com/cerner/cerner_kafka.git","ssh_url":"git@github.com:cerner/cerner_kafka.git","clone_url":"https://github.com/cerner/cerner_kafka.git","svn_url":"https://github.com/cerner/cerner_kafka","homepage":null,"size":535,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":8,"forks":9,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerner/cerner_kafka/pulls/18"},"html":{"href":"https://github.com/cerner/cerner_kafka/pull/18"},"issue":{"href":"https://api.github.com/repos/cerner/cerner_kafka/issues/18"},"comments":{"href":"https://api.github.com/repos/cerner/cerner_kafka/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/cerner/cerner_kafka/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/cerner/cerner_kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerner/cerner_kafka/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/cerner/cerner_kafka/statuses/2e80da43530f89a728424c3bd36071384108159b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bbaugher","id":2530095,"avatar_url":"https://avatars.githubusercontent.com/u/2530095?v=3","gravatar_id":"","url":"https://api.github.com/users/bbaugher","html_url":"https://github.com/bbaugher","followers_url":"https://api.github.com/users/bbaugher/followers","following_url":"https://api.github.com/users/bbaugher/following{/other_user}","gists_url":"https://api.github.com/users/bbaugher/gists{/gist_id}","starred_url":"https://api.github.com/users/bbaugher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbaugher/subscriptions","organizations_url":"https://api.github.com/users/bbaugher/orgs","repos_url":"https://api.github.com/users/bbaugher/repos","events_url":"https://api.github.com/users/bbaugher/events{/privacy}","received_events_url":"https://api.github.com/users/bbaugher/received_events","type":"User","site_admin":false},"comments":21,"review_comments":1,"commits":6,"additions":40,"deletions":42,"changed_files":2}}