{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/9222","labels_url":"https://api.github.com/repos/apache/spark/issues/9222/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/9222/comments","events_url":"https://api.github.com/repos/apache/spark/issues/9222/events","html_url":"https://github.com/apache/spark/pull/9222","id":112758904,"number":9222,"title":"SPARK-11258 Remove quadratic runtime complexity for converting a Spark DataFrame into an R data.frame","user":{"login":"FRosner","id":3427394,"avatar_url":"https://avatars.githubusercontent.com/u/3427394?v=3","gravatar_id":"","url":"https://api.github.com/users/FRosner","html_url":"https://github.com/FRosner","followers_url":"https://api.github.com/users/FRosner/followers","following_url":"https://api.github.com/users/FRosner/following{/other_user}","gists_url":"https://api.github.com/users/FRosner/gists{/gist_id}","starred_url":"https://api.github.com/users/FRosner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRosner/subscriptions","organizations_url":"https://api.github.com/users/FRosner/orgs","repos_url":"https://api.github.com/users/FRosner/repos","events_url":"https://api.github.com/users/FRosner/events{/privacy}","received_events_url":"https://api.github.com/users/FRosner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-10-22T08:50:32Z","updated_at":"2015-10-23T07:10:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/9222","html_url":"https://github.com/apache/spark/pull/9222","diff_url":"https://github.com/apache/spark/pull/9222.diff","patch_url":"https://github.com/apache/spark/pull/9222.patch"},"body":"https://issues.apache.org/jira/browse/SPARK-11258\r\n\r\nI was not able to locate an existing unit test for this function so I wrote one."},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/150494394","html_url":"https://github.com/apache/spark/pull/9222#issuecomment-150494394","issue_url":"https://api.github.com/repos/apache/spark/issues/9222","id":150494394,"user":{"login":"FRosner","id":3427394,"avatar_url":"https://avatars.githubusercontent.com/u/3427394?v=3","gravatar_id":"","url":"https://api.github.com/users/FRosner","html_url":"https://github.com/FRosner","followers_url":"https://api.github.com/users/FRosner/followers","following_url":"https://api.github.com/users/FRosner/following{/other_user}","gists_url":"https://api.github.com/users/FRosner/gists{/gist_id}","starred_url":"https://api.github.com/users/FRosner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRosner/subscriptions","organizations_url":"https://api.github.com/users/FRosner/orgs","repos_url":"https://api.github.com/users/FRosner/repos","events_url":"https://api.github.com/users/FRosner/events{/privacy}","received_events_url":"https://api.github.com/users/FRosner/received_events","type":"User","site_admin":false},"created_at":"2015-10-23T07:10:54Z","updated_at":"2015-10-23T07:10:54Z","body":"@sun-rui so there is an existing R test case for this method? In the end I just did a refactoring so existing tests should not break.\r\n\r\nThe idea of unit tests however is to test one thing. A unit test for a method should test exactly what this method is doing and not other related things like serde. If serde breaks, you still want to test for this method to succeed, because it is working. And since it is public API, anyone using Spark can use it."}}