{"action":"created","comment":{"url":"https://api.github.com/repos/qcubed/framework/pulls/comments/26544545","id":26544545,"diff_hunk":"@@ -815,54 +815,62 @@ public function ModelConnectorLabelVariableName($objColumn) {\n \t\t *\n \t\t * @param QColumn|QReverseReference|QManyToManyReference $objColumn\n \t\t *\n-\t\t * @return string Class name of control which can handle this column's data\n+\t\t * @return AbstractControl_CodeGenerator helper object\n \t\t * @throws Exception\n \t\t */\n-\t\tpublic function ModelConnectorControlClass($objColumn) {\n-\n+\t\tpublic function GetControlCodeGenerator($objColumn) {","path":"includes/codegen/QCodeGenBase.class.php","position":30,"original_position":30,"commit_id":"1abd64098bba77bd1f7360799950b3c7477c982c","original_commit_id":"1abd64098bba77bd1f7360799950b3c7477c982c","user":{"login":"spekary","id":755757,"avatar_url":"https://avatars.githubusercontent.com/u/755757?v=3","gravatar_id":"","url":"https://api.github.com/users/spekary","html_url":"https://github.com/spekary","followers_url":"https://api.github.com/users/spekary/followers","following_url":"https://api.github.com/users/spekary/following{/other_user}","gists_url":"https://api.github.com/users/spekary/gists{/gist_id}","starred_url":"https://api.github.com/users/spekary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spekary/subscriptions","organizations_url":"https://api.github.com/users/spekary/orgs","repos_url":"https://api.github.com/users/spekary/repos","events_url":"https://api.github.com/users/spekary/events{/privacy}","received_events_url":"https://api.github.com/users/spekary/received_events","type":"User","site_admin":false},"body":"You removed ModelConnectorControlClass and replaced it with this. This is more difficult to override in QCodeGen.php and specify a default class for each table type. I would prefer you to reinstate ModelConnectorControlClass, and then base this function on the results of that function. That would make it much easier for a developer to specify default classes for data types.","created_at":"2015-03-17T02:04:36Z","updated_at":"2015-03-17T02:04:36Z","html_url":"https://github.com/qcubed/framework/pull/655#discussion_r26544545","pull_request_url":"https://api.github.com/repos/qcubed/framework/pulls/655","_links":{"self":{"href":"https://api.github.com/repos/qcubed/framework/pulls/comments/26544545"},"html":{"href":"https://github.com/qcubed/framework/pull/655#discussion_r26544545"},"pull_request":{"href":"https://api.github.com/repos/qcubed/framework/pulls/655"}}},"pull_request":{"url":"https://api.github.com/repos/qcubed/framework/pulls/655","id":30984245,"html_url":"https://github.com/qcubed/framework/pull/655","diff_url":"https://github.com/qcubed/framework/pull/655.diff","patch_url":"https://github.com/qcubed/framework/pull/655.patch","issue_url":"https://api.github.com/repos/qcubed/framework/issues/655","number":655,"state":"open","locked":false,"title":"Model connector codegen refactor phase1","user":{"login":"vakopian","id":2228819,"avatar_url":"https://avatars.githubusercontent.com/u/2228819?v=3","gravatar_id":"","url":"https://api.github.com/users/vakopian","html_url":"https://github.com/vakopian","followers_url":"https://api.github.com/users/vakopian/followers","following_url":"https://api.github.com/users/vakopian/following{/other_user}","gists_url":"https://api.github.com/users/vakopian/gists{/gist_id}","starred_url":"https://api.github.com/users/vakopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vakopian/subscriptions","organizations_url":"https://api.github.com/users/vakopian/orgs","repos_url":"https://api.github.com/users/vakopian/repos","events_url":"https://api.github.com/users/vakopian/events{/privacy}","received_events_url":"https://api.github.com/users/vakopian/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-11T20:55:30Z","updated_at":"2015-03-17T02:04:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ca5ddbd0b6e53a0eeb9e2f0b33f145eede8662d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/qcubed/framework/pulls/655/commits","review_comments_url":"https://api.github.com/repos/qcubed/framework/pulls/655/comments","review_comment_url":"https://api.github.com/repos/qcubed/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qcubed/framework/issues/655/comments","statuses_url":"https://api.github.com/repos/qcubed/framework/statuses/1abd64098bba77bd1f7360799950b3c7477c982c","head":{"label":"vakopian:model-connector-codegen-refactor-phase1","ref":"model-connector-codegen-refactor-phase1","sha":"1abd64098bba77bd1f7360799950b3c7477c982c","user":{"login":"vakopian","id":2228819,"avatar_url":"https://avatars.githubusercontent.com/u/2228819?v=3","gravatar_id":"","url":"https://api.github.com/users/vakopian","html_url":"https://github.com/vakopian","followers_url":"https://api.github.com/users/vakopian/followers","following_url":"https://api.github.com/users/vakopian/following{/other_user}","gists_url":"https://api.github.com/users/vakopian/gists{/gist_id}","starred_url":"https://api.github.com/users/vakopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vakopian/subscriptions","organizations_url":"https://api.github.com/users/vakopian/orgs","repos_url":"https://api.github.com/users/vakopian/repos","events_url":"https://api.github.com/users/vakopian/events{/privacy}","received_events_url":"https://api.github.com/users/vakopian/received_events","type":"User","site_admin":false},"repo":{"id":13707023,"name":"jqcubed","full_name":"vakopian/jqcubed","owner":{"login":"vakopian","id":2228819,"avatar_url":"https://avatars.githubusercontent.com/u/2228819?v=3","gravatar_id":"","url":"https://api.github.com/users/vakopian","html_url":"https://github.com/vakopian","followers_url":"https://api.github.com/users/vakopian/followers","following_url":"https://api.github.com/users/vakopian/following{/other_user}","gists_url":"https://api.github.com/users/vakopian/gists{/gist_id}","starred_url":"https://api.github.com/users/vakopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vakopian/subscriptions","organizations_url":"https://api.github.com/users/vakopian/orgs","repos_url":"https://api.github.com/users/vakopian/repos","events_url":"https://api.github.com/users/vakopian/events{/privacy}","received_events_url":"https://api.github.com/users/vakopian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vakopian/jqcubed","description":"The official QCubed framework git repo","fork":true,"url":"https://api.github.com/repos/vakopian/jqcubed","forks_url":"https://api.github.com/repos/vakopian/jqcubed/forks","keys_url":"https://api.github.com/repos/vakopian/jqcubed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vakopian/jqcubed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vakopian/jqcubed/teams","hooks_url":"https://api.github.com/repos/vakopian/jqcubed/hooks","issue_events_url":"https://api.github.com/repos/vakopian/jqcubed/issues/events{/number}","events_url":"https://api.github.com/repos/vakopian/jqcubed/events","assignees_url":"https://api.github.com/repos/vakopian/jqcubed/assignees{/user}","branches_url":"https://api.github.com/repos/vakopian/jqcubed/branches{/branch}","tags_url":"https://api.github.com/repos/vakopian/jqcubed/tags","blobs_url":"https://api.github.com/repos/vakopian/jqcubed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vakopian/jqcubed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vakopian/jqcubed/git/refs{/sha}","trees_url":"https://api.github.com/repos/vakopian/jqcubed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vakopian/jqcubed/statuses/{sha}","languages_url":"https://api.github.com/repos/vakopian/jqcubed/languages","stargazers_url":"https://api.github.com/repos/vakopian/jqcubed/stargazers","contributors_url":"https://api.github.com/repos/vakopian/jqcubed/contributors","subscribers_url":"https://api.github.com/repos/vakopian/jqcubed/subscribers","subscription_url":"https://api.github.com/repos/vakopian/jqcubed/subscription","commits_url":"https://api.github.com/repos/vakopian/jqcubed/commits{/sha}","git_commits_url":"https://api.github.com/repos/vakopian/jqcubed/git/commits{/sha}","comments_url":"https://api.github.com/repos/vakopian/jqcubed/comments{/number}","issue_comment_url":"https://api.github.com/repos/vakopian/jqcubed/issues/comments{/number}","contents_url":"https://api.github.com/repos/vakopian/jqcubed/contents/{+path}","compare_url":"https://api.github.com/repos/vakopian/jqcubed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vakopian/jqcubed/merges","archive_url":"https://api.github.com/repos/vakopian/jqcubed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vakopian/jqcubed/downloads","issues_url":"https://api.github.com/repos/vakopian/jqcubed/issues{/number}","pulls_url":"https://api.github.com/repos/vakopian/jqcubed/pulls{/number}","milestones_url":"https://api.github.com/repos/vakopian/jqcubed/milestones{/number}","notifications_url":"https://api.github.com/repos/vakopian/jqcubed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vakopian/jqcubed/labels{/name}","releases_url":"https://api.github.com/repos/vakopian/jqcubed/releases{/id}","created_at":"2013-10-19T19:09:05Z","updated_at":"2015-02-20T19:56:52Z","pushed_at":"2015-03-15T21:05:16Z","git_url":"git://github.com/vakopian/jqcubed.git","ssh_url":"git@github.com:vakopian/jqcubed.git","clone_url":"https://github.com/vakopian/jqcubed.git","svn_url":"https://github.com/vakopian/jqcubed","homepage":null,"size":15888,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qcubed:alpha-3.0","ref":"alpha-3.0","sha":"bbf8a204b72b40055a72210f433353006ceeff45","user":{"login":"qcubed","id":330382,"avatar_url":"https://avatars.githubusercontent.com/u/330382?v=3","gravatar_id":"","url":"https://api.github.com/users/qcubed","html_url":"https://github.com/qcubed","followers_url":"https://api.github.com/users/qcubed/followers","following_url":"https://api.github.com/users/qcubed/following{/other_user}","gists_url":"https://api.github.com/users/qcubed/gists{/gist_id}","starred_url":"https://api.github.com/users/qcubed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qcubed/subscriptions","organizations_url":"https://api.github.com/users/qcubed/orgs","repos_url":"https://api.github.com/users/qcubed/repos","events_url":"https://api.github.com/users/qcubed/events{/privacy}","received_events_url":"https://api.github.com/users/qcubed/received_events","type":"Organization","site_admin":false},"repo":{"id":6742077,"name":"framework","full_name":"qcubed/framework","owner":{"login":"qcubed","id":330382,"avatar_url":"https://avatars.githubusercontent.com/u/330382?v=3","gravatar_id":"","url":"https://api.github.com/users/qcubed","html_url":"https://github.com/qcubed","followers_url":"https://api.github.com/users/qcubed/followers","following_url":"https://api.github.com/users/qcubed/following{/other_user}","gists_url":"https://api.github.com/users/qcubed/gists{/gist_id}","starred_url":"https://api.github.com/users/qcubed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qcubed/subscriptions","organizations_url":"https://api.github.com/users/qcubed/orgs","repos_url":"https://api.github.com/users/qcubed/repos","events_url":"https://api.github.com/users/qcubed/events{/privacy}","received_events_url":"https://api.github.com/users/qcubed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qcubed/framework","description":"The official QCubed framework git repo","fork":false,"url":"https://api.github.com/repos/qcubed/framework","forks_url":"https://api.github.com/repos/qcubed/framework/forks","keys_url":"https://api.github.com/repos/qcubed/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qcubed/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qcubed/framework/teams","hooks_url":"https://api.github.com/repos/qcubed/framework/hooks","issue_events_url":"https://api.github.com/repos/qcubed/framework/issues/events{/number}","events_url":"https://api.github.com/repos/qcubed/framework/events","assignees_url":"https://api.github.com/repos/qcubed/framework/assignees{/user}","branches_url":"https://api.github.com/repos/qcubed/framework/branches{/branch}","tags_url":"https://api.github.com/repos/qcubed/framework/tags","blobs_url":"https://api.github.com/repos/qcubed/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qcubed/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qcubed/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/qcubed/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qcubed/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/qcubed/framework/languages","stargazers_url":"https://api.github.com/repos/qcubed/framework/stargazers","contributors_url":"https://api.github.com/repos/qcubed/framework/contributors","subscribers_url":"https://api.github.com/repos/qcubed/framework/subscribers","subscription_url":"https://api.github.com/repos/qcubed/framework/subscription","commits_url":"https://api.github.com/repos/qcubed/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/qcubed/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/qcubed/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/qcubed/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/qcubed/framework/contents/{+path}","compare_url":"https://api.github.com/repos/qcubed/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qcubed/framework/merges","archive_url":"https://api.github.com/repos/qcubed/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qcubed/framework/downloads","issues_url":"https://api.github.com/repos/qcubed/framework/issues{/number}","pulls_url":"https://api.github.com/repos/qcubed/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/qcubed/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/qcubed/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qcubed/framework/labels{/name}","releases_url":"https://api.github.com/repos/qcubed/framework/releases{/id}","created_at":"2012-11-18T00:52:56Z","updated_at":"2015-03-10T19:33:45Z","pushed_at":"2015-03-16T18:38:21Z","git_url":"git://github.com/qcubed/framework.git","ssh_url":"git@github.com:qcubed/framework.git","clone_url":"https://github.com/qcubed/framework.git","svn_url":"https://github.com/qcubed/framework","homepage":"http://qcu.be/","size":25292,"stargazers_count":28,"watchers_count":28,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":101,"forks":32,"open_issues":101,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qcubed/framework/pulls/655"},"html":{"href":"https://github.com/qcubed/framework/pull/655"},"issue":{"href":"https://api.github.com/repos/qcubed/framework/issues/655"},"comments":{"href":"https://api.github.com/repos/qcubed/framework/issues/655/comments"},"review_comments":{"href":"https://api.github.com/repos/qcubed/framework/pulls/655/comments"},"review_comment":{"href":"https://api.github.com/repos/qcubed/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qcubed/framework/pulls/655/commits"},"statuses":{"href":"https://api.github.com/repos/qcubed/framework/statuses/1abd64098bba77bd1f7360799950b3c7477c982c"}}}}