{"action":"opened","number":677,"pull_request":{"url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/677","id":43878555,"html_url":"https://github.com/BabylonJS/Babylon.js/pull/677","diff_url":"https://github.com/BabylonJS/Babylon.js/pull/677.diff","patch_url":"https://github.com/BabylonJS/Babylon.js/pull/677.patch","issue_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/677","number":677,"state":"open","locked":false,"title":"fixed Path3D : no more wrong normal/binormal computation due to normalization approximation","user":{"login":"jbousquie","id":11529,"avatar_url":"https://avatars.githubusercontent.com/u/11529?v=3","gravatar_id":"","url":"https://api.github.com/users/jbousquie","html_url":"https://github.com/jbousquie","followers_url":"https://api.github.com/users/jbousquie/followers","following_url":"https://api.github.com/users/jbousquie/following{/other_user}","gists_url":"https://api.github.com/users/jbousquie/gists{/gist_id}","starred_url":"https://api.github.com/users/jbousquie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbousquie/subscriptions","organizations_url":"https://api.github.com/users/jbousquie/orgs","repos_url":"https://api.github.com/users/jbousquie/repos","events_url":"https://api.github.com/users/jbousquie/events{/privacy}","received_events_url":"https://api.github.com/users/jbousquie/received_events","type":"User","site_admin":false},"body":"The Path3D normals and binormals are computed in a point of the curve path from the tangent in this point and from an arbitrary vector chosen as non-collinear to this tangent.\r\nIf the tangent normalization is approximated, the choice of the arbitrary vector gave in in some limit cases something collinear with the tangent.\r\n\r\nThis PR fixes this problem with the use of  _WithinEpsilon()_","created_at":"2015-09-01T13:59:14Z","updated_at":"2015-09-01T13:59:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/677/commits","review_comments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/677/comments","review_comment_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/677/comments","statuses_url":"https://api.github.com/repos/BabylonJS/Babylon.js/statuses/7377c08f586265b3406870fac7c63b29f35069c3","head":{"label":"jbousquie:fix.Path3D","ref":"fix.Path3D","sha":"7377c08f586265b3406870fac7c63b29f35069c3","user":{"login":"jbousquie","id":11529,"avatar_url":"https://avatars.githubusercontent.com/u/11529?v=3","gravatar_id":"","url":"https://api.github.com/users/jbousquie","html_url":"https://github.com/jbousquie","followers_url":"https://api.github.com/users/jbousquie/followers","following_url":"https://api.github.com/users/jbousquie/following{/other_user}","gists_url":"https://api.github.com/users/jbousquie/gists{/gist_id}","starred_url":"https://api.github.com/users/jbousquie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbousquie/subscriptions","organizations_url":"https://api.github.com/users/jbousquie/orgs","repos_url":"https://api.github.com/users/jbousquie/repos","events_url":"https://api.github.com/users/jbousquie/events{/privacy}","received_events_url":"https://api.github.com/users/jbousquie/received_events","type":"User","site_admin":false},"repo":{"id":41722412,"name":"Babylon.js","full_name":"jbousquie/Babylon.js","owner":{"login":"jbousquie","id":11529,"avatar_url":"https://avatars.githubusercontent.com/u/11529?v=3","gravatar_id":"","url":"https://api.github.com/users/jbousquie","html_url":"https://github.com/jbousquie","followers_url":"https://api.github.com/users/jbousquie/followers","following_url":"https://api.github.com/users/jbousquie/following{/other_user}","gists_url":"https://api.github.com/users/jbousquie/gists{/gist_id}","starred_url":"https://api.github.com/users/jbousquie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbousquie/subscriptions","organizations_url":"https://api.github.com/users/jbousquie/orgs","repos_url":"https://api.github.com/users/jbousquie/repos","events_url":"https://api.github.com/users/jbousquie/events{/privacy}","received_events_url":"https://api.github.com/users/jbousquie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbousquie/Babylon.js","description":"Babylon.js: a complete JavaScript framework for building 3D games with HTML 5 and WebGL","fork":true,"url":"https://api.github.com/repos/jbousquie/Babylon.js","forks_url":"https://api.github.com/repos/jbousquie/Babylon.js/forks","keys_url":"https://api.github.com/repos/jbousquie/Babylon.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbousquie/Babylon.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbousquie/Babylon.js/teams","hooks_url":"https://api.github.com/repos/jbousquie/Babylon.js/hooks","issue_events_url":"https://api.github.com/repos/jbousquie/Babylon.js/issues/events{/number}","events_url":"https://api.github.com/repos/jbousquie/Babylon.js/events","assignees_url":"https://api.github.com/repos/jbousquie/Babylon.js/assignees{/user}","branches_url":"https://api.github.com/repos/jbousquie/Babylon.js/branches{/branch}","tags_url":"https://api.github.com/repos/jbousquie/Babylon.js/tags","blobs_url":"https://api.github.com/repos/jbousquie/Babylon.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbousquie/Babylon.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbousquie/Babylon.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbousquie/Babylon.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbousquie/Babylon.js/statuses/{sha}","languages_url":"https://api.github.com/repos/jbousquie/Babylon.js/languages","stargazers_url":"https://api.github.com/repos/jbousquie/Babylon.js/stargazers","contributors_url":"https://api.github.com/repos/jbousquie/Babylon.js/contributors","subscribers_url":"https://api.github.com/repos/jbousquie/Babylon.js/subscribers","subscription_url":"https://api.github.com/repos/jbousquie/Babylon.js/subscription","commits_url":"https://api.github.com/repos/jbousquie/Babylon.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbousquie/Babylon.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbousquie/Babylon.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbousquie/Babylon.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbousquie/Babylon.js/contents/{+path}","compare_url":"https://api.github.com/repos/jbousquie/Babylon.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbousquie/Babylon.js/merges","archive_url":"https://api.github.com/repos/jbousquie/Babylon.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbousquie/Babylon.js/downloads","issues_url":"https://api.github.com/repos/jbousquie/Babylon.js/issues{/number}","pulls_url":"https://api.github.com/repos/jbousquie/Babylon.js/pulls{/number}","milestones_url":"https://api.github.com/repos/jbousquie/Babylon.js/milestones{/number}","notifications_url":"https://api.github.com/repos/jbousquie/Babylon.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbousquie/Babylon.js/labels{/name}","releases_url":"https://api.github.com/repos/jbousquie/Babylon.js/releases{/id}","created_at":"2015-09-01T06:59:00Z","updated_at":"2015-09-01T06:59:04Z","pushed_at":"2015-09-01T13:52:07Z","git_url":"git://github.com/jbousquie/Babylon.js.git","ssh_url":"git@github.com:jbousquie/Babylon.js.git","clone_url":"https://github.com/jbousquie/Babylon.js.git","svn_url":"https://github.com/jbousquie/Babylon.js","homepage":"http://www.babylonjs.com","size":469216,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BabylonJS:master","ref":"master","sha":"283f459e3e11b73e357a54d7caa022b6a5321a92","user":{"login":"BabylonJS","id":4855800,"avatar_url":"https://avatars.githubusercontent.com/u/4855800?v=3","gravatar_id":"","url":"https://api.github.com/users/BabylonJS","html_url":"https://github.com/BabylonJS","followers_url":"https://api.github.com/users/BabylonJS/followers","following_url":"https://api.github.com/users/BabylonJS/following{/other_user}","gists_url":"https://api.github.com/users/BabylonJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BabylonJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BabylonJS/subscriptions","organizations_url":"https://api.github.com/users/BabylonJS/orgs","repos_url":"https://api.github.com/users/BabylonJS/repos","events_url":"https://api.github.com/users/BabylonJS/events{/privacy}","received_events_url":"https://api.github.com/users/BabylonJS/received_events","type":"Organization","site_admin":false},"repo":{"id":11007313,"name":"Babylon.js","full_name":"BabylonJS/Babylon.js","owner":{"login":"BabylonJS","id":4855800,"avatar_url":"https://avatars.githubusercontent.com/u/4855800?v=3","gravatar_id":"","url":"https://api.github.com/users/BabylonJS","html_url":"https://github.com/BabylonJS","followers_url":"https://api.github.com/users/BabylonJS/followers","following_url":"https://api.github.com/users/BabylonJS/following{/other_user}","gists_url":"https://api.github.com/users/BabylonJS/gists{/gist_id}","starred_url":"https://api.github.com/users/BabylonJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BabylonJS/subscriptions","organizations_url":"https://api.github.com/users/BabylonJS/orgs","repos_url":"https://api.github.com/users/BabylonJS/repos","events_url":"https://api.github.com/users/BabylonJS/events{/privacy}","received_events_url":"https://api.github.com/users/BabylonJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BabylonJS/Babylon.js","description":"Babylon.js: a complete JavaScript framework for building 3D games with HTML 5 and WebGL","fork":false,"url":"https://api.github.com/repos/BabylonJS/Babylon.js","forks_url":"https://api.github.com/repos/BabylonJS/Babylon.js/forks","keys_url":"https://api.github.com/repos/BabylonJS/Babylon.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BabylonJS/Babylon.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BabylonJS/Babylon.js/teams","hooks_url":"https://api.github.com/repos/BabylonJS/Babylon.js/hooks","issue_events_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/events{/number}","events_url":"https://api.github.com/repos/BabylonJS/Babylon.js/events","assignees_url":"https://api.github.com/repos/BabylonJS/Babylon.js/assignees{/user}","branches_url":"https://api.github.com/repos/BabylonJS/Babylon.js/branches{/branch}","tags_url":"https://api.github.com/repos/BabylonJS/Babylon.js/tags","blobs_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BabylonJS/Babylon.js/statuses/{sha}","languages_url":"https://api.github.com/repos/BabylonJS/Babylon.js/languages","stargazers_url":"https://api.github.com/repos/BabylonJS/Babylon.js/stargazers","contributors_url":"https://api.github.com/repos/BabylonJS/Babylon.js/contributors","subscribers_url":"https://api.github.com/repos/BabylonJS/Babylon.js/subscribers","subscription_url":"https://api.github.com/repos/BabylonJS/Babylon.js/subscription","commits_url":"https://api.github.com/repos/BabylonJS/Babylon.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/BabylonJS/Babylon.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/BabylonJS/Babylon.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/BabylonJS/Babylon.js/contents/{+path}","compare_url":"https://api.github.com/repos/BabylonJS/Babylon.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BabylonJS/Babylon.js/merges","archive_url":"https://api.github.com/repos/BabylonJS/Babylon.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BabylonJS/Babylon.js/downloads","issues_url":"https://api.github.com/repos/BabylonJS/Babylon.js/issues{/number}","pulls_url":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls{/number}","milestones_url":"https://api.github.com/repos/BabylonJS/Babylon.js/milestones{/number}","notifications_url":"https://api.github.com/repos/BabylonJS/Babylon.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BabylonJS/Babylon.js/labels{/name}","releases_url":"https://api.github.com/repos/BabylonJS/Babylon.js/releases{/id}","created_at":"2013-06-27T20:40:42Z","updated_at":"2015-09-01T10:11:35Z","pushed_at":"2015-09-01T13:23:40Z","git_url":"git://github.com/BabylonJS/Babylon.js.git","ssh_url":"git@github.com:BabylonJS/Babylon.js.git","clone_url":"https://github.com/BabylonJS/Babylon.js.git","svn_url":"https://github.com/BabylonJS/Babylon.js","homepage":"http://www.babylonjs.com","size":469216,"stargazers_count":2383,"watchers_count":2383,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":588,"mirror_url":null,"open_issues_count":4,"forks":588,"open_issues":4,"watchers":2383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/677"},"html":{"href":"https://github.com/BabylonJS/Babylon.js/pull/677"},"issue":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/677"},"comments":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/issues/677/comments"},"review_comments":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/677/comments"},"review_comment":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/pulls/677/commits"},"statuses":{"href":"https://api.github.com/repos/BabylonJS/Babylon.js/statuses/7377c08f586265b3406870fac7c63b29f35069c3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":1}}