{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/39722160","id":39722160,"diff_hunk":"@@ -351,13 +354,37 @@ describe('AdContext', function () {\n \t\texpect(getModule().getContext().opts.sourcePoint).toBe(undefined);\n \t});\n \n-\tit('enables SourcePoint when country in instantGlobals.wgAdDriverSourcePointCountries', function () {\n+\tit('enables SourcePoint when country in instant var', function () {\n \t\tmocks.win = {ads: {context: {opts: {sourcePointUrl: '//foo.bar'}}}};\n \t\tmocks.instantGlobals = {wgAdDriverSourcePointCountries: ['XX', 'ZZ']};\n \n \t\texpect(getModule().getContext().opts.sourcePoint).toBeTruthy();\n \t});\n \n+\tit('enables SourcePoint when region in instant var', function () {\n+\t\tmocks.win = {ads: {context: {opts: {sourcePointUrl: '//foo.bar'}}}};\n+\t\tmocks.instantGlobals = {wgAdDriverSourcePointCountries: ['XX-RR']};\n+\n+\t\texpect(getModule().getContext().opts.sourcePoint).toBeTruthy();\n+\t});\n+\n+\tit('enables SourcePoint when country and region in instant var (country overwrites region)', function () {\n+\t\tmocks.win = {ads: {context: {opts: {sourcePointUrl: '//foo.bar'}}}};\n+\t\tmocks.instantGlobals = {wgAdDriverSourcePointCountries: ['XX-EE', 'XX']};\n+\n+\t\texpect(getModule().getContext().opts.sourcePoint).toBeTruthy();\n+\t});\n+\n+\tit(\n+\t\t'disables SourcePoint when country and region in instant var and both are invalid',","path":"extensions/wikia/AdEngine/js/spec/AdContext.spec.js","position":37,"original_position":37,"commit_id":"afde0c48eeae126668f912de8fad456dc8da966e","original_commit_id":"afde0c48eeae126668f912de8fad456dc8da966e","user":{"login":"nandy-andy","id":1662451,"avatar_url":"https://avatars.githubusercontent.com/u/1662451?v=3","gravatar_id":"","url":"https://api.github.com/users/nandy-andy","html_url":"https://github.com/nandy-andy","followers_url":"https://api.github.com/users/nandy-andy/followers","following_url":"https://api.github.com/users/nandy-andy/following{/other_user}","gists_url":"https://api.github.com/users/nandy-andy/gists{/gist_id}","starred_url":"https://api.github.com/users/nandy-andy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nandy-andy/subscriptions","organizations_url":"https://api.github.com/users/nandy-andy/orgs","repos_url":"https://api.github.com/users/nandy-andy/repos","events_url":"https://api.github.com/users/nandy-andy/events{/privacy}","received_events_url":"https://api.github.com/users/nandy-andy/received_events","type":"User","site_admin":false},"body":"You're right! :japanese_ogre: ","created_at":"2015-09-17T08:37:39Z","updated_at":"2015-09-17T08:37:39Z","html_url":"https://github.com/Wikia/app/pull/8505#discussion_r39722160","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/8505","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/39722160"},"html":{"href":"https://github.com/Wikia/app/pull/8505#discussion_r39722160"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/8505"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/8505","id":45191868,"html_url":"https://github.com/Wikia/app/pull/8505","diff_url":"https://github.com/Wikia/app/pull/8505.diff","patch_url":"https://github.com/Wikia/app/pull/8505.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/8505","number":8505,"state":"open","locked":false,"title":"ADEN-2434 Region in geo for sourcepoint","user":{"login":"nandy-andy","id":1662451,"avatar_url":"https://avatars.githubusercontent.com/u/1662451?v=3","gravatar_id":"","url":"https://api.github.com/users/nandy-andy","html_url":"https://github.com/nandy-andy","followers_url":"https://api.github.com/users/nandy-andy/followers","following_url":"https://api.github.com/users/nandy-andy/following{/other_user}","gists_url":"https://api.github.com/users/nandy-andy/gists{/gist_id}","starred_url":"https://api.github.com/users/nandy-andy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nandy-andy/subscriptions","organizations_url":"https://api.github.com/users/nandy-andy/orgs","repos_url":"https://api.github.com/users/nandy-andy/repos","events_url":"https://api.github.com/users/nandy-andy/events{/privacy}","received_events_url":"https://api.github.com/users/nandy-andy/received_events","type":"User","site_admin":false},"body":"In order to enable SourcePoint feature in a specific region of a country we added new method to `Wikia.geo` module and made changes in our `AdContext` module.","created_at":"2015-09-16T16:10:13Z","updated_at":"2015-09-17T08:37:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1ed853ba903e13ac777d708d5966a91b04e6e7c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/8505/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/8505/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/8505/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/afde0c48eeae126668f912de8fad456dc8da966e","head":{"label":"Wikia:aden-2434-region-in-geo","ref":"aden-2434-region-in-geo","sha":"afde0c48eeae126668f912de8fad456dc8da966e","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-09-11T11:45:30Z","pushed_at":"2015-09-17T08:10:12Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1485725,"stargazers_count":86,"watchers_count":86,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":70,"forks":66,"open_issues":70,"watchers":86,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"541e6fb94434aa351659bada9329b649232a10dd","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-09-11T11:45:30Z","pushed_at":"2015-09-17T08:10:12Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1485725,"stargazers_count":86,"watchers_count":86,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":70,"forks":66,"open_issues":70,"watchers":86,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/8505"},"html":{"href":"https://github.com/Wikia/app/pull/8505"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/8505"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/8505/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/8505/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/8505/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/afde0c48eeae126668f912de8fad456dc8da966e"}}}}