{"action":"created","issue":{"url":"https://api.github.com/repos/TelescopeJS/Telescope/issues/662","labels_url":"https://api.github.com/repos/TelescopeJS/Telescope/issues/662/labels{/name}","comments_url":"https://api.github.com/repos/TelescopeJS/Telescope/issues/662/comments","events_url":"https://api.github.com/repos/TelescopeJS/Telescope/issues/662/events","html_url":"https://github.com/TelescopeJS/Telescope/pull/662","id":53099956,"number":662,"title":"Adding nav client unit test","user":{"login":"anthonymayer","id":829762,"avatar_url":"https://avatars.githubusercontent.com/u/829762?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonymayer","html_url":"https://github.com/anthonymayer","followers_url":"https://api.github.com/users/anthonymayer/followers","following_url":"https://api.github.com/users/anthonymayer/following{/other_user}","gists_url":"https://api.github.com/users/anthonymayer/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonymayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonymayer/subscriptions","organizations_url":"https://api.github.com/users/anthonymayer/orgs","repos_url":"https://api.github.com/users/anthonymayer/repos","events_url":"https://api.github.com/users/anthonymayer/events{/privacy}","received_events_url":"https://api.github.com/users/anthonymayer/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2014-12-30T08:09:19Z","updated_at":"2015-01-05T06:47:14Z","closed_at":"2015-01-02T20:29:53Z","pull_request":{"url":"https://api.github.com/repos/TelescopeJS/Telescope/pulls/662","html_url":"https://github.com/TelescopeJS/Telescope/pull/662","diff_url":"https://github.com/TelescopeJS/Telescope/pull/662.diff","patch_url":"https://github.com/TelescopeJS/Telescope/pull/662.patch"},"body":"Using the jasmine package seemed like the best way to go because we'll want most of the testing modes. I added the travis file, but it doesn't quite work yet (see https://travis-ci.org/anthonymayer/Telescope). I don't think any other changes should be required of the travis file right now though because I'm controlling it all through https://github.com/anthonymayer/travis-ci-meteor-packages. Once I get that working I'll probably add a tag in the README too.\r\n\r\nMostly I'm looking for feedback on testing structure. I'm hoping that after we have a few more examples of these that we start making adding/updating tests a requirement of push requests. Getting feedback from either @sanjo and/or @samhatoum would be awesome too.\r\n\r\nI also deleted some nav stuff that looked unused."},"comment":{"url":"https://api.github.com/repos/TelescopeJS/Telescope/issues/comments/68673716","html_url":"https://github.com/TelescopeJS/Telescope/pull/662#issuecomment-68673716","issue_url":"https://api.github.com/repos/TelescopeJS/Telescope/issues/662","id":68673716,"user":{"login":"anthonymayer","id":829762,"avatar_url":"https://avatars.githubusercontent.com/u/829762?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonymayer","html_url":"https://github.com/anthonymayer","followers_url":"https://api.github.com/users/anthonymayer/followers","following_url":"https://api.github.com/users/anthonymayer/following{/other_user}","gists_url":"https://api.github.com/users/anthonymayer/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonymayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonymayer/subscriptions","organizations_url":"https://api.github.com/users/anthonymayer/orgs","repos_url":"https://api.github.com/users/anthonymayer/repos","events_url":"https://api.github.com/users/anthonymayer/events{/privacy}","received_events_url":"https://api.github.com/users/anthonymayer/received_events","type":"User","site_admin":false},"created_at":"2015-01-05T06:47:14Z","updated_at":"2015-01-05T06:47:14Z","body":"Okay I can work on some documentation. Can you fix the tests? If not I can this time but it would be good if you did because writing/updating tests should be part of the development process. The tests were just failing, right, or were you having issues with the test runner itself? As soon as the todos on https://github.com/Sanjo/meteor-jasmine/pull/118 are done I plan on enabling travis for Telescope and probably adding a badge to the README so that people know the state of the tests. I'll make sure it's mentioned in the docs too. Also we shouldn't disable velocity if a test is failing, we can disable individual tests."}}