{"action":"created","comment":{"url":"https://api.github.com/repos/candlepin/candlepin/pulls/comments/34481407","id":34481407,"diff_hunk":"@@ -185,8 +188,10 @@ public Product getProduct(@PathParam(\"owner_key\") String ownerKey,\n     @Path(\"/{product_id}/certificate\")\n     @Produces(MediaType.APPLICATION_JSON)\n     @SecurityHole\n-    public ProductCertificate getProductCertificate(@PathParam(\"owner_key\") String ownerKey,\n-                                                    @PathParam(\"product_id\") String productId) {\n+    public ProductCertificate getProductCertificate(\n+        @Verify(Owner.class) @PathParam(\"owner_key\") String ownerKey,\n+        @Verify(Product.class) @PathParam(\"product_id\") String productId) {","path":"server/src/main/java/org/candlepin/resource/OwnerProductResource.java","position":40,"original_position":40,"commit_id":"69ee897ce7f2f0b63c33ff18055e13614a16c603","original_commit_id":"69ee897ce7f2f0b63c33ff18055e13614a16c603","user":{"login":"dgoodwin","id":51265,"avatar_url":"https://avatars.githubusercontent.com/u/51265?v=3","gravatar_id":"","url":"https://api.github.com/users/dgoodwin","html_url":"https://github.com/dgoodwin","followers_url":"https://api.github.com/users/dgoodwin/followers","following_url":"https://api.github.com/users/dgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/dgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoodwin/subscriptions","organizations_url":"https://api.github.com/users/dgoodwin/orgs","repos_url":"https://api.github.com/users/dgoodwin/repos","events_url":"https://api.github.com/users/dgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/dgoodwin/received_events","type":"User","site_admin":false},"body":"This one I almost think should go back to super admin only if it was in 1.0, which I suspect it was. This doesn't feel like something regular users or consumers should be calling, and I could tsee them having read access to the owner and product.","created_at":"2015-07-13T16:26:05Z","updated_at":"2015-07-13T16:26:05Z","html_url":"https://github.com/candlepin/candlepin/pull/932#discussion_r34481407","pull_request_url":"https://api.github.com/repos/candlepin/candlepin/pulls/932","_links":{"self":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/comments/34481407"},"html":{"href":"https://github.com/candlepin/candlepin/pull/932#discussion_r34481407"},"pull_request":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/932"}}},"pull_request":{"url":"https://api.github.com/repos/candlepin/candlepin/pulls/932","id":39483638,"html_url":"https://github.com/candlepin/candlepin/pull/932","diff_url":"https://github.com/candlepin/candlepin/pull/932.diff","patch_url":"https://github.com/candlepin/candlepin/pull/932.patch","issue_url":"https://api.github.com/repos/candlepin/candlepin/issues/932","number":932,"state":"open","locked":false,"title":"Updated @Verify to use owner when checking products","user":{"login":"Ceiu","id":6061522,"avatar_url":"https://avatars.githubusercontent.com/u/6061522?v=3","gravatar_id":"","url":"https://api.github.com/users/Ceiu","html_url":"https://github.com/Ceiu","followers_url":"https://api.github.com/users/Ceiu/followers","following_url":"https://api.github.com/users/Ceiu/following{/other_user}","gists_url":"https://api.github.com/users/Ceiu/gists{/gist_id}","starred_url":"https://api.github.com/users/Ceiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ceiu/subscriptions","organizations_url":"https://api.github.com/users/Ceiu/orgs","repos_url":"https://api.github.com/users/Ceiu/repos","events_url":"https://api.github.com/users/Ceiu/events{/privacy}","received_events_url":"https://api.github.com/users/Ceiu/received_events","type":"User","site_admin":false},"body":"- When using @Verify with both an owner and a product, the\r\n  lookup on the product will be owner-specific\r\n- Added @Verify to most requests in ProductResource and\r\n  OwnerProductResource\r\n- ProductResource.getProductCertificate now throws an exception along\r\n  with the other org-agnostic write operations\r\n\r\nNote that this change introduces its own set of oddities. Particularly, to ensure the proper permission is checked, a @Verify must be present on both an owner (that occurs in the argument list before the product) and the product; and due to the ordering, a user must meet both verify criteria to perform the action. As such, the @Verify tags may need to be adjusted to have the proper explicit permissions for this update.","created_at":"2015-07-08T14:35:10Z","updated_at":"2015-07-13T16:26:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5940be037fbcb4d1101f58b221e4546c69799b47","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/candlepin/candlepin/pulls/932/commits","review_comments_url":"https://api.github.com/repos/candlepin/candlepin/pulls/932/comments","review_comment_url":"https://api.github.com/repos/candlepin/candlepin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/candlepin/candlepin/issues/932/comments","statuses_url":"https://api.github.com/repos/candlepin/candlepin/statuses/69ee897ce7f2f0b63c33ff18055e13614a16c603","head":{"label":"candlepin:crog/perorgprod-verify","ref":"crog/perorgprod-verify","sha":"69ee897ce7f2f0b63c33ff18055e13614a16c603","user":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"repo":{"id":4586516,"name":"candlepin","full_name":"candlepin/candlepin","owner":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/candlepin/candlepin","description":"The Candlepin entitlement engine","fork":false,"url":"https://api.github.com/repos/candlepin/candlepin","forks_url":"https://api.github.com/repos/candlepin/candlepin/forks","keys_url":"https://api.github.com/repos/candlepin/candlepin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candlepin/candlepin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candlepin/candlepin/teams","hooks_url":"https://api.github.com/repos/candlepin/candlepin/hooks","issue_events_url":"https://api.github.com/repos/candlepin/candlepin/issues/events{/number}","events_url":"https://api.github.com/repos/candlepin/candlepin/events","assignees_url":"https://api.github.com/repos/candlepin/candlepin/assignees{/user}","branches_url":"https://api.github.com/repos/candlepin/candlepin/branches{/branch}","tags_url":"https://api.github.com/repos/candlepin/candlepin/tags","blobs_url":"https://api.github.com/repos/candlepin/candlepin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candlepin/candlepin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candlepin/candlepin/git/refs{/sha}","trees_url":"https://api.github.com/repos/candlepin/candlepin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candlepin/candlepin/statuses/{sha}","languages_url":"https://api.github.com/repos/candlepin/candlepin/languages","stargazers_url":"https://api.github.com/repos/candlepin/candlepin/stargazers","contributors_url":"https://api.github.com/repos/candlepin/candlepin/contributors","subscribers_url":"https://api.github.com/repos/candlepin/candlepin/subscribers","subscription_url":"https://api.github.com/repos/candlepin/candlepin/subscription","commits_url":"https://api.github.com/repos/candlepin/candlepin/commits{/sha}","git_commits_url":"https://api.github.com/repos/candlepin/candlepin/git/commits{/sha}","comments_url":"https://api.github.com/repos/candlepin/candlepin/comments{/number}","issue_comment_url":"https://api.github.com/repos/candlepin/candlepin/issues/comments{/number}","contents_url":"https://api.github.com/repos/candlepin/candlepin/contents/{+path}","compare_url":"https://api.github.com/repos/candlepin/candlepin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candlepin/candlepin/merges","archive_url":"https://api.github.com/repos/candlepin/candlepin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candlepin/candlepin/downloads","issues_url":"https://api.github.com/repos/candlepin/candlepin/issues{/number}","pulls_url":"https://api.github.com/repos/candlepin/candlepin/pulls{/number}","milestones_url":"https://api.github.com/repos/candlepin/candlepin/milestones{/number}","notifications_url":"https://api.github.com/repos/candlepin/candlepin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candlepin/candlepin/labels{/name}","releases_url":"https://api.github.com/repos/candlepin/candlepin/releases{/id}","created_at":"2012-06-07T14:58:35Z","updated_at":"2015-07-04T05:44:27Z","pushed_at":"2015-07-13T16:21:07Z","git_url":"git://github.com/candlepin/candlepin.git","ssh_url":"git@github.com:candlepin/candlepin.git","clone_url":"https://github.com/candlepin/candlepin.git","svn_url":"https://github.com/candlepin/candlepin","homepage":"http://candlepinproject.org","size":54715,"stargazers_count":29,"watchers_count":29,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":4,"forks":22,"open_issues":4,"watchers":29,"default_branch":"master"}},"base":{"label":"candlepin:master","ref":"master","sha":"a6835a9b5092e63627c5ef7bf0db5a60a4d87526","user":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"repo":{"id":4586516,"name":"candlepin","full_name":"candlepin/candlepin","owner":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/candlepin/candlepin","description":"The Candlepin entitlement engine","fork":false,"url":"https://api.github.com/repos/candlepin/candlepin","forks_url":"https://api.github.com/repos/candlepin/candlepin/forks","keys_url":"https://api.github.com/repos/candlepin/candlepin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candlepin/candlepin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candlepin/candlepin/teams","hooks_url":"https://api.github.com/repos/candlepin/candlepin/hooks","issue_events_url":"https://api.github.com/repos/candlepin/candlepin/issues/events{/number}","events_url":"https://api.github.com/repos/candlepin/candlepin/events","assignees_url":"https://api.github.com/repos/candlepin/candlepin/assignees{/user}","branches_url":"https://api.github.com/repos/candlepin/candlepin/branches{/branch}","tags_url":"https://api.github.com/repos/candlepin/candlepin/tags","blobs_url":"https://api.github.com/repos/candlepin/candlepin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candlepin/candlepin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candlepin/candlepin/git/refs{/sha}","trees_url":"https://api.github.com/repos/candlepin/candlepin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candlepin/candlepin/statuses/{sha}","languages_url":"https://api.github.com/repos/candlepin/candlepin/languages","stargazers_url":"https://api.github.com/repos/candlepin/candlepin/stargazers","contributors_url":"https://api.github.com/repos/candlepin/candlepin/contributors","subscribers_url":"https://api.github.com/repos/candlepin/candlepin/subscribers","subscription_url":"https://api.github.com/repos/candlepin/candlepin/subscription","commits_url":"https://api.github.com/repos/candlepin/candlepin/commits{/sha}","git_commits_url":"https://api.github.com/repos/candlepin/candlepin/git/commits{/sha}","comments_url":"https://api.github.com/repos/candlepin/candlepin/comments{/number}","issue_comment_url":"https://api.github.com/repos/candlepin/candlepin/issues/comments{/number}","contents_url":"https://api.github.com/repos/candlepin/candlepin/contents/{+path}","compare_url":"https://api.github.com/repos/candlepin/candlepin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candlepin/candlepin/merges","archive_url":"https://api.github.com/repos/candlepin/candlepin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candlepin/candlepin/downloads","issues_url":"https://api.github.com/repos/candlepin/candlepin/issues{/number}","pulls_url":"https://api.github.com/repos/candlepin/candlepin/pulls{/number}","milestones_url":"https://api.github.com/repos/candlepin/candlepin/milestones{/number}","notifications_url":"https://api.github.com/repos/candlepin/candlepin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candlepin/candlepin/labels{/name}","releases_url":"https://api.github.com/repos/candlepin/candlepin/releases{/id}","created_at":"2012-06-07T14:58:35Z","updated_at":"2015-07-04T05:44:27Z","pushed_at":"2015-07-13T16:21:07Z","git_url":"git://github.com/candlepin/candlepin.git","ssh_url":"git@github.com:candlepin/candlepin.git","clone_url":"https://github.com/candlepin/candlepin.git","svn_url":"https://github.com/candlepin/candlepin","homepage":"http://candlepinproject.org","size":54715,"stargazers_count":29,"watchers_count":29,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":4,"forks":22,"open_issues":4,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/932"},"html":{"href":"https://github.com/candlepin/candlepin/pull/932"},"issue":{"href":"https://api.github.com/repos/candlepin/candlepin/issues/932"},"comments":{"href":"https://api.github.com/repos/candlepin/candlepin/issues/932/comments"},"review_comments":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/932/comments"},"review_comment":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/932/commits"},"statuses":{"href":"https://api.github.com/repos/candlepin/candlepin/statuses/69ee897ce7f2f0b63c33ff18055e13614a16c603"}}}}