{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/24682277","id":24682277,"diff_hunk":"@@ -116,9 +119,39 @@ def collection_config\n     api_config[:collections]\n   end\n \n-  def action_identifier(type, action)\n-    collection_config.fetch_path(type, :resource_actions, :post)\n+  def action_identifier(type, action, selection = :resource_actions)\n+    collection_config.fetch_path(type, selection, :post)\n       .select { |spec| spec[:name] == action.to_s }\n       .first[:identifier]\n   end\n+\n+  def collection_action_identifier(type, action)\n+    action_identifier(type, action, :collection_actions)\n+  end\n+\n+  def subcollection_action_identifier(type, subtype, action)\n+    action_identifier(type, action, \"#{subtype}_subcollection_actions\".to_sym)\n+  end\n+\n+  def gen_request(action, *hrefs)\n+    request = {\"action\" => action.to_s}\n+    request[\"resources\"] = hrefs.collect { |href| {\"href\" => href} } if hrefs.present?","path":"vmdb/spec/support/api_spec_helper.rb","position":40,"original_position":40,"commit_id":"d487b5303206281c29cd064552bec80566c3dedb","original_commit_id":"d487b5303206281c29cd064552bec80566c3dedb","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"This is not a rule, but I always get confused when calling `.present?` on an Array, personally.  I feel like \"the Array is there so it's present\", even though I know `.present?` just means `!.blank?`.  I usually use `.any?` instead, because to me that's clearer for collections.","created_at":"2015-02-13T17:53:08Z","updated_at":"2015-02-13T17:53:08Z","html_url":"https://github.com/ManageIQ/manageiq/pull/1612#discussion_r24682277","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1612","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/24682277"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1612#discussion_r24682277"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1612"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1612","id":28881971,"html_url":"https://github.com/ManageIQ/manageiq/pull/1612","diff_url":"https://github.com/ManageIQ/manageiq/pull/1612.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/1612.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1612","number":1612,"state":"open","locked":false,"title":"[api] Adding support for conditions","user":{"login":"abellotti","id":5797328,"avatar_url":"https://avatars.githubusercontent.com/u/5797328?v=3","gravatar_id":"","url":"https://api.github.com/users/abellotti","html_url":"https://github.com/abellotti","followers_url":"https://api.github.com/users/abellotti/followers","following_url":"https://api.github.com/users/abellotti/following{/other_user}","gists_url":"https://api.github.com/users/abellotti/gists{/gist_id}","starred_url":"https://api.github.com/users/abellotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abellotti/subscriptions","organizations_url":"https://api.github.com/users/abellotti/orgs","repos_url":"https://api.github.com/users/abellotti/repos","events_url":"https://api.github.com/users/abellotti/events{/privacy}","received_events_url":"https://api.github.com/users/abellotti/received_events","type":"User","site_admin":false},"body":"- Adding /api/conditions as primary collection\r\n- Adding conditions as policies subcollection via /api/policies/:id/conditions\r\n- Adding Rspecs\r\n\r\nhttps://trello.com/c/dWVX0ECl","created_at":"2015-02-08T15:48:54Z","updated_at":"2015-02-13T17:53:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e82a8cf541a8ca5357493f1c1c8ce2ebc4c177f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1612/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1612/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1612/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/d487b5303206281c29cd064552bec80566c3dedb","head":{"label":"abellotti:rest_api_condition_list","ref":"rest_api_condition_list","sha":"d487b5303206281c29cd064552bec80566c3dedb","user":{"login":"abellotti","id":5797328,"avatar_url":"https://avatars.githubusercontent.com/u/5797328?v=3","gravatar_id":"","url":"https://api.github.com/users/abellotti","html_url":"https://github.com/abellotti","followers_url":"https://api.github.com/users/abellotti/followers","following_url":"https://api.github.com/users/abellotti/following{/other_user}","gists_url":"https://api.github.com/users/abellotti/gists{/gist_id}","starred_url":"https://api.github.com/users/abellotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abellotti/subscriptions","organizations_url":"https://api.github.com/users/abellotti/orgs","repos_url":"https://api.github.com/users/abellotti/repos","events_url":"https://api.github.com/users/abellotti/events{/privacy}","received_events_url":"https://api.github.com/users/abellotti/received_events","type":"User","site_admin":false},"repo":{"id":20813598,"name":"manageiq","full_name":"abellotti/manageiq","owner":{"login":"abellotti","id":5797328,"avatar_url":"https://avatars.githubusercontent.com/u/5797328?v=3","gravatar_id":"","url":"https://api.github.com/users/abellotti","html_url":"https://github.com/abellotti","followers_url":"https://api.github.com/users/abellotti/followers","following_url":"https://api.github.com/users/abellotti/following{/other_user}","gists_url":"https://api.github.com/users/abellotti/gists{/gist_id}","starred_url":"https://api.github.com/users/abellotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abellotti/subscriptions","organizations_url":"https://api.github.com/users/abellotti/orgs","repos_url":"https://api.github.com/users/abellotti/repos","events_url":"https://api.github.com/users/abellotti/events{/privacy}","received_events_url":"https://api.github.com/users/abellotti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abellotti/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/abellotti/manageiq","forks_url":"https://api.github.com/repos/abellotti/manageiq/forks","keys_url":"https://api.github.com/repos/abellotti/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abellotti/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abellotti/manageiq/teams","hooks_url":"https://api.github.com/repos/abellotti/manageiq/hooks","issue_events_url":"https://api.github.com/repos/abellotti/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/abellotti/manageiq/events","assignees_url":"https://api.github.com/repos/abellotti/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/abellotti/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/abellotti/manageiq/tags","blobs_url":"https://api.github.com/repos/abellotti/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abellotti/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abellotti/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/abellotti/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abellotti/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/abellotti/manageiq/languages","stargazers_url":"https://api.github.com/repos/abellotti/manageiq/stargazers","contributors_url":"https://api.github.com/repos/abellotti/manageiq/contributors","subscribers_url":"https://api.github.com/repos/abellotti/manageiq/subscribers","subscription_url":"https://api.github.com/repos/abellotti/manageiq/subscription","commits_url":"https://api.github.com/repos/abellotti/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/abellotti/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/abellotti/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/abellotti/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/abellotti/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/abellotti/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abellotti/manageiq/merges","archive_url":"https://api.github.com/repos/abellotti/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abellotti/manageiq/downloads","issues_url":"https://api.github.com/repos/abellotti/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/abellotti/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/abellotti/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/abellotti/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abellotti/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/abellotti/manageiq/releases{/id}","created_at":"2014-06-13T18:22:42Z","updated_at":"2014-06-17T20:58:44Z","pushed_at":"2015-02-13T15:21:03Z","git_url":"git://github.com/abellotti/manageiq.git","ssh_url":"git@github.com:abellotti/manageiq.git","clone_url":"https://github.com/abellotti/manageiq.git","svn_url":"https://github.com/abellotti/manageiq","homepage":null,"size":63302,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"3486880dc0208b2fcb5e49ad7ee563b448b9cc61","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/{number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-02-13T17:10:09Z","pushed_at":"2015-02-13T17:10:09Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":95084,"stargazers_count":86,"watchers_count":86,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":87,"mirror_url":null,"open_issues_count":270,"forks":87,"open_issues":270,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1612"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/1612"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1612"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/1612/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1612/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1612/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/d487b5303206281c29cd064552bec80566c3dedb"}}}}