{"action":"created","issue":{"url":"https://api.github.com/repos/CausalityLtd/ponyc/issues/428","labels_url":"https://api.github.com/repos/CausalityLtd/ponyc/issues/428/labels{/name}","comments_url":"https://api.github.com/repos/CausalityLtd/ponyc/issues/428/comments","events_url":"https://api.github.com/repos/CausalityLtd/ponyc/issues/428/events","html_url":"https://github.com/CausalityLtd/ponyc/pull/428","id":120920982,"number":428,"title":"Clean up uses of String.substring and codepoints methods after #417.","user":{"login":"jemc","id":4623870,"avatar_url":"https://avatars.githubusercontent.com/u/4623870?v=3","gravatar_id":"","url":"https://api.github.com/users/jemc","html_url":"https://github.com/jemc","followers_url":"https://api.github.com/users/jemc/followers","following_url":"https://api.github.com/users/jemc/following{/other_user}","gists_url":"https://api.github.com/users/jemc/gists{/gist_id}","starred_url":"https://api.github.com/users/jemc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jemc/subscriptions","organizations_url":"https://api.github.com/users/jemc/orgs","repos_url":"https://api.github.com/users/jemc/repos","events_url":"https://api.github.com/users/jemc/events{/privacy}","received_events_url":"https://api.github.com/users/jemc/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-08T03:14:43Z","updated_at":"2015-12-08T15:12:38Z","closed_at":"2015-12-08T09:48:16Z","pull_request":{"url":"https://api.github.com/repos/CausalityLtd/ponyc/pulls/428","html_url":"https://github.com/CausalityLtd/ponyc/pull/428","diff_url":"https://github.com/CausalityLtd/ponyc/pull/428.diff","patch_url":"https://github.com/CausalityLtd/ponyc/pull/428.patch"},"body":"PR #417 left some uses of `String.substring` and `String.codepoints` unchanged, where they should have been changed to match the changed behavior of the second argument.\r\n\r\nThis was probably the cause of #427.\r\n\r\nThis PR fixes the remaining uses of these methods.  I did a full search for these methods on all files in the repo, and compared to the list of those changed in #417.\r\n\r\n@andymcn [Here's one spot I wasn't sure about in the JSON package](https://github.com/CausalityLtd/ponyc/blob/873323591465b29d4de5a27d923ec02d9a078f73/packages/json/doc.pony#L423) - I don't understand how this invocation was supposed to work, since `to` will usually be less than `from` here.  I thought I would leave that for you to deal with since you wrote that snippet and I don't understand what's going on there."},"comment":{"url":"https://api.github.com/repos/CausalityLtd/ponyc/issues/comments/162910689","html_url":"https://github.com/CausalityLtd/ponyc/pull/428#issuecomment-162910689","issue_url":"https://api.github.com/repos/CausalityLtd/ponyc/issues/428","id":162910689,"user":{"login":"andymcn","id":7050628,"avatar_url":"https://avatars.githubusercontent.com/u/7050628?v=3","gravatar_id":"","url":"https://api.github.com/users/andymcn","html_url":"https://github.com/andymcn","followers_url":"https://api.github.com/users/andymcn/followers","following_url":"https://api.github.com/users/andymcn/following{/other_user}","gists_url":"https://api.github.com/users/andymcn/gists{/gist_id}","starred_url":"https://api.github.com/users/andymcn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymcn/subscriptions","organizations_url":"https://api.github.com/users/andymcn/orgs","repos_url":"https://api.github.com/users/andymcn/repos","events_url":"https://api.github.com/users/andymcn/events{/privacy}","received_events_url":"https://api.github.com/users/andymcn/received_events","type":"User","site_admin":false},"created_at":"2015-12-08T15:12:37Z","updated_at":"2015-12-08T15:12:37Z","body":"The JSON usage of `substring()` is now fixed."}}