{"action":"created","issue":{"url":"https://api.github.com/repos/polydawn/repeatr/issues/58","labels_url":"https://api.github.com/repos/polydawn/repeatr/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/polydawn/repeatr/issues/58/comments","events_url":"https://api.github.com/repos/polydawn/repeatr/issues/58/events","html_url":"https://github.com/polydawn/repeatr/pull/58","id":82993308,"number":58,"title":"Fix base dir attribs, mode cannonicalization, and support dev modes","user":{"login":"heavenlyhash","id":627638,"avatar_url":"https://avatars.githubusercontent.com/u/627638?v=3","gravatar_id":"","url":"https://api.github.com/users/heavenlyhash","html_url":"https://github.com/heavenlyhash","followers_url":"https://api.github.com/users/heavenlyhash/followers","following_url":"https://api.github.com/users/heavenlyhash/following{/other_user}","gists_url":"https://api.github.com/users/heavenlyhash/gists{/gist_id}","starred_url":"https://api.github.com/users/heavenlyhash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heavenlyhash/subscriptions","organizations_url":"https://api.github.com/users/heavenlyhash/orgs","repos_url":"https://api.github.com/users/heavenlyhash/repos","events_url":"https://api.github.com/users/heavenlyhash/events{/privacy}","received_events_url":"https://api.github.com/users/heavenlyhash/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-31T04:10:46Z","updated_at":"2015-06-01T20:05:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/polydawn/repeatr/pulls/58","html_url":"https://github.com/polydawn/repeatr/pull/58","diff_url":"https://github.com/polydawn/repeatr/pull/58.diff","patch_url":"https://github.com/polydawn/repeatr/pull/58.patch"},"body":"Enhanced test coverage of tar inputs, resulting in several critical fixes:\r\n\r\n- Foreign tar streams missing a \"./\" element now always get deterministic attributes on the base dir, as they should.\r\n- Whitelist modes as fed into hashing more consistently.  (Golang tar has some odd opinions about modes above 0777.)  GNU tar outputs and our own now behave the same.\r\n- Include devmajor and devminor attributes in hash coverage for block and character devices.  Always should have; not doing so has been a security and integrity failure.\r\n\r\nThere's a flag day on hashes -- there are breaking changes to the hashing algorithm.  Here it is, your \"we're pre-alpha\" admonition in practice!"},"comment":{"url":"https://api.github.com/repos/polydawn/repeatr/issues/comments/107691933","html_url":"https://github.com/polydawn/repeatr/pull/58#issuecomment-107691933","issue_url":"https://api.github.com/repos/polydawn/repeatr/issues/58","id":107691933,"user":{"login":"kofalt","id":265071,"avatar_url":"https://avatars.githubusercontent.com/u/265071?v=3","gravatar_id":"","url":"https://api.github.com/users/kofalt","html_url":"https://github.com/kofalt","followers_url":"https://api.github.com/users/kofalt/followers","following_url":"https://api.github.com/users/kofalt/following{/other_user}","gists_url":"https://api.github.com/users/kofalt/gists{/gist_id}","starred_url":"https://api.github.com/users/kofalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kofalt/subscriptions","organizations_url":"https://api.github.com/users/kofalt/orgs","repos_url":"https://api.github.com/users/kofalt/repos","events_url":"https://api.github.com/users/kofalt/events{/privacy}","received_events_url":"https://api.github.com/users/kofalt/received_events","type":"User","site_admin":false},"created_at":"2015-06-01T20:05:59Z","updated_at":"2015-06-01T20:05:59Z","body":"LGTM; merge when ready"}}