{"action":"created","issue":{"url":"https://api.github.com/repos/dc-js/dc.js/issues/908","labels_url":"https://api.github.com/repos/dc-js/dc.js/issues/908/labels{/name}","comments_url":"https://api.github.com/repos/dc-js/dc.js/issues/908/comments","events_url":"https://api.github.com/repos/dc-js/dc.js/issues/908/events","html_url":"https://github.com/dc-js/dc.js/pull/908","id":67191830,"number":908,"title":"Heatmap X axis tweaks","user":{"login":"gazal-k","id":8210299,"avatar_url":"https://avatars.githubusercontent.com/u/8210299?v=3","gravatar_id":"","url":"https://api.github.com/users/gazal-k","html_url":"https://github.com/gazal-k","followers_url":"https://api.github.com/users/gazal-k/followers","following_url":"https://api.github.com/users/gazal-k/following{/other_user}","gists_url":"https://api.github.com/users/gazal-k/gists{/gist_id}","starred_url":"https://api.github.com/users/gazal-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gazal-k/subscriptions","organizations_url":"https://api.github.com/users/gazal-k/orgs","repos_url":"https://api.github.com/users/gazal-k/repos","events_url":"https://api.github.com/users/gazal-k/events{/privacy}","received_events_url":"https://api.github.com/users/gazal-k/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-04-08T18:37:21Z","updated_at":"2015-04-16T13:57:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dc-js/dc.js/pulls/908","html_url":"https://github.com/dc-js/dc.js/pull/908","diff_url":"https://github.com/dc-js/dc.js/pull/908.diff","patch_url":"https://github.com/dc-js/dc.js/pull/908.patch"},"body":"The way the x axis was rendered for heatmap chart had one restriction for us, we couldn't rotate the tick labels like we could for coordinate grid charts, bubble chart etc.\r\n\r\nSpecifically, there was a single g.cols.axis element under which all the text elements were placed.\r\nThe x,y positioning was done separately for each text element.\r\n\r\nThis modification wraps each text element in a g.axis element where the x positioning is done using a translate transform. And the y positioning is done on the g.cols.axis element. This makes it easier to apply renderlets on the text elements for transformations such as rotation.\r\n\r\nDidn't change the y axis rendering as we weren't sure whether it'll be useful. But if necessary, a similar modification can be made."},"comment":{"url":"https://api.github.com/repos/dc-js/dc.js/issues/comments/93740691","html_url":"https://github.com/dc-js/dc.js/pull/908#issuecomment-93740691","issue_url":"https://api.github.com/repos/dc-js/dc.js/issues/908","id":93740691,"user":{"login":"mtraynham","id":5741321,"avatar_url":"https://avatars.githubusercontent.com/u/5741321?v=3","gravatar_id":"","url":"https://api.github.com/users/mtraynham","html_url":"https://github.com/mtraynham","followers_url":"https://api.github.com/users/mtraynham/followers","following_url":"https://api.github.com/users/mtraynham/following{/other_user}","gists_url":"https://api.github.com/users/mtraynham/gists{/gist_id}","starred_url":"https://api.github.com/users/mtraynham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtraynham/subscriptions","organizations_url":"https://api.github.com/users/mtraynham/orgs","repos_url":"https://api.github.com/users/mtraynham/repos","events_url":"https://api.github.com/users/mtraynham/events{/privacy}","received_events_url":"https://api.github.com/users/mtraynham/received_events","type":"User","site_admin":false},"created_at":"2015-04-16T13:57:26Z","updated_at":"2015-04-16T13:57:26Z","body":"@gazal-k Hey that would be awesome!  I'll be in the gitter chat if you want to talk about it."}}