{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/engine/pulls/comments/42521219","id":42521219,"diff_hunk":"@@ -53,7 +54,7 @@ Future<UrlResponse> fetchUrl(String relativeUrl) async {\n   UrlRequest request = new UrlRequest()\n     ..url = url\n     ..autoFollowRedirects = true;\n-  return await fetch(request);\n+  return fetch(request);","path":"sky/packages/sky/lib/src/services/fetch.dart","position":24,"original_position":24,"commit_id":"c87c1e0322d5be922e62a117984802c55abefd22","original_commit_id":"c87c1e0322d5be922e62a117984802c55abefd22","user":{"login":"jimbeveridge","id":7953123,"avatar_url":"https://avatars.githubusercontent.com/u/7953123?v=3","gravatar_id":"","url":"https://api.github.com/users/jimbeveridge","html_url":"https://github.com/jimbeveridge","followers_url":"https://api.github.com/users/jimbeveridge/followers","following_url":"https://api.github.com/users/jimbeveridge/following{/other_user}","gists_url":"https://api.github.com/users/jimbeveridge/gists{/gist_id}","starred_url":"https://api.github.com/users/jimbeveridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimbeveridge/subscriptions","organizations_url":"https://api.github.com/users/jimbeveridge/orgs","repos_url":"https://api.github.com/users/jimbeveridge/repos","events_url":"https://api.github.com/users/jimbeveridge/events{/privacy}","received_events_url":"https://api.github.com/users/jimbeveridge/received_events","type":"User","site_admin":false},"body":"fetch() and Future<UrlResponse> both return a Future<UrlResponse>, so this return just passes it through. The only reason you need an await is if you were doing some additional processing before returning. @johnmccutchan, could you please confirm or deny this?\r\n\r\n","created_at":"2015-10-20T16:47:35Z","updated_at":"2015-10-20T16:47:35Z","html_url":"https://github.com/flutter/engine/pull/1693#discussion_r42521219","pull_request_url":"https://api.github.com/repos/flutter/engine/pulls/1693","_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments/42521219"},"html":{"href":"https://github.com/flutter/engine/pull/1693#discussion_r42521219"},"pull_request":{"href":"https://api.github.com/repos/flutter/engine/pulls/1693"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/engine/pulls/1693","id":48222878,"html_url":"https://github.com/flutter/engine/pull/1693","diff_url":"https://github.com/flutter/engine/pull/1693.diff","patch_url":"https://github.com/flutter/engine/pull/1693.patch","issue_url":"https://api.github.com/repos/flutter/engine/issues/1693","number":1693,"state":"open","locked":false,"title":"Close the UrlLoaderProxy on error.","user":{"login":"jimbeveridge","id":7953123,"avatar_url":"https://avatars.githubusercontent.com/u/7953123?v=3","gravatar_id":"","url":"https://api.github.com/users/jimbeveridge","html_url":"https://github.com/jimbeveridge","followers_url":"https://api.github.com/users/jimbeveridge/followers","following_url":"https://api.github.com/users/jimbeveridge/following{/other_user}","gists_url":"https://api.github.com/users/jimbeveridge/gists{/gist_id}","starred_url":"https://api.github.com/users/jimbeveridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimbeveridge/subscriptions","organizations_url":"https://api.github.com/users/jimbeveridge/orgs","repos_url":"https://api.github.com/users/jimbeveridge/repos","events_url":"https://api.github.com/users/jimbeveridge/events{/privacy}","received_events_url":"https://api.github.com/users/jimbeveridge/received_events","type":"User","site_admin":false},"body":"Fixes #1680.","created_at":"2015-10-20T16:12:20Z","updated_at":"2015-10-20T16:47:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f4f7d8c1f4a15dc7750b0df89f1bfa4de631f37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flutter/engine/pulls/1693/commits","review_comments_url":"https://api.github.com/repos/flutter/engine/pulls/1693/comments","review_comment_url":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/engine/issues/1693/comments","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/c87c1e0322d5be922e62a117984802c55abefd22","head":{"label":"jimbeveridge:close","ref":"close","sha":"c87c1e0322d5be922e62a117984802c55abefd22","user":{"login":"jimbeveridge","id":7953123,"avatar_url":"https://avatars.githubusercontent.com/u/7953123?v=3","gravatar_id":"","url":"https://api.github.com/users/jimbeveridge","html_url":"https://github.com/jimbeveridge","followers_url":"https://api.github.com/users/jimbeveridge/followers","following_url":"https://api.github.com/users/jimbeveridge/following{/other_user}","gists_url":"https://api.github.com/users/jimbeveridge/gists{/gist_id}","starred_url":"https://api.github.com/users/jimbeveridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimbeveridge/subscriptions","organizations_url":"https://api.github.com/users/jimbeveridge/orgs","repos_url":"https://api.github.com/users/jimbeveridge/repos","events_url":"https://api.github.com/users/jimbeveridge/events{/privacy}","received_events_url":"https://api.github.com/users/jimbeveridge/received_events","type":"User","site_admin":false},"repo":{"id":39976739,"name":"sky_engine","full_name":"jimbeveridge/sky_engine","owner":{"login":"jimbeveridge","id":7953123,"avatar_url":"https://avatars.githubusercontent.com/u/7953123?v=3","gravatar_id":"","url":"https://api.github.com/users/jimbeveridge","html_url":"https://github.com/jimbeveridge","followers_url":"https://api.github.com/users/jimbeveridge/followers","following_url":"https://api.github.com/users/jimbeveridge/following{/other_user}","gists_url":"https://api.github.com/users/jimbeveridge/gists{/gist_id}","starred_url":"https://api.github.com/users/jimbeveridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimbeveridge/subscriptions","organizations_url":"https://api.github.com/users/jimbeveridge/orgs","repos_url":"https://api.github.com/users/jimbeveridge/repos","events_url":"https://api.github.com/users/jimbeveridge/events{/privacy}","received_events_url":"https://api.github.com/users/jimbeveridge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimbeveridge/sky_engine","description":"The Sky engine","fork":true,"url":"https://api.github.com/repos/jimbeveridge/sky_engine","forks_url":"https://api.github.com/repos/jimbeveridge/sky_engine/forks","keys_url":"https://api.github.com/repos/jimbeveridge/sky_engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimbeveridge/sky_engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimbeveridge/sky_engine/teams","hooks_url":"https://api.github.com/repos/jimbeveridge/sky_engine/hooks","issue_events_url":"https://api.github.com/repos/jimbeveridge/sky_engine/issues/events{/number}","events_url":"https://api.github.com/repos/jimbeveridge/sky_engine/events","assignees_url":"https://api.github.com/repos/jimbeveridge/sky_engine/assignees{/user}","branches_url":"https://api.github.com/repos/jimbeveridge/sky_engine/branches{/branch}","tags_url":"https://api.github.com/repos/jimbeveridge/sky_engine/tags","blobs_url":"https://api.github.com/repos/jimbeveridge/sky_engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimbeveridge/sky_engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimbeveridge/sky_engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimbeveridge/sky_engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimbeveridge/sky_engine/statuses/{sha}","languages_url":"https://api.github.com/repos/jimbeveridge/sky_engine/languages","stargazers_url":"https://api.github.com/repos/jimbeveridge/sky_engine/stargazers","contributors_url":"https://api.github.com/repos/jimbeveridge/sky_engine/contributors","subscribers_url":"https://api.github.com/repos/jimbeveridge/sky_engine/subscribers","subscription_url":"https://api.github.com/repos/jimbeveridge/sky_engine/subscription","commits_url":"https://api.github.com/repos/jimbeveridge/sky_engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimbeveridge/sky_engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimbeveridge/sky_engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimbeveridge/sky_engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimbeveridge/sky_engine/contents/{+path}","compare_url":"https://api.github.com/repos/jimbeveridge/sky_engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimbeveridge/sky_engine/merges","archive_url":"https://api.github.com/repos/jimbeveridge/sky_engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimbeveridge/sky_engine/downloads","issues_url":"https://api.github.com/repos/jimbeveridge/sky_engine/issues{/number}","pulls_url":"https://api.github.com/repos/jimbeveridge/sky_engine/pulls{/number}","milestones_url":"https://api.github.com/repos/jimbeveridge/sky_engine/milestones{/number}","notifications_url":"https://api.github.com/repos/jimbeveridge/sky_engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimbeveridge/sky_engine/labels{/name}","releases_url":"https://api.github.com/repos/jimbeveridge/sky_engine/releases{/id}","created_at":"2015-07-30T23:25:58Z","updated_at":"2015-07-30T23:26:17Z","pushed_at":"2015-10-20T16:11:13Z","git_url":"git://github.com/jimbeveridge/sky_engine.git","ssh_url":"git@github.com:jimbeveridge/sky_engine.git","clone_url":"https://github.com/jimbeveridge/sky_engine.git","svn_url":"https://github.com/jimbeveridge/sky_engine","homepage":null,"size":77585,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"1d55f9ff20a2b2dce204ba1fe2f569a4dafeafb2","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39211337,"name":"engine","full_name":"flutter/engine","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/engine","description":"The Flutter engine","fork":false,"url":"https://api.github.com/repos/flutter/engine","forks_url":"https://api.github.com/repos/flutter/engine/forks","keys_url":"https://api.github.com/repos/flutter/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/engine/teams","hooks_url":"https://api.github.com/repos/flutter/engine/hooks","issue_events_url":"https://api.github.com/repos/flutter/engine/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/engine/events","assignees_url":"https://api.github.com/repos/flutter/engine/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/engine/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/engine/tags","blobs_url":"https://api.github.com/repos/flutter/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/engine/languages","stargazers_url":"https://api.github.com/repos/flutter/engine/stargazers","contributors_url":"https://api.github.com/repos/flutter/engine/contributors","subscribers_url":"https://api.github.com/repos/flutter/engine/subscribers","subscription_url":"https://api.github.com/repos/flutter/engine/subscription","commits_url":"https://api.github.com/repos/flutter/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/engine/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/engine/merges","archive_url":"https://api.github.com/repos/flutter/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/engine/downloads","issues_url":"https://api.github.com/repos/flutter/engine/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/engine/labels{/name}","releases_url":"https://api.github.com/repos/flutter/engine/releases{/id}","created_at":"2015-07-16T17:39:56Z","updated_at":"2015-10-20T14:21:05Z","pushed_at":"2015-10-20T16:44:09Z","git_url":"git://github.com/flutter/engine.git","ssh_url":"git@github.com:flutter/engine.git","clone_url":"https://github.com/flutter/engine.git","svn_url":"https://github.com/flutter/engine","homepage":"http://flutter.io","size":92854,"stargazers_count":283,"watchers_count":283,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":195,"forks":65,"open_issues":195,"watchers":283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/1693"},"html":{"href":"https://github.com/flutter/engine/pull/1693"},"issue":{"href":"https://api.github.com/repos/flutter/engine/issues/1693"},"comments":{"href":"https://api.github.com/repos/flutter/engine/issues/1693/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/engine/pulls/1693/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/engine/pulls/1693/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/engine/statuses/c87c1e0322d5be922e62a117984802c55abefd22"}}}}