{"action":"closed","number":27574,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/27574","id":41846331,"html_url":"https://github.com/rust-lang/rust/pull/27574","diff_url":"https://github.com/rust-lang/rust/pull/27574.diff","patch_url":"https://github.com/rust-lang/rust/pull/27574.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/27574","number":27574,"state":"closed","locked":false,"title":"Cache a linear search for the #[staged_api] attribute.","user":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"body":"This search happens a lot! Locally, compiling hyper sees the following improvements:\r\n\r\nbefore\r\n\r\nreal    0m30.843s\r\nuser    0m51.644s\r\nsys     0m2.128s\r\n\r\nreal    0m30.164s\r\nuser    0m53.320s\r\nsys     0m2.208s\r\n\r\nafter\r\n\r\nreal    0m28.438s\r\nuser    0m51.076s\r\nsys     0m2.276s\r\n\r\nreal    0m28.612s\r\nuser    0m51.560s\r\nsys     0m2.192s","created_at":"2015-08-06T23:28:31Z","updated_at":"2015-08-07T02:46:51Z","closed_at":"2015-08-07T02:46:51Z","merged_at":"2015-08-07T02:46:51Z","merge_commit_sha":"bc7979a4b7217fc948c574c522365f6117fb08d2","assignee":{"login":"jroesch","id":696509,"avatar_url":"https://avatars.githubusercontent.com/u/696509?v=3","gravatar_id":"","url":"https://api.github.com/users/jroesch","html_url":"https://github.com/jroesch","followers_url":"https://api.github.com/users/jroesch/followers","following_url":"https://api.github.com/users/jroesch/following{/other_user}","gists_url":"https://api.github.com/users/jroesch/gists{/gist_id}","starred_url":"https://api.github.com/users/jroesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jroesch/subscriptions","organizations_url":"https://api.github.com/users/jroesch/orgs","repos_url":"https://api.github.com/users/jroesch/repos","events_url":"https://api.github.com/users/jroesch/events{/privacy}","received_events_url":"https://api.github.com/users/jroesch/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/27574/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/27574/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/27574/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/fd142bb741848236d4ab3a7655e58014d29889da","head":{"label":"brson:cache-staged-api","ref":"cache-staged-api","sha":"fd142bb741848236d4ab3a7655e58014d29889da","user":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"repo":{"id":779820,"name":"rust","full_name":"brson/rust","owner":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brson/rust","description":"pursuing the trifecta","fork":true,"url":"https://api.github.com/repos/brson/rust","forks_url":"https://api.github.com/repos/brson/rust/forks","keys_url":"https://api.github.com/repos/brson/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brson/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brson/rust/teams","hooks_url":"https://api.github.com/repos/brson/rust/hooks","issue_events_url":"https://api.github.com/repos/brson/rust/issues/events{/number}","events_url":"https://api.github.com/repos/brson/rust/events","assignees_url":"https://api.github.com/repos/brson/rust/assignees{/user}","branches_url":"https://api.github.com/repos/brson/rust/branches{/branch}","tags_url":"https://api.github.com/repos/brson/rust/tags","blobs_url":"https://api.github.com/repos/brson/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brson/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brson/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/brson/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brson/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/brson/rust/languages","stargazers_url":"https://api.github.com/repos/brson/rust/stargazers","contributors_url":"https://api.github.com/repos/brson/rust/contributors","subscribers_url":"https://api.github.com/repos/brson/rust/subscribers","subscription_url":"https://api.github.com/repos/brson/rust/subscription","commits_url":"https://api.github.com/repos/brson/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/brson/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/brson/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/brson/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/brson/rust/contents/{+path}","compare_url":"https://api.github.com/repos/brson/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brson/rust/merges","archive_url":"https://api.github.com/repos/brson/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brson/rust/downloads","issues_url":"https://api.github.com/repos/brson/rust/issues{/number}","pulls_url":"https://api.github.com/repos/brson/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/brson/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/brson/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brson/rust/labels{/name}","releases_url":"https://api.github.com/repos/brson/rust/releases{/id}","created_at":"2010-07-16T23:45:53Z","updated_at":"2015-05-01T18:47:25Z","pushed_at":"2015-08-06T23:53:15Z","git_url":"git://github.com/brson/rust.git","ssh_url":"git@github.com:brson/rust.git","clone_url":"https://github.com/brson/rust.git","svn_url":"https://github.com/brson/rust","homepage":"http://www.rust-lang.org","size":323851,"stargazers_count":3,"watchers_count":3,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"68f79288bf1ac2b014277750cbf59416c91f7d04","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-08-07T02:33:54Z","pushed_at":"2015-08-07T02:46:44Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":652369,"stargazers_count":12872,"watchers_count":12872,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2492,"mirror_url":null,"open_issues_count":2138,"forks":2492,"open_issues":2138,"watchers":12872,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27574"},"html":{"href":"https://github.com/rust-lang/rust/pull/27574"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/27574"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/27574/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27574/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27574/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/fd142bb741848236d4ab3a7655e58014d29889da"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"avatar_url":"https://avatars.githubusercontent.com/u/3372342?v=3","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":6,"review_comments":1,"commits":1,"additions":15,"deletions":10,"changed_files":3}}