{"push_id":804400836,"size":3,"distinct_size":3,"ref":"refs/heads/master","head":"246ab92a0b6dce328f987f7e1576951f6ab01794","before":"0572b05ec73828c935231486ba9a1451239740a4","commits":[{"sha":"f377f7f927d62c55c45a0c9c99e8b519c72b59b1","author":{"email":"363321912c8af25d1104fb33c2c64b848c097226@fb.com","name":"Joel Marcey"},"message":"Ensure we have a standalone serial test bucket and make specifying serial tests more generic\n\nSummary: We didn't have a standalone serial test bucket before.\n\nWhen running `test/run test/slow/ext_mysqli/ test/slow/ext_memcache test/slow/ext_memcached/`\n\nSee the buckets in our current system; look at bucket 4. It contains the serial tests, but it also had a parallel test in it (`return_types`).\n\nP20039027\n\nThe new way ensures that there is a bucket for serial tests only. See bucket 31. Only the 8 tests that are supposed to be serial are there.\n\nP20039029\n\nThis diff also adds a `.serial` file for those tests that will be put in the serial bucket.\nNow we don't have to hard code those tests in the code and we can easily add\nmore serial tests with the `touch` of a file.\n\nUse case: I want to run some of our documentation tests in serial, particularly\nthe async mysql ones.\n\nReviewed By: @jwatzman\n\nDifferential Revision: D2469773","distinct":true,"url":"https://api.github.com/repos/facebook/hhvm/commits/f377f7f927d62c55c45a0c9c99e8b519c72b59b1"},{"sha":"f680cd4d5891a94179ed3acd2159fbf3ff3c7d31","author":{"email":"363321912c8af25d1104fb33c2c64b848c097226@fb.com","name":"Joel Marcey"},"message":"flushAll returns mc_res_ok, not mc_res_stored (isStored())\n\nSummary: We are throwing an exception even when `flushAll` succeeds:\n\n```\nFatal error: Uncaught exception 'MCRouterException' with message 'flushall failed with result mc_res_ok' in /data/users/joelm/user-documentation/guides/hack/99-api-examples/mcrouter-examples/mcrouter-examples/flushAll.php:53\nStack trace:\n```\n\nThis is because we were checking for the wrong reply value. This changes that so we check for the right one.\n\nReviewed By: @pavlo-fb\n\nDifferential Revision: D2474930","distinct":true,"url":"https://api.github.com/repos/facebook/hhvm/commits/f680cd4d5891a94179ed3acd2159fbf3ff3c7d31"},{"sha":"246ab92a0b6dce328f987f7e1576951f6ab01794","author":{"email":"363321912c8af25d1104fb33c2c64b848c097226@fb.com","name":"Joel Marcey"},"message":"Annotate AsyncMysqlQueryErrorResult::getSuccessfulResults return Vector\n\nSummary: ```\ngetSuccessfulResults.php:39:15,44: You cannot use this Vector (Typing[4008])\n  /tmp/hh_server/hhi_85e59ed/hhi/stdlib/builtins_async_mysql.hhi:122:43,48: It is missing its type parameters\n```\n\nSo add the type of the `Vector` which is `AsyncMysqlQueryResult`.\n\nReviewed By: @jwatzman\n\nDifferential Revision: D2468914","distinct":true,"url":"https://api.github.com/repos/facebook/hhvm/commits/246ab92a0b6dce328f987f7e1576951f6ab01794"}]}