{"action":"opened","number":77,"pull_request":{"url":"https://api.github.com/repos/soulwire/sketch.js/pulls/77","id":49560949,"html_url":"https://github.com/soulwire/sketch.js/pull/77","diff_url":"https://github.com/soulwire/sketch.js/pull/77.diff","patch_url":"https://github.com/soulwire/sketch.js/pull/77.patch","issue_url":"https://api.github.com/repos/soulwire/sketch.js/issues/77","number":77,"state":"open","locked":false,"title":"Scaling retina coordinates for all callbacks","user":{"login":"filR","id":2776512,"avatar_url":"https://avatars.githubusercontent.com/u/2776512?v=3","gravatar_id":"","url":"https://api.github.com/users/filR","html_url":"https://github.com/filR","followers_url":"https://api.github.com/users/filR/followers","following_url":"https://api.github.com/users/filR/following{/other_user}","gists_url":"https://api.github.com/users/filR/gists{/gist_id}","starred_url":"https://api.github.com/users/filR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filR/subscriptions","organizations_url":"https://api.github.com/users/filR/orgs","repos_url":"https://api.github.com/users/filR/repos","events_url":"https://api.github.com/users/filR/events{/privacy}","received_events_url":"https://api.github.com/users/filR/received_events","type":"User","site_admin":false},"body":"Before this pull request, when in \"retina land\", only the `draw` callback and no other had its coordinate system scaled. This means that coordinates were inconsistent between `draw` and `sketch.mouse` on the one hand and all other callbacks (such as `update` and `touchmove`) on the other.\r\n\r\nIn this pull request I moved the execution of `update` to also be affected by the `draw` scaling. Furthermore I added a scaling wrapper around all other callbacks. I also removed my previous pull request which \"fixes\" the mouse retina coordinates for all \"other\" callbacks, but inconveniently breaks it for `draw`.\r\n\r\nAll changes affect only `retina: true` scenes.\r\nPlease let me know if you had another solution in mind or anything is unclear, I am happy to adjust this pull request to whatever fits the project. Thanks!","created_at":"2015-11-03T14:25:28Z","updated_at":"2015-11-03T14:25:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/soulwire/sketch.js/pulls/77/commits","review_comments_url":"https://api.github.com/repos/soulwire/sketch.js/pulls/77/comments","review_comment_url":"https://api.github.com/repos/soulwire/sketch.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/soulwire/sketch.js/issues/77/comments","statuses_url":"https://api.github.com/repos/soulwire/sketch.js/statuses/2f79606d9b4e8c2d7d732504c118d83d9e875457","head":{"label":"filR:fix_retina_coordinates","ref":"fix_retina_coordinates","sha":"2f79606d9b4e8c2d7d732504c118d83d9e875457","user":{"login":"filR","id":2776512,"avatar_url":"https://avatars.githubusercontent.com/u/2776512?v=3","gravatar_id":"","url":"https://api.github.com/users/filR","html_url":"https://github.com/filR","followers_url":"https://api.github.com/users/filR/followers","following_url":"https://api.github.com/users/filR/following{/other_user}","gists_url":"https://api.github.com/users/filR/gists{/gist_id}","starred_url":"https://api.github.com/users/filR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filR/subscriptions","organizations_url":"https://api.github.com/users/filR/orgs","repos_url":"https://api.github.com/users/filR/repos","events_url":"https://api.github.com/users/filR/events{/privacy}","received_events_url":"https://api.github.com/users/filR/received_events","type":"User","site_admin":false},"repo":{"id":44315944,"name":"sketch.js","full_name":"filR/sketch.js","owner":{"login":"filR","id":2776512,"avatar_url":"https://avatars.githubusercontent.com/u/2776512?v=3","gravatar_id":"","url":"https://api.github.com/users/filR","html_url":"https://github.com/filR","followers_url":"https://api.github.com/users/filR/followers","following_url":"https://api.github.com/users/filR/following{/other_user}","gists_url":"https://api.github.com/users/filR/gists{/gist_id}","starred_url":"https://api.github.com/users/filR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filR/subscriptions","organizations_url":"https://api.github.com/users/filR/orgs","repos_url":"https://api.github.com/users/filR/repos","events_url":"https://api.github.com/users/filR/events{/privacy}","received_events_url":"https://api.github.com/users/filR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/filR/sketch.js","description":"Cross-Platform JavaScript Creative Coding Framework","fork":true,"url":"https://api.github.com/repos/filR/sketch.js","forks_url":"https://api.github.com/repos/filR/sketch.js/forks","keys_url":"https://api.github.com/repos/filR/sketch.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filR/sketch.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filR/sketch.js/teams","hooks_url":"https://api.github.com/repos/filR/sketch.js/hooks","issue_events_url":"https://api.github.com/repos/filR/sketch.js/issues/events{/number}","events_url":"https://api.github.com/repos/filR/sketch.js/events","assignees_url":"https://api.github.com/repos/filR/sketch.js/assignees{/user}","branches_url":"https://api.github.com/repos/filR/sketch.js/branches{/branch}","tags_url":"https://api.github.com/repos/filR/sketch.js/tags","blobs_url":"https://api.github.com/repos/filR/sketch.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filR/sketch.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filR/sketch.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/filR/sketch.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filR/sketch.js/statuses/{sha}","languages_url":"https://api.github.com/repos/filR/sketch.js/languages","stargazers_url":"https://api.github.com/repos/filR/sketch.js/stargazers","contributors_url":"https://api.github.com/repos/filR/sketch.js/contributors","subscribers_url":"https://api.github.com/repos/filR/sketch.js/subscribers","subscription_url":"https://api.github.com/repos/filR/sketch.js/subscription","commits_url":"https://api.github.com/repos/filR/sketch.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/filR/sketch.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/filR/sketch.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/filR/sketch.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/filR/sketch.js/contents/{+path}","compare_url":"https://api.github.com/repos/filR/sketch.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filR/sketch.js/merges","archive_url":"https://api.github.com/repos/filR/sketch.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filR/sketch.js/downloads","issues_url":"https://api.github.com/repos/filR/sketch.js/issues{/number}","pulls_url":"https://api.github.com/repos/filR/sketch.js/pulls{/number}","milestones_url":"https://api.github.com/repos/filR/sketch.js/milestones{/number}","notifications_url":"https://api.github.com/repos/filR/sketch.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filR/sketch.js/labels{/name}","releases_url":"https://api.github.com/repos/filR/sketch.js/releases{/id}","created_at":"2015-10-15T12:30:07Z","updated_at":"2015-10-15T12:30:08Z","pushed_at":"2015-11-03T14:14:32Z","git_url":"git://github.com/filR/sketch.js.git","ssh_url":"git@github.com:filR/sketch.js.git","clone_url":"https://github.com/filR/sketch.js.git","svn_url":"https://github.com/filR/sketch.js","homepage":"","size":656,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"soulwire:master","ref":"master","sha":"3d5b8e83f9c06114addcb10ffbd1123010f9e4e1","user":{"login":"soulwire","id":346311,"avatar_url":"https://avatars.githubusercontent.com/u/346311?v=3","gravatar_id":"","url":"https://api.github.com/users/soulwire","html_url":"https://github.com/soulwire","followers_url":"https://api.github.com/users/soulwire/followers","following_url":"https://api.github.com/users/soulwire/following{/other_user}","gists_url":"https://api.github.com/users/soulwire/gists{/gist_id}","starred_url":"https://api.github.com/users/soulwire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soulwire/subscriptions","organizations_url":"https://api.github.com/users/soulwire/orgs","repos_url":"https://api.github.com/users/soulwire/repos","events_url":"https://api.github.com/users/soulwire/events{/privacy}","received_events_url":"https://api.github.com/users/soulwire/received_events","type":"User","site_admin":false},"repo":{"id":4967590,"name":"sketch.js","full_name":"soulwire/sketch.js","owner":{"login":"soulwire","id":346311,"avatar_url":"https://avatars.githubusercontent.com/u/346311?v=3","gravatar_id":"","url":"https://api.github.com/users/soulwire","html_url":"https://github.com/soulwire","followers_url":"https://api.github.com/users/soulwire/followers","following_url":"https://api.github.com/users/soulwire/following{/other_user}","gists_url":"https://api.github.com/users/soulwire/gists{/gist_id}","starred_url":"https://api.github.com/users/soulwire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soulwire/subscriptions","organizations_url":"https://api.github.com/users/soulwire/orgs","repos_url":"https://api.github.com/users/soulwire/repos","events_url":"https://api.github.com/users/soulwire/events{/privacy}","received_events_url":"https://api.github.com/users/soulwire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/soulwire/sketch.js","description":"Cross-Platform JavaScript Creative Coding Framework","fork":false,"url":"https://api.github.com/repos/soulwire/sketch.js","forks_url":"https://api.github.com/repos/soulwire/sketch.js/forks","keys_url":"https://api.github.com/repos/soulwire/sketch.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soulwire/sketch.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soulwire/sketch.js/teams","hooks_url":"https://api.github.com/repos/soulwire/sketch.js/hooks","issue_events_url":"https://api.github.com/repos/soulwire/sketch.js/issues/events{/number}","events_url":"https://api.github.com/repos/soulwire/sketch.js/events","assignees_url":"https://api.github.com/repos/soulwire/sketch.js/assignees{/user}","branches_url":"https://api.github.com/repos/soulwire/sketch.js/branches{/branch}","tags_url":"https://api.github.com/repos/soulwire/sketch.js/tags","blobs_url":"https://api.github.com/repos/soulwire/sketch.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soulwire/sketch.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soulwire/sketch.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/soulwire/sketch.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soulwire/sketch.js/statuses/{sha}","languages_url":"https://api.github.com/repos/soulwire/sketch.js/languages","stargazers_url":"https://api.github.com/repos/soulwire/sketch.js/stargazers","contributors_url":"https://api.github.com/repos/soulwire/sketch.js/contributors","subscribers_url":"https://api.github.com/repos/soulwire/sketch.js/subscribers","subscription_url":"https://api.github.com/repos/soulwire/sketch.js/subscription","commits_url":"https://api.github.com/repos/soulwire/sketch.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/soulwire/sketch.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/soulwire/sketch.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/soulwire/sketch.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/soulwire/sketch.js/contents/{+path}","compare_url":"https://api.github.com/repos/soulwire/sketch.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soulwire/sketch.js/merges","archive_url":"https://api.github.com/repos/soulwire/sketch.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soulwire/sketch.js/downloads","issues_url":"https://api.github.com/repos/soulwire/sketch.js/issues{/number}","pulls_url":"https://api.github.com/repos/soulwire/sketch.js/pulls{/number}","milestones_url":"https://api.github.com/repos/soulwire/sketch.js/milestones{/number}","notifications_url":"https://api.github.com/repos/soulwire/sketch.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soulwire/sketch.js/labels{/name}","releases_url":"https://api.github.com/repos/soulwire/sketch.js/releases{/id}","created_at":"2012-07-10T01:55:55Z","updated_at":"2015-11-03T01:26:23Z","pushed_at":"2015-10-26T16:15:10Z","git_url":"git://github.com/soulwire/sketch.js.git","ssh_url":"git@github.com:soulwire/sketch.js.git","clone_url":"https://github.com/soulwire/sketch.js.git","svn_url":"https://github.com/soulwire/sketch.js","homepage":"","size":1172,"stargazers_count":1798,"watchers_count":1798,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":207,"mirror_url":null,"open_issues_count":14,"forks":207,"open_issues":14,"watchers":1798,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/soulwire/sketch.js/pulls/77"},"html":{"href":"https://github.com/soulwire/sketch.js/pull/77"},"issue":{"href":"https://api.github.com/repos/soulwire/sketch.js/issues/77"},"comments":{"href":"https://api.github.com/repos/soulwire/sketch.js/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/soulwire/sketch.js/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/soulwire/sketch.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/soulwire/sketch.js/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/soulwire/sketch.js/statuses/2f79606d9b4e8c2d7d732504c118d83d9e875457"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":23,"deletions":12,"changed_files":2}}