{"action":"created","comment":{"url":"https://api.github.com/repos/cb372/scalacache/pulls/comments/43613280","id":43613280,"diff_hunk":"@@ -27,6 +27,10 @@ package object scalacache extends StrictLogging {\n       _caching(keyParts: _*)(Some(ttl))(f)\n     }\n \n+    def cachingWithOptionalTTL(keyParts: Any*)(optionalttl: Option[Duration])(f: => Future[V])(implicit flags: Flags, execContext: ExecutionContext = ExecutionContext.global): Future[V] = {","path":"core/src/main/scala/scalacache/package.scala","position":4,"original_position":4,"commit_id":"04bd027aadb7989aeb3d97da9646c84b9c6f728a","original_commit_id":"04bd027aadb7989aeb3d97da9646c84b9c6f728a","user":{"login":"cb372","id":106760,"avatar_url":"https://avatars.githubusercontent.com/u/106760?v=3","gravatar_id":"","url":"https://api.github.com/users/cb372","html_url":"https://github.com/cb372","followers_url":"https://api.github.com/users/cb372/followers","following_url":"https://api.github.com/users/cb372/following{/other_user}","gists_url":"https://api.github.com/users/cb372/gists{/gist_id}","starred_url":"https://api.github.com/users/cb372/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cb372/subscriptions","organizations_url":"https://api.github.com/users/cb372/orgs","repos_url":"https://api.github.com/users/cb372/repos","events_url":"https://api.github.com/users/cb372/events{/privacy}","received_events_url":"https://api.github.com/users/cb372/received_events","type":"User","site_admin":false},"body":"For consistency with other methods, please add a wrapper for this in the top-level of the package object, similar to `cachingWithTTL` on line 225. (Sorry, it's a little confusing - there's a typed API and an untyped wrapper, with sync and async variants, meaning a total of 4 places to add new methods!)","created_at":"2015-11-02T10:15:10Z","updated_at":"2015-11-02T10:15:10Z","html_url":"https://github.com/cb372/scalacache/pull/72#discussion_r43613280","pull_request_url":"https://api.github.com/repos/cb372/scalacache/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/cb372/scalacache/pulls/comments/43613280"},"html":{"href":"https://github.com/cb372/scalacache/pull/72#discussion_r43613280"},"pull_request":{"href":"https://api.github.com/repos/cb372/scalacache/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/cb372/scalacache/pulls/72","id":49390835,"html_url":"https://github.com/cb372/scalacache/pull/72","diff_url":"https://github.com/cb372/scalacache/pull/72.diff","patch_url":"https://github.com/cb372/scalacache/pull/72.patch","issue_url":"https://api.github.com/repos/cb372/scalacache/issues/72","number":72,"state":"open","locked":false,"title":"- Initial commit, added optional TTL implementations of memoize","user":{"login":"mdedetrich","id":2337269,"avatar_url":"https://avatars.githubusercontent.com/u/2337269?v=3","gravatar_id":"","url":"https://api.github.com/users/mdedetrich","html_url":"https://github.com/mdedetrich","followers_url":"https://api.github.com/users/mdedetrich/followers","following_url":"https://api.github.com/users/mdedetrich/following{/other_user}","gists_url":"https://api.github.com/users/mdedetrich/gists{/gist_id}","starred_url":"https://api.github.com/users/mdedetrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdedetrich/subscriptions","organizations_url":"https://api.github.com/users/mdedetrich/orgs","repos_url":"https://api.github.com/users/mdedetrich/repos","events_url":"https://api.github.com/users/mdedetrich/events{/privacy}","received_events_url":"https://api.github.com/users/mdedetrich/received_events","type":"User","site_admin":false},"body":"This just adds implementations of memoize with an optionalttl argument (i.e. `Option[Duration]`). Internally we use `Option[Duration]` often.\r\n\r\nLet me know if you want to add unit tests for the additions, the change is however very trivial","created_at":"2015-11-02T03:02:26Z","updated_at":"2015-11-02T10:15:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff181ad55c72dc01a87a7adff59e2223b22d4d09","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cb372/scalacache/pulls/72/commits","review_comments_url":"https://api.github.com/repos/cb372/scalacache/pulls/72/comments","review_comment_url":"https://api.github.com/repos/cb372/scalacache/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cb372/scalacache/issues/72/comments","statuses_url":"https://api.github.com/repos/cb372/scalacache/statuses/04bd027aadb7989aeb3d97da9646c84b9c6f728a","head":{"label":"mdedetrich:memoizeOptionalTTLParameter","ref":"memoizeOptionalTTLParameter","sha":"04bd027aadb7989aeb3d97da9646c84b9c6f728a","user":{"login":"mdedetrich","id":2337269,"avatar_url":"https://avatars.githubusercontent.com/u/2337269?v=3","gravatar_id":"","url":"https://api.github.com/users/mdedetrich","html_url":"https://github.com/mdedetrich","followers_url":"https://api.github.com/users/mdedetrich/followers","following_url":"https://api.github.com/users/mdedetrich/following{/other_user}","gists_url":"https://api.github.com/users/mdedetrich/gists{/gist_id}","starred_url":"https://api.github.com/users/mdedetrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdedetrich/subscriptions","organizations_url":"https://api.github.com/users/mdedetrich/orgs","repos_url":"https://api.github.com/users/mdedetrich/repos","events_url":"https://api.github.com/users/mdedetrich/events{/privacy}","received_events_url":"https://api.github.com/users/mdedetrich/received_events","type":"User","site_admin":false},"repo":{"id":44642586,"name":"scalacache","full_name":"mdedetrich/scalacache","owner":{"login":"mdedetrich","id":2337269,"avatar_url":"https://avatars.githubusercontent.com/u/2337269?v=3","gravatar_id":"","url":"https://api.github.com/users/mdedetrich","html_url":"https://github.com/mdedetrich","followers_url":"https://api.github.com/users/mdedetrich/followers","following_url":"https://api.github.com/users/mdedetrich/following{/other_user}","gists_url":"https://api.github.com/users/mdedetrich/gists{/gist_id}","starred_url":"https://api.github.com/users/mdedetrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdedetrich/subscriptions","organizations_url":"https://api.github.com/users/mdedetrich/orgs","repos_url":"https://api.github.com/users/mdedetrich/repos","events_url":"https://api.github.com/users/mdedetrich/events{/privacy}","received_events_url":"https://api.github.com/users/mdedetrich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdedetrich/scalacache","description":"Simple caching in Scala","fork":true,"url":"https://api.github.com/repos/mdedetrich/scalacache","forks_url":"https://api.github.com/repos/mdedetrich/scalacache/forks","keys_url":"https://api.github.com/repos/mdedetrich/scalacache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdedetrich/scalacache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdedetrich/scalacache/teams","hooks_url":"https://api.github.com/repos/mdedetrich/scalacache/hooks","issue_events_url":"https://api.github.com/repos/mdedetrich/scalacache/issues/events{/number}","events_url":"https://api.github.com/repos/mdedetrich/scalacache/events","assignees_url":"https://api.github.com/repos/mdedetrich/scalacache/assignees{/user}","branches_url":"https://api.github.com/repos/mdedetrich/scalacache/branches{/branch}","tags_url":"https://api.github.com/repos/mdedetrich/scalacache/tags","blobs_url":"https://api.github.com/repos/mdedetrich/scalacache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdedetrich/scalacache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdedetrich/scalacache/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdedetrich/scalacache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdedetrich/scalacache/statuses/{sha}","languages_url":"https://api.github.com/repos/mdedetrich/scalacache/languages","stargazers_url":"https://api.github.com/repos/mdedetrich/scalacache/stargazers","contributors_url":"https://api.github.com/repos/mdedetrich/scalacache/contributors","subscribers_url":"https://api.github.com/repos/mdedetrich/scalacache/subscribers","subscription_url":"https://api.github.com/repos/mdedetrich/scalacache/subscription","commits_url":"https://api.github.com/repos/mdedetrich/scalacache/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdedetrich/scalacache/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdedetrich/scalacache/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdedetrich/scalacache/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdedetrich/scalacache/contents/{+path}","compare_url":"https://api.github.com/repos/mdedetrich/scalacache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdedetrich/scalacache/merges","archive_url":"https://api.github.com/repos/mdedetrich/scalacache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdedetrich/scalacache/downloads","issues_url":"https://api.github.com/repos/mdedetrich/scalacache/issues{/number}","pulls_url":"https://api.github.com/repos/mdedetrich/scalacache/pulls{/number}","milestones_url":"https://api.github.com/repos/mdedetrich/scalacache/milestones{/number}","notifications_url":"https://api.github.com/repos/mdedetrich/scalacache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdedetrich/scalacache/labels{/name}","releases_url":"https://api.github.com/repos/mdedetrich/scalacache/releases{/id}","created_at":"2015-10-21T00:21:18Z","updated_at":"2015-10-21T00:21:19Z","pushed_at":"2015-11-02T03:00:48Z","git_url":"git://github.com/mdedetrich/scalacache.git","ssh_url":"git@github.com:mdedetrich/scalacache.git","clone_url":"https://github.com/mdedetrich/scalacache.git","svn_url":"https://github.com/mdedetrich/scalacache","homepage":"","size":1085,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cb372:master","ref":"master","sha":"e70c81545e32569a3abef05fdf593072666edac5","user":{"login":"cb372","id":106760,"avatar_url":"https://avatars.githubusercontent.com/u/106760?v=3","gravatar_id":"","url":"https://api.github.com/users/cb372","html_url":"https://github.com/cb372","followers_url":"https://api.github.com/users/cb372/followers","following_url":"https://api.github.com/users/cb372/following{/other_user}","gists_url":"https://api.github.com/users/cb372/gists{/gist_id}","starred_url":"https://api.github.com/users/cb372/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cb372/subscriptions","organizations_url":"https://api.github.com/users/cb372/orgs","repos_url":"https://api.github.com/users/cb372/repos","events_url":"https://api.github.com/users/cb372/events{/privacy}","received_events_url":"https://api.github.com/users/cb372/received_events","type":"User","site_admin":false},"repo":{"id":8252003,"name":"scalacache","full_name":"cb372/scalacache","owner":{"login":"cb372","id":106760,"avatar_url":"https://avatars.githubusercontent.com/u/106760?v=3","gravatar_id":"","url":"https://api.github.com/users/cb372","html_url":"https://github.com/cb372","followers_url":"https://api.github.com/users/cb372/followers","following_url":"https://api.github.com/users/cb372/following{/other_user}","gists_url":"https://api.github.com/users/cb372/gists{/gist_id}","starred_url":"https://api.github.com/users/cb372/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cb372/subscriptions","organizations_url":"https://api.github.com/users/cb372/orgs","repos_url":"https://api.github.com/users/cb372/repos","events_url":"https://api.github.com/users/cb372/events{/privacy}","received_events_url":"https://api.github.com/users/cb372/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cb372/scalacache","description":"Simple caching in Scala","fork":false,"url":"https://api.github.com/repos/cb372/scalacache","forks_url":"https://api.github.com/repos/cb372/scalacache/forks","keys_url":"https://api.github.com/repos/cb372/scalacache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cb372/scalacache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cb372/scalacache/teams","hooks_url":"https://api.github.com/repos/cb372/scalacache/hooks","issue_events_url":"https://api.github.com/repos/cb372/scalacache/issues/events{/number}","events_url":"https://api.github.com/repos/cb372/scalacache/events","assignees_url":"https://api.github.com/repos/cb372/scalacache/assignees{/user}","branches_url":"https://api.github.com/repos/cb372/scalacache/branches{/branch}","tags_url":"https://api.github.com/repos/cb372/scalacache/tags","blobs_url":"https://api.github.com/repos/cb372/scalacache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cb372/scalacache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cb372/scalacache/git/refs{/sha}","trees_url":"https://api.github.com/repos/cb372/scalacache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cb372/scalacache/statuses/{sha}","languages_url":"https://api.github.com/repos/cb372/scalacache/languages","stargazers_url":"https://api.github.com/repos/cb372/scalacache/stargazers","contributors_url":"https://api.github.com/repos/cb372/scalacache/contributors","subscribers_url":"https://api.github.com/repos/cb372/scalacache/subscribers","subscription_url":"https://api.github.com/repos/cb372/scalacache/subscription","commits_url":"https://api.github.com/repos/cb372/scalacache/commits{/sha}","git_commits_url":"https://api.github.com/repos/cb372/scalacache/git/commits{/sha}","comments_url":"https://api.github.com/repos/cb372/scalacache/comments{/number}","issue_comment_url":"https://api.github.com/repos/cb372/scalacache/issues/comments{/number}","contents_url":"https://api.github.com/repos/cb372/scalacache/contents/{+path}","compare_url":"https://api.github.com/repos/cb372/scalacache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cb372/scalacache/merges","archive_url":"https://api.github.com/repos/cb372/scalacache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cb372/scalacache/downloads","issues_url":"https://api.github.com/repos/cb372/scalacache/issues{/number}","pulls_url":"https://api.github.com/repos/cb372/scalacache/pulls{/number}","milestones_url":"https://api.github.com/repos/cb372/scalacache/milestones{/number}","notifications_url":"https://api.github.com/repos/cb372/scalacache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cb372/scalacache/labels{/name}","releases_url":"https://api.github.com/repos/cb372/scalacache/releases{/id}","created_at":"2013-02-17T15:07:42Z","updated_at":"2015-10-29T12:31:12Z","pushed_at":"2015-11-02T03:02:26Z","git_url":"git://github.com/cb372/scalacache.git","ssh_url":"git@github.com:cb372/scalacache.git","clone_url":"https://github.com/cb372/scalacache.git","svn_url":"https://github.com/cb372/scalacache","homepage":"","size":1077,"stargazers_count":225,"watchers_count":225,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":9,"forks":20,"open_issues":9,"watchers":225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cb372/scalacache/pulls/72"},"html":{"href":"https://github.com/cb372/scalacache/pull/72"},"issue":{"href":"https://api.github.com/repos/cb372/scalacache/issues/72"},"comments":{"href":"https://api.github.com/repos/cb372/scalacache/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/cb372/scalacache/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/cb372/scalacache/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cb372/scalacache/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/cb372/scalacache/statuses/04bd027aadb7989aeb3d97da9646c84b9c6f728a"}}}}