{"action":"created","comment":{"url":"https://api.github.com/repos/CCI-MOC/haas/pulls/comments/47944486","id":47944486,"diff_hunk":"@@ -664,8 +672,8 @@ def test_headnode_delete_hnic_success(self, db):\n         api.headnode_create('hn-0', 'anvil-nextgen', 'base-headnode')\n         api.headnode_create_hnic('hn-0', 'hn-0-eth0')\n         api.headnode_delete_hnic('hn-0', 'hn-0-eth0')\n-        api._assert_absent(db, model.Hnic, 'hn-0-eth0')\n-        hn = api._must_find(db, model.Headnode, 'hn-0')\n+        api._assert_absent(model.Hnic, 'hn-0-eth0')\n+        hn = api._must_find(model.Headnode, 'hn-0')","path":"tests/unit/api.py","position":208,"original_position":208,"commit_id":"f1f3cf403034b04f5859db4dce72083799e9cc0c","original_commit_id":"f1f3cf403034b04f5859db4dce72083799e9cc0c","user":{"login":"zenhack","id":883774,"avatar_url":"https://avatars.githubusercontent.com/u/883774?v=3","gravatar_id":"","url":"https://api.github.com/users/zenhack","html_url":"https://github.com/zenhack","followers_url":"https://api.github.com/users/zenhack/followers","following_url":"https://api.github.com/users/zenhack/following{/other_user}","gists_url":"https://api.github.com/users/zenhack/gists{/gist_id}","starred_url":"https://api.github.com/users/zenhack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenhack/subscriptions","organizations_url":"https://api.github.com/users/zenhack/orgs","repos_url":"https://api.github.com/users/zenhack/repos","events_url":"https://api.github.com/users/zenhack/events{/privacy}","received_events_url":"https://api.github.com/users/zenhack/received_events","type":"User","site_admin":false},"body":"Yeah, that's odd. My guess is it's just sloppy coding, and the point of that statement it just to make sure the headnode is still in there. Wouldn't it be nice if our test suite was more readable?\r\n\r\nIn any case, it's orthogonal to this patch.","created_at":"2015-12-17T18:50:01Z","updated_at":"2015-12-17T18:50:01Z","html_url":"https://github.com/CCI-MOC/haas/pull/505#discussion_r47944486","pull_request_url":"https://api.github.com/repos/CCI-MOC/haas/pulls/505","_links":{"self":{"href":"https://api.github.com/repos/CCI-MOC/haas/pulls/comments/47944486"},"html":{"href":"https://github.com/CCI-MOC/haas/pull/505#discussion_r47944486"},"pull_request":{"href":"https://api.github.com/repos/CCI-MOC/haas/pulls/505"}}},"pull_request":{"url":"https://api.github.com/repos/CCI-MOC/haas/pulls/505","id":49756411,"html_url":"https://github.com/CCI-MOC/haas/pull/505","diff_url":"https://github.com/CCI-MOC/haas/pull/505.diff","patch_url":"https://github.com/CCI-MOC/haas/pull/505.patch","issue_url":"https://api.github.com/repos/CCI-MOC/haas/issues/505","number":505,"state":"open","locked":false,"title":"Make database sessions request-local (address #454)","user":{"login":"zenhack","id":883774,"avatar_url":"https://avatars.githubusercontent.com/u/883774?v=3","gravatar_id":"","url":"https://api.github.com/users/zenhack","html_url":"https://github.com/zenhack","followers_url":"https://api.github.com/users/zenhack/followers","following_url":"https://api.github.com/users/zenhack/following{/other_user}","gists_url":"https://api.github.com/users/zenhack/gists{/gist_id}","starred_url":"https://api.github.com/users/zenhack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenhack/subscriptions","organizations_url":"https://api.github.com/users/zenhack/orgs","repos_url":"https://api.github.com/users/zenhack/repos","events_url":"https://api.github.com/users/zenhack/events{/privacy}","received_events_url":"https://api.github.com/users/zenhack/received_events","type":"User","site_admin":false},"body":"This fixes #454. There are still a couple TODOs though. I think it's worth doing a lot of that cleanup; if we  don't do it now it will never happen. See the bullet points in the last commit message. Also, I'm unable to run the deployment tests, so while I *think* I've made the necessary adjustments, someone else should check.","created_at":"2015-11-04T22:37:19Z","updated_at":"2015-12-17T18:50:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e901274b04b8b24570388a6a5bb36ed152ea82a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CCI-MOC/haas/pulls/505/commits","review_comments_url":"https://api.github.com/repos/CCI-MOC/haas/pulls/505/comments","review_comment_url":"https://api.github.com/repos/CCI-MOC/haas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CCI-MOC/haas/issues/505/comments","statuses_url":"https://api.github.com/repos/CCI-MOC/haas/statuses/f1f3cf403034b04f5859db4dce72083799e9cc0c","head":{"label":"zenhack:issue-454","ref":"issue-454","sha":"f1f3cf403034b04f5859db4dce72083799e9cc0c","user":{"login":"zenhack","id":883774,"avatar_url":"https://avatars.githubusercontent.com/u/883774?v=3","gravatar_id":"","url":"https://api.github.com/users/zenhack","html_url":"https://github.com/zenhack","followers_url":"https://api.github.com/users/zenhack/followers","following_url":"https://api.github.com/users/zenhack/following{/other_user}","gists_url":"https://api.github.com/users/zenhack/gists{/gist_id}","starred_url":"https://api.github.com/users/zenhack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenhack/subscriptions","organizations_url":"https://api.github.com/users/zenhack/orgs","repos_url":"https://api.github.com/users/zenhack/repos","events_url":"https://api.github.com/users/zenhack/events{/privacy}","received_events_url":"https://api.github.com/users/zenhack/received_events","type":"User","site_admin":false},"repo":{"id":19796467,"name":"haas","full_name":"zenhack/haas","owner":{"login":"zenhack","id":883774,"avatar_url":"https://avatars.githubusercontent.com/u/883774?v=3","gravatar_id":"","url":"https://api.github.com/users/zenhack","html_url":"https://github.com/zenhack","followers_url":"https://api.github.com/users/zenhack/followers","following_url":"https://api.github.com/users/zenhack/following{/other_user}","gists_url":"https://api.github.com/users/zenhack/gists{/gist_id}","starred_url":"https://api.github.com/users/zenhack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenhack/subscriptions","organizations_url":"https://api.github.com/users/zenhack/orgs","repos_url":"https://api.github.com/users/zenhack/repos","events_url":"https://api.github.com/users/zenhack/events{/privacy}","received_events_url":"https://api.github.com/users/zenhack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zenhack/haas","description":"","fork":true,"url":"https://api.github.com/repos/zenhack/haas","forks_url":"https://api.github.com/repos/zenhack/haas/forks","keys_url":"https://api.github.com/repos/zenhack/haas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenhack/haas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenhack/haas/teams","hooks_url":"https://api.github.com/repos/zenhack/haas/hooks","issue_events_url":"https://api.github.com/repos/zenhack/haas/issues/events{/number}","events_url":"https://api.github.com/repos/zenhack/haas/events","assignees_url":"https://api.github.com/repos/zenhack/haas/assignees{/user}","branches_url":"https://api.github.com/repos/zenhack/haas/branches{/branch}","tags_url":"https://api.github.com/repos/zenhack/haas/tags","blobs_url":"https://api.github.com/repos/zenhack/haas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenhack/haas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenhack/haas/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenhack/haas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenhack/haas/statuses/{sha}","languages_url":"https://api.github.com/repos/zenhack/haas/languages","stargazers_url":"https://api.github.com/repos/zenhack/haas/stargazers","contributors_url":"https://api.github.com/repos/zenhack/haas/contributors","subscribers_url":"https://api.github.com/repos/zenhack/haas/subscribers","subscription_url":"https://api.github.com/repos/zenhack/haas/subscription","commits_url":"https://api.github.com/repos/zenhack/haas/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenhack/haas/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenhack/haas/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenhack/haas/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenhack/haas/contents/{+path}","compare_url":"https://api.github.com/repos/zenhack/haas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenhack/haas/merges","archive_url":"https://api.github.com/repos/zenhack/haas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenhack/haas/downloads","issues_url":"https://api.github.com/repos/zenhack/haas/issues{/number}","pulls_url":"https://api.github.com/repos/zenhack/haas/pulls{/number}","milestones_url":"https://api.github.com/repos/zenhack/haas/milestones{/number}","notifications_url":"https://api.github.com/repos/zenhack/haas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenhack/haas/labels{/name}","releases_url":"https://api.github.com/repos/zenhack/haas/releases{/id}","created_at":"2014-05-14T21:13:52Z","updated_at":"2015-12-10T14:32:56Z","pushed_at":"2015-12-15T04:48:30Z","git_url":"git://github.com/zenhack/haas.git","ssh_url":"git@github.com:zenhack/haas.git","clone_url":"https://github.com/zenhack/haas.git","svn_url":"https://github.com/zenhack/haas","homepage":null,"size":1652,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"CCI-MOC:master","ref":"master","sha":"45dae53798786be08a2e57092edc0e51da31fffd","user":{"login":"CCI-MOC","id":3578683,"avatar_url":"https://avatars.githubusercontent.com/u/3578683?v=3","gravatar_id":"","url":"https://api.github.com/users/CCI-MOC","html_url":"https://github.com/CCI-MOC","followers_url":"https://api.github.com/users/CCI-MOC/followers","following_url":"https://api.github.com/users/CCI-MOC/following{/other_user}","gists_url":"https://api.github.com/users/CCI-MOC/gists{/gist_id}","starred_url":"https://api.github.com/users/CCI-MOC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CCI-MOC/subscriptions","organizations_url":"https://api.github.com/users/CCI-MOC/orgs","repos_url":"https://api.github.com/users/CCI-MOC/repos","events_url":"https://api.github.com/users/CCI-MOC/events{/privacy}","received_events_url":"https://api.github.com/users/CCI-MOC/received_events","type":"Organization","site_admin":false},"repo":{"id":16487339,"name":"haas","full_name":"CCI-MOC/haas","owner":{"login":"CCI-MOC","id":3578683,"avatar_url":"https://avatars.githubusercontent.com/u/3578683?v=3","gravatar_id":"","url":"https://api.github.com/users/CCI-MOC","html_url":"https://github.com/CCI-MOC","followers_url":"https://api.github.com/users/CCI-MOC/followers","following_url":"https://api.github.com/users/CCI-MOC/following{/other_user}","gists_url":"https://api.github.com/users/CCI-MOC/gists{/gist_id}","starred_url":"https://api.github.com/users/CCI-MOC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CCI-MOC/subscriptions","organizations_url":"https://api.github.com/users/CCI-MOC/orgs","repos_url":"https://api.github.com/users/CCI-MOC/repos","events_url":"https://api.github.com/users/CCI-MOC/events{/privacy}","received_events_url":"https://api.github.com/users/CCI-MOC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CCI-MOC/haas","description":"","fork":false,"url":"https://api.github.com/repos/CCI-MOC/haas","forks_url":"https://api.github.com/repos/CCI-MOC/haas/forks","keys_url":"https://api.github.com/repos/CCI-MOC/haas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CCI-MOC/haas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CCI-MOC/haas/teams","hooks_url":"https://api.github.com/repos/CCI-MOC/haas/hooks","issue_events_url":"https://api.github.com/repos/CCI-MOC/haas/issues/events{/number}","events_url":"https://api.github.com/repos/CCI-MOC/haas/events","assignees_url":"https://api.github.com/repos/CCI-MOC/haas/assignees{/user}","branches_url":"https://api.github.com/repos/CCI-MOC/haas/branches{/branch}","tags_url":"https://api.github.com/repos/CCI-MOC/haas/tags","blobs_url":"https://api.github.com/repos/CCI-MOC/haas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CCI-MOC/haas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CCI-MOC/haas/git/refs{/sha}","trees_url":"https://api.github.com/repos/CCI-MOC/haas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CCI-MOC/haas/statuses/{sha}","languages_url":"https://api.github.com/repos/CCI-MOC/haas/languages","stargazers_url":"https://api.github.com/repos/CCI-MOC/haas/stargazers","contributors_url":"https://api.github.com/repos/CCI-MOC/haas/contributors","subscribers_url":"https://api.github.com/repos/CCI-MOC/haas/subscribers","subscription_url":"https://api.github.com/repos/CCI-MOC/haas/subscription","commits_url":"https://api.github.com/repos/CCI-MOC/haas/commits{/sha}","git_commits_url":"https://api.github.com/repos/CCI-MOC/haas/git/commits{/sha}","comments_url":"https://api.github.com/repos/CCI-MOC/haas/comments{/number}","issue_comment_url":"https://api.github.com/repos/CCI-MOC/haas/issues/comments{/number}","contents_url":"https://api.github.com/repos/CCI-MOC/haas/contents/{+path}","compare_url":"https://api.github.com/repos/CCI-MOC/haas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CCI-MOC/haas/merges","archive_url":"https://api.github.com/repos/CCI-MOC/haas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CCI-MOC/haas/downloads","issues_url":"https://api.github.com/repos/CCI-MOC/haas/issues{/number}","pulls_url":"https://api.github.com/repos/CCI-MOC/haas/pulls{/number}","milestones_url":"https://api.github.com/repos/CCI-MOC/haas/milestones{/number}","notifications_url":"https://api.github.com/repos/CCI-MOC/haas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CCI-MOC/haas/labels{/name}","releases_url":"https://api.github.com/repos/CCI-MOC/haas/releases{/id}","created_at":"2014-02-03T17:48:01Z","updated_at":"2015-10-06T01:51:50Z","pushed_at":"2015-12-15T04:48:30Z","git_url":"git://github.com/CCI-MOC/haas.git","ssh_url":"git@github.com:CCI-MOC/haas.git","clone_url":"https://github.com/CCI-MOC/haas.git","svn_url":"https://github.com/CCI-MOC/haas","homepage":null,"size":1812,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":110,"forks":21,"open_issues":110,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CCI-MOC/haas/pulls/505"},"html":{"href":"https://github.com/CCI-MOC/haas/pull/505"},"issue":{"href":"https://api.github.com/repos/CCI-MOC/haas/issues/505"},"comments":{"href":"https://api.github.com/repos/CCI-MOC/haas/issues/505/comments"},"review_comments":{"href":"https://api.github.com/repos/CCI-MOC/haas/pulls/505/comments"},"review_comment":{"href":"https://api.github.com/repos/CCI-MOC/haas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CCI-MOC/haas/pulls/505/commits"},"statuses":{"href":"https://api.github.com/repos/CCI-MOC/haas/statuses/f1f3cf403034b04f5859db4dce72083799e9cc0c"}}}}