{"action":"created","comment":{"url":"https://api.github.com/repos/dropbox/pyston/pulls/comments/29395179","id":29395179,"diff_hunk":"@@ -285,6 +285,11 @@ class RegisterHelper {\n Value ASTInterpreter::execute(ASTInterpreter& interpreter, CFGBlock* start_block, AST_stmt* start_at) {\n     threading::allowGLReadPreemption();\n \n+#if SLOWPATH_TIMERS\n+    static int _stid = Stats::getStatId(\"zzz_slowpath_astinterpreter_execute_us\");\n+    StatTimer _st(_stid);\n+#endif","path":"src/codegen/ast_interpreter.cpp","position":7,"original_position":7,"commit_id":"927589a001cfcbe72783d0aa32a1419376daa2df","original_commit_id":"927589a001cfcbe72783d0aa32a1419376daa2df","user":{"login":"toshok","id":24245,"avatar_url":"https://avatars.githubusercontent.com/u/24245?v=3","gravatar_id":"","url":"https://api.github.com/users/toshok","html_url":"https://github.com/toshok","followers_url":"https://api.github.com/users/toshok/followers","following_url":"https://api.github.com/users/toshok/following{/other_user}","gists_url":"https://api.github.com/users/toshok/gists{/gist_id}","starred_url":"https://api.github.com/users/toshok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshok/subscriptions","organizations_url":"https://api.github.com/users/toshok/orgs","repos_url":"https://api.github.com/users/toshok/repos","events_url":"https://api.github.com/users/toshok/events{/privacy}","received_events_url":"https://api.github.com/users/toshok/received_events","type":"User","site_admin":false},"body":"yeah, that was already on my todo list :)\n\nOn Wed, Apr 29, 2015 at 2:20 PM, Kevin Modzelewski <notifications@github.com\n> wrote:\n\n> In src/codegen/ast_interpreter.cpp\n> <https://github.com/dropbox/pyston/pull/475#discussion_r29382242>:\n>\n> > @@ -285,6 +285,11 @@ class RegisterHelper {\n> >  Value ASTInterpreter::execute(ASTInterpreter& interpreter, CFGBlock* start_block, AST_stmt* start_at) {\n> >      threading::allowGLReadPreemption();\n> >\n> > +#if SLOWPATH_TIMERS\n> > +    static int _stid = Stats::getStatId(\"zzz_slowpath_astinterpreter_execute_us\");\n> > +    StatTimer _st(_stid);\n> > +#endif\n>\n> I would make this into a macro :)\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/dropbox/pyston/pull/475/files#r29382242>.\n>\n","created_at":"2015-04-30T00:26:34Z","updated_at":"2015-04-30T00:26:34Z","html_url":"https://github.com/dropbox/pyston/pull/475#discussion_r29395179","pull_request_url":"https://api.github.com/repos/dropbox/pyston/pulls/475","_links":{"self":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/comments/29395179"},"html":{"href":"https://github.com/dropbox/pyston/pull/475#discussion_r29395179"},"pull_request":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/475"}}},"pull_request":{"url":"https://api.github.com/repos/dropbox/pyston/pulls/475","id":34372356,"html_url":"https://github.com/dropbox/pyston/pull/475","diff_url":"https://github.com/dropbox/pyston/pull/475.diff","patch_url":"https://github.com/dropbox/pyston/pull/475.patch","issue_url":"https://api.github.com/repos/dropbox/pyston/issues/475","number":475,"state":"open","locked":false,"title":"Stat timers","user":{"login":"toshok","id":24245,"avatar_url":"https://avatars.githubusercontent.com/u/24245?v=3","gravatar_id":"","url":"https://api.github.com/users/toshok","html_url":"https://github.com/toshok","followers_url":"https://api.github.com/users/toshok/followers","following_url":"https://api.github.com/users/toshok/following{/other_user}","gists_url":"https://api.github.com/users/toshok/gists{/gist_id}","starred_url":"https://api.github.com/users/toshok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshok/subscriptions","organizations_url":"https://api.github.com/users/toshok/orgs","repos_url":"https://api.github.com/users/toshok/repos","events_url":"https://api.github.com/users/toshok/events{/privacy}","received_events_url":"https://api.github.com/users/toshok/received_events","type":"User","site_admin":false},"body":"Each thread has a stack of timers (which should have automatic storage.)  creating a timer starts it and pushes it onto the stack, and also pauses the currently running one (if there is one) to avoid double counting.  When a timer goes out of scope it's stopped and popped off the stack, and the previous one on the stack is resumed.","created_at":"2015-04-29T15:06:33Z","updated_at":"2015-04-30T00:26:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcb3be7013d196b55ad62ec72a39aeaf83678fb5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dropbox/pyston/pulls/475/commits","review_comments_url":"https://api.github.com/repos/dropbox/pyston/pulls/475/comments","review_comment_url":"https://api.github.com/repos/dropbox/pyston/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dropbox/pyston/issues/475/comments","statuses_url":"https://api.github.com/repos/dropbox/pyston/statuses/927589a001cfcbe72783d0aa32a1419376daa2df","head":{"label":"toshok:stat-timers","ref":"stat-timers","sha":"927589a001cfcbe72783d0aa32a1419376daa2df","user":{"login":"toshok","id":24245,"avatar_url":"https://avatars.githubusercontent.com/u/24245?v=3","gravatar_id":"","url":"https://api.github.com/users/toshok","html_url":"https://github.com/toshok","followers_url":"https://api.github.com/users/toshok/followers","following_url":"https://api.github.com/users/toshok/following{/other_user}","gists_url":"https://api.github.com/users/toshok/gists{/gist_id}","starred_url":"https://api.github.com/users/toshok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshok/subscriptions","organizations_url":"https://api.github.com/users/toshok/orgs","repos_url":"https://api.github.com/users/toshok/repos","events_url":"https://api.github.com/users/toshok/events{/privacy}","received_events_url":"https://api.github.com/users/toshok/received_events","type":"User","site_admin":false},"repo":{"id":26560265,"name":"pyston","full_name":"toshok/pyston","owner":{"login":"toshok","id":24245,"avatar_url":"https://avatars.githubusercontent.com/u/24245?v=3","gravatar_id":"","url":"https://api.github.com/users/toshok","html_url":"https://github.com/toshok","followers_url":"https://api.github.com/users/toshok/followers","following_url":"https://api.github.com/users/toshok/following{/other_user}","gists_url":"https://api.github.com/users/toshok/gists{/gist_id}","starred_url":"https://api.github.com/users/toshok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshok/subscriptions","organizations_url":"https://api.github.com/users/toshok/orgs","repos_url":"https://api.github.com/users/toshok/repos","events_url":"https://api.github.com/users/toshok/events{/privacy}","received_events_url":"https://api.github.com/users/toshok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toshok/pyston","description":"An open-source Python implementation using JIT techniques. ","fork":true,"url":"https://api.github.com/repos/toshok/pyston","forks_url":"https://api.github.com/repos/toshok/pyston/forks","keys_url":"https://api.github.com/repos/toshok/pyston/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toshok/pyston/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toshok/pyston/teams","hooks_url":"https://api.github.com/repos/toshok/pyston/hooks","issue_events_url":"https://api.github.com/repos/toshok/pyston/issues/events{/number}","events_url":"https://api.github.com/repos/toshok/pyston/events","assignees_url":"https://api.github.com/repos/toshok/pyston/assignees{/user}","branches_url":"https://api.github.com/repos/toshok/pyston/branches{/branch}","tags_url":"https://api.github.com/repos/toshok/pyston/tags","blobs_url":"https://api.github.com/repos/toshok/pyston/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toshok/pyston/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toshok/pyston/git/refs{/sha}","trees_url":"https://api.github.com/repos/toshok/pyston/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toshok/pyston/statuses/{sha}","languages_url":"https://api.github.com/repos/toshok/pyston/languages","stargazers_url":"https://api.github.com/repos/toshok/pyston/stargazers","contributors_url":"https://api.github.com/repos/toshok/pyston/contributors","subscribers_url":"https://api.github.com/repos/toshok/pyston/subscribers","subscription_url":"https://api.github.com/repos/toshok/pyston/subscription","commits_url":"https://api.github.com/repos/toshok/pyston/commits{/sha}","git_commits_url":"https://api.github.com/repos/toshok/pyston/git/commits{/sha}","comments_url":"https://api.github.com/repos/toshok/pyston/comments{/number}","issue_comment_url":"https://api.github.com/repos/toshok/pyston/issues/comments{/number}","contents_url":"https://api.github.com/repos/toshok/pyston/contents/{+path}","compare_url":"https://api.github.com/repos/toshok/pyston/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toshok/pyston/merges","archive_url":"https://api.github.com/repos/toshok/pyston/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toshok/pyston/downloads","issues_url":"https://api.github.com/repos/toshok/pyston/issues{/number}","pulls_url":"https://api.github.com/repos/toshok/pyston/pulls{/number}","milestones_url":"https://api.github.com/repos/toshok/pyston/milestones{/number}","notifications_url":"https://api.github.com/repos/toshok/pyston/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toshok/pyston/labels{/name}","releases_url":"https://api.github.com/repos/toshok/pyston/releases{/id}","created_at":"2014-11-12T22:56:58Z","updated_at":"2015-03-07T07:42:00Z","pushed_at":"2015-04-29T20:05:31Z","git_url":"git://github.com/toshok/pyston.git","ssh_url":"git@github.com:toshok/pyston.git","clone_url":"https://github.com/toshok/pyston.git","svn_url":"https://github.com/toshok/pyston","homepage":"https://tech.dropbox.com/2014/04/introducing-pyston-an-upcoming-jit-based-python-implementation/","size":19136,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dropbox:master","ref":"master","sha":"d150327229b0602cf1a85e883edfbd510b7a0181","user":{"login":"dropbox","id":559357,"avatar_url":"https://avatars.githubusercontent.com/u/559357?v=3","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"repo":{"id":18320947,"name":"pyston","full_name":"dropbox/pyston","owner":{"login":"dropbox","id":559357,"avatar_url":"https://avatars.githubusercontent.com/u/559357?v=3","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dropbox/pyston","description":"An open-source Python implementation using JIT techniques. ","fork":false,"url":"https://api.github.com/repos/dropbox/pyston","forks_url":"https://api.github.com/repos/dropbox/pyston/forks","keys_url":"https://api.github.com/repos/dropbox/pyston/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dropbox/pyston/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dropbox/pyston/teams","hooks_url":"https://api.github.com/repos/dropbox/pyston/hooks","issue_events_url":"https://api.github.com/repos/dropbox/pyston/issues/events{/number}","events_url":"https://api.github.com/repos/dropbox/pyston/events","assignees_url":"https://api.github.com/repos/dropbox/pyston/assignees{/user}","branches_url":"https://api.github.com/repos/dropbox/pyston/branches{/branch}","tags_url":"https://api.github.com/repos/dropbox/pyston/tags","blobs_url":"https://api.github.com/repos/dropbox/pyston/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dropbox/pyston/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dropbox/pyston/git/refs{/sha}","trees_url":"https://api.github.com/repos/dropbox/pyston/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dropbox/pyston/statuses/{sha}","languages_url":"https://api.github.com/repos/dropbox/pyston/languages","stargazers_url":"https://api.github.com/repos/dropbox/pyston/stargazers","contributors_url":"https://api.github.com/repos/dropbox/pyston/contributors","subscribers_url":"https://api.github.com/repos/dropbox/pyston/subscribers","subscription_url":"https://api.github.com/repos/dropbox/pyston/subscription","commits_url":"https://api.github.com/repos/dropbox/pyston/commits{/sha}","git_commits_url":"https://api.github.com/repos/dropbox/pyston/git/commits{/sha}","comments_url":"https://api.github.com/repos/dropbox/pyston/comments{/number}","issue_comment_url":"https://api.github.com/repos/dropbox/pyston/issues/comments{/number}","contents_url":"https://api.github.com/repos/dropbox/pyston/contents/{+path}","compare_url":"https://api.github.com/repos/dropbox/pyston/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dropbox/pyston/merges","archive_url":"https://api.github.com/repos/dropbox/pyston/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dropbox/pyston/downloads","issues_url":"https://api.github.com/repos/dropbox/pyston/issues{/number}","pulls_url":"https://api.github.com/repos/dropbox/pyston/pulls{/number}","milestones_url":"https://api.github.com/repos/dropbox/pyston/milestones{/number}","notifications_url":"https://api.github.com/repos/dropbox/pyston/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dropbox/pyston/labels{/name}","releases_url":"https://api.github.com/repos/dropbox/pyston/releases{/id}","created_at":"2014-04-01T07:17:20Z","updated_at":"2015-04-29T21:34:15Z","pushed_at":"2015-04-29T23:32:31Z","git_url":"git://github.com/dropbox/pyston.git","ssh_url":"git@github.com:dropbox/pyston.git","clone_url":"https://github.com/dropbox/pyston.git","svn_url":"https://github.com/dropbox/pyston","homepage":"https://tech.dropbox.com/2014/04/introducing-pyston-an-upcoming-jit-based-python-implementation/","size":27403,"stargazers_count":2934,"watchers_count":2934,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":213,"mirror_url":null,"open_issues_count":56,"forks":213,"open_issues":56,"watchers":2934,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/475"},"html":{"href":"https://github.com/dropbox/pyston/pull/475"},"issue":{"href":"https://api.github.com/repos/dropbox/pyston/issues/475"},"comments":{"href":"https://api.github.com/repos/dropbox/pyston/issues/475/comments"},"review_comments":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/475/comments"},"review_comment":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/475/commits"},"statuses":{"href":"https://api.github.com/repos/dropbox/pyston/statuses/927589a001cfcbe72783d0aa32a1419376daa2df"}}}}