{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/30166855","id":30166855,"diff_hunk":"@@ -95,7 +102,15 @@\n         for (TransientActionFactory<?> taf : ExtensionList.lookup(TransientActionFactory.class)) {\n             if (taf.type().isInstance(this)) {\n                 try {\n-                    _actions.addAll(createFor(taf));\n+                    Collection<? extends Action> newActions = createFor(taf);\n+                    for (Action action : newActions) {\n+                        if (action instanceof Action) {\n+                            _actions.add(action);\n+                        } else {\n+                            LOGGER.log(Level.WARNING, \"Actionable#getAllActions: Found a not action: \" + action.getClass().toString());","path":"core/src/main/java/hudson/model/Actionable.java","position":38,"original_position":38,"commit_id":"bf1ca6676aeb252781a45aa37cbcba044cb63efc","original_commit_id":"bf1ca6676aeb252781a45aa37cbcba044cb63efc","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"The most interesting information, `taf.getClass().getName()` (i.e., the culprit) is not even included in this message.","created_at":"2015-05-12T18:45:03Z","updated_at":"2015-05-12T18:45:03Z","html_url":"https://github.com/jenkinsci/jenkins/pull/1694#discussion_r30166855","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1694","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/30166855"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1694#discussion_r30166855"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1694"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1694","id":35013545,"html_url":"https://github.com/jenkinsci/jenkins/pull/1694","diff_url":"https://github.com/jenkinsci/jenkins/pull/1694.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/1694.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1694","number":1694,"state":"open","locked":false,"title":"Remove not actions and logging null and other kind of objects","user":{"login":"fbelzunc","id":3898648,"avatar_url":"https://avatars.githubusercontent.com/u/3898648?v=3","gravatar_id":"","url":"https://api.github.com/users/fbelzunc","html_url":"https://github.com/fbelzunc","followers_url":"https://api.github.com/users/fbelzunc/followers","following_url":"https://api.github.com/users/fbelzunc/following{/other_user}","gists_url":"https://api.github.com/users/fbelzunc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbelzunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbelzunc/subscriptions","organizations_url":"https://api.github.com/users/fbelzunc/orgs","repos_url":"https://api.github.com/users/fbelzunc/repos","events_url":"https://api.github.com/users/fbelzunc/events{/privacy}","received_events_url":"https://api.github.com/users/fbelzunc/received_events","type":"User","site_admin":false},"body":"Remove not actions and logging null and other kind of objects.\r\n\r\nTry to make sure that `_actions` really contained only Action instances, no nulls or other kinds of objects, by stripping out anything else and logging a warning explaining what class was responsible for adding the bad element.\r\n\r\n@reviewbybees","created_at":"2015-05-08T14:27:17Z","updated_at":"2015-05-12T18:45:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4302505dcc9556a1a368e26e9710376a9828927","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1694/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1694/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1694/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/bf1ca6676aeb252781a45aa37cbcba044cb63efc","head":{"label":"fbelzunc:actionable","ref":"actionable","sha":"bf1ca6676aeb252781a45aa37cbcba044cb63efc","user":{"login":"fbelzunc","id":3898648,"avatar_url":"https://avatars.githubusercontent.com/u/3898648?v=3","gravatar_id":"","url":"https://api.github.com/users/fbelzunc","html_url":"https://github.com/fbelzunc","followers_url":"https://api.github.com/users/fbelzunc/followers","following_url":"https://api.github.com/users/fbelzunc/following{/other_user}","gists_url":"https://api.github.com/users/fbelzunc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbelzunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbelzunc/subscriptions","organizations_url":"https://api.github.com/users/fbelzunc/orgs","repos_url":"https://api.github.com/users/fbelzunc/repos","events_url":"https://api.github.com/users/fbelzunc/events{/privacy}","received_events_url":"https://api.github.com/users/fbelzunc/received_events","type":"User","site_admin":false},"repo":{"id":28363598,"name":"jenkins","full_name":"fbelzunc/jenkins","owner":{"login":"fbelzunc","id":3898648,"avatar_url":"https://avatars.githubusercontent.com/u/3898648?v=3","gravatar_id":"","url":"https://api.github.com/users/fbelzunc","html_url":"https://github.com/fbelzunc","followers_url":"https://api.github.com/users/fbelzunc/followers","following_url":"https://api.github.com/users/fbelzunc/following{/other_user}","gists_url":"https://api.github.com/users/fbelzunc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbelzunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbelzunc/subscriptions","organizations_url":"https://api.github.com/users/fbelzunc/orgs","repos_url":"https://api.github.com/users/fbelzunc/repos","events_url":"https://api.github.com/users/fbelzunc/events{/privacy}","received_events_url":"https://api.github.com/users/fbelzunc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fbelzunc/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/fbelzunc/jenkins","forks_url":"https://api.github.com/repos/fbelzunc/jenkins/forks","keys_url":"https://api.github.com/repos/fbelzunc/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbelzunc/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbelzunc/jenkins/teams","hooks_url":"https://api.github.com/repos/fbelzunc/jenkins/hooks","issue_events_url":"https://api.github.com/repos/fbelzunc/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/fbelzunc/jenkins/events","assignees_url":"https://api.github.com/repos/fbelzunc/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/fbelzunc/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/fbelzunc/jenkins/tags","blobs_url":"https://api.github.com/repos/fbelzunc/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbelzunc/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbelzunc/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbelzunc/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbelzunc/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/fbelzunc/jenkins/languages","stargazers_url":"https://api.github.com/repos/fbelzunc/jenkins/stargazers","contributors_url":"https://api.github.com/repos/fbelzunc/jenkins/contributors","subscribers_url":"https://api.github.com/repos/fbelzunc/jenkins/subscribers","subscription_url":"https://api.github.com/repos/fbelzunc/jenkins/subscription","commits_url":"https://api.github.com/repos/fbelzunc/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbelzunc/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbelzunc/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbelzunc/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbelzunc/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/fbelzunc/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbelzunc/jenkins/merges","archive_url":"https://api.github.com/repos/fbelzunc/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbelzunc/jenkins/downloads","issues_url":"https://api.github.com/repos/fbelzunc/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/fbelzunc/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/fbelzunc/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/fbelzunc/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbelzunc/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/fbelzunc/jenkins/releases{/id}","created_at":"2014-12-22T22:48:05Z","updated_at":"2015-05-08T11:53:06Z","pushed_at":"2015-05-11T10:22:21Z","git_url":"git://github.com/fbelzunc/jenkins.git","ssh_url":"git@github.com:fbelzunc/jenkins.git","clone_url":"https://github.com/fbelzunc/jenkins.git","svn_url":"https://github.com/fbelzunc/jenkins","homepage":"http://jenkins-ci.org/","size":85571,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"718eca574543c5a550c0a661433b17fb0f9c84c4","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","created_at":"2010-11-22T21:21:23Z","updated_at":"2015-05-12T13:44:47Z","pushed_at":"2015-05-12T16:48:49Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"http://jenkins-ci.org/","size":420927,"stargazers_count":4066,"watchers_count":4066,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1819,"mirror_url":null,"open_issues_count":109,"forks":1819,"open_issues":109,"watchers":4066,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1694"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1694"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1694"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1694/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1694/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1694/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/bf1ca6676aeb252781a45aa37cbcba044cb63efc"}}}}