{"action":"closed","number":3516,"pull_request":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/3516","id":40394047,"html_url":"https://github.com/elixir-lang/elixir/pull/3516","diff_url":"https://github.com/elixir-lang/elixir/pull/3516.diff","patch_url":"https://github.com/elixir-lang/elixir/pull/3516.patch","issue_url":"https://api.github.com/repos/elixir-lang/elixir/issues/3516","number":3516,"state":"closed","locked":false,"title":"Add Range.Iterator for BitString","user":{"login":"maxnordlund","id":664779,"avatar_url":"https://avatars.githubusercontent.com/u/664779?v=3","gravatar_id":"","url":"https://api.github.com/users/maxnordlund","html_url":"https://github.com/maxnordlund","followers_url":"https://api.github.com/users/maxnordlund/followers","following_url":"https://api.github.com/users/maxnordlund/following{/other_user}","gists_url":"https://api.github.com/users/maxnordlund/gists{/gist_id}","starred_url":"https://api.github.com/users/maxnordlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxnordlund/subscriptions","organizations_url":"https://api.github.com/users/maxnordlund/orgs","repos_url":"https://api.github.com/users/maxnordlund/repos","events_url":"https://api.github.com/users/maxnordlund/events{/privacy}","received_events_url":"https://api.github.com/users/maxnordlund/received_events","type":"User","site_admin":false},"body":"This will add a [Range.Iterator][1] implementation for (Bit)Strings. The next logic is very simple, but it should follow the same behaviour as the `<` et al operators does for strings.\r\n\r\nI wrote this because of #2912, since I would like for strings/characters/graphemes/runes to be included in that set. But I didn't want to change to much, like #3374, to ensure ranges are still usable in guards. Luckily the strings in Elixir can be compared with `<` et al, and this follows that logic.\r\n\r\n[1]: https://github.com/elixir-lang/elixir/blob/99cb66d5ec25d80ae67d88da1db6055b6d0be572/lib/elixir/lib/range.ex#L47-L61","created_at":"2015-07-20T20:34:32Z","updated_at":"2015-07-20T20:53:31Z","closed_at":"2015-07-20T20:53:31Z","merged_at":null,"merge_commit_sha":"cbe1ea9ec49f9608c56bb7670ba6500fe23dd4fa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/3516/commits","review_comments_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/3516/comments","review_comment_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/issues/3516/comments","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/6d0dcd2e38d3e0ff64954312e42cc58e1b139a19","head":{"label":"maxnordlund:range-iterator-for-string","ref":"range-iterator-for-string","sha":"6d0dcd2e38d3e0ff64954312e42cc58e1b139a19","user":{"login":"maxnordlund","id":664779,"avatar_url":"https://avatars.githubusercontent.com/u/664779?v=3","gravatar_id":"","url":"https://api.github.com/users/maxnordlund","html_url":"https://github.com/maxnordlund","followers_url":"https://api.github.com/users/maxnordlund/followers","following_url":"https://api.github.com/users/maxnordlund/following{/other_user}","gists_url":"https://api.github.com/users/maxnordlund/gists{/gist_id}","starred_url":"https://api.github.com/users/maxnordlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxnordlund/subscriptions","organizations_url":"https://api.github.com/users/maxnordlund/orgs","repos_url":"https://api.github.com/users/maxnordlund/repos","events_url":"https://api.github.com/users/maxnordlund/events{/privacy}","received_events_url":"https://api.github.com/users/maxnordlund/received_events","type":"User","site_admin":false},"repo":{"id":39130296,"name":"elixir","full_name":"maxnordlund/elixir","owner":{"login":"maxnordlund","id":664779,"avatar_url":"https://avatars.githubusercontent.com/u/664779?v=3","gravatar_id":"","url":"https://api.github.com/users/maxnordlund","html_url":"https://github.com/maxnordlund","followers_url":"https://api.github.com/users/maxnordlund/followers","following_url":"https://api.github.com/users/maxnordlund/following{/other_user}","gists_url":"https://api.github.com/users/maxnordlund/gists{/gist_id}","starred_url":"https://api.github.com/users/maxnordlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxnordlund/subscriptions","organizations_url":"https://api.github.com/users/maxnordlund/orgs","repos_url":"https://api.github.com/users/maxnordlund/repos","events_url":"https://api.github.com/users/maxnordlund/events{/privacy}","received_events_url":"https://api.github.com/users/maxnordlund/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxnordlund/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":true,"url":"https://api.github.com/repos/maxnordlund/elixir","forks_url":"https://api.github.com/repos/maxnordlund/elixir/forks","keys_url":"https://api.github.com/repos/maxnordlund/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxnordlund/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxnordlund/elixir/teams","hooks_url":"https://api.github.com/repos/maxnordlund/elixir/hooks","issue_events_url":"https://api.github.com/repos/maxnordlund/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/maxnordlund/elixir/events","assignees_url":"https://api.github.com/repos/maxnordlund/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/maxnordlund/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/maxnordlund/elixir/tags","blobs_url":"https://api.github.com/repos/maxnordlund/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxnordlund/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxnordlund/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxnordlund/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxnordlund/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/maxnordlund/elixir/languages","stargazers_url":"https://api.github.com/repos/maxnordlund/elixir/stargazers","contributors_url":"https://api.github.com/repos/maxnordlund/elixir/contributors","subscribers_url":"https://api.github.com/repos/maxnordlund/elixir/subscribers","subscription_url":"https://api.github.com/repos/maxnordlund/elixir/subscription","commits_url":"https://api.github.com/repos/maxnordlund/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxnordlund/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxnordlund/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxnordlund/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxnordlund/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/maxnordlund/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxnordlund/elixir/merges","archive_url":"https://api.github.com/repos/maxnordlund/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxnordlund/elixir/downloads","issues_url":"https://api.github.com/repos/maxnordlund/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/maxnordlund/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/maxnordlund/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/maxnordlund/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxnordlund/elixir/labels{/name}","releases_url":"https://api.github.com/repos/maxnordlund/elixir/releases{/id}","created_at":"2015-07-15T10:15:43Z","updated_at":"2015-07-15T10:15:46Z","pushed_at":"2015-07-20T20:26:32Z","git_url":"git://github.com/maxnordlund/elixir.git","ssh_url":"git@github.com:maxnordlund/elixir.git","clone_url":"https://github.com/maxnordlund/elixir.git","svn_url":"https://github.com/maxnordlund/elixir","homepage":"http://elixir-lang.org/","size":29746,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elixir-lang:master","ref":"master","sha":"99cb66d5ec25d80ae67d88da1db6055b6d0be572","user":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":1234714,"name":"elixir","full_name":"elixir-lang/elixir","owner":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-lang/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":false,"url":"https://api.github.com/repos/elixir-lang/elixir","forks_url":"https://api.github.com/repos/elixir-lang/elixir/forks","keys_url":"https://api.github.com/repos/elixir-lang/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-lang/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-lang/elixir/teams","hooks_url":"https://api.github.com/repos/elixir-lang/elixir/hooks","issue_events_url":"https://api.github.com/repos/elixir-lang/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-lang/elixir/events","assignees_url":"https://api.github.com/repos/elixir-lang/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-lang/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-lang/elixir/tags","blobs_url":"https://api.github.com/repos/elixir-lang/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-lang/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-lang/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-lang/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-lang/elixir/languages","stargazers_url":"https://api.github.com/repos/elixir-lang/elixir/stargazers","contributors_url":"https://api.github.com/repos/elixir-lang/elixir/contributors","subscribers_url":"https://api.github.com/repos/elixir-lang/elixir/subscribers","subscription_url":"https://api.github.com/repos/elixir-lang/elixir/subscription","commits_url":"https://api.github.com/repos/elixir-lang/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-lang/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-lang/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-lang/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-lang/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-lang/elixir/merges","archive_url":"https://api.github.com/repos/elixir-lang/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-lang/elixir/downloads","issues_url":"https://api.github.com/repos/elixir-lang/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-lang/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-lang/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-lang/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-lang/elixir/labels{/name}","releases_url":"https://api.github.com/repos/elixir-lang/elixir/releases{/id}","created_at":"2011-01-09T08:43:57Z","updated_at":"2015-07-20T20:30:14Z","pushed_at":"2015-07-20T20:34:32Z","git_url":"git://github.com/elixir-lang/elixir.git","ssh_url":"git@github.com:elixir-lang/elixir.git","clone_url":"https://github.com/elixir-lang/elixir.git","svn_url":"https://github.com/elixir-lang/elixir","homepage":"http://elixir-lang.org/","size":47929,"stargazers_count":4363,"watchers_count":4363,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":605,"mirror_url":null,"open_issues_count":87,"forks":605,"open_issues":87,"watchers":4363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/3516"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/3516"},"issue":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/3516"},"comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/3516/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/3516/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/3516/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-lang/elixir/statuses/6d0dcd2e38d3e0ff64954312e42cc58e1b139a19"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":55,"deletions":2,"changed_files":2}}