{"action":"closed","number":291,"pull_request":{"url":"https://api.github.com/repos/mozilla/amo-validator/pulls/291","id":38977384,"html_url":"https://github.com/mozilla/amo-validator/pull/291","diff_url":"https://github.com/mozilla/amo-validator/pull/291.diff","patch_url":"https://github.com/mozilla/amo-validator/pull/291.patch","issue_url":"https://api.github.com/repos/mozilla/amo-validator/issues/291","number":291,"state":"closed","locked":false,"title":"install fastchardet from PyPi","user":{"login":"myrdd","id":4286829,"avatar_url":"https://avatars.githubusercontent.com/u/4286829?v=3","gravatar_id":"","url":"https://api.github.com/users/myrdd","html_url":"https://github.com/myrdd","followers_url":"https://api.github.com/users/myrdd/followers","following_url":"https://api.github.com/users/myrdd/following{/other_user}","gists_url":"https://api.github.com/users/myrdd/gists{/gist_id}","starred_url":"https://api.github.com/users/myrdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myrdd/subscriptions","organizations_url":"https://api.github.com/users/myrdd/orgs","repos_url":"https://api.github.com/users/myrdd/repos","events_url":"https://api.github.com/users/myrdd/events{/privacy}","received_events_url":"https://api.github.com/users/myrdd/received_events","type":"User","site_admin":false},"body":"When calling `setup.py`, fastchardet is not installed, because `-e` is excluded. However, fastchardet is available from PyPi, so I suggest to use that.\r\n\r\nAnother solution (or an additional one) is to remove the exception for `-e` in `setup.py`, see https://github.com/mozilla/amo-validator/blob/v1.7.0/setup.py#L18.","created_at":"2015-07-01T12:37:24Z","updated_at":"2015-07-01T13:14:17Z","closed_at":"2015-07-01T13:14:17Z","merged_at":null,"merge_commit_sha":"5f2df4a6a5a5c6f9aa189fe986db27c8263f3529","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/amo-validator/pulls/291/commits","review_comments_url":"https://api.github.com/repos/mozilla/amo-validator/pulls/291/comments","review_comment_url":"https://api.github.com/repos/mozilla/amo-validator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/amo-validator/issues/291/comments","statuses_url":"https://api.github.com/repos/mozilla/amo-validator/statuses/4cbafb1b7d782bbe8b0de73a7eaf65aee6a8aeed","head":{"label":"myrdd:patch-requirements-txt","ref":"patch-requirements-txt","sha":"4cbafb1b7d782bbe8b0de73a7eaf65aee6a8aeed","user":{"login":"myrdd","id":4286829,"avatar_url":"https://avatars.githubusercontent.com/u/4286829?v=3","gravatar_id":"","url":"https://api.github.com/users/myrdd","html_url":"https://github.com/myrdd","followers_url":"https://api.github.com/users/myrdd/followers","following_url":"https://api.github.com/users/myrdd/following{/other_user}","gists_url":"https://api.github.com/users/myrdd/gists{/gist_id}","starred_url":"https://api.github.com/users/myrdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myrdd/subscriptions","organizations_url":"https://api.github.com/users/myrdd/orgs","repos_url":"https://api.github.com/users/myrdd/repos","events_url":"https://api.github.com/users/myrdd/events{/privacy}","received_events_url":"https://api.github.com/users/myrdd/received_events","type":"User","site_admin":false},"repo":{"id":38298616,"name":"amo-validator","full_name":"myrdd/amo-validator","owner":{"login":"myrdd","id":4286829,"avatar_url":"https://avatars.githubusercontent.com/u/4286829?v=3","gravatar_id":"","url":"https://api.github.com/users/myrdd","html_url":"https://github.com/myrdd","followers_url":"https://api.github.com/users/myrdd/followers","following_url":"https://api.github.com/users/myrdd/following{/other_user}","gists_url":"https://api.github.com/users/myrdd/gists{/gist_id}","starred_url":"https://api.github.com/users/myrdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myrdd/subscriptions","organizations_url":"https://api.github.com/users/myrdd/orgs","repos_url":"https://api.github.com/users/myrdd/repos","events_url":"https://api.github.com/users/myrdd/events{/privacy}","received_events_url":"https://api.github.com/users/myrdd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/myrdd/amo-validator","description":"Validator for addons.mozilla.org","fork":true,"url":"https://api.github.com/repos/myrdd/amo-validator","forks_url":"https://api.github.com/repos/myrdd/amo-validator/forks","keys_url":"https://api.github.com/repos/myrdd/amo-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/myrdd/amo-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/myrdd/amo-validator/teams","hooks_url":"https://api.github.com/repos/myrdd/amo-validator/hooks","issue_events_url":"https://api.github.com/repos/myrdd/amo-validator/issues/events{/number}","events_url":"https://api.github.com/repos/myrdd/amo-validator/events","assignees_url":"https://api.github.com/repos/myrdd/amo-validator/assignees{/user}","branches_url":"https://api.github.com/repos/myrdd/amo-validator/branches{/branch}","tags_url":"https://api.github.com/repos/myrdd/amo-validator/tags","blobs_url":"https://api.github.com/repos/myrdd/amo-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/myrdd/amo-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/myrdd/amo-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/myrdd/amo-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/myrdd/amo-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/myrdd/amo-validator/languages","stargazers_url":"https://api.github.com/repos/myrdd/amo-validator/stargazers","contributors_url":"https://api.github.com/repos/myrdd/amo-validator/contributors","subscribers_url":"https://api.github.com/repos/myrdd/amo-validator/subscribers","subscription_url":"https://api.github.com/repos/myrdd/amo-validator/subscription","commits_url":"https://api.github.com/repos/myrdd/amo-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/myrdd/amo-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/myrdd/amo-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/myrdd/amo-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/myrdd/amo-validator/contents/{+path}","compare_url":"https://api.github.com/repos/myrdd/amo-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/myrdd/amo-validator/merges","archive_url":"https://api.github.com/repos/myrdd/amo-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/myrdd/amo-validator/downloads","issues_url":"https://api.github.com/repos/myrdd/amo-validator/issues{/number}","pulls_url":"https://api.github.com/repos/myrdd/amo-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/myrdd/amo-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/myrdd/amo-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/myrdd/amo-validator/labels{/name}","releases_url":"https://api.github.com/repos/myrdd/amo-validator/releases{/id}","created_at":"2015-06-30T08:56:35Z","updated_at":"2015-06-30T08:56:36Z","pushed_at":"2015-07-01T13:03:50Z","git_url":"git://github.com/myrdd/amo-validator.git","ssh_url":"git@github.com:myrdd/amo-validator.git","clone_url":"https://github.com/myrdd/amo-validator.git","svn_url":"https://github.com/myrdd/amo-validator","homepage":"","size":18594,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"c85d5cf3d5e335e7c2b302aa87982b2238b5d9b3","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1441734,"name":"amo-validator","full_name":"mozilla/amo-validator","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/amo-validator","description":"Validator for addons.mozilla.org","fork":false,"url":"https://api.github.com/repos/mozilla/amo-validator","forks_url":"https://api.github.com/repos/mozilla/amo-validator/forks","keys_url":"https://api.github.com/repos/mozilla/amo-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/amo-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/amo-validator/teams","hooks_url":"https://api.github.com/repos/mozilla/amo-validator/hooks","issue_events_url":"https://api.github.com/repos/mozilla/amo-validator/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/amo-validator/events","assignees_url":"https://api.github.com/repos/mozilla/amo-validator/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/amo-validator/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/amo-validator/tags","blobs_url":"https://api.github.com/repos/mozilla/amo-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/amo-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/amo-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/amo-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/amo-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/amo-validator/languages","stargazers_url":"https://api.github.com/repos/mozilla/amo-validator/stargazers","contributors_url":"https://api.github.com/repos/mozilla/amo-validator/contributors","subscribers_url":"https://api.github.com/repos/mozilla/amo-validator/subscribers","subscription_url":"https://api.github.com/repos/mozilla/amo-validator/subscription","commits_url":"https://api.github.com/repos/mozilla/amo-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/amo-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/amo-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/amo-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/amo-validator/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/amo-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/amo-validator/merges","archive_url":"https://api.github.com/repos/mozilla/amo-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/amo-validator/downloads","issues_url":"https://api.github.com/repos/mozilla/amo-validator/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/amo-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/amo-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/amo-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/amo-validator/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/amo-validator/releases{/id}","created_at":"2011-03-05T00:24:22Z","updated_at":"2015-06-07T03:09:17Z","pushed_at":"2015-07-01T13:12:42Z","git_url":"git://github.com/mozilla/amo-validator.git","ssh_url":"git@github.com:mozilla/amo-validator.git","clone_url":"https://github.com/mozilla/amo-validator.git","svn_url":"https://github.com/mozilla/amo-validator","homepage":"","size":18594,"stargazers_count":40,"watchers_count":40,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":2,"forks":40,"open_issues":2,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/amo-validator/pulls/291"},"html":{"href":"https://github.com/mozilla/amo-validator/pull/291"},"issue":{"href":"https://api.github.com/repos/mozilla/amo-validator/issues/291"},"comments":{"href":"https://api.github.com/repos/mozilla/amo-validator/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/amo-validator/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/amo-validator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/amo-validator/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/amo-validator/statuses/4cbafb1b7d782bbe8b0de73a7eaf65aee6a8aeed"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":5,"commits":2,"additions":1,"deletions":1,"changed_files":1}}