{"action":"created","comment":{"url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/pulls/comments/32895141","id":32895141,"diff_hunk":"@@ -87,38 +88,30 @@ class J2objcUtils {\n             throw new InvalidUserDataException(message)\n         }\n         if (!proj.file(result).exists()) {\n-            def message = \"j2objc directory not found, expected location: ${result}\"\n+            String message = \"j2objc directory not found, expected location: ${result}\"\n             throw new InvalidUserDataException(message)\n         }\n         return result\n     }\n \n-    // Filters a FileCollection by path:\n-    // must match includeRegex and NOT match excludeRegex, regex ignored if null\n-    static def fileFilter(FileCollection files, String includeRegex, String excludeRegex) {\n-        return files.filter { file ->\n-            return file.path.matches(includeRegex)\n-        }.filter { file ->\n-            return !file.path.matches(excludeRegex)\n-        }\n-    }\n-\n-    // Reads properties file and flags from translateFlags (last flag takes precedence)\n+    // Reads properties file and arguments from translateArgs (last argument takes precedence)\n     //   --prefixes dir/prefixes.properties --prefix com.ex.dir=Short --prefix com.ex.dir2=Short2\n-    // TODO: separate this out to a distinct flag that's added to translateFlags\n+    // TODO: separate this out to a distinct argument that's added to translateArgs\n     // TODO: @InputFile conversion for this\n-    static def prefixProperties(Project proj, String translateFlags) {\n+    static Properties prefixProperties(Project proj, List<String> translateArgs) {","path":"src/main/groovy/com/github/j2objccontrib/j2objcgradle/tasks/J2objcUtils.groovy","position":78,"original_position":78,"commit_id":"3140fdc4ca6e06e969b119a6f5a10e701b5afc39","original_commit_id":"3140fdc4ca6e06e969b119a6f5a10e701b5afc39","user":{"login":"confile","id":64265,"avatar_url":"https://avatars.githubusercontent.com/u/64265?v=3","gravatar_id":"","url":"https://api.github.com/users/confile","html_url":"https://github.com/confile","followers_url":"https://api.github.com/users/confile/followers","following_url":"https://api.github.com/users/confile/following{/other_user}","gists_url":"https://api.github.com/users/confile/gists{/gist_id}","starred_url":"https://api.github.com/users/confile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confile/subscriptions","organizations_url":"https://api.github.com/users/confile/orgs","repos_url":"https://api.github.com/users/confile/repos","events_url":"https://api.github.com/users/confile/events{/privacy}","received_events_url":"https://api.github.com/users/confile/received_events","type":"User","site_admin":false},"body":"I use Eclipse but it does not show anything. Better keep an Unused import than a missing import somewhere else.","created_at":"2015-06-21T17:04:12Z","updated_at":"2015-06-21T17:04:12Z","html_url":"https://github.com/j2objc-contrib/j2objc-gradle/pull/198#discussion_r32895141","pull_request_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/pulls/198","_links":{"self":{"href":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/pulls/comments/32895141"},"html":{"href":"https://github.com/j2objc-contrib/j2objc-gradle/pull/198#discussion_r32895141"},"pull_request":{"href":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/pulls/198","id":38163887,"html_url":"https://github.com/j2objc-contrib/j2objc-gradle/pull/198","diff_url":"https://github.com/j2objc-contrib/j2objc-gradle/pull/198.diff","patch_url":"https://github.com/j2objc-contrib/j2objc-gradle/pull/198.patch","issue_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/issues/198","number":198,"state":"closed","locked":false,"title":"J2objcUtils: type checking + unit tests","user":{"login":"brunobowden","id":679339,"avatar_url":"https://avatars.githubusercontent.com/u/679339?v=3","gravatar_id":"","url":"https://api.github.com/users/brunobowden","html_url":"https://github.com/brunobowden","followers_url":"https://api.github.com/users/brunobowden/followers","following_url":"https://api.github.com/users/brunobowden/following{/other_user}","gists_url":"https://api.github.com/users/brunobowden/gists{/gist_id}","starred_url":"https://api.github.com/users/brunobowden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunobowden/subscriptions","organizations_url":"https://api.github.com/users/brunobowden/orgs","repos_url":"https://api.github.com/users/brunobowden/repos","events_url":"https://api.github.com/users/brunobowden/events{/privacy}","received_events_url":"https://api.github.com/users/brunobowden/received_events","type":"User","site_admin":false},"body":"Changes isolated to J2objcUtils, J2objcUtilsTest and test resource\r\n- First unit tests for the plugin\r\n- TODO’s for methods not unit tested\r\n- Added prefixes.properties as test resource\r\n- Replace many instances of “def” with explicit type\r\n- Remove unused fileFilter(…) method\r\n- Introduces unit tests - issue #98","created_at":"2015-06-20T06:52:09Z","updated_at":"2015-06-21T17:04:12Z","closed_at":"2015-06-20T22:25:57Z","merged_at":"2015-06-20T22:25:57Z","merge_commit_sha":"fd0bb94d82bc19ff69ae02d1156f9fce2b6c527a","assignee":{"login":"advayDev1","id":11729521,"avatar_url":"https://avatars.githubusercontent.com/u/11729521?v=3","gravatar_id":"","url":"https://api.github.com/users/advayDev1","html_url":"https://github.com/advayDev1","followers_url":"https://api.github.com/users/advayDev1/followers","following_url":"https://api.github.com/users/advayDev1/following{/other_user}","gists_url":"https://api.github.com/users/advayDev1/gists{/gist_id}","starred_url":"https://api.github.com/users/advayDev1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advayDev1/subscriptions","organizations_url":"https://api.github.com/users/advayDev1/orgs","repos_url":"https://api.github.com/users/advayDev1/repos","events_url":"https://api.github.com/users/advayDev1/events{/privacy}","received_events_url":"https://api.github.com/users/advayDev1/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/milestones/3","html_url":"https://github.com/j2objc-contrib/j2objc-gradle/milestones/Beta%20Release","labels_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/milestones/3/labels","id":1162580,"number":3,"title":"Beta Release","description":null,"creator":{"login":"advayDev1","id":11729521,"avatar_url":"https://avatars.githubusercontent.com/u/11729521?v=3","gravatar_id":"","url":"https://api.github.com/users/advayDev1","html_url":"https://github.com/advayDev1","followers_url":"https://api.github.com/users/advayDev1/followers","following_url":"https://api.github.com/users/advayDev1/following{/other_user}","gists_url":"https://api.github.com/users/advayDev1/gists{/gist_id}","starred_url":"https://api.github.com/users/advayDev1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advayDev1/subscriptions","organizations_url":"https://api.github.com/users/advayDev1/orgs","repos_url":"https://api.github.com/users/advayDev1/repos","events_url":"https://api.github.com/users/advayDev1/events{/privacy}","received_events_url":"https://api.github.com/users/advayDev1/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":19,"state":"open","created_at":"2015-06-12T19:01:13Z","updated_at":"2015-06-21T15:17:36Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/pulls/198/commits","review_comments_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/pulls/198/comments","review_comment_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/issues/198/comments","statuses_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/statuses/3140fdc4ca6e06e969b119a6f5a10e701b5afc39","head":{"label":"brunobowden:testing","ref":"testing","sha":"3140fdc4ca6e06e969b119a6f5a10e701b5afc39","user":{"login":"brunobowden","id":679339,"avatar_url":"https://avatars.githubusercontent.com/u/679339?v=3","gravatar_id":"","url":"https://api.github.com/users/brunobowden","html_url":"https://github.com/brunobowden","followers_url":"https://api.github.com/users/brunobowden/followers","following_url":"https://api.github.com/users/brunobowden/following{/other_user}","gists_url":"https://api.github.com/users/brunobowden/gists{/gist_id}","starred_url":"https://api.github.com/users/brunobowden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunobowden/subscriptions","organizations_url":"https://api.github.com/users/brunobowden/orgs","repos_url":"https://api.github.com/users/brunobowden/repos","events_url":"https://api.github.com/users/brunobowden/events{/privacy}","received_events_url":"https://api.github.com/users/brunobowden/received_events","type":"User","site_admin":false},"repo":{"id":37033994,"name":"j2objc-gradle","full_name":"brunobowden/j2objc-gradle","owner":{"login":"brunobowden","id":679339,"avatar_url":"https://avatars.githubusercontent.com/u/679339?v=3","gravatar_id":"","url":"https://api.github.com/users/brunobowden","html_url":"https://github.com/brunobowden","followers_url":"https://api.github.com/users/brunobowden/followers","following_url":"https://api.github.com/users/brunobowden/following{/other_user}","gists_url":"https://api.github.com/users/brunobowden/gists{/gist_id}","starred_url":"https://api.github.com/users/brunobowden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunobowden/subscriptions","organizations_url":"https://api.github.com/users/brunobowden/orgs","repos_url":"https://api.github.com/users/brunobowden/repos","events_url":"https://api.github.com/users/brunobowden/events{/privacy}","received_events_url":"https://api.github.com/users/brunobowden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brunobowden/j2objc-gradle","description":"Gradle plugin for j2objc (Java to Objective-C transpiler)","fork":true,"url":"https://api.github.com/repos/brunobowden/j2objc-gradle","forks_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/forks","keys_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/teams","hooks_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/hooks","issue_events_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/issues/events{/number}","events_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/events","assignees_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/assignees{/user}","branches_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/branches{/branch}","tags_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/tags","blobs_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/languages","stargazers_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/stargazers","contributors_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/contributors","subscribers_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/subscribers","subscription_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/subscription","commits_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/contents/{+path}","compare_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/merges","archive_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/downloads","issues_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/issues{/number}","pulls_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/labels{/name}","releases_url":"https://api.github.com/repos/brunobowden/j2objc-gradle/releases{/id}","created_at":"2015-06-07T22:04:38Z","updated_at":"2015-06-18T06:13:01Z","pushed_at":"2015-06-21T16:14:08Z","git_url":"git://github.com/brunobowden/j2objc-gradle.git","ssh_url":"git@github.com:brunobowden/j2objc-gradle.git","clone_url":"https://github.com/brunobowden/j2objc-gradle.git","svn_url":"https://github.com/brunobowden/j2objc-gradle","homepage":null,"size":582,"stargazers_count":1,"watchers_count":1,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"j2objc-contrib:master","ref":"master","sha":"047787dbb34dd7942f03e131d2ec72a744f00530","user":{"login":"j2objc-contrib","id":12766207,"avatar_url":"https://avatars.githubusercontent.com/u/12766207?v=3","gravatar_id":"","url":"https://api.github.com/users/j2objc-contrib","html_url":"https://github.com/j2objc-contrib","followers_url":"https://api.github.com/users/j2objc-contrib/followers","following_url":"https://api.github.com/users/j2objc-contrib/following{/other_user}","gists_url":"https://api.github.com/users/j2objc-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/j2objc-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j2objc-contrib/subscriptions","organizations_url":"https://api.github.com/users/j2objc-contrib/orgs","repos_url":"https://api.github.com/users/j2objc-contrib/repos","events_url":"https://api.github.com/users/j2objc-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/j2objc-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":30206593,"name":"j2objc-gradle","full_name":"j2objc-contrib/j2objc-gradle","owner":{"login":"j2objc-contrib","id":12766207,"avatar_url":"https://avatars.githubusercontent.com/u/12766207?v=3","gravatar_id":"","url":"https://api.github.com/users/j2objc-contrib","html_url":"https://github.com/j2objc-contrib","followers_url":"https://api.github.com/users/j2objc-contrib/followers","following_url":"https://api.github.com/users/j2objc-contrib/following{/other_user}","gists_url":"https://api.github.com/users/j2objc-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/j2objc-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j2objc-contrib/subscriptions","organizations_url":"https://api.github.com/users/j2objc-contrib/orgs","repos_url":"https://api.github.com/users/j2objc-contrib/repos","events_url":"https://api.github.com/users/j2objc-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/j2objc-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/j2objc-contrib/j2objc-gradle","description":"Gradle plugin for j2objc (Java to Objective-C transpiler)","fork":false,"url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle","forks_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/forks","keys_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/teams","hooks_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/hooks","issue_events_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/issues/events{/number}","events_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/events","assignees_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/assignees{/user}","branches_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/branches{/branch}","tags_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/tags","blobs_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/languages","stargazers_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/stargazers","contributors_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/contributors","subscribers_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/subscribers","subscription_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/subscription","commits_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/contents/{+path}","compare_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/merges","archive_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/downloads","issues_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/issues{/number}","pulls_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/labels{/name}","releases_url":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/releases{/id}","created_at":"2015-02-02T20:22:07Z","updated_at":"2015-06-12T18:14:45Z","pushed_at":"2015-06-21T16:29:59Z","git_url":"git://github.com/j2objc-contrib/j2objc-gradle.git","ssh_url":"git@github.com:j2objc-contrib/j2objc-gradle.git","clone_url":"https://github.com/j2objc-contrib/j2objc-gradle.git","svn_url":"https://github.com/j2objc-contrib/j2objc-gradle","homepage":null,"size":1137,"stargazers_count":33,"watchers_count":33,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":43,"forks":8,"open_issues":43,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/pulls/198"},"html":{"href":"https://github.com/j2objc-contrib/j2objc-gradle/pull/198"},"issue":{"href":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/issues/198"},"comments":{"href":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/j2objc-contrib/j2objc-gradle/statuses/3140fdc4ca6e06e969b119a6f5a10e701b5afc39"}}}}