{"action":"created","issue":{"url":"https://api.github.com/repos/bkane56/Greedy/issues/2","labels_url":"https://api.github.com/repos/bkane56/Greedy/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/bkane56/Greedy/issues/2/comments","events_url":"https://api.github.com/repos/bkane56/Greedy/issues/2/events","html_url":"https://github.com/bkane56/Greedy/issues/2","id":76624122,"number":2,"title":"Refactor the EU and US calculators","user":{"login":"MoMenne","id":217904,"avatar_url":"https://avatars.githubusercontent.com/u/217904?v=3","gravatar_id":"","url":"https://api.github.com/users/MoMenne","html_url":"https://github.com/MoMenne","followers_url":"https://api.github.com/users/MoMenne/followers","following_url":"https://api.github.com/users/MoMenne/following{/other_user}","gists_url":"https://api.github.com/users/MoMenne/gists{/gist_id}","starred_url":"https://api.github.com/users/MoMenne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoMenne/subscriptions","organizations_url":"https://api.github.com/users/MoMenne/orgs","repos_url":"https://api.github.com/users/MoMenne/repos","events_url":"https://api.github.com/users/MoMenne/events{/privacy}","received_events_url":"https://api.github.com/users/MoMenne/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-15T06:58:31Z","updated_at":"2015-05-17T16:28:04Z","closed_at":null,"body":"Hi Brian,\r\n\r\nConsider refactoring so that the EU and US calculators each have their own class.  Consider using the an interface to complete the Strategy pattern.\r\n\r\nThis refactoring allows your code to hold true to the Single Responsibility Principle which states that a class should only have one purpose.\r\n\r\nCheers,\r\nMike"},"comment":{"url":"https://api.github.com/repos/bkane56/Greedy/issues/comments/102820345","html_url":"https://github.com/bkane56/Greedy/issues/2#issuecomment-102820345","issue_url":"https://api.github.com/repos/bkane56/Greedy/issues/2","id":102820345,"user":{"login":"bkane56","id":10392802,"avatar_url":"https://avatars.githubusercontent.com/u/10392802?v=3","gravatar_id":"","url":"https://api.github.com/users/bkane56","html_url":"https://github.com/bkane56","followers_url":"https://api.github.com/users/bkane56/followers","following_url":"https://api.github.com/users/bkane56/following{/other_user}","gists_url":"https://api.github.com/users/bkane56/gists{/gist_id}","starred_url":"https://api.github.com/users/bkane56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkane56/subscriptions","organizations_url":"https://api.github.com/users/bkane56/orgs","repos_url":"https://api.github.com/users/bkane56/repos","events_url":"https://api.github.com/users/bkane56/events{/privacy}","received_events_url":"https://api.github.com/users/bkane56/received_events","type":"User","site_admin":false},"created_at":"2015-05-17T16:28:04Z","updated_at":"2015-05-17T16:28:04Z","body":"Mike,\n\nI pushed this branch (strategydesign) which has my work on interface and\nseparate coin calculators.\n\nOn Sun, May 17, 2015 at 11:16 AM, Brian Kane <bkane56@gmail.com> wrote:\n\n> Hello again,\n>\n> I had been working on that with the calculators in there package as your\n> video had done but they would not implement spent a few days messing with\n> it.\n> I noticed that it is on a branch that did not get pushed so I will do that\n> in a few minutes.  Let you take a look.  I was having a hard time getting\n> it to run properly\n> even with the calculators in the java folder.  I will spend a little more\n> time messing with it.\n>\n> On Fri, May 15, 2015 at 1:58 AM, Mike Menne <notifications@github.com>\n> wrote:\n>\n>> Hi Brian,\n>>\n>> Consider refactoring so that the EU and US calculators each have their\n>> own class. Consider using the an interface to complete the Strategy pattern.\n>>\n>> This refactoring allows your code to hold true to the Single\n>> Responsibility Principle which states that a class should only have one\n>> purpose.\n>>\n>> Cheers,\n>> Mike\n>>\n>> —\n>> Reply to this email directly or view it on GitHub\n>> <https://github.com/bkane56/Greedy/issues/2>.\n>>\n>\n>\n"}}