{"action":"created","comment":{"url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments/38973283","id":38973283,"diff_hunk":"@@ -229,6 +229,15 @@ case class ReferenceRegion(referenceName: String, start: Long, end: Long, orient\n   def length(): Long = {\n     end - start\n   }\n+\n+  override def hashCode: Int = {\n+    var result = 37\n+    result = 41 * result + (if (referenceName != null) referenceName.hashCode else 0)\n+    result = 41 * result + (if (start != null) start.hashCode else 0)","path":"adam-core/src/main/scala/org/bdgenomics/adam/models/ReferenceRegion.scala","position":18,"original_position":18,"commit_id":"c0998c15e797fa00963becf33e3404fa4d408e75","original_commit_id":"c0998c15e797fa00963becf33e3404fa4d408e75","user":{"login":"laserson","id":118141,"avatar_url":"https://avatars.githubusercontent.com/u/118141?v=3","gravatar_id":"","url":"https://api.github.com/users/laserson","html_url":"https://github.com/laserson","followers_url":"https://api.github.com/users/laserson/followers","following_url":"https://api.github.com/users/laserson/following{/other_user}","gists_url":"https://api.github.com/users/laserson/gists{/gist_id}","starred_url":"https://api.github.com/users/laserson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laserson/subscriptions","organizations_url":"https://api.github.com/users/laserson/orgs","repos_url":"https://api.github.com/users/laserson/repos","events_url":"https://api.github.com/users/laserson/events{/privacy}","received_events_url":"https://api.github.com/users/laserson/received_events","type":"User","site_admin":false},"body":"Does this mean that two `ReferenceRegion` objects that differ only in that one has `start=0` and the other has `start=null` would have the same `hashCode`?","created_at":"2015-09-08T20:08:21Z","updated_at":"2015-09-08T20:08:21Z","html_url":"https://github.com/bigdatagenomics/adam/pull/819#discussion_r38973283","pull_request_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/819","_links":{"self":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments/38973283"},"html":{"href":"https://github.com/bigdatagenomics/adam/pull/819#discussion_r38973283"},"pull_request":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/819"}}},"pull_request":{"url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/819","id":44471354,"html_url":"https://github.com/bigdatagenomics/adam/pull/819","diff_url":"https://github.com/bigdatagenomics/adam/pull/819.diff","patch_url":"https://github.com/bigdatagenomics/adam/pull/819.patch","issue_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/819","number":819,"state":"open","locked":false,"title":"Implement custom ReferenceRegion hashcode","user":{"login":"arahuja","id":455755,"avatar_url":"https://avatars.githubusercontent.com/u/455755?v=3","gravatar_id":"","url":"https://api.github.com/users/arahuja","html_url":"https://github.com/arahuja","followers_url":"https://api.github.com/users/arahuja/followers","following_url":"https://api.github.com/users/arahuja/following{/other_user}","gists_url":"https://api.github.com/users/arahuja/gists{/gist_id}","starred_url":"https://api.github.com/users/arahuja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arahuja/subscriptions","organizations_url":"https://api.github.com/users/arahuja/orgs","repos_url":"https://api.github.com/users/arahuja/repos","events_url":"https://api.github.com/users/arahuja/events{/privacy}","received_events_url":"https://api.github.com/users/arahuja/received_events","type":"User","site_admin":false},"body":"Fixes #817 ","created_at":"2015-09-08T19:15:13Z","updated_at":"2015-09-08T20:08:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb69f3be472ab5029db9a52f909247bea8e708c1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/819/commits","review_comments_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/819/comments","review_comment_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/819/comments","statuses_url":"https://api.github.com/repos/bigdatagenomics/adam/statuses/c0998c15e797fa00963becf33e3404fa4d408e75","head":{"label":"hammerlab:reference-region-hashcode","ref":"reference-region-hashcode","sha":"c0998c15e797fa00963becf33e3404fa4d408e75","user":{"login":"hammerlab","id":6563873,"avatar_url":"https://avatars.githubusercontent.com/u/6563873?v=3","gravatar_id":"","url":"https://api.github.com/users/hammerlab","html_url":"https://github.com/hammerlab","followers_url":"https://api.github.com/users/hammerlab/followers","following_url":"https://api.github.com/users/hammerlab/following{/other_user}","gists_url":"https://api.github.com/users/hammerlab/gists{/gist_id}","starred_url":"https://api.github.com/users/hammerlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammerlab/subscriptions","organizations_url":"https://api.github.com/users/hammerlab/orgs","repos_url":"https://api.github.com/users/hammerlab/repos","events_url":"https://api.github.com/users/hammerlab/events{/privacy}","received_events_url":"https://api.github.com/users/hammerlab/received_events","type":"Organization","site_admin":false},"repo":{"id":16501747,"name":"adam","full_name":"hammerlab/adam","owner":{"login":"hammerlab","id":6563873,"avatar_url":"https://avatars.githubusercontent.com/u/6563873?v=3","gravatar_id":"","url":"https://api.github.com/users/hammerlab","html_url":"https://github.com/hammerlab","followers_url":"https://api.github.com/users/hammerlab/followers","following_url":"https://api.github.com/users/hammerlab/following{/other_user}","gists_url":"https://api.github.com/users/hammerlab/gists{/gist_id}","starred_url":"https://api.github.com/users/hammerlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hammerlab/subscriptions","organizations_url":"https://api.github.com/users/hammerlab/orgs","repos_url":"https://api.github.com/users/hammerlab/repos","events_url":"https://api.github.com/users/hammerlab/events{/privacy}","received_events_url":"https://api.github.com/users/hammerlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hammerlab/adam","description":"A genomics processing engine and specialized file format built using Apache Avro, Apache Spark and Parquet. Apache 2 licensed.","fork":true,"url":"https://api.github.com/repos/hammerlab/adam","forks_url":"https://api.github.com/repos/hammerlab/adam/forks","keys_url":"https://api.github.com/repos/hammerlab/adam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hammerlab/adam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hammerlab/adam/teams","hooks_url":"https://api.github.com/repos/hammerlab/adam/hooks","issue_events_url":"https://api.github.com/repos/hammerlab/adam/issues/events{/number}","events_url":"https://api.github.com/repos/hammerlab/adam/events","assignees_url":"https://api.github.com/repos/hammerlab/adam/assignees{/user}","branches_url":"https://api.github.com/repos/hammerlab/adam/branches{/branch}","tags_url":"https://api.github.com/repos/hammerlab/adam/tags","blobs_url":"https://api.github.com/repos/hammerlab/adam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hammerlab/adam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hammerlab/adam/git/refs{/sha}","trees_url":"https://api.github.com/repos/hammerlab/adam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hammerlab/adam/statuses/{sha}","languages_url":"https://api.github.com/repos/hammerlab/adam/languages","stargazers_url":"https://api.github.com/repos/hammerlab/adam/stargazers","contributors_url":"https://api.github.com/repos/hammerlab/adam/contributors","subscribers_url":"https://api.github.com/repos/hammerlab/adam/subscribers","subscription_url":"https://api.github.com/repos/hammerlab/adam/subscription","commits_url":"https://api.github.com/repos/hammerlab/adam/commits{/sha}","git_commits_url":"https://api.github.com/repos/hammerlab/adam/git/commits{/sha}","comments_url":"https://api.github.com/repos/hammerlab/adam/comments{/number}","issue_comment_url":"https://api.github.com/repos/hammerlab/adam/issues/comments{/number}","contents_url":"https://api.github.com/repos/hammerlab/adam/contents/{+path}","compare_url":"https://api.github.com/repos/hammerlab/adam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hammerlab/adam/merges","archive_url":"https://api.github.com/repos/hammerlab/adam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hammerlab/adam/downloads","issues_url":"https://api.github.com/repos/hammerlab/adam/issues{/number}","pulls_url":"https://api.github.com/repos/hammerlab/adam/pulls{/number}","milestones_url":"https://api.github.com/repos/hammerlab/adam/milestones{/number}","notifications_url":"https://api.github.com/repos/hammerlab/adam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hammerlab/adam/labels{/name}","releases_url":"https://api.github.com/repos/hammerlab/adam/releases{/id}","created_at":"2014-02-04T03:57:44Z","updated_at":"2015-05-06T18:46:20Z","pushed_at":"2015-09-08T19:42:07Z","git_url":"git://github.com/hammerlab/adam.git","ssh_url":"git@github.com:hammerlab/adam.git","clone_url":"https://github.com/hammerlab/adam.git","svn_url":"https://github.com/hammerlab/adam","homepage":"","size":5368,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bigdatagenomics:master","ref":"master","sha":"b987dcc67b839c91eff81af2448291b547924ba4","user":{"login":"bigdatagenomics","id":5839438,"avatar_url":"https://avatars.githubusercontent.com/u/5839438?v=3","gravatar_id":"","url":"https://api.github.com/users/bigdatagenomics","html_url":"https://github.com/bigdatagenomics","followers_url":"https://api.github.com/users/bigdatagenomics/followers","following_url":"https://api.github.com/users/bigdatagenomics/following{/other_user}","gists_url":"https://api.github.com/users/bigdatagenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdatagenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdatagenomics/subscriptions","organizations_url":"https://api.github.com/users/bigdatagenomics/orgs","repos_url":"https://api.github.com/users/bigdatagenomics/repos","events_url":"https://api.github.com/users/bigdatagenomics/events{/privacy}","received_events_url":"https://api.github.com/users/bigdatagenomics/received_events","type":"Organization","site_admin":false},"repo":{"id":14541530,"name":"adam","full_name":"bigdatagenomics/adam","owner":{"login":"bigdatagenomics","id":5839438,"avatar_url":"https://avatars.githubusercontent.com/u/5839438?v=3","gravatar_id":"","url":"https://api.github.com/users/bigdatagenomics","html_url":"https://github.com/bigdatagenomics","followers_url":"https://api.github.com/users/bigdatagenomics/followers","following_url":"https://api.github.com/users/bigdatagenomics/following{/other_user}","gists_url":"https://api.github.com/users/bigdatagenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdatagenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdatagenomics/subscriptions","organizations_url":"https://api.github.com/users/bigdatagenomics/orgs","repos_url":"https://api.github.com/users/bigdatagenomics/repos","events_url":"https://api.github.com/users/bigdatagenomics/events{/privacy}","received_events_url":"https://api.github.com/users/bigdatagenomics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigdatagenomics/adam","description":"ADAM is a genomics analysis platform with specialized file formats built using Apache Avro, Apache Spark and Parquet. Apache 2 licensed.","fork":false,"url":"https://api.github.com/repos/bigdatagenomics/adam","forks_url":"https://api.github.com/repos/bigdatagenomics/adam/forks","keys_url":"https://api.github.com/repos/bigdatagenomics/adam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigdatagenomics/adam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigdatagenomics/adam/teams","hooks_url":"https://api.github.com/repos/bigdatagenomics/adam/hooks","issue_events_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/events{/number}","events_url":"https://api.github.com/repos/bigdatagenomics/adam/events","assignees_url":"https://api.github.com/repos/bigdatagenomics/adam/assignees{/user}","branches_url":"https://api.github.com/repos/bigdatagenomics/adam/branches{/branch}","tags_url":"https://api.github.com/repos/bigdatagenomics/adam/tags","blobs_url":"https://api.github.com/repos/bigdatagenomics/adam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigdatagenomics/adam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigdatagenomics/adam/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigdatagenomics/adam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigdatagenomics/adam/statuses/{sha}","languages_url":"https://api.github.com/repos/bigdatagenomics/adam/languages","stargazers_url":"https://api.github.com/repos/bigdatagenomics/adam/stargazers","contributors_url":"https://api.github.com/repos/bigdatagenomics/adam/contributors","subscribers_url":"https://api.github.com/repos/bigdatagenomics/adam/subscribers","subscription_url":"https://api.github.com/repos/bigdatagenomics/adam/subscription","commits_url":"https://api.github.com/repos/bigdatagenomics/adam/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigdatagenomics/adam/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigdatagenomics/adam/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigdatagenomics/adam/contents/{+path}","compare_url":"https://api.github.com/repos/bigdatagenomics/adam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigdatagenomics/adam/merges","archive_url":"https://api.github.com/repos/bigdatagenomics/adam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigdatagenomics/adam/downloads","issues_url":"https://api.github.com/repos/bigdatagenomics/adam/issues{/number}","pulls_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls{/number}","milestones_url":"https://api.github.com/repos/bigdatagenomics/adam/milestones{/number}","notifications_url":"https://api.github.com/repos/bigdatagenomics/adam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigdatagenomics/adam/labels{/name}","releases_url":"https://api.github.com/repos/bigdatagenomics/adam/releases{/id}","created_at":"2013-11-19T23:47:57Z","updated_at":"2015-09-06T19:51:51Z","pushed_at":"2015-09-08T19:42:08Z","git_url":"git://github.com/bigdatagenomics/adam.git","ssh_url":"git@github.com:bigdatagenomics/adam.git","clone_url":"https://github.com/bigdatagenomics/adam.git","svn_url":"https://github.com/bigdatagenomics/adam","homepage":"http://bdgenomics.org/","size":56400,"stargazers_count":326,"watchers_count":326,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"open_issues_count":113,"forks":124,"open_issues":113,"watchers":326,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/819"},"html":{"href":"https://github.com/bigdatagenomics/adam/pull/819"},"issue":{"href":"https://api.github.com/repos/bigdatagenomics/adam/issues/819"},"comments":{"href":"https://api.github.com/repos/bigdatagenomics/adam/issues/819/comments"},"review_comments":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/819/comments"},"review_comment":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/819/commits"},"statuses":{"href":"https://api.github.com/repos/bigdatagenomics/adam/statuses/c0998c15e797fa00963becf33e3404fa4d408e75"}}}}