{"push_id":869444081,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"bd2dbb91a519473fe17bfe7a54c86e530aba860b","before":"34e45dd0b5ce69446d6f373d0fe85d408adcc242","commits":[{"sha":"bd2dbb91a519473fe17bfe7a54c86e530aba860b","author":{"email":"e1fb1a05abba8fb04acbcbe6d766da7764320db0@nylas.com","name":"Christine Spang"},"message":"Normalize \"regex\" patterns in providers.py.\n\nSummary:\nThe immediate reason to do this is because the current code is wrongly\ninterpreting 'ppsmtp.com' to be an MX server for Gmail, but altogether\nthe current plugging of things that were intended to be straight strings\ninto a regex has lots of room for misinterpretation, mostly with the '.'\ncharacter, which can stand for everything—but we generally intend for it\nto be used literally, except in wildcard matches.\n\nSo as a compromise between legibility and being able to actually tell\nwhat a given pattern does, we leave dots as literal dots and * as a glob\n*, and substitute these into proper regexes before using them. Otherwise\nwe'd have to switch out '.' for '[.]' and '*' for '.*' everywhere.\n\nTest Plan:\nUnit tests, some manual testing\n\nI added some new test cases for providers, but couldn't find good domains for\nnamecheap/godaddy that aren't likely to randomly stop working at some point\nin the future.\n\nReviewers: khamidou\n\nReviewed By: khamidou\n\nDifferential Revision: https://phab.nylas.com/D2268","distinct":true,"url":"https://api.github.com/repos/nylas/sync-engine/commits/bd2dbb91a519473fe17bfe7a54c86e530aba860b"}]}