{"action":"created","comment":{"url":"https://api.github.com/repos/caelum/mamute/pulls/comments/23352294","id":23352294,"diff_hunk":"@@ -141,12 +172,28 @@ public void should_not_save_repeated_tags() throws Exception {\n \t\tassertEquals(tags.all().size(), originalSize+1);\n \t}\n \n+    @Test\n+    public void should_not_save_tags_with_unique_name_but_same_slug() throws Exception {\n+        int originalSize = tags.all().size();\n+        Tag cevapciciWithSpecialChar = new Tag(\"čevapčiči\", \"\", leo);\n+        Tag cevapciciWithoutSpecialChar = new Tag(\"cevapcici\", \"\", leo);\n+        tags.saveIfDoesntExists(cevapciciWithSpecialChar);\n+        tags.saveIfDoesntExists(cevapciciWithoutSpecialChar);\n+\n+        assertEquals(tags.all().size(), originalSize+1);\n+    }\n+\n+    @Test\n+    public void should_define_correct_slugged_url() {\n+        assertNotNull(tags.findBySluggedName(\"java\"));\n+        assertNotNull(tags.findBySluggedName(\"ruby\"));\n+        assertNotNull(tags.findBySluggedName(\"c%2b%2b\"));\n+    }","path":"src/test/java/org/mamute/dao/TagDAOTest.java","position":126,"original_position":126,"commit_id":"c453a4c47f3163de1aaf401cdd7f5f5aae53abf4","original_commit_id":"c453a4c47f3163de1aaf401cdd7f5f5aae53abf4","user":{"login":"leocwolter","id":1354822,"avatar_url":"https://avatars.githubusercontent.com/u/1354822?v=3","gravatar_id":"","url":"https://api.github.com/users/leocwolter","html_url":"https://github.com/leocwolter","followers_url":"https://api.github.com/users/leocwolter/followers","following_url":"https://api.github.com/users/leocwolter/following{/other_user}","gists_url":"https://api.github.com/users/leocwolter/gists{/gist_id}","starred_url":"https://api.github.com/users/leocwolter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leocwolter/subscriptions","organizations_url":"https://api.github.com/users/leocwolter/orgs","repos_url":"https://api.github.com/users/leocwolter/repos","events_url":"https://api.github.com/users/leocwolter/events{/privacy}","received_events_url":"https://api.github.com/users/leocwolter/received_events","type":"User","site_admin":false},"body":"better to assert if the returned tag is actually `c++` ","created_at":"2015-01-22T02:39:26Z","updated_at":"2015-01-22T02:39:26Z","html_url":"https://github.com/caelum/mamute/pull/135#discussion_r23352294","pull_request_url":"https://api.github.com/repos/caelum/mamute/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/caelum/mamute/pulls/comments/23352294"},"html":{"href":"https://github.com/caelum/mamute/pull/135#discussion_r23352294"},"pull_request":{"href":"https://api.github.com/repos/caelum/mamute/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/caelum/mamute/pulls/135","id":27372105,"html_url":"https://github.com/caelum/mamute/pull/135","diff_url":"https://github.com/caelum/mamute/pull/135.diff","patch_url":"https://github.com/caelum/mamute/pull/135.patch","issue_url":"https://api.github.com/repos/caelum/mamute/issues/135","number":135,"state":"open","locked":false,"title":"Link to Tags using sluggedName instead of the name itself.","user":{"login":"MatejBalantic","id":994179,"avatar_url":"https://avatars.githubusercontent.com/u/994179?v=3","gravatar_id":"","url":"https://api.github.com/users/MatejBalantic","html_url":"https://github.com/MatejBalantic","followers_url":"https://api.github.com/users/MatejBalantic/followers","following_url":"https://api.github.com/users/MatejBalantic/following{/other_user}","gists_url":"https://api.github.com/users/MatejBalantic/gists{/gist_id}","starred_url":"https://api.github.com/users/MatejBalantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatejBalantic/subscriptions","organizations_url":"https://api.github.com/users/MatejBalantic/orgs","repos_url":"https://api.github.com/users/MatejBalantic/repos","events_url":"https://api.github.com/users/MatejBalantic/events{/privacy}","received_events_url":"https://api.github.com/users/MatejBalantic/received_events","type":"User","site_admin":false},"body":"* this allows tag names to contain any character, including spaces etc, thus validation of the name is now removed\r\n* slugged name is automatically generated in the same way as for the questions\r\n* the change is backwards-compatible as all the names are transferred to suggedName upon migration\r\n\r\nNotice: this passes unit tests, however will not build on Travis until https://github.com/caelum/mamute/pull/134 is merged","created_at":"2015-01-14T18:36:39Z","updated_at":"2015-01-22T02:39:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67c4becbab2b56251944901f64c8ee48f2ac420c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/caelum/mamute/pulls/135/commits","review_comments_url":"https://api.github.com/repos/caelum/mamute/pulls/135/comments","review_comment_url":"https://api.github.com/repos/caelum/mamute/pulls/comments/{number}","comments_url":"https://api.github.com/repos/caelum/mamute/issues/135/comments","statuses_url":"https://api.github.com/repos/caelum/mamute/statuses/c453a4c47f3163de1aaf401cdd7f5f5aae53abf4","head":{"label":"MatejBalantic:tags_slugged","ref":"tags_slugged","sha":"c453a4c47f3163de1aaf401cdd7f5f5aae53abf4","user":{"login":"MatejBalantic","id":994179,"avatar_url":"https://avatars.githubusercontent.com/u/994179?v=3","gravatar_id":"","url":"https://api.github.com/users/MatejBalantic","html_url":"https://github.com/MatejBalantic","followers_url":"https://api.github.com/users/MatejBalantic/followers","following_url":"https://api.github.com/users/MatejBalantic/following{/other_user}","gists_url":"https://api.github.com/users/MatejBalantic/gists{/gist_id}","starred_url":"https://api.github.com/users/MatejBalantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatejBalantic/subscriptions","organizations_url":"https://api.github.com/users/MatejBalantic/orgs","repos_url":"https://api.github.com/users/MatejBalantic/repos","events_url":"https://api.github.com/users/MatejBalantic/events{/privacy}","received_events_url":"https://api.github.com/users/MatejBalantic/received_events","type":"User","site_admin":false},"repo":{"id":28788024,"name":"mamute","full_name":"MatejBalantic/mamute","owner":{"login":"MatejBalantic","id":994179,"avatar_url":"https://avatars.githubusercontent.com/u/994179?v=3","gravatar_id":"","url":"https://api.github.com/users/MatejBalantic","html_url":"https://github.com/MatejBalantic","followers_url":"https://api.github.com/users/MatejBalantic/followers","following_url":"https://api.github.com/users/MatejBalantic/following{/other_user}","gists_url":"https://api.github.com/users/MatejBalantic/gists{/gist_id}","starred_url":"https://api.github.com/users/MatejBalantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatejBalantic/subscriptions","organizations_url":"https://api.github.com/users/MatejBalantic/orgs","repos_url":"https://api.github.com/users/MatejBalantic/repos","events_url":"https://api.github.com/users/MatejBalantic/events{/privacy}","received_events_url":"https://api.github.com/users/MatejBalantic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MatejBalantic/mamute","description":"Q&A Engine","fork":true,"url":"https://api.github.com/repos/MatejBalantic/mamute","forks_url":"https://api.github.com/repos/MatejBalantic/mamute/forks","keys_url":"https://api.github.com/repos/MatejBalantic/mamute/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MatejBalantic/mamute/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MatejBalantic/mamute/teams","hooks_url":"https://api.github.com/repos/MatejBalantic/mamute/hooks","issue_events_url":"https://api.github.com/repos/MatejBalantic/mamute/issues/events{/number}","events_url":"https://api.github.com/repos/MatejBalantic/mamute/events","assignees_url":"https://api.github.com/repos/MatejBalantic/mamute/assignees{/user}","branches_url":"https://api.github.com/repos/MatejBalantic/mamute/branches{/branch}","tags_url":"https://api.github.com/repos/MatejBalantic/mamute/tags","blobs_url":"https://api.github.com/repos/MatejBalantic/mamute/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MatejBalantic/mamute/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MatejBalantic/mamute/git/refs{/sha}","trees_url":"https://api.github.com/repos/MatejBalantic/mamute/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MatejBalantic/mamute/statuses/{sha}","languages_url":"https://api.github.com/repos/MatejBalantic/mamute/languages","stargazers_url":"https://api.github.com/repos/MatejBalantic/mamute/stargazers","contributors_url":"https://api.github.com/repos/MatejBalantic/mamute/contributors","subscribers_url":"https://api.github.com/repos/MatejBalantic/mamute/subscribers","subscription_url":"https://api.github.com/repos/MatejBalantic/mamute/subscription","commits_url":"https://api.github.com/repos/MatejBalantic/mamute/commits{/sha}","git_commits_url":"https://api.github.com/repos/MatejBalantic/mamute/git/commits{/sha}","comments_url":"https://api.github.com/repos/MatejBalantic/mamute/comments{/number}","issue_comment_url":"https://api.github.com/repos/MatejBalantic/mamute/issues/comments/{number}","contents_url":"https://api.github.com/repos/MatejBalantic/mamute/contents/{+path}","compare_url":"https://api.github.com/repos/MatejBalantic/mamute/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MatejBalantic/mamute/merges","archive_url":"https://api.github.com/repos/MatejBalantic/mamute/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MatejBalantic/mamute/downloads","issues_url":"https://api.github.com/repos/MatejBalantic/mamute/issues{/number}","pulls_url":"https://api.github.com/repos/MatejBalantic/mamute/pulls{/number}","milestones_url":"https://api.github.com/repos/MatejBalantic/mamute/milestones{/number}","notifications_url":"https://api.github.com/repos/MatejBalantic/mamute/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MatejBalantic/mamute/labels{/name}","releases_url":"https://api.github.com/repos/MatejBalantic/mamute/releases{/id}","created_at":"2015-01-04T22:27:54Z","updated_at":"2015-01-14T18:28:35Z","pushed_at":"2015-01-21T20:54:59Z","git_url":"git://github.com/MatejBalantic/mamute.git","ssh_url":"git@github.com:MatejBalantic/mamute.git","clone_url":"https://github.com/MatejBalantic/mamute.git","svn_url":"https://github.com/MatejBalantic/mamute","homepage":"http://www.mamute.org/","size":45271,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"caelum:master","ref":"master","sha":"bada755368c07e636fe28936da620fcfb3e731c1","user":{"login":"caelum","id":65012,"avatar_url":"https://avatars.githubusercontent.com/u/65012?v=3","gravatar_id":"","url":"https://api.github.com/users/caelum","html_url":"https://github.com/caelum","followers_url":"https://api.github.com/users/caelum/followers","following_url":"https://api.github.com/users/caelum/following{/other_user}","gists_url":"https://api.github.com/users/caelum/gists{/gist_id}","starred_url":"https://api.github.com/users/caelum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caelum/subscriptions","organizations_url":"https://api.github.com/users/caelum/orgs","repos_url":"https://api.github.com/users/caelum/repos","events_url":"https://api.github.com/users/caelum/events{/privacy}","received_events_url":"https://api.github.com/users/caelum/received_events","type":"Organization","site_admin":false},"repo":{"id":17177044,"name":"mamute","full_name":"caelum/mamute","owner":{"login":"caelum","id":65012,"avatar_url":"https://avatars.githubusercontent.com/u/65012?v=3","gravatar_id":"","url":"https://api.github.com/users/caelum","html_url":"https://github.com/caelum","followers_url":"https://api.github.com/users/caelum/followers","following_url":"https://api.github.com/users/caelum/following{/other_user}","gists_url":"https://api.github.com/users/caelum/gists{/gist_id}","starred_url":"https://api.github.com/users/caelum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caelum/subscriptions","organizations_url":"https://api.github.com/users/caelum/orgs","repos_url":"https://api.github.com/users/caelum/repos","events_url":"https://api.github.com/users/caelum/events{/privacy}","received_events_url":"https://api.github.com/users/caelum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caelum/mamute","description":"Q&A Engine","fork":false,"url":"https://api.github.com/repos/caelum/mamute","forks_url":"https://api.github.com/repos/caelum/mamute/forks","keys_url":"https://api.github.com/repos/caelum/mamute/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caelum/mamute/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caelum/mamute/teams","hooks_url":"https://api.github.com/repos/caelum/mamute/hooks","issue_events_url":"https://api.github.com/repos/caelum/mamute/issues/events{/number}","events_url":"https://api.github.com/repos/caelum/mamute/events","assignees_url":"https://api.github.com/repos/caelum/mamute/assignees{/user}","branches_url":"https://api.github.com/repos/caelum/mamute/branches{/branch}","tags_url":"https://api.github.com/repos/caelum/mamute/tags","blobs_url":"https://api.github.com/repos/caelum/mamute/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caelum/mamute/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caelum/mamute/git/refs{/sha}","trees_url":"https://api.github.com/repos/caelum/mamute/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caelum/mamute/statuses/{sha}","languages_url":"https://api.github.com/repos/caelum/mamute/languages","stargazers_url":"https://api.github.com/repos/caelum/mamute/stargazers","contributors_url":"https://api.github.com/repos/caelum/mamute/contributors","subscribers_url":"https://api.github.com/repos/caelum/mamute/subscribers","subscription_url":"https://api.github.com/repos/caelum/mamute/subscription","commits_url":"https://api.github.com/repos/caelum/mamute/commits{/sha}","git_commits_url":"https://api.github.com/repos/caelum/mamute/git/commits{/sha}","comments_url":"https://api.github.com/repos/caelum/mamute/comments{/number}","issue_comment_url":"https://api.github.com/repos/caelum/mamute/issues/comments/{number}","contents_url":"https://api.github.com/repos/caelum/mamute/contents/{+path}","compare_url":"https://api.github.com/repos/caelum/mamute/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caelum/mamute/merges","archive_url":"https://api.github.com/repos/caelum/mamute/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caelum/mamute/downloads","issues_url":"https://api.github.com/repos/caelum/mamute/issues{/number}","pulls_url":"https://api.github.com/repos/caelum/mamute/pulls{/number}","milestones_url":"https://api.github.com/repos/caelum/mamute/milestones{/number}","notifications_url":"https://api.github.com/repos/caelum/mamute/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caelum/mamute/labels{/name}","releases_url":"https://api.github.com/repos/caelum/mamute/releases{/id}","created_at":"2014-02-25T15:10:04Z","updated_at":"2015-01-22T02:31:23Z","pushed_at":"2015-01-22T02:31:23Z","git_url":"git://github.com/caelum/mamute.git","ssh_url":"git@github.com:caelum/mamute.git","clone_url":"https://github.com/caelum/mamute.git","svn_url":"https://github.com/caelum/mamute","homepage":"http://www.mamute.org/","size":48319,"stargazers_count":90,"watchers_count":90,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":47,"mirror_url":null,"open_issues_count":39,"forks":47,"open_issues":39,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caelum/mamute/pulls/135"},"html":{"href":"https://github.com/caelum/mamute/pull/135"},"issue":{"href":"https://api.github.com/repos/caelum/mamute/issues/135"},"comments":{"href":"https://api.github.com/repos/caelum/mamute/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/caelum/mamute/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/caelum/mamute/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/caelum/mamute/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/caelum/mamute/statuses/c453a4c47f3163de1aaf401cdd7f5f5aae53abf4"}}}}