{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/sigma.js/pulls/comments/24630336","id":24630336,"diff_hunk":"@@ -93,6 +93,18 @@\n         node.image.url);\n       group.appendChild(def);\n       group.appendChild(image);\n+    } else if ((!node.image || !node.image.url) && group.childNodes.length >= 1) {\n+      var childNodes = group.childNodes,\n+          className,\n+          i = 0;\n+      while(i < childNodes.length) {\n+        className = childNodes[i].getAttribute('class');\n+        if (className !== (settings('classPrefix') + '-node')) {\n+          group.removeChild(childNodes[i]);\n+          continue;\n+        }\n+        i++;","path":"plugins/sigma.renderers.customShapes/sigma.renderers.customShapes.js","position":25,"original_position":25,"commit_id":"e885a0324e6563dcd08198b758c71452552ac318","original_commit_id":"e885a0324e6563dcd08198b758c71452552ac318","user":{"login":"ashwinr","id":362990,"avatar_url":"https://avatars.githubusercontent.com/u/362990?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwinr","html_url":"https://github.com/ashwinr","followers_url":"https://api.github.com/users/ashwinr/followers","following_url":"https://api.github.com/users/ashwinr/following{/other_user}","gists_url":"https://api.github.com/users/ashwinr/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwinr/subscriptions","organizations_url":"https://api.github.com/users/ashwinr/orgs","repos_url":"https://api.github.com/users/ashwinr/repos","events_url":"https://api.github.com/users/ashwinr/events{/privacy}","received_events_url":"https://api.github.com/users/ashwinr/received_events","type":"User","site_admin":false},"body":"use an else and remove the continue above","created_at":"2015-02-12T23:07:24Z","updated_at":"2015-02-12T23:07:24Z","html_url":"https://github.com/palantir/sigma.js/pull/34#discussion_r24630336","pull_request_url":"https://api.github.com/repos/palantir/sigma.js/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/palantir/sigma.js/pulls/comments/24630336"},"html":{"href":"https://github.com/palantir/sigma.js/pull/34#discussion_r24630336"},"pull_request":{"href":"https://api.github.com/repos/palantir/sigma.js/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/sigma.js/pulls/34","id":29101061,"html_url":"https://github.com/palantir/sigma.js/pull/34","diff_url":"https://github.com/palantir/sigma.js/pull/34.diff","patch_url":"https://github.com/palantir/sigma.js/pull/34.patch","issue_url":"https://api.github.com/repos/palantir/sigma.js/issues/34","number":34,"state":"open","locked":false,"title":"SVG image logic to update when image settings are changed","user":{"login":"qinfchen","id":8294715,"avatar_url":"https://avatars.githubusercontent.com/u/8294715?v=3","gravatar_id":"","url":"https://api.github.com/users/qinfchen","html_url":"https://github.com/qinfchen","followers_url":"https://api.github.com/users/qinfchen/followers","following_url":"https://api.github.com/users/qinfchen/following{/other_user}","gists_url":"https://api.github.com/users/qinfchen/gists{/gist_id}","starred_url":"https://api.github.com/users/qinfchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinfchen/subscriptions","organizations_url":"https://api.github.com/users/qinfchen/orgs","repos_url":"https://api.github.com/users/qinfchen/repos","events_url":"https://api.github.com/users/qinfchen/events{/privacy}","received_events_url":"https://api.github.com/users/qinfchen/received_events","type":"User","site_admin":false},"body":"Currently, it draws the image when a new renderer gets instantiated. If\r\nwe decide to remove the image property from a node, the nodes won't\r\nreflect the change until they are recreated.","created_at":"2015-02-11T15:43:39Z","updated_at":"2015-02-12T23:07:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb3115bebcd04e0bed727c1cc8c3605eb3749ab7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/palantir/sigma.js/pulls/34/commits","review_comments_url":"https://api.github.com/repos/palantir/sigma.js/pulls/34/comments","review_comment_url":"https://api.github.com/repos/palantir/sigma.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/palantir/sigma.js/issues/34/comments","statuses_url":"https://api.github.com/repos/palantir/sigma.js/statuses/e885a0324e6563dcd08198b758c71452552ac318","head":{"label":"qinfchen:icon","ref":"icon","sha":"e885a0324e6563dcd08198b758c71452552ac318","user":{"login":"qinfchen","id":8294715,"avatar_url":"https://avatars.githubusercontent.com/u/8294715?v=3","gravatar_id":"","url":"https://api.github.com/users/qinfchen","html_url":"https://github.com/qinfchen","followers_url":"https://api.github.com/users/qinfchen/followers","following_url":"https://api.github.com/users/qinfchen/following{/other_user}","gists_url":"https://api.github.com/users/qinfchen/gists{/gist_id}","starred_url":"https://api.github.com/users/qinfchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinfchen/subscriptions","organizations_url":"https://api.github.com/users/qinfchen/orgs","repos_url":"https://api.github.com/users/qinfchen/repos","events_url":"https://api.github.com/users/qinfchen/events{/privacy}","received_events_url":"https://api.github.com/users/qinfchen/received_events","type":"User","site_admin":false},"repo":{"id":26418846,"name":"sigma.js","full_name":"qinfchen/sigma.js","owner":{"login":"qinfchen","id":8294715,"avatar_url":"https://avatars.githubusercontent.com/u/8294715?v=3","gravatar_id":"","url":"https://api.github.com/users/qinfchen","html_url":"https://github.com/qinfchen","followers_url":"https://api.github.com/users/qinfchen/followers","following_url":"https://api.github.com/users/qinfchen/following{/other_user}","gists_url":"https://api.github.com/users/qinfchen/gists{/gist_id}","starred_url":"https://api.github.com/users/qinfchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinfchen/subscriptions","organizations_url":"https://api.github.com/users/qinfchen/orgs","repos_url":"https://api.github.com/users/qinfchen/repos","events_url":"https://api.github.com/users/qinfchen/events{/privacy}","received_events_url":"https://api.github.com/users/qinfchen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qinfchen/sigma.js","description":"A JavaScript library dedicated to graph drawing","fork":true,"url":"https://api.github.com/repos/qinfchen/sigma.js","forks_url":"https://api.github.com/repos/qinfchen/sigma.js/forks","keys_url":"https://api.github.com/repos/qinfchen/sigma.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qinfchen/sigma.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qinfchen/sigma.js/teams","hooks_url":"https://api.github.com/repos/qinfchen/sigma.js/hooks","issue_events_url":"https://api.github.com/repos/qinfchen/sigma.js/issues/events{/number}","events_url":"https://api.github.com/repos/qinfchen/sigma.js/events","assignees_url":"https://api.github.com/repos/qinfchen/sigma.js/assignees{/user}","branches_url":"https://api.github.com/repos/qinfchen/sigma.js/branches{/branch}","tags_url":"https://api.github.com/repos/qinfchen/sigma.js/tags","blobs_url":"https://api.github.com/repos/qinfchen/sigma.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qinfchen/sigma.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qinfchen/sigma.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/qinfchen/sigma.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qinfchen/sigma.js/statuses/{sha}","languages_url":"https://api.github.com/repos/qinfchen/sigma.js/languages","stargazers_url":"https://api.github.com/repos/qinfchen/sigma.js/stargazers","contributors_url":"https://api.github.com/repos/qinfchen/sigma.js/contributors","subscribers_url":"https://api.github.com/repos/qinfchen/sigma.js/subscribers","subscription_url":"https://api.github.com/repos/qinfchen/sigma.js/subscription","commits_url":"https://api.github.com/repos/qinfchen/sigma.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/qinfchen/sigma.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/qinfchen/sigma.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/qinfchen/sigma.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/qinfchen/sigma.js/contents/{+path}","compare_url":"https://api.github.com/repos/qinfchen/sigma.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qinfchen/sigma.js/merges","archive_url":"https://api.github.com/repos/qinfchen/sigma.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qinfchen/sigma.js/downloads","issues_url":"https://api.github.com/repos/qinfchen/sigma.js/issues{/number}","pulls_url":"https://api.github.com/repos/qinfchen/sigma.js/pulls{/number}","milestones_url":"https://api.github.com/repos/qinfchen/sigma.js/milestones{/number}","notifications_url":"https://api.github.com/repos/qinfchen/sigma.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qinfchen/sigma.js/labels{/name}","releases_url":"https://api.github.com/repos/qinfchen/sigma.js/releases{/id}","created_at":"2014-11-10T03:06:55Z","updated_at":"2015-01-29T21:14:55Z","pushed_at":"2015-02-12T21:13:58Z","git_url":"git://github.com/qinfchen/sigma.js.git","ssh_url":"git@github.com:qinfchen/sigma.js.git","clone_url":"https://github.com/qinfchen/sigma.js.git","svn_url":"https://github.com/qinfchen/sigma.js","homepage":"http://sigmajs.org","size":3184,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"palantir:develop","ref":"develop","sha":"e8d63d7ae828f4ac4a7f95742cd25b22785986ae","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":29687708,"name":"sigma.js","full_name":"palantir/sigma.js","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/sigma.js","description":"A JavaScript library dedicated to graph drawing","fork":true,"url":"https://api.github.com/repos/palantir/sigma.js","forks_url":"https://api.github.com/repos/palantir/sigma.js/forks","keys_url":"https://api.github.com/repos/palantir/sigma.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/sigma.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/sigma.js/teams","hooks_url":"https://api.github.com/repos/palantir/sigma.js/hooks","issue_events_url":"https://api.github.com/repos/palantir/sigma.js/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/sigma.js/events","assignees_url":"https://api.github.com/repos/palantir/sigma.js/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/sigma.js/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/sigma.js/tags","blobs_url":"https://api.github.com/repos/palantir/sigma.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/sigma.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/sigma.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/sigma.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/sigma.js/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/sigma.js/languages","stargazers_url":"https://api.github.com/repos/palantir/sigma.js/stargazers","contributors_url":"https://api.github.com/repos/palantir/sigma.js/contributors","subscribers_url":"https://api.github.com/repos/palantir/sigma.js/subscribers","subscription_url":"https://api.github.com/repos/palantir/sigma.js/subscription","commits_url":"https://api.github.com/repos/palantir/sigma.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/sigma.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/sigma.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/sigma.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/palantir/sigma.js/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/sigma.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/sigma.js/merges","archive_url":"https://api.github.com/repos/palantir/sigma.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/sigma.js/downloads","issues_url":"https://api.github.com/repos/palantir/sigma.js/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/sigma.js/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/sigma.js/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/sigma.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/sigma.js/labels{/name}","releases_url":"https://api.github.com/repos/palantir/sigma.js/releases{/id}","created_at":"2015-01-22T16:20:36Z","updated_at":"2015-02-02T16:37:47Z","pushed_at":"2015-02-11T17:22:47Z","git_url":"git://github.com/palantir/sigma.js.git","ssh_url":"git@github.com:palantir/sigma.js.git","clone_url":"https://github.com/palantir/sigma.js.git","svn_url":"https://github.com/palantir/sigma.js","homepage":"http://sigmajs.org","size":3242,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/sigma.js/pulls/34"},"html":{"href":"https://github.com/palantir/sigma.js/pull/34"},"issue":{"href":"https://api.github.com/repos/palantir/sigma.js/issues/34"},"comments":{"href":"https://api.github.com/repos/palantir/sigma.js/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/sigma.js/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/sigma.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/palantir/sigma.js/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/sigma.js/statuses/e885a0324e6563dcd08198b758c71452552ac318"}}}}