{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/facebook-python-ads-sdk/issues/58","labels_url":"https://api.github.com/repos/facebook/facebook-python-ads-sdk/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/facebook/facebook-python-ads-sdk/issues/58/comments","events_url":"https://api.github.com/repos/facebook/facebook-python-ads-sdk/issues/58/events","html_url":"https://github.com/facebook/facebook-python-ads-sdk/issues/58","id":74044400,"number":58,"title":"filename param for AdImage","user":{"login":"tomako","id":1412056,"avatar_url":"https://avatars.githubusercontent.com/u/1412056?v=3","gravatar_id":"","url":"https://api.github.com/users/tomako","html_url":"https://github.com/tomako","followers_url":"https://api.github.com/users/tomako/followers","following_url":"https://api.github.com/users/tomako/following{/other_user}","gists_url":"https://api.github.com/users/tomako/gists{/gist_id}","starred_url":"https://api.github.com/users/tomako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomako/subscriptions","organizations_url":"https://api.github.com/users/tomako/orgs","repos_url":"https://api.github.com/users/tomako/repos","events_url":"https://api.github.com/users/tomako/events{/privacy}","received_events_url":"https://api.github.com/users/tomako/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-05-07T16:23:27Z","updated_at":"2015-05-08T13:08:33Z","closed_at":null,"body":"`filename` is definitely a string containing path and name. But sometimes it would be useful passing just a file-like object because we have the file only in memory. We could modify the methods to process also file object but the parameter's name is still `filename`. So it could be misleading.\r\nAny suggestion?"},"comment":{"url":"https://api.github.com/repos/facebook/facebook-python-ads-sdk/issues/comments/100226555","html_url":"https://github.com/facebook/facebook-python-ads-sdk/issues/58#issuecomment-100226555","issue_url":"https://api.github.com/repos/facebook/facebook-python-ads-sdk/issues/58","id":100226555,"user":{"login":"tomako","id":1412056,"avatar_url":"https://avatars.githubusercontent.com/u/1412056?v=3","gravatar_id":"","url":"https://api.github.com/users/tomako","html_url":"https://github.com/tomako","followers_url":"https://api.github.com/users/tomako/followers","following_url":"https://api.github.com/users/tomako/following{/other_user}","gists_url":"https://api.github.com/users/tomako/gists{/gist_id}","starred_url":"https://api.github.com/users/tomako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomako/subscriptions","organizations_url":"https://api.github.com/users/tomako/orgs","repos_url":"https://api.github.com/users/tomako/repos","events_url":"https://api.github.com/users/tomako/events{/privacy}","received_events_url":"https://api.github.com/users/tomako/received_events","type":"User","site_admin":false},"created_at":"2015-05-08T13:08:33Z","updated_at":"2015-05-08T13:08:33Z","body":"Hah, for all my caveats I just spotted in the standard lib that `ZipFile` has a `file` parameter and the description is suprisingly *\"`file` can be either a path to a file (a string) or a file-like object\"*. I don't fight :)"}}