{"action":"created","issue":{"url":"https://api.github.com/repos/FAForever/fafbot/issues/8","labels_url":"https://api.github.com/repos/FAForever/fafbot/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/FAForever/fafbot/issues/8/comments","events_url":"https://api.github.com/repos/FAForever/fafbot/issues/8/events","html_url":"https://github.com/FAForever/fafbot/issues/8","id":60009980,"number":8,"title":"Use the Python package manager infrastructure","user":{"login":"JeroenDeDauw","id":146040,"avatar_url":"https://avatars.githubusercontent.com/u/146040?v=3","gravatar_id":"","url":"https://api.github.com/users/JeroenDeDauw","html_url":"https://github.com/JeroenDeDauw","followers_url":"https://api.github.com/users/JeroenDeDauw/followers","following_url":"https://api.github.com/users/JeroenDeDauw/following{/other_user}","gists_url":"https://api.github.com/users/JeroenDeDauw/gists{/gist_id}","starred_url":"https://api.github.com/users/JeroenDeDauw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeroenDeDauw/subscriptions","organizations_url":"https://api.github.com/users/JeroenDeDauw/orgs","repos_url":"https://api.github.com/users/JeroenDeDauw/repos","events_url":"https://api.github.com/users/JeroenDeDauw/events{/privacy}","received_events_url":"https://api.github.com/users/JeroenDeDauw/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-05T20:21:55Z","updated_at":"2015-03-31T04:21:50Z","closed_at":"2015-03-31T04:16:45Z","body":"This repository appears to mostly contain dependencies for the actual FAFbot, in the form of copied code. This is problematic in several ways, amongst which:\r\n\r\n* It is not entirely obvious what code is external and what is part of FAFbot\r\n* It is not easy to tell if there are modifications to the external code that we made and require\r\n* It is not obvious which versions of the external code are used\r\n* It is harder to upgrade the external code\r\n\r\nNot being familiar with this code and not having done Python in a long time, it seems to me that these are external code:\r\n\r\n* ircbot.py (rather obvious this one)\r\n* the whole trueSkill directory\r\n* the whole irc directory (I'm guessing, and hoping, this is a library)\r\n\r\nAn additional problem is that the required version of Python and any additional system dependencies are not specified anywhere. That problem can also be solved by adding this information to the README, as per #5"},"comment":{"url":"https://api.github.com/repos/FAForever/fafbot/issues/comments/87931933","html_url":"https://github.com/FAForever/fafbot/issues/8#issuecomment-87931933","issue_url":"https://api.github.com/repos/FAForever/fafbot/issues/8","id":87931933,"user":{"login":"Sheeo","id":37968,"avatar_url":"https://avatars.githubusercontent.com/u/37968?v=3","gravatar_id":"","url":"https://api.github.com/users/Sheeo","html_url":"https://github.com/Sheeo","followers_url":"https://api.github.com/users/Sheeo/followers","following_url":"https://api.github.com/users/Sheeo/following{/other_user}","gists_url":"https://api.github.com/users/Sheeo/gists{/gist_id}","starred_url":"https://api.github.com/users/Sheeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sheeo/subscriptions","organizations_url":"https://api.github.com/users/Sheeo/orgs","repos_url":"https://api.github.com/users/Sheeo/repos","events_url":"https://api.github.com/users/Sheeo/events{/privacy}","received_events_url":"https://api.github.com/users/Sheeo/received_events","type":"User","site_admin":false},"created_at":"2015-03-31T04:21:49Z","updated_at":"2015-03-31T04:21:49Z","body":"If you reference the issue from a commit with \"Fixes\" or \"Closes\", it will automatically get closed when the commit hits master"}}