{"action":"created","issue":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/703","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/703/labels{/name}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/703/comments","events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/703/events","html_url":"https://github.com/mixxxdj/mixxx/pull/703","id":105475503,"number":703,"title":"Contrl object slave direct","user":{"login":"daschuer","id":1777442,"avatar_url":"https://avatars.githubusercontent.com/u/1777442?v=3","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-08T21:41:11Z","updated_at":"2015-09-09T18:47:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/703","html_url":"https://github.com/mixxxdj/mixxx/pull/703","diff_url":"https://github.com/mixxxdj/mixxx/pull/703.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/703.patch"},"body":"This should Fix Bug https://bugs.launchpad.net/mixxx/+bug/1406124\r\n\r\nI have changed the internal signal/slot connection according to the requested connection, like that: \r\n* connectValueChanged Auto -> COP = Auto / SCO = Auto\r\n* connectValueChanged Direct -> COP = Direct / SCO = Direct\r\n* connectValueChanged Queued -> COP = Auto / SCO = Queued\r\n* connectValueChanged BlockingQueued -> Assert(false)\r\n\r\nI have also reviewed all occurrence of ControlObjectSlave and it should work now. \r\n\r\nI have removed  most manual deletes and scoped pointer in favour of the Qt Object tree delete feature. This offers the best safety since the COS is deleted by its parent object, from which it usually inherits the event queue as well. \r\n\r\nTODO: The deprecated ControlObjectThread suffers the same issue. I think we need to replace it with ControlObjectSlaves.\r\n\r\n\r\n  "},"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/139003315","html_url":"https://github.com/mixxxdj/mixxx/pull/703#issuecomment-139003315","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/703","id":139003315,"user":{"login":"ywwg","id":888940,"avatar_url":"https://avatars.githubusercontent.com/u/888940?v=3","gravatar_id":"","url":"https://api.github.com/users/ywwg","html_url":"https://github.com/ywwg","followers_url":"https://api.github.com/users/ywwg/followers","following_url":"https://api.github.com/users/ywwg/following{/other_user}","gists_url":"https://api.github.com/users/ywwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ywwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywwg/subscriptions","organizations_url":"https://api.github.com/users/ywwg/orgs","repos_url":"https://api.github.com/users/ywwg/repos","events_url":"https://api.github.com/users/ywwg/events{/privacy}","received_events_url":"https://api.github.com/users/ywwg/received_events","type":"User","site_admin":false},"created_at":"2015-09-09T18:47:47Z","updated_at":"2015-09-09T18:47:47Z","body":"This is targeted at master but you say you're waiting on this for the shoutcast fix which is needed for 1.12.  Is your work on the shoutcast fix meant for master?  If so, then is the existing fix good enough for 1.12?  We need a solution for 1.12 so that shoutcast is at least workable for long-lived streams, even if it's not a perfect solution"}}