{"action":"created","issue":{"url":"https://api.github.com/repos/emberjs/ember.js/issues/12619","labels_url":"https://api.github.com/repos/emberjs/ember.js/issues/12619/labels{/name}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/12619/comments","events_url":"https://api.github.com/repos/emberjs/ember.js/issues/12619/events","html_url":"https://github.com/emberjs/ember.js/pull/12619","id":117217149,"number":12619,"title":"[DOC release] Add example and clear up wording for CP get/set","user":{"login":"SaladFork","id":107798,"avatar_url":"https://avatars.githubusercontent.com/u/107798?v=3","gravatar_id":"","url":"https://api.github.com/users/SaladFork","html_url":"https://github.com/SaladFork","followers_url":"https://api.github.com/users/SaladFork/followers","following_url":"https://api.github.com/users/SaladFork/following{/other_user}","gists_url":"https://api.github.com/users/SaladFork/gists{/gist_id}","starred_url":"https://api.github.com/users/SaladFork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaladFork/subscriptions","organizations_url":"https://api.github.com/users/SaladFork/orgs","repos_url":"https://api.github.com/users/SaladFork/repos","events_url":"https://api.github.com/users/SaladFork/events{/privacy}","received_events_url":"https://api.github.com/users/SaladFork/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-16T21:02:59Z","updated_at":"2015-11-16T22:44:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/12619","html_url":"https://github.com/emberjs/ember.js/pull/12619","diff_url":"https://github.com/emberjs/ember.js/pull/12619.diff","patch_url":"https://github.com/emberjs/ember.js/pull/12619.patch"},"body":"This PR makes the following changes to `Ember.computed` API documentation:\r\n - Changes the `fullName` getter function to match [the example in the latest guides](http://guides.emberjs.com/v2.1.0/object-model/computed-properties/). This involved changing to a template string from a string concatenation.\r\n - Switches class property default values to be defined in `init()` instead ([suggested](https://github.com/emberjs/ember.js/pull/12619#discussion_r44983617))\r\n - Minor changes to wording and sentence structure, mostly adding articles.\r\n - Adds an example that uses the hash format with `get` and `set`\r\n - Removes confusing/incorrect phrase:\r\n\r\n > The `get` function should accept two parameters, `key` and `value`.\r\n\r\nMy one concern is that the two examples are very similar except for a few lines. Would it be more helpful if the second example only included the computed property (rather than the whole class and usage example)?"},"comment":{"url":"https://api.github.com/repos/emberjs/ember.js/issues/comments/157196530","html_url":"https://github.com/emberjs/ember.js/pull/12619#issuecomment-157196530","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/12619","id":157196530,"user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"created_at":"2015-11-16T22:44:15Z","updated_at":"2015-11-16T22:44:15Z","body":"@homu r+"}}