{"action":"created","issue":{"url":"https://api.github.com/repos/solettaproject/soletta/issues/141","labels_url":"https://api.github.com/repos/solettaproject/soletta/issues/141/labels{/name}","comments_url":"https://api.github.com/repos/solettaproject/soletta/issues/141/comments","events_url":"https://api.github.com/repos/solettaproject/soletta/issues/141/events","html_url":"https://github.com/solettaproject/soletta/pull/141","id":91954853,"number":141,"title":"[v1] pthread: fix building with or without pthread support","user":{"login":"ulissesf","id":2476277,"avatar_url":"https://avatars.githubusercontent.com/u/2476277?v=3","gravatar_id":"","url":"https://api.github.com/users/ulissesf","html_url":"https://github.com/ulissesf","followers_url":"https://api.github.com/users/ulissesf/followers","following_url":"https://api.github.com/users/ulissesf/following{/other_user}","gists_url":"https://api.github.com/users/ulissesf/gists{/gist_id}","starred_url":"https://api.github.com/users/ulissesf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulissesf/subscriptions","organizations_url":"https://api.github.com/users/ulissesf/orgs","repos_url":"https://api.github.com/users/ulissesf/repos","events_url":"https://api.github.com/users/ulissesf/events{/privacy}","received_events_url":"https://api.github.com/users/ulissesf/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-30T01:53:02Z","updated_at":"2015-06-30T18:00:27Z","closed_at":"2015-06-30T18:00:27Z","pull_request":{"url":"https://api.github.com/repos/solettaproject/soletta/pulls/141","html_url":"https://github.com/solettaproject/soletta/pull/141","diff_url":"https://github.com/solettaproject/soletta/pull/141.diff","patch_url":"https://github.com/solettaproject/soletta/pull/141.patch"},"body":"When some dependency checks were removed the pthread one went from\r\nPTHREAD_H to PTHREAD and thus breaking the build.\r\n\r\nHowever, the bigger problem is that we were always compiling with\r\npthread support because the dependency solver always defines\r\nHAVE_PTHREAD_H even when we mark the config option PTHREAD as 'n'.\r\nPreviously autotools defined HAVE_PTHREAD_H when we had pthread.h\r\n_and_ wanted to compile with pthreads support. Now that's not the\r\ncase anymore with Kbuild so we should test for PTHREAD in the code\r\nand not HAVE_PTHREAD_H.\r\n\r\nNote that the ldflags still need to be properly sorted out even though\r\neverything compiles and works now."},"comment":{"url":"https://api.github.com/repos/solettaproject/soletta/issues/comments/117284104","html_url":"https://github.com/solettaproject/soletta/pull/141#issuecomment-117284104","issue_url":"https://api.github.com/repos/solettaproject/soletta/issues/141","id":117284104,"user":{"login":"dorileo","id":960327,"avatar_url":"https://avatars.githubusercontent.com/u/960327?v=3","gravatar_id":"","url":"https://api.github.com/users/dorileo","html_url":"https://github.com/dorileo","followers_url":"https://api.github.com/users/dorileo/followers","following_url":"https://api.github.com/users/dorileo/following{/other_user}","gists_url":"https://api.github.com/users/dorileo/gists{/gist_id}","starred_url":"https://api.github.com/users/dorileo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dorileo/subscriptions","organizations_url":"https://api.github.com/users/dorileo/orgs","repos_url":"https://api.github.com/users/dorileo/repos","events_url":"https://api.github.com/users/dorileo/events{/privacy}","received_events_url":"https://api.github.com/users/dorileo/received_events","type":"User","site_admin":false},"created_at":"2015-06-30T18:00:27Z","updated_at":"2015-06-30T18:00:27Z","body":"this patch was applied via pull req https://github.com/solettaproject/soletta/pull/149"}}