{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/source-map/pulls/comments/26267880","id":26267880,"diff_hunk":"@@ -583,6 +583,34 @@ define(function (require, exports, module) {\n     assert.equal(mappings.length, 0);\n   };\n \n+  exports['test allGeneratedPositionsFor for position with multiple mappings'] = function (assert, util) {","path":"test/source-map/test-source-map-consumer.js","position":22,"original_position":22,"commit_id":"134bc47bd8e1cf233b71fd3f158f60a06451f06a","original_commit_id":"134bc47bd8e1cf233b71fd3f158f60a06451f06a","user":{"login":"fitzgen","id":74571,"avatar_url":"https://avatars.githubusercontent.com/u/74571?v=3","gravatar_id":"","url":"https://api.github.com/users/fitzgen","html_url":"https://github.com/fitzgen","followers_url":"https://api.github.com/users/fitzgen/followers","following_url":"https://api.github.com/users/fitzgen/following{/other_user}","gists_url":"https://api.github.com/users/fitzgen/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzgen/subscriptions","organizations_url":"https://api.github.com/users/fitzgen/orgs","repos_url":"https://api.github.com/users/fitzgen/repos","events_url":"https://api.github.com/users/fitzgen/events{/privacy}","received_events_url":"https://api.github.com/users/fitzgen/received_events","type":"User","site_admin":false},"body":"This adds tests for multiple mappings for a single generated position, however there are no tests for passing a column into `allGeneratedPositionsFor`. Please add tests for that.\r\n\r\nAlso, how is the column parameter expected to interact with the fuzzy searching? Please add a test for this case as well.","created_at":"2015-03-11T23:55:33Z","updated_at":"2015-03-11T23:55:33Z","html_url":"https://github.com/mozilla/source-map/pull/173#discussion_r26267880","pull_request_url":"https://api.github.com/repos/mozilla/source-map/pulls/173","_links":{"self":{"href":"https://api.github.com/repos/mozilla/source-map/pulls/comments/26267880"},"html":{"href":"https://github.com/mozilla/source-map/pull/173#discussion_r26267880"},"pull_request":{"href":"https://api.github.com/repos/mozilla/source-map/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/source-map/pulls/173","id":30963018,"html_url":"https://github.com/mozilla/source-map/pull/173","diff_url":"https://github.com/mozilla/source-map/pull/173.diff","patch_url":"https://github.com/mozilla/source-map/pull/173.patch","issue_url":"https://api.github.com/repos/mozilla/source-map/issues/173","number":173,"state":"open","locked":false,"title":"Add a column argument to allGeneratedPositionsFor.","user":{"login":"ejpbruel","id":186111,"avatar_url":"https://avatars.githubusercontent.com/u/186111?v=3","gravatar_id":"","url":"https://api.github.com/users/ejpbruel","html_url":"https://github.com/ejpbruel","followers_url":"https://api.github.com/users/ejpbruel/followers","following_url":"https://api.github.com/users/ejpbruel/following{/other_user}","gists_url":"https://api.github.com/users/ejpbruel/gists{/gist_id}","starred_url":"https://api.github.com/users/ejpbruel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejpbruel/subscriptions","organizations_url":"https://api.github.com/users/ejpbruel/orgs","repos_url":"https://api.github.com/users/ejpbruel/repos","events_url":"https://api.github.com/users/ejpbruel/events{/privacy}","received_events_url":"https://api.github.com/users/ejpbruel/received_events","type":"User","site_admin":false},"body":"Some source maps define multiple mappings for a single original column. We need\r\na way to obtain all mappings for a given column, instead of just the first one.\r\nThis patch refactors allGeneratedPositionsFor so that it returns all mappings\r\nfor a single line if no column argument is passed (not necessarily the line that\r\nwas requested, due to fuzzy search), and all mappings for a single line and\r\ncolumn otherwise.","created_at":"2015-03-11T16:59:50Z","updated_at":"2015-03-11T23:55:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef11b6c651b6be5d32576b5c59c0b81d6194c64d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/source-map/pulls/173/commits","review_comments_url":"https://api.github.com/repos/mozilla/source-map/pulls/173/comments","review_comment_url":"https://api.github.com/repos/mozilla/source-map/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/source-map/issues/173/comments","statuses_url":"https://api.github.com/repos/mozilla/source-map/statuses/134bc47bd8e1cf233b71fd3f158f60a06451f06a","head":{"label":"ejpbruel:column","ref":"column","sha":"134bc47bd8e1cf233b71fd3f158f60a06451f06a","user":{"login":"ejpbruel","id":186111,"avatar_url":"https://avatars.githubusercontent.com/u/186111?v=3","gravatar_id":"","url":"https://api.github.com/users/ejpbruel","html_url":"https://github.com/ejpbruel","followers_url":"https://api.github.com/users/ejpbruel/followers","following_url":"https://api.github.com/users/ejpbruel/following{/other_user}","gists_url":"https://api.github.com/users/ejpbruel/gists{/gist_id}","starred_url":"https://api.github.com/users/ejpbruel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejpbruel/subscriptions","organizations_url":"https://api.github.com/users/ejpbruel/orgs","repos_url":"https://api.github.com/users/ejpbruel/repos","events_url":"https://api.github.com/users/ejpbruel/events{/privacy}","received_events_url":"https://api.github.com/users/ejpbruel/received_events","type":"User","site_admin":false},"repo":{"id":26794859,"name":"source-map","full_name":"ejpbruel/source-map","owner":{"login":"ejpbruel","id":186111,"avatar_url":"https://avatars.githubusercontent.com/u/186111?v=3","gravatar_id":"","url":"https://api.github.com/users/ejpbruel","html_url":"https://github.com/ejpbruel","followers_url":"https://api.github.com/users/ejpbruel/followers","following_url":"https://api.github.com/users/ejpbruel/following{/other_user}","gists_url":"https://api.github.com/users/ejpbruel/gists{/gist_id}","starred_url":"https://api.github.com/users/ejpbruel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejpbruel/subscriptions","organizations_url":"https://api.github.com/users/ejpbruel/orgs","repos_url":"https://api.github.com/users/ejpbruel/repos","events_url":"https://api.github.com/users/ejpbruel/events{/privacy}","received_events_url":"https://api.github.com/users/ejpbruel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ejpbruel/source-map","description":"Parse and consume source maps.","fork":true,"url":"https://api.github.com/repos/ejpbruel/source-map","forks_url":"https://api.github.com/repos/ejpbruel/source-map/forks","keys_url":"https://api.github.com/repos/ejpbruel/source-map/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ejpbruel/source-map/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ejpbruel/source-map/teams","hooks_url":"https://api.github.com/repos/ejpbruel/source-map/hooks","issue_events_url":"https://api.github.com/repos/ejpbruel/source-map/issues/events{/number}","events_url":"https://api.github.com/repos/ejpbruel/source-map/events","assignees_url":"https://api.github.com/repos/ejpbruel/source-map/assignees{/user}","branches_url":"https://api.github.com/repos/ejpbruel/source-map/branches{/branch}","tags_url":"https://api.github.com/repos/ejpbruel/source-map/tags","blobs_url":"https://api.github.com/repos/ejpbruel/source-map/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ejpbruel/source-map/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ejpbruel/source-map/git/refs{/sha}","trees_url":"https://api.github.com/repos/ejpbruel/source-map/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ejpbruel/source-map/statuses/{sha}","languages_url":"https://api.github.com/repos/ejpbruel/source-map/languages","stargazers_url":"https://api.github.com/repos/ejpbruel/source-map/stargazers","contributors_url":"https://api.github.com/repos/ejpbruel/source-map/contributors","subscribers_url":"https://api.github.com/repos/ejpbruel/source-map/subscribers","subscription_url":"https://api.github.com/repos/ejpbruel/source-map/subscription","commits_url":"https://api.github.com/repos/ejpbruel/source-map/commits{/sha}","git_commits_url":"https://api.github.com/repos/ejpbruel/source-map/git/commits{/sha}","comments_url":"https://api.github.com/repos/ejpbruel/source-map/comments{/number}","issue_comment_url":"https://api.github.com/repos/ejpbruel/source-map/issues/comments{/number}","contents_url":"https://api.github.com/repos/ejpbruel/source-map/contents/{+path}","compare_url":"https://api.github.com/repos/ejpbruel/source-map/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ejpbruel/source-map/merges","archive_url":"https://api.github.com/repos/ejpbruel/source-map/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ejpbruel/source-map/downloads","issues_url":"https://api.github.com/repos/ejpbruel/source-map/issues{/number}","pulls_url":"https://api.github.com/repos/ejpbruel/source-map/pulls{/number}","milestones_url":"https://api.github.com/repos/ejpbruel/source-map/milestones{/number}","notifications_url":"https://api.github.com/repos/ejpbruel/source-map/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ejpbruel/source-map/labels{/name}","releases_url":"https://api.github.com/repos/ejpbruel/source-map/releases{/id}","created_at":"2014-11-18T06:16:26Z","updated_at":"2015-03-02T09:19:29Z","pushed_at":"2015-03-10T15:50:13Z","git_url":"git://github.com/ejpbruel/source-map.git","ssh_url":"git@github.com:ejpbruel/source-map.git","clone_url":"https://github.com/ejpbruel/source-map.git","svn_url":"https://github.com/ejpbruel/source-map","homepage":"https://wiki.mozilla.org/DevTools","size":2818,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"fab2520116a34c6607c396a082557f59b4db842c","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":2014930,"name":"source-map","full_name":"mozilla/source-map","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/source-map","description":"Parse and consume source maps.","fork":false,"url":"https://api.github.com/repos/mozilla/source-map","forks_url":"https://api.github.com/repos/mozilla/source-map/forks","keys_url":"https://api.github.com/repos/mozilla/source-map/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/source-map/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/source-map/teams","hooks_url":"https://api.github.com/repos/mozilla/source-map/hooks","issue_events_url":"https://api.github.com/repos/mozilla/source-map/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/source-map/events","assignees_url":"https://api.github.com/repos/mozilla/source-map/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/source-map/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/source-map/tags","blobs_url":"https://api.github.com/repos/mozilla/source-map/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/source-map/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/source-map/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/source-map/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/source-map/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/source-map/languages","stargazers_url":"https://api.github.com/repos/mozilla/source-map/stargazers","contributors_url":"https://api.github.com/repos/mozilla/source-map/contributors","subscribers_url":"https://api.github.com/repos/mozilla/source-map/subscribers","subscription_url":"https://api.github.com/repos/mozilla/source-map/subscription","commits_url":"https://api.github.com/repos/mozilla/source-map/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/source-map/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/source-map/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/source-map/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/source-map/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/source-map/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/source-map/merges","archive_url":"https://api.github.com/repos/mozilla/source-map/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/source-map/downloads","issues_url":"https://api.github.com/repos/mozilla/source-map/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/source-map/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/source-map/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/source-map/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/source-map/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/source-map/releases{/id}","created_at":"2011-07-07T22:07:39Z","updated_at":"2015-03-11T13:12:58Z","pushed_at":"2015-03-09T18:43:05Z","git_url":"git://github.com/mozilla/source-map.git","ssh_url":"git@github.com:mozilla/source-map.git","clone_url":"https://github.com/mozilla/source-map.git","svn_url":"https://github.com/mozilla/source-map","homepage":"https://wiki.mozilla.org/DevTools","size":3764,"stargazers_count":537,"watchers_count":537,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"open_issues_count":15,"forks":87,"open_issues":15,"watchers":537,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/source-map/pulls/173"},"html":{"href":"https://github.com/mozilla/source-map/pull/173"},"issue":{"href":"https://api.github.com/repos/mozilla/source-map/issues/173"},"comments":{"href":"https://api.github.com/repos/mozilla/source-map/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/source-map/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/source-map/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/source-map/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/source-map/statuses/134bc47bd8e1cf233b71fd3f158f60a06451f06a"}}}}