{"action":"closed","number":1226,"pull_request":{"url":"https://api.github.com/repos/riot/riot/pulls/1226","id":45324556,"html_url":"https://github.com/riot/riot/pull/1226","diff_url":"https://github.com/riot/riot/pull/1226.diff","patch_url":"https://github.com/riot/riot/pull/1226.patch","issue_url":"https://api.github.com/repos/riot/riot/issues/1226","number":1226,"state":"closed","locked":false,"title":"replace tag internal _id property with a Symbol","user":{"login":"sylvainpolletvillard","id":566536,"avatar_url":"https://avatars.githubusercontent.com/u/566536?v=3","gravatar_id":"","url":"https://api.github.com/users/sylvainpolletvillard","html_url":"https://github.com/sylvainpolletvillard","followers_url":"https://api.github.com/users/sylvainpolletvillard/followers","following_url":"https://api.github.com/users/sylvainpolletvillard/following{/other_user}","gists_url":"https://api.github.com/users/sylvainpolletvillard/gists{/gist_id}","starred_url":"https://api.github.com/users/sylvainpolletvillard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylvainpolletvillard/subscriptions","organizations_url":"https://api.github.com/users/sylvainpolletvillard/orgs","repos_url":"https://api.github.com/users/sylvainpolletvillard/repos","events_url":"https://api.github.com/users/sylvainpolletvillard/events{/privacy}","received_events_url":"https://api.github.com/users/sylvainpolletvillard/received_events","type":"User","site_admin":false},"body":"This PR replace tag internal _id property with an ES6 Symbol to prevent name conflicts. \r\nIt fixes issue https://github.com/riot/riot/issues/1181\r\n\r\nSymbols as keys of properties are the best way to prevent any clash with user data. Symbols are already supported in Chrome, Firefox and Microsoft Edge. Also, it is really easy to provide a simple fallback to older browsers. The fallback I chose returns a String prefixed by ' \\_riot_', so that '_id' becomes '_riot_id' for the old grumpy Internet Explorer.\r\n\r\nSome unit tests for mixins were using this internal property _id, but when using Symbols this property is no longer exposed outside of Riot source. So I had to add a fixture in mocha tests that forces to use the fallback, which exposes _riot_id.\r\n\r\nThis does __not__ solve issue https://github.com/riot/riot/issues/1190 because these other blacklisted properties and methods are useful to the user, so we have to figure out something else for these.","created_at":"2015-09-17T18:28:06Z","updated_at":"2015-09-26T15:49:28Z","closed_at":"2015-09-26T15:49:28Z","merged_at":null,"merge_commit_sha":"9a6a6bdf834650a59e0e8b8a64bb461cec2fbbe3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/riot/riot/pulls/1226/commits","review_comments_url":"https://api.github.com/repos/riot/riot/pulls/1226/comments","review_comment_url":"https://api.github.com/repos/riot/riot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/riot/riot/issues/1226/comments","statuses_url":"https://api.github.com/repos/riot/riot/statuses/90897d233593ed39e76933d029f8a22281cec026","head":{"label":"sylvainpolletvillard:dev","ref":"dev","sha":"90897d233593ed39e76933d029f8a22281cec026","user":{"login":"sylvainpolletvillard","id":566536,"avatar_url":"https://avatars.githubusercontent.com/u/566536?v=3","gravatar_id":"","url":"https://api.github.com/users/sylvainpolletvillard","html_url":"https://github.com/sylvainpolletvillard","followers_url":"https://api.github.com/users/sylvainpolletvillard/followers","following_url":"https://api.github.com/users/sylvainpolletvillard/following{/other_user}","gists_url":"https://api.github.com/users/sylvainpolletvillard/gists{/gist_id}","starred_url":"https://api.github.com/users/sylvainpolletvillard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylvainpolletvillard/subscriptions","organizations_url":"https://api.github.com/users/sylvainpolletvillard/orgs","repos_url":"https://api.github.com/users/sylvainpolletvillard/repos","events_url":"https://api.github.com/users/sylvainpolletvillard/events{/privacy}","received_events_url":"https://api.github.com/users/sylvainpolletvillard/received_events","type":"User","site_admin":false},"repo":{"id":42615000,"name":"riot","full_name":"sylvainpolletvillard/riot","owner":{"login":"sylvainpolletvillard","id":566536,"avatar_url":"https://avatars.githubusercontent.com/u/566536?v=3","gravatar_id":"","url":"https://api.github.com/users/sylvainpolletvillard","html_url":"https://github.com/sylvainpolletvillard","followers_url":"https://api.github.com/users/sylvainpolletvillard/followers","following_url":"https://api.github.com/users/sylvainpolletvillard/following{/other_user}","gists_url":"https://api.github.com/users/sylvainpolletvillard/gists{/gist_id}","starred_url":"https://api.github.com/users/sylvainpolletvillard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylvainpolletvillard/subscriptions","organizations_url":"https://api.github.com/users/sylvainpolletvillard/orgs","repos_url":"https://api.github.com/users/sylvainpolletvillard/repos","events_url":"https://api.github.com/users/sylvainpolletvillard/events{/privacy}","received_events_url":"https://api.github.com/users/sylvainpolletvillard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sylvainpolletvillard/riot","description":"A React-like, user interface library","fork":true,"url":"https://api.github.com/repos/sylvainpolletvillard/riot","forks_url":"https://api.github.com/repos/sylvainpolletvillard/riot/forks","keys_url":"https://api.github.com/repos/sylvainpolletvillard/riot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sylvainpolletvillard/riot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sylvainpolletvillard/riot/teams","hooks_url":"https://api.github.com/repos/sylvainpolletvillard/riot/hooks","issue_events_url":"https://api.github.com/repos/sylvainpolletvillard/riot/issues/events{/number}","events_url":"https://api.github.com/repos/sylvainpolletvillard/riot/events","assignees_url":"https://api.github.com/repos/sylvainpolletvillard/riot/assignees{/user}","branches_url":"https://api.github.com/repos/sylvainpolletvillard/riot/branches{/branch}","tags_url":"https://api.github.com/repos/sylvainpolletvillard/riot/tags","blobs_url":"https://api.github.com/repos/sylvainpolletvillard/riot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sylvainpolletvillard/riot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sylvainpolletvillard/riot/git/refs{/sha}","trees_url":"https://api.github.com/repos/sylvainpolletvillard/riot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sylvainpolletvillard/riot/statuses/{sha}","languages_url":"https://api.github.com/repos/sylvainpolletvillard/riot/languages","stargazers_url":"https://api.github.com/repos/sylvainpolletvillard/riot/stargazers","contributors_url":"https://api.github.com/repos/sylvainpolletvillard/riot/contributors","subscribers_url":"https://api.github.com/repos/sylvainpolletvillard/riot/subscribers","subscription_url":"https://api.github.com/repos/sylvainpolletvillard/riot/subscription","commits_url":"https://api.github.com/repos/sylvainpolletvillard/riot/commits{/sha}","git_commits_url":"https://api.github.com/repos/sylvainpolletvillard/riot/git/commits{/sha}","comments_url":"https://api.github.com/repos/sylvainpolletvillard/riot/comments{/number}","issue_comment_url":"https://api.github.com/repos/sylvainpolletvillard/riot/issues/comments{/number}","contents_url":"https://api.github.com/repos/sylvainpolletvillard/riot/contents/{+path}","compare_url":"https://api.github.com/repos/sylvainpolletvillard/riot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sylvainpolletvillard/riot/merges","archive_url":"https://api.github.com/repos/sylvainpolletvillard/riot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sylvainpolletvillard/riot/downloads","issues_url":"https://api.github.com/repos/sylvainpolletvillard/riot/issues{/number}","pulls_url":"https://api.github.com/repos/sylvainpolletvillard/riot/pulls{/number}","milestones_url":"https://api.github.com/repos/sylvainpolletvillard/riot/milestones{/number}","notifications_url":"https://api.github.com/repos/sylvainpolletvillard/riot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sylvainpolletvillard/riot/labels{/name}","releases_url":"https://api.github.com/repos/sylvainpolletvillard/riot/releases{/id}","created_at":"2015-09-16T21:42:11Z","updated_at":"2015-09-16T21:42:12Z","pushed_at":"2015-09-17T18:15:14Z","git_url":"git://github.com/sylvainpolletvillard/riot.git","ssh_url":"git@github.com:sylvainpolletvillard/riot.git","clone_url":"https://github.com/sylvainpolletvillard/riot.git","svn_url":"https://github.com/sylvainpolletvillard/riot","homepage":"http://riotjs.com/","size":2563,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"riot:dev","ref":"dev","sha":"687751f747b8248595b38b38699ba981342766c6","user":{"login":"riot","id":12729373,"avatar_url":"https://avatars.githubusercontent.com/u/12729373?v=3","gravatar_id":"","url":"https://api.github.com/users/riot","html_url":"https://github.com/riot","followers_url":"https://api.github.com/users/riot/followers","following_url":"https://api.github.com/users/riot/following{/other_user}","gists_url":"https://api.github.com/users/riot/gists{/gist_id}","starred_url":"https://api.github.com/users/riot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riot/subscriptions","organizations_url":"https://api.github.com/users/riot/orgs","repos_url":"https://api.github.com/users/riot/repos","events_url":"https://api.github.com/users/riot/events{/privacy}","received_events_url":"https://api.github.com/users/riot/received_events","type":"Organization","site_admin":false},"repo":{"id":13142126,"name":"riot","full_name":"riot/riot","owner":{"login":"riot","id":12729373,"avatar_url":"https://avatars.githubusercontent.com/u/12729373?v=3","gravatar_id":"","url":"https://api.github.com/users/riot","html_url":"https://github.com/riot","followers_url":"https://api.github.com/users/riot/followers","following_url":"https://api.github.com/users/riot/following{/other_user}","gists_url":"https://api.github.com/users/riot/gists{/gist_id}","starred_url":"https://api.github.com/users/riot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riot/subscriptions","organizations_url":"https://api.github.com/users/riot/orgs","repos_url":"https://api.github.com/users/riot/repos","events_url":"https://api.github.com/users/riot/events{/privacy}","received_events_url":"https://api.github.com/users/riot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riot/riot","description":"A React-like, user interface library","fork":false,"url":"https://api.github.com/repos/riot/riot","forks_url":"https://api.github.com/repos/riot/riot/forks","keys_url":"https://api.github.com/repos/riot/riot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riot/riot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riot/riot/teams","hooks_url":"https://api.github.com/repos/riot/riot/hooks","issue_events_url":"https://api.github.com/repos/riot/riot/issues/events{/number}","events_url":"https://api.github.com/repos/riot/riot/events","assignees_url":"https://api.github.com/repos/riot/riot/assignees{/user}","branches_url":"https://api.github.com/repos/riot/riot/branches{/branch}","tags_url":"https://api.github.com/repos/riot/riot/tags","blobs_url":"https://api.github.com/repos/riot/riot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riot/riot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riot/riot/git/refs{/sha}","trees_url":"https://api.github.com/repos/riot/riot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riot/riot/statuses/{sha}","languages_url":"https://api.github.com/repos/riot/riot/languages","stargazers_url":"https://api.github.com/repos/riot/riot/stargazers","contributors_url":"https://api.github.com/repos/riot/riot/contributors","subscribers_url":"https://api.github.com/repos/riot/riot/subscribers","subscription_url":"https://api.github.com/repos/riot/riot/subscription","commits_url":"https://api.github.com/repos/riot/riot/commits{/sha}","git_commits_url":"https://api.github.com/repos/riot/riot/git/commits{/sha}","comments_url":"https://api.github.com/repos/riot/riot/comments{/number}","issue_comment_url":"https://api.github.com/repos/riot/riot/issues/comments{/number}","contents_url":"https://api.github.com/repos/riot/riot/contents/{+path}","compare_url":"https://api.github.com/repos/riot/riot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riot/riot/merges","archive_url":"https://api.github.com/repos/riot/riot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riot/riot/downloads","issues_url":"https://api.github.com/repos/riot/riot/issues{/number}","pulls_url":"https://api.github.com/repos/riot/riot/pulls{/number}","milestones_url":"https://api.github.com/repos/riot/riot/milestones{/number}","notifications_url":"https://api.github.com/repos/riot/riot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riot/riot/labels{/name}","releases_url":"https://api.github.com/repos/riot/riot/releases{/id}","created_at":"2013-09-27T05:21:01Z","updated_at":"2015-09-26T06:37:25Z","pushed_at":"2015-09-26T15:45:00Z","git_url":"git://github.com/riot/riot.git","ssh_url":"git@github.com:riot/riot.git","clone_url":"https://github.com/riot/riot.git","svn_url":"https://github.com/riot/riot","homepage":"http://riotjs.com/","size":7183,"stargazers_count":7362,"watchers_count":7362,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":628,"mirror_url":null,"open_issues_count":107,"forks":628,"open_issues":107,"watchers":7362,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/riot/riot/pulls/1226"},"html":{"href":"https://github.com/riot/riot/pull/1226"},"issue":{"href":"https://api.github.com/repos/riot/riot/issues/1226"},"comments":{"href":"https://api.github.com/repos/riot/riot/issues/1226/comments"},"review_comments":{"href":"https://api.github.com/repos/riot/riot/pulls/1226/comments"},"review_comment":{"href":"https://api.github.com/repos/riot/riot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/riot/riot/pulls/1226/commits"},"statuses":{"href":"https://api.github.com/repos/riot/riot/statuses/90897d233593ed39e76933d029f8a22281cec026"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":23,"deletions":16,"changed_files":6}}