{"action":"created","comment":{"url":"https://api.github.com/repos/uber/tchannel/pulls/comments/37531697","id":37531697,"diff_hunk":"@@ -0,0 +1,41 @@\n+// Copyright (c) 2015 Uber Technologies, Inc.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a copy\n+// of this software and associated documentation files (the \"Software\"), to deal\n+// in the Software without restriction, including without limitation the rights\n+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+// copies of the Software, and to permit persons to whom the Software is\n+// furnished to do so, subject to the following conditions:\n+//\n+// The above copyright notice and this permission notice shall be included in\n+// all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+// THE SOFTWARE.\n+\n+var TChannel = require('../index.js');\n+\n+var serverOptions = {host: '127.0.0.1', port: 4040, listening: false};\n+var serverName = serverOptions.host + ':' + serverOptions.port;","path":"test/listen-on-fd-child.js","position":24,"original_position":24,"commit_id":"7daeb1a3fcfbb039ef15405af7da38c6cdfe133e","original_commit_id":"7daeb1a3fcfbb039ef15405af7da38c6cdfe133e","user":{"login":"benfleis","id":2185001,"avatar_url":"https://avatars.githubusercontent.com/u/2185001?v=3","gravatar_id":"","url":"https://api.github.com/users/benfleis","html_url":"https://github.com/benfleis","followers_url":"https://api.github.com/users/benfleis/followers","following_url":"https://api.github.com/users/benfleis/following{/other_user}","gists_url":"https://api.github.com/users/benfleis/gists{/gist_id}","starred_url":"https://api.github.com/users/benfleis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfleis/subscriptions","organizations_url":"https://api.github.com/users/benfleis/orgs","repos_url":"https://api.github.com/users/benfleis/repos","events_url":"https://api.github.com/users/benfleis/events{/privacy}","received_events_url":"https://api.github.com/users/benfleis/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2015-08-20T13:58:36Z","updated_at":"2015-08-20T13:58:36Z","html_url":"https://github.com/uber/tchannel/pull/1174#discussion_r37531697","pull_request_url":"https://api.github.com/repos/uber/tchannel/pulls/1174","_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel/pulls/comments/37531697"},"html":{"href":"https://github.com/uber/tchannel/pull/1174#discussion_r37531697"},"pull_request":{"href":"https://api.github.com/repos/uber/tchannel/pulls/1174"}}},"pull_request":{"url":"https://api.github.com/repos/uber/tchannel/pulls/1174","id":42805693,"html_url":"https://github.com/uber/tchannel/pull/1174","diff_url":"https://github.com/uber/tchannel/pull/1174.diff","patch_url":"https://github.com/uber/tchannel/pull/1174.patch","issue_url":"https://api.github.com/repos/uber/tchannel/issues/1174","number":1174,"state":"open","locked":false,"title":"(v1.x) add support to listen on socket/fd, via options argument to","user":{"login":"benfleis","id":2185001,"avatar_url":"https://avatars.githubusercontent.com/u/2185001?v=3","gravatar_id":"","url":"https://api.github.com/users/benfleis","html_url":"https://github.com/benfleis","followers_url":"https://api.github.com/users/benfleis/followers","following_url":"https://api.github.com/users/benfleis/following{/other_user}","gists_url":"https://api.github.com/users/benfleis/gists{/gist_id}","starred_url":"https://api.github.com/users/benfleis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfleis/subscriptions","organizations_url":"https://api.github.com/users/benfleis/orgs","repos_url":"https://api.github.com/users/benfleis/repos","events_url":"https://api.github.com/users/benfleis/events{/privacy}","received_events_url":"https://api.github.com/users/benfleis/received_events","type":"User","site_admin":false},"body":".listen. conceptually identical to same patch for master (v2.x).\r\n\r\naddresses https://github.com/uber/tchannel/issues/1166","created_at":"2015-08-19T11:57:19Z","updated_at":"2015-08-20T13:58:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa655736b4e773d5e1a3baf96bca12d783ff5c21","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/tchannel/pulls/1174/commits","review_comments_url":"https://api.github.com/repos/uber/tchannel/pulls/1174/comments","review_comment_url":"https://api.github.com/repos/uber/tchannel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/tchannel/issues/1174/comments","statuses_url":"https://api.github.com/repos/uber/tchannel/statuses/7daeb1a3fcfbb039ef15405af7da38c6cdfe133e","head":{"label":"benfleis:feature/listen-on-fd-v1.x","ref":"feature/listen-on-fd-v1.x","sha":"7daeb1a3fcfbb039ef15405af7da38c6cdfe133e","user":{"login":"benfleis","id":2185001,"avatar_url":"https://avatars.githubusercontent.com/u/2185001?v=3","gravatar_id":"","url":"https://api.github.com/users/benfleis","html_url":"https://github.com/benfleis","followers_url":"https://api.github.com/users/benfleis/followers","following_url":"https://api.github.com/users/benfleis/following{/other_user}","gists_url":"https://api.github.com/users/benfleis/gists{/gist_id}","starred_url":"https://api.github.com/users/benfleis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfleis/subscriptions","organizations_url":"https://api.github.com/users/benfleis/orgs","repos_url":"https://api.github.com/users/benfleis/repos","events_url":"https://api.github.com/users/benfleis/events{/privacy}","received_events_url":"https://api.github.com/users/benfleis/received_events","type":"User","site_admin":false},"repo":{"id":40902336,"name":"tchannel","full_name":"benfleis/tchannel","owner":{"login":"benfleis","id":2185001,"avatar_url":"https://avatars.githubusercontent.com/u/2185001?v=3","gravatar_id":"","url":"https://api.github.com/users/benfleis","html_url":"https://github.com/benfleis","followers_url":"https://api.github.com/users/benfleis/followers","following_url":"https://api.github.com/users/benfleis/following{/other_user}","gists_url":"https://api.github.com/users/benfleis/gists{/gist_id}","starred_url":"https://api.github.com/users/benfleis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benfleis/subscriptions","organizations_url":"https://api.github.com/users/benfleis/orgs","repos_url":"https://api.github.com/users/benfleis/repos","events_url":"https://api.github.com/users/benfleis/events{/privacy}","received_events_url":"https://api.github.com/users/benfleis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benfleis/tchannel","description":"network multiplexing and framing protocol for RPC","fork":true,"url":"https://api.github.com/repos/benfleis/tchannel","forks_url":"https://api.github.com/repos/benfleis/tchannel/forks","keys_url":"https://api.github.com/repos/benfleis/tchannel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benfleis/tchannel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benfleis/tchannel/teams","hooks_url":"https://api.github.com/repos/benfleis/tchannel/hooks","issue_events_url":"https://api.github.com/repos/benfleis/tchannel/issues/events{/number}","events_url":"https://api.github.com/repos/benfleis/tchannel/events","assignees_url":"https://api.github.com/repos/benfleis/tchannel/assignees{/user}","branches_url":"https://api.github.com/repos/benfleis/tchannel/branches{/branch}","tags_url":"https://api.github.com/repos/benfleis/tchannel/tags","blobs_url":"https://api.github.com/repos/benfleis/tchannel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benfleis/tchannel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benfleis/tchannel/git/refs{/sha}","trees_url":"https://api.github.com/repos/benfleis/tchannel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benfleis/tchannel/statuses/{sha}","languages_url":"https://api.github.com/repos/benfleis/tchannel/languages","stargazers_url":"https://api.github.com/repos/benfleis/tchannel/stargazers","contributors_url":"https://api.github.com/repos/benfleis/tchannel/contributors","subscribers_url":"https://api.github.com/repos/benfleis/tchannel/subscribers","subscription_url":"https://api.github.com/repos/benfleis/tchannel/subscription","commits_url":"https://api.github.com/repos/benfleis/tchannel/commits{/sha}","git_commits_url":"https://api.github.com/repos/benfleis/tchannel/git/commits{/sha}","comments_url":"https://api.github.com/repos/benfleis/tchannel/comments{/number}","issue_comment_url":"https://api.github.com/repos/benfleis/tchannel/issues/comments{/number}","contents_url":"https://api.github.com/repos/benfleis/tchannel/contents/{+path}","compare_url":"https://api.github.com/repos/benfleis/tchannel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benfleis/tchannel/merges","archive_url":"https://api.github.com/repos/benfleis/tchannel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benfleis/tchannel/downloads","issues_url":"https://api.github.com/repos/benfleis/tchannel/issues{/number}","pulls_url":"https://api.github.com/repos/benfleis/tchannel/pulls{/number}","milestones_url":"https://api.github.com/repos/benfleis/tchannel/milestones{/number}","notifications_url":"https://api.github.com/repos/benfleis/tchannel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benfleis/tchannel/labels{/name}","releases_url":"https://api.github.com/repos/benfleis/tchannel/releases{/id}","created_at":"2015-08-17T14:40:58Z","updated_at":"2015-08-17T14:41:00Z","pushed_at":"2015-08-20T11:26:44Z","git_url":"git://github.com/benfleis/tchannel.git","ssh_url":"git@github.com:benfleis/tchannel.git","clone_url":"https://github.com/benfleis/tchannel.git","svn_url":"https://github.com/benfleis/tchannel","homepage":"","size":6807,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uber:v1.x","ref":"v1.x","sha":"505a00e65f1e7c97bd1538adad99143178da9892","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":28419663,"name":"tchannel","full_name":"uber/tchannel","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel","description":"network multiplexing and framing protocol for RPC","fork":false,"url":"https://api.github.com/repos/uber/tchannel","forks_url":"https://api.github.com/repos/uber/tchannel/forks","keys_url":"https://api.github.com/repos/uber/tchannel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel/teams","hooks_url":"https://api.github.com/repos/uber/tchannel/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel/events","assignees_url":"https://api.github.com/repos/uber/tchannel/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel/tags","blobs_url":"https://api.github.com/repos/uber/tchannel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel/subscription","commits_url":"https://api.github.com/repos/uber/tchannel/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel/merges","archive_url":"https://api.github.com/repos/uber/tchannel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel/downloads","issues_url":"https://api.github.com/repos/uber/tchannel/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel/releases{/id}","created_at":"2014-12-23T21:06:57Z","updated_at":"2015-08-18T16:16:29Z","pushed_at":"2015-08-20T11:26:45Z","git_url":"git://github.com/uber/tchannel.git","ssh_url":"git@github.com:uber/tchannel.git","clone_url":"https://github.com/uber/tchannel.git","svn_url":"https://github.com/uber/tchannel","homepage":"","size":19086,"stargazers_count":138,"watchers_count":138,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":93,"forks":13,"open_issues":93,"watchers":138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel/pulls/1174"},"html":{"href":"https://github.com/uber/tchannel/pull/1174"},"issue":{"href":"https://api.github.com/repos/uber/tchannel/issues/1174"},"comments":{"href":"https://api.github.com/repos/uber/tchannel/issues/1174/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/tchannel/pulls/1174/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/tchannel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/tchannel/pulls/1174/commits"},"statuses":{"href":"https://api.github.com/repos/uber/tchannel/statuses/7daeb1a3fcfbb039ef15405af7da38c6cdfe133e"}}}}