{"action":"created","comment":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/comments/41102690","id":41102690,"diff_hunk":"@@ -136,14 +188,50 @@ func (n *network) destroySandbox() {\n \t\t\tiface.Remove()\n \t\t}\n \n-\t\tif err := deleteVxlan(n.vxlanName); err != nil {\n-\t\t\tlogrus.Warnf(\"could not cleanup sandbox properly: %v\", err)\n+\t\tfor _, s := range n.subnets {\n+\t\t\tif len(s.vxlanName) != 0 {","path":"drivers/overlay/ov_network.go","position":158,"original_position":158,"commit_id":"232d11b2a0cfaa8979cfb4bfa3fd4c6093467b7b","original_commit_id":"232d11b2a0cfaa8979cfb4bfa3fd4c6093467b7b","user":{"login":"mrjana","id":1693482,"avatar_url":"https://avatars.githubusercontent.com/u/1693482?v=3","gravatar_id":"","url":"https://api.github.com/users/mrjana","html_url":"https://github.com/mrjana","followers_url":"https://api.github.com/users/mrjana/followers","following_url":"https://api.github.com/users/mrjana/following{/other_user}","gists_url":"https://api.github.com/users/mrjana/gists{/gist_id}","starred_url":"https://api.github.com/users/mrjana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrjana/subscriptions","organizations_url":"https://api.github.com/users/mrjana/orgs","repos_url":"https://api.github.com/users/mrjana/repos","events_url":"https://api.github.com/users/mrjana/events{/privacy}","received_events_url":"https://api.github.com/users/mrjana/received_events","type":"User","site_admin":false},"body":"You can just say `if s.vxlanName != \"\"`","created_at":"2015-10-04T21:32:32Z","updated_at":"2015-10-04T21:32:32Z","html_url":"https://github.com/docker/libnetwork/pull/584#discussion_r41102690","pull_request_url":"https://api.github.com/repos/docker/libnetwork/pulls/584","_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments/41102690"},"html":{"href":"https://github.com/docker/libnetwork/pull/584#discussion_r41102690"},"pull_request":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/584"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/584","id":46718436,"html_url":"https://github.com/docker/libnetwork/pull/584","diff_url":"https://github.com/docker/libnetwork/pull/584.diff","patch_url":"https://github.com/docker/libnetwork/pull/584.patch","issue_url":"https://api.github.com/repos/docker/libnetwork/issues/584","number":584,"state":"open","locked":false,"title":"Support for multiple subnets in a overlay network","user":{"login":"sanimej","id":10071849,"avatar_url":"https://avatars.githubusercontent.com/u/10071849?v=3","gravatar_id":"","url":"https://api.github.com/users/sanimej","html_url":"https://github.com/sanimej","followers_url":"https://api.github.com/users/sanimej/followers","following_url":"https://api.github.com/users/sanimej/following{/other_user}","gists_url":"https://api.github.com/users/sanimej/gists{/gist_id}","starred_url":"https://api.github.com/users/sanimej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanimej/subscriptions","organizations_url":"https://api.github.com/users/sanimej/orgs","repos_url":"https://api.github.com/users/sanimej/repos","events_url":"https://api.github.com/users/sanimej/events{/privacy}","received_events_url":"https://api.github.com/users/sanimej/received_events","type":"User","site_admin":false},"body":"Added the subnet construct in the overlay driver. Bridge and the vxlan dev will be created per subnet.","created_at":"2015-10-04T03:33:35Z","updated_at":"2015-10-04T21:32:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6ade3f29a723e09b47003cda87b03815b906db5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/libnetwork/pulls/584/commits","review_comments_url":"https://api.github.com/repos/docker/libnetwork/pulls/584/comments","review_comment_url":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libnetwork/issues/584/comments","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/232d11b2a0cfaa8979cfb4bfa3fd4c6093467b7b","head":{"label":"sanimej:subnets","ref":"subnets","sha":"232d11b2a0cfaa8979cfb4bfa3fd4c6093467b7b","user":{"login":"sanimej","id":10071849,"avatar_url":"https://avatars.githubusercontent.com/u/10071849?v=3","gravatar_id":"","url":"https://api.github.com/users/sanimej","html_url":"https://github.com/sanimej","followers_url":"https://api.github.com/users/sanimej/followers","following_url":"https://api.github.com/users/sanimej/following{/other_user}","gists_url":"https://api.github.com/users/sanimej/gists{/gist_id}","starred_url":"https://api.github.com/users/sanimej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanimej/subscriptions","organizations_url":"https://api.github.com/users/sanimej/orgs","repos_url":"https://api.github.com/users/sanimej/repos","events_url":"https://api.github.com/users/sanimej/events{/privacy}","received_events_url":"https://api.github.com/users/sanimej/received_events","type":"User","site_admin":false},"repo":{"id":39800598,"name":"libnetwork","full_name":"sanimej/libnetwork","owner":{"login":"sanimej","id":10071849,"avatar_url":"https://avatars.githubusercontent.com/u/10071849?v=3","gravatar_id":"","url":"https://api.github.com/users/sanimej","html_url":"https://github.com/sanimej","followers_url":"https://api.github.com/users/sanimej/followers","following_url":"https://api.github.com/users/sanimej/following{/other_user}","gists_url":"https://api.github.com/users/sanimej/gists{/gist_id}","starred_url":"https://api.github.com/users/sanimej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanimej/subscriptions","organizations_url":"https://api.github.com/users/sanimej/orgs","repos_url":"https://api.github.com/users/sanimej/repos","events_url":"https://api.github.com/users/sanimej/events{/privacy}","received_events_url":"https://api.github.com/users/sanimej/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sanimej/libnetwork","description":"networking for containers","fork":true,"url":"https://api.github.com/repos/sanimej/libnetwork","forks_url":"https://api.github.com/repos/sanimej/libnetwork/forks","keys_url":"https://api.github.com/repos/sanimej/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sanimej/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sanimej/libnetwork/teams","hooks_url":"https://api.github.com/repos/sanimej/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/sanimej/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/sanimej/libnetwork/events","assignees_url":"https://api.github.com/repos/sanimej/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/sanimej/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/sanimej/libnetwork/tags","blobs_url":"https://api.github.com/repos/sanimej/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sanimej/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sanimej/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/sanimej/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sanimej/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/sanimej/libnetwork/languages","stargazers_url":"https://api.github.com/repos/sanimej/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/sanimej/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/sanimej/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/sanimej/libnetwork/subscription","commits_url":"https://api.github.com/repos/sanimej/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/sanimej/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/sanimej/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/sanimej/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/sanimej/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/sanimej/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sanimej/libnetwork/merges","archive_url":"https://api.github.com/repos/sanimej/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sanimej/libnetwork/downloads","issues_url":"https://api.github.com/repos/sanimej/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/sanimej/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/sanimej/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/sanimej/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sanimej/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/sanimej/libnetwork/releases{/id}","created_at":"2015-07-27T22:17:26Z","updated_at":"2015-07-27T22:17:27Z","pushed_at":"2015-10-04T04:02:39Z","git_url":"git://github.com/sanimej/libnetwork.git","ssh_url":"git@github.com:sanimej/libnetwork.git","clone_url":"https://github.com/sanimej/libnetwork.git","svn_url":"https://github.com/sanimej/libnetwork","homepage":"","size":6027,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"0bf5afe28c8a66738f57032f48b91b964e6c3f4a","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":31046054,"name":"libnetwork","full_name":"docker/libnetwork","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libnetwork","description":"networking for containers","fork":false,"url":"https://api.github.com/repos/docker/libnetwork","forks_url":"https://api.github.com/repos/docker/libnetwork/forks","keys_url":"https://api.github.com/repos/docker/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libnetwork/teams","hooks_url":"https://api.github.com/repos/docker/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/docker/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libnetwork/events","assignees_url":"https://api.github.com/repos/docker/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libnetwork/tags","blobs_url":"https://api.github.com/repos/docker/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libnetwork/languages","stargazers_url":"https://api.github.com/repos/docker/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/docker/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/docker/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/docker/libnetwork/subscription","commits_url":"https://api.github.com/repos/docker/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libnetwork/merges","archive_url":"https://api.github.com/repos/docker/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libnetwork/downloads","issues_url":"https://api.github.com/repos/docker/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/docker/libnetwork/releases{/id}","created_at":"2015-02-20T01:20:15Z","updated_at":"2015-09-29T20:21:59Z","pushed_at":"2015-10-04T08:14:07Z","git_url":"git://github.com/docker/libnetwork.git","ssh_url":"git@github.com:docker/libnetwork.git","clone_url":"https://github.com/docker/libnetwork.git","svn_url":"https://github.com/docker/libnetwork","homepage":"","size":12903,"stargazers_count":455,"watchers_count":455,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":167,"mirror_url":null,"open_issues_count":98,"forks":167,"open_issues":98,"watchers":455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/584"},"html":{"href":"https://github.com/docker/libnetwork/pull/584"},"issue":{"href":"https://api.github.com/repos/docker/libnetwork/issues/584"},"comments":{"href":"https://api.github.com/repos/docker/libnetwork/issues/584/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/584/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/584/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libnetwork/statuses/232d11b2a0cfaa8979cfb4bfa3fd4c6093467b7b"}}}}