{"action":"created","comment":{"url":"https://api.github.com/repos/theairkit/zfs-1/pulls/comments/42209391","id":42209391,"diff_hunk":"@@ -6018,6 +6022,26 @@ _init(void)\n \t\treturn (error);\n \t}\n \n+\tnetlink_id = zpl_ioacct_init();\n+\tif(netlink_id == -2){\n+\t\tprintk(KERN_ERR\n+\t\t    \"ZFS: Can't create ioacct NETLINK thread\\n\");\n+\t}else if(netlink_id == -1){","path":"module/zfs/zfs_ioctl.c","position":26,"original_position":26,"commit_id":"10a2bb7091ca4895a2cfcd50e7049d1978126545","original_commit_id":"10a2bb7091ca4895a2cfcd50e7049d1978126545","user":{"login":"kovetskiy","id":8445924,"avatar_url":"https://avatars.githubusercontent.com/u/8445924?v=3","gravatar_id":"","url":"https://api.github.com/users/kovetskiy","html_url":"https://github.com/kovetskiy","followers_url":"https://api.github.com/users/kovetskiy/followers","following_url":"https://api.github.com/users/kovetskiy/following{/other_user}","gists_url":"https://api.github.com/users/kovetskiy/gists{/gist_id}","starred_url":"https://api.github.com/users/kovetskiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kovetskiy/subscriptions","organizations_url":"https://api.github.com/users/kovetskiy/orgs","repos_url":"https://api.github.com/users/kovetskiy/repos","events_url":"https://api.github.com/users/kovetskiy/events{/privacy}","received_events_url":"https://api.github.com/users/kovetskiy/received_events","type":"User","site_admin":false},"body":"formatting","created_at":"2015-10-16T05:17:21Z","updated_at":"2015-10-16T05:17:21Z","html_url":"https://github.com/theairkit/zfs-1/pull/2#discussion_r42209391","pull_request_url":"https://api.github.com/repos/theairkit/zfs-1/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/theairkit/zfs-1/pulls/comments/42209391"},"html":{"href":"https://github.com/theairkit/zfs-1/pull/2#discussion_r42209391"},"pull_request":{"href":"https://api.github.com/repos/theairkit/zfs-1/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/theairkit/zfs-1/pulls/2","id":47679517,"html_url":"https://github.com/theairkit/zfs-1/pull/2","diff_url":"https://github.com/theairkit/zfs-1/pull/2.diff","patch_url":"https://github.com/theairkit/zfs-1/pull/2.patch","issue_url":"https://api.github.com/repos/theairkit/zfs-1/issues/2","number":2,"state":"open","locked":false,"title":"zfs io accounting through netlink","user":{"login":"theairkit","id":3401239,"avatar_url":"https://avatars.githubusercontent.com/u/3401239?v=3","gravatar_id":"","url":"https://api.github.com/users/theairkit","html_url":"https://github.com/theairkit","followers_url":"https://api.github.com/users/theairkit/followers","following_url":"https://api.github.com/users/theairkit/following{/other_user}","gists_url":"https://api.github.com/users/theairkit/gists{/gist_id}","starred_url":"https://api.github.com/users/theairkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theairkit/subscriptions","organizations_url":"https://api.github.com/users/theairkit/orgs","repos_url":"https://api.github.com/users/theairkit/repos","events_url":"https://api.github.com/users/theairkit/events{/privacy}","received_events_url":"https://api.github.com/users/theairkit/received_events","type":"User","site_admin":false},"body":"- all zfs functional works;\r\n- need to review naming scheme and try to find possible bugs;\r\n- utility showing zfs i/o stats in userspace: WIP;\r\n- documentation: WIP;\r\n\r\nIO accounting creates minimal overhead on zfs perfomance:\r\n- create (as local variable) accounting struct in i/o-zpl-layer;\r\n- fill it;\r\n- send serialized accounting data to NETLINK socket (unicast); if we cannot send - drop it; this is NETLINK 'by design' behavior;","created_at":"2015-10-14T16:04:30Z","updated_at":"2015-10-16T05:17:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"796e87fbb8e26d19fffb169abc76e85a1c94b949","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theairkit/zfs-1/pulls/2/commits","review_comments_url":"https://api.github.com/repos/theairkit/zfs-1/pulls/2/comments","review_comment_url":"https://api.github.com/repos/theairkit/zfs-1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theairkit/zfs-1/issues/2/comments","statuses_url":"https://api.github.com/repos/theairkit/zfs-1/statuses/10a2bb7091ca4895a2cfcd50e7049d1978126545","head":{"label":"theairkit:dev","ref":"dev","sha":"10a2bb7091ca4895a2cfcd50e7049d1978126545","user":{"login":"theairkit","id":3401239,"avatar_url":"https://avatars.githubusercontent.com/u/3401239?v=3","gravatar_id":"","url":"https://api.github.com/users/theairkit","html_url":"https://github.com/theairkit","followers_url":"https://api.github.com/users/theairkit/followers","following_url":"https://api.github.com/users/theairkit/following{/other_user}","gists_url":"https://api.github.com/users/theairkit/gists{/gist_id}","starred_url":"https://api.github.com/users/theairkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theairkit/subscriptions","organizations_url":"https://api.github.com/users/theairkit/orgs","repos_url":"https://api.github.com/users/theairkit/repos","events_url":"https://api.github.com/users/theairkit/events{/privacy}","received_events_url":"https://api.github.com/users/theairkit/received_events","type":"User","site_admin":false},"repo":{"id":44066344,"name":"zfs-1","full_name":"theairkit/zfs-1","owner":{"login":"theairkit","id":3401239,"avatar_url":"https://avatars.githubusercontent.com/u/3401239?v=3","gravatar_id":"","url":"https://api.github.com/users/theairkit","html_url":"https://github.com/theairkit","followers_url":"https://api.github.com/users/theairkit/followers","following_url":"https://api.github.com/users/theairkit/following{/other_user}","gists_url":"https://api.github.com/users/theairkit/gists{/gist_id}","starred_url":"https://api.github.com/users/theairkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theairkit/subscriptions","organizations_url":"https://api.github.com/users/theairkit/orgs","repos_url":"https://api.github.com/users/theairkit/repos","events_url":"https://api.github.com/users/theairkit/events{/privacy}","received_events_url":"https://api.github.com/users/theairkit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theairkit/zfs-1","description":"Native ZFS for Linux","fork":true,"url":"https://api.github.com/repos/theairkit/zfs-1","forks_url":"https://api.github.com/repos/theairkit/zfs-1/forks","keys_url":"https://api.github.com/repos/theairkit/zfs-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theairkit/zfs-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theairkit/zfs-1/teams","hooks_url":"https://api.github.com/repos/theairkit/zfs-1/hooks","issue_events_url":"https://api.github.com/repos/theairkit/zfs-1/issues/events{/number}","events_url":"https://api.github.com/repos/theairkit/zfs-1/events","assignees_url":"https://api.github.com/repos/theairkit/zfs-1/assignees{/user}","branches_url":"https://api.github.com/repos/theairkit/zfs-1/branches{/branch}","tags_url":"https://api.github.com/repos/theairkit/zfs-1/tags","blobs_url":"https://api.github.com/repos/theairkit/zfs-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theairkit/zfs-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theairkit/zfs-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/theairkit/zfs-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theairkit/zfs-1/statuses/{sha}","languages_url":"https://api.github.com/repos/theairkit/zfs-1/languages","stargazers_url":"https://api.github.com/repos/theairkit/zfs-1/stargazers","contributors_url":"https://api.github.com/repos/theairkit/zfs-1/contributors","subscribers_url":"https://api.github.com/repos/theairkit/zfs-1/subscribers","subscription_url":"https://api.github.com/repos/theairkit/zfs-1/subscription","commits_url":"https://api.github.com/repos/theairkit/zfs-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/theairkit/zfs-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/theairkit/zfs-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/theairkit/zfs-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/theairkit/zfs-1/contents/{+path}","compare_url":"https://api.github.com/repos/theairkit/zfs-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theairkit/zfs-1/merges","archive_url":"https://api.github.com/repos/theairkit/zfs-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theairkit/zfs-1/downloads","issues_url":"https://api.github.com/repos/theairkit/zfs-1/issues{/number}","pulls_url":"https://api.github.com/repos/theairkit/zfs-1/pulls{/number}","milestones_url":"https://api.github.com/repos/theairkit/zfs-1/milestones{/number}","notifications_url":"https://api.github.com/repos/theairkit/zfs-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theairkit/zfs-1/labels{/name}","releases_url":"https://api.github.com/repos/theairkit/zfs-1/releases{/id}","created_at":"2015-10-11T19:29:41Z","updated_at":"2015-10-11T19:29:48Z","pushed_at":"2015-10-16T04:43:05Z","git_url":"git://github.com/theairkit/zfs-1.git","ssh_url":"git@github.com:theairkit/zfs-1.git","clone_url":"https://github.com/theairkit/zfs-1.git","svn_url":"https://github.com/theairkit/zfs-1","homepage":"http://zfsonlinux.org/","size":58408,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"theairkit:master","ref":"master","sha":"8f90f7372a1b456ec6ede5e5464ffa23273a7a99","user":{"login":"theairkit","id":3401239,"avatar_url":"https://avatars.githubusercontent.com/u/3401239?v=3","gravatar_id":"","url":"https://api.github.com/users/theairkit","html_url":"https://github.com/theairkit","followers_url":"https://api.github.com/users/theairkit/followers","following_url":"https://api.github.com/users/theairkit/following{/other_user}","gists_url":"https://api.github.com/users/theairkit/gists{/gist_id}","starred_url":"https://api.github.com/users/theairkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theairkit/subscriptions","organizations_url":"https://api.github.com/users/theairkit/orgs","repos_url":"https://api.github.com/users/theairkit/repos","events_url":"https://api.github.com/users/theairkit/events{/privacy}","received_events_url":"https://api.github.com/users/theairkit/received_events","type":"User","site_admin":false},"repo":{"id":44066344,"name":"zfs-1","full_name":"theairkit/zfs-1","owner":{"login":"theairkit","id":3401239,"avatar_url":"https://avatars.githubusercontent.com/u/3401239?v=3","gravatar_id":"","url":"https://api.github.com/users/theairkit","html_url":"https://github.com/theairkit","followers_url":"https://api.github.com/users/theairkit/followers","following_url":"https://api.github.com/users/theairkit/following{/other_user}","gists_url":"https://api.github.com/users/theairkit/gists{/gist_id}","starred_url":"https://api.github.com/users/theairkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theairkit/subscriptions","organizations_url":"https://api.github.com/users/theairkit/orgs","repos_url":"https://api.github.com/users/theairkit/repos","events_url":"https://api.github.com/users/theairkit/events{/privacy}","received_events_url":"https://api.github.com/users/theairkit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theairkit/zfs-1","description":"Native ZFS for Linux","fork":true,"url":"https://api.github.com/repos/theairkit/zfs-1","forks_url":"https://api.github.com/repos/theairkit/zfs-1/forks","keys_url":"https://api.github.com/repos/theairkit/zfs-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theairkit/zfs-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theairkit/zfs-1/teams","hooks_url":"https://api.github.com/repos/theairkit/zfs-1/hooks","issue_events_url":"https://api.github.com/repos/theairkit/zfs-1/issues/events{/number}","events_url":"https://api.github.com/repos/theairkit/zfs-1/events","assignees_url":"https://api.github.com/repos/theairkit/zfs-1/assignees{/user}","branches_url":"https://api.github.com/repos/theairkit/zfs-1/branches{/branch}","tags_url":"https://api.github.com/repos/theairkit/zfs-1/tags","blobs_url":"https://api.github.com/repos/theairkit/zfs-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theairkit/zfs-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theairkit/zfs-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/theairkit/zfs-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theairkit/zfs-1/statuses/{sha}","languages_url":"https://api.github.com/repos/theairkit/zfs-1/languages","stargazers_url":"https://api.github.com/repos/theairkit/zfs-1/stargazers","contributors_url":"https://api.github.com/repos/theairkit/zfs-1/contributors","subscribers_url":"https://api.github.com/repos/theairkit/zfs-1/subscribers","subscription_url":"https://api.github.com/repos/theairkit/zfs-1/subscription","commits_url":"https://api.github.com/repos/theairkit/zfs-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/theairkit/zfs-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/theairkit/zfs-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/theairkit/zfs-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/theairkit/zfs-1/contents/{+path}","compare_url":"https://api.github.com/repos/theairkit/zfs-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theairkit/zfs-1/merges","archive_url":"https://api.github.com/repos/theairkit/zfs-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theairkit/zfs-1/downloads","issues_url":"https://api.github.com/repos/theairkit/zfs-1/issues{/number}","pulls_url":"https://api.github.com/repos/theairkit/zfs-1/pulls{/number}","milestones_url":"https://api.github.com/repos/theairkit/zfs-1/milestones{/number}","notifications_url":"https://api.github.com/repos/theairkit/zfs-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theairkit/zfs-1/labels{/name}","releases_url":"https://api.github.com/repos/theairkit/zfs-1/releases{/id}","created_at":"2015-10-11T19:29:41Z","updated_at":"2015-10-11T19:29:48Z","pushed_at":"2015-10-16T04:43:05Z","git_url":"git://github.com/theairkit/zfs-1.git","ssh_url":"git@github.com:theairkit/zfs-1.git","clone_url":"https://github.com/theairkit/zfs-1.git","svn_url":"https://github.com/theairkit/zfs-1","homepage":"http://zfsonlinux.org/","size":58408,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theairkit/zfs-1/pulls/2"},"html":{"href":"https://github.com/theairkit/zfs-1/pull/2"},"issue":{"href":"https://api.github.com/repos/theairkit/zfs-1/issues/2"},"comments":{"href":"https://api.github.com/repos/theairkit/zfs-1/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/theairkit/zfs-1/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/theairkit/zfs-1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theairkit/zfs-1/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/theairkit/zfs-1/statuses/10a2bb7091ca4895a2cfcd50e7049d1978126545"}}}}