{"action":"created","issue":{"url":"https://api.github.com/repos/fscheck/FsCheck/issues/176","labels_url":"https://api.github.com/repos/fscheck/FsCheck/issues/176/labels{/name}","comments_url":"https://api.github.com/repos/fscheck/FsCheck/issues/176/comments","events_url":"https://api.github.com/repos/fscheck/FsCheck/issues/176/events","html_url":"https://github.com/fscheck/FsCheck/pull/176","id":114738121,"number":176,"title":"Update xUnit summary on property failure due to exception","user":{"login":"neoeinstein","id":18165,"avatar_url":"https://avatars.githubusercontent.com/u/18165?v=3","gravatar_id":"","url":"https://api.github.com/users/neoeinstein","html_url":"https://github.com/neoeinstein","followers_url":"https://api.github.com/users/neoeinstein/followers","following_url":"https://api.github.com/users/neoeinstein/following{/other_user}","gists_url":"https://api.github.com/users/neoeinstein/gists{/gist_id}","starred_url":"https://api.github.com/users/neoeinstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neoeinstein/subscriptions","organizations_url":"https://api.github.com/users/neoeinstein/orgs","repos_url":"https://api.github.com/users/neoeinstein/repos","events_url":"https://api.github.com/users/neoeinstein/events{/privacy}","received_events_url":"https://api.github.com/users/neoeinstein/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-03T04:05:59Z","updated_at":"2015-11-03T08:43:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fscheck/FsCheck/pulls/176","html_url":"https://github.com/fscheck/FsCheck/pull/176","diff_url":"https://github.com/fscheck/FsCheck/pull/176.diff","patch_url":"https://github.com/fscheck/FsCheck/pull/176.patch"},"body":"This initially comes from the xUnit runner failing to increment the failure count on an exception being thrown during property evaluation (as might happen when using Unquote). In this case, the test was not being added to the summary as failed, though that was the test result returned. The number of failures reported ends up being xUnit's exit code, so if a property ended up throwing an exception and failing, it might not be seen as a failure to an external program (such as FAKE) that relied on that exit code.\r\n\r\nThis change increments those failure counters on a thrown exception so that it appropriately influences xUnit's exit code and matches user expectations in the console. This PR is also a bit of a question: it looks like these two cases were singled out for not incrementing the failure count, so it may be for a reason that I don't know about."},"comment":{"url":"https://api.github.com/repos/fscheck/FsCheck/issues/comments/153288849","html_url":"https://github.com/fscheck/FsCheck/pull/176#issuecomment-153288849","issue_url":"https://api.github.com/repos/fscheck/FsCheck/issues/176","id":153288849,"user":{"login":"kurtschelfthout","id":164917,"avatar_url":"https://avatars.githubusercontent.com/u/164917?v=3","gravatar_id":"","url":"https://api.github.com/users/kurtschelfthout","html_url":"https://github.com/kurtschelfthout","followers_url":"https://api.github.com/users/kurtschelfthout/followers","following_url":"https://api.github.com/users/kurtschelfthout/following{/other_user}","gists_url":"https://api.github.com/users/kurtschelfthout/gists{/gist_id}","starred_url":"https://api.github.com/users/kurtschelfthout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurtschelfthout/subscriptions","organizations_url":"https://api.github.com/users/kurtschelfthout/orgs","repos_url":"https://api.github.com/users/kurtschelfthout/repos","events_url":"https://api.github.com/users/kurtschelfthout/events{/privacy}","received_events_url":"https://api.github.com/users/kurtschelfthout/received_events","type":"User","site_admin":false},"created_at":"2015-11-03T08:43:12Z","updated_at":"2015-11-03T08:43:12Z","body":"Good point I think, it looks like an oversight to me.\r\n\r\n@ploeh any thoughts?"}}