{"action":"created","comment":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments/35245450","id":35245450,"diff_hunk":"@@ -17,3 +17,27 @@ deleted wiki page\n <a data-bind=\"attr: {href: wikiUrl}, text: params.page\"></a>\n of <a class = \"log-node-title-link overflow\" data-bind=\"text:nodeTitle, attr: {href: nodeUrl}\"></a>\n </script>\n+\n+<script type=\"text/html\" id=\"made_wiki_public\">\n+made the wiki\n+of <a class = \"log-node-title-link overflow\" data-bind=\"text:nodeTitle, attr: {href: nodeUrl}\"></a>\n+publicly editable\n+</script>\n+\n+<script type=\"text/html\" id=\"made_wiki_public_no_user\">","path":"website/addons/wiki/templates/log_templates.mako","position":11,"original_position":11,"commit_id":"c32a177e49bf28eb66a8e9607f380366155443b9","original_commit_id":"c32a177e49bf28eb66a8e9607f380366155443b9","user":{"login":"lyndsysimon","id":131414,"avatar_url":"https://avatars.githubusercontent.com/u/131414?v=3","gravatar_id":"","url":"https://api.github.com/users/lyndsysimon","html_url":"https://github.com/lyndsysimon","followers_url":"https://api.github.com/users/lyndsysimon/followers","following_url":"https://api.github.com/users/lyndsysimon/following{/other_user}","gists_url":"https://api.github.com/users/lyndsysimon/gists{/gist_id}","starred_url":"https://api.github.com/users/lyndsysimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyndsysimon/subscriptions","organizations_url":"https://api.github.com/users/lyndsysimon/orgs","repos_url":"https://api.github.com/users/lyndsysimon/repos","events_url":"https://api.github.com/users/lyndsysimon/events{/privacy}","received_events_url":"https://api.github.com/users/lyndsysimon/received_events","type":"User","site_admin":false},"body":"Cool. In that case, keeping it consistent makes much more sense.","created_at":"2015-07-22T18:19:25Z","updated_at":"2015-07-22T18:19:25Z","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/3397#discussion_r35245450","pull_request_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/3397","_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments/35245450"},"html":{"href":"https://github.com/CenterForOpenScience/osf.io/pull/3397#discussion_r35245450"},"pull_request":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/3397"}}},"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/3397","id":38918600,"html_url":"https://github.com/CenterForOpenScience/osf.io/pull/3397","diff_url":"https://github.com/CenterForOpenScience/osf.io/pull/3397.diff","patch_url":"https://github.com/CenterForOpenScience/osf.io/pull/3397.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/3397","number":3397,"state":"open","locked":false,"title":"[feature] publicly editable wiki","user":{"login":"geeksnglitter","id":7839433,"avatar_url":"https://avatars.githubusercontent.com/u/7839433?v=3","gravatar_id":"","url":"https://api.github.com/users/geeksnglitter","html_url":"https://github.com/geeksnglitter","followers_url":"https://api.github.com/users/geeksnglitter/followers","following_url":"https://api.github.com/users/geeksnglitter/following{/other_user}","gists_url":"https://api.github.com/users/geeksnglitter/gists{/gist_id}","starred_url":"https://api.github.com/users/geeksnglitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeksnglitter/subscriptions","organizations_url":"https://api.github.com/users/geeksnglitter/orgs","repos_url":"https://api.github.com/users/geeksnglitter/repos","events_url":"https://api.github.com/users/geeksnglitter/events{/privacy}","received_events_url":"https://api.github.com/users/geeksnglitter/received_events","type":"User","site_admin":false},"body":"Purpose\r\n-------------------\r\nThis feature adds the ability to make wikis for nodes to be made publicly editable. This allows any logged in user to edit said wiki. This allows admins to make their wikis accessible to users of whom they may not know the contact information.\r\n\r\nChanges\r\n--------------------\r\nA flag was added to the wiki_settings stored object (similar to the is_public for projects) to keep track of wiki edit-ability. A wiki settings panel was added to the project settings page. This panel was modeled closely after Saman's comment notifications model.\r\n\r\nTODO\r\n-------------------\r\n- [x] Add tests\r\n- [x] Add confirmation modal\r\n\r\n\r\n*Notes:*\r\nThere were some parts of implementation of which I was unsure.\r\nWhen reviewing, one might want to pay special attention to:\r\n- I am unsure of some of my exception usage. Which exceptions to use and how they should be handled, is not as clear as it should be. Exception usage in the definitions of set_editing, get_wiki_permission,  and edit_wiki_permissions are my main concerns.\r\n- On a related note, if logging fails due to the node not being passed to set_editing, an exception is raised and the processes is stopped. Theoretically the permissions should be able to be changed even if logging fails, but there should never be a time when one asks for logging but does not pass a node object. Should this exception be handled differently?.\r\n- In set_editing, I was also unsure about when to save my node and my wiki_settings object.\r\n\r\n","created_at":"2015-06-30T20:07:35Z","updated_at":"2015-07-22T18:19:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecce894a95dadc3cc2f4fa51ee2c828336d52264","assignee":{"login":"lyndsysimon","id":131414,"avatar_url":"https://avatars.githubusercontent.com/u/131414?v=3","gravatar_id":"","url":"https://api.github.com/users/lyndsysimon","html_url":"https://github.com/lyndsysimon","followers_url":"https://api.github.com/users/lyndsysimon/followers","following_url":"https://api.github.com/users/lyndsysimon/following{/other_user}","gists_url":"https://api.github.com/users/lyndsysimon/gists{/gist_id}","starred_url":"https://api.github.com/users/lyndsysimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyndsysimon/subscriptions","organizations_url":"https://api.github.com/users/lyndsysimon/orgs","repos_url":"https://api.github.com/users/lyndsysimon/repos","events_url":"https://api.github.com/users/lyndsysimon/events{/privacy}","received_events_url":"https://api.github.com/users/lyndsysimon/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/3397/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/3397/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/3397/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/c32a177e49bf28eb66a8e9607f380366155443b9","head":{"label":"geeksnglitter:feature/publicWiki","ref":"feature/publicWiki","sha":"c32a177e49bf28eb66a8e9607f380366155443b9","user":{"login":"geeksnglitter","id":7839433,"avatar_url":"https://avatars.githubusercontent.com/u/7839433?v=3","gravatar_id":"","url":"https://api.github.com/users/geeksnglitter","html_url":"https://github.com/geeksnglitter","followers_url":"https://api.github.com/users/geeksnglitter/followers","following_url":"https://api.github.com/users/geeksnglitter/following{/other_user}","gists_url":"https://api.github.com/users/geeksnglitter/gists{/gist_id}","starred_url":"https://api.github.com/users/geeksnglitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeksnglitter/subscriptions","organizations_url":"https://api.github.com/users/geeksnglitter/orgs","repos_url":"https://api.github.com/users/geeksnglitter/repos","events_url":"https://api.github.com/users/geeksnglitter/events{/privacy}","received_events_url":"https://api.github.com/users/geeksnglitter/received_events","type":"User","site_admin":false},"repo":{"id":36674767,"name":"osf.io","full_name":"geeksnglitter/osf.io","owner":{"login":"geeksnglitter","id":7839433,"avatar_url":"https://avatars.githubusercontent.com/u/7839433?v=3","gravatar_id":"","url":"https://api.github.com/users/geeksnglitter","html_url":"https://github.com/geeksnglitter","followers_url":"https://api.github.com/users/geeksnglitter/followers","following_url":"https://api.github.com/users/geeksnglitter/following{/other_user}","gists_url":"https://api.github.com/users/geeksnglitter/gists{/gist_id}","starred_url":"https://api.github.com/users/geeksnglitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeksnglitter/subscriptions","organizations_url":"https://api.github.com/users/geeksnglitter/orgs","repos_url":"https://api.github.com/users/geeksnglitter/repos","events_url":"https://api.github.com/users/geeksnglitter/events{/privacy}","received_events_url":"https://api.github.com/users/geeksnglitter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geeksnglitter/osf.io","description":"Facilitating Open Science","fork":true,"url":"https://api.github.com/repos/geeksnglitter/osf.io","forks_url":"https://api.github.com/repos/geeksnglitter/osf.io/forks","keys_url":"https://api.github.com/repos/geeksnglitter/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geeksnglitter/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geeksnglitter/osf.io/teams","hooks_url":"https://api.github.com/repos/geeksnglitter/osf.io/hooks","issue_events_url":"https://api.github.com/repos/geeksnglitter/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/geeksnglitter/osf.io/events","assignees_url":"https://api.github.com/repos/geeksnglitter/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/geeksnglitter/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/geeksnglitter/osf.io/tags","blobs_url":"https://api.github.com/repos/geeksnglitter/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geeksnglitter/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geeksnglitter/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/geeksnglitter/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geeksnglitter/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/geeksnglitter/osf.io/languages","stargazers_url":"https://api.github.com/repos/geeksnglitter/osf.io/stargazers","contributors_url":"https://api.github.com/repos/geeksnglitter/osf.io/contributors","subscribers_url":"https://api.github.com/repos/geeksnglitter/osf.io/subscribers","subscription_url":"https://api.github.com/repos/geeksnglitter/osf.io/subscription","commits_url":"https://api.github.com/repos/geeksnglitter/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/geeksnglitter/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/geeksnglitter/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/geeksnglitter/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/geeksnglitter/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/geeksnglitter/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geeksnglitter/osf.io/merges","archive_url":"https://api.github.com/repos/geeksnglitter/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geeksnglitter/osf.io/downloads","issues_url":"https://api.github.com/repos/geeksnglitter/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/geeksnglitter/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/geeksnglitter/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/geeksnglitter/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geeksnglitter/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/geeksnglitter/osf.io/releases{/id}","created_at":"2015-06-01T16:51:30Z","updated_at":"2015-06-01T16:51:33Z","pushed_at":"2015-07-20T15:03:31Z","git_url":"git://github.com/geeksnglitter/osf.io.git","ssh_url":"git@github.com:geeksnglitter/osf.io.git","clone_url":"https://github.com/geeksnglitter/osf.io.git","svn_url":"https://github.com/geeksnglitter/osf.io","homepage":"http://osf.io","size":96739,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:develop","ref":"develop","sha":"8874bc1a3b345c498fd98c1142c082ac83963709","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":10199599,"name":"osf.io","full_name":"CenterForOpenScience/osf.io","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/osf.io","description":"Facilitating Open Science","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/osf.io","forks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/releases{/id}","created_at":"2013-05-21T15:53:37Z","updated_at":"2015-07-22T07:35:55Z","pushed_at":"2015-07-22T18:19:17Z","git_url":"git://github.com/CenterForOpenScience/osf.io.git","ssh_url":"git@github.com:CenterForOpenScience/osf.io.git","clone_url":"https://github.com/CenterForOpenScience/osf.io.git","svn_url":"https://github.com/CenterForOpenScience/osf.io","homepage":"http://osf.io","size":218659,"stargazers_count":120,"watchers_count":120,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":575,"forks":104,"open_issues":575,"watchers":120,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/3397"},"html":{"href":"https://github.com/CenterForOpenScience/osf.io/pull/3397"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/3397"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/3397/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/3397/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/3397/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/c32a177e49bf28eb66a8e9607f380366155443b9"}}}}