{"action":"created","issue":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/577","labels_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/577/labels{/name}","comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/577/comments","events_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/577/events","html_url":"https://github.com/react-bootstrap/react-bootstrap/pull/577","id":71112738,"number":577,"title":"Update dev dependencies","user":{"login":"AlexKVal","id":847572,"avatar_url":"https://avatars.githubusercontent.com/u/847572?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexKVal","html_url":"https://github.com/AlexKVal","followers_url":"https://api.github.com/users/AlexKVal/followers","following_url":"https://api.github.com/users/AlexKVal/following{/other_user}","gists_url":"https://api.github.com/users/AlexKVal/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexKVal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexKVal/subscriptions","organizations_url":"https://api.github.com/users/AlexKVal/orgs","repos_url":"https://api.github.com/users/AlexKVal/repos","events_url":"https://api.github.com/users/AlexKVal/events{/privacy}","received_events_url":"https://api.github.com/users/AlexKVal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-26T19:58:30Z","updated_at":"2015-04-26T20:15:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/577","html_url":"https://github.com/react-bootstrap/react-bootstrap/pull/577","diff_url":"https://github.com/react-bootstrap/react-bootstrap/pull/577.diff","patch_url":"https://github.com/react-bootstrap/react-bootstrap/pull/577.patch"},"body":"```sh\r\n$ npm up\r\n$ npm outdated\r\nedit package.json\r\n$ rm -rf node_modules\r\n$ npm test\r\n```\r\nAll is green.\r\n\r\nThen\r\n```sh\r\n$ npm run docs\r\n```\r\nI've checked all pages with opened dev console on two browsers: Chrome and Firefox.\r\nAll components seem in place and working.\r\nIn console there are no warnings.\r\n\r\n(just small `complaining` in Firefox console about `react-router+eslint` known bug https://github.com/react-bootstrap/react-bootstrap/issues/550)\r\n```console\r\nmutating the [[Prototype]] of an object will cause your code to run very slowly; \r\ninstead create the object with the correct initial [[Prototype]] value \r\nusing Object.create bundle.js:11597:398\r\n```"},"comment":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/comments/96430536","html_url":"https://github.com/react-bootstrap/react-bootstrap/pull/577#issuecomment-96430536","issue_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/577","id":96430536,"user":{"login":"AlexKVal","id":847572,"avatar_url":"https://avatars.githubusercontent.com/u/847572?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexKVal","html_url":"https://github.com/AlexKVal","followers_url":"https://api.github.com/users/AlexKVal/followers","following_url":"https://api.github.com/users/AlexKVal/following{/other_user}","gists_url":"https://api.github.com/users/AlexKVal/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexKVal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexKVal/subscriptions","organizations_url":"https://api.github.com/users/AlexKVal/orgs","repos_url":"https://api.github.com/users/AlexKVal/repos","events_url":"https://api.github.com/users/AlexKVal/events{/privacy}","received_events_url":"https://api.github.com/users/AlexKVal/received_events","type":"User","site_admin":false},"created_at":"2015-04-26T20:15:42Z","updated_at":"2015-04-26T20:15:42Z","body":"And one more question about another rule.\r\nIn the `eslint-plugin-react` last version there is also new rule has been implemented\r\n[jsx-sort-prop-types](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-sort-prop-types.md)\r\n\r\n`AffixMixin.js`\r\n```js\r\nconst AffixMixin = {\r\n  propTypes: {\r\n    offset: React.PropTypes.number,\r\n    offsetTop: React.PropTypes.number,\r\n    offsetBottom: React.PropTypes.number\r\n  },\r\n...\r\n```\r\nWith this rule enforced:\r\n```js\r\nconst AffixMixin = {\r\n  propTypes: {\r\n    offset:       React.PropTypes.number,\r\n    offsetBottom: React.PropTypes.number,\r\n    offsetTop:    React.PropTypes.number\r\n  },\r\n...\r\n```\r\nI'm concerned that `Bottom` is now over the `Top` and not sure about value to enforce the rule in `react-bootstrap` project.\r\n(though I did implement it with this project in mind)"}}