{"action":"created","comment":{"url":"https://api.github.com/repos/Netflix/spectator/pulls/comments/40715339","id":40715339,"diff_hunk":"@@ -52,6 +52,28 @@\n   Id createId(String name, Iterable<Tag> tags);\n \n   /**\n+   * Creates a dynamic identifier for a meter. All ids passed into other calls should be created by the registry.\n+   *\n+   * @param name\n+   *     Description of the measurement that is being collected.\n+   * @return\n+   *     The newly created dynamic identifier.\n+   */\n+  DynamicId createDynamicId(String name);\n+\n+  /**\n+   * Creates a dynamic identifier for a meter. All ids passed into other calls should be created by the registry.\n+   *\n+   * @param name\n+   *     Description of the measurement that is being collected.\n+   * @param tagFactories\n+   *     Other factories that can generate other dimensions that can be used to classify the measurement.\n+   * @return\n+   *     The newly created dynamic identifier.\n+   */\n+  DynamicId createDynamicId(String name, Iterable<TagFactory> tagFactories);","path":"spectator-api/src/main/java/com/netflix/spectator/api/Registry.java","position":23,"original_position":23,"commit_id":"819a3823cb81940d823a312dc9717828ff4c39d2","original_commit_id":"819a3823cb81940d823a312dc9717828ff4c39d2","user":{"login":"brharrington","id":1289028,"avatar_url":"https://avatars.githubusercontent.com/u/1289028?v=3","gravatar_id":"","url":"https://api.github.com/users/brharrington","html_url":"https://github.com/brharrington","followers_url":"https://api.github.com/users/brharrington/followers","following_url":"https://api.github.com/users/brharrington/following{/other_user}","gists_url":"https://api.github.com/users/brharrington/gists{/gist_id}","starred_url":"https://api.github.com/users/brharrington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brharrington/subscriptions","organizations_url":"https://api.github.com/users/brharrington/orgs","repos_url":"https://api.github.com/users/brharrington/repos","events_url":"https://api.github.com/users/brharrington/events{/privacy}","received_events_url":"https://api.github.com/users/brharrington/received_events","type":"User","site_admin":false},"body":"Note to self, this should have caused the compatibility check in the build to fail.","created_at":"2015-09-29T19:12:15Z","updated_at":"2015-09-29T19:12:15Z","html_url":"https://github.com/Netflix/spectator/pull/231#discussion_r40715339","pull_request_url":"https://api.github.com/repos/Netflix/spectator/pulls/231","_links":{"self":{"href":"https://api.github.com/repos/Netflix/spectator/pulls/comments/40715339"},"html":{"href":"https://github.com/Netflix/spectator/pull/231#discussion_r40715339"},"pull_request":{"href":"https://api.github.com/repos/Netflix/spectator/pulls/231"}}},"pull_request":{"url":"https://api.github.com/repos/Netflix/spectator/pulls/231","id":46057487,"html_url":"https://github.com/Netflix/spectator/pull/231","diff_url":"https://github.com/Netflix/spectator/pull/231.diff","patch_url":"https://github.com/Netflix/spectator/pull/231.patch","issue_url":"https://api.github.com/repos/Netflix/spectator/issues/231","number":231,"state":"open","locked":false,"title":"Add support for Ids that have dynamically commuted tag values.","user":{"login":"pstout","id":1458375,"avatar_url":"https://avatars.githubusercontent.com/u/1458375?v=3","gravatar_id":"","url":"https://api.github.com/users/pstout","html_url":"https://github.com/pstout","followers_url":"https://api.github.com/users/pstout/followers","following_url":"https://api.github.com/users/pstout/following{/other_user}","gists_url":"https://api.github.com/users/pstout/gists{/gist_id}","starred_url":"https://api.github.com/users/pstout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pstout/subscriptions","organizations_url":"https://api.github.com/users/pstout/orgs","repos_url":"https://api.github.com/users/pstout/repos","events_url":"https://api.github.com/users/pstout/events{/privacy}","received_events_url":"https://api.github.com/users/pstout/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-25T20:58:13Z","updated_at":"2015-09-29T19:12:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40494c16ff84e9a91b22c3fe1c0ad9c207bd4f17","assignee":null,"milestone":{"url":"https://api.github.com/repos/Netflix/spectator/milestones/19","html_url":"https://github.com/Netflix/spectator/milestones/0.33.0","labels_url":"https://api.github.com/repos/Netflix/spectator/milestones/19/labels","id":1320623,"number":19,"title":"0.33.0","description":"","creator":{"login":"brharrington","id":1289028,"avatar_url":"https://avatars.githubusercontent.com/u/1289028?v=3","gravatar_id":"","url":"https://api.github.com/users/brharrington","html_url":"https://github.com/brharrington","followers_url":"https://api.github.com/users/brharrington/followers","following_url":"https://api.github.com/users/brharrington/following{/other_user}","gists_url":"https://api.github.com/users/brharrington/gists{/gist_id}","starred_url":"https://api.github.com/users/brharrington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brharrington/subscriptions","organizations_url":"https://api.github.com/users/brharrington/orgs","repos_url":"https://api.github.com/users/brharrington/repos","events_url":"https://api.github.com/users/brharrington/events{/privacy}","received_events_url":"https://api.github.com/users/brharrington/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":2,"state":"open","created_at":"2015-09-23T16:03:58Z","updated_at":"2015-09-25T23:09:54Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Netflix/spectator/pulls/231/commits","review_comments_url":"https://api.github.com/repos/Netflix/spectator/pulls/231/comments","review_comment_url":"https://api.github.com/repos/Netflix/spectator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/spectator/issues/231/comments","statuses_url":"https://api.github.com/repos/Netflix/spectator/statuses/819a3823cb81940d823a312dc9717828ff4c39d2","head":{"label":"pstout:pds-dynamic-ids","ref":"pds-dynamic-ids","sha":"819a3823cb81940d823a312dc9717828ff4c39d2","user":{"login":"pstout","id":1458375,"avatar_url":"https://avatars.githubusercontent.com/u/1458375?v=3","gravatar_id":"","url":"https://api.github.com/users/pstout","html_url":"https://github.com/pstout","followers_url":"https://api.github.com/users/pstout/followers","following_url":"https://api.github.com/users/pstout/following{/other_user}","gists_url":"https://api.github.com/users/pstout/gists{/gist_id}","starred_url":"https://api.github.com/users/pstout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pstout/subscriptions","organizations_url":"https://api.github.com/users/pstout/orgs","repos_url":"https://api.github.com/users/pstout/repos","events_url":"https://api.github.com/users/pstout/events{/privacy}","received_events_url":"https://api.github.com/users/pstout/received_events","type":"User","site_admin":false},"repo":{"id":37343357,"name":"spectator","full_name":"pstout/spectator","owner":{"login":"pstout","id":1458375,"avatar_url":"https://avatars.githubusercontent.com/u/1458375?v=3","gravatar_id":"","url":"https://api.github.com/users/pstout","html_url":"https://github.com/pstout","followers_url":"https://api.github.com/users/pstout/followers","following_url":"https://api.github.com/users/pstout/following{/other_user}","gists_url":"https://api.github.com/users/pstout/gists{/gist_id}","starred_url":"https://api.github.com/users/pstout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pstout/subscriptions","organizations_url":"https://api.github.com/users/pstout/orgs","repos_url":"https://api.github.com/users/pstout/repos","events_url":"https://api.github.com/users/pstout/events{/privacy}","received_events_url":"https://api.github.com/users/pstout/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pstout/spectator","description":"","fork":true,"url":"https://api.github.com/repos/pstout/spectator","forks_url":"https://api.github.com/repos/pstout/spectator/forks","keys_url":"https://api.github.com/repos/pstout/spectator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pstout/spectator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pstout/spectator/teams","hooks_url":"https://api.github.com/repos/pstout/spectator/hooks","issue_events_url":"https://api.github.com/repos/pstout/spectator/issues/events{/number}","events_url":"https://api.github.com/repos/pstout/spectator/events","assignees_url":"https://api.github.com/repos/pstout/spectator/assignees{/user}","branches_url":"https://api.github.com/repos/pstout/spectator/branches{/branch}","tags_url":"https://api.github.com/repos/pstout/spectator/tags","blobs_url":"https://api.github.com/repos/pstout/spectator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pstout/spectator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pstout/spectator/git/refs{/sha}","trees_url":"https://api.github.com/repos/pstout/spectator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pstout/spectator/statuses/{sha}","languages_url":"https://api.github.com/repos/pstout/spectator/languages","stargazers_url":"https://api.github.com/repos/pstout/spectator/stargazers","contributors_url":"https://api.github.com/repos/pstout/spectator/contributors","subscribers_url":"https://api.github.com/repos/pstout/spectator/subscribers","subscription_url":"https://api.github.com/repos/pstout/spectator/subscription","commits_url":"https://api.github.com/repos/pstout/spectator/commits{/sha}","git_commits_url":"https://api.github.com/repos/pstout/spectator/git/commits{/sha}","comments_url":"https://api.github.com/repos/pstout/spectator/comments{/number}","issue_comment_url":"https://api.github.com/repos/pstout/spectator/issues/comments{/number}","contents_url":"https://api.github.com/repos/pstout/spectator/contents/{+path}","compare_url":"https://api.github.com/repos/pstout/spectator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pstout/spectator/merges","archive_url":"https://api.github.com/repos/pstout/spectator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pstout/spectator/downloads","issues_url":"https://api.github.com/repos/pstout/spectator/issues{/number}","pulls_url":"https://api.github.com/repos/pstout/spectator/pulls{/number}","milestones_url":"https://api.github.com/repos/pstout/spectator/milestones{/number}","notifications_url":"https://api.github.com/repos/pstout/spectator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pstout/spectator/labels{/name}","releases_url":"https://api.github.com/repos/pstout/spectator/releases{/id}","created_at":"2015-06-12T20:36:19Z","updated_at":"2015-06-12T20:36:20Z","pushed_at":"2015-09-29T16:10:27Z","git_url":"git://github.com/pstout/spectator.git","ssh_url":"git@github.com:pstout/spectator.git","clone_url":"https://github.com/pstout/spectator.git","svn_url":"https://github.com/pstout/spectator","homepage":"","size":3894,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Netflix:master","ref":"master","sha":"0098515f93e684cafbcf9dc6bff950f9fd0c4389","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":21993347,"name":"spectator","full_name":"Netflix/spectator","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/spectator","description":"","fork":false,"url":"https://api.github.com/repos/Netflix/spectator","forks_url":"https://api.github.com/repos/Netflix/spectator/forks","keys_url":"https://api.github.com/repos/Netflix/spectator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/spectator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/spectator/teams","hooks_url":"https://api.github.com/repos/Netflix/spectator/hooks","issue_events_url":"https://api.github.com/repos/Netflix/spectator/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/spectator/events","assignees_url":"https://api.github.com/repos/Netflix/spectator/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/spectator/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/spectator/tags","blobs_url":"https://api.github.com/repos/Netflix/spectator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/spectator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/spectator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/spectator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/spectator/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/spectator/languages","stargazers_url":"https://api.github.com/repos/Netflix/spectator/stargazers","contributors_url":"https://api.github.com/repos/Netflix/spectator/contributors","subscribers_url":"https://api.github.com/repos/Netflix/spectator/subscribers","subscription_url":"https://api.github.com/repos/Netflix/spectator/subscription","commits_url":"https://api.github.com/repos/Netflix/spectator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/spectator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/spectator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/spectator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/spectator/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/spectator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/spectator/merges","archive_url":"https://api.github.com/repos/Netflix/spectator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/spectator/downloads","issues_url":"https://api.github.com/repos/Netflix/spectator/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/spectator/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/spectator/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/spectator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/spectator/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/spectator/releases{/id}","created_at":"2014-07-18T20:22:53Z","updated_at":"2015-09-26T16:10:38Z","pushed_at":"2015-09-29T16:10:29Z","git_url":"git://github.com/Netflix/spectator.git","ssh_url":"git@github.com:Netflix/spectator.git","clone_url":"https://github.com/Netflix/spectator.git","svn_url":"https://github.com/Netflix/spectator","homepage":"","size":6539,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":9,"forks":17,"open_issues":9,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/spectator/pulls/231"},"html":{"href":"https://github.com/Netflix/spectator/pull/231"},"issue":{"href":"https://api.github.com/repos/Netflix/spectator/issues/231"},"comments":{"href":"https://api.github.com/repos/Netflix/spectator/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/spectator/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/spectator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/spectator/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/spectator/statuses/819a3823cb81940d823a312dc9717828ff4c39d2"}}}}