{"action":"created","comment":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments/39432222","id":39432222,"diff_hunk":"@@ -8,54 +10,45 @@\n import com.google.checkstyle.test.base.BaseCheckTestSupport;\n import com.google.checkstyle.test.base.ConfigurationBuilder;\n import com.puppycrawl.tools.checkstyle.api.Configuration;\n-import com.puppycrawl.tools.checkstyle.checks.coding.NoFinalizerCheck;\n+import com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck;\n \n public class NonEmptyAtclauseDescriptionTest extends BaseCheckTestSupport{\n \n-    private static ConfigurationBuilder builder;\n-\n-    @BeforeClass\n-    public static void setConfigurationBuilder() {\n-        builder = new ConfigurationBuilder(new File(\"src/it/\"));\n-    }\n-\n-    @Test\n-    public void noFinalizerBasicTest() throws Exception {\n-        \n-        String msg = getCheckMessage(NoFinalizerCheck.class, \"avoid.finalizer.method\");\n-\n-        final String[] expected = {\n-            \"5: \" + msg,\n-        };\n-\n-        Configuration checkConfig = builder.getCheckConfig(\"NoFinalizer\");\n-        String filePath = builder.getFilePath(\"NoFinalizerInput\");\n-        \n-        Integer[] warnList = builder.getLinesWithWarn(filePath);\n-        verify(checkConfig, filePath, expected, warnList);\n-    }\n-    \n     @Test\n-    public void noFinalizerExtendedTest() throws Exception {\n-        \n-        String msg = getCheckMessage(NoFinalizerCheck.class, \"avoid.finalizer.method\");\n+    public void testDefault() throws Exception {\n+        ConfigurationBuilder builder = new ConfigurationBuilder(new File(\"src/it/\"));\n+        String msg = getCheckMessage(NonEmptyAtclauseDescriptionCheck.class, \"non.empty.atclause\");\n \n         final String[] expected = {\n-            \"9: \" + msg,\n-            \"21: \" + msg,\n-            \"33: \" + msg,\n-            \"45: \" + msg,\n-            \"57: \" + msg,\n-            \"69: \" + msg,\n+            //this is a case with description that is sequences of spaces\n+            \"27: \" + msg,\n+            //this is a case with description that is sequences of spaces\n+            \"28: \" + msg,\n+            //this is a case with description that is sequences of spaces\n+            \"29: \" + msg,\n+            //this is a case with description that is sequences of spaces\n+            \"38: \" + msg,\n+            //this is a case with description that is sequences of spaces\n+            \"39: \" + msg,\n+            //this is a case with description that is sequences of spaces\n+            \"40: \" + msg,\n+            \"76: \" + msg,\n+            \"77: \" + msg,\n+            \"78: \" + msg,\n             \"79: \" + msg,\n-            \"119: \" + msg,\n-            \"136: \" + msg,\n+            \"80: \" + msg,\n+            \"81: \" + msg,\n+            \"90: \" + msg,\n+            \"91: \" + msg,\n+            \"92: \" + msg,\n+            \"93: \" + msg,\n+            \"94: \" + msg,\n         };\n \n-        Configuration checkConfig = builder.getCheckConfig(\"NoFinalizer\");\n-        String filePath = builder.getFilePath(\"NoFinalizeExtendInput\");\n+        Configuration checkConfig = builder.getCheckConfig(\"NonEmptyAtclauseDescription\");\n+        String filePath = builder.getFilePath(\"InputNonEmptyAtclauseDescriptionCheck\");\n         \n-        Integer[] warnList = builder.getLinesWithWarn(filePath);\n+        Integer[] warnList = {27, 28, 29, 38, 39, 40, 76, 77, 78, 79, 80, 81, 90, 91, 92, 93, 94};","path":"src/it/java/com/google/checkstyle/test/chapter7javadoc/rule713atclauses/NonEmptyAtclauseDescriptionTest.java","position":88,"original_position":88,"commit_id":"2bcabed86b151921547445af3b12ad51bc6c532d","original_commit_id":"2bcabed86b151921547445af3b12ad51bc6c532d","user":{"login":"mkordas","id":5467276,"avatar_url":"https://avatars.githubusercontent.com/u/5467276?v=3","gravatar_id":"","url":"https://api.github.com/users/mkordas","html_url":"https://github.com/mkordas","followers_url":"https://api.github.com/users/mkordas/followers","following_url":"https://api.github.com/users/mkordas/following{/other_user}","gists_url":"https://api.github.com/users/mkordas/gists{/gist_id}","starred_url":"https://api.github.com/users/mkordas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkordas/subscriptions","organizations_url":"https://api.github.com/users/mkordas/orgs","repos_url":"https://api.github.com/users/mkordas/repos","events_url":"https://api.github.com/users/mkordas/events{/privacy}","received_events_url":"https://api.github.com/users/mkordas/received_events","type":"User","site_admin":false},"body":"> `{27, 28, 29, 38, 39, 40, 76, 77, 78, 79, 80, 81, 90, 91, 92, 93, 94}`\r\n\r\nCan we do something about it? Looks like duplication - any change in input file would force us to update line numbers in two places.","created_at":"2015-09-14T18:55:48Z","updated_at":"2015-09-14T18:55:48Z","html_url":"https://github.com/checkstyle/checkstyle/pull/2180#discussion_r39432222","pull_request_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2180","_links":{"self":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments/39432222"},"html":{"href":"https://github.com/checkstyle/checkstyle/pull/2180#discussion_r39432222"},"pull_request":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2180"}}},"pull_request":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2180","id":44934557,"html_url":"https://github.com/checkstyle/checkstyle/pull/2180","diff_url":"https://github.com/checkstyle/checkstyle/pull/2180.diff","patch_url":"https://github.com/checkstyle/checkstyle/pull/2180.patch","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2180","number":2180,"state":"open","locked":false,"title":"Correct ITs for NonEmptyAtclauseDescription and JavadocTagContinuationIndentation","user":{"login":"Vladlis","id":9678372,"avatar_url":"https://avatars.githubusercontent.com/u/9678372?v=3","gravatar_id":"","url":"https://api.github.com/users/Vladlis","html_url":"https://github.com/Vladlis","followers_url":"https://api.github.com/users/Vladlis/followers","following_url":"https://api.github.com/users/Vladlis/following{/other_user}","gists_url":"https://api.github.com/users/Vladlis/gists{/gist_id}","starred_url":"https://api.github.com/users/Vladlis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vladlis/subscriptions","organizations_url":"https://api.github.com/users/Vladlis/orgs","repos_url":"https://api.github.com/users/Vladlis/repos","events_url":"https://api.github.com/users/Vladlis/events{/privacy}","received_events_url":"https://api.github.com/users/Vladlis/received_events","type":"User","site_admin":false},"body":"In NonEmptyAtclauseDescriptionTest the only way I found possible to write \"//warn\" comments in the input file is\r\n```java\r\n/**\r\n \t * Some javadoc.  \r\n \t * @param c     \t */ //warn\r\n```\r\nBut this would make the test incomplete, I guess.","created_at":"2015-09-14T14:12:37Z","updated_at":"2015-09-14T18:55:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6489220878725124894725faa62be44688e8bb1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2180/commits","review_comments_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2180/comments","review_comment_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2180/comments","statuses_url":"https://api.github.com/repos/checkstyle/checkstyle/statuses/2bcabed86b151921547445af3b12ad51bc6c532d","head":{"label":"Vladlis:i2074-correct-ITs","ref":"i2074-correct-ITs","sha":"2bcabed86b151921547445af3b12ad51bc6c532d","user":{"login":"Vladlis","id":9678372,"avatar_url":"https://avatars.githubusercontent.com/u/9678372?v=3","gravatar_id":"","url":"https://api.github.com/users/Vladlis","html_url":"https://github.com/Vladlis","followers_url":"https://api.github.com/users/Vladlis/followers","following_url":"https://api.github.com/users/Vladlis/following{/other_user}","gists_url":"https://api.github.com/users/Vladlis/gists{/gist_id}","starred_url":"https://api.github.com/users/Vladlis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vladlis/subscriptions","organizations_url":"https://api.github.com/users/Vladlis/orgs","repos_url":"https://api.github.com/users/Vladlis/repos","events_url":"https://api.github.com/users/Vladlis/events{/privacy}","received_events_url":"https://api.github.com/users/Vladlis/received_events","type":"User","site_admin":false},"repo":{"id":35640976,"name":"checkstyle","full_name":"Vladlis/checkstyle","owner":{"login":"Vladlis","id":9678372,"avatar_url":"https://avatars.githubusercontent.com/u/9678372?v=3","gravatar_id":"","url":"https://api.github.com/users/Vladlis","html_url":"https://github.com/Vladlis","followers_url":"https://api.github.com/users/Vladlis/followers","following_url":"https://api.github.com/users/Vladlis/following{/other_user}","gists_url":"https://api.github.com/users/Vladlis/gists{/gist_id}","starred_url":"https://api.github.com/users/Vladlis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vladlis/subscriptions","organizations_url":"https://api.github.com/users/Vladlis/orgs","repos_url":"https://api.github.com/users/Vladlis/repos","events_url":"https://api.github.com/users/Vladlis/events{/privacy}","received_events_url":"https://api.github.com/users/Vladlis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vladlis/checkstyle","description":"Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.","fork":true,"url":"https://api.github.com/repos/Vladlis/checkstyle","forks_url":"https://api.github.com/repos/Vladlis/checkstyle/forks","keys_url":"https://api.github.com/repos/Vladlis/checkstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vladlis/checkstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vladlis/checkstyle/teams","hooks_url":"https://api.github.com/repos/Vladlis/checkstyle/hooks","issue_events_url":"https://api.github.com/repos/Vladlis/checkstyle/issues/events{/number}","events_url":"https://api.github.com/repos/Vladlis/checkstyle/events","assignees_url":"https://api.github.com/repos/Vladlis/checkstyle/assignees{/user}","branches_url":"https://api.github.com/repos/Vladlis/checkstyle/branches{/branch}","tags_url":"https://api.github.com/repos/Vladlis/checkstyle/tags","blobs_url":"https://api.github.com/repos/Vladlis/checkstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vladlis/checkstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vladlis/checkstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vladlis/checkstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vladlis/checkstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/Vladlis/checkstyle/languages","stargazers_url":"https://api.github.com/repos/Vladlis/checkstyle/stargazers","contributors_url":"https://api.github.com/repos/Vladlis/checkstyle/contributors","subscribers_url":"https://api.github.com/repos/Vladlis/checkstyle/subscribers","subscription_url":"https://api.github.com/repos/Vladlis/checkstyle/subscription","commits_url":"https://api.github.com/repos/Vladlis/checkstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vladlis/checkstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vladlis/checkstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vladlis/checkstyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vladlis/checkstyle/contents/{+path}","compare_url":"https://api.github.com/repos/Vladlis/checkstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vladlis/checkstyle/merges","archive_url":"https://api.github.com/repos/Vladlis/checkstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vladlis/checkstyle/downloads","issues_url":"https://api.github.com/repos/Vladlis/checkstyle/issues{/number}","pulls_url":"https://api.github.com/repos/Vladlis/checkstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/Vladlis/checkstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/Vladlis/checkstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vladlis/checkstyle/labels{/name}","releases_url":"https://api.github.com/repos/Vladlis/checkstyle/releases{/id}","created_at":"2015-05-14T22:48:05Z","updated_at":"2015-05-14T22:48:08Z","pushed_at":"2015-09-14T14:23:58Z","git_url":"git://github.com/Vladlis/checkstyle.git","ssh_url":"git@github.com:Vladlis/checkstyle.git","clone_url":"https://github.com/Vladlis/checkstyle.git","svn_url":"https://github.com/Vladlis/checkstyle","homepage":"http://checkstyle.sourceforge.net/","size":46380,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"checkstyle:master","ref":"master","sha":"e5dd96d8dcfb6503d57fe70a9aff44fb5406e617","user":{"login":"checkstyle","id":5179750,"avatar_url":"https://avatars.githubusercontent.com/u/5179750?v=3","gravatar_id":"","url":"https://api.github.com/users/checkstyle","html_url":"https://github.com/checkstyle","followers_url":"https://api.github.com/users/checkstyle/followers","following_url":"https://api.github.com/users/checkstyle/following{/other_user}","gists_url":"https://api.github.com/users/checkstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/checkstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checkstyle/subscriptions","organizations_url":"https://api.github.com/users/checkstyle/orgs","repos_url":"https://api.github.com/users/checkstyle/repos","events_url":"https://api.github.com/users/checkstyle/events{/privacy}","received_events_url":"https://api.github.com/users/checkstyle/received_events","type":"Organization","site_admin":false},"repo":{"id":12499251,"name":"checkstyle","full_name":"checkstyle/checkstyle","owner":{"login":"checkstyle","id":5179750,"avatar_url":"https://avatars.githubusercontent.com/u/5179750?v=3","gravatar_id":"","url":"https://api.github.com/users/checkstyle","html_url":"https://github.com/checkstyle","followers_url":"https://api.github.com/users/checkstyle/followers","following_url":"https://api.github.com/users/checkstyle/following{/other_user}","gists_url":"https://api.github.com/users/checkstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/checkstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checkstyle/subscriptions","organizations_url":"https://api.github.com/users/checkstyle/orgs","repos_url":"https://api.github.com/users/checkstyle/repos","events_url":"https://api.github.com/users/checkstyle/events{/privacy}","received_events_url":"https://api.github.com/users/checkstyle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/checkstyle/checkstyle","description":"Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.","fork":false,"url":"https://api.github.com/repos/checkstyle/checkstyle","forks_url":"https://api.github.com/repos/checkstyle/checkstyle/forks","keys_url":"https://api.github.com/repos/checkstyle/checkstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/checkstyle/checkstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/checkstyle/checkstyle/teams","hooks_url":"https://api.github.com/repos/checkstyle/checkstyle/hooks","issue_events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/events{/number}","events_url":"https://api.github.com/repos/checkstyle/checkstyle/events","assignees_url":"https://api.github.com/repos/checkstyle/checkstyle/assignees{/user}","branches_url":"https://api.github.com/repos/checkstyle/checkstyle/branches{/branch}","tags_url":"https://api.github.com/repos/checkstyle/checkstyle/tags","blobs_url":"https://api.github.com/repos/checkstyle/checkstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/checkstyle/checkstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/checkstyle/checkstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/checkstyle/checkstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/checkstyle/checkstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/checkstyle/checkstyle/languages","stargazers_url":"https://api.github.com/repos/checkstyle/checkstyle/stargazers","contributors_url":"https://api.github.com/repos/checkstyle/checkstyle/contributors","subscribers_url":"https://api.github.com/repos/checkstyle/checkstyle/subscribers","subscription_url":"https://api.github.com/repos/checkstyle/checkstyle/subscription","commits_url":"https://api.github.com/repos/checkstyle/checkstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/checkstyle/checkstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/checkstyle/checkstyle/contents/{+path}","compare_url":"https://api.github.com/repos/checkstyle/checkstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/checkstyle/checkstyle/merges","archive_url":"https://api.github.com/repos/checkstyle/checkstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/checkstyle/checkstyle/downloads","issues_url":"https://api.github.com/repos/checkstyle/checkstyle/issues{/number}","pulls_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/checkstyle/checkstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/checkstyle/checkstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/labels{/name}","releases_url":"https://api.github.com/repos/checkstyle/checkstyle/releases{/id}","created_at":"2013-08-31T02:05:05Z","updated_at":"2015-09-14T03:14:33Z","pushed_at":"2015-09-14T16:59:03Z","git_url":"git://github.com/checkstyle/checkstyle.git","ssh_url":"git@github.com:checkstyle/checkstyle.git","clone_url":"https://github.com/checkstyle/checkstyle.git","svn_url":"https://github.com/checkstyle/checkstyle","homepage":"http://checkstyle.sourceforge.net/","size":66346,"stargazers_count":509,"watchers_count":509,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":271,"mirror_url":null,"open_issues_count":190,"forks":271,"open_issues":190,"watchers":509,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2180"},"html":{"href":"https://github.com/checkstyle/checkstyle/pull/2180"},"issue":{"href":"https://api.github.com/repos/checkstyle/checkstyle/issues/2180"},"comments":{"href":"https://api.github.com/repos/checkstyle/checkstyle/issues/2180/comments"},"review_comments":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2180/comments"},"review_comment":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2180/commits"},"statuses":{"href":"https://api.github.com/repos/checkstyle/checkstyle/statuses/2bcabed86b151921547445af3b12ad51bc6c532d"}}}}