{"action":"closed","number":137,"pull_request":{"url":"https://api.github.com/repos/jdbi/jdbi/pulls/137","id":28058815,"html_url":"https://github.com/jdbi/jdbi/pull/137","diff_url":"https://github.com/jdbi/jdbi/pull/137.diff","patch_url":"https://github.com/jdbi/jdbi/pull/137.patch","issue_url":"https://api.github.com/repos/jdbi/jdbi/issues/137","number":137,"state":"closed","locked":false,"title":"Cache original query, not key","user":{"login":"HiJon89","id":611459,"avatar_url":"https://avatars.githubusercontent.com/u/611459?v=3","gravatar_id":"","url":"https://api.github.com/users/HiJon89","html_url":"https://github.com/HiJon89","followers_url":"https://api.github.com/users/HiJon89/followers","following_url":"https://api.github.com/users/HiJon89/following{/other_user}","gists_url":"https://api.github.com/users/HiJon89/gists{/gist_id}","starred_url":"https://api.github.com/users/HiJon89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HiJon89/subscriptions","organizations_url":"https://api.github.com/users/HiJon89/orgs","repos_url":"https://api.github.com/users/HiJon89/repos","events_url":"https://api.github.com/users/HiJon89/events{/privacy}","received_events_url":"https://api.github.com/users/HiJon89/received_events","type":"User","site_admin":false},"body":"It looks like dd1e5ac25043c27f29a2509d2e64221667b530f7 introduced a pretty serious bug in `ClasspathStatementLocator` that we found when upgrading to 2.58. It was inserting `cache_key` instead of `name`, which seems to open up the possibility of the memory leak it was trying to prevent, but more importantly `cache_key` has the FQCN of the SqlObjectType prepended. Additionally, MySQL `replace` queries were sneaking past the `looksLikeSql` check. The end result was that our queries were getting transformed from something like `REPLACE INTO table (columns) VALUES (:values)` to `com/hubspot/ExampleDao/REPLACE INTO table (columns) VALUES (:values)` which is obviously invalid\r\n\r\n@hgschmie @stevenschlansker ","created_at":"2015-01-26T20:47:12Z","updated_at":"2015-01-26T22:02:59Z","closed_at":"2015-01-26T22:02:59Z","merged_at":"2015-01-26T22:02:59Z","merge_commit_sha":"b711bda73a6396f0825c573a7a1e109f8071ede4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jdbi/jdbi/pulls/137/commits","review_comments_url":"https://api.github.com/repos/jdbi/jdbi/pulls/137/comments","review_comment_url":"https://api.github.com/repos/jdbi/jdbi/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jdbi/jdbi/issues/137/comments","statuses_url":"https://api.github.com/repos/jdbi/jdbi/statuses/2e6a89408c7bd116686050093ab8e5f387c82038","head":{"label":"HiJon89:master","ref":"master","sha":"2e6a89408c7bd116686050093ab8e5f387c82038","user":{"login":"HiJon89","id":611459,"avatar_url":"https://avatars.githubusercontent.com/u/611459?v=3","gravatar_id":"","url":"https://api.github.com/users/HiJon89","html_url":"https://github.com/HiJon89","followers_url":"https://api.github.com/users/HiJon89/followers","following_url":"https://api.github.com/users/HiJon89/following{/other_user}","gists_url":"https://api.github.com/users/HiJon89/gists{/gist_id}","starred_url":"https://api.github.com/users/HiJon89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HiJon89/subscriptions","organizations_url":"https://api.github.com/users/HiJon89/orgs","repos_url":"https://api.github.com/users/HiJon89/repos","events_url":"https://api.github.com/users/HiJon89/events{/privacy}","received_events_url":"https://api.github.com/users/HiJon89/received_events","type":"User","site_admin":false},"repo":{"id":29880194,"name":"jdbi","full_name":"HiJon89/jdbi","owner":{"login":"HiJon89","id":611459,"avatar_url":"https://avatars.githubusercontent.com/u/611459?v=3","gravatar_id":"","url":"https://api.github.com/users/HiJon89","html_url":"https://github.com/HiJon89","followers_url":"https://api.github.com/users/HiJon89/followers","following_url":"https://api.github.com/users/HiJon89/following{/other_user}","gists_url":"https://api.github.com/users/HiJon89/gists{/gist_id}","starred_url":"https://api.github.com/users/HiJon89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HiJon89/subscriptions","organizations_url":"https://api.github.com/users/HiJon89/orgs","repos_url":"https://api.github.com/users/HiJon89/repos","events_url":"https://api.github.com/users/HiJon89/events{/privacy}","received_events_url":"https://api.github.com/users/HiJon89/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HiJon89/jdbi","description":"jDBI is designed to provide convenient tabular data access in Java(tm). It uses the Java collections framework for query results, provides a convenient means of externalizing sql statements, and provides named parameter support for any database being used.","fork":true,"url":"https://api.github.com/repos/HiJon89/jdbi","forks_url":"https://api.github.com/repos/HiJon89/jdbi/forks","keys_url":"https://api.github.com/repos/HiJon89/jdbi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HiJon89/jdbi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HiJon89/jdbi/teams","hooks_url":"https://api.github.com/repos/HiJon89/jdbi/hooks","issue_events_url":"https://api.github.com/repos/HiJon89/jdbi/issues/events{/number}","events_url":"https://api.github.com/repos/HiJon89/jdbi/events","assignees_url":"https://api.github.com/repos/HiJon89/jdbi/assignees{/user}","branches_url":"https://api.github.com/repos/HiJon89/jdbi/branches{/branch}","tags_url":"https://api.github.com/repos/HiJon89/jdbi/tags","blobs_url":"https://api.github.com/repos/HiJon89/jdbi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HiJon89/jdbi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HiJon89/jdbi/git/refs{/sha}","trees_url":"https://api.github.com/repos/HiJon89/jdbi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HiJon89/jdbi/statuses/{sha}","languages_url":"https://api.github.com/repos/HiJon89/jdbi/languages","stargazers_url":"https://api.github.com/repos/HiJon89/jdbi/stargazers","contributors_url":"https://api.github.com/repos/HiJon89/jdbi/contributors","subscribers_url":"https://api.github.com/repos/HiJon89/jdbi/subscribers","subscription_url":"https://api.github.com/repos/HiJon89/jdbi/subscription","commits_url":"https://api.github.com/repos/HiJon89/jdbi/commits{/sha}","git_commits_url":"https://api.github.com/repos/HiJon89/jdbi/git/commits{/sha}","comments_url":"https://api.github.com/repos/HiJon89/jdbi/comments{/number}","issue_comment_url":"https://api.github.com/repos/HiJon89/jdbi/issues/comments/{number}","contents_url":"https://api.github.com/repos/HiJon89/jdbi/contents/{+path}","compare_url":"https://api.github.com/repos/HiJon89/jdbi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HiJon89/jdbi/merges","archive_url":"https://api.github.com/repos/HiJon89/jdbi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HiJon89/jdbi/downloads","issues_url":"https://api.github.com/repos/HiJon89/jdbi/issues{/number}","pulls_url":"https://api.github.com/repos/HiJon89/jdbi/pulls{/number}","milestones_url":"https://api.github.com/repos/HiJon89/jdbi/milestones{/number}","notifications_url":"https://api.github.com/repos/HiJon89/jdbi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HiJon89/jdbi/labels{/name}","releases_url":"https://api.github.com/repos/HiJon89/jdbi/releases{/id}","created_at":"2015-01-26T20:31:37Z","updated_at":"2015-01-26T21:28:13Z","pushed_at":"2015-01-26T21:28:13Z","git_url":"git://github.com/HiJon89/jdbi.git","ssh_url":"git@github.com:HiJon89/jdbi.git","clone_url":"https://github.com/HiJon89/jdbi.git","svn_url":"https://github.com/HiJon89/jdbi","homepage":"http://jdbi.org/","size":12930,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jdbi:master","ref":"master","sha":"7c35508881b033403e82fb6c4a11d8904d68bc87","user":{"login":"jdbi","id":9668860,"avatar_url":"https://avatars.githubusercontent.com/u/9668860?v=3","gravatar_id":"","url":"https://api.github.com/users/jdbi","html_url":"https://github.com/jdbi","followers_url":"https://api.github.com/users/jdbi/followers","following_url":"https://api.github.com/users/jdbi/following{/other_user}","gists_url":"https://api.github.com/users/jdbi/gists{/gist_id}","starred_url":"https://api.github.com/users/jdbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdbi/subscriptions","organizations_url":"https://api.github.com/users/jdbi/orgs","repos_url":"https://api.github.com/users/jdbi/repos","events_url":"https://api.github.com/users/jdbi/events{/privacy}","received_events_url":"https://api.github.com/users/jdbi/received_events","type":"Organization","site_admin":false},"repo":{"id":229738,"name":"jdbi","full_name":"jdbi/jdbi","owner":{"login":"jdbi","id":9668860,"avatar_url":"https://avatars.githubusercontent.com/u/9668860?v=3","gravatar_id":"","url":"https://api.github.com/users/jdbi","html_url":"https://github.com/jdbi","followers_url":"https://api.github.com/users/jdbi/followers","following_url":"https://api.github.com/users/jdbi/following{/other_user}","gists_url":"https://api.github.com/users/jdbi/gists{/gist_id}","starred_url":"https://api.github.com/users/jdbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdbi/subscriptions","organizations_url":"https://api.github.com/users/jdbi/orgs","repos_url":"https://api.github.com/users/jdbi/repos","events_url":"https://api.github.com/users/jdbi/events{/privacy}","received_events_url":"https://api.github.com/users/jdbi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jdbi/jdbi","description":"jDBI is designed to provide convenient tabular data access in Java(tm). It uses the Java collections framework for query results, provides a convenient means of externalizing sql statements, and provides named parameter support for any database being used.","fork":false,"url":"https://api.github.com/repos/jdbi/jdbi","forks_url":"https://api.github.com/repos/jdbi/jdbi/forks","keys_url":"https://api.github.com/repos/jdbi/jdbi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdbi/jdbi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdbi/jdbi/teams","hooks_url":"https://api.github.com/repos/jdbi/jdbi/hooks","issue_events_url":"https://api.github.com/repos/jdbi/jdbi/issues/events{/number}","events_url":"https://api.github.com/repos/jdbi/jdbi/events","assignees_url":"https://api.github.com/repos/jdbi/jdbi/assignees{/user}","branches_url":"https://api.github.com/repos/jdbi/jdbi/branches{/branch}","tags_url":"https://api.github.com/repos/jdbi/jdbi/tags","blobs_url":"https://api.github.com/repos/jdbi/jdbi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdbi/jdbi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdbi/jdbi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdbi/jdbi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdbi/jdbi/statuses/{sha}","languages_url":"https://api.github.com/repos/jdbi/jdbi/languages","stargazers_url":"https://api.github.com/repos/jdbi/jdbi/stargazers","contributors_url":"https://api.github.com/repos/jdbi/jdbi/contributors","subscribers_url":"https://api.github.com/repos/jdbi/jdbi/subscribers","subscription_url":"https://api.github.com/repos/jdbi/jdbi/subscription","commits_url":"https://api.github.com/repos/jdbi/jdbi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdbi/jdbi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdbi/jdbi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdbi/jdbi/issues/comments/{number}","contents_url":"https://api.github.com/repos/jdbi/jdbi/contents/{+path}","compare_url":"https://api.github.com/repos/jdbi/jdbi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdbi/jdbi/merges","archive_url":"https://api.github.com/repos/jdbi/jdbi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdbi/jdbi/downloads","issues_url":"https://api.github.com/repos/jdbi/jdbi/issues{/number}","pulls_url":"https://api.github.com/repos/jdbi/jdbi/pulls{/number}","milestones_url":"https://api.github.com/repos/jdbi/jdbi/milestones{/number}","notifications_url":"https://api.github.com/repos/jdbi/jdbi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdbi/jdbi/labels{/name}","releases_url":"https://api.github.com/repos/jdbi/jdbi/releases{/id}","created_at":"2009-06-17T16:36:36Z","updated_at":"2015-01-26T22:03:00Z","pushed_at":"2015-01-26T22:03:00Z","git_url":"git://github.com/jdbi/jdbi.git","ssh_url":"git@github.com:jdbi/jdbi.git","clone_url":"https://github.com/jdbi/jdbi.git","svn_url":"https://github.com/jdbi/jdbi","homepage":"http://jdbi.org/","size":12930,"stargazers_count":393,"watchers_count":393,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":95,"mirror_url":null,"open_issues_count":26,"forks":95,"open_issues":26,"watchers":393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/137"},"html":{"href":"https://github.com/jdbi/jdbi/pull/137"},"issue":{"href":"https://api.github.com/repos/jdbi/jdbi/issues/137"},"comments":{"href":"https://api.github.com/repos/jdbi/jdbi/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jdbi/jdbi/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/jdbi/jdbi/statuses/2e6a89408c7bd116686050093ab8e5f387c82038"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"stevenschlansker","id":129097,"avatar_url":"https://avatars.githubusercontent.com/u/129097?v=3","gravatar_id":"","url":"https://api.github.com/users/stevenschlansker","html_url":"https://github.com/stevenschlansker","followers_url":"https://api.github.com/users/stevenschlansker/followers","following_url":"https://api.github.com/users/stevenschlansker/following{/other_user}","gists_url":"https://api.github.com/users/stevenschlansker/gists{/gist_id}","starred_url":"https://api.github.com/users/stevenschlansker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevenschlansker/subscriptions","organizations_url":"https://api.github.com/users/stevenschlansker/orgs","repos_url":"https://api.github.com/users/stevenschlansker/repos","events_url":"https://api.github.com/users/stevenschlansker/events{/privacy}","received_events_url":"https://api.github.com/users/stevenschlansker/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"commits":2,"additions":28,"deletions":2,"changed_files":2}}