{"action":"created","comment":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/44709091","id":44709091,"diff_hunk":"@@ -109,14 +109,14 @@ confederation_id:\n     config_set_append: '<state> confederation identifier <id>'\n \n confederation_peers:\n-  # TODO: Supported in XR but broken as identifier is nvgened on a seperate line.\n   default_value: \"\"","path":"lib/cisco_node_utils/cmd_ref/bgp.yaml","position":5,"original_position":5,"commit_id":"e2a02532fd56577eaad33aae9094fe49a9be30a6","original_commit_id":"e2a02532fd56577eaad33aae9094fe49a9be30a6","user":{"login":"robert-w-gries","id":7546625,"avatar_url":"https://avatars.githubusercontent.com/u/7546625?v=3","gravatar_id":"","url":"https://api.github.com/users/robert-w-gries","html_url":"https://github.com/robert-w-gries","followers_url":"https://api.github.com/users/robert-w-gries/followers","following_url":"https://api.github.com/users/robert-w-gries/following{/other_user}","gists_url":"https://api.github.com/users/robert-w-gries/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-w-gries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-w-gries/subscriptions","organizations_url":"https://api.github.com/users/robert-w-gries/orgs","repos_url":"https://api.github.com/users/robert-w-gries/repos","events_url":"https://api.github.com/users/robert-w-gries/events{/privacy}","received_events_url":"https://api.github.com/users/robert-w-gries/received_events","type":"User","site_admin":false},"body":"Good call!","created_at":"2015-11-12T20:20:55Z","updated_at":"2015-11-12T20:20:55Z","html_url":"https://github.com/cisco/cisco-network-node-utils/pull/78#discussion_r44709091","pull_request_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/44709091"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/78#discussion_r44709091"},"pull_request":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/78","id":50554302,"html_url":"https://github.com/cisco/cisco-network-node-utils/pull/78","diff_url":"https://github.com/cisco/cisco-network-node-utils/pull/78.diff","patch_url":"https://github.com/cisco/cisco-network-node-utils/pull/78.patch","issue_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/78","number":78,"state":"open","locked":false,"title":"Feature/grpc confed","user":{"login":"RichWellum","id":10466025,"avatar_url":"https://avatars.githubusercontent.com/u/10466025?v=3","gravatar_id":"","url":"https://api.github.com/users/RichWellum","html_url":"https://github.com/RichWellum","followers_url":"https://api.github.com/users/RichWellum/followers","following_url":"https://api.github.com/users/RichWellum/following{/other_user}","gists_url":"https://api.github.com/users/RichWellum/gists{/gist_id}","starred_url":"https://api.github.com/users/RichWellum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichWellum/subscriptions","organizations_url":"https://api.github.com/users/RichWellum/orgs","repos_url":"https://api.github.com/users/RichWellum/repos","events_url":"https://api.github.com/users/RichWellum/events{/privacy}","received_events_url":"https://api.github.com/users/RichWellum/received_events","type":"User","site_admin":false},"body":"Note: there is an associated puppet change that is needed to run this manifest and that's going to be a separate review.\r\n\r\nChanges to make bgp confederation peers work on XR.\r\n\r\nChange the setter to use the delta functionality introduced recently.\r\n\r\nMini test on both platforms:\r\n\r\nXrv9k:\r\n```\r\nFinished in 478.095544s, 0.1129 runs/s, 0.2886 assertions/s.\r\n54 runs, 138 assertions, 0 failures, 0 errors, 24 skips\r\n```\r\nNexus:\r\n```\r\nFinished in 595.645666s, 0.0907 runs/s, 0.3693 assertions/s.\r\n54 runs, 220 assertions, 0 failures, 0 errors, 0 skips\r\n```\r\nAdding confed peers to my bgp manifest:\r\n\r\nroot@rtp-puppetserver228:~/cisco-network-puppet-module# cat /etc/puppetlabs/code/environments/production/manifests/site.pp\r\n```puppet\r\nclass ciscopuppet::demo_bgp {\r\n  cisco_bgp { 'default_vrf_global':\r\n    ensure                                 => present,\r\n    asn                                    => 55.77,\r\n    vrf                                    => 'default',\r\n    router_id                              => '1.1.1.1',\r\n\r\n    # Graceful Restart Properties\r\n    graceful_restart                       => true,\r\n\r\n    # Inherited Properties - applied to VRF but configured globally\r\n    confederation_id                       => '33',\r\n    confederation_peers                    => '999',\r\n    cluster_id                             => '55',\r\n    graceful_restart_timers_restart        => '131',\r\n    graceful_restart_timers_stalepath_time => '311',\r\n    bestpath_med_confed                    => true,\r\n  } \r\n}\r\n```\r\nResults in:\r\n```\r\nInfo: Loading facts\r\nInfo: Caching catalog for sunstoneabc.cisco.com\r\nInfo: Applying configuration version '1447352626'\r\nNotice: Applied catalog in 2.18 seconds\r\n\r\nRP/0/RP0/CPU0:ios#sh run router bgp\r\nThu Nov 12 18:35:16.666 UTC\r\nrouter bgp 3604557\r\n bgp confederation peers\r\n  999\r\n !\r\n bgp confederation identifier 33\r\n bgp router-id 1.1.1.1\r\n bgp cluster-id 55\r\n bgp graceful-restart restart-time 131\r\n bgp graceful-restart stalepath-time 311\r\n bgp graceful-restart\r\n bgp bestpath med confed\r\n vrf blue\r\n  rd auto\r\n  timers bgp 46 111\r\n  bgp router-id 192.168.0.66\r\n  bgp bestpath cost-community ignore\r\n  bgp bestpath med always\r\n  bgp bestpath compare-routerid\r\n  bgp bestpath as-path multipath-relax\r\n !\r\n!\r\n```\r\nChanging the peer to a list and expecting a CLI error:\r\n\r\n```puppet\r\n    confederation_peers                    => '999 44 55.77 22 1001 1003 88',\r\n```\r\n```\r\nNotice: /Stage[main]/Ciscopuppet::Demo_bgp/Cisco_bgp[default_vrf_global]/confederation_peers: confederation_peers changed '999' to '999 44 55.77 22 1001 1003 88'\r\nError: /Stage[main]/Ciscopuppet::Demo_bgp/Cisco_bgp[default_vrf_global]: Could not evaluate: CliError: 'input TODO' rejected with message:\r\n'[\"'BGP' detected the 'warning' condition 'Local member-AS not allowed in confed peer list'\"]'\r\nNotice: Applied catalog in 3.93 seconds\r\n```\r\nChange it to a working range of peers:\r\n\r\n```puppet\r\n    confederation_peers                    => '999 44 55.77 22 1001 1003 88',\r\n```\r\n```\r\nNotice: /Stage[main]/Ciscopuppet::Demo_bgp/Cisco_bgp[default_vrf_global]/confederation_peers: confederation_peers changed '1001 1003 22 44 88 999' to '999 44 22 1001 1003 88'\r\n```\r\n```\r\nRP/0/RP0/CPU0:ios#sh run router bgp 3604557 bgp confederation peers\r\nThu Nov 12 19:15:18.091 UTC\r\nrouter bgp 3604557\r\n bgp confederation peers\r\n  22\r\n  44\r\n  88\r\n  999\r\n  1001\r\n  1003\r\n !\r\n!\r\n```","created_at":"2015-11-12T19:16:59Z","updated_at":"2015-11-12T20:20:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48301cf37040ac8c16219ba78b47f6f563a5ac33","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/78/commits","review_comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/78/comments","review_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/78/comments","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/e2a02532fd56577eaad33aae9094fe49a9be30a6","head":{"label":"cisco:feature/grpc-confed","ref":"feature/grpc-confed","sha":"e2a02532fd56577eaad33aae9094fe49a9be30a6","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565196,"name":"cisco-network-node-utils","full_name":"cisco/cisco-network-node-utils","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-node-utils","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-node-utils","forks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/releases{/id}","created_at":"2015-07-23T12:07:39Z","updated_at":"2015-11-12T06:34:19Z","pushed_at":"2015-11-12T19:16:59Z","git_url":"git://github.com/cisco/cisco-network-node-utils.git","ssh_url":"git@github.com:cisco/cisco-network-node-utils.git","clone_url":"https://github.com/cisco/cisco-network-node-utils.git","svn_url":"https://github.com/cisco/cisco-network-node-utils","homepage":null,"size":2873,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":4,"forks":22,"open_issues":4,"watchers":7,"default_branch":"develop"}},"base":{"label":"cisco:feature/grpc","ref":"feature/grpc","sha":"6f8731a3c35f33eedc094f6f4b40240c43c8580a","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565196,"name":"cisco-network-node-utils","full_name":"cisco/cisco-network-node-utils","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-node-utils","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-node-utils","forks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/releases{/id}","created_at":"2015-07-23T12:07:39Z","updated_at":"2015-11-12T06:34:19Z","pushed_at":"2015-11-12T19:16:59Z","git_url":"git://github.com/cisco/cisco-network-node-utils.git","ssh_url":"git@github.com:cisco/cisco-network-node-utils.git","clone_url":"https://github.com/cisco/cisco-network-node-utils.git","svn_url":"https://github.com/cisco/cisco-network-node-utils","homepage":null,"size":2873,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":4,"forks":22,"open_issues":4,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/78"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/78"},"issue":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/78"},"comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/e2a02532fd56577eaad33aae9094fe49a9be30a6"}}}}