{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/pulls/comments/37070052","id":37070052,"diff_hunk":"@@ -40,19 +42,25 @@ def test_urn_invalid_database(self):\n \n     def test_is_valid_urn_format(self):\n         good_urns = [\n-            \"06/AA/0000000/00\",\n+            \"06/AA/12345/99\",\n+            \"06/AA/0012345/99\",\n             \"06/bb/1234567/12\",\n             \"06/JJ/50563/14\",\n             \"06/JJ/50534/14\",\n+            \"06AB/12345/99\",\n+            \"06AB12345/99\",\n+            \"06AB123456711\"\n         ]\n         bad_urns = [\n             \"123\",\n-            \"00bb/0000000/00\",","path":"apps/plea/tests/test_validators.py","position":33,"original_position":33,"commit_id":"afe0031d03f44e0a826b2a3bfa8e3d8eafbd403e","original_commit_id":"afe0031d03f44e0a826b2a3bfa8e3d8eafbd403e","user":{"login":"elbeanio","id":454689,"avatar_url":"https://avatars.githubusercontent.com/u/454689?v=3","gravatar_id":"","url":"https://api.github.com/users/elbeanio","html_url":"https://github.com/elbeanio","followers_url":"https://api.github.com/users/elbeanio/followers","following_url":"https://api.github.com/users/elbeanio/following{/other_user}","gists_url":"https://api.github.com/users/elbeanio/gists{/gist_id}","starred_url":"https://api.github.com/users/elbeanio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elbeanio/subscriptions","organizations_url":"https://api.github.com/users/elbeanio/orgs","repos_url":"https://api.github.com/users/elbeanio/repos","events_url":"https://api.github.com/users/elbeanio/events{/privacy}","received_events_url":"https://api.github.com/users/elbeanio/received_events","type":"User","site_admin":false},"body":"Why is 00bb/0000000/00 a bad URN?\r\n\r\nThey miss out the first slash in Staffordshire I think.","created_at":"2015-08-14T12:03:24Z","updated_at":"2015-08-14T12:03:24Z","html_url":"https://github.com/ministryofjustice/manchester_traffic_offences_pleas/pull/198#discussion_r37070052","pull_request_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/pulls/198","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/pulls/comments/37070052"},"html":{"href":"https://github.com/ministryofjustice/manchester_traffic_offences_pleas/pull/198#discussion_r37070052"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/pulls/198","id":42362385,"html_url":"https://github.com/ministryofjustice/manchester_traffic_offences_pleas/pull/198","diff_url":"https://github.com/ministryofjustice/manchester_traffic_offences_pleas/pull/198.diff","patch_url":"https://github.com/ministryofjustice/manchester_traffic_offences_pleas/pull/198.patch","issue_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/issues/198","number":198,"state":"open","locked":false,"title":"Universal URN entry field","user":{"login":"froddd","id":496382,"avatar_url":"https://avatars.githubusercontent.com/u/496382?v=3","gravatar_id":"","url":"https://api.github.com/users/froddd","html_url":"https://github.com/froddd","followers_url":"https://api.github.com/users/froddd/followers","following_url":"https://api.github.com/users/froddd/following{/other_user}","gists_url":"https://api.github.com/users/froddd/gists{/gist_id}","starred_url":"https://api.github.com/users/froddd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/froddd/subscriptions","organizations_url":"https://api.github.com/users/froddd/orgs","repos_url":"https://api.github.com/users/froddd/repos","events_url":"https://api.github.com/users/froddd/events{/privacy}","received_events_url":"https://api.github.com/users/froddd/received_events","type":"User","site_admin":false},"body":"Freeform entry field replaces split fields to allow entry\r\nof freeform URNs. The URN is automatically standardised and\r\nslashified, but users can omit slashes when entering the URN,\r\nto allow extra flexibility in respects to variations in notice\r\nformats between regions.\r\n\r\nCourt finder updated to new field; validation for this has\r\nalso been streamlined and uses correct validator: this also allows\r\nproperly translating the error message, which wasn't yet done.\r\n\r\nValidators moved out of fields.py.\r\nTests updated for all validators (including date ones).\r\n\r\nAlso fixed JS issue: Google Analytics wasn't defined on\r\nComplete screen locally.\r\n\r\n[MAPDEV374]","created_at":"2015-08-13T15:17:00Z","updated_at":"2015-08-14T12:03:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a15230bb9c559b0fde874cfe76a81a09f13f17ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/pulls/198/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/pulls/198/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/issues/198/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/statuses/afe0031d03f44e0a826b2a3bfa8e3d8eafbd403e","head":{"label":"ministryofjustice:MAPDEV374-universal_URN_field","ref":"MAPDEV374-universal_URN_field","sha":"afe0031d03f44e0a826b2a3bfa8e3d8eafbd403e","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":19695722,"name":"manchester_traffic_offences_pleas","full_name":"ministryofjustice/manchester_traffic_offences_pleas","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/manchester_traffic_offences_pleas","description":"Manchester Traffic Offences","fork":false,"url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas","forks_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/forks","keys_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/events","assignees_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/merges","archive_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/releases{/id}","created_at":"2014-05-12T11:13:00Z","updated_at":"2015-05-07T12:37:27Z","pushed_at":"2015-08-13T15:17:00Z","git_url":"git://github.com/ministryofjustice/manchester_traffic_offences_pleas.git","ssh_url":"git@github.com:ministryofjustice/manchester_traffic_offences_pleas.git","clone_url":"https://github.com/ministryofjustice/manchester_traffic_offences_pleas.git","svn_url":"https://github.com/ministryofjustice/manchester_traffic_offences_pleas","homepage":null,"size":5750,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"c87135743adefbd62ee96af80797613e622afb43","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":19695722,"name":"manchester_traffic_offences_pleas","full_name":"ministryofjustice/manchester_traffic_offences_pleas","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/manchester_traffic_offences_pleas","description":"Manchester Traffic Offences","fork":false,"url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas","forks_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/forks","keys_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/events","assignees_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/merges","archive_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/releases{/id}","created_at":"2014-05-12T11:13:00Z","updated_at":"2015-05-07T12:37:27Z","pushed_at":"2015-08-13T15:17:00Z","git_url":"git://github.com/ministryofjustice/manchester_traffic_offences_pleas.git","ssh_url":"git@github.com:ministryofjustice/manchester_traffic_offences_pleas.git","clone_url":"https://github.com/ministryofjustice/manchester_traffic_offences_pleas.git","svn_url":"https://github.com/ministryofjustice/manchester_traffic_offences_pleas","homepage":null,"size":5750,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/pulls/198"},"html":{"href":"https://github.com/ministryofjustice/manchester_traffic_offences_pleas/pull/198"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/issues/198"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/manchester_traffic_offences_pleas/statuses/afe0031d03f44e0a826b2a3bfa8e3d8eafbd403e"}}}}