{"action":"created","comment":{"url":"https://api.github.com/repos/warmshowers/wsandroid/pulls/comments/42300673","id":42300673,"diff_hunk":"@@ -4,7 +4,6 @@\n     <style name=\"wsAppTheme\" parent=\"Theme.AppCompat.Light.NoActionBar\">\n         <item name=\"colorPrimary\">@color/primaryColor</item>\n         <item name=\"colorPrimaryDark\">@color/primaryColorDark</item>\n-        <item name=\"statusBarColor\">@color/primaryColorDark</item>","path":"app/src/main/res/values-v21/styles.xml","position":4,"original_position":4,"commit_id":"098e3c190d359120cf654cbfb27e4f5fb65edd76","original_commit_id":"098e3c190d359120cf654cbfb27e4f5fb65edd76","user":{"login":"kirbydcool","id":696150,"avatar_url":"https://avatars.githubusercontent.com/u/696150?v=3","gravatar_id":"","url":"https://api.github.com/users/kirbydcool","html_url":"https://github.com/kirbydcool","followers_url":"https://api.github.com/users/kirbydcool/followers","following_url":"https://api.github.com/users/kirbydcool/following{/other_user}","gists_url":"https://api.github.com/users/kirbydcool/gists{/gist_id}","starred_url":"https://api.github.com/users/kirbydcool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirbydcool/subscriptions","organizations_url":"https://api.github.com/users/kirbydcool/orgs","repos_url":"https://api.github.com/users/kirbydcool/repos","events_url":"https://api.github.com/users/kirbydcool/events{/privacy}","received_events_url":"https://api.github.com/users/kirbydcool/received_events","type":"User","site_admin":false},"body":"\"statusBarColor\" doesn't seem to be a valid item name and throws a compilation error. I think this worked before because the folder was incorrectly named \"values-21\" and was likely not parsed. The app looks fine without this line.","created_at":"2015-10-16T23:31:15Z","updated_at":"2015-10-16T23:31:15Z","html_url":"https://github.com/warmshowers/wsandroid/pull/247#discussion_r42300673","pull_request_url":"https://api.github.com/repos/warmshowers/wsandroid/pulls/247","_links":{"self":{"href":"https://api.github.com/repos/warmshowers/wsandroid/pulls/comments/42300673"},"html":{"href":"https://github.com/warmshowers/wsandroid/pull/247#discussion_r42300673"},"pull_request":{"href":"https://api.github.com/repos/warmshowers/wsandroid/pulls/247"}}},"pull_request":{"url":"https://api.github.com/repos/warmshowers/wsandroid/pulls/247","id":47851750,"html_url":"https://github.com/warmshowers/wsandroid/pull/247","diff_url":"https://github.com/warmshowers/wsandroid/pull/247.diff","patch_url":"https://github.com/warmshowers/wsandroid/pull/247.patch","issue_url":"https://api.github.com/repos/warmshowers/wsandroid/issues/247","number":247,"state":"open","locked":false,"title":"Port to modern gradle project structure","user":{"login":"kirbydcool","id":696150,"avatar_url":"https://avatars.githubusercontent.com/u/696150?v=3","gravatar_id":"","url":"https://api.github.com/users/kirbydcool","html_url":"https://github.com/kirbydcool","followers_url":"https://api.github.com/users/kirbydcool/followers","following_url":"https://api.github.com/users/kirbydcool/following{/other_user}","gists_url":"https://api.github.com/users/kirbydcool/gists{/gist_id}","starred_url":"https://api.github.com/users/kirbydcool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirbydcool/subscriptions","organizations_url":"https://api.github.com/users/kirbydcool/orgs","repos_url":"https://api.github.com/users/kirbydcool/repos","events_url":"https://api.github.com/users/kirbydcool/events{/privacy}","received_events_url":"https://api.github.com/users/kirbydcool/received_events","type":"User","site_admin":false},"body":"We should move to the updated android/gradle project structure. This page has a good outline.\r\nhttps://github.com/futurice/android-best-practices#project-structure\r\nAnd the official page: http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Project-Structure\r\n\r\nThis should make a our gradle configuration much easier since we can use the defaults implicitly. It should also make it easier for new collaborators to jump in since our structure will be closer to the norm.\r\n\r\nNOTE: This will probably mess up the merges for any other PRs open on the repo, so we probably want to pull this first and rebase the other ones.\r\n\r\n@rfay","created_at":"2015-10-15T22:45:02Z","updated_at":"2015-10-16T23:31:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b4acffaaacad97f882994f634045485201fdd6a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/warmshowers/wsandroid/pulls/247/commits","review_comments_url":"https://api.github.com/repos/warmshowers/wsandroid/pulls/247/comments","review_comment_url":"https://api.github.com/repos/warmshowers/wsandroid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/warmshowers/wsandroid/issues/247/comments","statuses_url":"https://api.github.com/repos/warmshowers/wsandroid/statuses/098e3c190d359120cf654cbfb27e4f5fb65edd76","head":{"label":"kirbydcool:kc_changeProjectStructure","ref":"kc_changeProjectStructure","sha":"098e3c190d359120cf654cbfb27e4f5fb65edd76","user":{"login":"kirbydcool","id":696150,"avatar_url":"https://avatars.githubusercontent.com/u/696150?v=3","gravatar_id":"","url":"https://api.github.com/users/kirbydcool","html_url":"https://github.com/kirbydcool","followers_url":"https://api.github.com/users/kirbydcool/followers","following_url":"https://api.github.com/users/kirbydcool/following{/other_user}","gists_url":"https://api.github.com/users/kirbydcool/gists{/gist_id}","starred_url":"https://api.github.com/users/kirbydcool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirbydcool/subscriptions","organizations_url":"https://api.github.com/users/kirbydcool/orgs","repos_url":"https://api.github.com/users/kirbydcool/repos","events_url":"https://api.github.com/users/kirbydcool/events{/privacy}","received_events_url":"https://api.github.com/users/kirbydcool/received_events","type":"User","site_admin":false},"repo":{"id":43780798,"name":"wsandroid","full_name":"kirbydcool/wsandroid","owner":{"login":"kirbydcool","id":696150,"avatar_url":"https://avatars.githubusercontent.com/u/696150?v=3","gravatar_id":"","url":"https://api.github.com/users/kirbydcool","html_url":"https://github.com/kirbydcool","followers_url":"https://api.github.com/users/kirbydcool/followers","following_url":"https://api.github.com/users/kirbydcool/following{/other_user}","gists_url":"https://api.github.com/users/kirbydcool/gists{/gist_id}","starred_url":"https://api.github.com/users/kirbydcool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirbydcool/subscriptions","organizations_url":"https://api.github.com/users/kirbydcool/orgs","repos_url":"https://api.github.com/users/kirbydcool/repos","events_url":"https://api.github.com/users/kirbydcool/events{/privacy}","received_events_url":"https://api.github.com/users/kirbydcool/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kirbydcool/wsandroid","description":"WarmShowers for Android","fork":true,"url":"https://api.github.com/repos/kirbydcool/wsandroid","forks_url":"https://api.github.com/repos/kirbydcool/wsandroid/forks","keys_url":"https://api.github.com/repos/kirbydcool/wsandroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kirbydcool/wsandroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kirbydcool/wsandroid/teams","hooks_url":"https://api.github.com/repos/kirbydcool/wsandroid/hooks","issue_events_url":"https://api.github.com/repos/kirbydcool/wsandroid/issues/events{/number}","events_url":"https://api.github.com/repos/kirbydcool/wsandroid/events","assignees_url":"https://api.github.com/repos/kirbydcool/wsandroid/assignees{/user}","branches_url":"https://api.github.com/repos/kirbydcool/wsandroid/branches{/branch}","tags_url":"https://api.github.com/repos/kirbydcool/wsandroid/tags","blobs_url":"https://api.github.com/repos/kirbydcool/wsandroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kirbydcool/wsandroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kirbydcool/wsandroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/kirbydcool/wsandroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kirbydcool/wsandroid/statuses/{sha}","languages_url":"https://api.github.com/repos/kirbydcool/wsandroid/languages","stargazers_url":"https://api.github.com/repos/kirbydcool/wsandroid/stargazers","contributors_url":"https://api.github.com/repos/kirbydcool/wsandroid/contributors","subscribers_url":"https://api.github.com/repos/kirbydcool/wsandroid/subscribers","subscription_url":"https://api.github.com/repos/kirbydcool/wsandroid/subscription","commits_url":"https://api.github.com/repos/kirbydcool/wsandroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/kirbydcool/wsandroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/kirbydcool/wsandroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/kirbydcool/wsandroid/issues/comments{/number}","contents_url":"https://api.github.com/repos/kirbydcool/wsandroid/contents/{+path}","compare_url":"https://api.github.com/repos/kirbydcool/wsandroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kirbydcool/wsandroid/merges","archive_url":"https://api.github.com/repos/kirbydcool/wsandroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kirbydcool/wsandroid/downloads","issues_url":"https://api.github.com/repos/kirbydcool/wsandroid/issues{/number}","pulls_url":"https://api.github.com/repos/kirbydcool/wsandroid/pulls{/number}","milestones_url":"https://api.github.com/repos/kirbydcool/wsandroid/milestones{/number}","notifications_url":"https://api.github.com/repos/kirbydcool/wsandroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kirbydcool/wsandroid/labels{/name}","releases_url":"https://api.github.com/repos/kirbydcool/wsandroid/releases{/id}","created_at":"2015-10-06T21:48:09Z","updated_at":"2015-10-06T21:48:11Z","pushed_at":"2015-10-16T23:20:16Z","git_url":"git://github.com/kirbydcool/wsandroid.git","ssh_url":"git@github.com:kirbydcool/wsandroid.git","clone_url":"https://github.com/kirbydcool/wsandroid.git","svn_url":"https://github.com/kirbydcool/wsandroid","homepage":"","size":5288,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"warmshowers:master","ref":"master","sha":"99c307057d005dae5f26a64f1339b55f4e5eba7d","user":{"login":"warmshowers","id":5882513,"avatar_url":"https://avatars.githubusercontent.com/u/5882513?v=3","gravatar_id":"","url":"https://api.github.com/users/warmshowers","html_url":"https://github.com/warmshowers","followers_url":"https://api.github.com/users/warmshowers/followers","following_url":"https://api.github.com/users/warmshowers/following{/other_user}","gists_url":"https://api.github.com/users/warmshowers/gists{/gist_id}","starred_url":"https://api.github.com/users/warmshowers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warmshowers/subscriptions","organizations_url":"https://api.github.com/users/warmshowers/orgs","repos_url":"https://api.github.com/users/warmshowers/repos","events_url":"https://api.github.com/users/warmshowers/events{/privacy}","received_events_url":"https://api.github.com/users/warmshowers/received_events","type":"Organization","site_admin":false},"repo":{"id":3242289,"name":"wsandroid","full_name":"warmshowers/wsandroid","owner":{"login":"warmshowers","id":5882513,"avatar_url":"https://avatars.githubusercontent.com/u/5882513?v=3","gravatar_id":"","url":"https://api.github.com/users/warmshowers","html_url":"https://github.com/warmshowers","followers_url":"https://api.github.com/users/warmshowers/followers","following_url":"https://api.github.com/users/warmshowers/following{/other_user}","gists_url":"https://api.github.com/users/warmshowers/gists{/gist_id}","starred_url":"https://api.github.com/users/warmshowers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warmshowers/subscriptions","organizations_url":"https://api.github.com/users/warmshowers/orgs","repos_url":"https://api.github.com/users/warmshowers/repos","events_url":"https://api.github.com/users/warmshowers/events{/privacy}","received_events_url":"https://api.github.com/users/warmshowers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/warmshowers/wsandroid","description":"WarmShowers for Android","fork":false,"url":"https://api.github.com/repos/warmshowers/wsandroid","forks_url":"https://api.github.com/repos/warmshowers/wsandroid/forks","keys_url":"https://api.github.com/repos/warmshowers/wsandroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/warmshowers/wsandroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/warmshowers/wsandroid/teams","hooks_url":"https://api.github.com/repos/warmshowers/wsandroid/hooks","issue_events_url":"https://api.github.com/repos/warmshowers/wsandroid/issues/events{/number}","events_url":"https://api.github.com/repos/warmshowers/wsandroid/events","assignees_url":"https://api.github.com/repos/warmshowers/wsandroid/assignees{/user}","branches_url":"https://api.github.com/repos/warmshowers/wsandroid/branches{/branch}","tags_url":"https://api.github.com/repos/warmshowers/wsandroid/tags","blobs_url":"https://api.github.com/repos/warmshowers/wsandroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/warmshowers/wsandroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/warmshowers/wsandroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/warmshowers/wsandroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/warmshowers/wsandroid/statuses/{sha}","languages_url":"https://api.github.com/repos/warmshowers/wsandroid/languages","stargazers_url":"https://api.github.com/repos/warmshowers/wsandroid/stargazers","contributors_url":"https://api.github.com/repos/warmshowers/wsandroid/contributors","subscribers_url":"https://api.github.com/repos/warmshowers/wsandroid/subscribers","subscription_url":"https://api.github.com/repos/warmshowers/wsandroid/subscription","commits_url":"https://api.github.com/repos/warmshowers/wsandroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/warmshowers/wsandroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/warmshowers/wsandroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/warmshowers/wsandroid/issues/comments{/number}","contents_url":"https://api.github.com/repos/warmshowers/wsandroid/contents/{+path}","compare_url":"https://api.github.com/repos/warmshowers/wsandroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/warmshowers/wsandroid/merges","archive_url":"https://api.github.com/repos/warmshowers/wsandroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/warmshowers/wsandroid/downloads","issues_url":"https://api.github.com/repos/warmshowers/wsandroid/issues{/number}","pulls_url":"https://api.github.com/repos/warmshowers/wsandroid/pulls{/number}","milestones_url":"https://api.github.com/repos/warmshowers/wsandroid/milestones{/number}","notifications_url":"https://api.github.com/repos/warmshowers/wsandroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/warmshowers/wsandroid/labels{/name}","releases_url":"https://api.github.com/repos/warmshowers/wsandroid/releases{/id}","created_at":"2012-01-22T21:41:33Z","updated_at":"2015-10-07T05:36:17Z","pushed_at":"2015-10-16T23:20:17Z","git_url":"git://github.com/warmshowers/wsandroid.git","ssh_url":"git@github.com:warmshowers/wsandroid.git","clone_url":"https://github.com/warmshowers/wsandroid.git","svn_url":"https://github.com/warmshowers/wsandroid","homepage":"","size":6024,"stargazers_count":18,"watchers_count":18,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":37,"forks":12,"open_issues":37,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/warmshowers/wsandroid/pulls/247"},"html":{"href":"https://github.com/warmshowers/wsandroid/pull/247"},"issue":{"href":"https://api.github.com/repos/warmshowers/wsandroid/issues/247"},"comments":{"href":"https://api.github.com/repos/warmshowers/wsandroid/issues/247/comments"},"review_comments":{"href":"https://api.github.com/repos/warmshowers/wsandroid/pulls/247/comments"},"review_comment":{"href":"https://api.github.com/repos/warmshowers/wsandroid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/warmshowers/wsandroid/pulls/247/commits"},"statuses":{"href":"https://api.github.com/repos/warmshowers/wsandroid/statuses/098e3c190d359120cf654cbfb27e4f5fb65edd76"}}}}