{"action":"created","comment":{"url":"https://api.github.com/repos/rams/barcode/pulls/comments/37757066","id":37757066,"diff_hunk":"@@ -0,0 +1,166 @@\n+from barcode import *\n+\n+import base64\n+import struct\n+import skip32\n+import code128\n+import os\n+\n+","path":"barcode_utils.py","position":9,"original_position":9,"commit_id":"a8b7fec1423cf33beee35c17d8361d618fb73a06","original_commit_id":"a8b7fec1423cf33beee35c17d8361d618fb73a06","user":{"login":"EliAndrewC","id":651592,"avatar_url":"https://avatars.githubusercontent.com/u/651592?v=3","gravatar_id":"","url":"https://api.github.com/users/EliAndrewC","html_url":"https://github.com/EliAndrewC","followers_url":"https://api.github.com/users/EliAndrewC/followers","following_url":"https://api.github.com/users/EliAndrewC/following{/other_user}","gists_url":"https://api.github.com/users/EliAndrewC/gists{/gist_id}","starred_url":"https://api.github.com/users/EliAndrewC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EliAndrewC/subscriptions","organizations_url":"https://api.github.com/users/EliAndrewC/orgs","repos_url":"https://api.github.com/users/EliAndrewC/repos","events_url":"https://api.github.com/users/EliAndrewC/events{/privacy}","received_events_url":"https://api.github.com/users/EliAndrewC/received_events","type":"User","site_admin":false},"body":"I'll omit my questions about things like why we're referring to ``self`` in a non-instance method, since the comment already notes that this is broken.","created_at":"2015-08-24T14:31:54Z","updated_at":"2015-08-24T14:31:54Z","html_url":"https://github.com/rams/barcode/pull/1#discussion_r37757066","pull_request_url":"https://api.github.com/repos/rams/barcode/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/rams/barcode/pulls/comments/37757066"},"html":{"href":"https://github.com/rams/barcode/pull/1#discussion_r37757066"},"pull_request":{"href":"https://api.github.com/repos/rams/barcode/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/rams/barcode/pulls/1","id":42669939,"html_url":"https://github.com/rams/barcode/pull/1","diff_url":"https://github.com/rams/barcode/pull/1.diff","patch_url":"https://github.com/rams/barcode/pull/1.patch","issue_url":"https://api.github.com/repos/rams/barcode/issues/1","number":1,"state":"closed","locked":false,"title":"Review WIP barcode code","user":{"login":"binary1230","id":5413064,"avatar_url":"https://avatars.githubusercontent.com/u/5413064?v=3","gravatar_id":"","url":"https://api.github.com/users/binary1230","html_url":"https://github.com/binary1230","followers_url":"https://api.github.com/users/binary1230/followers","following_url":"https://api.github.com/users/binary1230/following{/other_user}","gists_url":"https://api.github.com/users/binary1230/gists{/gist_id}","starred_url":"https://api.github.com/users/binary1230/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary1230/subscriptions","organizations_url":"https://api.github.com/users/binary1230/orgs","repos_url":"https://api.github.com/users/binary1230/repos","events_url":"https://api.github.com/users/binary1230/events{/privacy}","received_events_url":"https://api.github.com/users/binary1230/received_events","type":"User","site_admin":false},"body":"hey @EliAndrewC and @kitsuta, I could use your eyes on this code in the next day or so, we gotta print the badges so this code will be generating a ton of barcodes.  This is a new plugin for RAMS that does barcode-stuff, it started with https://github.com/magfest/barcode-generator and that code is now in here.\r\n\r\nI don't quite know how this stuff will integrate with the API and the checkin page, but, the functionality for converting between a barcode / badge# works, and there's unit tests for it.\r\n\r\nI suggest you check out the README first for what's actually going on here.\r\n\r\n@EliAndrewC I could use you eyes on anything I'm doing stupidly with python stuff when converting to bytes(), bytearray() and packing structs.  That part was pretty gnarly.\r\n\r\nI'll leave some comments inline.","created_at":"2015-08-18T07:46:58Z","updated_at":"2015-08-24T14:31:54Z","closed_at":"2015-08-21T12:29:26Z","merged_at":"2015-08-21T12:29:26Z","merge_commit_sha":"9deb38300ab08895ab0c0415a0207ad4d6d87643","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rams/barcode/pulls/1/commits","review_comments_url":"https://api.github.com/repos/rams/barcode/pulls/1/comments","review_comment_url":"https://api.github.com/repos/rams/barcode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rams/barcode/issues/1/comments","statuses_url":"https://api.github.com/repos/rams/barcode/statuses/a8b7fec1423cf33beee35c17d8361d618fb73a06","head":{"label":"rams:review","ref":"review","sha":"a8b7fec1423cf33beee35c17d8361d618fb73a06","user":{"login":"rams","id":13419938,"avatar_url":"https://avatars.githubusercontent.com/u/13419938?v=3","gravatar_id":"","url":"https://api.github.com/users/rams","html_url":"https://github.com/rams","followers_url":"https://api.github.com/users/rams/followers","following_url":"https://api.github.com/users/rams/following{/other_user}","gists_url":"https://api.github.com/users/rams/gists{/gist_id}","starred_url":"https://api.github.com/users/rams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rams/subscriptions","organizations_url":"https://api.github.com/users/rams/orgs","repos_url":"https://api.github.com/users/rams/repos","events_url":"https://api.github.com/users/rams/events{/privacy}","received_events_url":"https://api.github.com/users/rams/received_events","type":"Organization","site_admin":false},"repo":{"id":40928891,"name":"barcode","full_name":"rams/barcode","owner":{"login":"rams","id":13419938,"avatar_url":"https://avatars.githubusercontent.com/u/13419938?v=3","gravatar_id":"","url":"https://api.github.com/users/rams","html_url":"https://github.com/rams","followers_url":"https://api.github.com/users/rams/followers","following_url":"https://api.github.com/users/rams/following{/other_user}","gists_url":"https://api.github.com/users/rams/gists{/gist_id}","starred_url":"https://api.github.com/users/rams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rams/subscriptions","organizations_url":"https://api.github.com/users/rams/orgs","repos_url":"https://api.github.com/users/rams/repos","events_url":"https://api.github.com/users/rams/events{/privacy}","received_events_url":"https://api.github.com/users/rams/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rams/barcode","description":"barcode scanner support for RAMS","fork":false,"url":"https://api.github.com/repos/rams/barcode","forks_url":"https://api.github.com/repos/rams/barcode/forks","keys_url":"https://api.github.com/repos/rams/barcode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rams/barcode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rams/barcode/teams","hooks_url":"https://api.github.com/repos/rams/barcode/hooks","issue_events_url":"https://api.github.com/repos/rams/barcode/issues/events{/number}","events_url":"https://api.github.com/repos/rams/barcode/events","assignees_url":"https://api.github.com/repos/rams/barcode/assignees{/user}","branches_url":"https://api.github.com/repos/rams/barcode/branches{/branch}","tags_url":"https://api.github.com/repos/rams/barcode/tags","blobs_url":"https://api.github.com/repos/rams/barcode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rams/barcode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rams/barcode/git/refs{/sha}","trees_url":"https://api.github.com/repos/rams/barcode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rams/barcode/statuses/{sha}","languages_url":"https://api.github.com/repos/rams/barcode/languages","stargazers_url":"https://api.github.com/repos/rams/barcode/stargazers","contributors_url":"https://api.github.com/repos/rams/barcode/contributors","subscribers_url":"https://api.github.com/repos/rams/barcode/subscribers","subscription_url":"https://api.github.com/repos/rams/barcode/subscription","commits_url":"https://api.github.com/repos/rams/barcode/commits{/sha}","git_commits_url":"https://api.github.com/repos/rams/barcode/git/commits{/sha}","comments_url":"https://api.github.com/repos/rams/barcode/comments{/number}","issue_comment_url":"https://api.github.com/repos/rams/barcode/issues/comments{/number}","contents_url":"https://api.github.com/repos/rams/barcode/contents/{+path}","compare_url":"https://api.github.com/repos/rams/barcode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rams/barcode/merges","archive_url":"https://api.github.com/repos/rams/barcode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rams/barcode/downloads","issues_url":"https://api.github.com/repos/rams/barcode/issues{/number}","pulls_url":"https://api.github.com/repos/rams/barcode/pulls{/number}","milestones_url":"https://api.github.com/repos/rams/barcode/milestones{/number}","notifications_url":"https://api.github.com/repos/rams/barcode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rams/barcode/labels{/name}","releases_url":"https://api.github.com/repos/rams/barcode/releases{/id}","created_at":"2015-08-17T21:06:13Z","updated_at":"2015-08-17T21:07:00Z","pushed_at":"2015-08-21T15:35:13Z","git_url":"git://github.com/rams/barcode.git","ssh_url":"git@github.com:rams/barcode.git","clone_url":"https://github.com/rams/barcode.git","svn_url":"https://github.com/rams/barcode","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rams:empty","ref":"empty","sha":"011efce8424e7a69b710173c3e52892e24c3d9aa","user":{"login":"rams","id":13419938,"avatar_url":"https://avatars.githubusercontent.com/u/13419938?v=3","gravatar_id":"","url":"https://api.github.com/users/rams","html_url":"https://github.com/rams","followers_url":"https://api.github.com/users/rams/followers","following_url":"https://api.github.com/users/rams/following{/other_user}","gists_url":"https://api.github.com/users/rams/gists{/gist_id}","starred_url":"https://api.github.com/users/rams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rams/subscriptions","organizations_url":"https://api.github.com/users/rams/orgs","repos_url":"https://api.github.com/users/rams/repos","events_url":"https://api.github.com/users/rams/events{/privacy}","received_events_url":"https://api.github.com/users/rams/received_events","type":"Organization","site_admin":false},"repo":{"id":40928891,"name":"barcode","full_name":"rams/barcode","owner":{"login":"rams","id":13419938,"avatar_url":"https://avatars.githubusercontent.com/u/13419938?v=3","gravatar_id":"","url":"https://api.github.com/users/rams","html_url":"https://github.com/rams","followers_url":"https://api.github.com/users/rams/followers","following_url":"https://api.github.com/users/rams/following{/other_user}","gists_url":"https://api.github.com/users/rams/gists{/gist_id}","starred_url":"https://api.github.com/users/rams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rams/subscriptions","organizations_url":"https://api.github.com/users/rams/orgs","repos_url":"https://api.github.com/users/rams/repos","events_url":"https://api.github.com/users/rams/events{/privacy}","received_events_url":"https://api.github.com/users/rams/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rams/barcode","description":"barcode scanner support for RAMS","fork":false,"url":"https://api.github.com/repos/rams/barcode","forks_url":"https://api.github.com/repos/rams/barcode/forks","keys_url":"https://api.github.com/repos/rams/barcode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rams/barcode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rams/barcode/teams","hooks_url":"https://api.github.com/repos/rams/barcode/hooks","issue_events_url":"https://api.github.com/repos/rams/barcode/issues/events{/number}","events_url":"https://api.github.com/repos/rams/barcode/events","assignees_url":"https://api.github.com/repos/rams/barcode/assignees{/user}","branches_url":"https://api.github.com/repos/rams/barcode/branches{/branch}","tags_url":"https://api.github.com/repos/rams/barcode/tags","blobs_url":"https://api.github.com/repos/rams/barcode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rams/barcode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rams/barcode/git/refs{/sha}","trees_url":"https://api.github.com/repos/rams/barcode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rams/barcode/statuses/{sha}","languages_url":"https://api.github.com/repos/rams/barcode/languages","stargazers_url":"https://api.github.com/repos/rams/barcode/stargazers","contributors_url":"https://api.github.com/repos/rams/barcode/contributors","subscribers_url":"https://api.github.com/repos/rams/barcode/subscribers","subscription_url":"https://api.github.com/repos/rams/barcode/subscription","commits_url":"https://api.github.com/repos/rams/barcode/commits{/sha}","git_commits_url":"https://api.github.com/repos/rams/barcode/git/commits{/sha}","comments_url":"https://api.github.com/repos/rams/barcode/comments{/number}","issue_comment_url":"https://api.github.com/repos/rams/barcode/issues/comments{/number}","contents_url":"https://api.github.com/repos/rams/barcode/contents/{+path}","compare_url":"https://api.github.com/repos/rams/barcode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rams/barcode/merges","archive_url":"https://api.github.com/repos/rams/barcode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rams/barcode/downloads","issues_url":"https://api.github.com/repos/rams/barcode/issues{/number}","pulls_url":"https://api.github.com/repos/rams/barcode/pulls{/number}","milestones_url":"https://api.github.com/repos/rams/barcode/milestones{/number}","notifications_url":"https://api.github.com/repos/rams/barcode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rams/barcode/labels{/name}","releases_url":"https://api.github.com/repos/rams/barcode/releases{/id}","created_at":"2015-08-17T21:06:13Z","updated_at":"2015-08-17T21:07:00Z","pushed_at":"2015-08-21T15:35:13Z","git_url":"git://github.com/rams/barcode.git","ssh_url":"git@github.com:rams/barcode.git","clone_url":"https://github.com/rams/barcode.git","svn_url":"https://github.com/rams/barcode","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rams/barcode/pulls/1"},"html":{"href":"https://github.com/rams/barcode/pull/1"},"issue":{"href":"https://api.github.com/repos/rams/barcode/issues/1"},"comments":{"href":"https://api.github.com/repos/rams/barcode/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/rams/barcode/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/rams/barcode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rams/barcode/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/rams/barcode/statuses/a8b7fec1423cf33beee35c17d8361d618fb73a06"}}}}