{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/comments/35476786","id":35476786,"diff_hunk":"@@ -8,17 +8,16 @@\n   # automatically assign teams for the capstone\n   $autoteam  = false\n \n-  # list of classes that should be available in the console\n-  $classes   = [ 'users', 'apache', 'userprefs' ]\n-\n   if $::osfamily == 'windows' {\n     # Path to the student's working directory\n     $workdir = 'c:/puppetcode'\n-    $etcpath = 'C:/ProgramData/PuppetLabs/puppet/etc'\n+    $confdir = 'C:/ProgramData/PuppetLabs/puppet/etc'\n+    $codedir = 'C:/ProgramData/PuppetLabs/puppet/etc'      # TODO","path":"manifests/params.pp","position":12,"original_position":12,"commit_id":"34de6a4bb4736dcb587038f76f2b13eb7d41e604","original_commit_id":"34de6a4bb4736dcb587038f76f2b13eb7d41e604","user":{"login":"binford2k","id":1392917,"avatar_url":"https://avatars.githubusercontent.com/u/1392917?v=3","gravatar_id":"","url":"https://api.github.com/users/binford2k","html_url":"https://github.com/binford2k","followers_url":"https://api.github.com/users/binford2k/followers","following_url":"https://api.github.com/users/binford2k/following{/other_user}","gists_url":"https://api.github.com/users/binford2k/gists{/gist_id}","starred_url":"https://api.github.com/users/binford2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binford2k/subscriptions","organizations_url":"https://api.github.com/users/binford2k/orgs","repos_url":"https://api.github.com/users/binford2k/repos","events_url":"https://api.github.com/users/binford2k/events{/privacy}","received_events_url":"https://api.github.com/users/binford2k/received_events","type":"User","site_admin":false},"body":"yes, probably a good call. I don't know what the AIO on windows looks like yet","created_at":"2015-07-25T00:29:54Z","updated_at":"2015-07-25T00:29:54Z","html_url":"https://github.com/puppetlabs/pltraining-classroom/pull/42#discussion_r35476786","pull_request_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/comments/35476786"},"html":{"href":"https://github.com/puppetlabs/pltraining-classroom/pull/42#discussion_r35476786"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/42","id":40080945,"html_url":"https://github.com/puppetlabs/pltraining-classroom/pull/42","diff_url":"https://github.com/puppetlabs/pltraining-classroom/pull/42.diff","patch_url":"https://github.com/puppetlabs/pltraining-classroom/pull/42.patch","issue_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/42","number":42,"state":"open","locked":false,"title":"First pass at Shallow Gravy support","user":{"login":"binford2k","id":1392917,"avatar_url":"https://avatars.githubusercontent.com/u/1392917?v=3","gravatar_id":"","url":"https://api.github.com/users/binford2k","html_url":"https://github.com/binford2k","followers_url":"https://api.github.com/users/binford2k/followers","following_url":"https://api.github.com/users/binford2k/following{/other_user}","gists_url":"https://api.github.com/users/binford2k/gists{/gist_id}","starred_url":"https://api.github.com/users/binford2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binford2k/subscriptions","organizations_url":"https://api.github.com/users/binford2k/orgs","repos_url":"https://api.github.com/users/binford2k/repos","events_url":"https://api.github.com/users/binford2k/events{/privacy}","received_events_url":"https://api.github.com/users/binford2k/received_events","type":"User","site_admin":false},"body":"This should now theoretically support both Shallow Gravy and 3.8.x.\r\nThere were two main avenues for porting to the new filesystem layout.\r\nFirst I parameterized `$codedir` and `$confdir` where I reasonably\r\ncould, so that if there are changes in the future, it should be\r\nrelatively easy to port. Second, I wrote a `classroom::compatibility`\r\nshim class that drops in some janky symlinks so that legacy PE\r\nfilesystem layouts will work unchanged with the new layout. This means\r\nthat when it comes time to drop 3.x support, we just drop the shim.\r\n\r\nThis isn't 100% parameterized, because some of the paths exist in static\r\nfiles, but the paths that would need corrected only exist in three\r\nfiles:\r\n\r\n* `files/pre-commit`\r\n* `files/process_reports.rb`\r\n* `files/sudoers.classroom`\r\n\r\nI ended up conflating a lot of overall cleanups and code refactoring\r\ninto this, simply because I was touching the same lines of code and I\r\ndidn't want to write and rewrite the code multiple times.\r\n\r\nI should also note that this isn't truly complete, as the `pltraining/rbac`\r\nand other modules may need updated.","created_at":"2015-07-15T23:29:27Z","updated_at":"2015-07-25T00:29:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"394ee3536421001ddcdaa58754cd9a8118ff859d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/42/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/42/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/42/comments","statuses_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/statuses/34de6a4bb4736dcb587038f76f2b13eb7d41e604","head":{"label":"binford2k:updates/sg","ref":"updates/sg","sha":"34de6a4bb4736dcb587038f76f2b13eb7d41e604","user":{"login":"binford2k","id":1392917,"avatar_url":"https://avatars.githubusercontent.com/u/1392917?v=3","gravatar_id":"","url":"https://api.github.com/users/binford2k","html_url":"https://github.com/binford2k","followers_url":"https://api.github.com/users/binford2k/followers","following_url":"https://api.github.com/users/binford2k/following{/other_user}","gists_url":"https://api.github.com/users/binford2k/gists{/gist_id}","starred_url":"https://api.github.com/users/binford2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binford2k/subscriptions","organizations_url":"https://api.github.com/users/binford2k/orgs","repos_url":"https://api.github.com/users/binford2k/repos","events_url":"https://api.github.com/users/binford2k/events{/privacy}","received_events_url":"https://api.github.com/users/binford2k/received_events","type":"User","site_admin":false},"repo":{"id":32814312,"name":"pltraining-classroom","full_name":"binford2k/pltraining-classroom","owner":{"login":"binford2k","id":1392917,"avatar_url":"https://avatars.githubusercontent.com/u/1392917?v=3","gravatar_id":"","url":"https://api.github.com/users/binford2k","html_url":"https://github.com/binford2k","followers_url":"https://api.github.com/users/binford2k/followers","following_url":"https://api.github.com/users/binford2k/following{/other_user}","gists_url":"https://api.github.com/users/binford2k/gists{/gist_id}","starred_url":"https://api.github.com/users/binford2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binford2k/subscriptions","organizations_url":"https://api.github.com/users/binford2k/orgs","repos_url":"https://api.github.com/users/binford2k/repos","events_url":"https://api.github.com/users/binford2k/events{/privacy}","received_events_url":"https://api.github.com/users/binford2k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/binford2k/pltraining-classroom","description":"Classroom module for Puppetlabs Training courses.  Not intended for general use.","fork":true,"url":"https://api.github.com/repos/binford2k/pltraining-classroom","forks_url":"https://api.github.com/repos/binford2k/pltraining-classroom/forks","keys_url":"https://api.github.com/repos/binford2k/pltraining-classroom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binford2k/pltraining-classroom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binford2k/pltraining-classroom/teams","hooks_url":"https://api.github.com/repos/binford2k/pltraining-classroom/hooks","issue_events_url":"https://api.github.com/repos/binford2k/pltraining-classroom/issues/events{/number}","events_url":"https://api.github.com/repos/binford2k/pltraining-classroom/events","assignees_url":"https://api.github.com/repos/binford2k/pltraining-classroom/assignees{/user}","branches_url":"https://api.github.com/repos/binford2k/pltraining-classroom/branches{/branch}","tags_url":"https://api.github.com/repos/binford2k/pltraining-classroom/tags","blobs_url":"https://api.github.com/repos/binford2k/pltraining-classroom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binford2k/pltraining-classroom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binford2k/pltraining-classroom/git/refs{/sha}","trees_url":"https://api.github.com/repos/binford2k/pltraining-classroom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binford2k/pltraining-classroom/statuses/{sha}","languages_url":"https://api.github.com/repos/binford2k/pltraining-classroom/languages","stargazers_url":"https://api.github.com/repos/binford2k/pltraining-classroom/stargazers","contributors_url":"https://api.github.com/repos/binford2k/pltraining-classroom/contributors","subscribers_url":"https://api.github.com/repos/binford2k/pltraining-classroom/subscribers","subscription_url":"https://api.github.com/repos/binford2k/pltraining-classroom/subscription","commits_url":"https://api.github.com/repos/binford2k/pltraining-classroom/commits{/sha}","git_commits_url":"https://api.github.com/repos/binford2k/pltraining-classroom/git/commits{/sha}","comments_url":"https://api.github.com/repos/binford2k/pltraining-classroom/comments{/number}","issue_comment_url":"https://api.github.com/repos/binford2k/pltraining-classroom/issues/comments{/number}","contents_url":"https://api.github.com/repos/binford2k/pltraining-classroom/contents/{+path}","compare_url":"https://api.github.com/repos/binford2k/pltraining-classroom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binford2k/pltraining-classroom/merges","archive_url":"https://api.github.com/repos/binford2k/pltraining-classroom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binford2k/pltraining-classroom/downloads","issues_url":"https://api.github.com/repos/binford2k/pltraining-classroom/issues{/number}","pulls_url":"https://api.github.com/repos/binford2k/pltraining-classroom/pulls{/number}","milestones_url":"https://api.github.com/repos/binford2k/pltraining-classroom/milestones{/number}","notifications_url":"https://api.github.com/repos/binford2k/pltraining-classroom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binford2k/pltraining-classroom/labels{/name}","releases_url":"https://api.github.com/repos/binford2k/pltraining-classroom/releases{/id}","created_at":"2015-03-24T17:34:32Z","updated_at":"2015-03-24T17:34:32Z","pushed_at":"2015-07-24T20:38:39Z","git_url":"git://github.com/binford2k/pltraining-classroom.git","ssh_url":"git@github.com:binford2k/pltraining-classroom.git","clone_url":"https://github.com/binford2k/pltraining-classroom.git","svn_url":"https://github.com/binford2k/pltraining-classroom","homepage":null,"size":17798,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"90f303770a406a84149edf64794fdca7740ebdb1","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":32344158,"name":"pltraining-classroom","full_name":"puppetlabs/pltraining-classroom","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/pltraining-classroom","description":"Classroom module for Puppetlabs Training courses.  Not intended for general use.","fork":false,"url":"https://api.github.com/repos/puppetlabs/pltraining-classroom","forks_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/forks","keys_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/teams","hooks_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/events","assignees_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/tags","blobs_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/subscription","commits_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/merges","archive_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/downloads","issues_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/pltraining-classroom/releases{/id}","created_at":"2015-03-16T18:17:47Z","updated_at":"2015-04-30T21:43:53Z","pushed_at":"2015-07-24T20:38:40Z","git_url":"git://github.com/puppetlabs/pltraining-classroom.git","ssh_url":"git@github.com:puppetlabs/pltraining-classroom.git","clone_url":"https://github.com/puppetlabs/pltraining-classroom.git","svn_url":"https://github.com/puppetlabs/pltraining-classroom","homepage":null,"size":18150,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/42"},"html":{"href":"https://github.com/puppetlabs/pltraining-classroom/pull/42"},"issue":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/42"},"comments":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/pltraining-classroom/statuses/34de6a4bb4736dcb587038f76f2b13eb7d41e604"}}}}