{"action":"reopened","number":4575,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4575","id":33110214,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/4575","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/4575.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/4575.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4575","number":4575,"state":"open","locked":false,"title":"PERF: Prevent using copy in astype if not needed","user":{"login":"jrings","id":1409127,"avatar_url":"https://avatars.githubusercontent.com/u/1409127?v=3","gravatar_id":"","url":"https://api.github.com/users/jrings","html_url":"https://github.com/jrings","followers_url":"https://api.github.com/users/jrings/followers","following_url":"https://api.github.com/users/jrings/following{/other_user}","gists_url":"https://api.github.com/users/jrings/gists{/gist_id}","starred_url":"https://api.github.com/users/jrings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrings/subscriptions","organizations_url":"https://api.github.com/users/jrings/orgs","repos_url":"https://api.github.com/users/jrings/repos","events_url":"https://api.github.com/users/jrings/events{/privacy}","received_events_url":"https://api.github.com/users/jrings/received_events","type":"User","site_admin":false},"body":"I went over all instances of `astype` in the code and, if a copy was not needed because it was assigned back to the same variable, used `utils.fixes.astype` with `copy=False`.\r\n\r\nResolves #4573 ","created_at":"2015-04-11T21:20:35Z","updated_at":"2015-04-11T22:14:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"587b5972229858214823f14768a9d61d737b8d93","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4575/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4575/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4575/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/d97a8b8bb9d2613d2e1d57e264a8dab2c7a83299","head":{"label":"jrings:master","ref":"master","sha":"d97a8b8bb9d2613d2e1d57e264a8dab2c7a83299","user":{"login":"jrings","id":1409127,"avatar_url":"https://avatars.githubusercontent.com/u/1409127?v=3","gravatar_id":"","url":"https://api.github.com/users/jrings","html_url":"https://github.com/jrings","followers_url":"https://api.github.com/users/jrings/followers","following_url":"https://api.github.com/users/jrings/following{/other_user}","gists_url":"https://api.github.com/users/jrings/gists{/gist_id}","starred_url":"https://api.github.com/users/jrings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrings/subscriptions","organizations_url":"https://api.github.com/users/jrings/orgs","repos_url":"https://api.github.com/users/jrings/repos","events_url":"https://api.github.com/users/jrings/events{/privacy}","received_events_url":"https://api.github.com/users/jrings/received_events","type":"User","site_admin":false},"repo":{"id":33790594,"name":"scikit-learn","full_name":"jrings/scikit-learn","owner":{"login":"jrings","id":1409127,"avatar_url":"https://avatars.githubusercontent.com/u/1409127?v=3","gravatar_id":"","url":"https://api.github.com/users/jrings","html_url":"https://github.com/jrings","followers_url":"https://api.github.com/users/jrings/followers","following_url":"https://api.github.com/users/jrings/following{/other_user}","gists_url":"https://api.github.com/users/jrings/gists{/gist_id}","starred_url":"https://api.github.com/users/jrings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrings/subscriptions","organizations_url":"https://api.github.com/users/jrings/orgs","repos_url":"https://api.github.com/users/jrings/repos","events_url":"https://api.github.com/users/jrings/events{/privacy}","received_events_url":"https://api.github.com/users/jrings/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrings/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/jrings/scikit-learn","forks_url":"https://api.github.com/repos/jrings/scikit-learn/forks","keys_url":"https://api.github.com/repos/jrings/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrings/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrings/scikit-learn/teams","hooks_url":"https://api.github.com/repos/jrings/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/jrings/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/jrings/scikit-learn/events","assignees_url":"https://api.github.com/repos/jrings/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/jrings/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/jrings/scikit-learn/tags","blobs_url":"https://api.github.com/repos/jrings/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrings/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrings/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrings/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrings/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/jrings/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/jrings/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/jrings/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/jrings/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/jrings/scikit-learn/subscription","commits_url":"https://api.github.com/repos/jrings/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrings/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrings/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrings/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrings/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/jrings/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrings/scikit-learn/merges","archive_url":"https://api.github.com/repos/jrings/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrings/scikit-learn/downloads","issues_url":"https://api.github.com/repos/jrings/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/jrings/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/jrings/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/jrings/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrings/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/jrings/scikit-learn/releases{/id}","created_at":"2015-04-11T20:10:44Z","updated_at":"2015-04-11T21:03:44Z","pushed_at":"2015-04-11T22:02:24Z","git_url":"git://github.com/jrings/scikit-learn.git","ssh_url":"git@github.com:jrings/scikit-learn.git","clone_url":"https://github.com/jrings/scikit-learn.git","svn_url":"https://github.com/jrings/scikit-learn","homepage":"http://scikit-learn.org","size":120648,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"28c893d044995b9e018dc80c6629c0d32d3f931d","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2015-04-11T19:36:08Z","pushed_at":"2015-04-11T22:03:40Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":120648,"stargazers_count":5570,"watchers_count":5570,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3339,"mirror_url":null,"open_issues_count":638,"forks":3339,"open_issues":638,"watchers":5570,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4575"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/4575"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4575"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4575/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4575/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4575/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/d97a8b8bb9d2613d2e1d57e264a8dab2c7a83299"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":34,"deletions":25,"changed_files":12}}