{"push_id":552662832,"size":109,"distinct_size":64,"ref":"refs/heads/sync-node-status","head":"0ee6a5846ee349630253caf105c3cfc5e5f8d3b7","before":"908ef1c349d060d341e543314d740b86d818add7","commits":[{"sha":"79ff06ffa1176eb0c855f7a3fea88898f604afaf","author":{"email":"46f5a0051bcaac06293374f80c77669d4919a80b@google.com","name":"Filipe Brandenburger"},"message":"Fix comparison of EtcdClient to nil so that it does not run into the pointer vs. interface issue\n\nThis is a partial rollback of commit 6e6f465a3699ff (\"Fix a crash for\nkubelet when without EtcdClient\") in which we used the `reflect` module\nto inspect that the pointer stored inside the interface was `nil`, but\nas pointed out by @lavalamp, the correct solution is to make the\nfunction return the interface type, in which case a `return nil` will\nreturn the interface nil and not a nil pointer that turns into a non-nil\nvalue when coerced into an interface.\n\nFor more details, see http://golang.org/doc/faq#nil_error and the\ndiscussion in PR #3356.\n\nTested by installing a kubelet built from head with this patch into a\ncontainervm instance and confirming it did not crash on standalone.go.\nConfirmed that by only removing the `reflect.IsNil()` comparison but not\nchanging the return type of `EtcdClientOrDie()` did indeed cause that\nsame crash, so changing the return type does indeed fix the issue.\n\nSigned-off-by: Filipe Brandenburger <filbranden@google.com>","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/79ff06ffa1176eb0c855f7a3fea88898f604afaf"},{"sha":"2fc8c08b01f9c66570abc9aa084c9b02d6b465c6","author":{"email":"851195210176e28024411996b6e9e0d8bf386761@gmail.com","name":"jay vyas"},"message":"Clarify origin of REDIS_MASTER_SERVICE_HOST variable.\n\nThis commit clarifies the origin of the REDIS_MASTER_SERVICE_HOST variable by linking to the documentation on the way kubernetes services create env variables in the services.md file.","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/2fc8c08b01f9c66570abc9aa084c9b02d6b465c6"},{"sha":"2367360321ee312aff4de0003740a0847bdf9a23","author":{"email":"33ee169af5c4a338e1d7829133182f5852741086@google.com","name":"Tim Hockin"},"message":"Update DNS doc","distinct":true,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/2367360321ee312aff4de0003740a0847bdf9a23"},{"sha":"6dee1d7fa4d43cdf4c403591cf51d1c67fbaa1fa","author":{"email":"34c6fceca75e456f25e7e99531e2425c6c1de443@aas.io","name":"Andrew Seidl"},"message":"Fix typos in user-facing strings","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/6dee1d7fa4d43cdf4c403591cf51d1c67fbaa1fa"},{"sha":"8248e6bef65b5a20fa2f1903bff4943925be822f","author":{"email":"34c6fceca75e456f25e7e99531e2425c6c1de443@aas.io","name":"Andrew Seidl"},"message":"Fix typos in kubectl docs, via gendocs","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/8248e6bef65b5a20fa2f1903bff4943925be822f"},{"sha":"f58198bad85084ef734e8a425b66fb6eaf4a57b2","author":{"email":"bb70c042bbc0dba315bfb4ba499bf3168b17759c@gmail.com","name":"Ryan Fowler"},"message":"remove .md from annotations link text\n\nAdds consistency with the other links on the page.","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/f58198bad85084ef734e8a425b66fb6eaf4a57b2"},{"sha":"9aec0a36099f76d6cec7e62e87918b7f06ede9f9","author":{"email":"bb70c042bbc0dba315bfb4ba499bf3168b17759c@gmail.com","name":"Ryan Fowler"},"message":"Fix table of contents\n\nAdditional user guides section appears to have been renamed.","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/9aec0a36099f76d6cec7e62e87918b7f06ede9f9"},{"sha":"e4dcbb6edbe5712fa4e4ef420026eaa58841113a","author":{"email":"4f499256fd2260f9682a9d9e63c3f1d668ee5cdf@redhat.com","name":"Clayton Coleman"},"message":"Explicitly handle errors received during watch\n\nLog them as Error and then continue.","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/e4dcbb6edbe5712fa4e4ef420026eaa58841113a"},{"sha":"888fe4b175240879ee4abecb975be8882227b0f2","author":{"email":"aa6ef2bbe17379c3e8e7883829f55c5a7ad052b1@redhat.com","name":"Jordan Liggitt"},"message":"Build TLS client for kubelet correctly","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/888fe4b175240879ee4abecb975be8882227b0f2"},{"sha":"8c900187b692cc4069c8065fb8a06126c4f7686d","author":{"email":"1cdc736ba6fd89dd9b69239aea62ddb9fd1482b1@google.com","name":"Anthony Yeh"},"message":"Add reverse proxy headers in apiserver proxy.\n\nFixes #3484","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/8c900187b692cc4069c8065fb8a06126c4f7686d"},{"sha":"60e7002474943cb85f86dd200eecefb2462f48e4","author":{"email":"33ee169af5c4a338e1d7829133182f5852741086@google.com","name":"Tim Hockin"},"message":"Fix errant error message from boilerplate check","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/60e7002474943cb85f86dd200eecefb2462f48e4"},{"sha":"868d2c4336e50791091447854146226535d92218","author":{"email":"66c8ad4f8476bca517121e7ddcc44918666b57ca@google.com","name":"Zach Loafman"},"message":"cmd/e2e: Port --orderseed and --times to cmd/e2e from hack/e2e\n\n* Add --orderseed, shuffle order every time, report order for repeatability\n* Add --times, acts like a multi-deck shoe\n* Remove fixed numbering in TAP output (this is actually not needed;\nTAP output is just done by outputting what assertion count you're on.)\n\nThis is essentially just a port of f3a992aa and 369064c6 (minus\nreporting, which can be handled later when we make TAP, etc, better).","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/868d2c4336e50791091447854146226535d92218"},{"sha":"6d6d3a3beed53d6f620ec0ac3ce81683ad582eaf","author":{"email":"55de653f60411f54174c6328fa96d87ccc452441@hotmail.com","name":"Parth Oberoi"},"message":"typo fixed","distinct":true,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/6d6d3a3beed53d6f620ec0ac3ce81683ad582eaf"},{"sha":"48146e01cd7d481a71145245e8f4183d2498082e","author":{"email":"4f499256fd2260f9682a9d9e63c3f1d668ee5cdf@redhat.com","name":"Clayton Coleman"},"message":"Expose ValidateLabels in validation.go for reuse by other components\n\nLabel validation is common to anyone building kube resources.","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/48146e01cd7d481a71145245e8f4183d2498082e"},{"sha":"9a151fc32c49594cbfe099ff5d5f94b43f242c48","author":{"email":"eb0e322e74060bb4753a9f4aec9333246612275c@google.com","name":"Eric Tune"},"message":"Merge pull request #3596 from andrewseidl/typo-cleanup\n\nFix several typos in user-facing strings","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/9a151fc32c49594cbfe099ff5d5f94b43f242c48"},{"sha":"41955a9235677ee3edbb8ef58f98c4a5ae84883e","author":{"email":"8ebd7c956eebb4b41ebd878bb4c245586e4fc9ce@php.net","name":"Patrick Reilly"},"message":"Update node.yaml to support graphdriver: overlay\n\nUpdate node.yaml to support graphdriver: overlay as btrfs produces \"fatal\" \"prerequisites for driver not satisfied (wrong filesystem?)\" on CoreOS Alpha 561.0.0","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/41955a9235677ee3edbb8ef58f98c4a5ae84883e"},{"sha":"1e36cb12bb1545d8128a8f838d4f81b7f7f5883e","author":{"email":"eb0e322e74060bb4753a9f4aec9333246612275c@google.com","name":"Eric Tune"},"message":"Merge pull request #3594 from jayunit100/master\n\nClarify origin of REDIS_MASTER_SERVICE_HOST variable.","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/1e36cb12bb1545d8128a8f838d4f81b7f7f5883e"},{"sha":"56f20bd8b04966f418d587a1f2ca164070cda119","author":{"email":"53ec011e097711cd4d64f846b963503de903d128@gmail.com","name":"Kelsey Hightower"},"message":"Merge pull request #3625 from preillyme/btrfs-overlay\n\nUpdate node.yaml to support graphdriver: overlay","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/56f20bd8b04966f418d587a1f2ca164070cda119"},{"sha":"fd52ba96cef160c64bcb9492886e34d1e915314f","author":{"email":"eb0e322e74060bb4753a9f4aec9333246612275c@google.com","name":"Eric Tune"},"message":"Merge pull request #3608 from smarterclayton/log_watch_errors\n\nExplicitly handle errors received during watch","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/fd52ba96cef160c64bcb9492886e34d1e915314f"},{"sha":"6ff26d924c789ad35172674b1680daf87b13f6c2","author":{"email":"33ee169af5c4a338e1d7829133182f5852741086@google.com","name":"Tim Hockin"},"message":"Merge pull request #3619 from smarterclayton/expose_validate_labels\n\nExpose ValidateLabels in validation.go for reuse by other components","distinct":false,"url":"https://api.github.com/repos/ddysher/kubernetes/commits/6ff26d924c789ad35172674b1680daf87b13f6c2"}]}