{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/41834434","id":41834434,"diff_hunk":"@@ -1022,7 +1023,8 @@\n       (insert-facts-pv-pairs! (certname-to-factset-id certname)\n                               (map #(vector (get paths-to-ids %1)\n                                             (get vhashes-to-ids %2))\n-                                   pathstrs vhashes))))))\n+                                   (map facts/unescape-string pathstrs)","path":"src/puppetlabs/puppetdb/scf/storage.clj","position":13,"original_position":13,"commit_id":"fc284dd2e325cdce36112f148656796c51766fd4","original_commit_id":"fc284dd2e325cdce36112f148656796c51766fd4","user":{"login":"ajroetker","id":3198124,"avatar_url":"https://avatars.githubusercontent.com/u/3198124?v=3","gravatar_id":"","url":"https://api.github.com/users/ajroetker","html_url":"https://github.com/ajroetker","followers_url":"https://api.github.com/users/ajroetker/followers","following_url":"https://api.github.com/users/ajroetker/following{/other_user}","gists_url":"https://api.github.com/users/ajroetker/gists{/gist_id}","starred_url":"https://api.github.com/users/ajroetker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajroetker/subscriptions","organizations_url":"https://api.github.com/users/ajroetker/orgs","repos_url":"https://api.github.com/users/ajroetker/repos","events_url":"https://api.github.com/users/ajroetker/events{/privacy}","received_events_url":"https://api.github.com/users/ajroetker/received_events","type":"User","site_admin":false},"body":"So we don't want `realize-paths` to also have the escaped quotes stripped?","created_at":"2015-10-13T07:33:10Z","updated_at":"2015-10-13T07:33:10Z","html_url":"https://github.com/puppetlabs/puppetdb/pull/1682#discussion_r41834434","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1682","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments/41834434"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1682#discussion_r41834434"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1682"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1682","id":47440889,"html_url":"https://github.com/puppetlabs/puppetdb/pull/1682","diff_url":"https://github.com/puppetlabs/puppetdb/pull/1682.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/1682.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1682","number":1682,"state":"open","locked":false,"title":"(pdb-2034) schema error on replace-facts with escape-quoted strings","user":{"login":"wkalt","id":4952091,"avatar_url":"https://avatars.githubusercontent.com/u/4952091?v=3","gravatar_id":"","url":"https://api.github.com/users/wkalt","html_url":"https://github.com/wkalt","followers_url":"https://api.github.com/users/wkalt/followers","following_url":"https://api.github.com/users/wkalt/following{/other_user}","gists_url":"https://api.github.com/users/wkalt/gists{/gist_id}","starred_url":"https://api.github.com/users/wkalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkalt/subscriptions","organizations_url":"https://api.github.com/users/wkalt/orgs","repos_url":"https://api.github.com/users/wkalt/repos","events_url":"https://api.github.com/users/wkalt/events{/privacy}","received_events_url":"https://api.github.com/users/wkalt/received_events","type":"User","site_admin":false},"body":"Without this commit we're broken on escape-quoted fact names and fact names\r\ncontaining #~. Some escape-quoting we do before storage was causing different\r\nnames to come out of realize-paths! than went in, which caused an empty key\r\nlookup that led to the error.","created_at":"2015-10-12T16:46:19Z","updated_at":"2015-10-13T07:33:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b231ed1075052d096ea4a3056629d96857a8379c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1682/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1682/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1682/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/fc284dd2e325cdce36112f148656796c51766fd4","head":{"label":"wkalt:ticket/stable/pdb-2034-fix-escape-quoted-facts","ref":"ticket/stable/pdb-2034-fix-escape-quoted-facts","sha":"fc284dd2e325cdce36112f148656796c51766fd4","user":{"login":"wkalt","id":4952091,"avatar_url":"https://avatars.githubusercontent.com/u/4952091?v=3","gravatar_id":"","url":"https://api.github.com/users/wkalt","html_url":"https://github.com/wkalt","followers_url":"https://api.github.com/users/wkalt/followers","following_url":"https://api.github.com/users/wkalt/following{/other_user}","gists_url":"https://api.github.com/users/wkalt/gists{/gist_id}","starred_url":"https://api.github.com/users/wkalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkalt/subscriptions","organizations_url":"https://api.github.com/users/wkalt/orgs","repos_url":"https://api.github.com/users/wkalt/repos","events_url":"https://api.github.com/users/wkalt/events{/privacy}","received_events_url":"https://api.github.com/users/wkalt/received_events","type":"User","site_admin":false},"repo":{"id":20931903,"name":"puppetdb","full_name":"wkalt/puppetdb","owner":{"login":"wkalt","id":4952091,"avatar_url":"https://avatars.githubusercontent.com/u/4952091?v=3","gravatar_id":"","url":"https://api.github.com/users/wkalt","html_url":"https://github.com/wkalt","followers_url":"https://api.github.com/users/wkalt/followers","following_url":"https://api.github.com/users/wkalt/following{/other_user}","gists_url":"https://api.github.com/users/wkalt/gists{/gist_id}","starred_url":"https://api.github.com/users/wkalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkalt/subscriptions","organizations_url":"https://api.github.com/users/wkalt/orgs","repos_url":"https://api.github.com/users/wkalt/repos","events_url":"https://api.github.com/users/wkalt/events{/privacy}","received_events_url":"https://api.github.com/users/wkalt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wkalt/puppetdb","description":"Centralized Puppet Storage","fork":true,"url":"https://api.github.com/repos/wkalt/puppetdb","forks_url":"https://api.github.com/repos/wkalt/puppetdb/forks","keys_url":"https://api.github.com/repos/wkalt/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wkalt/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wkalt/puppetdb/teams","hooks_url":"https://api.github.com/repos/wkalt/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/wkalt/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/wkalt/puppetdb/events","assignees_url":"https://api.github.com/repos/wkalt/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/wkalt/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/wkalt/puppetdb/tags","blobs_url":"https://api.github.com/repos/wkalt/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wkalt/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wkalt/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/wkalt/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wkalt/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/wkalt/puppetdb/languages","stargazers_url":"https://api.github.com/repos/wkalt/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/wkalt/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/wkalt/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/wkalt/puppetdb/subscription","commits_url":"https://api.github.com/repos/wkalt/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/wkalt/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/wkalt/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/wkalt/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/wkalt/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/wkalt/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wkalt/puppetdb/merges","archive_url":"https://api.github.com/repos/wkalt/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wkalt/puppetdb/downloads","issues_url":"https://api.github.com/repos/wkalt/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/wkalt/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/wkalt/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/wkalt/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wkalt/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/wkalt/puppetdb/releases{/id}","created_at":"2014-06-17T16:54:41Z","updated_at":"2015-04-03T19:51:15Z","pushed_at":"2015-10-12T16:45:59Z","git_url":"git://github.com/wkalt/puppetdb.git","ssh_url":"git@github.com:wkalt/puppetdb.git","clone_url":"https://github.com/wkalt/puppetdb.git","svn_url":"https://github.com/wkalt/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":18750,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"982d0ec8473b64fe26267eae77c62ceb27a07a38","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2193032,"name":"puppetdb","full_name":"puppetlabs/puppetdb","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetdb","description":"Centralized Puppet Storage","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetdb/releases{/id}","created_at":"2011-08-11T18:54:46Z","updated_at":"2015-10-09T03:29:13Z","pushed_at":"2015-10-13T00:03:09Z","git_url":"git://github.com/puppetlabs/puppetdb.git","ssh_url":"git@github.com:puppetlabs/puppetdb.git","clone_url":"https://github.com/puppetlabs/puppetdb.git","svn_url":"https://github.com/puppetlabs/puppetdb","homepage":"http://docs.puppetlabs.com/puppetdb","size":23353,"stargazers_count":173,"watchers_count":173,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":138,"mirror_url":null,"open_issues_count":10,"forks":138,"open_issues":10,"watchers":173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1682"},"html":{"href":"https://github.com/puppetlabs/puppetdb/pull/1682"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1682"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/issues/1682/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1682/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/1682/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetdb/statuses/fc284dd2e325cdce36112f148656796c51766fd4"}}}}