{"action":"created","issue":{"url":"https://api.github.com/repos/DataDog/dd-agent/issues/2117","labels_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2117/labels{/name}","comments_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2117/comments","events_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2117/events","html_url":"https://github.com/DataDog/dd-agent/pull/2117","id":120049254,"number":2117,"title":"[mysql] Flavored mysql test","user":{"login":"truthbk","id":448216,"avatar_url":"https://avatars.githubusercontent.com/u/448216?v=3","gravatar_id":"","url":"https://api.github.com/users/truthbk","html_url":"https://github.com/truthbk","followers_url":"https://api.github.com/users/truthbk/followers","following_url":"https://api.github.com/users/truthbk/following{/other_user}","gists_url":"https://api.github.com/users/truthbk/gists{/gist_id}","starred_url":"https://api.github.com/users/truthbk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/truthbk/subscriptions","organizations_url":"https://api.github.com/users/truthbk/orgs","repos_url":"https://api.github.com/users/truthbk/repos","events_url":"https://api.github.com/users/truthbk/events{/privacy}","received_events_url":"https://api.github.com/users/truthbk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-02T22:22:04Z","updated_at":"2015-12-03T23:18:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-agent/pulls/2117","html_url":"https://github.com/DataDog/dd-agent/pull/2117","diff_url":"https://github.com/DataDog/dd-agent/pull/2117.diff","patch_url":"https://github.com/DataDog/dd-agent/pull/2117.patch"},"body":"# Description\r\nAdding a flavored test that will allow us to finally have a disposable environment for our MySQL tests. The new test brings up two MySQL instances, one for the master, and a second one for the slave, and we setup replication. \r\n\r\n## Improvable\r\n* tarballs should probably be put in our S3\r\n* we should get tarballs for multiple versions.\r\n* replication seems to be working as the logs indicate, but replication test is failing - not sure if the problem is with the actual check and the newer 5.7.x STATUS tables - 'Slave_running' is definitely not there. We will know once we merge with the revamped MySQL check.\r\n\r\n## Caveats\r\n* `libaio1` is a dependency for mysqld, unavailable in the Travis executors. We therefore have to download manually, extract and employ `LD_LIBRARY_PATH` for the dynamic linking to work. Currently we download the deb from the ubuntu repo's, and extract the `deb` to a directory of our choice. Not sure if the Travis executors will allow all necessary commands (namely: `apt-cache` and `dpkg-deb`) - we can always put a tarball in our S3 with the lib.\r\n\r\n* test has to resort to system() instead of sh to start-up the mysql instances because sh won't allow prepending env variables in the call. There may be some other way, but I'm not aware of it currently. If init fails, we won't notice until the actual mysql client tries to connect to the DB's but that should work fine and take us to the clean-up code.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/DataDog/dd-agent/issues/comments/161820577","html_url":"https://github.com/DataDog/dd-agent/pull/2117#issuecomment-161820577","issue_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2117","id":161820577,"user":{"login":"truthbk","id":448216,"avatar_url":"https://avatars.githubusercontent.com/u/448216?v=3","gravatar_id":"","url":"https://api.github.com/users/truthbk","html_url":"https://github.com/truthbk","followers_url":"https://api.github.com/users/truthbk/followers","following_url":"https://api.github.com/users/truthbk/following{/other_user}","gists_url":"https://api.github.com/users/truthbk/gists{/gist_id}","starred_url":"https://api.github.com/users/truthbk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/truthbk/subscriptions","organizations_url":"https://api.github.com/users/truthbk/orgs","repos_url":"https://api.github.com/users/truthbk/repos","events_url":"https://api.github.com/users/truthbk/events{/privacy}","received_events_url":"https://api.github.com/users/truthbk/received_events","type":"User","site_admin":false},"created_at":"2015-12-03T23:18:36Z","updated_at":"2015-12-03T23:18:36Z","body":"MySQL test now passes but several stylistic offenses in ruby file must be fixed ^_^"}}