{"action":"created","comment":{"url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/pulls/comments/34144072","id":34144072,"diff_hunk":"@@ -1,72 +1,79 @@\n import Ember from 'ember';\n import noUiSlider from 'noUiSlider';\n \n+const {\n+  on,\n+  isEmpty,","path":"addon/components/range-slider.js","position":6,"original_position":6,"commit_id":"a01c2aef767fa32f4c243bb675c8798c475a3ed6","original_commit_id":"a01c2aef767fa32f4c243bb675c8798c475a3ed6","user":{"login":"blimmer","id":630449,"avatar_url":"https://avatars.githubusercontent.com/u/630449?v=3","gravatar_id":"","url":"https://api.github.com/users/blimmer","html_url":"https://github.com/blimmer","followers_url":"https://api.github.com/users/blimmer/followers","following_url":"https://api.github.com/users/blimmer/following{/other_user}","gists_url":"https://api.github.com/users/blimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/blimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blimmer/subscriptions","organizations_url":"https://api.github.com/users/blimmer/orgs","repos_url":"https://api.github.com/users/blimmer/repos","events_url":"https://api.github.com/users/blimmer/events{/privacy}","received_events_url":"https://api.github.com/users/blimmer/received_events","type":"User","site_admin":false},"body":"This is what's failing the build since you're using `Ember.isEmpty` below.","created_at":"2015-07-08T13:02:18Z","updated_at":"2015-07-08T13:02:18Z","html_url":"https://github.com/kennethkalmer/ember-cli-nouislider/pull/14#discussion_r34144072","pull_request_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/pulls/comments/34144072"},"html":{"href":"https://github.com/kennethkalmer/ember-cli-nouislider/pull/14#discussion_r34144072"},"pull_request":{"href":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/pulls/14","id":39473188,"html_url":"https://github.com/kennethkalmer/ember-cli-nouislider/pull/14","diff_url":"https://github.com/kennethkalmer/ember-cli-nouislider/pull/14.diff","patch_url":"https://github.com/kennethkalmer/ember-cli-nouislider/pull/14.patch","issue_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/issues/14","number":14,"state":"open","locked":false,"title":"Use events, and tear down listeners","user":{"login":"knownasilya","id":34726,"avatar_url":"https://avatars.githubusercontent.com/u/34726?v=3","gravatar_id":"","url":"https://api.github.com/users/knownasilya","html_url":"https://github.com/knownasilya","followers_url":"https://api.github.com/users/knownasilya/followers","following_url":"https://api.github.com/users/knownasilya/following{/other_user}","gists_url":"https://api.github.com/users/knownasilya/gists{/gist_id}","starred_url":"https://api.github.com/users/knownasilya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knownasilya/subscriptions","organizations_url":"https://api.github.com/users/knownasilya/orgs","repos_url":"https://api.github.com/users/knownasilya/repos","events_url":"https://api.github.com/users/knownasilya/events{/privacy}","received_events_url":"https://api.github.com/users/knownasilya/received_events","type":"User","site_admin":false},"body":"I've updated the syntax to a more correct one for events like `didInsertElement`. Also added some teardown code for cleanup of listeners on the slider when the component gets destroyed.","created_at":"2015-07-08T12:51:50Z","updated_at":"2015-07-08T13:02:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c16ebe9dfeec84ba66bf9fe7d7919db3b5200df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/pulls/14/commits","review_comments_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/pulls/14/comments","review_comment_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/issues/14/comments","statuses_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/statuses/a01c2aef767fa32f4c243bb675c8798c475a3ed6","head":{"label":"knownasilya:events","ref":"events","sha":"a01c2aef767fa32f4c243bb675c8798c475a3ed6","user":{"login":"knownasilya","id":34726,"avatar_url":"https://avatars.githubusercontent.com/u/34726?v=3","gravatar_id":"","url":"https://api.github.com/users/knownasilya","html_url":"https://github.com/knownasilya","followers_url":"https://api.github.com/users/knownasilya/followers","following_url":"https://api.github.com/users/knownasilya/following{/other_user}","gists_url":"https://api.github.com/users/knownasilya/gists{/gist_id}","starred_url":"https://api.github.com/users/knownasilya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knownasilya/subscriptions","organizations_url":"https://api.github.com/users/knownasilya/orgs","repos_url":"https://api.github.com/users/knownasilya/repos","events_url":"https://api.github.com/users/knownasilya/events{/privacy}","received_events_url":"https://api.github.com/users/knownasilya/received_events","type":"User","site_admin":false},"repo":{"id":37615427,"name":"ember-cli-nouislider","full_name":"knownasilya/ember-cli-nouislider","owner":{"login":"knownasilya","id":34726,"avatar_url":"https://avatars.githubusercontent.com/u/34726?v=3","gravatar_id":"","url":"https://api.github.com/users/knownasilya","html_url":"https://github.com/knownasilya","followers_url":"https://api.github.com/users/knownasilya/followers","following_url":"https://api.github.com/users/knownasilya/following{/other_user}","gists_url":"https://api.github.com/users/knownasilya/gists{/gist_id}","starred_url":"https://api.github.com/users/knownasilya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knownasilya/subscriptions","organizations_url":"https://api.github.com/users/knownasilya/orgs","repos_url":"https://api.github.com/users/knownasilya/repos","events_url":"https://api.github.com/users/knownasilya/events{/privacy}","received_events_url":"https://api.github.com/users/knownasilya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/knownasilya/ember-cli-nouislider","description":"{{range-slider}} component for ember-cli powered by noUiSlider","fork":true,"url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider","forks_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/forks","keys_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/teams","hooks_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/hooks","issue_events_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/issues/events{/number}","events_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/events","assignees_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/assignees{/user}","branches_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/branches{/branch}","tags_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/tags","blobs_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/git/refs{/sha}","trees_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/statuses/{sha}","languages_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/languages","stargazers_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/stargazers","contributors_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/contributors","subscribers_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/subscribers","subscription_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/subscription","commits_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/commits{/sha}","git_commits_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/git/commits{/sha}","comments_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/comments{/number}","issue_comment_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/issues/comments{/number}","contents_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/contents/{+path}","compare_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/merges","archive_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/downloads","issues_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/issues{/number}","pulls_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/pulls{/number}","milestones_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/milestones{/number}","notifications_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/labels{/name}","releases_url":"https://api.github.com/repos/knownasilya/ember-cli-nouislider/releases{/id}","created_at":"2015-06-17T19:11:53Z","updated_at":"2015-06-17T19:11:54Z","pushed_at":"2015-07-08T12:54:35Z","git_url":"git://github.com/knownasilya/ember-cli-nouislider.git","ssh_url":"git@github.com:knownasilya/ember-cli-nouislider.git","clone_url":"https://github.com/knownasilya/ember-cli-nouislider.git","svn_url":"https://github.com/knownasilya/ember-cli-nouislider","homepage":"http://kennethkalmer.github.com/ember-cli-nouislider","size":537,"stargazers_count":0,"watchers_count":0,"language":"Handlebars","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kennethkalmer:master","ref":"master","sha":"c7d8cdedd990477191b2a0891b17641d0050ca94","user":{"login":"kennethkalmer","id":8756,"avatar_url":"https://avatars.githubusercontent.com/u/8756?v=3","gravatar_id":"","url":"https://api.github.com/users/kennethkalmer","html_url":"https://github.com/kennethkalmer","followers_url":"https://api.github.com/users/kennethkalmer/followers","following_url":"https://api.github.com/users/kennethkalmer/following{/other_user}","gists_url":"https://api.github.com/users/kennethkalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/kennethkalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennethkalmer/subscriptions","organizations_url":"https://api.github.com/users/kennethkalmer/orgs","repos_url":"https://api.github.com/users/kennethkalmer/repos","events_url":"https://api.github.com/users/kennethkalmer/events{/privacy}","received_events_url":"https://api.github.com/users/kennethkalmer/received_events","type":"User","site_admin":false},"repo":{"id":31870164,"name":"ember-cli-nouislider","full_name":"kennethkalmer/ember-cli-nouislider","owner":{"login":"kennethkalmer","id":8756,"avatar_url":"https://avatars.githubusercontent.com/u/8756?v=3","gravatar_id":"","url":"https://api.github.com/users/kennethkalmer","html_url":"https://github.com/kennethkalmer","followers_url":"https://api.github.com/users/kennethkalmer/followers","following_url":"https://api.github.com/users/kennethkalmer/following{/other_user}","gists_url":"https://api.github.com/users/kennethkalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/kennethkalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennethkalmer/subscriptions","organizations_url":"https://api.github.com/users/kennethkalmer/orgs","repos_url":"https://api.github.com/users/kennethkalmer/repos","events_url":"https://api.github.com/users/kennethkalmer/events{/privacy}","received_events_url":"https://api.github.com/users/kennethkalmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kennethkalmer/ember-cli-nouislider","description":"{{range-slider}} component for ember-cli powered by noUiSlider","fork":false,"url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider","forks_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/forks","keys_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/teams","hooks_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/hooks","issue_events_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/issues/events{/number}","events_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/events","assignees_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/assignees{/user}","branches_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/branches{/branch}","tags_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/tags","blobs_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/git/refs{/sha}","trees_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/statuses/{sha}","languages_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/languages","stargazers_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/stargazers","contributors_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/contributors","subscribers_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/subscribers","subscription_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/subscription","commits_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/commits{/sha}","git_commits_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/git/commits{/sha}","comments_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/comments{/number}","issue_comment_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/issues/comments{/number}","contents_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/contents/{+path}","compare_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/merges","archive_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/downloads","issues_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/issues{/number}","pulls_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/pulls{/number}","milestones_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/milestones{/number}","notifications_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/labels{/name}","releases_url":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/releases{/id}","created_at":"2015-03-08T23:33:03Z","updated_at":"2015-07-02T21:22:29Z","pushed_at":"2015-07-08T12:54:35Z","git_url":"git://github.com/kennethkalmer/ember-cli-nouislider.git","ssh_url":"git@github.com:kennethkalmer/ember-cli-nouislider.git","clone_url":"https://github.com/kennethkalmer/ember-cli-nouislider.git","svn_url":"https://github.com/kennethkalmer/ember-cli-nouislider","homepage":"http://kennethkalmer.github.com/ember-cli-nouislider","size":814,"stargazers_count":5,"watchers_count":5,"language":"Handlebars","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":4,"forks":9,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/pulls/14"},"html":{"href":"https://github.com/kennethkalmer/ember-cli-nouislider/pull/14"},"issue":{"href":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/issues/14"},"comments":{"href":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/kennethkalmer/ember-cli-nouislider/statuses/a01c2aef767fa32f4c243bb675c8798c475a3ed6"}}}}