{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1743","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1743/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1743/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1743/events","html_url":"https://github.com/ManageIQ/manageiq/pull/1743","id":57919636,"number":1743,"title":"Openstack infra heat resource collection","user":{"login":"Ladas","id":1737058,"avatar_url":"https://avatars.githubusercontent.com/u/1737058?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladas","html_url":"https://github.com/Ladas","followers_url":"https://api.github.com/users/Ladas/followers","following_url":"https://api.github.com/users/Ladas/following{/other_user}","gists_url":"https://api.github.com/users/Ladas/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladas/subscriptions","organizations_url":"https://api.github.com/users/Ladas/orgs","repos_url":"https://api.github.com/users/Ladas/repos","events_url":"https://api.github.com/users/Ladas/events{/privacy}","received_events_url":"https://api.github.com/users/Ladas/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/WIP","name":"WIP","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-02-17T12:44:19Z","updated_at":"2015-02-20T17:32:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/1743","html_url":"https://github.com/ManageIQ/manageiq/pull/1743","diff_url":"https://github.com/ManageIQ/manageiq/pull/1743.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/1743.patch"},"body":"Collecting heat related attributes for OpenstackInfra Host\r\n\r\nIt's up to debate which of the commits are really needed, I am filling blank spaces where I feel it's appropriate, though that doesn't make it right. :-)\r\n\r\n1) commit is the most important, it implements the Node Type task, so you have info in host name whether host is compute, controller, storage, etc. And you can use to for writing filter, automate, etc.\r\nWording and format of hostname could be better here.\r\n\r\n2) commit\r\nvmm_vendor, it's hardcoded to RedHat and OS is hardcoded to rhel, cause we support only that. Later we could try to fetch actual OS from somewhere.\r\nvmm_product, wording could be much better here, basically it either has NovaCompute hypervisor, or there is no hypervisor at all, so I am stating purpose of the node. \r\n\r\nSeems like vmm product is used on stats on dashboard. So better to differ between node types. Or should it be all rhel? For other providers vmm_product marks what hypervisor it uses.\r\n\r\n3) commit \r\nhardcoding operating system to linux, that is all we support now\r\n\r\n4)  commit\r\nnot really sure what is connection state good for, I made it the same as in rhev and I though it will be connected to the right-down corner icon of the host list, but it's not. Seems like that requires some credentials for direct approach to host.\r\n\r\n5) commit \r\ntests\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/75283096","html_url":"https://github.com/ManageIQ/manageiq/pull/1743#issuecomment-75283096","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/1743","id":75283096,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2015-02-20T17:32:33Z","updated_at":"2015-02-20T17:32:33Z","body":"<rubocop />Checked commits https://github.com/Ladas/manageiq/commit/ece351cbe5dd91916423d715f13eb6c2400125e6 .. https://github.com/Ladas/manageiq/commit/63fe747e5b478bf316a786e394a9f5241ef79193 with rubocop 0.27.1\n3 files checked, 2 offenses detected\n\n**vmdb/spec/models/ems_refresh/refreshers/openstack_infra_refresher_rhos_juno_spec.rb**\n- [ ] :large_orange_diamond: - [Line 98](https://github.com/Ladas/manageiq/blob/63fe747e5b478bf316a786e394a9f5241ef79193/vmdb/spec/models/ems_refresh/refreshers/openstack_infra_refresher_rhos_juno_spec.rb#L98), Col 7 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :large_orange_diamond: - [Line 99](https://github.com/Ladas/manageiq/blob/63fe747e5b478bf316a786e394a9f5241ef79193/vmdb/spec/models/ems_refresh/refreshers/openstack_infra_refresher_rhos_juno_spec.rb#L99), Col 7 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.27.1/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n"}}