{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/24145972","id":24145972,"diff_hunk":"@@ -0,0 +1,204 @@\n+﻿// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved.\n+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.\n+\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Threading.Tasks;\n+using Microsoft.AspNet.Razor.Runtime.TagHelpers;\n+using Microsoft.Framework.Logging;\n+using Moq;\n+using Xunit;\n+\n+namespace Microsoft.AspNet.Mvc.TagHelpers\n+{\n+    public class ScriptTagHelperTest\n+    {\n+        [Theory]\n+        [InlineData(true)]\n+        [InlineData(false)]\n+        public async Task RunsWhenRequiredAttributesArePresent(bool srcAvailable)\n+        {\n+            // Arrange\n+            var attributes = new Dictionary<string, object>\n+                {\n+                    { \"asp-fallback-src\", \"http://www.example.com/blank.js\" },\n+                    { \"asp-fallback-test\", \"isavailable()\" },\n+                };\n+\n+            if (srcAvailable)\n+            {\n+                attributes.Add(\"src\", \"~/blank.js\");\n+            }\n+\n+            var context = MakeTagHelperContext(attributes);\n+\n+            var output = MakeTagHelperOutput(\"script\");\n+            var logger = new Logger();\n+\n+            // Act\n+            var helper = new ScriptTagHelper()\n+            {\n+                Logger = logger,\n+                FallbackSrc = \"http://www.example.com/blank.js\",\n+                FallbackTestMethod = \"isavailable()\",\n+            };\n+\n+            await helper.ProcessAsync(context, output);\n+\n+            // Assert\n+            Assert.Null(output.TagName);\n+            Assert.NotNull(output.Content);\n+            Assert.True(output.ContentSet);\n+            Assert.Equal(0, logger.Logged.Count);\n+        }\n+\n+        [Theory]\n+        [InlineData(0)]\n+        [InlineData(1)]\n+        public async Task DoesNotRunWhenARequiredAttributeIsMissing(int attributeToRemove)\n+        {\n+            // Arrange\n+            var attributes = new Dictionary<string, object>\n+                {\n+                    { \"asp-fallback-src\", \"http://www.example.com/blank.js\" },\n+                    { \"asp-fallback-test\", \"isavailable()\" },\n+                };\n+\n+            var removed = attributes.Keys.ElementAt(attributeToRemove);\n+            attributes.Remove(removed);\n+\n+            Assert.Equal(1, attributes.Count);\n+\n+            var context = MakeTagHelperContext(attributes);\n+\n+            var output = MakeTagHelperOutput(\"script\");\n+            var logger = new Logger();\n+\n+            // Act\n+            var helper = new ScriptTagHelper\n+            {\n+                Logger = logger,\n+            };\n+\n+            await helper.ProcessAsync(context, output);\n+\n+            // Assert\n+            Assert.NotNull(output.TagName);","path":"test/Microsoft.AspNet.Mvc.TagHelpers.Test/ScriptTagHelperTest.cs","position":86,"original_position":87,"commit_id":"bfaa47199fff9bea423da980872ead61c864f075","original_commit_id":"7ebddd56088cb14dde3d7928e7a2c3062fbdfed8","user":{"login":"NTaylorMullen","id":2008729,"avatar_url":"https://avatars.githubusercontent.com/u/2008729?v=3","gravatar_id":"","url":"https://api.github.com/users/NTaylorMullen","html_url":"https://github.com/NTaylorMullen","followers_url":"https://api.github.com/users/NTaylorMullen/followers","following_url":"https://api.github.com/users/NTaylorMullen/following{/other_user}","gists_url":"https://api.github.com/users/NTaylorMullen/gists{/gist_id}","starred_url":"https://api.github.com/users/NTaylorMullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NTaylorMullen/subscriptions","organizations_url":"https://api.github.com/users/NTaylorMullen/orgs","repos_url":"https://api.github.com/users/NTaylorMullen/repos","events_url":"https://api.github.com/users/NTaylorMullen/events{/privacy}","received_events_url":"https://api.github.com/users/NTaylorMullen/received_events","type":"User","site_admin":false},"body":"`Assert.Equal(\"script\", output.TagName);`","created_at":"2015-02-05T06:49:00Z","updated_at":"2015-02-05T06:49:00Z","html_url":"https://github.com/aspnet/Mvc/pull/1959#discussion_r24145972","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/1959","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/24145972"},"html":{"href":"https://github.com/aspnet/Mvc/pull/1959#discussion_r24145972"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/1959"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/1959","id":28687446,"html_url":"https://github.com/aspnet/Mvc/pull/1959","diff_url":"https://github.com/aspnet/Mvc/pull/1959.diff","patch_url":"https://github.com/aspnet/Mvc/pull/1959.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/1959","number":1959,"state":"open","locked":false,"title":"Script Tag Helper","user":{"login":"yishaigalatzer","id":1238711,"avatar_url":"https://avatars.githubusercontent.com/u/1238711?v=3","gravatar_id":"","url":"https://api.github.com/users/yishaigalatzer","html_url":"https://github.com/yishaigalatzer","followers_url":"https://api.github.com/users/yishaigalatzer/followers","following_url":"https://api.github.com/users/yishaigalatzer/following{/other_user}","gists_url":"https://api.github.com/users/yishaigalatzer/gists{/gist_id}","starred_url":"https://api.github.com/users/yishaigalatzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yishaigalatzer/subscriptions","organizations_url":"https://api.github.com/users/yishaigalatzer/orgs","repos_url":"https://api.github.com/users/yishaigalatzer/repos","events_url":"https://api.github.com/users/yishaigalatzer/events{/privacy}","received_events_url":"https://api.github.com/users/yishaigalatzer/received_events","type":"User","site_admin":false},"body":"This is the implementation suggestion for ScriptTagHelper/Fallback.\r\n\r\nI did yet go and clean it up 100%, but it does include functional and unit tests. \r\nI'm also testing the logging, and it was useful to flush out issues with the code. If you guys want I can make the private Logger class a Logger<T> that can be reused with other tag helpers.\r\n\r\nDidn't yet try it in a browser, but wanted to get it out for a quick review earlier rather than later.\r\n\r\nResolves #1576\r\n\r\nCC @DamianEdwards @NTaylorMullen ","created_at":"2015-02-04T23:56:45Z","updated_at":"2015-02-05T06:49:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7ae9efc967b6408b19b0195166f8b35a5a7af54","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/1959/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/1959/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/1959/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/bfaa47199fff9bea423da980872ead61c864f075","head":{"label":"aspnet:ScriptTagHelper","ref":"ScriptTagHelper","sha":"bfaa47199fff9bea423da980872ead61c864f075","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-02-05T00:42:51Z","pushed_at":"2015-02-05T06:19:31Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":68947,"stargazers_count":1322,"watchers_count":1322,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":386,"mirror_url":null,"open_issues_count":261,"forks":386,"open_issues":261,"watchers":1322,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"19ca77ac2db874d396fbe047ae548db7cc57b76c","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-02-05T00:42:51Z","pushed_at":"2015-02-05T06:19:31Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":68947,"stargazers_count":1322,"watchers_count":1322,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":386,"mirror_url":null,"open_issues_count":261,"forks":386,"open_issues":261,"watchers":1322,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/1959"},"html":{"href":"https://github.com/aspnet/Mvc/pull/1959"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/1959"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/1959/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/1959/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/1959/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/bfaa47199fff9bea423da980872ead61c864f075"}}}}