{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/27517956","id":27517956,"diff_hunk":"@@ -203,7 +208,12 @@ let\n   # Flag change between versions (e.g. \"--enable-armvfp\" -> \"--enable-vfp\" changed in v1.1)\n   chgFlg = chgVer: oldFlag: newFlag: if reqMin chgVer then newFlag else oldFlag;\n \n+  # Disable dependency that needs fixes before it will work on Darwin\n+  disDarwinFix = origArg: if stdenv.isDarwin then false else origArg;\n+\n   isCygwin = stdenv.isCygwin;\n+  isDarwin = stdenv.isDarwin;\n+  isLinux = stdenv.isLinux;","path":"pkgs/development/libraries/ffmpeg/generic.nix","position":39,"original_position":39,"commit_id":"a5f065d708af26be86e1f639cee1dd68303f5339","original_commit_id":"a5f065d708af26be86e1f639cee1dd68303f5339","user":{"login":"vcunat","id":1785925,"avatar_url":"https://avatars.githubusercontent.com/u/1785925?v=3","gravatar_id":"","url":"https://api.github.com/users/vcunat","html_url":"https://github.com/vcunat","followers_url":"https://api.github.com/users/vcunat/followers","following_url":"https://api.github.com/users/vcunat/following{/other_user}","gists_url":"https://api.github.com/users/vcunat/gists{/gist_id}","starred_url":"https://api.github.com/users/vcunat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcunat/subscriptions","organizations_url":"https://api.github.com/users/vcunat/orgs","repos_url":"https://api.github.com/users/vcunat/repos","events_url":"https://api.github.com/users/vcunat/events{/privacy}","received_events_url":"https://api.github.com/users/vcunat/received_events","type":"User","site_admin":false},"body":"For future reference: in ``let`` you can instead have ``inherit (stdenv) isCygwin isDarwin isLinux;``.","created_at":"2015-03-31T20:10:13Z","updated_at":"2015-03-31T20:10:13Z","html_url":"https://github.com/NixOS/nixpkgs/pull/7047#discussion_r27517956","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7047","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/27517956"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/7047#discussion_r27517956"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7047"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7047","id":32164594,"html_url":"https://github.com/NixOS/nixpkgs/pull/7047","diff_url":"https://github.com/NixOS/nixpkgs/pull/7047.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/7047.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/7047","number":7047,"state":"closed","locked":false,"title":"ffmpeg: improve cross platform support & fix licensing issues, resolves #7013","user":{"login":"codyopel","id":5561189,"avatar_url":"https://avatars.githubusercontent.com/u/5561189?v=3","gravatar_id":"","url":"https://api.github.com/users/codyopel","html_url":"https://github.com/codyopel","followers_url":"https://api.github.com/users/codyopel/followers","following_url":"https://api.github.com/users/codyopel/following{/other_user}","gists_url":"https://api.github.com/users/codyopel/gists{/gist_id}","starred_url":"https://api.github.com/users/codyopel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codyopel/subscriptions","organizations_url":"https://api.github.com/users/codyopel/orgs","repos_url":"https://api.github.com/users/codyopel/repos","events_url":"https://api.github.com/users/codyopel/events{/privacy}","received_events_url":"https://api.github.com/users/codyopel/received_events","type":"User","site_admin":false},"body":"+ Removed asserts for (l)gpl & (l)gpl3 making it easier to enable\r\n  and disable all (l)gpl & (l)gpl3 portions\r\n+ Fix build inputs so that nonfree software isn't pulled in when building ffmpeg\r\n+ Fix compiler on systems with clang\r\n+ Disable libraries that fail on darwin until they can be fixed\r\n+ Fix linux only build inputs so that they aren't pulled in on other platforms\r\n+ Fix optional build inputs\r\n+ Opencv causes circular dependency issues so it is disabled until it can be resolved\r\n\r\n","created_at":"2015-03-28T13:39:02Z","updated_at":"2015-03-31T20:10:13Z","closed_at":"2015-03-30T16:47:03Z","merged_at":"2015-03-30T16:47:03Z","merge_commit_sha":"212cd5c7b7d95fcf09adb1292db885fa004c7ad8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7047/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7047/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/7047/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/a5f065d708af26be86e1f639cee1dd68303f5339","head":{"label":"codyopel:ffmpeg-darwin","ref":"ffmpeg-darwin","sha":"a5f065d708af26be86e1f639cee1dd68303f5339","user":{"login":"codyopel","id":5561189,"avatar_url":"https://avatars.githubusercontent.com/u/5561189?v=3","gravatar_id":"","url":"https://api.github.com/users/codyopel","html_url":"https://github.com/codyopel","followers_url":"https://api.github.com/users/codyopel/followers","following_url":"https://api.github.com/users/codyopel/following{/other_user}","gists_url":"https://api.github.com/users/codyopel/gists{/gist_id}","starred_url":"https://api.github.com/users/codyopel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codyopel/subscriptions","organizations_url":"https://api.github.com/users/codyopel/orgs","repos_url":"https://api.github.com/users/codyopel/repos","events_url":"https://api.github.com/users/codyopel/events{/privacy}","received_events_url":"https://api.github.com/users/codyopel/received_events","type":"User","site_admin":false},"repo":{"id":30282343,"name":"nixpkgs","full_name":"codyopel/nixpkgs","owner":{"login":"codyopel","id":5561189,"avatar_url":"https://avatars.githubusercontent.com/u/5561189?v=3","gravatar_id":"","url":"https://api.github.com/users/codyopel","html_url":"https://github.com/codyopel","followers_url":"https://api.github.com/users/codyopel/followers","following_url":"https://api.github.com/users/codyopel/following{/other_user}","gists_url":"https://api.github.com/users/codyopel/gists{/gist_id}","starred_url":"https://api.github.com/users/codyopel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codyopel/subscriptions","organizations_url":"https://api.github.com/users/codyopel/orgs","repos_url":"https://api.github.com/users/codyopel/repos","events_url":"https://api.github.com/users/codyopel/events{/privacy}","received_events_url":"https://api.github.com/users/codyopel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codyopel/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/codyopel/nixpkgs","forks_url":"https://api.github.com/repos/codyopel/nixpkgs/forks","keys_url":"https://api.github.com/repos/codyopel/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codyopel/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codyopel/nixpkgs/teams","hooks_url":"https://api.github.com/repos/codyopel/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/codyopel/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/codyopel/nixpkgs/events","assignees_url":"https://api.github.com/repos/codyopel/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/codyopel/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/codyopel/nixpkgs/tags","blobs_url":"https://api.github.com/repos/codyopel/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codyopel/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codyopel/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/codyopel/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codyopel/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/codyopel/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/codyopel/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/codyopel/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/codyopel/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/codyopel/nixpkgs/subscription","commits_url":"https://api.github.com/repos/codyopel/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/codyopel/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/codyopel/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/codyopel/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/codyopel/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/codyopel/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codyopel/nixpkgs/merges","archive_url":"https://api.github.com/repos/codyopel/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codyopel/nixpkgs/downloads","issues_url":"https://api.github.com/repos/codyopel/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/codyopel/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/codyopel/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/codyopel/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codyopel/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/codyopel/nixpkgs/releases{/id}","created_at":"2015-02-04T05:02:33Z","updated_at":"2015-03-28T11:18:42Z","pushed_at":"2015-03-29T20:43:36Z","git_url":"git://github.com/codyopel/nixpkgs.git","ssh_url":"git@github.com:codyopel/nixpkgs.git","clone_url":"https://github.com/codyopel/nixpkgs.git","svn_url":"https://github.com/codyopel/nixpkgs","homepage":null,"size":152340,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"7e0bde1e7bb52cd8ec5e282c38c691fa4c757bac","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","created_at":"2012-06-04T02:49:46Z","updated_at":"2015-03-31T20:05:00Z","pushed_at":"2015-03-31T20:04:57Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":329737,"stargazers_count":586,"watchers_count":586,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":736,"mirror_url":null,"open_issues_count":638,"forks":736,"open_issues":638,"watchers":586,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7047"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/7047"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/7047"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/7047/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7047/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/7047/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/a5f065d708af26be86e1f639cee1dd68303f5339"}}}}