{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/Krelborn/KILabel/pulls/6","id":15609448,"html_url":"https://github.com/Krelborn/KILabel/pull/6","diff_url":"https://github.com/Krelborn/KILabel/pull/6.diff","patch_url":"https://github.com/Krelborn/KILabel/pull/6.patch","issue_url":"https://api.github.com/repos/Krelborn/KILabel/issues/6","number":6,"state":"closed","locked":false,"title":"Interface improvements + bug fixing","user":{"login":"vilanovi","id":1830894,"avatar_url":"https://avatars.githubusercontent.com/u/1830894?v=3","gravatar_id":"","url":"https://api.github.com/users/vilanovi","html_url":"https://github.com/vilanovi","followers_url":"https://api.github.com/users/vilanovi/followers","following_url":"https://api.github.com/users/vilanovi/following{/other_user}","gists_url":"https://api.github.com/users/vilanovi/gists{/gist_id}","starred_url":"https://api.github.com/users/vilanovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilanovi/subscriptions","organizations_url":"https://api.github.com/users/vilanovi/orgs","repos_url":"https://api.github.com/users/vilanovi/repos","events_url":"https://api.github.com/users/vilanovi/events{/privacy}","received_events_url":"https://api.github.com/users/vilanovi/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nWe are using the KILabel class in our organisation projects. However we have \brefracted the interface of the KILabel class: added documentation, unified the KILinkDetectorType with the KILinkType, add getters and setters for each link type text attributes, added support for ignore keywords, and a few changes more.\r\n\r\nRegarding bugs:\r\n\r\n1. We have fixed a bug that made the KILabel crash the execution when setting a nil text. \r\n\r\n2. There is still a bug in the \brendering of the text: the bounds are not exactly the same as a normal UILabel. This makes the KILabel be rendered in a rectangle that doesn't correspond with the method `[@\"string\" boundingRectWithSize:options:attributes:context:]` (as UILabel does). I have to study a bit more why this is happening and how to prevent it.\r\n\r\nI don't know if you might be interested in merge our fork in your repository, in any case, I offer you a pull request and is your call to decide if you are interested or not.\r\n\r\nAlso, if you feel we must add/change something else, please, tell me and we will do it.\r\n\r\nThanks,\r\n\r\nJoan","created_at":"2014-05-07T17:45:33Z","updated_at":"2015-01-30T14:06:23Z","closed_at":"2015-01-30T14:06:23Z","merged_at":"2015-01-30T14:06:22Z","merge_commit_sha":"ffede3e7dc165cb7cd3dcb0b868fc7fde5517cb0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Krelborn/KILabel/pulls/6/commits","review_comments_url":"https://api.github.com/repos/Krelborn/KILabel/pulls/6/comments","review_comment_url":"https://api.github.com/repos/Krelborn/KILabel/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Krelborn/KILabel/issues/6/comments","statuses_url":"https://api.github.com/repos/Krelborn/KILabel/statuses/5bddf0b69ddf9338dc6925dfe010fa7506c53b8a","head":{"label":"mobilejazz:master","ref":"master","sha":"5bddf0b69ddf9338dc6925dfe010fa7506c53b8a","user":{"login":"mobilejazz","id":1347660,"avatar_url":"https://avatars.githubusercontent.com/u/1347660?v=3","gravatar_id":"","url":"https://api.github.com/users/mobilejazz","html_url":"https://github.com/mobilejazz","followers_url":"https://api.github.com/users/mobilejazz/followers","following_url":"https://api.github.com/users/mobilejazz/following{/other_user}","gists_url":"https://api.github.com/users/mobilejazz/gists{/gist_id}","starred_url":"https://api.github.com/users/mobilejazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobilejazz/subscriptions","organizations_url":"https://api.github.com/users/mobilejazz/orgs","repos_url":"https://api.github.com/users/mobilejazz/repos","events_url":"https://api.github.com/users/mobilejazz/events{/privacy}","received_events_url":"https://api.github.com/users/mobilejazz/received_events","type":"Organization","site_admin":false},"repo":{"id":19541799,"name":"KILabel","full_name":"mobilejazz/KILabel","owner":{"login":"mobilejazz","id":1347660,"avatar_url":"https://avatars.githubusercontent.com/u/1347660?v=3","gravatar_id":"","url":"https://api.github.com/users/mobilejazz","html_url":"https://github.com/mobilejazz","followers_url":"https://api.github.com/users/mobilejazz/followers","following_url":"https://api.github.com/users/mobilejazz/following{/other_user}","gists_url":"https://api.github.com/users/mobilejazz/gists{/gist_id}","starred_url":"https://api.github.com/users/mobilejazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobilejazz/subscriptions","organizations_url":"https://api.github.com/users/mobilejazz/orgs","repos_url":"https://api.github.com/users/mobilejazz/repos","events_url":"https://api.github.com/users/mobilejazz/events{/privacy}","received_events_url":"https://api.github.com/users/mobilejazz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobilejazz/KILabel","description":"A simple to use drop in replacement for UILabel for iOS 7 that provides automatic detection of links such as URLs, twitter style usernames and hashtags.","fork":true,"url":"https://api.github.com/repos/mobilejazz/KILabel","forks_url":"https://api.github.com/repos/mobilejazz/KILabel/forks","keys_url":"https://api.github.com/repos/mobilejazz/KILabel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobilejazz/KILabel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobilejazz/KILabel/teams","hooks_url":"https://api.github.com/repos/mobilejazz/KILabel/hooks","issue_events_url":"https://api.github.com/repos/mobilejazz/KILabel/issues/events{/number}","events_url":"https://api.github.com/repos/mobilejazz/KILabel/events","assignees_url":"https://api.github.com/repos/mobilejazz/KILabel/assignees{/user}","branches_url":"https://api.github.com/repos/mobilejazz/KILabel/branches{/branch}","tags_url":"https://api.github.com/repos/mobilejazz/KILabel/tags","blobs_url":"https://api.github.com/repos/mobilejazz/KILabel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobilejazz/KILabel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobilejazz/KILabel/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobilejazz/KILabel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobilejazz/KILabel/statuses/{sha}","languages_url":"https://api.github.com/repos/mobilejazz/KILabel/languages","stargazers_url":"https://api.github.com/repos/mobilejazz/KILabel/stargazers","contributors_url":"https://api.github.com/repos/mobilejazz/KILabel/contributors","subscribers_url":"https://api.github.com/repos/mobilejazz/KILabel/subscribers","subscription_url":"https://api.github.com/repos/mobilejazz/KILabel/subscription","commits_url":"https://api.github.com/repos/mobilejazz/KILabel/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobilejazz/KILabel/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobilejazz/KILabel/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobilejazz/KILabel/issues/comments/{number}","contents_url":"https://api.github.com/repos/mobilejazz/KILabel/contents/{+path}","compare_url":"https://api.github.com/repos/mobilejazz/KILabel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobilejazz/KILabel/merges","archive_url":"https://api.github.com/repos/mobilejazz/KILabel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobilejazz/KILabel/downloads","issues_url":"https://api.github.com/repos/mobilejazz/KILabel/issues{/number}","pulls_url":"https://api.github.com/repos/mobilejazz/KILabel/pulls{/number}","milestones_url":"https://api.github.com/repos/mobilejazz/KILabel/milestones{/number}","notifications_url":"https://api.github.com/repos/mobilejazz/KILabel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobilejazz/KILabel/labels{/name}","releases_url":"https://api.github.com/repos/mobilejazz/KILabel/releases{/id}","created_at":"2014-05-07T16:29:16Z","updated_at":"2014-10-28T16:44:43Z","pushed_at":"2014-10-28T16:49:40Z","git_url":"git://github.com/mobilejazz/KILabel.git","ssh_url":"git@github.com:mobilejazz/KILabel.git","clone_url":"https://github.com/mobilejazz/KILabel.git","svn_url":"https://github.com/mobilejazz/KILabel","homepage":null,"size":393,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Krelborn:master","ref":"master","sha":"dc7e4aae84b6ee01f141a1f1faf190bc0e4ddf3c","user":{"login":"Krelborn","id":1315792,"avatar_url":"https://avatars.githubusercontent.com/u/1315792?v=3","gravatar_id":"","url":"https://api.github.com/users/Krelborn","html_url":"https://github.com/Krelborn","followers_url":"https://api.github.com/users/Krelborn/followers","following_url":"https://api.github.com/users/Krelborn/following{/other_user}","gists_url":"https://api.github.com/users/Krelborn/gists{/gist_id}","starred_url":"https://api.github.com/users/Krelborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Krelborn/subscriptions","organizations_url":"https://api.github.com/users/Krelborn/orgs","repos_url":"https://api.github.com/users/Krelborn/repos","events_url":"https://api.github.com/users/Krelborn/events{/privacy}","received_events_url":"https://api.github.com/users/Krelborn/received_events","type":"User","site_admin":false},"repo":{"id":14494027,"name":"KILabel","full_name":"Krelborn/KILabel","owner":{"login":"Krelborn","id":1315792,"avatar_url":"https://avatars.githubusercontent.com/u/1315792?v=3","gravatar_id":"","url":"https://api.github.com/users/Krelborn","html_url":"https://github.com/Krelborn","followers_url":"https://api.github.com/users/Krelborn/followers","following_url":"https://api.github.com/users/Krelborn/following{/other_user}","gists_url":"https://api.github.com/users/Krelborn/gists{/gist_id}","starred_url":"https://api.github.com/users/Krelborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Krelborn/subscriptions","organizations_url":"https://api.github.com/users/Krelborn/orgs","repos_url":"https://api.github.com/users/Krelborn/repos","events_url":"https://api.github.com/users/Krelborn/events{/privacy}","received_events_url":"https://api.github.com/users/Krelborn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Krelborn/KILabel","description":"A simple to use drop in replacement for UILabel for iOS 7 that provides automatic detection of links such as URLs, twitter style usernames and hashtags.","fork":false,"url":"https://api.github.com/repos/Krelborn/KILabel","forks_url":"https://api.github.com/repos/Krelborn/KILabel/forks","keys_url":"https://api.github.com/repos/Krelborn/KILabel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Krelborn/KILabel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Krelborn/KILabel/teams","hooks_url":"https://api.github.com/repos/Krelborn/KILabel/hooks","issue_events_url":"https://api.github.com/repos/Krelborn/KILabel/issues/events{/number}","events_url":"https://api.github.com/repos/Krelborn/KILabel/events","assignees_url":"https://api.github.com/repos/Krelborn/KILabel/assignees{/user}","branches_url":"https://api.github.com/repos/Krelborn/KILabel/branches{/branch}","tags_url":"https://api.github.com/repos/Krelborn/KILabel/tags","blobs_url":"https://api.github.com/repos/Krelborn/KILabel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Krelborn/KILabel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Krelborn/KILabel/git/refs{/sha}","trees_url":"https://api.github.com/repos/Krelborn/KILabel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Krelborn/KILabel/statuses/{sha}","languages_url":"https://api.github.com/repos/Krelborn/KILabel/languages","stargazers_url":"https://api.github.com/repos/Krelborn/KILabel/stargazers","contributors_url":"https://api.github.com/repos/Krelborn/KILabel/contributors","subscribers_url":"https://api.github.com/repos/Krelborn/KILabel/subscribers","subscription_url":"https://api.github.com/repos/Krelborn/KILabel/subscription","commits_url":"https://api.github.com/repos/Krelborn/KILabel/commits{/sha}","git_commits_url":"https://api.github.com/repos/Krelborn/KILabel/git/commits{/sha}","comments_url":"https://api.github.com/repos/Krelborn/KILabel/comments{/number}","issue_comment_url":"https://api.github.com/repos/Krelborn/KILabel/issues/comments/{number}","contents_url":"https://api.github.com/repos/Krelborn/KILabel/contents/{+path}","compare_url":"https://api.github.com/repos/Krelborn/KILabel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Krelborn/KILabel/merges","archive_url":"https://api.github.com/repos/Krelborn/KILabel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Krelborn/KILabel/downloads","issues_url":"https://api.github.com/repos/Krelborn/KILabel/issues{/number}","pulls_url":"https://api.github.com/repos/Krelborn/KILabel/pulls{/number}","milestones_url":"https://api.github.com/repos/Krelborn/KILabel/milestones{/number}","notifications_url":"https://api.github.com/repos/Krelborn/KILabel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Krelborn/KILabel/labels{/name}","releases_url":"https://api.github.com/repos/Krelborn/KILabel/releases{/id}","created_at":"2013-11-18T14:04:05Z","updated_at":"2015-01-27T09:21:49Z","pushed_at":"2015-01-30T14:06:23Z","git_url":"git://github.com/Krelborn/KILabel.git","ssh_url":"git@github.com:Krelborn/KILabel.git","clone_url":"https://github.com/Krelborn/KILabel.git","svn_url":"https://github.com/Krelborn/KILabel","homepage":null,"size":470,"stargazers_count":54,"watchers_count":54,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":5,"forks":13,"open_issues":5,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Krelborn/KILabel/pulls/6"},"html":{"href":"https://github.com/Krelborn/KILabel/pull/6"},"issue":{"href":"https://api.github.com/repos/Krelborn/KILabel/issues/6"},"comments":{"href":"https://api.github.com/repos/Krelborn/KILabel/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/Krelborn/KILabel/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/Krelborn/KILabel/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Krelborn/KILabel/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/Krelborn/KILabel/statuses/5bddf0b69ddf9338dc6925dfe010fa7506c53b8a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Krelborn","id":1315792,"avatar_url":"https://avatars.githubusercontent.com/u/1315792?v=3","gravatar_id":"","url":"https://api.github.com/users/Krelborn","html_url":"https://github.com/Krelborn","followers_url":"https://api.github.com/users/Krelborn/followers","following_url":"https://api.github.com/users/Krelborn/following{/other_user}","gists_url":"https://api.github.com/users/Krelborn/gists{/gist_id}","starred_url":"https://api.github.com/users/Krelborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Krelborn/subscriptions","organizations_url":"https://api.github.com/users/Krelborn/orgs","repos_url":"https://api.github.com/users/Krelborn/repos","events_url":"https://api.github.com/users/Krelborn/events{/privacy}","received_events_url":"https://api.github.com/users/Krelborn/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":8,"additions":344,"deletions":255,"changed_files":6}}