{"action":"created","issue":{"url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/issues/79","labels_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/issues/79/comments","events_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/issues/79/events","html_url":"https://github.com/Yelp/puppet-monitoring_check/pull/79","id":114085244,"number":79,"title":"better compat with sensu-puppet for subdue param","user":{"login":"somic","id":16408,"avatar_url":"https://avatars.githubusercontent.com/u/16408?v=3","gravatar_id":"","url":"https://api.github.com/users/somic","html_url":"https://github.com/somic","followers_url":"https://api.github.com/users/somic/followers","following_url":"https://api.github.com/users/somic/following{/other_user}","gists_url":"https://api.github.com/users/somic/gists{/gist_id}","starred_url":"https://api.github.com/users/somic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/somic/subscriptions","organizations_url":"https://api.github.com/users/somic/orgs","repos_url":"https://api.github.com/users/somic/repos","events_url":"https://api.github.com/users/somic/events{/privacy}","received_events_url":"https://api.github.com/users/somic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-29T16:10:47Z","updated_at":"2015-10-29T16:28:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/pulls/79","html_url":"https://github.com/Yelp/puppet-monitoring_check/pull/79","diff_url":"https://github.com/Yelp/puppet-monitoring_check/pull/79.diff","patch_url":"https://github.com/Yelp/puppet-monitoring_check/pull/79.patch"},"body":"Our internal sensu-puppet doesn't have subdue param on sensu::check yet because this change was merged fairly recently.\r\n\r\nThis change introduces a simple compat mechanism to allow us and anybody else who's not running fairly recent sensu-puppet, to continue using monitoring_check."},"comment":{"url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/issues/comments/152235764","html_url":"https://github.com/Yelp/puppet-monitoring_check/pull/79#issuecomment-152235764","issue_url":"https://api.github.com/repos/Yelp/puppet-monitoring_check/issues/79","id":152235764,"user":{"login":"solarkennedy","id":370205,"avatar_url":"https://avatars.githubusercontent.com/u/370205?v=3","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false},"created_at":"2015-10-29T16:28:40Z","updated_at":"2015-10-29T16:28:40Z","body":"Hmm. I was actually going to just bump our version of the puppet module, but I understand what you are getting at.\r\n\r\nInstead of this though, what if `subdue` defaulted to undef and we used the https://github.com/puppetlabs/puppetlabs-stdlib#delete_undef_values function to remove it if it was unset?\r\n\r\nThat way only the people who want to use this feature will be required to provide a sensu module new enough to use it?"}}