{"action":"created","comment":{"url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/pulls/comments/29954975","id":29954975,"diff_hunk":"@@ -9,6 +9,7 @@ angular.module('configuration.identity', ['configuration.rest', 'ngCookies', 'ui\n         });\n \n         $scope.signOut = function () {\n+            $resource(restConfigService.getLogoutOperation()).delete();","path":"app/templates/skeleton/app/modules/configuration/identity/identity-config.js","position":12,"original_position":12,"commit_id":"ce595d0ce14a72cf65eb37a90a72eaa9b228b535","original_commit_id":"ce595d0ce14a72cf65eb37a90a72eaa9b228b535","user":{"login":"JLBoor","id":1694602,"avatar_url":"https://avatars.githubusercontent.com/u/1694602?v=3","gravatar_id":"","url":"https://api.github.com/users/JLBoor","html_url":"https://github.com/JLBoor","followers_url":"https://api.github.com/users/JLBoor/followers","following_url":"https://api.github.com/users/JLBoor/following{/other_user}","gists_url":"https://api.github.com/users/JLBoor/gists{/gist_id}","starred_url":"https://api.github.com/users/JLBoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JLBoor/subscriptions","organizations_url":"https://api.github.com/users/JLBoor/orgs","repos_url":"https://api.github.com/users/JLBoor/repos","events_url":"https://api.github.com/users/JLBoor/events{/privacy}","received_events_url":"https://api.github.com/users/JLBoor/received_events","type":"User","site_admin":false},"body":"Would it make sense to move this code inside the authenticationService ?","created_at":"2015-05-08T16:40:20Z","updated_at":"2015-05-08T16:40:20Z","html_url":"https://github.com/JLBoor/generator-jlb-angular/pull/2#discussion_r29954975","pull_request_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/JLBoor/generator-jlb-angular/pulls/comments/29954975"},"html":{"href":"https://github.com/JLBoor/generator-jlb-angular/pull/2#discussion_r29954975"},"pull_request":{"href":"https://api.github.com/repos/JLBoor/generator-jlb-angular/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/pulls/2","id":35024760,"html_url":"https://github.com/JLBoor/generator-jlb-angular/pull/2","diff_url":"https://github.com/JLBoor/generator-jlb-angular/pull/2.diff","patch_url":"https://github.com/JLBoor/generator-jlb-angular/pull/2.patch","issue_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/issues/2","number":2,"state":"open","locked":false,"title":"Java server integration","user":{"login":"elhartk","id":12296934,"avatar_url":"https://avatars.githubusercontent.com/u/12296934?v=3","gravatar_id":"","url":"https://api.github.com/users/elhartk","html_url":"https://github.com/elhartk","followers_url":"https://api.github.com/users/elhartk/followers","following_url":"https://api.github.com/users/elhartk/following{/other_user}","gists_url":"https://api.github.com/users/elhartk/gists{/gist_id}","starred_url":"https://api.github.com/users/elhartk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elhartk/subscriptions","organizations_url":"https://api.github.com/users/elhartk/orgs","repos_url":"https://api.github.com/users/elhartk/repos","events_url":"https://api.github.com/users/elhartk/events{/privacy}","received_events_url":"https://api.github.com/users/elhartk/received_events","type":"User","site_admin":false},"body":"Here are 3 fixes for your review.","created_at":"2015-05-08T16:33:33Z","updated_at":"2015-05-08T16:40:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"135b1d488f6baaca050271fe2c27ebbba6adc1bb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/pulls/2/commits","review_comments_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/pulls/2/comments","review_comment_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/issues/2/comments","statuses_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/statuses/ce595d0ce14a72cf65eb37a90a72eaa9b228b535","head":{"label":"elhartk:javaServerIntegration","ref":"javaServerIntegration","sha":"ce595d0ce14a72cf65eb37a90a72eaa9b228b535","user":{"login":"elhartk","id":12296934,"avatar_url":"https://avatars.githubusercontent.com/u/12296934?v=3","gravatar_id":"","url":"https://api.github.com/users/elhartk","html_url":"https://github.com/elhartk","followers_url":"https://api.github.com/users/elhartk/followers","following_url":"https://api.github.com/users/elhartk/following{/other_user}","gists_url":"https://api.github.com/users/elhartk/gists{/gist_id}","starred_url":"https://api.github.com/users/elhartk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elhartk/subscriptions","organizations_url":"https://api.github.com/users/elhartk/orgs","repos_url":"https://api.github.com/users/elhartk/repos","events_url":"https://api.github.com/users/elhartk/events{/privacy}","received_events_url":"https://api.github.com/users/elhartk/received_events","type":"User","site_admin":false},"repo":{"id":35223483,"name":"generator-jlb-angular","full_name":"elhartk/generator-jlb-angular","owner":{"login":"elhartk","id":12296934,"avatar_url":"https://avatars.githubusercontent.com/u/12296934?v=3","gravatar_id":"","url":"https://api.github.com/users/elhartk","html_url":"https://github.com/elhartk","followers_url":"https://api.github.com/users/elhartk/followers","following_url":"https://api.github.com/users/elhartk/following{/other_user}","gists_url":"https://api.github.com/users/elhartk/gists{/gist_id}","starred_url":"https://api.github.com/users/elhartk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elhartk/subscriptions","organizations_url":"https://api.github.com/users/elhartk/orgs","repos_url":"https://api.github.com/users/elhartk/repos","events_url":"https://api.github.com/users/elhartk/events{/privacy}","received_events_url":"https://api.github.com/users/elhartk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elhartk/generator-jlb-angular","description":"Yeoman Generator for maintainable AngularJS projects.","fork":true,"url":"https://api.github.com/repos/elhartk/generator-jlb-angular","forks_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/forks","keys_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/teams","hooks_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/hooks","issue_events_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/issues/events{/number}","events_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/events","assignees_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/assignees{/user}","branches_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/branches{/branch}","tags_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/tags","blobs_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/statuses/{sha}","languages_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/languages","stargazers_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/stargazers","contributors_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/contributors","subscribers_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/subscribers","subscription_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/subscription","commits_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/contents/{+path}","compare_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/merges","archive_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/downloads","issues_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/issues{/number}","pulls_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/pulls{/number}","milestones_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/milestones{/number}","notifications_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/labels{/name}","releases_url":"https://api.github.com/repos/elhartk/generator-jlb-angular/releases{/id}","created_at":"2015-05-07T14:04:30Z","updated_at":"2015-05-07T14:04:31Z","pushed_at":"2015-05-08T16:20:10Z","git_url":"git://github.com/elhartk/generator-jlb-angular.git","ssh_url":"git@github.com:elhartk/generator-jlb-angular.git","clone_url":"https://github.com/elhartk/generator-jlb-angular.git","svn_url":"https://github.com/elhartk/generator-jlb-angular","homepage":"","size":454,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JLBoor:javaServerIntegration","ref":"javaServerIntegration","sha":"bc120005abf633f4fb8bdc3b2f542e7ed4878134","user":{"login":"JLBoor","id":1694602,"avatar_url":"https://avatars.githubusercontent.com/u/1694602?v=3","gravatar_id":"","url":"https://api.github.com/users/JLBoor","html_url":"https://github.com/JLBoor","followers_url":"https://api.github.com/users/JLBoor/followers","following_url":"https://api.github.com/users/JLBoor/following{/other_user}","gists_url":"https://api.github.com/users/JLBoor/gists{/gist_id}","starred_url":"https://api.github.com/users/JLBoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JLBoor/subscriptions","organizations_url":"https://api.github.com/users/JLBoor/orgs","repos_url":"https://api.github.com/users/JLBoor/repos","events_url":"https://api.github.com/users/JLBoor/events{/privacy}","received_events_url":"https://api.github.com/users/JLBoor/received_events","type":"User","site_admin":false},"repo":{"id":31908350,"name":"generator-jlb-angular","full_name":"JLBoor/generator-jlb-angular","owner":{"login":"JLBoor","id":1694602,"avatar_url":"https://avatars.githubusercontent.com/u/1694602?v=3","gravatar_id":"","url":"https://api.github.com/users/JLBoor","html_url":"https://github.com/JLBoor","followers_url":"https://api.github.com/users/JLBoor/followers","following_url":"https://api.github.com/users/JLBoor/following{/other_user}","gists_url":"https://api.github.com/users/JLBoor/gists{/gist_id}","starred_url":"https://api.github.com/users/JLBoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JLBoor/subscriptions","organizations_url":"https://api.github.com/users/JLBoor/orgs","repos_url":"https://api.github.com/users/JLBoor/repos","events_url":"https://api.github.com/users/JLBoor/events{/privacy}","received_events_url":"https://api.github.com/users/JLBoor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JLBoor/generator-jlb-angular","description":"Yeoman Generator for maintainable AngularJS projects.","fork":true,"url":"https://api.github.com/repos/JLBoor/generator-jlb-angular","forks_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/forks","keys_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/teams","hooks_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/hooks","issue_events_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/issues/events{/number}","events_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/events","assignees_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/assignees{/user}","branches_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/branches{/branch}","tags_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/tags","blobs_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/statuses/{sha}","languages_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/languages","stargazers_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/stargazers","contributors_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/contributors","subscribers_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/subscribers","subscription_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/subscription","commits_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/contents/{+path}","compare_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/merges","archive_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/downloads","issues_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/issues{/number}","pulls_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/pulls{/number}","milestones_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/milestones{/number}","notifications_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/labels{/name}","releases_url":"https://api.github.com/repos/JLBoor/generator-jlb-angular/releases{/id}","created_at":"2015-03-09T16:03:51Z","updated_at":"2015-04-15T15:41:51Z","pushed_at":"2015-05-08T16:33:34Z","git_url":"git://github.com/JLBoor/generator-jlb-angular.git","ssh_url":"git@github.com:JLBoor/generator-jlb-angular.git","clone_url":"https://github.com/JLBoor/generator-jlb-angular.git","svn_url":"https://github.com/JLBoor/generator-jlb-angular","homepage":"","size":454,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JLBoor/generator-jlb-angular/pulls/2"},"html":{"href":"https://github.com/JLBoor/generator-jlb-angular/pull/2"},"issue":{"href":"https://api.github.com/repos/JLBoor/generator-jlb-angular/issues/2"},"comments":{"href":"https://api.github.com/repos/JLBoor/generator-jlb-angular/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/JLBoor/generator-jlb-angular/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/JLBoor/generator-jlb-angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JLBoor/generator-jlb-angular/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/JLBoor/generator-jlb-angular/statuses/ce595d0ce14a72cf65eb37a90a72eaa9b228b535"}}}}