{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/7319","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7319/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7319/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7319/events","html_url":"https://github.com/joomla/joomla-cms/pull/7319","id":92649004,"number":7319,"title":"JPagination link issue href issue in frontend with getListFooter","user":{"login":"gunjanpatel","id":2002921,"avatar_url":"https://avatars.githubusercontent.com/u/2002921?v=3","gravatar_id":"","url":"https://api.github.com/users/gunjanpatel","html_url":"https://github.com/gunjanpatel","followers_url":"https://api.github.com/users/gunjanpatel/followers","following_url":"https://api.github.com/users/gunjanpatel/following{/other_user}","gists_url":"https://api.github.com/users/gunjanpatel/gists{/gist_id}","starred_url":"https://api.github.com/users/gunjanpatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunjanpatel/subscriptions","organizations_url":"https://api.github.com/users/gunjanpatel/orgs","repos_url":"https://api.github.com/users/gunjanpatel/repos","events_url":"https://api.github.com/users/gunjanpatel/events{/privacy}","received_events_url":"https://api.github.com/users/gunjanpatel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-02T14:15:39Z","updated_at":"2015-07-03T05:02:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7319","html_url":"https://github.com/joomla/joomla-cms/pull/7319","diff_url":"https://github.com/joomla/joomla-cms/pull/7319.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/7319.patch"},"body":"### Problem\r\nWhen using `getListFooter` in frontend, having issue in pagination link. \r\n\r\n#### For Example:\r\nIf we use in `index.php?option=com_content&view=category&id=<category_id>&Itemid=260&limitstart=0`\r\n\r\n```\r\necho $this->pagination->getListFooter();\r\n```\r\n_Note: Layout or pagination file should not be overrided_\r\n\r\n### How to reproduce\r\nTo reproduce this issue can manually use above function in code or if you are using `JPagination` in your component you may check there. \r\n\r\n_There are many other ways to fix it by overriding `JPagination` class and `JLayout` but I think this should be fix in core too._\r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/118234231","html_url":"https://github.com/joomla/joomla-cms/pull/7319#issuecomment-118234231","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7319","id":118234231,"user":{"login":"gunjanpatel","id":2002921,"avatar_url":"https://avatars.githubusercontent.com/u/2002921?v=3","gravatar_id":"","url":"https://api.github.com/users/gunjanpatel","html_url":"https://github.com/gunjanpatel","followers_url":"https://api.github.com/users/gunjanpatel/followers","following_url":"https://api.github.com/users/gunjanpatel/following{/other_user}","gists_url":"https://api.github.com/users/gunjanpatel/gists{/gist_id}","starred_url":"https://api.github.com/users/gunjanpatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunjanpatel/subscriptions","organizations_url":"https://api.github.com/users/gunjanpatel/orgs","repos_url":"https://api.github.com/users/gunjanpatel/repos","events_url":"https://api.github.com/users/gunjanpatel/events{/privacy}","received_events_url":"https://api.github.com/users/gunjanpatel/received_events","type":"User","site_admin":false},"created_at":"2015-07-03T05:02:15Z","updated_at":"2015-07-03T05:02:15Z","body":"Thanks @Fedik for review\r\n> In theory, for frontend $pagination->getPaginationLinks() should fix your problem, there also some other methods that produce different pagination \"style\" :smile: ...\r\n\r\nYes, as I said there are many ways to get it fixed in your project. But this PR will fix issue in core.\r\n\r\n> In current pull request, check for JFactory::getApplication()->isAdmin() not really safe, as someone can use adminForm on the site also\r\n\r\nYes agree. Many developers are using `adminForm` in frontend. But this PR is using `$item->link` in `href` instead of `onclick` attribute. So, in any case it is correct to use `href` also good in SEO perspective. \r\n"}}