{"action":"created","comment":{"url":"https://api.github.com/repos/nrc/rustfmt/pulls/comments/39440823","id":39440823,"diff_hunk":"@@ -82,6 +82,50 @@ macro_rules! create_config {\n             $(pub $i: Option<$ty>),+\n         }\n \n+        // This trait and the following impl blocks are there only so that we\n+        // can use UCFS inside the get_docs() function on builtin types for configs.\n+        trait IsConfigType {\n+            fn get_variant_names() -> Vec<&'static str>;","path":"src/config.rs","position":16,"original_position":16,"commit_id":"cd9e9b5db08f03dff80e91cbc7e6beaf441cf3ec","original_commit_id":"8b808de6ff9aed5c631f088bf1293874b5299cff","user":{"login":"alobb","id":5897943,"avatar_url":"https://avatars.githubusercontent.com/u/5897943?v=3","gravatar_id":"","url":"https://api.github.com/users/alobb","html_url":"https://github.com/alobb","followers_url":"https://api.github.com/users/alobb/followers","following_url":"https://api.github.com/users/alobb/following{/other_user}","gists_url":"https://api.github.com/users/alobb/gists{/gist_id}","starred_url":"https://api.github.com/users/alobb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alobb/subscriptions","organizations_url":"https://api.github.com/users/alobb/orgs","repos_url":"https://api.github.com/users/alobb/repos","events_url":"https://api.github.com/users/alobb/events{/privacy}","received_events_url":"https://api.github.com/users/alobb/received_events","type":"User","site_admin":false},"body":"I think I understand; you mean as opposed to returning a `Vec<'static str>`, combine in `get_variant_names()` and only return `&'static str`?","created_at":"2015-09-14T20:13:32Z","updated_at":"2015-09-14T20:13:32Z","html_url":"https://github.com/nrc/rustfmt/pull/314#discussion_r39440823","pull_request_url":"https://api.github.com/repos/nrc/rustfmt/pulls/314","_links":{"self":{"href":"https://api.github.com/repos/nrc/rustfmt/pulls/comments/39440823"},"html":{"href":"https://github.com/nrc/rustfmt/pull/314#discussion_r39440823"},"pull_request":{"href":"https://api.github.com/repos/nrc/rustfmt/pulls/314"}}},"pull_request":{"url":"https://api.github.com/repos/nrc/rustfmt/pulls/314","id":44900151,"html_url":"https://github.com/nrc/rustfmt/pull/314","diff_url":"https://github.com/nrc/rustfmt/pull/314.diff","patch_url":"https://github.com/nrc/rustfmt/pull/314.patch","issue_url":"https://api.github.com/repos/nrc/rustfmt/issues/314","number":314,"state":"open","locked":false,"title":"Fixed https://github.com/nrc/rustfmt/issues/291","user":{"login":"alobb","id":5897943,"avatar_url":"https://avatars.githubusercontent.com/u/5897943?v=3","gravatar_id":"","url":"https://api.github.com/users/alobb","html_url":"https://github.com/alobb","followers_url":"https://api.github.com/users/alobb/followers","following_url":"https://api.github.com/users/alobb/following{/other_user}","gists_url":"https://api.github.com/users/alobb/gists{/gist_id}","starred_url":"https://api.github.com/users/alobb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alobb/subscriptions","organizations_url":"https://api.github.com/users/alobb/orgs","repos_url":"https://api.github.com/users/alobb/repos","events_url":"https://api.github.com/users/alobb/events{/privacy}","received_events_url":"https://api.github.com/users/alobb/received_events","type":"User","site_admin":false},"body":"Added to the create_config! macro to automatically create usage output when config options are added, as well as outputting all possible values for them.","created_at":"2015-09-14T07:32:21Z","updated_at":"2015-09-14T20:13:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f89304ec9f70c63e495ecdefc7c4dfe92131b6f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nrc/rustfmt/pulls/314/commits","review_comments_url":"https://api.github.com/repos/nrc/rustfmt/pulls/314/comments","review_comment_url":"https://api.github.com/repos/nrc/rustfmt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nrc/rustfmt/issues/314/comments","statuses_url":"https://api.github.com/repos/nrc/rustfmt/statuses/cd9e9b5db08f03dff80e91cbc7e6beaf441cf3ec","head":{"label":"alobb:configDocumentation","ref":"configDocumentation","sha":"cd9e9b5db08f03dff80e91cbc7e6beaf441cf3ec","user":{"login":"alobb","id":5897943,"avatar_url":"https://avatars.githubusercontent.com/u/5897943?v=3","gravatar_id":"","url":"https://api.github.com/users/alobb","html_url":"https://github.com/alobb","followers_url":"https://api.github.com/users/alobb/followers","following_url":"https://api.github.com/users/alobb/following{/other_user}","gists_url":"https://api.github.com/users/alobb/gists{/gist_id}","starred_url":"https://api.github.com/users/alobb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alobb/subscriptions","organizations_url":"https://api.github.com/users/alobb/orgs","repos_url":"https://api.github.com/users/alobb/repos","events_url":"https://api.github.com/users/alobb/events{/privacy}","received_events_url":"https://api.github.com/users/alobb/received_events","type":"User","site_admin":false},"repo":{"id":42433088,"name":"rustfmt","full_name":"alobb/rustfmt","owner":{"login":"alobb","id":5897943,"avatar_url":"https://avatars.githubusercontent.com/u/5897943?v=3","gravatar_id":"","url":"https://api.github.com/users/alobb","html_url":"https://github.com/alobb","followers_url":"https://api.github.com/users/alobb/followers","following_url":"https://api.github.com/users/alobb/following{/other_user}","gists_url":"https://api.github.com/users/alobb/gists{/gist_id}","starred_url":"https://api.github.com/users/alobb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alobb/subscriptions","organizations_url":"https://api.github.com/users/alobb/orgs","repos_url":"https://api.github.com/users/alobb/repos","events_url":"https://api.github.com/users/alobb/events{/privacy}","received_events_url":"https://api.github.com/users/alobb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alobb/rustfmt","description":"Format Rust code","fork":true,"url":"https://api.github.com/repos/alobb/rustfmt","forks_url":"https://api.github.com/repos/alobb/rustfmt/forks","keys_url":"https://api.github.com/repos/alobb/rustfmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alobb/rustfmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alobb/rustfmt/teams","hooks_url":"https://api.github.com/repos/alobb/rustfmt/hooks","issue_events_url":"https://api.github.com/repos/alobb/rustfmt/issues/events{/number}","events_url":"https://api.github.com/repos/alobb/rustfmt/events","assignees_url":"https://api.github.com/repos/alobb/rustfmt/assignees{/user}","branches_url":"https://api.github.com/repos/alobb/rustfmt/branches{/branch}","tags_url":"https://api.github.com/repos/alobb/rustfmt/tags","blobs_url":"https://api.github.com/repos/alobb/rustfmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alobb/rustfmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alobb/rustfmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/alobb/rustfmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alobb/rustfmt/statuses/{sha}","languages_url":"https://api.github.com/repos/alobb/rustfmt/languages","stargazers_url":"https://api.github.com/repos/alobb/rustfmt/stargazers","contributors_url":"https://api.github.com/repos/alobb/rustfmt/contributors","subscribers_url":"https://api.github.com/repos/alobb/rustfmt/subscribers","subscription_url":"https://api.github.com/repos/alobb/rustfmt/subscription","commits_url":"https://api.github.com/repos/alobb/rustfmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/alobb/rustfmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/alobb/rustfmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/alobb/rustfmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/alobb/rustfmt/contents/{+path}","compare_url":"https://api.github.com/repos/alobb/rustfmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alobb/rustfmt/merges","archive_url":"https://api.github.com/repos/alobb/rustfmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alobb/rustfmt/downloads","issues_url":"https://api.github.com/repos/alobb/rustfmt/issues{/number}","pulls_url":"https://api.github.com/repos/alobb/rustfmt/pulls{/number}","milestones_url":"https://api.github.com/repos/alobb/rustfmt/milestones{/number}","notifications_url":"https://api.github.com/repos/alobb/rustfmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alobb/rustfmt/labels{/name}","releases_url":"https://api.github.com/repos/alobb/rustfmt/releases{/id}","created_at":"2015-09-14T07:12:32Z","updated_at":"2015-09-14T07:12:32Z","pushed_at":"2015-09-14T20:09:44Z","git_url":"git://github.com/alobb/rustfmt.git","ssh_url":"git@github.com:alobb/rustfmt.git","clone_url":"https://github.com/alobb/rustfmt.git","svn_url":"https://github.com/alobb/rustfmt","homepage":null,"size":2004,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nrc:master","ref":"master","sha":"4738d284f2c1c6d448b3a375f547b61da2c86adc","user":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"repo":{"id":31830551,"name":"rustfmt","full_name":"nrc/rustfmt","owner":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nrc/rustfmt","description":"Format Rust code","fork":false,"url":"https://api.github.com/repos/nrc/rustfmt","forks_url":"https://api.github.com/repos/nrc/rustfmt/forks","keys_url":"https://api.github.com/repos/nrc/rustfmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nrc/rustfmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nrc/rustfmt/teams","hooks_url":"https://api.github.com/repos/nrc/rustfmt/hooks","issue_events_url":"https://api.github.com/repos/nrc/rustfmt/issues/events{/number}","events_url":"https://api.github.com/repos/nrc/rustfmt/events","assignees_url":"https://api.github.com/repos/nrc/rustfmt/assignees{/user}","branches_url":"https://api.github.com/repos/nrc/rustfmt/branches{/branch}","tags_url":"https://api.github.com/repos/nrc/rustfmt/tags","blobs_url":"https://api.github.com/repos/nrc/rustfmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nrc/rustfmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nrc/rustfmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/nrc/rustfmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nrc/rustfmt/statuses/{sha}","languages_url":"https://api.github.com/repos/nrc/rustfmt/languages","stargazers_url":"https://api.github.com/repos/nrc/rustfmt/stargazers","contributors_url":"https://api.github.com/repos/nrc/rustfmt/contributors","subscribers_url":"https://api.github.com/repos/nrc/rustfmt/subscribers","subscription_url":"https://api.github.com/repos/nrc/rustfmt/subscription","commits_url":"https://api.github.com/repos/nrc/rustfmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/nrc/rustfmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/nrc/rustfmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/nrc/rustfmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/nrc/rustfmt/contents/{+path}","compare_url":"https://api.github.com/repos/nrc/rustfmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nrc/rustfmt/merges","archive_url":"https://api.github.com/repos/nrc/rustfmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nrc/rustfmt/downloads","issues_url":"https://api.github.com/repos/nrc/rustfmt/issues{/number}","pulls_url":"https://api.github.com/repos/nrc/rustfmt/pulls{/number}","milestones_url":"https://api.github.com/repos/nrc/rustfmt/milestones{/number}","notifications_url":"https://api.github.com/repos/nrc/rustfmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nrc/rustfmt/labels{/name}","releases_url":"https://api.github.com/repos/nrc/rustfmt/releases{/id}","created_at":"2015-03-07T22:51:56Z","updated_at":"2015-09-13T11:13:18Z","pushed_at":"2015-09-14T20:09:45Z","git_url":"git://github.com/nrc/rustfmt.git","ssh_url":"git@github.com:nrc/rustfmt.git","clone_url":"https://github.com/nrc/rustfmt.git","svn_url":"https://github.com/nrc/rustfmt","homepage":null,"size":2004,"stargazers_count":330,"watchers_count":330,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":87,"forks":44,"open_issues":87,"watchers":330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nrc/rustfmt/pulls/314"},"html":{"href":"https://github.com/nrc/rustfmt/pull/314"},"issue":{"href":"https://api.github.com/repos/nrc/rustfmt/issues/314"},"comments":{"href":"https://api.github.com/repos/nrc/rustfmt/issues/314/comments"},"review_comments":{"href":"https://api.github.com/repos/nrc/rustfmt/pulls/314/comments"},"review_comment":{"href":"https://api.github.com/repos/nrc/rustfmt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nrc/rustfmt/pulls/314/commits"},"statuses":{"href":"https://api.github.com/repos/nrc/rustfmt/statuses/cd9e9b5db08f03dff80e91cbc7e6beaf441cf3ec"}}}}