{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/28443969","id":28443969,"diff_hunk":"@@ -220,6 +224,27 @@ pub mod fs {\n             self.as_inner_mut().mode(mode); self\n         }\n     }\n+\n+    /// Creates a new symbolic link on the filesystem.\n+    ///\n+    /// The `dst` path will be a symbolic link pointing to the `src` path.","path":"src/libstd/sys/unix/ext.rs","position":20,"original_position":20,"commit_id":"3c824c76d064f6874f8f4acca438dd29418e8165","original_commit_id":"72cfaaee19e02f7f8fb3d52820d447b92ea527e2","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"Could you also add some notes about how windows requires a special permission to create symlinks? Otherwise this all looks great to me!","created_at":"2015-04-15T17:46:57Z","updated_at":"2015-04-15T17:46:57Z","html_url":"https://github.com/rust-lang/rust/pull/24222#discussion_r28443969","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/24222","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/28443969"},"html":{"href":"https://github.com/rust-lang/rust/pull/24222#discussion_r28443969"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/24222"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/24222","id":32931574,"html_url":"https://github.com/rust-lang/rust/pull/24222","diff_url":"https://github.com/rust-lang/rust/pull/24222.diff","patch_url":"https://github.com/rust-lang/rust/pull/24222.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/24222","number":24222,"state":"open","locked":false,"title":"Rename std::fs::soft_link to std::fs::symlink","user":{"login":"lambda","id":37398,"avatar_url":"https://avatars.githubusercontent.com/u/37398?v=3","gravatar_id":"","url":"https://api.github.com/users/lambda","html_url":"https://github.com/lambda","followers_url":"https://api.github.com/users/lambda/followers","following_url":"https://api.github.com/users/lambda/following{/other_user}","gists_url":"https://api.github.com/users/lambda/gists{/gist_id}","starred_url":"https://api.github.com/users/lambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambda/subscriptions","organizations_url":"https://api.github.com/users/lambda/orgs","repos_url":"https://api.github.com/users/lambda/repos","events_url":"https://api.github.com/users/lambda/events{/privacy}","received_events_url":"https://api.github.com/users/lambda/received_events","type":"User","site_admin":false},"body":"The term \"soft link\" is not used in any other APIs or formal\r\ndocumentation on symbolic links, making this name somewhat surprising\r\nand hard to find.  Switch to the more commonly recognized, but still\r\nreasonably short, std::fs::symlink instead.\r\n\r\nBecause this is a stable API in the beta period, the old name is\r\nretained but marked deprecated as a wrapper around the new name.\r\n\r\nThis is discussed in rust-lang/rfcs#1048, and shouldn't be merged until that is approved.","created_at":"2015-04-09T07:36:14Z","updated_at":"2015-04-15T17:46:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"689effdfb6c773932ee1f23c23f1ab872d93cf09","assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/24222/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/24222/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/24222/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/3c824c76d064f6874f8f4acca438dd29418e8165","head":{"label":"lambda:rename-soft-link-to-symlink","ref":"rename-soft-link-to-symlink","sha":"3c824c76d064f6874f8f4acca438dd29418e8165","user":{"login":"lambda","id":37398,"avatar_url":"https://avatars.githubusercontent.com/u/37398?v=3","gravatar_id":"","url":"https://api.github.com/users/lambda","html_url":"https://github.com/lambda","followers_url":"https://api.github.com/users/lambda/followers","following_url":"https://api.github.com/users/lambda/following{/other_user}","gists_url":"https://api.github.com/users/lambda/gists{/gist_id}","starred_url":"https://api.github.com/users/lambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambda/subscriptions","organizations_url":"https://api.github.com/users/lambda/orgs","repos_url":"https://api.github.com/users/lambda/repos","events_url":"https://api.github.com/users/lambda/events{/privacy}","received_events_url":"https://api.github.com/users/lambda/received_events","type":"User","site_admin":false},"repo":{"id":24796648,"name":"rust","full_name":"lambda/rust","owner":{"login":"lambda","id":37398,"avatar_url":"https://avatars.githubusercontent.com/u/37398?v=3","gravatar_id":"","url":"https://api.github.com/users/lambda","html_url":"https://github.com/lambda","followers_url":"https://api.github.com/users/lambda/followers","following_url":"https://api.github.com/users/lambda/following{/other_user}","gists_url":"https://api.github.com/users/lambda/gists{/gist_id}","starred_url":"https://api.github.com/users/lambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambda/subscriptions","organizations_url":"https://api.github.com/users/lambda/orgs","repos_url":"https://api.github.com/users/lambda/repos","events_url":"https://api.github.com/users/lambda/events{/privacy}","received_events_url":"https://api.github.com/users/lambda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lambda/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/lambda/rust","forks_url":"https://api.github.com/repos/lambda/rust/forks","keys_url":"https://api.github.com/repos/lambda/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lambda/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lambda/rust/teams","hooks_url":"https://api.github.com/repos/lambda/rust/hooks","issue_events_url":"https://api.github.com/repos/lambda/rust/issues/events{/number}","events_url":"https://api.github.com/repos/lambda/rust/events","assignees_url":"https://api.github.com/repos/lambda/rust/assignees{/user}","branches_url":"https://api.github.com/repos/lambda/rust/branches{/branch}","tags_url":"https://api.github.com/repos/lambda/rust/tags","blobs_url":"https://api.github.com/repos/lambda/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lambda/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lambda/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/lambda/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lambda/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/lambda/rust/languages","stargazers_url":"https://api.github.com/repos/lambda/rust/stargazers","contributors_url":"https://api.github.com/repos/lambda/rust/contributors","subscribers_url":"https://api.github.com/repos/lambda/rust/subscribers","subscription_url":"https://api.github.com/repos/lambda/rust/subscription","commits_url":"https://api.github.com/repos/lambda/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/lambda/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/lambda/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/lambda/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/lambda/rust/contents/{+path}","compare_url":"https://api.github.com/repos/lambda/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lambda/rust/merges","archive_url":"https://api.github.com/repos/lambda/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lambda/rust/downloads","issues_url":"https://api.github.com/repos/lambda/rust/issues{/number}","pulls_url":"https://api.github.com/repos/lambda/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/lambda/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/lambda/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lambda/rust/labels{/name}","releases_url":"https://api.github.com/repos/lambda/rust/releases{/id}","created_at":"2014-10-04T17:44:00Z","updated_at":"2014-10-04T17:41:20Z","pushed_at":"2015-04-15T17:43:25Z","git_url":"git://github.com/lambda/rust.git","ssh_url":"git@github.com:lambda/rust.git","clone_url":"https://github.com/lambda/rust.git","svn_url":"https://github.com/lambda/rust","homepage":"http://www.rust-lang.org","size":272067,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"a691f1eefea586f154700be6ee1b991158f82b7f","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-04-15T17:31:42Z","pushed_at":"2015-04-15T17:43:27Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":553910,"stargazers_count":10320,"watchers_count":10320,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1987,"mirror_url":null,"open_issues_count":2037,"forks":1987,"open_issues":2037,"watchers":10320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/24222"},"html":{"href":"https://github.com/rust-lang/rust/pull/24222"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/24222"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/24222/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/24222/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/24222/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/3c824c76d064f6874f8f4acca438dd29418e8165"}}}}