{"action":"created","issue":{"url":"https://api.github.com/repos/4ian/GD/issues/190","labels_url":"https://api.github.com/repos/4ian/GD/issues/190/labels{/name}","comments_url":"https://api.github.com/repos/4ian/GD/issues/190/comments","events_url":"https://api.github.com/repos/4ian/GD/issues/190/events","html_url":"https://github.com/4ian/GD/issues/190","id":103596738,"number":190,"title":"Wrong accented characters in source files","user":{"login":"4ian","id":1280130,"avatar_url":"https://avatars.githubusercontent.com/u/1280130?v=3","gravatar_id":"","url":"https://api.github.com/users/4ian","html_url":"https://github.com/4ian","followers_url":"https://api.github.com/users/4ian/followers","following_url":"https://api.github.com/users/4ian/following{/other_user}","gists_url":"https://api.github.com/users/4ian/gists{/gist_id}","starred_url":"https://api.github.com/users/4ian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4ian/subscriptions","organizations_url":"https://api.github.com/users/4ian/orgs","repos_url":"https://api.github.com/users/4ian/repos","events_url":"https://api.github.com/users/4ian/events{/privacy}","received_events_url":"https://api.github.com/users/4ian/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-27T21:16:52Z","updated_at":"2015-08-27T22:31:29Z","closed_at":null,"body":"@victorlevasseur It seems that the sources are containing bad characters for accented characters (for example https://github.com/4ian/GD/blob/2593a9ef4d68cec81d1f336988fd3daceb37ad86/IDE/Credits.cpp#L223).\r\n\r\nI think it was messed up during the refactoring to use gd::String. What should be the rationale for the encoding of the source files? Are we using UTF8?"},"comment":{"url":"https://api.github.com/repos/4ian/GD/issues/comments/135574047","html_url":"https://github.com/4ian/GD/issues/190#issuecomment-135574047","issue_url":"https://api.github.com/repos/4ian/GD/issues/190","id":135574047,"user":{"login":"victorlevasseur","id":964512,"avatar_url":"https://avatars.githubusercontent.com/u/964512?v=3","gravatar_id":"","url":"https://api.github.com/users/victorlevasseur","html_url":"https://github.com/victorlevasseur","followers_url":"https://api.github.com/users/victorlevasseur/followers","following_url":"https://api.github.com/users/victorlevasseur/following{/other_user}","gists_url":"https://api.github.com/users/victorlevasseur/gists{/gist_id}","starred_url":"https://api.github.com/users/victorlevasseur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorlevasseur/subscriptions","organizations_url":"https://api.github.com/users/victorlevasseur/orgs","repos_url":"https://api.github.com/users/victorlevasseur/repos","events_url":"https://api.github.com/users/victorlevasseur/events{/privacy}","received_events_url":"https://api.github.com/users/victorlevasseur/received_events","type":"User","site_admin":false},"created_at":"2015-08-27T22:31:28Z","updated_at":"2015-08-27T22:31:28Z","body":"I think Github assumes that the source files are encoded in UTF8 but this\nfile is encoded in ISO 8859-1. That's why the accentuated character are\ndisplayed as invalid characters.\n\nLe jeu. 27 août 2015 à 23:16, Florian Rival <notifications@github.com> a\nécrit :\n\n> @victorlevasseur <https://github.com/victorlevasseur> It seems that the\n> sources are containing bad characters for accented characters (for example\n> https://github.com/4ian/GD/blob/2593a9ef4d68cec81d1f336988fd3daceb37ad86/IDE/Credits.cpp#L223\n> ).\n>\n> I think it was messed up during the refactoring to use gd::String. What\n> should be the rationale for the encoding of the source files? Are we using\n> UTF8?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/4ian/GD/issues/190>.\n>\n"}}