{"action":"closed","number":5412,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/5412","id":45824094,"html_url":"https://github.com/dotnet/roslyn/pull/5412","diff_url":"https://github.com/dotnet/roslyn/pull/5412.diff","patch_url":"https://github.com/dotnet/roslyn/pull/5412.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/5412","number":5412,"state":"closed","locked":false,"title":"Fix Roslyn EE to handle function pointers","user":{"login":"ericfe-ms","id":12943474,"avatar_url":"https://avatars.githubusercontent.com/u/12943474?v=3","gravatar_id":"","url":"https://api.github.com/users/ericfe-ms","html_url":"https://github.com/ericfe-ms","followers_url":"https://api.github.com/users/ericfe-ms/followers","following_url":"https://api.github.com/users/ericfe-ms/following{/other_user}","gists_url":"https://api.github.com/users/ericfe-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/ericfe-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericfe-ms/subscriptions","organizations_url":"https://api.github.com/users/ericfe-ms/orgs","repos_url":"https://api.github.com/users/ericfe-ms/repos","events_url":"https://api.github.com/users/ericfe-ms/events{/privacy}","received_events_url":"https://api.github.com/users/ericfe-ms/received_events","type":"User","site_admin":false},"body":"Fix NullReferenceException's in the result provider when consuming\r\nfunction pointers.\r\n\r\nThe VS 2015 Update 1 version of\r\nMicrosoft.VisualStudio.Debugger.Metadata.dll adds support for functions\r\npointers on the metadata api layer.  We represent it in the LMR type\r\nsystem through new api's to detect if a type is a function pointer and,\r\nif so, get the return type and argument types.  Currently, the result\r\nprovider crashes because it doesn't know how to handle a pointer type\r\nwith a null element type.  This change adds a couple of checks to\r\ndisable expansion on function pointers, which avoids the problem.  With\r\nthis change, the EE will simply display the memory address of the\r\nfunction pointer in the value column, with the function pointer type in\r\nthe type column.\r\n\r\nTo avoid taking a dependency on the Update 1 version of\r\nMicrosoft.VisualStudio.Debugger.MetadataReader.dll before it ships, we\r\ntemporarily shim Type.IsFunctionPointer() via an extension method.  The\r\nextension method exploits the fact that the function pointer case is the\r\nonly time we can have a pointer type with a null element type.  Once\r\nUpdate 1 ships and the project references are updated, we can remove the\r\nshim layer can just call Type.IsFunctionPointer() directly.","created_at":"2015-09-23T20:00:23Z","updated_at":"2015-09-24T21:16:16Z","closed_at":"2015-09-24T21:16:15Z","merged_at":"2015-09-24T21:16:15Z","merge_commit_sha":"3d21014e28aaca6e8fdc4953aea8f5685b233ddb","assignee":{"login":"amcasey","id":10508071,"avatar_url":"https://avatars.githubusercontent.com/u/10508071?v=3","gravatar_id":"","url":"https://api.github.com/users/amcasey","html_url":"https://github.com/amcasey","followers_url":"https://api.github.com/users/amcasey/followers","following_url":"https://api.github.com/users/amcasey/following{/other_user}","gists_url":"https://api.github.com/users/amcasey/gists{/gist_id}","starred_url":"https://api.github.com/users/amcasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcasey/subscriptions","organizations_url":"https://api.github.com/users/amcasey/orgs","repos_url":"https://api.github.com/users/amcasey/repos","events_url":"https://api.github.com/users/amcasey/events{/privacy}","received_events_url":"https://api.github.com/users/amcasey/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/5412/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/5412/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/5412/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/271096b85da5130b7bfddcbfe983f59e2938a796","head":{"label":"ericfe-ms:master","ref":"master","sha":"271096b85da5130b7bfddcbfe983f59e2938a796","user":{"login":"ericfe-ms","id":12943474,"avatar_url":"https://avatars.githubusercontent.com/u/12943474?v=3","gravatar_id":"","url":"https://api.github.com/users/ericfe-ms","html_url":"https://github.com/ericfe-ms","followers_url":"https://api.github.com/users/ericfe-ms/followers","following_url":"https://api.github.com/users/ericfe-ms/following{/other_user}","gists_url":"https://api.github.com/users/ericfe-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/ericfe-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericfe-ms/subscriptions","organizations_url":"https://api.github.com/users/ericfe-ms/orgs","repos_url":"https://api.github.com/users/ericfe-ms/repos","events_url":"https://api.github.com/users/ericfe-ms/events{/privacy}","received_events_url":"https://api.github.com/users/ericfe-ms/received_events","type":"User","site_admin":false},"repo":{"id":37624516,"name":"roslyn","full_name":"ericfe-ms/roslyn","owner":{"login":"ericfe-ms","id":12943474,"avatar_url":"https://avatars.githubusercontent.com/u/12943474?v=3","gravatar_id":"","url":"https://api.github.com/users/ericfe-ms","html_url":"https://github.com/ericfe-ms","followers_url":"https://api.github.com/users/ericfe-ms/followers","following_url":"https://api.github.com/users/ericfe-ms/following{/other_user}","gists_url":"https://api.github.com/users/ericfe-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/ericfe-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericfe-ms/subscriptions","organizations_url":"https://api.github.com/users/ericfe-ms/orgs","repos_url":"https://api.github.com/users/ericfe-ms/repos","events_url":"https://api.github.com/users/ericfe-ms/events{/privacy}","received_events_url":"https://api.github.com/users/ericfe-ms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericfe-ms/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/ericfe-ms/roslyn","forks_url":"https://api.github.com/repos/ericfe-ms/roslyn/forks","keys_url":"https://api.github.com/repos/ericfe-ms/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericfe-ms/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericfe-ms/roslyn/teams","hooks_url":"https://api.github.com/repos/ericfe-ms/roslyn/hooks","issue_events_url":"https://api.github.com/repos/ericfe-ms/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/ericfe-ms/roslyn/events","assignees_url":"https://api.github.com/repos/ericfe-ms/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/ericfe-ms/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/ericfe-ms/roslyn/tags","blobs_url":"https://api.github.com/repos/ericfe-ms/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericfe-ms/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericfe-ms/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericfe-ms/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericfe-ms/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/ericfe-ms/roslyn/languages","stargazers_url":"https://api.github.com/repos/ericfe-ms/roslyn/stargazers","contributors_url":"https://api.github.com/repos/ericfe-ms/roslyn/contributors","subscribers_url":"https://api.github.com/repos/ericfe-ms/roslyn/subscribers","subscription_url":"https://api.github.com/repos/ericfe-ms/roslyn/subscription","commits_url":"https://api.github.com/repos/ericfe-ms/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericfe-ms/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericfe-ms/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericfe-ms/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericfe-ms/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/ericfe-ms/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericfe-ms/roslyn/merges","archive_url":"https://api.github.com/repos/ericfe-ms/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericfe-ms/roslyn/downloads","issues_url":"https://api.github.com/repos/ericfe-ms/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/ericfe-ms/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/ericfe-ms/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/ericfe-ms/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericfe-ms/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/ericfe-ms/roslyn/releases{/id}","created_at":"2015-06-17T22:35:20Z","updated_at":"2015-06-17T22:35:49Z","pushed_at":"2015-09-24T16:07:47Z","git_url":"git://github.com/ericfe-ms/roslyn.git","ssh_url":"git@github.com:ericfe-ms/roslyn.git","clone_url":"https://github.com/ericfe-ms/roslyn.git","svn_url":"https://github.com/ericfe-ms/roslyn","homepage":"","size":99476,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"0a481241ab5f8776d8d1b7ff07252d087d0f82b2","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-09-24T17:12:17Z","pushed_at":"2015-09-24T21:16:16Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":193271,"stargazers_count":3342,"watchers_count":3342,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":779,"mirror_url":null,"open_issues_count":1463,"forks":779,"open_issues":1463,"watchers":3342,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/5412"},"html":{"href":"https://github.com/dotnet/roslyn/pull/5412"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/5412"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/5412/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/5412/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/5412/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/271096b85da5130b7bfddcbfe983f59e2938a796"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ericfe-ms","id":12943474,"avatar_url":"https://avatars.githubusercontent.com/u/12943474?v=3","gravatar_id":"","url":"https://api.github.com/users/ericfe-ms","html_url":"https://github.com/ericfe-ms","followers_url":"https://api.github.com/users/ericfe-ms/followers","following_url":"https://api.github.com/users/ericfe-ms/following{/other_user}","gists_url":"https://api.github.com/users/ericfe-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/ericfe-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericfe-ms/subscriptions","organizations_url":"https://api.github.com/users/ericfe-ms/orgs","repos_url":"https://api.github.com/users/ericfe-ms/repos","events_url":"https://api.github.com/users/ericfe-ms/events{/privacy}","received_events_url":"https://api.github.com/users/ericfe-ms/received_events","type":"User","site_admin":false},"comments":10,"review_comments":7,"commits":1,"additions":28,"deletions":2,"changed_files":4}}