{"action":"opened","number":231,"pull_request":{"url":"https://api.github.com/repos/tumblr/colossus/pulls/231","id":39942030,"html_url":"https://github.com/tumblr/colossus/pull/231","diff_url":"https://github.com/tumblr/colossus/pull/231.diff","patch_url":"https://github.com/tumblr/colossus/pull/231.patch","issue_url":"https://api.github.com/repos/tumblr/colossus/issues/231","number":231,"state":"open","locked":false,"title":"Adding exception handling into WriteBuffer","user":{"login":"DanSimon","id":287961,"avatar_url":"https://avatars.githubusercontent.com/u/287961?v=3","gravatar_id":"","url":"https://api.github.com/users/DanSimon","html_url":"https://github.com/DanSimon","followers_url":"https://api.github.com/users/DanSimon/followers","following_url":"https://api.github.com/users/DanSimon/following{/other_user}","gists_url":"https://api.github.com/users/DanSimon/gists{/gist_id}","starred_url":"https://api.github.com/users/DanSimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanSimon/subscriptions","organizations_url":"https://api.github.com/users/DanSimon/orgs","repos_url":"https://api.github.com/users/DanSimon/repos","events_url":"https://api.github.com/users/DanSimon/events{/privacy}","received_events_url":"https://api.github.com/users/DanSimon/received_events","type":"User","site_admin":false},"body":"If someone attempts to write to a closed connection, the call to `WriteBuffer.write` will currently throw the resulting `CancelledKeyException`, whereas it should just be returning a `Failure` state.  This is something that used to be here, but fell out during the rewrite that's in 0.6.4.\r\n\r\nAlso added some more docs, including explaining why we intentionally don't catch the same exception in `handleWrite`","created_at":"2015-07-14T17:43:28Z","updated_at":"2015-07-14T17:43:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":{"url":"https://api.github.com/repos/tumblr/colossus/milestones/19","html_url":"https://github.com/tumblr/colossus/milestones/0.6.4","labels_url":"https://api.github.com/repos/tumblr/colossus/milestones/19/labels","id":1147693,"number":19,"title":"0.6.4","description":"","creator":{"login":"DanSimon","id":287961,"avatar_url":"https://avatars.githubusercontent.com/u/287961?v=3","gravatar_id":"","url":"https://api.github.com/users/DanSimon","html_url":"https://github.com/DanSimon","followers_url":"https://api.github.com/users/DanSimon/followers","following_url":"https://api.github.com/users/DanSimon/following{/other_user}","gists_url":"https://api.github.com/users/DanSimon/gists{/gist_id}","starred_url":"https://api.github.com/users/DanSimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanSimon/subscriptions","organizations_url":"https://api.github.com/users/DanSimon/orgs","repos_url":"https://api.github.com/users/DanSimon/repos","events_url":"https://api.github.com/users/DanSimon/events{/privacy}","received_events_url":"https://api.github.com/users/DanSimon/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":16,"state":"open","created_at":"2015-06-03T15:44:48Z","updated_at":"2015-07-14T17:43:28Z","due_on":"2015-07-14T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/tumblr/colossus/pulls/231/commits","review_comments_url":"https://api.github.com/repos/tumblr/colossus/pulls/231/comments","review_comment_url":"https://api.github.com/repos/tumblr/colossus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tumblr/colossus/issues/231/comments","statuses_url":"https://api.github.com/repos/tumblr/colossus/statuses/3f7859da511c95b33a207f6341fb3f4be58fec6d","head":{"label":"tumblr:write-exceptions","ref":"write-exceptions","sha":"3f7859da511c95b33a207f6341fb3f4be58fec6d","user":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"repo":{"id":26492586,"name":"colossus","full_name":"tumblr/colossus","owner":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tumblr/colossus","description":"I/O and Microservice library for Scala","fork":false,"url":"https://api.github.com/repos/tumblr/colossus","forks_url":"https://api.github.com/repos/tumblr/colossus/forks","keys_url":"https://api.github.com/repos/tumblr/colossus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tumblr/colossus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tumblr/colossus/teams","hooks_url":"https://api.github.com/repos/tumblr/colossus/hooks","issue_events_url":"https://api.github.com/repos/tumblr/colossus/issues/events{/number}","events_url":"https://api.github.com/repos/tumblr/colossus/events","assignees_url":"https://api.github.com/repos/tumblr/colossus/assignees{/user}","branches_url":"https://api.github.com/repos/tumblr/colossus/branches{/branch}","tags_url":"https://api.github.com/repos/tumblr/colossus/tags","blobs_url":"https://api.github.com/repos/tumblr/colossus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tumblr/colossus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tumblr/colossus/git/refs{/sha}","trees_url":"https://api.github.com/repos/tumblr/colossus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tumblr/colossus/statuses/{sha}","languages_url":"https://api.github.com/repos/tumblr/colossus/languages","stargazers_url":"https://api.github.com/repos/tumblr/colossus/stargazers","contributors_url":"https://api.github.com/repos/tumblr/colossus/contributors","subscribers_url":"https://api.github.com/repos/tumblr/colossus/subscribers","subscription_url":"https://api.github.com/repos/tumblr/colossus/subscription","commits_url":"https://api.github.com/repos/tumblr/colossus/commits{/sha}","git_commits_url":"https://api.github.com/repos/tumblr/colossus/git/commits{/sha}","comments_url":"https://api.github.com/repos/tumblr/colossus/comments{/number}","issue_comment_url":"https://api.github.com/repos/tumblr/colossus/issues/comments{/number}","contents_url":"https://api.github.com/repos/tumblr/colossus/contents/{+path}","compare_url":"https://api.github.com/repos/tumblr/colossus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tumblr/colossus/merges","archive_url":"https://api.github.com/repos/tumblr/colossus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tumblr/colossus/downloads","issues_url":"https://api.github.com/repos/tumblr/colossus/issues{/number}","pulls_url":"https://api.github.com/repos/tumblr/colossus/pulls{/number}","milestones_url":"https://api.github.com/repos/tumblr/colossus/milestones{/number}","notifications_url":"https://api.github.com/repos/tumblr/colossus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tumblr/colossus/labels{/name}","releases_url":"https://api.github.com/repos/tumblr/colossus/releases{/id}","created_at":"2014-11-11T16:06:06Z","updated_at":"2015-07-13T05:24:12Z","pushed_at":"2015-07-14T17:43:28Z","git_url":"git://github.com/tumblr/colossus.git","ssh_url":"git@github.com:tumblr/colossus.git","clone_url":"https://github.com/tumblr/colossus.git","svn_url":"https://github.com/tumblr/colossus","homepage":"","size":5894,"stargazers_count":586,"watchers_count":586,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":40,"mirror_url":null,"open_issues_count":20,"forks":40,"open_issues":20,"watchers":586,"default_branch":"master"}},"base":{"label":"tumblr:master","ref":"master","sha":"743f0a9ee71fbfabac00504d7072db7a023a75ee","user":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"repo":{"id":26492586,"name":"colossus","full_name":"tumblr/colossus","owner":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tumblr/colossus","description":"I/O and Microservice library for Scala","fork":false,"url":"https://api.github.com/repos/tumblr/colossus","forks_url":"https://api.github.com/repos/tumblr/colossus/forks","keys_url":"https://api.github.com/repos/tumblr/colossus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tumblr/colossus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tumblr/colossus/teams","hooks_url":"https://api.github.com/repos/tumblr/colossus/hooks","issue_events_url":"https://api.github.com/repos/tumblr/colossus/issues/events{/number}","events_url":"https://api.github.com/repos/tumblr/colossus/events","assignees_url":"https://api.github.com/repos/tumblr/colossus/assignees{/user}","branches_url":"https://api.github.com/repos/tumblr/colossus/branches{/branch}","tags_url":"https://api.github.com/repos/tumblr/colossus/tags","blobs_url":"https://api.github.com/repos/tumblr/colossus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tumblr/colossus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tumblr/colossus/git/refs{/sha}","trees_url":"https://api.github.com/repos/tumblr/colossus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tumblr/colossus/statuses/{sha}","languages_url":"https://api.github.com/repos/tumblr/colossus/languages","stargazers_url":"https://api.github.com/repos/tumblr/colossus/stargazers","contributors_url":"https://api.github.com/repos/tumblr/colossus/contributors","subscribers_url":"https://api.github.com/repos/tumblr/colossus/subscribers","subscription_url":"https://api.github.com/repos/tumblr/colossus/subscription","commits_url":"https://api.github.com/repos/tumblr/colossus/commits{/sha}","git_commits_url":"https://api.github.com/repos/tumblr/colossus/git/commits{/sha}","comments_url":"https://api.github.com/repos/tumblr/colossus/comments{/number}","issue_comment_url":"https://api.github.com/repos/tumblr/colossus/issues/comments{/number}","contents_url":"https://api.github.com/repos/tumblr/colossus/contents/{+path}","compare_url":"https://api.github.com/repos/tumblr/colossus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tumblr/colossus/merges","archive_url":"https://api.github.com/repos/tumblr/colossus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tumblr/colossus/downloads","issues_url":"https://api.github.com/repos/tumblr/colossus/issues{/number}","pulls_url":"https://api.github.com/repos/tumblr/colossus/pulls{/number}","milestones_url":"https://api.github.com/repos/tumblr/colossus/milestones{/number}","notifications_url":"https://api.github.com/repos/tumblr/colossus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tumblr/colossus/labels{/name}","releases_url":"https://api.github.com/repos/tumblr/colossus/releases{/id}","created_at":"2014-11-11T16:06:06Z","updated_at":"2015-07-13T05:24:12Z","pushed_at":"2015-07-14T17:43:28Z","git_url":"git://github.com/tumblr/colossus.git","ssh_url":"git@github.com:tumblr/colossus.git","clone_url":"https://github.com/tumblr/colossus.git","svn_url":"https://github.com/tumblr/colossus","homepage":"","size":5894,"stargazers_count":586,"watchers_count":586,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":40,"mirror_url":null,"open_issues_count":20,"forks":40,"open_issues":20,"watchers":586,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tumblr/colossus/pulls/231"},"html":{"href":"https://github.com/tumblr/colossus/pull/231"},"issue":{"href":"https://api.github.com/repos/tumblr/colossus/issues/231"},"comments":{"href":"https://api.github.com/repos/tumblr/colossus/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/tumblr/colossus/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/tumblr/colossus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tumblr/colossus/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/tumblr/colossus/statuses/3f7859da511c95b33a207f6341fb3f4be58fec6d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":60,"deletions":19,"changed_files":3}}