{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/dunglas/php-property-info/pulls/6","id":43811284,"html_url":"https://github.com/dunglas/php-property-info/pull/6","diff_url":"https://github.com/dunglas/php-property-info/pull/6.diff","patch_url":"https://github.com/dunglas/php-property-info/pull/6.patch","issue_url":"https://api.github.com/repos/dunglas/php-property-info/issues/6","number":6,"state":"closed","locked":false,"title":"Type info parser pattern","user":{"login":"mihai-stancu","id":1294142,"avatar_url":"https://avatars.githubusercontent.com/u/1294142?v=3","gravatar_id":"","url":"https://api.github.com/users/mihai-stancu","html_url":"https://github.com/mihai-stancu","followers_url":"https://api.github.com/users/mihai-stancu/followers","following_url":"https://api.github.com/users/mihai-stancu/following{/other_user}","gists_url":"https://api.github.com/users/mihai-stancu/gists{/gist_id}","starred_url":"https://api.github.com/users/mihai-stancu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihai-stancu/subscriptions","organizations_url":"https://api.github.com/users/mihai-stancu/orgs","repos_url":"https://api.github.com/users/mihai-stancu/repos","events_url":"https://api.github.com/users/mihai-stancu/events{/privacy}","received_events_url":"https://api.github.com/users/mihai-stancu/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nThis PR covers the following:\r\n\r\n* refactored the `DoctrineExtractor` to work with the `TypeInfoParser` pattern I used for the `NativeExtractor`.\r\n* moved the HHVM specific logic into a trait (`ContainerTypeInfoParser`) in order to reuse the same parser for Doctrine.\r\n* refactored the `NativeExtractor` logic as a trait (instead of a class).\r\n* I noticed and fixed a bug in my HHVM implementation -- I understood the type/collectionType structure wrong and wrote the code and the tests according to my wrong understanding.\r\n\r\nHHVM Bug [fixed]: For any `Collection<Object>` I was returning a `$type->class = 'Object'` which contained a `$type->collectionType->class = 'Collection'`.\r\n","created_at":"2015-08-31T21:15:40Z","updated_at":"2015-09-18T14:22:04Z","closed_at":"2015-09-18T14:22:04Z","merged_at":null,"merge_commit_sha":"24b73b952def6ef442feb378c72cabaa2e376eae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dunglas/php-property-info/pulls/6/commits","review_comments_url":"https://api.github.com/repos/dunglas/php-property-info/pulls/6/comments","review_comment_url":"https://api.github.com/repos/dunglas/php-property-info/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dunglas/php-property-info/issues/6/comments","statuses_url":"https://api.github.com/repos/dunglas/php-property-info/statuses/1b443f304c8cd79a6d0539f26d08d7823471d5ec","head":{"label":"mihai-stancu:type_info_parser_pattern","ref":"type_info_parser_pattern","sha":"1b443f304c8cd79a6d0539f26d08d7823471d5ec","user":{"login":"mihai-stancu","id":1294142,"avatar_url":"https://avatars.githubusercontent.com/u/1294142?v=3","gravatar_id":"","url":"https://api.github.com/users/mihai-stancu","html_url":"https://github.com/mihai-stancu","followers_url":"https://api.github.com/users/mihai-stancu/followers","following_url":"https://api.github.com/users/mihai-stancu/following{/other_user}","gists_url":"https://api.github.com/users/mihai-stancu/gists{/gist_id}","starred_url":"https://api.github.com/users/mihai-stancu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihai-stancu/subscriptions","organizations_url":"https://api.github.com/users/mihai-stancu/orgs","repos_url":"https://api.github.com/users/mihai-stancu/repos","events_url":"https://api.github.com/users/mihai-stancu/events{/privacy}","received_events_url":"https://api.github.com/users/mihai-stancu/received_events","type":"User","site_admin":false},"repo":{"id":37942687,"name":"php-property-info","full_name":"mihai-stancu/php-property-info","owner":{"login":"mihai-stancu","id":1294142,"avatar_url":"https://avatars.githubusercontent.com/u/1294142?v=3","gravatar_id":"","url":"https://api.github.com/users/mihai-stancu","html_url":"https://github.com/mihai-stancu","followers_url":"https://api.github.com/users/mihai-stancu/followers","following_url":"https://api.github.com/users/mihai-stancu/following{/other_user}","gists_url":"https://api.github.com/users/mihai-stancu/gists{/gist_id}","starred_url":"https://api.github.com/users/mihai-stancu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihai-stancu/subscriptions","organizations_url":"https://api.github.com/users/mihai-stancu/orgs","repos_url":"https://api.github.com/users/mihai-stancu/repos","events_url":"https://api.github.com/users/mihai-stancu/events{/privacy}","received_events_url":"https://api.github.com/users/mihai-stancu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mihai-stancu/php-property-info","description":"Retrieve type and description of PHP properties using various sources ","fork":true,"url":"https://api.github.com/repos/mihai-stancu/php-property-info","forks_url":"https://api.github.com/repos/mihai-stancu/php-property-info/forks","keys_url":"https://api.github.com/repos/mihai-stancu/php-property-info/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mihai-stancu/php-property-info/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mihai-stancu/php-property-info/teams","hooks_url":"https://api.github.com/repos/mihai-stancu/php-property-info/hooks","issue_events_url":"https://api.github.com/repos/mihai-stancu/php-property-info/issues/events{/number}","events_url":"https://api.github.com/repos/mihai-stancu/php-property-info/events","assignees_url":"https://api.github.com/repos/mihai-stancu/php-property-info/assignees{/user}","branches_url":"https://api.github.com/repos/mihai-stancu/php-property-info/branches{/branch}","tags_url":"https://api.github.com/repos/mihai-stancu/php-property-info/tags","blobs_url":"https://api.github.com/repos/mihai-stancu/php-property-info/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mihai-stancu/php-property-info/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mihai-stancu/php-property-info/git/refs{/sha}","trees_url":"https://api.github.com/repos/mihai-stancu/php-property-info/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mihai-stancu/php-property-info/statuses/{sha}","languages_url":"https://api.github.com/repos/mihai-stancu/php-property-info/languages","stargazers_url":"https://api.github.com/repos/mihai-stancu/php-property-info/stargazers","contributors_url":"https://api.github.com/repos/mihai-stancu/php-property-info/contributors","subscribers_url":"https://api.github.com/repos/mihai-stancu/php-property-info/subscribers","subscription_url":"https://api.github.com/repos/mihai-stancu/php-property-info/subscription","commits_url":"https://api.github.com/repos/mihai-stancu/php-property-info/commits{/sha}","git_commits_url":"https://api.github.com/repos/mihai-stancu/php-property-info/git/commits{/sha}","comments_url":"https://api.github.com/repos/mihai-stancu/php-property-info/comments{/number}","issue_comment_url":"https://api.github.com/repos/mihai-stancu/php-property-info/issues/comments{/number}","contents_url":"https://api.github.com/repos/mihai-stancu/php-property-info/contents/{+path}","compare_url":"https://api.github.com/repos/mihai-stancu/php-property-info/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mihai-stancu/php-property-info/merges","archive_url":"https://api.github.com/repos/mihai-stancu/php-property-info/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mihai-stancu/php-property-info/downloads","issues_url":"https://api.github.com/repos/mihai-stancu/php-property-info/issues{/number}","pulls_url":"https://api.github.com/repos/mihai-stancu/php-property-info/pulls{/number}","milestones_url":"https://api.github.com/repos/mihai-stancu/php-property-info/milestones{/number}","notifications_url":"https://api.github.com/repos/mihai-stancu/php-property-info/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mihai-stancu/php-property-info/labels{/name}","releases_url":"https://api.github.com/repos/mihai-stancu/php-property-info/releases{/id}","created_at":"2015-06-23T20:19:00Z","updated_at":"2015-06-23T20:19:01Z","pushed_at":"2015-09-18T14:07:13Z","git_url":"git://github.com/mihai-stancu/php-property-info.git","ssh_url":"git@github.com:mihai-stancu/php-property-info.git","clone_url":"https://github.com/mihai-stancu/php-property-info.git","svn_url":"https://github.com/mihai-stancu/php-property-info","homepage":"http://dunglas.fr/2015/02/introducing-propertyinfo-a-php-component-to-find-types-and-doc-of-properties/","size":178,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dunglas:master","ref":"master","sha":"d5f336dd19fbd2564e90bb8109c5704cc227c4ea","user":{"login":"dunglas","id":57224,"avatar_url":"https://avatars.githubusercontent.com/u/57224?v=3","gravatar_id":"","url":"https://api.github.com/users/dunglas","html_url":"https://github.com/dunglas","followers_url":"https://api.github.com/users/dunglas/followers","following_url":"https://api.github.com/users/dunglas/following{/other_user}","gists_url":"https://api.github.com/users/dunglas/gists{/gist_id}","starred_url":"https://api.github.com/users/dunglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunglas/subscriptions","organizations_url":"https://api.github.com/users/dunglas/orgs","repos_url":"https://api.github.com/users/dunglas/repos","events_url":"https://api.github.com/users/dunglas/events{/privacy}","received_events_url":"https://api.github.com/users/dunglas/received_events","type":"User","site_admin":false},"repo":{"id":30669386,"name":"php-property-info","full_name":"dunglas/php-property-info","owner":{"login":"dunglas","id":57224,"avatar_url":"https://avatars.githubusercontent.com/u/57224?v=3","gravatar_id":"","url":"https://api.github.com/users/dunglas","html_url":"https://github.com/dunglas","followers_url":"https://api.github.com/users/dunglas/followers","following_url":"https://api.github.com/users/dunglas/following{/other_user}","gists_url":"https://api.github.com/users/dunglas/gists{/gist_id}","starred_url":"https://api.github.com/users/dunglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunglas/subscriptions","organizations_url":"https://api.github.com/users/dunglas/orgs","repos_url":"https://api.github.com/users/dunglas/repos","events_url":"https://api.github.com/users/dunglas/events{/privacy}","received_events_url":"https://api.github.com/users/dunglas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dunglas/php-property-info","description":"Retrieve type and description of PHP properties using various sources ","fork":false,"url":"https://api.github.com/repos/dunglas/php-property-info","forks_url":"https://api.github.com/repos/dunglas/php-property-info/forks","keys_url":"https://api.github.com/repos/dunglas/php-property-info/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dunglas/php-property-info/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dunglas/php-property-info/teams","hooks_url":"https://api.github.com/repos/dunglas/php-property-info/hooks","issue_events_url":"https://api.github.com/repos/dunglas/php-property-info/issues/events{/number}","events_url":"https://api.github.com/repos/dunglas/php-property-info/events","assignees_url":"https://api.github.com/repos/dunglas/php-property-info/assignees{/user}","branches_url":"https://api.github.com/repos/dunglas/php-property-info/branches{/branch}","tags_url":"https://api.github.com/repos/dunglas/php-property-info/tags","blobs_url":"https://api.github.com/repos/dunglas/php-property-info/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dunglas/php-property-info/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dunglas/php-property-info/git/refs{/sha}","trees_url":"https://api.github.com/repos/dunglas/php-property-info/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dunglas/php-property-info/statuses/{sha}","languages_url":"https://api.github.com/repos/dunglas/php-property-info/languages","stargazers_url":"https://api.github.com/repos/dunglas/php-property-info/stargazers","contributors_url":"https://api.github.com/repos/dunglas/php-property-info/contributors","subscribers_url":"https://api.github.com/repos/dunglas/php-property-info/subscribers","subscription_url":"https://api.github.com/repos/dunglas/php-property-info/subscription","commits_url":"https://api.github.com/repos/dunglas/php-property-info/commits{/sha}","git_commits_url":"https://api.github.com/repos/dunglas/php-property-info/git/commits{/sha}","comments_url":"https://api.github.com/repos/dunglas/php-property-info/comments{/number}","issue_comment_url":"https://api.github.com/repos/dunglas/php-property-info/issues/comments{/number}","contents_url":"https://api.github.com/repos/dunglas/php-property-info/contents/{+path}","compare_url":"https://api.github.com/repos/dunglas/php-property-info/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dunglas/php-property-info/merges","archive_url":"https://api.github.com/repos/dunglas/php-property-info/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dunglas/php-property-info/downloads","issues_url":"https://api.github.com/repos/dunglas/php-property-info/issues{/number}","pulls_url":"https://api.github.com/repos/dunglas/php-property-info/pulls{/number}","milestones_url":"https://api.github.com/repos/dunglas/php-property-info/milestones{/number}","notifications_url":"https://api.github.com/repos/dunglas/php-property-info/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dunglas/php-property-info/labels{/name}","releases_url":"https://api.github.com/repos/dunglas/php-property-info/releases{/id}","created_at":"2015-02-11T20:58:50Z","updated_at":"2015-09-14T08:00:14Z","pushed_at":"2015-09-18T14:07:14Z","git_url":"git://github.com/dunglas/php-property-info.git","ssh_url":"git@github.com:dunglas/php-property-info.git","clone_url":"https://github.com/dunglas/php-property-info.git","svn_url":"https://github.com/dunglas/php-property-info","homepage":"https://dunglas.fr/2015/02/introducing-propertyinfo-a-php-component-to-find-types-and-doc-of-properties/","size":318,"stargazers_count":24,"watchers_count":24,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dunglas/php-property-info/pulls/6"},"html":{"href":"https://github.com/dunglas/php-property-info/pull/6"},"issue":{"href":"https://api.github.com/repos/dunglas/php-property-info/issues/6"},"comments":{"href":"https://api.github.com/repos/dunglas/php-property-info/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/dunglas/php-property-info/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/dunglas/php-property-info/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dunglas/php-property-info/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/dunglas/php-property-info/statuses/1b443f304c8cd79a6d0539f26d08d7823471d5ec"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":17,"commits":5,"additions":393,"deletions":309,"changed_files":14}}