{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/46420283","id":46420283,"diff_hunk":"@@ -1898,8 +1898,9 @@ def _rs_series(expr, series_rs, a, prec):\n     elif expr.is_Mul:\n         n = len(args)\n         for arg in args:    # XXX Looks redundant\n-            R1, _ = sring(arg, expand=False, series=True)\n-            R = R.compose(R1)\n+            if not arg.is_Number:","path":"sympy/polys/ring_series.py","position":6,"original_position":6,"commit_id":"e21b152ce1d9d665671e94b6e94620a4c8177b71","original_commit_id":"e21b152ce1d9d665671e94b6e94620a4c8177b71","user":{"login":"smichr","id":90703,"avatar_url":"https://avatars.githubusercontent.com/u/90703?v=3","gravatar_id":"","url":"https://api.github.com/users/smichr","html_url":"https://github.com/smichr","followers_url":"https://api.github.com/users/smichr/followers","following_url":"https://api.github.com/users/smichr/following{/other_user}","gists_url":"https://api.github.com/users/smichr/gists{/gist_id}","starred_url":"https://api.github.com/users/smichr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smichr/subscriptions","organizations_url":"https://api.github.com/users/smichr/orgs","repos_url":"https://api.github.com/users/smichr/repos","events_url":"https://api.github.com/users/smichr/events{/privacy}","received_events_url":"https://api.github.com/users/smichr/received_events","type":"User","site_admin":false},"body":"Not familiar with this routine, but could arg be `sqrt(2)`? If so then you should use `arg.is_number`. ","created_at":"2015-12-02T14:33:03Z","updated_at":"2015-12-02T14:33:03Z","html_url":"https://github.com/sympy/sympy/pull/10186#discussion_r46420283","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/10186","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/46420283"},"html":{"href":"https://github.com/sympy/sympy/pull/10186#discussion_r46420283"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10186"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/10186","id":52355431,"html_url":"https://github.com/sympy/sympy/pull/10186","diff_url":"https://github.com/sympy/sympy/pull/10186.diff","patch_url":"https://github.com/sympy/sympy/pull/10186.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/10186","number":10186,"state":"open","locked":false,"title":"Handle numbers as coeffs of input expression","user":{"login":"shivamvats","id":6918975,"avatar_url":"https://avatars.githubusercontent.com/u/6918975?v=3","gravatar_id":"","url":"https://api.github.com/users/shivamvats","html_url":"https://github.com/shivamvats","followers_url":"https://api.github.com/users/shivamvats/followers","following_url":"https://api.github.com/users/shivamvats/following{/other_user}","gists_url":"https://api.github.com/users/shivamvats/gists{/gist_id}","starred_url":"https://api.github.com/users/shivamvats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivamvats/subscriptions","organizations_url":"https://api.github.com/users/shivamvats/orgs","repos_url":"https://api.github.com/users/shivamvats/repos","events_url":"https://api.github.com/users/shivamvats/events{/privacy}","received_events_url":"https://api.github.com/users/shivamvats/received_events","type":"User","site_admin":false},"body":"This case was failing earlier.\r\n\r\n@certik","created_at":"2015-12-02T05:30:51Z","updated_at":"2015-12-02T14:33:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b823f42a233c209f6909a6a3cf1342f3427a56fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/10186/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/10186/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/10186/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/e21b152ce1d9d665671e94b6e94620a4c8177b71","head":{"label":"shivamvats:handle_number","ref":"handle_number","sha":"e21b152ce1d9d665671e94b6e94620a4c8177b71","user":{"login":"shivamvats","id":6918975,"avatar_url":"https://avatars.githubusercontent.com/u/6918975?v=3","gravatar_id":"","url":"https://api.github.com/users/shivamvats","html_url":"https://github.com/shivamvats","followers_url":"https://api.github.com/users/shivamvats/followers","following_url":"https://api.github.com/users/shivamvats/following{/other_user}","gists_url":"https://api.github.com/users/shivamvats/gists{/gist_id}","starred_url":"https://api.github.com/users/shivamvats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivamvats/subscriptions","organizations_url":"https://api.github.com/users/shivamvats/orgs","repos_url":"https://api.github.com/users/shivamvats/repos","events_url":"https://api.github.com/users/shivamvats/events{/privacy}","received_events_url":"https://api.github.com/users/shivamvats/received_events","type":"User","site_admin":false},"repo":{"id":25822792,"name":"sympy","full_name":"shivamvats/sympy","owner":{"login":"shivamvats","id":6918975,"avatar_url":"https://avatars.githubusercontent.com/u/6918975?v=3","gravatar_id":"","url":"https://api.github.com/users/shivamvats","html_url":"https://github.com/shivamvats","followers_url":"https://api.github.com/users/shivamvats/followers","following_url":"https://api.github.com/users/shivamvats/following{/other_user}","gists_url":"https://api.github.com/users/shivamvats/gists{/gist_id}","starred_url":"https://api.github.com/users/shivamvats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivamvats/subscriptions","organizations_url":"https://api.github.com/users/shivamvats/orgs","repos_url":"https://api.github.com/users/shivamvats/repos","events_url":"https://api.github.com/users/shivamvats/events{/privacy}","received_events_url":"https://api.github.com/users/shivamvats/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shivamvats/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/shivamvats/sympy","forks_url":"https://api.github.com/repos/shivamvats/sympy/forks","keys_url":"https://api.github.com/repos/shivamvats/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shivamvats/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shivamvats/sympy/teams","hooks_url":"https://api.github.com/repos/shivamvats/sympy/hooks","issue_events_url":"https://api.github.com/repos/shivamvats/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/shivamvats/sympy/events","assignees_url":"https://api.github.com/repos/shivamvats/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/shivamvats/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/shivamvats/sympy/tags","blobs_url":"https://api.github.com/repos/shivamvats/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shivamvats/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shivamvats/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/shivamvats/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shivamvats/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/shivamvats/sympy/languages","stargazers_url":"https://api.github.com/repos/shivamvats/sympy/stargazers","contributors_url":"https://api.github.com/repos/shivamvats/sympy/contributors","subscribers_url":"https://api.github.com/repos/shivamvats/sympy/subscribers","subscription_url":"https://api.github.com/repos/shivamvats/sympy/subscription","commits_url":"https://api.github.com/repos/shivamvats/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/shivamvats/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/shivamvats/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/shivamvats/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/shivamvats/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/shivamvats/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shivamvats/sympy/merges","archive_url":"https://api.github.com/repos/shivamvats/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shivamvats/sympy/downloads","issues_url":"https://api.github.com/repos/shivamvats/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/shivamvats/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/shivamvats/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/shivamvats/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shivamvats/sympy/labels{/name}","releases_url":"https://api.github.com/repos/shivamvats/sympy/releases{/id}","created_at":"2014-10-27T14:24:33Z","updated_at":"2014-11-07T04:25:04Z","pushed_at":"2015-12-02T05:28:24Z","git_url":"git://github.com/shivamvats/sympy.git","ssh_url":"git@github.com:shivamvats/sympy.git","clone_url":"https://github.com/shivamvats/sympy.git","svn_url":"https://github.com/shivamvats/sympy","homepage":"http://sympy.org/","size":73031,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"cbc73f198998c4d53b228511ed3a821fa4e1bb8f","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","created_at":"2010-04-30T20:37:14Z","updated_at":"2015-12-01T20:08:14Z","pushed_at":"2015-12-02T10:32:32Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":102310,"stargazers_count":2485,"watchers_count":2485,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1210,"mirror_url":null,"open_issues_count":2074,"forks":1210,"open_issues":2074,"watchers":2485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10186"},"html":{"href":"https://github.com/sympy/sympy/pull/10186"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/10186"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/10186/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10186/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10186/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/e21b152ce1d9d665671e94b6e94620a4c8177b71"}}}}