{"action":"created","comment":{"url":"https://api.github.com/repos/oaeproject/Hilary/pulls/comments/27988593","id":27988593,"diff_hunk":"@@ -1839,15 +1810,22 @@ describe('Users', function() {\n                                                     // Verify an incorrect email is invalid\n                                                     PrincipalsTestUtil.assertUpdateUserFails(jack.restContext, jack.user.id, {'email': 'so incorrect'}, 400, function() {\n \n-                                                        // Make sure that the user's basic profile is unchanged\n-                                                        RestAPI.User.getUser(jack.restContext, jack.user.id, function(err, userObj) {\n-                                                            assert.ok(!err);\n-                                                            assert.ok(userObj);\n-                                                            assert.equal(userObj.visibility, jack.user.visibility);\n-                                                            assert.equal(userObj.displayName, jack.user.displayName);\n-                                                            assert.equal(userObj.resourceType, 'user');\n-                                                            assert.equal(userObj.profilePath, '/user/' + userObj.tenant.alias + '/' + AuthzUtil.getResourceFromId(userObj.id).resourceId);\n-                                                            return callback();\n+                                                        // Verify unknown fields aren't allowed\n+                                                        PrincipalsTestUtil.assertUpdateUserFails(jack.restContext, jack.user.id, {'wumptiedumpty': true}, 400, function() {\n+\n+                                                            // Make sure that the user's basic profile is unchanged\n+                                                            RestAPI.User.getUser(jack.restContext, jack.user.id, function(err, userObj) {\n+                                                                assert.ok(!err);\n+                                                                assert.ok(userObj);\n+                                                                assert.equal(userObj.visibility, jack.user.visibility);\n+                                                                assert.equal(userObj.displayName, jack.user.displayName);\n+                                                                assert.equal(userObj.resourceType, 'user');\n+                                                                assert.equal(userObj.profilePath, '/user/' + userObj.tenant.alias + '/' + AuthzUtil.getResourceFromId(userObj.id).resourceId);\n+                                                                assert.equal(userObj.email, jack.user.email);\n+                                                                assert.equal(userObj.emailChange, jack.user.emailChange);\n+                                                                assert.equal(userObj.emailVerified, jack.user.emailVerified);","path":"node_modules/oae-principals/tests/test-users.js","position":130,"original_position":130,"commit_id":"4db4dc832fd71d8c1b1214605419f739e200422d","original_commit_id":"4db4dc832fd71d8c1b1214605419f739e200422d","user":{"login":"mrvisser","id":102265,"avatar_url":"https://avatars.githubusercontent.com/u/102265?v=3","gravatar_id":"","url":"https://api.github.com/users/mrvisser","html_url":"https://github.com/mrvisser","followers_url":"https://api.github.com/users/mrvisser/followers","following_url":"https://api.github.com/users/mrvisser/following{/other_user}","gists_url":"https://api.github.com/users/mrvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/mrvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrvisser/subscriptions","organizations_url":"https://api.github.com/users/mrvisser/orgs","repos_url":"https://api.github.com/users/mrvisser/repos","events_url":"https://api.github.com/users/mrvisser/events{/privacy}","received_events_url":"https://api.github.com/users/mrvisser/received_events","type":"User","site_admin":false},"body":"These assertions should be removed. Can you do a quick `git grep` for these and make sure they're all gone?","created_at":"2015-04-08T16:47:18Z","updated_at":"2015-04-08T16:47:18Z","html_url":"https://github.com/oaeproject/Hilary/pull/1160#discussion_r27988593","pull_request_url":"https://api.github.com/repos/oaeproject/Hilary/pulls/1160","_links":{"self":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/comments/27988593"},"html":{"href":"https://github.com/oaeproject/Hilary/pull/1160#discussion_r27988593"},"pull_request":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/1160"}}},"pull_request":{"url":"https://api.github.com/repos/oaeproject/Hilary/pulls/1160","id":32168780,"html_url":"https://github.com/oaeproject/Hilary/pull/1160","diff_url":"https://github.com/oaeproject/Hilary/pull/1160.diff","patch_url":"https://github.com/oaeproject/Hilary/pull/1160.patch","issue_url":"https://api.github.com/repos/oaeproject/Hilary/issues/1160","number":1160,"state":"open","locked":false,"title":"Email verification","user":{"login":"simong","id":92180,"avatar_url":"https://avatars.githubusercontent.com/u/92180?v=3","gravatar_id":"","url":"https://api.github.com/users/simong","html_url":"https://github.com/simong","followers_url":"https://api.github.com/users/simong/followers","following_url":"https://api.github.com/users/simong/following{/other_user}","gists_url":"https://api.github.com/users/simong/gists{/gist_id}","starred_url":"https://api.github.com/users/simong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simong/subscriptions","organizations_url":"https://api.github.com/users/simong/orgs","repos_url":"https://api.github.com/users/simong/repos","events_url":"https://api.github.com/users/simong/events{/privacy}","received_events_url":"https://api.github.com/users/simong/received_events","type":"User","site_admin":false},"body":"This build on top of https://github.com/oaeproject/Hilary/pull/1153 but I'm submitting for review in any-case","created_at":"2015-03-28T18:31:14Z","updated_at":"2015-04-08T16:47:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"797871e086599d57d6586ee05c142b91f069c64d","assignee":{"login":"mrvisser","id":102265,"avatar_url":"https://avatars.githubusercontent.com/u/102265?v=3","gravatar_id":"","url":"https://api.github.com/users/mrvisser","html_url":"https://github.com/mrvisser","followers_url":"https://api.github.com/users/mrvisser/followers","following_url":"https://api.github.com/users/mrvisser/following{/other_user}","gists_url":"https://api.github.com/users/mrvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/mrvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrvisser/subscriptions","organizations_url":"https://api.github.com/users/mrvisser/orgs","repos_url":"https://api.github.com/users/mrvisser/repos","events_url":"https://api.github.com/users/mrvisser/events{/privacy}","received_events_url":"https://api.github.com/users/mrvisser/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/oaeproject/Hilary/pulls/1160/commits","review_comments_url":"https://api.github.com/repos/oaeproject/Hilary/pulls/1160/comments","review_comment_url":"https://api.github.com/repos/oaeproject/Hilary/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oaeproject/Hilary/issues/1160/comments","statuses_url":"https://api.github.com/repos/oaeproject/Hilary/statuses/4db4dc832fd71d8c1b1214605419f739e200422d","head":{"label":"simong:email-verification-clean","ref":"email-verification-clean","sha":"4db4dc832fd71d8c1b1214605419f739e200422d","user":{"login":"simong","id":92180,"avatar_url":"https://avatars.githubusercontent.com/u/92180?v=3","gravatar_id":"","url":"https://api.github.com/users/simong","html_url":"https://github.com/simong","followers_url":"https://api.github.com/users/simong/followers","following_url":"https://api.github.com/users/simong/following{/other_user}","gists_url":"https://api.github.com/users/simong/gists{/gist_id}","starred_url":"https://api.github.com/users/simong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simong/subscriptions","organizations_url":"https://api.github.com/users/simong/orgs","repos_url":"https://api.github.com/users/simong/repos","events_url":"https://api.github.com/users/simong/events{/privacy}","received_events_url":"https://api.github.com/users/simong/received_events","type":"User","site_admin":false},"repo":{"id":5638617,"name":"Hilary","full_name":"simong/Hilary","owner":{"login":"simong","id":92180,"avatar_url":"https://avatars.githubusercontent.com/u/92180?v=3","gravatar_id":"","url":"https://api.github.com/users/simong","html_url":"https://github.com/simong","followers_url":"https://api.github.com/users/simong/followers","following_url":"https://api.github.com/users/simong/following{/other_user}","gists_url":"https://api.github.com/users/simong/gists{/gist_id}","starred_url":"https://api.github.com/users/simong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simong/subscriptions","organizations_url":"https://api.github.com/users/simong/orgs","repos_url":"https://api.github.com/users/simong/repos","events_url":"https://api.github.com/users/simong/events{/privacy}","received_events_url":"https://api.github.com/users/simong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simong/Hilary","description":"","fork":true,"url":"https://api.github.com/repos/simong/Hilary","forks_url":"https://api.github.com/repos/simong/Hilary/forks","keys_url":"https://api.github.com/repos/simong/Hilary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simong/Hilary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simong/Hilary/teams","hooks_url":"https://api.github.com/repos/simong/Hilary/hooks","issue_events_url":"https://api.github.com/repos/simong/Hilary/issues/events{/number}","events_url":"https://api.github.com/repos/simong/Hilary/events","assignees_url":"https://api.github.com/repos/simong/Hilary/assignees{/user}","branches_url":"https://api.github.com/repos/simong/Hilary/branches{/branch}","tags_url":"https://api.github.com/repos/simong/Hilary/tags","blobs_url":"https://api.github.com/repos/simong/Hilary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simong/Hilary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simong/Hilary/git/refs{/sha}","trees_url":"https://api.github.com/repos/simong/Hilary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simong/Hilary/statuses/{sha}","languages_url":"https://api.github.com/repos/simong/Hilary/languages","stargazers_url":"https://api.github.com/repos/simong/Hilary/stargazers","contributors_url":"https://api.github.com/repos/simong/Hilary/contributors","subscribers_url":"https://api.github.com/repos/simong/Hilary/subscribers","subscription_url":"https://api.github.com/repos/simong/Hilary/subscription","commits_url":"https://api.github.com/repos/simong/Hilary/commits{/sha}","git_commits_url":"https://api.github.com/repos/simong/Hilary/git/commits{/sha}","comments_url":"https://api.github.com/repos/simong/Hilary/comments{/number}","issue_comment_url":"https://api.github.com/repos/simong/Hilary/issues/comments{/number}","contents_url":"https://api.github.com/repos/simong/Hilary/contents/{+path}","compare_url":"https://api.github.com/repos/simong/Hilary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simong/Hilary/merges","archive_url":"https://api.github.com/repos/simong/Hilary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simong/Hilary/downloads","issues_url":"https://api.github.com/repos/simong/Hilary/issues{/number}","pulls_url":"https://api.github.com/repos/simong/Hilary/pulls{/number}","milestones_url":"https://api.github.com/repos/simong/Hilary/milestones{/number}","notifications_url":"https://api.github.com/repos/simong/Hilary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simong/Hilary/labels{/name}","releases_url":"https://api.github.com/repos/simong/Hilary/releases{/id}","created_at":"2012-09-01T10:17:52Z","updated_at":"2015-03-22T12:32:33Z","pushed_at":"2015-04-02T14:37:19Z","git_url":"git://github.com/simong/Hilary.git","ssh_url":"git@github.com:simong/Hilary.git","clone_url":"https://github.com/simong/Hilary.git","svn_url":"https://github.com/simong/Hilary","homepage":null,"size":24371,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"oaeproject:inviting-guests","ref":"inviting-guests","sha":"3fbaca0ab4b209f05b30f78d3671c3d9024df545","user":{"login":"oaeproject","id":4659912,"avatar_url":"https://avatars.githubusercontent.com/u/4659912?v=3","gravatar_id":"","url":"https://api.github.com/users/oaeproject","html_url":"https://github.com/oaeproject","followers_url":"https://api.github.com/users/oaeproject/followers","following_url":"https://api.github.com/users/oaeproject/following{/other_user}","gists_url":"https://api.github.com/users/oaeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/oaeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oaeproject/subscriptions","organizations_url":"https://api.github.com/users/oaeproject/orgs","repos_url":"https://api.github.com/users/oaeproject/repos","events_url":"https://api.github.com/users/oaeproject/events{/privacy}","received_events_url":"https://api.github.com/users/oaeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":5638565,"name":"Hilary","full_name":"oaeproject/Hilary","owner":{"login":"oaeproject","id":4659912,"avatar_url":"https://avatars.githubusercontent.com/u/4659912?v=3","gravatar_id":"","url":"https://api.github.com/users/oaeproject","html_url":"https://github.com/oaeproject","followers_url":"https://api.github.com/users/oaeproject/followers","following_url":"https://api.github.com/users/oaeproject/following{/other_user}","gists_url":"https://api.github.com/users/oaeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/oaeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oaeproject/subscriptions","organizations_url":"https://api.github.com/users/oaeproject/orgs","repos_url":"https://api.github.com/users/oaeproject/repos","events_url":"https://api.github.com/users/oaeproject/events{/privacy}","received_events_url":"https://api.github.com/users/oaeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oaeproject/Hilary","description":"Open Academic Environment (OAE) Back-End","fork":false,"url":"https://api.github.com/repos/oaeproject/Hilary","forks_url":"https://api.github.com/repos/oaeproject/Hilary/forks","keys_url":"https://api.github.com/repos/oaeproject/Hilary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oaeproject/Hilary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oaeproject/Hilary/teams","hooks_url":"https://api.github.com/repos/oaeproject/Hilary/hooks","issue_events_url":"https://api.github.com/repos/oaeproject/Hilary/issues/events{/number}","events_url":"https://api.github.com/repos/oaeproject/Hilary/events","assignees_url":"https://api.github.com/repos/oaeproject/Hilary/assignees{/user}","branches_url":"https://api.github.com/repos/oaeproject/Hilary/branches{/branch}","tags_url":"https://api.github.com/repos/oaeproject/Hilary/tags","blobs_url":"https://api.github.com/repos/oaeproject/Hilary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oaeproject/Hilary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oaeproject/Hilary/git/refs{/sha}","trees_url":"https://api.github.com/repos/oaeproject/Hilary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oaeproject/Hilary/statuses/{sha}","languages_url":"https://api.github.com/repos/oaeproject/Hilary/languages","stargazers_url":"https://api.github.com/repos/oaeproject/Hilary/stargazers","contributors_url":"https://api.github.com/repos/oaeproject/Hilary/contributors","subscribers_url":"https://api.github.com/repos/oaeproject/Hilary/subscribers","subscription_url":"https://api.github.com/repos/oaeproject/Hilary/subscription","commits_url":"https://api.github.com/repos/oaeproject/Hilary/commits{/sha}","git_commits_url":"https://api.github.com/repos/oaeproject/Hilary/git/commits{/sha}","comments_url":"https://api.github.com/repos/oaeproject/Hilary/comments{/number}","issue_comment_url":"https://api.github.com/repos/oaeproject/Hilary/issues/comments{/number}","contents_url":"https://api.github.com/repos/oaeproject/Hilary/contents/{+path}","compare_url":"https://api.github.com/repos/oaeproject/Hilary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oaeproject/Hilary/merges","archive_url":"https://api.github.com/repos/oaeproject/Hilary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oaeproject/Hilary/downloads","issues_url":"https://api.github.com/repos/oaeproject/Hilary/issues{/number}","pulls_url":"https://api.github.com/repos/oaeproject/Hilary/pulls{/number}","milestones_url":"https://api.github.com/repos/oaeproject/Hilary/milestones{/number}","notifications_url":"https://api.github.com/repos/oaeproject/Hilary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oaeproject/Hilary/labels{/name}","releases_url":"https://api.github.com/repos/oaeproject/Hilary/releases{/id}","created_at":"2012-09-01T10:05:13Z","updated_at":"2015-03-26T15:30:12Z","pushed_at":"2015-04-08T00:48:27Z","git_url":"git://github.com/oaeproject/Hilary.git","ssh_url":"git@github.com:oaeproject/Hilary.git","clone_url":"https://github.com/oaeproject/Hilary.git","svn_url":"https://github.com/oaeproject/Hilary","homepage":"http://www.oaeproject.org","size":28927,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":31,"forks":64,"open_issues":31,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/1160"},"html":{"href":"https://github.com/oaeproject/Hilary/pull/1160"},"issue":{"href":"https://api.github.com/repos/oaeproject/Hilary/issues/1160"},"comments":{"href":"https://api.github.com/repos/oaeproject/Hilary/issues/1160/comments"},"review_comments":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/1160/comments"},"review_comment":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oaeproject/Hilary/pulls/1160/commits"},"statuses":{"href":"https://api.github.com/repos/oaeproject/Hilary/statuses/4db4dc832fd71d8c1b1214605419f739e200422d"}}}}