{"action":"created","issue":{"url":"https://api.github.com/repos/CounterpartyXCP/counterpartyd/issues/728","labels_url":"https://api.github.com/repos/CounterpartyXCP/counterpartyd/issues/728/labels{/name}","comments_url":"https://api.github.com/repos/CounterpartyXCP/counterpartyd/issues/728/comments","events_url":"https://api.github.com/repos/CounterpartyXCP/counterpartyd/issues/728/events","html_url":"https://github.com/CounterpartyXCP/counterpartyd/pull/728","id":59990482,"number":728,"title":"Some refactoring to make possible transactions checking client-side","user":{"login":"ouziel-slama","id":4574979,"avatar_url":"https://avatars.githubusercontent.com/u/4574979?v=3","gravatar_id":"","url":"https://api.github.com/users/ouziel-slama","html_url":"https://github.com/ouziel-slama","followers_url":"https://api.github.com/users/ouziel-slama/followers","following_url":"https://api.github.com/users/ouziel-slama/following{/other_user}","gists_url":"https://api.github.com/users/ouziel-slama/gists{/gist_id}","starred_url":"https://api.github.com/users/ouziel-slama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ouziel-slama/subscriptions","organizations_url":"https://api.github.com/users/ouziel-slama/orgs","repos_url":"https://api.github.com/users/ouziel-slama/repos","events_url":"https://api.github.com/users/ouziel-slama/events{/privacy}","received_events_url":"https://api.github.com/users/ouziel-slama/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-05T18:04:11Z","updated_at":"2015-03-09T12:15:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CounterpartyXCP/counterpartyd/pulls/728","html_url":"https://github.com/CounterpartyXCP/counterpartyd/pull/728","diff_url":"https://github.com/CounterpartyXCP/counterpartyd/pull/728.diff","patch_url":"https://github.com/CounterpartyXCP/counterpartyd/pull/728.patch"},"body":"Move sub functions outside `get_tx_info2()` because `counterpary-cli` needs the function `decode_output()` to check transactions generated by a server.\r\n\r\nAdd `raw_unpack_data()` method. This method don't use the database or the backend.\r\nIt is used by `counterparty-client/gui` to check transactions generated by `counterparty-server`.\r\n\r\nsee: https://github.com/CounterpartyXCP/counterparty-cli/pull/34"},"comment":{"url":"https://api.github.com/repos/CounterpartyXCP/counterpartyd/issues/comments/77842940","html_url":"https://github.com/CounterpartyXCP/counterpartyd/pull/728#issuecomment-77842940","issue_url":"https://api.github.com/repos/CounterpartyXCP/counterpartyd/issues/728","id":77842940,"user":{"login":"ouziel-slama","id":4574979,"avatar_url":"https://avatars.githubusercontent.com/u/4574979?v=3","gravatar_id":"","url":"https://api.github.com/users/ouziel-slama","html_url":"https://github.com/ouziel-slama","followers_url":"https://api.github.com/users/ouziel-slama/followers","following_url":"https://api.github.com/users/ouziel-slama/following{/other_user}","gists_url":"https://api.github.com/users/ouziel-slama/gists{/gist_id}","starred_url":"https://api.github.com/users/ouziel-slama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ouziel-slama/subscriptions","organizations_url":"https://api.github.com/users/ouziel-slama/orgs","repos_url":"https://api.github.com/users/ouziel-slama/repos","events_url":"https://api.github.com/users/ouziel-slama/events{/privacy}","received_events_url":"https://api.github.com/users/ouziel-slama/received_events","type":"User","site_admin":false},"created_at":"2015-03-09T12:15:53Z","updated_at":"2015-03-09T12:15:53Z","body":"@adamkrellenstein, there is problem to check `btcpay` transaction without database: it's impossible to get the address and amount corresponding to the order hash without querying the database.\r\nTo enable full client side validation, maybe we should add two mandatories parameters for `btcpay`: `destination` and `amount`. \r\nOr we can show for confirmation to the user, these 2 parameters when the transaction is generated.\r\nthought?"}}