{"action":"created","issue":{"url":"https://api.github.com/repos/sbt/sbt/issues/2228","labels_url":"https://api.github.com/repos/sbt/sbt/issues/2228/labels{/name}","comments_url":"https://api.github.com/repos/sbt/sbt/issues/2228/comments","events_url":"https://api.github.com/repos/sbt/sbt/issues/2228/events","html_url":"https://github.com/sbt/sbt/issues/2228","id":109174590,"number":2228,"title":"sbt's handling of javac errors differs between running locally and forked.","user":{"login":"baroquebobcat","id":7378,"avatar_url":"https://avatars.githubusercontent.com/u/7378?v=3","gravatar_id":"","url":"https://api.github.com/users/baroquebobcat","html_url":"https://github.com/baroquebobcat","followers_url":"https://api.github.com/users/baroquebobcat/followers","following_url":"https://api.github.com/users/baroquebobcat/following{/other_user}","gists_url":"https://api.github.com/users/baroquebobcat/gists{/gist_id}","starred_url":"https://api.github.com/users/baroquebobcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baroquebobcat/subscriptions","organizations_url":"https://api.github.com/users/baroquebobcat/orgs","repos_url":"https://api.github.com/users/baroquebobcat/repos","events_url":"https://api.github.com/users/baroquebobcat/events{/privacy}","received_events_url":"https://api.github.com/users/baroquebobcat/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sbt/sbt/labels/Bug","name":"Bug","color":"e10c02"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-30T20:37:38Z","updated_at":"2015-11-02T13:43:44Z","closed_at":null,"body":"We ran into this when javac's encoding had been accidentally defaulted to ascii. We have a java file with a comment containing utf-8 characters. When sbt compiles with a forked javac, it fails to compile. When sbt compiles with a local javac it compiles successfully, but prints the errors from javac as errors.\r\n\r\nThis is confusing because users expect compiler errors to cause a compilation failure.\r\n\r\nThe thing that's interesting is that it fails to compile as expected both locally and forked when the utf-8 character is in a char literal or a string literal.\r\n\r\nI was able to verify this with the source version of sbt on the 0.13 branch with a change to JavaCompilerSpec, but I'm not sure how to approach fixing it."},"comment":{"url":"https://api.github.com/repos/sbt/sbt/issues/comments/153020363","html_url":"https://github.com/sbt/sbt/issues/2228#issuecomment-153020363","issue_url":"https://api.github.com/repos/sbt/sbt/issues/2228","id":153020363,"user":{"login":"eed3si9n","id":184683,"avatar_url":"https://avatars.githubusercontent.com/u/184683?v=3","gravatar_id":"","url":"https://api.github.com/users/eed3si9n","html_url":"https://github.com/eed3si9n","followers_url":"https://api.github.com/users/eed3si9n/followers","following_url":"https://api.github.com/users/eed3si9n/following{/other_user}","gists_url":"https://api.github.com/users/eed3si9n/gists{/gist_id}","starred_url":"https://api.github.com/users/eed3si9n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eed3si9n/subscriptions","organizations_url":"https://api.github.com/users/eed3si9n/orgs","repos_url":"https://api.github.com/users/eed3si9n/repos","events_url":"https://api.github.com/users/eed3si9n/events{/privacy}","received_events_url":"https://api.github.com/users/eed3si9n/received_events","type":"User","site_admin":false},"created_at":"2015-11-02T13:43:43Z","updated_at":"2015-11-02T13:43:43Z","body":"> I suppose all the messages reported as ERROR to the DiagnosticsReporter should be flushed as WARNING if the compilation actually succeeded?\r\n\r\nWe have a stringly logic that determines what's an error and what's a warning. I don't know if we should change that completely. Maybe this needed to be added as a warning. /cc @jsuereth "}}