{"action":"created","issue":{"url":"https://api.github.com/repos/emberjs/ember.js/issues/12314","labels_url":"https://api.github.com/repos/emberjs/ember.js/issues/12314/labels{/name}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/12314/comments","events_url":"https://api.github.com/repos/emberjs/ember.js/issues/12314/events","html_url":"https://github.com/emberjs/ember.js/pull/12314","id":105671374,"number":12314,"title":"[BUGFIX beta] Mandatory setter should check prototype descriptors.","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-09T19:49:42Z","updated_at":"2015-09-21T23:51:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/12314","html_url":"https://github.com/emberjs/ember.js/pull/12314","diff_url":"https://github.com/emberjs/ember.js/pull/12314.diff","patch_url":"https://github.com/emberjs/ember.js/pull/12314.patch"},"body":"Prior to this change, a setter that exists on the prototype of the object was not detected and was effectively clobbered.\n\nThis change updates `handleMandatorySetter` to check both the objects own descriptors and its prototypes descriptors.\n\nAlso removed the guard for `Object.getOwnPropertyDescriptor` since all supported platforms are ES5."},"comment":{"url":"https://api.github.com/repos/emberjs/ember.js/issues/comments/142140319","html_url":"https://github.com/emberjs/ember.js/pull/12314#issuecomment-142140319","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/12314","id":142140319,"user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"created_at":"2015-09-21T23:51:43Z","updated_at":"2015-09-21T23:51:43Z","body":"quick chat with @krisselden, he raised that this does not walk the proto chain correctly. Which can cause us to accidentally miss + smash inherited accessors. This will likely cause another perf hit, but I suspect we may want to pursue it.\r\n\r\n@krisselden im curious if you have any other ideas."}}