{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/26100045","id":26100045,"diff_hunk":"@@ -148,10 +150,19 @@ public void CopyPublic(List<FunctionEndPoint> rhs)\n                     continue;\n                 }\n \n-                if (fep.DoesTypeDeepMatch(reducedParamSVs, runtimeCore))\n+                bool typesOK = true;\n+                foreach (List<StackValue> reducedParamSVs in allReducedParamSVs)\n                 {\n-                    ret.Add(fep);\n+                    if (!fep.DoesTypeDeepMatch(reducedParamSVs, runtimeCore))","path":"src/Engine/ProtoCore/Lang/FunctionGroup.cs","position":27,"original_position":27,"commit_id":"82792853c2de622d68eeb9973c982ad7c1634e33","original_commit_id":"82792853c2de622d68eeb9973c982ad7c1634e33","user":{"login":"junmendoza","id":5109659,"avatar_url":"https://avatars.githubusercontent.com/u/5109659?v=3","gravatar_id":"","url":"https://api.github.com/users/junmendoza","html_url":"https://github.com/junmendoza","followers_url":"https://api.github.com/users/junmendoza/followers","following_url":"https://api.github.com/users/junmendoza/following{/other_user}","gists_url":"https://api.github.com/users/junmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/junmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junmendoza/subscriptions","organizations_url":"https://api.github.com/users/junmendoza/orgs","repos_url":"https://api.github.com/users/junmendoza/repos","events_url":"https://api.github.com/users/junmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/junmendoza/received_events","type":"User","site_admin":false},"body":"YEa seems to be righter this time. Previously it seemed to only check a match for the first param","created_at":"2015-03-10T05:43:43Z","updated_at":"2015-03-10T05:43:43Z","html_url":"https://github.com/DynamoDS/Dynamo/pull/3932#discussion_r26100045","pull_request_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/3932","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/26100045"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/3932#discussion_r26100045"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/3932"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/3932","id":30816087,"html_url":"https://github.com/DynamoDS/Dynamo/pull/3932","diff_url":"https://github.com/DynamoDS/Dynamo/pull/3932.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/3932.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/3932","number":3932,"state":"open","locked":false,"title":"Fix for type system resolution error","user":{"login":"lukechurch","id":2978182,"avatar_url":"https://avatars.githubusercontent.com/u/2978182?v=3","gravatar_id":"","url":"https://api.github.com/users/lukechurch","html_url":"https://github.com/lukechurch","followers_url":"https://api.github.com/users/lukechurch/followers","following_url":"https://api.github.com/users/lukechurch/following{/other_user}","gists_url":"https://api.github.com/users/lukechurch/gists{/gist_id}","starred_url":"https://api.github.com/users/lukechurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukechurch/subscriptions","organizations_url":"https://api.github.com/users/lukechurch/orgs","repos_url":"https://api.github.com/users/lukechurch/repos","events_url":"https://api.github.com/users/lukechurch/events{/privacy}","received_events_url":"https://api.github.com/users/lukechurch/received_events","type":"User","site_admin":false},"body":"This is PR 1/2\r\n\r\nThis fixes the functionality of when a replication is forced over a hetreo-type array with multiple exact matches e.g.\r\n\r\n{0, 1.0}<1> dispatching correctly to an int and double \r\n\r\nPR 2/2 will reunify case 1 and 1a, and generalise to do testing of cases 3,4 and 5 under partially replication guide forced conditions\r\n\r\nRegression tests running now, I will only merge if they're clean.\r\n\r\n@junmendoza \r\n","created_at":"2015-03-10T01:37:00Z","updated_at":"2015-03-10T05:43:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44d7cad72477c3c9568f7647b36a9d2a1bf4aca5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/3932/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/3932/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/3932/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/82792853c2de622d68eeb9973c982ad7c1634e33","head":{"label":"DynamoDS:MAGN5729_candidate","ref":"MAGN5729_candidate","sha":"82792853c2de622d68eeb9973c982ad7c1634e33","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"name":"Dynamo","full_name":"DynamoDS/Dynamo","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/Dynamo","description":"Visual Programming","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","created_at":"2012-02-09T07:35:33Z","updated_at":"2015-03-09T22:35:48Z","pushed_at":"2015-03-10T01:33:44Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":884774,"stargazers_count":203,"watchers_count":203,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"open_issues_count":549,"forks":142,"open_issues":549,"watchers":203,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"15f9c4c28c88d96b1955bfca1c574e76c23e5427","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"name":"Dynamo","full_name":"DynamoDS/Dynamo","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/Dynamo","description":"Visual Programming","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","created_at":"2012-02-09T07:35:33Z","updated_at":"2015-03-09T22:35:48Z","pushed_at":"2015-03-10T01:33:44Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":884774,"stargazers_count":203,"watchers_count":203,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"open_issues_count":549,"forks":142,"open_issues":549,"watchers":203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/3932"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/3932"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/3932"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/3932/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/3932/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/3932/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/82792853c2de622d68eeb9973c982ad7c1634e33"}}}}