{"action":"created","comment":{"url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/comments/26685224","id":26685224,"diff_hunk":"@@ -42,51 +38,13 @@\n   include rjil::contrail::server\n \n   ##\n-  # Add route target in contrail config database.\n+  # Create fip pools including creation of network, subnet, fip pool etc\n   ##\n-  contrail_rt {\"default-domain:services:${public_network_name}\":\n-    ensure             => present,\n-    rt_number          => $public_rt_number,\n-    router_asn         => $router_asn,\n-    api_server_address => $contrail_api_server,\n-    admin_password     => $keystone_admin_password,\n-    require            => Neutron_network[$public_network_name],\n-  }\n-\n-  consul_kv{'neutron/floatingip_pool/status':\n-    value   => 'ready',\n-    require => Contrail_rt[\"default-domain:services:${public_network_name}\"],\n-  }\n-\n-  if $public_cidr {\n-    ##\n-    # Add floating IPs\n-    ##\n-\n-    neutron_network {$public_network_name:\n-      ensure          => present,\n-      router_external => true,\n-    }\n-\n-    if $public_subnet_ip_start {\n-      if !$public_subnet_ip_end {\n-        fail('public_subnet_ip_end is required if subset of IPs to be added to subnet')\n-      }\n-\n-      neutron_subnet {$public_subnet_name:\n-        ensure           => present,\n-        cidr             => $public_cidr,\n-        network_name     => $public_network_name,\n-        allocation_pools => [\"start=$public_subnet_ip_start,end=$public_subnet_ip_end\"],\n-        before           => Contrail_rt[\"default-domain:services:${public_network_name}\"],\n-      }\n-    } else {\n-      neutron_subnet {$public_subnet_name:\n-        ensure       => present,\n-        cidr         => $public_cidr,\n-        network_name => $public_network_name,\n-        before       => Contrail_rt[\"default-domain:services:${public_network_name}\"],\n-      }\n-    }\n-  }\n+  $fip_pool_defaults = {","path":"manifests/neutron/contrail.pp","position":71,"original_position":71,"commit_id":"3d93253e2a8bd22a89e44351176d176e2f0d279c","original_commit_id":"3d93253e2a8bd22a89e44351176d176e2f0d279c","user":{"login":"bodepd","id":97123,"avatar_url":"https://avatars.githubusercontent.com/u/97123?v=3","gravatar_id":"","url":"https://api.github.com/users/bodepd","html_url":"https://github.com/bodepd","followers_url":"https://api.github.com/users/bodepd/followers","following_url":"https://api.github.com/users/bodepd/following{/other_user}","gists_url":"https://api.github.com/users/bodepd/gists{/gist_id}","starred_url":"https://api.github.com/users/bodepd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bodepd/subscriptions","organizations_url":"https://api.github.com/users/bodepd/orgs","repos_url":"https://api.github.com/users/bodepd/repos","events_url":"https://api.github.com/users/bodepd/events{/privacy}","received_events_url":"https://api.github.com/users/bodepd/received_events","type":"User","site_admin":false},"body":"I' d much rather have a fp_pools class so that we can just add it to whatever the seed role is.","created_at":"2015-03-18T17:19:09Z","updated_at":"2015-03-18T17:19:09Z","html_url":"https://github.com/JioCloud/puppet-rjil/pull/475#discussion_r26685224","pull_request_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/475","_links":{"self":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/comments/26685224"},"html":{"href":"https://github.com/JioCloud/puppet-rjil/pull/475#discussion_r26685224"},"pull_request":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/475"}}},"pull_request":{"url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/475","id":31427236,"html_url":"https://github.com/JioCloud/puppet-rjil/pull/475","diff_url":"https://github.com/JioCloud/puppet-rjil/pull/475.diff","patch_url":"https://github.com/JioCloud/puppet-rjil/pull/475.patch","issue_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/475","number":475,"state":"open","locked":false,"title":"Code to create fip pool using different methods","user":{"login":"hkumarmk","id":6316902,"avatar_url":"https://avatars.githubusercontent.com/u/6316902?v=3","gravatar_id":"","url":"https://api.github.com/users/hkumarmk","html_url":"https://github.com/hkumarmk","followers_url":"https://api.github.com/users/hkumarmk/followers","following_url":"https://api.github.com/users/hkumarmk/following{/other_user}","gists_url":"https://api.github.com/users/hkumarmk/gists{/gist_id}","starred_url":"https://api.github.com/users/hkumarmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkumarmk/subscriptions","organizations_url":"https://api.github.com/users/hkumarmk/orgs","repos_url":"https://api.github.com/users/hkumarmk/repos","events_url":"https://api.github.com/users/hkumarmk/events{/privacy}","received_events_url":"https://api.github.com/users/hkumarmk/received_events","type":"User","site_admin":false},"body":"FIP pools can be of two types.\r\n\r\n1. Shared to all tenants - this is setup using neutron apis, and it is shared to\r\nall tenants.\r\n2. Shared to specific tenants only - this need to be setup using contrail api,\r\nand it can be shared only to specific tenants. so this can be a private floating\r\nIPs to one or more tenants.\r\n\r\nCreated one defined resource to create both the type of fip pools. So a hash of\r\nfip pools to be provided using hiera to the class rjil::neutron::contrail and it\r\ncall the define rjil::neutron::contrail::fip_pool to create the fips using\r\nappropriate apis.\r\n\r\nChanged Puppetfile to point to harish's repo for contrail to test.","created_at":"2015-03-18T13:16:30Z","updated_at":"2015-03-18T17:19:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed127c6a07abfcaa54c56dd0d4a05d049782ffde","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/475/commits","review_comments_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/475/comments","review_comment_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/475/comments","statuses_url":"https://api.github.com/repos/JioCloud/puppet-rjil/statuses/3d93253e2a8bd22a89e44351176d176e2f0d279c","head":{"label":"hkumarmk:support_fip_pool_using_contrail_n_neutron_apis","ref":"support_fip_pool_using_contrail_n_neutron_apis","sha":"3d93253e2a8bd22a89e44351176d176e2f0d279c","user":{"login":"hkumarmk","id":6316902,"avatar_url":"https://avatars.githubusercontent.com/u/6316902?v=3","gravatar_id":"","url":"https://api.github.com/users/hkumarmk","html_url":"https://github.com/hkumarmk","followers_url":"https://api.github.com/users/hkumarmk/followers","following_url":"https://api.github.com/users/hkumarmk/following{/other_user}","gists_url":"https://api.github.com/users/hkumarmk/gists{/gist_id}","starred_url":"https://api.github.com/users/hkumarmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkumarmk/subscriptions","organizations_url":"https://api.github.com/users/hkumarmk/orgs","repos_url":"https://api.github.com/users/hkumarmk/repos","events_url":"https://api.github.com/users/hkumarmk/events{/privacy}","received_events_url":"https://api.github.com/users/hkumarmk/received_events","type":"User","site_admin":false},"repo":{"id":23566380,"name":"puppet-rjil","full_name":"hkumarmk/puppet-rjil","owner":{"login":"hkumarmk","id":6316902,"avatar_url":"https://avatars.githubusercontent.com/u/6316902?v=3","gravatar_id":"","url":"https://api.github.com/users/hkumarmk","html_url":"https://github.com/hkumarmk","followers_url":"https://api.github.com/users/hkumarmk/followers","following_url":"https://api.github.com/users/hkumarmk/following{/other_user}","gists_url":"https://api.github.com/users/hkumarmk/gists{/gist_id}","starred_url":"https://api.github.com/users/hkumarmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkumarmk/subscriptions","organizations_url":"https://api.github.com/users/hkumarmk/orgs","repos_url":"https://api.github.com/users/hkumarmk/repos","events_url":"https://api.github.com/users/hkumarmk/events{/privacy}","received_events_url":"https://api.github.com/users/hkumarmk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hkumarmk/puppet-rjil","description":"","fork":true,"url":"https://api.github.com/repos/hkumarmk/puppet-rjil","forks_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/forks","keys_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/teams","hooks_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/hooks","issue_events_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/issues/events{/number}","events_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/events","assignees_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/assignees{/user}","branches_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/branches{/branch}","tags_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/tags","blobs_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/git/refs{/sha}","trees_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/statuses/{sha}","languages_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/languages","stargazers_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/stargazers","contributors_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/contributors","subscribers_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/subscribers","subscription_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/subscription","commits_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/commits{/sha}","git_commits_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/git/commits{/sha}","comments_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/comments{/number}","issue_comment_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/issues/comments{/number}","contents_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/contents/{+path}","compare_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/merges","archive_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/downloads","issues_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/issues{/number}","pulls_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/pulls{/number}","milestones_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/milestones{/number}","notifications_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/labels{/name}","releases_url":"https://api.github.com/repos/hkumarmk/puppet-rjil/releases{/id}","created_at":"2014-09-02T05:36:38Z","updated_at":"2014-08-14T10:22:52Z","pushed_at":"2015-03-18T13:15:51Z","git_url":"git://github.com/hkumarmk/puppet-rjil.git","ssh_url":"git@github.com:hkumarmk/puppet-rjil.git","clone_url":"https://github.com/hkumarmk/puppet-rjil.git","svn_url":"https://github.com/hkumarmk/puppet-rjil","homepage":null,"size":2479,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JioCloud:master","ref":"master","sha":"1f195c81084da7632355cb12f13ea4f4e7685790","user":{"login":"JioCloud","id":5500757,"avatar_url":"https://avatars.githubusercontent.com/u/5500757?v=3","gravatar_id":"","url":"https://api.github.com/users/JioCloud","html_url":"https://github.com/JioCloud","followers_url":"https://api.github.com/users/JioCloud/followers","following_url":"https://api.github.com/users/JioCloud/following{/other_user}","gists_url":"https://api.github.com/users/JioCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/JioCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JioCloud/subscriptions","organizations_url":"https://api.github.com/users/JioCloud/orgs","repos_url":"https://api.github.com/users/JioCloud/repos","events_url":"https://api.github.com/users/JioCloud/events{/privacy}","received_events_url":"https://api.github.com/users/JioCloud/received_events","type":"Organization","site_admin":false},"repo":{"id":16161513,"name":"puppet-rjil","full_name":"JioCloud/puppet-rjil","owner":{"login":"JioCloud","id":5500757,"avatar_url":"https://avatars.githubusercontent.com/u/5500757?v=3","gravatar_id":"","url":"https://api.github.com/users/JioCloud","html_url":"https://github.com/JioCloud","followers_url":"https://api.github.com/users/JioCloud/followers","following_url":"https://api.github.com/users/JioCloud/following{/other_user}","gists_url":"https://api.github.com/users/JioCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/JioCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JioCloud/subscriptions","organizations_url":"https://api.github.com/users/JioCloud/orgs","repos_url":"https://api.github.com/users/JioCloud/repos","events_url":"https://api.github.com/users/JioCloud/events{/privacy}","received_events_url":"https://api.github.com/users/JioCloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JioCloud/puppet-rjil","description":"Puppet scripts for managing JioCloud","fork":false,"url":"https://api.github.com/repos/JioCloud/puppet-rjil","forks_url":"https://api.github.com/repos/JioCloud/puppet-rjil/forks","keys_url":"https://api.github.com/repos/JioCloud/puppet-rjil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JioCloud/puppet-rjil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JioCloud/puppet-rjil/teams","hooks_url":"https://api.github.com/repos/JioCloud/puppet-rjil/hooks","issue_events_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/events{/number}","events_url":"https://api.github.com/repos/JioCloud/puppet-rjil/events","assignees_url":"https://api.github.com/repos/JioCloud/puppet-rjil/assignees{/user}","branches_url":"https://api.github.com/repos/JioCloud/puppet-rjil/branches{/branch}","tags_url":"https://api.github.com/repos/JioCloud/puppet-rjil/tags","blobs_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/refs{/sha}","trees_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JioCloud/puppet-rjil/statuses/{sha}","languages_url":"https://api.github.com/repos/JioCloud/puppet-rjil/languages","stargazers_url":"https://api.github.com/repos/JioCloud/puppet-rjil/stargazers","contributors_url":"https://api.github.com/repos/JioCloud/puppet-rjil/contributors","subscribers_url":"https://api.github.com/repos/JioCloud/puppet-rjil/subscribers","subscription_url":"https://api.github.com/repos/JioCloud/puppet-rjil/subscription","commits_url":"https://api.github.com/repos/JioCloud/puppet-rjil/commits{/sha}","git_commits_url":"https://api.github.com/repos/JioCloud/puppet-rjil/git/commits{/sha}","comments_url":"https://api.github.com/repos/JioCloud/puppet-rjil/comments{/number}","issue_comment_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/comments{/number}","contents_url":"https://api.github.com/repos/JioCloud/puppet-rjil/contents/{+path}","compare_url":"https://api.github.com/repos/JioCloud/puppet-rjil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JioCloud/puppet-rjil/merges","archive_url":"https://api.github.com/repos/JioCloud/puppet-rjil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JioCloud/puppet-rjil/downloads","issues_url":"https://api.github.com/repos/JioCloud/puppet-rjil/issues{/number}","pulls_url":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls{/number}","milestones_url":"https://api.github.com/repos/JioCloud/puppet-rjil/milestones{/number}","notifications_url":"https://api.github.com/repos/JioCloud/puppet-rjil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JioCloud/puppet-rjil/labels{/name}","releases_url":"https://api.github.com/repos/JioCloud/puppet-rjil/releases{/id}","created_at":"2014-01-23T03:45:55Z","updated_at":"2015-03-18T04:21:47Z","pushed_at":"2015-03-18T04:21:47Z","git_url":"git://github.com/JioCloud/puppet-rjil.git","ssh_url":"git@github.com:JioCloud/puppet-rjil.git","clone_url":"https://github.com/JioCloud/puppet-rjil.git","svn_url":"https://github.com/JioCloud/puppet-rjil","homepage":"","size":5656,"stargazers_count":1,"watchers_count":1,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":83,"forks":27,"open_issues":83,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/475"},"html":{"href":"https://github.com/JioCloud/puppet-rjil/pull/475"},"issue":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/475"},"comments":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/issues/475/comments"},"review_comments":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/475/comments"},"review_comment":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/pulls/475/commits"},"statuses":{"href":"https://api.github.com/repos/JioCloud/puppet-rjil/statuses/3d93253e2a8bd22a89e44351176d176e2f0d279c"}}}}