{"action":"created","issue":{"url":"https://api.github.com/repos/editorconfig/editorconfig-core-test/issues/5","labels_url":"https://api.github.com/repos/editorconfig/editorconfig-core-test/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/editorconfig/editorconfig-core-test/issues/5/comments","events_url":"https://api.github.com/repos/editorconfig/editorconfig-core-test/issues/5/events","html_url":"https://github.com/editorconfig/editorconfig-core-test/pull/5","id":77495418,"number":5,"title":"Spec property name and value limits","user":{"login":"josh","id":137,"avatar_url":"https://avatars.githubusercontent.com/u/137?v=3","gravatar_id":"","url":"https://api.github.com/users/josh","html_url":"https://github.com/josh","followers_url":"https://api.github.com/users/josh/followers","following_url":"https://api.github.com/users/josh/following{/other_user}","gists_url":"https://api.github.com/users/josh/gists{/gist_id}","starred_url":"https://api.github.com/users/josh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh/subscriptions","organizations_url":"https://api.github.com/users/josh/orgs","repos_url":"https://api.github.com/users/josh/repos","events_url":"https://api.github.com/users/josh/events{/privacy}","received_events_url":"https://api.github.com/users/josh/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-05-18T04:37:38Z","updated_at":"2015-05-18T18:43:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/editorconfig/editorconfig-core-test/pulls/5","html_url":"https://github.com/editorconfig/editorconfig-core-test/pull/5","diff_url":"https://github.com/editorconfig/editorconfig-core-test/pull/5.diff","patch_url":"https://github.com/editorconfig/editorconfig-core-test/pull/5.patch"},"body":"*(Current patch for purposes of discussion)*\r\n\r\nI'm curious what people think about spec'ing some limits for things like maximum property name and value sizes.\r\n\r\nThe C implementation has defined max lengths of 500 for section and properties.\r\n\r\nhttps://github.com/editorconfig/editorconfig-core-c/blob/ab5a28de6420188a128571fd579aebe6e49e0abd/src/lib/ini.h#L80-L81\r\n\r\nI realize this maybe too implementation specific. But I think its interesting because we could have well defined behavior for what happens when the limits are exceeded.\r\n\r\n* These properties could simply be ignored if they exceed the max lengths\r\n* Or, these properties could be truncated to fit the max length\r\n\r\nAny thoughts? Has this already been discussed in the past?\r\n\r\nThanks."},"comment":{"url":"https://api.github.com/repos/editorconfig/editorconfig-core-test/issues/comments/103167926","html_url":"https://github.com/editorconfig/editorconfig-core-test/pull/5#issuecomment-103167926","issue_url":"https://api.github.com/repos/editorconfig/editorconfig-core-test/issues/5","id":103167926,"user":{"login":"treyhunner","id":285352,"avatar_url":"https://avatars.githubusercontent.com/u/285352?v=3","gravatar_id":"","url":"https://api.github.com/users/treyhunner","html_url":"https://github.com/treyhunner","followers_url":"https://api.github.com/users/treyhunner/followers","following_url":"https://api.github.com/users/treyhunner/following{/other_user}","gists_url":"https://api.github.com/users/treyhunner/gists{/gist_id}","starred_url":"https://api.github.com/users/treyhunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treyhunner/subscriptions","organizations_url":"https://api.github.com/users/treyhunner/orgs","repos_url":"https://api.github.com/users/treyhunner/repos","events_url":"https://api.github.com/users/treyhunner/events{/privacy}","received_events_url":"https://api.github.com/users/treyhunner/received_events","type":"User","site_admin":false},"created_at":"2015-05-18T18:43:54Z","updated_at":"2015-05-18T18:43:54Z","body":"Those two limits sound reasonable to me also."}}