{"push_id":628283847,"size":1,"distinct_size":1,"ref":"refs/heads/fix/12505-refactor-hashrings","head":"f67c39fd5c723696d7481bc650511a15eca312ea","before":"daf6a4ede8308deb5c20d678ec3eb7b8cf8585e0","commits":[{"sha":"f67c39fd5c723696d7481bc650511a15eca312ea","author":{"email":"830ecb0551a2e1179e1b0a4d09890973273772f4@torproject.org","name":"Isis Lovecruft"},"message":"Why were there ever unreachable subhashrings? Kill them with fire.\n\nAs part of #4297, $SOMEONE added the prepopulateRings() methods, which\nare used when BridgeDB parses incoming descriptors.  These methods add\nsubhashrings and allocate bridges to them.  When a client requests\nbridges, they are either requesting IPv4 or IPv6 bridges, and thus\nclients *always* have either filterBridgesByIPv4 or filterBridgesByIPv6,\nrespectively.  So why is there an extra subhashring with no IP version\nfilters if clients *can never get to it*?\n\nBlame $SOMEONE.  The $SOMEONE who authored the commit below would be a\ngood start.\n\n * BUGFIX on e6ce57e728802689544c130867edcadfeecd38ec.\n * REMOVE the \"filterless\" subhashring from the IPBasedDistributor.\n * UPDATE documentation for IPBasedDistributor.prepopulateRings().","distinct":true,"url":"https://api.github.com/repos/isislovecruft/bridgedb/commits/f67c39fd5c723696d7481bc650511a15eca312ea"}]}