{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4327","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4327/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4327/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4327/events","html_url":"https://github.com/ManageIQ/manageiq/pull/4327","id":106065272,"number":4327,"title":"Added OOTB sample Tenant Roles.","user":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/tenancy","name":"tenancy","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-11T18:22:53Z","updated_at":"2015-09-15T13:40:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4327","html_url":"https://github.com/ManageIQ/manageiq/pull/4327","diff_url":"https://github.com/ManageIQ/manageiq/pull/4327.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/4327.patch"},"body":"- Added OOTB sample Tenant Admin & Quota Admin roles, these role can do everything that a normal admin can do in addition to that Tenant Admin also has access to Tenant CRUD in Access Control. Tenant Quota admin has access to Manage Quotas.\r\n- Added RBAC checks to Access Control tree building code and related screens to only show nodes/links if user has access to those features.\r\n- Added spec test to verify that signed in user only sees nodes based on their role.\r\n\r\nbefore:\r\n![before_new_roles](https://cloud.githubusercontent.com/assets/3450808/9798705/b9cd51d6-57d0-11e5-81f5-ce856bab698e.png)\r\n\r\nafter:\r\n![new_roles](https://cloud.githubusercontent.com/assets/3450808/9799952/481f00fe-57d8-11e5-8994-52d72d4af063.png)\r\n\r\nOPS Explorer logged in as Tenant Admin\r\n![logged_in_with_tenant_admin](https://cloud.githubusercontent.com/assets/3450808/9798720/d4db2700-57d0-11e5-9b4e-6dba6b750ec3.png)\r\n\r\nAdded groups to match new OOTB sample roles\r\n![new_groups_to_match_with_new_roles](https://cloud.githubusercontent.com/assets/3450808/9820879/cdd60128-5884-11e5-86c5-3810c7aca803.png)\r\n\r\n\r\nClosed a PR that got messed up during rebase from upstream master https://github.com/ManageIQ/manageiq/pull/4310 \r\n\r\n@dclarizio please review/test"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/140396216","html_url":"https://github.com/ManageIQ/manageiq/pull/4327#issuecomment-140396216","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4327","id":140396216,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2015-09-15T13:40:10Z","updated_at":"2015-09-15T13:40:10Z","body":"<rubocop />Checked commits https://github.com/h-kataria/manageiq/compare/1d4f562645e9175638f2cb3dc773c83eb61af0d2~...d04f3f6983da1af9e1e918593940cadf92e2dd59 with ruby 1.9.3, rubocop 0.33.0, and haml-lint 0.13.0\n8 files checked, 6 offenses detected\n\n**app/presenters/tree_builder_ops_rbac.rb**\n- [ ] :small_blue_diamond: - [Line 24](https://github.com/h-kataria/manageiq/blob/d04f3f6983da1af9e1e918593940cadf92e2dd59/app/presenters/tree_builder_ops_rbac.rb#L24), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [172/120]\n- [ ] :small_blue_diamond: - [Line 25](https://github.com/h-kataria/manageiq/blob/d04f3f6983da1af9e1e918593940cadf92e2dd59/app/presenters/tree_builder_ops_rbac.rb#L25), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [173/120]\n- [ ] :small_blue_diamond: - [Line 26](https://github.com/h-kataria/manageiq/blob/d04f3f6983da1af9e1e918593940cadf92e2dd59/app/presenters/tree_builder_ops_rbac.rb#L26), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [172/120]\n- [ ] :small_blue_diamond: - [Line 27](https://github.com/h-kataria/manageiq/blob/d04f3f6983da1af9e1e918593940cadf92e2dd59/app/presenters/tree_builder_ops_rbac.rb#L27), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.33.0/RuboCop/Cop/Metrics/LineLength) - Line is too long. [174/120]\n\n**app/views/ops/_rbac_tenant_details.html.haml**\n- [ ] :red_circle: **Warn** - [Line 30](https://github.com/h-kataria/manageiq/blob/d04f3f6983da1af9e1e918593940cadf92e2dd59/app/views/ops/_rbac_tenant_details.html.haml#L30), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n- [ ] :red_circle: **Warn** - [Line 30](https://github.com/h-kataria/manageiq/blob/d04f3f6983da1af9e1e918593940cadf92e2dd59/app/views/ops/_rbac_tenant_details.html.haml#L30), Col  -  - Style/ExtraSpacing: Unnecessary spacing detected.\n"}}