{"action":"opened","number":306,"pull_request":{"url":"https://api.github.com/repos/stb-tester/stb-tester/pulls/306","id":46311187,"html_url":"https://github.com/stb-tester/stb-tester/pull/306","diff_url":"https://github.com/stb-tester/stb-tester/pull/306.diff","patch_url":"https://github.com/stb-tester/stb-tester/pull/306.patch","issue_url":"https://api.github.com/repos/stb-tester/stb-tester/issues/306","number":306,"state":"open","locked":false,"title":"Work around regression in PyGObject 3.13","user":{"login":"wmanley","id":494659,"avatar_url":"https://avatars.githubusercontent.com/u/494659?v=3","gravatar_id":"","url":"https://api.github.com/users/wmanley","html_url":"https://github.com/wmanley","followers_url":"https://api.github.com/users/wmanley/followers","following_url":"https://api.github.com/users/wmanley/following{/other_user}","gists_url":"https://api.github.com/users/wmanley/gists{/gist_id}","starred_url":"https://api.github.com/users/wmanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmanley/subscriptions","organizations_url":"https://api.github.com/users/wmanley/orgs","repos_url":"https://api.github.com/users/wmanley/repos","events_url":"https://api.github.com/users/wmanley/events{/privacy}","received_events_url":"https://api.github.com/users/wmanley/received_events","type":"User","site_admin":false},"body":"Preventing stb-tester from working on Ubuntu >= 14.04 and Fedora >= 21.\r\n\r\n`map_gst_sample` was failing with:\r\n\r\n    Traceback(most recent call last):\r\n      File\"/usr/libexec/stbt/stbt/__init__.py\", line 1920, in on_new_sample\r\n        self.push_sample(sample)\r\n      File\"/usr/libexec/stbt/stbt/__init__.py\", line 1984, in push_sample\r\n        with _numpy_from_sample(sample)as img:\r\n      File\"/usr/lib64/python2.7/contextlib.py\", line 17, in __enter__\r\n        returnself.gen.next()\r\n      File\"/usr/libexec/stbt/stbt/__init__.py\", line 1708, in _numpy_from_sample\r\n        with map_gst_buffer(sample.get_buffer(), flags) as buf:\r\n      File\"/usr/lib64/python2.7/contextlib.py\", line 17, in __enter__\r\n        return self.gen.next()\r\n      File\"/usr/libexec/stbt/_stbt/gst_hacks.py\", line 47, in map_gst_buffer\r\n        \"Writable array requested but buffer is not writeable\")\r\n    ValueError: Writable array requested but buffer is not writeable\r\n\r\nPyGObject changed the behaviour of `Gst.Sample.get_buffer` to take a reference to the buffer it returns with `gst_mini_object_ref`.  to prevent use-after-free bugs if the `Gst.Buffer` is used after the `Gst.Sample` goes out of scope.  Unfortunately `gst_mini_object_ref` isn't just a reference-counting increment, it also marks the object as read-only. This makes it impossible to get a writable handle to the `Gst.Buffer` owned by the `Gst.Sample`.\r\n\r\nIn this commit we work around this by using the C API directly via ctypes as we had to for `map_gst_buffer()` (see f0c5b31).\r\n\r\nSee the upstream bug ticket: https://bugzilla.gnome.org/show_bug.cgi?id=736896\r\n\r\nFixes: #305","created_at":"2015-09-29T18:06:32Z","updated_at":"2015-09-29T18:06:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stb-tester/stb-tester/pulls/306/commits","review_comments_url":"https://api.github.com/repos/stb-tester/stb-tester/pulls/306/comments","review_comment_url":"https://api.github.com/repos/stb-tester/stb-tester/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stb-tester/stb-tester/issues/306/comments","statuses_url":"https://api.github.com/repos/stb-tester/stb-tester/statuses/a5f99385b5f17cfc8eaea1763b1f9250bbf93193","head":{"label":"wmanley:pygobject-3.13-support","ref":"pygobject-3.13-support","sha":"a5f99385b5f17cfc8eaea1763b1f9250bbf93193","user":{"login":"wmanley","id":494659,"avatar_url":"https://avatars.githubusercontent.com/u/494659?v=3","gravatar_id":"","url":"https://api.github.com/users/wmanley","html_url":"https://github.com/wmanley","followers_url":"https://api.github.com/users/wmanley/followers","following_url":"https://api.github.com/users/wmanley/following{/other_user}","gists_url":"https://api.github.com/users/wmanley/gists{/gist_id}","starred_url":"https://api.github.com/users/wmanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmanley/subscriptions","organizations_url":"https://api.github.com/users/wmanley/orgs","repos_url":"https://api.github.com/users/wmanley/repos","events_url":"https://api.github.com/users/wmanley/events{/privacy}","received_events_url":"https://api.github.com/users/wmanley/received_events","type":"User","site_admin":false},"repo":{"id":4783326,"name":"stb-tester","full_name":"wmanley/stb-tester","owner":{"login":"wmanley","id":494659,"avatar_url":"https://avatars.githubusercontent.com/u/494659?v=3","gravatar_id":"","url":"https://api.github.com/users/wmanley","html_url":"https://github.com/wmanley","followers_url":"https://api.github.com/users/wmanley/followers","following_url":"https://api.github.com/users/wmanley/following{/other_user}","gists_url":"https://api.github.com/users/wmanley/gists{/gist_id}","starred_url":"https://api.github.com/users/wmanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmanley/subscriptions","organizations_url":"https://api.github.com/users/wmanley/orgs","repos_url":"https://api.github.com/users/wmanley/repos","events_url":"https://api.github.com/users/wmanley/events{/privacy}","received_events_url":"https://api.github.com/users/wmanley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wmanley/stb-tester","description":"A record + playback testing system for set-top boxes","fork":true,"url":"https://api.github.com/repos/wmanley/stb-tester","forks_url":"https://api.github.com/repos/wmanley/stb-tester/forks","keys_url":"https://api.github.com/repos/wmanley/stb-tester/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmanley/stb-tester/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmanley/stb-tester/teams","hooks_url":"https://api.github.com/repos/wmanley/stb-tester/hooks","issue_events_url":"https://api.github.com/repos/wmanley/stb-tester/issues/events{/number}","events_url":"https://api.github.com/repos/wmanley/stb-tester/events","assignees_url":"https://api.github.com/repos/wmanley/stb-tester/assignees{/user}","branches_url":"https://api.github.com/repos/wmanley/stb-tester/branches{/branch}","tags_url":"https://api.github.com/repos/wmanley/stb-tester/tags","blobs_url":"https://api.github.com/repos/wmanley/stb-tester/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmanley/stb-tester/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmanley/stb-tester/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmanley/stb-tester/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmanley/stb-tester/statuses/{sha}","languages_url":"https://api.github.com/repos/wmanley/stb-tester/languages","stargazers_url":"https://api.github.com/repos/wmanley/stb-tester/stargazers","contributors_url":"https://api.github.com/repos/wmanley/stb-tester/contributors","subscribers_url":"https://api.github.com/repos/wmanley/stb-tester/subscribers","subscription_url":"https://api.github.com/repos/wmanley/stb-tester/subscription","commits_url":"https://api.github.com/repos/wmanley/stb-tester/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmanley/stb-tester/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmanley/stb-tester/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmanley/stb-tester/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmanley/stb-tester/contents/{+path}","compare_url":"https://api.github.com/repos/wmanley/stb-tester/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmanley/stb-tester/merges","archive_url":"https://api.github.com/repos/wmanley/stb-tester/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmanley/stb-tester/downloads","issues_url":"https://api.github.com/repos/wmanley/stb-tester/issues{/number}","pulls_url":"https://api.github.com/repos/wmanley/stb-tester/pulls{/number}","milestones_url":"https://api.github.com/repos/wmanley/stb-tester/milestones{/number}","notifications_url":"https://api.github.com/repos/wmanley/stb-tester/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmanley/stb-tester/labels{/name}","releases_url":"https://api.github.com/repos/wmanley/stb-tester/releases{/id}","created_at":"2012-06-25T15:17:46Z","updated_at":"2015-02-24T16:36:05Z","pushed_at":"2015-09-29T18:05:35Z","git_url":"git://github.com/wmanley/stb-tester.git","ssh_url":"git@github.com:wmanley/stb-tester.git","clone_url":"https://github.com/wmanley/stb-tester.git","svn_url":"https://github.com/wmanley/stb-tester","homepage":null,"size":8098,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"stb-tester:master","ref":"master","sha":"f72d971dd26dd67294729b8b1b72dfbe5a765993","user":{"login":"stb-tester","id":5528358,"avatar_url":"https://avatars.githubusercontent.com/u/5528358?v=3","gravatar_id":"","url":"https://api.github.com/users/stb-tester","html_url":"https://github.com/stb-tester","followers_url":"https://api.github.com/users/stb-tester/followers","following_url":"https://api.github.com/users/stb-tester/following{/other_user}","gists_url":"https://api.github.com/users/stb-tester/gists{/gist_id}","starred_url":"https://api.github.com/users/stb-tester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stb-tester/subscriptions","organizations_url":"https://api.github.com/users/stb-tester/orgs","repos_url":"https://api.github.com/users/stb-tester/repos","events_url":"https://api.github.com/users/stb-tester/events{/privacy}","received_events_url":"https://api.github.com/users/stb-tester/received_events","type":"Organization","site_admin":false},"repo":{"id":4739298,"name":"stb-tester","full_name":"stb-tester/stb-tester","owner":{"login":"stb-tester","id":5528358,"avatar_url":"https://avatars.githubusercontent.com/u/5528358?v=3","gravatar_id":"","url":"https://api.github.com/users/stb-tester","html_url":"https://github.com/stb-tester","followers_url":"https://api.github.com/users/stb-tester/followers","following_url":"https://api.github.com/users/stb-tester/following{/other_user}","gists_url":"https://api.github.com/users/stb-tester/gists{/gist_id}","starred_url":"https://api.github.com/users/stb-tester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stb-tester/subscriptions","organizations_url":"https://api.github.com/users/stb-tester/orgs","repos_url":"https://api.github.com/users/stb-tester/repos","events_url":"https://api.github.com/users/stb-tester/events{/privacy}","received_events_url":"https://api.github.com/users/stb-tester/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stb-tester/stb-tester","description":"Automated Testing for Set-Top Boxes and Smart TVs","fork":false,"url":"https://api.github.com/repos/stb-tester/stb-tester","forks_url":"https://api.github.com/repos/stb-tester/stb-tester/forks","keys_url":"https://api.github.com/repos/stb-tester/stb-tester/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stb-tester/stb-tester/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stb-tester/stb-tester/teams","hooks_url":"https://api.github.com/repos/stb-tester/stb-tester/hooks","issue_events_url":"https://api.github.com/repos/stb-tester/stb-tester/issues/events{/number}","events_url":"https://api.github.com/repos/stb-tester/stb-tester/events","assignees_url":"https://api.github.com/repos/stb-tester/stb-tester/assignees{/user}","branches_url":"https://api.github.com/repos/stb-tester/stb-tester/branches{/branch}","tags_url":"https://api.github.com/repos/stb-tester/stb-tester/tags","blobs_url":"https://api.github.com/repos/stb-tester/stb-tester/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stb-tester/stb-tester/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stb-tester/stb-tester/git/refs{/sha}","trees_url":"https://api.github.com/repos/stb-tester/stb-tester/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stb-tester/stb-tester/statuses/{sha}","languages_url":"https://api.github.com/repos/stb-tester/stb-tester/languages","stargazers_url":"https://api.github.com/repos/stb-tester/stb-tester/stargazers","contributors_url":"https://api.github.com/repos/stb-tester/stb-tester/contributors","subscribers_url":"https://api.github.com/repos/stb-tester/stb-tester/subscribers","subscription_url":"https://api.github.com/repos/stb-tester/stb-tester/subscription","commits_url":"https://api.github.com/repos/stb-tester/stb-tester/commits{/sha}","git_commits_url":"https://api.github.com/repos/stb-tester/stb-tester/git/commits{/sha}","comments_url":"https://api.github.com/repos/stb-tester/stb-tester/comments{/number}","issue_comment_url":"https://api.github.com/repos/stb-tester/stb-tester/issues/comments{/number}","contents_url":"https://api.github.com/repos/stb-tester/stb-tester/contents/{+path}","compare_url":"https://api.github.com/repos/stb-tester/stb-tester/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stb-tester/stb-tester/merges","archive_url":"https://api.github.com/repos/stb-tester/stb-tester/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stb-tester/stb-tester/downloads","issues_url":"https://api.github.com/repos/stb-tester/stb-tester/issues{/number}","pulls_url":"https://api.github.com/repos/stb-tester/stb-tester/pulls{/number}","milestones_url":"https://api.github.com/repos/stb-tester/stb-tester/milestones{/number}","notifications_url":"https://api.github.com/repos/stb-tester/stb-tester/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stb-tester/stb-tester/labels{/name}","releases_url":"https://api.github.com/repos/stb-tester/stb-tester/releases{/id}","created_at":"2012-06-21T13:11:28Z","updated_at":"2015-09-27T00:58:43Z","pushed_at":"2015-09-22T10:56:35Z","git_url":"git://github.com/stb-tester/stb-tester.git","ssh_url":"git@github.com:stb-tester/stb-tester.git","clone_url":"https://github.com/stb-tester/stb-tester.git","svn_url":"https://github.com/stb-tester/stb-tester","homepage":"http://stb-tester.com","size":11238,"stargazers_count":45,"watchers_count":45,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":22,"forks":44,"open_issues":22,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stb-tester/stb-tester/pulls/306"},"html":{"href":"https://github.com/stb-tester/stb-tester/pull/306"},"issue":{"href":"https://api.github.com/repos/stb-tester/stb-tester/issues/306"},"comments":{"href":"https://api.github.com/repos/stb-tester/stb-tester/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/stb-tester/stb-tester/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/stb-tester/stb-tester/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stb-tester/stb-tester/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/stb-tester/stb-tester/statuses/a5f99385b5f17cfc8eaea1763b1f9250bbf93193"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":54,"deletions":16,"changed_files":3}}