{"action":"created","issue":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/140","labels_url":"https://api.github.com/repos/Valloric/ycmd/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/Valloric/ycmd/issues/140/comments","events_url":"https://api.github.com/repos/Valloric/ycmd/issues/140/events","html_url":"https://github.com/Valloric/ycmd/pull/140","id":79455932,"number":140,"title":"Fix Gocode path on Windows","user":{"login":"micbou","id":10026824,"avatar_url":"https://avatars.githubusercontent.com/u/10026824?v=3","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-22T13:29:16Z","updated_at":"2015-05-22T17:40:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Valloric/ycmd/pulls/140","html_url":"https://github.com/Valloric/ycmd/pull/140","diff_url":"https://github.com/Valloric/ycmd/pull/140.diff","patch_url":"https://github.com/Valloric/ycmd/pull/140.patch"},"body":"This pull request fixes the default Gocode path on Windows by adding the `.exe` extension and using `os.path.join` for the full path. Otherwise, python does not find `gocode.exe` and there is no completion (and no exception raised).\r\n\r\nThere are other changes:\r\n  - the logic in `hook.py` was moved to the `GoCodeCompleter` class. This avoids calling `FindGoCodeBinary` two times. An exception is raised when no binary is found (like in the `CsCompleter` class). \r\n  - `FindGoCodeBinary` is now a method of the `GoCodeCompleter` class since not used elsewhere. `os.path.exists` was replaced by `os.path.isfile`.\r\n  - Add test for `FindGoCodeBinary` method (it does not test finding `gocode` binary in the `PATH`).\r\n  - Fix code style and clean-up code.\r\n\r\nThere are still problems on Windows but it will be for another PR.\r\n\r\nCLA signed."},"comment":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/comments/104723866","html_url":"https://github.com/Valloric/ycmd/pull/140#issuecomment-104723866","issue_url":"https://api.github.com/repos/Valloric/ycmd/issues/140","id":104723866,"user":{"login":"Valloric","id":919444,"avatar_url":"https://avatars.githubusercontent.com/u/919444?v=3","gravatar_id":"","url":"https://api.github.com/users/Valloric","html_url":"https://github.com/Valloric","followers_url":"https://api.github.com/users/Valloric/followers","following_url":"https://api.github.com/users/Valloric/following{/other_user}","gists_url":"https://api.github.com/users/Valloric/gists{/gist_id}","starred_url":"https://api.github.com/users/Valloric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valloric/subscriptions","organizations_url":"https://api.github.com/users/Valloric/orgs","repos_url":"https://api.github.com/users/Valloric/repos","events_url":"https://api.github.com/users/Valloric/events{/privacy}","received_events_url":"https://api.github.com/users/Valloric/received_events","type":"User","site_admin":false},"created_at":"2015-05-22T17:40:37Z","updated_at":"2015-05-22T17:40:37Z","body":"@ekfriis I'd appreciate you taking a look at this."}}