{"action":"created","comment":{"url":"https://api.github.com/repos/huei90/angular-validation/pulls/comments/47733507","id":47733507,"diff_hunk":"@@ -225,6 +228,7 @@\n             ctrl.$render();\n             if (attrs.messageId) angular.element(document.querySelector('#' + attrs.messageId)).html('');\n             else element.next().html('');\n+            if ($validationProvider.validCallback) $validationProvider.validCallback(element);","path":"src/validator.directive.js","position":12,"original_position":21,"commit_id":"bbff0bf3fb743150209c5c1b7353c87913f419a7","original_commit_id":"47ab87728698bf7e483a588a30622c5bd2a81388","user":{"login":"huei90","id":2560096,"avatar_url":"https://avatars.githubusercontent.com/u/2560096?v=3","gravatar_id":"","url":"https://api.github.com/users/huei90","html_url":"https://github.com/huei90","followers_url":"https://api.github.com/users/huei90/followers","following_url":"https://api.github.com/users/huei90/following{/other_user}","gists_url":"https://api.github.com/users/huei90/gists{/gist_id}","starred_url":"https://api.github.com/users/huei90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huei90/subscriptions","organizations_url":"https://api.github.com/users/huei90/orgs","repos_url":"https://api.github.com/users/huei90/repos","events_url":"https://api.github.com/users/huei90/events{/privacy}","received_events_url":"https://api.github.com/users/huei90/received_events","type":"User","site_admin":false},"body":"`validCallback` is used for the input validate as valid's callback. not for reset.","created_at":"2015-12-16T03:34:53Z","updated_at":"2015-12-16T03:34:53Z","html_url":"https://github.com/huei90/angular-validation/pull/171#discussion_r47733507","pull_request_url":"https://api.github.com/repos/huei90/angular-validation/pulls/171","_links":{"self":{"href":"https://api.github.com/repos/huei90/angular-validation/pulls/comments/47733507"},"html":{"href":"https://github.com/huei90/angular-validation/pull/171#discussion_r47733507"},"pull_request":{"href":"https://api.github.com/repos/huei90/angular-validation/pulls/171"}}},"pull_request":{"url":"https://api.github.com/repos/huei90/angular-validation/pulls/171","id":53672452,"html_url":"https://github.com/huei90/angular-validation/pull/171","diff_url":"https://github.com/huei90/angular-validation/pull/171.diff","patch_url":"https://github.com/huei90/angular-validation/pull/171.patch","issue_url":"https://api.github.com/repos/huei90/angular-validation/issues/171","number":171,"state":"open","locked":false,"title":"Small Fixes to make Error Message clean up","user":{"login":"nmccready","id":583593,"avatar_url":"https://avatars.githubusercontent.com/u/583593?v=3","gravatar_id":"","url":"https://api.github.com/users/nmccready","html_url":"https://github.com/nmccready","followers_url":"https://api.github.com/users/nmccready/followers","following_url":"https://api.github.com/users/nmccready/following{/other_user}","gists_url":"https://api.github.com/users/nmccready/gists{/gist_id}","starred_url":"https://api.github.com/users/nmccready/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmccready/subscriptions","organizations_url":"https://api.github.com/users/nmccready/orgs","repos_url":"https://api.github.com/users/nmccready/repos","events_url":"https://api.github.com/users/nmccready/events{/privacy}","received_events_url":"https://api.github.com/users/nmccready/received_events","type":"User","site_admin":false},"body":"- Validation messages are removed when validFunc is true\n- $validationProvider.validCallback is also called on reset if it exists","created_at":"2015-12-15T08:19:48Z","updated_at":"2015-12-16T03:34:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76dbc8e63b9ba9ac932c7a580eadb18a277e55a1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/huei90/angular-validation/pulls/171/commits","review_comments_url":"https://api.github.com/repos/huei90/angular-validation/pulls/171/comments","review_comment_url":"https://api.github.com/repos/huei90/angular-validation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/huei90/angular-validation/issues/171/comments","statuses_url":"https://api.github.com/repos/huei90/angular-validation/statuses/bbff0bf3fb743150209c5c1b7353c87913f419a7","head":{"label":"nmccready:master","ref":"master","sha":"bbff0bf3fb743150209c5c1b7353c87913f419a7","user":{"login":"nmccready","id":583593,"avatar_url":"https://avatars.githubusercontent.com/u/583593?v=3","gravatar_id":"","url":"https://api.github.com/users/nmccready","html_url":"https://github.com/nmccready","followers_url":"https://api.github.com/users/nmccready/followers","following_url":"https://api.github.com/users/nmccready/following{/other_user}","gists_url":"https://api.github.com/users/nmccready/gists{/gist_id}","starred_url":"https://api.github.com/users/nmccready/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmccready/subscriptions","organizations_url":"https://api.github.com/users/nmccready/orgs","repos_url":"https://api.github.com/users/nmccready/repos","events_url":"https://api.github.com/users/nmccready/events{/privacy}","received_events_url":"https://api.github.com/users/nmccready/received_events","type":"User","site_admin":false},"repo":{"id":48021910,"name":"angular-validation","full_name":"nmccready/angular-validation","owner":{"login":"nmccready","id":583593,"avatar_url":"https://avatars.githubusercontent.com/u/583593?v=3","gravatar_id":"","url":"https://api.github.com/users/nmccready","html_url":"https://github.com/nmccready","followers_url":"https://api.github.com/users/nmccready/followers","following_url":"https://api.github.com/users/nmccready/following{/other_user}","gists_url":"https://api.github.com/users/nmccready/gists{/gist_id}","starred_url":"https://api.github.com/users/nmccready/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmccready/subscriptions","organizations_url":"https://api.github.com/users/nmccready/orgs","repos_url":"https://api.github.com/users/nmccready/repos","events_url":"https://api.github.com/users/nmccready/events{/privacy}","received_events_url":"https://api.github.com/users/nmccready/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nmccready/angular-validation","description":"Client Side Validation for AngularJS - http://huei90.github.io/angular-validation/","fork":true,"url":"https://api.github.com/repos/nmccready/angular-validation","forks_url":"https://api.github.com/repos/nmccready/angular-validation/forks","keys_url":"https://api.github.com/repos/nmccready/angular-validation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmccready/angular-validation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmccready/angular-validation/teams","hooks_url":"https://api.github.com/repos/nmccready/angular-validation/hooks","issue_events_url":"https://api.github.com/repos/nmccready/angular-validation/issues/events{/number}","events_url":"https://api.github.com/repos/nmccready/angular-validation/events","assignees_url":"https://api.github.com/repos/nmccready/angular-validation/assignees{/user}","branches_url":"https://api.github.com/repos/nmccready/angular-validation/branches{/branch}","tags_url":"https://api.github.com/repos/nmccready/angular-validation/tags","blobs_url":"https://api.github.com/repos/nmccready/angular-validation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmccready/angular-validation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmccready/angular-validation/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmccready/angular-validation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmccready/angular-validation/statuses/{sha}","languages_url":"https://api.github.com/repos/nmccready/angular-validation/languages","stargazers_url":"https://api.github.com/repos/nmccready/angular-validation/stargazers","contributors_url":"https://api.github.com/repos/nmccready/angular-validation/contributors","subscribers_url":"https://api.github.com/repos/nmccready/angular-validation/subscribers","subscription_url":"https://api.github.com/repos/nmccready/angular-validation/subscription","commits_url":"https://api.github.com/repos/nmccready/angular-validation/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmccready/angular-validation/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmccready/angular-validation/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmccready/angular-validation/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmccready/angular-validation/contents/{+path}","compare_url":"https://api.github.com/repos/nmccready/angular-validation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmccready/angular-validation/merges","archive_url":"https://api.github.com/repos/nmccready/angular-validation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmccready/angular-validation/downloads","issues_url":"https://api.github.com/repos/nmccready/angular-validation/issues{/number}","pulls_url":"https://api.github.com/repos/nmccready/angular-validation/pulls{/number}","milestones_url":"https://api.github.com/repos/nmccready/angular-validation/milestones{/number}","notifications_url":"https://api.github.com/repos/nmccready/angular-validation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmccready/angular-validation/labels{/name}","releases_url":"https://api.github.com/repos/nmccready/angular-validation/releases{/id}","created_at":"2015-12-15T05:37:27Z","updated_at":"2015-12-15T05:37:28Z","pushed_at":"2015-12-15T08:32:16Z","git_url":"git://github.com/nmccready/angular-validation.git","ssh_url":"git@github.com:nmccready/angular-validation.git","clone_url":"https://github.com/nmccready/angular-validation.git","svn_url":"https://github.com/nmccready/angular-validation","homepage":"","size":1080,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"huei90:master","ref":"master","sha":"5bf0a5c40109b63a1305c7832964ba673e42d714","user":{"login":"huei90","id":2560096,"avatar_url":"https://avatars.githubusercontent.com/u/2560096?v=3","gravatar_id":"","url":"https://api.github.com/users/huei90","html_url":"https://github.com/huei90","followers_url":"https://api.github.com/users/huei90/followers","following_url":"https://api.github.com/users/huei90/following{/other_user}","gists_url":"https://api.github.com/users/huei90/gists{/gist_id}","starred_url":"https://api.github.com/users/huei90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huei90/subscriptions","organizations_url":"https://api.github.com/users/huei90/orgs","repos_url":"https://api.github.com/users/huei90/repos","events_url":"https://api.github.com/users/huei90/events{/privacy}","received_events_url":"https://api.github.com/users/huei90/received_events","type":"User","site_admin":false},"repo":{"id":15153183,"name":"angular-validation","full_name":"huei90/angular-validation","owner":{"login":"huei90","id":2560096,"avatar_url":"https://avatars.githubusercontent.com/u/2560096?v=3","gravatar_id":"","url":"https://api.github.com/users/huei90","html_url":"https://github.com/huei90","followers_url":"https://api.github.com/users/huei90/followers","following_url":"https://api.github.com/users/huei90/following{/other_user}","gists_url":"https://api.github.com/users/huei90/gists{/gist_id}","starred_url":"https://api.github.com/users/huei90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huei90/subscriptions","organizations_url":"https://api.github.com/users/huei90/orgs","repos_url":"https://api.github.com/users/huei90/repos","events_url":"https://api.github.com/users/huei90/events{/privacy}","received_events_url":"https://api.github.com/users/huei90/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huei90/angular-validation","description":"Client Side Validation for AngularJS - http://huei90.github.io/angular-validation/","fork":false,"url":"https://api.github.com/repos/huei90/angular-validation","forks_url":"https://api.github.com/repos/huei90/angular-validation/forks","keys_url":"https://api.github.com/repos/huei90/angular-validation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huei90/angular-validation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huei90/angular-validation/teams","hooks_url":"https://api.github.com/repos/huei90/angular-validation/hooks","issue_events_url":"https://api.github.com/repos/huei90/angular-validation/issues/events{/number}","events_url":"https://api.github.com/repos/huei90/angular-validation/events","assignees_url":"https://api.github.com/repos/huei90/angular-validation/assignees{/user}","branches_url":"https://api.github.com/repos/huei90/angular-validation/branches{/branch}","tags_url":"https://api.github.com/repos/huei90/angular-validation/tags","blobs_url":"https://api.github.com/repos/huei90/angular-validation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huei90/angular-validation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huei90/angular-validation/git/refs{/sha}","trees_url":"https://api.github.com/repos/huei90/angular-validation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huei90/angular-validation/statuses/{sha}","languages_url":"https://api.github.com/repos/huei90/angular-validation/languages","stargazers_url":"https://api.github.com/repos/huei90/angular-validation/stargazers","contributors_url":"https://api.github.com/repos/huei90/angular-validation/contributors","subscribers_url":"https://api.github.com/repos/huei90/angular-validation/subscribers","subscription_url":"https://api.github.com/repos/huei90/angular-validation/subscription","commits_url":"https://api.github.com/repos/huei90/angular-validation/commits{/sha}","git_commits_url":"https://api.github.com/repos/huei90/angular-validation/git/commits{/sha}","comments_url":"https://api.github.com/repos/huei90/angular-validation/comments{/number}","issue_comment_url":"https://api.github.com/repos/huei90/angular-validation/issues/comments{/number}","contents_url":"https://api.github.com/repos/huei90/angular-validation/contents/{+path}","compare_url":"https://api.github.com/repos/huei90/angular-validation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huei90/angular-validation/merges","archive_url":"https://api.github.com/repos/huei90/angular-validation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huei90/angular-validation/downloads","issues_url":"https://api.github.com/repos/huei90/angular-validation/issues{/number}","pulls_url":"https://api.github.com/repos/huei90/angular-validation/pulls{/number}","milestones_url":"https://api.github.com/repos/huei90/angular-validation/milestones{/number}","notifications_url":"https://api.github.com/repos/huei90/angular-validation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huei90/angular-validation/labels{/name}","releases_url":"https://api.github.com/repos/huei90/angular-validation/releases{/id}","created_at":"2013-12-13T02:39:08Z","updated_at":"2015-12-16T03:26:25Z","pushed_at":"2015-12-15T09:59:44Z","git_url":"git://github.com/huei90/angular-validation.git","ssh_url":"git@github.com:huei90/angular-validation.git","clone_url":"https://github.com/huei90/angular-validation.git","svn_url":"https://github.com/huei90/angular-validation","homepage":"","size":1327,"stargazers_count":468,"watchers_count":468,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":126,"mirror_url":null,"open_issues_count":12,"forks":126,"open_issues":12,"watchers":468,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/huei90/angular-validation/pulls/171"},"html":{"href":"https://github.com/huei90/angular-validation/pull/171"},"issue":{"href":"https://api.github.com/repos/huei90/angular-validation/issues/171"},"comments":{"href":"https://api.github.com/repos/huei90/angular-validation/issues/171/comments"},"review_comments":{"href":"https://api.github.com/repos/huei90/angular-validation/pulls/171/comments"},"review_comment":{"href":"https://api.github.com/repos/huei90/angular-validation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/huei90/angular-validation/pulls/171/commits"},"statuses":{"href":"https://api.github.com/repos/huei90/angular-validation/statuses/bbff0bf3fb743150209c5c1b7353c87913f419a7"}}}}