{"action":"created","issue":{"url":"https://api.github.com/repos/Return-To-The-Roots/s25client/issues/94","labels_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/issues/94/labels{/name}","comments_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/issues/94/comments","events_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/issues/94/events","html_url":"https://github.com/Return-To-The-Roots/s25client/issues/94","id":98300498,"number":94,"title":"Code cleanup","user":{"login":"lweberk","id":896038,"avatar_url":"https://avatars.githubusercontent.com/u/896038?v=3","gravatar_id":"","url":"https://api.github.com/users/lweberk","html_url":"https://github.com/lweberk","followers_url":"https://api.github.com/users/lweberk/followers","following_url":"https://api.github.com/users/lweberk/following{/other_user}","gists_url":"https://api.github.com/users/lweberk/gists{/gist_id}","starred_url":"https://api.github.com/users/lweberk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lweberk/subscriptions","organizations_url":"https://api.github.com/users/lweberk/orgs","repos_url":"https://api.github.com/users/lweberk/repos","events_url":"https://api.github.com/users/lweberk/events{/privacy}","received_events_url":"https://api.github.com/users/lweberk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Return-To-The-Roots/s25client/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":34,"created_at":"2015-07-31T01:59:12Z","updated_at":"2015-08-04T16:10:25Z","closed_at":null,"body":"- [ ] Reduction / Removal of macros by pushing platform dependant stuff onto interface / implementation modules chosen by the buildsystem / meta-buildsystem.\r\n- [ ] Compaction of code by usage of explicit width types: int32_t, int16_t, ... instead of unsigned/signed and implicits.\r\n- [ ] Horizontal alignment whenever it eases readability.\r\n- [ ] Reduction of singletons whenever possible.\r\n- [ ] Dedent class bodies.\r\n- [ ] Move in-declaration (header) implementations out into own source file.\r\n- [x] Move different sources into own subdirs in src/ to make source tree less clogged and lookups clearer. \r\n- [ ] Remove double allocation in array initializations. Using initializer lists instead of assignment.\r\n- [ ] Move hard-coded constants out of source code. See [feature branch (~Flamefire)](https://github.com/Flamefire/s25client/tree/DynamicNations) on this. Also [discussion](http://www.siedler25.org/index.php?com=forum&mod=forum&action=thread&id=1348&start=-1).\r\n- [ ] Removal of raw pointer usage throughout the codebase. Usage of smart pointers (unique_ptr, shared_ptr) and contiguous datastructures (vector, array)\r\n- [ ] Translate comments.\r\n- [ ] Proper usage of enumeration instead of loose constants.\r\n- [ ] Enforce proper naming scheme\r\n\r\n+ Anything that you can come up with... please share and discuss. This can be a controversial topic and needs proper discussion."},"comment":{"url":"https://api.github.com/repos/Return-To-The-Roots/s25client/issues/comments/127661544","html_url":"https://github.com/Return-To-The-Roots/s25client/issues/94#issuecomment-127661544","issue_url":"https://api.github.com/repos/Return-To-The-Roots/s25client/issues/94","id":127661544,"user":{"login":"Flamefire","id":309017,"avatar_url":"https://avatars.githubusercontent.com/u/309017?v=3","gravatar_id":"","url":"https://api.github.com/users/Flamefire","html_url":"https://github.com/Flamefire","followers_url":"https://api.github.com/users/Flamefire/followers","following_url":"https://api.github.com/users/Flamefire/following{/other_user}","gists_url":"https://api.github.com/users/Flamefire/gists{/gist_id}","starred_url":"https://api.github.com/users/Flamefire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flamefire/subscriptions","organizations_url":"https://api.github.com/users/Flamefire/orgs","repos_url":"https://api.github.com/users/Flamefire/repos","events_url":"https://api.github.com/users/Flamefire/events{/privacy}","received_events_url":"https://api.github.com/users/Flamefire/received_events","type":"User","site_admin":false},"created_at":"2015-08-04T16:10:25Z","updated_at":"2015-08-04T16:10:25Z","body":"I added naming scheme to the list. Can be done by somebody without much code knowledge as its a simple refactoring (use an IDE for that!)\r\nWhat I mean is use camelCase/CamelCase for all names. Remove the underscore-versions and the (very ugly) lowercase versions like tmposroopsOnMission or even worse ones..."}}