{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/mschae/cors_plug/pulls/6","id":37258159,"html_url":"https://github.com/mschae/cors_plug/pull/6","diff_url":"https://github.com/mschae/cors_plug/pull/6.diff","patch_url":"https://github.com/mschae/cors_plug/pull/6.patch","issue_url":"https://api.github.com/repos/mschae/cors_plug/issues/6","number":6,"state":"closed","locked":false,"title":"Updating README to add note about it's use in Phoenix.","user":{"login":"leighhalliday","id":603921,"avatar_url":"https://avatars.githubusercontent.com/u/603921?v=3","gravatar_id":"","url":"https://api.github.com/users/leighhalliday","html_url":"https://github.com/leighhalliday","followers_url":"https://api.github.com/users/leighhalliday/followers","following_url":"https://api.github.com/users/leighhalliday/following{/other_user}","gists_url":"https://api.github.com/users/leighhalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/leighhalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leighhalliday/subscriptions","organizations_url":"https://api.github.com/users/leighhalliday/orgs","repos_url":"https://api.github.com/users/leighhalliday/repos","events_url":"https://api.github.com/users/leighhalliday/events{/privacy}","received_events_url":"https://api.github.com/users/leighhalliday/received_events","type":"User","site_admin":false},"body":"I ran into some difficulty using this plug because it wasn't being invoked, but I was instead receiving 404s. After chatting with Chris McCord he let me know that pipelines are only invoked for matched routes. By adding options routes, it would correctly call the pipeline and therefore the CORSPlug plug.\r\n\r\nI just wanted to add that to the README as it took me a little while to figure out!","created_at":"2015-06-09T14:19:36Z","updated_at":"2015-07-09T21:05:53Z","closed_at":"2015-07-09T21:05:53Z","merged_at":"2015-07-09T21:05:53Z","merge_commit_sha":"395f106c9306cf4981d2555c28cc9646135b0b55","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mschae/cors_plug/pulls/6/commits","review_comments_url":"https://api.github.com/repos/mschae/cors_plug/pulls/6/comments","review_comment_url":"https://api.github.com/repos/mschae/cors_plug/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mschae/cors_plug/issues/6/comments","statuses_url":"https://api.github.com/repos/mschae/cors_plug/statuses/16444eb3dc6ec6ff39fa70002ea43255796d2fb7","head":{"label":"leighhalliday:feature/readme-update","ref":"feature/readme-update","sha":"16444eb3dc6ec6ff39fa70002ea43255796d2fb7","user":{"login":"leighhalliday","id":603921,"avatar_url":"https://avatars.githubusercontent.com/u/603921?v=3","gravatar_id":"","url":"https://api.github.com/users/leighhalliday","html_url":"https://github.com/leighhalliday","followers_url":"https://api.github.com/users/leighhalliday/followers","following_url":"https://api.github.com/users/leighhalliday/following{/other_user}","gists_url":"https://api.github.com/users/leighhalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/leighhalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leighhalliday/subscriptions","organizations_url":"https://api.github.com/users/leighhalliday/orgs","repos_url":"https://api.github.com/users/leighhalliday/repos","events_url":"https://api.github.com/users/leighhalliday/events{/privacy}","received_events_url":"https://api.github.com/users/leighhalliday/received_events","type":"User","site_admin":false},"repo":{"id":37135937,"name":"cors_plug","full_name":"leighhalliday/cors_plug","owner":{"login":"leighhalliday","id":603921,"avatar_url":"https://avatars.githubusercontent.com/u/603921?v=3","gravatar_id":"","url":"https://api.github.com/users/leighhalliday","html_url":"https://github.com/leighhalliday","followers_url":"https://api.github.com/users/leighhalliday/followers","following_url":"https://api.github.com/users/leighhalliday/following{/other_user}","gists_url":"https://api.github.com/users/leighhalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/leighhalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leighhalliday/subscriptions","organizations_url":"https://api.github.com/users/leighhalliday/orgs","repos_url":"https://api.github.com/users/leighhalliday/repos","events_url":"https://api.github.com/users/leighhalliday/events{/privacy}","received_events_url":"https://api.github.com/users/leighhalliday/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leighhalliday/cors_plug","description":"cors-plug","fork":true,"url":"https://api.github.com/repos/leighhalliday/cors_plug","forks_url":"https://api.github.com/repos/leighhalliday/cors_plug/forks","keys_url":"https://api.github.com/repos/leighhalliday/cors_plug/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leighhalliday/cors_plug/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leighhalliday/cors_plug/teams","hooks_url":"https://api.github.com/repos/leighhalliday/cors_plug/hooks","issue_events_url":"https://api.github.com/repos/leighhalliday/cors_plug/issues/events{/number}","events_url":"https://api.github.com/repos/leighhalliday/cors_plug/events","assignees_url":"https://api.github.com/repos/leighhalliday/cors_plug/assignees{/user}","branches_url":"https://api.github.com/repos/leighhalliday/cors_plug/branches{/branch}","tags_url":"https://api.github.com/repos/leighhalliday/cors_plug/tags","blobs_url":"https://api.github.com/repos/leighhalliday/cors_plug/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leighhalliday/cors_plug/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leighhalliday/cors_plug/git/refs{/sha}","trees_url":"https://api.github.com/repos/leighhalliday/cors_plug/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leighhalliday/cors_plug/statuses/{sha}","languages_url":"https://api.github.com/repos/leighhalliday/cors_plug/languages","stargazers_url":"https://api.github.com/repos/leighhalliday/cors_plug/stargazers","contributors_url":"https://api.github.com/repos/leighhalliday/cors_plug/contributors","subscribers_url":"https://api.github.com/repos/leighhalliday/cors_plug/subscribers","subscription_url":"https://api.github.com/repos/leighhalliday/cors_plug/subscription","commits_url":"https://api.github.com/repos/leighhalliday/cors_plug/commits{/sha}","git_commits_url":"https://api.github.com/repos/leighhalliday/cors_plug/git/commits{/sha}","comments_url":"https://api.github.com/repos/leighhalliday/cors_plug/comments{/number}","issue_comment_url":"https://api.github.com/repos/leighhalliday/cors_plug/issues/comments{/number}","contents_url":"https://api.github.com/repos/leighhalliday/cors_plug/contents/{+path}","compare_url":"https://api.github.com/repos/leighhalliday/cors_plug/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leighhalliday/cors_plug/merges","archive_url":"https://api.github.com/repos/leighhalliday/cors_plug/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leighhalliday/cors_plug/downloads","issues_url":"https://api.github.com/repos/leighhalliday/cors_plug/issues{/number}","pulls_url":"https://api.github.com/repos/leighhalliday/cors_plug/pulls{/number}","milestones_url":"https://api.github.com/repos/leighhalliday/cors_plug/milestones{/number}","notifications_url":"https://api.github.com/repos/leighhalliday/cors_plug/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leighhalliday/cors_plug/labels{/name}","releases_url":"https://api.github.com/repos/leighhalliday/cors_plug/releases{/id}","created_at":"2015-06-09T14:09:39Z","updated_at":"2015-06-09T14:09:39Z","pushed_at":"2015-07-09T21:03:16Z","git_url":"git://github.com/leighhalliday/cors_plug.git","ssh_url":"git@github.com:leighhalliday/cors_plug.git","clone_url":"https://github.com/leighhalliday/cors_plug.git","svn_url":"https://github.com/leighhalliday/cors_plug","homepage":null,"size":90,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mschae:master","ref":"master","sha":"5acb31d9dea03c2b6544680d5b013084ea5c8d5e","user":{"login":"mschae","id":473241,"avatar_url":"https://avatars.githubusercontent.com/u/473241?v=3","gravatar_id":"","url":"https://api.github.com/users/mschae","html_url":"https://github.com/mschae","followers_url":"https://api.github.com/users/mschae/followers","following_url":"https://api.github.com/users/mschae/following{/other_user}","gists_url":"https://api.github.com/users/mschae/gists{/gist_id}","starred_url":"https://api.github.com/users/mschae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mschae/subscriptions","organizations_url":"https://api.github.com/users/mschae/orgs","repos_url":"https://api.github.com/users/mschae/repos","events_url":"https://api.github.com/users/mschae/events{/privacy}","received_events_url":"https://api.github.com/users/mschae/received_events","type":"User","site_admin":false},"repo":{"id":24842121,"name":"cors_plug","full_name":"mschae/cors_plug","owner":{"login":"mschae","id":473241,"avatar_url":"https://avatars.githubusercontent.com/u/473241?v=3","gravatar_id":"","url":"https://api.github.com/users/mschae","html_url":"https://github.com/mschae","followers_url":"https://api.github.com/users/mschae/followers","following_url":"https://api.github.com/users/mschae/following{/other_user}","gists_url":"https://api.github.com/users/mschae/gists{/gist_id}","starred_url":"https://api.github.com/users/mschae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mschae/subscriptions","organizations_url":"https://api.github.com/users/mschae/orgs","repos_url":"https://api.github.com/users/mschae/repos","events_url":"https://api.github.com/users/mschae/events{/privacy}","received_events_url":"https://api.github.com/users/mschae/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mschae/cors_plug","description":"cors-plug","fork":false,"url":"https://api.github.com/repos/mschae/cors_plug","forks_url":"https://api.github.com/repos/mschae/cors_plug/forks","keys_url":"https://api.github.com/repos/mschae/cors_plug/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mschae/cors_plug/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mschae/cors_plug/teams","hooks_url":"https://api.github.com/repos/mschae/cors_plug/hooks","issue_events_url":"https://api.github.com/repos/mschae/cors_plug/issues/events{/number}","events_url":"https://api.github.com/repos/mschae/cors_plug/events","assignees_url":"https://api.github.com/repos/mschae/cors_plug/assignees{/user}","branches_url":"https://api.github.com/repos/mschae/cors_plug/branches{/branch}","tags_url":"https://api.github.com/repos/mschae/cors_plug/tags","blobs_url":"https://api.github.com/repos/mschae/cors_plug/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mschae/cors_plug/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mschae/cors_plug/git/refs{/sha}","trees_url":"https://api.github.com/repos/mschae/cors_plug/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mschae/cors_plug/statuses/{sha}","languages_url":"https://api.github.com/repos/mschae/cors_plug/languages","stargazers_url":"https://api.github.com/repos/mschae/cors_plug/stargazers","contributors_url":"https://api.github.com/repos/mschae/cors_plug/contributors","subscribers_url":"https://api.github.com/repos/mschae/cors_plug/subscribers","subscription_url":"https://api.github.com/repos/mschae/cors_plug/subscription","commits_url":"https://api.github.com/repos/mschae/cors_plug/commits{/sha}","git_commits_url":"https://api.github.com/repos/mschae/cors_plug/git/commits{/sha}","comments_url":"https://api.github.com/repos/mschae/cors_plug/comments{/number}","issue_comment_url":"https://api.github.com/repos/mschae/cors_plug/issues/comments{/number}","contents_url":"https://api.github.com/repos/mschae/cors_plug/contents/{+path}","compare_url":"https://api.github.com/repos/mschae/cors_plug/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mschae/cors_plug/merges","archive_url":"https://api.github.com/repos/mschae/cors_plug/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mschae/cors_plug/downloads","issues_url":"https://api.github.com/repos/mschae/cors_plug/issues{/number}","pulls_url":"https://api.github.com/repos/mschae/cors_plug/pulls{/number}","milestones_url":"https://api.github.com/repos/mschae/cors_plug/milestones{/number}","notifications_url":"https://api.github.com/repos/mschae/cors_plug/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mschae/cors_plug/labels{/name}","releases_url":"https://api.github.com/repos/mschae/cors_plug/releases{/id}","created_at":"2014-10-06T10:45:00Z","updated_at":"2015-06-23T11:44:41Z","pushed_at":"2015-07-09T21:05:53Z","git_url":"git://github.com/mschae/cors_plug.git","ssh_url":"git@github.com:mschae/cors_plug.git","clone_url":"https://github.com/mschae/cors_plug.git","svn_url":"https://github.com/mschae/cors_plug","homepage":null,"size":214,"stargazers_count":10,"watchers_count":10,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mschae/cors_plug/pulls/6"},"html":{"href":"https://github.com/mschae/cors_plug/pull/6"},"issue":{"href":"https://api.github.com/repos/mschae/cors_plug/issues/6"},"comments":{"href":"https://api.github.com/repos/mschae/cors_plug/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/mschae/cors_plug/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/mschae/cors_plug/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mschae/cors_plug/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/mschae/cors_plug/statuses/16444eb3dc6ec6ff39fa70002ea43255796d2fb7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mschae","id":473241,"avatar_url":"https://avatars.githubusercontent.com/u/473241?v=3","gravatar_id":"","url":"https://api.github.com/users/mschae","html_url":"https://github.com/mschae","followers_url":"https://api.github.com/users/mschae/followers","following_url":"https://api.github.com/users/mschae/following{/other_user}","gists_url":"https://api.github.com/users/mschae/gists{/gist_id}","starred_url":"https://api.github.com/users/mschae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mschae/subscriptions","organizations_url":"https://api.github.com/users/mschae/orgs","repos_url":"https://api.github.com/users/mschae/repos","events_url":"https://api.github.com/users/mschae/events{/privacy}","received_events_url":"https://api.github.com/users/mschae/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":2,"additions":11,"deletions":0,"changed_files":1}}